date:20101209


[ 
https://issues.apache.org/jira/browse/OFBIZ-3789?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12969657#action_12969657
 ] 

Jacques Le Roux commented on OFBIZ-3789:


Thanks Atul,

Your patch works well and also fixed OFBIZ-4032

> No results when searching with keywords in catalog
> --
>
> Key: OFBIZ-3789
> URL: https://issues.apache.org/jira/browse/OFBIZ-3789
> Project: OFBiz
>  Issue Type: Bug
>  Components: product
>Affects Versions: SVN trunk
>Reporter: Erwan de FERRIERES
>Assignee: Adam Heath
> Fix For: SVN trunk
>
> Attachments: UseGroupByForKeywordSortOnly.patch
>
>
> Steps to reproduce :
> go to : https://localhost:8443/catalog/control/keywordsearch
> then in the Keywords textbox, type GZ, then hit enter key.
> No results are shown.
> Log error in the console :
> 2010-05-28 16:03:07,780 (http-0.0.0.0-8443-1) [  
> ProductSearch.java:271:INFO ] Finished initial setup of keywords, 
> doingBothAndOr=false, andKeywordFixedSet={%gz%}
>  keywordFixedOrSetAndList={}
> 2010-05-28 16:03:07,849 (http-0.0.0.0-8443-1) [  
> ProductSearch.java:654:ERROR] 
>  exception report 
> --
> Error in product search
> Exception: org.ofbiz.entity.GenericDataSourceException
> Message: SQL Exception while executing the following:SELECT DISTINCT 
> PK1.RELEVANCY_WEIGHT, PROD.PRODUCT_ID FROM (OFBIZ.PRODUCT PROD LEFT OUTER 
> JOIN OFBIZ.PRODUCT_CALCULATED_INFO PRODCI ON PROD.PRODUCT_ID = 
> PRODCI.PRODUCT_ID) INNER JOIN OFBIZ.PRODUCT_KEYWORD PK1 ON PROD.PRODUCT_ID = 
> PK1.PRODUCT_ID WHERE (PK1.KEYWORD LIKE ?) ORDER BY TOTAL_RELEVANCY DESC 
> (Column 'TOTAL_RELEVANCY' is either not in any table in the FROM list or 
> appears within a join specification and is outside the scope of the join 
> specification or appears in a HAVING clause and is not in the GROUP BY list. 
> If this is a CREATE or ALTER TABLE  statement then 'TOTAL_RELEVANCY' is not a 
> column in the target table.)
>  cause 
> -
> Exception: java.sql.SQLSyntaxErrorException
> Message: Column 'TOTAL_RELEVANCY' is either not in any table in the FROM list 
> or appears within a join specification and is outside the scope of the join 
> specification or appears in a HAVING clause and is not in the GROUP BY list. 
> If this is a CREATE or ALTER TABLE  statement then 'TOTAL_RELEVANCY' is not a 
> column in the target table.
>  cause 
> -
> Exception: org.apache.derby.impl.jdbc.EmbedSQLException
> Message: Column 'TOTAL_RELEVANCY' is either not in any table in the FROM list 
> or appears within a join specification and is outside the scope of the join 
> specification or appears in a HAVING clause and is not in the GROUP BY list. 
> If this is a CREATE or ALTER TABLE  statement then 'TOTAL_RELEVANCY' is not a 
> column in the target table.
>  cause 
> -
> Exception: org.apache.derby.iapi.error.StandardException
> Message: Column 'TOTAL_RELEVANCY' is either not in any table in the FROM list 
> or appears within a join specification and is outside the scope of the join 
> specification or appears in a HAVING clause and is not in the GROUP BY list. 
> If this is a CREATE or ALTER TABLE  statement then 'TOTAL_RELEVANCY' is not a 
> column in the target table.
>  stack trace 
> ---
> ERROR 42X04: Column 'TOTAL_RELEVANCY' is either not in any table in the FROM 
> list or appears within a join specification and is outside the scope of the 
> join specification or appears in a HAVING clause and is not in the GROUP BY 
> list. If this is a CREATE or ALTER TABLE  statement then 'TOTAL_RELEVANCY' is 
> not a column in the target table.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Re: duplicate transaction ids for authorized.net

You could try turning off the "Split Pay Pref Per Shp Grp" option on the 
product store.

Regards
Scott

HotWax Media
http://www.hotwaxmedia.com

On 9/12/2010, at 11:05 AM, Adam Heath wrote:

> We recently had some payments get rejected by authorized.net.  The ofbiz 
> install in this situation allows for multiple ship groups.  The duplicate 
> detection code on the authorized.net side checks the credit card info, plus 
> payment amount, and if they match, rejects the request, saying it is a 
> duplicate.
> 
> The issue here, is the grandmother situation.  A grandmother could buy 5 
> copies of a book, or a sweater, or something, and send them to her 5 
> grandchildren.  This will cause 5 payment method requests, all identical, to 
> occur.
> 
> If separate AUTH/CAPTURE methods are used, the AUTH will succeed, a 
> transaction refnum will be returned, and the final CAPTURE will also succeed.
> 
> However, when the combined AUTH_CAPTURE is used, there is no intermediate 
> transaction refnum, so this duplicate error shows up.
> 
> Adding a x_duplicate_window=0 is the suggested fix(as returned by the 
> google), but that disables the security feature, so I don't know if it is 
> correct.
> 
> Is there a better way for this to be fixed?  Maybe ofbiz should aggregate all 
> payments requests that can be issued at the same time. Maybe it could have a 
> request falloff algorithm, that is per-credit card(or other classification), 
> to support not hitting the processor so quickly.  Or maybe something else.
> 
> I plan on committing x_duplicate_window=0 into the buildAuthTransaction 
> method of AIMPaymentServices in the next few days, unless others speak up 
> with alternative plans of action.



smime.p7s
Description: S/MIME cryptographic signature

[jira] Closed: (OFBIZ-4032) There are issues whit search in eCommerce


 [ 
https://issues.apache.org/jira/browse/OFBIZ-4032?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacques Le Roux closed OFBIZ-4032.
--

   Resolution: Fixed
Fix Version/s: SVN trunk
   Release Branch 10.04
 Assignee: Jacques Le Roux

Finally, Atul's patch at OFBIZ-3789 fixed this issue also.

Fixed in trunk at r1043861, R10.04 at r1043863.

> There are issues whit search in eCommerce
> -
>
> Key: OFBIZ-4032
> URL: https://issues.apache.org/jira/browse/OFBIZ-4032
> Project: OFBiz
>  Issue Type: Bug
>  Components: specialpurpose/ecommerce
>Affects Versions: Release Branch 10.04, jQuery, SVN trunk
>Reporter: Jacques Le Roux
>Assignee: Jacques Le Roux
> Fix For: Release Branch 10.04, SVN trunk
>
>
> Try gz-1000 or "gift card" and follow [this comment from 
> OFBIZ-3789|https://issues.apache.org/jira/browse/OFBIZ-3789?focusedCommentId=12910997&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#action_12910997]
>  (last one)
> I guess it's also an issue for R10.04 (I did not try) R9.04 seems OK

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[jira] Created: (OFBIZ-4050) Editing an Electronic Text (Data Ressource) in HTML mode does not work

Editing an Electronic Text (Data Ressource) in HTML mode does not work
--

 Key: OFBIZ-4050
 URL: https://issues.apache.org/jira/browse/OFBIZ-4050
 Project: OFBiz
  Issue Type: Bug
  Components: content
Affects Versions: Release Branch 10.04
Reporter: Jacques Le Roux


It works in R9.04 not in R10.04.
Try for instance  
https://demo-stable.ofbiz.apache.org/content/control/EditHtmlText?dataResourceId=BLG10009

I have not taken into account the trunk since we will soon merge the jQuery 
branch and it's fixed there

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[jira] Closed: (OFBIZ-4030) We need to replace all references to whizzywig.js


 [ 
https://issues.apache.org/jira/browse/OFBIZ-4030?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacques Le Roux closed OFBIZ-4030.
--

   Resolution: Fixed
Fix Version/s: jQuery

Thanks Sascha,

Your patch is commited at r1043874 . I have opened OFBIZ-4050 for R10.04


> We need to replace all references to whizzywig.js
> -
>
> Key: OFBIZ-4030
> URL: https://issues.apache.org/jira/browse/OFBIZ-4030
> Project: OFBiz
>  Issue Type: Sub-task
>Reporter: Jacques Le Roux
>Assignee: Jacques Le Roux
> Fix For: jQuery
>
> Attachments: OFBIZ-4030_WysiwygEditorReplaced.patch, 
> OFBIZ-4030_WysiwygEditorReplaced.patch
>
>


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[jira] Closed: (OFBIZ-366) Separate VAT from Sales Tax


 [ 
https://issues.apache.org/jira/browse/OFBIZ-366?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacques Le Roux closed OFBIZ-366.
-

Resolution: Fixed
  Assignee: David E. Jones

With recent David's effort we have now a basic support for VAT included prices 
in OFBiz. 

* So we finally have prices with VAT included in DB 
** a raw UI for now, to be enhanced
** a mechanims to handle accurate values downstream (price rules, promos, order 
items, adjustements, invoices, etc.)
* We still lack VAT/GST/etc. reports...

So I close this issue, was a long time but it's there now :)


> Separate VAT from Sales Tax
> ---
>
> Key: OFBIZ-366
> URL: https://issues.apache.org/jira/browse/OFBIZ-366
> Project: OFBiz
>  Issue Type: Improvement
>  Components: order
>Affects Versions: SVN trunk
>Reporter: Jacques Le Roux
>Assignee: David E. Jones
> Fix For: SVN trunk
>
>
> We need to separate VAT from Sales Tax.
> The main reason is that VAT taxe is a very important type of tax in EU (and I 
> guess on some other places) but not in US. An example of problems that arise 
> if we not distinguish them is shown in OFBIZ-362. There we see that VAT in EU 
> has specific mandatory constraints.
> This is a huge work I guess. We will see from futur if it's really needed...

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[jira] Created: (OFBIZ-4051) i18n for elrte editor

i18n for elrte editor
-

 Key: OFBIZ-4051
 URL: https://issues.apache.org/jira/browse/OFBIZ-4051
 Project: OFBiz
  Issue Type: Improvement
  Components: ALL COMPONENTS
Affects Versions: jQuery
Reporter: Erwan de FERRIERES
Priority: Minor
 Fix For: jQuery


elrte editor has its i18n files included in the archive

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[jira] Commented: (OFBIZ-3789) No results when searching with keywords in catalog

2010-12-09 Thread Atul Vani (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-3789?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12969682#action_12969682
 ] 

Atul Vani commented on OFBIZ-3789:
--

Thanks Jacques.

> No results when searching with keywords in catalog
> --
>
> Key: OFBIZ-3789
> URL: https://issues.apache.org/jira/browse/OFBIZ-3789
> Project: OFBiz
>  Issue Type: Bug
>  Components: product
>Affects Versions: SVN trunk
>Reporter: Erwan de FERRIERES
>Assignee: Adam Heath
> Fix For: SVN trunk
>
> Attachments: UseGroupByForKeywordSortOnly.patch
>
>
> Steps to reproduce :
> go to : https://localhost:8443/catalog/control/keywordsearch
> then in the Keywords textbox, type GZ, then hit enter key.
> No results are shown.
> Log error in the console :
> 2010-05-28 16:03:07,780 (http-0.0.0.0-8443-1) [  
> ProductSearch.java:271:INFO ] Finished initial setup of keywords, 
> doingBothAndOr=false, andKeywordFixedSet={%gz%}
>  keywordFixedOrSetAndList={}
> 2010-05-28 16:03:07,849 (http-0.0.0.0-8443-1) [  
> ProductSearch.java:654:ERROR] 
>  exception report 
> --
> Error in product search
> Exception: org.ofbiz.entity.GenericDataSourceException
> Message: SQL Exception while executing the following:SELECT DISTINCT 
> PK1.RELEVANCY_WEIGHT, PROD.PRODUCT_ID FROM (OFBIZ.PRODUCT PROD LEFT OUTER 
> JOIN OFBIZ.PRODUCT_CALCULATED_INFO PRODCI ON PROD.PRODUCT_ID = 
> PRODCI.PRODUCT_ID) INNER JOIN OFBIZ.PRODUCT_KEYWORD PK1 ON PROD.PRODUCT_ID = 
> PK1.PRODUCT_ID WHERE (PK1.KEYWORD LIKE ?) ORDER BY TOTAL_RELEVANCY DESC 
> (Column 'TOTAL_RELEVANCY' is either not in any table in the FROM list or 
> appears within a join specification and is outside the scope of the join 
> specification or appears in a HAVING clause and is not in the GROUP BY list. 
> If this is a CREATE or ALTER TABLE  statement then 'TOTAL_RELEVANCY' is not a 
> column in the target table.)
>  cause 
> -
> Exception: java.sql.SQLSyntaxErrorException
> Message: Column 'TOTAL_RELEVANCY' is either not in any table in the FROM list 
> or appears within a join specification and is outside the scope of the join 
> specification or appears in a HAVING clause and is not in the GROUP BY list. 
> If this is a CREATE or ALTER TABLE  statement then 'TOTAL_RELEVANCY' is not a 
> column in the target table.
>  cause 
> -
> Exception: org.apache.derby.impl.jdbc.EmbedSQLException
> Message: Column 'TOTAL_RELEVANCY' is either not in any table in the FROM list 
> or appears within a join specification and is outside the scope of the join 
> specification or appears in a HAVING clause and is not in the GROUP BY list. 
> If this is a CREATE or ALTER TABLE  statement then 'TOTAL_RELEVANCY' is not a 
> column in the target table.
>  cause 
> -
> Exception: org.apache.derby.iapi.error.StandardException
> Message: Column 'TOTAL_RELEVANCY' is either not in any table in the FROM list 
> or appears within a join specification and is outside the scope of the join 
> specification or appears in a HAVING clause and is not in the GROUP BY list. 
> If this is a CREATE or ALTER TABLE  statement then 'TOTAL_RELEVANCY' is not a 
> column in the target table.
>  stack trace 
> ---
> ERROR 42X04: Column 'TOTAL_RELEVANCY' is either not in any table in the FROM 
> list or appears within a join specification and is outside the scope of the 
> join specification or appears in a HAVING clause and is not in the GROUP BY 
> list. If this is a CREATE or ALTER TABLE  statement then 'TOTAL_RELEVANCY' is 
> not a column in the target table.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[jira] Commented: (OFBIZ-4051) i18n for elrte editor


[ 
https://issues.apache.org/jira/browse/OFBIZ-4051?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12969696#action_12969696
 ] 

Jacques Le Roux commented on OFBIZ-4051:


Hi Erwan,

Could you be more explicit? Thanks

> i18n for elrte editor
> -
>
> Key: OFBIZ-4051
> URL: https://issues.apache.org/jira/browse/OFBIZ-4051
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: ALL COMPONENTS
>Affects Versions: jQuery
>Reporter: Erwan de FERRIERES
>Priority: Minor
> Fix For: jQuery
>
>
> elrte editor has its i18n files included in the archive

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[jira] Updated: (OFBIZ-4051) i18n for elrte editor


 [ 
https://issues.apache.org/jira/browse/OFBIZ-4051?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacques Le Roux updated OFBIZ-4051:
---

Issue Type: Sub-task  (was: Improvement)
Parent: OFBIZ-3814

> i18n for elrte editor
> -
>
> Key: OFBIZ-4051
> URL: https://issues.apache.org/jira/browse/OFBIZ-4051
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: ALL COMPONENTS
>Affects Versions: jQuery
>Reporter: Erwan de FERRIERES
>Priority: Minor
> Fix For: jQuery
>
>
> elrte editor has its i18n files included in the archive

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[jira] Commented: (OFBIZ-4051) i18n for elrte editor


[ 
https://issues.apache.org/jira/browse/OFBIZ-4051?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12969697#action_12969697
 ] 

Jacques Le Roux commented on OFBIZ-4051:


Ha, I see. You mean that we should add our own. And it's done internally, right 
(at the top of elrte.full.js it's easy to see)?  If it the case, I think we 
should ask elRte team if it could not be externalized, like it's done with 
jQuery UI for instance. We could then supply our own and other teams as well...

> i18n for elrte editor
> -
>
> Key: OFBIZ-4051
> URL: https://issues.apache.org/jira/browse/OFBIZ-4051
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: ALL COMPONENTS
>Affects Versions: jQuery
>Reporter: Erwan de FERRIERES
>Priority: Minor
> Fix For: jQuery
>
>
> elrte editor has its i18n files included in the archive

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[jira] Commented: (OFBIZ-4051) i18n for elrte editor


[ 
https://issues.apache.org/jira/browse/OFBIZ-4051?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12969706#action_12969706
 ] 

Erwan de FERRIERES commented on OFBIZ-4051:
---

Hi Jacques,

elrte is already providing the translation files, in js/i18n. We just have to 
make it work !

This issue is more a reminder, as it will be a problem when end-users will be 
using it. I don't think this would take a lot of time to implement!

Cheers,

> i18n for elrte editor
> -
>
> Key: OFBIZ-4051
> URL: https://issues.apache.org/jira/browse/OFBIZ-4051
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: ALL COMPONENTS
>Affects Versions: jQuery
>Reporter: Erwan de FERRIERES
>Priority: Minor
> Fix For: jQuery
>
>
> elrte editor has its i18n files included in the archive

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[jira] Commented: (OFBIZ-4051) i18n for elrte editor


[ 
https://issues.apache.org/jira/browse/OFBIZ-4051?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12969720#action_12969720
 ] 

Jacques Le Roux commented on OFBIZ-4051:


Thanks Erwan,

I have added those files at r1043949. Please let me know if it's enough or if 
we need more work

> i18n for elrte editor
> -
>
> Key: OFBIZ-4051
> URL: https://issues.apache.org/jira/browse/OFBIZ-4051
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: ALL COMPONENTS
>Affects Versions: jQuery
>Reporter: Erwan de FERRIERES
>Priority: Minor
> Fix For: jQuery
>
>
> elrte editor has its i18n files included in the archive

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[jira] Commented: (OFBIZ-4051) i18n for elrte editor


[ 
https://issues.apache.org/jira/browse/OFBIZ-4051?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12969729#action_12969729
 ] 

Erwan de FERRIERES commented on OFBIZ-4051:
---

Thanks Jacques, but it seems there is more work than this to be done...

> i18n for elrte editor
> -
>
> Key: OFBIZ-4051
> URL: https://issues.apache.org/jira/browse/OFBIZ-4051
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: ALL COMPONENTS
>Affects Versions: jQuery
>Reporter: Erwan de FERRIERES
>Priority: Minor
> Fix For: jQuery
>
>
> elrte editor has its i18n files included in the archive

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[jira] Updated: (OFBIZ-4051) i18n for elrte editor

2010-12-09 Thread Sascha Rodekamp (JIRA)


 [ 
https://issues.apache.org/jira/browse/OFBIZ-4051?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Sascha Rodekamp updated OFBIZ-4051:
---

Attachment: elrte_i18n.patch
elrte_i18n.zip

Hi guys,
ok i added a language flag in the editor macro. It reads the language from the 
userLogin and if the last locale field isn't empty the language file will be 
loaded.

to add this feature:
1.) extract the zip and copy the files to : 
framework/images/webapp/images/jquery/plugins/elrteEditor/i18n
2.) apply the patch file

Have a good day
Cheers
Sascha 

> i18n for elrte editor
> -
>
> Key: OFBIZ-4051
> URL: https://issues.apache.org/jira/browse/OFBIZ-4051
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: ALL COMPONENTS
>Affects Versions: jQuery
>Reporter: Erwan de FERRIERES
>Priority: Minor
> Fix For: jQuery
>
> Attachments: elrte_i18n.patch, elrte_i18n.zip
>
>
> elrte editor has its i18n files included in the archive

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[jira] Commented: (OFBIZ-4051) i18n for elrte editor

2010-12-09 Thread Sascha Rodekamp (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-4051?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12969733#action_12969733
 ] 

Sascha Rodekamp commented on OFBIZ-4051:


Oh i missed that you just added the files ... when they in the right directory 
you simply have to apply the patch Jacques ;)

thanks a lot

> i18n for elrte editor
> -
>
> Key: OFBIZ-4051
> URL: https://issues.apache.org/jira/browse/OFBIZ-4051
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: ALL COMPONENTS
>Affects Versions: jQuery
>Reporter: Erwan de FERRIERES
>Priority: Minor
> Fix For: jQuery
>
> Attachments: elrte_i18n.patch, elrte_i18n.zip
>
>
> elrte editor has its i18n files included in the archive

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Re: duplicate transaction ids for authorized.net

2010-12-09 Thread Ean Schuessler


That would suppress the problem, but shouldn't splitting work without being 
flagged as a duplicate? 
- "Scott Gray" wrote: 
> You could try turning off the "Split Pay Pref Per Shp Grp" option on the 
> product store. 

-- 
Ean Schuessler, CTO 
e...@brainfood.com 
214-720-0700 x 315 
Brainfood, Inc. 
http://www.brainfood.com

[jira] Commented: (OFBIZ-4051) i18n for elrte editor


[ 
https://issues.apache.org/jira/browse/OFBIZ-4051?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12969748#action_12969748
 ] 

Erwan de FERRIERES commented on OFBIZ-4051:
---

I'll look at it tonight ! Thanks Sascha

> i18n for elrte editor
> -
>
> Key: OFBIZ-4051
> URL: https://issues.apache.org/jira/browse/OFBIZ-4051
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: ALL COMPONENTS
>Affects Versions: jQuery
>Reporter: Erwan de FERRIERES
>Assignee: Erwan de FERRIERES
>Priority: Minor
> Fix For: jQuery
>
> Attachments: elrte_i18n.patch, elrte_i18n.zip
>
>
> elrte editor has its i18n files included in the archive

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[jira] Updated: (OFBIZ-4051) i18n for elrte editor


 [ 
https://issues.apache.org/jira/browse/OFBIZ-4051?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Erwan de FERRIERES updated OFBIZ-4051:
--

Assignee: Erwan de FERRIERES

> i18n for elrte editor
> -
>
> Key: OFBIZ-4051
> URL: https://issues.apache.org/jira/browse/OFBIZ-4051
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: ALL COMPONENTS
>Affects Versions: jQuery
>Reporter: Erwan de FERRIERES
>Assignee: Erwan de FERRIERES
>Priority: Minor
> Fix For: jQuery
>
> Attachments: elrte_i18n.patch, elrte_i18n.zip
>
>
> elrte editor has its i18n files included in the archive

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[jira] Commented: (OFBIZ-4051) i18n for elrte editor

2010-12-09 Thread Sascha Rodekamp (JIRA)


[ 
https://issues.apache.org/jira/browse/OFBIZ-4051?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12969750#action_12969750
 ] 

Sascha Rodekamp commented on OFBIZ-4051:


Cool Erwan, Thanks

> i18n for elrte editor
> -
>
> Key: OFBIZ-4051
> URL: https://issues.apache.org/jira/browse/OFBIZ-4051
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: ALL COMPONENTS
>Affects Versions: jQuery
>Reporter: Erwan de FERRIERES
>Assignee: Erwan de FERRIERES
>Priority: Minor
> Fix For: jQuery
>
> Attachments: elrte_i18n.patch, elrte_i18n.zip
>
>
> elrte editor has its i18n files included in the archive

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[jira] Commented: (OFBIZ-4051) i18n for elrte editor


[ 
https://issues.apache.org/jira/browse/OFBIZ-4051?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12969762#action_12969762
 ] 

Jacques Le Roux commented on OFBIZ-4051:


Sascha, Erwan,

I had a quick look. As, like jQuery UI, elrte editor uses also the 
language.country couple, please check that we don't nee to use something like 
the snippet I have introduced for the calendar 




 





>From elrte.zh_TW. I suppose that the *replace('_', '-')* trick should not be 
>needed

Thanks

> i18n for elrte editor
> -
>
> Key: OFBIZ-4051
> URL: https://issues.apache.org/jira/browse/OFBIZ-4051
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: ALL COMPONENTS
>Affects Versions: jQuery
>Reporter: Erwan de FERRIERES
>Assignee: Erwan de FERRIERES
>Priority: Minor
> Fix For: jQuery
>
> Attachments: elrte_i18n.patch, elrte_i18n.zip
>
>
> elrte editor has its i18n files included in the archive

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Re: duplicate transaction ids for authorized.net


On 12/09/2010 08:32 AM, Ean Schuessler wrote:


That would suppress the problem, but shouldn't splitting work without being 
flagged as a duplicate?
- "Scott Gray" wrote:

You could try turning off the "Split Pay Pref Per Shp Grp" option on the 
product store.


It also might be illegal.  You shouldn't capture the payment until the 
ship group is shipped, and it's entirely possible that a 
multi-shipgroup order would have 2 shipments packed by separate users, 
within the time window that this security feature attempts to implement.

Re: svn commit: r1043999 - /ofbiz/trunk/specialpurpose/ebaystore/src/org/ofbiz/ebaystore/EbayStoreAutoPreferences.java

2010-12-09 Thread Jacopo Cappellato


On Dec 9, 2010, at 4:14 PM, doo...@apache.org wrote:

> Author: doogie
> Date: Thu Dec  9 15:14:47 2010
> New Revision: 1043999
> 
> URL: http://svn.apache.org/viewvc?rev=1043999&view=rev
> Log:
> Yet another bad bug.  The name/value pair was never actually turned into
> a map.  findByAnd(entityName, field, value, list) was never a valid
> call.  However, this code still compiled, as it ended up using the
> vararg variant of findByAnd.  If this code had ever been run, then it
> would have blown up.
> 
> broken since: 984366, initial commit
> date: Wed Aug 11 10:39:10 2010 +
> 
> Modified:
>
> ofbiz/trunk/specialpurpose/ebaystore/src/org/ofbiz/ebaystore/EbayStoreAutoPreferences.java
> 
> Modified: 
> ofbiz/trunk/specialpurpose/ebaystore/src/org/ofbiz/ebaystore/EbayStoreAutoPreferences.java
> URL: 
> http://svn.apache.org/viewvc/ofbiz/trunk/specialpurpose/ebaystore/src/org/ofbiz/ebaystore/EbayStoreAutoPreferences.java?rev=1043999&r1=1043998&r2=1043999&view=diff
> ==
> --- 
> ofbiz/trunk/specialpurpose/ebaystore/src/org/ofbiz/ebaystore/EbayStoreAutoPreferences.java
>  (original)
> +++ 
> ofbiz/trunk/specialpurpose/ebaystore/src/org/ofbiz/ebaystore/EbayStoreAutoPreferences.java
>  Thu Dec  9 15:14:47 2010
> @@ -1269,7 +1269,8 @@ public class EbayStoreAutoPreferences {
> } else if (priceType.equals("RETAIL_PRICE")) {
> //ignore
> } else if (priceType.equals("SELLER_COST")) {
> -List supplierProduct = 
> delegator.findByAnd("SupplierProduct", "productId", SKUItem, 
> UtilMisc.toList("availableFromDate DESC"));
> +// FIXME
> +List supplierProduct = 
> delegator.findByAnd("SupplierProduct", UtilMisc.toMap("productId", SKUItem), 
> UtilMisc.toList("availableFromDate DESC"));

And "-availableFromDate" should be used instead of "availableFromDate DESC".

Jacopo

> String lastPrice = 
> supplierProduct.get(0).getString("lastPrice");
> doBasePrice = Double.parseDouble(lastPrice);
> } else if (priceType.equals("SECOND_CHANCE_PRICE")) {
> 
>

Re: findByAnd(Map) ws findList(EntityCondition)

2010-12-09 Thread Jacopo Cappellato

Cool!

Jacopo

On Dec 8, 2010, at 10:00 PM, Scott Gray wrote:

> On 8/12/2010, at 4:29 AM, Adam Heath wrote:
> 
>> I've deprecated findByAnd locally, replacing calls with a variant that
>> takes a boolean, which specifies whether to use the cache.
>> 
>> Initially, my replacement just added a new findByAnd.  However, I'm
>> now starting to lean towards replacing with findList instead.
>> However, in my opinion, I think that will make programming ofbiz more
>> difficult.
>> 
>> I'd like to add a findList variant, that takes a Map instead of an
>> EntityCondition.  Without this new variant, there would be ton of
>> variants that would only need to import EntityCondition, just to
>> create a condition.
>> 
>> There are also performance considerations to consider.
>> 
>> EntityCondition.makeCondition(Map) directly takes the map, doing no
>> processing.  However, EntityCondition.makeCondition(Object...)
>> eventually calls EntityUtil.makeFields, which does a little more than
>> UtilMisc.  In addition to the iteration over the array, it also does a
>> check on the value for Comparable/Serializable.  This latter check
>> seems a bit superfluous, as eventually the base condition classes
>> check the values against the model.
>> 
>> So, from a purist stand point, even tho findByAnd could be replaced by
>> findList, I think it is too useful; it saves enough code in
>> application layers, imho.
>> 
> 
> This reminded me of the query objects with method chaining that I suggested a 
> while back so I threw them together this morning.
> 
> Here are some examples:
> thisContent = delegator.findByPrimaryKeyCache("Content", 
> UtilMisc.toMap("contentId", assocContentId));
> // becomes
> thisContent = EntityOne.query(delegator).from("Content").where("contentId", 
> assocContentId).cache().find();
> 
> List productNodesList = delegator.findByAndCache("ProductAssoc", 
> UtilMisc.toMap("productIdTo", productId, "productAssocTypeId", bomType));
> productNodesList = EntityUtil.filterByDate(productNodesList, inDate);
> // becomes
> List productNodesList = 
> EntityList.query(delegator).from("ProductAssoc").where("productIdTo", 
> productId, "productAssocTypeId", bomType).cache().filterByDate().list();
> 
> List inventoryItems = delegator.findByAnd("InventoryItem", ecl, 
> null, null, null, false);
> // becomes
> List inventoryItems = 
> EntityList.query(delegator).from("InventoryItem").where(ecl).list();
> 
> // all this (long winded example)
> EntityFindOptions efo = new EntityFindOptions();
> efo.setDistinct(true);
> efo.setResultSetType(EntityFindOptions.TYPE_SCROLL_INSENSITIVE);
> if (maxResults != null) {
>efo.setMaxRows(maxResults);
> }
> eli = delegator.findListIteratorByCondition(dynamicViewEntity, 
> whereCondition, null, fieldsToSelect, orderByList, efo);
> // becomes
> eli = 
> EntityList.query(delegator).from(dynamicViewEntity).where(whereCondition).select(fieldsToSelect).orderBy(orderByList).distinct().cursorScrollInsensitive().maxRows(maxResults).iterator();
> 
> They aren't necessarily shorter, but they are easier to write, easier to read 
> and would be easier to remember (for things like groovy).
> 
> Regards
> Scott
> 
> HotWax Media
> http://www.hotwaxmedia.com
>

Re: svn commit: r1043999 - /ofbiz/trunk/specialpurpose/ebaystore/src/org/ofbiz/ebaystore/EbayStoreAutoPreferences.java


On 12/09/2010 10:26 AM, Jacopo Cappellato wrote:


On Dec 9, 2010, at 4:14 PM, doo...@apache.org wrote:


Author: doogie
Date: Thu Dec  9 15:14:47 2010
New Revision: 1043999

URL: http://svn.apache.org/viewvc?rev=1043999&view=rev
Log:
Yet another bad bug.  The name/value pair was never actually turned into
a map.  findByAnd(entityName, field, value, list) was never a valid
call.  However, this code still compiled, as it ended up using the
vararg variant of findByAnd.  If this code had ever been run, then it
would have blown up.

broken since: 984366, initial commit
date: Wed Aug 11 10:39:10 2010 +

Modified:

ofbiz/trunk/specialpurpose/ebaystore/src/org/ofbiz/ebaystore/EbayStoreAutoPreferences.java

Modified: 
ofbiz/trunk/specialpurpose/ebaystore/src/org/ofbiz/ebaystore/EbayStoreAutoPreferences.java
URL: 
http://svn.apache.org/viewvc/ofbiz/trunk/specialpurpose/ebaystore/src/org/ofbiz/ebaystore/EbayStoreAutoPreferences.java?rev=1043999&r1=1043998&r2=1043999&view=diff
==
--- 
ofbiz/trunk/specialpurpose/ebaystore/src/org/ofbiz/ebaystore/EbayStoreAutoPreferences.java
 (original)
+++ 
ofbiz/trunk/specialpurpose/ebaystore/src/org/ofbiz/ebaystore/EbayStoreAutoPreferences.java
 Thu Dec  9 15:14:47 2010
@@ -1269,7 +1269,8 @@ public class EbayStoreAutoPreferences {
 } else if (priceType.equals("RETAIL_PRICE")) {
 //ignore
 } else if (priceType.equals("SELLER_COST")) {
-List  supplierProduct = 
delegator.findByAnd("SupplierProduct", "productId", SKUItem, 
UtilMisc.toList("availableFromDate DESC"));
+// FIXME
+List  supplierProduct = 
delegator.findByAnd("SupplierProduct", UtilMisc.toMap("productId", SKUItem), 
UtilMisc.toList("availableFromDate DESC"));


And "-availableFromDate" should be used instead of "availableFromDate DESC".


Why?  Both work.

My last 4 commits need to be discusssed.  3 of them *NEVER* worked, 
even with the initial commit to ofbiz.  There is no way at all that 
the code was run by the original author.  So why was the code there in 
the first place?


Then, the one change by Scott was a findByAnd->findList, whether the 
parameters were changed, but the method name was not.  I am not 
annoyed that that line was changed badly.  Those things happen.  What 
is annoying is that the problem code hadn't been run by anyone in the 
last 2 years.

Re: findByAnd(Map) ws findList(EntityCondition)


On 12/09/2010 12:03 AM, Scott Gray wrote:

On 9/12/2010, at 11:50 AM, Adam Heath wrote:


On 12/08/2010 03:00 PM, Scott Gray wrote:

On 8/12/2010, at 4:29 AM, Adam Heath wrote:


I've deprecated findByAnd locally, replacing calls with a variant that
takes a boolean, which specifies whether to use the cache.

Initially, my replacement just added a new findByAnd.  However, I'm
now starting to lean towards replacing with findList instead.
However, in my opinion, I think that will make programming ofbiz more
difficult.

I'd like to add a findList variant, that takes a Map instead of an
EntityCondition.  Without this new variant, there would be ton of
variants that would only need to import EntityCondition, just to
create a condition.

There are also performance considerations to consider.

EntityCondition.makeCondition(Map) directly takes the map, doing no
processing.  However, EntityCondition.makeCondition(Object...)
eventually calls EntityUtil.makeFields, which does a little more than
UtilMisc.  In addition to the iteration over the array, it also does a
check on the value for Comparable/Serializable.  This latter check
seems a bit superfluous, as eventually the base condition classes
check the values against the model.

So, from a purist stand point, even tho findByAnd could be replaced by
findList, I think it is too useful; it saves enough code in
application layers, imho.



This reminded me of the query objects with method chaining that I suggested a 
while back so I threw them together this morning.

Here are some examples:
thisContent = delegator.findByPrimaryKeyCache("Content", 
UtilMisc.toMap("contentId", assocContentId));
// becomes
thisContent = EntityOne.query(delegator).from("Content").where("contentId", 
assocContentId).cache().find();


api:
EntityOne(delegator).from()

in foo.groovy:
use(DelegatorCategory) {

}

class DelegatorCategory {
  public static EntityOneBuilder EntityOne(Delegator delegator) {
return new EntityOneBuilder(delegator);
  }
}
class EntityOneBuilder {
  public EntityOneBuilder from(String entityName) {
return this;
  }

  public GenericValue query() {
return delegator.findOne();
  }
}

This is almost like what you suggested, but it removes the query() method that 
starts thte builder, and changes the find() to query().

EntityList would be done the same one.

The way you have it, is that the start(EntityOne, EntityList) and the 
end(find(), list()), are 2 things that have to be remembered.  My version just 
has one thing(the start of the call).


This is all groovy DSL related though right?  I hadn't worried about groovy too 
much because I knew we had a fair bit of flexibility thanks to the language 
features.  The API I've written to date was solely intended for java 
development but seems succinct enough that not much would need to change for 
groovy.

Also EntityList's execute methods so far are:
list()
iterator()
first()
count()


All primary methods should be query(), imho.

interface GenericQueryBuilder {
  T query();
}

public class EntityOne implements GenericQueryBuilder {
  public GenericValue query() {}
}

public class EntityList implements 
GenericQueryBuilder>, Iterable {

  public List query() {}
  public Iterator iterator() {}
  ...
}

lead status


Hi,

When you update personal information of a lead, if this lead is assigned, in the status dropdown you see LEAD_ASSIGNED. I'd like to 
change this to show correct information. But on the other hand I'd not like to take the burden of handling impossible changes by 
mucking in in services and such. Is a such scheme already used somewhere?


To be clear the idea would be to have PARTY_STATUS (Enabled, Disabled) accessible but LEAD_STATUS (Assigned, Converted, Qualified) 
only shown. I began to write



   
   
   
   
   
   


   
   
   
   
   
   


before understanding the issue, any (creative ;o) ideas?

Thanks

Jacques

Re: jquey

At 1st glance it does not look like a quickly done task. There are 68 conflicts to handle. 70% are tree conflicts, hopefully easier 
to handle...


Jacques


From: "Jacques Le Roux" 

Hi Rohit,

As I already said, I hope to do it before the new year...
I want at least to fix this before 
https://issues.apache.org/jira/browse/OFBIZ-4030
Fortunately you may help since it seems the issue is in the trunk, see my 
comment

Also I will need to put a tag before the back merge to trunk. I wonder if we 
should not avoid to commit between these 2 events. In
order to have not changes trapped bewteen, not a big deal if I can do the back 
merge quickly. So I will try locally before...

Thanks

Jacques


Hi Jacques,

I guess everybody has agreed with the merger, so when can we can be expect
it to be done. I am sorry if i sound little haste, but we are very eagerly
waiting for it.

thanks,

Rohit


-
http://www.saanjhi.com saanjhi.com
--
View this message in context: 
http://ofbiz.135035.n4.nabble.com/jquey-tp3068464p3075960.html
Sent from the OFBiz - Dev mailing list archive at Nabble.com.

Docbooks help


I have not found the start of docbook generation.
I am trying to track down where
alink="#FF">

is generated.

Pointer would help. will probably find eventually. just trying to save 
some time.


=
BJ Freeman
Strategic Power Office with Supplier Automation  

Specialtymarket.com  
Systems Integrator-- Glad to Assist

Chat  Y! messenger: bjfr33man

Re: lead status


Fixed at r1044082

Jacques

From: "Jacques Le Roux" 

Hi,

When you update personal information of a lead, if this lead is assigned, in the status dropdown you see LEAD_ASSIGNED. I'd like 
to change this to show correct information. But on the other hand I'd not like to take the burden of handling impossible changes 
by mucking in in services and such. Is a such scheme already used somewhere?


To be clear the idea would be to have PARTY_STATUS (Enabled, Disabled) accessible but LEAD_STATUS (Assigned, Converted, Qualified) 
only shown. I began to write



   
   
   
   
   
   


   
   
   
   
   
   


before understanding the issue, any (creative ;o) ideas?

Thanks

Jacques

Re: duplicate transaction ids for authorized.net

On 10/12/2010, at 5:17 AM, Adam Heath wrote:

> On 12/09/2010 08:32 AM, Ean Schuessler wrote:
>> 
>> That would suppress the problem, but shouldn't splitting work without being 
>> flagged as a duplicate?
>> - "Scott Gray" wrote:
>>> You could try turning off the "Split Pay Pref Per Shp Grp" option on the 
>>> product store.
> 
> It also might be illegal.  You shouldn't capture the payment until the ship 
> group is shipped, and it's entirely possible that a multi-shipgroup order 
> would have 2 shipments packed by separate users, within the time window that 
> this security feature attempts to implement.

Nothing illegal about it, the only difference in functionality is that you end 
up with one auth for the larger amount and then a capture per shipment.  Split 
Pay Pref Per Shp Grp is a relatively new feature (few years old) and I believe 
was mostly intended for supporting differing payment methods per ship group.

And yes your problem could still arise and I wasn't suggesting this as a fix so 
much as a workaround.

Regards
Scott

smime.p7s
Description: S/MIME cryptographic signature

location patterns for files availible to web.


The Doc file moves the css from the theme to

which is under runtime.
my question is do we want to have tempfiles as part of the access from 
the web.
so say if a zip file was generated from the ecommerce store as a product 
the URL would be



as far as dockbook.css I think it should reference the actual theme 
location of the docbook.css



=
BJ Freeman
Strategic Power Office with Supplier Automation  

Specialtymarket.com  
Systems Integrator-- Glad to Assist

Chat  Y! messenger: bjfr33man

Re: findByAnd(Map) ws findList(EntityCondition)

On 10/12/2010, at 5:53 AM, Adam Heath wrote:

> On 12/09/2010 12:03 AM, Scott Gray wrote:
>> On 9/12/2010, at 11:50 AM, Adam Heath wrote:
>> 
>>> On 12/08/2010 03:00 PM, Scott Gray wrote:
 On 8/12/2010, at 4:29 AM, Adam Heath wrote:
 
> I've deprecated findByAnd locally, replacing calls with a variant that
> takes a boolean, which specifies whether to use the cache.
> 
> Initially, my replacement just added a new findByAnd.  However, I'm
> now starting to lean towards replacing with findList instead.
> However, in my opinion, I think that will make programming ofbiz more
> difficult.
> 
> I'd like to add a findList variant, that takes a Map instead of an
> EntityCondition.  Without this new variant, there would be ton of
> variants that would only need to import EntityCondition, just to
> create a condition.
> 
> There are also performance considerations to consider.
> 
> EntityCondition.makeCondition(Map) directly takes the map, doing no
> processing.  However, EntityCondition.makeCondition(Object...)
> eventually calls EntityUtil.makeFields, which does a little more than
> UtilMisc.  In addition to the iteration over the array, it also does a
> check on the value for Comparable/Serializable.  This latter check
> seems a bit superfluous, as eventually the base condition classes
> check the values against the model.
> 
> So, from a purist stand point, even tho findByAnd could be replaced by
> findList, I think it is too useful; it saves enough code in
> application layers, imho.
> 
 
 This reminded me of the query objects with method chaining that I 
 suggested a while back so I threw them together this morning.
 
 Here are some examples:
 thisContent = delegator.findByPrimaryKeyCache("Content", 
 UtilMisc.toMap("contentId", assocContentId));
 // becomes
 thisContent = 
 EntityOne.query(delegator).from("Content").where("contentId", 
 assocContentId).cache().find();
>>> 
>>> api:
>>> EntityOne(delegator).from()
>>> 
>>> in foo.groovy:
>>> use(DelegatorCategory) {
>>> 
>>> }
>>> 
>>> class DelegatorCategory {
>>>  public static EntityOneBuilder EntityOne(Delegator delegator) {
>>>return new EntityOneBuilder(delegator);
>>>  }
>>> }
>>> class EntityOneBuilder {
>>>  public EntityOneBuilder from(String entityName) {
>>>return this;
>>>  }
>>> 
>>>  public GenericValue query() {
>>>return delegator.findOne();
>>>  }
>>> }
>>> 
>>> This is almost like what you suggested, but it removes the query() method 
>>> that starts thte builder, and changes the find() to query().
>>> 
>>> EntityList would be done the same one.
>>> 
>>> The way you have it, is that the start(EntityOne, EntityList) and the 
>>> end(find(), list()), are 2 things that have to be remembered.  My version 
>>> just has one thing(the start of the call).
>> 
>> This is all groovy DSL related though right?  I hadn't worried about groovy 
>> too much because I knew we had a fair bit of flexibility thanks to the 
>> language features.  The API I've written to date was solely intended for 
>> java development but seems succinct enough that not much would need to 
>> change for groovy.
>> 
>> Also EntityList's execute methods so far are:
>> list()
>> iterator()
>> first()
>> count()
> 
> All primary methods should be query(), imho.
> 
> interface GenericQueryBuilder {
>  T query();
> }
> 
> public class EntityOne implements GenericQueryBuilder {
>  public GenericValue query() {}
> }
> 
> public class EntityList implements GenericQueryBuilder>, 
> Iterable {
>  public List query() {}
>  public Iterator iterator() {}
>  ...
> }

I'm not opposed to that, but I'll need another method name for specifying the 
delegator.  How about use(delegator)?

Regards
Scott



smime.p7s
Description: S/MIME cryptographic signature

Re: findByAnd(Map) ws findList(EntityCondition)


On 12/09/2010 01:48 PM, Scott Gray wrote:

On 10/12/2010, at 5:53 AM, Adam Heath wrote:


On 12/09/2010 12:03 AM, Scott Gray wrote:

On 9/12/2010, at 11:50 AM, Adam Heath wrote:


On 12/08/2010 03:00 PM, Scott Gray wrote:

On 8/12/2010, at 4:29 AM, Adam Heath wrote:


I've deprecated findByAnd locally, replacing calls with a variant that
takes a boolean, which specifies whether to use the cache.

Initially, my replacement just added a new findByAnd.  However, I'm
now starting to lean towards replacing with findList instead.
However, in my opinion, I think that will make programming ofbiz more
difficult.

I'd like to add a findList variant, that takes a Map instead of an
EntityCondition.  Without this new variant, there would be ton of
variants that would only need to import EntityCondition, just to
create a condition.

There are also performance considerations to consider.

EntityCondition.makeCondition(Map) directly takes the map, doing no
processing.  However, EntityCondition.makeCondition(Object...)
eventually calls EntityUtil.makeFields, which does a little more than
UtilMisc.  In addition to the iteration over the array, it also does a
check on the value for Comparable/Serializable.  This latter check
seems a bit superfluous, as eventually the base condition classes
check the values against the model.

So, from a purist stand point, even tho findByAnd could be replaced by
findList, I think it is too useful; it saves enough code in
application layers, imho.



This reminded me of the query objects with method chaining that I suggested a 
while back so I threw them together this morning.

Here are some examples:
thisContent = delegator.findByPrimaryKeyCache("Content", 
UtilMisc.toMap("contentId", assocContentId));
// becomes
thisContent = EntityOne.query(delegator).from("Content").where("contentId", 
assocContentId).cache().find();


api:
EntityOne(delegator).from()

in foo.groovy:
use(DelegatorCategory) {

}

class DelegatorCategory {
  public static EntityOneBuilder EntityOne(Delegator delegator) {
return new EntityOneBuilder(delegator);
  }
}
class EntityOneBuilder {
  public EntityOneBuilder from(String entityName) {
return this;
  }

  public GenericValue query() {
return delegator.findOne();
  }
}

This is almost like what you suggested, but it removes the query() method that 
starts thte builder, and changes the find() to query().

EntityList would be done the same one.

The way you have it, is that the start(EntityOne, EntityList) and the 
end(find(), list()), are 2 things that have to be remembered.  My version just 
has one thing(the start of the call).


This is all groovy DSL related though right?  I hadn't worried about groovy too 
much because I knew we had a fair bit of flexibility thanks to the language 
features.  The API I've written to date was solely intended for java 
development but seems succinct enough that not much would need to change for 
groovy.

Also EntityList's execute methods so far are:
list()
iterator()
first()
count()


All primary methods should be query(), imho.

interface GenericQueryBuilder  {
  T query();
}

public class EntityOne implements GenericQueryBuilder  {
  public GenericValue query() {}
}

public class EntityList implements GenericQueryBuilder>, 
Iterable  {
  public List  query() {}
  public Iterator  iterator() {}
  ...
}


I'm not opposed to that, but I'll need another method name for specifying the 
delegator.  How about use(delegator)?


public final class EntityBuilderUtil {
  public static EntityOne one(Delegator delegator) {
return new EntityOne(delegator);
  }

  public static EntityList list(Delegator delegator) {
return new EntityList(delegator);
  }
}

This also means that java api code only needs to import one class. 
Plus, if this class is used as a groovy category, then groovy code can 
do this:


one(delegator).cache(true).

As groovy will see one as a method call, taking a variable with type 
Delegator, and search all its categories to find a matching method. 
You'll get all things for free.

freemarker Static[UtilMisc].toMap() use

I just noticed that several(many) ftl files use UtilMisc.toMap, but 
others are using {}(freemarker syntax).  I assume we would like the 
latter to prevail.  Agreements?

Re: findByAnd(Map) ws findList(EntityCondition)

On 10/12/2010, at 8:54 AM, Adam Heath wrote:

> On 12/09/2010 01:48 PM, Scott Gray wrote:
>> On 10/12/2010, at 5:53 AM, Adam Heath wrote:
>> 
>>> On 12/09/2010 12:03 AM, Scott Gray wrote:
 On 9/12/2010, at 11:50 AM, Adam Heath wrote:
 
> On 12/08/2010 03:00 PM, Scott Gray wrote:
>> On 8/12/2010, at 4:29 AM, Adam Heath wrote:
>> 
>>> I've deprecated findByAnd locally, replacing calls with a variant that
>>> takes a boolean, which specifies whether to use the cache.
>>> 
>>> Initially, my replacement just added a new findByAnd.  However, I'm
>>> now starting to lean towards replacing with findList instead.
>>> However, in my opinion, I think that will make programming ofbiz more
>>> difficult.
>>> 
>>> I'd like to add a findList variant, that takes a Map instead of an
>>> EntityCondition.  Without this new variant, there would be ton of
>>> variants that would only need to import EntityCondition, just to
>>> create a condition.
>>> 
>>> There are also performance considerations to consider.
>>> 
>>> EntityCondition.makeCondition(Map) directly takes the map, doing no
>>> processing.  However, EntityCondition.makeCondition(Object...)
>>> eventually calls EntityUtil.makeFields, which does a little more than
>>> UtilMisc.  In addition to the iteration over the array, it also does a
>>> check on the value for Comparable/Serializable.  This latter check
>>> seems a bit superfluous, as eventually the base condition classes
>>> check the values against the model.
>>> 
>>> So, from a purist stand point, even tho findByAnd could be replaced by
>>> findList, I think it is too useful; it saves enough code in
>>> application layers, imho.
>>> 
>> 
>> This reminded me of the query objects with method chaining that I 
>> suggested a while back so I threw them together this morning.
>> 
>> Here are some examples:
>> thisContent = delegator.findByPrimaryKeyCache("Content", 
>> UtilMisc.toMap("contentId", assocContentId));
>> // becomes
>> thisContent = 
>> EntityOne.query(delegator).from("Content").where("contentId", 
>> assocContentId).cache().find();
> 
> api:
> EntityOne(delegator).from()
> 
> in foo.groovy:
> use(DelegatorCategory) {
> 
> }
> 
> class DelegatorCategory {
>  public static EntityOneBuilder EntityOne(Delegator delegator) {
>return new EntityOneBuilder(delegator);
>  }
> }
> class EntityOneBuilder {
>  public EntityOneBuilder from(String entityName) {
>return this;
>  }
> 
>  public GenericValue query() {
>return delegator.findOne();
>  }
> }
> 
> This is almost like what you suggested, but it removes the query() method 
> that starts thte builder, and changes the find() to query().
> 
> EntityList would be done the same one.
> 
> The way you have it, is that the start(EntityOne, EntityList) and the 
> end(find(), list()), are 2 things that have to be remembered.  My version 
> just has one thing(the start of the call).
 
 This is all groovy DSL related though right?  I hadn't worried about 
 groovy too much because I knew we had a fair bit of flexibility thanks to 
 the language features.  The API I've written to date was solely intended 
 for java development but seems succinct enough that not much would need to 
 change for groovy.
 
 Also EntityList's execute methods so far are:
 list()
 iterator()
 first()
 count()
>>> 
>>> All primary methods should be query(), imho.
>>> 
>>> interface GenericQueryBuilder  {
>>>  T query();
>>> }
>>> 
>>> public class EntityOne implements GenericQueryBuilder  {
>>>  public GenericValue query() {}
>>> }
>>> 
>>> public class EntityList implements GenericQueryBuilder>, 
>>> Iterable  {
>>>  public List  query() {}
>>>  public Iterator  iterator() {}
>>>  ...
>>> }
>> 
>> I'm not opposed to that, but I'll need another method name for specifying 
>> the delegator.  How about use(delegator)?
> 
> public final class EntityBuilderUtil {
>  public static EntityOne one(Delegator delegator) {
>return new EntityOne(delegator);
>  }
> 
>  public static EntityList list(Delegator delegator) {
>return new EntityList(delegator);
>  }
> }
> 
> This also means that java api code only needs to import one class. Plus, if 
> this class is used as a groovy category, then groovy code can do this:
> 
> one(delegator).cache(true).
> 
> As groovy will see one as a method call, taking a variable with type 
> Delegator, and search all its categories to find a matching method. You'll 
> get all things for free.

Works for me.

Thanks
Scott

smime.p7s
Description: S/MIME cryptographic signature

Re: freemarker Static[UtilMisc].toMap() use


On 12/09/2010 01:58 PM, Adam Heath wrote:

I just noticed that several(many) ftl files use UtilMisc.toMap, but
others are using {}(freemarker syntax). I assume we would like the
latter to prevail. Agreements?


Same goes for UtilMisc.toMap and UtilMisc.toList inside groovy; groovy 
has native support for map/list creation, and imho should be preferred.

[jira] Commented: (OFBIZ-4051) i18n for elrte editor


[ 
https://issues.apache.org/jira/browse/OFBIZ-4051?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12969951#action_12969951
 ] 

Erwan de FERRIERES commented on OFBIZ-4051:
---

Done at 1044132. Thanks Jacques and Sascha.

> i18n for elrte editor
> -
>
> Key: OFBIZ-4051
> URL: https://issues.apache.org/jira/browse/OFBIZ-4051
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: ALL COMPONENTS
>Affects Versions: jQuery
>Reporter: Erwan de FERRIERES
>Assignee: Erwan de FERRIERES
>Priority: Minor
> Fix For: jQuery
>
> Attachments: elrte_i18n.patch, elrte_i18n.zip
>
>
> elrte editor has its i18n files included in the archive

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[jira] Closed: (OFBIZ-4051) i18n for elrte editor


 [ 
https://issues.apache.org/jira/browse/OFBIZ-4051?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Erwan de FERRIERES closed OFBIZ-4051.
-

Resolution: Fixed

> i18n for elrte editor
> -
>
> Key: OFBIZ-4051
> URL: https://issues.apache.org/jira/browse/OFBIZ-4051
> Project: OFBiz
>  Issue Type: Sub-task
>  Components: ALL COMPONENTS
>Affects Versions: jQuery
>Reporter: Erwan de FERRIERES
>Assignee: Erwan de FERRIERES
>Priority: Minor
> Fix For: jQuery
>
> Attachments: elrte_i18n.patch, elrte_i18n.zip
>
>
> elrte editor has its i18n files included in the archive

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

demo server performance


there is a thread on the user ML about the demo being slow.
I would think that would be a high priority for all those that commit 
and make changes to ofbiz.

after all what good is all this stuff if it can't be used.
I brought down the demo trunk by accessing with seperate requests at one 
time, as I stated on the user ml.


lets focus on real problems.

Re: demo server performance

Everybody works on the areas of the system that are important to them, I 
suggest you do the same.

The demo server is under-resourced so of course you're going to be able to 
bring it down if you try to, my suggestion is that you don't try to.

Regards
Scott

HotWax Media
http://www.hotwaxmedia.com

On 10/12/2010, at 10:32 AM, BJ Freeman wrote:

> there is a thread on the user ML about the demo being slow.
> I would think that would be a high priority for all those that commit and 
> make changes to ofbiz.
> after all what good is all this stuff if it can't be used.
> I brought down the demo trunk by accessing with seperate requests at one 
> time, as I stated on the user ml.
> 
> lets focus on real problems.
> 
> 
> 

smime.p7s
Description: S/MIME cryptographic signature

Re: demo server performance

2010-12-09 Thread David E Jones

On Dec 9, 2010, at 1:32 PM, BJ Freeman wrote:

> there is a thread on the user ML about the demo being slow.
> I would think that would be a high priority for all those that commit and 
> make changes to ofbiz.
> after all what good is all this stuff if it can't be used.
> I brought down the demo trunk by accessing with seperate requests at one 
> time, as I stated on the user ml.
> 
> lets focus on real problems.

The real problem is: real problems according to who/what?

Don't make the mistake of thinking that problems on the demo server mean that 
real-world users with production instances are having the same problems. Also, 
consider that many of the features (like the WebTools -> Artifact Info stuff) 
are NOT meant to be run on production systems and doing so is guaranteed to use 
system resources in a wasteful way.

The main way that things get fixed is by a "real-world" user dedicating 
resources to fixing things that are important to their use of the system, and 
if you look at the commit logs you'll see those kinds of fixes (and/or 
improvements) coming in all the time. That's what drives the project.

Scott mentioned that the demo server is under-resourced, and that is true of 
hardware resources AND human resources. If not enough people care about it, 
there is no means of force or incentive from the project itself to get it done.

BTW BJ, why in your message did you limit the people who should do something 
about this to "all those that commit and make changes to ofbiz"? Or did you 
mean that more generally, like anyone who changes OFBiz, which would include 
you too?

If that's not what you meant, then would you consider yourself to be in the 
category of person that believes that a voluntary gift by someone obligates 
them to future involuntary gifts? And what will you do if they stop giving and 
your entitlements are gone?

-David

Re: freemarker Static[UtilMisc].toMap() use


Yes I agree, why not use an idiomatic syntax when it exists?
I guess some persons prefer to have the same syntax everywhere or even don't know the idiomatic syntax (or maybe in some cases 
simply C/P snippets from Java)


Jacques

From: "Adam Heath" 

On 12/09/2010 01:58 PM, Adam Heath wrote:

I just noticed that several(many) ftl files use UtilMisc.toMap, but
others are using {}(freemarker syntax). I assume we would like the
latter to prevail. Agreements?


Same goes for UtilMisc.toMap and UtilMisc.toList inside groovy; groovy has native support for map/list creation, and imho should 
be preferred.

Re: freemarker Static[UtilMisc].toMap() use


On 12/09/2010 04:45 PM, Jacques Le Roux wrote:

Yes I agree, why not use an idiomatic syntax when it exists?
I guess some persons prefer to have the same syntax everywhere or even
don't know the idiomatic syntax (or maybe in some cases simply C/P
snippets from Java)


The only reason I knew about {} in freemarker is because I saw it 
being used.  I am finding all findByAnd calls, to deprecate older 
versions, so am getting a chance to look at tons of files.


As for using {} and [] in freemarker, and [:] and [] in groovy, the 
native syntax tends to be faster.  Using classes in freemarker and 
groovy requires using reflection, which does end up being slower. 
Using native syntax all that indirection can be bypassed.

Re: demo server performance


Thanks for you view on my motives.
From what Jacques states the server has max hardware resources.
so what resources are you referring to?
I since I have a similar server running more than what Jacques has 
stated, and it runs, I am at a loss on how to work on the ofbiz demo.

I have been focused as much as I am allowed on this for almost a year.
considering posting five urls at the same time should not effect a 
server, I don't see that as testing the limits of the server.



Scott Gray sent the following on 12/9/2010 1:47 PM:

Everybody works on the areas of the system that are important to them, I 
suggest you do the same.

The demo server is under-resourced so of course you're going to be able to 
bring it down if you try to, my suggestion is that you don't try to.

Regards
Scott

HotWax Media
http://www.hotwaxmedia.com

On 10/12/2010, at 10:32 AM, BJ Freeman wrote:


there is a thread on the user ML about the demo being slow.
I would think that would be a high priority for all those that commit and make 
changes to ofbiz.
after all what good is all this stuff if it can't be used.
I brought down the demo trunk by accessing with seperate requests at one time, 
as I stated on the user ml.

lets focus on real problems.

Re: demo server performance

I have, what I consider, not only production but demo and test instances 
on a server.

an they work so I agree.
BTW I can use the artifacts on my production so that is not a consideration.

I mean those that review the code that gets committed and have access to 
the demo server.


I answer the resources in my reply to scott.

If everyone stop contributing the way they do(little or no intensive 
testing, and upgrade paths), maybe I could get release stable. So I 
don't see the "gifts" as that.


that is slowly being taken care of as my resources are gaining.





BJ Freeman
Strategic Power Office with Supplier Automation  

Specialtymarket.com  
Systems Integrator-- Glad to Assist

Chat  Y! messenger: bjfr33man


David E Jones sent the following on 12/9/2010 2:23 PM:


On Dec 9, 2010, at 1:32 PM, BJ Freeman wrote:


there is a thread on the user ML about the demo being slow.
I would think that would be a high priority for all those that commit and make 
changes to ofbiz.
after all what good is all this stuff if it can't be used.
I brought down the demo trunk by accessing with seperate requests at one time, 
as I stated on the user ml.

lets focus on real problems.


The real problem is: real problems according to who/what?

Don't make the mistake of thinking that problems on the demo server mean that 
real-world users with production instances are having the same problems. Also, 
consider that many of the features (like the WebTools ->  Artifact Info stuff) 
are NOT meant to be run on production systems and doing so is guaranteed to use 
system resources in a wasteful way.

The main way that things get fixed is by a "real-world" user dedicating 
resources to fixing things that are important to their use of the system, and if you look 
at the commit logs you'll see those kinds of fixes (and/or improvements) coming in all 
the time. That's what drives the project.

Scott mentioned that the demo server is under-resourced, and that is true of 
hardware resources AND human resources. If not enough people care about it, 
there is no means of force or incentive from the project itself to get it done.

BTW BJ, why in your message did you limit the people who should do something about this 
to "all those that commit and make changes to ofbiz"? Or did you mean that more 
generally, like anyone who changes OFBiz, which would include you too?

If that's not what you meant, then would you consider yourself to be in the 
category of person that believes that a voluntary gift by someone obligates 
them to future involuntary gifts? And what will you do if they stop giving and 
your entitlements are gone?

-David

Re: demo server performance


On 12/09/2010 05:01 PM, BJ Freeman wrote:

Thanks for you view on my motives.
 From what Jacques states the server has max hardware resources.
so what resources are you referring to?
I since I have a similar server running more than what Jacques has
stated, and it runs, I am at a loss on how to work on the ofbiz demo.
I have been focused as much as I am allowed on this for almost a year.
considering posting five urls at the same time should not effect a
server, I don't see that as testing the limits of the server.


What urls?  What actions are you performing, and what do you expect to 
happen?  Details, please.


'max hardware' to me means that it has the most resources that are 
available.  It most definately does not mean that it is running on the 
fastest computer known to man.


Plus, it is not tuned to for its installation.  Installing a 
production system for a client requires tuning tons of different 
knobs.  For each install, those knobs will be different.  It does not 
make sense to change the sane defaults in ofbiz to something that is 
for one particular install(apache demo installs).


As David said, this project is just a bunch of volunteers.  If you see 
a problem, and no one steps up to resolve it(or, at the least, 
investigate), then it falls on the reporter to do the work.  If that 
doesn't happen, then I guess nothing will be finished.  But you can't 
force anyone in this project to do anything.


The best you could do(if I could borrow the terminology) is to show 
the business case for why something should be better, and get others 
to be excited about fixing it.  Then you can just sit back and watch 
others do work for you.

Re: demo server performance


I have spent a lot of time (I mean in respect of my free time) this last days 
to understand the problems.
It appears that removing the help was a great relief for our demo sever.

For few hours now we are running with

trunk: -Xms128M -Xmx768M -XX:MaxPermSize=192m (so max seems 768+192=960MB but 
actually it's more)
branch9: -Xms128M -Xmx512M

For instance now we have
Mem:   2573924k total,  2159888k used,   414036k free,53672k buffers
Swap:  1502036k total,50676k used,  1451360k free,   438000k cached

PID USER  PR  NI  VIRT  RES  SHR  %CPU %MEM
trunk 14896 ofbiz 20   0 1377m 753m 7956   0.3 30.0
branch918147 ofbiz 20   0  918m 670m  13m   0.7 26.7

As you can see at some stage we reach more than 960MB for the trunk (1377 max, 
which is approx but anyway)

The main points:
* We have still around 400MB  free, but I suppose it will be less just before 
the 24h reload)
* We have anymore CPU running always near 100%, for instance right now
 PID USER  PR  NI  VIRT  RES  SHR  %CPU %MEMTIME+  COMMAND
14896 ofbiz 20   0 1377m 757m 7968  29.7 30.2  19:57.63 java -Xms128M 
-Xmx768M -XX:MaxPermSize=192m
18147 ofbiz 20   0  918m 671m  13m  22.4 26.7  14:23.55 java -Xms128M 
-Xmx512M


I will wait some days and, if things continue to go well, will re-use more 
memory for our 2 processes. But I know there are other
problems...

Like David and Scott said if people are using the Artifact Info or other 
gluttonous features (Birts?) we will be in trouble with our
memory quota. So if such things come back in the future I will suggest to 
prevent users to use them on the demo server...

For the real problems, I think we should focus on fixing the online Help 
feature. It seems that this isues is something relatively
new and a disect should help (I use this word because it's convenient, on my 
side I simply use dichotomic tests with svn but I have
bigger fish to fry for now, that's why I have deactivated it). I think it's not 
more than few days (weeks?), help appreciated...

Thanks

Jacques

From: "BJ Freeman" 

there is a thread on the user ML about the demo being slow.
I would think that would be a high priority for all those that commit and make 
changes to ofbiz.
after all what good is all this stuff if it can't be used.
I brought down the demo trunk by accessing with seperate requests at one time, 
as I stated on the user ml.

lets focus on real problems.

Re: demo server performance


On 12/09/2010 05:11 PM, BJ Freeman wrote:
> [snip, just want to talk about the next paragraph]


If everyone stop contributing the way they do(little or no intensive
testing, and upgrade paths), maybe I could get release stable. So I
don't see the "gifts" as that.


What do you mean, getting a release stable?  Are you deploying new 
applications on trunk, and then after the deployment, continuing to 
upgrade to the latest trunk each time, in a production environment? 
If so, then don't do that.


In all the various open source projects I have been involved with, 
*none* have ever done full upgrade testing, full system regression, on 
trunk.  Only when the set of features stablizes, and a real release is 
iniment, does final upgrade testing occur, and release notes get 
finalized.


A feature added to trunk during a development cycle may end up getting 
completely rewritten, or removed, before the next stable release comes 
out.  If we follow your design practice, then every single change will 
have to come with full deprecation of old features, full upgrade 
support, and nothing will actually get implemented.


Here at brainfood, our current ofbiz deployments are based on svn 
902021.  There was nothing special about that particular version.  I 
just happened to have time to create a new ofbiz.deb package(we use 
debian internally).  Since then, there have been 447 commits to our 
local package, and 42 separate package releases.  99% of those changes 
are backports(actually, we use git, so they are called cherry-picks) 
directly from trunk.  I've been able to do this all on my own, a 
single person, in addition to my other duties.  It has not been a huge 
sap on my personal resources.

Re: demo server performance


On 12/09/2010 05:18 PM, Jacques Le Roux wrote:

I have spent a lot of time (I mean in respect of my free time) this last
days to understand the problems.
It appears that removing the help was a great relief for our demo sever.

For few hours now we are running with

trunk: -Xms128M -Xmx768M -XX:MaxPermSize=192m (so max seems
768+192=960MB but actually it's more)
branch9: -Xms128M -Xmx512M

For instance now we have
Mem: 2573924k total, 2159888k used, 414036k free, 53672k buffers
Swap: 1502036k total, 50676k used, 1451360k free, 438000k cached

PID USER PR NI VIRT RES SHR %CPU %MEM
trunk 14896 ofbiz 20 0 1377m 753m 7956 0.3 30.0
branch9 18147 ofbiz 20 0 918m 670m 13m 0.7 26.7

As you can see at some stage we reach more than 960MB for the trunk
(1377 max, which is approx but anyway)

The main points:
* We have still around 400MB free, but I suppose it will be less just
before the 24h reload)
* We have anymore CPU running always near 100%, for instance right now
PID USER PR NI VIRT RES SHR %CPU %MEM TIME+ COMMAND
14896 ofbiz 20 0 1377m 757m 7968 29.7 30.2 19:57.63 java -Xms128M
-Xmx768M -XX:MaxPermSize=192m
18147 ofbiz 20 0 918m 671m 13m 22.4 26.7 14:23.55 java -Xms128M -Xmx512M


I will wait some days and, if things continue to go well, will re-use
more memory for our 2 processes. But I know there are other
problems...

Like David and Scott said if people are using the Artifact Info or other
gluttonous features (Birts?) we will be in trouble with our
memory quota. So if such things come back in the future I will suggest
to prevent users to use them on the demo server...

For the real problems, I think we should focus on fixing the online Help
feature. It seems that this isues is something relatively
new and a disect should help (I use this word because it's convenient,
on my side I simply use dichotomic tests with svn but I have
bigger fish to fry for now, that's why I have deactivated it). I think
it's not more than few days (weeks?), help appreciated...


Hate to disappoint, but all those memory stats you posted are 
completely useless for actually tracking down what java is doing.


You need to become friends with jmap, jhat(both standard jdk tools), 
and ibm's heap analyzer.  Plus, sending the QUIT signal to the java 
process.


In all honesty, I'm going to go out on a limb here and say the higher 
memory requirements of newer ofbiz is due to converting tons of code 
to groovy.  With it as a simple-method, or a bsh, both would end up 
using heap, as they are interpetted.  java or groovy get compiled to 
bytecode, which ends up being allocated in the permgen area, which 
might also get jit compiled.  So, permgen needs to increase.

Re: demo server performance


From: "BJ Freeman" 

Thanks for you view on my motives.
From what Jacques states the server has max hardware resources.
so what resources are you referring to?
I since I have a similar server running more than what Jacques has stated, and it runs, I am at a loss on how to work on the ofbiz 
demo.

I have been focused as much as I am allowed on this for almost a year.
considering posting five urls at the same time should not effect a server, I 
don't see that as testing the limits of the server.


Which URLs? It really depends on them... Artifact Info, Entity Maintenance, Label Manager, etc. are good culprits... This does not 
mean that we can't use Entity Maintenance on the demo server, nor even Artifact Info. But it depends on the number of people which 
are using them at the same time. And when it's down, it's down: you will have to wait a good soul (not sleeping, like me in some 
mins) to reload the demo instance... Webtools are not all days tools for a production server... I will suggest to use rather such 
tools locally... Does it make sense?


Thanks

Jacques



Scott Gray sent the following on 12/9/2010 1:47 PM:

Everybody works on the areas of the system that are important to them, I 
suggest you do the same.

The demo server is under-resourced so of course you're going to be able to bring it down if you try to, my suggestion is that you 
don't try to.


Regards
Scott

HotWax Media
http://www.hotwaxmedia.com

On 10/12/2010, at 10:32 AM, BJ Freeman wrote:


there is a thread on the user ML about the demo being slow.
I would think that would be a high priority for all those that commit and make 
changes to ofbiz.
after all what good is all this stuff if it can't be used.
I brought down the demo trunk by accessing with seperate requests at one time, 
as I stated on the user ml.

lets focus on real problems.

when I restart my client firefox brings up all the pages from last session.
the following URl are accessed from different tabs.
I expect them to come up to the login screen except for the ecommerce.
many times I will get
problem loading
http://demo-trunk.ofbiz.apache.org:8080/ecommerce/control/main
https://demo-trunk.ofbiz.apache.org/accounting/control/FindBillingAccount?partyId=DemoCustomer
https://demo-trunk.ofbiz.apache.org/webtools/control/login
https://demo-trunk.ofbiz.apache.org/partymgr/control/editpartygroup?partyId=DemoSupplier
https://demo-trunk.ofbiz.apache.org/webtools/control/FindGeneric?entityName=Product&find=true&VIEW_SIZE=50&VIEW_INDEX=0

lately when they load
http://monitoring.apache.org/status/
shows everthing is ok
I then load the above URLs and get a warning then flap then shutdown.

I can not duplicate the above on my demo-trunk on my server.

BJ Freeman
Strategic Power Office with Supplier Automation

Specialtymarket.com
Systems Integrator-- Glad to Assist

Chat Y! messenger: bjfr33man

Adam Heath sent the following on 12/9/2010 3:13 PM:

On 12/09/2010 05:01 PM, BJ Freeman wrote:

Thanks for you view on my motives.
From what Jacques states the server has max hardware resources.
so what resources are you referring to?
I since I have a similar server running more than what Jacques has
stated, and it runs, I am at a loss on how to work on the ofbiz demo.
I have been focused as much as I am allowed on this for almost a year.
considering posting five urls at the same time should not effect a
server, I don't see that as testing the limits of the server.

What urls? What actions are you performing, and what do you expect to
happen? Details, please.

'max hardware' to me means that it has the most resources that are
available. It most definately does not mean that it is running on the
fastest computer known to man.

Plus, it is not tuned to for its installation. Installing a production
system for a client requires tuning tons of different knobs. For each
install, those knobs will be different. It does not make sense to change
the sane defaults in ofbiz to something that is for one particular
install(apache demo installs).

As David said, this project is just a bunch of volunteers. If you see a
problem, and no one steps up to resolve it(or, at the least,
investigate), then it falls on the reporter to do the work. If that
doesn't happen, then I guess nothing will be finished. But you can't
force anyone in this project to do anything.

The best you could do(if I could borrow the terminology) is to show the
business case for why something should be better, and get others to be
excited about fixing it. Then you can just sit back and watch others do
work for you.

Re: demo server performance


From: "Adam Heath" 

On 12/09/2010 05:18 PM, Jacques Le Roux wrote:

I have spent a lot of time (I mean in respect of my free time) this last
days to understand the problems.
It appears that removing the help was a great relief for our demo sever.

For few hours now we are running with

trunk: -Xms128M -Xmx768M -XX:MaxPermSize=192m (so max seems
768+192=960MB but actually it's more)
branch9: -Xms128M -Xmx512M

For instance now we have
Mem: 2573924k total, 2159888k used, 414036k free, 53672k buffers
Swap: 1502036k total, 50676k used, 1451360k free, 438000k cached

PID USER PR NI VIRT RES SHR %CPU %MEM
trunk 14896 ofbiz 20 0 1377m 753m 7956 0.3 30.0
branch9 18147 ofbiz 20 0 918m 670m 13m 0.7 26.7

As you can see at some stage we reach more than 960MB for the trunk
(1377 max, which is approx but anyway)

The main points:
* We have still around 400MB free, but I suppose it will be less just
before the 24h reload)
* We have anymore CPU running always near 100%, for instance right now
PID USER PR NI VIRT RES SHR %CPU %MEM TIME+ COMMAND
14896 ofbiz 20 0 1377m 757m 7968 29.7 30.2 19:57.63 java -Xms128M
-Xmx768M -XX:MaxPermSize=192m
18147 ofbiz 20 0 918m 671m 13m 22.4 26.7 14:23.55 java -Xms128M -Xmx512M


I will wait some days and, if things continue to go well, will re-use
more memory for our 2 processes. But I know there are other
problems...

Like David and Scott said if people are using the Artifact Info or other
gluttonous features (Birts?) we will be in trouble with our
memory quota. So if such things come back in the future I will suggest
to prevent users to use them on the demo server...

For the real problems, I think we should focus on fixing the online Help
feature. It seems that this isues is something relatively
new and a disect should help (I use this word because it's convenient,
on my side I simply use dichotomic tests with svn but I have
bigger fish to fry for now, that's why I have deactivated it). I think
it's not more than few days (weeks?), help appreciated...


Hate to disappoint, but all those memory stats you posted are completely 
useless for actually tracking down what java is doing.

You need to become friends with jmap, jhat(both standard jdk tools), and ibm's heap analyzer.  Plus, sending the QUIT signal to 
the java process.


Yes I know, this is only to give a general information about what's going on on 
the server.
As I have already wrote I'm actually using mat http://www.eclipse.org/mat/ 
behind the scene
I'm also using -XX:+HeapDumpOnOutOfMemoryError but most of the time get rather 
out of swap issues when crashing, hard to trace...
One way would be mod_log_forensic... if someone wants to help...

In all honesty, I'm going to go out on a limb here and say the higher memory requirements of newer ofbiz is due to converting tons 
of code to groovy.  With it as a simple-method, or a bsh, both would end up using heap, as they are interpetted.  java or groovy 
get compiled to bytecode, which ends up being allocated in the permgen area, which might also get jit compiled.  So, permgen needs 
to increase.


It does not seem that we have permgen issues. It's not yet clear, but for those interested I could move hprof files from demo roots 
to bigfiles dir...


Thanks

Jacques

Re: demo server performance


On 12/09/2010 05:31 PM, BJ Freeman wrote:

when I restart my  client firefox brings up all the pages from last
session.
the following URl are accessed from different tabs.
I expect them to come up to the login screen except for the ecommerce.
many times I will get
problem loading
http://demo-trunk.ofbiz.apache.org:8080/ecommerce/control/main
https://demo-trunk.ofbiz.apache.org/accounting/control/FindBillingAccount?partyId=DemoCustomer

https://demo-trunk.ofbiz.apache.org/webtools/control/login
https://demo-trunk.ofbiz.apache.org/partymgr/control/editpartygroup?partyId=DemoSupplier

https://demo-trunk.ofbiz.apache.org/webtools/control/FindGeneric?entityName=Product&find=true&VIEW_SIZE=50&VIEW_INDEX=0


So, 5 requests issued at all once.  Should be easy to duplicate that. 
 Start up a local ofbiz, hit then right after startup, then hit them 
again after the cache(s) are primed.



lately when they load
http://monitoring.apache.org/status/
shows everthing is ok
I then load the above URLs and get a warning then flap then shutdown.


That status link can't be used for debugging these kinds of problems. 
 It's the as saying "I found a problem in a groovy file, but the 
machine pings, so I'm at a loss as to what is going on."

Re: demo server performance


From: "BJ Freeman" 

when I restart my  client firefox brings up all the pages from last session.
the following URl are accessed from different tabs.
I expect them to come up to the login screen except for the ecommerce.
many times I will get
problem loading
http://demo-trunk.ofbiz.apache.org:8080/ecommerce/control/main
https://demo-trunk.ofbiz.apache.org/accounting/control/FindBillingAccount?partyId=DemoCustomer
https://demo-trunk.ofbiz.apache.org/webtools/control/login
https://demo-trunk.ofbiz.apache.org/partymgr/control/editpartygroup?partyId=DemoSupplier
https://demo-trunk.ofbiz.apache.org/webtools/control/FindGeneric?entityName=Product&find=true&VIEW_SIZE=50&VIEW_INDEX=0


What kinds of problems?


lately when they load
http://monitoring.apache.org/status/
shows everthing is ok
I then load the above URLs and get a warning then flap then shutdown.


With the above URLs all should go smoothly, I'm surprised... I will test 
tomorrow...

Jacques


I can not duplicate the above on my demo-trunk on my server.

=

BJ Freeman
Strategic Power Office with Supplier Automation  

Specialtymarket.com  
Systems Integrator-- Glad to Assist

Chat  Y! messenger: bjfr33man


Adam Heath sent the following on 12/9/2010 3:13 PM:

On 12/09/2010 05:01 PM, BJ Freeman wrote:

Thanks for you view on my motives.
From what Jacques states the server has max hardware resources.
so what resources are you referring to?
I since I have a similar server running more than what Jacques has
stated, and it runs, I am at a loss on how to work on the ofbiz demo.
I have been focused as much as I am allowed on this for almost a year.
considering posting five urls at the same time should not effect a
server, I don't see that as testing the limits of the server.


What urls? What actions are you performing, and what do you expect to
happen? Details, please.

'max hardware' to me means that it has the most resources that are
available. It most definately does not mean that it is running on the
fastest computer known to man.

Plus, it is not tuned to for its installation. Installing a production
system for a client requires tuning tons of different knobs. For each
install, those knobs will be different. It does not make sense to change
the sane defaults in ofbiz to something that is for one particular
install(apache demo installs).

As David said, this project is just a bunch of volunteers. If you see a
problem, and no one steps up to resolve it(or, at the least,
investigate), then it falls on the reporter to do the work. If that
doesn't happen, then I guess nothing will be finished. But you can't
force anyone in this project to do anything.

The best you could do(if I could borrow the terminology) is to show the
business case for why something should be better, and get others to be
excited about fixing it. Then you can just sit back and watch others do
work for you.

Re: demo server performance


all my changes are in seperate components.
currently my attention is 10.4 branch, which I keep updating in a test 
instance.

1)load and configure my componets
2)ant run-install
check logs and operation related to my components.
what usually happens is I get log errors do to changes that are not 
compatible from 9.04.

3)connect to postgresql
4)load data from production server into this test instance.
set entityengine so will not update db.
5)run code so get logs reports of data changes
6)see if any effect my components
7)got through the compoents to change.
8)ant clean-all
9)clean the postresql and turn back on add tables.
10)run migration of production data to changed db for 10.4

first time workeffort was a few manweeks.
each subsequence update of the 10.4 does not exceed a manweek.


=

BJ Freeman
Strategic Power Office with Supplier Automation  

Specialtymarket.com  
Systems Integrator-- Glad to Assist

Chat  Y! messenger: bjfr33man


Adam Heath sent the following on 12/9/2010 3:22 PM:

On 12/09/2010 05:11 PM, BJ Freeman wrote:
 > [snip, just want to talk about the next paragraph]


If everyone stop contributing the way they do(little or no intensive
testing, and upgrade paths), maybe I could get release stable. So I
don't see the "gifts" as that.


What do you mean, getting a release stable? Are you deploying new
applications on trunk, and then after the deployment, continuing to
upgrade to the latest trunk each time, in a production environment? If
so, then don't do that.

In all the various open source projects I have been involved with,
*none* have ever done full upgrade testing, full system regression, on
trunk. Only when the set of features stablizes, and a real release is
iniment, does final upgrade testing occur, and release notes get finalized.

A feature added to trunk during a development cycle may end up getting
completely rewritten, or removed, before the next stable release comes
out. If we follow your design practice, then every single change will
have to come with full deprecation of old features, full upgrade
support, and nothing will actually get implemented.

Here at brainfood, our current ofbiz deployments are based on svn
902021. There was nothing special about that particular version. I just
happened to have time to create a new ofbiz.deb package(we use debian
internally). Since then, there have been 447 commits to our local
package, and 42 separate package releases. 99% of those changes are
backports(actually, we use git, so they are called cherry-picks)
directly from trunk. I've been able to do this all on my own, a single
person, in addition to my other duties. It has not been a huge sap on my
personal resources.

Re: demo server performance


On 12/09/2010 05:50 PM, BJ Freeman wrote:

all my changes are in seperate components.
currently my attention is 10.4 branch, which I keep updating in a test
instance.
1)load and configure my componets
2)ant run-install
check logs and operation related to my components.
what usually happens is I get log errors do to changes that are not
compatible from 9.04.
3)connect to postgresql
4)load data from production server into this test instance.
set entityengine so will not update db.
5)run code so get logs reports of data changes
6)see if any effect my components
7)got through the compoents to change.
8)ant clean-all
9)clean the postresql and turn back on add tables.
10)run migration of production data to changed db for 10.4

first time workeffort was a few manweeks.
each subsequence update of the 10.4 does not exceed a manweek.


Interesting.  Yes, I agree, a defined release branch in ofbiz(10.4 in 
this case) should have such upgrade support from one minor point 
release to another.


However, there actually hasn't been a real release of that branch, so, ...

Re: demo server performance

all the status page does is give my an indicatioh if the demo is healthy
before I start
I have done it enough time to figure out that it probably not other
influences.
Since I don't have access to the logs on the demo-trunk, I can not do
further debug.

BJ Freeman
Strategic Power Office with Supplier Automation

Specialtymarket.com
Systems Integrator-- Glad to Assist

Chat Y! messenger: bjfr33man

Adam Heath sent the following on 12/9/2010 3:43 PM:

On 12/09/2010 05:31 PM, BJ Freeman wrote:

https://demo-trunk.ofbiz.apache.org/webtools/control/login
https://demo-trunk.ofbiz.apache.org/partymgr/control/editpartygroup?partyId=DemoSupplier

https://demo-trunk.ofbiz.apache.org/webtools/control/FindGeneric?entityName=Product&find=true&VIEW_SIZE=50&VIEW_INDEX=0

So, 5 requests issued at all once. Should be easy to duplicate that.
Start up a local ofbiz, hit then right after startup, then hit them
again after the cache(s) are primed.

lately when they load
http://monitoring.apache.org/status/
shows everthing is ok
I then load the above URLs and get a warning then flap then shutdown.

That status link can't be used for debugging these kinds of problems.
It's the as saying "I found a problem in a groovy file, but the machine
pings, so I'm at a loss as to what is going on."

Re: demo server performance


that works for me. Count me in.

=
BJ Freeman
Strategic Power Office with Supplier Automation  

Specialtymarket.com  
Systems Integrator-- Glad to Assist

Chat  Y! messenger: bjfr33man


Jacques Le Roux sent the following on 12/9/2010 3:42 PM:

From: "Adam Heath" 

On 12/09/2010 05:18 PM, Jacques Le Roux wrote:

I have spent a lot of time (I mean in respect of my free time) this last
days to understand the problems.
It appears that removing the help was a great relief for our demo sever.

For few hours now we are running with

trunk: -Xms128M -Xmx768M -XX:MaxPermSize=192m (so max seems
768+192=960MB but actually it's more)
branch9: -Xms128M -Xmx512M

For instance now we have
Mem: 2573924k total, 2159888k used, 414036k free, 53672k buffers
Swap: 1502036k total, 50676k used, 1451360k free, 438000k cached

PID USER PR NI VIRT RES SHR %CPU %MEM
trunk 14896 ofbiz 20 0 1377m 753m 7956 0.3 30.0
branch9 18147 ofbiz 20 0 918m 670m 13m 0.7 26.7

As you can see at some stage we reach more than 960MB for the trunk
(1377 max, which is approx but anyway)

The main points:
* We have still around 400MB free, but I suppose it will be less just
before the 24h reload)
* We have anymore CPU running always near 100%, for instance right now
PID USER PR NI VIRT RES SHR %CPU %MEM TIME+ COMMAND
14896 ofbiz 20 0 1377m 757m 7968 29.7 30.2 19:57.63 java -Xms128M
-Xmx768M -XX:MaxPermSize=192m
18147 ofbiz 20 0 918m 671m 13m 22.4 26.7 14:23.55 java -Xms128M -Xmx512M


I will wait some days and, if things continue to go well, will re-use
more memory for our 2 processes. But I know there are other
problems...

Like David and Scott said if people are using the Artifact Info or other
gluttonous features (Birts?) we will be in trouble with our
memory quota. So if such things come back in the future I will suggest
to prevent users to use them on the demo server...

For the real problems, I think we should focus on fixing the online Help
feature. It seems that this isues is something relatively
new and a disect should help (I use this word because it's convenient,
on my side I simply use dichotomic tests with svn but I have
bigger fish to fry for now, that's why I have deactivated it). I think
it's not more than few days (weeks?), help appreciated...


Hate to disappoint, but all those memory stats you posted are
completely useless for actually tracking down what java is doing.

You need to become friends with jmap, jhat(both standard jdk tools),
and ibm's heap analyzer. Plus, sending the QUIT signal to the java
process.


Yes I know, this is only to give a general information about what's
going on on the server.
As I have already wrote I'm actually using mat
http://www.eclipse.org/mat/ behind the scene
I'm also using -XX:+HeapDumpOnOutOfMemoryError but most of the time get
rather out of swap issues when crashing, hard to trace...
One way would be mod_log_forensic... if someone wants to help...


In all honesty, I'm going to go out on a limb here and say the higher
memory requirements of newer ofbiz is due to converting tons of code
to groovy. With it as a simple-method, or a bsh, both would end up
using heap, as they are interpetted. java or groovy get compiled to
bytecode, which ends up being allocated in the permgen area, which
might also get jit compiled. So, permgen needs to increase.


It does not seem that we have permgen issues. It's not yet clear, but
for those interested I could move hprof files from demo roots to
bigfiles dir...

Thanks

Jacques

Re: demo server performance


You got me there Adam.
and I am not saying we test or run upgrade at each update of 10.4.
based on efforts so far I don't expect the effort I outlined to be done 
by the volunteers, though they are the best qualified to do this.


as you see I do take my support of ofbiz seriously.
and when you multiply this more than 50 times it turns out to be more 
than a man year to release what I consider stable systems.



=

BJ Freeman
Strategic Power Office with Supplier Automation  

Specialtymarket.com  
Systems Integrator-- Glad to Assist

Chat  Y! messenger: bjfr33man


Adam Heath sent the following on 12/9/2010 3:52 PM:

On 12/09/2010 05:50 PM, BJ Freeman wrote:

all my changes are in seperate components.
currently my attention is 10.4 branch, which I keep updating in a test
instance.
1)load and configure my componets
2)ant run-install
check logs and operation related to my components.
what usually happens is I get log errors do to changes that are not
compatible from 9.04.
3)connect to postgresql
4)load data from production server into this test instance.
set entityengine so will not update db.
5)run code so get logs reports of data changes
6)see if any effect my components
7)got through the compoents to change.
8)ant clean-all
9)clean the postresql and turn back on add tables.
10)run migration of production data to changed db for 10.4

first time workeffort was a few manweeks.
each subsequence update of the 10.4 does not exceed a manweek.


Interesting. Yes, I agree, a defined release branch in ofbiz(10.4 in
this case) should have such upgrade support from one minor point release
to another.

However, there actually hasn't been a real release of that branch, so, ...

Re: demo server performance


On 12/09/2010 06:09 PM, BJ Freeman wrote:

You got me there Adam.
and I am not saying we test or run upgrade at each update of 10.4.
based on efforts so far I don't expect the effort I outlined to be done
by the volunteers, though they are the best qualified to do this.

as you see I do take my support of ofbiz seriously.
and when you multiply this more than 50 times it turns out to be more
than a man year to release what I consider stable systems.


We don't upgrade production systems.  We leave them alone.  If there 
are problems, we backport changes into whatever version of ofbiz is 
deployed.  For the last 3 years, that has been thru a debian package 
of ofbiz.  When a client has a problem, and it gets fixed, using the 
debian package allows us to get that same fix out to other production 
instances running the same version.


We also manage the debian package thru git, and it's possible to 
checkout the exact version of the debian package locally onto the 
production system.  We then change OFBIZ_HOME in the init script to 
point to the checkout, and can then fix the code in place.  Once the 
fix works, it is copied into the build system, and a new package is 
produced.


Full ofbiz package upgrades are never done without a client paying.

I currently have ofbiz packages of 595296, 811564, and 902021 that I 
have to maintain.  There are some really old versions, where we would 
take a snapshot of whatever ofbiz was current at the time the new job 
was created, but we've moved away from that.  Instead, the company as 
a whole decided to stick with a version of ofbiz for an extended 
period.  This period tends to be yearly(but that's not set in stone).

Re: demo server performance


small misunderstanding.
50 as business models, in realestate, education, restraunt, and so on.
so this is work that has to be done even if the paritular busine3ss 
model has not been sold so that it is update when a clients buys.


yes I have my own Svn there is "production" for each.
and a script that upgrades each client for that business model that is 
already in production.


this is nothing new to me since I have been doing software life cycles 
since the early 80's.



=

BJ Freeman
Strategic Power Office with Supplier Automation  

Specialtymarket.com  
Systems Integrator-- Glad to Assist

Chat  Y! messenger: bjfr33man


Adam Heath sent the following on 12/9/2010 4:18 PM:

On 12/09/2010 06:09 PM, BJ Freeman wrote:

You got me there Adam.
and I am not saying we test or run upgrade at each update of 10.4.
based on efforts so far I don't expect the effort I outlined to be done
by the volunteers, though they are the best qualified to do this.

as you see I do take my support of ofbiz seriously.
and when you multiply this more than 50 times it turns out to be more
than a man year to release what I consider stable systems.


We don't upgrade production systems. We leave them alone. If there are
problems, we backport changes into whatever version of ofbiz is
deployed. For the last 3 years, that has been thru a debian package of
ofbiz. When a client has a problem, and it gets fixed, using the debian
package allows us to get that same fix out to other production instances
running the same version.

We also manage the debian package thru git, and it's possible to
checkout the exact version of the debian package locally onto the
production system. We then change OFBIZ_HOME in the init script to point
to the checkout, and can then fix the code in place. Once the fix works,
it is copied into the build system, and a new package is produced.

Full ofbiz package upgrades are never done without a client paying.

I currently have ofbiz packages of 595296, 811564, and 902021 that I
have to maintain. There are some really old versions, where we would
take a snapshot of whatever ofbiz was current at the time the new job
was created, but we've moved away from that. Instead, the company as a
whole decided to stick with a version of ofbiz for an extended period.
This period tends to be yearly(but that's not set in stone).

[jira] Created: (OFBIZ-4052) Update Docbook files and give a nice look to doc

Update Docbook files and give a nice look to doc


 Key: OFBIZ-4052
 URL: https://issues.apache.org/jira/browse/OFBIZ-4052
 Project: OFBiz
  Issue Type: Improvement
Affects Versions: SVN trunk
Reporter: BJ Freeman
Priority: Minor


updateds all the docbook.css in themes.
remove tags from the 


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[jira] Updated: (OFBIZ-4052) Update Docbook files and give a nice look to doc


 [ 
https://issues.apache.org/jira/browse/OFBIZ-4052?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

BJ Freeman updated OFBIZ-4052:
--

Attachment: OFBIZ-4052Docbookfiles.patch

> Update Docbook files and give a nice look to doc
> 
>
> Key: OFBIZ-4052
> URL: https://issues.apache.org/jira/browse/OFBIZ-4052
> Project: OFBiz
>  Issue Type: Improvement
>Affects Versions: SVN trunk
>Reporter: BJ Freeman
>Priority: Minor
> Attachments: OFBIZ-4052Docbookfiles.patch
>
>
> updateds all the docbook.css in themes.
> remove tags from the 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[jira] Issue Comment Edited: (OFBIZ-4052) Update Docbook files and give a nice look to doc


[ 
https://issues.apache.org/jira/browse/OFBIZ-4052?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12970053#action_12970053
 ] 

BJ Freeman edited comment on OFBIZ-4052 at 12/9/10 9:16 PM:


since the docbook is disabled use this to see
http://demo-trunk.businessesnetwork.com/cmssite/cms/APACHE_OFBIZ_HTML

  was (Author: bjfreeman):
since the docbook is disabled use this to see

  
> Update Docbook files and give a nice look to doc
> 
>
> Key: OFBIZ-4052
> URL: https://issues.apache.org/jira/browse/OFBIZ-4052
> Project: OFBiz
>  Issue Type: Improvement
>Affects Versions: SVN trunk
>Reporter: BJ Freeman
>Priority: Minor
> Attachments: OFBIZ-4052Docbookfiles.patch
>
>
> updateds all the docbook.css in themes.
> remove tags from the 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[jira] Commented: (OFBIZ-4052) Update Docbook files and give a nice look to doc


[ 
https://issues.apache.org/jira/browse/OFBIZ-4052?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12970053#action_12970053
 ] 

BJ Freeman commented on OFBIZ-4052:
---

since the docbook is disabled use this to see


> Update Docbook files and give a nice look to doc
> 
>
> Key: OFBIZ-4052
> URL: https://issues.apache.org/jira/browse/OFBIZ-4052
> Project: OFBiz
>  Issue Type: Improvement
>Affects Versions: SVN trunk
>Reporter: BJ Freeman
>Priority: Minor
> Attachments: OFBIZ-4052Docbookfiles.patch
>
>
> updateds all the docbook.css in themes.
> remove tags from the 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[jira] Commented: (OFBIZ-4052) Update Docbook files and give a nice look to doc