[jira] [Commented] (PIVOT-999) Update code to take advantage of Java 8 features
[ https://issues.apache.org/jira/browse/PIVOT-999?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16906859#comment-16906859 ] Roger Whitcomb commented on PIVOT-999: -- Ooops! Didn't compile under Java 8: Sending core\test\org\apache\pivot\beans\test\BeanAdapterTest.java Transmitting file data .done Committing transaction... Committed revision 1865083. > Update code to take advantage of Java 8 features > > > Key: PIVOT-999 > URL: https://issues.apache.org/jira/browse/PIVOT-999 > Project: Pivot > Issue Type: New Feature > Components: all >Affects Versions: 2.1 > Environment: All >Reporter: Roger Whitcomb >Assignee: Roger Whitcomb >Priority: Major > Fix For: 2.1 > > > Some features that we could potentially use include: > * default methods in interfaces to extend features while maintaining backward > compatibility > * lambdas for such things as callbacks > * really use functional interfaces (already kind of present, but not really > used) > * "forEach" in many places for Iterable collections -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Commented] (PIVOT-999) Update code to take advantage of Java 8 features
[ https://issues.apache.org/jira/browse/PIVOT-999?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16906703#comment-16906703 ] Roger Whitcomb commented on PIVOT-999: -- Tweak a demo program: Sending demos-server\src\org\apache\pivot\demos\rest\server\RESTDemoServlet.java Transmitting file data .done Committing transaction... Committed revision 1865080. > Update code to take advantage of Java 8 features > > > Key: PIVOT-999 > URL: https://issues.apache.org/jira/browse/PIVOT-999 > Project: Pivot > Issue Type: New Feature > Components: all >Affects Versions: 2.1 > Environment: All >Reporter: Roger Whitcomb >Assignee: Roger Whitcomb >Priority: Major > Fix For: 2.1 > > > Some features that we could potentially use include: > * default methods in interfaces to extend features while maintaining backward > compatibility > * lambdas for such things as callbacks > * really use functional interfaces (already kind of present, but not really > used) > * "forEach" in many places for Iterable collections -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Commented] (PIVOT-999) Update code to take advantage of Java 8 features
[ https://issues.apache.org/jira/browse/PIVOT-999?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16906702#comment-16906702 ] Roger Whitcomb commented on PIVOT-999: -- Tweak BeanAdapter to use generic "putAll" method in Dictionary, add test: Sending core\src\org\apache\pivot\beans\BeanAdapter.java Sending core\test\org\apache\pivot\beans\test\BeanAdapterTest.java Transmitting file data ..done Committing transaction... Committed revision 1865079. > Update code to take advantage of Java 8 features > > > Key: PIVOT-999 > URL: https://issues.apache.org/jira/browse/PIVOT-999 > Project: Pivot > Issue Type: New Feature > Components: all >Affects Versions: 2.1 > Environment: All >Reporter: Roger Whitcomb >Assignee: Roger Whitcomb >Priority: Major > Fix For: 2.1 > > > Some features that we could potentially use include: > * default methods in interfaces to extend features while maintaining backward > compatibility > * lambdas for such things as callbacks > * really use functional interfaces (already kind of present, but not really > used) > * "forEach" in many places for Iterable collections -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Commented] (PIVOT-1045) Refactor read-only classes to use a common abstract class to reduce code
[ https://issues.apache.org/jira/browse/PIVOT-1045?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16905665#comment-16905665 ] Roger Whitcomb commented on PIVOT-1045: --- Other candidates include: * CalendarDateSpinnerData * QueryServlet.Path * ResultList * FileObjectList ( ? ) * FileList ( ? ) (these two are not completely read-only but only allow "add") * Sequence.ImmutablePath Other things that could be looked at: * The immutable list has other methods (such as "clear()" that are not allowed, so we could build a second base class for those) (see EnumList also) * ImmutableSet has a slightly different set of disallowed operations, so we could build ReadOnlySet maybe... * ImmutableMap could be looked at too. * EnumSet and EnumMap look a lot like these "Immutable" variants, so * BeanAdapter has a bunch of unsupported operations: is this a candidate also for a base class? > Refactor read-only classes to use a common abstract class to reduce code > > > Key: PIVOT-1045 > URL: https://issues.apache.org/jira/browse/PIVOT-1045 > Project: Pivot > Issue Type: Improvement > Components: core-collections >Reporter: Roger Whitcomb >Assignee: Roger Whitcomb >Priority: Minor > > All of the "read-only" collection classes (such as ArrayAdapter, EnumList, > ImmutableList) share the concept that "add", "insert", "remove", etc. all > throw exceptions because they are unsupported in a read-only collection. It > would reduce code and expose the common functionality if they were all > implemented on top of a single abstract class that provides a uniform > implementation of these unsupported methods. > I propose to implement a ReadOnlySequence class that does this and refactor > all other existing places (at least) with the common subclass. -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Resolved] (PIVOT-1046) Regularize ColorUtilities methods
[ https://issues.apache.org/jira/browse/PIVOT-1046?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Roger Whitcomb resolved PIVOT-1046. --- Resolution: Fixed > Regularize ColorUtilities methods > - > > Key: PIVOT-1046 > URL: https://issues.apache.org/jira/browse/PIVOT-1046 > Project: Pivot > Issue Type: Improvement > Components: wtk >Reporter: Roger Whitcomb >Assignee: Roger Whitcomb >Priority: Minor > > The method names in ColorUtilities are a bit verbose, and not regular (in > that there is a method to add transparency, but not one to take it away). > I propose to deprecate "setTransparencyInColor" and add "toTransparentColor" > which does the same thing with a "better" name. Then propose adding > "toSolidColor" as the obverse. This will regularize the functions in here > better, while still leaving the old method (deprecated) for backward > compatibility. > Next step would be changing all the callers to use the new method(s). -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Commented] (PIVOT-1046) Regularize ColorUtilities methods
[ https://issues.apache.org/jira/browse/PIVOT-1046?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16905653#comment-16905653 ] Roger Whitcomb commented on PIVOT-1046: --- Basically finished this issue: Sending tutorials\src\org\apache\pivot\tutorials\bxmlexplorer\FakeWindowSkin.java Sending tutorials\src\org\apache\pivot\tutorials\databinding\PropertyBinding.java Sending wtk\src\org\apache\pivot\wtk\CSSColor.java Sending wtk\src\org\apache\pivot\wtk\content\ColorItem.java Sending wtk\src\org\apache\pivot\wtk\content\ListButtonColorItemRenderer.java Sending wtk\src\org\apache\pivot\wtk\content\ListViewColorItemRenderer.java Sending wtk\src\org\apache\pivot\wtk\util\ColorUtilities.java Sending wtk\test\org\apache\pivot\wtk\test\ColorUtilitiesTest.java Sending wtk-terra\src\org\apache\pivot\wtk\skin\terra\TerraActivityIndicatorSkin.java Sending wtk-terra\src\org\apache\pivot\wtk\skin\terra\TerraAlertSkin.java Sending wtk-terra\src\org\apache\pivot\wtk\skin\terra\TerraCheckboxSkin.java Sending wtk-terra\src\org\apache\pivot\wtk\skin\terra\TerraDialogSkin.java Sending wtk-terra\src\org\apache\pivot\wtk\skin\terra\TerraFrameSkin.java Sending wtk-terra\src\org\apache\pivot\wtk\skin\terra\TerraMenuSkin.java Sending wtk-terra\src\org\apache\pivot\wtk\skin\terra\TerraPaletteSkin.java Sending wtk-terra\src\org\apache\pivot\wtk\skin\terra\TerraRadioButtonSkin.java Sending wtk-terra\src\org\apache\pivot\wtk\skin\terra\TerraSheetSkin.java Transmitting file data .done Committing transaction... Committed revision 1864994. > Regularize ColorUtilities methods > - > > Key: PIVOT-1046 > URL: https://issues.apache.org/jira/browse/PIVOT-1046 > Project: Pivot > Issue Type: Improvement > Components: wtk >Reporter: Roger Whitcomb >Assignee: Roger Whitcomb >Priority: Minor > > The method names in ColorUtilities are a bit verbose, and not regular (in > that there is a method to add transparency, but not one to take it away). > I propose to deprecate "setTransparencyInColor" and add "toTransparentColor" > which does the same thing with a "better" name. Then propose adding > "toSolidColor" as the obverse. This will regularize the functions in here > better, while still leaving the old method (deprecated) for backward > compatibility. > Next step would be changing all the callers to use the new method(s). -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Updated] (PIVOT-1045) Refactor read-only classes to use a common abstract class to reduce code
[ https://issues.apache.org/jira/browse/PIVOT-1045?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Roger Whitcomb updated PIVOT-1045: -- Description: All of the "read-only" collection classes (such as ArrayAdapter, EnumList, ImmutableList) share the concept that "add", "insert", "remove", etc. all throw an exception because they are unsupported in a read-only collection. It would reduce code and expose the common functionality if they were all implemented on top of a single abstract class that provides a uniform implementation of these unsupported methods. I propose to implement a ReadOnlySequence class that does this and refactor all other existing places (at least) with the common subclass. was: All of the "read-only" collections (such as ArrayAdapter, EnumList, ImmutableList) share the concept that "add", "insert", "remove", etc. all throw an exception because they are unsupported in a read-only collection. It would reduce code and expose the common functionality if they were all implemented on top of a single abstract class the provides a uniform implementation of these unsupported methods. I propose to implement a ReadOnlySequence class that does this and refactor all other existing places (at least) with the common subclass. > Refactor read-only classes to use a common abstract class to reduce code > > > Key: PIVOT-1045 > URL: https://issues.apache.org/jira/browse/PIVOT-1045 > Project: Pivot > Issue Type: Improvement > Components: core-collections >Reporter: Roger Whitcomb >Assignee: Roger Whitcomb >Priority: Minor > > All of the "read-only" collection classes (such as ArrayAdapter, EnumList, > ImmutableList) share the concept that "add", "insert", "remove", etc. all > throw an exception because they are unsupported in a read-only collection. It > would reduce code and expose the common functionality if they were all > implemented on top of a single abstract class that provides a uniform > implementation of these unsupported methods. > I propose to implement a ReadOnlySequence class that does this and refactor > all other existing places (at least) with the common subclass. -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Updated] (PIVOT-1045) Refactor read-only classes to use a common abstract class to reduce code
[ https://issues.apache.org/jira/browse/PIVOT-1045?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Roger Whitcomb updated PIVOT-1045: -- Description: All of the "read-only" collection classes (such as ArrayAdapter, EnumList, ImmutableList) share the concept that "add", "insert", "remove", etc. all throw exceptions because they are unsupported in a read-only collection. It would reduce code and expose the common functionality if they were all implemented on top of a single abstract class that provides a uniform implementation of these unsupported methods. I propose to implement a ReadOnlySequence class that does this and refactor all other existing places (at least) with the common subclass. was: All of the "read-only" collection classes (such as ArrayAdapter, EnumList, ImmutableList) share the concept that "add", "insert", "remove", etc. all throw an exception because they are unsupported in a read-only collection. It would reduce code and expose the common functionality if they were all implemented on top of a single abstract class that provides a uniform implementation of these unsupported methods. I propose to implement a ReadOnlySequence class that does this and refactor all other existing places (at least) with the common subclass. > Refactor read-only classes to use a common abstract class to reduce code > > > Key: PIVOT-1045 > URL: https://issues.apache.org/jira/browse/PIVOT-1045 > Project: Pivot > Issue Type: Improvement > Components: core-collections >Reporter: Roger Whitcomb >Assignee: Roger Whitcomb >Priority: Minor > > All of the "read-only" collection classes (such as ArrayAdapter, EnumList, > ImmutableList) share the concept that "add", "insert", "remove", etc. all > throw exceptions because they are unsupported in a read-only collection. It > would reduce code and expose the common functionality if they were all > implemented on top of a single abstract class that provides a uniform > implementation of these unsupported methods. > I propose to implement a ReadOnlySequence class that does this and refactor > all other existing places (at least) with the common subclass. -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Created] (PIVOT-1046) Regularize ColorUtilities methods
Roger Whitcomb created PIVOT-1046: - Summary: Regularize ColorUtilities methods Key: PIVOT-1046 URL: https://issues.apache.org/jira/browse/PIVOT-1046 Project: Pivot Issue Type: Improvement Components: wtk Reporter: Roger Whitcomb Assignee: Roger Whitcomb The method names in ColorUtilities are a bit verbose, and not regular (in that there is a method to add transparency, but not one to take it away). I propose to deprecate "setTransparencyInColor" and add "toTransparentColor" which does the same thing with a "better" name. Then propose adding "toSolidColor" as the obverse. This will regularize the functions in here better, while still leaving the old method (deprecated) for backward compatibility. Next step would be changing all the callers to use the new method(s). -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Commented] (PIVOT-1045) Refactor read-only classes to use a common abstract class to reduce code
[ https://issues.apache.org/jira/browse/PIVOT-1045?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16905627#comment-16905627 ] Roger Whitcomb commented on PIVOT-1045: --- First iteration: Sending core\src\org\apache\pivot\collections\ArrayAdapter.java Sending core\src\org\apache\pivot\collections\ArrayList.java Sending core\src\org\apache\pivot\collections\EnumList.java Adding core\src\org\apache\pivot\collections\ReadOnlySequence.java Sending core\src\org\apache\pivot\collections\immutable\ImmutableList.java Sending core\test\org\apache\pivot\collections\test\ArrayListTest.java Sending wtk\src\org\apache\pivot\wtk\content\NumericSpinnerData.java Transmitting file data ...done Committing transaction... Committed revision 1864990. > Refactor read-only classes to use a common abstract class to reduce code > > > Key: PIVOT-1045 > URL: https://issues.apache.org/jira/browse/PIVOT-1045 > Project: Pivot > Issue Type: Improvement > Components: core-collections >Reporter: Roger Whitcomb >Assignee: Roger Whitcomb >Priority: Minor > > All of the "read-only" collections (such as ArrayAdapter, EnumList, > ImmutableList) share the concept that "add", "insert", "remove", etc. all > throw an exception because they are unsupported in a read-only collection. It > would reduce code and expose the common functionality if they were all > implemented on top of a single abstract class the provides a uniform > implementation of these unsupported methods. > I propose to implement a ReadOnlySequence class that does this and refactor > all other existing places (at least) with the common subclass. -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Created] (PIVOT-1045) Refactor read-only classes to use a common abstract class to reduce code
Roger Whitcomb created PIVOT-1045: - Summary: Refactor read-only classes to use a common abstract class to reduce code Key: PIVOT-1045 URL: https://issues.apache.org/jira/browse/PIVOT-1045 Project: Pivot Issue Type: Improvement Components: core-collections Reporter: Roger Whitcomb Assignee: Roger Whitcomb All of the "read-only" collections (such as ArrayAdapter, EnumList, ImmutableList) share the concept that "add", "insert", "remove", etc. all throw an exception because they are unsupported in a read-only collection. It would reduce code and expose the common functionality if they were all implemented on top of a single abstract class the provides a uniform implementation of these unsupported methods. I propose to implement a ReadOnlySequence class that does this and refactor all other existing places (at least) with the common subclass. -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Commented] (PIVOT-1044) Avoid using FileInputStream / FileOutputStream to avoid GC issues with finalizer
[ https://issues.apache.org/jira/browse/PIVOT-1044?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16862528#comment-16862528 ] Roger Whitcomb commented on PIVOT-1044: --- One more file fixed: Sending tutorials\src\org\apache\pivot\tutorials\bxmlexplorer\BXMLExplorerDocument.java Transmitting file data .done Committing transaction... Committed revision 1861203. > Avoid using FileInputStream / FileOutputStream to avoid GC issues with > finalizer > > > Key: PIVOT-1044 > URL: https://issues.apache.org/jira/browse/PIVOT-1044 > Project: Pivot > Issue Type: Improvement > Components: core, web >Reporter: Roger Whitcomb >Assignee: Roger Whitcomb >Priority: Minor > Fix For: 2.1.0 > > > From this blog post (and similar) > ([https://www.cloudbees.com/blog/fileinputstream-fileoutputstream-considered-harmful)] > as well as pending changes to Ant ([https://github.com/apache/ant/pull/77)] > it seems wise to change these uses, which are just in a couple of places: > FileSerializer and QueryServlet (and some demos, but those don't seem as > important as "core" classes). -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (PIVOT-1032) Implement "checkstyle" for builds and make changes to bring code into better compliance
[ https://issues.apache.org/jira/browse/PIVOT-1032?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16862525#comment-16862525 ] Roger Whitcomb commented on PIVOT-1032: --- A few tiny changes: Sending demos\src\org\apache\pivot\demos\dnd\FileDropTargetDemo.java Sending demos\src\org\apache\pivot\demos\xml\XMLViewer.java Sending wtk\src\org\apache\pivot\wtk\media\BufferedImageSerializer.java Transmitting file data ...done Committing transaction... Committed revision 1861202. > Implement "checkstyle" for builds and make changes to bring code into better > compliance > --- > > Key: PIVOT-1032 > URL: https://issues.apache.org/jira/browse/PIVOT-1032 > Project: Pivot > Issue Type: Improvement >Reporter: Roger Whitcomb >Assignee: Roger Whitcomb >Priority: Minor > Attachments: 1032.diffs.txt > > > I thought it would be interesting, in addition to the "trim-whitespace" task > already implemented, to do some sort of "checkstyle" processing to evaluate > all the code to see where there might be changes to make the code more robust > and a better example of "canonical" Java style. > I hesitate to expect that we could address everything (or indeed whether we > *should*), but there might be things that would make the code better and > easier to read and maintain, and wouldn't take much effort. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (PIVOT-1032) Implement "checkstyle" for builds and make changes to bring code into better compliance
[ https://issues.apache.org/jira/browse/PIVOT-1032?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16862268#comment-16862268 ] Roger Whitcomb commented on PIVOT-1032: --- Get rid of final HideUtilityClassConstructor style errors: Sending tests\src\org\apache\pivot\tests\BXMLDictionaryTest.java Sending tests\src\org\apache\pivot\tests\EnumBeanTest.java Sending tests\src\org\apache\pivot\tests\JSONBeanTest.java Sending tests\src\org\apache\pivot\tests\MessageBusTest.java Sending tests\src\org\apache\pivot\tests\ResultListTest.java Sending tests\src\org\apache\pivot\tests\issues\Pivot751WithoutGUI.java Transmitting file data ..done Committing transaction... Committed revision 1861148. > Implement "checkstyle" for builds and make changes to bring code into better > compliance > --- > > Key: PIVOT-1032 > URL: https://issues.apache.org/jira/browse/PIVOT-1032 > Project: Pivot > Issue Type: Improvement >Reporter: Roger Whitcomb >Assignee: Roger Whitcomb >Priority: Minor > Attachments: 1032.diffs.txt > > > I thought it would be interesting, in addition to the "trim-whitespace" task > already implemented, to do some sort of "checkstyle" processing to evaluate > all the code to see where there might be changes to make the code more robust > and a better example of "canonical" Java style. > I hesitate to expect that we could address everything (or indeed whether we > *should*), but there might be things that would make the code better and > easier to read and maintain, and wouldn't take much effort. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (PIVOT-1032) Implement "checkstyle" for builds and make changes to bring code into better compliance
[ https://issues.apache.org/jira/browse/PIVOT-1032?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16857008#comment-16857008 ] Roger Whitcomb commented on PIVOT-1032: --- Trying to get one more file completely clean (not quite there though): Sending wtk\src\org\apache\pivot\wtk\GraphicsUtilities.java Transmitting file data .done Committing transaction... Committed revision 1860685. > Implement "checkstyle" for builds and make changes to bring code into better > compliance > --- > > Key: PIVOT-1032 > URL: https://issues.apache.org/jira/browse/PIVOT-1032 > Project: Pivot > Issue Type: Improvement >Reporter: Roger Whitcomb >Assignee: Roger Whitcomb >Priority: Minor > Attachments: 1032.diffs.txt > > > I thought it would be interesting, in addition to the "trim-whitespace" task > already implemented, to do some sort of "checkstyle" processing to evaluate > all the code to see where there might be changes to make the code more robust > and a better example of "canonical" Java style. > I hesitate to expect that we could address everything (or indeed whether we > *should*), but there might be things that would make the code better and > easier to read and maintain, and wouldn't take much effort. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (PIVOT-1032) Implement "checkstyle" for builds and make changes to bring code into better compliance
[ https://issues.apache.org/jira/browse/PIVOT-1032?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16856922#comment-16856922 ] Roger Whitcomb commented on PIVOT-1032: --- Some EmptyBlock and NestedBlock problems: Sending wtk\src\org\apache\pivot\wtk\DesktopApplicationContext.java Sending wtk\src\org\apache\pivot\wtk\GraphicsUtilities.java Sending wtk\src\org\apache\pivot\wtk\ListView.java Transmitting file data ...done Committing transaction... Committed revision 1860674. > Implement "checkstyle" for builds and make changes to bring code into better > compliance > --- > > Key: PIVOT-1032 > URL: https://issues.apache.org/jira/browse/PIVOT-1032 > Project: Pivot > Issue Type: Improvement >Reporter: Roger Whitcomb >Assignee: Roger Whitcomb >Priority: Minor > Attachments: 1032.diffs.txt > > > I thought it would be interesting, in addition to the "trim-whitespace" task > already implemented, to do some sort of "checkstyle" processing to evaluate > all the code to see where there might be changes to make the code more robust > and a better example of "canonical" Java style. > I hesitate to expect that we could address everything (or indeed whether we > *should*), but there might be things that would make the code better and > easier to read and maintain, and wouldn't take much effort. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (PIVOT-1044) Avoid using FileInputStream / FileOutputStream to avoid GC issues with finalizer
[ https://issues.apache.org/jira/browse/PIVOT-1044?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16856920#comment-16856920 ] Roger Whitcomb commented on PIVOT-1044: --- Fixed the "core" (that is, non-demo or non-tutorial) classes: Sending core\src\org\apache\pivot\io\FileSerializer.java Sending web-server\src\org\apache\pivot\web\server\QueryServlet.java Transmitting file data ..done Committing transaction... Committed revision 1860673. > Avoid using FileInputStream / FileOutputStream to avoid GC issues with > finalizer > > > Key: PIVOT-1044 > URL: https://issues.apache.org/jira/browse/PIVOT-1044 > Project: Pivot > Issue Type: Improvement > Components: core, web >Reporter: Roger Whitcomb >Assignee: Roger Whitcomb >Priority: Minor > Fix For: 2.1.0 > > > From this blog post (and similar) > ([https://www.cloudbees.com/blog/fileinputstream-fileoutputstream-considered-harmful)] > as well as pending changes to Ant ([https://github.com/apache/ant/pull/77)] > it seems wise to change these uses, which are just in a couple of places: > FileSerializer and QueryServlet (and some demos, but those don't seem as > important as "core" classes). -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (PIVOT-1043) Investigate Java 11 compatibility
[ https://issues.apache.org/jira/browse/PIVOT-1043?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16791072#comment-16791072 ] Roger Whitcomb commented on PIVOT-1043: --- The replacements for the internal OSX APIs are documented here: http://openjdk.java.net/jeps/272 > Investigate Java 11 compatibility > - > > Key: PIVOT-1043 > URL: https://issues.apache.org/jira/browse/PIVOT-1043 > Project: Pivot > Issue Type: Bug >Reporter: Roger Whitcomb >Assignee: Roger Whitcomb >Priority: Major > Fix For: 2.1.0 > > > Trying to run a Pivot application under OSX using OpenJDK Java 11 version > gives this error on the console: > Unable to attach EAWT hooks: java.lang.ClassNotFoundException: > com.apple.eawt.ApplicationListener > Everything appeared to work correctly, so I'm thinking this API call can just > go away for Java 11. But it should be investigated. > Other things with Java 11 might come up too, so this is a placeholder for > them too. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (PIVOT-1027) Add an @UnsupportedOperation annotation that can be used to mark methods that always throw UnsupportedOperationException when called
[ https://issues.apache.org/jira/browse/PIVOT-1027?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16790899#comment-16790899 ] Roger Whitcomb commented on PIVOT-1027: --- Last of the changes: Sending core\src\org\apache\pivot\util\Resources.java Sending wtk\src\org\apache\pivot\wtk\LinkButton.java Sending wtk\src\org\apache\pivot\wtk\Menu.java Sending wtk\src\org\apache\pivot\wtk\MenuBar.java Sending wtk\src\org\apache\pivot\wtk\MenuButton.java Sending wtk\src\org\apache\pivot\wtk\Prompt.java Sending wtk\src\org\apache\pivot\wtk\RadioButton.java Sending wtk\src\org\apache\pivot\wtk\TabPane.java Sending wtk\src\org\apache\pivot\wtk\TablePane.java Sending wtk\src\org\apache\pivot\wtk\TableView.java Sending wtk\src\org\apache\pivot\wtk\TextArea.java Sending wtk\src\org\apache\pivot\wtk\Window.java Sending wtk\src\org\apache\pivot\wtk\content\TableViewMultiCellRenderer.java Sending wtk\src\org\apache\pivot\wtk\media\SVGDiagramSerializer.java Sending wtk\src\org\apache\pivot\wtk\skin\TextPaneSkinElementView.java Sending wtk\src\org\apache\pivot\wtk\text\ComponentNode.java Sending wtk\src\org\apache\pivot\wtk\text\Document.java Sending wtk\src\org\apache\pivot\wtk\text\Element.java Sending wtk\src\org\apache\pivot\wtk\text\ImageNode.java Sending wtk-terra\src\org\apache\pivot\wtk\skin\terra\TerraAccordionSkin.java Sending wtk-terra\src\org\apache\pivot\wtk\skin\terra\TerraCalendarSkin.java Sending wtk-terra\src\org\apache\pivot\wtk\skin\terra\TerraPanoramaSkin.java Sending wtk-terra\src\org\apache\pivot\wtk\skin\terra\TerraScrollBarSkin.java Transmitting file data ...done Committing transaction... Committed revision 1855341. Although, arguably, there could be more javadoc and better error messages. But at least the annotation is there now, and it shows up in the generated javadoc as a marker. > Add an @UnsupportedOperation annotation that can be used to mark methods that > always throw UnsupportedOperationException when called > > > Key: PIVOT-1027 > URL: https://issues.apache.org/jira/browse/PIVOT-1027 > Project: Pivot > Issue Type: Improvement > Components: core >Reporter: Roger Whitcomb >Assignee: Roger Whitcomb >Priority: Minor > > This can be used to annotate (primarily in Javadoc) those methods, presumable > defined by an interface so they must be implemented, but which make no sense > in the specific implementation. There are numerous examples, but a few > should suffice: > * NumericSpinnerData has a fixed range of values specified by the lower and > upper bounds, so the "remove(...)", "clear()", "add(...)", or "update(...)" > methods of the List interface don't apply. > * Various iterators backed by other lists (such as VisibleNodeIterator of > TerraTreeViewSkin) doesn't support the "remove(...)" method for whatever > reason, even though it is specified in the Iterator interface. > * TabButton (part of TerraTabPaneSkin) is a subclass of Button, but many > methods are unsupported because of its unique structure (such as > "setTriState", "setButtonData", etc.) > * ImageNode (one of the unique children of TextPane) always holds a single > image, so the "insertRange" and "removeRange" methods make no sense. > Note: this annotation does nothing, and is not retained at runtime, and > really should be in the Java language (see > [https://bugs.openjdk.java.net/browse/JDK-6447051] for instance), but it > makes documentation of unsupported operations a bit clearer at no real cost. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Closed] (PIVOT-1027) Add an @UnsupportedOperation annotation that can be used to mark methods that always throw UnsupportedOperationException when called
[ https://issues.apache.org/jira/browse/PIVOT-1027?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Roger Whitcomb closed PIVOT-1027. - Resolution: Fixed > Add an @UnsupportedOperation annotation that can be used to mark methods that > always throw UnsupportedOperationException when called > > > Key: PIVOT-1027 > URL: https://issues.apache.org/jira/browse/PIVOT-1027 > Project: Pivot > Issue Type: Improvement > Components: core >Reporter: Roger Whitcomb >Assignee: Roger Whitcomb >Priority: Minor > > This can be used to annotate (primarily in Javadoc) those methods, presumable > defined by an interface so they must be implemented, but which make no sense > in the specific implementation. There are numerous examples, but a few > should suffice: > * NumericSpinnerData has a fixed range of values specified by the lower and > upper bounds, so the "remove(...)", "clear()", "add(...)", or "update(...)" > methods of the List interface don't apply. > * Various iterators backed by other lists (such as VisibleNodeIterator of > TerraTreeViewSkin) doesn't support the "remove(...)" method for whatever > reason, even though it is specified in the Iterator interface. > * TabButton (part of TerraTabPaneSkin) is a subclass of Button, but many > methods are unsupported because of its unique structure (such as > "setTriState", "setButtonData", etc.) > * ImageNode (one of the unique children of TextPane) always holds a single > image, so the "insertRange" and "removeRange" methods make no sense. > Note: this annotation does nothing, and is not retained at runtime, and > really should be in the Java language (see > [https://bugs.openjdk.java.net/browse/JDK-6447051] for instance), but it > makes documentation of unsupported operations a bit clearer at no real cost. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (PIVOT-1027) Add an @UnsupportedOperation annotation that can be used to mark methods that always throw UnsupportedOperationException when called
[ https://issues.apache.org/jira/browse/PIVOT-1027?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16736274#comment-16736274 ] Roger Whitcomb commented on PIVOT-1027: --- Sending tutorials\src\org\apache\pivot\tutorials\stocktracker\ChangeMapping.java Transmitting file data .done Committing transaction... Committed revision 1850679. > Add an @UnsupportedOperation annotation that can be used to mark methods that > always throw UnsupportedOperationException when called > > > Key: PIVOT-1027 > URL: https://issues.apache.org/jira/browse/PIVOT-1027 > Project: Pivot > Issue Type: Improvement > Components: core >Reporter: Roger Whitcomb >Assignee: Roger Whitcomb >Priority: Minor > > This can be used to annotate (primarily in Javadoc) those methods, presumable > defined by an interface so they must be implemented, but which make no sense > in the specific implementation. There are numerous examples, but a few > should suffice: > * NumericSpinnerData has a fixed range of values specified by the lower and > upper bounds, so the "remove(...)", "clear()", "add(...)", or "update(...)" > methods of the List interface don't apply. > * Various iterators backed by other lists (such as VisibleNodeIterator of > TerraTreeViewSkin) doesn't support the "remove(...)" method for whatever > reason, even though it is specified in the Iterator interface. > * TabButton (part of TerraTabPaneSkin) is a subclass of Button, but many > methods are unsupported because of its unique structure (such as > "setTriState", "setButtonData", etc.) > * ImageNode (one of the unique children of TextPane) always holds a single > image, so the "insertRange" and "removeRange" methods make no sense. > Note: this annotation does nothing, and is not retained at runtime, and > really should be in the Java language (see > [https://bugs.openjdk.java.net/browse/JDK-6447051] for instance), but it > makes documentation of unsupported operations a bit clearer at no real cost. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (PIVOT-1027) Add an @UnsupportedOperation annotation that can be used to mark methods that always throw UnsupportedOperationException when called
[ https://issues.apache.org/jira/browse/PIVOT-1027?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16736273#comment-16736273 ] Roger Whitcomb commented on PIVOT-1027: --- More files updated: Sending core\src\org\apache\pivot\collections\ArrayAdapter.java Sending core\src\org\apache\pivot\xml\Element.java Sending tutorials\src\org\apache\pivot\tutorials\explorer\tools\EventLogger.java Sending tutorials\src\org\apache\pivot\tutorials\stocktracker\ValueMapping.java Sending tutorials\src\org\apache\pivot\tutorials\stocktracker\VolumeMapping.java Sending wtk\src\org\apache\pivot\wtk\Accordion.java Sending wtk\src\org\apache\pivot\wtk\Alert.java Sending wtk\src\org\apache\pivot\wtk\ApplicationContext.java Sending wtk\src\org\apache\pivot\wtk\Border.java Sending wtk\src\org\apache\pivot\wtk\CalendarButton.java Sending wtk\src\org\apache\pivot\wtk\ColorChooserButton.java Sending wtk\src\org\apache\pivot\wtk\Component.java Sending wtk\src\org\apache\pivot\wtk\Container.java Sending wtk\src\org\apache\pivot\wtk\Display.java Sending wtk\src\org\apache\pivot\wtk\Expander.java Sending wtk\src\org\apache\pivot\wtk\Form.java Sending wtk\src\org\apache\pivot\wtk\Frame.java Sending wtk\src\org\apache\pivot\wtk\GridPane.java Sending wtk-terra\src\org\apache\pivot\wtk\skin\terra\TerraTabPaneSkin.java Sending wtk-terra\src\org\apache\pivot\wtk\skin\terra\TerraTreeViewSkin.java Transmitting file data done Committing transaction... Committed revision 1850678. > Add an @UnsupportedOperation annotation that can be used to mark methods that > always throw UnsupportedOperationException when called > > > Key: PIVOT-1027 > URL: https://issues.apache.org/jira/browse/PIVOT-1027 > Project: Pivot > Issue Type: Improvement > Components: core >Reporter: Roger Whitcomb >Assignee: Roger Whitcomb >Priority: Minor > > This can be used to annotate (primarily in Javadoc) those methods, presumable > defined by an interface so they must be implemented, but which make no sense > in the specific implementation. There are numerous examples, but a few > should suffice: > * NumericSpinnerData has a fixed range of values specified by the lower and > upper bounds, so the "remove(...)", "clear()", "add(...)", or "update(...)" > methods of the List interface don't apply. > * Various iterators backed by other lists (such as VisibleNodeIterator of > TerraTreeViewSkin) doesn't support the "remove(...)" method for whatever > reason, even though it is specified in the Iterator interface. > * TabButton (part of TerraTabPaneSkin) is a subclass of Button, but many > methods are unsupported because of its unique structure (such as > "setTriState", "setButtonData", etc.) > * ImageNode (one of the unique children of TextPane) always holds a single > image, so the "insertRange" and "removeRange" methods make no sense. > Note: this annotation does nothing, and is not retained at runtime, and > really should be in the Java language (see > [https://bugs.openjdk.java.net/browse/JDK-6447051] for instance), but it > makes documentation of unsupported operations a bit clearer at no real cost. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (PIVOT-1044) Avoid using FileInputStream / FileOutputStream to avoid GC issues with finalizer
Roger Whitcomb created PIVOT-1044: - Summary: Avoid using FileInputStream / FileOutputStream to avoid GC issues with finalizer Key: PIVOT-1044 URL: https://issues.apache.org/jira/browse/PIVOT-1044 Project: Pivot Issue Type: Improvement Components: core, web Reporter: Roger Whitcomb Assignee: Roger Whitcomb Fix For: 2.1.0 >From this blog post (and similar) >([https://www.cloudbees.com/blog/fileinputstream-fileoutputstream-considered-harmful)] > as well as pending changes to Ant ([https://github.com/apache/ant/pull/77)] >it seems wise to change these uses, which are just in a couple of places: >FileSerializer and QueryServlet (and some demos, but those don't seem as >important as "core" classes). -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (PIVOT-1043) Investigate Java 11 compatibility
[ https://issues.apache.org/jira/browse/PIVOT-1043?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16667340#comment-16667340 ] Roger Whitcomb commented on PIVOT-1043: --- And a HUGE thing with Java 11 is that Nashorn scripting engine is scheduled to be removed soon, so we need to figure out how to deal with that. See [https://jaxenter.com/nashorn-javascript-engine-deprecated-145320.html] for instance. > Investigate Java 11 compatibility > - > > Key: PIVOT-1043 > URL: https://issues.apache.org/jira/browse/PIVOT-1043 > Project: Pivot > Issue Type: Bug >Reporter: Roger Whitcomb >Assignee: Roger Whitcomb >Priority: Major > Fix For: 2.1.0 > > > Trying to run a Pivot application under OSX using OpenJDK Java 11 version > gives this error on the console: > Unable to attach EAWT hooks: java.lang.ClassNotFoundException: > com.apple.eawt.ApplicationListener > Everything appeared to work correctly, so I'm thinking this API call can just > go away for Java 11. But it should be investigated. > Other things with Java 11 might come up too, so this is a placeholder for > them too. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (PIVOT-1042) Investigate support of surrogate pairs in all text processing
[ https://issues.apache.org/jira/browse/PIVOT-1042?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Roger Whitcomb updated PIVOT-1042: -- Description: According to PIVOT-850, most if not all the code that advances through text (such as for label sizing, drawing, etc.) uses CharSequence to do so (usually using "charAt()" method). This does not work correctly for surrogate pairs (such as emoji). And maybe the TextLayout stuff used by IME support needs tweaking as well This issue is meant to collect all the fixes / changes necessary so that emoji (or any surrogate pair characters) will work with all the Pivot text code. was: According to PIVOT-850, most if not all the code that advances through text (such as for label sizing, drawing, etc.) is use CharSequence to do so (usually using "charAt()" method). This does not work correctly for surrogate pairs (such as emoji). And maybe the TextLayout stuff used by IME support needs tweaking as well This issue is meant to collect all the fixes / changes necessary so that emoji (or any surrogate pair characters) will work with all the Pivot text code. > Investigate support of surrogate pairs in all text processing > - > > Key: PIVOT-1042 > URL: https://issues.apache.org/jira/browse/PIVOT-1042 > Project: Pivot > Issue Type: Bug > Components: wtk, wtk-terra, wtk-validation >Reporter: Roger Whitcomb >Assignee: Roger Whitcomb >Priority: Major > Fix For: 2.1.0 > > > According to PIVOT-850, most if not all the code that advances through text > (such as for label sizing, drawing, etc.) uses CharSequence to do so (usually > using "charAt()" method). This does not work correctly for surrogate pairs > (such as emoji). And maybe the TextLayout stuff used by IME support needs > tweaking as well > This issue is meant to collect all the fixes / changes necessary so that > emoji (or any surrogate pair characters) will work with all the Pivot text > code. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (PIVOT-1042) Investigate support of surrogate pairs in all text processing
[ https://issues.apache.org/jira/browse/PIVOT-1042?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16657247#comment-16657247 ] Roger Whitcomb commented on PIVOT-1042: --- Here is a good article from IBM about this issue and some methods to efficiently handle surrogate pairs: [https://www.ibm.com/developerworks/java/library/j-unicode/] > Investigate support of surrogate pairs in all text processing > - > > Key: PIVOT-1042 > URL: https://issues.apache.org/jira/browse/PIVOT-1042 > Project: Pivot > Issue Type: Bug > Components: wtk, wtk-terra, wtk-validation >Reporter: Roger Whitcomb >Assignee: Roger Whitcomb >Priority: Major > Fix For: 2.1.0 > > > According to PIVOT-850, most if not all the code that advances through text > (such as for label sizing, drawing, etc.) is use CharSequence to do so > (usually using "charAt()" method). This does not work correctly for > surrogate pairs (such as emoji). And maybe the TextLayout stuff used by IME > support needs tweaking as well > This issue is meant to collect all the fixes / changes necessary so that > emoji (or any surrogate pair characters) will work with all the Pivot text > code. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (PIVOT-1043) Investigate Java 11 compatibility
[ https://issues.apache.org/jira/browse/PIVOT-1043?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16657239#comment-16657239 ] Roger Whitcomb commented on PIVOT-1043: --- Same deprecation issues from Java 9 and 10 (and maybe more) are also present with Java 11 (the ongoing support version). > Investigate Java 11 compatibility > - > > Key: PIVOT-1043 > URL: https://issues.apache.org/jira/browse/PIVOT-1043 > Project: Pivot > Issue Type: Bug >Reporter: Roger Whitcomb >Assignee: Roger Whitcomb >Priority: Major > Fix For: 2.1.0 > > > Trying to run a Pivot application under OSX using OpenJDK Java 11 version > gives this error on the console: > Unable to attach EAWT hooks: java.lang.ClassNotFoundException: > com.apple.eawt.ApplicationListener > Everything appeared to work correctly, so I'm thinking this API call can just > go away for Java 11. But it should be investigated. > Other things with Java 11 might come up too, so this is a placeholder for > them too. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (PIVOT-1043) Investigate Java 11 compatibility
Roger Whitcomb created PIVOT-1043: - Summary: Investigate Java 11 compatibility Key: PIVOT-1043 URL: https://issues.apache.org/jira/browse/PIVOT-1043 Project: Pivot Issue Type: Bug Reporter: Roger Whitcomb Assignee: Roger Whitcomb Fix For: 2.1.0 Trying to run a Pivot application under OSX using OpenJDK Java 11 version gives this error on the console: Unable to attach EAWT hooks: java.lang.ClassNotFoundException: com.apple.eawt.ApplicationListener Everything appeared to work correctly, so I'm thinking this API call can just go away for Java 11. But it should be investigated. Other things with Java 11 might come up too, so this is a placeholder for them too. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (PIVOT-1042) Investigate support of surrogate pairs in all text processing
Roger Whitcomb created PIVOT-1042: - Summary: Investigate support of surrogate pairs in all text processing Key: PIVOT-1042 URL: https://issues.apache.org/jira/browse/PIVOT-1042 Project: Pivot Issue Type: Bug Components: wtk, wtk-terra, wtk-validation Reporter: Roger Whitcomb Assignee: Roger Whitcomb Fix For: 2.1.0 According to PIVOT-850, most if not all the code that advances through text (such as for label sizing, drawing, etc.) is use CharSequence to do so (usually using "charAt()" method). This does not work correctly for surrogate pairs (such as emoji). And maybe the TextLayout stuff used by IME support needs tweaking as well This issue is meant to collect all the fixes / changes necessary so that emoji (or any surrogate pair characters) will work with all the Pivot text code. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Closed] (PIVOT-1039) Address deprecation issues with Java 9 and 10
[ https://issues.apache.org/jira/browse/PIVOT-1039?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Roger Whitcomb closed PIVOT-1039. - Resolution: Fixed Fix Version/s: 2.1.0 > Address deprecation issues with Java 9 and 10 > - > > Key: PIVOT-1039 > URL: https://issues.apache.org/jira/browse/PIVOT-1039 > Project: Pivot > Issue Type: Improvement >Affects Versions: 2.1 >Reporter: Roger Whitcomb >Assignee: Roger Whitcomb >Priority: Minor > Fix For: 2.1.0 > > Attachments: java10.log > > > Compiling "trunk" with the latest JDK 10.0.2 yields a few places where > methods are being deprecated going forward. Suitable replacements that are > also backward compatible are available, so it seems reasonable to use those > and eliminate the deprecation warnings. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (PIVOT-1039) Address deprecation issues with Java 9 and 10
[ https://issues.apache.org/jira/browse/PIVOT-1039?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16611003#comment-16611003 ] Roger Whitcomb commented on PIVOT-1039: --- Fixed the warnings related to Class.newInstance(): Sending charts\src\org\apache\pivot\charts\ChartView.java Sending core\src\org\apache\pivot\beans\BXMLSerializer.java Sending core\src\org\apache\pivot\json\JSONSerializer.java Sending core\src\org\apache\pivot\serialization\CSVSerializer.java Sending core\src\org\apache\pivot\util\Service.java Sending wtk\src\org\apache\pivot\wtk\BrowserApplicationContext.java Sending wtk\src\org\apache\pivot\wtk\Component.java Sending wtk\src\org\apache\pivot\wtk\DesktopApplicationContext.java Transmitting file data done Committing transaction... Committed revision 1840595. The remaining warnings from Java 10 are all related to JApplet 'nother issue entirely. > Address deprecation issues with Java 9 and 10 > - > > Key: PIVOT-1039 > URL: https://issues.apache.org/jira/browse/PIVOT-1039 > Project: Pivot > Issue Type: Improvement >Affects Versions: 2.1 >Reporter: Roger Whitcomb >Assignee: Roger Whitcomb >Priority: Minor > Attachments: java10.log > > > Compiling "trunk" with the latest JDK 10.0.2 yields a few places where > methods are being deprecated going forward. Suitable replacements that are > also backward compatible are available, so it seems reasonable to use those > and eliminate the deprecation warnings. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Closed] (PIVOT-1040) Add a renderer for vertical buttons (image above the text)
[ https://issues.apache.org/jira/browse/PIVOT-1040?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Roger Whitcomb closed PIVOT-1040. - Resolution: Fixed > Add a renderer for vertical buttons (image above the text) > -- > > Key: PIVOT-1040 > URL: https://issues.apache.org/jira/browse/PIVOT-1040 > Project: Pivot > Issue Type: Improvement > Components: wtk >Reporter: Roger Whitcomb >Assignee: Roger Whitcomb >Priority: Trivial > Fix For: 2.1.0 > > Attachments: image-2018-08-13-11-00-26-767.png > > > The effect would be as shown: > !image-2018-08-13-11-00-26-767.png! -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Reopened] (PIVOT-1040) Add a renderer for vertical buttons (image above the text)
[ https://issues.apache.org/jira/browse/PIVOT-1040?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Roger Whitcomb reopened PIVOT-1040: --- > Add a renderer for vertical buttons (image above the text) > -- > > Key: PIVOT-1040 > URL: https://issues.apache.org/jira/browse/PIVOT-1040 > Project: Pivot > Issue Type: Improvement > Components: wtk >Reporter: Roger Whitcomb >Assignee: Roger Whitcomb >Priority: Trivial > Fix For: 2.1.0 > > Attachments: image-2018-08-13-11-00-26-767.png > > > The effect would be as shown: > !image-2018-08-13-11-00-26-767.png! -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (PIVOT-1040) Add a renderer for vertical buttons (image above the text)
[ https://issues.apache.org/jira/browse/PIVOT-1040?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Roger Whitcomb updated PIVOT-1040: -- Fix Version/s: 2.1.0 > Add a renderer for vertical buttons (image above the text) > -- > > Key: PIVOT-1040 > URL: https://issues.apache.org/jira/browse/PIVOT-1040 > Project: Pivot > Issue Type: Improvement > Components: wtk >Reporter: Roger Whitcomb >Assignee: Roger Whitcomb >Priority: Trivial > Fix For: 2.1.0 > > Attachments: image-2018-08-13-11-00-26-767.png > > > The effect would be as shown: > !image-2018-08-13-11-00-26-767.png! -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (PIVOT-1040) Add a renderer for vertical buttons (image above the text)
[ https://issues.apache.org/jira/browse/PIVOT-1040?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16610907#comment-16610907 ] Roger Whitcomb commented on PIVOT-1040: --- Adding tests\src\org\apache\pivot\tests\VerticalButtonTest.java Adding wtk\src\org\apache\pivot\wtk\content\VerticalButtonDataRenderer.java Transmitting file data ..done Committing transaction... Committed revision 1840591. > Add a renderer for vertical buttons (image above the text) > -- > > Key: PIVOT-1040 > URL: https://issues.apache.org/jira/browse/PIVOT-1040 > Project: Pivot > Issue Type: Improvement > Components: wtk >Reporter: Roger Whitcomb >Assignee: Roger Whitcomb >Priority: Trivial > Attachments: image-2018-08-13-11-00-26-767.png > > > The effect would be as shown: > !image-2018-08-13-11-00-26-767.png! -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Closed] (PIVOT-1040) Add a renderer for vertical buttons (image above the text)
[ https://issues.apache.org/jira/browse/PIVOT-1040?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Roger Whitcomb closed PIVOT-1040. - Resolution: Fixed > Add a renderer for vertical buttons (image above the text) > -- > > Key: PIVOT-1040 > URL: https://issues.apache.org/jira/browse/PIVOT-1040 > Project: Pivot > Issue Type: Improvement > Components: wtk >Reporter: Roger Whitcomb >Assignee: Roger Whitcomb >Priority: Trivial > Attachments: image-2018-08-13-11-00-26-767.png > > > The effect would be as shown: > !image-2018-08-13-11-00-26-767.png! -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (PIVOT-1027) Add an @UnsupportedOperation annotation that can be used to mark methods that always throw UnsupportedOperationException when called
[ https://issues.apache.org/jira/browse/PIVOT-1027?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16610903#comment-16610903 ] Roger Whitcomb commented on PIVOT-1027: --- Sending core\src\org\apache\pivot\util\ListenerList.java Transmitting file data .done Committing transaction... Committed revision 1840590. > Add an @UnsupportedOperation annotation that can be used to mark methods that > always throw UnsupportedOperationException when called > > > Key: PIVOT-1027 > URL: https://issues.apache.org/jira/browse/PIVOT-1027 > Project: Pivot > Issue Type: Improvement > Components: core >Reporter: Roger Whitcomb >Assignee: Roger Whitcomb >Priority: Minor > > This can be used to annotate (primarily in Javadoc) those methods, presumable > defined by an interface so they must be implemented, but which make no sense > in the specific implementation. There are numerous examples, but a few > should suffice: > * NumericSpinnerData has a fixed range of values specified by the lower and > upper bounds, so the "remove(...)", "clear()", "add(...)", or "update(...)" > methods of the List interface don't apply. > * Various iterators backed by other lists (such as VisibleNodeIterator of > TerraTreeViewSkin) doesn't support the "remove(...)" method for whatever > reason, even though it is specified in the Iterator interface. > * TabButton (part of TerraTabPaneSkin) is a subclass of Button, but many > methods are unsupported because of its unique structure (such as > "setTriState", "setButtonData", etc.) > * ImageNode (one of the unique children of TextPane) always holds a single > image, so the "insertRange" and "removeRange" methods make no sense. > Note: this annotation does nothing, and is not retained at runtime, and > really should be in the Java language (see > [https://bugs.openjdk.java.net/browse/JDK-6447051] for instance), but it > makes documentation of unsupported operations a bit clearer at no real cost. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (PIVOT-1027) Add an @UnsupportedOperation annotation that can be used to mark methods that always throw UnsupportedOperationException when called
[ https://issues.apache.org/jira/browse/PIVOT-1027?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16610888#comment-16610888 ] Roger Whitcomb commented on PIVOT-1027: --- Another whole set of these (and related) changes: Sending charts\src\org\apache\pivot\charts\ChartView.java Sending core\src\org\apache\pivot\beans\BXMLSerializer.java Sending core\src\org\apache\pivot\beans\BeanAdapter.java Sending core\src\org\apache\pivot\collections\ArrayAdapter.java Sending core\src\org\apache\pivot\collections\EnumList.java Sending core\src\org\apache\pivot\collections\EnumMap.java Sending core\src\org\apache\pivot\collections\EnumSet.java Sending core\src\org\apache\pivot\collections\Sequence.java Sending core\src\org\apache\pivot\collections\immutable\ImmutableList.java Sending core\src\org\apache\pivot\collections\immutable\ImmutableMap.java Sending core\src\org\apache\pivot\collections\immutable\ImmutableSet.java Sending core\src\org\apache\pivot\functional\monad\Option.java Sending core\src\org\apache\pivot\functional\monad\Try.java Sending core\src\org\apache\pivot\io\FileList.java Sending core\src\org\apache\pivot\io\FileObjectList.java Sending core\src\org\apache\pivot\sql\ResultList.java Sending core\src\org\apache\pivot\text\FileSizeFormat.java Sending core\src\org\apache\pivot\util\Resources.java Sending web-server\src\org\apache\pivot\web\server\QueryServlet.java Transmitting file data ...done Committing transaction... Committed revision 1840587. > Add an @UnsupportedOperation annotation that can be used to mark methods that > always throw UnsupportedOperationException when called > > > Key: PIVOT-1027 > URL: https://issues.apache.org/jira/browse/PIVOT-1027 > Project: Pivot > Issue Type: Improvement > Components: core >Reporter: Roger Whitcomb >Assignee: Roger Whitcomb >Priority: Minor > > This can be used to annotate (primarily in Javadoc) those methods, presumable > defined by an interface so they must be implemented, but which make no sense > in the specific implementation. There are numerous examples, but a few > should suffice: > * NumericSpinnerData has a fixed range of values specified by the lower and > upper bounds, so the "remove(...)", "clear()", "add(...)", or "update(...)" > methods of the List interface don't apply. > * Various iterators backed by other lists (such as VisibleNodeIterator of > TerraTreeViewSkin) doesn't support the "remove(...)" method for whatever > reason, even though it is specified in the Iterator interface. > * TabButton (part of TerraTabPaneSkin) is a subclass of Button, but many > methods are unsupported because of its unique structure (such as > "setTriState", "setButtonData", etc.) > * ImageNode (one of the unique children of TextPane) always holds a single > image, so the "insertRange" and "removeRange" methods make no sense. > Note: this annotation does nothing, and is not retained at runtime, and > really should be in the Java language (see > [https://bugs.openjdk.java.net/browse/JDK-6447051] for instance), but it > makes documentation of unsupported operations a bit clearer at no real cost. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Closed] (PIVOT-1034) Change ThemeNotFoundException to a subclass of Error
[ https://issues.apache.org/jira/browse/PIVOT-1034?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Roger Whitcomb closed PIVOT-1034. - Resolution: Fixed Fix Version/s: 2.1.0 > Change ThemeNotFoundException to a subclass of Error > > > Key: PIVOT-1034 > URL: https://issues.apache.org/jira/browse/PIVOT-1034 > Project: Pivot > Issue Type: Improvement > Components: wtk >Reporter: Roger Whitcomb >Assignee: Roger Whitcomb >Priority: Minor > Fix For: 2.1.0 > > > It seems like the ThemeNotFoundException is more akin to a Java "Error" than > a RuntimeException, because the user or program is not expected to be able to > recover from it. > Also, there are some error conditions in TerraTheme during initialization > that also are essentially the same thing (that is, a part of the theme > configuration is not available for some reason). These things also could > throw this ThemeNotFoundException. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (PIVOT-1039) Address deprecation issues with Java 9 and 10
[ https://issues.apache.org/jira/browse/PIVOT-1039?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16607347#comment-16607347 ] Roger Whitcomb commented on PIVOT-1039: --- Fix (some, most of?) the deprecation warnings due to "new Float", "new Long" and so forth: Sending core\src\org\apache\pivot\util\Version.java Sending core\test\org\apache\pivot\functional\monad\test\OptionTest.java Sending tests\src\org\apache\pivot\tests\TextInputValidatorTest.java Sending wtk\src\org\apache\pivot\wtk\content\LinkButtonDataRenderer.java Sending wtk\src\org\apache\pivot\wtk\content\MenuItemDataRenderer.java Sending wtk-terra\src\org\apache\pivot\wtk\skin\terra\TerraFrameSkin.java Transmitting file data ..done Committing transaction... Committed revision 1840311. > Address deprecation issues with Java 9 and 10 > - > > Key: PIVOT-1039 > URL: https://issues.apache.org/jira/browse/PIVOT-1039 > Project: Pivot > Issue Type: Improvement >Affects Versions: 2.1 >Reporter: Roger Whitcomb >Assignee: Roger Whitcomb >Priority: Minor > Attachments: java10.log > > > Compiling "trunk" with the latest JDK 10.0.2 yields a few places where > methods are being deprecated going forward. Suitable replacements that are > also backward compatible are available, so it seems reasonable to use those > and eliminate the deprecation warnings. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (PIVOT-1041) Add a Constants class as a place to store frequently used constant values
[ https://issues.apache.org/jira/browse/PIVOT-1041?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16590947#comment-16590947 ] Roger Whitcomb commented on PIVOT-1041: --- Put the constant values I could find right away into the Constants class: Sending core\src\org\apache\pivot\io\FileSerializer.java Sending core\src\org\apache\pivot\json\JSONSerializer.java Sending core\src\org\apache\pivot\serialization\ByteArraySerializer.java Sending core\src\org\apache\pivot\serialization\CSVSerializer.java Sending core\src\org\apache\pivot\serialization\StringSerializer.java Adding core\src\org\apache\pivot\util\Constants.java Sending core\src\org\apache\pivot\util\Resources.java Sending core\src\org\apache\pivot\util\Service.java Sending core\src\org\apache\pivot\xml\XMLSerializer.java Sending demos\src\org\apache\pivot\demos\suggest\SuggestionDemo.java Sending web\src\org\apache\pivot\web\Query.java Sending web-server\src\org\apache\pivot\web\server\QueryServlet.java Sending wtk\src\org\apache\pivot\wtk\BrowserApplicationContext.java Sending wtk\src\org\apache\pivot\wtk\text\PlainTextSerializer.java Transmitting file data ..done Committing transaction... Committed revision 1838770. > Add a Constants class as a place to store frequently used constant values > - > > Key: PIVOT-1041 > URL: https://issues.apache.org/jira/browse/PIVOT-1041 > Project: Pivot > Issue Type: Improvement > Components: core-util >Reporter: Roger Whitcomb >Assignee: Roger Whitcomb >Priority: Minor > > There are a number of strings and other constant (usually static final) > values that are scattered in multiple places, but with the same values. > These could meaningfully be put into a single place and referenced from there. > Examples include: > * int BUFFER_SIZE = 16384 (for BufferedReader, Writer) > * String HTTP_PROTOCOL, String HTTPS_PROTOCOL > * "UTF-8" or the UTF_8 charset > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (PIVOT-1041) Add a Constants class as a place to store frequently used constant values
Roger Whitcomb created PIVOT-1041: - Summary: Add a Constants class as a place to store frequently used constant values Key: PIVOT-1041 URL: https://issues.apache.org/jira/browse/PIVOT-1041 Project: Pivot Issue Type: Improvement Components: core-util Reporter: Roger Whitcomb Assignee: Roger Whitcomb There are a number of strings and other constant (usually static final) values that are scattered in multiple places, but with the same values. These could meaningfully be put into a single place and referenced from there. Examples include: * int BUFFER_SIZE = 16384 (for BufferedReader, Writer) * String HTTP_PROTOCOL, String HTTPS_PROTOCOL * "UTF-8" or the UTF_8 charset -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (PIVOT-1032) Implement "checkstyle" for builds and make changes to bring code into better compliance
[ https://issues.apache.org/jira/browse/PIVOT-1032?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16590444#comment-16590444 ] Roger Whitcomb commented on PIVOT-1032: --- Fix the rest of AvoidNestedBlocks errors (except for two, which were hard to get right without the nested blocks), as well as other errors in the affected files: Sending core/src/org/apache/pivot/xml/XMLSerializer.java Sending wtk/src/org/apache/pivot/wtk/ApplicationContext.java Sending wtk/src/org/apache/pivot/wtk/DesktopApplicationContext.java Sending wtk/src/org/apache/pivot/wtk/GraphicsUtilities.java Sending wtk/src/org/apache/pivot/wtk/ImageView.java Sending wtk/src/org/apache/pivot/wtk/ListView.java Sending wtk/src/org/apache/pivot/wtk/TableView.java Sending wtk/src/org/apache/pivot/wtk/effects/TagDecorator.java Sending wtk/src/org/apache/pivot/wtk/media/Picture.java Sending wtk/src/org/apache/pivot/wtk/skin/BoxPaneSkin.java Sending wtk/src/org/apache/pivot/wtk/skin/CalendarButtonSkin.java Sending wtk/src/org/apache/pivot/wtk/skin/CardPaneSkin.java Sending wtk/src/org/apache/pivot/wtk/skin/ContainerSkin.java Sending wtk/src/org/apache/pivot/wtk/skin/FlowPaneSkin.java Sending wtk-terra/src/org/apache/pivot/wtk/skin/terra/TerraAccordionSkin.java Sending wtk-terra/src/org/apache/pivot/wtk/skin/terra/TerraCalendarSkin.java Sending wtk-terra/src/org/apache/pivot/wtk/skin/terra/TerraFileBrowserSheetSkin.java Sending wtk-terra/src/org/apache/pivot/wtk/skin/terra/TerraFormSkin.java Sending wtk-terra/src/org/apache/pivot/wtk/skin/terra/TerraSplitPaneSkin.java Sending wtk-terra/src/org/apache/pivot/wtk/skin/terra/TerraSuggestionPopupSkin.java Sending wtk-terra/src/org/apache/pivot/wtk/skin/terra/TerraTabPaneSkin.java Sending wtk-terra/src/org/apache/pivot/wtk/skin/terra/TerraTableViewHeaderSkin.java Sending wtk-terra/src/org/apache/pivot/wtk/skin/terra/TerraTextInputSkin.java Sending wtk-terra/src/org/apache/pivot/wtk/skin/terra/TerraTreeViewSkin.java Sending wtk-terra/src/org/apache/pivot/wtk/skin/terra/TerraVFSBrowserSheetSkin.java Transmitting file data .done Committing transaction... Committed revision 1838738. > Implement "checkstyle" for builds and make changes to bring code into better > compliance > --- > > Key: PIVOT-1032 > URL: https://issues.apache.org/jira/browse/PIVOT-1032 > Project: Pivot > Issue Type: Improvement >Reporter: Roger Whitcomb >Assignee: Roger Whitcomb >Priority: Minor > Attachments: 1032.diffs.txt > > > I thought it would be interesting, in addition to the "trim-whitespace" task > already implemented, to do some sort of "checkstyle" processing to evaluate > all the code to see where there might be changes to make the code more robust > and a better example of "canonical" Java style. > I hesitate to expect that we could address everything (or indeed whether we > *should*), but there might be things that would make the code better and > easier to read and maintain, and wouldn't take much effort. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (PIVOT-1032) Implement "checkstyle" for builds and make changes to bring code into better compliance
[ https://issues.apache.org/jira/browse/PIVOT-1032?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16584459#comment-16584459 ] Roger Whitcomb commented on PIVOT-1032: --- Fixed the remaining LineLength errors, some AvoidNestedBlocks errors and many other (mostly non-final parameter errors) in these files: Sending charts/src/org/apache/pivot/charts/ChartView.java Sending core/src/org/apache/pivot/beans/BXMLSerializer.java Sending core/src/org/apache/pivot/collections/Sequence.java Sending core/src/org/apache/pivot/collections/adapter/ListAdapter.java Sending core/src/org/apache/pivot/collections/immutable/ImmutableList.java Sending core/src/org/apache/pivot/collections/immutable/ImmutableMap.java Sending core/src/org/apache/pivot/collections/immutable/ImmutableSet.java Sending core/src/org/apache/pivot/text/AttributedStringCharacterIterator.java Sending core/src/org/apache/pivot/util/CharUtils.java Sending core/src/org/apache/pivot/util/ImageUtils.java Sending core/src/org/apache/pivot/util/ImmutableIterator.java Sending core/src/org/apache/pivot/util/Utils.java Sending core/test/org/apache/pivot/util/test/CharUtilsTest.java Sending demos/src/org/apache/pivot/demos/roweditor/CurrencyValidator.java Sending demos/src/org/apache/pivot/demos/styles/ColorSchemeBuilderWindow.java Sending eclipse/src/org/apache/pivot/eclipse/PivotApplicationLaunchShortcut.java Sending eclipse/src/org/apache/pivot/eclipse/PivotScriptApplicationLaunchShortcut.java Sending tests/src/org/apache/pivot/tests/ApplicationWithPropertiesTest.java Sending tests/src/org/apache/pivot/tests/BXMLDictionaryTest.java Sending tests/src/org/apache/pivot/tests/FileBrowserWithCharsetTest.java Sending tests/src/org/apache/pivot/tests/LabelAntialiasTest.java Sending tests/src/org/apache/pivot/tests/SheetTest.java Sending tests/src/org/apache/pivot/tests/TextAreaConsoleTest.java Sending tests/src/org/apache/pivot/tests/issues/Pivot765.java Sending tests/src/org/apache/pivot/tests/issues/Pivot862.java Sending tutorials/src/org/apache/pivot/tutorials/KitchenSink.java Sending tutorials/src/org/apache/pivot/tutorials/explorer/tools/ComponentInspector.java Sending tutorials/src/org/apache/pivot/tutorials/webqueries/Expenses.java Sending wtk/src/org/apache/pivot/wtk/Accordion.java Sending wtk/src/org/apache/pivot/wtk/ApplicationContext.java Sending wtk/src/org/apache/pivot/wtk/CalendarButton.java Sending wtk/src/org/apache/pivot/wtk/ColorChooser.java Sending wtk/src/org/apache/pivot/wtk/ColorChooserButton.java Sending wtk/src/org/apache/pivot/wtk/ListButton.java Sending wtk/src/org/apache/pivot/wtk/SuggestionPopup.java Sending wtk/src/org/apache/pivot/wtk/TablePane.java Sending wtk/src/org/apache/pivot/wtk/TablePaneAttributeListener.java Sending wtk/src/org/apache/pivot/wtk/TableView.java Sending wtk/src/org/apache/pivot/wtk/TableViewHeader.java Sending wtk/src/org/apache/pivot/wtk/TextInputMethodListener.java Sending wtk/src/org/apache/pivot/wtk/Window.java Sending wtk/src/org/apache/pivot/wtk/skin/CalendarButtonSkin.java Sending wtk/src/org/apache/pivot/wtk/skin/CardPaneSkin.java Sending wtk/src/org/apache/pivot/wtk/skin/ColorChooserButtonSkin.java Sending wtk/src/org/apache/pivot/wtk/skin/LabelSkin.java Sending wtk/src/org/apache/pivot/wtk/skin/ListButtonSkin.java Sending wtk/src/org/apache/pivot/wtk/skin/NumberRulerSkin.java Sending wtk/src/org/apache/pivot/wtk/skin/ScrollPaneSkin.java Sending wtk/src/org/apache/pivot/wtk/skin/TextPaneSkin.java Sending wtk-terra/src/org/apache/pivot/wtk/skin/terra/TerraCalendarSkin.java Sending wtk-terra/src/org/apache/pivot/wtk/skin/terra/TerraColorChooserButtonSkin.java Sending wtk-terra/src/org/apache/pivot/wtk/skin/terra/TerraExpanderSkin.java Sending wtk-terra/src/org/apache/pivot/wtk/skin/terra/TerraFormSkin.java Sending wtk-terra/src/org/apache/pivot/wtk/skin/terra/TerraScrollBarSkin.java Sending wtk-terra/src/org/apache/pivot/wtk/skin/terra/TerraSplitPaneSkin.java Sending wtk-terra/src/org/apache/pivot/wtk/skin/terra/TerraSuggestionPopupSkin.java Sending wtk-terra/src/org/apache/pivot/wtk/skin/terra/TerraTabPaneSkin.java Sending wtk-terra/src/org/apache/pivot/wtk/skin/terra/TerraTreeViewSkin.java Sending wtk-terra/src/org/apache/pivot/wtk/skin/terra/TerraVFSBrowserSheetSkin.java Sending wtk-terra/src/org/apache/pivot/wtk/skin/terra/TerraVFSBrowserSkin.java Transmitting file data done Committing transaction... Committed revision 1838293. >
[jira] [Created] (PIVOT-1040) Add a renderer for vertical buttons (image above the text)
Roger Whitcomb created PIVOT-1040: - Summary: Add a renderer for vertical buttons (image above the text) Key: PIVOT-1040 URL: https://issues.apache.org/jira/browse/PIVOT-1040 Project: Pivot Issue Type: Improvement Components: wtk Reporter: Roger Whitcomb Assignee: Roger Whitcomb Attachments: image-2018-08-13-11-00-26-767.png The effect would be as shown: !image-2018-08-13-11-00-26-767.png! -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (PIVOT-1032) Implement "checkstyle" for builds and make changes to bring code into better compliance
[ https://issues.apache.org/jira/browse/PIVOT-1032?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16577802#comment-16577802 ] Roger Whitcomb commented on PIVOT-1032: --- Fix "HideUtilityClassConstructor" and the other errors (as much as useful) in those files also: Sending core/src/org/apache/pivot/util/MessageBus.java Sending core/src/org/apache/pivot/util/Service.java Sending core/src/org/apache/pivot/xml/XML.java Sending wtk/src/org/apache/pivot/wtk/FontUtilities.java Sending wtk/src/org/apache/pivot/wtk/Keyboard.java Sending wtk/src/org/apache/pivot/wtk/Mouse.java Transmitting file data ..done Committing transaction... Committed revision 1837916. > Implement "checkstyle" for builds and make changes to bring code into better > compliance > --- > > Key: PIVOT-1032 > URL: https://issues.apache.org/jira/browse/PIVOT-1032 > Project: Pivot > Issue Type: Improvement >Reporter: Roger Whitcomb >Assignee: Roger Whitcomb >Priority: Minor > Attachments: 1032.diffs.txt > > > I thought it would be interesting, in addition to the "trim-whitespace" task > already implemented, to do some sort of "checkstyle" processing to evaluate > all the code to see where there might be changes to make the code more robust > and a better example of "canonical" Java style. > I hesitate to expect that we could address everything (or indeed whether we > *should*), but there might be things that would make the code better and > easier to read and maintain, and wouldn't take much effort. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Closed] (PIVOT-1035) Add a real build number to the Pivot (internal) version
[ https://issues.apache.org/jira/browse/PIVOT-1035?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Roger Whitcomb closed PIVOT-1035. - Resolution: Fixed Having implemented what [~smartini] suggested as far as using the latest SVN revision number, I will close this issue as fixed. Feel free to reopen if anyone finds objection to this scheme. Thanks. > Add a real build number to the Pivot (internal) version > --- > > Key: PIVOT-1035 > URL: https://issues.apache.org/jira/browse/PIVOT-1035 > Project: Pivot > Issue Type: Improvement > Components: wtk >Reporter: Roger Whitcomb >Assignee: Roger Whitcomb >Priority: Minor > > Right now the internal Pivot version number looks like this: 2.1.0_00, where > the final "00" is always 00. It would be helpful if we could implement a > "real" build number to track changes during development (for instance). I'm > not sure how this should work, but beginning with the Ant "" > task might be a start. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (PIVOT-1032) Implement "checkstyle" for builds and make changes to bring code into better compliance
[ https://issues.apache.org/jira/browse/PIVOT-1032?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16577762#comment-16577762 ] Roger Whitcomb commented on PIVOT-1032: --- Finished the rest of the "Whitespace" errors and some other style errors in the smaller files: Sending core/src/org/apache/pivot/beans/BXMLSerializer.java Sending core/src/org/apache/pivot/collections/Dictionary.java Sending core/src/org/apache/pivot/text/CharSpan.java Sending core/src/org/apache/pivot/util/CharUtils.java Sending core/src/org/apache/pivot/util/ImageUtils.java Sending core/src/org/apache/pivot/util/Resources.java Sending core/src/org/apache/pivot/util/Utils.java Sending core/src/org/apache/pivot/util/Version.java Sending core/test/org/apache/pivot/json/test/JSONSerializerTest.java Sending core/test/org/apache/pivot/serialization/test/BinarySerializerTest.java Sending demos/src/org/apache/pivot/demos/rest/RESTDemoTest.java Sending eclipse/src/org/apache/pivot/eclipse/PivotApplicationLaunchShortcut.java Sending eclipse/src/org/apache/pivot/eclipse/PivotScriptApplicationLaunchShortcut.java Transmitting file data .done Committing transaction... Committed revision 1837911. Sending tests/src/org/apache/pivot/tests/CheckedListViewTest.java Sending tests/src/org/apache/pivot/tests/DataBindingTest.java Sending tests/src/org/apache/pivot/tests/LabelAntialiasTest.java Sending tests/src/org/apache/pivot/tests/NamespaceTest.java Sending tests/src/org/apache/pivot/tests/issues/Pivot738.java Sending tests/src/org/apache/pivot/tests/issues/Pivot765.java Sending tests/src/org/apache/pivot/tests/issues/Pivot800.java Sending tests/src/org/apache/pivot/tests/issues/Pivot811.java Sending tests/src/org/apache/pivot/tests/issues/pivot859/Pivot859.java Sending tests/src/org/apache/pivot/tests/issues/pivot948/Pivot948.java Sending tests/src/org/apache/pivot/tests/issues/pivot964/Pivot964Pivot.java Sending tests/src/org/apache/pivot/tests/issues/pivot965/Pivot965Main.java Sending tutorials/src/org/apache/pivot/tutorials/explorer/tools/EventLogger.java Sending tutorials/src/org/apache/pivot/tutorials/layout/Forms.java Transmitting file data ..done Committing transaction... Committed revision 1837912. Sending wtk/src/org/apache/pivot/wtk/Button.java Sending wtk/src/org/apache/pivot/wtk/Component.java Sending wtk/src/org/apache/pivot/wtk/Dimensions.java Sending wtk/src/org/apache/pivot/wtk/HyperlinkButton.java Sending wtk/src/org/apache/pivot/wtk/Label.java Sending wtk/src/org/apache/pivot/wtk/Limits.java Sending wtk/src/org/apache/pivot/wtk/Point.java Sending wtk/src/org/apache/pivot/wtk/ScriptApplication.java Sending wtk/src/org/apache/pivot/wtk/ScrollBar.java Sending wtk/src/org/apache/pivot/wtk/Span.java Sending wtk/src/org/apache/pivot/wtk/TextPane.java Sending wtk/src/org/apache/pivot/wtk/content/ListViewIndexBindMapping.java Sending wtk/src/org/apache/pivot/wtk/content/SpinnerIndexBindMapping.java Sending wtk/src/org/apache/pivot/wtk/skin/TextPaneSkin.java Sending wtk/src/org/apache/pivot/wtk/skin/TextPaneSkinNodeView.java Sending wtk/src/org/apache/pivot/wtk/skin/TextPaneSkinNumberedListView.java Sending wtk/src/org/apache/pivot/wtk/text/ComponentNode.java Sending wtk/src/org/apache/pivot/wtk/text/Element.java Sending wtk/src/org/apache/pivot/wtk/text/Paragraph.java Transmitting file data ...done Committing transaction... Committed revision 1837913. Sending wtk-terra/src/org/apache/pivot/wtk/skin/terra/TerraActivityIndicatorSkin.java Sending wtk-terra/src/org/apache/pivot/wtk/skin/terra/TerraAlertSkin.java Sending wtk-terra/src/org/apache/pivot/wtk/skin/terra/TerraCalendarButtonSkin.java Sending wtk-terra/src/org/apache/pivot/wtk/skin/terra/TerraCalendarSkin.java Sending wtk-terra/src/org/apache/pivot/wtk/skin/terra/TerraColorChooserButtonSkin.java Sending wtk-terra/src/org/apache/pivot/wtk/skin/terra/TerraExpanderSkin.java Sending wtk-terra/src/org/apache/pivot/wtk/skin/terra/TerraGaugeSkin.java Sending wtk-terra/src/org/apache/pivot/wtk/skin/terra/TerraListButtonSkin.java Sending wtk-terra/src/org/apache/pivot/wtk/skin/terra/TerraMenuBarSkin.java Sending wtk-terra/src/org/apache/pivot/wtk/skin/terra/TerraMenuButtonSkin.java Sending wtk-terra/src/org/apache/pivot/wtk/skin/terra/TerraMenuItemSkin.java Sending wtk-terra/src/org/apache/pivot/wtk/skin/terra/TerraPanoramaSkin.java Sending wtk-terra/src/org/apache/pivot/wtk/skin/terra/TerraPromptSkin.java Sending wtk-terra/src/org/apache/
[jira] [Comment Edited] (PIVOT-1035) Add a real build number to the Pivot (internal) version
[
https://issues.apache.org/jira/browse/PIVOT-1035?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16574866#comment-16574866
]
Roger Whitcomb edited comment on PIVOT-1035 at 8/9/18 1:53 PM:
---
Committed this change:
Sending build.xml
Transmitting file data .done
Committing transaction...
Committed revision 1837729.
So that the latest manifest information is now:
{{Manifest-Version : 1.0}}
{{Ant-Version : Apache Ant 1.10.5}}
{{Created-By : 10.0.2+13 ("Oracle Corporation")}}
{{Sealed : true}}
{{Specification-Title : Apache Pivot Core}}
{{Specification-Version : 2.1.0}}
{{Specification-Vendor : The Apache Software Foundation}}
{{Implementation-Vendor-Id : org.apache}}
{{Implementation-Vendor : The Apache Software Foundation}}
{{Implementation-Title : Apache Pivot Core}}
{{Implementation-Version : 2.1.0_1837729}}
{{Permissions : all-permissions}}
{{Codebase : *}}
{{Caller-Allowable-Codebase : *}}
{{Application-Library-Allowable-Codebase : *}}
was (Author: rwhitcomb):
Committed this change:
Sending build.xml
Transmitting file data .done
Committing transaction...
Committed revision 1837729.
> Add a real build number to the Pivot (internal) version
> ---
>
> Key: PIVOT-1035
> URL: https://issues.apache.org/jira/browse/PIVOT-1035
> Project: Pivot
> Issue Type: Improvement
> Components: wtk
>Reporter: Roger Whitcomb
>Assignee: Roger Whitcomb
>Priority: Minor
>
> Right now the internal Pivot version number looks like this: 2.1.0_00, where
> the final "00" is always 00. It would be helpful if we could implement a
> "real" build number to track changes during development (for instance). I'm
> not sure how this should work, but beginning with the Ant ""
> task might be a start.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (PIVOT-1035) Add a real build number to the Pivot (internal) version
[ https://issues.apache.org/jira/browse/PIVOT-1035?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16574866#comment-16574866 ] Roger Whitcomb commented on PIVOT-1035: --- Committed this change: Sending build.xml Transmitting file data .done Committing transaction... Committed revision 1837729. > Add a real build number to the Pivot (internal) version > --- > > Key: PIVOT-1035 > URL: https://issues.apache.org/jira/browse/PIVOT-1035 > Project: Pivot > Issue Type: Improvement > Components: wtk >Reporter: Roger Whitcomb >Assignee: Roger Whitcomb >Priority: Minor > > Right now the internal Pivot version number looks like this: 2.1.0_00, where > the final "00" is always 00. It would be helpful if we could implement a > "real" build number to track changes during development (for instance). I'm > not sure how this should work, but beginning with the Ant "" > task might be a start. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Comment Edited] (PIVOT-1035) Add a real build number to the Pivot (internal) version
[
https://issues.apache.org/jira/browse/PIVOT-1035?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16573779#comment-16573779
]
Roger Whitcomb edited comment on PIVOT-1035 at 8/8/18 8:03 PM:
---
What about using the "Last Changed Rev" from "svn" as the build number? This
makes a bit more sense (and is what [~smartini] suggested from the blog
earlier)? That rev can be traced to specific dates, files, issues, etc.
{{Index: build.xml}}
{{===}}
{{--- build.xml (revision 1837669)}}
{{+++ build.xml (working copy)}}
{{@@ -66,10 +66,23 @@}}
{{+ }}
{{+ }}
{{+ }}
{{+ }}
{{+ }}
{{+ }}
{{+ }}
{{+ }}
{{+ }}
{{+ }}
{{+ }}
{{+ }}
{{- }}
{{+ }}
{{+ }}{{}}
This produced a version string like this: 2.1.0_1837548 (which parses
correctly with Version.java)
was (Author: rwhitcomb):
What about using the "Last Changed Rev" from "svn" as the build number? This
makes a bit more sense (and is what [~smartini] suggested from the blog
earlier)? That rev can be traced to specific dates, files, issues, etc.
{{Index: build.xml}}
{{===}}
{{--- build.xml (revision 1837669)}}
{{+++ build.xml (working copy)}}
{{@@ -66,10 +66,23 @@}}
{{ }}
{{ }}
{{ }}
{{+ }}
{{+ }}
{{+ }}
{{+ }}
{{+ }}
{{+ }}
{{+ }}
{{+ }}
{{+ }}
{{+ }}
{{+ }}
{{+ }}
{{ }}
{{- }}
{{+ }}
{{ }}
{{ }}
{{+ }}{{}}
This produced a version string like this: 2.1.0_1837548 (which parses
correctly with Version.java)
> Add a real build number to the Pivot (internal) version
> ---
>
> Key: PIVOT-1035
> URL: https://issues.apache.org/jira/browse/PIVOT-1035
> Project: Pivot
> Issue Type: Improvement
> Components: wtk
>Reporter: Roger Whitcomb
>Assignee: Roger Whitcomb
>Priority: Minor
>
> Right now the internal Pivot version number looks like this: 2.1.0_00, where
> the final "00" is always 00. It would be helpful if we could implement a
> "real" build number to track changes during development (for instance). I'm
> not sure how this should work, but beginning with the Ant ""
> task might be a start.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (PIVOT-1035) Add a real build number to the Pivot (internal) version
[
https://issues.apache.org/jira/browse/PIVOT-1035?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16573779#comment-16573779
]
Roger Whitcomb commented on PIVOT-1035:
---
What about using the "Last Changed Rev" from "svn" as the build number? This
makes a bit more sense (and is what [~smartini] suggested from the blog
earlier)? That rev can be traced to specific dates, files, issues, etc.
{{Index: build.xml}}
{{===}}
{{--- build.xml (revision 1837669)}}
{{+++ build.xml (working copy)}}
{{@@ -66,10 +66,23 @@}}
{{ }}
{{ }}
{{ }}
{{+ }}
{{+ }}
{{+ }}
{{+ }}
{{+ }}
{{+ }}
{{+ }}
{{+ }}
{{+ }}
{{+ }}
{{+ }}
{{+ }}
{{ }}
{{- }}
{{+ }}
{{ }}
{{ }}
{{+ }}{{}}
This produced a version string like this: 2.1.0_1837548 (which parses
correctly with Version.java)
> Add a real build number to the Pivot (internal) version
> ---
>
> Key: PIVOT-1035
> URL: https://issues.apache.org/jira/browse/PIVOT-1035
> Project: Pivot
> Issue Type: Improvement
> Components: wtk
>Reporter: Roger Whitcomb
>Assignee: Roger Whitcomb
>Priority: Minor
>
> Right now the internal Pivot version number looks like this: 2.1.0_00, where
> the final "00" is always 00. It would be helpful if we could implement a
> "real" build number to track changes during development (for instance). I'm
> not sure how this should work, but beginning with the Ant ""
> task might be a start.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (PIVOT-1039) Address deprecation issues with Java 9 and 10
[ https://issues.apache.org/jira/browse/PIVOT-1039?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16570647#comment-16570647 ] Roger Whitcomb commented on PIVOT-1039: --- Fix style errors from last commit, and stuff related to Javadoc process: Sending build.xml Sending core\test\org\apache\pivot\util\test\VersionTest.java Sending web\src\org\apache\pivot\web\package.html Sending wtk-terra\src\org\apache\pivot\wtk\skin\terra\package.html Transmitting file data done Committing transaction... Committed revision 1837548. > Address deprecation issues with Java 9 and 10 > - > > Key: PIVOT-1039 > URL: https://issues.apache.org/jira/browse/PIVOT-1039 > Project: Pivot > Issue Type: Improvement >Affects Versions: 2.1 >Reporter: Roger Whitcomb >Assignee: Roger Whitcomb >Priority: Minor > Attachments: java10.log > > > Compiling "trunk" with the latest JDK 10.0.2 yields a few places where > methods are being deprecated going forward. Suitable replacements that are > also backward compatible are available, so it seems reasonable to use those > and eliminate the deprecation warnings. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (PIVOT-1039) Address deprecation issues with Java 9 and 10
[ https://issues.apache.org/jira/browse/PIVOT-1039?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16570438#comment-16570438 ] Roger Whitcomb commented on PIVOT-1039: --- Addressed the failure in "VersionTest" with Java 10: Sending core/src/org/apache/pivot/util/Version.java Sending core/test/org/apache/pivot/util/test/VersionTest.java Transmitting file data ..done Committing transaction... Committed revision 1837541. > Address deprecation issues with Java 9 and 10 > - > > Key: PIVOT-1039 > URL: https://issues.apache.org/jira/browse/PIVOT-1039 > Project: Pivot > Issue Type: Improvement >Affects Versions: 2.1 >Reporter: Roger Whitcomb >Assignee: Roger Whitcomb >Priority: Minor > Attachments: java10.log > > > Compiling "trunk" with the latest JDK 10.0.2 yields a few places where > methods are being deprecated going forward. Suitable replacements that are > also backward compatible are available, so it seems reasonable to use those > and eliminate the deprecation warnings. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (PIVOT-1039) Address deprecation issues with Java 9 and 10
[ https://issues.apache.org/jira/browse/PIVOT-1039?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16567539#comment-16567539 ] Roger Whitcomb commented on PIVOT-1039: --- The "java10.log" lists all the errors (one test failure) and warnings building with JDK 10. > Address deprecation issues with Java 9 and 10 > - > > Key: PIVOT-1039 > URL: https://issues.apache.org/jira/browse/PIVOT-1039 > Project: Pivot > Issue Type: Improvement >Affects Versions: 2.1 >Reporter: Roger Whitcomb >Assignee: Roger Whitcomb >Priority: Minor > Attachments: java10.log > > > Compiling "trunk" with the latest JDK 10.0.2 yields a few places where > methods are being deprecated going forward. Suitable replacements that are > also backward compatible are available, so it seems reasonable to use those > and eliminate the deprecation warnings. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Updated] (PIVOT-1039) Address deprecation issues with Java 9 and 10
[ https://issues.apache.org/jira/browse/PIVOT-1039?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Roger Whitcomb updated PIVOT-1039: -- Attachment: java10.log > Address deprecation issues with Java 9 and 10 > - > > Key: PIVOT-1039 > URL: https://issues.apache.org/jira/browse/PIVOT-1039 > Project: Pivot > Issue Type: Improvement >Affects Versions: 2.1 >Reporter: Roger Whitcomb >Assignee: Roger Whitcomb >Priority: Minor > Attachments: java10.log > > > Compiling "trunk" with the latest JDK 10.0.2 yields a few places where > methods are being deprecated going forward. Suitable replacements that are > also backward compatible are available, so it seems reasonable to use those > and eliminate the deprecation warnings. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Closed] (PIVOT-1036) Add a Japanese translation of Pivot
[ https://issues.apache.org/jira/browse/PIVOT-1036?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Roger Whitcomb closed PIVOT-1036. - Resolution: Fixed Our translators are happy with the text, so closing this as done. > Add a Japanese translation of Pivot > --- > > Key: PIVOT-1036 > URL: https://issues.apache.org/jira/browse/PIVOT-1036 > Project: Pivot > Issue Type: Improvement > Components: wtk-terra >Reporter: Roger Whitcomb >Assignee: Roger Whitcomb >Priority: Minor > > Our product is being translated into Japanese, and for that we will need > Japanese translations of the various resource files (Prompt, Alert, file > dialogs, etc.) -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (PIVOT-1039) Address deprecation issues with Java 9 and 10
Roger Whitcomb created PIVOT-1039: - Summary: Address deprecation issues with Java 9 and 10 Key: PIVOT-1039 URL: https://issues.apache.org/jira/browse/PIVOT-1039 Project: Pivot Issue Type: Improvement Affects Versions: 2.1 Reporter: Roger Whitcomb Assignee: Roger Whitcomb Compiling "trunk" with the latest JDK 10.0.2 yields a few places where methods are being deprecated going forward. Suitable replacements that are also backward compatible are available, so it seems reasonable to use those and eliminate the deprecation warnings. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (PIVOT-1036) Add a Japanese translation of Pivot
[ https://issues.apache.org/jira/browse/PIVOT-1036?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16519672#comment-16519672 ] Roger Whitcomb commented on PIVOT-1036: --- Added the translated Japanese resources: Adding tutorials\src\org\apache\pivot\tutorials\localization\Localization_ja.json Adding tutorials\src\org\apache\pivot\tutorials\stocktracker\StockTrackerWindow_ja.json Adding wtk\src\org\apache\pivot\wtk\Alert_ja.json Adding wtk\src\org\apache\pivot\wtk\Prompt_ja.json Adding wtk-terra\src\org\apache\pivot\wtk\skin\terra\TerraCalendarSkin_ja.json Adding wtk-terra\src\org\apache\pivot\wtk\skin\terra\TerraFileBrowserSheetSkin_ja.json Adding wtk-terra\src\org\apache\pivot\wtk\skin\terra\TerraFileBrowserSkin_ja.json Adding wtk-terra\src\org\apache\pivot\wtk\skin\terra\TerraVFSBrowserSheetSkin_ja.json Adding wtk-terra\src\org\apache\pivot\wtk\skin\terra\TerraVFSBrowserSkin_ja.json Transmitting file data .done Committing transaction... Committed revision 1834042. > Add a Japanese translation of Pivot > --- > > Key: PIVOT-1036 > URL: https://issues.apache.org/jira/browse/PIVOT-1036 > Project: Pivot > Issue Type: Improvement > Components: wtk-terra >Reporter: Roger Whitcomb >Assignee: Roger Whitcomb >Priority: Minor > > Our product is being translated into Japanese, and for that we will need > Japanese translations of the various resource files (Prompt, Alert, file > dialogs, etc.) -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Closed] (PIVOT-1038) Allow override of default Locale for all internal resources
[ https://issues.apache.org/jira/browse/PIVOT-1038?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Roger Whitcomb closed PIVOT-1038. - Resolution: Not A Problem Just realized this is not necessary, since any application can call "Locale.setDefault(...)" which has the same effect. So, closing the issue. > Allow override of default Locale for all internal resources > --- > > Key: PIVOT-1038 > URL: https://issues.apache.org/jira/browse/PIVOT-1038 > Project: Pivot > Issue Type: Improvement > Components: core, wtk, wtk-terra >Reporter: Roger Whitcomb >Assignee: Roger Whitcomb >Priority: Minor > > The Resources class, and therefore all our internal resources, depend on the > default platform Locale. Sometimes (and it is so in our application) we want > to use a non-default Locale to display an internationalized version of the > application. To accomplish this we would need to specify an override of the > default platform locale that can be set and used everywhere. > I propose to add a field to Platform for this purpose, and replace calls to > "Locale.getDefault()" with "Platform.getDefaultLocale()". -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (PIVOT-1038) Allow override of default Locale for all internal resources
Roger Whitcomb created PIVOT-1038: - Summary: Allow override of default Locale for all internal resources Key: PIVOT-1038 URL: https://issues.apache.org/jira/browse/PIVOT-1038 Project: Pivot Issue Type: Improvement Components: core, wtk, wtk-terra Reporter: Roger Whitcomb Assignee: Roger Whitcomb The Resources class, and therefore all our internal resources, depend on the default platform Locale. Sometimes (and it is so in our application) we want to use a non-default Locale to display an internationalized version of the application. To accomplish this we would need to specify an override of the default platform locale that can be set and used everywhere. I propose to add a field to Platform for this purpose, and replace calls to "Locale.getDefault()" with "Platform.getDefaultLocale()". -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Closed] (PIVOT-1037) Removing tree nodes before they are visible will cause exceptions
[ https://issues.apache.org/jira/browse/PIVOT-1037?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Roger Whitcomb closed PIVOT-1037. - Resolution: Fixed Fix Version/s: 2.1.0 Closing pending further testing to verify, but the obvious exceptions shown above are gone now. > Removing tree nodes before they are visible will cause exceptions > - > > Key: PIVOT-1037 > URL: https://issues.apache.org/jira/browse/PIVOT-1037 > Project: Pivot > Issue Type: Bug > Components: wtk-terra >Reporter: Roger Whitcomb >Assignee: Roger Whitcomb >Priority: Minor > Fix For: 2.1.0 > > > We build a tree, but don't expand it all initially. User can do things that > cause the tree to be rebuilt before the child nodes have become visible. > This leads to exceptions such as: > java.lang.IndexOutOfBoundsException: Index 1 out of bounds [0,0]. > STACK TRACE: > at org.apache.pivot.util.Utils.checkIndexBounds(Utils.java:246) > at org.apache.pivot.collections.ArrayList.get(ArrayList.java:431) > at > org.apache.pivot.wtk.skin.terra.TerraTreeViewSkin.removeVisibleNodes(TerraTreeViewSkin.java:1358) > at > org.apache.pivot.wtk.skin.terra.TerraTreeViewSkin.nodesRemoved(TerraTreeViewSkin.java:2064) > at > org.apache.pivot.wtk.TreeViewNodeListener$Listeners.lambda$nodesRemoved$1(TreeViewNodeListener.java:38) > at java.lang.Iterable.forEach(Iterable.java:75) > at > org.apache.pivot.wtk.TreeViewNodeListener$Listeners.nodesRemoved(TreeViewNodeListener.java:38) > at org.apache.pivot.wtk.TreeView$BranchHandler.itemsRemoved(TreeView.java:365) > at > org.apache.pivot.collections.List$ListListenerList.lambda$itemsRemoved$1(List.java:57) > at java.lang.Iterable.forEach(Iterable.java:75) > at > org.apache.pivot.collections.List$ListListenerList.itemsRemoved(List.java:57) > at org.apache.pivot.wtk.content.TreeBranch.remove(TreeBranch.java:156) -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (PIVOT-1037) Removing tree nodes before they are visible will cause exceptions
[ https://issues.apache.org/jira/browse/PIVOT-1037?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16518578#comment-16518578 ] Roger Whitcomb commented on PIVOT-1037: --- Should be fixed now: Sending wtk-terra\src\org\apache\pivot\wtk\skin\terra\TerraTreeViewSkin.java Transmitting file data .done Committing transaction... Committed revision 1833950. > Removing tree nodes before they are visible will cause exceptions > - > > Key: PIVOT-1037 > URL: https://issues.apache.org/jira/browse/PIVOT-1037 > Project: Pivot > Issue Type: Bug > Components: wtk-terra >Reporter: Roger Whitcomb >Assignee: Roger Whitcomb >Priority: Minor > > We build a tree, but don't expand it all initially. User can do things that > cause the tree to be rebuilt before the child nodes have become visible. > This leads to exceptions such as: > java.lang.IndexOutOfBoundsException: Index 1 out of bounds [0,0]. > STACK TRACE: > at org.apache.pivot.util.Utils.checkIndexBounds(Utils.java:246) > at org.apache.pivot.collections.ArrayList.get(ArrayList.java:431) > at > org.apache.pivot.wtk.skin.terra.TerraTreeViewSkin.removeVisibleNodes(TerraTreeViewSkin.java:1358) > at > org.apache.pivot.wtk.skin.terra.TerraTreeViewSkin.nodesRemoved(TerraTreeViewSkin.java:2064) > at > org.apache.pivot.wtk.TreeViewNodeListener$Listeners.lambda$nodesRemoved$1(TreeViewNodeListener.java:38) > at java.lang.Iterable.forEach(Iterable.java:75) > at > org.apache.pivot.wtk.TreeViewNodeListener$Listeners.nodesRemoved(TreeViewNodeListener.java:38) > at org.apache.pivot.wtk.TreeView$BranchHandler.itemsRemoved(TreeView.java:365) > at > org.apache.pivot.collections.List$ListListenerList.lambda$itemsRemoved$1(List.java:57) > at java.lang.Iterable.forEach(Iterable.java:75) > at > org.apache.pivot.collections.List$ListListenerList.itemsRemoved(List.java:57) > at org.apache.pivot.wtk.content.TreeBranch.remove(TreeBranch.java:156) -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (PIVOT-1036) Add a Japanese translation of Pivot
[ https://issues.apache.org/jira/browse/PIVOT-1036?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16518532#comment-16518532 ] Roger Whitcomb commented on PIVOT-1036: --- Note: sent the files to our translators to get the Japanese versions (later this week). > Add a Japanese translation of Pivot > --- > > Key: PIVOT-1036 > URL: https://issues.apache.org/jira/browse/PIVOT-1036 > Project: Pivot > Issue Type: Improvement > Components: wtk-terra >Reporter: Roger Whitcomb >Assignee: Roger Whitcomb >Priority: Minor > > Our product is being translated into Japanese, and for that we will need > Japanese translations of the various resource files (Prompt, Alert, file > dialogs, etc.) -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (PIVOT-1035) Add a real build number to the Pivot (internal) version
[ https://issues.apache.org/jira/browse/PIVOT-1035?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16518528#comment-16518528 ] Roger Whitcomb commented on PIVOT-1035: --- We could set the "Specification-Version" to just be the "2.1.0" value (without the build number), but I think we have to keep the "Implementation-Version" as-is because ApplicationContext expects it to be a "Version" value Add three of the "Specification" fields in the .jar file manifests: * Specification-Title * Specification-Version * Specification-Vendor to make the manifest as complete as possible. Sending build.xml Transmitting file data .done Committing transaction... Committed revision 1833942. Now the manifest looks like: Manifest-Version : 1.0 Ant-Version : Apache Ant 1.9.7 Created-By : 1.8.0_131-b11 (Oracle Corporation) Sealed : true Specification-Title : Apache Pivot Core Specification-Version : 2.1.0 Specification-Vendor : The Apache Software Foundation Implementation-Vendor-Id : org.apache Implementation-Vendor : The Apache Software Foundation Implementation-Title : Apache Pivot Core Implementation-Version : 2.1.0_20181711230 Permissions : all-permissions Codebase : * Caller-Allowable-Codebase : * Application-Library-Allowable-Codebase : * > Add a real build number to the Pivot (internal) version > --- > > Key: PIVOT-1035 > URL: https://issues.apache.org/jira/browse/PIVOT-1035 > Project: Pivot > Issue Type: Improvement > Components: wtk >Reporter: Roger Whitcomb >Assignee: Roger Whitcomb >Priority: Minor > > Right now the internal Pivot version number looks like this: 2.1.0_00, where > the final "00" is always 00. It would be helpful if we could implement a > "real" build number to track changes during development (for instance). I'm > not sure how this should work, but beginning with the Ant "" > task might be a start. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Comment Edited] (PIVOT-1035) Add a real build number to the Pivot (internal) version
[ https://issues.apache.org/jira/browse/PIVOT-1035?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16518500#comment-16518500 ] Roger Whitcomb edited comment on PIVOT-1035 at 6/20/18 7:17 PM: The "Implementation-Version" field looks like it can be any arbitrary text. But in ApplicationContext it is getting this value and parsing it as a "Version"... (line 1867 in the static initialization of the class), so it pretty much has to correspond to our understanding of a "Version" string (org.apache.pivot.util.Version). So, I have just updated our own "Version" class to deal with the build number in the format I just implemented (change from "short" to "long"): Sending core\src\org\apache\pivot\util\Version.java Transmitting file data .done Committing transaction... Committed revision 1833933. was (Author: rwhitcomb): The "Implementation-Version" field looks like it can be any arbitrary text. But in ApplicationContext it is getting this value and parsing it as a "Version"... (line 1867 in the static initialization of the class), so it pretty much has to correspond to our understanding of a "Version" string (org.apache.pivot.util.Version). So, I have just updated our own "Version" class to deal with the build number in the format I just implemented (change from "short" to "long"): Sending core\src\org\apache\pivot\util\Version.java Transmitting file data .done Committing transaction... Committed revision 1833933. > Add a real build number to the Pivot (internal) version > --- > > Key: PIVOT-1035 > URL: https://issues.apache.org/jira/browse/PIVOT-1035 > Project: Pivot > Issue Type: Improvement > Components: wtk >Reporter: Roger Whitcomb >Assignee: Roger Whitcomb >Priority: Minor > > Right now the internal Pivot version number looks like this: 2.1.0_00, where > the final "00" is always 00. It would be helpful if we could implement a > "real" build number to track changes during development (for instance). I'm > not sure how this should work, but beginning with the Ant "" > task might be a start. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (PIVOT-1035) Add a real build number to the Pivot (internal) version
[ https://issues.apache.org/jira/browse/PIVOT-1035?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16518500#comment-16518500 ] Roger Whitcomb commented on PIVOT-1035: --- The "Implementation-Version" field looks like it can be any arbitrary text. But in ApplicationContext it is getting this value and parsing it as a "Version"... (line 1867 in the static initialization of the class), so it pretty much has to correspond to our understanding of a "Version" string (org.apache.pivot.util.Version). So, I have just updated our own "Version" class to deal with the build number in the format I just implemented (change from "short" to "long"): Sending core\src\org\apache\pivot\util\Version.java Transmitting file data .done Committing transaction... Committed revision 1833933. > Add a real build number to the Pivot (internal) version > --- > > Key: PIVOT-1035 > URL: https://issues.apache.org/jira/browse/PIVOT-1035 > Project: Pivot > Issue Type: Improvement > Components: wtk >Reporter: Roger Whitcomb >Assignee: Roger Whitcomb >Priority: Minor > > Right now the internal Pivot version number looks like this: 2.1.0_00, where > the final "00" is always 00. It would be helpful if we could implement a > "real" build number to track changes during development (for instance). I'm > not sure how this should work, but beginning with the Ant "" > task might be a start. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (PIVOT-1035) Add a real build number to the Pivot (internal) version
[ https://issues.apache.org/jira/browse/PIVOT-1035?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16518393#comment-16518393 ] Roger Whitcomb commented on PIVOT-1035: --- Changed to use a date format of "DDDHHmm" for the build number now (looks a bit ugly and too long, but it is definitely unique and always increasing). Implementation-Title : Apache Pivot Core Implementation-Version : 2.1.0_20181711037 Sending build.xml Transmitting file data .done Committing transaction... Committed revision 1833931. What do you think? Too ugly? > Add a real build number to the Pivot (internal) version > --- > > Key: PIVOT-1035 > URL: https://issues.apache.org/jira/browse/PIVOT-1035 > Project: Pivot > Issue Type: Improvement > Components: wtk >Reporter: Roger Whitcomb >Assignee: Roger Whitcomb >Priority: Minor > > Right now the internal Pivot version number looks like this: 2.1.0_00, where > the final "00" is always 00. It would be helpful if we could implement a > "real" build number to track changes during development (for instance). I'm > not sure how this should work, but beginning with the Ant "" > task might be a start. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (PIVOT-1035) Add a real build number to the Pivot (internal) version
[ https://issues.apache.org/jira/browse/PIVOT-1035?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16518364#comment-16518364 ] Roger Whitcomb commented on PIVOT-1035: --- Ciao [~smartini], right now the build number is local (in a "build.number" file). This could be checked into svn to make it a global number I don't know how to use the commit id/hash for that purpose, but that's not a bad idea. Have you seen that done in other places? Of course, that works for a CI build, where you (presumably) have one build per commit. Doesn't work so well for multiple, interim builds without intervening changes, though. That's why I say I don't know how best to make it work, but it seems like *something* is better than just having the number be "00" all the time. > Add a real build number to the Pivot (internal) version > --- > > Key: PIVOT-1035 > URL: https://issues.apache.org/jira/browse/PIVOT-1035 > Project: Pivot > Issue Type: Improvement > Components: wtk >Reporter: Roger Whitcomb >Assignee: Roger Whitcomb >Priority: Minor > > Right now the internal Pivot version number looks like this: 2.1.0_00, where > the final "00" is always 00. It would be helpful if we could implement a > "real" build number to track changes during development (for instance). I'm > not sure how this should work, but beginning with the Ant "" > task might be a start. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (PIVOT-1037) Removing tree nodes before they are visible will cause exceptions
Roger Whitcomb created PIVOT-1037: - Summary: Removing tree nodes before they are visible will cause exceptions Key: PIVOT-1037 URL: https://issues.apache.org/jira/browse/PIVOT-1037 Project: Pivot Issue Type: Bug Components: wtk-terra Reporter: Roger Whitcomb Assignee: Roger Whitcomb We build a tree, but don't expand it all initially. User can do things that cause the tree to be rebuilt before the child nodes have become visible. This leads to exceptions such as: java.lang.IndexOutOfBoundsException: Index 1 out of bounds [0,0]. STACK TRACE: at org.apache.pivot.util.Utils.checkIndexBounds(Utils.java:246) at org.apache.pivot.collections.ArrayList.get(ArrayList.java:431) at org.apache.pivot.wtk.skin.terra.TerraTreeViewSkin.removeVisibleNodes(TerraTreeViewSkin.java:1358) at org.apache.pivot.wtk.skin.terra.TerraTreeViewSkin.nodesRemoved(TerraTreeViewSkin.java:2064) at org.apache.pivot.wtk.TreeViewNodeListener$Listeners.lambda$nodesRemoved$1(TreeViewNodeListener.java:38) at java.lang.Iterable.forEach(Iterable.java:75) at org.apache.pivot.wtk.TreeViewNodeListener$Listeners.nodesRemoved(TreeViewNodeListener.java:38) at org.apache.pivot.wtk.TreeView$BranchHandler.itemsRemoved(TreeView.java:365) at org.apache.pivot.collections.List$ListListenerList.lambda$itemsRemoved$1(List.java:57) at java.lang.Iterable.forEach(Iterable.java:75) at org.apache.pivot.collections.List$ListListenerList.itemsRemoved(List.java:57) at org.apache.pivot.wtk.content.TreeBranch.remove(TreeBranch.java:156) -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (PIVOT-1036) Add a Japanese translation of Pivot
[
https://issues.apache.org/jira/browse/PIVOT-1036?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16515994#comment-16515994
]
Roger Whitcomb commented on PIVOT-1036:
---
Ant target to zip up the translation files ("ant package-i18n-resources"):
Sending build.xml
Transmitting file data .done
Committing transaction...
Committed revision 1833735.
> Add a Japanese translation of Pivot
> ---
>
> Key: PIVOT-1036
> URL: https://issues.apache.org/jira/browse/PIVOT-1036
> Project: Pivot
> Issue Type: Improvement
> Components: wtk-terra
>Reporter: Roger Whitcomb
>Assignee: Roger Whitcomb
>Priority: Minor
>
> Our product is being translated into Japanese, and for that we will need
> Japanese translations of the various resource files (Prompt, Alert, file
> dialogs, etc.)
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Created] (PIVOT-1036) Add a Japanese translation of Pivot
Roger Whitcomb created PIVOT-1036: - Summary: Add a Japanese translation of Pivot Key: PIVOT-1036 URL: https://issues.apache.org/jira/browse/PIVOT-1036 Project: Pivot Issue Type: Improvement Components: wtk-terra Reporter: Roger Whitcomb Assignee: Roger Whitcomb Our product is being translated into Japanese, and for that we will need Japanese translations of the various resource files (Prompt, Alert, file dialogs, etc.) -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (PIVOT-1032) Implement "checkstyle" for builds and make changes to bring code into better compliance
[ https://issues.apache.org/jira/browse/PIVOT-1032?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16515813#comment-16515813 ] Roger Whitcomb commented on PIVOT-1032: --- Sending core\src\org\apache\pivot\collections\ArrayList.java Sending core\src\org\apache\pivot\collections\EnumSet.java Sending core\src\org\apache\pivot\collections\Sequence.java Sending core\src\org\apache\pivot\serialization\CSVSerializer.java Sending core\src\org\apache\pivot\serialization\CSVSerializerListener.java Sending core\test\org\apache\pivot\collections\test\ArrayListTest.java Sending wtk\src\org\apache\pivot\wtk\CSSColor.java Sending wtk\src\org\apache\pivot\wtk\Cursor.java Sending wtk\src\org\apache\pivot\wtk\Origin.java Sending wtk\src\org\apache\pivot\wtk\Platform.java Sending wtk\src\org\apache\pivot\wtk\media\BufferedImageSerializer.java Sending wtk-terra\src\org\apache\pivot\wtk\skin\terra\TerraTableViewSkin.java Sending wtk-terra\src\org\apache\pivot\wtk\skin\terra\TerraTextInputSkin.java Transmitting file data .done Committing transaction... Committed revision 1833730. > Implement "checkstyle" for builds and make changes to bring code into better > compliance > --- > > Key: PIVOT-1032 > URL: https://issues.apache.org/jira/browse/PIVOT-1032 > Project: Pivot > Issue Type: Improvement >Reporter: Roger Whitcomb >Assignee: Roger Whitcomb >Priority: Minor > Attachments: 1032.diffs.txt > > > I thought it would be interesting, in addition to the "trim-whitespace" task > already implemented, to do some sort of "checkstyle" processing to evaluate > all the code to see where there might be changes to make the code more robust > and a better example of "canonical" Java style. > I hesitate to expect that we could address everything (or indeed whether we > *should*), but there might be things that would make the code better and > easier to read and maintain, and wouldn't take much effort. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (PIVOT-1026) Replace logic for StockTracker demo since Yahoo has discontinued its API to download stock data
[ https://issues.apache.org/jira/browse/PIVOT-1026?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16515812#comment-16515812 ] Roger Whitcomb commented on PIVOT-1026: --- Also Alpha Vantage has a free API (with a "demo" key available): [https://www.alphavantage.co/] The API looks very simple to use, so I will try to implement this in StockTracker: [https://www.alphavantage.co/documentation/] > Replace logic for StockTracker demo since Yahoo has discontinued its API to > download stock data > --- > > Key: PIVOT-1026 > URL: https://issues.apache.org/jira/browse/PIVOT-1026 > Project: Pivot > Issue Type: Bug > Components: tutorials >Affects Versions: 2.1, 2.0.5 >Reporter: Roger Whitcomb >Assignee: Roger Whitcomb >Priority: Major > Fix For: 2.1 > > > Yahoo has as of around mid-2017 discontinued the "download.finance.yahoo.com" > API for downloading stock data. There are new APIs that are meant to be used > only by browsers (in order to satisfy Yahoo's Terms and Conditions, involving > the use of a crumb and cookies). So, the StockTracker tutorial is > effectively rendering unusable as of now until replacement logic is > available. There is a Visual Basic solution here: > [http://www.signalsolver.com/wp-content/uploads/2017/10/EmulateURL-V1.0f.txt] > that is complicated but seems to work at least. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (PIVOT-1035) Add a real build number to the Pivot (internal) version
[ https://issues.apache.org/jira/browse/PIVOT-1035?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16515806#comment-16515806 ] Roger Whitcomb commented on PIVOT-1035: --- Did a simple implementation using "": Sending build.xml Transmitting file data .done Committing transaction... Committed revision 1833728. > Add a real build number to the Pivot (internal) version > --- > > Key: PIVOT-1035 > URL: https://issues.apache.org/jira/browse/PIVOT-1035 > Project: Pivot > Issue Type: Improvement > Components: wtk >Reporter: Roger Whitcomb >Assignee: Roger Whitcomb >Priority: Minor > > Right now the internal Pivot version number looks like this: 2.1.0_00, where > the final "00" is always 00. It would be helpful if we could implement a > "real" build number to track changes during development (for instance). I'm > not sure how this should work, but beginning with the Ant "" > task might be a start. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (PIVOT-1035) Add a real build number to the Pivot (internal) version
Roger Whitcomb created PIVOT-1035: - Summary: Add a real build number to the Pivot (internal) version Key: PIVOT-1035 URL: https://issues.apache.org/jira/browse/PIVOT-1035 Project: Pivot Issue Type: Improvement Components: wtk Reporter: Roger Whitcomb Assignee: Roger Whitcomb Right now the internal Pivot version number looks like this: 2.1.0_00, where the final "00" is always 00. It would be helpful if we could implement a "real" build number to track changes during development (for instance). I'm not sure how this should work, but beginning with the Ant "" task might be a start. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (PIVOT-1034) Change ThemeNotFoundException to a subclass of Error
[ https://issues.apache.org/jira/browse/PIVOT-1034?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16505122#comment-16505122 ] Roger Whitcomb commented on PIVOT-1034: --- Made these changes and a bunch of cleanup too: Sending wtk\src\org\apache\pivot\wtk\Theme.java Sending wtk\src\org\apache\pivot\wtk\ThemeNotFoundException.java Sending wtk-terra\src\org\apache\pivot\wtk\skin\terra\TerraTheme.java Transmitting file data ...done Committing transaction... Committed revision 1833140. > Change ThemeNotFoundException to a subclass of Error > > > Key: PIVOT-1034 > URL: https://issues.apache.org/jira/browse/PIVOT-1034 > Project: Pivot > Issue Type: Improvement > Components: wtk >Reporter: Roger Whitcomb >Assignee: Roger Whitcomb >Priority: Minor > > It seems like the ThemeNotFoundException is more akin to a Java "Error" than > a RuntimeException, because the user or program is not expected to be able to > recover from it. > Also, there are some error conditions in TerraTheme during initialization > that also are essentially the same thing (that is, a part of the theme > configuration is not available for some reason). These things also could > throw this ThemeNotFoundException. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (PIVOT-1034) Change ThemeNotFoundException to a subclass of Error
Roger Whitcomb created PIVOT-1034: - Summary: Change ThemeNotFoundException to a subclass of Error Key: PIVOT-1034 URL: https://issues.apache.org/jira/browse/PIVOT-1034 Project: Pivot Issue Type: Improvement Components: wtk Reporter: Roger Whitcomb Assignee: Roger Whitcomb It seems like the ThemeNotFoundException is more akin to a Java "Error" than a RuntimeException, because the user or program is not expected to be able to recover from it. Also, there are some error conditions in TerraTheme during initialization that also are essentially the same thing (that is, a part of the theme configuration is not available for some reason). These things also could throw this ThemeNotFoundException. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (PIVOT-1032) Implement "checkstyle" for builds and make changes to bring code into better compliance
[ https://issues.apache.org/jira/browse/PIVOT-1032?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16496978#comment-16496978 ] Roger Whitcomb commented on PIVOT-1032: --- Sending core/src/org/apache/pivot/json/JSON.java Sending wtk/src/org/apache/pivot/wtk/skin/FillPaneSkin.java Sending wtk/src/org/apache/pivot/wtk/skin/GridPaneSkin.java Sending wtk/src/org/apache/pivot/wtk/skin/RulerSkin.java Transmitting file data done Committing transaction... Committed revision 1832639. > Implement "checkstyle" for builds and make changes to bring code into better > compliance > --- > > Key: PIVOT-1032 > URL: https://issues.apache.org/jira/browse/PIVOT-1032 > Project: Pivot > Issue Type: Improvement >Reporter: Roger Whitcomb >Assignee: Roger Whitcomb >Priority: Minor > Attachments: 1032.diffs.txt > > > I thought it would be interesting, in addition to the "trim-whitespace" task > already implemented, to do some sort of "checkstyle" processing to evaluate > all the code to see where there might be changes to make the code more robust > and a better example of "canonical" Java style. > I hesitate to expect that we could address everything (or indeed whether we > *should*), but there might be things that would make the code better and > easier to read and maintain, and wouldn't take much effort. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (PIVOT-1032) Implement "checkstyle" for builds and make changes to bring code into better compliance
[ https://issues.apache.org/jira/browse/PIVOT-1032?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16461836#comment-16461836 ] Roger Whitcomb commented on PIVOT-1032: --- Count the number of unique file names with errors in the summary file: Sending StyleErrors.java Transmitting file data .done Committing transaction... Committed revision 1830789. > Implement "checkstyle" for builds and make changes to bring code into better > compliance > --- > > Key: PIVOT-1032 > URL: https://issues.apache.org/jira/browse/PIVOT-1032 > Project: Pivot > Issue Type: Improvement >Reporter: Roger Whitcomb >Assignee: Roger Whitcomb >Priority: Minor > Attachments: 1032.diffs.txt > > > I thought it would be interesting, in addition to the "trim-whitespace" task > already implemented, to do some sort of "checkstyle" processing to evaluate > all the code to see where there might be changes to make the code more robust > and a better example of "canonical" Java style. > I hesitate to expect that we could address everything (or indeed whether we > *should*), but there might be things that would make the code better and > easier to read and maintain, and wouldn't take much effort. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (PIVOT-1032) Implement "checkstyle" for builds and make changes to bring code into better compliance
[ https://issues.apache.org/jira/browse/PIVOT-1032?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16456945#comment-16456945 ] Roger Whitcomb commented on PIVOT-1032: --- Fixed the NewlineAtEndOfFile setting: Sending pivot_checks.xml Transmitting file data .done Committing transaction... Committed revision 1830388. > Implement "checkstyle" for builds and make changes to bring code into better > compliance > --- > > Key: PIVOT-1032 > URL: https://issues.apache.org/jira/browse/PIVOT-1032 > Project: Pivot > Issue Type: Improvement >Reporter: Roger Whitcomb >Assignee: Roger Whitcomb >Priority: Minor > Attachments: 1032.diffs.txt > > > I thought it would be interesting, in addition to the "trim-whitespace" task > already implemented, to do some sort of "checkstyle" processing to evaluate > all the code to see where there might be changes to make the code more robust > and a better example of "canonical" Java style. > I hesitate to expect that we could address everything (or indeed whether we > *should*), but there might be things that would make the code better and > easier to read and maintain, and wouldn't take much effort. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (PIVOT-1032) Implement "checkstyle" for builds and make changes to bring code into better compliance
[ https://issues.apache.org/jira/browse/PIVOT-1032?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16456939#comment-16456939 ] Roger Whitcomb commented on PIVOT-1032: --- Updated the list of files to check: Sending build.xml Transmitting file data .done Committing transaction... Committed revision 1830387. > Implement "checkstyle" for builds and make changes to bring code into better > compliance > --- > > Key: PIVOT-1032 > URL: https://issues.apache.org/jira/browse/PIVOT-1032 > Project: Pivot > Issue Type: Improvement >Reporter: Roger Whitcomb >Assignee: Roger Whitcomb >Priority: Minor > Attachments: 1032.diffs.txt > > > I thought it would be interesting, in addition to the "trim-whitespace" task > already implemented, to do some sort of "checkstyle" processing to evaluate > all the code to see where there might be changes to make the code more robust > and a better example of "canonical" Java style. > I hesitate to expect that we could address everything (or indeed whether we > *should*), but there might be things that would make the code better and > easier to read and maintain, and wouldn't take much effort. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (PIVOT-1032) Implement "checkstyle" for builds and make changes to bring code into better compliance
[ https://issues.apache.org/jira/browse/PIVOT-1032?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16456885#comment-16456885 ] Roger Whitcomb commented on PIVOT-1032: --- Changed "build.xml" to add the "check-style" target. NOTE: The "checkstyle...-all.jar" file must be in the $ANT_HOME/lib directory for this to work. Sending build.xml Transmitting file data .done Committing transaction... Committed revision 1830386. > Implement "checkstyle" for builds and make changes to bring code into better > compliance > --- > > Key: PIVOT-1032 > URL: https://issues.apache.org/jira/browse/PIVOT-1032 > Project: Pivot > Issue Type: Improvement >Reporter: Roger Whitcomb >Assignee: Roger Whitcomb >Priority: Minor > Attachments: 1032.diffs.txt > > > I thought it would be interesting, in addition to the "trim-whitespace" task > already implemented, to do some sort of "checkstyle" processing to evaluate > all the code to see where there might be changes to make the code more robust > and a better example of "canonical" Java style. > I hesitate to expect that we could address everything (or indeed whether we > *should*), but there might be things that would make the code better and > easier to read and maintain, and wouldn't take much effort. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (PIVOT-1032) Implement "checkstyle" for builds and make changes to bring code into better compliance
[ https://issues.apache.org/jira/browse/PIVOT-1032?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16456866#comment-16456866 ] Roger Whitcomb commented on PIVOT-1032: --- Fixed the last [ModifierOrder] errors: Sending wtk-terra/src/org/apache/pivot/wtk/skin/terra/TerraFileBrowserSkin.java Sending wtk-terra/src/org/apache/pivot/wtk/skin/terra/TerraVFSBrowserSkin.java Transmitting file data ..done Committing transaction... Committed revision 1830384. > Implement "checkstyle" for builds and make changes to bring code into better > compliance > --- > > Key: PIVOT-1032 > URL: https://issues.apache.org/jira/browse/PIVOT-1032 > Project: Pivot > Issue Type: Improvement >Reporter: Roger Whitcomb >Assignee: Roger Whitcomb >Priority: Minor > Attachments: 1032.diffs.txt > > > I thought it would be interesting, in addition to the "trim-whitespace" task > already implemented, to do some sort of "checkstyle" processing to evaluate > all the code to see where there might be changes to make the code more robust > and a better example of "canonical" Java style. > I hesitate to expect that we could address everything (or indeed whether we > *should*), but there might be things that would make the code better and > easier to read and maintain, and wouldn't take much effort. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (PIVOT-1032) Implement "checkstyle" for builds and make changes to bring code into better compliance
[ https://issues.apache.org/jira/browse/PIVOT-1032?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16456853#comment-16456853 ] Roger Whitcomb commented on PIVOT-1032: --- Changed all "default public" in the Listener interfaces to just "default": 120 files changed. Committed revision 1830383. > Implement "checkstyle" for builds and make changes to bring code into better > compliance > --- > > Key: PIVOT-1032 > URL: https://issues.apache.org/jira/browse/PIVOT-1032 > Project: Pivot > Issue Type: Improvement >Reporter: Roger Whitcomb >Assignee: Roger Whitcomb >Priority: Minor > Attachments: 1032.diffs.txt > > > I thought it would be interesting, in addition to the "trim-whitespace" task > already implemented, to do some sort of "checkstyle" processing to evaluate > all the code to see where there might be changes to make the code more robust > and a better example of "canonical" Java style. > I hesitate to expect that we could address everything (or indeed whether we > *should*), but there might be things that would make the code better and > easier to read and maintain, and wouldn't take much effort. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (PIVOT-1032) Implement "checkstyle" for builds and make changes to bring code into better compliance
[ https://issues.apache.org/jira/browse/PIVOT-1032?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16456791#comment-16456791 ] Roger Whitcomb commented on PIVOT-1032: --- Tweak a Javadoc from the earlier commit: Sending wtk-terra/src/org/apache/pivot/wtk/skin/terra/TerraTreeViewSkin.java Transmitting file data .done Committing transaction... Committed revision 1830372. > Implement "checkstyle" for builds and make changes to bring code into better > compliance > --- > > Key: PIVOT-1032 > URL: https://issues.apache.org/jira/browse/PIVOT-1032 > Project: Pivot > Issue Type: Improvement >Reporter: Roger Whitcomb >Assignee: Roger Whitcomb >Priority: Minor > Attachments: 1032.diffs.txt > > > I thought it would be interesting, in addition to the "trim-whitespace" task > already implemented, to do some sort of "checkstyle" processing to evaluate > all the code to see where there might be changes to make the code more robust > and a better example of "canonical" Java style. > I hesitate to expect that we could address everything (or indeed whether we > *should*), but there might be things that would make the code better and > easier to read and maintain, and wouldn't take much effort. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (PIVOT-1032) Implement "checkstyle" for builds and make changes to bring code into better compliance
[ https://issues.apache.org/jira/browse/PIVOT-1032?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16456782#comment-16456782 ] Roger Whitcomb commented on PIVOT-1032: --- Added a program to summarize the check style results: Adding StyleErrors.java Transmitting file data .done Committing transaction... Committed revision 1830370. > Implement "checkstyle" for builds and make changes to bring code into better > compliance > --- > > Key: PIVOT-1032 > URL: https://issues.apache.org/jira/browse/PIVOT-1032 > Project: Pivot > Issue Type: Improvement >Reporter: Roger Whitcomb >Assignee: Roger Whitcomb >Priority: Minor > Attachments: 1032.diffs.txt > > > I thought it would be interesting, in addition to the "trim-whitespace" task > already implemented, to do some sort of "checkstyle" processing to evaluate > all the code to see where there might be changes to make the code more robust > and a better example of "canonical" Java style. > I hesitate to expect that we could address everything (or indeed whether we > *should*), but there might be things that would make the code better and > easier to read and maintain, and wouldn't take much effort. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (PIVOT-1032) Implement "checkstyle" for builds and make changes to bring code into better compliance
[ https://issues.apache.org/jira/browse/PIVOT-1032?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16456776#comment-16456776 ] Roger Whitcomb commented on PIVOT-1032: --- Update the method length maximum setting to 200 lines to reduce the errors: Sending pivot_checks.xml Transmitting file data .done Committing transaction... Committed revision 1830366. > Implement "checkstyle" for builds and make changes to bring code into better > compliance > --- > > Key: PIVOT-1032 > URL: https://issues.apache.org/jira/browse/PIVOT-1032 > Project: Pivot > Issue Type: Improvement >Reporter: Roger Whitcomb >Assignee: Roger Whitcomb >Priority: Minor > Attachments: 1032.diffs.txt > > > I thought it would be interesting, in addition to the "trim-whitespace" task > already implemented, to do some sort of "checkstyle" processing to evaluate > all the code to see where there might be changes to make the code more robust > and a better example of "canonical" Java style. > I hesitate to expect that we could address everything (or indeed whether we > *should*), but there might be things that would make the code better and > easier to read and maintain, and wouldn't take much effort. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (PIVOT-1032) Implement "checkstyle" for builds and make changes to bring code into better compliance
[ https://issues.apache.org/jira/browse/PIVOT-1032?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16455571#comment-16455571 ] Roger Whitcomb commented on PIVOT-1032: --- More check style errors fixed: Sending core/src/org/apache/pivot/collections/adapter/ListAdapter.java Sending core/src/org/apache/pivot/functional/monad/Failure.java Sending core/src/org/apache/pivot/functional/monad/Monad.java Sending core/src/org/apache/pivot/functional/monad/Option.java Sending core/src/org/apache/pivot/functional/monad/Some.java Sending core/src/org/apache/pivot/functional/monad/Success.java Sending core/src/org/apache/pivot/functional/monad/Try.java Sending core/src/org/apache/pivot/functional/monad/TryCompanion.java Sending core/test/org/apache/pivot/functional/monad/test/OptionTest.java Sending core/test/org/apache/pivot/functional/monad/test/TryTest.java Sending core/test/org/apache/pivot/util/test/BooleanResultTest.java Sending demos/src/org/apache/pivot/demos/million/LargeData.java Sending tests/src/org/apache/pivot/tests/CardPaneTest.java Sending tests/src/org/apache/pivot/tests/JavascriptConsoleTest.java Sending tests/src/org/apache/pivot/tests/issues/Pivot686.java Sending tests/src/org/apache/pivot/tests/issues/pivot964/Pivot964Pivot.java Sending tests/src/org/apache/pivot/tests/issues/pivot964/Pivot964Swing.java Sending tutorials/src/org/apache/pivot/tutorials/bxmlexplorer/BXMLExplorerDocument.java Sending tutorials/src/org/apache/pivot/tutorials/text/TextInputs.java Sending wtk/src/org/apache/pivot/wtk/ApplicationContext.java Sending wtk/src/org/apache/pivot/wtk/Checkbox.java Sending wtk/src/org/apache/pivot/wtk/CornerRadii.java Sending wtk/src/org/apache/pivot/wtk/DesktopApplicationContext.java Sending wtk/src/org/apache/pivot/wtk/Gauge.java Sending wtk/src/org/apache/pivot/wtk/GraphicsUtilities.java Sending wtk/src/org/apache/pivot/wtk/Insets.java Sending wtk/src/org/apache/pivot/wtk/ListView.java Sending wtk/src/org/apache/pivot/wtk/Meter.java Sending wtk/src/org/apache/pivot/wtk/RadioButtonGroup.java Sending wtk/src/org/apache/pivot/wtk/Span.java Sending wtk/src/org/apache/pivot/wtk/TableView.java Sending wtk/src/org/apache/pivot/wtk/skin/BorderSkin.java Sending wtk/src/org/apache/pivot/wtk/skin/ComponentSkin.java Sending wtk/src/org/apache/pivot/wtk/skin/LabelSkin.java Sending wtk/src/org/apache/pivot/wtk/skin/NumberRulerSkin.java Sending wtk/src/org/apache/pivot/wtk/validation/RegexTextValidator.java Sending wtk-terra/src/org/apache/pivot/wtk/skin/terra/TerraAlertSkin.java Sending wtk-terra/src/org/apache/pivot/wtk/skin/terra/TerraCheckboxSkin.java Sending wtk-terra/src/org/apache/pivot/wtk/skin/terra/TerraFileBrowserSkin.java Sending wtk-terra/src/org/apache/pivot/wtk/skin/terra/TerraListViewSkin.java Sending wtk-terra/src/org/apache/pivot/wtk/skin/terra/TerraPaletteSkin.java Sending wtk-terra/src/org/apache/pivot/wtk/skin/terra/TerraPromptSkin.java Sending wtk-terra/src/org/apache/pivot/wtk/skin/terra/TerraTableViewSkin.java Sending wtk-terra/src/org/apache/pivot/wtk/skin/terra/TerraTreeViewSkin.java Sending wtk-terra/src/org/apache/pivot/wtk/skin/terra/TerraVFSBrowserSkin.java Transmitting file data .done Committing transaction... Committed revision 1830285. > Implement "checkstyle" for builds and make changes to bring code into better > compliance > --- > > Key: PIVOT-1032 > URL: https://issues.apache.org/jira/browse/PIVOT-1032 > Project: Pivot > Issue Type: Improvement >Reporter: Roger Whitcomb >Assignee: Roger Whitcomb >Priority: Minor > Attachments: 1032.diffs.txt > > > I thought it would be interesting, in addition to the "trim-whitespace" task > already implemented, to do some sort of "checkstyle" processing to evaluate > all the code to see where there might be changes to make the code more robust > and a better example of "canonical" Java style. > I hesitate to expect that we could address everything (or indeed whether we > *should*), but there might be things that would make the code better and > easier to read and maintain, and wouldn't take much effort. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (PIVOT-1032) Implement "checkstyle" for builds and make changes to bring code into better compliance
[ https://issues.apache.org/jira/browse/PIVOT-1032?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16454288#comment-16454288 ] Roger Whitcomb commented on PIVOT-1032: --- Fixed the UnusedImports in all the sub-packages of "wtk": Sending wtk/src/org/apache/pivot/wtk/content/ListViewItemRenderer.java Sending wtk/src/org/apache/pivot/wtk/content/SpinnerItemRenderer.java Sending wtk/src/org/apache/pivot/wtk/content/TableViewCellRenderer.java Sending wtk/src/org/apache/pivot/wtk/content/TableViewTextAreaCellRenderer.java Sending wtk/src/org/apache/pivot/wtk/effects/BaselineDecorator.java Sending wtk/src/org/apache/pivot/wtk/effects/BlurDecorator.java Sending wtk/src/org/apache/pivot/wtk/effects/ClipDecorator.java Sending wtk/src/org/apache/pivot/wtk/effects/DropShadowDecorator.java Sending wtk/src/org/apache/pivot/wtk/effects/FadeDecorator.java Sending wtk/src/org/apache/pivot/wtk/effects/GrayscaleDecorator.java Sending wtk/src/org/apache/pivot/wtk/effects/OverlayDecorator.java Sending wtk/src/org/apache/pivot/wtk/effects/SaturationDecorator.java Sending wtk/src/org/apache/pivot/wtk/effects/ScaleDecorator.java Sending wtk/src/org/apache/pivot/wtk/effects/ShadeDecorator.java Sending wtk/src/org/apache/pivot/wtk/effects/TagDecorator.java Sending wtk/src/org/apache/pivot/wtk/effects/WatermarkDecorator.java Sending wtk/src/org/apache/pivot/wtk/media/Drawing.java Sending wtk/src/org/apache/pivot/wtk/media/Image.java Sending wtk/src/org/apache/pivot/wtk/skin/BorderSkin.java Sending wtk/src/org/apache/pivot/wtk/skin/CalendarButtonSkin.java Sending wtk/src/org/apache/pivot/wtk/skin/CheckboxSkin.java Sending wtk/src/org/apache/pivot/wtk/skin/ColorChooserButtonSkin.java Sending wtk/src/org/apache/pivot/wtk/skin/ComponentSkin.java Sending wtk/src/org/apache/pivot/wtk/skin/ListButtonSkin.java Sending wtk/src/org/apache/pivot/wtk/skin/MenuBarItemSkin.java Sending wtk/src/org/apache/pivot/wtk/skin/MenuButtonSkin.java Sending wtk/src/org/apache/pivot/wtk/skin/PushButtonSkin.java Sending wtk/src/org/apache/pivot/wtk/skin/RadioButtonSkin.java Sending wtk/src/org/apache/pivot/wtk/skin/RulerSkin.java Sending wtk/src/org/apache/pivot/wtk/skin/ScrollPaneSkin.java Sending wtk/src/org/apache/pivot/wtk/skin/SeparatorSkin.java Sending wtk/src/org/apache/pivot/wtk/skin/TablePaneSkin.java Sending wtk/src/org/apache/pivot/wtk/skin/TextPaneSkin.java Sending wtk/src/org/apache/pivot/wtk/skin/TextPaneSkinNodeView.java Sending wtk/src/org/apache/pivot/wtk/skin/TextPaneSkinTextNodeView.java Sending wtk/src/org/apache/pivot/wtk/text/Element.java Sending wtk/src/org/apache/pivot/wtk/validation/RegexTextValidator.java Transmitting file data .done Committing transaction... Committed revision 1830230. > Implement "checkstyle" for builds and make changes to bring code into better > compliance > --- > > Key: PIVOT-1032 > URL: https://issues.apache.org/jira/browse/PIVOT-1032 > Project: Pivot > Issue Type: Improvement >Reporter: Roger Whitcomb >Assignee: Roger Whitcomb >Priority: Minor > Attachments: 1032.diffs.txt > > > I thought it would be interesting, in addition to the "trim-whitespace" task > already implemented, to do some sort of "checkstyle" processing to evaluate > all the code to see where there might be changes to make the code more robust > and a better example of "canonical" Java style. > I hesitate to expect that we could address everything (or indeed whether we > *should*), but there might be things that would make the code better and > easier to read and maintain, and wouldn't take much effort. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (PIVOT-1032) Implement "checkstyle" for builds and make changes to bring code into better compliance
[ https://issues.apache.org/jira/browse/PIVOT-1032?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16454268#comment-16454268 ] Roger Whitcomb commented on PIVOT-1032: --- Fixed these UnusedImports errors in the "wtk" classes: Sending wtk/src/org/apache/pivot/wtk/Accordion.java Sending wtk/src/org/apache/pivot/wtk/Bounds.java Sending wtk/src/org/apache/pivot/wtk/Component.java Sending wtk/src/org/apache/pivot/wtk/Container.java Sending wtk/src/org/apache/pivot/wtk/CornerRadii.java Sending wtk/src/org/apache/pivot/wtk/Dialog.java Sending wtk/src/org/apache/pivot/wtk/Dimensions.java Sending wtk/src/org/apache/pivot/wtk/Form.java Sending wtk/src/org/apache/pivot/wtk/Insets.java Sending wtk/src/org/apache/pivot/wtk/Limits.java Sending wtk/src/org/apache/pivot/wtk/LocalManifest.java Sending wtk/src/org/apache/pivot/wtk/Point.java Sending wtk/src/org/apache/pivot/wtk/Sheet.java Sending wtk/src/org/apache/pivot/wtk/Span.java Sending wtk/src/org/apache/pivot/wtk/TextInput.java Sending wtk/src/org/apache/pivot/wtk/TextPane.java Sending wtk/src/org/apache/pivot/wtk/TreeView.java Sending wtk/src/org/apache/pivot/wtk/Viewport.java Sending wtk/src/org/apache/pivot/wtk/Window.java Transmitting file data ...done Committing transaction... Committed revision 1830229. > Implement "checkstyle" for builds and make changes to bring code into better > compliance > --- > > Key: PIVOT-1032 > URL: https://issues.apache.org/jira/browse/PIVOT-1032 > Project: Pivot > Issue Type: Improvement >Reporter: Roger Whitcomb >Assignee: Roger Whitcomb >Priority: Minor > Attachments: 1032.diffs.txt > > > I thought it would be interesting, in addition to the "trim-whitespace" task > already implemented, to do some sort of "checkstyle" processing to evaluate > all the code to see where there might be changes to make the code more robust > and a better example of "canonical" Java style. > I hesitate to expect that we could address everything (or indeed whether we > *should*), but there might be things that would make the code better and > easier to read and maintain, and wouldn't take much effort. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (PIVOT-1032) Implement "checkstyle" for builds and make changes to bring code into better compliance
[ https://issues.apache.org/jira/browse/PIVOT-1032?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16453048#comment-16453048 ] Roger Whitcomb commented on PIVOT-1032: --- The UnusedImports fixed in the "wtk-terra" files: Sending wtk-terra/src/org/apache/pivot/wtk/skin/terra/TerraAccordionSkin.java Sending wtk-terra/src/org/apache/pivot/wtk/skin/terra/TerraActivityIndicatorSkin.java Sending wtk-terra/src/org/apache/pivot/wtk/skin/terra/TerraCalendarButtonSkin.java Sending wtk-terra/src/org/apache/pivot/wtk/skin/terra/TerraCalendarSkin.java Sending wtk-terra/src/org/apache/pivot/wtk/skin/terra/TerraCheckboxSkin.java Sending wtk-terra/src/org/apache/pivot/wtk/skin/terra/TerraColorChooserButtonSkin.java Sending wtk-terra/src/org/apache/pivot/wtk/skin/terra/TerraDialogSkin.java Sending wtk-terra/src/org/apache/pivot/wtk/skin/terra/TerraExpanderSkin.java Sending wtk-terra/src/org/apache/pivot/wtk/skin/terra/TerraFileBrowserSkin.java Sending wtk-terra/src/org/apache/pivot/wtk/skin/terra/TerraFormSkin.java Sending wtk-terra/src/org/apache/pivot/wtk/skin/terra/TerraFrameSkin.java Sending wtk-terra/src/org/apache/pivot/wtk/skin/terra/TerraGaugeSkin.java Sending wtk-terra/src/org/apache/pivot/wtk/skin/terra/TerraListButtonSkin.java Sending wtk-terra/src/org/apache/pivot/wtk/skin/terra/TerraListViewSkin.java Sending wtk-terra/src/org/apache/pivot/wtk/skin/terra/TerraMenuButtonSkin.java Sending wtk-terra/src/org/apache/pivot/wtk/skin/terra/TerraMenuItemSkin.java Sending wtk-terra/src/org/apache/pivot/wtk/skin/terra/TerraMenuPopupSkin.java Sending wtk-terra/src/org/apache/pivot/wtk/skin/terra/TerraMenuSkin.java Sending wtk-terra/src/org/apache/pivot/wtk/skin/terra/TerraMeterSkin.java Sending wtk-terra/src/org/apache/pivot/wtk/skin/terra/TerraPaletteSkin.java Sending wtk-terra/src/org/apache/pivot/wtk/skin/terra/TerraPanoramaSkin.java Sending wtk-terra/src/org/apache/pivot/wtk/skin/terra/TerraPushButtonSkin.java Sending wtk-terra/src/org/apache/pivot/wtk/skin/terra/TerraRadioButtonSkin.java Sending wtk-terra/src/org/apache/pivot/wtk/skin/terra/TerraRollupSkin.java Sending wtk-terra/src/org/apache/pivot/wtk/skin/terra/TerraScrollBarSkin.java Sending wtk-terra/src/org/apache/pivot/wtk/skin/terra/TerraScrollPaneSkin.java Sending wtk-terra/src/org/apache/pivot/wtk/skin/terra/TerraSheetSkin.java Sending wtk-terra/src/org/apache/pivot/wtk/skin/terra/TerraSliderSkin.java Sending wtk-terra/src/org/apache/pivot/wtk/skin/terra/TerraSpinnerSkin.java Sending wtk-terra/src/org/apache/pivot/wtk/skin/terra/TerraSuggestionPopupSkin.java Sending wtk-terra/src/org/apache/pivot/wtk/skin/terra/TerraTabPaneSkin.java Sending wtk-terra/src/org/apache/pivot/wtk/skin/terra/TerraTableViewHeaderSkin.java Sending wtk-terra/src/org/apache/pivot/wtk/skin/terra/TerraTableViewSkin.java Sending wtk-terra/src/org/apache/pivot/wtk/skin/terra/TerraTextInputSkin.java Sending wtk-terra/src/org/apache/pivot/wtk/skin/terra/TerraTheme.java Sending wtk-terra/src/org/apache/pivot/wtk/skin/terra/TerraTreeViewSkin.java Sending wtk-terra/src/org/apache/pivot/wtk/skin/terra/TerraVFSBrowserSkin.java Transmitting file data .done Committing transaction... Committed revision 1830117. > Implement "checkstyle" for builds and make changes to bring code into better > compliance > --- > > Key: PIVOT-1032 > URL: https://issues.apache.org/jira/browse/PIVOT-1032 > Project: Pivot > Issue Type: Improvement >Reporter: Roger Whitcomb >Assignee: Roger Whitcomb >Priority: Minor > Attachments: 1032.diffs.txt > > > I thought it would be interesting, in addition to the "trim-whitespace" task > already implemented, to do some sort of "checkstyle" processing to evaluate > all the code to see where there might be changes to make the code more robust > and a better example of "canonical" Java style. > I hesitate to expect that we could address everything (or indeed whether we > *should*), but there might be things that would make the code better and > easier to read and maintain, and wouldn't take much effort. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (PIVOT-1032) Implement "checkstyle" for builds and make changes to bring code into better compliance
[ https://issues.apache.org/jira/browse/PIVOT-1032?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16452885#comment-16452885 ] Roger Whitcomb commented on PIVOT-1032: --- Work on UnusedImports errors: Sending core/src/org/apache/pivot/beans/BXMLSerializer.java Sending core/src/org/apache/pivot/collections/Queue.java Sending core/src/org/apache/pivot/collections/Stack.java Sending core/src/org/apache/pivot/text/AttributedStringCharacterIterator.java Sending core/src/org/apache/pivot/text/CharSpan.java Sending core/src/org/apache/pivot/util/CalendarDate.java Sending core/src/org/apache/pivot/util/Time.java Sending core/test/org/apache/pivot/util/test/CharUtilsTest.java Sending core/test/org/apache/pivot/util/test/ImmutableIteratorTest.java Sending demos/src/org/apache/pivot/demos/million/LargeData.java Sending tests/src/org/apache/pivot/tests/CheckedListViewTest.java Sending tests/src/org/apache/pivot/tests/HyperlinkButtonTest.java Sending tutorials/src/org/apache/pivot/tutorials/KitchenSink.java Sending tutorials/src/org/apache/pivot/tutorials/bxmlexplorer/FakeWindowSkin.java Sending tutorials/src/org/apache/pivot/tutorials/lists/ListButtons.java Transmitting file data ...done Committing transaction... Committed revision 1830111. > Implement "checkstyle" for builds and make changes to bring code into better > compliance > --- > > Key: PIVOT-1032 > URL: https://issues.apache.org/jira/browse/PIVOT-1032 > Project: Pivot > Issue Type: Improvement >Reporter: Roger Whitcomb >Assignee: Roger Whitcomb >Priority: Minor > Attachments: 1032.diffs.txt > > > I thought it would be interesting, in addition to the "trim-whitespace" task > already implemented, to do some sort of "checkstyle" processing to evaluate > all the code to see where there might be changes to make the code more robust > and a better example of "canonical" Java style. > I hesitate to expect that we could address everything (or indeed whether we > *should*), but there might be things that would make the code better and > easier to read and maintain, and wouldn't take much effort. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (PIVOT-891) Fixes to selection logic in TextArea and TextPane
[ https://issues.apache.org/jira/browse/PIVOT-891?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16452794#comment-16452794 ] Roger Whitcomb commented on PIVOT-891: -- Add unit tests for new CharUtils methods. Sending core\src\org\apache\pivot\text\CharSpan.java Adding core\test\org\apache\pivot\util\test\CharUtilsTest.java Transmitting file data ..done Committing transaction... Committed revision 1830106. > Fixes to selection logic in TextArea and TextPane > - > > Key: PIVOT-891 > URL: https://issues.apache.org/jira/browse/PIVOT-891 > Project: Pivot > Issue Type: Improvement > Components: wtk-terra >Affects Versions: 2.0.2, 2.0.4 > Environment: All >Reporter: Roger Whitcomb >Assignee: Roger Whitcomb >Priority: Minor > Labels: text-selection > Fix For: 2.0.3, 2.1 > > > Currently (in TextArea at least) if you type Shift-Down and select a line or > two, then do Shift-Up it will extend the beginning of the area, instead of > reducing the end that you just extended. This is not how any other editor > works. > Also would like to have double-click select the "word" the mouse is pointing > to, as other editors do. > We'd like TextArea and TextPane (at least, maybe TextInput also) do the same > things. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (PIVOT-1033) Allow startup properties of the form "--switch" in addition to "--option=value"
[
https://issues.apache.org/jira/browse/PIVOT-1033?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16448793#comment-16448793
]
Roger Whitcomb commented on PIVOT-1033:
---
Implemented this:
Sending wtk\src\org\apache\pivot\wtk\BrowserApplicationContext.java
Sending wtk\src\org\apache\pivot\wtk\DesktopApplicationContext.java
Transmitting file data ..done
Committing transaction...
Committed revision 1829940.
Need to think about tests now...
> Allow startup properties of the form "--switch" in addition to
> "--option=value"
> ---
>
> Key: PIVOT-1033
> URL: https://issues.apache.org/jira/browse/PIVOT-1033
> Project: Pivot
> Issue Type: Improvement
> Components: wtk
>Reporter: Roger Whitcomb
>Assignee: Roger Whitcomb
>Priority: Minor
>
> Sometimes applications need options that are either specified or not (a
> common one is "–verbose" for instance), where there is no need for a value,
> but simply the presence (or absence) of the flag. Our current option
> processing in BrowserApplicationContext and DesktopApplicationContext will
> not allow that – it always requires "–option=value". This could be changed.
> Then the Map could have a Boolean.TRUE as the value (which could be ignored,
> of course), but the semantics would be the same as if the option were given
> as ("–option=true"), but with less typing required ("--option").
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (PIVOT-999) Update code to take advantage of Java 8 features
[ https://issues.apache.org/jira/browse/PIVOT-999?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16448787#comment-16448787 ] Roger Whitcomb commented on PIVOT-999: -- More tests: Sending core\test\org\apache\pivot\collections\test\DictionaryTest.java Transmitting file data .done Committing transaction... Committed revision 1829939. > Update code to take advantage of Java 8 features > > > Key: PIVOT-999 > URL: https://issues.apache.org/jira/browse/PIVOT-999 > Project: Pivot > Issue Type: New Feature > Components: all >Affects Versions: 2.1 > Environment: All >Reporter: Roger Whitcomb >Assignee: Roger Whitcomb >Priority: Major > Fix For: 2.1 > > > Some features that we could potentially use include: > * default methods in interfaces to extend features while maintaining backward > compatibility > * lambdas for such things as callbacks > * really use functional interfaces (already kind of present, but not really > used) > * "forEach" in many places for Iterable collections -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (PIVOT-999) Update code to take advantage of Java 8 features
[ https://issues.apache.org/jira/browse/PIVOT-999?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16448761#comment-16448761 ] Roger Whitcomb commented on PIVOT-999: -- Add tests: Sending core\test\org\apache\pivot\collections\test\DictionaryTest.java Transmitting file data .done Committing transaction... Committed revision 1829929. > Update code to take advantage of Java 8 features > > > Key: PIVOT-999 > URL: https://issues.apache.org/jira/browse/PIVOT-999 > Project: Pivot > Issue Type: New Feature > Components: all >Affects Versions: 2.1 > Environment: All >Reporter: Roger Whitcomb >Assignee: Roger Whitcomb >Priority: Major > Fix For: 2.1 > > > Some features that we could potentially use include: > * default methods in interfaces to extend features while maintaining backward > compatibility > * lambdas for such things as callbacks > * really use functional interfaces (already kind of present, but not really > used) > * "forEach" in many places for Iterable collections -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (PIVOT-999) Update code to take advantage of Java 8 features
[ https://issues.apache.org/jira/browse/PIVOT-999?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16448749#comment-16448749 ] Roger Whitcomb commented on PIVOT-999: -- Two new default methods for Dictionary: containsAny(K...) and getFirst(K...): Sending core\src\org\apache\pivot\collections\Dictionary.java Transmitting file data .done Committing transaction... Committed revision 1829922. > Update code to take advantage of Java 8 features > > > Key: PIVOT-999 > URL: https://issues.apache.org/jira/browse/PIVOT-999 > Project: Pivot > Issue Type: New Feature > Components: all >Affects Versions: 2.1 > Environment: All >Reporter: Roger Whitcomb >Assignee: Roger Whitcomb >Priority: Major > Fix For: 2.1 > > > Some features that we could potentially use include: > * default methods in interfaces to extend features while maintaining backward > compatibility > * lambdas for such things as callbacks > * really use functional interfaces (already kind of present, but not really > used) > * "forEach" in many places for Iterable collections -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Created] (PIVOT-1033) Allow startup properties of the form "--switch" in addition to "--option=value"
Roger Whitcomb created PIVOT-1033:
-
Summary: Allow startup properties of the form "--switch" in
addition to "--option=value"
Key: PIVOT-1033
URL: https://issues.apache.org/jira/browse/PIVOT-1033
Project: Pivot
Issue Type: Improvement
Components: wtk
Reporter: Roger Whitcomb
Assignee: Roger Whitcomb
Sometimes applications need options that are either specified or not (a common
one is "–verbose" for instance), where there is no need for a value, but simply
the presence (or absence) of the flag. Our current option processing in
BrowserApplicationContext and DesktopApplicationContext will not allow that –
it always requires "–option=value". This could be changed. Then the Map could
have a Boolean.TRUE as the value (which could be ignored, of course), but the
semantics would be the same as if the option were given as ("–option=true"),
but with less typing required ("--option").
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (PIVOT-1029) Need some tests of things in the various "wtk" Component classes
[ https://issues.apache.org/jira/browse/PIVOT-1029?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16431390#comment-16431390 ] Roger Whitcomb commented on PIVOT-1029: --- The "wtk/test" directory now includes the following: * BoundsTest.java * CornerRadiiTest.java * GaugeTest.java * LimitsTest.java * SpanTest.java * ColorUtilitiesTest.java * DimensionsTest.java * InsetsTest.java * MeterTest.java > Need some tests of things in the various "wtk" Component classes > > > Key: PIVOT-1029 > URL: https://issues.apache.org/jira/browse/PIVOT-1029 > Project: Pivot > Issue Type: Test > Components: tests, wtk >Reporter: Roger Whitcomb >Assignee: Roger Whitcomb >Priority: Minor > > I noticed some things that were not quite right (listener being fired always > instead of on a change) in a Component, and it occurred to me that things > like this need to be tested systematically. One way to do that would be to > introduce component-based tests in the "wtk/test" directories. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
