[PR] Bump org.apache.maven.plugins:maven-antrun-plugin from 3.0.0 to 3.1.0 [maven-archetype]
dependabot[bot] opened a new pull request, #184: URL: https://github.com/apache/maven-archetype/pull/184 Bumps [org.apache.maven.plugins:maven-antrun-plugin](https://github.com/apache/maven-antrun-plugin) from 3.0.0 to 3.1.0. Commits https://github.com/apache/maven-antrun-plugin/commit/feceee80f82e1f52a8233a19015c1ed0e4cef2ef;>feceee8 [maven-release-plugin] prepare release maven-antrun-plugin-3.1.0 https://github.com/apache/maven-antrun-plugin/commit/4e899c4314aa9e1d8ee0e6b17844c849359c42ce;>4e899c4 [MANTRUN-236] Upgrade Maven Plugin Plugin to 3.6.4 https://github.com/apache/maven-antrun-plugin/commit/61c21bd0e95cb2e4433492f00eb473d5b39fb27d;>61c21bd Update CI URL https://github.com/apache/maven-antrun-plugin/commit/b44673765e5cb4990e779d9115226510403273a7;>b446737 Bump checkstyle from 9.2.1 to 9.3 https://github.com/apache/maven-antrun-plugin/commit/43cb90edb00dfd305574820b32d368a4ae25008d;>43cb90e [MANTRUN-232] Require Maven 3.2.5 - set proper maven scopes https://github.com/apache/maven-antrun-plugin/commit/2274253cdaed396d1de6964e1c6f93ebc7502141;>2274253 Shared GitHub Actions v2 https://github.com/apache/maven-antrun-plugin/commit/7911362e0ac86b5a1120bc8f6ef451c342ec;>7911362 Bump checkstyle from 9.0.1 to 9.2.1 https://github.com/apache/maven-antrun-plugin/commit/5bb03c35533255f04d98267c5662d3b2272835c2;>5bb03c3 (doc) Update plugins before release https://github.com/apache/maven-antrun-plugin/commit/e773180d4e7d1b661efe6fa7882fcd24c11e84bc;>e773180 Bump maven-site-plugin from 3.9.1 to 3.10.0 https://github.com/apache/maven-antrun-plugin/commit/68fc8330e278b92829168e66065b5fa32086df93;>68fc833 Bump xmlunit-matchers from 2.8.3 to 2.8.4 Additional commits viewable in https://github.com/apache/maven-antrun-plugin/compare/maven-antrun-plugin-3.0.0...maven-antrun-plugin-3.1.0;>compare view [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- Dependabot commands and options You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] Bump org.codehaus.plexus:plexus-interactivity-api from 1.1 to 1.2 [maven-archetype]
dependabot[bot] opened a new pull request, #183: URL: https://github.com/apache/maven-archetype/pull/183 Bumps [org.codehaus.plexus:plexus-interactivity-api](https://github.com/codehaus-plexus/plexus-interactivity) from 1.1 to 1.2. Release notes Sourced from https://github.com/codehaus-plexus/plexus-interactivity/releases;>org.codehaus.plexus:plexus-interactivity-api's releases. plexus-interactivity-1.2 New features and improvements ensure prompter does not double colon (https://redirect.github.com/codehaus-plexus/plexus-interactivity/pull/10;>#10) https://github.com/rmannibucau;>@rmannibucau java 8 as mininum (https://redirect.github.com/codehaus-plexus/plexus-interactivity/pull/6;>#6) https://github.com/olamy;>@olamy Move off plexus (https://redirect.github.com/codehaus-plexus/plexus-interactivity/pull/49;>#49) https://github.com/cstamas;>@cstamas Dependency updates Update parent pom to plexus 16 (https://redirect.github.com/codehaus-plexus/plexus-interactivity/pull/48;>#48) https://github.com/slachiewicz;>@slachiewicz Bump org.junit.jupiter:junit-jupiter from 5.10.0 to 5.10.1 (https://redirect.github.com/codehaus-plexus/plexus-interactivity/pull/44;>#44) https://github.com/dependabot;>@dependabot Bump javax.annotation-api from 1.2 to 1.3.2 (https://redirect.github.com/codehaus-plexus/plexus-interactivity/pull/40;>#40) https://github.com/dependabot;>@dependabot JSR330 Replace plexus-container-default with javax.annotation (https://redirect.github.com/codehaus-plexus/plexus-interactivity/pull/39;>#39) https://github.com/slachiewicz;>@slachiewicz Upgrade to JUnit 5 (https://redirect.github.com/codehaus-plexus/plexus-interactivity/pull/38;>#38) https://github.com/slachiewicz;>@slachiewicz Maintenance Update parent pom to plexus 16 (https://redirect.github.com/codehaus-plexus/plexus-interactivity/pull/48;>#48) https://github.com/slachiewicz;>@slachiewicz Reuse plexus-pom action for CI (https://redirect.github.com/codehaus-plexus/plexus-interactivity/pull/46;>#46) https://github.com/slachiewicz;>@slachiewicz JSR330 Replace plexus-container-default with javax.annotation (https://redirect.github.com/codehaus-plexus/plexus-interactivity/pull/39;>#39) https://github.com/slachiewicz;>@slachiewicz Upgrade to JUnit 5 (https://redirect.github.com/codehaus-plexus/plexus-interactivity/pull/38;>#38) https://github.com/slachiewicz;>@slachiewicz Add JDK 20 to CI (https://redirect.github.com/codehaus-plexus/plexus-interactivity/pull/36;>#36) https://github.com/slachiewicz;>@slachiewicz add some ghaction, dependabot and release drafter (https://redirect.github.com/codehaus-plexus/plexus-interactivity/pull/4;>#4) https://github.com/olamy;>@olamy Commits https://github.com/codehaus-plexus/plexus-interactivity/commit/558b3bbcac0564cab42b5af0e943b1563f4f3994;>558b3bb [maven-release-plugin] prepare release plexus-interactivity-1.2 https://github.com/codehaus-plexus/plexus-interactivity/commit/79eff99176129fa88c40c5929c4fc74d09493010;>79eff99 Move off plexus https://github.com/codehaus-plexus/plexus-interactivity/commit/2da2de8427db0191a2ef36bf8c340b507c16e257;>2da2de8 Update to plexus parent pom 16 https://github.com/codehaus-plexus/plexus-interactivity/commit/5cde88e4f1c89624671d782c6f03cc297f0f3dbe;>5cde88e Reformat code https://github.com/codehaus-plexus/plexus-interactivity/commit/5827324f69705692776aa4f210d5447f20fcde0e;>5827324 Bump org.codehaus.plexus:plexus-components from 10.0 to 14.2 https://github.com/codehaus-plexus/plexus-interactivity/commit/45c2e881c5ff9ecfc5b9c41b916101bd17f41b4c;>45c2e88 Reuse plexus-pom action for CI https://github.com/codehaus-plexus/plexus-interactivity/commit/5b38c7783bc0097530e2376cf702185b362f3271;>5b38c77 Bump org.junit.jupiter:junit-jupiter from 5.10.0 to 5.10.1 https://github.com/codehaus-plexus/plexus-interactivity/commit/03433395d82177024f1ab75d2614bf1bff75cbeb;>0343339 Bump actions/checkout from 3 to 4 https://github.com/codehaus-plexus/plexus-interactivity/commit/e4a0551e7097bdfd361fe48b027fdf7f5b9c8dcd;>e4a0551 Bump org.junit.jupiter:junit-jupiter from 5.9.3 to 5.10.0 https://github.com/codehaus-plexus/plexus-interactivity/commit/fdd1ff98809559404d4d4188dab2f9dc840e359d;>fdd1ff9 Bump javax.annotation-api from 1.2 to 1.3.2 Additional commits viewable in https://github.com/codehaus-plexus/plexus-interactivity/compare/plexus-interactivity-1.1...plexus-interactivity-1.2;>compare view [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you
[jira] [Commented] (MARCHETYPES-56) finish maven-archetype-profiles
[ https://issues.apache.org/jira/browse/MARCHETYPES-56?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17802327#comment-17802327 ] Sylwester Lachiewicz commented on MARCHETYPES-56: - nowadays, maybe drop it? > finish maven-archetype-profiles > --- > > Key: MARCHETYPES-56 > URL: https://issues.apache.org/jira/browse/MARCHETYPES-56 > Project: Maven Archetype Bundles > Issue Type: Task >Reporter: Herve Boutemy >Priority: Major > > this is a WIP that was never finished: there is still no profile in generated > pom.xml... -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (MARCHETYPES-66) Updating archetype-samples servlet and jdk versions
[ https://issues.apache.org/jira/browse/MARCHETYPES-66?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sylwester Lachiewicz updated MARCHETYPES-66: Fix Version/s: 1.5 > Updating archetype-samples servlet and jdk versions > --- > > Key: MARCHETYPES-66 > URL: https://issues.apache.org/jira/browse/MARCHETYPES-66 > Project: Maven Archetype Bundles > Issue Type: Improvement >Reporter: Vitalij Zadneprovskij >Priority: Minor > Fix For: 1.5 > > > It would be great if we could update the versions of archetype-samples to be > servlet 3.1 and jdk 8. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (MARCHETYPES-78) Update default Java version in archetype projects to 1.8
[
https://issues.apache.org/jira/browse/MARCHETYPES-78?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Sylwester Lachiewicz updated MARCHETYPES-78:
Fix Version/s: 1.5
> Update default Java version in archetype projects to 1.8
>
>
> Key: MARCHETYPES-78
> URL: https://issues.apache.org/jira/browse/MARCHETYPES-78
> Project: Maven Archetype Bundles
> Issue Type: Improvement
>Reporter: jiri vanek
>Assignee: Elliotte Rusty Harold
>Priority: Major
> Fix For: 1.5
>
>
> namely at least
> maven-archetype-plugin/src/main/resources-filtered/archetype-resources/pom.xml
> maven-archetype-archetype/src/main/resources-filtered/archetype-resources/src/main/resources/archetype-resources/pom.xml
> maven-archetype-archetype/src/main/resources-filtered/archetype-resources/pom.xml
> maven-archetype-profiles/src/main/resources-filtered/archetype-resources/pom.xml
> maven-archetype-simple/src/main/resources-filtered/archetype-resources/pom.xml
> maven-archetype-portlet/src/main/resources-filtered/archetype-resources/pom.xml
> maven-archetype-quickstart/src/main/resources-filtered/archetype-resources/pom.xml
> still use 1.7 as default version.
> I'm happy to fix them all (see
> https://github.com/apache/maven-archetypes/pull/18 and
> https://issues.apache.org/jira/projects/MARCHETYPES/issues/MARCHETYPES-76),
> but first I need some ack from somebody with commit permissions to
> MARCHETYPES/https://github.com/apache/maven-archetypes
> {code:java}
> grep -ir -e maven.compiler.source -e maven.compiler.target| grep -v test
> maven-archetype-plugin/src/main/resources-filtered/archetype-resources/pom.xml:
> 1.7
> maven-archetype-plugin/src/main/resources-filtered/archetype-resources/pom.xml:
> 1.7
> maven-archetype-archetype/src/main/resources-filtered/archetype-resources/src/main/resources/archetype-resources/pom.xml:
> 1.7
> maven-archetype-archetype/src/main/resources-filtered/archetype-resources/src/main/resources/archetype-resources/pom.xml:
> 1.7
> maven-archetype-archetype/src/main/resources-filtered/archetype-resources/pom.xml:
> 1.7
> maven-archetype-archetype/src/main/resources-filtered/archetype-resources/pom.xml:
> 1.7
> maven-archetype-profiles/src/main/resources-filtered/archetype-resources/pom.xml:
> 1.7
> maven-archetype-profiles/src/main/resources-filtered/archetype-resources/pom.xml:
> 1.7
> maven-archetype-webapp/src/main/resources-filtered/archetype-resources/pom.xml:
> 1.8
> maven-archetype-webapp/src/main/resources-filtered/archetype-resources/pom.xml:
> 1.8
> maven-archetype-simple/src/main/resources-filtered/archetype-resources/pom.xml:
> 1.7
> maven-archetype-simple/src/main/resources-filtered/archetype-resources/pom.xml:
> 1.7
> maven-archetype-portlet/src/main/resources-filtered/archetype-resources/pom.xml:
> 1.7
> maven-archetype-portlet/src/main/resources-filtered/archetype-resources/pom.xml:
> 1.7
> maven-archetype-quickstart/src/main/resources-filtered/archetype-resources/pom.xml:
> ${jcv}
> maven-archetype-quickstart/src/main/resources-filtered/archetype-resources/pom.xml:
> ${jcv}
> {code}
> with tests:
> {code:java}
> grep -ir -e maven.compiler.source -e maven.compiler.target
> maven-archetype-plugin/src/main/resources-filtered/archetype-resources/pom.xml:
> 1.7
> maven-archetype-plugin/src/main/resources-filtered/archetype-resources/pom.xml:
> 1.7
> maven-archetype-archetype/src/main/resources-filtered/archetype-resources/src/main/resources/archetype-resources/pom.xml:
> 1.7
> maven-archetype-archetype/src/main/resources-filtered/archetype-resources/src/main/resources/archetype-resources/pom.xml:
> 1.7
> maven-archetype-archetype/src/main/resources-filtered/archetype-resources/pom.xml:
> 1.7
> maven-archetype-archetype/src/main/resources-filtered/archetype-resources/pom.xml:
> 1.7
> maven-archetype-profiles/src/main/resources-filtered/archetype-resources/pom.xml:
> 1.7
> maven-archetype-profiles/src/main/resources-filtered/archetype-resources/pom.xml:
> 1.7
> maven-archetype-webapp/src/main/resources-filtered/archetype-resources/pom.xml:
> 1.8
> maven-archetype-webapp/src/main/resources-filtered/archetype-resources/pom.xml:
> 1.8
> maven-archetype-simple/src/main/resources-filtered/archetype-resources/pom.xml:
> 1.7
> maven-archetype-simple/src/main/resources-filtered/archetype-resources/pom.xml:
> 1.7
> maven-archetype-portlet/src/main/resources-filtered/archetype-resources/pom.xml:
> 1.7
> maven-archetype-portlet/src/main/resources-filtered/archetype-resources/pom.xml:
> 1.7
> maven-archetype-quickstart/src/main/resources-filtered/archetype-resources/pom.xml:
> ${jcv}
>
[jira] [Closed] (MARCHETYPES-76) maven-archetype-quickstart generates EOLed maven.compiler setup
[ https://issues.apache.org/jira/browse/MARCHETYPES-76?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sylwester Lachiewicz closed MARCHETYPES-76. --- Resolution: Fixed > maven-archetype-quickstart generates EOLed maven.compiler setup > > > Key: MARCHETYPES-76 > URL: https://issues.apache.org/jira/browse/MARCHETYPES-76 > Project: Maven Archetype Bundles > Issue Type: Bug > Components: Maven Quickstart Archetype >Reporter: jiri vanek >Priority: Major > > The default imput to #compilerProperties is 1.7, which is making any > generated project to be not buildable with fresh jdk21. The default should > be1.8. Where jdk8 is still live and jdk21 is still comaptible with it. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Updated] (MARCHETYPES-76) maven-archetype-quickstart generates EOLed maven.compiler setup
[ https://issues.apache.org/jira/browse/MARCHETYPES-76?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sylwester Lachiewicz updated MARCHETYPES-76: Fix Version/s: 1.5 > maven-archetype-quickstart generates EOLed maven.compiler setup > > > Key: MARCHETYPES-76 > URL: https://issues.apache.org/jira/browse/MARCHETYPES-76 > Project: Maven Archetype Bundles > Issue Type: Bug > Components: Maven Quickstart Archetype >Reporter: jiri vanek >Priority: Major > Fix For: 1.5 > > > The default imput to #compilerProperties is 1.7, which is making any > generated project to be not buildable with fresh jdk21. The default should > be1.8. Where jdk8 is still live and jdk21 is still comaptible with it. -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] Bump org.junit:junit-bom from 5.9.3 to 5.10.1 [maven-surefire]
elharo commented on PR #685: URL: https://github.com/apache/maven-surefire/pull/685#issuecomment-1875960183 @dependabot rebase -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump org.apache.maven.wagon:wagon-http-lightweight from 3.5.1 to 3.5.3 [maven-surefire]
elharo merged PR #699: URL: https://github.com/apache/maven-surefire/pull/699 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Closed] (MARCHETYPES-78) Update default Java version in archetype projects to 1.8
[
https://issues.apache.org/jira/browse/MARCHETYPES-78?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Elliotte Rusty Harold closed MARCHETYPES-78.
> Update default Java version in archetype projects to 1.8
>
>
> Key: MARCHETYPES-78
> URL: https://issues.apache.org/jira/browse/MARCHETYPES-78
> Project: Maven Archetype Bundles
> Issue Type: Improvement
>Reporter: jiri vanek
>Assignee: Elliotte Rusty Harold
>Priority: Major
>
> namely at least
> maven-archetype-plugin/src/main/resources-filtered/archetype-resources/pom.xml
> maven-archetype-archetype/src/main/resources-filtered/archetype-resources/src/main/resources/archetype-resources/pom.xml
> maven-archetype-archetype/src/main/resources-filtered/archetype-resources/pom.xml
> maven-archetype-profiles/src/main/resources-filtered/archetype-resources/pom.xml
> maven-archetype-simple/src/main/resources-filtered/archetype-resources/pom.xml
> maven-archetype-portlet/src/main/resources-filtered/archetype-resources/pom.xml
> maven-archetype-quickstart/src/main/resources-filtered/archetype-resources/pom.xml
> still use 1.7 as default version.
> I'm happy to fix them all (see
> https://github.com/apache/maven-archetypes/pull/18 and
> https://issues.apache.org/jira/projects/MARCHETYPES/issues/MARCHETYPES-76),
> but first I need some ack from somebody with commit permissions to
> MARCHETYPES/https://github.com/apache/maven-archetypes
> {code:java}
> grep -ir -e maven.compiler.source -e maven.compiler.target| grep -v test
> maven-archetype-plugin/src/main/resources-filtered/archetype-resources/pom.xml:
> 1.7
> maven-archetype-plugin/src/main/resources-filtered/archetype-resources/pom.xml:
> 1.7
> maven-archetype-archetype/src/main/resources-filtered/archetype-resources/src/main/resources/archetype-resources/pom.xml:
> 1.7
> maven-archetype-archetype/src/main/resources-filtered/archetype-resources/src/main/resources/archetype-resources/pom.xml:
> 1.7
> maven-archetype-archetype/src/main/resources-filtered/archetype-resources/pom.xml:
> 1.7
> maven-archetype-archetype/src/main/resources-filtered/archetype-resources/pom.xml:
> 1.7
> maven-archetype-profiles/src/main/resources-filtered/archetype-resources/pom.xml:
> 1.7
> maven-archetype-profiles/src/main/resources-filtered/archetype-resources/pom.xml:
> 1.7
> maven-archetype-webapp/src/main/resources-filtered/archetype-resources/pom.xml:
> 1.8
> maven-archetype-webapp/src/main/resources-filtered/archetype-resources/pom.xml:
> 1.8
> maven-archetype-simple/src/main/resources-filtered/archetype-resources/pom.xml:
> 1.7
> maven-archetype-simple/src/main/resources-filtered/archetype-resources/pom.xml:
> 1.7
> maven-archetype-portlet/src/main/resources-filtered/archetype-resources/pom.xml:
> 1.7
> maven-archetype-portlet/src/main/resources-filtered/archetype-resources/pom.xml:
> 1.7
> maven-archetype-quickstart/src/main/resources-filtered/archetype-resources/pom.xml:
> ${jcv}
> maven-archetype-quickstart/src/main/resources-filtered/archetype-resources/pom.xml:
> ${jcv}
> {code}
> with tests:
> {code:java}
> grep -ir -e maven.compiler.source -e maven.compiler.target
> maven-archetype-plugin/src/main/resources-filtered/archetype-resources/pom.xml:
> 1.7
> maven-archetype-plugin/src/main/resources-filtered/archetype-resources/pom.xml:
> 1.7
> maven-archetype-archetype/src/main/resources-filtered/archetype-resources/src/main/resources/archetype-resources/pom.xml:
> 1.7
> maven-archetype-archetype/src/main/resources-filtered/archetype-resources/src/main/resources/archetype-resources/pom.xml:
> 1.7
> maven-archetype-archetype/src/main/resources-filtered/archetype-resources/pom.xml:
> 1.7
> maven-archetype-archetype/src/main/resources-filtered/archetype-resources/pom.xml:
> 1.7
> maven-archetype-profiles/src/main/resources-filtered/archetype-resources/pom.xml:
> 1.7
> maven-archetype-profiles/src/main/resources-filtered/archetype-resources/pom.xml:
> 1.7
> maven-archetype-webapp/src/main/resources-filtered/archetype-resources/pom.xml:
> 1.8
> maven-archetype-webapp/src/main/resources-filtered/archetype-resources/pom.xml:
> 1.8
> maven-archetype-simple/src/main/resources-filtered/archetype-resources/pom.xml:
> 1.7
> maven-archetype-simple/src/main/resources-filtered/archetype-resources/pom.xml:
> 1.7
> maven-archetype-portlet/src/main/resources-filtered/archetype-resources/pom.xml:
> 1.7
> maven-archetype-portlet/src/main/resources-filtered/archetype-resources/pom.xml:
> 1.7
> maven-archetype-quickstart/src/main/resources-filtered/archetype-resources/pom.xml:
> ${jcv}
> maven-archetype-quickstart/src/main/resources-filtered/archetype-resources/pom.xml:
> ${jcv}
>
[jira] [Resolved] (MARCHETYPES-78) Update default Java version in archetype projects to 1.8
[
https://issues.apache.org/jira/browse/MARCHETYPES-78?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Elliotte Rusty Harold resolved MARCHETYPES-78.
--
Resolution: Fixed
> Update default Java version in archetype projects to 1.8
>
>
> Key: MARCHETYPES-78
> URL: https://issues.apache.org/jira/browse/MARCHETYPES-78
> Project: Maven Archetype Bundles
> Issue Type: Improvement
>Reporter: jiri vanek
>Assignee: Elliotte Rusty Harold
>Priority: Major
>
> namely at least
> maven-archetype-plugin/src/main/resources-filtered/archetype-resources/pom.xml
> maven-archetype-archetype/src/main/resources-filtered/archetype-resources/src/main/resources/archetype-resources/pom.xml
> maven-archetype-archetype/src/main/resources-filtered/archetype-resources/pom.xml
> maven-archetype-profiles/src/main/resources-filtered/archetype-resources/pom.xml
> maven-archetype-simple/src/main/resources-filtered/archetype-resources/pom.xml
> maven-archetype-portlet/src/main/resources-filtered/archetype-resources/pom.xml
> maven-archetype-quickstart/src/main/resources-filtered/archetype-resources/pom.xml
> still use 1.7 as default version.
> I'm happy to fix them all (see
> https://github.com/apache/maven-archetypes/pull/18 and
> https://issues.apache.org/jira/projects/MARCHETYPES/issues/MARCHETYPES-76),
> but first I need some ack from somebody with commit permissions to
> MARCHETYPES/https://github.com/apache/maven-archetypes
> {code:java}
> grep -ir -e maven.compiler.source -e maven.compiler.target| grep -v test
> maven-archetype-plugin/src/main/resources-filtered/archetype-resources/pom.xml:
> 1.7
> maven-archetype-plugin/src/main/resources-filtered/archetype-resources/pom.xml:
> 1.7
> maven-archetype-archetype/src/main/resources-filtered/archetype-resources/src/main/resources/archetype-resources/pom.xml:
> 1.7
> maven-archetype-archetype/src/main/resources-filtered/archetype-resources/src/main/resources/archetype-resources/pom.xml:
> 1.7
> maven-archetype-archetype/src/main/resources-filtered/archetype-resources/pom.xml:
> 1.7
> maven-archetype-archetype/src/main/resources-filtered/archetype-resources/pom.xml:
> 1.7
> maven-archetype-profiles/src/main/resources-filtered/archetype-resources/pom.xml:
> 1.7
> maven-archetype-profiles/src/main/resources-filtered/archetype-resources/pom.xml:
> 1.7
> maven-archetype-webapp/src/main/resources-filtered/archetype-resources/pom.xml:
> 1.8
> maven-archetype-webapp/src/main/resources-filtered/archetype-resources/pom.xml:
> 1.8
> maven-archetype-simple/src/main/resources-filtered/archetype-resources/pom.xml:
> 1.7
> maven-archetype-simple/src/main/resources-filtered/archetype-resources/pom.xml:
> 1.7
> maven-archetype-portlet/src/main/resources-filtered/archetype-resources/pom.xml:
> 1.7
> maven-archetype-portlet/src/main/resources-filtered/archetype-resources/pom.xml:
> 1.7
> maven-archetype-quickstart/src/main/resources-filtered/archetype-resources/pom.xml:
> ${jcv}
> maven-archetype-quickstart/src/main/resources-filtered/archetype-resources/pom.xml:
> ${jcv}
> {code}
> with tests:
> {code:java}
> grep -ir -e maven.compiler.source -e maven.compiler.target
> maven-archetype-plugin/src/main/resources-filtered/archetype-resources/pom.xml:
> 1.7
> maven-archetype-plugin/src/main/resources-filtered/archetype-resources/pom.xml:
> 1.7
> maven-archetype-archetype/src/main/resources-filtered/archetype-resources/src/main/resources/archetype-resources/pom.xml:
> 1.7
> maven-archetype-archetype/src/main/resources-filtered/archetype-resources/src/main/resources/archetype-resources/pom.xml:
> 1.7
> maven-archetype-archetype/src/main/resources-filtered/archetype-resources/pom.xml:
> 1.7
> maven-archetype-archetype/src/main/resources-filtered/archetype-resources/pom.xml:
> 1.7
> maven-archetype-profiles/src/main/resources-filtered/archetype-resources/pom.xml:
> 1.7
> maven-archetype-profiles/src/main/resources-filtered/archetype-resources/pom.xml:
> 1.7
> maven-archetype-webapp/src/main/resources-filtered/archetype-resources/pom.xml:
> 1.8
> maven-archetype-webapp/src/main/resources-filtered/archetype-resources/pom.xml:
> 1.8
> maven-archetype-simple/src/main/resources-filtered/archetype-resources/pom.xml:
> 1.7
> maven-archetype-simple/src/main/resources-filtered/archetype-resources/pom.xml:
> 1.7
> maven-archetype-portlet/src/main/resources-filtered/archetype-resources/pom.xml:
> 1.7
> maven-archetype-portlet/src/main/resources-filtered/archetype-resources/pom.xml:
> 1.7
> maven-archetype-quickstart/src/main/resources-filtered/archetype-resources/pom.xml:
> ${jcv}
> maven-archetype-quickstart/src/main/resources-filtered/archetype-resources/pom.xml:
>
[jira] [Commented] (DOXIASITETOOLS-323) Upgrade components
[
https://issues.apache.org/jira/browse/DOXIASITETOOLS-323?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17802319#comment-17802319
]
ASF GitHub Bot commented on DOXIASITETOOLS-323:
---
kwin commented on code in PR #125:
URL:
https://github.com/apache/maven-doxia-sitetools/pull/125#discussion_r1440916439
##
doxia-integration-tools/pom.xml:
##
@@ -86,9 +86,15 @@
provided
- org.apache.maven
- maven-plugin-api
- ${mavenVersion}
+ org.eclipse.aether
+ aether-api
+ ${aetherVersion}
+ provided
+
+
+ org.eclipse.aether
+ aether-impl
Review Comment:
To make m-dependency-p work correctly and to reduce the (compile) classpath
of this module itself (it won’t have an effect on referencing projects as you
noticed correctly). I consider this best practice given that Maven < 4 lacks a
proper API artifact.
> Upgrade components
> --
>
> Key: DOXIASITETOOLS-323
> URL: https://issues.apache.org/jira/browse/DOXIASITETOOLS-323
> Project: Maven Doxia Sitetools
> Issue Type: Dependency upgrade
>Reporter: Michael Osipov
>Assignee: Michael Osipov
>Priority: Major
> Fix For: 2.0.0, 2.0.0-M17
>
>
> * Upgrade to Plexus Interpolation 1.27
> * Upgrade to Plexus Testing 1.3.0
> * Upgrade to Plexus Velocity 2.1.0
> * Upgrade to Commons Lang 3.14.0
> * Upgrade to Commons IO 2.15.1
> * Upgrade to JUnit 5.10.1
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
Re: [PR] [DOXIASITETOOLS-323] Upgrade components [maven-doxia-sitetools]
kwin commented on code in PR #125:
URL:
https://github.com/apache/maven-doxia-sitetools/pull/125#discussion_r1440916439
##
doxia-integration-tools/pom.xml:
##
@@ -86,9 +86,15 @@
provided
- org.apache.maven
- maven-plugin-api
- ${mavenVersion}
+ org.eclipse.aether
+ aether-api
+ ${aetherVersion}
+ provided
+
+
+ org.eclipse.aether
+ aether-impl
Review Comment:
To make m-dependency-p work correctly and to reduce the (compile) classpath
of this module itself (it won’t have an effect on referencing projects as you
noticed correctly). I consider this best practice given that Maven < 4 lacks a
proper API artifact.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[PR] Correct reporting - maven-plugin-report-plugin [maven-archetype]
slachiewicz opened a new pull request, #182: URL: https://github.com/apache/maven-archetype/pull/182 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (DOXIASITETOOLS-323) Upgrade components
[
https://issues.apache.org/jira/browse/DOXIASITETOOLS-323?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17802318#comment-17802318
]
ASF GitHub Bot commented on DOXIASITETOOLS-323:
---
kwin commented on code in PR #125:
URL:
https://github.com/apache/maven-doxia-sitetools/pull/125#discussion_r1440916439
##
doxia-integration-tools/pom.xml:
##
@@ -86,9 +86,15 @@
provided
- org.apache.maven
- maven-plugin-api
- ${mavenVersion}
+ org.eclipse.aether
+ aether-api
+ ${aetherVersion}
+ provided
+
+
+ org.eclipse.aether
+ aether-impl
Review Comment:
To make m-dependency-p work correctly and to reduce the classpath of this
module itself (it won’t have an effect on referencing projects as you noticed
correctly). I consider this best practice given that Maven < 4 lacks a proper
API artifact.
> Upgrade components
> --
>
> Key: DOXIASITETOOLS-323
> URL: https://issues.apache.org/jira/browse/DOXIASITETOOLS-323
> Project: Maven Doxia Sitetools
> Issue Type: Dependency upgrade
>Reporter: Michael Osipov
>Assignee: Michael Osipov
>Priority: Major
> Fix For: 2.0.0, 2.0.0-M17
>
>
> * Upgrade to Plexus Interpolation 1.27
> * Upgrade to Plexus Testing 1.3.0
> * Upgrade to Plexus Velocity 2.1.0
> * Upgrade to Commons Lang 3.14.0
> * Upgrade to Commons IO 2.15.1
> * Upgrade to JUnit 5.10.1
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
Re: [PR] [DOXIASITETOOLS-323] Upgrade components [maven-doxia-sitetools]
kwin commented on code in PR #125:
URL:
https://github.com/apache/maven-doxia-sitetools/pull/125#discussion_r1440916439
##
doxia-integration-tools/pom.xml:
##
@@ -86,9 +86,15 @@
provided
- org.apache.maven
- maven-plugin-api
- ${mavenVersion}
+ org.eclipse.aether
+ aether-api
+ ${aetherVersion}
+ provided
+
+
+ org.eclipse.aether
+ aether-impl
Review Comment:
To make m-dependency-p work correctly and to reduce the classpath of this
module itself (it won’t have an effect on referencing projects as you noticed
correctly). I consider this best practice given that Maven < 4 lacks a proper
API artifact.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Commented] (MNG-6776) Inconsistent list of parameters in MojoDescriptor
[ https://issues.apache.org/jira/browse/MNG-6776?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17802314#comment-17802314 ] ASF GitHub Bot commented on MNG-6776: - slawekjaranowski commented on code in PR #1361: URL: https://github.com/apache/maven/pull/1361#discussion_r1440897194 ## maven-plugin-api/src/main/java/org/apache/maven/plugin/descriptor/MojoDescriptor.java: ## @@ -51,9 +52,7 @@ public class MojoDescriptor extends ComponentDescriptor implements Cloneab private static final String DEFAULT_LANGUAGE = "java"; -private List parameters; - -private Map parameterMap; +private final ArrayList parameters; Review Comment: Ok I see a source commit > Inconsistent list of parameters in MojoDescriptor > - > > Key: MNG-6776 > URL: https://issues.apache.org/jira/browse/MNG-6776 > Project: Maven > Issue Type: Bug > Components: Plugin API >Affects Versions: 3.6.2 >Reporter: Sylwester Lachiewicz >Assignee: Tamas Cservenak >Priority: Minor > Time Spent: 10m > Remaining Estimate: 0h > > While working with maven-plugin-tools I discovered inconsistent results > returned from MojoDescriptor getParameters() and getParametersMap(). > In > [AntMojoDescriptorExtractor.java#L101|https://github.com/apache/maven-plugin-tools/blob/master/maven-script/maven-plugin-tools-ant/src/main/java/org/apache/maven/tools/plugin/extractor/ant/AntMojoDescriptorExtractor.java#L101] > If first I call MojoDescriptor.getParameterMap() and then later add parameter > via MojoDescriptor.addParameter - MojoDescriptor.getParameterMap() will still > return map with old (cached) list with parameters. -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] [MNG-6776] Inconsistent list of parameters for MojoDescriptor (#584) [maven]
slawekjaranowski commented on code in PR #1361: URL: https://github.com/apache/maven/pull/1361#discussion_r1440897194 ## maven-plugin-api/src/main/java/org/apache/maven/plugin/descriptor/MojoDescriptor.java: ## @@ -51,9 +52,7 @@ public class MojoDescriptor extends ComponentDescriptor implements Cloneab private static final String DEFAULT_LANGUAGE = "java"; -private List parameters; - -private Map parameterMap; +private final ArrayList parameters; Review Comment: Ok I see a source commit -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (MNG-7309) Remove redundant MojoDescriptor parameterMap
[ https://issues.apache.org/jira/browse/MNG-7309?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael Osipov updated MNG-7309: Fix Version/s: 3.9.x-candidate > Remove redundant MojoDescriptor parameterMap > > > Key: MNG-7309 > URL: https://issues.apache.org/jira/browse/MNG-7309 > Project: Maven > Issue Type: Task > Components: Core >Reporter: Tamas Cservenak >Assignee: Tamas Cservenak >Priority: Major > Fix For: 3.9.x-candidate, 4.0.0-alpha-2, 4.0.0 > > > The class maven-plugin-api:MojoDescriptor contains a list of parameters and a > map of parameters: > https://maven.apache.org/ref/3.8.4/maven-plugin-api/xref/org/apache/maven/plugin/descriptor/MojoDescriptor.html#L58 > The code is broken, in a way that the two – that should contain same things – > may end up not containing same things. > Note: not that anything uses it in such way, as instances of this class are > loaded up from descriptor, but still, it may easily lead to confusion. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MNG-6776) Inconsistent list of parameters in MojoDescriptor
[ https://issues.apache.org/jira/browse/MNG-6776?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17802310#comment-17802310 ] ASF GitHub Bot commented on MNG-6776: - michael-o commented on code in PR #1361: URL: https://github.com/apache/maven/pull/1361#discussion_r1440868896 ## maven-plugin-api/src/main/java/org/apache/maven/plugin/descriptor/MojoDescriptor.java: ## @@ -51,9 +52,7 @@ public class MojoDescriptor extends ComponentDescriptor implements Cloneab private static final String DEFAULT_LANGUAGE = "java"; -private List parameters; - -private Map parameterMap; +private final ArrayList parameters; Review Comment: Can, you have to complain to @cstamas. I'd like to leave as-is to make backports as easy as possible. > Inconsistent list of parameters in MojoDescriptor > - > > Key: MNG-6776 > URL: https://issues.apache.org/jira/browse/MNG-6776 > Project: Maven > Issue Type: Bug > Components: Plugin API >Affects Versions: 3.6.2 >Reporter: Sylwester Lachiewicz >Assignee: Tamas Cservenak >Priority: Minor > Time Spent: 10m > Remaining Estimate: 0h > > While working with maven-plugin-tools I discovered inconsistent results > returned from MojoDescriptor getParameters() and getParametersMap(). > In > [AntMojoDescriptorExtractor.java#L101|https://github.com/apache/maven-plugin-tools/blob/master/maven-script/maven-plugin-tools-ant/src/main/java/org/apache/maven/tools/plugin/extractor/ant/AntMojoDescriptorExtractor.java#L101] > If first I call MojoDescriptor.getParameterMap() and then later add parameter > via MojoDescriptor.addParameter - MojoDescriptor.getParameterMap() will still > return map with old (cached) list with parameters. -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] [MNG-6776] Inconsistent list of parameters for MojoDescriptor (#584) [maven]
michael-o commented on code in PR #1361: URL: https://github.com/apache/maven/pull/1361#discussion_r1440868896 ## maven-plugin-api/src/main/java/org/apache/maven/plugin/descriptor/MojoDescriptor.java: ## @@ -51,9 +52,7 @@ public class MojoDescriptor extends ComponentDescriptor implements Cloneab private static final String DEFAULT_LANGUAGE = "java"; -private List parameters; - -private Map parameterMap; +private final ArrayList parameters; Review Comment: Can, you have to complain to @cstamas. I'd like to leave as-is to make backports as easy as possible. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (DOXIASITETOOLS-323) Upgrade components
[
https://issues.apache.org/jira/browse/DOXIASITETOOLS-323?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17802309#comment-17802309
]
ASF GitHub Bot commented on DOXIASITETOOLS-323:
---
michael-o commented on code in PR #125:
URL:
https://github.com/apache/maven-doxia-sitetools/pull/125#discussion_r1440867789
##
doxia-integration-tools/pom.xml:
##
@@ -86,9 +86,15 @@
provided
- org.apache.maven
- maven-plugin-api
- ${mavenVersion}
+ org.eclipse.aether
+ aether-api
+ ${aetherVersion}
+ provided
+
+
+ org.eclipse.aether
+ aether-impl
Review Comment:
I see this and `maven-core` is in `provided` scope, why should we exclude
all deps? Moreover, we don't exclude in other components. I don't fully
understand the reasoning.
Tree:
```
[INFO] +- org.apache.maven:maven-core:jar:3.2.5:provided
[INFO] | +- org.apache.maven:maven-settings:jar:3.2.5:provided
[INFO] | +- org.apache.maven:maven-settings-builder:jar:3.2.5:provided
[INFO] | +- org.apache.maven:maven-repository-metadata:jar:3.2.5:provided
[INFO] | +- org.apache.maven:maven-plugin-api:jar:3.2.5:provided
[INFO] | +- org.apache.maven:maven-model-builder:jar:3.2.5:provided
[INFO] | +- org.eclipse.aether:aether-util:jar:1.0.0.v20140518:provided
[INFO] | +- org.sonatype.sisu:sisu-guice:jar:no_aop:3.2.3:provided
[INFO] | +- org.codehaus.plexus:plexus-classworlds:jar:2.5.2:compile
[INFO] | +-
org.codehaus.plexus:plexus-component-annotations:jar:1.5.5:compile
[INFO] | \- org.sonatype.plexus:plexus-sec-dispatcher:jar:1.3:provided
[INFO] | \- org.sonatype.plexus:plexus-cipher:jar:1.4:provided
```
> Upgrade components
> --
>
> Key: DOXIASITETOOLS-323
> URL: https://issues.apache.org/jira/browse/DOXIASITETOOLS-323
> Project: Maven Doxia Sitetools
> Issue Type: Dependency upgrade
>Reporter: Michael Osipov
>Assignee: Michael Osipov
>Priority: Major
> Fix For: 2.0.0, 2.0.0-M17
>
>
> * Upgrade to Plexus Interpolation 1.27
> * Upgrade to Plexus Testing 1.3.0
> * Upgrade to Plexus Velocity 2.1.0
> * Upgrade to Commons Lang 3.14.0
> * Upgrade to Commons IO 2.15.1
> * Upgrade to JUnit 5.10.1
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
Re: [PR] [DOXIASITETOOLS-323] Upgrade components [maven-doxia-sitetools]
michael-o commented on code in PR #125:
URL:
https://github.com/apache/maven-doxia-sitetools/pull/125#discussion_r1440867789
##
doxia-integration-tools/pom.xml:
##
@@ -86,9 +86,15 @@
provided
- org.apache.maven
- maven-plugin-api
- ${mavenVersion}
+ org.eclipse.aether
+ aether-api
+ ${aetherVersion}
+ provided
+
+
+ org.eclipse.aether
+ aether-impl
Review Comment:
I see this and `maven-core` is in `provided` scope, why should we exclude
all deps? Moreover, we don't exclude in other components. I don't fully
understand the reasoning.
Tree:
```
[INFO] +- org.apache.maven:maven-core:jar:3.2.5:provided
[INFO] | +- org.apache.maven:maven-settings:jar:3.2.5:provided
[INFO] | +- org.apache.maven:maven-settings-builder:jar:3.2.5:provided
[INFO] | +- org.apache.maven:maven-repository-metadata:jar:3.2.5:provided
[INFO] | +- org.apache.maven:maven-plugin-api:jar:3.2.5:provided
[INFO] | +- org.apache.maven:maven-model-builder:jar:3.2.5:provided
[INFO] | +- org.eclipse.aether:aether-util:jar:1.0.0.v20140518:provided
[INFO] | +- org.sonatype.sisu:sisu-guice:jar:no_aop:3.2.3:provided
[INFO] | +- org.codehaus.plexus:plexus-classworlds:jar:2.5.2:compile
[INFO] | +-
org.codehaus.plexus:plexus-component-annotations:jar:1.5.5:compile
[INFO] | \- org.sonatype.plexus:plexus-sec-dispatcher:jar:1.3:provided
[INFO] | \- org.sonatype.plexus:plexus-cipher:jar:1.4:provided
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] Bump org.assertj:assertj-core from 3.24.2 to 3.25.0 [maven-archiver]
dependabot[bot] commented on PR #49: URL: https://github.com/apache/maven-archiver/pull/49#issuecomment-1875849711 Superseded by #50. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump org.assertj:assertj-core from 3.24.2 to 3.25.0 [maven-archiver]
dependabot[bot] closed pull request #49: Bump org.assertj:assertj-core from 3.24.2 to 3.25.0 URL: https://github.com/apache/maven-archiver/pull/49 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] Bump org.assertj:assertj-core from 3.24.2 to 3.25.1 [maven-archiver]
dependabot[bot] opened a new pull request, #50: URL: https://github.com/apache/maven-archiver/pull/50 Bumps [org.assertj:assertj-core](https://github.com/assertj/assertj) from 3.24.2 to 3.25.1. Release notes Sourced from https://github.com/assertj/assertj/releases;>org.assertj:assertj-core's releases. v3.25.1 :jigsaw: Binary Compatibility The release is: Binary compatible with the previous minor version. Binary incompatible with the previous patch version. :bug: Bug Fixes Core Revert Provide value when assertThatThrownBy/thenThrownBy fail https://redirect.github.com/assertj/assertj/issues/3318;>#3318 Revert fix: containsExactly does not work properly with maps not using equals to compare keys https://redirect.github.com/assertj/assertj/issues/3321;>#3321 v3.25.0 :jigsaw: Binary Compatibility The release is https://assertj.github.io/doc/#binary-compatibility;>binary compatible with the previous minor version. :no_entry_sign: Deprecated Core Deprecate the following date/time related assertions in favor of isCloseTo: isEqualToIgnoringHours isEqualToIgnoringMinutes isEqualToIgnoringSeconds isEqualToIgnoringMillis isEqualToIgnoringNanos isInSameHourAs isInSameMinuteAs isInSameSecondAs Deprecate asList in favor of asInstanceOf https://redirect.github.com/assertj/assertj/issues/3138;>#3138 :sparkles: New Features Core Add Descriptable#describedAs(SupplierString) Add isInThePast and isInTheFuture to LocalDate assertions https://redirect.github.com/assertj/assertj/issues/2933;>#2933 Add isInThePast and isInTheFuture to the missing Java 8 date/time types https://redirect.github.com/assertj/assertj/issues/2947;>#2947 Add isRecord and isNotRecord to Class assertions https://redirect.github.com/assertj/assertj/issues/2968;>#2968 Add hasNullValue and doesNotHaveNullValue to AtomicReferenceAssert https://redirect.github.com/assertj/assertj/issues/2969;>#2969 Add asBoolean|Byte|Short|Int|Long|Float|Double to String assertions https://redirect.github.com/assertj/assertj/issues/2580;>#2580 Add hasRecordComponents to Class assertions https://redirect.github.com/assertj/assertj/issues/2995;>#2995 Add getters for field path in ComparisonDifference https://redirect.github.com/assertj/assertj/issues/3007;>#3007 Allow to compare enum and string fields in the recursive comparison https://redirect.github.com/assertj/assertj/issues/2616;>#2616 Provide value when assertThatThrownBy / thenThrownBy fail https://redirect.github.com/assertj/assertj/issues/3043;>#3043 Add isSealed and isNotSealed to Class assertions https://redirect.github.com/assertj/assertj/issues/3080;>#3080 Add assertThatCharSequence to disambiguate Groovy's GString https://redirect.github.com/assertj/assertj/issues/3132;>#3132 ... (truncated) Commits https://github.com/assertj/assertj/commit/65f6433d26f74795434ac2ef2118cd5cec7c1be4;>65f6433 [maven-release-plugin] prepare release assertj-build-3.25.1 https://github.com/assertj/assertj/commit/4753165446ddec5e25250e52e6e5582093793262;>4753165 Revert fix: containsExactly does not work properly with maps not using equal... https://github.com/assertj/assertj/commit/2a7c5a6e205e29d42e9886657987893cb03b6875;>2a7c5a6 Revert Provide value when assertThatThrownBy/thenThrownBy fail (https://redirect.github.com/assertj/assertj/issues/3318;>#3318) https://github.com/assertj/assertj/commit/887f97b65da068e03308a6373a0c8a76912377aa;>887f97b Update license headers https://github.com/assertj/assertj/commit/25347d57bb28295548ec6bd5b06e70b6d03496c9;>25347d5 [maven-release-plugin] prepare for next development iteration https://github.com/assertj/assertj/commit/2c1c0839af66989c2d30d5b556799ca75ef2c246;>2c1c083 [maven-release-plugin] prepare release assertj-build-3.25.0 https://github.com/assertj/assertj/commit/c44129de725f5a3ecbaba16dd7b9ec31fd9e293b;>c44129d Move flatten-maven-plugin version to separate property https://github.com/assertj/assertj/commit/31cefaf68c04e13c6703033151f776251782af85;>31cefaf Apply flatten-maven-plugin to assertj-core and assertj-guava (https://redirect.github.com/assertj/assertj/issues/3311;>#3311) https://github.com/assertj/assertj/commit/435d183f2ededb18246338fb780098fabfba700b;>435d183 chore(deps-dev): bump org.testng:testng from 7.8.0 to 7.9.0 (https://redirect.github.com/assertj/assertj/issues/3312;>#3312) https://github.com/assertj/assertj/commit/e044604d99cdb513177d467886d51c47e0163251;>e044604 chore(deps-dev): bump nl.jqno.equalsverifier:equalsverifier from 3.15.4 to 3 Additional commits viewable in https://github.com/assertj/assertj/compare/assertj-build-3.24.2...assertj-build-3.25.1;>compare view [![Dependabot compatibility
[jira] [Commented] (DOXIASITETOOLS-323) Upgrade components
[
https://issues.apache.org/jira/browse/DOXIASITETOOLS-323?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17802300#comment-17802300
]
ASF GitHub Bot commented on DOXIASITETOOLS-323:
---
kwin commented on code in PR #125:
URL:
https://github.com/apache/maven-doxia-sitetools/pull/125#discussion_r1440800335
##
doxia-integration-tools/pom.xml:
##
@@ -86,9 +86,15 @@
provided
- org.apache.maven
- maven-plugin-api
- ${mavenVersion}
+ org.eclipse.aether
+ aether-api
+ ${aetherVersion}
+ provided
+
+
+ org.eclipse.aether
+ aether-impl
Review Comment:
Please move the test dependencies to the "test" scope section in the pom and
also add the transitive excludes for `maven-core` (otherwise they are still
transitive dependencies).
> Upgrade components
> --
>
> Key: DOXIASITETOOLS-323
> URL: https://issues.apache.org/jira/browse/DOXIASITETOOLS-323
> Project: Maven Doxia Sitetools
> Issue Type: Dependency upgrade
>Reporter: Michael Osipov
>Assignee: Michael Osipov
>Priority: Major
> Fix For: 2.0.0, 2.0.0-M17
>
>
> * Upgrade to Plexus Interpolation 1.27
> * Upgrade to Plexus Testing 1.3.0
> * Upgrade to Plexus Velocity 2.1.0
> * Upgrade to Commons Lang 3.14.0
> * Upgrade to Commons IO 2.15.1
> * Upgrade to JUnit 5.10.1
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
Re: [PR] [DOXIASITETOOLS-323] Upgrade components [maven-doxia-sitetools]
kwin commented on code in PR #125:
URL:
https://github.com/apache/maven-doxia-sitetools/pull/125#discussion_r1440800335
##
doxia-integration-tools/pom.xml:
##
@@ -86,9 +86,15 @@
provided
- org.apache.maven
- maven-plugin-api
- ${mavenVersion}
+ org.eclipse.aether
+ aether-api
+ ${aetherVersion}
+ provided
+
+
+ org.eclipse.aether
+ aether-impl
Review Comment:
Please move the test dependencies to the "test" scope section in the pom and
also add the transitive excludes for `maven-core` (otherwise they are still
transitive dependencies).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] Bump org.testng:testng from 5.10 to 5.11 [maven-surefire]
slachiewicz commented on PR #677: URL: https://github.com/apache/maven-surefire/pull/677#issuecomment-1875796828 @dependabot recreate -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump jacocoVersion from 0.8.8 to 0.8.11 [maven-surefire]
slachiewicz commented on PR #683: URL: https://github.com/apache/maven-surefire/pull/683#issuecomment-1875796460 @dependabot recreate -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump ch.qos.logback:logback-classic from 1.2.3 to 1.2.13 in /surefire-its/src/test/resources/surefire-1659-stream-corruption [maven-surefire]
dependabot[bot] commented on PR #696: URL: https://github.com/apache/maven-surefire/pull/696#issuecomment-1875794969 OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting `@dependabot ignore this major version` or `@dependabot ignore this minor version`. You can also ignore all major, minor, or patch releases for a dependency by adding an [`ignore` condition](https://docs.github.com/en/code-security/supply-chain-security/configuration-options-for-dependency-updates#ignore) with the desired `update_types` to your config file. If you change your mind, just re-open this PR and I'll resolve any conflicts on it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump ch.qos.logback:logback-classic from 1.2.3 to 1.2.13 in /surefire-its/src/test/resources/surefire-1659-stream-corruption [maven-surefire]
slachiewicz closed pull request #696: Bump ch.qos.logback:logback-classic from 1.2.3 to 1.2.13 in /surefire-its/src/test/resources/surefire-1659-stream-corruption URL: https://github.com/apache/maven-surefire/pull/696 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MNG-6776) Inconsistent list of parameters in MojoDescriptor
[ https://issues.apache.org/jira/browse/MNG-6776?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17802294#comment-17802294 ] ASF GitHub Bot commented on MNG-6776: - slawekjaranowski commented on code in PR #1361: URL: https://github.com/apache/maven/pull/1361#discussion_r1440780384 ## maven-plugin-api/src/main/java/org/apache/maven/plugin/descriptor/MojoDescriptor.java: ## @@ -51,9 +52,7 @@ public class MojoDescriptor extends ComponentDescriptor implements Cloneab private static final String DEFAULT_LANGUAGE = "java"; -private List parameters; - -private Map parameterMap; +private final ArrayList parameters; Review Comment: Can be `List` type? > Inconsistent list of parameters in MojoDescriptor > - > > Key: MNG-6776 > URL: https://issues.apache.org/jira/browse/MNG-6776 > Project: Maven > Issue Type: Bug > Components: Plugin API >Affects Versions: 3.6.2 >Reporter: Sylwester Lachiewicz >Assignee: Tamas Cservenak >Priority: Minor > Time Spent: 10m > Remaining Estimate: 0h > > While working with maven-plugin-tools I discovered inconsistent results > returned from MojoDescriptor getParameters() and getParametersMap(). > In > [AntMojoDescriptorExtractor.java#L101|https://github.com/apache/maven-plugin-tools/blob/master/maven-script/maven-plugin-tools-ant/src/main/java/org/apache/maven/tools/plugin/extractor/ant/AntMojoDescriptorExtractor.java#L101] > If first I call MojoDescriptor.getParameterMap() and then later add parameter > via MojoDescriptor.addParameter - MojoDescriptor.getParameterMap() will still > return map with old (cached) list with parameters. -- This message was sent by Atlassian Jira (v8.20.10#820010)
Re: [PR] [MNG-6776] Inconsistent list of parameters for MojoDescriptor (#584) [maven]
slawekjaranowski commented on code in PR #1361: URL: https://github.com/apache/maven/pull/1361#discussion_r1440780384 ## maven-plugin-api/src/main/java/org/apache/maven/plugin/descriptor/MojoDescriptor.java: ## @@ -51,9 +52,7 @@ public class MojoDescriptor extends ComponentDescriptor implements Cloneab private static final String DEFAULT_LANGUAGE = "java"; -private List parameters; - -private Map parameterMap; +private final ArrayList parameters; Review Comment: Can be `List` type? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Upgrade to Maven 4.0.0-alpha-11 [maven-plugin-testing]
slawekjaranowski commented on code in PR #39:
URL:
https://github.com/apache/maven-plugin-testing/pull/39#discussion_r1440766870
##
maven-plugin-testing-harness/pom.xml:
##
@@ -74,6 +80,15 @@ under the License.
${mavenVersion}
provided
+
+ org.apache.maven
+ maven-xml-impl
+ ${mavenVersion}
Review Comment:
Should be optional or provided to allow use with 3.x
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Updated] (MNG-7679) [REGRESSION] Build fails when executing a single mojo without a POM
[
https://issues.apache.org/jira/browse/MNG-7679?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael Osipov updated MNG-7679:
Affects Version/s: 3.8.7
(was: 3.8.x-candidate)
(was: 3.9.x-candidate)
> [REGRESSION] Build fails when executing a single mojo without a POM
> ---
>
> Key: MNG-7679
> URL: https://issues.apache.org/jira/browse/MNG-7679
> Project: Maven
> Issue Type: Bug
> Components: Core
>Affects Versions: 3.8.7, 3.9.0, 4.0.0-alpha-4
> Environment: Linux, MacOS, Windows
>Reporter: Alexey Venderov
>Assignee: Guillaume Nodet
>Priority: Major
> Fix For: 3.8.8, 3.9.1, 4.0.0-alpha-5, 4.0.0
>
>
> Hi,
>
> When invoking a single mojo, for example, {{{}install:install-file{}}},
> outside of the project directory (no pom in the directory), then the build is
> failing with {{{}NullPointerException{}}}.
>
> Steps to reproduce:
> # Download maven 3.9:
> [https://dlcdn.apache.org/maven/maven-3/3.9.0/binaries/apache-maven-3.9.0-bin.zip]
> # Unzip it to any directory
> # Create a simple text file {{echo "foo" > foo.txt}}
> # Try to install {{foo.txt}} into the local repository:
> {{./apache-maven-3.9.0/bin/mvn install:install-file -Dfile=foo.txt
> -DgroupId=com.example -DartifactId=foo -Dversion=1.0.0 -Dpackaging=jar -X}}
> Build fails with the {{{}NullPointerException{}}}:
>
> {code:java}
> [INFO]
>
> [INFO] BUILD FAILURE
> [INFO]
>
> [INFO] Total time: 0.086 s
> [INFO] Finished at: 2023-02-06T11:48:49+01:00
> [INFO]
>
> [ERROR] NullPointerException
> java.lang.NullPointerException
> at
> org.apache.maven.lifecycle.internal.LifecycleDependencyResolver.getProjectAndSubModules
> (LifecycleDependencyResolver.java:102)
> at
> org.apache.maven.lifecycle.internal.LifecycleDependencyResolver.getProjects
> (LifecycleDependencyResolver.java:93)
> at
> org.apache.maven.lifecycle.internal.MojoExecutor.ensureDependenciesAreResolved
> (MojoExecutor.java:395)
> at org.apache.maven.lifecycle.internal.MojoExecutor.doExecute
> (MojoExecutor.java:327)
> at org.apache.maven.lifecycle.internal.MojoExecutor.execute
> (MojoExecutor.java:213)
> at org.apache.maven.lifecycle.internal.MojoExecutor.execute
> (MojoExecutor.java:175)
> at org.apache.maven.lifecycle.internal.MojoExecutor.access$000
> (MojoExecutor.java:76)
> at org.apache.maven.lifecycle.internal.MojoExecutor$1.run
> (MojoExecutor.java:163)
> at org.apache.maven.plugin.DefaultMojosExecutionStrategy.execute
> (DefaultMojosExecutionStrategy.java:39)
> at org.apache.maven.lifecycle.internal.MojoExecutor.execute
> (MojoExecutor.java:160)
> at
> org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject
> (LifecycleModuleBuilder.java:105)
> at
> org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject
> (LifecycleModuleBuilder.java:73)
> at
> org.apache.maven.lifecycle.internal.builder.singlethreaded.SingleThreadedBuilder.build
> (SingleThreadedBuilder.java:53)
> at org.apache.maven.lifecycle.internal.LifecycleStarter.execute
> (LifecycleStarter.java:118)
> at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:260)
> at org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:172)
> at org.apache.maven.DefaultMaven.execute (DefaultMaven.java:100)
> at org.apache.maven.cli.MavenCli.execute (MavenCli.java:821)
> at org.apache.maven.cli.MavenCli.doMain (MavenCli.java:270)
> at org.apache.maven.cli.MavenCli.main (MavenCli.java:192)
> at jdk.internal.reflect.NativeMethodAccessorImpl.invoke0 (Native Method)
> at jdk.internal.reflect.NativeMethodAccessorImpl.invoke
> (NativeMethodAccessorImpl.java:62)
> at jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke
> (DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke (Method.java:566)
> at org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced
> (Launcher.java:282)
> at org.codehaus.plexus.classworlds.launcher.Launcher.launch
> (Launcher.java:225)
> at org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode
> (Launcher.java:406)
> at org.codehaus.plexus.classworlds.launcher.Launcher.main
> (Launcher.java:347)
> [ERROR]
> {code}
>
> The same operation is successful when using maven 3.8.7 or earlier:
> {code:java}
> 11:56:50 ➜ mvn --version
> Apache Maven 3.8.7 (b89d5959fcde851dcb1c8946a785a163f14e1e29)
> Maven home: /Users/avenderov/.sdkman/candidates/maven/current
> Java
[jira] [Updated] (MNG-6825) Cleaning Up dependencies plexus-utils/maven-shared-utils/commons-lang3/commons-io
[
https://issues.apache.org/jira/browse/MNG-6825?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael Osipov updated MNG-6825:
Fix Version/s: (was: 3.9.x-candidate)
> Cleaning Up dependencies
> plexus-utils/maven-shared-utils/commons-lang3/commons-io
> -
>
> Key: MNG-6825
> URL: https://issues.apache.org/jira/browse/MNG-6825
> Project: Maven
> Issue Type: Improvement
> Components: Bootstrap Build
>Affects Versions: 3.6.3
>Reporter: Karl Heinz Marbaise
>Assignee: Guillaume Nodet
>Priority: Minor
> Fix For: 4.0.0-alpha-7, 4.0.0
>
>
> Experiment to see if we can get rid of commons-lang3 dependency.
> * Identified code duplication between:
> ** {{org.apache.commons.lang3.StringUtils}} from {{commons-lang3}} (501879
> Bytes commons-lang3-3.8.1.jar)
> ** {{org.codehaus.plexus.util.StringUtil}} from {{plexus-utils}} (261801
> Bytes plexus-utils-3.2.1.jar)
> ** {{org.apache.maven.shared.utils}} from {{maven-shared-utils}} (166562
> Bytes maven-shared-utils-3.2.1.jar)
> ** We should replace the self implemented with
> {{org.codehaus.plexus.util.StringUtil}}. or with {{maven-shared-utils}}
> * {{commons-io}} usage by {{maven-shared-utils}} (208700 Bytes
> commons-io-2.5.jar)
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (DOXIASITETOOLS-323) Upgrade components
[
https://issues.apache.org/jira/browse/DOXIASITETOOLS-323?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17802260#comment-17802260
]
ASF GitHub Bot commented on DOXIASITETOOLS-323:
---
michael-o commented on code in PR #125:
URL:
https://github.com/apache/maven-doxia-sitetools/pull/125#discussion_r1440662357
##
doxia-integration-tools/pom.xml:
##
@@ -86,9 +86,15 @@
provided
- org.apache.maven
- maven-plugin-api
- ${mavenVersion}
+ org.eclipse.aether
+ aether-api
+ ${aetherVersion}
+ provided
+
+
+ org.eclipse.aether
+ aether-impl
Review Comment:
Either a bug in the plugin or these truly cause it:
https://github.com/apache/maven-doxia-sitetools/blob/dacaa552c1b8e89eed84db0f43b6b0a72be91d0c/doxia-integration-tools/src/main/java/org/apache/maven/doxia/tools/DefaultSiteTool.java#L87-L96
Let me move it to test scope...
> Upgrade components
> --
>
> Key: DOXIASITETOOLS-323
> URL: https://issues.apache.org/jira/browse/DOXIASITETOOLS-323
> Project: Maven Doxia Sitetools
> Issue Type: Dependency upgrade
>Reporter: Michael Osipov
>Assignee: Michael Osipov
>Priority: Major
> Fix For: 2.0.0, 2.0.0-M17
>
>
> * Upgrade to Plexus Interpolation 1.27
> * Upgrade to Plexus Testing 1.3.0
> * Upgrade to Plexus Velocity 2.1.0
> * Upgrade to Commons Lang 3.14.0
> * Upgrade to Commons IO 2.15.1
> * Upgrade to JUnit 5.10.1
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
Re: [PR] [DOXIASITETOOLS-323] Upgrade components [maven-doxia-sitetools]
michael-o commented on code in PR #125:
URL:
https://github.com/apache/maven-doxia-sitetools/pull/125#discussion_r1440662357
##
doxia-integration-tools/pom.xml:
##
@@ -86,9 +86,15 @@
provided
- org.apache.maven
- maven-plugin-api
- ${mavenVersion}
+ org.eclipse.aether
+ aether-api
+ ${aetherVersion}
+ provided
+
+
+ org.eclipse.aether
+ aether-impl
Review Comment:
Either a bug in the plugin or these truly cause it:
https://github.com/apache/maven-doxia-sitetools/blob/dacaa552c1b8e89eed84db0f43b6b0a72be91d0c/doxia-integration-tools/src/main/java/org/apache/maven/doxia/tools/DefaultSiteTool.java#L87-L96
Let me move it to test scope...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Commented] (DOXIASITETOOLS-323) Upgrade components
[
https://issues.apache.org/jira/browse/DOXIASITETOOLS-323?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17802257#comment-17802257
]
ASF GitHub Bot commented on DOXIASITETOOLS-323:
---
kwin commented on code in PR #125:
URL:
https://github.com/apache/maven-doxia-sitetools/pull/125#discussion_r1440651510
##
doxia-integration-tools/pom.xml:
##
@@ -86,9 +86,15 @@
provided
- org.apache.maven
- maven-plugin-api
- ${mavenVersion}
+ org.eclipse.aether
+ aether-api
+ ${aetherVersion}
+ provided
+
+
+ org.eclipse.aether
+ aether-impl
Review Comment:
The funny thing is that once you exclude those transitive deps, the
m-dependency-p does not longer deem them necessary.
For testing they are indeed necessary (due to references in `SiteToolTest`.
For me the pom.xml works like this
```
...
org.apache.maven
maven-core
${mavenVersion}
provided
*
*
org.apache.maven
maven-compat
${mavenVersion}
provided
org.apache.maven
maven-model
${mavenVersion}
provided
org.eclipse.aether
aether-api
${aetherVersion}
provided
Upgrade components
> --
>
> Key: DOXIASITETOOLS-323
> URL: https://issues.apache.org/jira/browse/DOXIASITETOOLS-323
> Project: Maven Doxia Sitetools
> Issue Type: Dependency upgrade
>Reporter: Michael Osipov
>Assignee: Michael Osipov
>Priority: Major
> Fix For: 2.0.0, 2.0.0-M17
>
>
> * Upgrade to Plexus Interpolation 1.27
> * Upgrade to Plexus Testing 1.3.0
> * Upgrade to Plexus Velocity 2.1.0
> * Upgrade to Commons Lang 3.14.0
> * Upgrade to Commons IO 2.15.1
> * Upgrade to JUnit 5.10.1
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
Re: [PR] [DOXIASITETOOLS-323] Upgrade components [maven-doxia-sitetools]
kwin commented on code in PR #125:
URL:
https://github.com/apache/maven-doxia-sitetools/pull/125#discussion_r1440651510
##
doxia-integration-tools/pom.xml:
##
@@ -86,9 +86,15 @@
provided
- org.apache.maven
- maven-plugin-api
- ${mavenVersion}
+ org.eclipse.aether
+ aether-api
+ ${aetherVersion}
+ provided
+
+
+ org.eclipse.aether
+ aether-impl
Review Comment:
The funny thing is that once you exclude those transitive deps, the
m-dependency-p does not longer deem them necessary.
For testing they are indeed necessary (due to references in `SiteToolTest`.
For me the pom.xml works like this
```
...
org.apache.maven
maven-core
${mavenVersion}
provided
*
*
org.apache.maven
maven-compat
${mavenVersion}
provided
org.apache.maven
maven-model
${mavenVersion}
provided
org.eclipse.aether
aether-api
${aetherVersion}
provided
org.apache.maven.doxia
doxia-site-model
org.eclipse.sisu
org.eclipse.sisu.plexus
org.codehaus.plexus
plexus-i18n
org.codehaus.plexus
plexus-component-api
org.codehaus.plexus
plexus-utils
org.codehaus.plexus
plexus-xml
org.codehaus.plexus
plexus-interpolation
1.27
org.junit.jupiter
junit-jupiter-api
test
org.junit.jupiter
junit-jupiter-engine
test
org.slf4j
slf4j-simple
test
com.google.inject
guice
test
org.apache.maven.plugin-testing
maven-plugin-testing-harness
3.3.0
test
org.codehaus.plexus
plexus-container-default
org.apache.maven
maven-settings-builder
${mavenVersion}
test
org.apache.maven
maven-plugin-api
${mavenVersion}
test
org.apache.maven
maven-aether-provider
${mavenVersion}
test
org.eclipse.aether
aether-impl
${aetherVersion}
test
org.eclipse.aether
aether-connector-basic
${aetherVersion}
test
...
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Commented] (DOXIASITETOOLS-323) Upgrade components
[
https://issues.apache.org/jira/browse/DOXIASITETOOLS-323?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17802256#comment-17802256
]
ASF GitHub Bot commented on DOXIASITETOOLS-323:
---
kwin commented on code in PR #125:
URL:
https://github.com/apache/maven-doxia-sitetools/pull/125#discussion_r1440651510
##
doxia-integration-tools/pom.xml:
##
@@ -86,9 +86,15 @@
provided
- org.apache.maven
- maven-plugin-api
- ${mavenVersion}
+ org.eclipse.aether
+ aether-api
+ ${aetherVersion}
+ provided
+
+
+ org.eclipse.aether
+ aether-impl
Review Comment:
The funny thing is that once you exclude those transitive deps, the
m-dependency-p does not longer deem them necessary.
For testing they are indeed necessary (due to references in `SiteToolTest`.
For me the pom.xml works like this suggested below.
> Upgrade components
> --
>
> Key: DOXIASITETOOLS-323
> URL: https://issues.apache.org/jira/browse/DOXIASITETOOLS-323
> Project: Maven Doxia Sitetools
> Issue Type: Dependency upgrade
>Reporter: Michael Osipov
>Assignee: Michael Osipov
>Priority: Major
> Fix For: 2.0.0, 2.0.0-M17
>
>
> * Upgrade to Plexus Interpolation 1.27
> * Upgrade to Plexus Testing 1.3.0
> * Upgrade to Plexus Velocity 2.1.0
> * Upgrade to Commons Lang 3.14.0
> * Upgrade to Commons IO 2.15.1
> * Upgrade to JUnit 5.10.1
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
Re: [PR] [DOXIASITETOOLS-323] Upgrade components [maven-doxia-sitetools]
kwin commented on code in PR #125:
URL:
https://github.com/apache/maven-doxia-sitetools/pull/125#discussion_r1440651510
##
doxia-integration-tools/pom.xml:
##
@@ -86,9 +86,15 @@
provided
- org.apache.maven
- maven-plugin-api
- ${mavenVersion}
+ org.eclipse.aether
+ aether-api
+ ${aetherVersion}
+ provided
+
+
+ org.eclipse.aether
+ aether-impl
Review Comment:
The funny thing is that once you exclude those transitive deps, the
m-dependency-p does not longer deem them necessary.
For testing they are indeed necessary (due to references in `SiteToolTest`.
For me the pom.xml works like this suggested below.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] [MPOM-451] Remove repository elements from Apache Parent [maven-apache-parent]
lprimak commented on PR #183: URL: https://github.com/apache/maven-apache-parent/pull/183#issuecomment-1875630975 > A lot of projects rely on this being already set up Understandable, but since these upgrades don't happen automatically and "fail fast", I don't see this as a big issue. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (DOXIASITETOOLS-323) Upgrade components
[
https://issues.apache.org/jira/browse/DOXIASITETOOLS-323?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17802252#comment-17802252
]
ASF GitHub Bot commented on DOXIASITETOOLS-323:
---
michael-o commented on code in PR #125:
URL:
https://github.com/apache/maven-doxia-sitetools/pull/125#discussion_r1440641008
##
doxia-integration-tools/pom.xml:
##
@@ -86,9 +86,15 @@
provided
- org.apache.maven
- maven-plugin-api
- ${mavenVersion}
+ org.eclipse.aether
+ aether-api
+ ${aetherVersion}
+ provided
+
+
+ org.eclipse.aether
+ aether-impl
Review Comment:
Does this work for you:
https://maven.apache.org/plugins/maven-dependency-plugin/analyze-mojo.html#verbose?
> Upgrade components
> --
>
> Key: DOXIASITETOOLS-323
> URL: https://issues.apache.org/jira/browse/DOXIASITETOOLS-323
> Project: Maven Doxia Sitetools
> Issue Type: Dependency upgrade
>Reporter: Michael Osipov
>Assignee: Michael Osipov
>Priority: Major
> Fix For: 2.0.0, 2.0.0-M17
>
>
> * Upgrade to Plexus Interpolation 1.27
> * Upgrade to Plexus Testing 1.3.0
> * Upgrade to Plexus Velocity 2.1.0
> * Upgrade to Commons Lang 3.14.0
> * Upgrade to Commons IO 2.15.1
> * Upgrade to JUnit 5.10.1
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
Re: [PR] [DOXIASITETOOLS-323] Upgrade components [maven-doxia-sitetools]
michael-o commented on code in PR #125:
URL:
https://github.com/apache/maven-doxia-sitetools/pull/125#discussion_r1440641008
##
doxia-integration-tools/pom.xml:
##
@@ -86,9 +86,15 @@
provided
- org.apache.maven
- maven-plugin-api
- ${mavenVersion}
+ org.eclipse.aether
+ aether-api
+ ${aetherVersion}
+ provided
+
+
+ org.eclipse.aether
+ aether-impl
Review Comment:
Does this work for you:
https://maven.apache.org/plugins/maven-dependency-plugin/analyze-mojo.html#verbose?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Commented] (DOXIASITETOOLS-323) Upgrade components
[
https://issues.apache.org/jira/browse/DOXIASITETOOLS-323?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17802250#comment-17802250
]
ASF GitHub Bot commented on DOXIASITETOOLS-323:
---
kwin commented on code in PR #125:
URL:
https://github.com/apache/maven-doxia-sitetools/pull/125#discussion_r1440639693
##
doxia-integration-tools/pom.xml:
##
@@ -86,9 +86,15 @@
provided
- org.apache.maven
- maven-plugin-api
- ${mavenVersion}
+ org.eclipse.aether
+ aether-api
+ ${aetherVersion}
+ provided
+
+
+ org.eclipse.aether
+ aether-impl
Review Comment:
It is a transitive dependency of `maven-core` and `maven-aether-provider`
(the latter also being a transitive dependency of maven-core). I don't know how
the
l
with https://maven.apache.org/shared/maven-dependency-analyzer/ concludes that
this is necessary (couldn't bring it to log the referencing class) but IMHO it
isn't. @michael-o Any idea how to make the output of m-dependency-p more
verbose in this regard?
> Upgrade components
> --
>
> Key: DOXIASITETOOLS-323
> URL: https://issues.apache.org/jira/browse/DOXIASITETOOLS-323
> Project: Maven Doxia Sitetools
> Issue Type: Dependency upgrade
>Reporter: Michael Osipov
>Assignee: Michael Osipov
>Priority: Major
> Fix For: 2.0.0, 2.0.0-M17
>
>
> * Upgrade to Plexus Interpolation 1.27
> * Upgrade to Plexus Testing 1.3.0
> * Upgrade to Plexus Velocity 2.1.0
> * Upgrade to Commons Lang 3.14.0
> * Upgrade to Commons IO 2.15.1
> * Upgrade to JUnit 5.10.1
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
Re: [PR] [DOXIASITETOOLS-323] Upgrade components [maven-doxia-sitetools]
kwin commented on code in PR #125:
URL:
https://github.com/apache/maven-doxia-sitetools/pull/125#discussion_r1440639693
##
doxia-integration-tools/pom.xml:
##
@@ -86,9 +86,15 @@
provided
- org.apache.maven
- maven-plugin-api
- ${mavenVersion}
+ org.eclipse.aether
+ aether-api
+ ${aetherVersion}
+ provided
+
+
+ org.eclipse.aether
+ aether-impl
Review Comment:
It is a transitive dependency of `maven-core` and `maven-aether-provider`
(the latter also being a transitive dependency of maven-core). I don't know how
the
l
with https://maven.apache.org/shared/maven-dependency-analyzer/ concludes that
this is necessary (couldn't bring it to log the referencing class) but IMHO it
isn't. @michael-o Any idea how to make the output of m-dependency-p more
verbose in this regard?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Commented] (MNG-6776) Inconsistent list of parameters in MojoDescriptor
[
https://issues.apache.org/jira/browse/MNG-6776?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17802248#comment-17802248
]
ASF GitHub Bot commented on MNG-6776:
-
michael-o commented on code in PR #1361:
URL: https://github.com/apache/maven/pull/1361#discussion_r1440639115
##
maven-plugin-api/src/main/java/org/apache/maven/plugin/descriptor/MojoDescriptor.java:
##
@@ -85,8 +84,8 @@ public class MojoDescriptor extends ComponentDescriptor
implements Cloneab
private String executeLifecycle;
/**
- * Description with reason of Mojo deprecation. Similar to Javadoc {@code
@deprecated}.
- * This will trigger a warning when a user tries to use a Mojo marked as
deprecated.
+ * Specify the version when the Mojo was deprecated to the API. Similar to
Javadoc deprecated. This will trigger a
Review Comment:
@kwin Now the diff is only v4 API related. Please check again.
> Inconsistent list of parameters in MojoDescriptor
> -
>
> Key: MNG-6776
> URL: https://issues.apache.org/jira/browse/MNG-6776
> Project: Maven
> Issue Type: Bug
> Components: Plugin API
>Affects Versions: 3.6.2
>Reporter: Sylwester Lachiewicz
>Assignee: Tamas Cservenak
>Priority: Minor
> Time Spent: 10m
> Remaining Estimate: 0h
>
> While working with maven-plugin-tools I discovered inconsistent results
> returned from MojoDescriptor getParameters() and getParametersMap().
> In
> [AntMojoDescriptorExtractor.java#L101|https://github.com/apache/maven-plugin-tools/blob/master/maven-script/maven-plugin-tools-ant/src/main/java/org/apache/maven/tools/plugin/extractor/ant/AntMojoDescriptorExtractor.java#L101]
> If first I call MojoDescriptor.getParameterMap() and then later add parameter
> via MojoDescriptor.addParameter - MojoDescriptor.getParameterMap() will still
> return map with old (cached) list with parameters.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
Re: [PR] [MNG-6776] Inconsistent list of parameters for MojoDescriptor (#584) [maven]
michael-o commented on code in PR #1361:
URL: https://github.com/apache/maven/pull/1361#discussion_r1440639115
##
maven-plugin-api/src/main/java/org/apache/maven/plugin/descriptor/MojoDescriptor.java:
##
@@ -85,8 +84,8 @@ public class MojoDescriptor extends ComponentDescriptor
implements Cloneab
private String executeLifecycle;
/**
- * Description with reason of Mojo deprecation. Similar to Javadoc {@code
@deprecated}.
- * This will trigger a warning when a user tries to use a Mojo marked as
deprecated.
+ * Specify the version when the Mojo was deprecated to the API. Similar to
Javadoc deprecated. This will trigger a
Review Comment:
@kwin Now the diff is only v4 API related. Please check again.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] Bump org.codehaus.plexus:plexus-utils from 1.0.4 to 3.0.24 in /surefire-its/src/test/resources/plexus-conflict [maven-surefire]
dependabot[bot] commented on PR #676: URL: https://github.com/apache/maven-surefire/pull/676#issuecomment-1875618330 OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting `@dependabot ignore this major version` or `@dependabot ignore this minor version`. You can also ignore all major, minor, or patch releases for a dependency by adding an [`ignore` condition](https://docs.github.com/en/code-security/supply-chain-security/configuration-options-for-dependency-updates#ignore) with the desired `update_types` to your config file. If you change your mind, just re-open this PR and I'll resolve any conflicts on it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump org.codehaus.plexus:plexus-utils from 1.0.4 to 3.0.24 in /surefire-its/src/test/resources/plexus-conflict [maven-surefire]
slachiewicz closed pull request #676: Bump org.codehaus.plexus:plexus-utils from 1.0.4 to 3.0.24 in /surefire-its/src/test/resources/plexus-conflict URL: https://github.com/apache/maven-surefire/pull/676 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MNG-6776) Inconsistent list of parameters in MojoDescriptor
[
https://issues.apache.org/jira/browse/MNG-6776?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17802243#comment-17802243
]
ASF GitHub Bot commented on MNG-6776:
-
michael-o commented on code in PR #1361:
URL: https://github.com/apache/maven/pull/1361#discussion_r1440632936
##
maven-plugin-api/src/main/java/org/apache/maven/plugin/descriptor/MojoDescriptor.java:
##
@@ -85,8 +84,8 @@ public class MojoDescriptor extends ComponentDescriptor
implements Cloneab
private String executeLifecycle;
/**
- * Description with reason of Mojo deprecation. Similar to Javadoc {@code
@deprecated}.
- * This will trigger a warning when a user tries to use a Mojo marked as
deprecated.
+ * Specify the version when the Mojo was deprecated to the API. Similar to
Javadoc deprecated. This will trigger a
Review Comment:
The only changes to this file on master I can find are
47e2d689d687358a85c2cdecc176cac36093817e and
5ce5591ae341188230d6ecca76c90bd0a786fcb2
I agree that they should be included as well.
> Inconsistent list of parameters in MojoDescriptor
> -
>
> Key: MNG-6776
> URL: https://issues.apache.org/jira/browse/MNG-6776
> Project: Maven
> Issue Type: Bug
> Components: Plugin API
>Affects Versions: 3.6.2
>Reporter: Sylwester Lachiewicz
>Assignee: Tamas Cservenak
>Priority: Minor
> Time Spent: 10m
> Remaining Estimate: 0h
>
> While working with maven-plugin-tools I discovered inconsistent results
> returned from MojoDescriptor getParameters() and getParametersMap().
> In
> [AntMojoDescriptorExtractor.java#L101|https://github.com/apache/maven-plugin-tools/blob/master/maven-script/maven-plugin-tools-ant/src/main/java/org/apache/maven/tools/plugin/extractor/ant/AntMojoDescriptorExtractor.java#L101]
> If first I call MojoDescriptor.getParameterMap() and then later add parameter
> via MojoDescriptor.addParameter - MojoDescriptor.getParameterMap() will still
> return map with old (cached) list with parameters.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
Re: [PR] [MNG-6776] Inconsistent list of parameters for MojoDescriptor (#584) [maven]
michael-o commented on code in PR #1361:
URL: https://github.com/apache/maven/pull/1361#discussion_r1440632936
##
maven-plugin-api/src/main/java/org/apache/maven/plugin/descriptor/MojoDescriptor.java:
##
@@ -85,8 +84,8 @@ public class MojoDescriptor extends ComponentDescriptor
implements Cloneab
private String executeLifecycle;
/**
- * Description with reason of Mojo deprecation. Similar to Javadoc {@code
@deprecated}.
- * This will trigger a warning when a user tries to use a Mojo marked as
deprecated.
+ * Specify the version when the Mojo was deprecated to the API. Similar to
Javadoc deprecated. This will trigger a
Review Comment:
The only changes to this file on master I can find are
47e2d689d687358a85c2cdecc176cac36093817e and
5ce5591ae341188230d6ecca76c90bd0a786fcb2
I agree that they should be included as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Commented] (MNG-6776) Inconsistent list of parameters in MojoDescriptor
[
https://issues.apache.org/jira/browse/MNG-6776?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17802240#comment-17802240
]
ASF GitHub Bot commented on MNG-6776:
-
michael-o commented on code in PR #1361:
URL: https://github.com/apache/maven/pull/1361#discussion_r1440629527
##
maven-plugin-api/src/main/java/org/apache/maven/plugin/descriptor/MojoDescriptor.java:
##
@@ -85,8 +84,8 @@ public class MojoDescriptor extends ComponentDescriptor
implements Cloneab
private String executeLifecycle;
/**
- * Description with reason of Mojo deprecation. Similar to Javadoc {@code
@deprecated}.
- * This will trigger a warning when a user tries to use a Mojo marked as
deprecated.
+ * Specify the version when the Mojo was deprecated to the API. Similar to
Javadoc deprecated. This will trigger a
Review Comment:
Let me check...
> Inconsistent list of parameters in MojoDescriptor
> -
>
> Key: MNG-6776
> URL: https://issues.apache.org/jira/browse/MNG-6776
> Project: Maven
> Issue Type: Bug
> Components: Plugin API
>Affects Versions: 3.6.2
>Reporter: Sylwester Lachiewicz
>Assignee: Tamas Cservenak
>Priority: Minor
> Time Spent: 10m
> Remaining Estimate: 0h
>
> While working with maven-plugin-tools I discovered inconsistent results
> returned from MojoDescriptor getParameters() and getParametersMap().
> In
> [AntMojoDescriptorExtractor.java#L101|https://github.com/apache/maven-plugin-tools/blob/master/maven-script/maven-plugin-tools-ant/src/main/java/org/apache/maven/tools/plugin/extractor/ant/AntMojoDescriptorExtractor.java#L101]
> If first I call MojoDescriptor.getParameterMap() and then later add parameter
> via MojoDescriptor.addParameter - MojoDescriptor.getParameterMap() will still
> return map with old (cached) list with parameters.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
Re: [PR] [MNG-6776] Inconsistent list of parameters for MojoDescriptor (#584) [maven]
michael-o commented on code in PR #1361:
URL: https://github.com/apache/maven/pull/1361#discussion_r1440629527
##
maven-plugin-api/src/main/java/org/apache/maven/plugin/descriptor/MojoDescriptor.java:
##
@@ -85,8 +84,8 @@ public class MojoDescriptor extends ComponentDescriptor
implements Cloneab
private String executeLifecycle;
/**
- * Description with reason of Mojo deprecation. Similar to Javadoc {@code
@deprecated}.
- * This will trigger a warning when a user tries to use a Mojo marked as
deprecated.
+ * Specify the version when the Mojo was deprecated to the API. Similar to
Javadoc deprecated. This will trigger a
Review Comment:
Let me check...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] [MPOM-451] Remove repository elements from Apache Parent [maven-apache-parent]
ctubbsii commented on PR #183: URL: https://github.com/apache/maven-apache-parent/pull/183#issuecomment-1875601253 > > this is probably going to create a huge headache > > Why? It's not difficult to put those lines into `settings.xml` in their own profile, on the CI system where they belong It's not a difficultly issue... it's a scale problem. A *lot* of projects rely on this being already set up in the parent POM. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump org.assertj:assertj-core from 3.24.2 to 3.25.0 [maven-enforcer]
dependabot[bot] closed pull request #300: Bump org.assertj:assertj-core from 3.24.2 to 3.25.0 URL: https://github.com/apache/maven-enforcer/pull/300 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump org.assertj:assertj-core from 3.24.2 to 3.25.0 [maven-enforcer]
dependabot[bot] commented on PR #300: URL: https://github.com/apache/maven-enforcer/pull/300#issuecomment-1875599472 Superseded by #301. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] Bump org.assertj:assertj-core from 3.24.2 to 3.25.1 [maven-enforcer]
dependabot[bot] opened a new pull request, #301: URL: https://github.com/apache/maven-enforcer/pull/301 Bumps [org.assertj:assertj-core](https://github.com/assertj/assertj) from 3.24.2 to 3.25.1. Release notes Sourced from https://github.com/assertj/assertj/releases;>org.assertj:assertj-core's releases. v3.25.1 :jigsaw: Binary Compatibility The release is: Binary compatible with the previous minor version. Binary incompatible with the previous patch version. :bug: Bug Fixes Core Revert Provide value when assertThatThrownBy/thenThrownBy fail https://redirect.github.com/assertj/assertj/issues/3318;>#3318 Revert fix: containsExactly does not work properly with maps not using equals to compare keys https://redirect.github.com/assertj/assertj/issues/3321;>#3321 v3.25.0 :jigsaw: Binary Compatibility The release is https://assertj.github.io/doc/#binary-compatibility;>binary compatible with the previous minor version. :no_entry_sign: Deprecated Core Deprecate the following date/time related assertions in favor of isCloseTo: isEqualToIgnoringHours isEqualToIgnoringMinutes isEqualToIgnoringSeconds isEqualToIgnoringMillis isEqualToIgnoringNanos isInSameHourAs isInSameMinuteAs isInSameSecondAs Deprecate asList in favor of asInstanceOf https://redirect.github.com/assertj/assertj/issues/3138;>#3138 :sparkles: New Features Core Add Descriptable#describedAs(SupplierString) Add isInThePast and isInTheFuture to LocalDate assertions https://redirect.github.com/assertj/assertj/issues/2933;>#2933 Add isInThePast and isInTheFuture to the missing Java 8 date/time types https://redirect.github.com/assertj/assertj/issues/2947;>#2947 Add isRecord and isNotRecord to Class assertions https://redirect.github.com/assertj/assertj/issues/2968;>#2968 Add hasNullValue and doesNotHaveNullValue to AtomicReferenceAssert https://redirect.github.com/assertj/assertj/issues/2969;>#2969 Add asBoolean|Byte|Short|Int|Long|Float|Double to String assertions https://redirect.github.com/assertj/assertj/issues/2580;>#2580 Add hasRecordComponents to Class assertions https://redirect.github.com/assertj/assertj/issues/2995;>#2995 Add getters for field path in ComparisonDifference https://redirect.github.com/assertj/assertj/issues/3007;>#3007 Allow to compare enum and string fields in the recursive comparison https://redirect.github.com/assertj/assertj/issues/2616;>#2616 Provide value when assertThatThrownBy / thenThrownBy fail https://redirect.github.com/assertj/assertj/issues/3043;>#3043 Add isSealed and isNotSealed to Class assertions https://redirect.github.com/assertj/assertj/issues/3080;>#3080 Add assertThatCharSequence to disambiguate Groovy's GString https://redirect.github.com/assertj/assertj/issues/3132;>#3132 ... (truncated) Commits https://github.com/assertj/assertj/commit/65f6433d26f74795434ac2ef2118cd5cec7c1be4;>65f6433 [maven-release-plugin] prepare release assertj-build-3.25.1 https://github.com/assertj/assertj/commit/4753165446ddec5e25250e52e6e5582093793262;>4753165 Revert fix: containsExactly does not work properly with maps not using equal... https://github.com/assertj/assertj/commit/2a7c5a6e205e29d42e9886657987893cb03b6875;>2a7c5a6 Revert Provide value when assertThatThrownBy/thenThrownBy fail (https://redirect.github.com/assertj/assertj/issues/3318;>#3318) https://github.com/assertj/assertj/commit/887f97b65da068e03308a6373a0c8a76912377aa;>887f97b Update license headers https://github.com/assertj/assertj/commit/25347d57bb28295548ec6bd5b06e70b6d03496c9;>25347d5 [maven-release-plugin] prepare for next development iteration https://github.com/assertj/assertj/commit/2c1c0839af66989c2d30d5b556799ca75ef2c246;>2c1c083 [maven-release-plugin] prepare release assertj-build-3.25.0 https://github.com/assertj/assertj/commit/c44129de725f5a3ecbaba16dd7b9ec31fd9e293b;>c44129d Move flatten-maven-plugin version to separate property https://github.com/assertj/assertj/commit/31cefaf68c04e13c6703033151f776251782af85;>31cefaf Apply flatten-maven-plugin to assertj-core and assertj-guava (https://redirect.github.com/assertj/assertj/issues/3311;>#3311) https://github.com/assertj/assertj/commit/435d183f2ededb18246338fb780098fabfba700b;>435d183 chore(deps-dev): bump org.testng:testng from 7.8.0 to 7.9.0 (https://redirect.github.com/assertj/assertj/issues/3312;>#3312) https://github.com/assertj/assertj/commit/e044604d99cdb513177d467886d51c47e0163251;>e044604 chore(deps-dev): bump nl.jqno.equalsverifier:equalsverifier from 3.15.4 to 3 Additional commits viewable in https://github.com/assertj/assertj/compare/assertj-build-3.24.2...assertj-build-3.25.1;>compare view [![Dependabot compatibility
[jira] [Commented] (MNG-6776) Inconsistent list of parameters in MojoDescriptor
[
https://issues.apache.org/jira/browse/MNG-6776?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17802237#comment-17802237
]
ASF GitHub Bot commented on MNG-6776:
-
kwin commented on code in PR #1361:
URL: https://github.com/apache/maven/pull/1361#discussion_r1440618341
##
maven-plugin-api/src/main/java/org/apache/maven/plugin/descriptor/MojoDescriptor.java:
##
@@ -85,8 +84,8 @@ public class MojoDescriptor extends ComponentDescriptor
implements Cloneab
private String executeLifecycle;
/**
- * Description with reason of Mojo deprecation. Similar to Javadoc {@code
@deprecated}.
- * This will trigger a warning when a user tries to use a Mojo marked as
deprecated.
+ * Specify the version when the Mojo was deprecated to the API. Similar to
Javadoc deprecated. This will trigger a
Review Comment:
In master it looks different:
https://github.com/apache/maven/blob/23d13fb322b8d66f03f02ece57d75e154f847367/maven-plugin-api/src/main/java/org/apache/maven/plugin/descriptor/MojoDescriptor.java#L88.
Seems that for some reason this PR restores the 12 year old revision
https://github.com/apache/maven/commit/acc04dca1b6a7ef39f41d976dcc8eb96aa0aa53f.
> Inconsistent list of parameters in MojoDescriptor
> -
>
> Key: MNG-6776
> URL: https://issues.apache.org/jira/browse/MNG-6776
> Project: Maven
> Issue Type: Bug
> Components: Plugin API
>Affects Versions: 3.6.2
>Reporter: Sylwester Lachiewicz
>Assignee: Tamas Cservenak
>Priority: Minor
> Time Spent: 10m
> Remaining Estimate: 0h
>
> While working with maven-plugin-tools I discovered inconsistent results
> returned from MojoDescriptor getParameters() and getParametersMap().
> In
> [AntMojoDescriptorExtractor.java#L101|https://github.com/apache/maven-plugin-tools/blob/master/maven-script/maven-plugin-tools-ant/src/main/java/org/apache/maven/tools/plugin/extractor/ant/AntMojoDescriptorExtractor.java#L101]
> If first I call MojoDescriptor.getParameterMap() and then later add parameter
> via MojoDescriptor.addParameter - MojoDescriptor.getParameterMap() will still
> return map with old (cached) list with parameters.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
Re: [PR] [MNG-6776] Inconsistent list of parameters for MojoDescriptor (#584) [maven]
kwin commented on code in PR #1361:
URL: https://github.com/apache/maven/pull/1361#discussion_r1440618341
##
maven-plugin-api/src/main/java/org/apache/maven/plugin/descriptor/MojoDescriptor.java:
##
@@ -85,8 +84,8 @@ public class MojoDescriptor extends ComponentDescriptor
implements Cloneab
private String executeLifecycle;
/**
- * Description with reason of Mojo deprecation. Similar to Javadoc {@code
@deprecated}.
- * This will trigger a warning when a user tries to use a Mojo marked as
deprecated.
+ * Specify the version when the Mojo was deprecated to the API. Similar to
Javadoc deprecated. This will trigger a
Review Comment:
In master it looks different:
https://github.com/apache/maven/blob/23d13fb322b8d66f03f02ece57d75e154f847367/maven-plugin-api/src/main/java/org/apache/maven/plugin/descriptor/MojoDescriptor.java#L88.
Seems that for some reason this PR restores the 12 year old revision
https://github.com/apache/maven/commit/acc04dca1b6a7ef39f41d976dcc8eb96aa0aa53f.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] Run CI tests also with Java 21 [maven-surefire]
slachiewicz merged PR #707: URL: https://github.com/apache/maven-surefire/pull/707 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] [DOXIASITETOOLS-323] Upgrade components [maven-doxia-sitetools]
michael-o commented on code in PR #125:
URL:
https://github.com/apache/maven-doxia-sitetools/pull/125#discussion_r1440611101
##
doxia-integration-tools/pom.xml:
##
@@ -86,9 +86,15 @@
provided
- org.apache.maven
- maven-plugin-api
- ${mavenVersion}
+ org.eclipse.aether
+ aether-api
+ ${aetherVersion}
+ provided
+
+
+ org.eclipse.aether
+ aether-impl
Review Comment:
This is what `dependency:analyze` has told me. Try for yourself.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Commented] (DOXIASITETOOLS-323) Upgrade components
[
https://issues.apache.org/jira/browse/DOXIASITETOOLS-323?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17802230#comment-17802230
]
ASF GitHub Bot commented on DOXIASITETOOLS-323:
---
michael-o commented on code in PR #125:
URL:
https://github.com/apache/maven-doxia-sitetools/pull/125#discussion_r1440611101
##
doxia-integration-tools/pom.xml:
##
@@ -86,9 +86,15 @@
provided
- org.apache.maven
- maven-plugin-api
- ${mavenVersion}
+ org.eclipse.aether
+ aether-api
+ ${aetherVersion}
+ provided
+
+
+ org.eclipse.aether
+ aether-impl
Review Comment:
This is what `dependency:analyze` has told me. Try for yourself.
> Upgrade components
> --
>
> Key: DOXIASITETOOLS-323
> URL: https://issues.apache.org/jira/browse/DOXIASITETOOLS-323
> Project: Maven Doxia Sitetools
> Issue Type: Dependency upgrade
>Reporter: Michael Osipov
>Assignee: Michael Osipov
>Priority: Major
> Fix For: 2.0.0, 2.0.0-M17
>
>
> * Upgrade to Plexus Interpolation 1.27
> * Upgrade to Plexus Testing 1.3.0
> * Upgrade to Plexus Velocity 2.1.0
> * Upgrade to Commons Lang 3.14.0
> * Upgrade to Commons IO 2.15.1
> * Upgrade to JUnit 5.10.1
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (DOXIASITETOOLS-323) Upgrade components
[
https://issues.apache.org/jira/browse/DOXIASITETOOLS-323?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17802227#comment-17802227
]
ASF GitHub Bot commented on DOXIASITETOOLS-323:
---
kwin commented on code in PR #125:
URL:
https://github.com/apache/maven-doxia-sitetools/pull/125#discussion_r1440606511
##
doxia-integration-tools/pom.xml:
##
@@ -86,9 +86,15 @@
provided
- org.apache.maven
- maven-plugin-api
- ${mavenVersion}
+ org.eclipse.aether
+ aether-api
+ ${aetherVersion}
+ provided
+
+
+ org.eclipse.aether
+ aether-impl
Review Comment:
I don't think we need impl with that scope. If at all only with "test" scope.
> Upgrade components
> --
>
> Key: DOXIASITETOOLS-323
> URL: https://issues.apache.org/jira/browse/DOXIASITETOOLS-323
> Project: Maven Doxia Sitetools
> Issue Type: Dependency upgrade
>Reporter: Michael Osipov
>Assignee: Michael Osipov
>Priority: Major
> Fix For: 2.0.0, 2.0.0-M17
>
>
> * Upgrade to Plexus Interpolation 1.27
> * Upgrade to Plexus Testing 1.3.0
> * Upgrade to Plexus Velocity 2.1.0
> * Upgrade to Commons Lang 3.14.0
> * Upgrade to Commons IO 2.15.1
> * Upgrade to JUnit 5.10.1
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
Re: [PR] [DOXIASITETOOLS-323] Upgrade components [maven-doxia-sitetools]
kwin commented on code in PR #125:
URL:
https://github.com/apache/maven-doxia-sitetools/pull/125#discussion_r1440606511
##
doxia-integration-tools/pom.xml:
##
@@ -86,9 +86,15 @@
provided
- org.apache.maven
- maven-plugin-api
- ${mavenVersion}
+ org.eclipse.aether
+ aether-api
+ ${aetherVersion}
+ provided
+
+
+ org.eclipse.aether
+ aether-impl
Review Comment:
I don't think we need impl with that scope. If at all only with "test" scope.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Commented] (SUREFIRE-2224) StatelessXmlReporter#getTestProblems() does not properly reflect report schema structure
[
https://issues.apache.org/jira/browse/SUREFIRE-2224?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17802226#comment-17802226
]
ASF GitHub Bot commented on SUREFIRE-2224:
--
michael-o commented on code in PR #702:
URL: https://github.com/apache/maven-surefire/pull/702#discussion_r1440602428
##
maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/report/StatelessXmlReporter.java:
##
@@ -456,21 +456,13 @@ private static void getTestProblems(
}
}
-boolean hasNestedElements = createOutErrElementsInside & stackTrace !=
null;
-
-if (stackTrace != null) {
-if (hasNestedElements) {
-ppw.startElement("stackTrace");
+if (enableNestedOutErrElements) {
+ppw.startElement("stackTrace");
+if (stackTrace != null) {
+extraEscapeElementValue(stackTrace, outputStreamWriter, ppw,
fw);
}
+ppw.endElement();
-extraEscapeElementValue(stackTrace, outputStreamWriter, ppw, fw);
Review Comment:
Fix: https://github.com/apache/maven-surefire/pull/709
> StatelessXmlReporter#getTestProblems() does not properly reflect report
> schema structure
>
>
> Key: SUREFIRE-2224
> URL: https://issues.apache.org/jira/browse/SUREFIRE-2224
> Project: Maven Surefire
> Issue Type: Bug
> Components: xml generation
>Affects Versions: 3.2.3
>Reporter: Michael Osipov
>Assignee: Michael Osipov
>Priority: Major
> Fix For: 3.2.4, 3.2.5
>
>
> According to
> https://maven.apache.org/surefire/maven-surefire-plugin/xsd/surefire-test-report.xsd
> and
> https://maven.apache.org/surefire/maven-failsafe-plugin/xsd/failsafe-test-report.xsd
> not all nested elements contain {{stackTrace}}, {{system-out}} and
> {{system-err}} elements, but the code makes it conditional whether there is a
> stack trace or not. This does not comply with the schema definition. Either
> the nested element is simple content or complex. In the latter {{stackTrace}}
> is mandatory, even if there is no strack trace according to the schema. The
> system streams are optional.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
Re: [PR] [SUREFIRE-2224] StatelessXmlReporter#getTestProblems() does not properly reflect report schema structure [maven-surefire]
michael-o commented on code in PR #702:
URL: https://github.com/apache/maven-surefire/pull/702#discussion_r1440602428
##
maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/report/StatelessXmlReporter.java:
##
@@ -456,21 +456,13 @@ private static void getTestProblems(
}
}
-boolean hasNestedElements = createOutErrElementsInside & stackTrace !=
null;
-
-if (stackTrace != null) {
-if (hasNestedElements) {
-ppw.startElement("stackTrace");
+if (enableNestedOutErrElements) {
+ppw.startElement("stackTrace");
+if (stackTrace != null) {
+extraEscapeElementValue(stackTrace, outputStreamWriter, ppw,
fw);
}
+ppw.endElement();
-extraEscapeElementValue(stackTrace, outputStreamWriter, ppw, fw);
Review Comment:
Fix: https://github.com/apache/maven-surefire/pull/709
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[jira] [Commented] (SUREFIRE-2229) [REGRESSION] SUREFIRE-2224 causes stack trace to be omitted for errors and failures
[
https://issues.apache.org/jira/browse/SUREFIRE-2229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17802225#comment-17802225
]
ASF GitHub Bot commented on SUREFIRE-2229:
--
michael-o commented on PR #709:
URL: https://github.com/apache/maven-surefire/pull/709#issuecomment-1875574599
@marcphilipp Please have a look. That should solve the regression.
> [REGRESSION] SUREFIRE-2224 causes stack trace to be omitted for errors and
> failures
> ---
>
> Key: SUREFIRE-2229
> URL: https://issues.apache.org/jira/browse/SUREFIRE-2229
> Project: Maven Surefire
> Issue Type: Bug
>Affects Versions: 3.2.4
>Reporter: Michael Osipov
>Assignee: Michael Osipov
>Priority: Major
> Fix For: 3.2.5
>
>
> As reported by [~marcphilipp]
> [here|https://github.com/apache/maven-surefire/pull/702#discussion_r1439664959]
> the stack traces of {{failure}} and {{error}} are omitted due to bad XML
> schema design. Restore the ability to record the stack trace and log an
> improvement request to the XML schema.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (SUREFIRE-2229) [REGRESSION] SUREFIRE-2224 causes stack trace to be omitted for errors and failures
[
https://issues.apache.org/jira/browse/SUREFIRE-2229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17802224#comment-17802224
]
ASF GitHub Bot commented on SUREFIRE-2229:
--
michael-o opened a new pull request, #709:
URL: https://github.com/apache/maven-surefire/pull/709
…mitted for errors and failures
This closes #709
Following this checklist to help us incorporate your
contribution quickly and easily:
- [ ] Make sure there is a [JIRA
issue](https://issues.apache.org/jira/browse/SUREFIRE) filed
for the change (usually before you start working on it). Trivial
changes like typos do not
require a JIRA issue. Your pull request should address just this
issue, without
pulling in other changes.
- [ ] Each commit in the pull request should have a meaningful subject line
and body.
- [ ] Format the pull request title like `[SUREFIRE-XXX] - Fixes bug in
ApproximateQuantiles`,
where you replace `SUREFIRE-XXX` with the appropriate JIRA issue.
Best practice
is to use the JIRA issue title in the pull request title and in the
first line of the
commit message.
- [ ] Write a pull request description that is detailed enough to
understand what the pull request does, how, and why.
- [ ] Run `mvn clean install` to make sure basic checks pass. A more
thorough check will
be performed on your pull request automatically.
- [ ] You have run the integration tests successfully (`mvn -Prun-its clean
install`).
If your pull request is about ~20 lines of code you don't need to sign an
[Individual Contributor License
Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure
please ask on the developers list.
To make clear that you license your contribution under
the [Apache License Version 2.0, January
2004](http://www.apache.org/licenses/LICENSE-2.0)
you have to acknowledge this by using the following check-box.
- [ ] I hereby declare this contribution to be licenced under the [Apache
License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
- [ ] In any other case, please file an [Apache Individual Contributor
License Agreement](https://www.apache.org/licenses/icla.pdf).
> [REGRESSION] SUREFIRE-2224 causes stack trace to be omitted for errors and
> failures
> ---
>
> Key: SUREFIRE-2229
> URL: https://issues.apache.org/jira/browse/SUREFIRE-2229
> Project: Maven Surefire
> Issue Type: Bug
>Affects Versions: 3.2.4
>Reporter: Michael Osipov
>Assignee: Michael Osipov
>Priority: Major
> Fix For: 3.2.5
>
>
> As reported by [~marcphilipp]
> [here|https://github.com/apache/maven-surefire/pull/702#discussion_r1439664959]
> the stack traces of {{failure}} and {{error}} are omitted due to bad XML
> schema design. Restore the ability to record the stack trace and log an
> improvement request to the XML schema.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
Re: [PR] [SUREFIRE-2229] [REGRESSION] SUREFIRE-2224 causes stack trace to be o… [maven-surefire]
michael-o commented on PR #709: URL: https://github.com/apache/maven-surefire/pull/709#issuecomment-1875574599 @marcphilipp Please have a look. That should solve the regression. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] [SUREFIRE-2229] [REGRESSION] SUREFIRE-2224 causes stack trace to be o… [maven-surefire]
michael-o opened a new pull request, #709: URL: https://github.com/apache/maven-surefire/pull/709 …mitted for errors and failures This closes #709 Following this checklist to help us incorporate your contribution quickly and easily: - [ ] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/SUREFIRE) filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes. - [ ] Each commit in the pull request should have a meaningful subject line and body. - [ ] Format the pull request title like `[SUREFIRE-XXX] - Fixes bug in ApproximateQuantiles`, where you replace `SUREFIRE-XXX` with the appropriate JIRA issue. Best practice is to use the JIRA issue title in the pull request title and in the first line of the commit message. - [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - [ ] Run `mvn clean install` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically. - [ ] You have run the integration tests successfully (`mvn -Prun-its clean install`). If your pull request is about ~20 lines of code you don't need to sign an [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure please ask on the developers list. To make clear that you license your contribution under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) you have to acknowledge this by using the following check-box. - [ ] I hereby declare this contribution to be licenced under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0) - [ ] In any other case, please file an [Apache Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Run CI tests also with Java 21 [maven-surefire]
michael-o commented on PR #707: URL: https://github.com/apache/maven-surefire/pull/707#issuecomment-1875567157 Boldly merge this. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Updated] (SUREFIRE-2230) Make failure and error element in XML test report schemas complex instead of simple
[
https://issues.apache.org/jira/browse/SUREFIRE-2230?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael Osipov updated SUREFIRE-2230:
-
Description:
Because of (bad/legacy) design choices both schemas
https://maven.apache.org/surefire/maven-surefire-plugin/xsd/surefire-test-report.xsd
and
https://maven.apache.org/surefire/maven-failsafe-plugin/xsd/failsafe-test-report.xsd
make both elements {{failure}} and {{error}} simple where the stack trace is
not a nested element, but the body of those elements. This is inconsistent with
other elements. With the next major version of Surefire this shall be changed
to complex elements with a nested {{stackTrace}} elements.
This is the outcome of SUREFIRE-2229.
was:
Because of (bad) design choices both schemas
https://maven.apache.org/surefire/maven-surefire-plugin/xsd/surefire-test-report.xsd
and
https://maven.apache.org/surefire/maven-failsafe-plugin/xsd/failsafe-test-report.xsd
make both elements {{failure}} and {{error}} simple where the stack trace is
not a nested element, but the body of those elements. This is inconsistent with
other elements. With the next major version of Surefire this shall be changed
to complex elements with a nested {{stackTrace}} elements.
This is the outcome of SUREFIRE-2229.
> Make failure and error element in XML test report schemas complex instead of
> simple
> ---
>
> Key: SUREFIRE-2230
> URL: https://issues.apache.org/jira/browse/SUREFIRE-2230
> Project: Maven Surefire
> Issue Type: New Feature
> Components: Maven Surefire Report Plugin, xml generation
>Affects Versions: 3.2.3
>Reporter: Michael Osipov
>Priority: Major
> Fix For: Backlog
>
>
> Because of (bad/legacy) design choices both schemas
> https://maven.apache.org/surefire/maven-surefire-plugin/xsd/surefire-test-report.xsd
> and
> https://maven.apache.org/surefire/maven-failsafe-plugin/xsd/failsafe-test-report.xsd
> make both elements {{failure}} and {{error}} simple where the stack trace is
> not a nested element, but the body of those elements. This is inconsistent
> with other elements. With the next major version of Surefire this shall be
> changed to complex elements with a nested {{stackTrace}} elements.
> This is the outcome of SUREFIRE-2229.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[I] `mvnd help:evaluate` regression [maven-mvnd]
Allsimon opened a new issue, #904: URL: https://github.com/apache/maven-mvnd/issues/904 `mvnd help:evaluate` doesn't print anything anymore since `1.0-m7-m39` To reproduce, setup a basic project: ```shell mvn archetype:generate -DgroupId=com.mycompany.app -DartifactId=my-app -DarchetypeArtifactId=maven-archetype-quickstart -DarchetypeVersion=1.4 -DinteractiveMode=false cd my-app mkdir .mvn ``` then run `mvnd help:evaluate -Dexpression=project.version -q -DforceStdout` using SDKMAN, it looks like it was broken in `1.0-m7-m39`: ```shell ~ sdk use mvnd 1.0-m6-m40 Using mvnd version 1.0-m6-m40 in this shell. ~ mvnd help:evaluate -Dexpression=project.version -q -DforceStdout [INFO] [stdout] 1.0-SNAPSHOT ~ sdk use mvnd 1.0-m7-m39 Using mvnd version 1.0-m7-m39 in this shell. ~ mvnd help:evaluate -Dexpression=project.version -q -DforceStdout ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (SUREFIRE-2229) [REGRESSION] SUREFIRE-2224 causes stack trace to be omitted for errors and failures
[
https://issues.apache.org/jira/browse/SUREFIRE-2229?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17802202#comment-17802202
]
Michael Osipov commented on SUREFIRE-2229:
--
[~marcphilipp]
> [REGRESSION] SUREFIRE-2224 causes stack trace to be omitted for errors and
> failures
> ---
>
> Key: SUREFIRE-2229
> URL: https://issues.apache.org/jira/browse/SUREFIRE-2229
> Project: Maven Surefire
> Issue Type: Bug
>Affects Versions: 3.2.4
>Reporter: Michael Osipov
>Assignee: Michael Osipov
>Priority: Major
> Fix For: 3.2.5
>
>
> As reported by [~marcphilipp]
> [here|https://github.com/apache/maven-surefire/pull/702#discussion_r1439664959]
> the stack traces of {{failure}} and {{error}} are omitted due to bad XML
> schema design. Restore the ability to record the stack trace and log an
> improvement request to the XML schema.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (SUREFIRE-2230) Make failure and error element in XML test report schemas complex instead of simple
[
https://issues.apache.org/jira/browse/SUREFIRE-2230?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17802203#comment-17802203
]
Michael Osipov commented on SUREFIRE-2230:
--
[~marcphilipp]
> Make failure and error element in XML test report schemas complex instead of
> simple
> ---
>
> Key: SUREFIRE-2230
> URL: https://issues.apache.org/jira/browse/SUREFIRE-2230
> Project: Maven Surefire
> Issue Type: New Feature
> Components: Maven Surefire Report Plugin, xml generation
>Affects Versions: 3.2.3
>Reporter: Michael Osipov
>Priority: Major
> Fix For: Backlog
>
>
> Because of (bad) design choices both schemas
> https://maven.apache.org/surefire/maven-surefire-plugin/xsd/surefire-test-report.xsd
> and
> https://maven.apache.org/surefire/maven-failsafe-plugin/xsd/failsafe-test-report.xsd
> make both elements {{failure}} and {{error}} simple where the stack trace is
> not a nested element, but the body of those elements. This is inconsistent
> with other elements. With the next major version of Surefire this shall be
> changed to complex elements with a nested {{stackTrace}} elements.
> This is the outcome of SUREFIRE-2229.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Created] (SUREFIRE-2230) Make failure and error element in XML test report schemas complex instead of simple
Michael Osipov created SUREFIRE-2230:
Summary: Make failure and error element in XML test report schemas
complex instead of simple
Key: SUREFIRE-2230
URL: https://issues.apache.org/jira/browse/SUREFIRE-2230
Project: Maven Surefire
Issue Type: New Feature
Components: Maven Surefire Report Plugin, xml generation
Affects Versions: 3.2.3
Reporter: Michael Osipov
Fix For: Backlog
Because of (bad) design choices both schemas
https://maven.apache.org/surefire/maven-surefire-plugin/xsd/surefire-test-report.xsd
and
https://maven.apache.org/surefire/maven-failsafe-plugin/xsd/failsafe-test-report.xsd
make both elements {{failure}} and {{error}} simple where the stack trace is
not a nested element, but the body of those elements. This is inconsistent with
other elements. With the next major version of Surefire this shall be changed
to complex elements with a nested {{stackTrace}} elements.
This is the outcome of SUREFIRE-2229.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
[jira] [Commented] (MARCHETYPES-76) maven-archetype-quickstart generates EOLed maven.compiler setup
[ https://issues.apache.org/jira/browse/MARCHETYPES-76?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17802188#comment-17802188 ] jiri vanek commented on MARCHETYPES-76: --- Afaik this is done, and should be closed. It seems jira was not autoclosed due to reopen status. Please anybody, do. > maven-archetype-quickstart generates EOLed maven.compiler setup > > > Key: MARCHETYPES-76 > URL: https://issues.apache.org/jira/browse/MARCHETYPES-76 > Project: Maven Archetype Bundles > Issue Type: Bug > Components: Maven Quickstart Archetype >Reporter: jiri vanek >Priority: Major > > The default imput to #compilerProperties is 1.7, which is making any > generated project to be not buildable with fresh jdk21. The default should > be1.8. Where jdk8 is still live and jdk21 is still comaptible with it. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[jira] [Commented] (MARCHETYPES-78) Update default Java version in archetype projects to 1.8
[
https://issues.apache.org/jira/browse/MARCHETYPES-78?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17802186#comment-17802186
]
jiri vanek commented on MARCHETYPES-78:
---
I was jsut going to manually close this. But you reassinged to yourslef, so do
as you need. TY!
> Update default Java version in archetype projects to 1.8
>
>
> Key: MARCHETYPES-78
> URL: https://issues.apache.org/jira/browse/MARCHETYPES-78
> Project: Maven Archetype Bundles
> Issue Type: Improvement
>Reporter: jiri vanek
>Assignee: Elliotte Rusty Harold
>Priority: Major
>
> namely at least
> maven-archetype-plugin/src/main/resources-filtered/archetype-resources/pom.xml
> maven-archetype-archetype/src/main/resources-filtered/archetype-resources/src/main/resources/archetype-resources/pom.xml
> maven-archetype-archetype/src/main/resources-filtered/archetype-resources/pom.xml
> maven-archetype-profiles/src/main/resources-filtered/archetype-resources/pom.xml
> maven-archetype-simple/src/main/resources-filtered/archetype-resources/pom.xml
> maven-archetype-portlet/src/main/resources-filtered/archetype-resources/pom.xml
> maven-archetype-quickstart/src/main/resources-filtered/archetype-resources/pom.xml
> still use 1.7 as default version.
> I'm happy to fix them all (see
> https://github.com/apache/maven-archetypes/pull/18 and
> https://issues.apache.org/jira/projects/MARCHETYPES/issues/MARCHETYPES-76),
> but first I need some ack from somebody with commit permissions to
> MARCHETYPES/https://github.com/apache/maven-archetypes
> {code:java}
> grep -ir -e maven.compiler.source -e maven.compiler.target| grep -v test
> maven-archetype-plugin/src/main/resources-filtered/archetype-resources/pom.xml:
> 1.7
> maven-archetype-plugin/src/main/resources-filtered/archetype-resources/pom.xml:
> 1.7
> maven-archetype-archetype/src/main/resources-filtered/archetype-resources/src/main/resources/archetype-resources/pom.xml:
> 1.7
> maven-archetype-archetype/src/main/resources-filtered/archetype-resources/src/main/resources/archetype-resources/pom.xml:
> 1.7
> maven-archetype-archetype/src/main/resources-filtered/archetype-resources/pom.xml:
> 1.7
> maven-archetype-archetype/src/main/resources-filtered/archetype-resources/pom.xml:
> 1.7
> maven-archetype-profiles/src/main/resources-filtered/archetype-resources/pom.xml:
> 1.7
> maven-archetype-profiles/src/main/resources-filtered/archetype-resources/pom.xml:
> 1.7
> maven-archetype-webapp/src/main/resources-filtered/archetype-resources/pom.xml:
> 1.8
> maven-archetype-webapp/src/main/resources-filtered/archetype-resources/pom.xml:
> 1.8
> maven-archetype-simple/src/main/resources-filtered/archetype-resources/pom.xml:
> 1.7
> maven-archetype-simple/src/main/resources-filtered/archetype-resources/pom.xml:
> 1.7
> maven-archetype-portlet/src/main/resources-filtered/archetype-resources/pom.xml:
> 1.7
> maven-archetype-portlet/src/main/resources-filtered/archetype-resources/pom.xml:
> 1.7
> maven-archetype-quickstart/src/main/resources-filtered/archetype-resources/pom.xml:
> ${jcv}
> maven-archetype-quickstart/src/main/resources-filtered/archetype-resources/pom.xml:
> ${jcv}
> {code}
> with tests:
> {code:java}
> grep -ir -e maven.compiler.source -e maven.compiler.target
> maven-archetype-plugin/src/main/resources-filtered/archetype-resources/pom.xml:
> 1.7
> maven-archetype-plugin/src/main/resources-filtered/archetype-resources/pom.xml:
> 1.7
> maven-archetype-archetype/src/main/resources-filtered/archetype-resources/src/main/resources/archetype-resources/pom.xml:
> 1.7
> maven-archetype-archetype/src/main/resources-filtered/archetype-resources/src/main/resources/archetype-resources/pom.xml:
> 1.7
> maven-archetype-archetype/src/main/resources-filtered/archetype-resources/pom.xml:
> 1.7
> maven-archetype-archetype/src/main/resources-filtered/archetype-resources/pom.xml:
> 1.7
> maven-archetype-profiles/src/main/resources-filtered/archetype-resources/pom.xml:
> 1.7
> maven-archetype-profiles/src/main/resources-filtered/archetype-resources/pom.xml:
> 1.7
> maven-archetype-webapp/src/main/resources-filtered/archetype-resources/pom.xml:
> 1.8
> maven-archetype-webapp/src/main/resources-filtered/archetype-resources/pom.xml:
> 1.8
> maven-archetype-simple/src/main/resources-filtered/archetype-resources/pom.xml:
> 1.7
> maven-archetype-simple/src/main/resources-filtered/archetype-resources/pom.xml:
> 1.7
> maven-archetype-portlet/src/main/resources-filtered/archetype-resources/pom.xml:
> 1.7
> maven-archetype-portlet/src/main/resources-filtered/archetype-resources/pom.xml:
> 1.7
> maven-archetype-quickstart/src/main/resources-filtered/archetype-resources/pom.xml:
> ${jcv}
Re: [PR] Bump org.apache.maven:maven-parent from 39 to 41 [maven-archetype]
slawekjaranowski commented on code in PR #162: URL: https://github.com/apache/maven-archetype/pull/162#discussion_r1440474263 ## maven-archetype-plugin/pom.xml: ## @@ -210,13 +210,6 @@ org.apache.maven.plugins maven-plugin-plugin Review Comment: `maven-plugin-report-plugin` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump org.assertj:assertj-core from 3.24.2 to 3.25.0 [maven-plugin-tools]
dependabot[bot] closed pull request #255: Bump org.assertj:assertj-core from 3.24.2 to 3.25.0 URL: https://github.com/apache/maven-plugin-tools/pull/255 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump org.assertj:assertj-core from 3.24.2 to 3.25.0 [maven-plugin-tools]
dependabot[bot] commented on PR #255: URL: https://github.com/apache/maven-plugin-tools/pull/255#issuecomment-1875396538 Superseded by #256. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[PR] Bump org.assertj:assertj-core from 3.24.2 to 3.25.1 [maven-plugin-tools]
dependabot[bot] opened a new pull request, #256: URL: https://github.com/apache/maven-plugin-tools/pull/256 Bumps [org.assertj:assertj-core](https://github.com/assertj/assertj) from 3.24.2 to 3.25.1. Release notes Sourced from https://github.com/assertj/assertj/releases;>org.assertj:assertj-core's releases. v3.25.1 :jigsaw: Binary Compatibility The release is: Binary compatible with the previous minor version. Binary incompatible with the previous patch version. :bug: Bug Fixes Core Revert Provide value when assertThatThrownBy/thenThrownBy fail https://redirect.github.com/assertj/assertj/issues/3318;>#3318 Revert fix: containsExactly does not work properly with maps not using equals to compare keys https://redirect.github.com/assertj/assertj/issues/3321;>#3321 v3.25.0 :jigsaw: Binary Compatibility The release is https://assertj.github.io/doc/#binary-compatibility;>binary compatible with the previous minor version. :no_entry_sign: Deprecated Core Deprecate the following date/time related assertions in favor of isCloseTo: isEqualToIgnoringHours isEqualToIgnoringMinutes isEqualToIgnoringSeconds isEqualToIgnoringMillis isEqualToIgnoringNanos isInSameHourAs isInSameMinuteAs isInSameSecondAs Deprecate asList in favor of asInstanceOf https://redirect.github.com/assertj/assertj/issues/3138;>#3138 :sparkles: New Features Core Add Descriptable#describedAs(SupplierString) Add isInThePast and isInTheFuture to LocalDate assertions https://redirect.github.com/assertj/assertj/issues/2933;>#2933 Add isInThePast and isInTheFuture to the missing Java 8 date/time types https://redirect.github.com/assertj/assertj/issues/2947;>#2947 Add isRecord and isNotRecord to Class assertions https://redirect.github.com/assertj/assertj/issues/2968;>#2968 Add hasNullValue and doesNotHaveNullValue to AtomicReferenceAssert https://redirect.github.com/assertj/assertj/issues/2969;>#2969 Add asBoolean|Byte|Short|Int|Long|Float|Double to String assertions https://redirect.github.com/assertj/assertj/issues/2580;>#2580 Add hasRecordComponents to Class assertions https://redirect.github.com/assertj/assertj/issues/2995;>#2995 Add getters for field path in ComparisonDifference https://redirect.github.com/assertj/assertj/issues/3007;>#3007 Allow to compare enum and string fields in the recursive comparison https://redirect.github.com/assertj/assertj/issues/2616;>#2616 Provide value when assertThatThrownBy / thenThrownBy fail https://redirect.github.com/assertj/assertj/issues/3043;>#3043 Add isSealed and isNotSealed to Class assertions https://redirect.github.com/assertj/assertj/issues/3080;>#3080 Add assertThatCharSequence to disambiguate Groovy's GString https://redirect.github.com/assertj/assertj/issues/3132;>#3132 ... (truncated) Commits https://github.com/assertj/assertj/commit/65f6433d26f74795434ac2ef2118cd5cec7c1be4;>65f6433 [maven-release-plugin] prepare release assertj-build-3.25.1 https://github.com/assertj/assertj/commit/4753165446ddec5e25250e52e6e5582093793262;>4753165 Revert fix: containsExactly does not work properly with maps not using equal... https://github.com/assertj/assertj/commit/2a7c5a6e205e29d42e9886657987893cb03b6875;>2a7c5a6 Revert Provide value when assertThatThrownBy/thenThrownBy fail (https://redirect.github.com/assertj/assertj/issues/3318;>#3318) https://github.com/assertj/assertj/commit/887f97b65da068e03308a6373a0c8a76912377aa;>887f97b Update license headers https://github.com/assertj/assertj/commit/25347d57bb28295548ec6bd5b06e70b6d03496c9;>25347d5 [maven-release-plugin] prepare for next development iteration https://github.com/assertj/assertj/commit/2c1c0839af66989c2d30d5b556799ca75ef2c246;>2c1c083 [maven-release-plugin] prepare release assertj-build-3.25.0 https://github.com/assertj/assertj/commit/c44129de725f5a3ecbaba16dd7b9ec31fd9e293b;>c44129d Move flatten-maven-plugin version to separate property https://github.com/assertj/assertj/commit/31cefaf68c04e13c6703033151f776251782af85;>31cefaf Apply flatten-maven-plugin to assertj-core and assertj-guava (https://redirect.github.com/assertj/assertj/issues/3311;>#3311) https://github.com/assertj/assertj/commit/435d183f2ededb18246338fb780098fabfba700b;>435d183 chore(deps-dev): bump org.testng:testng from 7.8.0 to 7.9.0 (https://redirect.github.com/assertj/assertj/issues/3312;>#3312) https://github.com/assertj/assertj/commit/e044604d99cdb513177d467886d51c47e0163251;>e044604 chore(deps-dev): bump nl.jqno.equalsverifier:equalsverifier from 3.15.4 to 3 Additional commits viewable in https://github.com/assertj/assertj/compare/assertj-build-3.24.2...assertj-build-3.25.1;>compare view [![Dependabot compatibility
Re: [PR] Bump org.apache.maven:maven-parent from 39 to 41 [maven-archetype]
slachiewicz commented on code in PR #162: URL: https://github.com/apache/maven-archetype/pull/162#discussion_r1440464371 ## maven-archetype-plugin/pom.xml: ## @@ -210,13 +210,6 @@ org.apache.maven.plugins maven-plugin-plugin Review Comment: What I shoud add? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump org.apache.maven:maven-parent from 39 to 41 [maven-archetype]
slawekjaranowski commented on code in PR #162: URL: https://github.com/apache/maven-archetype/pull/162#discussion_r1440455576 ## maven-archetype-plugin/pom.xml: ## @@ -210,13 +210,6 @@ org.apache.maven.plugins maven-plugin-plugin Review Comment: There is no report in `maven-plugin-plugin` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump org.apache.maven.shared:maven-invoker from 3.0.1 to 3.2.0 [maven-archetype]
elharo commented on PR #172: URL: https://github.com/apache/maven-archetype/pull/172#issuecomment-1875376484 @dependabot rebase -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump org.apache.maven:maven-parent from 39 to 41 [maven-archetype]
slawekjaranowski commented on code in PR #162: URL: https://github.com/apache/maven-archetype/pull/162#discussion_r1440455576 ## maven-archetype-plugin/pom.xml: ## @@ -210,13 +210,6 @@ org.apache.maven.plugins maven-plugin-plugin Review Comment: There is no report in `maven-plugin-plugi` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Assigned] (MARCHETYPES-78) Update default Java version in archetype projects to 1.8
[
https://issues.apache.org/jira/browse/MARCHETYPES-78?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Elliotte Rusty Harold reassigned MARCHETYPES-78:
Assignee: Elliotte Rusty Harold
> Update default Java version in archetype projects to 1.8
>
>
> Key: MARCHETYPES-78
> URL: https://issues.apache.org/jira/browse/MARCHETYPES-78
> Project: Maven Archetype Bundles
> Issue Type: Improvement
>Reporter: jiri vanek
>Assignee: Elliotte Rusty Harold
>Priority: Major
>
> namely at least
> maven-archetype-plugin/src/main/resources-filtered/archetype-resources/pom.xml
> maven-archetype-archetype/src/main/resources-filtered/archetype-resources/src/main/resources/archetype-resources/pom.xml
> maven-archetype-archetype/src/main/resources-filtered/archetype-resources/pom.xml
> maven-archetype-profiles/src/main/resources-filtered/archetype-resources/pom.xml
> maven-archetype-simple/src/main/resources-filtered/archetype-resources/pom.xml
> maven-archetype-portlet/src/main/resources-filtered/archetype-resources/pom.xml
> maven-archetype-quickstart/src/main/resources-filtered/archetype-resources/pom.xml
> still use 1.7 as default version.
> I'm happy to fix them all (see
> https://github.com/apache/maven-archetypes/pull/18 and
> https://issues.apache.org/jira/projects/MARCHETYPES/issues/MARCHETYPES-76),
> but first I need some ack from somebody with commit permissions to
> MARCHETYPES/https://github.com/apache/maven-archetypes
> {code:java}
> grep -ir -e maven.compiler.source -e maven.compiler.target| grep -v test
> maven-archetype-plugin/src/main/resources-filtered/archetype-resources/pom.xml:
> 1.7
> maven-archetype-plugin/src/main/resources-filtered/archetype-resources/pom.xml:
> 1.7
> maven-archetype-archetype/src/main/resources-filtered/archetype-resources/src/main/resources/archetype-resources/pom.xml:
> 1.7
> maven-archetype-archetype/src/main/resources-filtered/archetype-resources/src/main/resources/archetype-resources/pom.xml:
> 1.7
> maven-archetype-archetype/src/main/resources-filtered/archetype-resources/pom.xml:
> 1.7
> maven-archetype-archetype/src/main/resources-filtered/archetype-resources/pom.xml:
> 1.7
> maven-archetype-profiles/src/main/resources-filtered/archetype-resources/pom.xml:
> 1.7
> maven-archetype-profiles/src/main/resources-filtered/archetype-resources/pom.xml:
> 1.7
> maven-archetype-webapp/src/main/resources-filtered/archetype-resources/pom.xml:
> 1.8
> maven-archetype-webapp/src/main/resources-filtered/archetype-resources/pom.xml:
> 1.8
> maven-archetype-simple/src/main/resources-filtered/archetype-resources/pom.xml:
> 1.7
> maven-archetype-simple/src/main/resources-filtered/archetype-resources/pom.xml:
> 1.7
> maven-archetype-portlet/src/main/resources-filtered/archetype-resources/pom.xml:
> 1.7
> maven-archetype-portlet/src/main/resources-filtered/archetype-resources/pom.xml:
> 1.7
> maven-archetype-quickstart/src/main/resources-filtered/archetype-resources/pom.xml:
> ${jcv}
> maven-archetype-quickstart/src/main/resources-filtered/archetype-resources/pom.xml:
> ${jcv}
> {code}
> with tests:
> {code:java}
> grep -ir -e maven.compiler.source -e maven.compiler.target
> maven-archetype-plugin/src/main/resources-filtered/archetype-resources/pom.xml:
> 1.7
> maven-archetype-plugin/src/main/resources-filtered/archetype-resources/pom.xml:
> 1.7
> maven-archetype-archetype/src/main/resources-filtered/archetype-resources/src/main/resources/archetype-resources/pom.xml:
> 1.7
> maven-archetype-archetype/src/main/resources-filtered/archetype-resources/src/main/resources/archetype-resources/pom.xml:
> 1.7
> maven-archetype-archetype/src/main/resources-filtered/archetype-resources/pom.xml:
> 1.7
> maven-archetype-archetype/src/main/resources-filtered/archetype-resources/pom.xml:
> 1.7
> maven-archetype-profiles/src/main/resources-filtered/archetype-resources/pom.xml:
> 1.7
> maven-archetype-profiles/src/main/resources-filtered/archetype-resources/pom.xml:
> 1.7
> maven-archetype-webapp/src/main/resources-filtered/archetype-resources/pom.xml:
> 1.8
> maven-archetype-webapp/src/main/resources-filtered/archetype-resources/pom.xml:
> 1.8
> maven-archetype-simple/src/main/resources-filtered/archetype-resources/pom.xml:
> 1.7
> maven-archetype-simple/src/main/resources-filtered/archetype-resources/pom.xml:
> 1.7
> maven-archetype-portlet/src/main/resources-filtered/archetype-resources/pom.xml:
> 1.7
> maven-archetype-portlet/src/main/resources-filtered/archetype-resources/pom.xml:
> 1.7
> maven-archetype-quickstart/src/main/resources-filtered/archetype-resources/pom.xml:
> ${jcv}
>
Re: [PR] Bump org.codehaus.plexus:plexus-archiver from 4.9.0 to 4.9.1 [maven-dependency-plugin]
elharo merged PR #358: URL: https://github.com/apache/maven-dependency-plugin/pull/358 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump org.apache.maven:maven-parent from 39 to 41 [maven-archetype]
slachiewicz merged PR #162: URL: https://github.com/apache/maven-archetype/pull/162 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Renamed local variable in maven archetype quickstart [maven-archetypes]
judovana commented on PR #26: URL: https://github.com/apache/maven-archetypes/pull/26#issuecomment-1875354256 tyvm sir! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MNG-6776) Inconsistent list of parameters in MojoDescriptor
[
https://issues.apache.org/jira/browse/MNG-6776?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17802157#comment-17802157
]
ASF GitHub Bot commented on MNG-6776:
-
michael-o commented on code in PR #1361:
URL: https://github.com/apache/maven/pull/1361#discussion_r1440420958
##
maven-plugin-api/src/main/java/org/apache/maven/plugin/descriptor/MojoDescriptor.java:
##
@@ -85,8 +84,8 @@ public class MojoDescriptor extends ComponentDescriptor
implements Cloneab
private String executeLifecycle;
/**
- * Description with reason of Mojo deprecation. Similar to Javadoc {@code
@deprecated}.
- * This will trigger a warning when a user tries to use a Mojo marked as
deprecated.
+ * Specify the version when the Mojo was deprecated to the API. Similar to
Javadoc deprecated. This will trigger a
Review Comment:
This is a pure backport, I didn't modify anything. Improvements should go to
master and than be backported.
> Inconsistent list of parameters in MojoDescriptor
> -
>
> Key: MNG-6776
> URL: https://issues.apache.org/jira/browse/MNG-6776
> Project: Maven
> Issue Type: Bug
> Components: Plugin API
>Affects Versions: 3.6.2
>Reporter: Sylwester Lachiewicz
>Assignee: Tamas Cservenak
>Priority: Minor
> Time Spent: 10m
> Remaining Estimate: 0h
>
> While working with maven-plugin-tools I discovered inconsistent results
> returned from MojoDescriptor getParameters() and getParametersMap().
> In
> [AntMojoDescriptorExtractor.java#L101|https://github.com/apache/maven-plugin-tools/blob/master/maven-script/maven-plugin-tools-ant/src/main/java/org/apache/maven/tools/plugin/extractor/ant/AntMojoDescriptorExtractor.java#L101]
> If first I call MojoDescriptor.getParameterMap() and then later add parameter
> via MojoDescriptor.addParameter - MojoDescriptor.getParameterMap() will still
> return map with old (cached) list with parameters.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
Re: [PR] [MNG-6776] Inconsistent list of parameters for MojoDescriptor (#584) [maven]
michael-o commented on code in PR #1361:
URL: https://github.com/apache/maven/pull/1361#discussion_r1440420958
##
maven-plugin-api/src/main/java/org/apache/maven/plugin/descriptor/MojoDescriptor.java:
##
@@ -85,8 +84,8 @@ public class MojoDescriptor extends ComponentDescriptor
implements Cloneab
private String executeLifecycle;
/**
- * Description with reason of Mojo deprecation. Similar to Javadoc {@code
@deprecated}.
- * This will trigger a warning when a user tries to use a Mojo marked as
deprecated.
+ * Specify the version when the Mojo was deprecated to the API. Similar to
Javadoc deprecated. This will trigger a
Review Comment:
This is a pure backport, I didn't modify anything. Improvements should go to
master and than be backported.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Re: [PR] Bump org.codehaus.plexus:plexus-io from 3.4.1 to 3.4.2 [maven-dependency-plugin]
elharo merged PR #359: URL: https://github.com/apache/maven-dependency-plugin/pull/359 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump org.jsoup:jsoup from 1.17.1 to 1.17.2 [maven-dependency-plugin]
elharo merged PR #361: URL: https://github.com/apache/maven-dependency-plugin/pull/361 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Re: [PR] Bump org.apache.maven.shared:maven-shared-components from 40 to 41 [maven-dependency-analyzer]
elharo commented on PR #101: URL: https://github.com/apache/maven-dependency-analyzer/pull/101#issuecomment-1875326530 @dependabot rebase -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Commented] (MSHARED-1347) maven-dependency-plugin ignores class of object passed as a parameter to method references
[
https://issues.apache.org/jira/browse/MSHARED-1347?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17802155#comment-17802155
]
ASF GitHub Bot commented on MSHARED-1347:
-
elharo merged PR #102:
URL: https://github.com/apache/maven-dependency-analyzer/pull/102
> maven-dependency-plugin ignores class of object passed as a parameter to
> method references
> --
>
> Key: MSHARED-1347
> URL: https://issues.apache.org/jira/browse/MSHARED-1347
> Project: Maven Shared Components
> Issue Type: Bug
> Components: maven-dependency-analyzer
>Affects Versions: maven-dependency-analyzer-1.13.2
>Reporter: Vidar Breivik
>Priority: Minor
>
> Text copied from [MDEP-576|https://issues.apache.org/jira/browse/MDEP-576]
> Hi there, i created a project on
> [github|https://github.com/vdergachev/dependency-plugin-vs-java-lambda] that
> can help you to reproduce the issue. Just clone it and make
> {code:java}
> mvn clean install{code}
> In my case plugin ignored Server class from jetty-server.jar and a as result
> i got message
> {code:java}
> Unused declared dependencies found{code}
>
> h4.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
Re: [PR] [MSHARED-1347] Include invoke dynamic bootstrap types in analysis [maven-dependency-analyzer]
elharo merged PR #102: URL: https://github.com/apache/maven-dependency-analyzer/pull/102 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@maven.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
