D15566: Add QT_NO_NARROWING_CONVERSIONS_IN_CONNECT as default compile flags
mlaurent added a comment. I fixed 2 repos. Otherwise all compiles fine (ok I don't test on windows/mac and perhaps some module is not compiles on my computer) REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D15566 To: mlaurent, dfaure Cc: kde-frameworks-devel, kde-buildsystem, michaelh, ngraham, bruns
D15566: Add QT_NO_NARROWING_CONVERSIONS_IN_CONNECT as default compile flags
mlaurent created this revision. Herald added projects: Frameworks, Build System. Herald added subscribers: kde-buildsystem, kde-frameworks-devel. mlaurent requested review of this revision. REVISION SUMMARY Use QT_NO_NARROWING_CONVERSIONS_IN_CONNECT as default flags REPOSITORY R240 Extra CMake Modules BRANCH add_QT_NO_NARROWING_CONVERSIONS_IN_CONNECT REVISION DETAIL https://phabricator.kde.org/D15566 AFFECTED FILES kde-modules/KDEFrameworkCompilerSettings.cmake To: mlaurent Cc: kde-frameworks-devel, kde-buildsystem, michaelh, ngraham, bruns
D15566: Add QT_NO_NARROWING_CONVERSIONS_IN_CONNECT as default compile flags
mlaurent added a reviewer: dfaure. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D15566 To: mlaurent, dfaure Cc: kde-frameworks-devel, kde-buildsystem, michaelh, ngraham, bruns
D6513: Add support for Attica tags support
mlaurent accepted this revision. REPOSITORY R304 KNewStuff REVISION DETAIL https://phabricator.kde.org/D6513 To: leinir, #knewstuff, apol, #kde_store, whiting, ahiemstra, mlaurent, dfaure, cfeck Cc: dfaure, cfeck, mlaurent, ngraham, ahiemstra, kde-frameworks-devel, #knewstuff, michaelh, ZrenBot, bruns
D15136: Fixed a typeo
mlaurent added a comment. done. REPOSITORY R293 Baloo BRANCH bug397843 (branched from master) REVISION DETAIL https://phabricator.kde.org/D15136 To: ssloan, mlaurent Cc: mlaurent, kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams
D15136: Fixed a typeo
mlaurent closed this revision. REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D15136 To: ssloan, mlaurent Cc: mlaurent, kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams
D15136: Fixed a typeo
mlaurent added a comment. I will commit for you. what is your email address ? REPOSITORY R293 Baloo BRANCH bug397843 (branched from master) REVISION DETAIL https://phabricator.kde.org/D15136 To: ssloan, mlaurent Cc: mlaurent, kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams
D15136: Fixed a typeo
mlaurent accepted this revision. mlaurent added a comment. This revision is now accepted and ready to land. Thanks can you commit it ? Do you have commit access ? REPOSITORY R293 Baloo BRANCH bug397843 (branched from master) REVISION DETAIL https://phabricator.kde.org/D15136 To: ssloan, mlaurent Cc: mlaurent, kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich, spoorun, ngraham, bruns, abrahams
D14435: Fix KTimeComboBox input mask for AM/PM times
mlaurent accepted this revision. This revision is now accepted and ready to land. REPOSITORY R236 KWidgetsAddons REVISION DETAIL https://phabricator.kde.org/D14435 To: glennw, cfeck, mlaurent Cc: ngraham, kde-frameworks-devel, michaelh, bruns
D14435: Fix KTimeComboBox input mask for AM/PM times
mlaurent requested changes to this revision.
mlaurent added a comment.
This revision now requires changes to proceed.
For me it's ok after using QVERIFY...
INLINE COMMENTS
> ktimecomboboxtest.cpp:198
> +QString mask = m_combo->lineEdit()->inputMask();
> +QCOMPARE(mask.contains(QLatin1String("aa")), true);
> +delete m_combo;
QVERIFY(...)
> ktimecomboboxtest.cpp:205
> +mask = m_combo->lineEdit()->inputMask();
> +QCOMPARE(mask.contains(QLatin1String("aa")), false);
> +delete m_combo;
QVERIFY(! )
REPOSITORY
R236 KWidgetsAddons
REVISION DETAIL
https://phabricator.kde.org/D14435
To: glennw, cfeck, mlaurent
Cc: ngraham, kde-frameworks-devel, michaelh, bruns
D14435: Fix KTimeComboBox input mask for AM/PM times
mlaurent requested changes to this revision.
mlaurent added inline comments.
This revision now requires changes to proceed.
INLINE COMMENTS
> ktimecomboboxtest.cpp:198
> +QString mask = m_combo->lineEdit()->inputMask();
> +QCOMPARE(mask.contains(QLatin1String("aa")), true);
> +delete m_combo;
Could you provide another case where mask will not contains "aa" so we can be
sure that code works
Thanks.
REPOSITORY
R236 KWidgetsAddons
REVISION DETAIL
https://phabricator.kde.org/D14435
To: glennw, cfeck, mlaurent
Cc: ngraham, kde-frameworks-devel, michaelh, bruns
D14447: Sonnet: setLanguage should schedule a rehighlight if highlight is enabled
mlaurent accepted this revision. This revision is now accepted and ready to land. REPOSITORY R246 Sonnet BRANCH master REVISION DETAIL https://phabricator.kde.org/D14447 To: dfaure, sandsmark, mlaurent Cc: kde-frameworks-devel, #kde_pim, michaelh, ngraham, bruns
D14435: Fix KTimeComboBox input mask for AM/PM times
mlaurent requested changes to this revision. mlaurent added a comment. This revision now requires changes to proceed. could you provide an autotest for it please ? (see autotest/ktimecomboboxtest.cpp) Thanks REPOSITORY R236 KWidgetsAddons REVISION DETAIL https://phabricator.kde.org/D14435 To: glennw, cfeck, mlaurent Cc: kde-frameworks-devel, michaelh, ngraham, bruns
D6513: Add support for Attica tags support
mlaurent requested changes to this revision.
mlaurent added inline comments.
This revision now requires changes to proceed.
INLINE COMMENTS
> entryinternal.cpp:495
> if (reader.name() != QLatin1String("stuff")) {
> -qWarning() << "Parsing Entry from invalid XML";
> +qWarning() << "Parsing Entry from invalid XML. Reader tag name was
> expected to be \"stuff\", but was found as:" << reader.name();
> return false;
qCWarning(KNEWSTUFF_CORE) ?
> tagsfilterchecker.cpp:147
> +for(const QString : tags) {
> +if(tag.length() == 0) {
> +// This happens when you do a split on an empty string (not an
> empty list, a list with one empty element... because reasons).
isEmpty() ?
> tagsfilterchecker.cpp:152
> +}
> +QStringList current = tag.split(QStringLiteral("="));
> +if(current.length() > 2) {
use QLatin1Char('=')
REPOSITORY
R304 KNewStuff
REVISION DETAIL
https://phabricator.kde.org/D6513
To: leinir, #knewstuff, apol, #kde_store, whiting, ahiemstra, mlaurent
Cc: mlaurent, ngraham, ahiemstra, kde-frameworks-devel, #knewstuff, michaelh,
ZrenBot, bruns
D14154: Add
mlaurent requested changes to this revision. mlaurent added a comment. This revision now requires changes to proceed. Please change commit title "Add" by a commit title which explains what your commit will do. thanks REPOSITORY R175 PIM: KHolidays REVISION DETAIL https://phabricator.kde.org/D14154 To: phanect, winterz, mlaurent, #kde_pim, #frameworks Cc: kde-pim, dvasin, rodsevich, winterz, vkrause, mlaurent, knauss, dvratil
D13987: Honor BUILD_TESTING
mlaurent accepted this revision. This revision is now accepted and ready to land. REPOSITORY R252 Framework Integration REVISION DETAIL https://phabricator.kde.org/D13987 To: arojas, afiestas, dfaure, mlaurent Cc: kde-frameworks-devel, michaelh, ngraham, bruns
D13989: Honor BUILD_TESTING
mlaurent accepted this revision. This revision is now accepted and ready to land. REPOSITORY R307 KPeople REVISION DETAIL https://phabricator.kde.org/D13989 To: arojas, apol, mlaurent Cc: kde-frameworks-devel, michaelh, ngraham, bruns
D13986: Honor BUILD_TESTING
mlaurent accepted this revision. This revision is now accepted and ready to land. REPOSITORY R301 KEmoticons REVISION DETAIL https://phabricator.kde.org/D13986 To: arojas, dfaure, mlaurent Cc: kde-frameworks-devel, michaelh, ngraham, bruns
D13991: Honor BUILD_TESTING
mlaurent accepted this revision. This revision is now accepted and ready to land. REPOSITORY R312 KXmlRpcClient REVISION DETAIL https://phabricator.kde.org/D13991 To: arojas, dvratil, mlaurent Cc: kde-frameworks-devel, michaelh, ngraham, bruns
D13992: Honor BUILD_TESTING
mlaurent accepted this revision. This revision is now accepted and ready to land. REPOSITORY R495 Purpose Library REVISION DETAIL https://phabricator.kde.org/D13992 To: arojas, apol, mlaurent Cc: kde-frameworks-devel, michaelh, ngraham, bruns
D13972: Honor BUILD_TESTING
mlaurent accepted this revision. This revision is now accepted and ready to land. REPOSITORY R290 KPackage REVISION DETAIL https://phabricator.kde.org/D13972 To: arojas, mart, mlaurent Cc: kde-frameworks-devel, michaelh, ngraham, bruns
D13974: Honor BUILD_TESTING
mlaurent accepted this revision. This revision is now accepted and ready to land. REPOSITORY R277 KPlotting REVISION DETAIL https://phabricator.kde.org/D13974 To: arojas, cfeck, mlaurent Cc: kde-frameworks-devel, michaelh, ngraham, bruns
D13958: Honor BUILD_TESTING
mlaurent accepted this revision. This revision is now accepted and ready to land. REPOSITORY R310 KTextWidgets REVISION DETAIL https://phabricator.kde.org/D13958 To: arojas, dfaure, mlaurent Cc: kde-frameworks-devel, michaelh, ngraham, bruns
D12892: KConfigCompiler_Test: Update test_signal.h.ref to follow the generated file
mlaurent accepted this revision. This revision is now accepted and ready to land. REPOSITORY R237 KConfig BRANCH ref_upd (branched from master) REVISION DETAIL https://phabricator.kde.org/D12892 To: maximilianocuria, #frameworks, mlaurent Cc: kde-frameworks-devel, michaelh, ngraham, bruns
D12283: Allow to load dictionaries form a rcc
mlaurent added inline comments.
INLINE COMMENTS
> hunspelldict.cpp:104
> delete m_speller;
> +if (m_tempDir) {
> +delete m_tempDir;
not necessary to check pointer here.
REPOSITORY
R246 Sonnet
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D12283
To: vonreth, mlaurent
Cc: #frameworks, michaelh, bruns
D12283: Allow to load dictionaries form a rcc
mlaurent accepted this revision. mlaurent added a comment. This revision is now accepted and ready to land. Remove indent and commit it :) Thanks INLINE COMMENTS > hunspellclient.cpp:104 > +} > +return QString(); > +} fix indent REPOSITORY R246 Sonnet BRANCH master REVISION DETAIL https://phabricator.kde.org/D12283 To: vonreth, mlaurent Cc: #frameworks, michaelh, bruns
D12282: Look into subdirectories for dictionaries
mlaurent accepted this revision. mlaurent added a comment. This revision is now accepted and ready to land. Thanks :) REPOSITORY R246 Sonnet BRANCH master REVISION DETAIL https://phabricator.kde.org/D12282 To: vonreth, mlaurent Cc: #frameworks, michaelh, ngraham, bruns
D11287: Introduce baloodb CLI tool
mlaurent accepted this revision. This revision is now accepted and ready to land. REPOSITORY R293 Baloo BRANCH sanitize-cmd (branched from master) REVISION DETAIL https://phabricator.kde.org/D11287 To: michaelh, #baloo, #frameworks, mlaurent Cc: mlaurent, ngraham, ashaposhnikov, michaelh, astippich, spoorun, nicolasfella, alexeymin
D11287: Introduce baloodb CLI tool
mlaurent added inline comments. INLINE COMMENTS > michaelh wrote in CMakeLists.txt:16 > @mlaurent Is it worth the effort to change this for the other cli tools > accordingly? It's the default variable. But don't chnage it in this patch. Perhaps in the future as you are the baloo maintainer :) REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D11287 To: michaelh, #baloo, #frameworks, mlaurent Cc: mlaurent, ngraham, ashaposhnikov, michaelh, astippich, spoorun, nicolasfella, alexeymin
D11287: Introduce baloodb CLI tool
mlaurent requested changes to this revision.
mlaurent added inline comments.
This revision now requires changes to proceed.
INLINE COMMENTS
> CMakeLists.txt:16
> +
> +install(TARGETS baloodb DESTINATION ${BIN_INSTALL_DIR})
install(TARGETS baloodb ${KDE_INSTALL_TARGETS_DEFAULT_ARGS})
> main.cpp:151
> +}
> +QString allCommandsStr = allowedcommands.join(QStringLiteral("\n"));
> +return i18n("\n\nCommands:\n%1", allCommandsStr);
const QString allCommandStr
REPOSITORY
R293 Baloo
REVISION DETAIL
https://phabricator.kde.org/D11287
To: michaelh, #baloo, #frameworks, mlaurent
Cc: mlaurent, ngraham, ashaposhnikov, michaelh, astippich, spoorun,
nicolasfella, alexeymin
D11287: Introduce baloodb CLI tool
mlaurent requested changes to this revision.
mlaurent added inline comments.
This revision now requires changes to proceed.
INLINE COMMENTS
> main.cpp:103
> +QStringLiteral("devices"),
> +i18n("List devices "),
> +QStringList{},
extra space at the end of i18n
> main.cpp:112
> +QStringList names;
> +for (const auto c : commands) {
> +names.append(c.name);
const auto ?
> main.cpp:124
> +}
> +return QStringList() ;
> +}
coding style: remove space after()
> main.cpp:131
> +auto options = getOptions(c.name);
> +QString optionStr = options.count() == 0
> +? QString()
options.count() == 0 => isEmpty()
> main.cpp:135
> +
> +auto str = QStringLiteral("%1 %2")
> +.arg(QStringLiteral("%1%2%3")
very hard to read it.
Could you split in several QString so it will more easy to check it's if ok :)
> main.cpp:203
> +const bool missingOnly = parser.isSet(QStringLiteral("missing-only"));
> +const QString pattern = args.size() > 0
> +? args.at(0)
!isEmpty()
REPOSITORY
R293 Baloo
REVISION DETAIL
https://phabricator.kde.org/D11287
To: michaelh, #baloo, #frameworks, mlaurent
Cc: mlaurent, ngraham, ashaposhnikov, michaelh, astippich, spoorun,
nicolasfella, alexeymin
D11285: Introduce sanitizer class
mlaurent accepted this revision. mlaurent added a comment. This revision is now accepted and ready to land. +2 for me but I don't know baloo code :) REPOSITORY R293 Baloo BRANCH sanitize-class (branched from master) REVISION DETAIL https://phabricator.kde.org/D11285 To: michaelh, #baloo, #frameworks, ngraham, mlaurent Cc: mlaurent, ngraham, smithjd, ashaposhnikov, michaelh, astippich, spoorun, nicolasfella, alexeymin
D11285: Introduce sanitizer class
mlaurent requested changes to this revision.
mlaurent added inline comments.
This revision now requires changes to proceed.
INLINE COMMENTS
> databasesanitizer.cpp:46
> +public:
> +FileInfo(const quint32 d = 0, const quint32 i = 0,
> +const QString& u = QString(), const bool a = true)
you can replace this constructor by initialize directly variable
> bool accessible = true;
=
etc.
> it avoids to create this constructor
==
> databasesanitizer.cpp:99
> +QVector excludeIds;
> +for (const auto& deviceId : deviceIds) {
> +if (deviceId > 0) {
const auto & for a quint32
it's better to use directly quint32 without const'ref
REPOSITORY
R293 Baloo
REVISION DETAIL
https://phabricator.kde.org/D11285
To: michaelh, #baloo, #frameworks, ngraham, mlaurent
Cc: mlaurent, ngraham, smithjd, ashaposhnikov, michaelh, astippich, spoorun,
nicolasfella, alexeymin
D11285: Introduce sanitizer class
mlaurent requested changes to this revision.
mlaurent added inline comments.
This revision now requires changes to proceed.
INLINE COMMENTS
> databasesanitizer.cpp:44
> +struct FileInfo {
> +quint32 deviceId;
> +quint32 inode;
initialize value by default please
> databasesanitizer.cpp:107
> +};
> +if ((includeIds.count() > 0 &&
> !includeIds.contains(info.deviceId))
> +|| (excludeIds.count() > 0 &&
> excludeIds.contains(info.deviceId))
includeIds.count() > 0 => use !isEmpty
> databasesanitizer.cpp:153
> +const bool missingOnly,
> +const QSharedPointer urlFilter)
> +{
const QSharedPointer &
--^
> databasesanitizer.cpp:165
> +} else {
> +qDebug() << "Skipping" << info.url;
> +Q_ASSERT(false);
use qCDebug(BALOO)
> databasesanitizer.cpp:174
> +}
> +err << i18n("Found %1 matching items", infos.count()) << endl;
> +
as you add a i18n in engine directory you need to extract them.
you missed to add a Message.sh in this subdirectory and loading message file.
REPOSITORY
R293 Baloo
REVISION DETAIL
https://phabricator.kde.org/D11285
To: michaelh, #baloo, #frameworks, ngraham, mlaurent
Cc: mlaurent, ngraham, smithjd, ashaposhnikov, michaelh, spoorun, nicolasfella,
alexeymin
D11285: Introduce sanitizer class
mlaurent added a comment. Is it possible to create an autotest for this class ? REPOSITORY R293 Baloo REVISION DETAIL https://phabricator.kde.org/D11285 To: michaelh, #baloo, #frameworks, ngraham, mlaurent Cc: mlaurent, ngraham, smithjd, ashaposhnikov, michaelh, spoorun, nicolasfella, alexeymin
D10744: Use correct directory to lookup trigrams in windows build dir
mlaurent accepted this revision. mlaurent added a comment. This revision is now accepted and ready to land. Seems good for me REPOSITORY R246 Sonnet BRANCH master REVISION DETAIL https://phabricator.kde.org/D10744 To: vonreth, mlaurent, dfaure, leinir Cc: #frameworks, michaelh
D9446: WIP: Allow to autogenerate and install categories file
mlaurent abandoned this revision. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D9446 To: mlaurent, kfunk, lbeltrame, cgiboudeaux, dfaure, fvogt Cc: #frameworks, #build_system, michaelh, ngraham
D10333: Introduce K_PLUGIN_CLASS_WITH_JSON
mlaurent requested changes to this revision. mlaurent added inline comments. This revision now requires changes to proceed. INLINE COMMENTS > kpluginfactory.h:211 > + */ > +#define K_PLUGIN_CLASS_WITH_JSON(classname, jsonFile) > K_PLUGIN_FACTORY_WITH_JSON(classname ## Factory, json, > registerPlugin();) > + it's doesn't work. jsonFile in all macro or json only otherwise it's not defined. REPOSITORY R244 KCoreAddons REVISION DETAIL https://phabricator.kde.org/D10333 To: aacid, dfaure, mlaurent Cc: mlaurent, kossebau, apol, #frameworks, michaelh, ngraham
D10135: Put built-in holiday definitions into qrc
mlaurent accepted this revision.
mlaurent added inline comments.
This revision is now accepted and ready to land.
INLINE COMMENTS
> CMakeLists.txt:8
> set(CMAKE_MODULE_PATH ${ECM_MODULE_PATH})
> +set(CMAKE_AUTORCC ON)
>
Just curious it's not default in ECM ? I never used it.
REPOSITORY
R175 PIM: KHolidays
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D10135
To: vkrause, #frameworks, #kde_pim, mlaurent
Cc: mlaurent, dvasin, winterz, vkrause, knauss, dvratil
D9420: Compile commenting remove_defintion(QT_NO_CAST_FROM_ASCII )
mlaurent added a comment. I made a fix. I wait a rebuild on windows to see if it's ok REPOSITORY R244 KCoreAddons REVISION DETAIL https://phabricator.kde.org/D9420 To: velurimithun, mlaurent Cc: bcooksley, dfaure, #frameworks
D9420: Compile commenting remove_defintion(QT_NO_CAST_FROM_ASCII )
mlaurent accepted this revision. mlaurent added a comment. This revision is now accepted and ready to land. Thanks REPOSITORY R244 KCoreAddons BRANCH complieWithoutRemoveDef REVISION DETAIL https://phabricator.kde.org/D9420 To: velurimithun, mlaurent Cc: dfaure, #frameworks
D9420: Compile commenting remove_defintion(QT_NO_CAST_FROM_ASCII )
mlaurent requested changes to this revision. mlaurent added a comment. This revision now requires changes to proceed. You still forgot to launch autotest... see: "laurent@linux-5nvn:/compile/kde5/framework/frameworks/kcoreaddons/build> ./bin/kaboutdatatest - Start testing of KAboutDataTest * Config: Using QtTest library 5.10.1, Qt 5.10.1 (x86_64-little_endian-lp64 shared (dynamic) release build; by GCC 7.2.1 20171020 [gcc-7-branch revision 253932]) PASS : KAboutDataTest::initTestCase() PASS : KAboutDataTest::testLongFormConstructorWithDefaults() PASS : KAboutDataTest::testLongFormConstructor() PASS : KAboutDataTest::testShortFormConstructor() FAIL! : KAboutDataTest::testSetAddLicense() Compared values are not the same Actual (aboutData.licenses().at(2).text()): "free to write, reading forbidden" Expected (QLatin1String(LicenseFileText)) : "free to write, reading forbidden, in the file" Loc: [/compile/kde5/framework/frameworks/kcoreaddons/autotests/kaboutdatatest.cpp(260)] PASS : KAboutDataTest::testSetProgramIconName() PASS : KAboutDataTest::testSetDesktopFileName() PASS : KAboutDataTest::testCopying() PASS : KAboutDataTest::testKAboutDataOrganizationDomain() PASS : KAboutDataTest::testLicenseSPDXID() PASS : KAboutDataTest::testLicenseOrLater() PASS : KAboutDataTest::cleanupTestCase() Totals: 11 passed, 1 failed, 0 skipped, 0 blacklisted, 3ms " > I found the porting error in line 260. Please compare you change in 260. == You must launch autotest to see if you created a bug or not. You need to compare before and after your patch and see if you have some failed. REPOSITORY R244 KCoreAddons REVISION DETAIL https://phabricator.kde.org/D9420 To: velurimithun, mlaurent Cc: dfaure, #frameworks
D9420: Compile commenting remove_defintion(QT_NO_CAST_FROM_ASCII )
mlaurent added a comment. Ping bis ?:) REPOSITORY R244 KCoreAddons REVISION DETAIL https://phabricator.kde.org/D9420 To: velurimithun, mlaurent Cc: dfaure, #frameworks
D8908: KDateComboBox: fix dateChanged() not emitted after typing a date
mlaurent accepted this revision. REPOSITORY R236 KWidgetsAddons BRANCH master REVISION DETAIL https://phabricator.kde.org/D8908 To: dfaure, cfeck, dvratil, mlaurent Cc: mlaurent, anthonyfieroni, #frameworks, #kde_pim
D9420: Compile commenting remove_defintion(QT_NO_CAST_FROM_ASCII )
mlaurent added a comment. Ping ? REPOSITORY R244 KCoreAddons REVISION DETAIL https://phabricator.kde.org/D9420 To: velurimithun, mlaurent Cc: dfaure, #frameworks
D8908: KDateComboBox: fix dateChanged() not emitted after typing a date
mlaurent accepted this revision. mlaurent added a comment. This revision is now accepted and ready to land. Otherwise all is good. +2 with the QVERIFY(...) INLINE COMMENTS > kdatecomboboxtest.cpp:182 > +combo->activateWindow(); > +QTest::qWaitForWindowActive(combo.data()); > + QVERIFY(QTest::qWa...) REPOSITORY R236 KWidgetsAddons BRANCH master REVISION DETAIL https://phabricator.kde.org/D8908 To: dfaure, cfeck, dvratil, mlaurent Cc: mlaurent, anthonyfieroni, #frameworks, #kde_pim
D9884: KMultiTabBar: Fix regression in conversion to new style connect()
mlaurent accepted this revision. mlaurent added a comment. This revision is now accepted and ready to land. indeed good catch REPOSITORY R236 KWidgetsAddons REVISION DETAIL https://phabricator.kde.org/D9884 To: sars, #frameworks, mlaurent
D9420: Compile commenting remove_defintion(QT_NO_CAST_FROM_ASCII )
mlaurent added a comment. Ok I understand why you don't have this problem you need to rebase patch with last kcoreaddons version. So code was added. Please rebase, make sure that it builds and upload patch. Regards. REPOSITORY R244 KCoreAddons REVISION DETAIL https://phabricator.kde.org/D9420 To: velurimithun, mlaurent Cc: dfaure, #frameworks
D9420: Compile commenting remove_defintion(QT_NO_CAST_FROM_ASCII )
mlaurent requested changes to this revision. mlaurent added a comment. This revision now requires changes to proceed. When I try to compile your patch I have this compile error: Do you are sure that you rebuild all ? /compile/kde5/framework/frameworks/kcoreaddons/autotests/kaboutdatatest.cpp: In member function ‘void KAboutDataTest::testLicenseSPDXID()’: /compile/kde5/framework/frameworks/kcoreaddons/autotests/kaboutdatatest.cpp:330:91: error: ‘QString::QString(const char*)’ is private within this context QLatin1String(ShortDescription), KAboutLicense::GPL_V2); ^ In file included from /opt/qt5.10/include/QtCore/QString:1:0, from /compile/kde5/framework/frameworks/kcoreaddons/src/lib/kaboutdata.h:30, from /compile/kde5/framework/frameworks/kcoreaddons/autotests/kaboutdatatest.cpp:21: /opt/qt5.10/include/QtCore/qstring.h:818:5: note: declared private here QString(const char *ch); ^~~ /compile/kde5/framework/frameworks/kcoreaddons/autotests/kaboutdatatest.cpp:330:91: error: ‘QString::QString(const char*)’ is private within this context QLatin1String(ShortDescription), KAboutLicense::GPL_V2); ^ In file included from /opt/qt5.10/include/QtCore/QString:1:0, from /compile/kde5/framework/frameworks/kcoreaddons/src/lib/kaboutdata.h:30, from /compile/kde5/framework/frameworks/kcoreaddons/autotests/kaboutdatatest.cpp:21: /opt/qt5.10/include/QtCore/qstring.h:818:5: note: declared private here REPOSITORY R244 KCoreAddons REVISION DETAIL https://phabricator.kde.org/D9420 To: velurimithun, mlaurent Cc: dfaure, #frameworks
D9420: Compile commenting remove_defintion(QT_NO_CAST_FROM_ASCII )
mlaurent added a comment. indeed code will be broken if we don't use QString::fromUtf8. Could you fix it please ? REPOSITORY R244 KCoreAddons REVISION DETAIL https://phabricator.kde.org/D9420 To: velurimithun, mlaurent Cc: dfaure, #frameworks
D9571: clang-tidy modernize-use-override
mlaurent accepted this revision. This revision is now accepted and ready to land. REPOSITORY R39 KTextEditor BRANCH UseOverride (branched from master) REVISION DETAIL https://phabricator.kde.org/D9571 To: dhaumann, kfunk, mlaurent Cc: #frameworks, kevinapavew, ngraham, demsking, cullmann, sars, dhaumann
D9420: Compile commenting remove_defintion(QT_NO_CAST_FROM_ASCII )
mlaurent added inline comments.
INLINE COMMENTS
> kprocesstest.cpp:47
> p.setProcessChannelMode(QProcess::MergedChannels);
> -p.start(gargv[0], QStringList() << QString::number(how) <<
> QStringLiteral("--nocrashhandler"));
> +p.start(QString::fromLatin1(gargv[0]), QStringList() <<
> QString::number(how) << QString::fromLatin1("--nocrashhandler"));
> p.waitForFinished();
nocrashhandler why do you changed as QString::fromLatin1 ? it's QStringList()
so it can work no ?
> kshelltest.cpp:167
>
> -const QString unicodeSpaceFileName = "test テスト.txt"; // #345140
> +const QString unicodeSpaceFileName = QLatin1String("test テスト.txt"); //
> #345140
> QCOMPARE(sj(unicodeSpaceFileName, KShell::AbortOnMeta |
> KShell::TildeExpand, ),
QLAtin1String for japan char ?
> velurimithun wrote in kstringhandlertest.cpp:45
> Here char i. e., (' ') is converted into string i.e., (" ") and then
> QLatin1String is applied.
>
> Since, we can't convert char into QLatin1String
QLatin1Char(' ') ?
> kstringhandlertest.cpp:49
> expected.clear();
> -expected << "Split" << "me" << "up ! I'm bored ! OK ?";
> -QCOMPARE(KStringHandler::perlSplit(QRegExp("[! ]"), "Split me up ! I'm
> bored ! OK ?", 3), expected);
> +expected << QLatin1String("Split") << QLatin1String("me") <<
> QLatin1String("up ! I'm bored ! OK ?");
> +QCOMPARE(KStringHandler::perlSplit(QRegExp(QLatin1String("[! ]")),
QStringLiteral no ?
REPOSITORY
R244 KCoreAddons
REVISION DETAIL
https://phabricator.kde.org/D9420
To: velurimithun, mlaurent
Cc: #frameworks
D9420: Compile commenting remove_defintion(QT_NO_CAST_FROM_ASCII )
mlaurent added a comment. no news ? REPOSITORY R244 KCoreAddons REVISION DETAIL https://phabricator.kde.org/D9420 To: velurimithun, mlaurent Cc: #frameworks
D9420: Compile commenting remove_defintion(QT_NO_CAST_FROM_ASCII )
mlaurent added a comment. You still missing all patch... Please use arc diff so we are sure that all patch is updated. REPOSITORY R244 KCoreAddons REVISION DETAIL https://phabricator.kde.org/D9420 To: velurimithun, mlaurent Cc: #frameworks
D9446: WIP: Allow to autogenerate and install categories file
mlaurent added reviewers: kfunk, lbeltrame, cgiboudeaux, dfaure. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D9446 To: mlaurent, kfunk, lbeltrame, cgiboudeaux, dfaure Cc: #frameworks, #build_system
D9446: WIP: Allow to autogenerate and install categories file
mlaurent added a comment. IT's a WIP as I use file(APPEND...) because I want to generate several categories in one file. But it doesn't work as I don't have idea how to reset file when cmake is started... Do you have an idea ? I will implement autotest and co if we have a solution for it. REPOSITORY R240 Extra CMake Modules REVISION DETAIL https://phabricator.kde.org/D9446 To: mlaurent Cc: #frameworks, #build_system
D9446: WIP: Allow to autogenerate and install categories file
mlaurent created this revision. Restricted Application added projects: Frameworks, Build System. Restricted Application added subscribers: Build System, Frameworks. TEST PLAN Generate kmail categories file REPOSITORY R240 Extra CMake Modules BRANCH autogenerate_categories_file REVISION DETAIL https://phabricator.kde.org/D9446 AFFECTED FILES modules/ECMQtDeclareLoggingCategory.cmake To: mlaurent Cc: #frameworks, #build_system
D9420: Compile commenting remove_defintion(QT_NO_CAST_FROM_ASCII )
mlaurent added inline comments. INLINE COMMENTS > velurimithun wrote in kprocesstest.cpp:93 > These strings are going as arguments for QStringList() method that why I used > QString::FromLatin1() ? QStringLiteral works fine with QStringList REPOSITORY R244 KCoreAddons REVISION DETAIL https://phabricator.kde.org/D9420 To: velurimithun, mlaurent Cc: #frameworks
D9420: Compile commenting remove_defintion(QT_NO_CAST_FROM_ASCII )
mlaurent added inline comments.
INLINE COMMENTS
> desktoptojsontest.cpp:84
> QByteArray input =
> -// include an insignificant group
> -"[Some Group]\n"
> -"Foo=Bar\n"
> -"\n"
> -"[Desktop Entry]\n"
> -// only data inside [Desktop Entry] should be included
> -"Name=Example\n"
> -//empty lines
> -"\n"
> -" \n"
> -// make sure translations are included:
> -"Name[de_DE]=Beispiel\n"
> -// ignore comments:
> -"#Comment=Comment\n"
> -" #Comment=Comment\n"
> -"Categories=foo;bar;a\\;b\n"
> -// As the case is significant, the keys Name and NAME are not
> equivalent:
> -"CaseSensitive=ABC\n"
> -"CASESENSITIVE=abc\n"
> -// Space before and after the equals sign should be ignored:
> -"SpacesBeforeEq =foo\n"
> -"SpacesAfterEq= foo\n"
> -// Space before and after the equals sign should be ignored; the =
> sign is the actual delimiter.
> -// TODO: error in spec (spaces before and after the key??)
> -" SpacesBeforeKey=foo\n"
> -"SpacesAfterKey =foo\n"
> -// ignore trailing spaces
> -"TrailingSpaces=foo \n"
> -// However spaces in the value are significant:
> -"SpacesInValue=Hello, World!\n"
> -// The escape sequences \s, \n, \t, \r, and \\ are supported for
> values of
> -// type string and localestring, meaning ASCII space, newline, tab,
> -// carriage return, and backslash, respectively:
> -"EscapeSequences=So\\sme esc\\nap\\te sequ\\rences\n" //
> make sure that the last n is a literal n not a newline!
> -// the standard keys that are used by plugins, make sure correct
> types are used:
> -"X-KDE-PluginInfo-Category=Examples\n" // string key
> -"X-KDE-PluginInfo-Version=1.0\n"
> -// The multiple values should be separated by a semicolon and the
> value of the key
> -// may be optionally terminated by a semicolon. Trailing empty
> strings must always
> -// be terminated with a semicolon. Semicolons in these values need
> to be escaped using \;.
> -"X-KDE-PluginInfo-Depends=foo,bar,esc\\,aped\n" // string list
> key
> -"X-KDE-ServiceTypes=\n" // empty string list
> -"X-KDE-PluginInfo-EnabledByDefault=true\n" // bool key
> -// now start a new group
> -"[New Group]\n"
> -"InWrongGroup=true\n";
> +// include an insignificant group
> +"[Some Group]\n"
not necessary to change indentation in this patch.
> desktoptojsontest.cpp:167
> QByteArray kdevInput =
> -"[Desktop Entry]\n"
> -"Type = Service\n"
> -"Icon=text-x-c++src\n"
> -"Exec=blubb\n"
> -"Comment=C/C++ Language Support\n"
> -"Comment[fr]=Prise en charge du langage C/C++\n"
> -"Comment[it]=Supporto al linguaggio C/C++\n"
> -"Name=C++ Support\n"
> -"Name[fi]=C++-tuki\n"
> -"Name[fr]=Prise en charge du C++\n"
> -"GenericName=Language Support\n"
> -"GenericName[sl]=Podpora jeziku\n"
> -"ServiceTypes=KDevelop/NonExistentPlugin\n"
> -"X-KDE-Library=kdevcpplanguagesupport\n"
> -"X-KDE-PluginInfo-Name=kdevcppsupport\n"
> -"X-KDE-PluginInfo-Category=Language Support\n"
> -"X-KDevelop-Version=1\n"
> -"X-KDevelop-Language=C++\n"
> -"X-KDevelop-Args=CPP\n"
> -"X-KDevelop-Interfaces=ILanguageSupport\n"
> -
> "X-KDevelop-SupportedMimeTypes=text/x-chdr,text/x-c++hdr,text/x-csrc,text/x-c++src\n"
> -"X-KDevelop-Mode=NoGUI\n"
> -"X-KDevelop-LoadMode=AlwaysOn";
> +"[Desktop Entry]\n"
> +"Type = Service\n"
don't change indent please
> kaboutdatatest.cpp:184
> QLatin1String("copyright"), QLatin1String("hello world"),
> -"http://www.koffice.org;);
> +QString::fromLatin1("http://www.koffice.org;));
> QCOMPARE(data.organizationDomain(), QString::fromLatin1("koffice.org"));
QStringLiteral doen't work here ?
> kprocesstest.cpp:93
> +p.setShellCommand(QStringLiteral("true || false"));
> +QCOMPARE(p.program(), QStringList() << QString::fromLatin1("/bin/sh") <<
> QString::fromLatin1("-c")
> + << QString::fromLatin1("true || false"));
QStringLiteral
REPOSITORY
R244 KCoreAddons
REVISION DETAIL
https://phabricator.kde.org/D9420
To: velurimithun, mlaurent
Cc: #frameworks
D9420: Compile commenting remove_defintion(QT_NO_CAST_FROM_ASCII )
mlaurent added a comment. Missing all patch... please see "https://community.kde.org/Infrastructure/Phabricator; "Step 2: Updating your diff. After you upload the code the reviewer will take a look and give you some comments. If you get a thumbs up, you can skip this step. But often you will get a review like "looks good, we can take it if you fix problems x, y, z." After you make your changes, you can add an extra commit to the git branch. $ git add -u $ git commit $ arc diff " REPOSITORY R244 KCoreAddons REVISION DETAIL https://phabricator.kde.org/D9420 To: velurimithun, mlaurent Cc: #frameworks
D9420: Compile commenting remove_defintion(QT_NO_CAST_FROM_ASCII )
mlaurent requested changes to this revision.
mlaurent added inline comments.
This revision now requires changes to proceed.
INLINE COMMENTS
> kaboutdatatest.cpp:48
>
> -static const char AppName[] ="app";
> -static const char ProgramName[] ="ProgramName";
> -static const char ProgramIconName[] ="program-icon";
> -static const char Version[] ="Version";
> -static const char ShortDescription[] = "ShortDescription";
> -static const char CopyrightStatement[] = "CopyrightStatement";
> -static const char Text[] = "Text";
> -static const char HomePageAddress[] ="http://test.no.where/;;
> -static const char HomePageSecure[] = "https://test.no.where/;;
> -static const char OrganizationDomain[] = "no.where";
> -static const char BugsEmailAddress[] = "b...@no.else";
> -static const char LicenseText[] ="free to write, reading forbidden";
> -static const char LicenseFileName[] ="testlicensefile";
> -static const char LicenseFileText[] ="free to write, reading forbidden,
> in the file";
> +static const QString AppName =QString::fromLatin1("app");
> +static const QString ProgramName =QString::fromLatin1("ProgramName");
no we need to keep const char ...[] and use QString::fromLatin1(...) in method
as it's already done previously
> kautosavefiletest.cpp:83
> {
> -QUrl normalFile =
> QUrl::fromLocalFile(QDir::temp().absoluteFilePath("test directory/tîst
> me.txt"));
> +QUrl normalFile =
> QUrl::fromLocalFile(QDir::temp().absoluteFilePath(QLatin1String("test
> directory/tîst me.txt")));
>
QStringLiteral(...)
> kformattest.cpp:36
>
> -QCOMPARE(format.formatByteSize(0), QString("0 B"));
> -QCOMPARE(format.formatByteSize(50), QString("50 B"));
> -QCOMPARE(format.formatByteSize(500), QString("500 B"));
> -QCOMPARE(format.formatByteSize(5000), QString("4.9 KiB"));
> -QCOMPARE(format.formatByteSize(5), QString("48.8 KiB"));
> -QCOMPARE(format.formatByteSize(50), QString("488.3 KiB"));
> -QCOMPARE(format.formatByteSize(500), QString("4.8 MiB"));
> -QCOMPARE(format.formatByteSize(5000), QString("47.7 MiB"));
> -QCOMPARE(format.formatByteSize(5), QString("476.8 MiB"));
> +QCOMPARE(format.formatByteSize(0), QLatin1String("0 B"));
> +QCOMPARE(format.formatByteSize(50), QLatin1String("50 B"));
QStringLiteral here and others.
> kformattest.cpp:308
> testDate = QDate::currentDate().addDays(-7);
> QCOMPARE(format.formatRelativeDate(testDate, QLocale::LongFormat),
> + QString::fromLatin1("Last
> %1").arg(QLocale::c().dayName(testDate.dayOfWeek(), QLocale::LongFormat)));
QStringLiteral here too
> kpluginfactorytest.cpp:34
> {
> -KPluginLoader multiplugin("multiplugin");
> +KPluginLoader multiplugin(QLatin1String("multiplugin"));
> KPluginFactory *factory = multiplugin.factory();
QStringLiteral(...)
> kpluginmetadatatest.cpp:49
> {
> -QString location = KPluginLoader::findPlugin("jsonplugin");
> +QString location =
> KPluginLoader::findPlugin(QLatin1String("jsonplugin"));
> QVERIFY2(!location.isEmpty(),"Could not find jsonplugin");
Same
> kpluginmetadatatest.cpp:207
> QTest::ignoreMessage(QtWarningMsg, "Expected JSON property
> \"String\" to be a string list. Treating it as a list with a single entry:
> \"foo\" ");
> -QCOMPARE(KPluginMetaData::readStringList(jo, "String"),
> QStringList("foo"));
> -QCOMPARE(KPluginMetaData::readStringList(jo, "OneArrayEntry"),
> QStringList("foo"));
> +QCOMPARE(KPluginMetaData::readStringList(jo,
> QLatin1String("String")), QStringList(QLatin1String("foo")));
> +QCOMPARE(KPluginMetaData::readStringList(jo,
> QLatin1String("OneArrayEntry")), QStringList(QLatin1String("foo")));
Same
> kshelltest.cpp:58
> QString me(KUser().loginName());
> -QCOMPARE(KShell::tildeExpand("~"), QDir::homePath());
> -QCOMPARE(KShell::tildeExpand("~/dir"), QString(QDir::homePath() +
> "/dir"));
> -QCOMPARE(KShell::tildeExpand('~' + me), myHomePath());
> -QCOMPARE(KShell::tildeExpand('~' + me + "/dir"), QString(myHomePath() +
> "/dir"));
> +QCOMPARE(KShell::tildeExpand(QString::fromLatin1("~")),
> QDir::homePath());
> +QCOMPARE(KShell::tildeExpand(QString::fromLatin1("~/dir")),
> QString(QDir::homePath() + QString::fromLatin1("/dir")));
QStringLiteral...
> kshelltest.cpp:84
> #else
> -QCOMPARE(KShell::quoteArg("a space"), QString("'a space'"));
> +QCOMPARE(KShell::quoteArg(QString::fromLatin1("a space")),
> QString::fromLatin1("'a space'"));
> #endif
you can change QString::fromLatin1(...) by QStringLiteral in all code that you
modified
REPOSITORY
R244 KCoreAddons
REVISION DETAIL
https://phabricator.kde.org/D9420
To: velurimithun, mlaurent
Cc: #frameworks
D9420: Compile commenting remove_defintion(QT_NO_CAST_FROM_ASCII defination)
mlaurent added a comment. Arguiment from method use QString and not QLatin1String() QString::fromLatin1 returns a QString REPOSITORY R244 KCoreAddons REVISION DETAIL https://phabricator.kde.org/D9420 To: velurimithun, mlaurent Cc: #frameworks
D9420: Compile commenting remove_defintion(QT_NO_CAST_FROM_ASCII defination)
mlaurent added a comment. KAboutData aboutData2(QString::fromLatin1(AppName2), QString::fromLatin1(ProgramName2), QString::fromLatin1(Version2)); use QString::fromLatin1 is will work REPOSITORY R244 KCoreAddons REVISION DETAIL https://phabricator.kde.org/D9420 To: velurimithun, mlaurent Cc: #frameworks
D9420: Compile commenting remove_defintion(QT_NO_CAST_FROM_ASCII defination)
mlaurent requested changes to this revision. This revision now requires changes to proceed. REPOSITORY R244 KCoreAddons REVISION DETAIL https://phabricator.kde.org/D9420 To: velurimithun, mlaurent Cc: #frameworks
D9420: Compile commenting remove_defintion(QT_NO_CAST_FROM_ASCII defination)
mlaurent added a comment. Could you paste you compile error here please. INLINE COMMENTS > CMakeLists.txt:1 > -remove_definitions(-DQT_NO_CAST_FROM_ASCII) > +#remove_definitions(-DQT_NO_CAST_FROM_ASCII) > Better to remove it. REPOSITORY R244 KCoreAddons REVISION DETAIL https://phabricator.kde.org/D9420 To: velurimithun, mlaurent Cc: #frameworks
D9332: Allow filter places based on alternative application name
mlaurent added a comment. Not commited ? REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D9332 To: renatoo, mwolff, mlaurent Cc: mlaurent, aacid, ngraham, #frameworks
Re: KHTML Commit 77c21d19c314d79da1b60e319aa40eff57fef375
Le vendredi 15 décembre 2017, 18:47:40 CET Ben Cooksley a écrit : > On Fri, Dec 15, 2017 at 7:41 PM, laurent Montel <mon...@kde.org> wrote: > > Le vendredi 15 décembre 2017, 03:38:32 CET Ben Cooksley a écrit : > >> Hi Laurent, all, > > > > Hi, > > Indeed fixed now. > > Thanks, I can confirm the Dependency Builds are now compiling again. ok cool. > I've initiated rebuilds of the normal builds which were affected by this. > > While I have you here, it looks like messagelib is making use of a > header which isn't in Qt 5.9. no it was just a missing lib in test apps. Fixed now. Regards. > > > Sorry for the problem. > > Regards > > Cheers, > Ben > > >> Recently a series of Dependency Build jobs on the CI system have begun > >> failing with errors pointing to missing headers inside KHTML. In > >> particular it seems a header called "khtml_debug.h" can no longer be > >> found. > >> > >> Looking more closely into the issue it seems that this header, and the > >> dependency on it from various installed headers, was introduced in > >> commit 77c21d19c314d79da1b60e319aa40eff57fef375 > >> > >> Can someone please fix this? > >> > >> At the moment it's breaking the build of various components which > >> depend on KHTML and as a consequence has left the CI system in an > >> inconsistent state. At this time both Applications and Plasma have > >> been negatively impacted by this. > >> > >> Cheers, > >> Ben > > > > -- > > Laurent Montel | laurent.mon...@kdab.com | KDE/Qt Senior Software Engineer > > KDAB (France) S.A.S., a KDAB Group company Tel. France +33 (0)4 90 84 08 > > 53,> > > www.kdab.fr KDAB - The Qt, C++ and OpenGL Experts - Platform-independent > > > > software solutions -- Laurent Montel | laurent.mon...@kdab.com | KDE/Qt Senior Software Engineer KDAB (France) S.A.S., a KDAB Group company Tel. France +33 (0)4 90 84 08 53, www.kdab.fr KDAB - The Qt, C++ and OpenGL Experts - Platform-independent software solutions
D9332: Allow filter places based on alternative application name
mlaurent accepted this revision. This revision is now accepted and ready to land. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D9332 To: renatoo, mwolff, mlaurent Cc: mlaurent, aacid, ngraham, #frameworks
Re: KHTML Commit 77c21d19c314d79da1b60e319aa40eff57fef375
Le vendredi 15 décembre 2017, 03:38:32 CET Ben Cooksley a écrit : > Hi Laurent, all, Hi, Indeed fixed now. Sorry for the problem. Regards > > Recently a series of Dependency Build jobs on the CI system have begun > failing with errors pointing to missing headers inside KHTML. In > particular it seems a header called "khtml_debug.h" can no longer be > found. > > Looking more closely into the issue it seems that this header, and the > dependency on it from various installed headers, was introduced in > commit 77c21d19c314d79da1b60e319aa40eff57fef375 > > Can someone please fix this? > > At the moment it's breaking the build of various components which > depend on KHTML and as a consequence has left the CI system in an > inconsistent state. At this time both Applications and Plasma have > been negatively impacted by this. > > Cheers, > Ben -- Laurent Montel | laurent.mon...@kdab.com | KDE/Qt Senior Software Engineer KDAB (France) S.A.S., a KDAB Group company Tel. France +33 (0)4 90 84 08 53, www.kdab.fr KDAB - The Qt, C++ and OpenGL Experts - Platform-independent software solutions
D9330: Fix cmake warning (with cmake >= 3.9.0)
mlaurent abandoned this revision. mlaurent added a comment. commited in kcoreaddons REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D9330 To: mlaurent, dfaure Cc: kossebau, flherne, #frameworks
D9334: Remove cmake 3.10+ warning for users of K_PLUGIN_FACTORY and K_PLUGIN_FACTORY_WITH_JSON
This revision was automatically updated to reflect the committed changes. Closed by commit R244:fbc5881b916c: Remove cmake 3.10+ warning for users of K_PLUGIN_FACTORY and… (authored by mlaurent). REPOSITORY R244 KCoreAddons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D9334?vs=23928=23946 REVISION DETAIL https://phabricator.kde.org/D9334 AFFECTED FILES KF5CoreAddonsConfig.cmake.in To: mlaurent, dfaure Cc: #frameworks
D9332: Allow filter places based on alternative application name
mlaurent added inline comments. INLINE COMMENTS > kfileplacesmodel.h:72 > +* @param parent Parent object > +* @since 5.41 > +*/ 5.42 and missing //kf6 comment REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D9332 To: renatoo, mwolff, mlaurent Cc: mlaurent, aacid, ngraham, #frameworks
D9334: Remove cmake 3.10+ warning for users of K_PLUGIN_FACTORY and K_PLUGIN_FACTORY_WITH_JSON
mlaurent retitled this revision from "Remove cmake warning" to "Remove cmake 3.10+ warning for users of K_PLUGIN_FACTORY and K_PLUGIN_FACTORY_WITH_JSON". REPOSITORY R244 KCoreAddons REVISION DETAIL https://phabricator.kde.org/D9334 To: mlaurent, dfaure Cc: #frameworks
D9334: Remove cmake warning
mlaurent updated this revision to Diff 23928. mlaurent added a comment. - Remove line which made no sense in this module REPOSITORY R244 KCoreAddons CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D9334?vs=23923=23928 BRANCH remove_cmake_warning REVISION DETAIL https://phabricator.kde.org/D9334 AFFECTED FILES KF5CoreAddonsConfig.cmake.in To: mlaurent, dfaure Cc: #frameworks
D9332: Allow filter places based on alternative application name
mlaurent requested changes to this revision.
mlaurent added inline comments.
This revision now requires changes to proceed.
INLINE COMMENTS
> kfileplacesmodeltest.cpp:1276
> +// create a new entry with alternative application name
> +KBookmark bookmark = root.addBookmark(QStringLiteral("Extra entry"),
> QUrl("search:/videos-alternative"), {});
> +const QString id = QUuid::createUuid().toString();
QUrl(QStringLiteral("search:/videos-alternative"))
> kfileplacesmodel.h:67
>
> KFilePlacesModel(QObject *parent = nullptr);
> +KFilePlacesModel(const QString , QObject
> *parent = nullptr);
Add a comment for kf6 //kf6 merge with above method
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D9332
To: renatoo, mwolff, mlaurent
Cc: mlaurent, aacid, ngraham, #frameworks
D9334: Remove cmake warning
mlaurent added a reviewer: dfaure. REPOSITORY R244 KCoreAddons REVISION DETAIL https://phabricator.kde.org/D9334 To: mlaurent, dfaure Cc: #frameworks
D9334: Remove cmake warning
mlaurent created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. TEST PLAN compile kio without warning REPOSITORY R244 KCoreAddons BRANCH remove_cmake_warning REVISION DETAIL https://phabricator.kde.org/D9334 AFFECTED FILES KF5CoreAddonsConfig.cmake.in To: mlaurent Cc: #frameworks
D9330: Fix cmake warning (with cmake >= 3.9.0)
mlaurent added a comment. ok see https://phabricator.kde.org/D9334 REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D9330 To: mlaurent, dfaure Cc: kossebau, flherne, #frameworks
D9327: Remove duplicate lines.
This revision was automatically updated to reflect the committed changes. Closed by commit R241:5a6ce6d48c29: Remove duplicate lines. (authored by mlaurent). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D9327?vs=23909=23918 REVISION DETAIL https://phabricator.kde.org/D9327 AFFECTED FILES src/filewidgets/kfilewidget.cpp To: mlaurent, dfaure Cc: #frameworks
D9206: Implement a kfile dialog where we can add custom widget
This revision was automatically updated to reflect the committed changes. Closed by commit R241:41fbb247d97c: Implement a kfile dialog where we can add custom widget (authored by mlaurent). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D9206?vs=23916=23917 REVISION DETAIL https://phabricator.kde.org/D9206 AFFECTED FILES autotests/CMakeLists.txt autotests/kfilecustomdialogtest.cpp autotests/kfilecustomdialogtest.h src/filewidgets/CMakeLists.txt src/filewidgets/kfilecustomdialog.cpp src/filewidgets/kfilecustomdialog.h tests/CMakeLists.txt tests/kfilecustomdialogtest_gui.cpp To: mlaurent, mwolff, dfaure Cc: #frameworks
D9206: Implement a kfile dialog where we can add custom widget
mlaurent updated this revision to Diff 23916. mlaurent added a comment. - Remove indirection methods as requested by David. Fix doc too REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D9206?vs=23908=23916 BRANCH add_kfile_dialog REVISION DETAIL https://phabricator.kde.org/D9206 AFFECTED FILES autotests/CMakeLists.txt autotests/kfilecustomdialogtest.cpp autotests/kfilecustomdialogtest.h src/filewidgets/CMakeLists.txt src/filewidgets/kfilecustomdialog.cpp src/filewidgets/kfilecustomdialog.h tests/CMakeLists.txt tests/kfilecustomdialogtest_gui.cpp To: mlaurent, mwolff, dfaure Cc: #frameworks
D9206: Implement a kfile dialog where we can add custom widget
mlaurent marked 2 inline comments as done. REPOSITORY R241 KIO BRANCH add_kfile_dialog REVISION DETAIL https://phabricator.kde.org/D9206 To: mlaurent, mwolff, dfaure Cc: #frameworks
D9330: Fix cmake warning (with cmake >= 3.9.0)
mlaurent added a comment. Ok I can move it to ecm (mais in which file ?) "kde-modules/KDECMakeSettings.cmake" ? and it depends if apps have some specific macro for example in kmail we have "EXPORT_KONTACT_PLUGIN" too REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D9330 To: mlaurent, dfaure Cc: #frameworks
D9329: Verify that qWaitForWindowActive doesn't fail
This revision was automatically updated to reflect the committed changes. Closed by commit R241:c0e239446b64: Verify that qWaitForWindowActive doesnt fail (authored by mlaurent). REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D9329?vs=23911=23915 REVISION DETAIL https://phabricator.kde.org/D9329 AFFECTED FILES autotests/kfileplacesviewtest.cpp To: mlaurent, dfaure Cc: #frameworks
D9330: Fix cmake warning (with cmake >= 3.9.0)
mlaurent created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. TEST PLAN build REPOSITORY R241 KIO BRANCH fix_cmake_warning REVISION DETAIL https://phabricator.kde.org/D9330 AFFECTED FILES CMakeLists.txt To: mlaurent Cc: #frameworks
D9330: Fix cmake warning (with cmake >= 3.9.0)
mlaurent added a reviewer: dfaure. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D9330 To: mlaurent, dfaure Cc: #frameworks
D9329: Verify that qWaitForWindowActive doesn't fail
mlaurent added a reviewer: dfaure. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D9329 To: mlaurent, dfaure Cc: #frameworks
D9329: Verify that qWaitForWindowActive doesn't fail
mlaurent created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. TEST PLAN compile REPOSITORY R241 KIO BRANCH verify_return_value_qWaitForWindowActive REVISION DETAIL https://phabricator.kde.org/D9329 AFFECTED FILES autotests/kfileplacesviewtest.cpp To: mlaurent Cc: #frameworks
D9327: Remove duplicate lines.
mlaurent added a reviewer: dfaure. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D9327 To: mlaurent, dfaure Cc: #frameworks
D9327: Remove duplicate lines.
mlaurent created this revision. Restricted Application added a project: Frameworks. Restricted Application added a subscriber: Frameworks. TEST PLAN build/execute test apps REPOSITORY R241 KIO BRANCH remove_duplicate_tab_order REVISION DETAIL https://phabricator.kde.org/D9327 AFFECTED FILES src/filewidgets/kfilewidget.cpp To: mlaurent Cc: #frameworks
D9206: Implement a kfile dialog where we can add custom widget
mlaurent updated this revision to Diff 23908. mlaurent added a comment. - Fix doc, remove unused code, etc. REPOSITORY R241 KIO CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D9206?vs=23514=23908 BRANCH add_kfile_dialog REVISION DETAIL https://phabricator.kde.org/D9206 AFFECTED FILES autotests/CMakeLists.txt autotests/kfilecustomdialogtest.cpp autotests/kfilecustomdialogtest.h src/filewidgets/CMakeLists.txt src/filewidgets/kfilecustomdialog.cpp src/filewidgets/kfilecustomdialog.h tests/CMakeLists.txt tests/kfilecustomdialogtest_gui.cpp To: mlaurent, mwolff, dfaure Cc: #frameworks
D9206: Implement a kfile dialog where we can add custom widget
mlaurent marked 7 inline comments as done. REPOSITORY R241 KIO REVISION DETAIL https://phabricator.kde.org/D9206 To: mlaurent, mwolff, dfaure Cc: #frameworks
D9277: Remove cmake warning about generating moc file
This revision was automatically updated to reflect the committed changes. Closed by commit R237:962998ad27e9: Remove cmake warning about generating moc file (authored by mlaurent). REPOSITORY R237 KConfig CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D9277?vs=23882=23883 REVISION DETAIL https://phabricator.kde.org/D9277 AFFECTED FILES KF5ConfigMacros.cmake To: mlaurent, kfunk, dfaure Cc: mpyne, apol, aacid, #frameworks
D9277: Remove cmake warning about generating moc file
mlaurent updated this revision to Diff 23882. mlaurent added a comment. - Use set_source_files_properties REPOSITORY R237 KConfig CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D9277?vs=23716=23882 BRANCH remove_cmake_warning REVISION DETAIL https://phabricator.kde.org/D9277 AFFECTED FILES KF5ConfigMacros.cmake To: mlaurent, kfunk, dfaure Cc: mpyne, apol, aacid, #frameworks
D9277: Remove cmake warning about generating moc file
mlaurent added a comment. @kfunk what do you think about it ? :) REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D9277 To: mlaurent, kfunk, dfaure Cc: mpyne, apol, aacid, #frameworks
D9277: Remove cmake warning about generating moc file
mlaurent added a comment. @dfaure yep I rebuild all qt5.10 so yep :) REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D9277 To: mlaurent, kfunk, dfaure Cc: mpyne, apol, aacid, #frameworks
D9277: Remove cmake warning about generating moc file
mlaurent added a comment. @apol do you have cmake >= 3.10 ? REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D9277 To: mlaurent, kfunk, dfaure Cc: mpyne, apol, aacid, #frameworks
D9277: Remove cmake warning about generating moc file
mlaurent added a comment. @apol do you have an example of class which generate signal/slot ? For me ARG_GENERATE_MOC seems to be the case and by default it skips AUTOMOC REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D9277 To: mlaurent, kfunk, dfaure Cc: mpyne, apol, aacid, #frameworks
D9277: Remove cmake warning about generating moc file
mlaurent added a comment. it's seems that it was not fixed as I updated my kde last friday afternoon. and this morning I was this problem. And if it's fixed we need to remove this 2 lines So it seems there is still a code to remove. REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D9277 To: mlaurent, kfunk, dfaure Cc: aacid, #frameworks
D9277: Remove cmake warning about generating moc file
mlaurent added reviewers: kfunk, dfaure. REPOSITORY R237 KConfig REVISION DETAIL https://phabricator.kde.org/D9277 To: mlaurent, kfunk, dfaure Cc: #frameworks
