date:20170418

Todd Lipcon has uploaded a new change for review.

  http://gerrit.cloudera.org:8080/6685

Change subject: Add blog post for 1.3.1
..

Add blog post for 1.3.1

Change-Id: If8a94c8b75d4ba39fdee151e775a65ed34f5ee79
---
A _posts/2017-04-19-apache-kudu-1-3-1-released.md
1 file changed, 19 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/85/6685/1
-- 
To view, visit http://gerrit.cloudera.org:8080/6685
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: If8a94c8b75d4ba39fdee151e775a65ed34f5ee79
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: gh-pages
Gerrit-Owner: Todd Lipcon

[kudu-CR](gh-pages) Add 1.3.1 release and docs

Todd Lipcon has submitted this change and it was merged.

Change subject: Add 1.3.1 release and docs
..


Add 1.3.1 release and docs

Change-Id: I0bab6a65d78c72aba325de8113afb99a8ee5eca1
Reviewed-on: http://gerrit.cloudera.org:8080/6684
Reviewed-by: Todd Lipcon 
Tested-by: Todd Lipcon 
---
M apidocs/allclasses-frame.html
M apidocs/allclasses-noframe.html
M apidocs/constant-values.html
M apidocs/deprecated-list.html
M apidocs/help-doc.html
M apidocs/index-all.html
M apidocs/index.html
M apidocs/org/apache/kudu/ColumnSchema.html
M apidocs/org/apache/kudu/Schema.html
M apidocs/org/apache/kudu/Type.html
M apidocs/org/apache/kudu/annotations/InterfaceAudience.html
M apidocs/org/apache/kudu/annotations/InterfaceStability.html
M apidocs/org/apache/kudu/annotations/class-use/InterfaceAudience.html
M apidocs/org/apache/kudu/annotations/class-use/InterfaceStability.html
M apidocs/org/apache/kudu/annotations/package-frame.html
M apidocs/org/apache/kudu/annotations/package-summary.html
M apidocs/org/apache/kudu/annotations/package-tree.html
M apidocs/org/apache/kudu/annotations/package-use.html
M apidocs/org/apache/kudu/class-use/ColumnSchema.html
M apidocs/org/apache/kudu/class-use/Schema.html
M apidocs/org/apache/kudu/class-use/Type.html
M apidocs/org/apache/kudu/client/AbstractKuduScannerBuilder.html
M apidocs/org/apache/kudu/client/AlterTableOptions.html
M apidocs/org/apache/kudu/client/AlterTableResponse.html
M apidocs/org/apache/kudu/client/AsyncKuduClient.AsyncKuduClientBuilder.html
M apidocs/org/apache/kudu/client/AsyncKuduClient.html
M apidocs/org/apache/kudu/client/AsyncKuduScanner.AsyncKuduScannerBuilder.html
M apidocs/org/apache/kudu/client/AsyncKuduScanner.ReadMode.html
M apidocs/org/apache/kudu/client/AsyncKuduScanner.html
M apidocs/org/apache/kudu/client/AsyncKuduSession.html
M apidocs/org/apache/kudu/client/ColumnRangePredicate.html
M apidocs/org/apache/kudu/client/CreateTableOptions.html
M apidocs/org/apache/kudu/client/Delete.html
M apidocs/org/apache/kudu/client/DeleteTableResponse.html
M apidocs/org/apache/kudu/client/ExternalConsistencyMode.html
M apidocs/org/apache/kudu/client/HasFailedRpcException.html
M apidocs/org/apache/kudu/client/Insert.html
M apidocs/org/apache/kudu/client/IsAlterTableDoneResponse.html
M apidocs/org/apache/kudu/client/KuduClient.KuduClientBuilder.html
M apidocs/org/apache/kudu/client/KuduClient.html
M apidocs/org/apache/kudu/client/KuduException.html
M apidocs/org/apache/kudu/client/KuduPredicate.ComparisonOp.html
M apidocs/org/apache/kudu/client/KuduPredicate.html
M apidocs/org/apache/kudu/client/KuduScanToken.KuduScanTokenBuilder.html
M apidocs/org/apache/kudu/client/KuduScanToken.html
M apidocs/org/apache/kudu/client/KuduScanner.KuduScannerBuilder.html
M apidocs/org/apache/kudu/client/KuduScanner.html
M apidocs/org/apache/kudu/client/KuduSession.html
M apidocs/org/apache/kudu/client/KuduTable.html
M apidocs/org/apache/kudu/client/ListTablesResponse.html
M apidocs/org/apache/kudu/client/ListTabletServersResponse.html
M apidocs/org/apache/kudu/client/LocatedTablet.Replica.html
M apidocs/org/apache/kudu/client/LocatedTablet.html
M apidocs/org/apache/kudu/client/Operation.html
M apidocs/org/apache/kudu/client/OperationResponse.html
M apidocs/org/apache/kudu/client/PartialRow.html
M apidocs/org/apache/kudu/client/PleaseThrottleException.html
M apidocs/org/apache/kudu/client/RangePartitionBound.html
M apidocs/org/apache/kudu/client/ReplicaSelection.html
M apidocs/org/apache/kudu/client/RowError.html
M apidocs/org/apache/kudu/client/RowErrorsAndOverflowStatus.html
M apidocs/org/apache/kudu/client/RowResult.html
M apidocs/org/apache/kudu/client/RowResultIterator.html
M apidocs/org/apache/kudu/client/SessionConfiguration.FlushMode.html
M apidocs/org/apache/kudu/client/SessionConfiguration.html
M apidocs/org/apache/kudu/client/Statistics.Statistic.html
M apidocs/org/apache/kudu/client/Statistics.html
M apidocs/org/apache/kudu/client/Status.html
M apidocs/org/apache/kudu/client/Update.html
M apidocs/org/apache/kudu/client/Upsert.html
M apidocs/org/apache/kudu/client/class-use/AbstractKuduScannerBuilder.html
M apidocs/org/apache/kudu/client/class-use/AlterTableOptions.html
M apidocs/org/apache/kudu/client/class-use/AlterTableResponse.html
M 
apidocs/org/apache/kudu/client/class-use/AsyncKuduClient.AsyncKuduClientBuilder.html
M apidocs/org/apache/kudu/client/class-use/AsyncKuduClient.html
M 
apidocs/org/apache/kudu/client/class-use/AsyncKuduScanner.AsyncKuduScannerBuilder.html
M apidocs/org/apache/kudu/client/class-use/AsyncKuduScanner.ReadMode.html
M apidocs/org/apache/kudu/client/class-use/AsyncKuduScanner.html
M apidocs/org/apache/kudu/client/class-use/AsyncKuduSession.html
M apidocs/org/apache/kudu/client/class-use/ColumnRangePredicate.html
M apidocs/org/apache/kudu/client/class-use/CreateTableOptions.html
M apidocs/org/apache/kudu/client/class-use/Delete.html
M

[kudu-CR](gh-pages) Add 1.3.1 release and docs

Todd Lipcon has posted comments on this change.

Change subject: Add 1.3.1 release and docs
..


Patch Set 1: Code-Review+2 Verified+1

-- 
To view, visit http://gerrit.cloudera.org:8080/6684
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I0bab6a65d78c72aba325de8113afb99a8ee5eca1
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: gh-pages
Gerrit-Owner: Todd Lipcon 
Gerrit-Reviewer: Todd Lipcon 
Gerrit-HasComments: No

[kudu-CR](gh-pages) Add 1.3.1 release and docs

Todd Lipcon has uploaded a new change for review.

  http://gerrit.cloudera.org:8080/6684

Change subject: Add 1.3.1 release and docs
..

Add 1.3.1 release and docs

Change-Id: I0bab6a65d78c72aba325de8113afb99a8ee5eca1
---
M apidocs/allclasses-frame.html
M apidocs/allclasses-noframe.html
M apidocs/constant-values.html
M apidocs/deprecated-list.html
M apidocs/help-doc.html
M apidocs/index-all.html
M apidocs/index.html
M apidocs/org/apache/kudu/ColumnSchema.html
M apidocs/org/apache/kudu/Schema.html
M apidocs/org/apache/kudu/Type.html
M apidocs/org/apache/kudu/annotations/InterfaceAudience.html
M apidocs/org/apache/kudu/annotations/InterfaceStability.html
M apidocs/org/apache/kudu/annotations/class-use/InterfaceAudience.html
M apidocs/org/apache/kudu/annotations/class-use/InterfaceStability.html
M apidocs/org/apache/kudu/annotations/package-frame.html
M apidocs/org/apache/kudu/annotations/package-summary.html
M apidocs/org/apache/kudu/annotations/package-tree.html
M apidocs/org/apache/kudu/annotations/package-use.html
M apidocs/org/apache/kudu/class-use/ColumnSchema.html
M apidocs/org/apache/kudu/class-use/Schema.html
M apidocs/org/apache/kudu/class-use/Type.html
M apidocs/org/apache/kudu/client/AbstractKuduScannerBuilder.html
M apidocs/org/apache/kudu/client/AlterTableOptions.html
M apidocs/org/apache/kudu/client/AlterTableResponse.html
M apidocs/org/apache/kudu/client/AsyncKuduClient.AsyncKuduClientBuilder.html
M apidocs/org/apache/kudu/client/AsyncKuduClient.html
M apidocs/org/apache/kudu/client/AsyncKuduScanner.AsyncKuduScannerBuilder.html
M apidocs/org/apache/kudu/client/AsyncKuduScanner.ReadMode.html
M apidocs/org/apache/kudu/client/AsyncKuduScanner.html
M apidocs/org/apache/kudu/client/AsyncKuduSession.html
M apidocs/org/apache/kudu/client/ColumnRangePredicate.html
M apidocs/org/apache/kudu/client/CreateTableOptions.html
M apidocs/org/apache/kudu/client/Delete.html
M apidocs/org/apache/kudu/client/DeleteTableResponse.html
M apidocs/org/apache/kudu/client/ExternalConsistencyMode.html
M apidocs/org/apache/kudu/client/HasFailedRpcException.html
M apidocs/org/apache/kudu/client/Insert.html
M apidocs/org/apache/kudu/client/IsAlterTableDoneResponse.html
M apidocs/org/apache/kudu/client/KuduClient.KuduClientBuilder.html
M apidocs/org/apache/kudu/client/KuduClient.html
M apidocs/org/apache/kudu/client/KuduException.html
M apidocs/org/apache/kudu/client/KuduPredicate.ComparisonOp.html
M apidocs/org/apache/kudu/client/KuduPredicate.html
M apidocs/org/apache/kudu/client/KuduScanToken.KuduScanTokenBuilder.html
M apidocs/org/apache/kudu/client/KuduScanToken.html
M apidocs/org/apache/kudu/client/KuduScanner.KuduScannerBuilder.html
M apidocs/org/apache/kudu/client/KuduScanner.html
M apidocs/org/apache/kudu/client/KuduSession.html
M apidocs/org/apache/kudu/client/KuduTable.html
M apidocs/org/apache/kudu/client/ListTablesResponse.html
M apidocs/org/apache/kudu/client/ListTabletServersResponse.html
M apidocs/org/apache/kudu/client/LocatedTablet.Replica.html
M apidocs/org/apache/kudu/client/LocatedTablet.html
M apidocs/org/apache/kudu/client/Operation.html
M apidocs/org/apache/kudu/client/OperationResponse.html
M apidocs/org/apache/kudu/client/PartialRow.html
M apidocs/org/apache/kudu/client/PleaseThrottleException.html
M apidocs/org/apache/kudu/client/RangePartitionBound.html
M apidocs/org/apache/kudu/client/ReplicaSelection.html
M apidocs/org/apache/kudu/client/RowError.html
M apidocs/org/apache/kudu/client/RowErrorsAndOverflowStatus.html
M apidocs/org/apache/kudu/client/RowResult.html
M apidocs/org/apache/kudu/client/RowResultIterator.html
M apidocs/org/apache/kudu/client/SessionConfiguration.FlushMode.html
M apidocs/org/apache/kudu/client/SessionConfiguration.html
M apidocs/org/apache/kudu/client/Statistics.Statistic.html
M apidocs/org/apache/kudu/client/Statistics.html
M apidocs/org/apache/kudu/client/Status.html
M apidocs/org/apache/kudu/client/Update.html
M apidocs/org/apache/kudu/client/Upsert.html
M apidocs/org/apache/kudu/client/class-use/AbstractKuduScannerBuilder.html
M apidocs/org/apache/kudu/client/class-use/AlterTableOptions.html
M apidocs/org/apache/kudu/client/class-use/AlterTableResponse.html
M 
apidocs/org/apache/kudu/client/class-use/AsyncKuduClient.AsyncKuduClientBuilder.html
M apidocs/org/apache/kudu/client/class-use/AsyncKuduClient.html
M 
apidocs/org/apache/kudu/client/class-use/AsyncKuduScanner.AsyncKuduScannerBuilder.html
M apidocs/org/apache/kudu/client/class-use/AsyncKuduScanner.ReadMode.html
M apidocs/org/apache/kudu/client/class-use/AsyncKuduScanner.html
M apidocs/org/apache/kudu/client/class-use/AsyncKuduSession.html
M apidocs/org/apache/kudu/client/class-use/ColumnRangePredicate.html
M apidocs/org/apache/kudu/client/class-use/CreateTableOptions.html
M apidocs/org/apache/kudu/client/class-use/Delete.html
M apidocs/org/apache/kudu/client/class-use/DeleteTableResponse.html
M

[kudu-CR] [rpc-test] fixed TestConnectionKeepalive flakiness

2017-04-18 Thread Sailesh Mukil (Code Review)

Sailesh Mukil has posted comments on this change.

Change subject: [rpc-test] fixed TestConnectionKeepalive flakiness
..


Patch Set 1: Code-Review+1

LGTM

-- 
To view, visit http://gerrit.cloudera.org:8080/6683
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I8fb2dec953c1047ea43fe9e28d470ae6566077c5
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin 
Gerrit-Reviewer: Dan Burkert 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy 
Gerrit-Reviewer: Sailesh Mukil 
Gerrit-Reviewer: Tidy Bot
Gerrit-Reviewer: Todd Lipcon 
Gerrit-HasComments: No

[kudu-CR] [rpc-test] fixed TestConnectionKeepalive flakiness

Alexey Serbin has uploaded a new change for review.

  http://gerrit.cloudera.org:8080/6683

Change subject: [rpc-test] fixed TestConnectionKeepalive flakiness
..

[rpc-test] fixed TestConnectionKeepalive flakiness

After introducing TLS option for Kudu RPC, the TestConnectionKeepalive
became a bit flaky, failing time to time with output like the following:

[ RUN  ] OptionalSSL/TestRpc.TestConnectionKeepalive/1
I0419 01:31:19.019090  4863 rpc-test.cc:223] Connecting to 0.0.0.0:52055
src/kudu/rpc/rpc-test.cc:225: Failure
Failed
Bad status: Network error: Recv() got EOF from remote (error 108)

[ RUN  ] OptionalSSL/TestRpc.TestConnectionKeepalive/1
I0419 01:31:25.609285   370 rpc-test.cc:223] Connecting to 0.0.0.0:41418
W0419 01:31:25.853305   398 connection.cc:462] client connection to \
  0.0.0.0:41418 recv error: Network error: recv error: \
  Connection reset by peer (error 104)
src/kudu/rpc/rpc-test.cc:225: Failure
Failed
Bad status: Network error: recv error: Connection reset by peer (error 104)

It seems the TLS connection establishment phase in some cases takes too long,
so by the time of test RPC call might close.

Bumping the keepalive interval helped to address the issue.  Prior to
this fix, if running with --stress_cpu_threads=32 option,
usually 15 out of 1024 runs failed.  After the fix 0 out of 4096 runs failed.

Change-Id: I8fb2dec953c1047ea43fe9e28d470ae6566077c5
---
M src/kudu/rpc/rpc-test.cc
1 file changed, 2 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/83/6683/1
-- 
To view, visit http://gerrit.cloudera.org:8080/6683
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I8fb2dec953c1047ea43fe9e28d470ae6566077c5
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin

[kudu-CR] log block manager: use extent maps to decide whether to truncate containers

Hello David Ribeiro Alves, Todd Lipcon, Kudu Jenkins,

I'd like you to reexamine a change.  Please visit

http://gerrit.cloudera.org:8080/6585

to look at the new patch set (#7).

Change subject: log block manager: use extent maps to decide whether to 
truncate containers
..

log block manager: use extent maps to decide whether to truncate containers

This patch wires the new GetExtentMap() method into the LBM for use in
determining whether there exists allocated disk space beyond the container
data file's logical size. Why bother? Well, it's not possible for the
"full container preallocation" accounting in FsReport to be accurate
otherwise. Also, reducing the number of cases wherein containers are
truncated ought to be safer. Finally, we'll eventually use the extent map
for other purposes (e.g. repunching holes efficiently at startup).

Performance testing revealed that GetExtentMap()-based truncation slows down
overall startup significantly; a follow-on patch will gate the affected
checks behind a new gflag.

My first implementation required LBM users to have GetExtentMap()-compatible
systems. Testing showed this to be safe across Kudu's supported distro and
filesystem matrix. The notable exception was aufs, used by Docker containers
that run our pre-commit tests. It would be unfortunate if Kudu were unusable
in Docker [1], so I adjusted the behavior to be more forgiving.

I also snuck in some cosmetic changes to a few error messages.

1. Though isn't KUDU-1419 still an issue? Maybe not in all versions of aufs?

Change-Id: I3541f70721328d5af911f4889f8b4bcf0de3ebf8
---
M src/kudu/fs/data_dirs.cc
M src/kudu/fs/log_block_manager-test.cc
M src/kudu/fs/log_block_manager.cc
3 files changed, 118 insertions(+), 23 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/85/6585/7
-- 
To view, visit http://gerrit.cloudera.org:8080/6585
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I3541f70721328d5af911f4889f8b4bcf0de3ebf8
Gerrit-PatchSet: 7
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Adar Dembo 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: David Ribeiro Alves 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon

[kudu-CR] block manager: gflag to control repairs at startup

Hello David Ribeiro Alves, Todd Lipcon,

I'd like you to do a code review.  Please visit

http://gerrit.cloudera.org:8080/6682

to review the following change.

Change subject: block manager: gflag to control repairs at startup
..

block manager: gflag to control repairs at startup

This patch introduces a gflag that controls which block manager repairs are
undertaken at startup. Its three states are:
- all: all inconsistencies are repaired.
- some (default): only "cheap" inconsistencies are repaired.
- none: no repairs are performed.

The idea is that regular server startup will only detect and repair some
stuff, while "kudu fs check" will detect (and optionally repair) everything.

As far as the LBM is concerned, 'all' means inconsistency checks that need
extent maps (expensive!) will be performed. Moreover, 'none' introduces some
complexity for fatal and repairable inconsistencies (i.e. partial records).

Note: the new gflag is a little overloaded; sometimes it deals with both
detection and repair (i.e. full container preallocation inconsistencies when
'all') while other times it's just repair (i.e. partial record
inconsistencies when 'none'). Feedback welcome on how to address that.

Change-Id: I06750991e1ede07ab7173a3cc5de12279d3f5b88
---
M src/kudu/fs/block_manager.cc
M src/kudu/fs/fs_report.cc
M src/kudu/fs/fs_report.h
M src/kudu/fs/log_block_manager-test.cc
M src/kudu/fs/log_block_manager.cc
M src/kudu/tools/tool_action_fs.cc
6 files changed, 102 insertions(+), 24 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/82/6682/1
-- 
To view, visit http://gerrit.cloudera.org:8080/6682
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I06750991e1ede07ab7173a3cc5de12279d3f5b88
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Adar Dembo 
Gerrit-Reviewer: David Ribeiro Alves 
Gerrit-Reviewer: Todd Lipcon

[kudu-CR] WIP: KUDU-463. Add checksumming to cfile

2017-04-18 Thread Grant Henke (Code Review)

Grant Henke has posted comments on this change.

Change subject: WIP: KUDU-463. Add checksumming to cfile
..


Patch Set 3:

(9 comments)

http://gerrit.cloudera.org:8080/#/c/6630/3//COMMIT_MSG
Commit Message:

Line 19: immeditaly result in performance degredation and incompatible data on
> typo
Done


Line 25: are not writen the incompatible_features "checksum" bit is not set.
> typo
Done


Line 27: cfile_verify_checksums is used in the CFileReader to enabled 
validating the
> typo
Done


http://gerrit.cloudera.org:8080/#/c/6630/3/src/kudu/cfile/cfile-test.cc
File src/kudu/cfile/cfile-test.cc:

Line 790:   TestReadWriteRawBlocks(SNAPPY, 1000);
> maybe this could be collapsed into a for loop?
Done


Line 819:   unique_ptr corrupt_source(
> would it be simpler to just corrupt the data on disk instead of this code-i
I will look into this. I think ideally I would like to corrupt each byte in a 
sample file and show it results in a corrupt/io error. I was planning to use 
this to do that. However I ran into some issues with the caching of index 
blocks. So regardless a slightly different approach than what is here is needed.


http://gerrit.cloudera.org:8080/#/c/6630/3/src/kudu/cfile/cfile_reader.cc
File src/kudu/cfile/cfile_reader.cc:

Line 157:   if (PREDICT_FALSE(footer_->incompatible_features() > 
IncompatibleFeatures::ALL)) {
> this strikes me as odd... don't you mean & (~IncompatibleFeatures::ALL)?
Your check is technically more correct since if there are bits in the middle 
that are not valid but are set, it will check that. I assumed incompatible 
feature bits would be used sequentially. Especially since we output "supported" 
as an integer in the log message below.


Line 363:   uint32_t data_size = ptr.size();
> best to use a signed int here
ptr.size() returns uint32_t, so I kept it the same for consistency.


Line 366: data_size = ptr.size() - sizeof(uint32_t);
> we should verify that ptr.size() >= sizeof(uint32_t) first and return a Cor
Done


Line 392: RETURN_NOT_OK(block_->Read(checksum_offset, sizeof(uint32_t), 
, checksum_scratch));
> I think perf wise it may be better to just allocate the extra 4 bytes in th
I didn't want to cache the checksum since that seamed to complicate cache reads.


-- 
To view, visit http://gerrit.cloudera.org:8080/6630
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6756834cd7f27af258797a3654a95244abeb0976
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Grant Henke 
Gerrit-Reviewer: Grant Henke 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Tidy Bot
Gerrit-Reviewer: Todd Lipcon 
Gerrit-HasComments: Yes

[kudu-CR] gutil: stop supporting AMD Opteron K8 (take 2)

Todd Lipcon has submitted this change and it was merged.

Change subject: gutil: stop supporting AMD Opteron K8 (take 2)
..


gutil: stop supporting AMD Opteron K8 (take 2)

This removes a workaround for a bug in very old (circa 2003) Opteron
chips. The workaround was producing an extra branch around most of our
atomic operations. This likely has a negligible perf impact, but it's
possible the slightly smaller code would make us run a bit faster or
reduce branch mispredictions.

Previously we also entirely forgot to call this function, so it was in
fact never applying the workaround. This patch marks the function as a
constructor, which ensures that it gets automatically called by any
binaries using atomic ops.

Impala made a similar change[1][2] a while back and seems to have had
no real issues.

[1] https://gerrit.cloudera.org/#/c/2516/
[2] 
https://github.com/apache/incubator-impala/commit/a7c3f301bb1da14d6bb35d37aab47450c67cca0c

Change-Id: I4eff19c62741e7433e378f7e0725079ecbcf1a97
Reviewed-on: http://gerrit.cloudera.org:8080/6680
Reviewed-by: Adar Dembo 
Tested-by: Kudu Jenkins
---
M src/kudu/gutil/atomicops-internals-tsan.h
M src/kudu/gutil/atomicops-internals-x86.cc
M src/kudu/gutil/atomicops-internals-x86.h
3 files changed, 11 insertions(+), 46 deletions(-)

Approvals:
  Adar Dembo: Looks good to me, approved
  Kudu Jenkins: Verified



-- 
To view, visit http://gerrit.cloudera.org:8080/6680
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I4eff19c62741e7433e378f7e0725079ecbcf1a97
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy 
Gerrit-Reviewer: Todd Lipcon

[kudu-CR] gutil: stop supporting AMD Opteron K8 (take 2)

Adar Dembo has posted comments on this change.

Change subject: gutil: stop supporting AMD Opteron K8 (take 2)
..


Patch Set 1: Code-Review+2

-- 
To view, visit http://gerrit.cloudera.org:8080/6680
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4eff19c62741e7433e378f7e0725079ecbcf1a97
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy 
Gerrit-Reviewer: Todd Lipcon 
Gerrit-HasComments: No

[kudu-CR] gutil: stop supporting AMD Opteron K8 (take 2)

Todd Lipcon has posted comments on this change.

Change subject: gutil: stop supporting AMD Opteron K8 (take 2)
..


Patch Set 1:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/6680/1/src/kudu/gutil/atomicops-internals-x86.cc
File src/kudu/gutil/atomicops-internals-x86.cc:

Line 70: static void AtomicOps_Internalx86CPUFeaturesInit() {
> Is this guaranteed to load before glog? If not, what will happen in the LOG
well, I think it's handier to just use a constructor function. tcmalloc seems 
to have switched to a module initializer as well, but they forgot to mark it 
static.

LOG(FATAL) still works even if glog isn't initted yet. It might not go to the 
right log file, but I think that's fine since this is so rare.


PS1, Line 107: 0fh
> 0fh == 0x0f? Is that typical parlance?
yea that's what they call it in docs, etc.


-- 
To view, visit http://gerrit.cloudera.org:8080/6680
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4eff19c62741e7433e378f7e0725079ecbcf1a97
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy 
Gerrit-Reviewer: Todd Lipcon 
Gerrit-HasComments: Yes

[kudu-CR] log-test: Add additional assert

Mike Percy has submitted this change and it was merged.

Change subject: log-test: Add additional assert
..


log-test: Add additional assert

This just adds an additional check which is nice to have in this test.
This was added in a backport to the 1.2.x branch and so is also being
added here.

Change-Id: Idb4847cb3fa8d4600be8a9b1b681613046988018
Reviewed-on: http://gerrit.cloudera.org:8080/6674
Tested-by: Mike Percy 
Reviewed-by: Alexey Serbin 
---
M src/kudu/consensus/log-test.cc
1 file changed, 1 insertion(+), 0 deletions(-)

Approvals:
  Mike Percy: Verified
  Alexey Serbin: Looks good to me, approved



-- 
To view, visit http://gerrit.cloudera.org:8080/6674
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Idb4847cb3fa8d4600be8a9b1b681613046988018
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Mike Percy 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: Jean-Daniel Cryans 
Gerrit-Reviewer: Mike Percy

[kudu-CR] gutil: stop supporting AMD Opteron K8 (take 2)

Adar Dembo has posted comments on this change.

Change subject: gutil: stop supporting AMD Opteron K8 (take 2)
..


Patch Set 1:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/6680/1/src/kudu/gutil/atomicops-internals-x86.cc
File src/kudu/gutil/atomicops-internals-x86.cc:

Line 70: static void AtomicOps_Internalx86CPUFeaturesInit() {
Is this guaranteed to load before glog? If not, what will happen in the 
LOG(FATAL) call below?

Why not just rename AtomicOps_x86CPUFeatureStruct (and stick to the original 
patch where this method is explicitly called) so there's no collision with the 
struct variant from tcmalloc? Or wrap it all in another namespace?


-- 
To view, visit http://gerrit.cloudera.org:8080/6680
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4eff19c62741e7433e378f7e0725079ecbcf1a97
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy 
Gerrit-HasComments: Yes

[kudu-CR] log-test: Add additional assert

Mike Percy has posted comments on this change.

Change subject: log-test: Add additional assert
..


Patch Set 2: Verified+1

Overriding existing test failure due to KUDU-1736

-- 
To view, visit http://gerrit.cloudera.org:8080/6674
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Idb4847cb3fa8d4600be8a9b1b681613046988018
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Mike Percy 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: Jean-Daniel Cryans 
Gerrit-Reviewer: Mike Percy 
Gerrit-HasComments: No

[kudu-CR] gutil: stop supporting AMD Opteron K8 (take 2)

Mike Percy has posted comments on this change.

Change subject: gutil: stop supporting AMD Opteron K8 (take 2)
..


Patch Set 1:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/6680/1/src/kudu/gutil/atomicops-internals-x86.cc
File src/kudu/gutil/atomicops-internals-x86.cc:

PS1, Line 107: 0fh
0fh == 0x0f? Is that typical parlance?


-- 
To view, visit http://gerrit.cloudera.org:8080/6680
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4eff19c62741e7433e378f7e0725079ecbcf1a97
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy 
Gerrit-HasComments: Yes

[kudu-CR] docs: Add breakpad documentation to user guide

Hello Todd Lipcon, Kudu Jenkins,

I'd like you to reexamine a change.  Please visit

http://gerrit.cloudera.org:8080/6504

to look at the new patch set (#2).

Change subject: docs: Add breakpad documentation to user guide
..

docs: Add breakpad documentation to user guide

Change-Id: I05275aab0196dbf8fc37da320a0bf34662606a14
---
M docs/troubleshooting.adoc
1 file changed, 49 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/04/6504/2
-- 
To view, visit http://gerrit.cloudera.org:8080/6504
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I05275aab0196dbf8fc37da320a0bf34662606a14
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Mike Percy 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy 
Gerrit-Reviewer: Todd Lipcon

[kudu-CR] docs: Shorten top-level headings in Troubleshooting Guide

Hello Todd Lipcon,

I'd like you to do a code review.  Please visit

http://gerrit.cloudera.org:8080/6681

to review the following change.

Change subject: docs: Shorten top-level headings in Troubleshooting Guide
..

docs: Shorten top-level headings in Troubleshooting Guide

The top level headings in the Troubleshooting Guide wrap in the table of
contents on the web site because they are too long. Let's shorten those
headings so they are easier to read in the TOC.

Change-Id: Iccd0daf7954f79760a20f1fd281c3d167114a063
---
M docs/troubleshooting.adoc
1 file changed, 5 insertions(+), 3 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/81/6681/1
-- 
To view, visit http://gerrit.cloudera.org:8080/6681
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Iccd0daf7954f79760a20f1fd281c3d167114a063
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Mike Percy 
Gerrit-Reviewer: Todd Lipcon

[kudu-CR] Replace deprecated OpenSSL function ERR remove state()

Todd Lipcon has submitted this change and it was merged.

Change subject: Replace deprecated OpenSSL function ERR_remove_state()
..


Replace deprecated OpenSSL function ERR_remove_state()

ERR_remove_state() has been deprecated. ERR_remove_thread_state()
should be used in its place instead.

Change-Id: If0d2895cd331f94ad383e8666b84e15bfc035d3a
Reviewed-on: http://gerrit.cloudera.org:8080/6556
Reviewed-by: Todd Lipcon 
Tested-by: Kudu Jenkins
---
M src/kudu/rpc/reactor.cc
M src/kudu/security/tls_socket.cc
2 files changed, 3 insertions(+), 1 deletion(-)

Approvals:
  Todd Lipcon: Looks good to me, approved
  Kudu Jenkins: Verified



-- 
To view, visit http://gerrit.cloudera.org:8080/6556
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: If0d2895cd331f94ad383e8666b84e15bfc035d3a
Gerrit-PatchSet: 4
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Sailesh Mukil 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Sailesh Mukil 
Gerrit-Reviewer: Todd Lipcon

[kudu-CR] Fix thirdparty build error in Centos 6.

Todd Lipcon has submitted this change and it was merged.

Change subject: Fix thirdparty build error in Centos 6.
..


Fix thirdparty build error in Centos 6.

When doing a fresh build in Centos 6, one might get errors like
this: libcurl.so: undefined reference to `libssh2_userauth_list'.
This patch fixes this error by building curl without libssh2.

Change-Id: I3c72d76f6c4f5db7eb03f3e5f7efb4d3f6bb1e74
Reviewed-on: http://gerrit.cloudera.org:8080/6673
Reviewed-by: Todd Lipcon 
Tested-by: Kudu Jenkins
---
M thirdparty/build-definitions.sh
1 file changed, 2 insertions(+), 1 deletion(-)

Approvals:
  Todd Lipcon: Looks good to me, approved
  Kudu Jenkins: Verified



-- 
To view, visit http://gerrit.cloudera.org:8080/6673
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I3c72d76f6c4f5db7eb03f3e5f7efb4d3f6bb1e74
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Amos Bird 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon

[kudu-CR] gutil: stop supporting AMD Opteron K8 (take 2)

Hello Adar Dembo,

I'd like you to do a code review. Please visit

http://gerrit.cloudera.org:8080/6680

to review the following change.

Change subject: gutil: stop supporting AMD Opteron K8 (take 2)
..

gutil: stop supporting AMD Opteron K8 (take 2)

This removes a workaround for a bug in very old (circa 2003) Opteron
chips. The workaround was producing an extra branch around most of our
atomic operations. This likely has a negligible perf impact, but it's
possible the slightly smaller code would make us run a bit faster or
reduce branch mispredictions.

Previously we also entirely forgot to call this function, so it was in
fact never applying the workaround. This patch marks the function as a
constructor, which ensures that it gets automatically called by any
binaries using atomic ops.

Impala made a similar change[1][2] a while back and seems to have had
no real issues.

[1] https://gerrit.cloudera.org/#/c/2516/
[2]
https://github.com/apache/incubator-impala/commit/a7c3f301bb1da14d6bb35d37aab47450c67cca0c

Change-Id: I4eff19c62741e7433e378f7e0725079ecbcf1a97
---
M src/kudu/gutil/atomicops-internals-tsan.h
M src/kudu/gutil/atomicops-internals-x86.cc
M src/kudu/gutil/atomicops-internals-x86.h
3 files changed, 11 insertions(+), 46 deletions(-)

git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/80/6680/1
--
To view, visit http://gerrit.cloudera.org:8080/6680
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I4eff19c62741e7433e378f7e0725079ecbcf1a97
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon
Gerrit-Reviewer: Adar Dembo

[kudu-CR] log-test: Add additional assert

Hello Kudu Jenkins,

I'd like you to reexamine a change.  Please visit

http://gerrit.cloudera.org:8080/6674

to look at the new patch set (#2).

Change subject: log-test: Add additional assert
..

log-test: Add additional assert

This just adds an additional check which is nice to have in this test.
This was added in a backport to the 1.2.x branch and so is also being
added here.

Change-Id: Idb4847cb3fa8d4600be8a9b1b681613046988018
---
M src/kudu/consensus/log-test.cc
1 file changed, 1 insertion(+), 0 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/74/6674/2
-- 
To view, visit http://gerrit.cloudera.org:8080/6674
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Idb4847cb3fa8d4600be8a9b1b681613046988018
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Mike Percy 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: Jean-Daniel Cryans 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy

[kudu-CR] log-test: Add additional assert

Mike Percy has posted comments on this change.

Change subject: log-test: Add additional assert
..


Patch Set 1:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/6674/1/src/kudu/consensus/log-test.cc
File src/kudu/consensus/log-test.cc:

PS1, Line 1020: INT32_MAX
> nit: why not to use std::numeric_limits::max() here as well (as it
Done


-- 
To view, visit http://gerrit.cloudera.org:8080/6674
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Idb4847cb3fa8d4600be8a9b1b681613046988018
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Mike Percy 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: Jean-Daniel Cryans 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy 
Gerrit-HasComments: Yes

[kudu-CR] Update link to KDE C++ ABI maintenance guidelines

Adar Dembo has submitted this change and it was merged.

Change subject: Update link to KDE C++ ABI maintenance guidelines
..


Update link to KDE C++ ABI maintenance guidelines

The old location advertises this new one.

Change-Id: Ia7009f83f7507ea0bc76299e73c2b41c65073481
Reviewed-on: http://gerrit.cloudera.org:8080/6679
Reviewed-by: Alexey Serbin 
Tested-by: Kudu Jenkins
---
M src/kudu/client/CMakeLists.txt
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Alexey Serbin: Looks good to me, approved
  Kudu Jenkins: Verified



-- 
To view, visit http://gerrit.cloudera.org:8080/6679
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ia7009f83f7507ea0bc76299e73c2b41c65073481
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Adar Dembo 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: Kudu Jenkins

[kudu-CR] Update link to KDE C++ ABI maintenance guidelines

Alexey Serbin has posted comments on this change.

Change subject: Update link to KDE C++ ABI maintenance guidelines
..


Patch Set 1: Code-Review+2

-- 
To view, visit http://gerrit.cloudera.org:8080/6679
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia7009f83f7507ea0bc76299e73c2b41c65073481
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Adar Dembo 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: No

[kudu-CR] Update link to KDE C++ ABI maintenance guidelines

Adar Dembo has uploaded a new change for review.

  http://gerrit.cloudera.org:8080/6679

Change subject: Update link to KDE C++ ABI maintenance guidelines
..

Update link to KDE C++ ABI maintenance guidelines

The old location advertises this new one.

Change-Id: Ia7009f83f7507ea0bc76299e73c2b41c65073481
---
M src/kudu/client/CMakeLists.txt
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/79/6679/1
-- 
To view, visit http://gerrit.cloudera.org:8080/6679
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ia7009f83f7507ea0bc76299e73c2b41c65073481
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Adar Dembo

[kudu-CR] log block manager: use extent maps to decide whether to truncate containers

Adar Dembo has posted comments on this change.

Change subject: log block manager: use extent maps to decide whether to 
truncate containers
..


Patch Set 6:

> Yea, I think it's quite reasonable to only do so in a "fs check
 > --repair" type situation.
 
OK, I'll work on that.

 > Another option I think is reasonable is to use stat() on the
 > container file, see the actual space usage, and if it's
 > significantly more than we expect based on the live block count in
 > the container, trigger the hole-punching.
 
Right, we talked about this before. Assuming an "expensive repair" thing 
exists, the issue isn't knowing _when_ to re-hole-punch; it's knowing _how 
much_ unpunched space exists (for reporting purposes), and this approach 
doesn't provide an accurate measure of that.

 > A third option: when we successfully hole-punch after a delete,
 > write an entry to the metadata file saying "hole-punched!" (no need
 > to fsync it). On restart, re-punch any containers which have
 > deletions at the trail of the metadata with no "hole-punched!".
 > This way you'd only have to re-punch those files which might have
 > missed their chance due to a premature process exit last time
 > around.

That's an interesting idea, though it trades off extent map fetching for larger 
metadata files. Need to think more about it.

 > BTW the restart times are longer than i expected, would be curious
 > to know where all that time is going (but that's unrelated to this
 > jira)

I'll look into that later.

-- 
To view, visit http://gerrit.cloudera.org:8080/6585
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3541f70721328d5af911f4889f8b4bcf0de3ebf8
Gerrit-PatchSet: 6
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Adar Dembo 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: David Ribeiro Alves 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon 
Gerrit-HasComments: No

[kudu-CR](branch-1.3.x) [docs] Add admin workflow for recovering from disk failure

Dan Burkert has posted comments on this change.

Change subject: [docs] Add admin workflow for recovering from disk failure
..


Patch Set 1:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/6677/1/docs/administration.adoc
File docs/administration.adoc:

Line 590: === Recovering from Disk Failure
> Do we have an jira for rebalancing tool now? Or it is covered in KUDU-616?
I think KUDU-886 is the relevant JIRA.


-- 
To view, visit http://gerrit.cloudera.org:8080/6677
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6541bffc5e9546c523df610fd8c025dd05e403bf
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: branch-1.3.x
Gerrit-Owner: Dan Burkert 
Gerrit-Reviewer: Dan Burkert 
Gerrit-Reviewer: Hao Hao 
Gerrit-Reviewer: Jean-Daniel Cryans 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon 
Gerrit-HasComments: Yes

[kudu-CR](branch-1.3.x) KUDU-1708. Document Kudu command-line tools

Alexey Serbin has posted comments on this change.

Change subject: KUDU-1708. Document Kudu command-line tools
..


Patch Set 2:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/6645/2/src/kudu/tools/tool_action.cc
File src/kudu/tools/tool_action.cc:

Line 190:   return xml;
> It's possible, but I followed the pattern used by existing helpxml flags. I
I see.

I just thought if it were possible to produce output (not only help) using 
libxo, it might be useful in troubleshooting and, maybe, even creating some 
automated scripts (the JSON output might be the preferred one in those 
scenarios).

If it's just for documenting the help output which is going to be processed by 
the Kudu documentation suite, then HTML or JSON output is not needed as is.


-- 
To view, visit http://gerrit.cloudera.org:8080/6645
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9f484f772cbaeb385687d83a2665ae4d7292aaf5
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: branch-1.3.x
Gerrit-Owner: Dan Burkert 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: Dan Burkert 
Gerrit-Reviewer: Grant Henke 
Gerrit-Reviewer: Jean-Daniel Cryans 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon 
Gerrit-HasComments: Yes

[kudu-CR] WIP: KUDU-463. Add checksumming to cfile

2017-04-18 Thread Grant Henke (Code Review)

Hello Kudu Jenkins,

I'd like you to reexamine a change.  Please visit

http://gerrit.cloudera.org:8080/6630

to look at the new patch set (#4).

Change subject: WIP: KUDU-463. Add checksumming to cfile
..

WIP: KUDU-463. Add checksumming to cfile

Adds optional checksumming and validation to cfile blocks.

Introduces 2 flags to control cfile checksumming:
- cfile_write_checksums (default false)
- cfile_verify_checksums (default true)

cfile_write_checksums is used in the CFileWriter to enable computing and
appending Crc32 checksums to the end of each cfile block, header and footer

cfile_write_checksums is defaulted to false to ensure upgrades don't
immediately result in performance degredation and incompatible data on
downgrade. It can and likely should be defaulted to true in a later release.

When cfile_write_checksums is set to true, the existing incompatible_features
bitset in the cfile footer is used. A "checksum" bit is set to ensure a clear
error message when older versions of Kudu try to read the file. If checksums
are not written the incompatible_features "checksum" bit is not set.

cfile_verify_checksums is used in the CFileReader to enable validating the
data against the written checksum. cfile_verify_checksums is defaulted to
true since validation only occurs if checksums are written. Any data that
was written before checksumming was an option or when cfile_write_checksums
was false will not be verified.

TODO:
- Update cfile docs
- Finish testing
- Change cfile block to page to avoid term overload?

Change-Id: I6756834cd7f27af258797a3654a95244abeb0976
---
M src/kudu/cfile/cfile-test.cc
M src/kudu/cfile/cfile_reader.cc
M src/kudu/cfile/cfile_reader.h
M src/kudu/cfile/cfile_util.h
M src/kudu/cfile/cfile_writer.cc
M src/kudu/fs/fs-test-util.h
M src/kudu/util/crc.cc
M src/kudu/util/crc.h
8 files changed, 321 insertions(+), 44 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/30/6630/4
-- 
To view, visit http://gerrit.cloudera.org:8080/6630
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I6756834cd7f27af258797a3654a95244abeb0976
Gerrit-PatchSet: 4
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Grant Henke 
Gerrit-Reviewer: Grant Henke 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon

[kudu-CR](branch-1.3.x) KUDU-1708. Document Kudu command-line tools

Alexey Serbin has posted comments on this change.

Change subject: KUDU-1708. Document Kudu command-line tools
..


Patch Set 2:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/6645/2/src/kudu/tools/tool_action.cc
File src/kudu/tools/tool_action.cc:

PS2, Line 174: string Mode::BuildHelpXML(const vector& chain) const {
 :   string xml;
 :   xml += "";
 :   xml += Substitute("$0", name());
 :   xml += Substitute("$0",
 : EscapeForHtmlToString(description()));
 :   for (const auto& a : actions()) {
 : xml += a->BuildHelpXML(chain);
 :   }
 : 
 :   for (const auto& m : modes()) {
 : vector m_chain(chain);
 : m_chain.push_back(m.get());
 : xml += m->BuildHelpXML(m_chain);
 :   }
 :   xml += "";
 :   return xml;
> This is just a backport, so if we were to do that it would need to be in a 
Ah, I see.  I missed it's for 1.3.x only.


-- 
To view, visit http://gerrit.cloudera.org:8080/6645
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9f484f772cbaeb385687d83a2665ae4d7292aaf5
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: branch-1.3.x
Gerrit-Owner: Dan Burkert 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: Dan Burkert 
Gerrit-Reviewer: Grant Henke 
Gerrit-Reviewer: Jean-Daniel Cryans 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon 
Gerrit-HasComments: Yes

[kudu-CR](branch-1.3.x) KUDU-1708. Document Kudu command-line tools

2017-04-18 Thread Grant Henke (Code Review)

Grant Henke has posted comments on this change.

Change subject: KUDU-1708. Document Kudu command-line tools
..


Patch Set 2:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/6645/2/src/kudu/tools/tool_action.cc
File src/kudu/tools/tool_action.cc:

Line 190:   return xml;
> Is it possible to use libxo library https://github.com/Juniper/libxo for th
It's possible, but I followed the pattern used by existing helpxml flags. I 
think a single patch to change all of them would be a good idea. 

When would we use json or html output?


-- 
To view, visit http://gerrit.cloudera.org:8080/6645
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9f484f772cbaeb385687d83a2665ae4d7292aaf5
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: branch-1.3.x
Gerrit-Owner: Dan Burkert 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: Dan Burkert 
Gerrit-Reviewer: Grant Henke 
Gerrit-Reviewer: Jean-Daniel Cryans 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon 
Gerrit-HasComments: Yes

[kudu-CR](branch-1.3.x) KUDU-1708. Document Kudu command-line tools

Dan Burkert has posted comments on this change.

Change subject: KUDU-1708. Document Kudu command-line tools
..


Patch Set 2:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/6645/2/src/kudu/tools/tool_action.cc
File src/kudu/tools/tool_action.cc:

PS2, Line 174: string Mode::BuildHelpXML(const vector& chain) const {
 :   string xml;
 :   xml += "";
 :   xml += Substitute("$0", name());
 :   xml += Substitute("$0",
 : EscapeForHtmlToString(description()));
 :   for (const auto& a : actions()) {
 : xml += a->BuildHelpXML(chain);
 :   }
 : 
 :   for (const auto& m : modes()) {
 : vector m_chain(chain);
 : m_chain.push_back(m.get());
 : xml += m->BuildHelpXML(m_chain);
 :   }
 :   xml += "";
 :   return xml;
> Is it possible to use libxo library https://github.com/Juniper/libxo for th
This is just a backport, so if we were to do that it would need to be in a new 
commit.


-- 
To view, visit http://gerrit.cloudera.org:8080/6645
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9f484f772cbaeb385687d83a2665ae4d7292aaf5
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: branch-1.3.x
Gerrit-Owner: Dan Burkert 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: Dan Burkert 
Gerrit-Reviewer: Grant Henke 
Gerrit-Reviewer: Jean-Daniel Cryans 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon 
Gerrit-HasComments: Yes

[kudu-CR](branch-1.3.x) KUDU-1708. Document Kudu command-line tools

Alexey Serbin has posted comments on this change.

Change subject: KUDU-1708. Document Kudu command-line tools
..


Patch Set 2:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/6645/2/src/kudu/tools/tool_action.cc
File src/kudu/tools/tool_action.cc:

PS2, Line 174: string Mode::BuildHelpXML(const vector& chain) const {
 :   string xml;
 :   xml += "";
 :   xml += Substitute("$0", name());
 :   xml += Substitute("$0",
 : EscapeForHtmlToString(description()));
 :   for (const auto& a : actions()) {
 : xml += a->BuildHelpXML(chain);
 :   }
 : 
 :   for (const auto& m : modes()) {
 : vector m_chain(chain);
 : m_chain.push_back(m.get());
 : xml += m->BuildHelpXML(m_chain);
 :   }
 :   xml += "";
 :   return xml;
Is it possible to use libxo library https://github.com/Juniper/libxo for that 
instead of building that manually?

Doing so would automatically add support for JSON and HTML output.


-- 
To view, visit http://gerrit.cloudera.org:8080/6645
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9f484f772cbaeb385687d83a2665ae4d7292aaf5
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: branch-1.3.x
Gerrit-Owner: Dan Burkert 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: Grant Henke 
Gerrit-Reviewer: Jean-Daniel Cryans 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon 
Gerrit-HasComments: Yes

[kudu-CR](branch-1.3.x) [docs] Add admin workflow for recovering from disk failure

2017-04-18 Thread Hao Hao (Code Review)

Hao Hao has posted comments on this change.

Change subject: [docs] Add admin workflow for recovering from disk failure
..


Patch Set 1: Code-Review+1

(1 comment)

http://gerrit.cloudera.org:8080/#/c/6677/1/docs/administration.adoc
File docs/administration.adoc:

Line 590: === Recovering from Disk Failure
Do we have an jira for rebalancing tool now? Or it is covered in KUDU-616?


-- 
To view, visit http://gerrit.cloudera.org:8080/6677
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I6541bffc5e9546c523df610fd8c025dd05e403bf
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: branch-1.3.x
Gerrit-Owner: Dan Burkert 
Gerrit-Reviewer: Hao Hao 
Gerrit-Reviewer: Jean-Daniel Cryans 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon 
Gerrit-HasComments: Yes

[kudu-CR](branch-1.3.x) [docs] Add admin workflow for recovering from disk failure

Dan Burkert has uploaded a new change for review.

  http://gerrit.cloudera.org:8080/6677

Change subject: [docs] Add admin workflow for recovering from disk failure
..

[docs] Add admin workflow for recovering from disk failure

I didn't document how to rebalance tablets onto the repaired tserver if
necessary, since the process is complicated and error prone, and we hope
to have a rebalancing tool in the future. These docs will quickly become
outdated when KUDU-616 is fixed, but I think it's worth it to document
since we frequently receive questions on the topic.

Change-Id: I6541bffc5e9546c523df610fd8c025dd05e403bf
Reviewed-on: http://gerrit.cloudera.org:8080/6606
Tested-by: Kudu Jenkins
Reviewed-by: Adar Dembo 
Reviewed-by: Andrew Wong 
(cherry picked from commit 87154f4a39c77ab92d80f3effa58de3000921127)
---
M docs/administration.adoc
1 file changed, 35 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/77/6677/1
-- 
To view, visit http://gerrit.cloudera.org:8080/6677
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I6541bffc5e9546c523df610fd8c025dd05e403bf
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: branch-1.3.x
Gerrit-Owner: Dan Burkert

[kudu-CR] log-test: Add additional assert

Alexey Serbin has posted comments on this change.

Change subject: log-test: Add additional assert
..


Patch Set 1:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/6674/1/src/kudu/consensus/log-test.cc
File src/kudu/consensus/log-test.cc:

PS1, Line 1020: INT32_MAX
nit: why not to use std::numeric_limits::max() here as well (as it's 
already for assigning first_log_index it's initial value)?


-- 
To view, visit http://gerrit.cloudera.org:8080/6674
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Idb4847cb3fa8d4600be8a9b1b681613046988018
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Mike Percy 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: Jean-Daniel Cryans 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: Yes

[kudu-CR] Revert "gutil: stop supporting AMD Opteron K8"

Adar Dembo has posted comments on this change.

Change subject: Revert "gutil: stop supporting AMD Opteron K8"
..


Patch Set 1: Code-Review+2

I presume you'll try to figure out what went wrong and resubmit though, right?

-- 
To view, visit http://gerrit.cloudera.org:8080/6676
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I898fe74cf80b0f91f1c88700572b07e131227901
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: No

[kudu-CR] Revert "gutil: stop supporting AMD Opteron K8"

Adar Dembo has submitted this change and it was merged.

Change subject: Revert "gutil: stop supporting AMD Opteron K8"
..


Revert "gutil: stop supporting AMD Opteron K8"

This reverts commit b5004e1886eb96839ec120da582f0a06ce869db2.

This change broke the release build on el6:

../../../lib/libgutil.a(atomicops-internals-x86.cc.o): In function 
`AtomicOps_x86CPUFeaturesInit()':
:122: multiple definition of 
`AtomicOps_Internalx86CPUFeatures'
../../../../../thirdparty/installed/uninstrumented/lib64/libtcmalloc.a(atomicops-internals-x86.o):(.bss+0x0):
 first defined here
/opt/rh/devtoolset-3/root/usr/libexec/gcc/x86_64-redhat-linux/4.9.2/ld: 
Warning: size of symbol `AtomicOps_Internalx86CPUFeatures' changed from 3 in 
../../../../../thirdparty/installed/uninstrumented/lib64/libtcmalloc.a(atomicops-internals-x86.o)
 to 2 in ../../../lib/libgutil.a(atomicops-internals-x86.cc.o)

Change-Id: I898fe74cf80b0f91f1c88700572b07e131227901
Reviewed-on: http://gerrit.cloudera.org:8080/6676
Tested-by: Kudu Jenkins
Reviewed-by: Adar Dembo 
---
M src/kudu/gutil/atomicops-internals-tsan.h
M src/kudu/gutil/atomicops-internals-x86.cc
M src/kudu/gutil/atomicops-internals-x86.h
M src/kudu/util/init.cc
4 files changed, 35 insertions(+), 11 deletions(-)

Approvals:
  Adar Dembo: Looks good to me, approved
  Kudu Jenkins: Verified



-- 
To view, visit http://gerrit.cloudera.org:8080/6676
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I898fe74cf80b0f91f1c88700572b07e131227901
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Kudu Jenkins

[kudu-CR] Allow to pad UNIXTIME MICROS slots in scan results

2017-04-18 Thread David Ribeiro Alves (Code Review)

David Ribeiro Alves has posted comments on this change.

Change subject: Allow to pad UNIXTIME_MICROS slots in scan results
..


Patch Set 8:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/6623/8/src/kudu/common/wire_protocol.h
File src/kudu/common/wire_protocol.h:

Line 130: void SerializeRowBlock(const RowBlock& block, RowwiseRowBlockPB* 
rowblock_pb,
> warning: function 'kudu::SerializeRowBlock' has a definition with different
Done


-- 
To view, visit http://gerrit.cloudera.org:8080/6623
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I99fc6d3be089d19ebe2e70c938f2405c381578b4
Gerrit-PatchSet: 8
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: David Ribeiro Alves 
Gerrit-Reviewer: Andrew Wong 
Gerrit-Reviewer: David Ribeiro Alves 
Gerrit-Reviewer: Jean-Daniel Cryans 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Matthew Jacobs 
Gerrit-Reviewer: Tidy Bot
Gerrit-Reviewer: Todd Lipcon 
Gerrit-HasComments: Yes

[kudu-CR] Allow to pad UNIXTIME MICROS slots in scan results

2017-04-18 Thread David Ribeiro Alves (Code Review)

Hello Kudu Jenkins,

I'd like you to reexamine a change.  Please visit

http://gerrit.cloudera.org:8080/6623

to look at the new patch set (#9).

Change subject: Allow to pad UNIXTIME_MICROS slots in scan results
..

Allow to pad UNIXTIME_MICROS slots in scan results

This changes the wire protocol to, upon request, pad
the slots that contain values for UNIXTIME_MICROS columns
by 8 bytes. This allows Impala to adopt the result of a
Kudu scan as a whole while still having space to transform
UNIXTIME_MICROS values, which occupy 8 bytes, to the Impala
representation of timestamp, which occupies 16, in place
and without copying memory.

This patch doesn't include any de-serialization logic
the reasoning being that Impala will have knowledge of
the data format in order to perform de-serialization
directly on the "raw" direct and indirect data.

This patch doesn't introduce any branching in the
serialization patch. It does move the memset() call
that was performed once per nullable column, per row,
to be performed on the whole block instead. While less
cache friendly, this is also executed less times. The
net gain is not significant, but it does not regress
in the normal case.

Results of running the wire_protocol-test benchmark
in slow mode:

Before (avg 3 runs): 3.076
After  (avg 3 runs): 3.000

The difference is around -2%, which might be in the noise
but demostrates no significant regression.

Change-Id: I99fc6d3be089d19ebe2e70c938f2405c381578b4
---
M src/kudu/common/wire_protocol-test.cc
M src/kudu/common/wire_protocol.cc
M src/kudu/common/wire_protocol.h
3 files changed, 199 insertions(+), 48 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/23/6623/9
-- 
To view, visit http://gerrit.cloudera.org:8080/6623
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I99fc6d3be089d19ebe2e70c938f2405c381578b4
Gerrit-PatchSet: 9
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: David Ribeiro Alves 
Gerrit-Reviewer: Andrew Wong 
Gerrit-Reviewer: David Ribeiro Alves 
Gerrit-Reviewer: Jean-Daniel Cryans 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Matthew Jacobs 
Gerrit-Reviewer: Tidy Bot
Gerrit-Reviewer: Todd Lipcon

[kudu-CR](branch-1.3.x) [docs] Add security guide

Jean-Daniel Cryans has submitted this change and it was merged.

Change subject: [docs] Add security guide
..


[docs] Add security guide

Change-Id: Iabf60804975dc105243626be48d3a141c9a4dab5
Reviewed-on: http://gerrit.cloudera.org:8080/6479
Tested-by: Kudu Jenkins
Reviewed-by: Todd Lipcon 
(cherry picked from commit d5ac00c792616a6935e9786dd0183b33b3e6dfc9)
Reviewed-on: http://gerrit.cloudera.org:8080/6647
Reviewed-by: Jean-Daniel Cryans 
---
A docs/security.adoc
1 file changed, 243 insertions(+), 0 deletions(-)

Approvals:
  Jean-Daniel Cryans: Looks good to me, approved
  Todd Lipcon: Looks good to me, approved
  Kudu Jenkins: Verified



-- 
To view, visit http://gerrit.cloudera.org:8080/6647
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Iabf60804975dc105243626be48d3a141c9a4dab5
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: branch-1.3.x
Gerrit-Owner: Dan Burkert 
Gerrit-Reviewer: Jean-Daniel Cryans 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon

[kudu-CR](branch-1.3.x) [docs] Add security guide

Jean-Daniel Cryans has posted comments on this change.

Change subject: [docs] Add security guide
..


Patch Set 1: Code-Review+2

-- 
To view, visit http://gerrit.cloudera.org:8080/6647
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iabf60804975dc105243626be48d3a141c9a4dab5
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: branch-1.3.x
Gerrit-Owner: Dan Burkert 
Gerrit-Reviewer: Jean-Daniel Cryans 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon 
Gerrit-HasComments: No

[kudu-CR](branch-1.3.x) Add ksck section to admin guide common workflows

Jean-Daniel Cryans has submitted this change and it was merged.

Change subject: Add ksck section to admin guide common workflows
..


Add ksck section to admin guide common workflows

I've often wanted this when helping people through ksck.

Change-Id: I9631337b113d2c67be0057f728c68f792e8a4fd6
Reviewed-on: http://gerrit.cloudera.org:8080/6598
Reviewed-by: Adar Dembo 
Tested-by: Kudu Jenkins
(cherry picked from commit 9d03677e45dfa5722d816645200071e4d78fb845)
Reviewed-on: http://gerrit.cloudera.org:8080/6646
Reviewed-by: Todd Lipcon 
Reviewed-by: Jean-Daniel Cryans 
---
M docs/administration.adoc
1 file changed, 70 insertions(+), 4 deletions(-)

Approvals:
  Jean-Daniel Cryans: Looks good to me, approved
  Todd Lipcon: Looks good to me, approved
  Kudu Jenkins: Verified



-- 
To view, visit http://gerrit.cloudera.org:8080/6646
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I9631337b113d2c67be0057f728c68f792e8a4fd6
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: branch-1.3.x
Gerrit-Owner: Dan Burkert 
Gerrit-Reviewer: Jean-Daniel Cryans 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon

[kudu-CR](branch-1.3.x) Add ksck section to admin guide common workflows

Jean-Daniel Cryans has posted comments on this change.

Change subject: Add ksck section to admin guide common workflows
..


Patch Set 1: Code-Review+2

-- 
To view, visit http://gerrit.cloudera.org:8080/6646
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9631337b113d2c67be0057f728c68f792e8a4fd6
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: branch-1.3.x
Gerrit-Owner: Dan Burkert 
Gerrit-Reviewer: Jean-Daniel Cryans 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon 
Gerrit-HasComments: No

[kudu-CR](branch-1.3.x) docs: Fix axis lable for hash-range-partitioning

Jean-Daniel Cryans has submitted this change and it was merged.

Change subject: docs: Fix axis lable for hash-range-partitioning
..


docs: Fix axis lable for hash-range-partitioning

Horizontal axis label should show range partition by time according to the 
example not (host, metric)

Change-Id: I619d2082941de257cee4270079b46116944c77a6
Reviewed-on: http://gerrit.cloudera.org:8080/6532
Reviewed-by: Dan Burkert 
Tested-by: Dan Burkert 
(cherry picked from commit 7206041f937f6c1dbd515e7cff4cd006573dc7d5)
Reviewed-on: http://gerrit.cloudera.org:8080/6644
Tested-by: Kudu Jenkins
Reviewed-by: Todd Lipcon 
Reviewed-by: Jean-Daniel Cryans 
---
M docs/images/hash-range-partitioning-example.png
M docs/media-src/schema_design.graffle
2 files changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Jean-Daniel Cryans: Looks good to me, approved
  Todd Lipcon: Looks good to me, approved
  Kudu Jenkins: Verified



-- 
To view, visit http://gerrit.cloudera.org:8080/6644
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I619d2082941de257cee4270079b46116944c77a6
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: branch-1.3.x
Gerrit-Owner: Dan Burkert 
Gerrit-Reviewer: Jean-Daniel Cryans 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon 
Gerrit-Reviewer: t...@phdata.io

[kudu-CR](branch-1.3.x) docs: Fix axis lable for hash-range-partitioning

Jean-Daniel Cryans has posted comments on this change.

Change subject: docs: Fix axis lable for hash-range-partitioning
..


Patch Set 1: Code-Review+2

-- 
To view, visit http://gerrit.cloudera.org:8080/6644
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I619d2082941de257cee4270079b46116944c77a6
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: branch-1.3.x
Gerrit-Owner: Dan Burkert 
Gerrit-Reviewer: Jean-Daniel Cryans 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon 
Gerrit-Reviewer: t...@phdata.io
Gerrit-HasComments: No

[kudu-CR](branch-1.3.x) docs: Fix "make site"

Jean-Daniel Cryans has submitted this change and it was merged.

Change subject: docs: Fix "make site"
..


docs: Fix "make site"

* "make site" was broken due to changed command-line argments on
  "docs/support/scripts/make_site.sh". This patch fixes that
  discrepancy.

* Also, assume the "apache" remote exists for the site build. That
  assumption is consistent with the "build-support/push_to_asf.py"
  script.

Change-Id: I9050eec37ea6b5b4917a4c8269de4178c3c14cb2
Reviewed-on: http://gerrit.cloudera.org:8080/6488
Tested-by: Kudu Jenkins
Reviewed-by: Todd Lipcon 
(cherry picked from commit b719b1e7c7e2a78f8e818a9c8275b5d030835811)
Reviewed-on: http://gerrit.cloudera.org:8080/6643
Reviewed-by: Mike Percy 
---
M CMakeLists.txt
M docs/support/scripts/make_site.sh
2 files changed, 4 insertions(+), 4 deletions(-)

Approvals:
  Mike Percy: Looks good to me, approved
  Todd Lipcon: Looks good to me, approved
  Kudu Jenkins: Verified



-- 
To view, visit http://gerrit.cloudera.org:8080/6643
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I9050eec37ea6b5b4917a4c8269de4178c3c14cb2
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: branch-1.3.x
Gerrit-Owner: Dan Burkert 
Gerrit-Reviewer: Jean-Daniel Cryans 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy 
Gerrit-Reviewer: Todd Lipcon

[kudu-CR](branch-1.2.x) KUDU-1933. consensus: Avoid and repair integer overflow in log index

Jean-Daniel Cryans has posted comments on this change.

Change subject: KUDU-1933. consensus: Avoid and repair integer overflow in log 
index
..


Patch Set 3: Code-Review+2

-- 
To view, visit http://gerrit.cloudera.org:8080/6660
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I284edbde51dc50fb2f98acc83cdcc3891d37863f
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: branch-1.2.x
Gerrit-Owner: Mike Percy 
Gerrit-Reviewer: David Ribeiro Alves 
Gerrit-Reviewer: Jean-Daniel Cryans 
Gerrit-Reviewer: Mike Percy 
Gerrit-HasComments: No

[kudu-CR](branch-1.2.x) KUDU-1933. consensus: Avoid and repair integer overflow in log index

Jean-Daniel Cryans has submitted this change and it was merged.

Change subject: KUDU-1933. consensus: Avoid and repair integer overflow in log 
index
..


KUDU-1933. consensus: Avoid and repair integer overflow in log index

We observed a crash on a long-running master server that looked like the
following:

  F0308 00:25:53.568773  7655 log_index.cc:171] Check failed: log_index > 0 
(-2147483648 vs. 0)

It turns out that this was caused due to integer overflow on the log
index field. This patch fixes this type of truncation in a couple of
places (LogReader and MakeOpId()) and adds a couple of new tests that
fail without both of those fixes.

This patch also adds "repair" logic in log replay during tablet
bootstrap that "reverts" integer overflow when it is detected while
rewriting the log entry.

Finally, this patch includes some test helper fixes to avoid log index
integer truncation in future tests.

This backport was modified from the original patch by changing the class
name of the regression test in log-test.cc to LogTest, which is the only
test class available in the 1.2.x code line.

Change-Id: I284edbde51dc50fb2f98acc83cdcc3891d37863f
Reviewed-on: http://gerrit.cloudera.org:8080/6376
Tested-by: Kudu Jenkins
Reviewed-by: David Ribeiro Alves 
(cherry picked from commit 8363b74506f8513e2fa9dbf772e30d0abce4e444)
Reviewed-on: http://gerrit.cloudera.org:8080/6660
Tested-by: Mike Percy 
Reviewed-by: Jean-Daniel Cryans 
---
M src/kudu/consensus/consensus-test-util.h
M src/kudu/consensus/log-test-base.h
M src/kudu/consensus/log-test.cc
M src/kudu/consensus/log_cache-test.cc
M src/kudu/consensus/log_reader.cc
M src/kudu/consensus/log_reader.h
M src/kudu/consensus/opid_util.cc
M src/kudu/consensus/opid_util.h
M src/kudu/integration-tests/ts_recovery-itest.cc
M src/kudu/tablet/tablet_bootstrap-test.cc
M src/kudu/tablet/tablet_bootstrap.cc
11 files changed, 237 insertions(+), 27 deletions(-)

Approvals:
  Jean-Daniel Cryans: Looks good to me, approved
  Mike Percy: Verified



-- 
To view, visit http://gerrit.cloudera.org:8080/6660
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I284edbde51dc50fb2f98acc83cdcc3891d37863f
Gerrit-PatchSet: 4
Gerrit-Project: kudu
Gerrit-Branch: branch-1.2.x
Gerrit-Owner: Mike Percy 
Gerrit-Reviewer: David Ribeiro Alves 
Gerrit-Reviewer: Jean-Daniel Cryans 
Gerrit-Reviewer: Mike Percy

[kudu-CR](branch-1.2.x) KUDU-1607. Unpin tablet flush after failed bootstrap

Jean-Daniel Cryans has posted comments on this change.

Change subject: KUDU-1607. Unpin tablet flush after failed bootstrap
..


Patch Set 3: Code-Review+2

(1 comment)

http://gerrit.cloudera.org:8080/#/c/6572/3//COMMIT_MSG
Commit Message:

Line 35: Note: This backport has been modified not to rely on KUDU-1741.
Cool, thanks!


-- 
To view, visit http://gerrit.cloudera.org:8080/6572
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id274c6ee1da75bc6f92ab91c0a01edaa009b8962
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: branch-1.2.x
Gerrit-Owner: Jean-Daniel Cryans 
Gerrit-Reviewer: David Ribeiro Alves 
Gerrit-Reviewer: Jean-Daniel Cryans 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy 
Gerrit-HasComments: Yes

[kudu-CR](branch-1.2.x) KUDU-1607. Unpin tablet flush after failed bootstrap

Jean-Daniel Cryans has submitted this change and it was merged.

Change subject: KUDU-1607. Unpin tablet flush after failed bootstrap
..


KUDU-1607. Unpin tablet flush after failed bootstrap

We have heard reports that, in certain scenarios, a failed tablet is
unable to be deleted. After some investigation, I determined that this
is because we neglect to unpin the Tablet when tablet bootstrap fails.

When a table is being deleted, we delete each tablet superblock by
calling TabletMetadata::DeleteSuperBlock(). This method double-checks
that no orphaned blocks remain referenced to ensure we don't leak disk
space. That requires TabletMetadata::DeleteTabletData() to be called
first, which invokes Flush() twice to ensure that no orphaned blocks are
referenced on disk upon returning. However, if the tablet is pinned,
Flush() silently becomes a no-op (except for a log message that is
printed) and so DeleteSuperBlock() also fails, resulting in the tablet
not being fully deleted and the following warning message being written
to the log file:

W0317 13:05:19.324373 13242 ts_tablet_manager.cc:634] Invalid argument: Unable 
to delete on-disk data from tablet d1b857ddaa0743c79c9bcbd9b2fda174: The 
metadata for tablet d1b857ddaa0743c79c9bcbd9b2fda174 still references orphaned 
blocks. Call DeleteTabletData() first

This patch makes the following changes:

1. Always unpin the tablet after pinning it.
2. Add a new itest that fails without that change, reproducing the
   above warning message.
3. Add a little more test infra to MiniCluster (and the MiniClusterBase
   interface) to make it easier to use the helper functions in
   cluster_itest_util.h in MiniCluster-based itests.

Note: This backport has been modified not to rely on KUDU-1741.

Change-Id: Id274c6ee1da75bc6f92ab91c0a01edaa009b8962
Reviewed-on: http://gerrit.cloudera.org:8080/6422
Tested-by: Kudu Jenkins
Reviewed-by: David Ribeiro Alves 
(cherry picked from commit 0450f77f69c74cc6dec08ad36bb89ac12c17608f)
Reviewed-on: http://gerrit.cloudera.org:8080/6572
Reviewed-by: Jean-Daniel Cryans 
---
M src/kudu/integration-tests/CMakeLists.txt
A src/kudu/integration-tests/delete_tablet-itest.cc
M src/kudu/integration-tests/external_mini_cluster.cc
M src/kudu/integration-tests/external_mini_cluster.h
M src/kudu/integration-tests/mini_cluster.cc
M src/kudu/integration-tests/mini_cluster.h
M src/kudu/integration-tests/mini_cluster_base.h
M src/kudu/tablet/tablet_bootstrap.cc
M src/kudu/tserver/mini_tablet_server.cc
M src/kudu/tserver/mini_tablet_server.h
10 files changed, 224 insertions(+), 48 deletions(-)

Approvals:
  Jean-Daniel Cryans: Looks good to me, approved
  Kudu Jenkins: Verified



-- 
To view, visit http://gerrit.cloudera.org:8080/6572
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Id274c6ee1da75bc6f92ab91c0a01edaa009b8962
Gerrit-PatchSet: 4
Gerrit-Project: kudu
Gerrit-Branch: branch-1.2.x
Gerrit-Owner: Jean-Daniel Cryans 
Gerrit-Reviewer: David Ribeiro Alves 
Gerrit-Reviewer: Jean-Daniel Cryans 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy

[kudu-CR](branch-1.3.x) Bump version to 1.3.2-SNAPSHOT

Jean-Daniel Cryans has submitted this change and it was merged.

Change subject: Bump version to 1.3.2-SNAPSHOT
..


Bump version to 1.3.2-SNAPSHOT

Change-Id: Ie4c48aa6ec08a40500d85a1a53ccb48b64d2d4ef
Reviewed-on: http://gerrit.cloudera.org:8080/6669
Tested-by: Kudu Jenkins
Reviewed-by: Todd Lipcon 
---
M java/interface-annotations/pom.xml
M java/kudu-client-tools/pom.xml
M java/kudu-client/pom.xml
M java/kudu-flume-sink/pom.xml
M java/kudu-jepsen/pom.xml
M java/kudu-mapreduce/pom.xml
M java/kudu-spark/pom.xml
M java/pom.xml
M python/setup.py
M version.txt
10 files changed, 11 insertions(+), 11 deletions(-)

Approvals:
  Todd Lipcon: Looks good to me, approved
  Kudu Jenkins: Verified



-- 
To view, visit http://gerrit.cloudera.org:8080/6669
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ie4c48aa6ec08a40500d85a1a53ccb48b64d2d4ef
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: branch-1.3.x
Gerrit-Owner: Jean-Daniel Cryans 
Gerrit-Reviewer: Jean-Daniel Cryans 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon

[kudu-CR] Revert "gutil: stop supporting AMD Opteron K8"

Hello Adar Dembo,

I'd like you to do a code review.  Please visit

http://gerrit.cloudera.org:8080/6676

to review the following change.

Change subject: Revert "gutil: stop supporting AMD Opteron K8"
..

Revert "gutil: stop supporting AMD Opteron K8"

This reverts commit b5004e1886eb96839ec120da582f0a06ce869db2.

This change broke the release build on el6:

../../../lib/libgutil.a(atomicops-internals-x86.cc.o): In function 
`AtomicOps_x86CPUFeaturesInit()':
:122: multiple definition of 
`AtomicOps_Internalx86CPUFeatures'
../../../../../thirdparty/installed/uninstrumented/lib64/libtcmalloc.a(atomicops-internals-x86.o):(.bss+0x0):
 first defined here
/opt/rh/devtoolset-3/root/usr/libexec/gcc/x86_64-redhat-linux/4.9.2/ld: 
Warning: size of symbol `AtomicOps_Internalx86CPUFeatures' changed from 3 in 
../../../../../thirdparty/installed/uninstrumented/lib64/libtcmalloc.a(atomicops-internals-x86.o)
 to 2 in ../../../lib/libgutil.a(atomicops-internals-x86.cc.o)

Change-Id: I898fe74cf80b0f91f1c88700572b07e131227901
---
M src/kudu/gutil/atomicops-internals-tsan.h
M src/kudu/gutil/atomicops-internals-x86.cc
M src/kudu/gutil/atomicops-internals-x86.h
M src/kudu/util/init.cc
4 files changed, 35 insertions(+), 11 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/76/6676/1
-- 
To view, visit http://gerrit.cloudera.org:8080/6676
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I898fe74cf80b0f91f1c88700572b07e131227901
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon 
Gerrit-Reviewer: Adar Dembo

[kudu-CR] [cmake] fixed 'latest' dir symlink on MacOS X

Adar Dembo has posted comments on this change.

Change subject: [cmake] fixed 'latest' dir symlink on MacOS X
..


Patch Set 2: Code-Review+2

-- 
To view, visit http://gerrit.cloudera.org:8080/6667
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ica6314eb5274e853b7b39b7e6ede17305d0c646d
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: Dan Burkert 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: No

[kudu-CR] [rpc] handling ERROR UNAVAILABLE RPC error

Dan Burkert has posted comments on this change.

Change subject: [rpc] handling ERROR_UNAVAILABLE RPC error
..


Patch Set 4:

(5 comments)

http://gerrit.cloudera.org:8080/#/c/6640/4/src/kudu/integration-tests/security-unknown-tsk-itest.cc
File src/kudu/integration-tests/security-unknown-tsk-itest.cc:

Line 50: //DECLARE_int32(heartbeat_rpc_timeout_ms);
remove these?


PS4, Line 83: torun
typo


Line 128:   ASSERT_NE(boost::none, authn_token);
I think this can be simplified to

ASSERT(authn_token);


Line 152:   ASSERT_OK(table_creator->table_name(kTableName)
When I initially read this, I got confused because I expected this to fail due 
to the invalid token, then I remembered that the master connection is probably 
already cached.  Is that right?  You may want to create the table before 
switching out the token just for clarity.


Line 174:   auto cleanup = MakeScopedCleanup([&]() {
Might be simpler to use ElementDeleter from stl_util.h


-- 
To view, visit http://gerrit.cloudera.org:8080/6640
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I87d780a4ad88c15ceaacfddf6c1b69ed053bb959
Gerrit-PatchSet: 4
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: Dan Burkert 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Tidy Bot
Gerrit-Reviewer: Todd Lipcon 
Gerrit-HasComments: Yes

[kudu-CR] [cmake] fixed 'latest' dir symlink on MacOS X

Dan Burkert has posted comments on this change.

Change subject: [cmake] fixed 'latest' dir symlink on MacOS X
..


Patch Set 2: Code-Review+1

-- 
To view, visit http://gerrit.cloudera.org:8080/6667
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ica6314eb5274e853b7b39b7e6ede17305d0c646d
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: Dan Burkert 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: No

[kudu-CR] [cmake] fixed 'latest' dir symlink on MacOS X

Hello Adar Dembo, Kudu Jenkins,

I'd like you to reexamine a change.  Please visit

http://gerrit.cloudera.org:8080/6667

to look at the new patch set (#2).

Change subject: [cmake] fixed 'latest' dir symlink on MacOS X
..

[cmake] fixed 'latest' dir symlink on MacOS X

If the 'latest' symbolic link already exists, do not follow it, so the
'latest' link is updated to point to the new src directory.  Prior to
this, the result symlink on OS X would be created in the directory
which the 'latest' points at.

The fix is in replacing Linux-specific '-T' option with '-n' option
which is compatible at least between BSD-style and Linux ln
implementations and adding that '-n' flag regardless of the platform.

Change-Id: Ica6314eb5274e853b7b39b7e6ede17305d0c646d
---
M CMakeLists.txt
1 file changed, 2 insertions(+), 6 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/67/6667/2
-- 
To view, visit http://gerrit.cloudera.org:8080/6667
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ica6314eb5274e853b7b39b7e6ede17305d0c646d
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: Dan Burkert 
Gerrit-Reviewer: Kudu Jenkins

[kudu-CR] log-test: Add additional assert

Hello Jean-Daniel Cryans,

I'd like you to do a code review.  Please visit

http://gerrit.cloudera.org:8080/6674

to review the following change.

Change subject: log-test: Add additional assert
..

log-test: Add additional assert

This just adds an additional check which is nice to have in this test.
This was added in a backport to the 1.2.x branch and so is also being
added here.

Change-Id: Idb4847cb3fa8d4600be8a9b1b681613046988018
---
M src/kudu/consensus/log-test.cc
1 file changed, 1 insertion(+), 0 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/74/6674/1
-- 
To view, visit http://gerrit.cloudera.org:8080/6674
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Idb4847cb3fa8d4600be8a9b1b681613046988018
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Mike Percy 
Gerrit-Reviewer: Jean-Daniel Cryans

[kudu-CR] [cmake] fixed 'latest' dir symlink on MacOS X

Alexey Serbin has posted comments on this change.

Change subject: [cmake] fixed 'latest' dir symlink on MacOS X
..


Patch Set 1:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/6667/1//COMMIT_MSG
Commit Message:

PS1, Line 9: If the 'latest' symbolic link already exists, do not follow it, so 
the
   : 'latest' link is updated to point to the new src directory.  Prior 
to
   : this fix, the result symlink would be created in the directory 
which
   : the 'latest' points at.
> Just to clarify, this part was only true for macOS, right?
Exactly -- prior to this fix that I observed the issue only on MacOS X.

If you want, I can update this to add that note.  I thought it's more or less 
obvious from the context, though.


PS1, Line 14: Also, replaced Linux-specific '-T' option with '-n' option which 
is
: compatible at least between BSD-style and Linux ln 
implementations.
> Hmm, ISTR someone doing this in the past but it not working for some reason
I did -- it worked for me at ve0518.halxg.cloudera.com


-- 
To view, visit http://gerrit.cloudera.org:8080/6667
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ica6314eb5274e853b7b39b7e6ede17305d0c646d
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: Dan Burkert 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: Yes

[kudu-CR](branch-1.3.x) Bump version to 1.3.2-SNAPSHOT

Todd Lipcon has posted comments on this change.

Change subject: Bump version to 1.3.2-SNAPSHOT
..


Patch Set 1: Code-Review+2

-- 
To view, visit http://gerrit.cloudera.org:8080/6669
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ie4c48aa6ec08a40500d85a1a53ccb48b64d2d4ef
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: branch-1.3.x
Gerrit-Owner: Jean-Daniel Cryans 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon 
Gerrit-HasComments: No

[kudu-CR](branch-1.2.x) KUDU-1933. consensus: Avoid and repair integer overflow in log index

Mike Percy has posted comments on this change.

Change subject: KUDU-1933. consensus: Avoid and repair integer overflow in log 
index
..


Patch Set 3: Verified+1

delete_table-test failed due to a known flaky that exists on master.

-- 
To view, visit http://gerrit.cloudera.org:8080/6660
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I284edbde51dc50fb2f98acc83cdcc3891d37863f
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: branch-1.2.x
Gerrit-Owner: Mike Percy 
Gerrit-Reviewer: David Ribeiro Alves 
Gerrit-Reviewer: Jean-Daniel Cryans 
Gerrit-Reviewer: Mike Percy 
Gerrit-HasComments: No

[kudu-CR] [rpc] Close socket on non-linux platforms during RPC shutdown

Alexey Serbin has abandoned this change.

Change subject: [rpc] Close socket on non-linux platforms during RPC shutdown
..


Abandoned

The issue has been fixed in another changelist (in the new approach the socket 
is closed after shutdown regardless of the platform): 
https://gerrit.cloudera.org/#/c/6665

-- 
To view, visit http://gerrit.cloudera.org:8080/4958
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: abandon
Gerrit-Change-Id: I1ed12bd5e4be5ee932196e77ce2f0ecd3810c992
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Dinesh Bhat 
Gerrit-Reviewer: Dan Burkert 
Gerrit-Reviewer: Dinesh Bhat 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy 
Gerrit-Reviewer: Todd Lipcon

[kudu-CR] [cmake] fixed 'latest' dir symlink on MacOS X

Adar Dembo has posted comments on this change.

Change subject: [cmake] fixed 'latest' dir symlink on MacOS X
..


Patch Set 1: Code-Review+2

-- 
To view, visit http://gerrit.cloudera.org:8080/6667
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ica6314eb5274e853b7b39b7e6ede17305d0c646d
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Dan Burkert 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: No

[kudu-CR] [cmake] fixed 'latest' dir symlink on MacOS X

Adar Dembo has posted comments on this change.

Change subject: [cmake] fixed 'latest' dir symlink on MacOS X
..


Patch Set 1:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/6667/1//COMMIT_MSG
Commit Message:

PS1, Line 9: If the 'latest' symbolic link already exists, do not follow it, so 
the
   : 'latest' link is updated to point to the new src directory.  Prior 
to
   : this fix, the result symlink would be created in the directory 
which
   : the 'latest' points at.
Just to clarify, this part was only true for macOS, right?


PS1, Line 14: Also, replaced Linux-specific '-T' option with '-n' option which 
is
: compatible at least between BSD-style and Linux ln 
implementations.
Hmm, ISTR someone doing this in the past but it not working for some reason. I 
scoured old gerrit patches but couldn't find it. 

Anyway, could you make sure it does the right thing even on an older el6 box?


-- 
To view, visit http://gerrit.cloudera.org:8080/6667
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ica6314eb5274e853b7b39b7e6ede17305d0c646d
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Dan Burkert 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: Yes

[kudu-CR] [rpc] close socket on AcceptorPool::Shutdown()

Alexey Serbin has posted comments on this change.

Change subject: [rpc] close socket on AcceptorPool::Shutdown()
..


Patch Set 2:

> Looks like Dinesh did the same thing back in 
> https://gerrit.cloudera.org/#/c/4958.
 > I wonder why that patch was never merged.

Oops, I missed that one, sorry.  Probably I should have updated it instead of 
creating a new one.

BTW, that patch did close only for MacOS X, not for Linux.  This does so 
regardless of platform.

-- 
To view, visit http://gerrit.cloudera.org:8080/6665
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ided3643b07e642beb586e51efa442b39b3785916
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: Dan Burkert 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon 
Gerrit-HasComments: No

[kudu-CR] [rpc] close socket on AcceptorPool::Shutdown()

Adar Dembo has posted comments on this change.

Change subject: [rpc] close socket on AcceptorPool::Shutdown()
..


Patch Set 2:

Looks like Dinesh did the same thing back in 
https://gerrit.cloudera.org/#/c/4958. I wonder why that patch was never merged.

-- 
To view, visit http://gerrit.cloudera.org:8080/6665
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ided3643b07e642beb586e51efa442b39b3785916
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: Dan Burkert 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon 
Gerrit-HasComments: No

[kudu-CR] Fix thirdparty build error in Centos 6.

Todd Lipcon has posted comments on this change.

Change subject: Fix thirdparty build error in Centos 6.
..


Patch Set 1: Code-Review+2

-- 
To view, visit http://gerrit.cloudera.org:8080/6673
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3c72d76f6c4f5db7eb03f3e5f7efb4d3f6bb1e74
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Amos Bird 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon 
Gerrit-HasComments: No

[kudu-CR] Fix thirdparty build error in Centos 6.

2017-04-18 Thread Amos Bird (Code Review)

Amos Bird has uploaded a new change for review.

  http://gerrit.cloudera.org:8080/6673

Change subject: Fix thirdparty build error in Centos 6.
..

Fix thirdparty build error in Centos 6.

When doing a fresh build in Centos 6, one might get errors like
this: libcurl.so: undefined reference to `libssh2_userauth_list'.
This patch fixes this error by building curl without libssh2.

Change-Id: I3c72d76f6c4f5db7eb03f3e5f7efb4d3f6bb1e74
---
M thirdparty/build-definitions.sh
1 file changed, 2 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/73/6673/1
-- 
To view, visit http://gerrit.cloudera.org:8080/6673
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I3c72d76f6c4f5db7eb03f3e5f7efb4d3f6bb1e74
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Amos Bird

[kudu-CR](branch-1.2.x) KUDU-1741: Keep MiniCluster::Restart consistent with ExternalMiniCluster::Restart

Mike Percy has abandoned this change.

Change subject: KUDU-1741: Keep MiniCluster::Restart consistent with 
ExternalMiniCluster::Restart
..


Abandoned

I removed the need to backport this patch.

-- 
To view, visit http://gerrit.cloudera.org:8080/6659
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: abandon
Gerrit-Change-Id: Iad33b7c46bfca3f277ccbca7d0420272f06a6633
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: branch-1.2.x
Gerrit-Owner: Mike Percy 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: Dinesh Bhat 
Gerrit-Reviewer: Jean-Daniel Cryans 
Gerrit-Reviewer: Kudu Jenkins

[kudu-CR] Slice::ToDebugString() - Add option to not ascii'ize

Todd Lipcon has posted comments on this change.

Change subject: Slice::ToDebugString() - Add option to not ascii'ize
..


Patch Set 1:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/6671/1//COMMIT_MSG
Commit Message:

Line 7: Slice::ToDebugString() - Add option to not ascii'ize
instead, would it be better to just use HexDump(slice) for this use case? Or 
maybe add a new method? I'm not too keen on adding optional parameters to such 
a commonly-used function.

This is also part of our public ABI so i'm not sure if we can modify the 
signature without breaking binary compat.


-- 
To view, visit http://gerrit.cloudera.org:8080/6671
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I15ed6f5e18fa20b3dca602c0a215980b97975d05
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: David Ribeiro Alves 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon 
Gerrit-HasComments: Yes

[kudu-CR](branch-1.2.x) KUDU-1607. Unpin tablet flush after failed bootstrap

Hello David Ribeiro Alves, Kudu Jenkins,

I'd like you to reexamine a change.  Please visit

http://gerrit.cloudera.org:8080/6572

to look at the new patch set (#3).

Change subject: KUDU-1607. Unpin tablet flush after failed bootstrap
..

KUDU-1607. Unpin tablet flush after failed bootstrap

We have heard reports that, in certain scenarios, a failed tablet is
unable to be deleted. After some investigation, I determined that this
is because we neglect to unpin the Tablet when tablet bootstrap fails.

When a table is being deleted, we delete each tablet superblock by
calling TabletMetadata::DeleteSuperBlock(). This method double-checks
that no orphaned blocks remain referenced to ensure we don't leak disk
space. That requires TabletMetadata::DeleteTabletData() to be called
first, which invokes Flush() twice to ensure that no orphaned blocks are
referenced on disk upon returning. However, if the tablet is pinned,
Flush() silently becomes a no-op (except for a log message that is
printed) and so DeleteSuperBlock() also fails, resulting in the tablet
not being fully deleted and the following warning message being written
to the log file:

W0317 13:05:19.324373 13242 ts_tablet_manager.cc:634] Invalid argument: Unable 
to delete on-disk data from tablet d1b857ddaa0743c79c9bcbd9b2fda174: The 
metadata for tablet d1b857ddaa0743c79c9bcbd9b2fda174 still references orphaned 
blocks. Call DeleteTabletData() first

This patch makes the following changes:

1. Always unpin the tablet after pinning it.
2. Add a new itest that fails without that change, reproducing the
   above warning message.
3. Add a little more test infra to MiniCluster (and the MiniClusterBase
   interface) to make it easier to use the helper functions in
   cluster_itest_util.h in MiniCluster-based itests.

Note: This backport has been modified not to rely on KUDU-1741.

Change-Id: Id274c6ee1da75bc6f92ab91c0a01edaa009b8962
Reviewed-on: http://gerrit.cloudera.org:8080/6422
Tested-by: Kudu Jenkins
Reviewed-by: David Ribeiro Alves 
(cherry picked from commit 0450f77f69c74cc6dec08ad36bb89ac12c17608f)
---
M src/kudu/integration-tests/CMakeLists.txt
A src/kudu/integration-tests/delete_tablet-itest.cc
M src/kudu/integration-tests/external_mini_cluster.cc
M src/kudu/integration-tests/external_mini_cluster.h
M src/kudu/integration-tests/mini_cluster.cc
M src/kudu/integration-tests/mini_cluster.h
M src/kudu/integration-tests/mini_cluster_base.h
M src/kudu/tablet/tablet_bootstrap.cc
M src/kudu/tserver/mini_tablet_server.cc
M src/kudu/tserver/mini_tablet_server.h
10 files changed, 224 insertions(+), 48 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/72/6572/3
-- 
To view, visit http://gerrit.cloudera.org:8080/6572
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Id274c6ee1da75bc6f92ab91c0a01edaa009b8962
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: branch-1.2.x
Gerrit-Owner: Jean-Daniel Cryans 
Gerrit-Reviewer: David Ribeiro Alves 
Gerrit-Reviewer: Jean-Daniel Cryans 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy

[kudu-CR] [rpc] close socket on AcceptorPool::Shutdown()

Todd Lipcon has posted comments on this change.

Change subject: [rpc] close socket on AcceptorPool::Shutdown()
..


Patch Set 1: Code-Review+2

-- 
To view, visit http://gerrit.cloudera.org:8080/6665
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ided3643b07e642beb586e51efa442b39b3785916
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Dan Burkert 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon 
Gerrit-HasComments: No

[kudu-CR] Slice::ToDebugString() - Add option to not ascii'ize

2017-04-18 Thread David Ribeiro Alves (Code Review)

David Ribeiro Alves has uploaded a new change for review.

  http://gerrit.cloudera.org:8080/6671

Change subject: Slice::ToDebugString() - Add option to not ascii'ize
..

Slice::ToDebugString() - Add option to not ascii'ize

This method prints bytes individually and always tries to find
a graphical representation of the byte, before outputting the raw
value. This is great when the slices are written messages but
not so good when slices point to raw data, in which case some
bytes will, by chance, correspond to well known ascii chars and
some won't.

To avoid this I've added a new argument, true by default, that when
set to false prevents the transformation and always prints the raw
bytes.

Change-Id: I15ed6f5e18fa20b3dca602c0a215980b97975d05
---
M src/kudu/util/slice-test.cc
M src/kudu/util/slice.cc
M src/kudu/util/slice.h
3 files changed, 9 insertions(+), 3 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/71/6671/1
-- 
To view, visit http://gerrit.cloudera.org:8080/6671
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I15ed6f5e18fa20b3dca602c0a215980b97975d05
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: David Ribeiro Alves

[kudu-CR] gutil: stop supporting AMD Opteron K8

Todd Lipcon has submitted this change and it was merged.

Change subject: gutil: stop supporting AMD Opteron K8
..


gutil: stop supporting AMD Opteron K8

This removes a workaround for a bug in very old (circa 2003) Opteron
chips. The workaround was producing an extra branch around most of our
atomic operations. This likely has a negligible perf impact, but it's
possible the slightly smaller code would make us run a bit faster or
reduce branch mispredictions.

This also adds a missing call to init the feature flags in the first
place, which we seem to have forgotten the first time around.

Impala made a similar change[1][2] a while back and seems to have had
no real issues.

[1] https://gerrit.cloudera.org/#/c/2516/
[2] 
https://github.com/apache/incubator-impala/commit/a7c3f301bb1da14d6bb35d37aab47450c67cca0c

Change-Id: I59b5aeaae56b5f310b5dd160b868fcb5d04f4da1
Reviewed-on: http://gerrit.cloudera.org:8080/6661
Reviewed-by: Adar Dembo 
Tested-by: Kudu Jenkins
---
M src/kudu/gutil/atomicops-internals-tsan.h
M src/kudu/gutil/atomicops-internals-x86.cc
M src/kudu/gutil/atomicops-internals-x86.h
M src/kudu/util/init.cc
4 files changed, 11 insertions(+), 35 deletions(-)

Approvals:
  Adar Dembo: Looks good to me, approved
  Kudu Jenkins: Verified



-- 
To view, visit http://gerrit.cloudera.org:8080/6661
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I59b5aeaae56b5f310b5dd160b868fcb5d04f4da1
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon

[kudu-CR](branch-1.2.x) KUDU-1933. consensus: Avoid and repair integer overflow in log index

Mike Percy has posted comments on this change.

Change subject: KUDU-1933. consensus: Avoid and repair integer overflow in log 
index
..


Patch Set 2:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/6660/2/src/kudu/consensus/log-test.cc
File src/kudu/consensus/log-test.cc:

Line 1005:   ASSERT_GT(op_id.index(), INT32_MAX);
> Should we have this in master too?
Sure, I'll submit a patch to add this to master.


-- 
To view, visit http://gerrit.cloudera.org:8080/6660
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I284edbde51dc50fb2f98acc83cdcc3891d37863f
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: branch-1.2.x
Gerrit-Owner: Mike Percy 
Gerrit-Reviewer: David Ribeiro Alves 
Gerrit-Reviewer: Jean-Daniel Cryans 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy 
Gerrit-HasComments: Yes

[kudu-CR] Allow to pad UNIXTIME MICROS slots in scan results

2017-04-18 Thread David Ribeiro Alves (Code Review)

David Ribeiro Alves has posted comments on this change.

Change subject: Allow to pad UNIXTIME_MICROS slots in scan results
..


Patch Set 8:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/6623/7/src/kudu/common/wire_protocol.h
File src/kudu/common/wire_protocol.h:

PS7, Line 130: const RowBlock& block, RowwiseRowBlockPB* r
> Do we need to add docs for this here if it's only being used by Impala?
Done


-- 
To view, visit http://gerrit.cloudera.org:8080/6623
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I99fc6d3be089d19ebe2e70c938f2405c381578b4
Gerrit-PatchSet: 8
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: David Ribeiro Alves 
Gerrit-Reviewer: Andrew Wong 
Gerrit-Reviewer: David Ribeiro Alves 
Gerrit-Reviewer: Jean-Daniel Cryans 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Matthew Jacobs 
Gerrit-Reviewer: Tidy Bot
Gerrit-Reviewer: Todd Lipcon 
Gerrit-HasComments: Yes

[kudu-CR] Allow to pad UNIXTIME MICROS slots in scan results

2017-04-18 Thread David Ribeiro Alves (Code Review)

Hello Kudu Jenkins,

I'd like you to reexamine a change.  Please visit

http://gerrit.cloudera.org:8080/6623

to look at the new patch set (#8).

Change subject: Allow to pad UNIXTIME_MICROS slots in scan results
..

Allow to pad UNIXTIME_MICROS slots in scan results

This changes the wire protocol to, upon request, pad
the slots that contain values for UNIXTIME_MICROS columns
by 8 bytes. This allows Impala to adopt the result of a
Kudu scan as a whole while still having space to transform
UNIXTIME_MICROS values, which occupy 8 bytes, to the Impala
representation of timestamp, which occupies 16, in place
and without copying memory.

This patch doesn't include any de-serialization logic
the reasoning being that Impala will have knowledge of
the data format in order to perform de-serialization
directly on the "raw" direct and indirect data.

This patch doesn't introduce any branching in the
serialization patch. It does move the memset() call
that was performed once per nullable column, per row,
to be performed on the whole block instead. While less
cache friendly, this is also executed less times. The
net gain is not significant, but it does not regress
in the normal case.

Results of running the wire_protocol-test benchmark
in slow mode:

Before (avg 3 runs): 3.076
After  (avg 3 runs): 3.000

The difference is around -2%, which might be in the noise
but demostrates no significant regression.

Change-Id: I99fc6d3be089d19ebe2e70c938f2405c381578b4
---
M src/kudu/common/wire_protocol-test.cc
M src/kudu/common/wire_protocol.cc
M src/kudu/common/wire_protocol.h
3 files changed, 199 insertions(+), 48 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/23/6623/8
-- 
To view, visit http://gerrit.cloudera.org:8080/6623
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I99fc6d3be089d19ebe2e70c938f2405c381578b4
Gerrit-PatchSet: 8
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: David Ribeiro Alves 
Gerrit-Reviewer: Andrew Wong 
Gerrit-Reviewer: David Ribeiro Alves 
Gerrit-Reviewer: Jean-Daniel Cryans 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Matthew Jacobs 
Gerrit-Reviewer: Tidy Bot
Gerrit-Reviewer: Todd Lipcon

[kudu-CR] Allow to pad UNIXTIME MICROS slots in scan results

2017-04-18 Thread Andrew Wong (Code Review)

Andrew Wong has posted comments on this change.

Change subject: Allow to pad UNIXTIME_MICROS slots in scan results
..


Patch Set 7:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/6623/7/src/kudu/common/wire_protocol.h
File src/kudu/common/wire_protocol.h:

PS7, Line 130: bool pad_unixtime_micros_for_impala = false
Do we need to add docs for this here if it's only being used by Impala?


-- 
To view, visit http://gerrit.cloudera.org:8080/6623
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I99fc6d3be089d19ebe2e70c938f2405c381578b4
Gerrit-PatchSet: 7
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: David Ribeiro Alves 
Gerrit-Reviewer: Andrew Wong 
Gerrit-Reviewer: David Ribeiro Alves 
Gerrit-Reviewer: Jean-Daniel Cryans 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Matthew Jacobs 
Gerrit-Reviewer: Tidy Bot
Gerrit-Reviewer: Todd Lipcon 
Gerrit-HasComments: Yes

[kudu-CR](branch-1.3.x) Bump version to 1.3.2-SNAPSHOT

Hello Todd Lipcon,

I'd like you to do a code review.  Please visit

http://gerrit.cloudera.org:8080/6669

to review the following change.

Change subject: Bump version to 1.3.2-SNAPSHOT
..

Bump version to 1.3.2-SNAPSHOT

Change-Id: Ie4c48aa6ec08a40500d85a1a53ccb48b64d2d4ef
---
M java/interface-annotations/pom.xml
M java/kudu-client-tools/pom.xml
M java/kudu-client/pom.xml
M java/kudu-flume-sink/pom.xml
M java/kudu-jepsen/pom.xml
M java/kudu-mapreduce/pom.xml
M java/kudu-spark/pom.xml
M java/pom.xml
M python/setup.py
M version.txt
10 files changed, 11 insertions(+), 11 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/69/6669/1
-- 
To view, visit http://gerrit.cloudera.org:8080/6669
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ie4c48aa6ec08a40500d85a1a53ccb48b64d2d4ef
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: branch-1.3.x
Gerrit-Owner: Jean-Daniel Cryans 
Gerrit-Reviewer: Todd Lipcon

[kudu-CR] Bump version to 1.3.2-SNAPSHOT

Jean-Daniel Cryans has abandoned this change.

Change subject: Bump version to 1.3.2-SNAPSHOT
..


Abandoned

-- 
To view, visit http://gerrit.cloudera.org:8080/6668
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: abandon
Gerrit-Change-Id: I2c0b37e16b93aad68fb76a60c4d826c989176103
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Jean-Daniel Cryans 
Gerrit-Reviewer: Jean-Daniel Cryans 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon

[kudu-CR] Bump version to 1.3.2-SNAPSHOT

Jean-Daniel Cryans has posted comments on this change.

Change subject: Bump version to 1.3.2-SNAPSHOT
..


Patch Set 2:

ugh I'm dumb, pushed against master

-- 
To view, visit http://gerrit.cloudera.org:8080/6668
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I2c0b37e16b93aad68fb76a60c4d826c989176103
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Jean-Daniel Cryans 
Gerrit-Reviewer: Jean-Daniel Cryans 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon 
Gerrit-HasComments: No

[kudu-CR](branch-1.2.x) KUDU-1741: Keep MiniCluster::Restart consistent with ExternalMiniCluster::Restart

Jean-Daniel Cryans has posted comments on this change.

Change subject: KUDU-1741: Keep MiniCluster::Restart consistent with 
ExternalMiniCluster::Restart
..


Patch Set 1:

> As I understand, it's not necessary to merge this into the 1.2.x
 > branch as it is.  However, having this patch would allow to avoid
 > editing MiniCluster::Restart()-related code if any new merged from
 > the main trunk (e.g., a new test which exercises some particular
 > scenario requiring restart of MiniCluster components).

Well so we have KUDU-1607 that depends on this, which we're trying to merge, 
but we need this patch to make it clean. But I was wondering if we could do 
without this.

-- 
To view, visit http://gerrit.cloudera.org:8080/6659
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iad33b7c46bfca3f277ccbca7d0420272f06a6633
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: branch-1.2.x
Gerrit-Owner: Mike Percy 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: Dinesh Bhat 
Gerrit-Reviewer: Jean-Daniel Cryans 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: No

[kudu-CR] Bump version to 1.3.2-SNAPSHOT

Hello Todd Lipcon,

I'd like you to do a code review.  Please visit

http://gerrit.cloudera.org:8080/6668

to review the following change.

Change subject: Bump version to 1.3.2-SNAPSHOT
..

Bump version to 1.3.2-SNAPSHOT

Change-Id: I2c0b37e16b93aad68fb76a60c4d826c989176103
---
M java/interface-annotations/pom.xml
M java/kudu-client-tools/pom.xml
M java/kudu-client/pom.xml
M java/kudu-flume-sink/pom.xml
M java/kudu-jepsen/pom.xml
M java/kudu-mapreduce/pom.xml
M java/kudu-spark/pom.xml
M java/pom.xml
M python/setup.py
M version.txt
10 files changed, 11 insertions(+), 11 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/68/6668/1
-- 
To view, visit http://gerrit.cloudera.org:8080/6668
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I2c0b37e16b93aad68fb76a60c4d826c989176103
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Jean-Daniel Cryans 
Gerrit-Reviewer: Todd Lipcon

[kudu-CR](branch-1.2.x) KUDU-1741: Keep MiniCluster::Restart consistent with ExternalMiniCluster::Restart

Alexey Serbin has posted comments on this change.

Change subject: KUDU-1741: Keep MiniCluster::Restart consistent with 
ExternalMiniCluster::Restart
..


Patch Set 1: -Code-Review

> I was curious about the need for this patch. It's all test-side,
 > which is great, but ideally we'd only be pulling bug fixes in dot
 > dot releases. Thoughts?

As I understand, it's not necessary to merge this into the 1.2.x branch as it 
is.  However, having this patch would allow to avoid editing 
MiniCluster::Restart()-related code if any new merged from the main trunk 
(e.g., a new test which exercises some particular scenario requiring restart of 
MiniCluster components).

-- 
To view, visit http://gerrit.cloudera.org:8080/6659
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iad33b7c46bfca3f277ccbca7d0420272f06a6633
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: branch-1.2.x
Gerrit-Owner: Mike Percy 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: Dinesh Bhat 
Gerrit-Reviewer: Jean-Daniel Cryans 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: No

[kudu-CR](branch-1.3.x) [docs] Add another workaround for macOS

Jean-Daniel Cryans has submitted this change and it was merged.

Change subject: [docs] Add another workaround for macOS
..


[docs] Add another workaround for macOS

I encountered an issue that was preventing me from building thirdparties
and with Adar's help I found a way to get unstuck. This patch adds more
instructions to our macOS installation instructions.

Change-Id: I870189eddec0a2e34221b5bbdf85353a91fcf527
Reviewed-on: http://gerrit.cloudera.org:8080/6456
Reviewed-by: Adar Dembo 
Tested-by: Kudu Jenkins
(cherry picked from commit 87bd862cb63785158affc065724b57bda7a5a7f4)
Reviewed-on: http://gerrit.cloudera.org:8080/6641
Reviewed-by: Todd Lipcon 
Reviewed-by: Jean-Daniel Cryans 
---
M docs/installation.adoc
1 file changed, 18 insertions(+), 0 deletions(-)

Approvals:
  Jean-Daniel Cryans: Looks good to me, approved
  Todd Lipcon: Looks good to me, approved
  Kudu Jenkins: Verified



-- 
To view, visit http://gerrit.cloudera.org:8080/6641
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I870189eddec0a2e34221b5bbdf85353a91fcf527
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: branch-1.3.x
Gerrit-Owner: Dan Burkert 
Gerrit-Reviewer: Jean-Daniel Cryans 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon

[kudu-CR](branch-1.3.x) [docs] Add another workaround for macOS

Jean-Daniel Cryans has posted comments on this change.

Change subject: [docs] Add another workaround for macOS
..


Patch Set 1: Code-Review+2

-- 
To view, visit http://gerrit.cloudera.org:8080/6641
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I870189eddec0a2e34221b5bbdf85353a91fcf527
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: branch-1.3.x
Gerrit-Owner: Dan Burkert 
Gerrit-Reviewer: Jean-Daniel Cryans 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon 
Gerrit-HasComments: No

[kudu-CR](branch-1.2.x) KUDU-1741: Keep MiniCluster::Restart consistent with ExternalMiniCluster::Restart

Jean-Daniel Cryans has posted comments on this change.

Change subject: KUDU-1741: Keep MiniCluster::Restart consistent with 
ExternalMiniCluster::Restart
..


Patch Set 1:

I was curious about the need for this patch. It's all test-side, which is 
great, but ideally we'd only be pulling bug fixes in dot dot releases. Thoughts?

-- 
To view, visit http://gerrit.cloudera.org:8080/6659
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iad33b7c46bfca3f277ccbca7d0420272f06a6633
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: branch-1.2.x
Gerrit-Owner: Mike Percy 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: Dinesh Bhat 
Gerrit-Reviewer: Jean-Daniel Cryans 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: No

[kudu-CR](branch-1.2.x) KUDU-1933. consensus: Avoid and repair integer overflow in log index

Jean-Daniel Cryans has posted comments on this change.

Change subject: KUDU-1933. consensus: Avoid and repair integer overflow in log 
index
..


Patch Set 2:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/6660/2/src/kudu/consensus/log-test.cc
File src/kudu/consensus/log-test.cc:

Line 1005:   ASSERT_GT(op_id.index(), INT32_MAX);
Should we have this in master too?


-- 
To view, visit http://gerrit.cloudera.org:8080/6660
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I284edbde51dc50fb2f98acc83cdcc3891d37863f
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: branch-1.2.x
Gerrit-Owner: Mike Percy 
Gerrit-Reviewer: David Ribeiro Alves 
Gerrit-Reviewer: Jean-Daniel Cryans 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: Yes

[kudu-CR] env: add RWFile::GetExtentMap for analyzing file extents

Alexey Serbin has posted comments on this change.

Change subject: env: add RWFile::GetExtentMap for analyzing file extents
..


Patch Set 6: Code-Review+2

-- 
To view, visit http://gerrit.cloudera.org:8080/6583
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I35bd1bdb9e1a839af2ab95ea73b79217c1f4a2b3
Gerrit-PatchSet: 6
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Adar Dembo 
Gerrit-Reviewer: Adar Dembo 
Gerrit-Reviewer: Alexey Serbin 
Gerrit-Reviewer: David Ribeiro Alves 
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Tidy Bot
Gerrit-Reviewer: Todd Lipcon 
Gerrit-HasComments: No

[kudu-CR] [cmake] fixed 'latest' dir symlink on MacOS X

Alexey Serbin has uploaded a new change for review.

  http://gerrit.cloudera.org:8080/6667

Change subject: [cmake] fixed 'latest' dir symlink on MacOS X
..

[cmake] fixed 'latest' dir symlink on MacOS X

If the 'latest' symbolic link already exists, do not follow it, so the
'latest' link is updated to point to the new src directory.  Prior to
this fix, the result symlink would be created in the directory which
the 'latest' points at.

Also, replaced Linux-specific '-T' option with '-n' option which is
compatible at least between BSD-style and Linux ln implementations.

Change-Id: Ica6314eb5274e853b7b39b7e6ede17305d0c646d
---
M CMakeLists.txt
1 file changed, 2 insertions(+), 6 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/67/6667/1
-- 
To view, visit http://gerrit.cloudera.org:8080/6667
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ica6314eb5274e853b7b39b7e6ede17305d0c646d
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Alexey Serbin

[kudu-CR] [rpc] close socket on AcceptorPool::Shutdown()