Change in vdsm[ovirt-3.5]: json-rpc: fix the Host.getVMList return value
Piotr Kliczewski has posted comments on this change. Change subject: json-rpc: fix the Host.getVMList return value .. Patch Set 1: Verified+1 Verified by Omer on master branch. -- To view, visit https://gerrit.ovirt.org/38322 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2b8b2ed205385f4bdd341cdc576b44312c3fc117 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: Revert json-rpc: fix the Host.getVMList return value
Piotr Kliczewski has posted comments on this change. Change subject: Revert json-rpc: fix the Host.getVMList return value .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/38433 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I367075353f4f3c3a5b9a0716a48a1ae3976669a1 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Barak Azulay bazu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Michal Skrivanek mskri...@redhat.com Gerrit-Reviewer: Omer Frenkel ofren...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Have the protocol detector use the Reactor
Piotr Kliczewski has posted comments on this change. Change subject: Have the protocol detector use the Reactor .. Patch Set 7: Verified+1 Verified by installing a host and seeing communication going between engine and vdsm. -- To view, visit https://gerrit.ovirt.org/37098 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If1cc2a205cdad335e8c3af4a77ed49c8977a79ba Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: stomp: Make sure the \0 is read before slicing the buffer
Piotr Kliczewski has posted comments on this change. Change subject: stomp: Make sure the \0 is read before slicing the buffer .. Patch Set 5: Thank you for bringing this up. This patch as it is was used as base for https://gerrit.ovirt.org/#/c/36806/ but there are more changes in this patch I will make sure that we differentiate both. -- To view, visit https://gerrit.ovirt.org/35938 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie0d8eaae161f3ec6c77726f4f9da044ab7c629d4 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[ovirt-3.5]: getVMList: using internal function instead of vm.status
Piotr Kliczewski has posted comments on this change. Change subject: getVMList: using internal function instead of vm.status .. Patch Set 1: Verified+1 Verified by using engine 3.6 and creating storage domain, running a vm. No issues noticed. -- To view, visit https://gerrit.ovirt.org/38513 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia890342a95124f86d3f8f3de0d8b4042384b8b52 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: ovirt-3.5 Gerrit-Owner: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: stomp: Optimize stomp encoder\decoder
Piotr Kliczewski has posted comments on this change. Change subject: stomp: Optimize stomp encoder\decoder .. Patch Set 6: (1 comment) https://gerrit.ovirt.org/#/c/35255/6//COMMIT_MSG Commit Message: Line 3: AuthorDate: 2014-11-18 00:55:35 +0200 Line 4: Commit: pkliczewski piotr.kliczew...@gmail.com Line 5: CommitDate: 2015-03-09 17:22:22 +0100 Line 6: Line 7: stomp: Optimize stomp encoder\decoder which is nice, but looks like this patch squashes together a few changes re Will explore splitting this patch and will update this message. Line 8: Line 9: Change-Id: I341e46463e654ae0a086cd49af18aa336b86cb6e -- To view, visit https://gerrit.ovirt.org/35255 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I341e46463e654ae0a086cd49af18aa336b86cb6e Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Dima Kuznetsov dkuzn...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: asyncore: dynamic tick support
Piotr Kliczewski has posted comments on this change. Change subject: asyncore: dynamic tick support .. Patch Set 11: (1 comment) https://gerrit.ovirt.org/#/c/37057/11/lib/yajsonrpc/betterAsyncore.py File lib/yajsonrpc/betterAsyncore.py: Line 162: def process_requests(self): Line 163: self._is_running = True Line 164: while self._is_running: Line 165: asyncore.loop( Line 166: timeout=self._get_timeout(self._map), So default here will be 30sec (in case of timeout=None)? Yes, this is refactored in later patch to be more flexible. Line 167: use_poll=True, Line 168: map=self._map, Line 169: count=1, Line 170: ) -- To view, visit https://gerrit.ovirt.org/37057 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I44b38e961d46e914bb687c924ba4e83f38371d5b Gerrit-PatchSet: 11 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Dima Kuznetsov dkuzn...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: [WIP] EVENTS
Piotr Kliczewski has posted comments on this change. Change subject: [WIP] EVENTS .. Patch Set 4: Verified-1 jsonrpc code is not working for el6 -- To view, visit https://gerrit.ovirt.org/38069 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id27b5ca1773139932eb5cb16921d5abec4991c5e Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Dima Kuznetsov dkuzn...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: gluster: add createBrick verb
Piotr Kliczewski has posted comments on this change. Change subject: gluster: add createBrick verb .. Patch Set 24: Code-Review+1 schema and api changes looks good -- To view, visit https://gerrit.ovirt.org/35498 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic47c4c56834deb457ae9d038f77bcf69c7b39ba5 Gerrit-PatchSet: 24 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Timothy Asir tjeya...@redhat.com Gerrit-Reviewer: Bala.FA barum...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Darshan N dnara...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Sahina Bose sab...@redhat.com Gerrit-Reviewer: Sandro Bonazzola sbona...@redhat.com Gerrit-Reviewer: Shubhendu Tripathi shtri...@redhat.com Gerrit-Reviewer: Timothy Asir tjeya...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: stomp: server side subscriptions
Piotr Kliczewski has posted comments on this change. Change subject: stomp: server side subscriptions .. Patch Set 5: Verified+1 -- To view, visit https://gerrit.ovirt.org/38451 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1493070f2ba66ca9d39a6661876c82c4727cad62 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Dima Kuznetsov dkuzn...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Oved Ourfali oourf...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: asyncore: Move generic reactor functionality
Piotr Kliczewski has posted comments on this change. Change subject: asyncore: Move generic reactor functionality .. Patch Set 14: Verified-1 There was rebase only so I still need to fix Francesco's comments. -- To view, visit https://gerrit.ovirt.org/37055 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I59a14b18f4c08d873763e1d3bd9d42b99de05fb1 Gerrit-PatchSet: 14 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Dima Kuznetsov dkuzn...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: asyncore: Move generic reactor functionality
Piotr Kliczewski has posted comments on this change. Change subject: asyncore: Move generic reactor functionality .. Patch Set 15: Verified+1 Rebased and added docstring in betterAsyncore as requested. Copying verify flag due to lack of functional change. -- To view, visit https://gerrit.ovirt.org/37055 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I59a14b18f4c08d873763e1d3bd9d42b99de05fb1 Gerrit-PatchSet: 15 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Dima Kuznetsov dkuzn...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: asyncore: Move ssl buffer handling to dispatcher
Piotr Kliczewski has posted comments on this change. Change subject: asyncore: Move ssl buffer handling to dispatcher .. Patch Set 14: Verified+1 Rebased, added requested docstring. Verified with engine 3.5 -- To view, visit https://gerrit.ovirt.org/37097 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id5b75c8cdcaf1ddb63b499619153c4df4772af4d Gerrit-PatchSet: 14 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Dima Kuznetsov dkuzn...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: stomp: Make sure the \0 is a last char in the buffer
Piotr Kliczewski has posted comments on this change. Change subject: stomp: Make sure the \0 is a last char in the buffer .. Patch Set 8: Verified+1 I would like to keep this patch as sanity check since I have seen it useful during development. Rebased and verified with engine 3.5. -- To view, visit https://gerrit.ovirt.org/35938 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie0d8eaae161f3ec6c77726f4f9da044ab7c629d4 Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: stomp: client side subscription
Piotr Kliczewski has posted comments on this change. Change subject: stomp: client side subscription .. Patch Set 8: Verified+1 Rebased, verified with engine 3.5 -- To view, visit https://gerrit.ovirt.org/36368 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8e43658f1cebd637ea3abf4396d388afa041ae71 Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Dima Kuznetsov dkuzn...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: jsonrpc: events
Piotr Kliczewski has posted comments on this change. Change subject: jsonrpc: events .. Patch Set 6: Rebased, communication with engine 3.5 works but events not verified yet. -- To view, visit https://gerrit.ovirt.org/38069 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id27b5ca1773139932eb5cb16921d5abec4991c5e Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Dima Kuznetsov dkuzn...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: asyncore: dynamic tick support
Piotr Kliczewski has posted comments on this change. Change subject: asyncore: dynamic tick support .. Patch Set 15: Verified+1 Fixed comments and rebased. Verified with engine 3.5 -- To view, visit https://gerrit.ovirt.org/37057 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I44b38e961d46e914bb687c924ba4e83f38371d5b Gerrit-PatchSet: 15 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Dima Kuznetsov dkuzn...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Have the protocol detector use the Reactor
Piotr Kliczewski has posted comments on this change. Change subject: Have the protocol detector use the Reactor .. Patch Set 12: Verified+1 Rebased, fix comments. Verified with engine 3.5 -- To view, visit https://gerrit.ovirt.org/37098 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If1cc2a205cdad335e8c3af4a77ed49c8977a79ba Gerrit-PatchSet: 12 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: jsonrpc: Fix callMethod in JsonRpcClient
Piotr Kliczewski has posted comments on this change. Change subject: jsonrpc: Fix callMethod in JsonRpcClient .. Patch Set 8: Verified+1 Rebased, updated commit message. Verified with engine 3.5. -- To view, visit https://gerrit.ovirt.org/35935 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7cf78f3b7f5d32c10339bbe6b49ce9b93662b4bb Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: stomp: server side subscriptions
Piotr Kliczewski has posted comments on this change. Change subject: stomp: server side subscriptions .. Patch Set 6: Verified+1 Rebased, fixed comments, Verified with engine 3.5 -- To view, visit https://gerrit.ovirt.org/38451 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1493070f2ba66ca9d39a6661876c82c4727cad62 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Dima Kuznetsov dkuzn...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Oved Ourfali oourf...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: stomp: parsing buffer refactoring
Piotr Kliczewski has posted comments on this change. Change subject: stomp: parsing buffer refactoring .. Patch Set 3: Verified+1 Rebased, fixed comments. Verified with engine 3.5 -- To view, visit https://gerrit.ovirt.org/38666 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1b835e0d8a5ca20e67f0562955255ba1ad6ae9a1 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: stomp: Stomp encoder\decoder improvements
Piotr Kliczewski has posted comments on this change. Change subject: stomp: Stomp encoder\decoder improvements .. Patch Set 9: Verified+1 Rebased and commit message updated to make it clear what type of changes this patch contains. Verified with engine 3.5 -- To view, visit https://gerrit.ovirt.org/35255 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I341e46463e654ae0a086cd49af18aa336b86cb6e Gerrit-PatchSet: 9 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Dima Kuznetsov dkuzn...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: stomp: Pop the frame even if a frame handler isn't defined
Piotr Kliczewski has posted comments on this change. Change subject: stomp: Pop the frame even if a frame handler isn't defined .. Patch Set 8: Verified+1 Rebased, comment fixed. Verified with engine 3.5 -- To view, visit https://gerrit.ovirt.org/35940 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9cd3c5b9ad70cf49e1b105260548720d5b34ea9a Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: stomp: Optimize stomp encoder\decoder
Piotr Kliczewski has posted comments on this change. Change subject: stomp: Optimize stomp encoder\decoder .. Patch Set 8: From my perspective it is not really optimization but bug fixing of stomp frame encoding/decoding. I understand that commit message is confusing will update. -- To view, visit https://gerrit.ovirt.org/35255 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I341e46463e654ae0a086cd49af18aa336b86cb6e Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Dima Kuznetsov dkuzn...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: API: onlyUUID should affect only short status
Piotr Kliczewski has posted comments on this change. Change subject: API: onlyUUID should affect only short status .. Patch Set 5: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/38679 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id05a1bb92100023e8a96ee6f13daa8eedd233ff6 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Adam Litke ali...@redhat.com Gerrit-Reviewer: Barak Azulay bazu...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Martin Sivák msi...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: API: getVMList: compatibity with internal clients
Piotr Kliczewski has posted comments on this change. Change subject: API: getVMList: compatibity with internal clients .. Patch Set 2: Code-Review-1 (1 comment) https://gerrit.ovirt.org/#/c/38805/2//COMMIT_MSG Commit Message: Line 27: With the current 'onlyUUID' defaults, clients of API.py Line 28: will get a list of UUIDs instead of a list of Short Status. Line 29: Line 30: To fix this, and given the findings outlined in the above bullet points, Line 31: we just switch the default value of 'onlyUUID' to cover this use case. How this switch will work with engine 3.5.0? When you set it to False it will get a map which would break the engine (ClassCastException) which results with lost connection to a host. I do not see in this patch how you want mitigate this issue. Line 32: Line 33: Change-Id: I0560a262329f729716577b28aa78b177f0929121 -- To view, visit https://gerrit.ovirt.org/38805 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0560a262329f729716577b28aa78b177f0929121 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Adam Litke ali...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Martin Sivák msi...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: API: getVMList: compatibity with internal clients
Piotr Kliczewski has posted comments on this change. Change subject: API: getVMList: compatibity with internal clients .. Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/38805 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0560a262329f729716577b28aa78b177f0929121 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Adam Litke ali...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Martin Sivák msi...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: API: getVMList: compatibity with internal clients
Piotr Kliczewski has posted comments on this change. Change subject: API: getVMList: compatibity with internal clients .. Patch Set 2: How does it looks from the engine perspective? Can you look for getVMFullList? -- To view, visit https://gerrit.ovirt.org/38805 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0560a262329f729716577b28aa78b177f0929121 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Adam Litke ali...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Martin Sivák msi...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: API: getVMList: compatibity with internal clients
Piotr Kliczewski has posted comments on this change. Change subject: API: getVMList: compatibity with internal clients .. Patch Set 2: -Code-Review Logs seems good. Please check with master and if that works I am fine with the change. -- To view, visit https://gerrit.ovirt.org/38805 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0560a262329f729716577b28aa78b177f0929121 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Adam Litke ali...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Martin Sivák msi...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: jsonrpc: events
Piotr Kliczewski has posted comments on this change. Change subject: jsonrpc: events .. Patch Set 7: Verified+1 Rebased, added event test and verified with engine 3.5. -- To view, visit https://gerrit.ovirt.org/38069 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id27b5ca1773139932eb5cb16921d5abec4991c5e Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Dima Kuznetsov dkuzn...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: stomp: outgoing connection to a broker
Piotr Kliczewski has uploaded a new change for review.
Change subject: stomp: outgoing connection to a broker
..
stomp: outgoing connection to a broker
Change-Id: Ied3095a305fd5a5bfc19c8bc0342fba7cb811843
Signed-off-by: pkliczewski piotr.kliczew...@gmail.com
---
M lib/vdsm/config.py.in
M lib/yajsonrpc/__init__.py
M lib/yajsonrpc/stompReactor.py
M tests/jsonRpcHelper.py
M vdsm/clientIF.py
M vdsm/rpc/BindingJsonRpc.py
6 files changed, 109 insertions(+), 22 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/19/38819/1
diff --git a/lib/vdsm/config.py.in b/lib/vdsm/config.py.in
index cf8cadd..5689696 100644
--- a/lib/vdsm/config.py.in
+++ b/lib/vdsm/config.py.in
@@ -197,6 +197,8 @@
('jsonrpc_enable', 'true', 'Enable the JSON RPC server'),
+('broker_enable', 'false', 'Enable outgoing connection to broker'),
+
('report_host_threads_as_cores', 'false',
'Count each cpu hyperthread as an individual core'),
@@ -328,6 +330,19 @@
('guests_gateway_ip', '', None),
+('broker_address', '127.0.0.1',
+'Address where the broker is listening at. Use an empty string '
+'for none'),
+
+('broker_port', '5445',
+'Port where the broker is listening at.'),
+
+('request_queues',
+'jms.topic.vdsm_requests,jms.topic.vdsm_irs_requests',
+'Queues to subscribe to for RPC requests'),
+
+('event_queue', 'jms.topic.vdsm_requests',
+'Queue used for events'),
]),
# Section: [devel]
diff --git a/lib/yajsonrpc/__init__.py b/lib/yajsonrpc/__init__.py
index 48c3ca1..557f3d5 100644
--- a/lib/yajsonrpc/__init__.py
+++ b/lib/yajsonrpc/__init__.py
@@ -184,7 +184,6 @@
self._cb(
notification,
-self._event_id
)
diff --git a/lib/yajsonrpc/stompReactor.py b/lib/yajsonrpc/stompReactor.py
index c62869b..383ca49 100644
--- a/lib/yajsonrpc/stompReactor.py
+++ b/lib/yajsonrpc/stompReactor.py
@@ -20,17 +20,14 @@
import stomp
from vdsm import utils
+from vdsm.config import config
from vdsm.compat import json
from betterAsyncore import Dispatcher, Reactor
from vdsm.sslutils import SSLSocket
-from yajsonrpc import JsonRpcClient
+from yajsonrpc import JsonRpcClient, JsonRpcServer
_STATE_LEN = Waiting for message length
_STATE_MSG = Waiting for message
-
-
-_DEFAULT_RESPONSE_DESTINATION = jms.topic.vdsm_legacy_responses
-_DEFAULT_REQUEST_DESTINATION = jms.topic.vdsm_legacy_requests
def parseHeartBeatHeader(v):
@@ -61,6 +58,8 @@
self._sub_dests = sub_map
self._req_dest = req_dest
self._sub_ids = {}
+request_queues = config.get('addresses', 'request_queues')
+self.request_queues = request_queues.split(,)
self._commands = {
stomp.Command.CONNECT: self._cmd_connect,
stomp.Command.SEND: self._cmd_send,
@@ -163,7 +162,7 @@
def _cmd_send(self, dispatcher, frame):
destination = frame.headers.get(stomp.Headers.DESTINATION, None)
-if _DEFAULT_REQUEST_DESTINATION == destination:
+if destination in self.request_queues:
# default subscription
self._handle_internal(dispatcher, stomp.Headers.REPLY_TO,
frame.body)
@@ -255,10 +254,10 @@
class StompServer(object):
log = logging.getLogger(yajsonrpc.StompServer)
-def __init__(self, reactor):
+def __init__(self, reactor, subs):
self._reactor = reactor
self._messageHandler = None
-self._sub_map = {}
+self._sub_map = subs
self._req_dest = {}
def add_client(self, sock):
@@ -270,7 +269,7 @@
def send(
self,
message,
-destination=_DEFAULT_RESPONSE_DESTINATION,
+destination=stomp.LEGACY_SUB_ID_RES,
):
self.log.debug(Sending response)
try:
@@ -348,12 +347,9 @@
def send(
self,
message,
-destination=None,
+destination=stomp.LEGACY_SUB_ID_RES,
headers=None
):
-if destination is None:
-destination = _DEFAULT_REQUEST_DESTINATION
-
self.log.debug(Sending request)
self._aclient.send(
destination,
@@ -393,9 +389,9 @@
class StompReactor(object):
-def __init__(self):
+def __init__(self, subs):
self._reactor = Reactor()
-self._server = StompServer(self._reactor)
+self._server = StompServer(self._reactor, subs)
def createListener(self, connected_socket, acceptHandler):
listener = StompListener(
@@ -440,6 +436,39 @@
self.log.debug(Stomp detected from %s, socket_address)
+class ServerRpcContextAdapter(object):
+@classmethod
+def subscription_handler(cls, server):
+def handler(sub, frame):
+server.queueRequest
Change in vdsm[master]: jsonrpc: events
Piotr Kliczewski has posted comments on this change. Change subject: jsonrpc: events .. Patch Set 8: Verified+1 Updaed __init__.py by moving part of change from broker patch which belong to this patch. Verified with engine 3.5. -- To view, visit https://gerrit.ovirt.org/38069 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id27b5ca1773139932eb5cb16921d5abec4991c5e Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Dima Kuznetsov dkuzn...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: stomp: outgoing connection to a broker
Piotr Kliczewski has posted comments on this change. Change subject: stomp: outgoing connection to a broker .. Patch Set 1: Verified-1 (1 comment) Connection to broker not tested yet. https://gerrit.ovirt.org/#/c/38819/1/lib/yajsonrpc/__init__.py File lib/yajsonrpc/__init__.py: Line 182: } Line 183: ) Line 184: Line 185: self._cb( Line 186: notification, This change need to be part of events patch. Will move it there. Line 187: ) Line 188: Line 189: Line 190: class _JsonRpcClientRequestContext(object): -- To view, visit https://gerrit.ovirt.org/38819 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ied3095a305fd5a5bfc19c8bc0342fba7cb811843 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Dima Kuznetsov dkuzn...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: gluster: Adds new verbs to setup gluster geo-replication.
Piotr Kliczewski has posted comments on this change. Change subject: gluster: Adds new verbs to setup gluster geo-replication. .. Patch Set 9: Code-Review+1 api and schema changes looks good -- To view, visit https://gerrit.ovirt.org/38228 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I06a64b8f0db8846ca2697b9f0ec69cab2d3d6b1e Gerrit-PatchSet: 9 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Darshan N dnara...@redhat.com Gerrit-Reviewer: Aravinda VK avish...@redhat.com Gerrit-Reviewer: Bala.FA barum...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Darshan N dnara...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Sahina Bose sab...@redhat.com Gerrit-Reviewer: Timothy Asir tjeya...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: events: vm status notifications
Piotr Kliczewski has uploaded a new change for review.
Change subject: events: vm status notifications
..
events: vm status notifications
Whenever vm changes status we send notification to an engine with vmid
and new status.
Change-Id: I746299f9f1e2f49831a05072f19af1d242796276
Signed-off-by: pkliczewski piotr.kliczew...@gmail.com
---
M tests/jsonRpcTests.py
M tests/vmfakelib.py
M vdsm/virt/vm.py
3 files changed, 23 insertions(+), 2 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/37/38937/1
diff --git a/tests/jsonRpcTests.py b/tests/jsonRpcTests.py
index 7325c0e..01bf3c8 100644
--- a/tests/jsonRpcTests.py
+++ b/tests/jsonRpcTests.py
@@ -60,7 +60,7 @@
def double_response(self):
n = self.cif.create_notification('vdsm.double_response')
-n.emit(content=True)
+n.emit(**{CALL_ID: True})
return 'sent'
def register_server_address(self, server_address):
@@ -193,7 +193,7 @@
else:
def callback(client, event, params):
self.assertEquals(event, 'vdsm.double_response')
-self.assertEquals(params, {'content': True})
+self.assertEquals(params, {CALL_ID: True})
client.registerEventCallback(callback)
res = self._callTimeout(client, double_response, [],
diff --git a/tests/vmfakelib.py b/tests/vmfakelib.py
index 271538e..5fc2861 100644
--- a/tests/vmfakelib.py
+++ b/tests/vmfakelib.py
@@ -35,6 +35,7 @@
from testlib import namedTemporaryDir
from monkeypatch import MonkeyPatchScope
+from yajsonrpc import Notification
class Connection:
@@ -57,6 +58,12 @@
self.vmContainerLock = threading.Lock()
self.vmContainer = {}
+def create_notification(self, event_id):
+def send(message):
+pass
+
+return Notification(event_id, send)
+
class Domain(object):
def __init__(self, xml='',
diff --git a/vdsm/virt/vm.py b/vdsm/virt/vm.py
index bb2ab62..8cd4d6c 100644
--- a/vdsm/virt/vm.py
+++ b/vdsm/virt/vm.py
@@ -865,6 +865,10 @@
def _set_lastStatus(self, value):
with self._statusLock:
+notification = self.cif.create_notification(
+'|virt|VM_status|' + self.id
+)
+notification.emit(**{self.id: value})
if self._lastStatus == vmstatus.DOWN:
self.log.warning(
'trying to set state to %s when already Down',
@@ -1616,6 +1620,12 @@
self._acquireCpuLockWithTimeout()
try:
self._guestCpuRunning = isRunning
+if (not self._guestCpuRunning and
+self._lastStatus in vmstatus.PAUSED_STATES):
+notification = self.cif.create_notification(
+'|virt|VM_status|' + self.id
+)
+notification.emit(**{self.id: 'Paused'})
finally:
if not guestCpuLocked:
self._guestCpuLock.release()
@@ -5015,6 +5025,10 @@
' (command timeout, age=%s)',
statsAge)
stats['monitorResponse'] = '-1'
+notification = self.cif.create_notification(
+'|virt|VM_status|' + self.id
+)
+notification.emit(**{self.id: 'NotResponding'})
class LiveMergeCleanupThread(threading.Thread):
--
To view, visit https://gerrit.ovirt.org/38937
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I746299f9f1e2f49831a05072f19af1d242796276
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski piotr.kliczew...@gmail.com
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: events: vm status notifications
Piotr Kliczewski has posted comments on this change. Change subject: events: vm status notifications .. Patch Set 1: Verified with engine containing vm status updates via events. I tested creation of a vm and suspending it. I noticed that engine processed and updated database with following status updates: Down, Up, Paused, PoweringDown. I am still missing NotResponding test. I am not marking it as verified because there is heartbeat issue on vdsm side that I need to resolve first. -- To view, visit https://gerrit.ovirt.org/38937 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I746299f9f1e2f49831a05072f19af1d242796276 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: stomp: Pop the frame even if a frame handler isn't defined
Piotr Kliczewski has posted comments on this change. Change subject: stomp: Pop the frame even if a frame handler isn't defined .. Patch Set 10: (1 comment) https://gerrit.ovirt.org/#/c/35940/10//COMMIT_MSG Commit Message: Line 3: AuthorDate: 2014-12-07 22:57:37 +0200 Line 4: Commit: pkliczewski piotr.kliczew...@gmail.com Line 5: CommitDate: 2015-03-18 12:08:18 +0100 Line 6: Line 7: stomp: Pop the frame even if a frame handler isn't defined ok, but why? We don't we need the hasattr() check anymore? Looking at the code all handlers have the method so no need to check. Will update message to be clear. Line 8: Line 9: Change-Id: I9cd3c5b9ad70cf49e1b105260548720d5b34ea9a Line 10: Signed-off-by: Saggi Mizrahi smizr...@redhat.com -- To view, visit https://gerrit.ovirt.org/35940 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9cd3c5b9ad70cf49e1b105260548720d5b34ea9a Gerrit-PatchSet: 10 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: jsonrpc: events
Piotr Kliczewski has posted comments on this change. Change subject: jsonrpc: events .. Patch Set 10: (1 comment) https://gerrit.ovirt.org/#/c/38069/10/vdsm/clientIF.py File vdsm/clientIF.py: Line 145: Line 146: def _send_notification(self, message, destination): Line 147: json_binding = self.bindings['jsonrpc'] Line 148: server = json_binding.getStompReactor().server Line 149: server.send(message) We have two problems here. We need a means to give people ability to send notifications. ClientIF is now used by most of the code which makes it ugly but good trash can. I am open for other commonly used parts of the code which could hold events infra code for sending. I agree with you and we should simplify the code. Will work on it. Line 150: Line 151: def contEIOVms(self, sdUUID, isDomainStateValid): Line 152: # This method is called everytime the onDomainStateChange Line 153: # event is emitted, this event is emitted even when a domain goes -- To view, visit https://gerrit.ovirt.org/38069 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id27b5ca1773139932eb5cb16921d5abec4991c5e Gerrit-PatchSet: 10 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Dima Kuznetsov dkuzn...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: events: vm status notifications
Piotr Kliczewski has posted comments on this change.
Change subject: events: vm status notifications
..
Patch Set 1:
(5 comments)
https://gerrit.ovirt.org/#/c/38937/1/tests/jsonRpcTests.py
File tests/jsonRpcTests.py:
Line 59: return None
Line 60:
Line 61: def double_response(self):
Line 62: n = self.cif.create_notification('vdsm.double_response')
Line 63: n.emit(**{CALL_ID: True})
related?
I wanted to be sure that this structure works nicely. Not really related to the
change.
Line 64: return 'sent'
Line 65:
Line 66: def register_server_address(self, server_address):
Line 67: self.server_address = server_address
Line 192: pass
Line 193: else:
Line 194: def callback(client, event, params):
Line 195: self.assertEquals(event,
'vdsm.double_response')
Line 196: self.assertEquals(params, {CALL_ID: True})
same
As above
Line 197:
Line 198: client.registerEventCallback(callback)
Line 199: res = self._callTimeout(client,
double_response, [],
Line 200: CALL_ID,
timeout=CALL_TIMEOUT)
https://gerrit.ovirt.org/#/c/38937/1/vdsm/virt/vm.py
File vdsm/virt/vm.py:
Line 867: with self._statusLock:
Line 868: notification = self.cif.create_notification(
Line 869: '|virt|VM_status|' + self.id
Line 870: )
Line 871: notification.emit(**{self.id: value})
this hides a lot IMHO. We need a simpler way to achieve the same result.
As replied to other comment I will simplify it.
Line 872: if self._lastStatus == vmstatus.DOWN:
Line 873: self.log.warning(
Line 874: 'trying to set state to %s when already Down',
Line 875: value)
Line 1624: self._lastStatus in vmstatus.PAUSED_STATES):
Line 1625: notification = self.cif.create_notification(
Line 1626: '|virt|VM_status|' + self.id
Line 1627: )
Line 1628: notification.emit(**{self.id: 'Paused'})
Need to check but I'm quite confident we can get rid of this hunk. Not a bi
As I understood from our conversation we do not update vm state to 'Paused' but
check for it when calling _get_lastStatus so if we want to send I think this is
good place to do so.
Line 1629: finally:
Line 1630: if not guestCpuLocked:
Line 1631: self._guestCpuLock.release()
Line 1632:
Line 5027: stats['monitorResponse'] = '-1'
Line 5028: notification = self.cif.create_notification(
Line 5029: '|virt|VM_status|' + self.id
Line 5030: )
Line 5031: notification.emit(**{self.id: 'NotResponding'})
We'll probably need the same treatment inside _timeoutExperienced.
Done
Line 5032:
Line 5033:
Line 5034: class LiveMergeCleanupThread(threading.Thread):
Line 5035: def __init__(self, vm, jobId, drive, doPivot):
--
To view, visit https://gerrit.ovirt.org/38937
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I746299f9f1e2f49831a05072f19af1d242796276
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski piotr.kliczew...@gmail.com
Gerrit-Reviewer: Dima Kuznetsov dkuzn...@redhat.com
Gerrit-Reviewer: Francesco Romani from...@redhat.com
Gerrit-Reviewer: Michal Skrivanek mskri...@redhat.com
Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com
Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com
Gerrit-Reviewer: Yeela Kaplan ykap...@redhat.com
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: stomp: server side subscriptions
Piotr Kliczewski has posted comments on this change. Change subject: stomp: server side subscriptions .. Patch Set 9: (1 comment) https://gerrit.ovirt.org/#/c/38451/9/lib/yajsonrpc/stomp.py File lib/yajsonrpc/stomp.py: Line 21: from vdsm.utils import monotonic_time Line 22: import re Line 23: Line 24: LEGACY_SUB_ID_REQ = /queue/_local/vdsm/requests Line 25: LEGACY_SUB_ID_RES = /queue/_local/vdsm/reponses typo. it is a typo but we used those names in 3.5 (with typo) so we need to keep them as they were. As I replied to your comment newer naming will be updated. Line 26: Line 27: _RE_ESCAPE_SEQUENCE = re.compile(r\\(.)) Line 28: Line 29: _RE_ENCODE_CHARS = re.compile(r[\r\n\\:]) -- To view, visit https://gerrit.ovirt.org/38451 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1493070f2ba66ca9d39a6661876c82c4727cad62 Gerrit-PatchSet: 9 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Dima Kuznetsov dkuzn...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Oved Ourfali oourf...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: stomp: client side subscription
Piotr Kliczewski has posted comments on this change. Change subject: stomp: client side subscription .. Patch Set 10: (4 comments) https://gerrit.ovirt.org/#/c/36368/10/lib/yajsonrpc/stomp.py File lib/yajsonrpc/stomp.py: Line 288: class AsyncDispatcher(object): Line 289: log = logging.getLogger(stomp.AsyncDispatcher) Line 290: Line 291: def __init__(self, frame_handler, bufferSize=4096): Line 292: self._frame_handler = frame_handler unrelated (but nice) rename? not related to the change. Just cleaning up. Line 293: self._bufferSize = bufferSize Line 294: self._parser = Parser() Line 295: self._outbuf = None Line 296: self._outgoing_heartbeat_in_milis = 0 Line 302: self._update_outgoing_heartbeat() Line 303: self._outgoing_heartbeat_in_milis = outgoing Line 304: Line 305: def handle_connect(self, dispatcher): Line 306: self._outbuf = None why we do need this now? it is a leftover should be in older patch. Will move it there. Line 307: self._frame_handler.handle_connect(self) Line 308: Line 309: def handle_read(self, dispatcher): Line 310: try: https://gerrit.ovirt.org/#/c/36368/10/lib/yajsonrpc/stompReactor.py File lib/yajsonrpc/stompReactor.py: Line 74: def pop_message(self): Line 75: return self._outbox.popleft() Line 76: Line 77: def queue_frame(self, frame): Line 78: self._outbox.append(frame) seems duplicated code. Any chance to factor it out? which part of it is duplicated? I am happy to refactor if needed. Line 79: Line 80: def _cmd_connect(self, dispatcher, frame): Line 81: self.log.info(Processing CONNECT request) Line 82: version = frame.headers.get(accept-version, None) https://gerrit.ovirt.org/#/c/36368/10/tests/jsonRpcHelper.py File tests/jsonRpcHelper.py: Line 101: if handler.NAME == type: Line 102: reactor = handler._reactor Line 103: Line 104: if not client: Line 105: def client(client_socket): def? maybe something is missing here? the code is intended to be like that. Line 106: return StompRpcClient( Line 107: reactor.createClient(client_socket), Line 108: _FAKE_SUB_ID, Line 109: _FAKE_SUB_ID, -- To view, visit https://gerrit.ovirt.org/36368 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8e43658f1cebd637ea3abf4396d388afa041ae71 Gerrit-PatchSet: 10 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Dima Kuznetsov dkuzn...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: stomp: server side subscriptions
Piotr Kliczewski has posted comments on this change. Change subject: stomp: server side subscriptions .. Patch Set 9: (1 comment) https://gerrit.ovirt.org/#/c/38451/9/lib/yajsonrpc/stompReactor.py File lib/yajsonrpc/stompReactor.py: Line 126: subs = self._sub_dests[destination] Line 127: except KeyError: Line 128: self._sub_dests[destination] = [subscription] Line 129: else: Line 130: subs.append(subscription) you may want to try defaultdict to simplify this code. Will try Line 131: Line 132: self._sub_ids[sub_id] = subscription Line 133: Line 134: def _send_error(self, msg, connection): -- To view, visit https://gerrit.ovirt.org/38451 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1493070f2ba66ca9d39a6661876c82c4727cad62 Gerrit-PatchSet: 9 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Dima Kuznetsov dkuzn...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Oved Ourfali oourf...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: stomp: server side subscriptions
Piotr Kliczewski has posted comments on this change. Change subject: stomp: server side subscriptions .. Patch Set 9: (1 comment) https://gerrit.ovirt.org/#/c/38451/9/lib/yajsonrpc/stomp.py File lib/yajsonrpc/stomp.py: Line 21: from vdsm.utils import monotonic_time Line 22: import re Line 23: Line 24: LEGACY_SUB_ID_REQ = /queue/_local/vdsm/requests Line 25: LEGACY_SUB_ID_RES = /queue/_local/vdsm/reponses ok..so this is not related to the new events? is it used in 3.5 for anythin In 3.5 time frame we haven't decided to implement subscriptions due to time constraints. For 3.6 we want to have it but the engine sends SUBSCRIBE frames anyway so we need to process them (know about them) in 3.6. By queue names we know whether we work with legacy mode or with new code. Based on this information we know to which client to deliver notifications. Line 26: Line 27: _RE_ESCAPE_SEQUENCE = re.compile(r\\(.)) Line 28: Line 29: _RE_ENCODE_CHARS = re.compile(r[\r\n\\:]) -- To view, visit https://gerrit.ovirt.org/38451 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1493070f2ba66ca9d39a6661876c82c4727cad62 Gerrit-PatchSet: 9 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Dima Kuznetsov dkuzn...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Oved Ourfali oourf...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: gluster: Patch adds geo-replication create and delete verbs.
Piotr Kliczewski has posted comments on this change. Change subject: gluster: Patch adds geo-replication create and delete verbs. .. Patch Set 30: Code-Review-1 (2 comments) https://gerrit.ovirt.org/#/c/17644/30/vdsm/gluster/apiwrapper.py File vdsm/gluster/apiwrapper.py: Line 274: return self._gluster.geoRepMountBrokerSetup(remoteUserName, Line 275: remoteGroupName, Line 276: remoteVolumeName) Line 277: Line 278: def geoRepSessionCreate(self, volumeName, remoteHost, remotVolumeName, if you want to have options parameter in apiwrapper you need to add it to schema. Line 279: remoteUserName=None, force=False, options=None): Line 280: return self._gluster.volumeGeoRepSessionCreate( Line 281: volumeName, Line 282: remoteHost, Line 284: remoteUserName, Line 285: force Line 286: ) Line 287: Line 288: def geoRepSessionDelete(self, volumeName, remoteHost, as above. Line 289: remoteVolumeName, Line 290: remoteUserName=None, options=None): Line 291: return self._gluster.volumeGeoRepSessionDelete( Line 292: volumeName, -- To view, visit https://gerrit.ovirt.org/17644 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If8c979a89ce11a1622819c474b59dcf088733594 Gerrit-PatchSet: 30 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Darshan N dnara...@redhat.com Gerrit-Reviewer: Bala.FA barum...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Darshan N dnara...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Sahina Bose sab...@redhat.com Gerrit-Reviewer: Timothy Asir tjeya...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: asyncore: adding __impl attribute
Piotr Kliczewski has uploaded a new change for review. Change subject: asyncore: adding __impl attribute .. asyncore: adding __impl attribute Change-Id: I16f4a9f98a1d8ca490db3e29d6becedb4ac52ea8 Signed-off-by: pkliczewski piotr.kliczew...@gmail.com --- M lib/yajsonrpc/betterAsyncore.py 1 file changed, 3 insertions(+), 0 deletions(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/00/39000/1 diff --git a/lib/yajsonrpc/betterAsyncore.py b/lib/yajsonrpc/betterAsyncore.py index 7101768..1ce4fbc 100644 --- a/lib/yajsonrpc/betterAsyncore.py +++ b/lib/yajsonrpc/betterAsyncore.py @@ -26,6 +26,9 @@ class Dispatcher(asyncore.dispatcher): def __init__(self, impl=None, sock=None, map=None): +# This has to be done before the super initialization because +# dispatcher implements __getattr__. +self.__impl = None asyncore.dispatcher.__init__(self, sock=sock, map=map) if impl is not None: self.switch_implementation(impl) -- To view, visit https://gerrit.ovirt.org/39000 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I16f4a9f98a1d8ca490db3e29d6becedb4ac52ea8 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski piotr.kliczew...@gmail.com ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: tests: making as broken
Piotr Kliczewski has posted comments on this change. Change subject: tests: making as broken .. Patch Set 1: Verified+1 Verified locally and by jenkins -- To view, visit https://gerrit.ovirt.org/39001 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iffbb482124427502f266dc97306482ab23c6d1c6 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: jsonrpc: events
Piotr Kliczewski has posted comments on this change. Change subject: jsonrpc: events .. Patch Set 11: Verified+1 Rebased, fixed comments, verified with latest engine (master). -- To view, visit https://gerrit.ovirt.org/38069 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id27b5ca1773139932eb5cb16921d5abec4991c5e Gerrit-PatchSet: 11 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Dima Kuznetsov dkuzn...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: asyncore: heartbeat fix
Piotr Kliczewski has posted comments on this change. Change subject: asyncore: heartbeat fix .. Patch Set 1: Verified+1 Verified with latest engine (master) by installing host and adding storage. No heartbeat issues found. -- To view, visit https://gerrit.ovirt.org/38988 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icad61fb62509764e8ecdd6f87ef60557f4465368 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: stomp: Stomp encoder\decoder improvements
Piotr Kliczewski has posted comments on this change. Change subject: stomp: Stomp encoder\decoder improvements .. Patch Set 12: Verified+1 Verified with latest engine (master) -- To view, visit https://gerrit.ovirt.org/35255 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I341e46463e654ae0a086cd49af18aa336b86cb6e Gerrit-PatchSet: 12 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Dima Kuznetsov dkuzn...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: asyncore: heartbeat fix
Hello Saggi Mizrahi, I'd like you to do a code review. Please visit https://gerrit.ovirt.org/38988 to review the following change. Change subject: asyncore: heartbeat fix .. asyncore: heartbeat fix When getting new timeout for asyncore loop we get None several times in a row we are forced to wait for dispatcher event. We expect to process heartbeat events so we need to set timeout to asyncore default value which is 30 seconds. Change-Id: Icad61fb62509764e8ecdd6f87ef60557f4465368 Signed-off-by: Saggi Mizrahi smizr...@redhat.com Signed-off-by: pkliczewski piotr.kliczew...@gmail.com --- M lib/yajsonrpc/betterAsyncore.py 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/88/38988/1 diff --git a/lib/yajsonrpc/betterAsyncore.py b/lib/yajsonrpc/betterAsyncore.py index 7101768..2f1122d 100644 --- a/lib/yajsonrpc/betterAsyncore.py +++ b/lib/yajsonrpc/betterAsyncore.py @@ -203,7 +203,7 @@ self._map.clear() def _get_timeout(self, map): -timeout = None +timeout = 30.0 for disp in self._map.values(): if hasattr(disp, next_check_interval): interval = disp.next_check_interval() -- To view, visit https://gerrit.ovirt.org/38988 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Icad61fb62509764e8ecdd6f87ef60557f4465368 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: stomp: make subscription class local
Hello Saggi Mizrahi, I'd like you to do a code review. Please visit https://gerrit.ovirt.org/38990 to review the following change. Change subject: stomp: make subscription class local .. stomp: make subscription class local Change-Id: Iabe55399860e92e7a0a41feba9879a8b82d5c786 Signed-off-by: Saggi Mizrahi smizr...@redhat.com Signed-off-by: pkliczewski piotr.kliczew...@gmail.com --- M lib/yajsonrpc/stomp.py 1 file changed, 2 insertions(+), 2 deletions(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/90/38990/1 diff --git a/lib/yajsonrpc/stomp.py b/lib/yajsonrpc/stomp.py index 3f31954..2be7a51 100644 --- a/lib/yajsonrpc/stomp.py +++ b/lib/yajsonrpc/stomp.py @@ -366,7 +366,7 @@ def put_subscribe(self, destination, ack=None): subid = self._aclient.subscribe(self._adisp, destination, ack) -sub = Subsciption(self, subid, ack) +sub = _Subsciption(self, subid, ack) self._registerSubscription(sub) return sub @@ -575,7 +575,7 @@ return subscriptionID -class Subsciption(object): +class _Subsciption(object): def __init__(self, client, subid, ack): self._ack = ack self._subid = subid -- To view, visit https://gerrit.ovirt.org/38990 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Iabe55399860e92e7a0a41feba9879a8b82d5c786 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: jsonrpc: extending buffer size
Hello Saggi Mizrahi, I'd like you to do a code review. Please visit https://gerrit.ovirt.org/38989 to review the following change. Change subject: jsonrpc: extending buffer size .. jsonrpc: extending buffer size Signed-off-by: Saggi Mizrahi smizr...@redhat.com Change-Id: I2b1f4d8e6c2c4e6ae1bb2c7371804c35e905ee95 Signed-off-by: pkliczewski piotr.kliczew...@gmail.com --- M lib/yajsonrpc/stomp.py 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/89/38989/1 diff --git a/lib/yajsonrpc/stomp.py b/lib/yajsonrpc/stomp.py index 790c695..3f31954 100644 --- a/lib/yajsonrpc/stomp.py +++ b/lib/yajsonrpc/stomp.py @@ -397,7 +397,7 @@ class AsyncDispatcher(object): log = logging.getLogger(stomp.AsyncDispatcher) -def __init__(self, frameHandler, bufferSize=1024): +def __init__(self, frameHandler, bufferSize=4096): self._frameHandler = frameHandler self._bufferSize = bufferSize self._parser = Parser() -- To view, visit https://gerrit.ovirt.org/38989 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I2b1f4d8e6c2c4e6ae1bb2c7371804c35e905ee95 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: stomp: parsing buffer refactoring
Piotr Kliczewski has posted comments on this change. Change subject: stomp: parsing buffer refactoring .. Patch Set 6: Verified+1 Patch split in 3 and rebased. Verified with latest engine. -- To view, visit https://gerrit.ovirt.org/38666 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1b835e0d8a5ca20e67f0562955255ba1ad6ae9a1 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: jsonrpc: extending buffer size
Piotr Kliczewski has posted comments on this change. Change subject: jsonrpc: extending buffer size .. Patch Set 1: Verified+1 This change was part of stomp: parsing buffer refactoring. Verified with latest engine (master). -- To view, visit https://gerrit.ovirt.org/38989 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2b1f4d8e6c2c4e6ae1bb2c7371804c35e905ee95 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: stomp: server side subscriptions
Piotr Kliczewski has posted comments on this change. Change subject: stomp: server side subscriptions .. Patch Set 10: Code-Review+1 Rebased, fixed comments, verified with latest engine (master). -- To view, visit https://gerrit.ovirt.org/38451 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1493070f2ba66ca9d39a6661876c82c4727cad62 Gerrit-PatchSet: 10 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Dima Kuznetsov dkuzn...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com Gerrit-Reviewer: Oved Ourfali oourf...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: stomp: client side subscription
Piotr Kliczewski has posted comments on this change. Change subject: stomp: client side subscription .. Patch Set 11: Verified+1 Rebased, fixed comments, verified with latest engine (master). -- To view, visit https://gerrit.ovirt.org/36368 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8e43658f1cebd637ea3abf4396d388afa041ae71 Gerrit-PatchSet: 11 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Dima Kuznetsov dkuzn...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: events: vm status notifications
Piotr Kliczewski has posted comments on this change. Change subject: events: vm status notifications .. Patch Set 2: Communication verified with latest engine (master). VM status changes are sent very fast and sometimes db status changes influence vm life cycle. -- To view, visit https://gerrit.ovirt.org/38937 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I746299f9f1e2f49831a05072f19af1d242796276 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Dima Kuznetsov dkuzn...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Michal Skrivanek mskri...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: jsonrpc: Fix callMethod in JsonRpcClient
Piotr Kliczewski has posted comments on this change. Change subject: jsonrpc: Fix callMethod in JsonRpcClient .. Patch Set 11: Verified+1 Rebased. Verified with latest engine (master). -- To view, visit https://gerrit.ovirt.org/35935 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7cf78f3b7f5d32c10339bbe6b49ce9b93662b4bb Gerrit-PatchSet: 11 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: stomp: Always pop the frame for frame handler
Piotr Kliczewski has posted comments on this change. Change subject: stomp: Always pop the frame for frame handler .. Patch Set 11: Verified+1 Rebased, verified with latest engine (master). -- To view, visit https://gerrit.ovirt.org/35940 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9cd3c5b9ad70cf49e1b105260548720d5b34ea9a Gerrit-PatchSet: 11 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: stomp: outgoing connection to a broker
Piotr Kliczewski has posted comments on this change. Change subject: stomp: outgoing connection to a broker .. Patch Set 5: Verified+1 Rebased, fixed event queue name (engine side comment). Not verified with broker but confirmed that it has no regression effect on communication with latest engine (master). -- To view, visit https://gerrit.ovirt.org/38819 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ied3095a305fd5a5bfc19c8bc0342fba7cb811843 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Dima Kuznetsov dkuzn...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: gluster: modified parsing logic in snapshot config list.
Piotr Kliczewski has posted comments on this change. Change subject: gluster: modified parsing logic in snapshot config list. .. Patch Set 1: Verified+1 Schema change looks good. -- To view, visit https://gerrit.ovirt.org/38758 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3c56c7448f6316835978577e4514568ddeb4a5ea Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Darshan N dnara...@redhat.com Gerrit-Reviewer: Bala.FA barum...@redhat.com Gerrit-Reviewer: Darshan N dnara...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Shubhendu Tripathi shtri...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: ceph: Initial support for network disk
Piotr Kliczewski has posted comments on this change. Change subject: ceph: Initial support for network disk .. Patch Set 4: Code-Review+1 Schema change looks good -- To view, visit https://gerrit.ovirt.org/38766 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1c5792bb6206a227ee0c2df9490b771a69c0093c Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Adam Litke ali...@redhat.com Gerrit-Reviewer: Allon Mureinik amure...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Daniel Erez de...@redhat.com Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Sahina Bose sab...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: asyncore: dynamic tick support
Piotr Kliczewski has posted comments on this change. Change subject: asyncore: dynamic tick support .. Patch Set 14: (2 comments) https://gerrit.ovirt.org/#/c/37057/14/lib/yajsonrpc/stomp.py File lib/yajsonrpc/stomp.py: Line 442: def _outgoing_heartbeat_expiration_interval(self): Line 443: since_last_update = (monotonic_time() - self._lastOutgoingTimeStamp) Line 444: return (self._outgoing_heartbeat_in_milis / 1000.0) - since_last_update Line 445: Line 446: def next_check_interval(self, dispatcher): im confused why this function gets dispatcher.. can you show me what am i m It looks like having dispatcher is only for consistency with other functions in Dispatcher. Line 447: if self._outgoing_heartbeat_in_milis == 0: Line 448: return None Line 449: Line 450: return max(self._outgoing_heartbeat_expiration_interval(), 0) Line 444: return (self._outgoing_heartbeat_in_milis / 1000.0) - since_last_update Line 445: Line 446: def next_check_interval(self, dispatcher): Line 447: if self._outgoing_heartbeat_in_milis == 0: Line 448: return None and why not returning -1? None might refer to 0 in some languages Please refer to docsting in betterAsyncore. Line 449: Line 450: return max(self._outgoing_heartbeat_expiration_interval(), 0) Line 451: Line 452: def handle_write(self, dispatcher): -- To view, visit https://gerrit.ovirt.org/37057 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I44b38e961d46e914bb687c924ba4e83f38371d5b Gerrit-PatchSet: 14 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Dima Kuznetsov dkuzn...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: stomp: parsing buffer refactoring
Piotr Kliczewski has posted comments on this change. Change subject: stomp: parsing buffer refactoring .. Patch Set 2: (1 comment) https://gerrit.ovirt.org/#/c/38666/2/lib/yajsonrpc/stomp.py File lib/yajsonrpc/stomp.py: Line 159: self._flush() Line 160: Line 161: def _change_state(self, new_state): Line 162: self._state = new_state Line 163: self._state_cb = self._states[new_state] please declare those attributes in init with default values Can you please tell what do you want to declare? In __init__ we initialize _states as well as we set initial state to _STATE_CMD. Line 164: Line 165: def _flush(self): Line 166: self._buffer = Line 167: -- To view, visit https://gerrit.ovirt.org/38666 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1b835e0d8a5ca20e67f0562955255ba1ad6ae9a1 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: stomp: Pop the frame even if a frame handler isn't defined
Piotr Kliczewski has posted comments on this change. Change subject: stomp: Pop the frame even if a frame handler isn't defined .. Patch Set 7: (1 comment) https://gerrit.ovirt.org/#/c/35940/7/lib/yajsonrpc/stomp.py File lib/yajsonrpc/stomp.py: Line 439: Line 440: frameHandler = self._frameHandler Line 441: while parser.pending 0: Line 442: frame = parser.popFrame() Line 443: frameHandler.handle_frame(self, frame) why not directly - Done Line 444: Line 445: def popFrame(self): Line 446: return self._parser.popFrame() Line 447: -- To view, visit https://gerrit.ovirt.org/35940 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9cd3c5b9ad70cf49e1b105260548720d5b34ea9a Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: Have the protocol detector use the Reactor
Piotr Kliczewski has posted comments on this change. Change subject: Have the protocol detector use the Reactor .. Patch Set 11: (8 comments) https://gerrit.ovirt.org/#/c/37098/11/lib/vdsm/sslutils.py File lib/vdsm/sslutils.py: Line 60: # we buffer first consumed message Line 61: def read(self, size=4096, flag=None): Line 62: result = None Line 63: if flag == socket.MSG_PEEK: Line 64: bytes_left = size - len(self._data) was it a bug? It seems like a bug fix. Line 65: if bytes_left 0: Line 66: self._data += self.connection.read(bytes_left) Line 67: result = self._data Line 68: else: Line 65: if bytes_left 0: Line 66: self._data += self.connection.read(bytes_left) Line 67: result = self._data Line 68: else: Line 69: if self._data: please state if self._data != '' if you don't use None anymore We can get None from ssl_read_nbio (connection.read) so we need to check it here. Line 70: result = self._data Line 71: self._data = '' Line 72: else: Line 73: result = self.connection.read(size) Line 250: self.key_file = key_file Line 251: self.cert_file = cert_file Line 252: Line 253: Line 254: class SSLHandshakeWrapper(object): it should be called SSLHandshakeDispatcher or at least state that this clas Will change the name. Line 255: log = logging.getLogger(ProtocolDetector.SSLHandshakeWrapper) Line 256: SSL_HANDSHAKE_TIMEOUT = 10 Line 257: Line 258: def __init__( Line 264: self._give_up_at = monotonic_time() + handshake_timeout Line 265: self._has_been_set_up = False Line 266: self._is_handshaking = True Line 267: self._sslctx = sslctx Line 268: self._handshake_finished_handler = handshake_finished_handler what is handshake_finished_handler? please document a bit .. at least what Done Line 269: Line 270: def _set_up_socket(self, dispatcher): Line 271: client_socket = dispatcher.socket Line 272: client_socket = self._sslctx.wrapSocket(client_socket) Line 271: client_socket = dispatcher.socket Line 272: client_socket = self._sslctx.wrapSocket(client_socket) Line 273: # Older versions of M2Crypto ignore nbio and retry internally Line 274: # if timeout is set. Line 275: client_socket.settimeout(None) isn't this timeout define the session timeout? don't we need to expose this I am not sure what you mean here but comment above can help. Line 276: client_socket.address = client_socket.getpeername() Line 277: try: Line 278: client_socket.setup_ssl() Line 279: client_socket.set_accept_state() Line 277: try: Line 278: client_socket.setup_ssl() Line 279: client_socket.set_accept_state() Line 280: except SSL.SSLError as e: Line 281: self.log.warning(Error setting up ssl: %s, e) only warning? it should be error Done Line 282: dispatcher.close() Line 283: return Line 284: Line 285: dispatcher.socket = client_socket Line 304: if self._is_handshaking: Line 305: try: Line 306: self._is_handshaking = (dispatcher.socket.accept_ssl() == 0) Line 307: except Exception as e: Line 308: self.log.debug(Error during handshake: %s, e) error Done Line 309: dispatcher.close() Line 310: Line 311: if not self._is_handshaking: https://gerrit.ovirt.org/#/c/37098/11/vdsm/protocoldetector.py File vdsm/protocoldetector.py: Line 35: def _create_socket(host, port): Line 36: addr = socket.getaddrinfo(host, port, socket.AF_INET, Line 37: socket.SOCK_STREAM) Line 38: if not addr: Line 39: raise Exception(Could not translate address '%s:%s' raise socket.error Done Line 40: % (host, str(port))) Line 41: Line 42: server_socket = socket.socket(addr[0][0], addr[0][1], addr[0][2]) Line 43: filecontrol.set_close_on_exec(server_socket.fileno()) -- To view, visit https://gerrit.ovirt.org/37098 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If1cc2a205cdad335e8c3af4a77ed49c8977a79ba Gerrit-PatchSet: 11 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: stomp: Make sure the \0 is a last char in the buffer
Piotr Kliczewski has posted comments on this change. Change subject: stomp: Make sure the \0 is a last char in the buffer .. Patch Set 7: I sill would like to keep. During development I have seen it being thrown so let's use it as sanity check. -- To view, visit https://gerrit.ovirt.org/35938 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie0d8eaae161f3ec6c77726f4f9da044ab7c629d4 Gerrit-PatchSet: 7 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: tests: making sure that after events changes all tests passes
Piotr Kliczewski has posted comments on this change. Change subject: tests: making sure that after events changes all tests passes .. Patch Set 4: Verified+1 Verified locally and by jenkins (schema validation failed the build). No issues with tests spotted. -- To view, visit https://gerrit.ovirt.org/39031 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I23302c7f742f31f0ab5e12265da3bb7f57a81d80 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: schema: temporarily skip getMigrationStatus
Piotr Kliczewski has posted comments on this change. Change subject: schema: temporarily skip getMigrationStatus .. Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/39062 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I86b15d626314e679b7fecb6d40cb9d950086fe27 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Shahar Havivi shav...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: gluster: Patch adds geo-replication create and delete verbs.
Piotr Kliczewski has posted comments on this change. Change subject: gluster: Patch adds geo-replication create and delete verbs. .. Patch Set 32: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/17644 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: If8c979a89ce11a1622819c474b59dcf088733594 Gerrit-PatchSet: 32 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Darshan N dnara...@redhat.com Gerrit-Reviewer: Bala.FA barum...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Darshan N dnara...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Sahina Bose sab...@redhat.com Gerrit-Reviewer: Timothy Asir tjeya...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: gluster: Fix arguments name for geo-replication status verb.
Piotr Kliczewski has posted comments on this change. Change subject: gluster: Fix arguments name for geo-replication status verb. .. Patch Set 2: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/39222 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2f2b935caae97d3f70ae002d9b66288f30a42c14 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Darshan N dnara...@redhat.com Gerrit-Reviewer: Bala.FA barum...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Darshan N dnara...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Sahina Bose sab...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: xmlrpc: detecting loop on centos7
Piotr Kliczewski has posted comments on this change. Change subject: xmlrpc: detecting loop on centos7 .. Patch Set 2: (1 comment) https://gerrit.ovirt.org/#/c/39343/2/lib/yajsonrpc/betterAsyncore.py File lib/yajsonrpc/betterAsyncore.py: Line 101: return Line 102: Line 103: # we need to check whether there is pending function on Line 104: # our fd because we use eventfds which do not provide it Line 105: if hasattr(self.socket, pending): shouldn't that logic be avoided by the pending attribute ? can it be set to We still need this logic when we receive big message so we need to process it all. We are fixing specific issue with xmlrpc which is processed differently and jsonrpc should be processed as it was so far. Line 106: while self.socket.pending() 0 and self.connected: Line 107: self.handle_read() Line 108: Line 109: def recv(self, buffer_size): -- To view, visit https://gerrit.ovirt.org/39343 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I238d10b3bd8aaf8baac55ec81a7d406609e544e6 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Ido Barkan ibar...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: xmlrpc: detecting loop on centos7
Piotr Kliczewski has posted comments on this change. Change subject: xmlrpc: detecting loop on centos7 .. Patch Set 2: (1 comment) https://gerrit.ovirt.org/#/c/39343/2/lib/yajsonrpc/betterAsyncore.py File lib/yajsonrpc/betterAsyncore.py: Line 101: return Line 102: Line 103: # we need to check whether there is pending function on Line 104: # our fd because we use eventfds which do not provide it Line 105: if hasattr(self.socket, pending): it sound like all this specific xmlrpc logic should be handled in the handl The difference is that xmlrpc is already handled differently. Jsonrpc is processed using asyncore whereas xmlrpc is processed by xmlrpc implementation. At this point when we detected the protocol we still want to process jsonrpc as we were before and we do not want further processing for xmlrpc which at this point is being handled in different place. This code is run by both protocols and this is the last common peace for both. We want to skip pending pool for xmlrpc. Line 106: while self.socket.pending() 0 and self.connected: Line 107: self.handle_read() Line 108: Line 109: def recv(self, buffer_size): -- To view, visit https://gerrit.ovirt.org/39343 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I238d10b3bd8aaf8baac55ec81a7d406609e544e6 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Ido Barkan ibar...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: xmlrpc: detecting loop on centos7
Piotr Kliczewski has posted comments on this change. Change subject: xmlrpc: detecting loop on centos7 .. Patch Set 2: Verified by running functional/networkTests.py on centos7 and confirmed that there is no regression by running unit tests on f20. -- To view, visit https://gerrit.ovirt.org/39343 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I238d10b3bd8aaf8baac55ec81a7d406609e544e6 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: stomp: Stomp encoder\decoder improvements
Piotr Kliczewski has posted comments on this change.
Change subject: stomp: Stomp encoder\decoder improvements
..
Patch Set 12:
(3 comments)
https://gerrit.ovirt.org/#/c/35255/12/lib/yajsonrpc/stomp.py
File lib/yajsonrpc/stomp.py:
Line 77: _heartBeatFrame = _HeartBeatFrame()
Line 78:
Line 79:
Line 80: class Frame(object):
Line 81: __slots__ = (headers, command, body)
this does not belong to this patch. it's an unrelated performance optimizat
Will move to separate patch.
Line 82:
Line 83: def __init__(self, command=, headers=None, body=None):
Line 84: self.command = command
Line 85: if headers is None:
Line 117: def copy(self):
Line 118: return Frame(self.command, self.headers.copy(), self.body)
Line 119:
Line 120:
Line 121: def decodeValue(s):
the encodeValue/decodeValue functions just beg to have a unit test, making
Done
Line 122: # Make sure to leave this check before decoding as ':' can appear
in the
Line 123: # value after decoding using \c
Line 124: if : in s:
Line 125: raise ValueError(Contains illigal charachter `:`)
Line 138: def encodeValue(s):
Line 139: if isinstance(s, unicode):
Line 140: s = s.encode('utf-8')
Line 141: elif not isinstance(s, str):
Line 142: s = str(s)
why do we want this? it makes encodeValue non-reversible. Normally, I'd rat
Will improve
Line 143:
Line 144: return _RE_ENCODE_CHARS.sub(lambda m: _EC_ENCODE_MAP[m.group(0)],
s)
Line 145:
Line 146:
--
To view, visit https://gerrit.ovirt.org/35255
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I341e46463e654ae0a086cd49af18aa336b86cb6e
Gerrit-PatchSet: 12
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi smizr...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Dima Kuznetsov dkuzn...@redhat.com
Gerrit-Reviewer: Francesco Romani from...@redhat.com
Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com
Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: xmlrpc: detecting loop on centos7
Piotr Kliczewski has posted comments on this change. Change subject: xmlrpc: detecting loop on centos7 .. Patch Set 2: Verified+1 -- To view, visit https://gerrit.ovirt.org/39343 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I238d10b3bd8aaf8baac55ec81a7d406609e544e6 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: xmlrpc: detecting loop on centos7
Piotr Kliczewski has uploaded a new change for review. Change subject: xmlrpc: detecting loop on centos7 .. xmlrpc: detecting loop on centos7 When we process newly incoming connection we receive read event and we detect xmlrpc protocol and we call handle_dispatcher which removes dispatcher from further processing in asyncore loop and pass the socket to xmlrpc implementation which handles requests in different thread. After handling read we check whether there is more data awaits processing (buffer to small to handle all of it). When xmlrpc impl slowly prcesses a request we run several iterations of handle_read which leads to detection loop. When we detect xmlrpc protocol we do not want to get trapped by handle_read loop and for jsonrpc a dispatcher generates another read event which finalizes processing. Change-Id: I238d10b3bd8aaf8baac55ec81a7d406609e544e6 Signed-off-by: pkliczewski piotr.kliczew...@gmail.com --- M lib/yajsonrpc/betterAsyncore.py M vdsm/protocoldetector.py 2 files changed, 13 insertions(+), 0 deletions(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/43/39343/1 diff --git a/lib/yajsonrpc/betterAsyncore.py b/lib/yajsonrpc/betterAsyncore.py index ad11cc1..84c743d 100644 --- a/lib/yajsonrpc/betterAsyncore.py +++ b/lib/yajsonrpc/betterAsyncore.py @@ -96,6 +96,10 @@ self.handle_read() +if hasattr(self.__impl, recently_detected): +if self.__impl.recently_detected(): +return + # we need to check whether there is pending function on # our fd because we use eventfds which do not provide it if hasattr(self.socket, pending): diff --git a/vdsm/protocoldetector.py b/vdsm/protocoldetector.py index e3c8312..a2d2c8f 100644 --- a/vdsm/protocoldetector.py +++ b/vdsm/protocoldetector.py @@ -80,6 +80,7 @@ def __init__(self, detectors, timeout=None): self._detectors = detectors +self._recently_detected = False self._required_size = max(h.REQUIRED_SIZE for h in self._detectors) self.log.debug(Using required_size=%d, self._required_size) self._give_up_at = monotonic_time() + timeout @@ -89,6 +90,13 @@ def next_check_interval(self): return min(self._give_up_at - monotonic_time(), 0) + +def recently_detected(self): +if self._recently_detected: +self._recently_detected = False +return True + +return False def handle_read(self, dispatcher): sock = dispatcher.socket @@ -117,6 +125,7 @@ port ) detector.handle_dispatcher(dispatcher, (host, port)) +self._recently_detected = True break else: self.log.warning(Unrecognized protocol: %r, data) -- To view, visit https://gerrit.ovirt.org/39343 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I238d10b3bd8aaf8baac55ec81a7d406609e544e6 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski piotr.kliczew...@gmail.com ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: xmlrpc: detecting loop on centos7
Piotr Kliczewski has posted comments on this change. Change subject: xmlrpc: detecting loop on centos7 .. Patch Set 2: (2 comments) https://gerrit.ovirt.org/#/c/39343/2/lib/yajsonrpc/betterAsyncore.py File lib/yajsonrpc/betterAsyncore.py: Line 101: return Line 102: Line 103: # we need to check whether there is pending function on Line 104: # our fd because we use eventfds which do not provide it Line 105: if hasattr(self.socket, pending): well, call it xmlprc_detected instead of general name as recently_detected Done Line 106: while self.socket.pending() 0 and self.connected: Line 107: self.handle_read() Line 108: Line 109: def recv(self, buffer_size): https://gerrit.ovirt.org/#/c/39343/2/vdsm/protocoldetector.py File vdsm/protocoldetector.py: Line 124: host, Line 125: port Line 126: ) Line 127: detector.handle_dispatcher(dispatcher, (host, port)) Line 128: self._recently_detected = True you sign it to true on each detection.. how is it tight to xmlrpc? I will modify detector to provide this value. Line 129: break Line 130: else: Line 131: self.log.warning(Unrecognized protocol: %r, data) Line 132: dispatcher.close() -- To view, visit https://gerrit.ovirt.org/39343 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I238d10b3bd8aaf8baac55ec81a7d406609e544e6 Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Ido Barkan ibar...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: xmlrpc: detecting loop on centos7
Piotr Kliczewski has posted comments on this change. Change subject: xmlrpc: detecting loop on centos7 .. Patch Set 4: (3 comments) https://gerrit.ovirt.org/#/c/39343/4/lib/yajsonrpc/betterAsyncore.py File lib/yajsonrpc/betterAsyncore.py: Line 99 Line 100 Line 101 Line 102 Line 103 This is wrong - please see the original asyncore code which does not have t For xmlrpc is is done handle_dispatcher. it is called in handle_read. So the problematic piece of code is to running again handle_read in a loop. Line 95: self.handle_connect_event() Line 96: Line 97: self.handle_read() Line 98: Line 99: if hasattr(self.__impl, recently_detected): for my understanding: how it is possible for __impl *not* to have this attr There is more than one dispatcher implementation that we use and not all of them have this method. Line 100: if self.__impl.recently_detected(): Line 101: return Line 102: Line 103: # we need to check whether there is pending function on Line 97: self.handle_read() Line 98: Line 99: if hasattr(self.__impl, recently_detected): Line 100: if self.__impl.recently_detected(): Line 101: return This is the wrong solution. so the issue is that when we detect xmlrpc we remove it from asyncore processing map and we do not want to run handle_read. Line 102: Line 103: # we need to check whether there is pending function on Line 104: # our fd because we use eventfds which do not provide it Line 105: if hasattr(self.socket, pending): -- To view, visit https://gerrit.ovirt.org/39343 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I238d10b3bd8aaf8baac55ec81a7d406609e544e6 Gerrit-PatchSet: 4 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Ido Barkan ibar...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: vdscliTests: add a test for connect with a timeout
Piotr Kliczewski has posted comments on this change. Change subject: vdscliTests: add a test for connect with a timeout .. Patch Set 8: Code-Review-1 (1 comment) https://gerrit.ovirt.org/#/c/38806/8/tests/functional/vdscliTests.py File tests/functional/vdscliTests.py: Line 26: from vdsm import vdscli Line 27: Line 28: Line 29: class ConnectTest(TestCaseBase): Line 30: We have 2 tests run for useSSL true and false. Please use permutations and get rid of code duplication. Line 31: @ValidateRunningAsRoot Line 32: def testTimeoutSafeTransport(self): Line 33: c = vdscli.connect(useSSL=True, Line 34:tsPath='/etc/pki/vdsm', -- To view, visit https://gerrit.ovirt.org/38806 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I21793986338a00caa1163c7f9297d160a9d1fc45 Gerrit-PatchSet: 8 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: migration: Use jsonrpc during migration of vms
Piotr Kliczewski has posted comments on this change.
Change subject: migration: Use jsonrpc during migration of vms
..
Patch Set 5: Code-Review-1
(2 comments)
https://gerrit.ovirt.org/#/c/36701/5/lib/yajsonrpc/__init__.py
File lib/yajsonrpc/__init__.py:
Line 23: from vdsm.utils import traceback
Line 24:
Line 25: __all__ = [betterAsyncore, stompReactor, stomp]
Line 26:
Line 27: CALL_TIMEOUT = 15
Is this related to this change?
Line 28:
Line 29: _STATE_INCOMING = 1
Line 30: _STATE_OUTGOING = 2
Line 31: _STATE_ONESHOT = 4
https://gerrit.ovirt.org/#/c/36701/5/vdsm/virt/migration.py
File vdsm/virt/migration.py:
Line 127: self.remoteHost, port = hostPort.rsplit(':', 1)
Line 128:
Line 129: try:
Line 130: client_socket = self._createSocket(port)
Line 131: reactor = self._vm.cif.getReactor(stomp)
getReactor is in patch https://gerrit.ovirt.org/#/c/38491 which is next patch
in this branch. This means that this patch do not compile as it is now. Please
rebase.
Line 132: self._destServer = jsonrpcvdscli.connect(reactor,
client_socket)
Line 133: self.log.debug('Initiating connection with destination')
Line 134: self._destServer.ping()
Line 135:
--
To view, visit https://gerrit.ovirt.org/36701
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie38334e6cdcc4d7899bd5e836b3196567fc0bfd8
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yeela Kaplan ykap...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Dima Kuznetsov dkuzn...@redhat.com
Gerrit-Reviewer: Francesco Romani from...@redhat.com
Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com
Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com
Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com
Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com
Gerrit-Reviewer: Yeela Kaplan ykap...@redhat.com
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: gluster: Fix arguments name for geo-replication status verb.
Piotr Kliczewski has posted comments on this change. Change subject: gluster: Fix arguments name for geo-replication status verb. .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/39222 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2f2b935caae97d3f70ae002d9b66288f30a42c14 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Darshan N dnara...@redhat.com Gerrit-Reviewer: Bala.FA barum...@redhat.com Gerrit-Reviewer: Darshan N dnara...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Sahina Bose sab...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: ceph: Initial support for network disk
Piotr Kliczewski has posted comments on this change.
Change subject: ceph: Initial support for network disk
..
Patch Set 4:
(2 comments)
https://gerrit.ovirt.org/#/c/38766/4/vdsm/rpc/vdsmapi-schema.json
File vdsm/rpc/vdsmapi-schema.json:
Line 2541: #
Line 2542: # Since: 4.17.0
Line 2543: ##
Line 2544: {'type': 'NetworkDiskHostInfo',
Line 2545: 'data': {'name': 'str', 'port': 'str', 'transport': 'str'}}
for a future patch: do we want something stricter than 'str' for port and t
+1
Line 2546:
Line 2547: ##
Line 2548: # @VmDiskDevice:
Line 2549: #
Line 2627: 'apparentsize': 'uint', 'index': 'int', 'name': 'str',
Line 2628: 'optional': 'bool', 'shared': 'VmSharedDriveType',
Line 2629: 'truesize': 'uint', 'volumeChain':
['VmDiskDeviceVolumeChainEntry'],
Line 2630: '*baseVolumeID': 'UUID', '*diskType': 'str',
Line 2631: '*hosts': ['NetworkDiskHostInfo'], '*protocol': 'str'}}
Same: do we want to add some new enums here for diskType and protocol?
It would be good to adopt/reuse already existing like StorageDomainType.
Line 2632:
Line 2633: ##
Line 2634: # @VmInterfaceDeviceType:
Line 2635: #
--
To view, visit https://gerrit.ovirt.org/38766
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I1c5792bb6206a227ee0c2df9490b771a69c0093c
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer nsof...@redhat.com
Gerrit-Reviewer: Adam Litke ali...@redhat.com
Gerrit-Reviewer: Allon Mureinik amure...@redhat.com
Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com
Gerrit-Reviewer: Daniel Erez de...@redhat.com
Gerrit-Reviewer: Deepak C Shetty deepa...@linux.vnet.ibm.com
Gerrit-Reviewer: Federico Simoncelli fsimo...@redhat.com
Gerrit-Reviewer: Francesco Romani from...@redhat.com
Gerrit-Reviewer: Nir Soffer nsof...@redhat.com
Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com
Gerrit-Reviewer: Sahina Bose sab...@redhat.com
Gerrit-Reviewer: Timothy Asir tjeya...@redhat.com
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: gluster: Adds new verb to setup geo-rep mount broker.
Piotr Kliczewski has posted comments on this change. Change subject: gluster: Adds new verb to setup geo-rep mount broker. .. Patch Set 6: Code-Review+1 Schema and api changes looks good -- To view, visit https://gerrit.ovirt.org/38444 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9498c937bdf44b7747253e9bc203cb9eca1e671f Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Darshan N dnara...@redhat.com Gerrit-Reviewer: Bala.FA barum...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Darshan N dnara...@redhat.com Gerrit-Reviewer: David Caro dcaro...@redhat.com Gerrit-Reviewer: Eyal Edri ee...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Sandro Bonazzola sbona...@redhat.com Gerrit-Reviewer: Timothy Asir tjeya...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: gluster: Modified geo-rep verbs to include newly added user
Piotr Kliczewski has posted comments on this change. Change subject: gluster: Modified geo-rep verbs to include newly added user .. Patch Set 3: Code-Review+1 api and schema changes looks good -- To view, visit https://gerrit.ovirt.org/38318 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I336e6c8c6d433787bda4b508b87b6bf9a90f137a Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Darshan N dnara...@redhat.com Gerrit-Reviewer: Bala.FA barum...@redhat.com Gerrit-Reviewer: Darshan N dnara...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Sahina Bose sab...@redhat.com Gerrit-Reviewer: Timothy Asir tjeya...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: jsonrpc: extending buffer size
Piotr Kliczewski has posted comments on this change. Change subject: jsonrpc: extending buffer size .. Patch Set 1: I will update commit message -- To view, visit https://gerrit.ovirt.org/38989 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I2b1f4d8e6c2c4e6ae1bb2c7371804c35e905ee95 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Dima Kuznetsov dkuzn...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: stomp: parsing buffer refactoring
Piotr Kliczewski has posted comments on this change. Change subject: stomp: parsing buffer refactoring .. Patch Set 6: (1 comment) https://gerrit.ovirt.org/#/c/38666/6/lib/yajsonrpc/stomp.py File lib/yajsonrpc/stomp.py: Line 423: self._update_outgoing_heartbeat() Line 424: self._outgoing_heartbeat_in_milis = outgoing Line 425: Line 426: def handle_connect(self, dispatcher): Line 427: self._outbuf = None this is not related. please post in separate patch and explain why we need Will push it as separate patch and give explanation. Line 428: self._frameHandler.handle_connect(self) Line 429: Line 430: def handle_read(self, dispatcher): Line 431: try: -- To view, visit https://gerrit.ovirt.org/38666 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1b835e0d8a5ca20e67f0562955255ba1ad6ae9a1 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: stomp: client side subscription
Piotr Kliczewski has posted comments on this change. Change subject: stomp: client side subscription .. Patch Set 11: (2 comments) https://gerrit.ovirt.org/#/c/36368/11//COMMIT_MSG Commit Message: Line 7: stomp: client side subscription Line 8: Line 9: When connecting to the server we need to send subscribe frame to receive Line 10: messages. Line 11: can you explain more what is done by this patch - removing client, jsonrpcC Will update the message. Line 12: Change-Id: I8e43658f1cebd637ea3abf4396d388afa041ae71 https://gerrit.ovirt.org/#/c/36368/11/lib/yajsonrpc/__init__.py File lib/yajsonrpc/__init__.py: Line 164: Line 165: result = obj.get(result) Line 166: error = obj.get(error) Line 167: Line 168: reqId = obj.get(id) why don't you need to check here - because notification do not contain id (according to spec) and we want to use the same code to parse both. Line 169: Line 170: return JsonRpcResponse(result, error, reqId) Line 171: Line 172: -- To view, visit https://gerrit.ovirt.org/36368 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8e43658f1cebd637ea3abf4396d388afa041ae71 Gerrit-PatchSet: 11 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Dima Kuznetsov dkuzn...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: schema: temporarily hide getMigrationStatus return
Piotr Kliczewski has posted comments on this change. Change subject: schema: temporarily hide getMigrationStatus return .. Patch Set 1: What do you think about adding VM.getMigrationStatus to IGNORED_CMDS in schemaValidation module with comment that it is temporary solution? -- To view, visit https://gerrit.ovirt.org/39062 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I86b15d626314e679b7fecb6d40cb9d950086fe27 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: tests: making sure that after events changes all tests passes
Piotr Kliczewski has uploaded a new change for review. Change subject: tests: making sure that after events changes all tests passes .. tests: making sure that after events changes all tests passes Change-Id: I23302c7f742f31f0ab5e12265da3bb7f57a81d80 Signed-off-by: pkliczewski piotr.kliczew...@gmail.com --- M tests/protocoldetectorTests.py M tests/scheduleTests.py 2 files changed, 4 insertions(+), 5 deletions(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/31/39031/1 diff --git a/tests/protocoldetectorTests.py b/tests/protocoldetectorTests.py index 8ef1582..4350e8d 100644 --- a/tests/protocoldetectorTests.py +++ b/tests/protocoldetectorTests.py @@ -58,8 +58,9 @@ client_socket.setblocking(1) client_socket.sendall(response) finally: -client_socket.shutdown(socket.SHUT_RDWR) -client_socket.close() +if client_socket is not None: +client_socket.shutdown(socket.SHUT_RDWR) +client_socket.close() t = threading.Thread(target=run) t.daemon = True diff --git a/tests/scheduleTests.py b/tests/scheduleTests.py index 4a5e52f..2774dda 100644 --- a/tests/scheduleTests.py +++ b/tests/scheduleTests.py @@ -24,7 +24,7 @@ from vdsm import schedule from vdsm import utils from testlib import VdsmTestCase -from testValidation import slowtest, brokentest +from testValidation import slowtest from testlib import permutations, expandPermutations @@ -94,7 +94,6 @@ task.wait(delay + self.GRACETIME) self.assertEquals(task.call_time, None) -@brokentest @permutations(PERMUTATIONS) def test_cancel_call_many(self, clock): self.create_scheduler(clock) @@ -121,7 +120,6 @@ task.wait(delay + self.GRACETIME) self.assertEquals(task.call_time, None) -@brokentest @permutations(PERMUTATIONS) def test_stop_scheduler_many(self, clock): self.create_scheduler(clock) -- To view, visit https://gerrit.ovirt.org/39031 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I23302c7f742f31f0ab5e12265da3bb7f57a81d80 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski piotr.kliczew...@gmail.com ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: asyncore: heartbeat fix
Piotr Kliczewski has posted comments on this change. Change subject: asyncore: heartbeat fix .. Patch Set 1: (2 comments) https://gerrit.ovirt.org/#/c/38988/1/lib/yajsonrpc/betterAsyncore.py File lib/yajsonrpc/betterAsyncore.py: Line 202: Line 203: self._map.clear() Line 204: Line 205: def _get_timeout(self, map): Line 206: timeout = 30.0 If this is the asyncore timeout, can you maybe import the constant from the This value is default value of timeout parameter and there is no constants that we can use. Line 207: for disp in self._map.values(): Line 208: if hasattr(disp, next_check_interval): Line 209: interval = disp.next_check_interval() Line 210: if interval is not None and interval = 0: Line 202: Line 203: self._map.clear() Line 204: Line 205: def _get_timeout(self, map): Line 206: timeout = 30.0 Maybe this should configurable or not passed at all if None? None is problematic here. That is why we had to change it. Usually timeout says how long asyncore loop is waiting for events if the timeout passes we check intervals and wait for events again. I could be any value here when we do not care but using asyncore default seems to be the best approach. Line 207: for disp in self._map.values(): Line 208: if hasattr(disp, next_check_interval): Line 209: interval = disp.next_check_interval() Line 210: if interval is not None and interval = 0: -- To view, visit https://gerrit.ovirt.org/38988 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icad61fb62509764e8ecdd6f87ef60557f4465368 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Dima Kuznetsov dkuzn...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Saggi Mizrahi smizr...@redhat.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: virt: remove unwanted 'response' aliasing
Piotr Kliczewski has posted comments on this change. Change subject: virt: remove unwanted 'response' aliasing .. Patch Set 3: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/38803 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I53f91af7e6d28aaf033bfb589216c0422bd4a311 Gerrit-PatchSet: 3 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Francesco Romani from...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Sandro Bonazzola sbona...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: xmlrpc: detecting loop on centos7
Piotr Kliczewski has posted comments on this change. Change subject: xmlrpc: detecting loop on centos7 .. Patch Set 5: (1 comment) https://gerrit.ovirt.org/#/c/39343/5/lib/vdsm/sslutils.py File lib/vdsm/sslutils.py: Line 54: self.connection.shutdown(socket.SHUT_RDWR) Line 55: self.connection.close() Line 56: # if we do not close socket we get ssl protocol shutdown Line 57: # but fd is not released Line 58: self.connection.socket.close() Maybe the fix should go into m2c? I agree we can start the process to push it there. From my experience I know that it takes a lot of time to push anything there so let's have it in our code and when the fix is in m2c we can revert it. Line 59: Line 60: def fileno(self): Line 61: return self.connection.fileno() Line 62: -- To view, visit https://gerrit.ovirt.org/39343 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I238d10b3bd8aaf8baac55ec81a7d406609e544e6 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Ido Barkan ibar...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: Yes ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: tests: making sure that after events changes all tests passes
Piotr Kliczewski has posted comments on this change. Change subject: tests: making sure that after events changes all tests passes .. Patch Set 5: Verified+1 Verified by running local build on f20. -- To view, visit https://gerrit.ovirt.org/39031 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I23302c7f742f31f0ab5e12265da3bb7f57a81d80 Gerrit-PatchSet: 5 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Dima Kuznetsov dkuzn...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: Yeela Kaplan ykap...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: events: vm status notifications
Piotr Kliczewski has posted comments on this change.
Change subject: events: vm status notifications
..
Patch Set 2:
(2 comments)
https://gerrit.ovirt.org/#/c/38937/2/vdsm/virt/vm.py
File vdsm/virt/vm.py:
Line 1578: self._guestCpuRunning = isRunning
Line 1579: if (not self._guestCpuRunning and
Line 1580: self._lastStatus in vmstatus.PAUSED_STATES):
Line 1581: self.cif.notify('|virt|VM_status|' + self.id,
Line 1582: **{self.id: 'Paused'})
I think we should move/refactor this to have a sync between setting _lastSt
As I understand here we are interested in self._guestCpuRunning which
influences state on the engine. Can you help me to understand how we could
track it in _lastStatus?
Line 1583: finally:
Line 1584: if not guestCpuLocked:
Line 1585: self._guestCpuLock.release()
Line 1586:
Line 5011: self.log.warning('monitor become unresponsive'
Line 5012: ' (command timeout, age=%s)',
Line 5013: statsAge)
Line 5014: stats['monitorResponse'] = '-1'
Line 5015: self.cif.notify('|virt|VM_status|' + self.id,
I think the same applies here
Here we are interested to know that vm is not responding. There is no
corresponding status on vdsm side. Only the engine is interested in it.
Line 5016: **{self.id: 'NotResponding'})
Line 5017:
Line 5018:
Line 5019: class LiveMergeCleanupThread(threading.Thread):
--
To view, visit https://gerrit.ovirt.org/38937
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I746299f9f1e2f49831a05072f19af1d242796276
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski piotr.kliczew...@gmail.com
Gerrit-Reviewer: Dima Kuznetsov dkuzn...@redhat.com
Gerrit-Reviewer: Francesco Romani from...@redhat.com
Gerrit-Reviewer: Michal Skrivanek michal.skriva...@redhat.com
Gerrit-Reviewer: Michal Skrivanek mskri...@redhat.com
Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com
Gerrit-Reviewer: Vinzenz Feenstra vfeen...@redhat.com
Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com
Gerrit-Reviewer: Yeela Kaplan ykap...@redhat.com
Gerrit-Reviewer: automat...@ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes
___
vdsm-patches mailing list
vdsm-patches@lists.fedorahosted.org
https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: xmlrpc: fd leak on centos7
Piotr Kliczewski has uploaded a new change for review. Change subject: xmlrpc: fd leak on centos7 .. xmlrpc: fd leak on centos7 We found that when running functional test networkTests we are leaking fds. Each seperate call ends with 1 fd not released. After long investigation I noticed that the leak was caused by not closing plain socket wrapped by ssl socket. Calling shutdown and close on ssl do not closes plain socket. Change-Id: I705b0cf39937fe8d175305ad8ea8ad615f3ffb49 Signed-off-by: pkliczewski piotr.kliczew...@gmail.com --- M lib/vdsm/sslutils.py 1 file changed, 3 insertions(+), 0 deletions(-) git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/06/39506/1 diff --git a/lib/vdsm/sslutils.py b/lib/vdsm/sslutils.py index 137a81e..a260fc6 100644 --- a/lib/vdsm/sslutils.py +++ b/lib/vdsm/sslutils.py @@ -53,6 +53,9 @@ def close(self): self.connection.shutdown(socket.SHUT_RDWR) self.connection.close() +# if we do not close socket we get ssl protocol shutdown +# but fd is not released +self.connection.socket.close() def fileno(self): return self.connection.fileno() -- To view, visit https://gerrit.ovirt.org/39506 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I705b0cf39937fe8d175305ad8ea8ad615f3ffb49 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski piotr.kliczew...@gmail.com ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: xmlrpc: detecting loop on centos7
Piotr Kliczewski has posted comments on this change. Change subject: xmlrpc: detecting loop on centos7 .. Patch Set 6: Verified+1 Verified on centos7 -- To view, visit https://gerrit.ovirt.org/39343 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I238d10b3bd8aaf8baac55ec81a7d406609e544e6 Gerrit-PatchSet: 6 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Dan Kenigsberg dan...@redhat.com Gerrit-Reviewer: Francesco Romani from...@redhat.com Gerrit-Reviewer: Ido Barkan ibar...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Yaniv Bronhaim ybron...@redhat.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: xmlrpc: fd leak on centos7
Piotr Kliczewski has posted comments on this change. Change subject: xmlrpc: fd leak on centos7 .. Patch Set 1: Verified+1 Verified on centos7 -- To view, visit https://gerrit.ovirt.org/39506 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I705b0cf39937fe8d175305ad8ea8ad615f3ffb49 Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: betterAsyncore: Fix event loop data stealing [1/2]
Piotr Kliczewski has posted comments on this change. Change subject: betterAsyncore: Fix event loop data stealing [1/2] .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/39513 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icf01f9a45ecf1e7d0ed14844f8203d7df32d2dcb Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
Change in vdsm[master]: betterAsyncore: Fix event loop data stealing [2/2]
Piotr Kliczewski has posted comments on this change. Change subject: betterAsyncore: Fix event loop data stealing [2/2] .. Patch Set 1: Code-Review+1 -- To view, visit https://gerrit.ovirt.org/39514 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5978b58ed47b7a3836f19b3b40fe857e43f76bae Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Nir Soffer nsof...@redhat.com Gerrit-Reviewer: Piotr Kliczewski piotr.kliczew...@gmail.com Gerrit-Reviewer: automat...@ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server Gerrit-HasComments: No ___ vdsm-patches mailing list vdsm-patches@lists.fedorahosted.org https://lists.fedorahosted.org/mailman/listinfo/vdsm-patches
