Re: Examples directory

2007-05-03 Thread Adam Winer
objections ? -M On 4/28/07, Matthias Wessendorf [EMAIL PROTECTED] wrote: On 4/28/07, Adam Winer [EMAIL PROTECTED] wrote: @Matthias: I think you added the examples directory, and put the trinidad-demo in as an example. However - this means we currently have two copies of the trinidad-demo, one

Re: client id problem

2007-04-30 Thread Adam Winer
. I'd be happy to test the 1.2 branch if I could find a maven repository for it :) You have to build it yourself, I'm afraid. Ongoing problems with continuum have prevented us from putting it in a maven repository. -- Adam Adam Winer a écrit : Is this on the 1.2 branch or the 1.1 trunk

Re: [process...] Trinidad moving to MyFaces

2007-04-27 Thread Adam Winer
I'm also reluctant to spin us off into a separate e-mail list. I do think we'll want a [Trinidad] convention for posts though. -- Adam On 4/27/07, Mike Kienenberger [EMAIL PROTECTED] wrote: I think Myfaces subprojects should be using the existing user and dev lists. Otherwise, you're getting

Examples directory

2007-04-27 Thread Adam Winer
@Matthias: I think you added the examples directory, and put the trinidad-demo in as an example. However - this means we currently have two copies of the trinidad-demo, one in examples and one at top level. Also, trinidad-examples is not built by default, as it's not one of the modules in the

FastMessageFormat to public API?

2007-04-27 Thread Adam Winer
Trinidad has a FastMessageFormat class in the impl that is a partial replacement for MessageFormat - and, last I tested, far faster for the typical case of use-once-and- throw-away scenario that comes up in webapps a lot. Any comments on moving it from

Re: SVN - move

2007-04-26 Thread Adam Winer
In general, no, but I got a bit more interested when you said the layout was going to change - how so? Did I miss an e-mail? Also, what about the branches - I'm very much in need of the 1.2 branch. -- Adam On 4/25/07, Matthias Wessendorf [EMAIL PROTECTED] wrote: hi, I am planing to move

Re: client id problem

2007-04-26 Thread Adam Winer
Is this on the 1.2 branch or the 1.1 trunk? -- Adam On 4/25/07, Anahide Tchertchian [EMAIL PROTECTED] wrote: Hi, I noticed that trinidad components client ids are not set up correctly when used inside a naming container that redefines its children client ids. I believe this could be fixed

Re: ADFFACES-466 - Issues in change persistence framework code

2007-04-26 Thread Adam Winer
I added one comment to the issue tracker: this patch adds global synchronization to the application of changes. This seems higly excessive! The responsibility for synchronization should belong on the implementation of ChangeManager.getComponentChanges(), not on its use. If you used a

Re: Dependencies ?

2007-04-24 Thread Adam Winer
I believe our JSF 1.2 code requires Shale Test 1.0.4, not 1.0.3. -- Adam On 4/24/07, Piyush Hari [EMAIL PROTECTED] wrote: Thanks for the reply Mike but this did not solve the problem. I had to include javaee.jar which I got when I installed Java EE 5 SDK on my machine. Also,I removed Myfaces

Re: [Graduation] Trinidad voted out of Incubator

2007-04-21 Thread Adam Winer
Woo-hoo! Thanks to all the contributors. Are we also going to move the issue list over? -- Adam On 4/21/07, Matthias Wessendorf [EMAIL PROTECTED] wrote: Dear Trinidad community, The Trinidad PPMC is pleased to let you know, that Trinidad has been voted out of the Apache Incubator. We got

Re: Client-side validation - enhance to match server-side

2007-04-20 Thread Adam Winer
would be more at home in trinidad-config.xml though. context-param param-name org.apache.myfaces.trinidadinternal.renderkit.INLINE_JS_VALIDATION/param-name param-valuetrue/param-value /context-param On 3/1/07, Adam Winer [EMAIL PROTECTED] wrote: Trinidad already has essentially the same

Re: MessageBundleTest._validateBundleParams

2007-04-20 Thread Adam Winer
? I'll file a bug that it's disabled, I'll enable it, when the translations arrive. On 4/19/07, Adam Winer [EMAIL PROTECTED] wrote: I think the test should just be dumping warnings, not failing. -- Adam On 4/19/07, Matthias Wessendorf [EMAIL PROTECTED] wrote: Hi, when putting

Re: Fwd: [jira] Reopened: (ADFFACES-445) Converters not working , Javascript error occuring on submit

2007-04-17 Thread Adam Winer
the underlying problem. Are there any other settings in either web.xml, faces-config or trindad-config which may affect that the required JavaScript isn't generated as supposed to? -- Safi Adam Winer skrev: Safurudin, Trinidad HTML source should always have something like: scriptvar

Re: [XRTS] overhaul of the NumberConverter messages (their details)

2007-04-11 Thread Adam Winer
Me too. The only downside is that these examples are a performance hit (a significant one, last time I profiled inputDate). NumberConverter is probably more lightweight than DateConverter. -- Adam On 4/11/07, Jeanne Waldman [EMAIL PROTECTED] wrote: That sounds great to me. - Jeanne Martin

Re: VOTE graduation (was Re: Next steps? (was Re: Is trinidad ready for graduation ?))

2007-04-11 Thread Adam Winer
[X] graduate as a subproject of the Apache MyFaces community [ ] graduate as a TLP [ ] not ready to graduate, because... On 4/11/07, Jeanne Waldman [EMAIL PROTECTED] wrote: [X] graduate as a subproject of the Apache MyFaces community [ ] graduate as a TLP [ ] not ready to graduate, because...

Re: Next steps? (was Re: Is trinidad ready for graduation ?)

2007-04-10 Thread Adam Winer
If there was an idea to split MyFaces into an implementation half and a component set half, each as separate TLPs, then I'd see your point - but as it is, MyFaces the TLP is both an implementation and (currently) 2 component sets. -- Adam On 4/10/07, Martin van den Bemt [EMAIL PROTECTED]

Re: [Fwd: Re: return an Iterator vs a List]

2007-04-09 Thread Adam Winer
the convenience of using a Collection class? -- Blake Sullivan Jeanne Waldman wrote: three out of six Original Message Subject: Re: return an Iterator vs a List Date: Wed, 4 Apr 2007 15:42:17 -0700 From: Adam Winer [EMAIL PROTECTED] Reply-To: adffaces-dev

Re: ADFFACES-191

2007-04-08 Thread Adam Winer
Martin, Just applied it. Sorry for the long delay. FYI, the patch works on Safari too. -- Adam On 4/4/07, Martin Koci [EMAIL PROTECTED] wrote: Hello, can anybody review ADFFACES-191? We are using suggested patch in a production environment without problems: windows, linux; firefox 1.5.X

Re: Next steps? (was Re: Is trinidad ready for graduation ?)

2007-04-07 Thread Adam Winer
On 4/7/07, Mike Kienenberger [EMAIL PROTECTED] wrote: I'm in favor of MyFaces for Trinidad. I would like to see Trinidad as the basis for Tomahawk JSF 1.2. However, if there is no interest in merging Tomahawk and Trinidad, then going with a TLP would be better. Right now, Tobago is in the

Re: JBoss Seam Trinidad integration

2007-04-04 Thread Adam Winer
On 3/29/07, Peter Muir [EMAIL PROTECTED] wrote: Hi I've started doing some work on this. On 02/02/07, Adam Winer [EMAIL PROTECTED] wrote: (1) Page in data as necessary, automatically I'm not entirely sure how this is supposed to be done with the CollectionModel. As we're using JPA what we

Re: Problem with showOneAccordion

2007-04-04 Thread Adam Winer
panelAccordion is rather badly broken, last I checked. See http://issues.apache.org/jira/browse/ADFFACES-398 And the renderer code for panelAccordion, panelRadio, panelChoice... shudder. Roughly speaking, everything in org.apache.myfaces.trinidadinternal.renderkit.html.layout needs to be

Re: VOTE RESULT (was Re: [vote] release of core (1.0.0-incubating))

2007-03-20 Thread Adam Winer
On 3/20/07, Matthias Wessendorf [EMAIL PROTECTED] wrote: got feedback from Noel, vote is closed. no release yet. Robert found some issues (almost caused by buggy maven plugins and already fixed here). The other one is the obfuscated JS files don't have the Apache license headers. Waiting on

Re: [Plugins] Obfuscator

2007-03-20 Thread Adam Winer
It's very intentional that we do this - the whole idea is to remove the wasteful download of content to the user. It's especially relevant since we concatenate these files. Including the Apache header on each and every one of those will waste on the order of 13K of bandwidth! Ugh. Do the

Re: Getting rid of an ugly assert usage

2007-03-15 Thread Adam Winer
Yeah, that abuse of assert always bugged me. -- Adam On 3/15/07, Simon Lessard [EMAIL PROTECTED] wrote: Hello all, I would like to get rid of the following code snippet from org.apache.myfaces.trinidadinternal.renderkit.core.xhtml.table.RowData and make that usage forbidden in our coding

Re: [NumberConverter] percentage vs. percent

2007-03-14 Thread Adam Winer
(both RI and MyFaces) So, they should change the doc to not say types... percentage -M On 3/14/07, Adam Winer [EMAIL PROTECTED] wrote: Yes, definitely. We should allow both. -- Adam On 3/13/07, Gabrielle Crawford [EMAIL PROTECTED] wrote: How strange. I think we should allow 'percentage' so

Re: Check for application specific resource bundle before the embedded one

2007-03-13 Thread Adam Winer
I guess +1 The spec only truly requires this for messages that are created by the JSF implementation, but it's common practice to apply this to other messages. -- Adam On 3/13/07, Gabrielle Crawford [EMAIL PROTECTED] wrote: +1 This seems to match the spec, which defines the algorithm

Re: Mark ui and uinode classes deprecated

2007-03-10 Thread Adam Winer
+1! -- Adam On 3/10/07, Simon Lessard [EMAIL PROTECTED] wrote: Hello all, Since most renderers were already made Faces major, I think it would be a good time to make the packages ui and uinode deprecated. Such change should allow us to easily detect remaining dependencies to those two

Re: [vote] release of core (1.0.0-incubating)

2007-03-09 Thread Adam Winer
In all honesty, I haven't had a chance to look at the bits... I'd want to vote +1, but that seems a bit against-the-spirit... -- Adam On 3/9/07, Bernd Bohmann [EMAIL PROTECTED] wrote: [ ] +1 (Binding) for PPMC members only [X] +1 for community members who have reviewed the bits [ ] +0 [ ] -1

Re: [vote] release of core (1.0.0-incubating)

2007-03-09 Thread Adam Winer
phew! :) -- Adam On 3/9/07, Mike Kienenberger [EMAIL PROTECTED] wrote: Hey Adam, It's open source. You're not obligated to be involved in everything and every decision :-) On 3/9/07, Adam Winer [EMAIL PROTECTED] wrote: In all honesty, I haven't had a chance to look at the bits... I'd

Re: about maven-faces-plugin

2007-03-09 Thread Adam Winer
On 3/8/07, Martin Marinschek [EMAIL PROTECTED] wrote: I still wonder if the approach MyFaces originally had wasn't better than the new approach of the generator in Trinidad. Apart from the fact of course that generation should happen on every run of the build - we kind of neglected that. What

Re: tr:datetimeconverter and shortish style

2007-03-09 Thread Adam Winer
The intent of the code is absolutely to use the two-digit year start to handle two-digits entries. If that isn't happening, it's a pretty bad bug. -- Adam On 3/8/07, Yee-wah Lee [EMAIL PROTECTED] wrote: Hi all, I see the following code in the (server-side) DateTimeConverter and think it may

Re-branch JSF 1.2?

2007-03-09 Thread Adam Winer
I'm thinking of re-branching JSF 1.2 from the current trunk. Does anyone have a reason to delay? -- Adam

Re: about maven-faces-plugin

2007-03-07 Thread Adam Winer
In general, I think the approach used by the faces plugin is a really good thing. You want as much autogenerated as possible (this made upgrading to JSF 1.2 vastly easier than without it). And the specific approach actually allows for treating the template .java files as fully compileable

Re: Volunteers for the Incubator board report ?

2007-03-07 Thread Adam Winer
I added some more material. -- Adam On 3/7/07, Matthias Wessendorf [EMAIL PROTECTED] wrote: updated On 3/6/07, Matthias Wessendorf [EMAIL PROTECTED] wrote: k On 3/6/07, Martin van den Bemt [EMAIL PROTECTED] wrote: I also (normally) tend to add something about what is planned / future

Re: about maven-faces-plugin

2007-03-07 Thread Adam Winer
advantage of being a piece of logic that I could code in minutes. (The principle of Good Enough applies. :) ) -- Adam The rest is fine, at least the part I was dealing w/ in order to get some stuff working in Trinidad -M On 3/7/07, Adam Winer [EMAIL PROTECTED] wrote: In general, I think

Re: myfaces version

2007-03-07 Thread Adam Winer
+1. -- Adam On 3/6/07, Matthias Wessendorf [EMAIL PROTECTED] wrote: hello, ok if I change the myfaces version from 1.1.4 to 1.1.5 ? at least I'd like to continue preparing the core release, based on that. if you agree, I'll update! -- Matthias Wessendorf http://tinyurl.com/fmywh further

Re: [JSF 1.2] UIXCOMMAND

2007-03-07 Thread Adam Winer
\maven-faces-plugin\main\java\org\apache\myfaces\trinidad\component -M On 3/5/07, Adam Winer [EMAIL PROTECTED] wrote: Yes. I'd have thought this would be marked deprecated on ActionSource, though, which means we'd be inheriting that deprecation? -- Adam On 3/5/07, Matthias Wessendorf [EMAIL

Re: GlobalConfiguratorImpl not called _releaseRequestContext

2007-03-07 Thread Adam Winer
I'd check to make sure how many times GlobalConfiguratorImpl. beginRequest() and endRequest() are being called per request. It should be once, but maybe it's happening twice on your machine, in which case a couple of stack dumps would be a good clue. -- Adam On 3/5/07, Matthias Wessendorf

Re: Client-side validation - enhance to match server-side

2007-03-01 Thread Adam Winer
Trinidad already has essentially the same functionality - input components can be marked as autoSubmit, at which point tabbing out will automatically trigger a server-side submit, and error messages will be automatically inserted into tr:messages, if present. (There's an existing bug where the

Re: @author tags

2007-03-01 Thread Adam Winer
We should be including the name of the patch author in every checkin message. I used to be in that habit, got out of it, and I'm trying to do a better job with it lately. -- Adam On 3/1/07, Simon Lessard [EMAIL PROTECTED] wrote: Not exactly, SVN show only the name of the commiter, not the

Re: using trinidad as non-default render-kit

2007-02-28 Thread Adam Winer
basically except for the RenderingContext creation. Theres also no such contract in the jsf RenderKit, so enforcement may turn out to become difficult. On 2/24/07, Adam Winer [EMAIL PROTECTED] wrote: Stefan, Take a look at the code in ViewHandlerImpl - w/regard to ExtendedRenderKitService

Re: Client-side validation - enhance to match server-side

2007-02-28 Thread Adam Winer
I'd be happy to see functionality like this too. The trickiest part is, I think, figuring out how to clear the messages. I agree with Matthias that we don't need GWT. We already have the client-side JS. It's just the code that decides to turn the messages into an alert that is the problem.

Re: @author tags

2007-02-28 Thread Adam Winer
I agree as well. There's something a little nice about @author tags as a way of giving credit to the people who aren't the obvious people on a project. But they're rarely kept up to date, and the implication of ownership is not very OSS-friendly. -- Adam On 2/26/07, Craig McClanahan [EMAIL

Re: versioning

2007-02-27 Thread Adam Winer
On 2/27/07, Matthias Wessendorf [EMAIL PROTECTED] wrote: Hi, I changed the trunk plugins to have 1.0.1-incubating-SNAPSHOT as its version. I changed the trunk core to have 1.0.1-incubating-SNAPSHOT as its version. I created also a branch for core to work on a release of 1.0.0-incubating, which

Re: [ANN] Release of Trinidad's Maven plugins (1.0.0-incubating)

2007-02-27 Thread Adam Winer
Thanks for all your work getting this out, Matthias! -- Adam On 2/27/07, Matthias Wessendorf [EMAIL PROTECTED] wrote: Hi, The Apache Trinidad community is pleased to announce its 1.0.0-incubation release of the Trinidad Maven2 plugins. These Maven2 plugins have been deployed to the Apache

Re: using trinidad as non-default render-kit

2007-02-21 Thread Adam Winer
the time for it. On 2/20/07, Adam Winer [EMAIL PROTECTED] wrote: Yep, re-reading it, that's exactly what you said. Sorry for the misunderstanding. So this is a tougher nut to crack. I can imagine some hacks to try to instantiate the rendering context on the fly, but nothing really obvious

Re: using trinidad as non-default render-kit

2007-02-20 Thread Adam Winer
. On 2/19/07, Adam Winer [EMAIL PROTECTED] wrote: Oh, I see. You're using Facelets. You need to configure things a bit differently than without Facelets. Check out: http://wiki.apache.org/myfaces/Facelets_with_Trinidad -- Adam On 2/16/07, Stefan Podkowinski [EMAIL PROTECTED] wrote: I just

Re: Split up the CSS across multiple files

2007-02-15 Thread Adam Winer
On 2/14/07, Chris Eidhof [EMAIL PROTECTED] wrote: Hey everyone, I really don't like very long files, and especially the long css-files. So I was wondering: why don't we split up the css-file into multiple files: one components-shared.css, and one file for each component. I think that this will

Re: versioning

2007-02-15 Thread Adam Winer
On 2/15/07, Matthias Wessendorf [EMAIL PROTECTED] wrote: Ok, ... so my plugins branch currently uses 1.0.1-incubating-SNAPSHOT I'll merge that to trunk AFTER we actually released the plugins. I think that technically this should happen now. 1.0.0 has already branched, right? If someone

Re: using trinidad as non-default render-kit

2007-02-15 Thread Adam Winer
Stefan, We have a JSF 1.2 branch of Trinidad which is well tested, and contains (nearly) the latest code. http://svn.apache.org/repos/asf/incubator/adffaces/branches/faces-1_2-070201/ The only bad news is that you currently have to build it yourself - we don't have an automated build going for

Re: [Skinning] FileSystemStyleCache code - ok to delete?

2007-02-12 Thread Adam Winer
Die die die. :) Unused code should almost always go. It can always be revived from source control, and if it's unused, the odds that it works steadily decreases as time goes on. -- Adam On 2/12/07, Jeanne Waldman [EMAIL PROTECTED] wrote: I'm trying to figure out what's going on in

Re: svn commit: r505339 - in /incubator/adffaces/trunk/trinidad: trinidad-api/src/main/java/org/apache/myfaces/trinidad/util/ trinidad-impl/src/main/java/org/apache/myfaces/trinidadinternal/config/upl

2007-02-09 Thread Adam Winer
This checkin doesn't seem right. The ClassLoaderUtils changes are unnecessary, as ClassLoaderUtils already checks the context ClassLoader first; there's no reason for the change to this code. And all the changes to the other classes are wrong: they should just be calling

Re: About the HTML Validator (W3C)

2007-02-07 Thread Adam Winer
IIRC, there's still some errors that we generate. I'd like to really reduce these as much as possible, though. -- Adam On 2/6/07, Matthias Wessendorf [EMAIL PROTECTED] wrote: I don't think so. -M On 2/7/07, Eric Marcoux [EMAIL PROTECTED] wrote: Hello, Does the Apache Trinidad

Re: RE : About the HTML Validator (W3C)

2007-02-07 Thread Adam Winer
We'd be happy to look at patches that improve our compatibility. -- Adam On 2/7/07, Eric Marcoux [EMAIL PROTECTED] wrote: Is there any plan to support HTML 4.01 Strict or Transitional in Trinidad or in the next version of ADF Faces RIA ? Thanks. ___

Re: Early Prototype - Dialog using DHTML / iFrame

2007-02-06 Thread Adam Winer
removing frame redirect from date picker also. Danny. On 2/3/07, Adam Winer [EMAIL PROTECTED] wrote: On 2/3/07, Danny Robinson [EMAIL PROTECTED] wrote: uploaded patch to jira - including extra bits for setting the dialog title using BodyRenderer. Nice! A few quick questions also

Re: Early Prototype - Dialog using DHTML / iFrame

2007-02-06 Thread Adam Winer
seem to work that well - everything is a bit too small (Safari + Firefox). -- Adam On 2/6/07, Adam Winer [EMAIL PROTECTED] wrote: Committed this patch - thanks! -- Adam On 2/6/07, Danny Robinson [EMAIL PROTECTED] wrote: OK, just uploaded an updated patch. Dialogs will now appear at a fixed

Re: [continuum] BUILD FAILURE: Apache Trinidad Impl

2007-02-05 Thread Adam Winer
Does anyone understand this build failure? It's looking as though the Trinidad Impl build is not finding the latest Trinidad API. A clean rebuild on my local machine completes successfully. -- Adam On 2/5/07, [EMAIL PROTECTED] [EMAIL PROTECTED] wrote: Online report :

Re: Early Prototype - Dialog using DHTML / iFrame

2007-02-02 Thread Adam Winer
. Hrm, when I get a chance to merge it in, I'll have a look. -- Adam Danny On 1/31/07, Adam Winer [EMAIL PROTECTED] wrote: Danny, I grabbed the patch, made a branch, and applied it. I fixed up some things: - Moved (almost) all of the popup dialog and panel popup JS code

Re: Oracle Skin Release

2007-02-02 Thread Adam Winer
RedwoodShores might be the best name ;) Mark Adam Winer wrote: Mark, FWIW, we probably should have deleted those images from Trinidad. Not because of licensing or anything - their license is fully transferred to Apache! - but because they're unused inside of Trinidad. I'd like to be able

Re: JBoss Seam Trinidad integration

2007-02-01 Thread Adam Winer
Pete, Hey, I'd be thrilled to see some better integration. On the subject of paging, et al: what'd be wonderful is a solid implementation of the Trinidad CollectionModel API, that could handle the following issues: (1) Page in data as necessary, automatically (2) Report good permanent row

Re: [Skinning] CSS selector limit hit in IE

2007-01-31 Thread Adam Winer
Having magic insider knowledge of the scenario where this problem occurs :), one of the major causes of it is using different keys for the same CSS rules. For example, we use af|selectManyShuttle and af|selectOrderShuttle, but they're basically the same thing. Merging the compressed versions of

Re: [Skinning] CSS selector limit hit in IE

2007-01-31 Thread Adam Winer
name? -- Adam On 1/31/07, Adam Winer [EMAIL PROTECTED] wrote: Having magic insider knowledge of the scenario where this problem occurs :), one of the major causes of it is using different keys for the same CSS rules. For example, we use af|selectManyShuttle and af|selectOrderShuttle, but they're

Re: unknown-version in generated css file

2007-01-30 Thread Adam Winer
jdev:jdev. - Jeanne Adam Winer wrote: The implementation version is defined in the manifest; since we're going from the StyleSheetDocumentParser's Package object, that should be the trinidad-impl.jar's MANIFEST.MF file. -- Adam On 1/19/07, Jeanne Waldman [EMAIL PROTECTED] wrote: Hi

Re: Early Prototype - Dialog using DHTML / iFrame

2007-01-30 Thread Adam Winer
Danny, I grabbed the patch, made a branch, and applied it. I fixed up some things: - Moved (almost) all of the popup dialog and panel popup JS code into TrPanelPopup and TrPopupDialog wrapper objects - Fix coding convention problems: no tabs allowed, braces on new lines - Instead of removing

Re: svn commit: r500011 - /incubator/adffaces/branches/jwaldman-portal/trinidad/trinidad-impl/src/main/java/org/apache/myfaces/trinidadinternal/renderkit/core/CoreRenderingContext.java

2007-01-25 Thread Adam Winer
Has this change been tested? I'm far from certain that this was purely an optimization. We often check whether there is a PartialPageContext to see if PPR is enabled, and if this check is removed, then a lot of code will (I think) assume that PPR is enabled and available when it is not. --

Problems with tables and transient components - should be fixed

2007-01-24 Thread Adam Winer
regarding NullPointerExceptions when the table has a comment directly in it, which I haven't looked into. Cheers, Adam Winer

Re: SortableModel should use Collator for sorting strings

2007-01-21 Thread Adam Winer
+1 to having *some* solution here. Perhaps SortableModel should have support for Comparators (which is implemented by Collators). One possible API would be: public MapString, Comparator getComparators(); ... so you could do: Collator collator =

Re: unknown-version in generated css file

2007-01-20 Thread Adam Winer
The implementation version is defined in the manifest; since we're going from the StyleSheetDocumentParser's Package object, that should be the trinidad-impl.jar's MANIFEST.MF file. -- Adam On 1/19/07, Jeanne Waldman [EMAIL PROTECTED] wrote: Hi, I see that when I run a demo jspx file, the

Re: [JSF 1.2] setXxx Methods on ExternalContextDecorator

2007-01-16 Thread Adam Winer
In the JSF 1.2 branch, yep, we have to. -- Adam On 1/16/07, Matthias Wessendorf [EMAIL PROTECTED] wrote: hi, in jsf 1.2 there are four new setXxx() methods available on the externalCtx clazz. Do we need to add them to our ExternalContextDecorator, like: @Override public void

Re: svn commit: r495895 - /incubator/adffaces/trunk/trinidad/trinidad-impl/src/main/java/org/apache/myfaces/trinidadinternal/io/XhtmlResponseWriter.java

2007-01-13 Thread Adam Winer
Whoa there! We can't make this change in JSF 1.1. In JSF 1.1, flush() has a very specific mixed meaning because of the interweaving of JSP execution and UIComponent rendering. flush() means some ordinary JSP output may be coming, so flush all buffered ResponseWriter content. In JSF 1.2,

Re: release plan

2007-01-12 Thread Adam Winer
And, I'd love to have the JSF 1.2 version released too - plugins and Trinidad itself - 'cause that's what I'm spending most of my time working with these days. I think that the full process for release should be: FOR PLUGINS: - Create m1 branch of plugins - Update version in POM of plugins

Re: immediate=true is ignored when auto submitting input components

2007-01-09 Thread Adam Winer
No, the code in UIXEditableValue is 100% correct, and there are no double validations, and this has nothing to do with any of the problems you're seeing. If immediate is true on an EditableValueHolder, it means that validation moves up from Process Validators to Apply Request Values; that's

Re: [PORTAL] Adamns inline questions

2006-12-27 Thread Adam Winer
-- Adam On 12/27/06, Scott O'Bryan [EMAIL PROTECTED] wrote: Hey Adam, In your last checkin to my branch you made some comments I would like to address. In the DispatchResponseConfiguratorImpl there is an isApplied function. You were asking why it was there. The reason for this is simple..

Re: [Skinning Enhancement] -tr-icon-class or equivalent

2006-12-27 Thread Adam Winer
I think, for now, that I'm OK with just requiring inline specification of the styles - that feels a lot more natural in a CSS file. At least, as long as it works. :) -- Adam On 12/27/06, Jeanne Waldman [EMAIL PROTECTED] wrote: Hi there, I see the need to render img class=someClass width=10

Re: [PORTAL] Changes and API review?

2006-12-23 Thread Adam Winer
Adam Winer wrote: On 12/21/06, Scott O'Bryan [EMAIL PROTECTED] wrote: Adam, Well, you basically implemented one of the solutions I said I didn't like earlier, but oh well. And there are a number of places you need to cast. So the concerns are still valid. Well, I don't get that claim, as I

Re: [PORTAL] Changes and API review?

2006-12-21 Thread Adam Winer
Scott, OK, well, I just went ahead and implemented what I was trying to say, to see if I'd run into the problems you're describing. I didn't... (It's possible I've broken something in portlet land - I only tested the changes in a servlet environment.) On 12/21/06, Scott O'Bryan [EMAIL

Re: [PORTAL] Changes and API review?

2006-12-21 Thread Adam Winer
+ initialize construct is more robust than a create-and-hope- it-gets-initialized-by-someone-else construct. -- Adam Either way, don't see as I really have the time to argue. So is it acceptable to everyone? Also, there is no Adam Winer wrote: Scott, OK, well, I just went ahead

Re: [PORTAL] Changes and API review?

2006-12-19 Thread Adam Winer
suggestions have been invaluable. :) Now... Adam Winer wrote: So I guess basically I'm making one last appeal on the GlobalConfigurator thing. If you still want it removed I'll get rid of it. But I honestly think we're backing ourselves into an unnecessary corner. I'll give in on everything

Re: [PORTAL] Changes and API review?

2006-12-19 Thread Adam Winer
for responding. Your suggestions have been invaluable. :) Now... Adam Winer wrote: So I guess basically I'm making one last appeal on the GlobalConfigurator thing. If you still want it removed I'll get rid of it. But I honestly think we're backing ourselves into an unnecessary corner. I'll give

Re: Include JavaScriptlets in Trinidad Component which is executed once per page

2006-12-19 Thread Adam Winer
You can use ExtendedRenderKitService.addScript(). -- Adam On 12/17/06, Böhringer Jochen [EMAIL PROTECTED] wrote: Hello, I am still in the development process of my Trinidad Drag and Drop Component. The dropzone calls an action method if a draggable object is dropped on it. It works fine if

Re: [PORTAL] Changes and API review?

2006-12-19 Thread Adam Winer
at adding here can be static. Scott Adam Winer wrote: That method could easily be a static method on Configurator in my scheme. -- Adam On 12/15/06, Scott O'Bryan [EMAIL PROTECTED] wrote: I just got one more example from your other input. I'm probably going to be adding

Re: [PORTAL] Changes and API review?

2006-12-19 Thread Adam Winer
the same functionality for these methods so it would force us to finalize them in order to PREVENT people from overriding them in one Configurator and not in another. Scott Adam Winer wrote: Scott, Why wouldn't methods that hook the start and end of the physical request be generically useful

Re: Trinidad sandbox?

2006-12-19 Thread Adam Winer
the popup from danny? Or a *branch* that really acts as a sandbox to play with ideas on components and when stable (or close to it) the stuff get's merged into _core_ ? -M On 12/14/06, Adam Winer [EMAIL PROTECTED] wrote: I'd like to add a new sandbox project to trinidad

Re: [PORTAL] Changes and API review?

2006-12-19 Thread Adam Winer
still havn't heard any compelling reason why THIS implementation is not good. Scott Adam Winer wrote: Well, in this specific instance, it therefore doesn't bloat every configurator, since it only appears in one location. -- Adam

Re: Re: [PORTAL] Changes and API review?

2006-12-15 Thread Adam Winer
On 12/15/06, Scott O'Bryan [EMAIL PROTECTED] wrote: Adam Winer wrote: Scott, My big concern is with the sheer quantity of new public APIs (that is, public classes in trinidad-api). We should be avoiding making anything public unless it is absolutely, critically necessary. Configurator

Re: Re: [PORTAL] Changes and API review?

2006-12-15 Thread Adam Winer
On 12/15/06, Scott O'Bryan [EMAIL PROTECTED] wrote: Adam Winer wrote: Therefore if these or other things arise, having an API for a global cofigurator will be more flexible in the future because we'll be able to add to this API would breaking binary compatibility. If we start returning

Re: Re: What DevEnv do you use for Trinidad

2006-12-14 Thread Adam Winer
And I use Emacs and a command-line, which I imagine makes me very old-school. ;) -- Adam On 12/14/06, Matt Cooper [EMAIL PROTECTED] wrote: Hi Danny, The most common ones I've heard of are either Eclipse or Oracle JDeveloper. I use the latter and create workspace/project files by running the

Re: Re: Trinidad sandbox?

2006-12-14 Thread Adam Winer
a bit without effecting the main line. I like it! +1 (non-binding) Adam Winer wrote: On 12/14/06, Danny Robinson [EMAIL PROTECTED] wrote: +1 (non binding). Q1 - Would this add more workload to those with Commit priviledge, or could we open up the commit access a little more for this project

Re: [PORTAL] Changes and API review?

2006-12-14 Thread Adam Winer
Scott, My big concern is with the sheer quantity of new public APIs (that is, public classes in trinidad-api). We should be avoiding making anything public unless it is absolutely, critically necessary. Configurator APIs: I'm not completely sold on the name, but anyway, I think we should: -

Re: Status

2006-12-14 Thread Adam Winer
What do you mean by working? It's long been working, so do you mean officially released version? -- Adam On 12/13/06, William Hoover [EMAIL PROTECTED] wrote: Do we have an ETA when we will have a working copy of Trinidad? Will Hoover Application Engineer IS - Application Development Nemours

Re: [PORTAL] Launch Parameters

2006-12-13 Thread Adam Winer
This is part of the dialog framework, for returning from a dialog shown in-place (instead of in a popup window). I think it'd be very tough to make this a redirect, since there can be *a lot* of parameters (it's basically a full POST), and they won't all fit in a GET. -- Adam On 12/13/06,

Re: Re: PATCH: ServerSide buttons are back

2006-12-05 Thread Adam Winer
to be heavily adapted and twisted to work in a JSF environment. It's slow, arcane, filled with obsolete code paths, etc., etc. Getting rid of it is a major goal in Trinidad. -- Adam Adam Winer wrote: Mark, It's not OK for anything in myfaces.trinidadinternal.renderkit to have dependencies

Re: PATCH: ServerSide buttons are back

2006-12-04 Thread Adam Winer
Mark, It's not OK for anything in myfaces.trinidadinternal.renderkit to have dependencies on code in myfaces.ui; our goal is to kill all code in myfaces.ui. So, for example: import org.apache.myfaces.trinidadinternal.ui.UIXRenderingContext; import

Re: Re: GoLinkRenderer calls writeURIAttribute to render name and id, why?

2006-11-30 Thread Adam Winer
); context.getResponseWriter().writeURIAttribute(name, clientId, id); } } Thanks. John On 11/29/06, Adam Winer [EMAIL PROTECTED] wrote: Guys, this is ALWAYS a # URL. It's the name attr of a link, and can't possibly be anything more. There are zero portal implications. -- Adam On 11/29

Re: GoLinkRenderer calls writeURIAttribute to render name and id, why?

2006-11-29 Thread Adam Winer
; if the destination doesn't start with http://;, https://;, mailto:;, javascript: or anything else. On 11/29/06, Scott O'Bryan [EMAIL PROTECTED] wrote: So they will basically reference bookmarks, correct? Scott Adam Winer wrote: Neither; they do not need to be encoded at all

Re: GoLinkRenderer calls writeURIAttribute to render name and id, why?

2006-11-28 Thread Adam Winer
The value of the attribute on name on GoLink will end up mapping up to href on some other link. So it really is a URI. E.g., you need to use % encoding, not encoding. And id must equal name. -- Adam On 11/28/06, Qiang Fan [EMAIL PROTECTED] wrote: In GoLinkRenderer class, there is the

Re: Re: GoLinkRenderer calls writeURIAttribute to render name and id, why?

2006-11-28 Thread Adam Winer
. renderURIID(context, id); } if (supportsNameIdentification(context) makeNameAndIDSame(context)) { renderURIAttribute(context, name, id); } } } Are they all Action URLs? Thanks. John On 11/28/06, Adam Winer [EMAIL PROTECTED] wrote: The value

Re: Re: svn commit: r479151 - in /incubator/adffaces/branches/myfaces-1_2-maven-faces-plugin/src/main/java/org/apache/myfaces/trinidadbuild/plugin/faces: ./ generator/ generator/component/ generator/t

2006-11-27 Thread Adam Winer
to avoid a huge code divergence but there were a big amount of changes, hence the creation of the branch. Cheers, Bruno On 26/11/06, Adam Winer [EMAIL PROTECTED] wrote: Bruno, Any idea how/when we're going to merge these changes back? (Excellent work, by the way!) I'd really like

Re: Problems running Trinidad in Tomcat with file permission restrictions for writing

2006-11-26 Thread Adam Winer
Craig, IIRC, Trinidad is in fact writing to exactly those temporary directories already, as per the servlet spec. And using our ResourceServlet to pull from those directories. The issue isn't that - it's that GoDaddy is refusing to allow any File writing, even into those legit temporary

Re: svn commit: r479151 - in /incubator/adffaces/branches/myfaces-1_2-maven-faces-plugin/src/main/java/org/apache/myfaces/trinidadbuild/plugin/faces: ./ generator/ generator/component/ generator/tagli

2006-11-26 Thread Adam Winer
Bruno, Any idea how/when we're going to merge these changes back? (Excellent work, by the way!) I'd really like to keep us all on one branch of the code, instead of getting some huge code divergence. -- Adam On 11/25/06, [EMAIL PROTECTED] [EMAIL PROTECTED] wrote: Author: baranda Date:

  1   2   3   >