do 'iw phy0 info' -- you
might need to modify the driver suitably if you haven't already.
A fun hack to find out where -EINVAL comes from:
http://lwn.net/Articles/614446/
--
Bob Copeland %% http://bobcopeland.com/
___
ath5k-devel mailing l
ort WiSoC chips added we can restore functionality back.
>
> Singed-off-by: Sergey Ryazanov
^^
Please keep the patches away from the stove! (SCNR)
--
Bob Copeland %% www.bobcopeland.com
___
ath5k-devel mailing list
ath5k-devel@
nd by Coverity.
Signed-off-by: Bob Copeland
---
drivers/net/wireless/ath/ath5k/led.c |1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/wireless/ath/ath5k/led.c
b/drivers/net/wireless/ath/ath5k/led.c
index f77ef36..edc32ea 100644
--- a/drivers/net/wireless/ath/ath5k/led.c
+++ b/driver
rxs->rate_idx is unsigned, so it will always be >= 0.
Found by Coverity.
Signed-off-by: Bob Copeland
---
John & Nick,
This and the next two patches are some simple cleanups from static
checkers, but no actual bugs here, so they can wait for 3.18.
drivers/net/wireless/ath/ath5k/bas
kfree() null-checks its argument.
Found by smatch.
Signed-off-by: Bob Copeland
---
drivers/net/wireless/ath/ath5k/attach.c |3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/net/wireless/ath/ath5k/attach.c
b/drivers/net/wireless/ath/ath5k/attach.c
index 7106547
On Tue, Feb 25, 2014 at 09:23:38AM +, Nick Kossifidis wrote:
> That should be fun ! Have in mind there is already a driver (STA only)
> included since 3.8 ->
> http://wireless.kernel.org/en/users/Drivers/ar5523 so probe/attach
> should be fine.
>
> Bob are you still inter
er anyway.
--
Bob Copeland %% www.bobcopeland.com
___
ath5k-devel mailing list
ath5k-devel@lists.ath5k.org
https://lists.ath5k.org/mailman/listinfo/ath5k-devel
On Sat, Nov 09, 2013 at 07:54:31AM -0800, Adrian Chadd wrote:
> On 9 November 2013 05:40, Nick Kossifidis wrote:
>
> > Adrian/Bob, these fixes (along with power saving etc) are very
> > interesting projects and I was thinking to submit them in OPW
> > (http://kernelnewbie
an up ath5k's transmit loop a lot now...
> * read-and-clear bugs
> * PHY register read problems, and why ANI may occasionally look whacked
One thing at a time for me... but do we even want to know? :)
--
Bob Copeland %% www.bobcopeland.com
e
hardware marks a descriptor complete versus when the 'next' pointer
in the descriptor is accessed -- do you mind sharing?
--
Bob Copeland %% www.bobcopeland.com
___
ath5k-devel mailing list
ath5k-devel@lists.ath5k.org
https://lists.ath5k.org/ma
n't quite work --
http://bobcopeland.com/kernel/wl/20120517/
They don't apply currently, but I guess I'll spend a few hours
on it given the interest.
--
Bob Copeland %% www.bobcopeland.com
___
ath5k-devel mailing list
ath5k-devel@lists.ath5
w - patches welcome :)
--
Bob Copeland %% www.bobcopeland.com
___
ath5k-devel mailing list
ath5k-devel@lists.ath5k.org
https://lists.ath5k.org/mailman/listinfo/ath5k-devel
rs :)
(Just to allay any confusion, perf is a CPU profiler, while you know
what iperf is already.)
--
Bob Copeland %% www.bobcopeland.com
___
ath5k-devel mailing list
ath5k-devel@lists.ath5k.org
https://lists.ath5k.org/mailman/listinfo/ath5k-devel
At any rate - results of
"perf record [do something wireless]" + "perf report" for both scenarios
could shed some light.
--
Bob Copeland %% www.bobcopeland.com
___
ath5k-devel mailing list
ath5k-devel@lists.ath5k.org
https://lists.ath5k.org/mailman/listinfo/ath5k-devel
em?
I don't see anything like this, but I can't recall the last time
I had madwifi working either. A capture of both scenarios would
help.
--
Bob Copeland %% www.bobcopeland.com
___
ath5k-devel mailing list
ath5k-devel@lists.ath5k.org
h
et_beacon() in net/wireless/nl80211.c (currently limited to
AP and P2P-GO).
--
Bob Copeland %% www.bobcopeland.com
___
ath5k-devel mailing list
ath5k-devel@lists.ath5k.org
https://lists.ath5k.org/mailman/listinfo/ath5k-devel
Bit 32 was always set which looks to have been accidental,
according to git history.
Signed-off-by: Bob Copeland
---
Just found this while reading old code -- I could maybe see
bit 0 being special, but bit 32 seemed odd. Then looked
back through the history and looks like it was accidentally
On Sat, Mar 02, 2013 at 06:18:45PM -0500, Sivateja Patibandla wrote:
> Hi Bob,
>
> Thank you very much for your help. I applied the patch and now I don't see
> any kernel panics.
Great, glad to hear it.
--
Bob Copeland %% ww
t. Any help will be greatly appreciated. Thank you.
Does your kernel have this patch?
commit 9cbbffe2ded494429b0d005a51a88242bd9b3095
Author: Bob Copeland
Date: Wed Jan 9 12:34:55 2013 -0500
mac80211: set NEED_TXPROCESSING for PERR frames
A user reported warnings in ath5k due to trans
100+ km. Details are available if you search and the code has been in
> freebsd for many years...
Indeed, that was a good read; thanks for the pointer.
--
Bob Copeland %% www.bobcopeland.com
___
ath5k-devel mailing list
ath5k-devel@lists.ath5k.or
devices I have access to without
digging through some boxes, but in the absence of someone with
old old hardware showing up and saying this is worse for them,
I'd say ship it...
Thomas, feel free to add my:
Tested-by: Bob Copeland
--
Bob Copeland %% www.bobcopeland.com
__
#x27;ll do some testing tonight with whatever cards I have around here to
see if we can at least get a better idea of which chipsets do what.
--
Bob Copeland %% www.bobcopeland.com
___
ath5k-devel mailing list
ath5k-devel@lists.ath5k.org
https://lists.ath5k.org/mailman/listinfo/ath5k-devel
wer_limit .. so I avoid this calculations.
>
> Felix is goint to use txp_cur_pwr, so for now it is not used ... maybe
> he can explain where it will be needed.
Ok great, thanks for the clarification.
--
Bob Copeland %% www.bobcopeland.com
___
ath5k-de
wrong before? Is txp_cur_pwr still
used for anything?
--
Bob Copeland %% www.bobcopeland.com
___
ath5k-devel mailing list
ath5k-devel@lists.ath5k.org
https://lists.ath5k.org/mailman/listinfo/ath5k-devel
look, it seems we're only missing a few KLOC board file. Either
it's worthwhile to add that, or it isn't worthwhile to keep this stuff.
Despite not having the HW, I wouldn't even mind doing the legwork, but
it'd probably be best if the original authors (Felix?) did so
s of removing it -- ath5k_ahb would
then be selected by default on non-pci platforms when ath5k was
selected, and that should probably be more explicit. Such as,
say, having it based on some non-existent platform :)
--
Bob Copeland %% www.bobcopeland.com
___
appear to be just, say, markers for dead code ever since they got
> added in v2.6.38.
Yup, and I complained about it when it went in too. Ok, how's this?
From: Bob Copeland
Date: Thu, 12 Jul 2012 16:27:27 -0400
Subject: [PATCH] Remove code conditional on CONFIG_ATHEROS_AR231X
Since t
I simply don't have any hobby hacking time after family time
and non-kernel-related job time, so I resume status as part-time
mailing list lurker.
Signed-off-by: Bob Copeland
---
MAINTAINERS |1 -
1 files changed, 0 insertions(+), 1 deletions(-)
diff --git a/MAINTAINERS b/MAINTAINERS
; + return cw_req - 1;
There's is_power_of_two() in log2.h .. but this whole thing could also
be something like roundup_pow_of_two(cw) maybe?
--
Bob Copeland %% www.bobcopeland.com
___
ath5k-devel mailing list
ath5k-devel@lists.ath5k.o
o Kconfig entry ATHEROS_AR231X. (Neither is
> there a direct definition of the macro CONFIG_ATHEROS_AR231X.)
Well, as I remember, it's a board/subarch that is missing from the kernel,
not just a config entry (AHB is for systems on a chip). Perhaps the patch
authors know if that's hea
ze
ath_common->clockrate at startup, or require the interface to be
up when calling this, rather than checking inside
ath5k_hw_set_coverage_class().. Lukáš, thoughts?
It reminds me of this one (but different):
commit b6855772f4a22c4fbdd4fcaceff5c8a527035123
Author: Bob Copeland
do:
$ trace-cmd report > trace.out
That will create a text listing of the tracepoints in trace.out, as
well as a pcap file with the packet info in /tmp/pcap.out.
--
Bob Copeland %% www.bobcopeland.com
___
ath5k-devel mailing list
ath5k-devel@list
but the patch description didn't
convince me so I double-checked. My comments above reflect how I
might have worded it.
Thanks for the patch!
Reviewed-by: Bob Copeland
>
> Signed-off-by: Dan Carpenter
>
> diff --git a/drivers/net/wireless/ath/ath5k/base.c
> b/drivers/net
ur -= 96;
I assume (I didn't write this code) that it was done this way because
we don't always have a vif to pass into the generic code.
--
Bob Copeland %% www.bobcopeland.com
___
ath5k-devel mailing list
ath5k-devel@lists.ath5k.org
https://lists.ath5k.org/mailman/listinfo/ath5k-devel
ardware handles it - the tx descriptor specifies a list of rates
and number of attempts to retry the frame and the hardware reports
back how many tries at which rates were used (of course upper layers might
retransmit packets unknown to ath5k but that is a different matter.)
--
Bob Cope
me
> packet several times when it should only be counted once. Does this make any
> sense ?
This is absolutely the case. Packets are only considered transmitted
when the tx status callback is invoked. And (for now) completed
packets might remain in the list as well.
--
Bob Copela
e
the change there:
http://linuxwireless.org/download/compat-wireless-2.6/
--
Bob Copeland %% www.bobcopeland.com
___
ath5k-devel mailing list
ath5k-devel@lists.ath5k.org
https://lists.ath5k.org/mailman/listinfo/ath5k-devel
antime is to use ftrace to see
what iwconfig / kernel is doing when you try to set the channel.
> As I said, we use "iwconfig" to change the channel. Is it good or is "iw"
> more appropriate?
It shouldn't matter -- but iw is recommended for any future work (e.g.
iw
On Tue, Sep 6, 2011 at 12:00 PM, Pavel Roskin wrote:
> On Mon, 29 Aug 2011 23:15:51 -0400
> Bob Copeland wrote:
>
>> Flush is a prerequisite for proper PS support and ensures we
>> empty queues before going off channel. We simply wait up to
>> 200 ms for the t
lso fixes accounting so that txq_len reflects reality,
and makes skb null check in the tx path unnecessary
(converted to WARN_ON).
Signed-off-by: Bob Copeland
---
drivers/net/wireless/ath/ath5k/base.c | 62 -
1 files changed, 30 insertions(+), 32 deletions(-)
d
Also avoid the extra udelay(100) in the case that we'd exit the loop.
This will be used later in ath5k_reset() to check for pending frames
before enabling fast switching.
Signed-off-by: Bob Copeland
---
drivers/net/wireless/ath/ath5k/ath5k.h |1 +
drivers/net/wireless/ath/ath5k/
Otherwise we could free skbs in ath5k_drain_tx_buffs() that are
mapped and in use by the hardware during ath5k_reset().
Signed-off-by: Bob Copeland
---
drivers/net/wireless/ath/ath5k/base.c |1 +
drivers/net/wireless/ath/ath5k/reset.c | 10 +-
2 files changed, 2 insertions(+), 9
obably the part that is most speculative.
Comments welcome.
FIXME - I haven't actually tested any of this yet
FIXME - pending count needs 5210 version
Bob Copeland (5):
ath5k: process all completed descriptors in tx_processq
ath5k: extract pending frame count read into a function
Flush is a prerequisite for proper PS support and ensures we
empty queues before going off channel. We simply wait up to
200 ms for the tx tasklet to run its course.
Signed-off-by: Bob Copeland
---
drivers/net/wireless/ath/ath5k/base.c | 37 +
drivers/net
This function will subsequently be used when draining queues
in flush. While at it, fix a bug wherein subsequent queues aren't
stopped after the first error.
Signed-off-by: Bob Copeland
---
drivers/net/wireless/ath/ath5k/ath5k.h |1 +
drivers/net/wireless/ath/ath5k/dma.c |
iv;
+
+ mutex_lock(&ah->lock);
+ ath5k_flush_tx(ah, drop);
+ mutex_unlock(&ah->lock);
+}
+
static int
ath5k_set_antenna(struct ieee80211_hw *hw, u32 tx_ant, u32 rx_ant)
@@ -802,7 +812,7 @@ const struct ieee80211_ops ath5k_hw_ops = {
.get_survey = ath5k_g
On Mon, Aug 01, 2011 at 09:36:30AM -0400, Bob Copeland wrote:
> Our accounting for packets is currently messed up due to the
> always-leave-one policy that we used in tx_processq to try to avoid DMA
> problems. I don't think keeping one buffer unprocessed is the right
> a
0211_ops ath5k_hw_ops = {
.get_survey = ath5k_get_survey,
.set_coverage_class = ath5k_set_coverage_class,
/* .rfkill_poll = not implemented */
- /* .flush = not implemented */
+ .flush = ath5k_flush,
ven separate modules. Maybe if ath9k developers become
> envious or our clean code in ath5k they with do it too :)
No complaints from me on that score: too often stuff was duplicated
between the two or just arbitrarily stuffed in one vs the other.
Thanks for all these cleanups, Pavel.
-
On Tue, Jul 5, 2011 at 12:42 PM, Bob Copeland wrote:
> Not sure why you want to use TSF, it's not necessarily monotonic if the
> STA's clock runs faster than the AP. Jiffies should work fine here.
Eh, forget jiffies, brain isn't working today (resolution is much wors
that processq loops over all
packets in the list. As such, I don't think your last_tx_time works the
way you expect it to.
> ...
> current_tsf = ath5k_hw_get_tsf64(sc->ah);
Not sure why you want to use TSF, it's not necessarily monotonic if the
STA's clock runs faster t
On Wed, Jun 22, 2011 at 11:07 AM, Joerg Pommnitz wrote:
>> I guess you'll need more help from the HW people here.
>
> Bob, Bruno, Felix, Luis, Nick: Do you read?
I guess I would be interested to know if there are any obvious
differences in the streams. E.g. taking a monitor
From: Eugene A. Shatokhin
We would free the proper number of curves, but in the wrong
slots, due to a missing level of indirection through
the pdgain_idx table.
It's simpler just to try to free all four slots, so do that.
Cc: sta...@kernel.org
Signed-off-by: Bob Copeland
---
driver
disabling ACK, then the receiving side won't be able
> to tell you that it's been successful so you can't retransmit. :)
> That means any and all collisions, any transient noise, etc is going
> to be hurting you.
Also minstrel e.g. relies on TX status to set the rat
B.
Oh, yeah, I did miss that completely, heh. I kept thinking the only BT
was on the phone since the other phones didn't have issues.
--
Bob Copeland %% www.bobcopeland.com
___
ath5k-devel mailing list
ath5k-devel@lists.ath5k.org
https://lists.ath5k.org/mailman/listinfo/ath5k-devel
On Thu, Jun 09, 2011 at 10:55:11AM +0800, Adrian Chadd wrote:
> On 9 June 2011 09:01, Bob Copeland wrote:
>
> >> Hm, is there BT coexistance support for ath5k?
> >
> > No, but my understanding is that BT coex support is only for co-located
> > devices, so u
the channel avoidance on the
BT device work better, but I don't know if there's anything more that
could be done.
--
Bob Copeland %% www.bobcopeland.com
___
ath5k-devel mailing list
ath5k-devel@lists.ath5k.org
https://lists.ath5k.org/mailman/listinfo/ath5k-devel
On Mon, Jun 6, 2011 at 11:20 AM, Piotr Kaczorek
wrote:
> W dniu 05.06.2011 21:13, Bob Copeland pisze:
>> On Fri, May 27, 2011 at 5:27 AM, Piotr Kaczorek
>> wrote:
>>> Sorry, I pressed reply instead of reply all.
>>>
>>> W dniu 26.05.2011 14:56, Bob
On Fri, May 27, 2011 at 5:27 AM, Piotr Kaczorek
wrote:
> Sorry, I pressed reply instead of reply all.
>
> W dniu 26.05.2011 14:56, Bob Copeland pisze:
>>
>> Please don't top-post.
>>
>> On Thu, May 26, 2011 at 2:48 AM, Piotr Kaczorek
>> wr
t;
> But thanks for pointing this out. It might be issue with ath5k<->
> nl80211 cooperation, as well.
> Should I post a bug on kernel's bugzilla?
It's fine to post here -- but you most likely need to get a packet dump
before anyone will be able to
tp://www.kernel.org/pub/linux/kernel/people/mickflemm/01-fast-chan-switch-modparm
--
Bob Copeland %% www.bobcopeland.com
___
ath5k-devel mailing list
ath5k-devel@lists.ath5k.org
https://lists.ath5k.org/mailman/listinfo/ath5k-devel
ffic.
> (http://thread.gmane.org/gmane.os.freebsd.current/110707)?
> A timeout?
> I have no idea where to look further for a solution.
Try to get a packet capture with a second device, and see if the AP
is sending when the station is in power save mode.
--
Bob Copeland %% www.bobcopeland.com
___
here, and besides it's a core component, not specific to ath5k.
linux-wirel...@vger.kernel.org
--
Bob Copeland %% www.bobcopeland.com
___
ath5k-devel mailing list
ath5k-devel@lists.ath5k.org
https://lists.ath5k.org/mailman/listinfo/ath5k-devel
nable leds support which I had with Broadcom card.
> I have nothing about led devices coresponding to ath, only this:
Can you post lspci -vnn?
We have a hardcoded list of laptops ath5k/led.c. It's not ideal but
the Windows drivers seem to do the same thing in an .ini file.
--
Bob Copel
ed-by: Eugene A. Shatokhin
> Signed-off-by: John W. Linville
Reviewed-by: Bob Copeland
Thanks!
--
Bob Copeland %% www.bobcopeland.com
___
ath5k-devel mailing list
ath5k-devel@lists.ath5k.org
https://lists.ath5k.org/mailman/listinfo/ath5k-devel
Johannes pointed out the mess of external function prototypes in the
mac80211-ops.c file. Woe to anyone who changes these functions...
Signed-off-by: Bob Copeland
Cc: Johannes Berg
---
drivers/net/wireless/ath/ath5k/ath5k.h| 20
drivers/net/wireless/ath/ath5k
ut it would be better to fix it there.
--
Bob Copeland %% www.bobcopeland.com
___
ath5k-devel mailing list
ath5k-devel@lists.ath5k.org
https://lists.ath5k.org/mailman/listinfo/ath5k-devel
minstrel, so my patch wouldn't have any effect now, for ath5k.
There still might be other drivers that would benefit from having
the change in the rate controller.
--
Bob Copeland %% www.bobcopeland.com
___
ath5k-devel mailing list
ath5k-devel@li
rx paths when the debugging is compiled
in but disabled, while improving the ability to process
the logged data. A new Kconfig option can disable the
tracepoints completely.
The corresponding debug dump functions are removed.
Signed-off-by: Bob Copeland
---
(Actually this patch doesn't r
he flags, so
> that would have to be changed. I guess it's no major problem but i can't be
> bothered right now.
--
Bob Copeland %% www.bobcopeland.com
___
ath5k-devel mailing list
ath5k-devel@lists.ath5k.org
https://lists.ath5k.org/mailman/listinfo/ath5k-devel
t; unsigned int i, count, size, chfreq, freq, ch;
> + enum ieee80211_band band;
I like this, but we can also change ath5k_channel_ok and get rid of chfreq
completely, no? And then maybe the CHANNEL_ defines.
Could be a follow-on patch.
--
Bob Cope
ath5k_reset must be called with sc->lock. Since the tx queue
watchdog runs in a workqueue and accesses sc, it's appropriate
to just take the lock over the whole function.
Signed-off-by: Bob Copeland
---
drivers/net/wireless/ath/ath5k/base.c |4
1 files changed, 4 insertio
On Wed, Jan 5, 2011 at 2:53 PM, Joe Perches wrote:
>
> bool is OK.
>
Yes, I was agreeing, just pointing out (for my own benefit, I guess) that
the old rule of using int for bool modparams no longer holds.
--
Bob Copeland %% www.bobcop
re. Google tells me
that changed about 2 years ago, so bool should be ok.
--
Bob Copeland %% www.bobcopeland.com
___
ath5k-devel mailing list
ath5k-devel@lists.ath5k.org
https://lists.ath5k.org/mailman/listinfo/ath5k-devel
Hi all,
I've implemented 802.11 power-saving support for ath5k, but I'm still
debugging some things. I'll post patches in a week or so, whether or not
I get the bugs out, so that it can be played with.
Anyway here are my notes; please correct anything that's wrong.
Notes on ath5k power saving
-
they should fix that problem. Please try them and report if they don't.
Indeed, applied first 3 patches and problem is resolved (and now I see
you pointed it out in patch 3). Thanks!
--
Bob Copeland %% www.bobcopeland.com
___
ath5k-devel
r table must be broken
at start up.
I saw that Bruno had a later series that touched this area, so I'll
try them next.
--
Bob Copeland %% www.bobcopeland.com
___
ath5k-devel mailing list
ath5k-devel@lists.ath5k.org
https://lists.ath5k.org/mailman/listinfo/ath5k-devel
[] ? kthread+0x67/0x6c
[ 21.405011] [] ? kthread+0x0/0x6c
[ 21.405011] [] ? kernel_thread_helper+0x6/0x10
Signed-off-by: Bob Copeland
---
drivers/net/wireless/ath/ath5k/base.c |4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/wireless/ath/ath5k/base.c
b/drive
his
holiday week.. I guess I'll re-rebase it whenever I get it
working.
--
Bob Copeland %% www.bobcopeland.com
___
ath5k-devel mailing list
ath5k-devel@lists.ath5k.org
https://lists.ath5k.org/mailman/listinfo/ath5k-devel
this
> > particular use case, minstrel is probably the way to go in general.
>
> So, while I say this with no idea how to do it, might it be worth
> fixing Minstrel so that it adheres to mac80211's maximum retry values?
Yeah, so that's what the linked
80211_hwsim, and found minstrel to be quite a bit better
at rate adaptation. So while it may be worth testing out for this
particular use case, minstrel is probably the way to go in general.
--
Bob Copeland %% www.bobcopeland.com
___
ath5k-devel mailing
e traffic with
iperf or something
- with another wireless interface & wireshark take a packet trace
- power off the AP
- verify that the configured retry limits aren't exceeded in the trace
once the AP goes away.
And do the same without the patch to see the difference.
On Wed, Dec 8, 2010 at 12:06 PM, Bob Copeland wrote:
> On Wed, Dec 8, 2010 at 11:56 AM, John W. Linville
> wrote:
>>> Found the patch:
>>>
>>> https://patchwork.kernel.org/patch/359722/
>>
>> Are you posting that for merging? Or just for testing?
&
On Wed, Dec 8, 2010 at 11:56 AM, John W. Linville
wrote:
>> Found the patch:
>>
>> https://patchwork.kernel.org/patch/359722/
>
> Are you posting that for merging? Or just for testing?
Testing -- I only compile tested it but it seemed relevant
to this t
On Wed, Dec 8, 2010 at 11:08 AM, Bob Copeland wrote:
> On Mon, Dec 6, 2010 at 3:14 AM, Bruno Randolf wrote:
>> But it seems weird that there are so many retransmissions. The default
>> maximum
>> numbers of retransmissions should be 7 for short frames and 4 for long frames
mac80211
> (local->hw.conf.short_frame_max_tx_count). Seems we are getting many
> retransmissions from minstel, i added some debug prints:
>
I posted a patch for this about a week ago to linux-wireless.
AFAICT minstrel doesn't use these configuration parrameters
at all (but PI
it to remove the leading space?
Also the "*" thing is a bit weird as kernel commit messages go.
--
Bob Copeland %% www.bobcopeland.com
___
ath5k-devel mailing list
ath5k-devel@lists.ath5k.org
https://lists.ath5k.org/mailman/listinfo/ath5k-devel
rticular driver,
which explains why I didn't see it (I currently compile ipv6 out).
--
Bob Copeland %% www.bobcopeland.com
___
ath5k-devel mailing list
ath5k-devel@lists.ath5k.org
https://lists.ath5k.org/mailman/listinfo/ath5k-devel
#x27;t have any problems. Are you
doing anything special when bringing up the interface? Can you
post your kernel config?
I take it this is a recent regression; if all else fails you can
try bisecting it.
--
Bob Copeland %% www.bobcopeland.com
___
ath
On Wed, Nov 17, 2010 at 9:31 AM, David Goodenough
wrote:
> On Wednesday 17 November 2010, Bob Copeland wrote:
>> On Wed, Nov 17, 2010 at 7:22 AM, David Goodenough
>>
>> wrote:
>> > I have a board with an atheros wireless card, driven by ath5k. The
>> > dri
ous that may be upsetting the AP.
--
Bob Copeland %% www.bobcopeland.com
___
ath5k-devel mailing list
ath5k-devel@lists.ath5k.org
https://lists.ath5k.org/mailman/listinfo/ath5k-devel
> so on further errors as well.
>
> Signed-off-by: Jones Desougi
Reviewed-by: Bob Copeland
Thanks, yes, looks like that was due to commit 9adca126d,
"ath5k: allocate ath5k_hw prior to initializing hw".
This should probably go to stable.
--
B
power curves is pretty heavy cpu-wise and we do it on every reset. There's
some low-hanging fruit there like precomputing the reciprocal of some
scaling factors instead of some divisions...
--
Bob Copeland %% www.bobcopeland.com
___
ath5k-devel mailing
y keeping the option on and reverting the following
patch to see if it makes a difference.
commit b61279809860690fe5c9fcb40441008d31fabab6
Author: Nick Kossifidis
Date: Sun Aug 15 13:03:11 2010 -0400
ath5k: remove own (wrong) IEEE80211_MAX_LEN
Use the version already
By the way, I just got a chance to look at the stack trace.
Try turning off CONFIG_NETWORK_PHY_TIMESTAMPING.
It seems the skb doesn't have enough headroom for the
skb_pull(skb, ETH_HLEN) in skb_defer_rx_timestamp.
--
Bob Copeland %% www.bobcopelan
-commit into each broken kernel.
The git-bisect manpage has more clues.
--
Bob Copeland %% www.bobcopeland.com
___
ath5k-devel mailing list
ath5k-devel@lists.ath5k.org
https://lists.ath5k.org/mailman/listinfo/ath5k-devel
narrow it down to a few dozen unrelated patches
since they all tend to go in about the same time, but it may be a bit
less messy than git-based bisection. I usually do git bisect myself
but you need to be careful to properly handle build breakages and such.
On Mon, Sep 20, 2010 at 3:37 PM, Neo Tida wrote:
> Hi
> I faced a problem with ath5k when I used wds(4addr) and encryption together.
Can you try latest wireless-testing tree? Crypto code was
recently removed in favor of ath9k's.
--
Bob Copeland %% www.bobc
On Fri, Sep 17, 2010 at 11:36:30AM +0900, Bruno Randolf wrote:
> From: Bob Copeland
>
> related functions and remove most of the forward declarations
> (from 61 down to 3). This is, unfortunately, a lot of churn, but
> there should be no functional changes.
>
> Signed
st fix it up, but that offending hunk is 2500 lines or so...
(for Bruno's benefit since I said as much on irc) -- I'll redo this
one as soon as the crypto series is pushed out in w-t.
--
Bob Copeland %% www.bobcopeland.com
___
ath5k-devel
1 - 100 of 802 matches
Mail list logo
