JDK are already addressed in a separate
> umbrella issue and its sub-tasks.
>
> Thanks for your review,
> Adam
Adam Sotona has updated the pull request with a new target base due to a merge
or a rebase. The pull request now contains 15 commits:
- Merge branch 'openjdk:maste
JDK are already addressed in a separate
> umbrella issue and its sub-tasks.
>
> Thanks for your review,
> Adam
Adam Sotona has updated the pull request with a new target base due to a merge
or a rebase. The pull request now contains 16 commits:
- Merge branch 'openjdk:master
JDK are already addressed in a separate
> umbrella issue and its sub-tasks.
>
> Thanks for your review,
> Adam
Adam Sotona has updated the pull request with a new target base due to a merge
or a rebase. The pull request now contains 17 commits:
- Merge branch 'openjdk:maste
JDK are already addressed in a separate
> umbrella issue and its sub-tasks.
>
> Thanks for your review,
> Adam
Adam Sotona has updated the pull request incrementally with one additional
commit since the last revision:
re-enabled lossy conversions warnings for java.security.jgss, j
On Mon, 27 Jun 2022 09:25:58 GMT, Adam Sotona wrote:
>> Please review this patch adding new lint option, **lossy-conversions**, to
>> javac to warn about type casts in compound assignments with possible lossy
>> conversions.
>>
>> The new lint warning is shown
On Mon, 2 Oct 2023 13:50:56 GMT, Maurizio Cimadamore
wrote:
>> src/java.base/share/classes/java/lang/classfile/instruction/InvokeInstruction.java
>> line 67:
>>
>>> 65:
>>> 66: /**
>>> 67: * {@return for an {@code invokeinterface}, the {@code count}
>>> value, as defined in {@jvms 6
On Mon, 2 Oct 2023 13:57:58 GMT, Maurizio Cimadamore
wrote:
>> Adam Sotona has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> fixed javadoc typo
>
> src/java.base/share/classes/java/lang/classfile/package
On Mon, 2 Oct 2023 13:54:22 GMT, Maurizio Cimadamore
wrote:
>> Adam Sotona has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> fixed javadoc typo
>
> src/java.base/share/classes/java/lang/classfile/package
On Mon, 2 Oct 2023 14:03:48 GMT, Maurizio Cimadamore
wrote:
>> Adam Sotona has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> fixed javadoc typo
>
> src/java.base/share/classes/java/lang/classfile/package
On Mon, 2 Oct 2023 14:51:47 GMT, Maurizio Cimadamore
wrote:
>> Adam Sotona has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> fixed javadoc typo
>
> test/langtools/tools/javac/classfiles/attributes/SourceF
ased on the
> internal version of the library from the JDK master branch, and there are no
> API features added.
>
> Please review this pull request to help the Classfile API turn into a preview.
>
> Any comments are welcome.
>
> Thanks,
> Adam
Adam Sotona has updat
On Tue, 3 Oct 2023 18:55:36 GMT, ExE Boss wrote:
>> Adam Sotona has updated the pull request incrementally with three additional
>> commits since the last revision:
>>
>> - fixed case in the test text
>> - fixing javadoc
>> - Unified implementation
ased on the
> internal version of the library from the JDK master branch, and there are no
> API features added.
>
> Please review this pull request to help the Classfile API turn into a preview.
>
> Any comments are welcome.
>
> Thanks,
> Adam
Adam Sotona has updat
ased on the
> internal version of the library from the JDK master branch, and there are no
> API features added.
>
> Please review this pull request to help the Classfile API turn into a preview.
>
> Any comments are welcome.
>
> Thanks,
> Adam
Adam Sotona has updated
ased on the
> internal version of the library from the JDK master branch, and there are no
> API features added.
>
> Please review this pull request to help the Classfile API turn into a preview.
>
> Any comments are welcome.
>
> Thanks,
> Adam
Adam Sotona has up
On Wed, 4 Oct 2023 09:30:16 GMT, Adam Sotona wrote:
>> Classfile API is an internal library under package `jdk.internal.classfile`
>> in JDK 21.
>> This pull request turns the Classfile API into a preview feature and moves
>> it into `java.lang.classfile`.
>> It
ased on the
> internal version of the library from the JDK master branch, and there are no
> API features added.
>
> Please review this pull request to help the Classfile API turn into a preview.
>
> Any comments are welcome.
>
> Thanks,
> Adam
Adam Sotona has updat
ased on the
> internal version of the library from the JDK master branch, and there are no
> API features added.
>
> Please review this pull request to help the Classfile API turn into a preview.
>
> Any comments are welcome.
>
> Thanks,
> Adam
Adam Sotona has updated t
ased on the
> internal version of the library from the JDK master branch, and there are no
> API features added.
>
> Please review this pull request to help the Classfile API turn into a preview.
>
> Any comments are welcome.
>
> Thanks,
> Adam
Adam Sotona has update
ased on the
> internal version of the library from the JDK master branch, and there are no
> API features added.
>
> Please review this pull request to help the Classfile API turn into a preview.
>
> Any comments are welcome.
>
> Thanks,
> Adam
Adam Sotona has updated
ased on the
> internal version of the library from the JDK master branch, and there are no
> API features added.
>
> Please review this pull request to help the Classfile API turn into a preview.
>
> Any comments are welcome.
>
> Thanks,
> Adam
Adam Sotona has updated
On Tue, 10 Oct 2023 14:46:32 GMT, Chen Liang wrote:
> We need to remove the outdated exports in `BuildMicroBenchmarks.gmk` after
> the package migration.
Removed, good catch, thanks!
-
PR Comment: https://git.openjdk.org/jdk/pull/15706#issuecomment-1756993662
On Thu, 12 Oct 2023 10:23:56 GMT, Magnus Ihse Bursie wrote:
>> Adam Sotona has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> removed obsolete exports from BuildMicrobenchmark.gmk
>
> make/test/BuildMicrob
On Thu, 12 Oct 2023 11:11:10 GMT, Maurizio Cimadamore
wrote:
>> Adam Sotona has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> removed obsolete exports from BuildMicrobenchmark.gmk
>
> src/java.base/sha
ased on the
> internal version of the library from the JDK master branch, and there are no
> API features added.
>
> Please review this pull request to help the Classfile API turn into a preview.
>
> Any comments are welcome.
>
> Thanks,
> Adam
Adam Sotona has upda
ased on the
> internal version of the library from the JDK master branch, and there are no
> API features added.
>
> Please review this pull request to help the Classfile API turn into a preview.
>
> Any comments are welcome.
>
> Thanks,
> Adam
Adam Sotona has updated
ased on the
> internal version of the library from the JDK master branch, and there are no
> API features added.
>
> Please review this pull request to help the Classfile API turn into a preview.
>
> Any comments are welcome.
>
> Thanks,
> Adam
Adam Sotona has updated
ased on the
> internal version of the library from the JDK master branch, and there are no
> API features added.
>
> Please review this pull request to help the Classfile API turn into a preview.
>
> Any comments are welcome.
>
> Thanks,
> Adam
Adam Sotona has updated
ased on the
> internal version of the library from the JDK master branch, and there are no
> API features added.
>
> Please review this pull request to help the Classfile API turn into a preview.
>
> Any comments are welcome.
>
> Thanks,
> Adam
Adam Sotona has updated
ased on the
> internal version of the library from the JDK master branch, and there are no
> API features added.
>
> Please review this pull request to help the Classfile API turn into a preview.
>
> Any comments are welcome.
>
> Thanks,
> Adam
Adam Sotona has updated
ased on the
> internal version of the library from the JDK master branch, and there are no
> API features added.
>
> Please review this pull request to help the Classfile API turn into a preview.
>
> Any comments are welcome.
>
> Thanks,
> Adam
Adam Sotona has upda
On Wed, 8 Nov 2023 15:22:54 GMT, Chen Liang wrote:
>> Adam Sotona has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains 360 commits:
>>
>> - fixed condy tests
>> - Merge branch 'master' int
ased on the
> internal version of the library from the JDK master branch, and there are no
> API features added.
>
> Please review this pull request to help the Classfile API turn into a preview.
>
> Any comments are welcome.
>
> Thanks,
> Adam
Adam Sotona has updated
ased on the
> internal version of the library from the JDK master branch, and there are no
> API features added.
>
> Please review this pull request to help the Classfile API turn into a preview.
>
> Any comments are welcome.
>
> Thanks,
> Adam
Adam Sotona has update
ased on the
> internal version of the library from the JDK master branch, and there are no
> API features added.
>
> Please review this pull request to help the Classfile API turn into a preview.
>
> Any comments are welcome.
>
> Thanks,
> Adam
Adam Sotona has updated
ased on the
> internal version of the library from the JDK master branch, and there are no
> API features added.
>
> Please review this pull request to help the Classfile API turn into a preview.
>
> Any comments are welcome.
>
> Thanks,
> Adam
Adam Sotona has updated
ased on the
> internal version of the library from the JDK master branch, and there are no
> API features added.
>
> Please review this pull request to help the Classfile API turn into a preview.
>
> Any comments are welcome.
>
> Thanks,
> Adam
Adam Sotona has updated
ased on the
> internal version of the library from the JDK master branch, and there are no
> API features added.
>
> Please review this pull request to help the Classfile API turn into a preview.
>
> Any comments are welcome.
>
> Thanks,
> Adam
Adam Sotona has updated t
On Tue, 28 Nov 2023 10:21:25 GMT, Per Minborg wrote:
>> Adam Sotona has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> fixed SwitchBootstrapTest
>
> src/java.base/share/classes/java/lang/classfile/ClassFile.ja
On Wed, 29 Nov 2023 08:46:46 GMT, Per Minborg wrote:
>> This is explicit list of supported class file versions, so I don't see any
>> other way.
>
> Would it not be possible to expose an immutable `Map` that
> maps from Java version to major class version?
This is actually out of scope of this
ased on the
> internal version of the library from the JDK master branch, and there are no
> API features added.
>
> Please review this pull request to help the Classfile API turn into a preview.
>
> Any comments are welcome.
>
> Thanks,
> Adam
Adam Sotona has updated
ased on the
> internal version of the library from the JDK master branch, and there are no
> API features added.
>
> Please review this pull request to help the Classfile API turn into a preview.
>
> Any comments are welcome.
>
> Thanks,
> Adam
Adam Sotona has updated
On Wed, 13 Sep 2023 09:48:00 GMT, Adam Sotona wrote:
> Classfile API is an internal library under package `jdk.internal.classfile`
> in JDK 21.
> This pull request turns the Classfile API into a preview feature and moves it
> into `java.lang.classfile`.
> It repackages all uses
On Mon, 4 Dec 2023 21:27:57 GMT, Jan Lahoda wrote:
>> As part of:
>> https://github.com/openjdk/jdk/pull/16505
>>
>> there are new symbol files for JDK 22, and @jddarcy noted the content looks
>> weird.
>>
>> I was investigating, and found a few problems, some introduced by
>> https://github.
On Wed, 17 Apr 2024 05:43:12 GMT, Joe Darcy wrote:
>> Get JDK 24 underway.
>
> Joe Darcy has updated the pull request incrementally with two additional
> commits since the last revision:
>
> - Correct release date as observed in review feedback.
> - Improve javadoc of class file update.
Clas
On Wed, 1 May 2024 11:18:36 GMT, Jan Lahoda wrote:
> When writing the `ModuleMainClass` attribute, `CreateSymbols` uses an UTF8
> entry (incorrect), instead of a Class_info (correct). This patch fixes that.
Looks good to me.
test/langtools/tools/javac/platform/createsymbols/CreateSymbolsTestIm
JDK are already addressed in a separate
> umbrella issue and its sub-tasks.
>
> Thanks for your review,
> Adam
Adam Sotona has updated the pull request with a new target base due to a merge
or a rebase. The pull request now contains 19 commits:
- Merge branch 'openjdk:master
JDK are already addressed in a separate
> umbrella issue and its sub-tasks.
>
> Thanks for your review,
> Adam
Adam Sotona has updated the pull request with a new target base due to a merge
or a rebase. The pull request now contains 20 commits:
- Merge branch 'openjdk:master
On Wed, 14 Sep 2022 11:10:15 GMT, Adam Sotona wrote:
>> Please review this patch adding new lint option, **lossy-conversions**, to
>> javac to warn about type casts in compound assignments with possible lossy
>> conversions.
>>
>> The new lint warning is shown
JDK are already addressed in a separate
> umbrella issue and its sub-tasks.
>
> Thanks for your review,
> Adam
Adam Sotona has updated the pull request incrementally with one additional
commit since the last revision:
re-enabled lossy-conversions warnings for jdk.hotspot.agent
---
On Mon, 9 May 2022 15:56:35 GMT, Adam Sotona wrote:
> Please review this patch adding new lint option, **lossy-conversions**, to
> javac to warn about type casts in compound assignments with possible lossy
> conversions.
>
> The new lint warning is shown if the type of the rig
This is root pull request with Classfile API implementation, tests and
benchmarks initial drop into JDK.
Following pull requests consolidating JDK class files parsing, generating, and
transforming ([JDK-8294957](https://bugs.openjdk.org/browse/JDK-8294957)) will
chain to this one.
Classfile AP
On Fri, 4 Nov 2022 12:38:04 GMT, Adam Sotona wrote:
> This is root pull request with Classfile API implementation, tests and
> benchmarks initial drop into JDK.
>
> Following pull requests consolidating JDK class files parsing, generating,
> and transforming ([JDK
On Fri, 4 Nov 2022 12:38:04 GMT, Adam Sotona wrote:
> This is root pull request with Classfile API implementation, tests and
> benchmarks initial drop into JDK.
>
> Following pull requests consolidating JDK class files parsing, generating,
> and transforming ([JDK
On Mon, 7 Nov 2022 12:16:29 GMT, Magnus Ihse Bursie wrote:
>> This is root pull request with Classfile API implementation, tests and
>> benchmarks initial drop into JDK.
>>
>> Following pull requests consolidating JDK class files parsing, generating,
>> and transforming
>> ([JDK-8294957](http
On Mon, 7 Nov 2022 12:15:35 GMT, Magnus Ihse Bursie wrote:
>> make/CompileInterimLangtools.gmk line 78:
>>
>>> 76: $(call LogInfo, Generating Preview.java for
>>> jdk.compiler.interim)
>>> 77: $(call MakeDir, $(@D))
>>> 78: $(GREP) -v 'case PATTERN_SWITCH ->' $< > $@
>>
On Mon, 7 Nov 2022 12:13:08 GMT, Magnus Ihse Bursie wrote:
>> This is root pull request with Classfile API implementation, tests and
>> benchmarks initial drop into JDK.
>>
>> Following pull requests consolidating JDK class files parsing, generating,
>> and transforming
>> ([JDK-8294957](http
On Mon, 7 Nov 2022 16:21:48 GMT, Magnus Ihse Bursie wrote:
>> Patched interim Preview and TransPatterns is a temporary workaround to allow
>> internal use of pattern switch in the JDK sources.
>
> So this will be removed later on in one of the follow up "chicken" PRs?
It will be removed in this
On Mon, 7 Nov 2022 13:01:41 GMT, Adam Sotona wrote:
>> make/modules/java.base/Java.gmk line 37:
>>
>>> 35:
>>> 36: EXCLUDES += java/lang/doc-files
>>> 37: EXCLUDES += jdk/classfile/snippets
>>
>> I don't like hard-coded excludes like th
content.com/openjdk/jdk-sandbox/classfile-api-javadoc-branch/doc/classfile-api/javadoc/jdk/classfile/package-summary.html)
> is also available.
>
> Please take you time to review this non-trivial JDK addition.
>
> Thank you,
> Adam
Adam Sotona has updated the pull request increme
On Sun, 27 Nov 2022 01:38:01 GMT, Erik Gahlin wrote:
>> Is the practice of naming the directory `snippets` well-established or
>> mandated? Otherwise I think a name like `snippet-files` (akin to
>> `doc-files`) would be much better, since it indicates that is not a java
>> package name. (These
content.com/openjdk/jdk-sandbox/classfile-api-javadoc-branch/doc/classfile-api/javadoc/jdk/classfile/package-summary.html)
> is also available.
>
> Please take you time to review this non-trivial JDK addition.
>
> Thank you,
> Adam
Adam Sotona has updated the pull request in
content.com/openjdk/jdk-sandbox/classfile-api-javadoc-branch/doc/classfile-api/javadoc/jdk/classfile/package-summary.html)
> is also available.
>
> Please take you time to review this non-trivial JDK addition.
>
> Thank you,
> Adam
Adam Sotona has updated the pull request increme
content.com/openjdk/jdk-sandbox/classfile-api-javadoc-branch/doc/classfile-api/javadoc/java.base/jdk/classfile/package-summary.html)
> is also available.
>
> Please take you time to review this non-trivial JDK addition.
>
> Thank you,
> Adam
Adam Sotona has updated the pull re
content.com/openjdk/jdk-sandbox/classfile-api-javadoc-branch/doc/classfile-api/javadoc/java.base/jdk/classfile/package-summary.html)
> is also available.
>
> Please take you time to review this non-trivial JDK addition.
>
> Thank you,
> Adam
Adam Sotona has updated the pull re
content.com/openjdk/jdk-sandbox/classfile-api-javadoc-branch/doc/classfile-api/javadoc/java.base/jdk/classfile/package-summary.html)
> is also available.
>
> Please take you time to review this non-trivial JDK addition.
>
> Thank you,
> Adam
Adam Sotona has updated the p
On Mon, 7 Nov 2022 16:28:19 GMT, Adam Sotona wrote:
>> So this will be removed later on in one of the follow up "chicken" PRs?
>
> It will be removed in this PR later, this specific workaround is not intended
> to fall into JDK.
> The CompileInterimLangtools patch
On Fri, 16 Dec 2022 18:22:24 GMT, Adam Sotona wrote:
>> **This pull request is not intended for immediate integration to JDK
>> mainline.**
>>
>> This is root pull request with Classfile API implementation, tests and
>> benchmarks initial drop into JDK.
On Fri, 16 Dec 2022 18:22:24 GMT, Adam Sotona wrote:
>> **This pull request is not intended for immediate integration to JDK
>> mainline.**
>>
>> This is root pull request with Classfile API implementation, tests and
>> benchmarks initial drop into JDK.
base/jdk/classfile/package-summary.html)
> is also available.
>
> Please take you time to review this non-trivial JDK addition.
>
> Thank you,
> Adam
Adam Sotona has updated the pull request incrementally with one additional
commit since the last revision:
merged JAVAC_F
On Thu, 12 Jan 2023 12:47:49 GMT, Magnus Ihse Bursie wrote:
>> Adam Sotona has updated the pull request incrementally with two additional
>> commits since the last revision:
>>
>> - removal of Preview.java and TransPatterns.java patch
>>and enabled preview fo
base/jdk/classfile/package-summary.html)
> is also available.
>
> Please take you time to review this non-trivial JDK addition.
>
> Thank you,
> Adam
Adam Sotona has updated the pull request incrementally with one additional
commit since the last revision:
unification of
On Thu, 26 Jan 2023 14:10:47 GMT, Hannes Greule wrote:
>> Adam Sotona has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> merged JAVAC_FLAGS and EXCLUDES in Java.gmk
>
> (not a reviewer) From a quick look at it
base/jdk/classfile/package-summary.html)
> is also available.
>
> Please take you time to review this non-trivial JDK addition.
>
> Thank you,
> Adam
Adam Sotona has updated the pull request incrementally with one additional
commit since the last revision:
update of Java version co
base/jdk/classfile/package-summary.html)
> is also available.
>
> Please take you time to review this non-trivial JDK addition.
>
> Thank you,
> Adam
Adam Sotona has updated the pull request with a new target base due to a merge
or a rebase. The pull request now contains 106 commits:
base/jdk/classfile/package-summary.html)
> is also available.
>
> Please take you time to review this non-trivial JDK addition.
>
> Thank you,
> Adam
Adam Sotona has updated the pull request incrementally with one additional
commit since the last revision:
Classfile API moved
On Fri, 3 Feb 2023 17:22:32 GMT, Maurizio Cimadamore
wrote:
>> Adam Sotona has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Classfile API moved under jdk.internal.classfile package
>
> src/java.base/share/
On Fri, 3 Feb 2023 17:23:51 GMT, Maurizio Cimadamore
wrote:
>> Adam Sotona has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Classfile API moved under jdk.internal.classfile package
>
> src/java.base/share/
On Fri, 3 Feb 2023 17:20:19 GMT, Maurizio Cimadamore
wrote:
>> Adam Sotona has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Classfile API moved under jdk.internal.classfile package
>
> src/java.base/share/
On Fri, 3 Feb 2023 17:32:37 GMT, Maurizio Cimadamore
wrote:
>> Adam Sotona has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Classfile API moved under jdk.internal.classfile package
>
> src/java.base/share/
base/jdk/classfile/package-summary.html)
> is also available.
>
> Please take you time to review this non-trivial JDK addition.
>
> Thank you,
> Adam
Adam Sotona has updated the pull request incrementally with three additional
commits since the last revision:
On Fri, 3 Feb 2023 17:37:55 GMT, Maurizio Cimadamore
wrote:
>> Adam Sotona has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Classfile API moved under jdk.internal.classfile package
>
> src/java.base/share/
On Fri, 3 Feb 2023 17:43:22 GMT, Maurizio Cimadamore
wrote:
>> Adam Sotona has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Classfile API moved under jdk.internal.classfile package
>
> src/java.base/share/
On Fri, 3 Feb 2023 18:07:27 GMT, Maurizio Cimadamore
wrote:
>> src/java.base/share/classes/jdk/internal/classfile/Classfile.java line 346:
>>
>>> 344: public static final int MAGIC_NUMBER = 0xCAFEBABE;
>>> 345:
>>> 346: public static final int NOP = 0;
>>
>> Not sure how I
On Fri, 3 Feb 2023 17:52:49 GMT, Maurizio Cimadamore
wrote:
>> Adam Sotona has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Classfile API moved under jdk.internal.classfile package
>
> src/java.base/share/
On Fri, 3 Feb 2023 17:56:45 GMT, Maurizio Cimadamore
wrote:
>> Adam Sotona has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Classfile API moved under jdk.internal.classfile package
>
> src/java.base/share/
On Fri, 3 Feb 2023 17:58:04 GMT, Maurizio Cimadamore
wrote:
>> Adam Sotona has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Classfile API moved under jdk.internal.classfile package
>
> src/java.base/share/
On Fri, 3 Feb 2023 17:59:53 GMT, Maurizio Cimadamore
wrote:
>> Adam Sotona has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Classfile API moved under jdk.internal.classfile package
>
> src/java.base/share/
On Fri, 3 Feb 2023 18:11:41 GMT, Maurizio Cimadamore
wrote:
>> Adam Sotona has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Classfile API moved under jdk.internal.classfile package
>
> src/java.base/share/
On Fri, 3 Feb 2023 18:37:43 GMT, Maurizio Cimadamore
wrote:
>> Adam Sotona has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Classfile API moved under jdk.internal.classfile package
>
> src/java.base/share/
On Fri, 3 Feb 2023 18:25:17 GMT, Maurizio Cimadamore
wrote:
>> Adam Sotona has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Classfile API moved under jdk.internal.classfile package
>
> src/java.base/share/
On Tue, 7 Feb 2023 11:48:28 GMT, Maurizio Cimadamore
wrote:
>> There are at least 72 usages of AttributedElement.Kind across the Classfile
>> API.
>> Do you suggest to rename it to something else (for example Location)?
>
> Uhm - I can't see these usages... something seems to be off with my IDE
On Tue, 7 Feb 2023 12:14:40 GMT, Maurizio Cimadamore
wrote:
>> On the contrary, it has been deduplicated. Opcode is referencing numeric
>> constants stored in Classfile.
>
> sure, but my question is - once you have a nice enum that is 1-1 with the
> opcodes - why would a client want to use the
On Tue, 7 Feb 2023 12:34:50 GMT, Maurizio Cimadamore
wrote:
>> `AttributedElement::attributedElementKind` identifies the one kind of the
>> attributes holder.
>> The "places where an attribute can appear" is available through
>> `AttributeMapper::whereApplicable` and matched against
>> `Attri
On Tue, 7 Feb 2023 14:14:50 GMT, Maurizio Cimadamore
wrote:
>> The relation is that each `Attribute` is applicable in N
>> `AttributedElements` and not vice versa.
>> For example `ClassModel::attributedElementKind` returns `CLASS` and for
>> example
>> `Attributes.RUNTIME_INVISIBLE_TYPE_ANNOT
On Tue, 7 Feb 2023 12:10:43 GMT, Maurizio Cimadamore
wrote:
>> The confusion come from simplified name. Signature probably should be called
>> JavaTypeSignature according to the spec. ClassSignature and MethodSignature
>> could not extend it, as it would not respect the reality. Each of them a
On Tue, 7 Feb 2023 15:47:25 GMT, Maurizio Cimadamore
wrote:
>> Class `Signature` (aka `JavaTypeSignature`), all subclasses,
>> `MethodSignature` and `ClassSignature` are designed according to [JVMS
>> 4.7.9.1
>> Signatures](https://docs.oracle.com/javase/specs/jvms/se19/html/jvms-4.html#jvms-
On Wed, 8 Feb 2023 07:21:07 GMT, Adam Sotona wrote:
>>> Class `Signature` (aka `JavaTypeSignature`), all subclasses,
>>> `MethodSignature` and `ClassSignature` are designed according to [JVMS
>>> 4.7.9.1
>>> Signatures](https://docs.oracle.com/javase/s
On Wed, 8 Feb 2023 07:21:07 GMT, Adam Sotona wrote:
>>> Class `Signature` (aka `JavaTypeSignature`), all subclasses,
>>> `MethodSignature` and `ClassSignature` are designed according to [JVMS
>>> 4.7.9.1
>>> Signatures](https://docs.oracle.com/javase/s
On Tue, 7 Feb 2023 15:20:15 GMT, Maurizio Cimadamore
wrote:
>> Adam Sotona has updated the pull request incrementally with three additional
>> commits since the last revision:
>>
>> - javadoc fixes
>> - obsolete identifiers and unused imports cleanup
>>
1 - 100 of 291 matches
Mail list logo
