Yes, please!! The srcdir should not be littered with output from the build
system. (At least it should be an option.)-Darin
On Wed, Sep 23, 2009 at 2:56 PM, Evan Martin wrote:
>
> We need builddir != srcdir. sgk was working on it, I helped with a
> patch, not sure what became of it.
>
> On We
I see. Yeah, we've had to deal with the "quit asap" issues in other cases
too. For example, the host resolver uses detached threads so that it can
simply leak a thread that is stuck on a getaddrinfo call. (FF does the same
thing.)
-Darin
On Wed, Sep 23, 2009 at 10:30 PM, Tim Steele wrote:
>
We did test it in the lab, though we focused on new users who seemed to like
it. We also looked at stats which indicated that the Most visited and
Recently closed items were the only things that were actually used. The few
people who used Recent bookmarks and Searches have been vocal, but we know
t
Not IO. The only contention it comes up against would be trying to get a
lock on data while another thread is applying changes that it already
received from a server, but that work is not intensive; it could be done by
the UI thread itself if it had to be, but it isn't since in the majority of
cas
Chrome's UI thread blocks on IO? Please tell me I misunderstand :-)
-Darin
On Wed, Sep 23, 2009 at 4:06 PM, Tim Steele wrote:
> If most of our uses on the UI thread are WriteTransactions today, then I
> agree using a Lock alone can't make things any jankier, because if you need
> to write you
On Wed, Sep 23, 2009 at 9:04 PM, Ben Goodger (Google) wrote:
> One day, we may offer further customization of this page. This may
> include the ability to show more items. I think this is preferable to
> a "classic view" option, which sets a bad precedent - that every time
> we make a UI change we
Note that this mode will probably vanish, it's a figment of the transition.
-Ben
On Wed, Sep 23, 2009 at 9:08 PM, Mohamed Mansour wrote:
> If you want to use the old new tab page, you can add this chrome switch (
> --old-new-tab-page )
> I personally like the 3x3 grid. I have a 24" screen and t
If you want to use the old new tab page, you can add this chrome
switch ( --old-new-tab-page
)
I personally like the 3x3 grid. I have a 24" screen and the new tab page is
so tiny, would of been nice if the user could fully customize it, that is
one of the popular features people want on the Chrome
One day, we may offer further customization of this page. This may
include the ability to show more items. I think this is preferable to
a "classic view" option, which sets a bad precedent - that every time
we make a UI change we'll carry the burden of supporting the old way
too forever. It adds t
I just got a fairly angry email from my sister about the new tab page UI.
She writes:
> "What’s up with the Chrome Tab page change? I thought I screwed up my page
> at home, but now my page at work has changed too.
I don’t like it.
Why do I have to have my tabs arranged 4x2 ? I liked 3x3.
W
Call me a wet blanket, but I don't think there's a strong need for more
divergence in the file. Anything not passing is failing and needs looking
at; having a way to say "oh, it's 'only' the image that's bad" will increase
maintenance burden and support ignoring problems. Situations where we're
wil
I prefer IMAGE and TEXT since people maintaining these lists need to type
these all the time. Also, longer names make for more bloat in the file and
in the dashboard. Anyone who works with these lists even a small amount will
know that IMAGE and TEXT refer to failures.
We should really get rid of
I think this plan sounds good, too.
I'm mucking with those scripts a bit at the moment for the LTTF
reporting, so I can make this change tomorrow, unless someone else
would rather do it.
I might actually prefer FAIL-TEXT and FAIL-IMAGE, but that's just me.
I agree that TEXTFAIL is better than TE
If most of our uses on the UI thread are WriteTransactions today, then I
agree using a Lock alone can't make things any jankier, because if you need
to write you need the lock. I guess what I'm wondering is if we'll ever
discover we could improve UI responsiveness somehow by using a
ReadTransactio
[Moving to chromium-dev]
Good question.
One case where we do any large amount of work with a ReadTransaction is the
LoadAssociations step of model association. This happens just once at
startup, and I don't expect there's another thread trying to do read-only
operations on the syncable::Director
We need builddir != srcdir. sgk was working on it, I helped with a
patch, not sure what became of it.
On Wed, Sep 23, 2009 at 2:52 PM, Andrew Scherkus wrote:
> One more data point: happens to me on windows and linux:
> $ cd src/v8
> $ svn st
> ? tools/gyp/v8_nosnapshot.mk
> ? tools/gy
One more data point: happens to me on windows and linux:
$ cd src/v8
$ svn st
? tools/gyp/v8_nosnapshot.mk
? tools/gyp/v8_snapshot.mk
? tools/gyp/v8.mk
? tools/gyp/js2c.mk
? tools/gyp/v8_shell.mk
? tools/gyp/mksnapshot.mk
? tools/gyp/v8_base.mk
On Wed, Sep 23, 2
I'll look into it. Sorrry, we added support for setting the default run
target, but it has to create a per user config file.
-BradN
On Wed, Sep 23, 2009 at 1:55 PM, Jeremy Orlow wrote:
> On Wed, Sep 23, 2009 at 1:43 PM, John Abd-El-Malek wrote:
>
>> I've seen this before last week as well.
>
>
On Wed, Sep 23, 2009 at 1:43 PM, John Abd-El-Malek wrote:
> I've seen this before last week as well.
I have too.
>
> Can this really be added to v8's svn:ignore? These VS generated files have
> the username in them.
>
>
> On Wed, Sep 23, 2009 at 1:39 PM, Mark Mentovai wrote:
>
>> This happe
Could we make them TEXTFAIL and IMAGEFAIL, just to be clear?
Stephen
(And then post them to failblog if they're really embarassing.. J/K ;)
On Wed, Sep 23, 2009 at 3:33 PM, Ojan Vafai wrote:
>
> +pam, tc, darin in case they disagree with what I'm saying here.
>
> Also a bunch of current expecta
John Abd-El-Malek wrote:
> I've seen this before last week as well.
OK, then there might be something else going on. When it happened in
the past, what did svn status show?
I've never seen this, by the way. (Any time I make changes to V8, I
don't do it in a Chromium working copy.)
> Can this
I've seen this before last week as well.
Can this really be added to v8's svn:ignore? These VS generated files have
the username in them.
On Wed, Sep 23, 2009 at 1:39 PM, Mark Mentovai wrote:
> This happened after a GYP change that Brad made recently (last week, I
> think).
>
> We need to add t
(using the write from address)
This sounds fine to me. It's like how we handle CRASH and TIMEOUT as
special failures.
On Wed, Sep 23, 2009 at 12:44 PM, Dimitri Glazkov wrote:
> On Wed, Sep 23, 2009 at 12:33 PM, Ojan Vafai wrote:
>> +pam, tc, darin in case they disagree with what I'm saying her
Same here. I see it both on windows and mac.
On Wed, Sep 23, 2009 at 1:35 PM, Elliot Glaysher (Chromium) <
e...@chromium.org> wrote:
>
> On Wed, Sep 23, 2009 at 1:25 PM, John Abd-El-Malek
> wrote:
> > I have to delete the v8 directory and run gclient sync again (or remove
> the
> > generated fi
This happened after a GYP change that Brad made recently (last week, I think).
We need to add to v8's svn:ignore.
John Abd-El-Malek wrote:
> Every time v8 team updates which branch is the one that's used in Chrome,
> gclient sync fails on Windows. The error is below.
> running 'svn upd
On Wed, Sep 23, 2009 at 1:25 PM, John Abd-El-Malek wrote:
> I have to delete the v8 directory and run gclient sync again (or remove the
> generated files). This is annoying, since it breaks syncing to all the
> Windows developers (I don't think this happens on Mac and Linux).
Actually, I have t
On Wed, Sep 23, 2009 at 1:26 PM, Peter Kasting wrote:
> On Wed, Sep 23, 2009 at 1:25 PM, John Abd-El-Malek wrote:
>
>> Every time v8 team updates which branch is the one that's used in Chrome,
>> gclient sync fails on Windows. The error is below.
>>
>
> That's weird. I haven't seen this on my m
On Wed, Sep 23, 2009 at 1:25 PM, John Abd-El-Malek wrote:
> Every time v8 team updates which branch is the one that's used in Chrome,
> gclient sync fails on Windows. The error is below.
>
That's weird. I haven't seen this on my machine.
PK
--~--~-~--~~~---~--~---
Every time v8 team updates which branch is the one that's used in Chrome,
gclient sync fails on Windows. The error is below.
running 'svn update a:\chrome2\src\tools\tryserver' in 'a:\chrome2'
At revision 3275.
Error: Can't switch the checkout to http://v8.googlecode.com/svn/tr...@2966;
FWIW, that command worked for me, but I have a hybrid checkout:
http://dev.chromium.org/developers/contributing-to-webkit
Adam
On Wed, Sep 23, 2009 at 1:10 PM, John Abd-El-Malek wrote:
> so I just tried a few experiments. For some reason, none of the changes in
> third_party\WebKit do an aut
so I just tried a few experiments. For some reason, none of the changes in
third_party\WebKit do an automatic try when uploading.
When I try to do gcl try with --root src\third_party, the change doesn't
apply on the server since it tries to patch a diff with
src\third_party\WebKit... in the filena
Yes I just fixed that moments ago. All today's try job up to now won't
show up on code review site. Sorry about that.
M-A
On Wed, Sep 23, 2009 at 3:54 PM, Matt Mueller wrote:
> I just ran git try and the status boxes didn't show up on the
> codereview page. Related?
> (http://codereview.chromi
On Wed, Sep 23, 2009 at 12:33 PM, Ojan Vafai wrote:
> +pam, tc, darin in case they disagree with what I'm saying here.
>
> Also a bunch of current expectations would need to be modified. All
> the cases where there is currently FAIL would need to be changed to
> either FAIL or IMAGE or both if it
I just ran git try and the status boxes didn't show up on the
codereview page. Related?
(http://codereview.chromium.org/219015/show, I do see the jobs on the
try-server waterfall..)
Matt
On Wed, Sep 23, 2009 at 12:32, Marc-Antoine Ruel wrote:
>
> The try server moved. There should be no side-
On Wed, Sep 23, 2009 at 11:30 AM, Evan Martin wrote:
>
> On Wed, Sep 23, 2009 at 11:26 AM, Mark Mentovai wrote:
> > If a test exposes a case where something requires 53/64-bit IEEE
> > double precision as opposed to 64/80-bit double extended, and we're
> > changing our configuration "to make tes
+pam, tc, darin in case they disagree with what I'm saying here.
Also a bunch of current expectations would need to be modified. All
the cases where there is currently FAIL would need to be changed to
either FAIL or IMAGE or both if it's a text and image failure. You
should be able to get most of
The try server moved. There should be no side-effects except that the
logs are lost (yet again). If you want to access the old try job logs,
the old try server is still running for a few days, so use the
continuous buildbot's address with the try server's port. If you don't
have access to corp net
BTW, would we want this to be temporary? I was thinking so, but then again,
being able to suppress a pixel failure separately from the layout failure
might be useful.
Avi
On Wed, Sep 23, 2009 at 3:24 PM, Avi Drissman wrote:
> I'm new to the test runner (and to python in general). Can you give m
There is not. But adding it would be easy. There's been mention of
doing this for a while, but noone has made the effort to make it work.
All you'd have to do is:
-modify a few lines in TestExpectationsFile in
src/webkit/tools/layout_tests/layout_package/test_expectations.py to
add support for IMA
I'm new to the test runner (and to python in general). Can you give me a
pointer where I should start?
Avi
On Wed, Sep 23, 2009 at 3:22 PM, Dirk Pranke wrote:
> No, there's no way to do that but it would be easy enough to add.
>
> -- Dirk
>
> On Wed, Sep 23, 2009 at 12:16 PM, Avi Drissman wrot
No, there's no way to do that but it would be easy enough to add.
-- Dirk
On Wed, Sep 23, 2009 at 12:16 PM, Avi Drissman wrote:
> I've been looking into the pixel test situation on the Mac, and it isn't bad
> at all. Of ~5300 tests that have png results, we're failing ~800, most of
> which fall
I've been looking into the pixel test situation on the Mac, and it isn't bad
at all. Of ~5300 tests that have png results, we're failing ~800, most of
which fall into huge buckets of easily-separable fail.
Is there a way to specify that we're expecting an image compare to fail but
still want the l
Ah. Yes that seems to be the guy. I can see in a text editor a
number of the URLs with {searchterm} scattered throughout. Haven't
verified if that is the only responsible entity, but it is certainly
involved.
Thanks Peter.
On Sep 23, 1:46 pm, Peter Kasting wrote:
> On Wed, Sep 23, 2009 at 11:
On Wed, Sep 23, 2009 at 11:44 AM, m.f wrote:
> That post suggested the entire User Data folder. I knew about this
> file long ago. However, the nature of the bug I was trying to
> overcome had to do with something that was not quite kosher within
> that folder. So I didn't want to just blindly
That post suggested the entire User Data folder. I knew about this
file long ago. However, the nature of the bug I was trying to
overcome had to do with something that was not quite kosher within
that folder. So I didn't want to just blindly copy it over. I tried
scrounging through the files i
Basically all Intel CPUs since Pentium 4 (since year 2000) support
SSE2, as well as AMD K8 CPUs. The main group seemingly left out is
Athlons pre-K8 (e.g. the non-64 bit versions available through 2005).
Do we have any sense of how big a market is? Is this basically the
same thing as Win2K where
Adam Langley wrote:
> * x87 doubles are 80-bits in registers and 64-bits in memory.
Depending on the state of the x87 floating point control word.
Can bracket significant test-impacting floating point operations with
fldcw or do something else in that code to force spills to memory?
I'm aware o
On Wed, Sep 23, 2009 at 11:34 AM, Evan Stade wrote:
> On Wed, Sep 23, 2009 at 11:31 AM, m.f wrote:
>>
>> I had to reinstall recently because of the enable-sync bug that hit a
>> few builds ago. As a result I had to re-establish all of my settings
>> including custom search engines. For future
On Wed, Sep 23, 2009 at 11:31 AM, m.f wrote:
>
> I had to reinstall recently because of the enable-sync bug that hit a
> few builds ago. As a result I had to re-establish all of my settings
> including custom search engines. For future preservation I would like
> to save a backup of whatever fi
If you pick "help" from the wrench menu it takes you to a user help forum.
I searched for "backup settings" there and found the answer in the
first page of search results.
On Wed, Sep 23, 2009 at 11:31 AM, m.f wrote:
>
> I had to reinstall recently because of the enable-sync bug that hit a
> few
On Wed, Sep 23, 2009 at 11:26 AM, Mark Mentovai wrote:
> doing something wrong. Using SSE2 floating-point operations in a
> configuration that we test and then using x87 floating-point
> operations in a configuration that we release is completely bogus.
The reality of the situation:
* x87 doub
I had to reinstall recently because of the enable-sync bug that hit a
few builds ago. As a result I had to re-establish all of my settings
including custom search engines. For future preservation I would like
to save a backup of whatever file/reg entry is responsible for these
settings. Can any
On Wed, Sep 23, 2009 at 11:26 AM, Mark Mentovai wrote:
> If a test exposes a case where something requires 53/64-bit IEEE
> double precision as opposed to 64/80-bit double extended, and we're
> changing our configuration "to make tests pass" but then releasing in
> another configuration where tho
Dan Kegel wrote:
> It's so our tests pass, I think.
We don't have tests for nothing.
If a test exposes a case where something requires 53/64-bit IEEE
double precision as opposed to 64/80-bit double extended, and we're
changing our configuration "to make tests pass" but then releasing in
another
It's so our tests pass, I think.
On Wed, Sep 23, 2009 at 11:20 AM, Mark Mentovai wrote:
> Is there a reason we gate this on branding? The comment doesn't speak
> to that at all.
>
> Evan Martin wrote:
>> The code doesn't lie:
>>
>> 'conditions': [
>> ['branding=="Chromium
Google Chrome builds without SSE2.
On Wed, Sep 23, 2009 at 11:16 AM, Dan Kegel wrote:
>
> Oddly, I can still install fine on my pentium III laptop, I think.
>
> On Wed, Sep 23, 2009 at 11:02 AM, Evan Martin wrote:
>> The code doesn't lie:
>>
>> 'conditions': [
>> ['brandi
Is there a reason we gate this on branding? The comment doesn't speak
to that at all.
Evan Martin wrote:
> The code doesn't lie:
>
> 'conditions': [
> ['branding=="Chromium"', {
> 'cflags': [
> '-march=pentium4',
> '-msse2',
Oddly, I can still install fine on my pentium III laptop, I think.
On Wed, Sep 23, 2009 at 11:02 AM, Evan Martin wrote:
> The code doesn't lie:
>
> 'conditions': [
> ['branding=="Chromium"', {
> 'cflags': [
> '-march=pentium4',
>
The code doesn't lie:
'conditions': [
['branding=="Chromium"', {
'cflags': [
'-march=pentium4',
'-msse2',
'-mfpmath=sse',
],
}],
],
http://code.google.com/p/c
Does our default build really depend on -msse2 anymore? Doesn't
seem to on linux...
2009/9/22 Ujjwol (उज्जवल लामिछाने) :
>
> This (http://code.google.com/p/chromium/wiki/LinuxPackaging) page says
> that
> For silly reasons our default build depends on SSE, but we don't
> actually need. Search ba
This (http://code.google.com/p/chromium/wiki/LinuxPackaging) page says
that
For silly reasons our default build depends on SSE, but we don't
actually need. Search base/common.gypi and patch out the -msse2 bits
before building your package.
But I cannot find base.common.gypi in the source tarball
2009/9/22 Ujjwol (उज्जवल लामिछाने) :
> But I cannot find base.common.gypi in the source tarball of the
> chromium. How should I fix this problem ?
Opps, there was a typo on that wiki page which I've now fixed. The
correct location is build/common.gypi.
AGL
--~--~-~--~~~
For anyone still interested in this issue, change sets for WebKit and
Chromium are available here:
http://codereview.chromium.org/220010 (WebKit)
http://codereview.chromium.org/225012 (Chromium)
Thanks,
Marshall
On Mon, Jul 6, 2009 at 12:47 PM, Marshall Greenblatt wrote:
> On Mon, Jul 6, 200
On Wed, Sep 23, 2009 at 2:21 AM, Jens Alfke wrote:
>
> On Sep 22, 2009, at 2:54 PM, Mikhail Naganov wrote:
>
>> I'm working on showing JS objects retainers. But this only works for
>> objects that live inside V8's heap.
>
> That would still be useful — I'd love to be able to look at all the 'Wind
> Apparently an announcement message is also en-route to the W3C WebApps
> working group.
It's in their archives now..
fyi: Strict Transport Security specification
http://lists.w3.org/Archives/Public/public-webapps/2009JulSep/1148.html
Please send feedback on the spec to the public-weba
Hi! i have an app which find opened browsers and retrieves opened
pages in each one.
With FF, IE and Opera i can get opened pages title with their urls
like "Google - http://www.google.com"; using Active Accessibility,
but i failed to do the same with Chrome. After two days of playing
with Chrome
This (http://code.google.com/p/chromium/wiki/LinuxPackaging) page says
that
For silly reasons our default build depends on SSE, but we don't
actually need. Search base/common.gypi and patch out the -msse2 bits
before building your package.
But I cannot find base.common.gypi in the source tarball
On Wed, Sep 23, 2009 at 7:02 PM, Jens Alfke wrote:
>
> On Sep 23, 2009, at 12:32 AM, Mads Sig Ager wrote:
>
>> another thing you should be aware of is that DOM nodes are only
>> collected on full garbage collections. In order to see what is
>> actually live at the end of a test, you have to forc
BTW, I trying to be snarky in my request. More like begging :)
:DG<
On Wed, Sep 23, 2009 at 10:08 AM, John Abd-El-Malek wrote:
> Marc-Antonie knows the try scripts best, so to avoid volunteering him
> directly, I'll say that I'm sure he can answer any questions from whoever
> does this. I don'
Marc-Antonie knows the try scripts best, so to avoid volunteering him
directly, I'll say that I'm sure he can answer any questions from whoever
does this. I don't think it'll be much work.
On Wed, Sep 23, 2009 at 10:04 AM, Dimitri Glazkov wrote:
> I think this is a great idea! Do we have a Pytho
I think this is a great idea! Do we have a Python/gcl/rietveld expert
who can tackle this?
:DG<
On Wed, Sep 23, 2009 at 9:49 AM, John Abd-El-Malek wrote:
> I didn't know this was possible. It seems it will get a lot more usage if
> it "just works", i.e. the try script grabs these settings auto
On Sep 23, 2009, at 12:32 AM, Mads Sig Ager wrote:
> another thing you should be aware of is that DOM nodes are only
> collected on full garbage collections. In order to see what is
> actually live at the end of a test, you have to force a number of GCs.
But the GC should happen automatically a
On Wed, Sep 23, 2009 at 5:36 PM, Evan Martin wrote:
>>> 5) Do a set subtraction of all-syms minus dead-syms.
>>> I wrote a small Python script:
>>>
>>> def load(filename):
>>> s = set()
>>> for line in open(filename):
>>> s.add(line.strip())
>>> return s
>>> for sym in sub(load(sy
I didn't know this was possible. It seems it will get a lot more usage if
it "just works", i.e. the try script grabs these settings automatically from
a codereview.settings file. If we start by putting this file in
third_party\WebKit, then people who start with their patch there (also to
upload)
On Wed, Sep 23, 2009 at 9:30 AM, David Levin wrote:
> On Wed, Sep 23, 2009 at 8:53 AM, Glenn Wilson wrote:
>
>> I'll take the action item to remove anyone in the rotation who is not
>> actively working on Webkit / is not a committer.
>>
>
> Oh no... now it will happen even more often :)
>
> Shoul
>> 5) Do a set subtraction of all-syms minus dead-syms.
>> I wrote a small Python script:
>>
>> def load(filename):
>> s = set()
>> for line in open(filename):
>> s.add(line.strip())
>> return s
>> for sym in sub(load(sys.argv[1]) - load(sys.argv[2]):
>> print sym
>
> FWIW, you
On Tue, Sep 22, 2009 at 10:47 PM, David Levin wrote:
> Actionable items for keeping the tree green (in addition to blaming the
> WebKit gardener for [insert action here]):
>
>- *Get people putting in chromium patches upstream to run their changes
>through trybots, etc*. imo, patches from
On Wed, Sep 23, 2009 at 8:55 AM, Paweł Hajdan Jr.
wrote:
> On Tue, Sep 22, 2009 at 18:06, Dimitri Glazkov wrote:
>
>> Today wasn't a happy day for p...@. He did a seemingly innocuous roll
>> that broke the world: selenium, ui tests, layout tests. I am sure it
>> was stressful and probably added un
On Wed, Sep 23, 2009 at 8:53 AM, Glenn Wilson wrote:
> I'll take the action item to remove anyone in the rotation who is not
> actively working on Webkit / is not a committer.
>
Oh no... now it will happen even more often :)
Should there also be the reverse adding WebKit committers who are not
I think it would be a good idea to ensure that there is at least someone on
call to help new gardeners if they have questions or find themselves in a
mess. I know I just asked dglazkov whenever I wasn't sure what to do, but
he'd probably appreciate not being the only designated knowledgeable perso
On Tue, Sep 22, 2009 at 18:06, Dimitri Glazkov wrote:
> Today wasn't a happy day for p...@. He did a seemingly innocuous roll
> that broke the world: selenium, ui tests, layout tests. I am sure it
> was stressful and probably added unnecessary gray to his hair.
How about running ui and selenium
I'll take the action item to remove anyone in the rotation who is not
actively working on Webkit / is not a committer.
In the past, I've floated the idea in the past of having a "Webkit deputy"
who helps the gardener keep the canary green. I'm not sure if that would
help, though.
Regards,
Glenn
I find that being a WebKit gardener is always dancing on a minefield
regardless of my familiarity with the WebKit code base. Look at yesterday
for an example.
In addition, we have several gardeners who are not actively working on
WebKit (amanda@ has 0 WebKit commits, pinkerton@ has a few all in 200
On Wed, Sep 23, 2009 at 7:46 AM, Mike Pinkerton wrote:
> > It is hard to be a WebKit gardener if you do not have WebKit commit
> access.
> > Sometimes the gardener has to commit a quick bustage fix upstream or roll
> > back a fellow Chromium committers change to WebKit.
> > -Darin
>
> Correct, it
On Wed, Sep 23, 2009 at 7:46 AM, Mike Pinkerton wrote:
>> It is hard to be a WebKit gardener if you do not have WebKit commit access.
>> Sometimes the gardener has to commit a quick bustage fix upstream or roll
>> back a fellow Chromium committers change to WebKit.
>> -Darin
>
> Correct, it is ha
> It is hard to be a WebKit gardener if you do not have WebKit commit access.
> Sometimes the gardener has to commit a quick bustage fix upstream or roll
> back a fellow Chromium committers change to WebKit.
> -Darin
Correct, it is hard, but many/most of us who are webkit
sheriffs/gardeners are n
On Tue, Sep 22, 2009 at 9:35 PM, Adam Barth wrote:
> On Tue, Sep 22, 2009 at 6:25 PM, John Abd-El-Malek wrote:
>> Is this even possible? i.e. I had uploaded a WebKit patch on codereview but
>> none of the patchsets got run on the try server
>> http://codereview.chromium.org/178030/show
>
> It i
> 1) writers of patches don't mention that the patch is two-sided and
> will break Chromium if landed prematurely. I don't have to go far for
> an example. Commit queue bot landed
> http://trac.webkit.org/changeset/48659 a few minutes ago and broke the
> canary. This means that the canary will be
On Wed, Sep 23, 2009 at 7:23 AM, Mike Pinkerton wrote:
>
> > WebKit gardening occurs more often than sheriff duties.
> > afaik all WebKit gardeners also have sheriff duties.
>
> This implies there are people on the team who don't have gardening
> duties. We need to fix that ASAP. Nobody should get
On Wed, Sep 23, 2009 at 6:52 AM, Amanda Walker wrote:
> ... I agree that the real solution is to keep pedaling hard to finish the
> webkit API.
>
If anyone has cycles to help with the WebKit API, please let me know! :-)
-Darin
--~--~-~--~~~---~--~~
Chromium Deve
> WebKit gardening occurs more often than sheriff duties.
> afaik all WebKit gardeners also have sheriff duties.
This implies there are people on the team who don't have gardening
duties. We need to fix that ASAP. Nobody should get special
dispensation.
--
Mike Pinkerton
Mac Weenie
pinker...@go
It was in the suppression list already, just shifted around. The original
bug isn't closed; it's marked as upstream, though I don't know if that's a
significant difference :)
Feel free to play with it; I have some pixel tests to stare down.
Avi
On Wed, Sep 23, 2009 at 12:46 AM, Erik Kay wrote:
On Tue, Sep 22, 2009 at 8:40 PM, Nicolas Sylvain wrote:
> Oh, and, if your change turned the tree red for 3 hours, don't be mad at
> the sheriff when he pings
> you repeatedly about the status of the fix. His job is to keep the tree
> green and running. He does
> not care about your change.
>
> T
sounds like this issue http://crbug.com/20451
On Sep 22, 8:39 pm, Daniel Cowx wrote:
> Can someone please provide a bit of insight into how to solve the
> following problem:
>
> 1. Open Chromium > Options > Show saved passwords
> 2. Click the "Remove All button"
>
> Now, *before* you click "Yes"
Sending from proper account, sorry.
On Wed, Sep 23, 2009 at 1:05 PM, Anton Muhin wrote:
> In your case there should be not that many DOM windows objects and
> they all should survive in batches, so if I'd face such a problem, I'd
> just put a break point to see why this object got marked in the
I use --debug-children (usually in conjunction with --single-process).
-Darin
On Tue, Sep 22, 2009 at 3:00 PM, Paweł Hajdan Jr.
wrote:
> What's the best way to attach the debugger to a browser started by a UI
> test? How about doing that only in case of a crash?
> I'm looking for solution both
Jens,
another thing you should be aware of is that DOM nodes are only
collected on full garbage collections. In order to see what is
actually live at the end of a test, you have to force a number of GCs.
If you run in the test shell with the --js-flags="--expose-gc" flag,
you can force gc's by
97 matches
Mail list logo
