On Thu, 25 Jan 2024 04:33:25 GMT, Tejesh R wrote:
> > Even if you'll go this route, I'm for replacing `Vector` with `ArrayList`
> > for the `newFileCache` and `newFiles` variables. These are local variables,
> > they're not accessed concurrently. Yet they're accessed from two threads:
> > the
On Thu, 18 Jan 2024 11:09:12 GMT, Prasanta Sadhukhan
wrote:
> Lines are left behind when moving the scrollbar in the positive direction.
> but are cleaned up on mouse release.
> Additonally, with right arrow clicks too, the lines are left behind.
> Seems like for mouseDragged and scrollByUnit
On Thu, 18 Jan 2024 11:09:12 GMT, Prasanta Sadhukhan
wrote:
> Lines are left behind when moving the scrollbar in the positive direction.
> but are cleaned up on mouse release.
> Additonally, with right arrow clicks too, the lines are left behind.
> Seems like for mouseDragged and scrollByUnit
On Tue, 23 Jan 2024 04:31:45 GMT, Prasanta Sadhukhan
wrote:
>> Lines are left behind when moving the scrollbar in the positive direction.
>> but are cleaned up on mouse release.
>> Additonally, with right arrow clicks too, the lines are left behind.
>> Seems like for mouseDragged and scrollBy
On Wed, 24 Jan 2024 05:35:42 GMT, Prasanta Sadhukhan
wrote:
>> When using a TreeCellRenterer which creates new components in
>> getTreeCellRendererComponent() in a JTree that is not visible, changes to
>> the nodes cause a memory leak.
>> When a node is changed, the Method getNodeDimensions()
On Wed, 17 Jan 2024 12:55:52 GMT, Tejesh R wrote:
> Suggested fix [JDK-8307091](https://bugs.openjdk.org/browse/JDK-8307091) also
> created concurrent exception intermittently (monthly once/quarterly once) on
> CI system. The issue was not able to be reproduced yet, hence proposing an
> altern
On Wed, 24 Jan 2024 16:51:15 GMT, Tejesh R wrote:
> Using `synchronized (fileCache)` inside `ShellFolder.invoke` would be better
> and one solution right? Than making local copy and again doing sanity
> checks/changing to `ArrayList`?
I'm afraid I can't answer this question without more detail
On Tue, 23 Jan 2024 08:41:02 GMT, Andrey Turbanov wrote:
>> Then adding `synchronized(fileCache)` in `FilesLoader` where list comparison
>> happens would be better idea?
>
> Yes. If you go with `synchronized` then it should be `synchronized
> (fileCache)`
This is my concern as well. It looks a
On Tue, 23 Jan 2024 03:37:45 GMT, Prasanta Sadhukhan
wrote:
>> javadoc contract for JComponent.setMinimumSize(Dimension) states:
>>
>> "Sets the minimum size of this component to a constant value. Subsequent
>> calls to getMinimumSize will always return this value..."
>>
>> However, JScrollBa
On Mon, 22 Jan 2024 21:07:03 GMT, Alexander Zuev wrote:
>> Replaced asserts with NullPointerException calls because outside of testing
>> that would be more informative - i do not think many people running their
>> applications with assertions in system libraries enabled;
>> Added a code that w
On Thu, 18 Jan 2024 02:48:26 GMT, Prasanta Sadhukhan
wrote:
> As mentioned in the comment
>
> https://github.com/openjdk/jdk/blob/36f4b34f1953af736706ec67192204727808bc6c/src/java.desktop/share/classes/javax/swing/plaf/basic/BasicTreeUI.java#L3283-L3284
>
> the components are to be removed whe
On Tue, 23 Jan 2024 04:58:00 GMT, Prasanta Sadhukhan
wrote:
>> src/java.desktop/share/classes/javax/swing/plaf/basic/BasicTreeUI.java line
>> 1338:
>>
>>> 1336: if(rendererPane != null) {
>>> 1337: if (!tree.isVisible()) {
>>> 1338: rendererPane.removeAll();
On Fri, 19 Jan 2024 04:48:40 GMT, Prasanta Sadhukhan
wrote:
>> javadoc contract for JComponent.setMinimumSize(Dimension) states:
>>
>> "Sets the minimum size of this component to a constant value. Subsequent
>> calls to getMinimumSize will always return this value..."
>>
>> However, JScrollBa
On Wed, 17 Jan 2024 07:19:21 GMT, Prasanta Sadhukhan
wrote:
> When using a TreeCellRenterer which creates new components in
> getTreeCellRendererComponent() in a JTree that is not visible, changes to the
> nodes cause a memory leak.
> When a node is changed, the Method getNodeDimensions() is c
On Wed, 17 Jan 2024 07:19:21 GMT, Prasanta Sadhukhan
wrote:
> When using a TreeCellRenterer which creates new components in
> getTreeCellRendererComponent() in a JTree that is not visible, changes to the
> nodes cause a memory leak.
> When a node is changed, the Method getNodeDimensions() is c
On Thu, 18 Jan 2024 11:09:12 GMT, Prasanta Sadhukhan
wrote:
> Lines are left behind when moving the scrollbar in the positive direction.
> but are cleaned up on mouse release.
> Additonally, with right arrow clicks too, the lines are left behind.
> Seems like for mouseDragged and scrollByUnit
On Sun, 21 Jan 2024 00:39:38 GMT, Sergey Bylokhov wrote:
> > Also, it might be the case the scrollbar methods like getUnitIncrement,
> > scrollBar.getValue scrollbar.setValue setThumbBounds sets or returns or
> > uses integer value despite scale being non-integer, so I guess repainting
> > dir
On Mon, 22 Jan 2024 00:33:34 GMT, Sergey Bylokhov wrote:
> Maybe we should check that something useful is returned? at least non-null VS
> null value?
Makes sense to ensure the returned value is not `null`.
-
PR Review Comment: https://git.openjdk.org/jdk/pull/17475#discussion_r14
On Thu, 18 Jan 2024 19:34:11 GMT, Alexander Zuev wrote:
>> src/java.desktop/windows/classes/sun/awt/shell/Win32ShellFolder2.java line
>> 1208:
>>
>>> 1206: } else {
>>> 1207: return new MultiResolutionIconImage(size,
>>> multiResolutionIcon);
>>> 1208: }
On Thu, 18 Jan 2024 19:40:40 GMT, Alexander Zuev wrote:
>> Replaced asserts with NullPointerException calls because outside of testing
>> that would be more informative - i do not think many people running their
>> applications with assertions in system libraries enabled;
>> Added a code that w
On Thu, 18 Jan 2024 00:47:00 GMT, Alexander Zuev wrote:
> Replaced asserts with NullPointerException calls because outside of testing
> that would be more informative - i do not think many people running their
> applications with assertions in system libraries enabled;
> Added a code that will
On Fri, 12 Jan 2024 02:55:59 GMT, Sergey Bylokhov wrote:
>> @mrserb ,
>>
>> Did you mean to use the wrapper for the middle like `ColorSpace mid =
>> createCS(ColorSpaceSelector.WRAPPED_PYCC);` , So we can achieve :
>>
>> **From**
>> wrapper->icc_color_space->wrapper
>> icc_color_space->i
On Wed, 17 Jan 2024 01:56:25 GMT, songpv-imt wrote:
>> The root cause of the bug is because mousePress() method is invoked before
>> mouseMove() event is completely processed causing the drag & drop behavior
>> not being able to be recognized properly. This in turn makes the method
>> dragSour
On Tue, 16 Jan 2024 18:54:42 GMT, songpv-imt wrote:
>> The root cause of the bug is because mousePress() method is invoked before
>> mouseMove() event is completely processed causing the drag & drop behavior
>> not being able to be recognized properly. This in turn makes the method
>> dragSour
On Tue, 16 Jan 2024 17:58:37 GMT, Harshitha Onkar wrote:
> Ran the updated test on macOS 13 and 14.2, it works well with the
> stabilization fix done for macOS 14.1. Changes look good.
I ran a job with 50 repeats of the test in our CI, the test passes. I've
submitted a new job, just in a case,
On Tue, 16 Jan 2024 17:29:50 GMT, songpv-imt wrote:
>> The root cause of the bug is because mousePress() method is invoked before
>> mouseMove() event is completely processed causing the drag & drop behavior
>> not being able to be recognized properly. This in turn makes the method
>> dragSour
On Tue, 16 Jan 2024 15:41:50 GMT, Renjith Kannath Pariyangad
wrote:
>> Hi Reviewers,
>> There was a typo for color conversion instead of dstColorSpace function
>> srcColorSpace was used. Please review and let me know your suggestions if
>> any.
>>
>> Renjith.
>
> Renjith Kannath Pariyangad
On Tue, 16 Jan 2024 12:47:50 GMT, Alexey Ivanov wrote:
> In addition to this, I propose removing `robot.delay(50);` from the
> for-loops, or at least reducing this value, let's say, to 5.
The test is unstable without a delay inside the for-loop.
`robot.delay(5)` does the tric
On Wed, 3 Jan 2024 19:21:47 GMT, Alexey Ivanov wrote:
>> Renjith Kannath Pariyangad has updated the pull request incrementally with
>> two additional commits since the last revision:
>>
>> - Copyright year updated
>> - Review suggestions implement
On Tue, 16 Jan 2024 04:21:48 GMT, Renjith Kannath Pariyangad
wrote:
>> Hi Reviewers,
>> There was a typo for color conversion instead of dstColorSpace function
>> srcColorSpace was used. Please review and let me know your suggestions if
>> any.
>>
>> Renjith.
>
> Renjith Kannath Pariyangad
On Fri, 12 Jan 2024 22:18:04 GMT, Alisen Chung wrote:
>> SunToolkit.java is trying to post an event on the TrayIcon appContext, but
>> the TrayIcon was already removed by the test, causing an error. The fix is
>> to make SunToolkit skip posting the event if appContext is null. The test is
>> a
On Tue, 16 Jan 2024 12:46:30 GMT, Alexey Ivanov wrote:
>> songpv-imt has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Update InterJVMGetDropSuccessTest.java
>> - Remove robot.setWaitForIdle(true) and
On Tue, 16 Jan 2024 10:52:34 GMT, songpv-imt wrote:
>> The root cause of the bug is because mousePress() method is invoked before
>> mouseMove() event is completely processed causing the drag & drop behavior
>> not being able to be recognized properly. This in turn makes the method
>> dragSour
On Tue, 19 Dec 2023 02:09:08 GMT, songpv-imt wrote:
>> The root cause of the bug is because mousePress() method is invoked before
>> mouseMove() event is completely processed causing the drag & drop behavior
>> not being able to be recognized properly. This in turn makes the method
>> dragSour
On Fri, 12 Jan 2024 22:18:04 GMT, Alisen Chung wrote:
>> SunToolkit.java is trying to post an event on the TrayIcon appContext, but
>> the TrayIcon was already removed by the test, causing an error. The fix is
>> to make SunToolkit skip posting the event if appContext is null. The test is
>> a
On Fri, 12 Jan 2024 22:04:37 GMT, Alisen Chung wrote:
>> SunToolkit.java is trying to post an event on the TrayIcon appContext, but
>> the TrayIcon was already removed by the test, causing an error. The fix is
>> to make SunToolkit skip posting the event if appContext is null. The test is
>> a
On Tue, 19 Dec 2023 02:09:08 GMT, songpv-imt wrote:
>> The root cause of the bug is because mousePress() method is invoked before
>> mouseMove() event is completely processed causing the drag & drop behavior
>> not being able to be recognized properly. This in turn makes the method
>> dragSour
On Tue, 19 Dec 2023 02:09:08 GMT, songpv-imt wrote:
>> The root cause of the bug is because mousePress() method is invoked before
>> mouseMove() event is completely processed causing the drag & drop behavior
>> not being able to be recognized properly. This in turn makes the method
>> dragSour
On Fri, 12 Jan 2024 23:46:06 GMT, Sergey Bylokhov wrote:
> for test execution it does not matter but when opened in ide it conflicts
> with some other Error classes from the tests.
I feel your pain!
I suggest refactoring those tests and make their private `Error` class a static
member of the
On Sun, 14 Jan 2024 09:31:29 GMT, Sergey Bylokhov wrote:
> > Currently, we have test and gold which use the same ColorSpace which could
> > be plain or wrapper for both cases. It looks confusing to me.
>
> That could be fine. We can create a gold image first, then parametrize the
> test method
On Fri, 12 Jan 2024 23:48:49 GMT, Sergey Bylokhov wrote:
>> Since the time the bug was reported color conversion accuracy for the sRGB
>> profile and specific values from the report increased by x100. This is a
>> request to add the code from the report as a test case.
>
> Sergey Bylokhov has u
On Fri, 12 Jan 2024 22:35:34 GMT, Sergey Bylokhov wrote:
>> Since the time the bug was reported color conversion accuracy for the sRGB
>> profile and specific values from the report increased by x100. This is a
>> request to add the code from the report as a test case.
>
> Sergey Bylokhov has u
On Fri, 12 Jan 2024 21:51:07 GMT, Rajat Mahajan wrote:
>> ImageIcon.loadImage used to handle InterruptedException only by printing a
>> message to the console. JDK-8236987 handled the interrupted state more
>> gracefully, but it didn't restore the interrupted flag.
>> This change restores the i
On Fri, 12 Jan 2024 20:51:38 GMT, Sergey Bylokhov wrote:
>> Since the time the bug was reported color conversion accuracy for the sRGB
>> profile and specific values from the report increased by x100. This is a
>> request to add the code from the report as a test case.
>
> Sergey Bylokhov has u
On Wed, 10 Jan 2024 21:08:35 GMT, Alisen Chung wrote:
>> SunToolkit.java is trying to post an event on the TrayIcon appContext, but
>> the TrayIcon was already removed by the test, causing an error. The fix is
>> to make SunToolkit skip posting the event if appContext is null. The test is
>> a
On Fri, 12 Jan 2024 09:53:46 GMT, Renjith Kannath Pariyangad
wrote:
>> Hi Reviewers,
>> There was a typo for color conversion instead of dstColorSpace function
>> srcColorSpace was used. Please review and let me know your suggestions if
>> any.
>>
>> Renjith.
>
> Renjith Kannath Pariyangad
On Fri, 12 Jan 2024 09:53:46 GMT, Renjith Kannath Pariyangad
wrote:
>> Hi Reviewers,
>> There was a typo for color conversion instead of dstColorSpace function
>> srcColorSpace was used. Please review and let me know your suggestions if
>> any.
>>
>> Renjith.
>
> Renjith Kannath Pariyangad
On Fri, 12 Jan 2024 19:17:24 GMT, Rajat Mahajan wrote:
> ImageIcon.loadImage used to handle InterruptedException only by printing a
> message to the console. JDK-8236987 handled the interrupted state more
> gracefully, but it didn't restore the interrupted flag.
> This change restores the inter
On Thu, 11 Jan 2024 20:04:56 GMT, Harshitha Onkar wrote:
> While investigating a macOS 14 issue noticed missing null checks in
> java/awt/Mouse/GetMousePositionTest/GetMousePositionWithPopup.java
>
> The missing null check will cause an NPE in finally block when frame2 is not
> created in the
On Fri, 12 Jan 2024 16:35:34 GMT, Rajat Mahajan wrote:
>> Remove commented out/ unused code from awt_List.cpp, which has been
>> commented out since 2007, when the code was moved to Mercurial.
>> The test ScrollPaneLimitation.java has been opened under
>> [JDK-8306137](https://bugs.openjdk.org/
On Thu, 11 Jan 2024 18:43:00 GMT, Rajat Mahajan wrote:
> Remove commented out/ unused code from awt_List.cpp, which has been commented
> out since 2007, when the code was moved to Mercurial.
> The test ScrollPaneLimitation.java has been opened under
> [JDK-8306137](https://bugs.openjdk.org/brow
On Thu, 4 Jan 2024 12:32:21 GMT, Alexey Ivanov wrote:
> > Thank you, Karl, for bringing the problem in this PR. It already exist in
> > JBS as [JDK-8320692](https://bugs.openjdk.org/browse/JDK-8320692): _Cannot
> > invoke java.awt.Image.getWidth(java.awt.image.ImageObserver
On Wed, 27 Dec 2023 04:20:42 GMT, Renjith Kannath Pariyangad
wrote:
> Hi Reviewers,
>
> I have updated the test case. Now test has pass/fail option also test will
> execute two time for covering different cases which are part of the test.
>
> Please review and let me know your suggestions.
>
On Tue, 9 Jan 2024 11:11:38 GMT, Renjith Kannath Pariyangad
wrote:
>> Hi Reviewers,
>> There was a typo for color conversion instead of dstColorSpace function
>> srcColorSpace was used. Please review and let me know your suggestions if
>> any.
>>
>> Renjith.
>
> Renjith Kannath Pariyangad h
On Thu, 4 Jan 2024 14:40:59 GMT, Matthias Baesken wrote:
> > It should be extended to include the possible failure in the preceding call
> > to ::GetDIBits.
>
> I handle now also a failure of the first GetDIBits call; and also added
> braces at the if's mentioned.
Sorry for my delayed reply.
On Tue, 9 Jan 2024 11:11:38 GMT, Renjith Kannath Pariyangad
wrote:
>> Hi Reviewers,
>> There was a typo for color conversion instead of dstColorSpace function
>> srcColorSpace was used. Please review and let me know your suggestions if
>> any.
>>
>> Renjith.
>
> Renjith Kannath Pariyangad h
On Mon, 8 Jan 2024 19:48:36 GMT, Rajat Mahajan wrote:
>> Since newInsets() function is a helper function used in ThemeReader.cpp only
>> , this change declares it as static.
>
> Rajat Mahajan has updated the pull request incrementally with one additional
> commit since the last revision:
>
>
On Mon, 8 Jan 2024 18:45:05 GMT, Rajat Mahajan wrote:
> 8322545: Declare newInsets as static in ThemeReader.cpp
Marked as reviewed by aivanov (Reviewer).
src/java.desktop/windows/native/libawt/windows/ThemeReader.cpp line 1:
> 1: /*
Update the copyright year to 2024.
-
PR Review
On Mon, 8 Jan 2024 13:48:10 GMT, Alexey Ivanov wrote:
> To avoid any confusion, I suggest renaming `compareImages` to
> `areImagesEqual` which leaves no ambiguity for its return value. I've updated
> the code in [commit
> `1788ef6`](https://github.com/aivan
On Thu, 30 Nov 2023 19:20:50 GMT, Sergey Bylokhov wrote:
>> Hi Reviewers,
>> There was a typo for color conversion instead of dstColorSpace function
>> srcColorSpace was used. Please review and let me know your suggestions if
>> any.
>>
>> Renjith.
>
> Can this patch be covered by the new te
On Fri, 5 Jan 2024 13:18:46 GMT, Renjith Kannath Pariyangad
wrote:
>> There are at least two similar copy/paste typos.
>> In the next line
>> https://github.com/openjdk/jdk/blob/f73dbb985823d2d59bfcff8ba6951a0d9eb2cefc/src/java.desktop/share/classes/java/awt/image/ColorConvertOp.java#L771
>> w
On Fri, 5 Jan 2024 12:03:43 GMT, Renjith Kannath Pariyangad
wrote:
>> Hi Reviewers,
>> There was a typo for color conversion instead of dstColorSpace function
>> srcColorSpace was used. Please review and let me know your suggestions if
>> any.
>>
>> Renjith.
>
> Renjith Kannath Pariyangad h
On Fri, 5 Jan 2024 12:03:43 GMT, Renjith Kannath Pariyangad
wrote:
>> Hi Reviewers,
>> There was a typo for color conversion instead of dstColorSpace function
>> srcColorSpace was used. Please review and let me know your suggestions if
>> any.
>>
>> Renjith.
>
> Renjith Kannath Pariyangad h
On Thu, 4 Jan 2024 18:04:59 GMT, Sergey Bylokhov wrote:
> > I thought about it… I thought that the filter itself should exercise the
> > code path that's modified but it doesn't seem like it does… I mean creating
> > images with regular ICC profile and using the wrapper TestColorSpace in
> > c
On Thu, 4 Jan 2024 13:05:42 GMT, Renjith Kannath Pariyangad
wrote:
>> Hi Reviewers,
>> There was a typo for color conversion instead of dstColorSpace function
>> srcColorSpace was used. Please review and let me know your suggestions if
>> any.
>>
>> Renjith.
>
> Renjith Kannath Pariyangad h
On Thu, 4 Jan 2024 11:53:19 GMT, Renjith Kannath Pariyangad
wrote:
>> Your `TestColorSpace` class is a wrapper on top of the actual color space.
>> So you can compare the results of conversion using `TestColorSpace` vs using
>> "actual color space" directly.
>
> Thank you for sharing the detai
On Thu, 4 Jan 2024 06:14:49 GMT, Sergey Bylokhov wrote:
>> @mrserb, Thank you for bringing this up. Sorry I am not pretty clear about
>> your suggestion on _Conversion via TestColorSpace wrapper vs ColorSpace w/o
>> wrapper._ . In existing code `compareImages` (pixel value compare) function
>>
On Tue, 2 Jan 2024 17:58:19 GMT, Alexey Ivanov wrote:
> Thank you, Karl, for bringing the problem in this PR. It already exist in JBS
> as [JDK-8320692](https://bugs.openjdk.org/browse/JDK-8320692): _Cannot invoke
> java.awt.Image.getWidth(java.awt.image.ImageObserver)_.
>
On Wed, 3 Jan 2024 19:54:47 GMT, Alexey Ivanov wrote:
>> Updated this
>
> I agree with Sergey and I can't see any updates.
Hm… If modify the `toRGB` and `fromRGB` methods to use `csRGB` object, then the
test does not fail without the fix.
What's more interesting is tha
On Wed, 3 Jan 2024 03:42:35 GMT, Renjith Kannath Pariyangad
wrote:
>> test/jdk/java/awt/color/NonICCFilterTest.java line 53:
>>
>>> 51:
>>> 52: public float[] toRGB(float[] colorvalue) {
>>> 53: return colorvalue;
>>
>> Just for completeness, it is probably better to use c
On Wed, 3 Jan 2024 03:45:06 GMT, Renjith Kannath Pariyangad
wrote:
>> Hi Reviewers,
>> There was a typo for color conversion instead of dstColorSpace function
>> srcColorSpace was used. Please review and let me know your suggestions if
>> any.
>>
>> Renjith.
>
> Renjith Kannath Pariyangad h
On Wed, 3 Jan 2024 13:55:22 GMT, Matthias Baesken wrote:
>> In [JDK-8322772](https://bugs.openjdk.org/browse/JDK-8322772) one similar
>> cleanup has been proposed before (and was done in the change). But there are
>> a number of other places in the codebase where the import is done and still
>
On Wed, 3 Jan 2024 08:16:12 GMT, Matthias Baesken wrote:
> https://learn.microsoft.com/en-us/cpp/c-runtime-library/format-specification-syntax-printf-and-wprintf-functions?view=msvc-170
> The %S is for wide chars, do you think we need the other one (%s) ?
You're right, it should be wide-char.
On Thu, 28 Dec 2023 09:48:52 GMT, Matthias Baesken wrote:
> When running with fastdebug binaries we run intermittent into the issue below
> in
> jtreg test
> java/awt/image/MultiResolutionImage/MultiResolutionImageObserverTest.java .
> Seems we miss checking of successful HBITMAP creation befor
On Wed, 3 Jan 2024 00:38:19 GMT, Sergey Bylokhov wrote:
> I think we should fallback to something. The bug itself looks similar to
> this: https://bugs.openjdk.org/browse/JDK-8185862
[JDK-8185862](https://bugs.openjdk.org/browse/JDK-8185862) seems to be the
exact duplicate of this one.
It ref
On Tue, 21 Nov 2023 03:33:21 GMT, Prasanta Sadhukhan
wrote:
>> javadoc contract for JComponent.setMinimumSize(Dimension) states:
>>
>> "Sets the minimum size of this component to a constant value. Subsequent
>> calls to getMinimumSize will always return this value..."
>>
>> However, JScrollBa
On Tue, 2 Jan 2024 19:37:53 GMT, Alexey Ivanov wrote:
> It seems that we cannot continue if `hBMDC` or `hBM` are null. Yet it seems
> unexpected.
Should we rather modify the code to back out and not to call APIs with NULL
handles?
-
PR Review Comment: https://git.openjdk.o
On Thu, 28 Dec 2023 09:48:52 GMT, Matthias Baesken wrote:
> When running with fastdebug binaries we run intermittent into the issue below
> in
> jtreg test
> java/awt/image/MultiResolutionImage/MultiResolutionImageObserverTest.java .
> Seems we miss checking of successful HBITMAP creation befor
On Mon, 16 Jan 2023 14:19:52 GMT, Alexey Ivanov wrote:
> This is somewhat a continuation of #11104 where the issue was discussed and
> where I found [the root
> cause](https://github.com/openjdk/jdk/pull/11104#issuecomment-1382435784).
>
> **Root Cause**
>
> The icon ext
On Wed, 27 Dec 2023 03:47:16 GMT, Renjith Kannath Pariyangad
wrote:
>> Hi Reviewers,
>>
>> Updated the test and it will generate required images on the fly so storing
>> and loading image from repo could be avoided. Please review and let me know
>> your suggestions.
>>
>> Regards,
>> Renjith
On Thu, 21 Dec 2023 01:19:40 GMT, Rajat Mahajan wrote:
> **Issue:**
> https://bugs.openjdk.org/browse/JDK-8294427 starts to use this API
> https://learn.microsoft.com/en-us/windows/win32/api/uxtheme/nf-uxtheme-openthemedatafordpi
>
> which was introduced only in Windows 10 1703.
> So the theming
On Thu, 21 Dec 2023 04:24:10 GMT, Renjith Kannath Pariyangad
wrote:
>> Hi Reviewers,
>>
>> Updated the test and it will generate required images on the fly so storing
>> and loading image from repo could be avoided. Please review and let me know
>> your suggestions.
>>
>> Regards,
>> Renjith
On Mon, 20 Nov 2023 12:54:25 GMT, Alexey Ivanov wrote:
> > > But I do have another suggestion that actually might have been the best
> > > thing to do all those years ago. Keep the over-ride as the default
> > > behaviour, and document it better. But if the
On Fri, 8 Dec 2023 03:23:22 GMT, Renjith Kannath Pariyangad
wrote:
> Hi Reviewers,
>
> Updated the test and it will generate required images on the fly so storing
> and loading image from repo could be avoided. Please review and let me know
> your suggestions.
>
> Regards,
> Renjith.
Change
On Mon, 18 Dec 2023 05:02:42 GMT, Tejesh R wrote:
> > > This is happening in linux
> > > Is it the Linux only? If yes why it cannot be reproduced on macOS and
> > > Windows?
>
> Yes, This is happening only in linux. The paintToOffScreen is done by
> BufferStrategyPaintManager rather than Repai
On Tue, 21 Nov 2023 08:40:40 GMT, songpv-imt wrote:
>> The root cause of the bug is because mousePress() method is invoked before
>> mouseMove() event is completely processed causing the drag & drop behavior
>> not being able to be recognized properly. This in turn makes the method
>> dragSour
On Mon, 11 Dec 2023 20:38:46 GMT, Sergey Bylokhov wrote:
> A previous call to
> [CoInitializeEx](https://learn.microsoft.com/en-us/windows/desktop/api/combaseapi/nf-combaseapi-coinitializeex)
> specified the concurrency model for this thread as multithread apartment
> (MTA). This could also in
t;>
>> @aivanov-jdk please take a look.
>
> Sergey Bylokhov has updated the pull request incrementally with one
> additional commit since the last revision:
>
> Update src/java.desktop/windows/native/libawt/windows/awt_Desktop.cpp
>
> date
>
> Co
On Mon, 12 Jun 2023 20:23:00 GMT, Alexey Ivanov wrote:
>>> > It may be useful to be able to run Java on previous versions though, yet
>>> > it's not a priority.
>>>
>>> Then probably it is better to add a fallback since that method was added to
t;>
>> @aivanov-jdk please take a look.
>
> Sergey Bylokhov has updated the pull request incrementally with one
> additional commit since the last revision:
>
> Update src/java.desktop/windows/native/libawt/windows/awt_Desktop.cpp
>
> date
>
>
On Thu, 7 Dec 2023 22:57:52 GMT, Sergey Bylokhov wrote:
>> The fix for a regression caused by the
>> https://bugs.openjdk.org/browse/JDK-6508941. it does not take into account
>> RPC_E_CHANGED_MODE when COM was already initialized using
>> COINIT_MULTITHREADED mode.
>>
>> @aivanov-jdk please
On Fri, 8 Dec 2023 15:36:40 GMT, Alexey Ivanov wrote:
>> Sergey Bylokhov has updated the pull request incrementally with three
>> additional commits since the last revision:
>>
>> - 8270269: Desktop.browse method fails if earlier CoInitialize call as
>> COI
On Thu, 7 Dec 2023 22:57:52 GMT, Sergey Bylokhov wrote:
>> The fix for a regression caused by the
>> https://bugs.openjdk.org/browse/JDK-6508941. it does not take into account
>> RPC_E_CHANGED_MODE when COM was already initialized using
>> COINIT_MULTITHREADED mode.
>>
>> @aivanov-jdk please
On Thu, 7 Dec 2023 22:53:25 GMT, Sergey Bylokhov wrote:
>> src/java.desktop/windows/native/libawt/windows/awt_Desktop.cpp line 99:
>>
>>> 97: ::CoUninitialize();
>>> 98: }
>>> 99: }
>>
>> I'm unsure this is the right thing to do. The documentation for
>> [`ShellExecute`
On Thu, 7 Dec 2023 22:57:52 GMT, Sergey Bylokhov wrote:
>> The fix for a regression caused by the
>> https://bugs.openjdk.org/browse/JDK-6508941. it does not take into account
>> RPC_E_CHANGED_MODE when COM was already initialized using
>> COINIT_MULTITHREADED mode.
>>
>> @aivanov-jdk please
On Thu, 7 Dec 2023 22:57:52 GMT, Sergey Bylokhov wrote:
>> The fix for a regression caused by the
>> https://bugs.openjdk.org/browse/JDK-6508941. it does not take into account
>> RPC_E_CHANGED_MODE when COM was already initialized using
>> COINIT_MULTITHREADED mode.
>>
>> @aivanov-jdk please
On Thu, 7 Dec 2023 03:03:59 GMT, Sergey Bylokhov wrote:
> The fix for a regression caused by the
> https://bugs.openjdk.org/browse/JDK-6508941. it does not take into account
> RPC_E_CHANGED_MODE when COM was already initialized using
> COINIT_MULTITHREADED mode.
>
> @aivanov-jdk please take a
On Wed, 6 Dec 2023 11:47:03 GMT, Prasanta Sadhukhan
wrote:
>> CSS.BackgroundImage.getImage uses double-checked locking but the loadedImage
>> field isn't declared as volatile. Without the volatile modifier,
>> double-checked locking implementation is broken.
>
> Prasanta Sadhukhan has updated
On Mon, 4 Dec 2023 23:26:12 GMT, Alexander Zvegintsev
wrote:
> The root of this issue is the incorrect calculation of window decoration
> insets.
>
> Previously we got non-zero window insets in the first PropertyNotify with
> [_NET_FRAME_EXTENTS](https://specifications.freedesktop.org/wm-spec
On Wed, 6 Dec 2023 13:18:53 GMT, Tejesh R wrote:
>>> Instead of passing the laf through all the methods, can't we create and use
>>> a class variable?
>>
>> Can be done but can't see any functional improvements. This seems ok to me.
>
> Yeah, those are to reduce redundancy in code, not function
1101 - 1200 of 2504 matches
Mail list logo
