On Tue, 19 Dec 2023 02:09:08 GMT, songpv-imt wrote:
>> The root cause of the bug is because mousePress() method is invoked before
>> mouseMove() event is completely processed causing the drag & drop behavior
>> not being able to be recognized properly. This in turn makes the method
>>
On Fri, 12 Jan 2024 22:18:04 GMT, Alisen Chung wrote:
>> SunToolkit.java is trying to post an event on the TrayIcon appContext, but
>> the TrayIcon was already removed by the test, causing an error. The fix is
>> to make SunToolkit skip posting the event if appContext is null. The test is
>>
On Fri, 12 Jan 2024 22:04:37 GMT, Alisen Chung wrote:
>> SunToolkit.java is trying to post an event on the TrayIcon appContext, but
>> the TrayIcon was already removed by the test, causing an error. The fix is
>> to make SunToolkit skip posting the event if appContext is null. The test is
>>
On Tue, 19 Dec 2023 02:09:08 GMT, songpv-imt wrote:
>> The root cause of the bug is because mousePress() method is invoked before
>> mouseMove() event is completely processed causing the drag & drop behavior
>> not being able to be recognized properly. This in turn makes the method
>>
On Tue, 19 Dec 2023 02:09:08 GMT, songpv-imt wrote:
>> The root cause of the bug is because mousePress() method is invoked before
>> mouseMove() event is completely processed causing the drag & drop behavior
>> not being able to be recognized properly. This in turn makes the method
>>
On Fri, 12 Jan 2024 23:46:06 GMT, Sergey Bylokhov wrote:
> for test execution it does not matter but when opened in ide it conflicts
> with some other Error classes from the tests.
I feel your pain!
I suggest refactoring those tests and make their private `Error` class a static
member of the
On Sun, 14 Jan 2024 09:31:29 GMT, Sergey Bylokhov wrote:
> > Currently, we have test and gold which use the same ColorSpace which could
> > be plain or wrapper for both cases. It looks confusing to me.
>
> That could be fine. We can create a gold image first, then parametrize the
> test
On Fri, 12 Jan 2024 23:48:49 GMT, Sergey Bylokhov wrote:
>> Since the time the bug was reported color conversion accuracy for the sRGB
>> profile and specific values from the report increased by x100. This is a
>> request to add the code from the report as a test case.
>
> Sergey Bylokhov has
On Fri, 12 Jan 2024 22:35:34 GMT, Sergey Bylokhov wrote:
>> Since the time the bug was reported color conversion accuracy for the sRGB
>> profile and specific values from the report increased by x100. This is a
>> request to add the code from the report as a test case.
>
> Sergey Bylokhov has
On Fri, 12 Jan 2024 21:51:07 GMT, Rajat Mahajan wrote:
>> ImageIcon.loadImage used to handle InterruptedException only by printing a
>> message to the console. JDK-8236987 handled the interrupted state more
>> gracefully, but it didn't restore the interrupted flag.
>> This change restores the
On Fri, 12 Jan 2024 20:51:38 GMT, Sergey Bylokhov wrote:
>> Since the time the bug was reported color conversion accuracy for the sRGB
>> profile and specific values from the report increased by x100. This is a
>> request to add the code from the report as a test case.
>
> Sergey Bylokhov has
On Wed, 10 Jan 2024 21:08:35 GMT, Alisen Chung wrote:
>> SunToolkit.java is trying to post an event on the TrayIcon appContext, but
>> the TrayIcon was already removed by the test, causing an error. The fix is
>> to make SunToolkit skip posting the event if appContext is null. The test is
>>
On Fri, 12 Jan 2024 09:53:46 GMT, Renjith Kannath Pariyangad
wrote:
>> Hi Reviewers,
>> There was a typo for color conversion instead of dstColorSpace function
>> srcColorSpace was used. Please review and let me know your suggestions if
>> any.
>>
>> Renjith.
>
> Renjith Kannath Pariyangad
On Fri, 12 Jan 2024 09:53:46 GMT, Renjith Kannath Pariyangad
wrote:
>> Hi Reviewers,
>> There was a typo for color conversion instead of dstColorSpace function
>> srcColorSpace was used. Please review and let me know your suggestions if
>> any.
>>
>> Renjith.
>
> Renjith Kannath Pariyangad
On Fri, 12 Jan 2024 19:17:24 GMT, Rajat Mahajan wrote:
> ImageIcon.loadImage used to handle InterruptedException only by printing a
> message to the console. JDK-8236987 handled the interrupted state more
> gracefully, but it didn't restore the interrupted flag.
> This change restores the
On Thu, 11 Jan 2024 20:04:56 GMT, Harshitha Onkar wrote:
> While investigating a macOS 14 issue noticed missing null checks in
> java/awt/Mouse/GetMousePositionTest/GetMousePositionWithPopup.java
>
> The missing null check will cause an NPE in finally block when frame2 is not
> created in the
On Fri, 12 Jan 2024 16:35:34 GMT, Rajat Mahajan wrote:
>> Remove commented out/ unused code from awt_List.cpp, which has been
>> commented out since 2007, when the code was moved to Mercurial.
>> The test ScrollPaneLimitation.java has been opened under
>>
On Thu, 11 Jan 2024 18:43:00 GMT, Rajat Mahajan wrote:
> Remove commented out/ unused code from awt_List.cpp, which has been commented
> out since 2007, when the code was moved to Mercurial.
> The test ScrollPaneLimitation.java has been opened under
>
On Thu, 4 Jan 2024 12:32:21 GMT, Alexey Ivanov wrote:
> > Thank you, Karl, for bringing the problem in this PR. It already exist in
> > JBS as [JDK-8320692](https://bugs.openjdk.org/browse/JDK-8320692): _Cannot
> > invoke java.awt.Image.getWidth(java.awt.image.ImageObserver
On Wed, 27 Dec 2023 04:20:42 GMT, Renjith Kannath Pariyangad
wrote:
> Hi Reviewers,
>
> I have updated the test case. Now test has pass/fail option also test will
> execute two time for covering different cases which are part of the test.
>
> Please review and let me know your suggestions.
>
On Tue, 9 Jan 2024 11:11:38 GMT, Renjith Kannath Pariyangad
wrote:
>> Hi Reviewers,
>> There was a typo for color conversion instead of dstColorSpace function
>> srcColorSpace was used. Please review and let me know your suggestions if
>> any.
>>
>> Renjith.
>
> Renjith Kannath Pariyangad
On Thu, 4 Jan 2024 14:40:59 GMT, Matthias Baesken wrote:
> > It should be extended to include the possible failure in the preceding call
> > to ::GetDIBits.
>
> I handle now also a failure of the first GetDIBits call; and also added
> braces at the if's mentioned.
Sorry for my delayed reply.
On Tue, 9 Jan 2024 11:11:38 GMT, Renjith Kannath Pariyangad
wrote:
>> Hi Reviewers,
>> There was a typo for color conversion instead of dstColorSpace function
>> srcColorSpace was used. Please review and let me know your suggestions if
>> any.
>>
>> Renjith.
>
> Renjith Kannath Pariyangad
On Mon, 8 Jan 2024 19:48:36 GMT, Rajat Mahajan wrote:
>> Since newInsets() function is a helper function used in ThemeReader.cpp only
>> , this change declares it as static.
>
> Rajat Mahajan has updated the pull request incrementally with one additional
> commit since the last revision:
>
>
On Mon, 8 Jan 2024 18:45:05 GMT, Rajat Mahajan wrote:
> 8322545: Declare newInsets as static in ThemeReader.cpp
Marked as reviewed by aivanov (Reviewer).
src/java.desktop/windows/native/libawt/windows/ThemeReader.cpp line 1:
> 1: /*
Update the copyright year to 2024.
-
PR
On Mon, 8 Jan 2024 13:48:10 GMT, Alexey Ivanov wrote:
> To avoid any confusion, I suggest renaming `compareImages` to
> `areImagesEqual` which leaves no ambiguity for its return value. I've updated
> the code in [commit
> `1788ef6`](https://github.com/aivanov-jd
On Thu, 30 Nov 2023 19:20:50 GMT, Sergey Bylokhov wrote:
>> Hi Reviewers,
>> There was a typo for color conversion instead of dstColorSpace function
>> srcColorSpace was used. Please review and let me know your suggestions if
>> any.
>>
>> Renjith.
>
> Can this patch be covered by the new
On Fri, 5 Jan 2024 13:18:46 GMT, Renjith Kannath Pariyangad
wrote:
>> There are at least two similar copy/paste typos.
>> In the next line
>> https://github.com/openjdk/jdk/blob/f73dbb985823d2d59bfcff8ba6951a0d9eb2cefc/src/java.desktop/share/classes/java/awt/image/ColorConvertOp.java#L771
>>
On Fri, 5 Jan 2024 12:03:43 GMT, Renjith Kannath Pariyangad
wrote:
>> Hi Reviewers,
>> There was a typo for color conversion instead of dstColorSpace function
>> srcColorSpace was used. Please review and let me know your suggestions if
>> any.
>>
>> Renjith.
>
> Renjith Kannath Pariyangad
On Fri, 5 Jan 2024 12:03:43 GMT, Renjith Kannath Pariyangad
wrote:
>> Hi Reviewers,
>> There was a typo for color conversion instead of dstColorSpace function
>> srcColorSpace was used. Please review and let me know your suggestions if
>> any.
>>
>> Renjith.
>
> Renjith Kannath Pariyangad
On Thu, 4 Jan 2024 18:04:59 GMT, Sergey Bylokhov wrote:
> > I thought about it… I thought that the filter itself should exercise the
> > code path that's modified but it doesn't seem like it does… I mean creating
> > images with regular ICC profile and using the wrapper TestColorSpace in
> >
On Thu, 4 Jan 2024 13:05:42 GMT, Renjith Kannath Pariyangad
wrote:
>> Hi Reviewers,
>> There was a typo for color conversion instead of dstColorSpace function
>> srcColorSpace was used. Please review and let me know your suggestions if
>> any.
>>
>> Renjith.
>
> Renjith Kannath Pariyangad
On Thu, 4 Jan 2024 11:53:19 GMT, Renjith Kannath Pariyangad
wrote:
>> Your `TestColorSpace` class is a wrapper on top of the actual color space.
>> So you can compare the results of conversion using `TestColorSpace` vs using
>> "actual color space" directly.
>
> Thank you for sharing the
On Thu, 4 Jan 2024 06:14:49 GMT, Sergey Bylokhov wrote:
>> @mrserb, Thank you for bringing this up. Sorry I am not pretty clear about
>> your suggestion on _Conversion via TestColorSpace wrapper vs ColorSpace w/o
>> wrapper._ . In existing code `compareImages` (pixel value compare) function
On Tue, 2 Jan 2024 17:58:19 GMT, Alexey Ivanov wrote:
> Thank you, Karl, for bringing the problem in this PR. It already exist in JBS
> as [JDK-8320692](https://bugs.openjdk.org/browse/JDK-8320692): _Cannot invoke
> java.awt.Image.getWidth(java.awt.image.ImageObserver)_.
>
On Wed, 3 Jan 2024 19:54:47 GMT, Alexey Ivanov wrote:
>> Updated this
>
> I agree with Sergey and I can't see any updates.
Hm… If modify the `toRGB` and `fromRGB` methods to use `csRGB` object, then the
test does not fail without the fix.
What's more interesting is that the imag
On Wed, 3 Jan 2024 03:42:35 GMT, Renjith Kannath Pariyangad
wrote:
>> test/jdk/java/awt/color/NonICCFilterTest.java line 53:
>>
>>> 51:
>>> 52: public float[] toRGB(float[] colorvalue) {
>>> 53: return colorvalue;
>>
>> Just for completeness, it is probably better to use
On Wed, 3 Jan 2024 03:45:06 GMT, Renjith Kannath Pariyangad
wrote:
>> Hi Reviewers,
>> There was a typo for color conversion instead of dstColorSpace function
>> srcColorSpace was used. Please review and let me know your suggestions if
>> any.
>>
>> Renjith.
>
> Renjith Kannath Pariyangad
On Wed, 3 Jan 2024 13:55:22 GMT, Matthias Baesken wrote:
>> In [JDK-8322772](https://bugs.openjdk.org/browse/JDK-8322772) one similar
>> cleanup has been proposed before (and was done in the change). But there are
>> a number of other places in the codebase where the import is done and still
On Wed, 3 Jan 2024 08:16:12 GMT, Matthias Baesken wrote:
> https://learn.microsoft.com/en-us/cpp/c-runtime-library/format-specification-syntax-printf-and-wprintf-functions?view=msvc-170
> The %S is for wide chars, do you think we need the other one (%s) ?
You're right, it should be wide-char.
On Thu, 28 Dec 2023 09:48:52 GMT, Matthias Baesken wrote:
> When running with fastdebug binaries we run intermittent into the issue below
> in
> jtreg test
> java/awt/image/MultiResolutionImage/MultiResolutionImageObserverTest.java .
> Seems we miss checking of successful HBITMAP creation
On Wed, 3 Jan 2024 00:38:19 GMT, Sergey Bylokhov wrote:
> I think we should fallback to something. The bug itself looks similar to
> this: https://bugs.openjdk.org/browse/JDK-8185862
[JDK-8185862](https://bugs.openjdk.org/browse/JDK-8185862) seems to be the
exact duplicate of this one.
It
On Tue, 21 Nov 2023 03:33:21 GMT, Prasanta Sadhukhan
wrote:
>> javadoc contract for JComponent.setMinimumSize(Dimension) states:
>>
>> "Sets the minimum size of this component to a constant value. Subsequent
>> calls to getMinimumSize will always return this value..."
>>
>> However,
On Tue, 2 Jan 2024 19:37:53 GMT, Alexey Ivanov wrote:
> It seems that we cannot continue if `hBMDC` or `hBM` are null. Yet it seems
> unexpected.
Should we rather modify the code to back out and not to call APIs with NULL
handles?
-
PR Review Comment: https://git.openjdk.o
On Thu, 28 Dec 2023 09:48:52 GMT, Matthias Baesken wrote:
> When running with fastdebug binaries we run intermittent into the issue below
> in
> jtreg test
> java/awt/image/MultiResolutionImage/MultiResolutionImageObserverTest.java .
> Seems we miss checking of successful HBITMAP creation
On Mon, 16 Jan 2023 14:19:52 GMT, Alexey Ivanov wrote:
> This is somewhat a continuation of #11104 where the issue was discussed and
> where I found [the root
> cause](https://github.com/openjdk/jdk/pull/11104#issuecomment-1382435784).
>
> **Root Cause**
>
> The icon ext
On Wed, 27 Dec 2023 03:47:16 GMT, Renjith Kannath Pariyangad
wrote:
>> Hi Reviewers,
>>
>> Updated the test and it will generate required images on the fly so storing
>> and loading image from repo could be avoided. Please review and let me know
>> your suggestions.
>>
>> Regards,
>>
On Thu, 21 Dec 2023 01:19:40 GMT, Rajat Mahajan wrote:
> **Issue:**
> https://bugs.openjdk.org/browse/JDK-8294427 starts to use this API
> https://learn.microsoft.com/en-us/windows/win32/api/uxtheme/nf-uxtheme-openthemedatafordpi
>
> which was introduced only in Windows 10 1703.
> So the
On Thu, 21 Dec 2023 04:24:10 GMT, Renjith Kannath Pariyangad
wrote:
>> Hi Reviewers,
>>
>> Updated the test and it will generate required images on the fly so storing
>> and loading image from repo could be avoided. Please review and let me know
>> your suggestions.
>>
>> Regards,
>>
On Mon, 20 Nov 2023 12:54:25 GMT, Alexey Ivanov wrote:
> > > But I do have another suggestion that actually might have been the best
> > > thing to do all those years ago. Keep the over-ride as the default
> > > behaviour, and document it better. But if t
On Fri, 8 Dec 2023 03:23:22 GMT, Renjith Kannath Pariyangad
wrote:
> Hi Reviewers,
>
> Updated the test and it will generate required images on the fly so storing
> and loading image from repo could be avoided. Please review and let me know
> your suggestions.
>
> Regards,
> Renjith.
On Mon, 18 Dec 2023 05:02:42 GMT, Tejesh R wrote:
> > > This is happening in linux
> > > Is it the Linux only? If yes why it cannot be reproduced on macOS and
> > > Windows?
>
> Yes, This is happening only in linux. The paintToOffScreen is done by
> BufferStrategyPaintManager rather than
On Tue, 21 Nov 2023 08:40:40 GMT, songpv-imt wrote:
>> The root cause of the bug is because mousePress() method is invoked before
>> mouseMove() event is completely processed causing the drag & drop behavior
>> not being able to be recognized properly. This in turn makes the method
>>
On Mon, 11 Dec 2023 20:38:46 GMT, Sergey Bylokhov wrote:
> A previous call to
> [CoInitializeEx](https://learn.microsoft.com/en-us/windows/desktop/api/combaseapi/nf-combaseapi-coinitializeex)
> specified the concurrency model for this thread as multithread apartment
> (MTA). This could also
t;>
>> @aivanov-jdk please take a look.
>
> Sergey Bylokhov has updated the pull request incrementally with one
> additional commit since the last revision:
>
> Update src/java.desktop/windows/native/libawt/windows/awt_Desktop.cpp
>
> date
>
> Co
On Mon, 12 Jun 2023 20:23:00 GMT, Alexey Ivanov wrote:
>>> > It may be useful to be able to run Java on previous versions though, yet
>>> > it's not a priority.
>>>
>>> Then probably it is better to add a fallback since that method was added to
>
t;>
>> @aivanov-jdk please take a look.
>
> Sergey Bylokhov has updated the pull request incrementally with one
> additional commit since the last revision:
>
> Update src/java.desktop/windows/native/libawt/windows/awt_Desktop.cpp
>
> date
>
>
On Thu, 7 Dec 2023 22:57:52 GMT, Sergey Bylokhov wrote:
>> The fix for a regression caused by the
>> https://bugs.openjdk.org/browse/JDK-6508941. it does not take into account
>> RPC_E_CHANGED_MODE when COM was already initialized using
>> COINIT_MULTITHREADED mode.
>>
>> @aivanov-jdk please
On Fri, 8 Dec 2023 15:36:40 GMT, Alexey Ivanov wrote:
>> Sergey Bylokhov has updated the pull request incrementally with three
>> additional commits since the last revision:
>>
>> - 8270269: Desktop.browse method fails if earlier CoInitialize call as
>> COI
On Thu, 7 Dec 2023 22:57:52 GMT, Sergey Bylokhov wrote:
>> The fix for a regression caused by the
>> https://bugs.openjdk.org/browse/JDK-6508941. it does not take into account
>> RPC_E_CHANGED_MODE when COM was already initialized using
>> COINIT_MULTITHREADED mode.
>>
>> @aivanov-jdk please
On Thu, 7 Dec 2023 22:53:25 GMT, Sergey Bylokhov wrote:
>> src/java.desktop/windows/native/libawt/windows/awt_Desktop.cpp line 99:
>>
>>> 97: ::CoUninitialize();
>>> 98: }
>>> 99: }
>>
>> I'm unsure this is the right thing to do. The documentation for
>>
On Thu, 7 Dec 2023 22:57:52 GMT, Sergey Bylokhov wrote:
>> The fix for a regression caused by the
>> https://bugs.openjdk.org/browse/JDK-6508941. it does not take into account
>> RPC_E_CHANGED_MODE when COM was already initialized using
>> COINIT_MULTITHREADED mode.
>>
>> @aivanov-jdk please
On Thu, 7 Dec 2023 03:03:59 GMT, Sergey Bylokhov wrote:
> The fix for a regression caused by the
> https://bugs.openjdk.org/browse/JDK-6508941. it does not take into account
> RPC_E_CHANGED_MODE when COM was already initialized using
> COINIT_MULTITHREADED mode.
>
> @aivanov-jdk please take
On Wed, 6 Dec 2023 11:47:03 GMT, Prasanta Sadhukhan
wrote:
>> CSS.BackgroundImage.getImage uses double-checked locking but the loadedImage
>> field isn't declared as volatile. Without the volatile modifier,
>> double-checked locking implementation is broken.
>
> Prasanta Sadhukhan has updated
On Mon, 4 Dec 2023 23:26:12 GMT, Alexander Zvegintsev
wrote:
> The root of this issue is the incorrect calculation of window decoration
> insets.
>
> Previously we got non-zero window insets in the first PropertyNotify with
>
On Wed, 6 Dec 2023 13:18:53 GMT, Tejesh R wrote:
>>> Instead of passing the laf through all the methods, can't we create and use
>>> a class variable?
>>
>> Can be done but can't see any functional improvements. This seems ok to me.
>
> Yeah, those are to reduce redundancy in code, not
On Tue, 5 Dec 2023 20:38:46 GMT, Phil Race wrote:
>> For as long as we've had the macOS port, it seems that queries on the
>> GraphicsConfiguration associated with
>> a printer would give you null for the defaultTransform.
>> Clearly this API isn't a popular one to call in such a context else
On Tue, 5 Dec 2023 20:32:49 GMT, Phil Race wrote:
>> With JDK 17, I still see the exception:
>>
>>
>> Exception in thread "main" java.awt.print.PrinterException
>> at java.desktop/sun.lwawt.macosx.CPrinterJob.print(CPrinterJob.java:393)
>> at PrinterDevice.main(PrinterDevice.java:68)
On Tue, 5 Dec 2023 20:13:50 GMT, Phil Race wrote:
>> For as long as we've had the macOS port, it seems that queries on the
>> GraphicsConfiguration associated with
>> a printer would give you null for the defaultTransform.
>> Clearly this API isn't a popular one to call in such a context else
On Tue, 5 Dec 2023 20:07:56 GMT, Phil Race wrote:
>> test/jdk/java/awt/print/PrinterJob/PrinterDevice.java line 71:
>>
>>> 69: if (failed) {
>>> 70: throw new RuntimeException("Test failed but no exception
>>> propagated.");
>>> 71: }
>>
>> A comment that
On Tue, 5 Dec 2023 19:35:50 GMT, Abhishek Kumar wrote:
>> The test fails for JFileChooser selection mode set to `DIRECTORIES_ONLY`.
>> For `DIRECTORIES_ONLY `mode, there may not be any directories in home
>> directory and due to that test failed. Added the code to create temporary
>>
On Mon, 4 Dec 2023 23:31:47 GMT, Phil Race wrote:
>> For as long as we've had the macOS port, it seems that queries on the
>> GraphicsConfiguration associated with
>> a printer would give you null for the defaultTransform.
>> Clearly this API isn't a popular one to call in such a context else
On Tue, 5 Dec 2023 19:21:52 GMT, Abhishek Kumar wrote:
>> The test fails for JFileChooser selection mode set to `DIRECTORIES_ONLY`.
>> For `DIRECTORIES_ONLY `mode, there may not be any directories in home
>> directory and due to that test failed. Added the code to create temporary
>>
On Tue, 5 Dec 2023 18:36:13 GMT, Abhishek Kumar wrote:
> > Is it intentional? It's the problem in
> > [JDK-6972078](https://bugs.openjdk.org/browse/JDK-6972078)… that
> > directories can't be selected.
>
> Not intentional though. Thought of creating a single folder with the mix of
> files
On Tue, 5 Dec 2023 18:34:52 GMT, Abhishek Kumar wrote:
>> The test fails for JFileChooser selection mode set to `DIRECTORIES_ONLY`.
>> For `DIRECTORIES_ONLY `mode, there may not be any directories in home
>> directory and due to that test failed. Added the code to create temporary
>>
On Mon, 20 Nov 2023 23:58:30 GMT, Phil Race wrote:
> Whilst reviewing the fix for https://bugs.openjdk.org/browse/JDK-7001133 I
> realised that although the proposed
> changes there may help, the problem would be inconsequential except that if
> anything causes an app to
> call
On Thu, 30 Nov 2023 03:34:08 GMT, Renjith Kannath Pariyangad
wrote:
> Hi Reviewers,
> There was a typo for color conversion instead of dstColorSpace function
> srcColorSpace was used. Please review and let me know your suggestions if
> any.
>
> Renjith.
The fix looks good to me.
I agree
On Tue, 5 Dec 2023 12:17:55 GMT, Abhishek Kumar wrote:
>> The test fails for JFileChooser selection mode set to `DIRECTORIES_ONLY`.
>> For `DIRECTORIES_ONLY `mode, there may not be any directories in home
>> directory and due to that test failed. Added the code to create temporary
>>
On Tue, 5 Dec 2023 08:30:44 GMT, Sergey Bylokhov wrote:
> The Java_java_awt_MenuComponent_initIDs function is empty on Windows and
> macOS, on linux it has some code but it is unused.
>
> This issue is similar to https://bugs.openjdk.org/browse/JDK-8318091
Marked as reviewed by aivanov
On Fri, 17 Nov 2023 20:21:32 GMT, Alexey Ivanov wrote:
> Update `FileChooserSymLinkTest.java` to simplify its implementation by
> replacing `List` with `JFrame` of its `createTestUI` which now uses
> `PassFailJFrame.Builder testUI(PassFailJFrame.WindowCreator)
wListCreator)`.
>
> The test works correctly with and without the update.
>
> This PR depends on #16717.
Alexey Ivanov has updated the pull request with a new target base due to a
merge or a rebase. The incremental webrev excludes the unrelated changes
brought in by the merge/rebase. The pul
wListCreator)`.
>
> The test works correctly with and without the update.
>
> This PR depends on #16717.
Alexey Ivanov has updated the pull request with a new target base due to a
merge or a rebase. The incremental webrev excludes the unrelated changes
brought in by the merge/rebase.
---
On Fri, 17 Nov 2023 20:01:55 GMT, Alexey Ivanov wrote:
> Enhance `PassFailJFrame` for single-window test UI which is the most common
> case so that there's no need to return `List.of`.
>
> With this change, the lambda or method reference passed to `Builder.testUI`
> will return
On Tue, 5 Dec 2023 14:24:09 GMT, Prasanta Sadhukhan
wrote:
> But it can be a bug in the code that it never gave a chance second time..I
> think it should get a chance to reload the URL again in case it is invalid
> the 1st time so I guess the change should be the one where if url is invalid,
On Tue, 5 Dec 2023 07:59:19 GMT, Prasanta Sadhukhan
wrote:
>> CSS.BackgroundImage.getImage uses double-checked locking but the loadedImage
>> field isn't declared as volatile. Without the volatile modifier,
>> double-checked locking implementation is broken.
>
> Prasanta Sadhukhan has updated
On Tue, 5 Dec 2023 12:17:55 GMT, Abhishek Kumar wrote:
>> The test fails for JFileChooser selection mode set to `DIRECTORIES_ONLY`.
>> For `DIRECTORIES_ONLY `mode, there may not be any directories in home
>> directory and due to that test failed. Added the code to create temporary
>>
On Tue, 5 Dec 2023 07:55:22 GMT, Prasanta Sadhukhan
wrote:
> > > > It is probably easy just drop the usage of loadedImage and use the
> > > > image instead?
> > >
> > >
> > > Ideally. Yet there's a corner case: if `url` is null, there's nothing to
> > > load; and it doesn't make sense to
On Mon, 4 Dec 2023 20:42:48 GMT, Sergey Bylokhov wrote:
> It is probably easy just drop the usage of loadedImage and use the image
> instead?
Ideally. Yet there's a corner case: if `url` is null, there's nothing to load;
and it doesn't make sense to re-try, the URL won't change. If it were
On Wed, 22 Nov 2023 05:42:24 GMT, Abhishek Kumar wrote:
>> The test fails for JFileChooser selection mode set to `DIRECTORIES_ONLY`.
>> For `DIRECTORIES_ONLY `mode, there may not be any directories in home
>> directory and due to that test failed. Added the code to create temporary
>>
On Mon, 4 Dec 2023 20:52:28 GMT, Alexey Ivanov wrote:
>> Abhishek Kumar has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Test update
>
> test/jdk/com/sun/java/swing/plaf/gtk/TestFileChooserSingleDirec
On Thu, 23 Nov 2023 11:53:00 GMT, Abhishek Kumar wrote:
>>> But the files gets deselected after selection which returns as no file
>>> selected and test failed.
>>
>> How is it? It sounds like magic… The working directory shouldn't matter; if
>> it does, the test isn't as stable as it should
On Mon, 4 Dec 2023 06:30:01 GMT, Prasanta Sadhukhan
wrote:
> > That code does not look like double-checked lock, it is something
> > different. It checks/init/sets one field and then returns another one. Even
> > if both will be marked as volatile the method may return null, since the
> >
On Fri, 1 Dec 2023 06:31:00 GMT, Prasanta Sadhukhan
wrote:
> CSS.BackgroundImage.getImage uses double-checked locking but the loadedImage
> field isn't declared as volatile. Without the volatile modifier,
> double-checked locking implementation is broken.
Based on my recent comment, the code
On Sat, 2 Dec 2023 20:55:30 GMT, Andrey Turbanov wrote:
>> Tejesh R has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Review fix
>
> src/java.desktop/share/classes/javax/swing/JTable.java line 3016:
>
>> 3014: // adjust the x
On Fri, 1 Dec 2023 06:31:00 GMT, Prasanta Sadhukhan
wrote:
> CSS.BackgroundImage.getImage uses double-checked locking but the loadedImage
> field isn't declared as volatile. Without the volatile modifier,
> double-checked locking implementation is broken.
Marked as reviewed by aivanov
On Fri, 1 Dec 2023 09:26:41 GMT, Tejesh R wrote:
>> Table contents does not follow right-left Orientation when Max width of
>> columns are set. This is due to not considering the offset in `x position`
>> while painting table grid and table cell. The fix handles the offset and
>> adjust the x
On Thu, 30 Nov 2023 18:23:28 GMT, Phil Race wrote:
>> Many printing tests do not have the @printer keyword. This adds them to
>> those that need it.
>> I also found one test that has nothing to do with printing in the print
>> folder and moved it out.
>
> Phil Race has updated the pull request
On Thu, 30 Nov 2023 18:14:21 GMT, Phil Race wrote:
>> That's the reason why I prefer you keep the `@run` tag in `SetOrient.java`:
>> to document that it's *an applet test* — with the html file being the test
>> starter.
>
> Ok, although when I see something like that it looks more like a bug
On Thu, 30 Nov 2023 17:20:40 GMT, Tejesh R wrote:
>> Table contents does not follow right-left Orientation when Max width of
>> columns are set. This is due to not considering the offset in `x position`
>> while painting table grid and table cell. The fix handles the offset and
>> adjust the
On Thu, 30 Nov 2023 17:44:11 GMT, Alexey Ivanov wrote:
>> I actually reused it from `JTableHeader` class and yeah it will be
>> `parent.getWidth ` always as of now, but I thought it might be for future
>> purpose, but not sure... Should we retain or just use `parent.getW
601 - 700 of 1956 matches
Mail list logo
