On Wed, 3 Jul 2024 19:39:10 GMT, Damon Nguyen wrote:
>> Currently the bug described in the issue is that the colors of the
>> TextComponents do not change when setting TextComponents to uneditable. The
>> default uneditable color (SystemColor.control) happens to be the same as the
>> default
On Wed, 3 Jul 2024 05:20:02 GMT, Harshitha Onkar wrote:
>> Currently the bug described in the issue is that the colors of the
>> TextComponents do not change when setting TextComponents to uneditable. The
>> default uneditable color (SystemColor.control) happens to be the same as the
>>
On Thu, 27 Jun 2024 09:04:33 GMT, Ravi Gupta wrote:
>> This testcase checks for the following assertions for Component events:
>>
>> 1. When components are resized, moved, hidden and shown the respective
>> events are triggered.
>> 2. When the components are hidden/disabled also,the component
Currently the bug described in the issue is that the colors of the
TextComponents do not change when set ySystemColor.control color when the
TextComponents are set to uneditable. You can check by changing
TextComponent.getBackground() code to return Color.GRAY on line 342 and you can
see that
On Mon, 24 Jun 2024 20:16:30 GMT, Alexey Ivanov wrote:
> This is somewhat a continuation for
> [JDK-8307160](https://bugs.openjdk.org/browse/JDK-8307160) and
> [JDK-8334509](https://bugs.openjdk.org/browse/JDK-8334509).
>
> The former removed the `doIt` flag in #18584, but it introduced a
On Wed, 26 Jun 2024 23:37:48 GMT, Alisen Chung wrote:
>> This is somewhat a continuation for
>> [JDK-8307160](https://bugs.openjdk.org/browse/JDK-8307160) and
>> [JDK-8334509](https://bugs.openjdk.org/browse/JDK-8334509).
>>
>> The former removed the `doIt` fla
On Mon, 24 Jun 2024 20:16:30 GMT, Alexey Ivanov wrote:
> This is somewhat a continuation for
> [JDK-8307160](https://bugs.openjdk.org/browse/JDK-8307160) and
> [JDK-8334509](https://bugs.openjdk.org/browse/JDK-8334509).
>
> The former removed the `doIt` flag in #18584, but it introduced a
On Mon, 24 Jun 2024 22:25:22 GMT, Phil Race wrote:
>> Migrate font code from jdk.internal.misc.Unsafe to using FFM.
>> This reduces the coupling between the java.desktop module and the internals
>> of the java.base module.
>>
>> The code being changed here is not particularly performance
On Fri, 21 Jun 2024 14:46:33 GMT, Renjith Kannath Pariyangad
wrote:
> Yes, there is some disconnect. For all OS (MAC with above changes) print
> range is working properly only with following values firstPage =0 and
> lastPage =-1 at **RasterPrinterJob.java** and highly depend on
>
On Thu, 6 Jun 2024 23:28:07 GMT, Alisen Chung wrote:
> Add a check for previous focused window on modal unblocking. If the owner of
> a closing dialog was the last focused window, then the owner of the dialog
> should regain focus.
This pull request has now been integrated.
On Tue, 18 Jun 2024 20:31:58 GMT, Phil Race wrote:
> Migrate font code from jdk.internal.misc.Unsafe to using FFM.
> This reduces the coupling between the java.desktop module and the internals
> of the java.base module.
>
> The code being changed here is not particularly performance sensitive,
On Mon, 17 Jun 2024 05:54:37 GMT, Renjith Kannath Pariyangad
wrote:
> Hi Reviewers,
>
> This fix will resolve page range not printing proper pages if the rage begin
> from 2 or above on Mac machines.
> I have verified the manual range related tests like PageRanges.java,
> ClippedImages.java
On Mon, 17 Jun 2024 07:29:45 GMT, Tejesh R wrote:
>> DetailsView removes JTable TAB, SHIFT-TAB, ENTER and SHIFT-ENTER
>> functionalities to disable navigation within JTable of FilePane in
>> DetailsView. This is causing the issue mentioned in the bug where on
>> invoking DetailsView the
On Mon, 10 Jun 2024 21:09:35 GMT, Alisen Chung wrote:
> Removing if check for unsupported jawt versions
This pull request has now been integrated.
Changeset: 2ce85d96
Author: Alisen Chung
URL:
https://git.openjdk.org/jdk/commit/2ce85d96352cef4910cb6a5c2d9b174ca9d8a4e4
Stats:
On Fri, 14 Jun 2024 09:28:28 GMT, Prasanta Sadhukhan
wrote:
>> Issue is seen in that if we call setEnabled(false) over JSplitPane than it
>> can't be dragged via its divider, But if SplitPane have one touch expandable
>> true than user can click those buttons and change the divider position.
On Fri, 14 Jun 2024 20:22:42 GMT, Phil Race wrote:
>> Abhishek Kumar has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> condition update
>
> src/java.desktop/share/classes/javax/swing/plaf/synth/SynthGraphicsUtils.java
> line 785:
>
>>
On Fri, 14 Jun 2024 09:28:28 GMT, Prasanta Sadhukhan
wrote:
>> Issue is seen in that if we call setEnabled(false) over JSplitPane than it
>> can't be dragged via its divider, But if SplitPane have one touch expandable
>> true than user can click those buttons and change the divider position.
On Fri, 14 Jun 2024 16:00:10 GMT, Tejesh R wrote:
> DetailsView removes JTable TAB, SHIFT-TAB, ENTER and SHIFT-ENTER
> functionalities to disable navigation within JTable of FilePane in
> DetailsView. This is causing the issue mentioned in the bug where on invoking
> DetailsView the
Add a check and storage for a custom DefaultMenuBar in Desktop.java and adds
key event handling for a custom DefaultMenuBar in KeyboardManager.java.
Also adds a manual test for checking that key event handling is correct for
DefaultMenuBars.
-
Commit messages:
- add test, fix
On Thu, 13 Jun 2024 05:48:22 GMT, Damon Nguyen wrote:
>> Alisen Chung has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> use == over .equals
>
> src/java.desktop/macosx/classes/sun/lwawt/macosx/CPlatformWindow
On Wed, 5 Jun 2024 23:33:21 GMT, Alisen Chung wrote:
> Issue is a mouse drag will trigger a popup in macos, but not in linux or
> windows.
> The solution is to add a check for a mouse pressed event to show popup and
> prevent mouse entered events from triggering the popup
This
On Tue, 11 Jun 2024 02:37:44 GMT, Sergey Bylokhov wrote:
> Is it possible to cover this fix by the test?
How would I go about writing a test?
-
PR Comment: https://git.openjdk.org/jdk/pull/19639#issuecomment-2163687022
On Mon, 10 Jun 2024 20:46:46 GMT, Naoto Sato wrote:
>> Damon Nguyen has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Revert updated translation
>
> Did not look at each for translation accuracy (did some for Japanese), but
> looks good
On Tue, 11 Jun 2024 19:28:27 GMT, Damon Nguyen wrote:
>> This issue is responsible for updating the translations of all the
>> localize(able) resources in the JDK. Primarily, the changes between JDK 22
>> RDP 1 and the integration of the JDK 23 RDP 1 L10n drop will be translated.
>>
>> The
On Mon, 10 Jun 2024 20:37:41 GMT, Damon Nguyen wrote:
>> src/java.desktop/share/classes/sun/print/resources/serviceui_zh_CN.properties
>> line 32:
>>
>>> 30: border.jobattributes=作业属性
>>> 31: border.media=介质
>>> 32: border.output=出纸
>>
>> What triggered this ? Just someone noticing it and
> Issue is a mouse drag will trigger a popup in macos, but not in linux or
> windows.
> The solution is to add a check for a mouse pressed event to show popup and
> prevent mouse entered events from triggering the popup
Alisen Chung has updated the pull request incrementally with on
On Tue, 11 Jun 2024 11:24:13 GMT, Tejesh R wrote:
> What happens when we introduce another component in-between, say for example
> in the test we add one more Frame in-between printDailogButton and mainFrame.
> Which frame does get activated on close of print dialog? The intermediate one
> or
Removing if check for unsupported jawt versions
-
Commit messages:
- update copyright year
- remove if check for awt version >= 1.4
Changes: https://git.openjdk.org/jdk/pull/19639/files
Webrev: https://webrevs.openjdk.org/?repo=jdk=19639=00
Issue:
On Tue, 4 Jun 2024 12:07:40 GMT, Renjith Kannath Pariyangad
wrote:
> Hi Reviewers,
> I have updated the test case with passing float value for evaluation and a
> typo. Please review and let me know your suggestions if any.
small typo and typing change, LGTM
-
Marked as reviewed
On Tue, 4 Jun 2024 12:07:40 GMT, Renjith Kannath Pariyangad
wrote:
> Hi Reviewers,
> I have updated the test case with passing float value for evaluation and a
> typo. Please review and let me know your suggestions if any.
Maybe outside the scope of this issue, but could this test be
On Wed, 5 Jun 2024 08:29:11 GMT, Ravi Gupta wrote:
>> This testcase checks for the following assertions for Component events:
>>
>> 1. When components are resized, moved, hidden and shown the respective
>> events are triggered.
>> 2. When the components are hidden/disabled also,the component
On Fri, 7 Jun 2024 22:46:44 GMT, Damon Nguyen wrote:
> This issue is responsible for updating the translations of all the
> localize(able) resources in the JDK. Primarily, the changes between JDK 22
> RDP 1 and the integration of the JDK 23 RDP 1 L10n drop will be translated.
>
> The
> Issue is a mouse drag will trigger a popup in macos, but not in linux or
> windows.
> The solution is to add a check for a mouse pressed event to show popup and
> prevent mouse entered events from triggering the popup
Alisen Chung has updated the pull request incrementally with on
On Fri, 7 Jun 2024 23:14:47 GMT, Damon Nguyen wrote:
>> Alisen Chung has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> update test based on feedback
>
> test/jdk/javax/swing/JPopupMenu/MouseDragPo
On Fri, 7 Jun 2024 07:35:19 GMT, Prasanta Sadhukhan
wrote:
>> Alisen Chung has updated the pull request incrementally with three
>> additional commits since the last revision:
>>
>> - update copyright years
>> - automated test
>> - changed test t
> Issue is a mouse drag will trigger a popup in macos, but not in linux or
> windows.
> The solution is to add a check for a mouse pressed event to show popup and
> prevent mouse entered events from triggering the popup
Alisen Chung has updated the pull request incrementally with on
On Fri, 7 Jun 2024 21:03:58 GMT, Alisen Chung wrote:
>> Although there's one more issue it seems where in native, after popup is
>> shown when right mouse button (or CTRL+left mouse button) is pressed, if you
>> release the mouse the popup vanishes which I noti
On Fri, 7 Jun 2024 07:40:01 GMT, Prasanta Sadhukhan
wrote:
>> looks good..
>
> Although there's one more issue it seems where in native, after popup is
> shown when right mouse button (or CTRL+left mouse button) is pressed, if you
> release the mouse the popup vanishes which I noticed in
> Add a check for previous focused window on modal unblocking. If the owner of
> a closing dialog was the last focused window, then the owner of the dialog
> should regain focus.
Alisen Chung has updated the pull request incrementally with one additional
commit since the last revisio
Add a check for previous focused window on modal unblocking. If the owner of a
closing dialog was the last focused window, then the owner of the dialog should
regain focus.
-
Commit messages:
- update copyright years
- init commit
Changes:
On Sun, 5 May 2024 10:17:40 GMT, 柳鲲鹏 wrote:
>> Candidat box can moving with caret on windows version. Someone must wrote
>> codes for linux(ubuntu), but it doesn't work, so he didn't commit the codes.
>> Why it doesn't work, is the key problem.
>>
>> 1, I wrote a example for linux:
>>
On Thu, 6 Jun 2024 18:18:14 GMT, Damon Nguyen wrote:
>> Alisen Chung has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> add event check in popup trigger
>
> src/java.desktop/macosx/classes/sun/lwawt/macosx/NS
> Issue is a mouse drag will trigger a popup in macos, but not in linux or
> windows.
> The solution is to add a check for a mouse pressed event to show popup and
> prevent mouse entered events from triggering the popup
Alisen Chung has updated the pull request incrementall
On Thu, 6 Jun 2024 16:08:31 GMT, Alisen Chung wrote:
>> Issue is a mouse drag will trigger a popup in macos, but not in linux or
>> windows.
>> The solution is to add a check for a mouse pressed event to show popup and
>> prevent mouse entered events from triggering th
On Thu, 6 Jun 2024 07:16:42 GMT, Prasanta Sadhukhan
wrote:
>> Alisen Chung has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request conta
> Issue is a mouse drag will trigger a popup in macos, but not in linux or
> windows.
> The solution is to add a check for a mouse pressed event to show popup and
> prevent mouse entered events from triggering the popup
Alisen Chung has updated the pull request incrementally with on
On Thu, 6 Jun 2024 09:17:13 GMT, Abhishek Kumar wrote:
>> "java.awt.IllegalComponentStateException: component must be showing on the
>> screen to determine its location" is thrown when getLocationOnScreen method
>> is invoked for JTableHeader while testing JFileChooser demo. It seems that
>>
On Thu, 6 Jun 2024 07:16:42 GMT, Prasanta Sadhukhan
wrote:
> I guess it needs to be understood why it is not failing in windows and linux
> and only reproducible in macos. The fix in BasicLookAndFeel is not
> appropriate in my opinion as that shared code will be exercised in windows
> and
> Issue is a mouse drag will trigger a popup in macos, but not in linux or
> windows.
> The solution is to add a check for a mouse pressed event to show popup and
> prevent mouse entered events from triggering the popup
Alisen Chung has updated the pull request incrementally with tw
> Issue is a mouse drag will trigger a popup in macos, but not in linux or
> windows.
> The solution is to add a check for a mouse pressed event to show popup and
> prevent mouse entered events from triggering the popup
Alisen Chung has updated the pull request with a new tar
Issue is a mouse drag will trigger a popup in macos, but not in linux or
windows.
The solution is to add a check for a mouse pressed event to show popup and
prevent mouse entered events from triggering the popup
-
Commit messages:
- fix trailing whitespace in instructions string
On Fri, 31 May 2024 08:49:17 GMT, Abhishek Kumar wrote:
>> In GTK LAF, the menu mnemonics are always displayed which is different from
>> the native behavior. In native application **(tested with gedit**), the menu
>> mnemonics toggle on press of `ALT` key. Menu mnemonics are hidden initially
On Wed, 5 Jun 2024 16:14:11 GMT, Abhishek Kumar wrote:
>> "java.awt.IllegalComponentStateException: component must be showing on the
>> screen to determine its location" is thrown when getLocationOnScreen method
>> is invoked for JTableHeader while testing JFileChooser demo. It seems that
>>
On Fri, 10 May 2024 05:48:35 GMT, Abhishek Kumar wrote:
>> src/java.desktop/share/classes/javax/swing/plaf/synth/SynthLookAndFeel.java
>> line 1085:
>>
>>> 1083: if (UIManager.getBoolean("Button.showMnemonics")) {
>>> 1084: // Do not hide mnemonics if the UI defaults do not
On Fri, 24 May 2024 06:29:23 GMT, Abhishek Kumar wrote:
>> In GTK LAF, the menu mnemonics are always displayed which is different from
>> the native behavior. In native application **(tested with gedit**), the menu
>> mnemonics toggle on press of `ALT` key. Menu mnemonics are hidden initially
On Fri, 24 May 2024 06:29:23 GMT, Abhishek Kumar wrote:
>> In GTK LAF, the menu mnemonics are always displayed which is different from
>> the native behavior. In native application **(tested with gedit**), the menu
>> mnemonics toggle on press of `ALT` key. Menu mnemonics are hidden initially
On Thu, 30 May 2024 07:33:31 GMT, Abhishek Kumar wrote:
>> bug6492108.java test always fails in GTK L in single as well as dual
>> screen linux machines. Since this test was not marked as "_headful_" in it's
>> initial version, it never failed but after the fix of
>>
On Wed, 22 May 2024 19:18:18 GMT, Alexander Scherbatiy
wrote:
>> The fix adds new public `OutputBin` print attribute class which allow to set
>> a printer output bin in a `PrinterJob` class. The corresponding internal
>> `CustomOutputBin` class is added as well.
>>
>> - Constants used in
On Sat, 11 May 2024 17:32:37 GMT, Alexander Scherbatiy
wrote:
>> The fix adds new public `OutputBin` print attribute class which allow to set
>> a printer output bin in a `PrinterJob` class. The corresponding internal
>> `CustomOutputBin` class is added as well.
>>
>> - Constants used in
On Sat, 11 May 2024 12:44:47 GMT, Alexander Scherbatiy
wrote:
>> I will look how to translate the `Output` and `Output Trays` into languages
>> used in the serviceui properties.
>
> The translation for the `border.output` and `label.outputbins` properties are
> added to the fix.
These
On Sat, 11 May 2024 17:32:37 GMT, Alexander Scherbatiy
wrote:
>> The fix adds new public `OutputBin` print attribute class which allow to set
>> a printer output bin in a `PrinterJob` class. The corresponding internal
>> `CustomOutputBin` class is added as well.
>>
>> - Constants used in
On Tue, 7 May 2024 18:03:23 GMT, Alisen Chung wrote:
> Opening closed dnd test
> Test is green on all platforms
This pull request has now been integrated.
Changeset: 6f7ddbec
Author:Alisen Chung
URL:
https://git.openjdk.org/jdk/commit/6f7ddbec7d0bc459d44b6518fe1d982eaba7f37b
On Tue, 14 May 2024 23:57:20 GMT, Damon Nguyen wrote:
>> JTabbedPane's contentOpaque and tabsOpaque properties are not honored in
>> Aqua L JTabbedPane's content area and tab background color are not as
>> expected when tabbedpane opacity is set to true or false. Fix is to handle
>> the
On Fri, 10 May 2024 07:05:11 GMT, Abhishek Kumar wrote:
> JTabbedPane's contentOpaque and tabsOpaque properties are not honored in Aqua
> L JTabbedPane's content area and tab background color are not as expected
> when tabbedpane opacity is set to true or false. Fix is to handle the opacity
>
On Thu, 9 May 2024 19:56:40 GMT, Phil Race wrote:
> You are opening the test, but the bug ID is about the test failing. Why
> specifically did the test fail before and what about this version fixes that ?
The test needed some delays between mouse moves for stability. I accidentally
deleted a
> Opening closed dnd test
> Test is green on all platforms
Alisen Chung has updated the pull request incrementally with two additional
commits since the last revision:
- extra newline after jtreg tags
- re-added delay
-
Changes:
- all: https://git.openjdk.org/jdk/pull
On Wed, 8 May 2024 05:53:38 GMT, Abhishek Kumar wrote:
>> In GTK LAF, the menu mnemonics are always displayed which is different from
>> the native behavior. In native application **(tested with gedit**), the menu
>> mnemonics toggle on press of `ALT` key. Menu mnemonics are hidden initially
On Wed, 8 May 2024 19:17:05 GMT, Damon Nguyen wrote:
>> Alisen Chung has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> button1_down_mask, dispose on edt, replace system err with out, frame
>> srcpoint and di
> Opening closed dnd test
> Test is green on all platforms
Alisen Chung has updated the pull request incrementally with one additional
commit since the last revision:
button1_down_mask, dispose on edt, replace system err with out, frame
srcpoint and dimension access
Opening closed dnd test
Test is green on all platforms
-
Commit messages:
- init commit
Changes: https://git.openjdk.org/jdk/pull/19128/files
Webrev: https://webrevs.openjdk.org/?repo=jdk=19128=00
Issue: https://bugs.openjdk.org/browse/JDK-8331870
Stats: 204 lines in 1 file
On Fri, 26 Apr 2024 21:37:56 GMT, Alisen Chung wrote:
> Updating giflib, clientlibs tests are green on all platforms
This pull request has now been integrated.
Changeset: 6969a9e0
Author: Alisen Chung
URL:
https://git.openjdk.org/jdk/commit/6969a9e0b2143eee5a7cfa02460a8ab6dfa08
On Wed, 1 May 2024 16:40:21 GMT, Phil Race wrote:
> So it sounds like the JDK mods are no longer needed, at least for current
> mainline compilers, and I assume you verified that all those formatting
> changes are from upstream, not your IDE ?
>
> If yes, approved, but it needs a 2nd reviewer
On Tue, 30 Apr 2024 21:33:41 GMT, Alexander Zvegintsev
wrote:
>> does this also apply for the other JDK modification for old compilers as
>> well?
>
> Regarding the `JDK modifications to support building using old compilers`
> from `gif_lib.h`:
>
> I found my old [review
>
On Mon, 29 Apr 2024 21:05:34 GMT, Alexander Zvegintsev
wrote:
>> src/java.desktop/share/native/libsplashscreen/giflib/gif_hash.h line 40:
>>
>>> 38: #include
>>> 39: #endif
>>> 40: /** End JDK modifications to support building on Windows **/
>>
>> Do we still need this ?
>
> The GIFLIB
On Tue, 30 Apr 2024 07:58:25 GMT, Tejesh R wrote:
> here
There are no changes to the COPYING file in the newest version of giblib so
there weren't any changes here either
-
PR Comment: https://git.openjdk.org/jdk/pull/18985#issuecomment-2086543204
Updating giflib, clientlibs tests are green on all platforms
-
Commit messages:
- update md
- revert tab spacing to spaces
- init commit
Changes: https://git.openjdk.org/jdk/pull/18985/files
Webrev: https://webrevs.openjdk.org/?repo=jdk=18985=00
Issue:
On Thu, 25 Apr 2024 16:26:49 GMT, Alisen Chung wrote:
> Updating giflib, clientlibs tests are green on all platforms
This pull request has been closed without being integrated.
-
PR: https://git.openjdk.org/jdk/pull/18956
On Fri, 26 Apr 2024 19:30:25 GMT, Phil Race wrote:
> Why don't I see an updated giflib.md ?
The md file is still in the process of being approved by legal
-
PR Comment: https://git.openjdk.org/jdk/pull/18956#issuecomment-2080072668
Updating giflib, clientlibs tests are green on all platforms
-
Commit messages:
- revert tab spacing to spaces
- init commit
Changes: https://git.openjdk.org/jdk/pull/18956/files
Webrev: https://webrevs.openjdk.org/?repo=jdk=18956=00
Issue:
On Fri, 19 Apr 2024 07:12:36 GMT, Tejesh R wrote:
> Instructions set has been updated as per OS specific. JTable keyboard
> navigation is tested in each OS and according it's current implementation the
> instructions has been updated (Few has been removed and few has been
> updated).
>
On Wed, 20 Mar 2024 22:48:46 GMT, Alisen Chung wrote:
> Removing applet usage from manual JFileChooser tests
This pull request has now been integrated.
Changeset: 021ed6ae
Author: Alisen Chung
URL:
https://git.openjdk.org/jdk/commit/021ed6aea92f770ebeae65175d94797f7c418c82
St
> Removing applet usage from manual JFileChooser tests
Alisen Chung has updated the pull request incrementally with one additional
commit since the last revision:
equals modifier
-
Changes:
- all: https://git.openjdk.org/jdk/pull/18415/files
- new: https://git.openjdk.
On Tue, 19 Mar 2024 01:47:01 GMT, Alisen Chung wrote:
> Removing applet usage from manual JColorChooser tests
This pull request has now been integrated.
Changeset: 1e76e1fd
Author: Alisen Chung
URL:
https://git.openjdk.org/jdk/commit/1e76e1fdfa67c28ce20b0dc7fb0253670be54554
St
On Fri, 29 Mar 2024 16:43:53 GMT, Abhishek Kumar wrote:
> Looks good now. Only point is "should we move this test outside folder as
> html file is deleted now?". Hope you have tested in CI for all platform.
Clientlibs is green, also I'll keep this inside the folder for bookkeeping
> Removing applet usage from manual JFileChooser tests
Alisen Chung has updated the pull request incrementally with one additional
commit since the last revision:
move var into local, simplified condition check, spacing
-
Changes:
- all: https://git.openjdk.org/jdk/pull/18
> Removing applet usage from manual JFileChooser tests
Alisen Chung has updated the pull request incrementally with one additional
commit since the last revision:
added headful tag, remove pass boolean var and directly evaluate pass
condition
-
Changes:
- all: ht
> Removing applet usage from manual JFileChooser tests
Alisen Chung has updated the pull request with a new target base due to a merge
or a rebase. The incremental webrev excludes the unrelated changes brought in
by the merge/rebase. The pull request contains seven additional commits si
> Removing applet usage from manual JColorChooser tests
Alisen Chung has updated the pull request incrementally with one additional
commit since the last revision:
update test from feedback
-
Changes:
- all: https://git.openjdk.org/jdk/pull/18369/files
- new: ht
On Tue, 26 Mar 2024 21:16:39 GMT, Phil Race wrote:
> are you going to reduce the timeout as Alexander suggested ?
I've lowered the timeout to 2 minutes
-
PR Comment: https://git.openjdk.org/jdk/pull/18369#issuecomment-2024149068
> Removing applet usage from manual JFileChooser tests
Alisen Chung has updated the pull request incrementally with one additional
commit since the last revision:
removed second pass check
-
Changes:
- all: https://git.openjdk.org/jdk/pull/18415/files
- new: ht
On Fri, 22 Mar 2024 15:40:39 GMT, Alisen Chung wrote:
> Removing applet usage from manual JFileChooser tests
> The original test is failing (nothing shows up in the JFileChooser), but this
> change does replace the applet usage with PassFailJFrame
This pull request has now been i
On Thu, 14 Mar 2024 23:02:58 GMT, Alisen Chung wrote:
> Removing applet usage from manual JColorChooser tests
This pull request has now been integrated.
Changeset: cc5b9c63
Author: Alisen Chung
URL:
https://git.openjdk.org/jdk/commit/cc5b9c63cbc1743e22f80dce51d803e267c60317
St
> Removing applet usage from manual JFileChooser tests
> The original test is failing (nothing shows up in the JFileChooser), but this
> change does replace the applet usage with PassFailJFrame
Alisen Chung has updated the pull request incrementally with one additional
commit since
> Removing applet usage from manual JFileChooser tests
Alisen Chung has updated the pull request incrementally with one additional
commit since the last revision:
moved create ui code to helper, change test pass check, add mouse release,
remove getContentPane
-
Changes:
-
> Removing applet usage from manual JColorChooser tests
Alisen Chung has updated the pull request incrementally with one additional
commit since the last revision:
instruction string change
-
Changes:
- all: https://git.openjdk.org/jdk/pull/18369/files
- new: ht
On Mon, 25 Mar 2024 18:43:44 GMT, Alexander Zvegintsev
wrote:
>> Alisen Chung has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> test instructions
>
> test/jdk/javax/swing/JColorChooser/Test
> Removing applet usage from manual JColorChooser tests
Alisen Chung has updated the pull request incrementally with one additional
commit since the last revision:
instruction string change
-
Changes:
- all: https://git.openjdk.org/jdk/pull/18369/files
- new: ht
> Removing applet usage from manual JColorChooser tests
Alisen Chung has updated the pull request incrementally with one additional
commit since the last revision:
instruction string change
-
Changes:
- all: https://git.openjdk.org/jdk/pull/18316/files
- new: ht
> Removing applet usage from manual JFileChooser tests
Alisen Chung has updated the pull request incrementally with one additional
commit since the last revision:
change to automatic test
-
Changes:
- all: https://git.openjdk.org/jdk/pull/18415/files
- new: ht
On Mon, 18 Mar 2024 20:07:50 GMT, Alisen Chung wrote:
> Removing applet usage from manual JColorChooser tests
This pull request has now been integrated.
Changeset: 78d1b904
Author: Alisen Chung
URL:
https://git.openjdk.org/jdk/commit/78d1b9046830198cd61c505f04f245a430878a5b
St
1 - 100 of 392 matches
Mail list logo