to [EMAIL PROTECTED] at some point in the near future.
Still, it would be great to follow up on your suggestions;
TransactionSupport would be a real benefit to DBCP.
Best regards
Henning
On Tue, 2007-07-03 at 18:21 -0700, Dain Sundstrom wrote:
I just posted a patch JIRA which
Yes, but it *still* has a check list of all things to do (as subtasks).
You don't need to clone it but you get an idea what a TLP can
potentially have (e.g. a lot of TLPs did not know about the Solaris
zones).
Best regards
Henning
On Sat, 2007-06-23 at 23:33 -0700
There is a Velocity JIRA Issue with a lot of subtasks that basically has
everything that is needed/can be done for a new TLP. Scott cloned it for
Turbine, so it is TRB-44 and INFRA-1249. These might be good starting
points.
Best regards
Henning
Torsten Curdt schrieb
[
https://issues.apache.org/jira/browse/POOL-98?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12506780
]
Henning Schmiedehausen commented on POOL-98:
Well, giving it away through a protected getter is not really
[
https://issues.apache.org/jira/browse/POOL-98?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12506802
]
Henning Schmiedehausen commented on POOL-98:
ok, I can understand this. Any time frame on compositepool
Well, it shows up on some of the reports:
http://velocity.apache.org/anakia/devel/dependencies.html
and it also breaks the links there.
Best regards
Henning
Henri Yandell schrieb:
All the poms of that age have that problem. For example:
http://repo1.maven.org
http://repo1.maven.org/maven2/commons-lang/commons-lang/2.1/commons-lang-2.1.pom
[...]
url
http://jakarta.apache.org/commons/${pom.artifactId.substring(8)}/
/url
[...]
Scary, scary, scary...
Best regards
Henning
--
Henning P. Schmiedehausen -- [EMAIL PROTECTED
be made clear
from the beginning, that if another commons community (let's say XML
commons) wants to join, we will be able to expand the charter.
Best regards
Henning
I am +1 to TLP so long as it specifies Java, possibly 'Java-focussed' to
cover [daemon]. As Phil
this might be moot).
Java Commons would be fine with me, it will be shortened to
commons anyway.
Best regards
Henning
--
Henning P. Schmiedehausen -- [EMAIL PROTECTED] | J2EE, Linux,
|gls
91054 Buckenhof, Germany -- +49 9131 506540 | Apache person
need adhesion. Ours is Java and Java related components.
Best regards
Henning
--
Henning P. Schmiedehausen -- [EMAIL PROTECTED] | J2EE, Linux,
|gls
91054 Buckenhof, Germany -- +49 9131 506540 | Apache person |eau
Open Source
into the
commons.apache.org shoes to start with?
Yes. +1 to commons.apache.org. Death to Jakarta. :-)
Best regards
Henning
--
Henning P. Schmiedehausen -- [EMAIL PROTECTED] | J2EE, Linux,
|gls
91054 Buckenhof, Germany -- +49 9131 506540 | Apache person
[
https://issues.apache.org/jira/browse/POOL-97?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12484747
]
Henning Schmiedehausen commented on POOL-97:
Ah, that would explain some strange behaviour that I have seen
: Henning Schmiedehausen
Priority: Minor
The current implementation of GenericObjectPool encapsulates the _pool
object and there is no way to get it directly, which makes some things
like JMX pool monitoring a bit awkward.
Would it be possible to either make _pool protected or add
() {
return _pool;
}
or something like that to the GenericObjectPool implementation (and
probably others, but that is the one that bites me most... :-) )
This would make extending the GenericObjectPool much easier.
Best regards
Henning
--
Henning P. Schmiedehausen
FileUpload
Issue Type: Improvement
Reporter: Henning Schmiedehausen
Currently, the 1.2 release of c-f is located at
http://people.apache.org/repo/m2-ibiblio-rsync-repository/commons-fileupload/
It is probably better off at
http://people.apache.org/repo/m2-ibiblio-rsync-repository
and dependencies are required is a FAQ.
+1 I hope that m2 will help us along here in being able to clearly
specify build and runtime dependencies.
Best regards
Henning
--
Dipl.-Inf. (Univ.) Henning P. Schmiedehausen INTERMETA GmbH
[EMAIL PROTECTED]+49 9131
Thanks for the work!
Best regards
Henning
--
Dipl.-Inf. (Univ.) Henning P. Schmiedehausen INTERMETA GmbH
[EMAIL PROTECTED]+49 9131 50 654 0 http://www.intermeta.de/
RedHat Certified Engineer -- Jakarta Turbine
Emmanuel Bourg [EMAIL PROTECTED] writes:
If you are bothered about the Javadoc warnings, run the code through
Jalopy; it will fix up the javadocs with stubs containing the
parameters, return types and exceptions.
Best regards
Henning
Oliver Heger wrote:
I am having some
put some support in there now or we might have a situation where 1.3
is out and JCL has no support for it for quite a while.
Best regards
Henning
--
Dipl.-Inf. (Univ.) Henning P. Schmiedehausen INTERMETA GmbH
[EMAIL PROTECTED]+49 9131 50 654 0 http
(foo, new Object()); ?
The use of Object here is a bit obfuscated IMHO. Maybe we should use
a NullType marker object?
Best regards
Henning
// Create Lists, arrays or DynaBeans
if (type.isArray() || List.class.isAssignableFrom(type)) {
return
Eric Pugh [EMAIL PROTECTED] writes:
It looks like Commons Email 1.0 based on Henning's RC8 is go for launch!
Thanks! Start rolling the release right now. Just in time for the
Turbine 2.3.2 release. :-)
Best regards
Henning
The following people voted +1 for the release
Author: henning
Date: Tue Sep 27 06:04:37 2005
New Revision: 291927
URL: http://svn.apache.org/viewcvs?rev=291927view=rev
Log:
Update status information. Add Bug and Download links.
Modified:
jakarta/commons/proper/email/trunk/xdocs/index.xml
Modified: jakarta/commons/proper/email/trunk
Author: henning
Date: Tue Sep 27 06:04:52 2005
New Revision: 291928
URL: http://svn.apache.org/viewcvs?rev=291928view=rev
Log:
Version 1.0 released
Modified:
jakarta/commons/proper/email/trunk/xdocs/changes.xml
Modified: jakarta/commons/proper/email/trunk/xdocs/changes.xml
URL:
http
Author: henning
Date: Tue Sep 27 06:05:11 2005
New Revision: 291929
URL: http://svn.apache.org/viewcvs?rev=291929view=rev
Log:
Rebuild using 1.0 release POM
Modified:
jakarta/commons/proper/email/trunk/build.xml
Modified: jakarta/commons/proper/email/trunk/build.xml
URL:
http
Author: henning
Date: Tue Sep 27 06:06:23 2005
New Revision: 291930
URL: http://svn.apache.org/viewcvs?rev=291930view=rev
Log:
- Update to 1.0
- Fix Mailinglist links
- Add version tag
- update findbugs dep to 0.9.2 to make maven 1.1 happy.
Modified:
jakarta/commons/proper/email/trunk
Author: henning
Date: Tue Sep 27 06:29:29 2005
New Revision: 291935
URL: http://svn.apache.org/viewcvs?rev=291935view=rev
Log:
No more reason to keep these reports out. Maven does them just fine
from Subversion.
Modified:
jakarta/commons/proper/email/trunk/project.xml
Modified: jakarta
Author: henning
Date: Tue Sep 27 07:36:10 2005
New Revision: 291961
URL: http://svn.apache.org/viewcvs?rev=291961view=rev
Log:
Add my public key for 1.0 release (same as the KEYS file on the
distribution site).
Modified:
jakarta/commons/proper/email/trunk/KEYS
Modified: jakarta/commons
Author: henning
Date: Tue Sep 27 07:36:41 2005
New Revision: 291962
URL: http://svn.apache.org/viewcvs?rev=291962view=rev
Log:
Maven now uses a different way to deploy artifacts.
Modified:
jakarta/commons/proper/email/trunk/project.properties
Modified: jakarta/commons/proper/email/trunk
Author: henning
Date: Tue Sep 27 07:37:36 2005
New Revision: 291963
URL: http://svn.apache.org/viewcvs?rev=291963view=rev
Log:
commons-email 1.0
Added:
jakarta/commons/proper/email/tags/EMAIL_1_0/trunk/
- copied from r291962, jakarta/commons/proper/email/trunk
Author: henning
Date: Tue Sep 27 07:39:55 2005
New Revision: 291965
URL: http://svn.apache.org/viewcvs?rev=291965view=rev
Log:
1.0 is tagged and rolled. Let's go for 1.1...
Modified:
jakarta/commons/proper/email/trunk/project.properties
jakarta/commons/proper/email/trunk/project.xml
The Commons Email team of the Jakarta Project of the ASF is happy to
announce the release of Commons Email 1.0.
Jakarta Commons Email provides an API for sending email. It is built on
top of the Java Mail API, which it aims to simplify.
While this is the first official release for Commons Email,
Author: henning
Date: Tue Sep 27 07:55:12 2005
New Revision: 291969
URL: http://svn.apache.org/viewcvs?rev=291969view=rev
Log: (empty)
Added:
jakarta/commons/proper/email/tags/new_1.0/
- copied from r291968, jakarta/commons/proper/email/tags/EMAIL_1_0/trunk/
Removed:
jakarta
Author: henning
Date: Tue Sep 27 07:55:49 2005
New Revision: 291970
URL: http://svn.apache.org/viewcvs?rev=291970view=rev
Log:
Remove old EMAIL_1_0 tag
Removed:
jakarta/commons/proper/email/tags/EMAIL_1_0/
-
To unsubscribe
Author: henning
Date: Tue Sep 27 07:56:36 2005
New Revision: 291971
URL: http://svn.apache.org/viewcvs?rev=291971view=rev
Log:
There already was a non-voted 1.0 release tag which conflicted with the
official tag. Removed it and put the right one in place
Added:
jakarta/commons/proper/email
Phil Steitz [EMAIL PROTECTED] writes:
I would like to nominate Jörg Schaible as an Apache Jakarta Commons Committer.
[X] +1, let him commit!
[ ] +0
[ ] -0
[ ] -1, no, because
--
Dipl.-Inf. (Univ.) Henning P. Schmiedehausen INTERMETA GmbH
[EMAIL PROTECTED]+49 9131 50 654 0
the vote to close and post a result.
Best regards
Henning
--
Dipl.-Inf. (Univ.) Henning P. Schmiedehausen INTERMETA GmbH
[EMAIL PROTECTED]+49 9131 50 654 0 http://www.intermeta.de/
RedHat Certified Engineer -- Jakarta Turbine Development -- hero
robert burrell donkin [EMAIL PROTECTED] writes:
i don't seem to be able to RC8 in
http://people.apache.org/~epugh/commons-email/. should i be looking
somewhere else?
http://people.apache.org/~henning/commons-email/
:-)
Best regards
Henning
--
Dipl.-Inf. (Univ
dependencies without good reason is frowned upon and then
commons-proper where dependencies are ok.
Best regards
Henning
--
Dipl.-Inf. (Univ.) Henning P. Schmiedehausen INTERMETA GmbH
[EMAIL PROTECTED]+49 9131 50 654 0 http://www.intermeta.de/
RedHat
being
added, and reducing the chance of a 1.0.1 coming out in a week!
[X ] +1 Release Email 1.0 based on RC8
Best regards
Henning
--
Dipl.-Inf. (Univ.) Henning P. Schmiedehausen INTERMETA GmbH
[EMAIL PROTECTED]+49 9131 50 654 0 http
()) if you need 1.3 compatibility.
should be possible everywhere.
Best regards
Henning
--
Dipl.-Inf. (Univ.) Henning P. Schmiedehausen INTERMETA GmbH
[EMAIL PROTECTED]+49 9131 50 654 0 http://www.intermeta.de/
RedHat Certified Engineer -- Jakarta Turbine
and sub-packages modifier. So
if you want to use an utility class in foo, foo.bar, foo.baz, you have
to make it public (Sun, are you listening? Here is a chance for
another cool new scope that C# probably doesn't have yet. ;-) )
Best regards
Henning
-Original Message
Andrei Polushin [EMAIL PROTECTED] writes:
Henning P. Schmiedehausen writes:
One of the quirks in the Java language is, that the package names
(foo, foo.bar, foo.bar.baz) imply a hierarchy which in fact does not
exist. There is no visible in package and sub-packages modifier. So
if you want
Henning
--
Dipl.-Inf. (Univ.) Henning P. Schmiedehausen INTERMETA GmbH
[EMAIL PROTECTED]+49 9131 50 654 0 http://www.intermeta.de/
RedHat Certified Engineer -- Jakarta Turbine Development -- hero for hire
Linux, Java, perl, Solaris -- Consulting, Training
that you've made. I'm currently
just reviewing a few issues with building and testing the jars on
1.3.1 JDK on Linux but locally here I'm already running c-e with your
patch applied. I plan on working on this today.
Regards
Henning
--
Dipl.-Inf. (Univ.) Henning P
Author: henning
Date: Wed Sep 7 02:52:44 2005
New Revision: 279285
URL: http://svn.apache.org/viewcvs?rev=279285view=rev
Log:
Apply Stephen Colebourne's patch to remove the commons-lang
dependency. Thanks a lot, Stephen.
Modified:
jakarta/commons/proper/email/trunk/build.xml
jakarta
Author: henning
Date: Wed Sep 7 02:58:35 2005
New Revision: 279287
URL: http://svn.apache.org/viewcvs?rev=279287view=rev
Log:
- Actually add EmailUtils.
- reformatted code to match overall commons-email style.
Added:
jakarta/commons/proper/email/trunk/src/java/org/apache/commons/mail
Author: henning
Date: Wed Sep 7 03:16:00 2005
New Revision: 279290
URL: http://svn.apache.org/viewcvs?rev=279290view=rev
Log:
Added Niall's Unit test for invalid addresses. Thanks.
Added:
jakarta/commons/proper/email/trunk/src/test/org/apache/commons/mail/InvalidAddressTest.java
Author: henning
Date: Wed Sep 7 03:56:41 2005
New Revision: 279295
URL: http://svn.apache.org/viewcvs?rev=279295view=rev
Log:
Applied Niall's patch from 36536. Thanks.
Added:
jakarta/commons/proper/email/trunk/src/test/org/apache/commons/mail/InvalidInternetAddressTest.java
(with props
Author: henning
Date: Wed Sep 7 03:57:22 2005
New Revision: 279296
URL: http://svn.apache.org/viewcvs?rev=279296view=rev
Log:
Whoops, that shouldn't have gone in...
Modified:
jakarta/commons/proper/email/trunk/project.xml
Modified: jakarta/commons/proper/email/trunk/project.xml
URL:
http
Author: henning
Date: Wed Sep 7 04:43:52 2005
New Revision: 279300
URL: http://svn.apache.org/viewcvs?rev=279300view=rev
Log:
Update the test cases to run each test on a different port. Else the
tests will fail consistently with JDK 1.3.x
Modified:
jakarta/commons/proper/email/trunk/src
Author: henning
Date: Wed Sep 7 04:49:32 2005
New Revision: 279301
URL: http://svn.apache.org/viewcvs?rev=279301view=rev
Log:
add some notes to the release notes
Modified:
jakarta/commons/proper/email/trunk/RELEASE-NOTES.txt
Modified: jakarta/commons/proper/email/trunk/RELEASE-NOTES.txt
Author: henning
Date: Wed Sep 7 05:02:43 2005
New Revision: 279302
URL: http://svn.apache.org/viewcvs?rev=279302view=rev
Log:
RC8
Modified:
jakarta/commons/proper/email/trunk/project.xml
Modified: jakarta/commons/proper/email/trunk/project.xml
URL:
http://svn.apache.org/viewcvs/jakarta
Author: henning
Date: Wed Sep 7 05:03:31 2005
New Revision: 279303
URL: http://svn.apache.org/viewcvs?rev=279303view=rev
Log:
RC8
Added:
jakarta/commons/proper/email/tags/EMAIL_1_0_RC8/
- copied from r279302, jakarta/commons/proper/email/trunk
Author: henning
Date: Wed Sep 7 05:03:47 2005
New Revision: 279304
URL: http://svn.apache.org/viewcvs?rev=279304view=rev
Log:
rc9-dev
Modified:
jakarta/commons/proper/email/trunk/project.xml
Modified: jakarta/commons/proper/email/trunk/project.xml
URL:
http://svn.apache.org/viewcvs
.
I've built a new release candidate using JDK 1.3.1: commons-email-1.0-rc8
Get it (and also source and binary distributions) from
http://people.apache.org/~henning/commons-email/
I also redeployed the commons-email site; the updated docs should be
available from jakarta.apache.org in a few hours
Dion Gillard [EMAIL PROTECTED] writes:
I'm sure I always use maven.junit.fork=true in my ~/build.properties
I've tried both junit.fork=true and false and it still failed
consistently for me on Linux. Easiest was to increment the port number
on every test.
Regards
Henning
Author: henning
Date: Wed Sep 7 05:41:58 2005
New Revision: 279313
URL: http://svn.apache.org/viewcvs?rev=279313view=rev
Log:
Fix minor keywords issue noticed by Andrei Polushin.
Modified:
jakarta/commons/proper/email/trunk/src/java/org/apache/commons/mail/EmailException.java
jakarta
')
.append(className)
.append(';');
}
clazz = Class.forName(actualNameBuffer.toString());
}
}
}
return clazz;
}
--- cut ---
Best regards
Henning
public static
=?iso-8859-1?Q?J=F6rg_Schaible?= [EMAIL PROTECTED] writes:
Hi Henning,
Hi Jörg,
Well, looking into the JDK source I see no real advantage of not using
endsWith. x.endsWith([]) will exactly do 2 character compares (if the string
matches), as well as your code above. And it only has one bounds
Stephen Colebourne [EMAIL PROTECTED] writes:
Henning P. Schmiedehausen wrote:
Give us a patch. Code before words. As I said, I've looked into this
and I might do some work for 1.1. Not for 1.0.
I send this as a patch on Bugzilla today.
Cool. Thanks.
Regards
Henning
, I'm +1. Do we copy all of this
or just the methods that we need?
Regards
Henning
--
Dipl.-Inf. (Univ.) Henning P. Schmiedehausen INTERMETA GmbH
[EMAIL PROTECTED]+49 9131 50 654 0 http://www.intermeta.de/
RedHat Certified Engineer -- Jakarta Turbine
this patch and restart the
voting.
Opinions? I've tested it locally and it works fine.
Regards
Henning
--
Dipl.-Inf. (Univ.) Henning P. Schmiedehausen INTERMETA GmbH
[EMAIL PROTECTED]+49 9131 50 654 0 http://www.intermeta.de/
RedHat Certified Engineer
for pointing this out, if you advise to
build the release using the 1.3.1 JDK, I will consider looking into
this.
Regards
Henning
--
Dipl.-Inf. (Univ.) Henning P. Schmiedehausen INTERMETA GmbH
[EMAIL PROTECTED]+49 9131 50 654 0 http://www.intermeta.de/
RedHat
-email isn't probably the right tool either.
Regards
Henning
--
Dipl.-Inf. (Univ.) Henning P. Schmiedehausen INTERMETA GmbH
[EMAIL PROTECTED]+49 9131 50 654 0 http://www.intermeta.de/
RedHat Certified Engineer -- Jakarta Turbine Development -- hero
, I'll try
again.
The 1.3.1 built jar passes the tests when running the test cases under
the 1.4.2 runtime. You can get this jar from
people.apache.org/~henning/commons-email-1.0-rc7.jar for
testing. Personally I'd consider this good enough.
As a side note: 1.3 is in EOL process at Sun. At what point
a patch. Code before words. As I said, I've looked into this
and I might do some work for 1.1. Not for 1.0.
Regards
Henning
--
Dipl.-Inf. (Univ.) Henning P. Schmiedehausen INTERMETA GmbH
[EMAIL PROTECTED]+49 9131 50 654 0 http://www.intermeta.de/
RedHat
There is only a 1.0.3, a 1.5 and a 1.6 version of dumbster @ ibiblio.
All three don't work with the 1.3 JDK.
Regards
Henning
On Fri, 2005-09-02 at 22:47 +1000, Dion Gillard wrote:
Which version of dumbster is being used? I specifically got a 1.3
version deployed
Henning
--
Dipl.-Inf. (Univ.) Henning P. Schmiedehausen INTERMETA GmbH
[EMAIL PROTECTED]+49 9131 50 654 0 http://www.intermeta.de/
RedHat Certified Engineer -- Jakarta Turbine Development -- hero for hire
Linux, Java, perl, Solaris -- Consulting, Training
Author: henning
Date: Wed Aug 31 01:13:46 2005
New Revision: 264969
URL: http://svn.apache.org/viewcvs?rev=264969view=rev
Log:
Remove double test on isEmpty(charset)
Modified:
jakarta/commons/proper/email/trunk/src/java/org/apache/commons/mail/MultiPartEmail.java
Modified:
jakarta
Author: henning
Date: Wed Aug 31 01:15:43 2005
New Revision: 264970
URL: http://svn.apache.org/viewcvs?rev=264970view=rev
Log:
Hrmpf. Compile first, then checking. Forgot a closing brace...
Modified:
jakarta/commons/proper/email/trunk/src/java/org/apache/commons/mail/MultiPartEmail.java
Author: henning
Date: Wed Aug 31 01:45:08 2005
New Revision: 264975
URL: http://svn.apache.org/viewcvs?rev=264975view=rev
Log:
remove tab chars
Modified:
jakarta/commons/proper/email/trunk/src/java/org/apache/commons/mail/MultiPartEmail.java
Modified:
jakarta/commons/proper/email/trunk
someone else confirm this issue?
The unit tests work fine for me with both en_US and en_US.UTF-8
locale. What platform, what locale did you try?
Regards
Henning
Eric
On Aug 30, 2005, at 8:22 AM, Henning P. Schmiedehausen wrote:
BodyPart primary = getPrimaryBodyPart
developer's boxes. This might be a good
thing to double check.
jar:jar, site, dist:build-bin and dist:build-src are ok on Linux with
JDK 1.4.2. And with the latest and greatest maven xdoc plugin, even
the site is readable again...
Regards
Henning
--
Dipl.-Inf. (Univ
Flatoff Allan [EMAIL PROTECTED] writes:
It was/is available at
http://jakarta.apache.org/commons/email/dependencies.html
activation, commons-lang, javamail. dumbster is needed only for
testing, not for using commons-email.
Regards
Henning
Eric,
What are the code
Eric Pugh [EMAIL PROTECTED] writes:
Henning (and others),
I'm fine. I did take a look at the open issue in bugzilla (#34056),
but IMHO it still needs some work.
There is at least one method name that I don't like:
setIsInitialized(). This should be setInitialized().
I do understand the issue
Author: henning
Date: Thu Aug 25 01:18:14 2005
New Revision: 240022
URL: http://svn.apache.org/viewcvs?rev=240022view=rev
Log:
Tagged release candidate 6
Added:
jakarta/commons/proper/email/tags/EMAIL_1_0_RC6/
- copied from r240021, jakarta/commons/proper/email/trunk
Author: henning
Date: Thu Aug 25 01:18:54 2005
New Revision: 240023
URL: http://svn.apache.org/viewcvs?rev=240023view=rev
Log:
trunk is now rc7-dev (or will be 1.0 when rc6 works out)
Modified:
jakarta/commons/proper/email/trunk/project.xml
Modified: jakarta/commons/proper/email/trunk
Eric Pugh [EMAIL PROTECTED] writes:
the sixth release candidate for commons email is now available for
download from http://people.apache.org/~epugh/commons-email/.
I tagged rc6 to tags/EMAIL_1_0_RC6 and moved the trunk to rc7-dev.
Regards
Henning
--
Dipl.-Inf. (Univ
Author: henning
Date: Thu Aug 25 02:40:24 2005
New Revision: 240027
URL: http://svn.apache.org/viewcvs?rev=240027view=rev
Log:
Gee, do you all have multi-GHz CPUs? This test fails consistently for
me on a slow CPU... Add some fuzzyness to the time compare.
Modified:
jakarta/commons/proper
Author: henning
Date: Thu Aug 25 02:44:06 2005
New Revision: 240028
URL: http://svn.apache.org/viewcvs?rev=240028view=rev
Log:
make the binary distribution contain the dependency libraries that we
are allowed to distribute. Add a notice which will be put into
/libs/.
Use the dist.bundle trick
Author: henning
Date: Thu Aug 25 02:44:54 2005
New Revision: 240029
URL: http://svn.apache.org/viewcvs?rev=240029view=rev
Log:
I'm so fed up with the dist:bin / site build failing just because I
forgot to check out the commons-build module. Add a big fat message
for this.
Modified:
jakarta
Author: henning
Date: Thu Aug 25 02:58:41 2005
New Revision: 240030
URL: http://svn.apache.org/viewcvs?rev=240030view=rev
Log:
Findbugs. Everyone loves Findbugs. :-)
Modified:
jakarta/commons/proper/email/trunk/project.xml
Modified: jakarta/commons/proper/email/trunk/project.xml
URL:
http
Author: henning
Date: Thu Aug 25 03:02:02 2005
New Revision: 240032
URL: http://svn.apache.org/viewcvs?rev=240032view=rev
Log:
Don't clobber these files when using cw.
Added:
jakarta/commons/proper/email/trunk/conf/CodeWrestler.excludes
Added: jakarta/commons/proper/email/trunk/conf
Author: henning
Date: Thu Aug 25 03:01:21 2005
New Revision: 240031
URL: http://svn.apache.org/viewcvs?rev=240031view=rev
Log:
Use CodeWrestler to bring all license notices to 2001-2005.
Modified:
jakarta/commons/proper/email/trunk/STATUS.html
jakarta/commons/proper/email/trunk
Author: henning
Date: Thu Aug 25 03:03:05 2005
New Revision: 240033
URL: http://svn.apache.org/viewcvs?rev=240033view=rev
Log:
Remove trailing blanks
Modified:
jakarta/commons/proper/email/trunk/maven.xml
jakarta/commons/proper/email/trunk/project.xml
jakarta/commons/proper/email
Author: henning
Date: Thu Aug 25 03:09:00 2005
New Revision: 240035
URL: http://svn.apache.org/viewcvs?rev=240035view=rev
Log:
down to just one checkstyle / one PMD error...
Modified:
jakarta/commons/proper/email/trunk/src/java/org/apache/commons/mail/Email.java
Modified:
jakarta/commons
Author: henning
Date: Thu Aug 25 03:16:26 2005
New Revision: 240037
URL: http://svn.apache.org/viewcvs?rev=240037view=rev
Log:
Found by Findbugs:
WMI: Method org.apache.commons.mail.Email.setHeaders(java.util.Map)
makes inefficient use of keySet iterator instead of entrySet
iterator
Author: henning
Date: Thu Aug 25 03:17:03 2005
New Revision: 240038
URL: http://svn.apache.org/viewcvs?rev=240038view=rev
Log:
Found by Findbugs:
ITA: Method org.apache.commons.mail.Email.toInternetAddressArray(java.util.List)
uses Collection.toArray() with zero-length array argument
and RuntimeException is not explicitly caught
False positives IMHO. There are a few Exceptions inside these blocks
that derive from Exception.
Regards
Henning
--
Dipl.-Inf. (Univ.) Henning P. Schmiedehausen INTERMETA GmbH
[EMAIL PROTECTED]+49 9131 50 654 0
Henning
--
Dipl.-Inf. (Univ.) Henning P. Schmiedehausen INTERMETA GmbH
[EMAIL PROTECTED]+49 9131 50 654 0 http://www.intermeta.de/
RedHat Certified Engineer -- Jakarta Turbine Development -- hero for hire
Linux, Java, perl, Solaris -- Consulting, Training
Eric Pugh [EMAIL PROTECTED] writes:
Yes, think we expected to do a couple fixes to Turbine once we hit
1.0...
It's ok. I just wanted to point it out in case it was unintentional.
Regards
Henning
Eric
On Aug 25, 2005, at 6:41 AM, Henning P. Schmiedehausen wrote
: when could a 1.2 release happen?
[ ] can replace 1.1 without any user or developer visible changes: 1.1.1
[ ] might have some developers gotchas or user visible changes: 1.2
IMHO.
Regards
Henning
--
Dipl.-Inf. (Univ.) Henning P. Schmiedehausen INTERMETA GmbH
Oliver Heger [EMAIL PROTECTED] writes:
Henning P. Schmiedehausen wrote:
[ ] can replace 1.1 without any user or developer visible changes: 1.1.1
[ ] might have some developers gotchas or user visible changes: 1.2
IMHO.
Okay, then 1.2 would be the number of choice. Fine with me!
Note
Henning
--
Dipl.-Inf. (Univ.) Henning P. Schmiedehausen INTERMETA GmbH
[EMAIL PROTECTED]+49 9131 50 654 0 http://www.intermeta.de/
RedHat Certified Engineer -- Jakarta Turbine Development -- hero for hire
Linux, Java, perl, Solaris -- Consulting, Training, Development
Eric Pugh [EMAIL PROTECTED] writes:
If no one finds a show stopper, then Henning has graciously
volunteered to be the release manager and perform the magic signing
of the jars with his Apache key.
:-)
Regards
Henning
--
Dipl.-Inf. (Univ.) Henning P. Schmiedehausen
strolling through the commons-dev list
early in the morning with my coffee right besides me and pointing out
stuff. ;-)
Regards
Henning
--
Dipl.-Inf. (Univ.) Henning P. Schmiedehausen INTERMETA GmbH
[EMAIL PROTECTED]+49 9131 50 654 0 http://www.intermeta.de
();
}
Regards
Henning
--
Dipl.-Inf. (Univ.) Henning P. Schmiedehausen INTERMETA GmbH
[EMAIL PROTECTED]+49 9131 50 654 0 http://www.intermeta.de/
RedHat Certified Engineer -- Jakarta Turbine Development -- hero for hire
Linux, Java, perl, Solaris
in the long run, because it makes sure that every
exception thrown by it.next() is caught.
Regards
Henning
--
Dipl.-Inf. (Univ.) Henning P. Schmiedehausen INTERMETA GmbH
[EMAIL PROTECTED]+49 9131 50 654 0 http://www.intermeta.de/
RedHat Certified Engineer
in 1.0.1 or 1.1
Regards
Henning
--
Dipl.-Inf. (Univ.) Henning P. Schmiedehausen INTERMETA GmbH
[EMAIL PROTECTED]+49 9131 50 654 0 http://www.intermeta.de/
RedHat Certified Engineer -- Jakarta Turbine Development -- hero for hire
Linux, Java, perl
tell
me that can never be null. Yeah, unless, some weird condition
happens that was not tested for and surfaced after customer
installation. Better safe than sorry. Defensive programming... :-)
Regards
Henning
--
Dipl.-Inf. (Univ.) Henning P. Schmiedehausen
1 - 100 of 275 matches
Mail list logo
