On Tue, 28 Mar 2023 18:25:21 GMT, Naoto Sato wrote:
> Fixing a documentation bug for `CharacterCodingException` without any
> description to it as attached. A corresponding CSR is also drafted.
>
> ![Screenshot 2023-03-28 at 11 19 00
>
> Last but not least, a port of fdlibm IEEEremainder from C to Java. I plan to
> write some more implementation-specific tests around decision points in the
> FDLIBM algorithm, but I wanted to get the bulk of the changes out for review
> first.
>
> Note that since IEEEremainder was the last
On Mon, 27 Mar 2023 09:43:03 GMT, Raffaello Giulietti
wrote:
>> Joe Darcy has updated the pull request with a new target base due to a merge
>> or a rebase. The incremental webrev excludes the unrelated changes brought
>> in by the merge/rebase. The pull request contains three additional
> Last but not least, a port of fdlibm IEEEremainder from C to Java. I plan to
> write some more implementation-specific tests around decision points in the
> FDLIBM algorithm, but I wanted to get the bulk of the changes out for review
> first.
>
> Note that since IEEEremainder was the last
On Sun, 29 Jan 2023 01:54:02 GMT, Tingjun Yuan wrote:
> Add `java.io.PrintOutput` to represent print operations, and modify
> `java.io.PrintStream` and `java.io.PrintWriter` to implement it.
This pull request has been closed without being integrated.
-
PR:
> This implements a shared utility to dump generated classes defined as
> normal/hidden classes via `Lookup` API. This replaces the implementation in
> `LambdaMetaFactory` and method handle implementation that dumps the hidden
> class bytes on disk for debugging.
>
> For classes defined
> Add API to explore Class Hierarchy with a `ClassLoader` or a `Lookup` with
> proper privileges, with tests.
>
> This addition is useful in case classes at runtime are not loaded from the
> system class loader, such as Proxy. This is also useful to APIs that generate
> bytecode with a
On Tue, 28 Mar 2023 10:57:36 GMT, Alan Bateman wrote:
>> Jaikiran Pai has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> use test.jdk system property in test
>
> src/jdk.jlink/share/classes/jdk/tools/jlink/internal/Platform.java line 39:
>
> Can I please get a review for this change which proposes to fix the issue
> reported in https://bugs.openjdk.org/browse/JDK-8206890?
>
> The `jlink` command allows a `--endian` option to specify the byte order in
> the generated image. Before this change, when such a image was being
>
On Tue, 28 Mar 2023 10:57:28 GMT, Rémi Forax wrote:
>> Chen Liang has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> rethrow error
>
> src/java.base/share/classes/java/lang/invoke/MethodHandleProxies.java line
> 206:
>
>> 204:
> As John Rose has pointed out in this issue, the current j.l.r.Proxy based
> implementation of MethodHandleProxies.asInterface has a few issues:
> 1. Exposes too much information via Proxy supertype (and WrapperInstance
> interface)
> 2. Does not allow future expansion to support SAM[^1]
On Mon, 27 Mar 2023 23:34:52 GMT, Chen Liang wrote:
> As John Rose has pointed out in this issue, the current j.l.r.Proxy based
> implementation of MethodHandleProxies.asInterface has a few issues:
> 1. Exposes too much information via Proxy supertype (and WrapperInstance
> interface)
> 2.
> As John Rose has pointed out in this issue, the current j.l.r.Proxy based
> implementation of MethodHandleProxies.asInterface has a few issues:
> 1. Exposes too much information via Proxy supertype (and WrapperInstance
> interface)
> 2. Does not allow future expansion to support SAM[^1]
On Wed, 29 Mar 2023 00:31:46 GMT, Johannes Kuhn wrote:
>> Do interfaces still implement these properly without definition if they
>> extend interfaces that declare `@Override boolean equals();` etc.?
>
> Yes. You can use [`Comperator`][1] as test.
>
> [1]:
>
On Wed, 29 Mar 2023 00:25:09 GMT, Chen Liang wrote:
>> src/java.base/share/classes/java/lang/invoke/MethodHandleProxies.java line
>> 338:
>>
>>> 336: .aload(1)
>>> 337: .ifThenElse(Opcode.IF_ACMPEQ,
>>> CodeBuilder::iconst_1, CodeBuilder::iconst_0)
>>>
On Wed, 29 Mar 2023 00:13:56 GMT, Johannes Kuhn wrote:
>> As John Rose has pointed out in this issue, the current j.l.r.Proxy based
>> implementation of MethodHandleProxies.asInterface has a few issues:
>> 1. Exposes too much information via Proxy supertype (and WrapperInstance
>> interface)
On Mon, 27 Mar 2023 23:34:52 GMT, Chen Liang wrote:
> As John Rose has pointed out in this issue, the current j.l.r.Proxy based
> implementation of MethodHandleProxies.asInterface has a few issues:
> 1. Exposes too much information via Proxy supertype (and WrapperInstance
> interface)
> 2.
On Wed, 29 Mar 2023 00:08:21 GMT, Pavel Rappo wrote:
>> src/java.base/share/classes/java/lang/System.java line 2566:
>>
>>> 2564:
>>> 2565: public V executeOnCarrierThread(Callable task)
>>> throws Exception {
>>> 2566: if (Thread.currentThread() instanceof
On Tue, 28 Mar 2023 23:47:02 GMT, Leonid Mesnik wrote:
>> Alan Bateman has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains four additional
>>
On Tue, 28 Mar 2023 19:36:18 GMT, Alan Bateman wrote:
>> JEP 444 proposes to make virtual threads a permanent feature in Java 21. The
>> APIs that were preview APIs in Java 19/20 are changed to permanent and their
>> `@since`/equivalent are changed to 21 (as per the guidance in JEP 12). The
> This patch adds checks in AbstractLinker to reject packed structs and structs
> with excess padding (e.g. unnamed bitfields), since both of those are
> currently not supported, and the ABI/spec seems too vague to base support on.
Jorn Vernee has updated the pull request with a new target base
On Mon, 27 Mar 2023 14:51:28 GMT, Maurizio Cimadamore
wrote:
>> Jorn Vernee has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase.
>
>
On Tue, 28 Mar 2023 17:59:33 GMT, Jorn Vernee wrote:
>> This patch adds checks in AbstractLinker to reject packed structs and
>> structs with excess padding (e.g. unnamed bitfields), since both of those
>> are currently not supported, and the ABI/spec seems too vague to base
>> support on.
>
> This patch adds checks in AbstractLinker to reject packed structs and structs
> with excess padding (e.g. unnamed bitfields), since both of those are
> currently not supported, and the ABI/spec seems too vague to base support on.
Jorn Vernee has updated the pull request incrementally with one
On Tue, 28 Mar 2023 21:01:45 GMT, Justin Lu wrote:
> This PR fixes a bad sentence break in DateFormat.FIELD AM_PM that caused
> incomplete API
>
> Before:
> src="https://user-images.githubusercontent.com/67398801/228359165-f8c66ca2-745b-47ea-bca9-9c4afc7af914.png;>
>
> After:
>
On Tue, 28 Mar 2023 21:48:23 GMT, Lance Andersen wrote:
> Please review this trivial change which removes a redundant `-` from an
> `@param` and cleans up the formatting for the `isValid` method.
>
>
> It looks like there is some additional formatting clean up that can be done
> but I will
On Tue, 28 Mar 2023 21:51:21 GMT, Roger Riggs wrote:
>> Mandy Chung has updated the pull request incrementally with two additional
>> commits since the last revision:
>>
>> - move ClassFileDumper to jdk.internal.util
>> - rename the system property for dumping class files
>
>
On Tue, 28 Mar 2023 21:01:45 GMT, Justin Lu wrote:
> This PR fixes a bad sentence break in DateFormat.FIELD AM_PM that caused
> incomplete API
>
> Before:
> src="https://user-images.githubusercontent.com/67398801/228359165-f8c66ca2-745b-47ea-bca9-9c4afc7af914.png;>
>
> After:
>
On Tue, 28 Mar 2023 21:01:45 GMT, Justin Lu wrote:
> This PR fixes a bad sentence break in DateFormat.FIELD AM_PM that caused
> incomplete API
>
> Before:
> src="https://user-images.githubusercontent.com/67398801/228359165-f8c66ca2-745b-47ea-bca9-9c4afc7af914.png;>
>
> After:
>
On Tue, 28 Mar 2023 21:01:45 GMT, Justin Lu wrote:
> This PR fixes a bad sentence break in DateFormat.FIELD AM_PM that caused
> incomplete API
>
> Before:
> src="https://user-images.githubusercontent.com/67398801/228359165-f8c66ca2-745b-47ea-bca9-9c4afc7af914.png;>
>
> After:
>
On Tue, 28 Mar 2023 21:48:23 GMT, Lance Andersen wrote:
> Please review this trivial change which removes a redundant `-` from an
> `@param` and cleans up the formatting for the `isValid` method.
>
>
> It looks like there is some additional formatting clean up that can be done
> but I will
On Mon, 27 Mar 2023 21:12:28 GMT, Mandy Chung wrote:
>> This implements a shared utility to dump generated classes defined as
>> normal/hidden classes via `Lookup` API. This replaces the implementation
>> in `LambdaMetaFactory` and method handle implementation that dumps the
>> hidden class
Please review this trivial change which removes a redundant `-` from an
`@param` and cleans up the formatting for the `invalid` method.
It looks like there is some additional formatting clean up that can be done but
I will handle that under a separate PR.
-
Commit messages:
-
On Tue, 28 Mar 2023 00:01:27 GMT, Stuart Marks wrote:
>> This change is absolutely massive, implementing reversed() basically doubles
>> the number of implementations which means multiple years of debugging / spec
>> fixing.
>>
>> Reversing a List makes sense, reversing a
This PR fixes a bad sentence break in DateFormat.FIELD AM_PM that caused
incomplete API
Before:
https://user-images.githubusercontent.com/67398801/228359165-f8c66ca2-745b-47ea-bca9-9c4afc7af914.png;>
After:
> This PR fixes the bug which occurred when `Calendar.roll(WEEK_OF_YEAR)`
> rolled into a minimal first week with an invalid `WEEK_OF_YEAR` and
> `DAY_OF_WEEK` combo.
>
> For example, Rolling _Monday, 30 December 2019_ by 1 week produced _Monday,
> 31 December 2018_, which is incorrect. This
On Thu, 23 Mar 2023 12:05:50 GMT, Eirik Bjorsnos wrote:
> This PR removes the JAR index feature from the runtime:
>
> - `URLClassPath` is updated to remove the `enableJarIndex` system property
> and any code which would be called when this property was `true`
> - The `JarIndex` implementation
On Tue, 28 Mar 2023 19:36:18 GMT, Alan Bateman wrote:
>> JEP 444 proposes to make virtual threads a permanent feature in Java 21. The
>> APIs that were preview APIs in Java 19/20 are changed to permanent and their
>> `@since`/equivalent are changed to 21 (as per the guidance in JEP 12). The
On Tue, 28 Mar 2023 18:25:21 GMT, Naoto Sato wrote:
> Fixing a documentation bug for `CharacterCodingException` without any
> description to it as attached. A corresponding CSR is also drafted.
>
> 