Re: new meta data for plugin.xml

2013-10-21 Thread Lucas Holmquist
Perhaps this has been brought up before, but why are we using an xml file? why not make it a json file. Plugman is written in node( js ) so why not have the plugin config file in it's native format. This will probably save a bit of code since the xml is converted to an object to

Re: new meta data for plugin.xml

2013-10-21 Thread Bryan Higgins
I believe the consensus at the time was to use XML since it is the format used in other cordova config files, making it easier for plugin developers to upgrade. Changing to json now would not be possible without breaking existing plugins or supporting both formats for a while. Not worth the

Re: config.xml discussion, we need to talk

2013-10-21 Thread Ian Clelland
Legacy, though, sounds like it's something that we're actively moving away from; something that we support only grudgingly, and which we might deprecate at the drop of a hat. The platform-only workflow supports legitimate use-cases which CLI probably will never cover -- things like embedding a

Re: new meta data for plugin.xml

2013-10-21 Thread Ian Clelland
I suspect that it is because plugin.xml was derived (intellectually, if not literally) from config.xml, which was an XML file because of the W3C Widgets spec, which we tried to adhere to. Whether that spec is still relevant (there doesn't seem to be a lot of vendor interest in it (speaking as an

Re: config.xml discussion, we need to talk

2013-10-21 Thread Michal Mocny
(Okay, this thread at high risk of bikeshedding, just going to mention that ;) But I do think it would be great to settle once and for all. I like the distinction Steven/Brian are making: Project flow vs Platform flow. I'm not sure that those names are immediately 100% clear (I'll ponder over

Re: Windows 8.1 and other platform addition

2013-10-21 Thread Andrew Grieve
On Fri, Oct 18, 2013 at 12:54 PM, Maxime LUCE max...@somatic.fr wrote: Hi everyone, As I said before, I'm working on the Windows 8.1 port of Cordova base on the Windows 8 one. I sent an email with my first thoughts about the improvements we have to do and there are few. In order to make

Re: new meta data for plugin.xml

2013-10-21 Thread Michal Mocny
XML is also buying us a couple of small but nice features, such as optionally wrapping tags with a platform tag or (potentially) a mode tag, etc. That functionality would not be expressed as cleanly with JSON, so its not a pure win to move away from XML. Add to that the fact that we are already

Re: new meta data for plugin.xml

2013-10-21 Thread Lucas Holmquist
yea, this is understandable. wasn't really sure the reasoning, but it looks like diminishing returns here On Oct 21, 2013, at 10:06 AM, Michal Mocny mmo...@chromium.org wrote: XML is also buying us a couple of small but nice features, such as optionally wrapping tags with a platform tag or

Re: Default template - size

2013-10-21 Thread Andrew Grieve
I thought it used to be in the README.md (or somewhere else?), but I don't think the res/ directory is meant to be included at all. When updating the template, you're supposed to take the platform-specific things out of there and put them in the right spot (splash screen and icon). They aren't

Re: a new client for download stats

2013-10-21 Thread Braden Shepherdson
There's no restriction, we just wanted to know what tools people were using. That means we definitely want JBoss Tools to call home and identify itself! We want to know what fraction of the downloads are coming from JBoss, and to have those downloads count towards the overall plugin download

Re: new meta data for plugin.xml

2013-10-21 Thread Braden Shepherdson
I'd be happier if it were JSON, but it's not, and the XML doesn't cause enough pain to be worth making the switch. Ian explained it accurately; it's mostly a historical accident that we're using XML. Braden On Mon, Oct 21, 2013 at 10:09 AM, Lucas Holmquist lholm...@redhat.comwrote: yea,

www/config.xml plugin dependencies

2013-10-21 Thread Axel.Nennker
Hi, the docs in https://cordova.apache.org/docs/en/3.1.0/config_ref_index.md.html#The%20config.xml%20File say that the feature element is only for the platform specific config.xml s, right? Is there a way to specify that my phonegap app needs a plugin on all platforms e.g. Globalization?

Re: Review Request 14757: Cordova Plugin Registry Blog Post

2013-10-21 Thread Michal Mocny
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14757/#review27246 --- /www/_posts/2013-10-21-cordova-registry.md

Re: Requisite Introduction

2013-10-21 Thread Andrew Grieve
Cool. One thing I would look at is whether Angular is using history.pushState / replaceState. They have been known to be buggy on Android. On Sun, Oct 20, 2013 at 3:22 AM, Dick Van den Brink d_vandenbr...@outlook.com wrote: Welcome! Seems like a nice bug to start with! ;) Sent from my

Re: www/config.xml plugin dependencies

2013-10-21 Thread Ian Clelland
I don't think that we have app dependencies in Cordova (yet). If your app depends on a plugin, then you should install that plugin. Either cordova plugin add org.apache.cordova.globalization or plugman install org.apache.cordova.globalization (not sure about the command line params there) should

Re: config.xml discussion, we need to talk

2013-10-21 Thread Braden Shepherdson
Less Magic (bin/create, Plugman) and More Magic (CLI).[1] Mike Billau's suggestions look decent to me. How about classic instead of legacy? Removes the it sucks and will die someday connotation, since that's not true. Braden On Mon, Oct 21, 2013 at 11:25 AM, Mike Billau mike.bil...@gmail.com

Re: config.xml discussion, we need to talk

2013-10-21 Thread Braden Shepherdson
Whoops, forgot my citation: [1] http://www.catb.org/jargon/html/magic-story.html On Mon, Oct 21, 2013 at 11:33 AM, Braden Shepherdson bra...@chromium.orgwrote: Less Magic (bin/create, Plugman) and More Magic (CLI).[1] Mike Billau's suggestions look decent to me. How about classic instead

Re: config.xml discussion, we need to talk

2013-10-21 Thread Mike Billau
Lets make the name as confusing as possible, to live up to our history (callback, phonegap, cordova.) ;) Personally I think that the names should try to describe the difference between the workflows instead of trying to prescribe some type of usage, since there are unknown and developing use

Re: Requisite Introduction

2013-10-21 Thread Joe Bowser
Yeah. I suspect that there's a WebView problem here that we can't do anything about because Samsung has its own modified version of the WebView. On Oct 21, 2013 8:28 AM, Andrew Grieve agri...@chromium.org wrote: Cool. One thing I would look at is whether Angular is using history.pushState /

Re: config.xml discussion, we need to talk

2013-10-21 Thread Joe Bowser
+1 for More Magic/Less Magic On Oct 21, 2013 8:34 AM, Braden Shepherdson bra...@chromium.org wrote: Less Magic (bin/create, Plugman) and More Magic (CLI).[1] Mike Billau's suggestions look decent to me. How about classic instead of legacy? Removes the it sucks and will die someday

RE: config.xml discussion, we need to talk

2013-10-21 Thread Michael Sierra
I've been meaning to catch up with this thread, and haven't had time to do it justice. My high-level takeaway so far is: doc must better clarify relative benefits of CLI vs. platform-level tooling. I've been revamping doc to try to address both workflows, so any lapses on that front are

Re: iOS only cordova-labs plugins (keyboard and statusbar, in plugins branch) - move to cordova-ios repo

2013-10-21 Thread Shazron
INFRA request filed: https://issues.apache.org/jira/browse/INFRA-6902 On Sat, Oct 19, 2013 at 3:36 PM, Brian LeRoux b...@brian.io wrote: Discreet repos do have value for discreet issue tracking IMO even when you use Jira. For example, feature branching is easier to reason about. /me shrugs

Brief Intro

2013-10-21 Thread 김형균 - Hyong Kim
Hello, I was feeling shy and dragging my feet for sending the brief intro to the list, but I wonder if this is truly a requirement for my pull-request to be considered / reviewed. I am based in Bay Area, CA and working on a mobile application targeting iOS and Android. We encountered an issue

Re: Brief Intro

2013-10-21 Thread Andrew Grieve
Thanks for contributing! Fixes like this make Cordova better. I'll have a look at your pull request follow up in your JIRA issue. On Mon, Oct 21, 2013 at 12:47 PM, 김형균 - Hyong Kim hyo...@gmail.com wrote: Hello, I was feeling shy and dragging my feet for sending the brief intro to the list,

Re: config.xml discussion, we need to talk

2013-10-21 Thread Brian LeRoux
I think we need to be explicit, not talk about legacy or magic. I'd like to propose: Native Platform Dev -- Build Cordova apps on the metal. No helpers for moving across platforms. Web Project Dev -- Build web first projects that (mostly) treats native projects as build artifacts. On Mon, Oct

Re: www/config.xml plugin dependencies

2013-10-21 Thread Axel Nennker
Yes. Currently we are adding plugin be hand. The problem is that we have a distributes developer team. So when the UI developers change something in www to require a plugin and merge that with master; then when the other developers pull master again the plugin is missing and the Application hangs.

Re: Review Request 14757: Cordova Plugin Registry Blog Post

2013-10-21 Thread Max Woghiren
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14757/#review27248 --- /www/_posts/2013-10-21-cordova-registry.md

Re: Review Request 14757: Cordova Plugin Registry Blog Post

2013-10-21 Thread Max Woghiren
On Oct. 21, 2013, 3:13 p.m., Michal Mocny wrote: /www/_posts/2013-10-21-cordova-registry.md, line 11 https://reviews.apache.org/r/14757/diff/1/?file=366404#file366404line11 s/what plugins/which plugins/ I believe what is correct here. Which is for when you're picking from a set

CommitterWorkflow

2013-10-21 Thread Josh Soref
Hi, I've reviewed http://wiki.apache.org/cordova/CommitterWorkflow and there doesn't seem to be much content on CLI workflow. I'm specifically looking for a process which explains how to start from nothing and download the latest git repos (how does one even figure out which git repos to

Re: Review Request 14757: Cordova Plugin Registry Blog Post

2013-10-21 Thread Max Woghiren
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14757/ --- (Updated Oct. 21, 2013, 6:04 p.m.) Review request for cordova. Repository:

Re: config.xml discussion, we need to talk

2013-10-21 Thread Michal Mocny
On Mon, Oct 21, 2013 at 1:35 PM, Brian LeRoux b...@brian.io wrote: I think we need to be explicit, not talk about legacy or magic. I'd like to propose: Native Platform Dev -- Build Cordova apps on the metal. No helpers for moving across platforms. Web Project Dev -- Build web first projects

Re: www/config.xml plugin dependencies

2013-10-21 Thread Michal Mocny
We've discussed adding dependancy to app's config.xml, but its interesting that you intend to have that work during build/prepare step. Previously I think this was discussed in terms of cordova create only, which wouldn't satisfy your use case. I think your use case is quite valid, but now im

Re: config.xml discussion, we need to talk

2013-10-21 Thread Ian Clelland
+1 -- I like both of those quite a lot On Mon, Oct 21, 2013 at 1:35 PM, Brian LeRoux b...@brian.io wrote: I think we need to be explicit, not talk about legacy or magic. I'd like to propose: Native Platform Dev -- Build Cordova apps on the metal. No helpers for moving across platforms.

Review Request 14793: CB-5125: replace child process exec with spawn

2013-10-21 Thread Carlos Santana
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14793/ --- Review request for cordova. Repository: cordova-cli Description ---

Re: Review Request 14793: CB-5125: replace child process exec with spawn

2013-10-21 Thread Steven Gill
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14793/#review27257 --- Haven't reviewed it yet, but wanted to make sure you remember to

Re: Review Request 14793: CB-5125: replace child process exec with spawn

2013-10-21 Thread Carlos Santana
On Oct. 21, 2013, 6:54 p.m., Steven Gill wrote: Haven't reviewed it yet, but wanted to make sure you remember to update all of the tests that spy on exec before pushing Thanks Steven good catch. Will start looking into that. - Carlos

Re: CommitterWorkflow

2013-10-21 Thread Andrew Grieve
Probably http://wiki.apache.org/cordova/WorkingWithThree is the best we've got. On Mon, Oct 21, 2013 at 1:53 PM, Josh Soref jso...@blackberry.com wrote: Hi, I've reviewed http://wiki.apache.org/cordova/CommitterWorkflow and there doesn't seem to be much content on CLI workflow. I'm

Re: Platforms Meet-up @ Waterloo

2013-10-21 Thread Andrew Grieve
Please tell me if this list is wrong: Attending: Joe, Shaz, Anis, Bryan Higgins, Gorkem, Carlos I'll start a private thread with all of you to exchange travel itinerary info contact info On Fri, Oct 18, 2013 at 12:51 PM, Andrew Grieve agri...@chromium.orgwrote: WOOOHOOO!! That's awesome!!!

Re: www/config.xml plugin dependencies

2013-10-21 Thread Axel Nennker
A MUST would be strong I think. Although the two ways don't mix well. Using dependency and plugin-add simultaneously is probably wrong. So plugin-add could look for www/config.xml dependency elements and suggest to continue to use them if one is found. If none is found then it adds the plugin.

Re: config.xml discussion, we need to talk

2013-10-21 Thread Axel Nennker
+1 Although I was about to suggest single platform development and multi platform development. Axel Am 21.10.2013 19:36 schrieb Brian LeRoux b...@brian.io: I think we need to be explicit, not talk about legacy or magic. I'd like to propose: Native Platform Dev -- Build Cordova apps on the

Re: config.xml discussion, we need to talk

2013-10-21 Thread Steven Gill
+1 to Native Platform Dev vs Web Project Dev On Mon, Oct 21, 2013 at 1:31 PM, Axel Nennker ignisvul...@gmail.com wrote: +1 Although I was about to suggest single platform development and multi platform development. Axel Am 21.10.2013 19:36 schrieb Brian LeRoux b...@brian.io: I think we

Code review of new ios plugins

2013-10-21 Thread Andrew Grieve
Hey Shaz, Looking at the Keyboard Statusbar plugins, would you be opposed to using: clobbers target=cordova.plugins.statusBar / instead of: clobbers target=window.StatusBar / Would require a major version bump, but probably it has little usage since it's new in labs still? Thinking here is

Re: Platforms Meet-up @ Waterloo

2013-10-21 Thread Jeffrey Heifetz
I'm not sure if I'll make it for the hacking, but I'm going to try and make it for the social event. On 13-10-21 4:12 PM, Andrew Grieve agri...@chromium.org wrote: Please tell me if this list is wrong: Attending: Joe, Shaz, Anis, Bryan Higgins, Gorkem, Carlos I'll start a private thread with

Re: build failure

2013-10-21 Thread Tim Kim
Hey David, I just uploaded a patch that should hopefully things for ya. Let me know if there are any more problems. On 18 October 2013 18:51, Tim Kim timki...@gmail.com wrote: Hrmmm. Shoot. Funny how a '.0' can paint you into a corner. I'm not sure if there are any easy solutions to this

Re: Platforms Meet-up @ Waterloo

2013-10-21 Thread Josh Soref
I'm probably attending too... - This transmission (including any attachments) may contain confidential information, privileged material (including material protected by the solicitor-client or other applicable privileges), or

Re: Platforms Meet-up @ Waterloo

2013-10-21 Thread Bryan Higgins
My cell is 416-435-5836. We will be driving in from Toronto. On Mon, Oct 21, 2013 at 4:44 PM, Josh Soref jso...@blackberry.com wrote: I'm probably attending too... - This transmission (including any attachments) may contain

Re: CommitterWorkflow

2013-10-21 Thread Marcel Kinard
The recent thread on the Native Platform dev vs Web Project dev workflows seems to have some application here. If the Apache Way is to distribute source (not saying it is a frequent way, but should be a supported way), then there isn't much documentation on how to get it up and running as Josh

Some plugin questions

2013-10-21 Thread Ray Camden
From the Cordova blog, there was an announcement of updated plugins (http://cordova.apache.org/news/2013/10/10/plugins-release.html), including one for Android WebSQL. The blog entry ends with: You can check out the individual release notes in each of the plugin repos for more details. But if

Re: www/config.xml plugin dependencies

2013-10-21 Thread Michal Mocny
Maybe we do just go the npm style route. cordova plugin add (without ID) - reads deps from config and installs them. cordova plugin add --save-deps ID - adds plugin and adds to config cordova plugin add --save-deps (without ID)- takes installed plugins and adds to deps something like that? On

Re: Intro Jerome

2013-10-21 Thread Marcel Kinard
Jerome, if you haven't seen it already, here is a good place to start: http://wiki.apache.org/cordova/ContributorWorkflow On Oct 19, 2013, at 3:06 PM, Jerome Schmaltz jerome.schma...@gmail.com wrote: Hi! My name is Jerome and it's my first experience as a committer for Apache. I've been

Re: Some plugin questions

2013-10-21 Thread Steven Gill
The answer to part 1 is that we are working on it. https://issues.apache.org/jira/browse/CB-5128 https://issues.apache.org/jira/browse/CB-5130 On Mon, Oct 21, 2013 at 2:12 PM, Ray Camden rayca...@adobe.com wrote: From the Cordova blog, there was an announcement of updated plugins

Re: CommitterWorkflow

2013-10-21 Thread Steven Gill
+1 On Mon, Oct 21, 2013 at 2:12 PM, Marcel Kinard cmarc...@gmail.com wrote: The recent thread on the Native Platform dev vs Web Project dev workflows seems to have some application here. If the Apache Way is to distribute source (not saying it is a frequent way, but should be a supported

The Cordova plugin registry blog post is up!

2013-10-21 Thread Max Woghiren
The Cordova plugin registry blog post (reviewed herehttps://reviews.apache.org/r/14757/) has been committed. I want to add a couple of things to the readme, but figured I'd check here first. 1. The generated html file (ie. /public/news//mm/dd/blog-post.html) needs to be svn added,

Re: The Cordova plugin registry blog post is up!

2013-10-21 Thread Steven Gill
Yes to both of your questions. 1) You need svn add the generated file. You should see a question mark when you do a svn status letting you know it hasn't been added. 2) The more tag is exactly what you use to handle the cutoff. I also learned this by looking at other posts. Would be a nice

Re: build failure

2013-10-21 Thread David Kemp
Looks like it fixed it! On Oct 21, 2013 4:40 PM, Tim Kim timki...@gmail.com wrote: Hey David, I just uploaded a patch that should hopefully things for ya. Let me know if there are any more problems. On 18 October 2013 18:51, Tim Kim timki...@gmail.com wrote: Hrmmm. Shoot. Funny how a

Re: build failure

2013-10-21 Thread Tim Kim
Woo! On 21 October 2013 15:59, David Kemp drk...@google.com wrote: Looks like it fixed it! On Oct 21, 2013 4:40 PM, Tim Kim timki...@gmail.com wrote: Hey David, I just uploaded a patch that should hopefully things for ya. Let me know if there are any more problems. On 18

Re: config.xml discussion, we need to talk

2013-10-21 Thread Wargo, John
Steven, of course, that is what I meant. Did you ever finish that review of my PhonegGap book? ;-) the next one will be out in a few weeks (hopefully). John M. Wargo On Oct 18, 2013, at 2:29 PM, Steven Gill stevengil...@gmail.com wrote: John: If you decided to take a stab a blogging

Re: Default template - size

2013-10-21 Thread Wargo, John
I brought this up with fil a while back and it's a documented issue in jira. He said config.xml had to be fixed to support different platform icons before something could be done about this. I can dig up the email and forward it off tomorrow. John M. Wargo On Oct 18, 2013, at 3:01 PM,

Re: config.xml discussion, we need to talk

2013-10-21 Thread Wargo, John
To plugman or not to plugman, that is the question. Or Different styles of plugin management. John M. Wargo On Oct 18, 2013, at 3:03 PM, Steven Gill stevengil...@gmail.com wrote: I think SinplePlatform vs MultiPlatform is misleading because you can use the CLI to do single platform

2.9.1 Backport release

2013-10-21 Thread Jesse
Having a tonne of fun putting the bunny back in the box. Here is a list of plugin defects [1] that have been closed between 2.9.0 and 3.1.0 Please have a look and decide if you think each is worth the effort of backporting. [1] https://issues.apache.org/jira/browse/CB-5136 @purplecabbage

Re: new meta data for plugin.xml

2013-10-21 Thread Brian LeRoux
Not so much an accident as very deliberate! When we started this is how you worked with JSON: var data = eval('' + my_json_string + '') We then had some fun w/ Crockford's JSON lib licensing. [1] Specifically IBM did not like the enforceability of The Software shall be used for Good, not Evil.

Re: 2.9.1 Backport release

2013-10-21 Thread Josh Soref
On 10/21/13 7:38 PM, Jesse purplecabb...@gmail.com wrote: Having a tonne of fun putting the bunny back in the box. Here is a list of plugin defects [1] that have been closed between 2.9.0 and 3.1.0 Please have a look and decide if you think each is worth the effort of backporting. [1]

Re: config.xml discussion, we need to talk

2013-10-21 Thread Wargo, John
Don't forget the short lived deviceReady! ;-) Most suggestions so far can't be easily understood at first glance. Legacy, merges, workflow and so on aren't words a reader is going to understand immediately when they look at the docs and decide if that is an article they want to read. We

RE: Some plugin questions

2013-10-21 Thread Dick Van den Brink
The websql plugin is in the cordova-labs repo. See https://github.com/apache/cordova-labs/tree/plugins/websql for details :) You are right, there are issues with websql on android! Sent from my Windows Phone From: Ray Camdenmailto:rayca...@adobe.com Sent:

Re: Code review of new ios plugins

2013-10-21 Thread Shazron
Answers inline. Looking at the Keyboard Statusbar plugins, would you be opposed to using: clobbers target=cordova.plugins.statusBar / instead of: clobbers target=window.StatusBar / Agreed. Would require a major version bump, but probably it has little usage since it's new in labs

Re: Code review of new ios plugins

2013-10-21 Thread Shazron
https://issues.apache.org/jira/browse/CB-5138 On Mon, Oct 21, 2013 at 5:10 PM, Shazron shaz...@gmail.com wrote: Answers inline. Looking at the Keyboard Statusbar plugins, would you be opposed to using: clobbers target=cordova.plugins.statusBar / instead of: clobbers

Re: new meta data for plugin.xml

2013-10-21 Thread Luke Holmquist
Thanks Brian. It's interesting to hear the history. Sent from my iPhone On Oct 21, 2013, at 7:45 PM, Brian LeRoux b...@brian.io wrote: Not so much an accident as very deliberate! When we started this is how you worked with JSON: var data = eval('' + my_json_string + '') We then

Cordova Issue Workflow

2013-10-21 Thread Josh Soref
Google https://www.google.ca/?q=cordova+issue+workflow tells me that there's a ContributorWorkflow: http://wiki.apache.org/cordova/ContributorWorkflow But: 1. Creating/finding an issue is buried in text in the middle of the About Commit Messages -- that can't possibly be where one creates or

Wiki permission

2013-10-21 Thread Josh Soref
Could someone please add JoshSoref to the list of accounts able to edit the wikiŠ - This transmission (including any attachments) may contain confidential information, privileged material (including material protected by the

update jasmine-node form 1.8.x to 1.11.x for cordova-cli?

2013-10-21 Thread Carlos Santana
I notice that there is a new version of jasmine-node 1.11.0 [1] I tested with 1.11.0 today and didn't find problems at the surface. It is OK to update the dependency to use the new version? [1] https://npmjs.org/package/jasmine-node -- Carlos Santana csantan...@gmail.com

Review Request 14822: CB-5125 add tests for chil process spawn

2013-10-21 Thread Carlos Santana
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14822/ --- Review request for cordova. Repository: cordova-cli Description ---

Re: Review Request 14793: CB-5125: replace child process exec with spawn

2013-10-21 Thread Carlos Santana
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/14793/#review27272 --- I added test cases here: https://reviews.apache.org/r/14822/ -