Re: Review Request 25818: Switch path::join() to be variadic

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25818/#review53945 --- Bad patch! Reviews applied: [25789, 25818] Failed command: make -j

Re: Review Request 25789: Variadic strings join for c++11 and above

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25789/#review53949 --- Mostly just style stuff, after a quick cleanup we'll get this commit

Re: Review Request 25798: Refactor Libprocess Help to reduce compile time.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25798/#review53951 --- 3rdparty/libprocess/include/process/help.hpp

Re: [VOTE] Release Apache Mesos 0.20.1 (rc3)

+1 make check on OSX 10.9.5, clang 3.5 (Xcode 6) ->all tests passed On Sep 19, 2014, at 3:03 AM, Vinod Kone wrote: > +1 (binding) > > sudo make check on CentOS 5.5 w/ gcc-4.8.2 > > On Thu, Sep 18, 2014 at 4:05 PM, Adam Bordelon wrote: > Hi all, > > Please vote on releasing the following can

Re: [VOTE] Release Apache Mesos 0.20.1 (rc3)

+1 (binding) On Friday, September 19, 2014, Till Toenshoff wrote: > +1 > > make check on OSX 10.9.5, clang 3.5 (Xcode 6) > ->all tests passed > > On Sep 19, 2014, at 3:03 AM, Vinod Kone > wrote: > > +1 (binding) > > sudo make check on CentOS 5.5 w/ gcc-4.8.2 > > On Thu, Sep 18, 2014 at 4:05 PM,

Re: Review Request 25818: Switch path::join() to be variadic

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25818/ --- (Updated Sept. 19, 2014, 4:08 p.m.) Review request for mesos and Benjamin Hindm

Re: [VOTE] Release Apache Mesos 0.20.1 (rc3)

+1 (binding) Make check on centos5 and centos6 (gcc48) On Thu, Sep 18, 2014 at 4:05 PM, Adam Bordelon wrote: > Hi all, > > Please vote on releasing the following candidate as Apache Mesos 0.20.1. > > > 0.20.1 includes the following: > > --

Re: Review Request 25818: Switch path::join() to be variadic

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25818/#review53965 --- Patch looks great! Reviews applied: [25789, 25818] All tests passe

Re: [VOTE] Release Apache Mesos 0.20.1 (rc3)

+1 (non-binding) Make check on Ubuntu 12.04 with gcc 4.6.3 On 19 September 2014 17:37, Tim Chen wrote: > +1 (non-binding) > > Make check on Centos 5.5, docker tests all passed too. > > Tim > > On Fri, Sep 19, 2014 at 9:17 AM, Jie Yu wrote: > >> +1 (binding) >> >> Make check on centos5 and cent

Re: Review Request 25448: Add std::unique_ptr and std::move checks to configure script

> On Sept. 18, 2014, 12:56 p.m., Cody Maloney wrote: > > m4/ax_cxx_compile_stdcxx_11.m4, line 76 > > > > > > It would be good to probably have an assert or two here to ensure the > > move worked. > > assert(!p2); >

Re: Review Request 25448: Add std::unique_ptr and std::move checks to configure script

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25448/ --- (Updated Sept. 19, 2014, 10:48 a.m.) Review request for mesos, Benjamin Hindman

Re: Review Request 25525: MESOS-1739: Allow slave reconfiguration on restart

> On Sept. 11, 2014, 9:53 p.m., Vinod Kone wrote: > > OK. I went through parts of this review but I have a bigger suggestion in > > mind, before I get too much into the weeds. > > > > I think it's worthwhile for you to write up a design doc similar to the > > framework info doc w.r.t. updating

Re: Review Request 25218: Updated a comment and some syntax formatting.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25218/#review53976 --- Ship it! Ben, I'll commit this for you. - Vinod Kone On Aug. 31,

Re: Review Request 25525: MESOS-1739: Allow slave reconfiguration on restart

> On Sept. 11, 2014, 9:53 p.m., Vinod Kone wrote: > > OK. I went through parts of this review but I have a bigger suggestion in > > mind, before I get too much into the weeds. > > > > I think it's worthwhile for you to write up a design doc similar to the > > framework info doc w.r.t. updating

Re: Review Request 25448: Add std::unique_ptr and std::move checks to configure script

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25448/#review53984 --- Patch looks great! Reviews applied: [25448] All tests passed. - M

Mesos Modules Design

Hi everyone, We have been iterating on a design for pluggable modules in Mesos lately and wanted to get a last round of feedback before putting out patch sets. Tim St Clair, Ben Hindman and I started the discussion (and work) on this subsystem https://issues.apache.org/jira/browse/MESOS-1224 and

Re: Review Request 25789: Variadic strings join for c++11 and above

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25789/ --- (Updated Sept. 19, 2014, 6:37 p.m.) Review request for mesos and Benjamin Hindm

Re: Review Request 25789: Variadic strings join for c++11 and above

> On Sept. 19, 2014, 10:25 a.m., Benjamin Hindman wrote: > > 3rdparty/libprocess/3rdparty/stout/include/stout/strings.hpp, line 205 > > > > > > At first I was expecting strings::join to just be variadic on > > std::st

Re: Review Request 25798: Refactor Libprocess Help to reduce compile time.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25798/ --- (Updated Sept. 19, 2014, 7:01 p.m.) Review request for mesos, Benjamin Hindman

Re: Review Request 25569: Refactor test environment validations

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25569/#review53993 --- src/tests/environment.cpp

Review Request 25844: Ignore terminal task resources in the Master's Framework struct.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25844/ --- Review request for mesos and Vinod Kone. Repository: mesos-git Description --

Review Request 25843: Fixed an executor accounting bug in framework re-registration.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25843/ --- Review request for mesos and Vinod Kone. Bugs: MESOS-1821 https://issues.ap

Re: Review Request 25843: Fixed an executor accounting bug in framework re-registration.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25843/#review54009 --- src/master/master.hpp

Re: Mesos Modules Design

I'm sorry, but I'm still having a hard time understanding why this needs to be dynamic. If the mesos core is split into modules that are built as standalone libraries (static) then at link time the right combination of libraries can be bundled together to create the end result. If you want to get

Re: Mesos Modules Design

The design was specifically tailored to allow non-modules to be used in lieu of modules. So nothing has to be reimplemented as a module. There may be some refactoring to abstract a class, though, but that’s usually a good idea anyway. On Sep 19, 2014, at 1:03 PM, Dominic Hamon wrote: > I'm sor

Re: Review Request 25798: Refactor Libprocess Help to reduce compile time.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25798/#review54017 --- Patch looks great! Reviews applied: [25789, 25798] All tests passe

Review Request 25847: Refactor Libprocess: class Node

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25847/ --- Review request for mesos and Niklas Nielsen. Repository: mesos-git Descriptio

Re: Review Request 25847: Refactor Libprocess: class Node

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25847/#review54018 --- 3rdparty/libprocess/include/process/node.hpp

Review Request 25848: Introducing mesos modules.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25848/ --- Review request for mesos, Benjamin Hindman, Bernd Mathiske, Niklas Nielsen, and

Re: Review Request 25844: Ignore terminal task resources in the Master's Framework struct.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25844/#review54020 --- Ship it! Ship It! - Vinod Kone On Sept. 19, 2014, 7:57 p.m., Ben

Re: Review Request 25848: Introducing mesos modules.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25848/ --- (Updated Sept. 19, 2014, 4:40 p.m.) Review request for mesos, Benjamin Hindman,

Re: Review Request 25847: Refactor Libprocess: class Node

> On Sept. 19, 2014, 8:32 p.m., Dominic Hamon wrote: > > 3rdparty/libprocess/include/process/node.hpp, line 32 > > > > > > uint64_t? > > > > start getting ipv6 support in... ;) Still won't fit in ipv6 though :

Re: Review Request 25847: Refactor Libprocess: class Node

> On Sept. 19, 2014, 8:32 p.m., Dominic Hamon wrote: > > 3rdparty/libprocess/include/process/node.hpp, line 32 > > > > > > uint64_t? > > > > start getting ipv6 support in... ;) > > Nikita Vetoshkin wrote: >

Re: Review Request 25847: Refactor Libprocess: class Node

> On Sept. 19, 2014, 1:32 p.m., Dominic Hamon wrote: > > 3rdparty/libprocess/include/process/node.hpp, line 32 > > > > > > uint64_t? > > > > start getting ipv6 support in... ;) > > Nikita Vetoshkin wrote: >

Re: Review Request 25843: Fixed an executor accounting bug in framework re-registration.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25843/#review54024 --- Ship it! src/master/master.cpp

Re: Review Request 25847: Refactor Libprocess: class Node

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25847/#review54030 --- Ship it! Can you motivate it a bit in context of eventually reworki

Re: Mesos Modules Design

inline - Original Message - > From: "Dominic Hamon" > To: "dev" > Sent: Friday, September 19, 2014 3:03:52 PM > Subject: Re: Mesos Modules Design > > I'm sorry, but I'm still having a hard time understanding why this needs to > be dynamic. > > If the mesos core is split into modules t

Re: Mesos Modules Design

Hi Dominic, (response inlined) On 19 September 2014 13:03, Dominic Hamon wrote: > I'm sorry, but I'm still having a hard time understanding why this needs to > be dynamic. > > If the mesos core is split into modules that are built as standalone > libraries (static) then at link time the right c

Re: Review Request 25843: Fixed an executor accounting bug in framework re-registration.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25843/#review54034 --- Patch looks great! Reviews applied: [25844, 25843] All tests passe

Re: Review Request 25847: Refactor Libprocess: class Node

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25847/ --- (Updated Sept. 19, 2014, 10:19 p.m.) Review request for mesos and Niklas Nielse

Re: Review Request 25569: Refactor test environment validations

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25569/ --- (Updated Sept. 19, 2014, 10:27 p.m.) Review request for mesos and Ben Mahler.

Re: Review Request 25819: post-reviews.py: use --no-color with git log.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25819/#review54042 --- Ship it! Thanks for updating the description on this one. - Ben Ma

Build failed in Jenkins: Mesos-Trunk-Ubuntu-Build-In-Src-Set-JAVA_HOME #2118

See Changes: [bmahler] Ignore terminal task resources in the Master's Framework struct. [bmahler] Fixed an executor accounting bug in framework re-registration. --

Re: Review Request 25848: Introducing mesos modules.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25848/#review54043 --- First pass src/examples/test_module.cpp

Build failed in Jenkins: Mesos-Trunk-Ubuntu-Build-In-Src-Set-JAVA_HOME #2119

See Changes: [bmahler] Fixed an issue with colored output in post-reviews.py. [niklas] Refactored Node class in libprocess. -- [...truncated 1055 lines...] checkin

Re: Review Request 25847: Refactor Libprocess: class Node

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25847/#review54050 --- Patch looks great! Reviews applied: [25847] All tests passed. - M

Re: Review Request 25569: Refactor test environment validations

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25569/#review54045 --- Thanks Tim, this is looking really nice! Appreciate the patience, j

Re: Review Request 25798: Refactor Libprocess Help to reduce compile time.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25798/#review54055 --- Ship it! LGTM (awaiting dependent patch to land) - Ben, any concern

Review Request 25858: Allowed co-mounted cgroup subsystems to enable Mesos on machines with systemd.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25858/ --- Review request for mesos, Ben Mahler, Ian Downes, Timothy St. Clair, and Vinod K

Re: Review Request 25785: Add guide to becoming a committer

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25785/#review54053 --- I think it's valuable to outline some guidelines for anybody interes

Review Request 25866: Updated the semantics of disconnected/deactivated semantics in master.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25866/ --- Review request for mesos, Adam B and Ben Mahler. Bugs: MESOS-1081 and MESOS-181

Review Request 25867: Updated ping message to embed the slave registered status.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25867/ --- Review request for mesos and Ben Mahler. Bugs: MESOS-1668 https://issues.ap

Re: Review Request 25569: Refactor test environment validations

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25569/#review54063 --- Patch looks great! Reviews applied: [25569] All tests passed. - M

Review Request 25868: Refactor Libprocess: class ProcessReference

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25868/ --- Review request for mesos and Niklas Nielsen. Repository: mesos-git Descriptio

Re: Review Request 25858: Allowed co-mounted cgroup subsystems to enable Mesos on machines with systemd.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25858/#review54070 --- Patch looks great! Reviews applied: [25858] All tests passed. - M

Re: Review Request 25866: Updated the semantics of disconnected/deactivated semantics in master.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25866/#review54072 --- Bad patch! Reviews applied: [25866] Failed command: git apply --in

Re: Review Request 25868: Refactor Libprocess: class ProcessReference

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/25868/#review54073 --- Patch looks great! Reviews applied: [25868] All tests passed. - M