ough additional overloads (possibly per operation to
> > cleanup the cruft in the Offer::Operation::LAUNCH case block below), but
> > one step at a time, a TODO for this latter part would be great :)
Left a TODO.
- Jie
-
t;
> > But obviously both work. Just mentioning what I've seen in the past.
Good idea! I used it.
- Jie
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.or
ned above for
Resources?
src/tests/slave_recovery_tests.cpp
<https://reviews.apache.org/r/29918/#comment113720>
Feel free to using google::protobuf::RepeatedPtrField in the begining.
src/tests/slave_recovery_tests.cpp
<https://reviews.apache.org/r/29918/#comment113723>
Add
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30149/#review69102
---
Ship it!
Ship It!
- Jie Yu
On Jan. 21, 2015, 11:52 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30148/#review69101
---
Ship it!
Thanks for the cleanup!
- Jie Yu
On Jan. 21, 2015, 11
adding this flag for
all os::open in our code base?
- Jie Yu
On Jan. 21, 2015, 10:43 p.m., Michael Park wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30145/#review69054
---
Ship it!
Ship It!
- Jie Yu
On Jan. 21, 2015, 10:25 p.m
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30144/#review69052
---
Ship it!
Ship It!
- Jie Yu
On Jan. 21, 2015, 10:25 p.m
e, and everywhere else.
- Jie Yu
On Jan. 21, 2015, 10:25 p.m., Michael Park wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.
e9dcca3c92c94f3123519855e238bcef47eeece9
src/tests/resource_offers_tests.cpp d098e7016ac0da7f1d629af099bb1b8fa66da839
Diff: https://reviews.apache.org/r/29976/diff/
Testing
---
make check
Thanks,
Jie Yu
ssage.isError()) {
return Error(message.error());
} else if (message.isNone()) {
break;
} else {
result.Add()->CopyFrom(message.get());
}
```
3rdparty/libprocess/3rdparty/stout/include/stout/protobuf.hpp
<https://reviews.apache.org/r/30111/#comment113612>
-4.4).
Sure. Added a NOTE in the code.
- Jie
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30140/#review69031
---
On Jan. 21, 201
/
Testing
---
make check using gcc-4.4.7
Thanks,
Jie Yu
> On Jan. 21, 2015, 6:16 p.m., Jie Yu wrote:
> > 3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp, line 300
> > <https://reviews.apache.org/r/30109/diff/1/?file=827850#file827850line300>
> >
> > Not your fault, but should we use:
> >
ease get the result from read and ASSERT_SOME on it.
```
Result> read = ::protobuf::read<...>(file);
ASSERT_SOME(read);
ASSERT_EQ(read.get().size(), size);
for (...) {
EXPECT_EQ(read.get().Get(i), actual.Get(i));
}
```
- Jie Yu
On Jan. 21, 201
' and kill the following two 'write's?
- Jie Yu
On Jan. 21, 2015, 10:19 a.m., Michael Park wrote:
>
> ---
> This is an automatically generated
e. Will follow up with a
cleanup.
- Jie
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29974/#review68890
---
On Jan.
827019#file827019line556>
> >
> > Any reason to not do this is a subsequent patch?
These tests are out of date because creating persistent volumes now needs to be
explicitly declared as an operation.
- Jie
---
This is
tps://reviews.apache.org/r/30109/#comment113487>
Not your fault, but should we use:
```S_IRUSR | S_IWUSR | S_IRGRP | S_IROTH```?
- Jie Yu
On Jan. 21, 2015, 10:18 a.m., Michael Park wrote:
>
> ---
> This is an automati
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/30108/#review68945
---
Ship it!
Ship It!
- Jie Yu
On Jan. 21, 2015, 10:16 a.m
,
Jie Yu
/tests/mesos.hpp 591134bab31da0a1cc224e332666d05f320d0f87
src/tests/resources_tests.cpp b7c1ddfda952f2d6b7f82e90cfe7b6b0aafbc36a
src/tests/sorter_tests.cpp 56e5714c2ab97d0ac81d29e1acb1fbec15471489
Diff: https://reviews.apache.org/r/30130/diff/
Testing
---
make check
Thanks,
Jie Yu
eviews.apache.org/r/29973/#review68814
-------
On Jan. 20, 2015, 6:49 p.m., Jie Yu wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29973/
> --
: mesos-git
Description
---
Style fixes for master.hpp.
Diffs
-
src/master/master.hpp a8ce4d023ddea36cb83a2dc7b95abd12342f345a
Diff: https://reviews.apache.org/r/30129/diff/
Testing
---
make check
Thanks,
Jie Yu
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29033/
> ---
>
> (Updated Jan. 20, 2015, 8:21 p.m.)
>
>
> Review request for mesos,
-
>
> (Updated Jan. 20, 2015, 8:21 p.m.)
>
>
> Review request for mesos, Dominic Hamon, Ian Downes, Jie Yu, and Cong Wang.
>
>
> Repository: mesos-git
>
>
> Description
> ---
>
> While we are sti
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29033/
> -------
>
> (Updated Jan. 20, 2015, 8:21 p.m.)
>
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29033/#review68779
---
Ship it!
- Jie Yu
On Jan. 20, 2015, 8:21 p.m., Chi Zhang wrote
mment113212>
Ditto.
src/tests/master_allocator_tests.cpp
<https://reviews.apache.org/r/29991/#comment113216>
Ditto.
src/tests/master_allocator_tests.cpp
<https://reviews.apache.org/r/29991/#comment113217>
Ditto.
- Jie
990/#comment113198>
Can we pull these to the top of this file?
src/tests/mesos.hpp
<https://reviews.apache.org/r/29990/#comment113208>
Haven't seen this being used.
- Jie Yu
On Jan. 16, 2015, 11:12 p.m.,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29989/#review68766
---
Ship it!
Ship It!
- Jie Yu
On Jan. 16, 2015, 11:12 p.m., Ben
e9dcca3c92c94f3123519855e238bcef47eeece9
src/tests/resource_offers_tests.cpp d098e7016ac0da7f1d629af099bb1b8fa66da839
Diff: https://reviews.apache.org/r/29976/diff/
Testing
---
make check
Thanks,
Jie Yu
Diff: https://reviews.apache.org/r/29975/diff/
Testing
---
make check
Thanks,
Jie Yu
/diff/
Testing
---
make check
Thanks,
Jie Yu
e9dcca3c92c94f3123519855e238bcef47eeece9
Diff: https://reviews.apache.org/r/29973/diff/
Testing
---
make check
Thanks,
Jie Yu
/rename.hpp
<https://reviews.apache.org/r/30081/#comment113163>
Use stdio.h
- Jie Yu
On Jan. 20, 2015, 6:08 p.m., Michael Park wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://re
framework lookup +
> > pid validation), thoughts?
Good idea. DOne!
- Jie
-----------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29973/#review68521
---
On Jan. 16, 2015, 7:23 p.m., Jie Yu wrote:
>
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29996/#review68525
---
Ship it!
Ship It!
- Jie Yu
On Jan. 16, 2015, 11:39 p.m., Ben
for containers
Done.
- Jie
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29896/#review68512
---
On Jan. 17, 2015, 12:41 a.m., Jie Yu wrote:
>
> -
/disk_quota_tests.cpp 4d23d97b5636bdc447c79e37b3b1b1402068b20e
Diff: https://reviews.apache.org/r/29895/diff/
Testing
---
make check
Thanks,
Jie Yu
/disk.cpp
fcadd780f9d417f7422080a03cfbfc2e4d15f1b3
src/slave/flags.hpp a4498e6573758642ed8ba28d6a1d228b91c4f2d4
src/tests/disk_quota_tests.cpp 4d23d97b5636bdc447c79e37b3b1b1402068b20e
Diff: https://reviews.apache.org/r/29896/diff/
Testing
---
make check
Thanks,
Jie Yu
/disk.cpp
fcadd780f9d417f7422080a03cfbfc2e4d15f1b3
src/slave/flags.hpp a4498e6573758642ed8ba28d6a1d228b91c4f2d4
src/tests/disk_quota_tests.cpp 4d23d97b5636bdc447c79e37b3b1b1402068b20e
Diff: https://reviews.apache.org/r/29896/diff/
Testing
---
make check
Thanks,
Jie Yu
/disk_quota_tests.cpp 4d23d97b5636bdc447c79e37b3b1b1402068b20e
Diff: https://reviews.apache.org/r/29895/diff/
Testing
---
make check
Thanks,
Jie Yu
t should be able to catch the kill of the task.
- Jie
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29896/#review68376
---
On Jan. 14, 2015, 8:53
eviews.apache.org/r/29895/diff/1/?file=821627#file821627line211>
> >
> > // NOTE: We can't pause the clock because we need the reaper to reap
> > the 'du' subprocess.
Added.
- Jie
---
This is an automatically
s.apache.org/r/29688/#review68314
---
On Jan. 14, 2015, 8:28 p.m., Jie Yu wrote:
>
> ---
> This is an automatically generated e-mail. To reply, v
d098e7016ac0da7f1d629af099bb1b8fa66da839
Diff: https://reviews.apache.org/r/29976/diff/
Testing
---
make check
Thanks,
Jie Yu
: mesos-git
Description
---
Added stream function for repeated protobuf messages.
Diffs
-
src/common/type_utils.hpp 2d22db85f87ec5c1134208aae5b2105d2d267000
Diff: https://reviews.apache.org/r/29974/diff/
Testing
---
make check
Thanks,
Jie Yu
check
Thanks,
Jie Yu
/
Testing
---
make check
Thanks,
Jie Yu
> On Jan. 15, 2015, 7:07 p.m., Jie Yu wrote:
> >
>
> Jie Yu wrote:
> Also, can you follow BenM's comment in r28809 and create a ticket to
> capture the TODO. I am wondering if we end up using two files to solve the
> TODO, what the interface should be? May
> On Jan. 15, 2015, 7:07 p.m., Jie Yu wrote:
> >
Also, can you follow BenM's comment in r28809 and create a ticket to capture
the TODO. I am wondering if we end up using two files to solve the TODO, what
the interface should be? Maybe we should call it state::update(path,
r
ts/slave_recovery_tests.cpp
<https://reviews.apache.org/r/29918/#comment112469>
That makes me feel that we should support repeated field for
protobuf::read. In that way, we could simplify the checkpoint function above as
well (instead of doing multiple writes, we can make it a single
commit this
patch first, and the subsequent patches will become more clear.
- Jie Yu
On Jan. 15, 2015, 5:19 a.m., Michael Park wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.
g/r/29911/#comment112449>
This fits in one line?
src/common/resources.cpp
<https://reviews.apache.org/r/29911/#comment112450>
Can you use ```_resources``` here?
- Jie Yu
On Jan. 15, 2015, 2:01 a.m., Michae
K is strange, given we're in a block defined by
> > `savedOffers.contains(offerId)` already.
Killed.
- Jie
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29870/#review68007
---
f1b8dfbb7391167b67a9498561742aa9ab9089a6
src/tests/disk_quota_tests.cpp PRE-CREATION
Diff: https://reviews.apache.org/r/29896/diff/
Testing
---
make check
Thanks,
Jie Yu
matically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29688/#review68113
-------
On Jan. 14, 2015, 8:28 p.m., Jie Yu wrote:
>
> ---
5007c0c58c5573ef19163c2c58cc3a7c5b555f46
src/slave/containerizer/isolators/posix/disk.hpp PRE-CREATION
src/slave/containerizer/isolators/posix/disk.cpp PRE-CREATION
src/tests/disk_quota_tests.cpp PRE-CREATION
Diff: https://reviews.apache.org/r/29895/diff/
Testing
---
make check
Thanks,
Jie Yu
Testing
---
make check
Thanks,
Jie Yu
Diff: https://reviews.apache.org/r/29690/diff/
Testing
---
make check
Thanks,
Jie Yu
fc0c3227466ccf364353a739fec8d9532ea3c683
src/tests/disk_quota_tests.cpp PRE-CREATION
Diff: https://reviews.apache.org/r/29689/diff/
Testing
---
make check
Thanks,
Jie Yu
tests.
- Jie
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29689/#review67745
---
On Jan. 12, 2015, 6:47 p.m
tors/posix/disk.cpp PRE-CREATION
src/slave/containerizer/mesos/containerizer.cpp
0bcf5ce7cfab470cabd3af3535344d19cb33b1c8
src/slave/flags.hpp f1b8dfbb7391167b67a9498561742aa9ab9089a6
Diff: https://reviews.apache.org/r/29688/diff/
Testing
---
make check
Thanks,
Jie Yu
---
Added three tuples overload for process::await.
Diffs
-
3rdparty/libprocess/include/process/collect.hpp
3bee8a6a0b7b48627ebc11c8b950b8582bba2c06
Diff: https://reviews.apache.org/r/29892/diff/
Testing
---
make check
Thanks,
Jie Yu
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29796/#review68069
---
Ship it!
Ship It!
- Jie Yu
On Jan. 14, 2015, 6:44 p.m., Ben
med the isolator as well.
> On Jan. 12, 2015, 11:11 p.m., Ben Mahler wrote:
> > src/slave/containerizer/isolators/disk_quota.cpp, lines 392-393
> > <https://reviews.apache.org/r/29688/diff/4/?file=816762#file816762line392>
> >
> > Can you implement this? The
The caller (the one call check(path)) should be able to print the path.
- Jie
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29688/#review67519
--------
g/r/29869/#comment112174>
Any reason keeps the scheduler:: namespace prefix?
- Jie Yu
On Jan. 14, 2015, 1:25 a.m., Ben Mahler wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.
rc/tests/port_mapping_tests.cpp
<https://reviews.apache.org/r/29033/#comment112126>
Is it guaranteed that the connective will be still active? If not, I would
rather not introduce those checks as it could cause flackyness.
- Jie Yu
On Jan. 9, 2015, 2:55 a.m., Chi Zhang wrote:
>
> ---
lso, using a
unified name 'call' makes it clear that it's for the new API.
src/master/master.cpp
<https://reviews.apache.org/r/29869/#comment112067>
I would suggest leaving empty with an Error message here. It'll be replaced
anyway.
src/scheduler/scheduler.cpp ff6ff115152c9278df6916fe9db432cbf127984e
Diff: https://reviews.apache.org/r/29870/diff/
Testing (updated)
---
will add tests to test accept offers later. Sadly, we don't have unit tests for
scheduler drivers.
make check passed
Thanks,
Jie Yu
ff6ff115152c9278df6916fe9db432cbf127984e
Diff: https://reviews.apache.org/r/29870/diff/
Testing
---
will add tests to test accept offers later. Sadly, we don't have unit tests for
scheduler drivers.
Thanks,
Jie Yu
; "acceptOffers is unimplemented";
> > error("acceptOffers is unimplemented");
> > ```
Done.
- Jie
---
This is an automatically generated e-mail. To reply, visit:
https://re
we can do it while we
are at other stuffs.
- Jie
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29822/#review67742
---
On Jan. 12, 20
generated e-mail. To reply, visit:
https://reviews.apache.org/r/29822/#review67737
---
On Jan. 12, 2015, 9:41 p.m., Jie Yu wrote:
>
> ---
> This is an automatically generat
---
make check
Thanks,
Jie Yu
Description
---
Style fixes for the scheduler header.
Diffs
-
include/mesos/scheduler.hpp 42e4e279d059801cd85955fd04995b60051a2b5e
Diff: https://reviews.apache.org/r/29822/diff/
Testing
---
make check
Thanks,
Jie Yu
r/29785/#comment111784>
since offer_ids is an Array, probably use:
offer_ids: [...]
- Jie Yu
On Jan. 12, 2015, 8:40 p.m., Ben Mahler wrote:
>
> ---
> This is an automatically generated e-mail. To repl
-mail. To reply, visit:
https://reviews.apache.org/r/29688/#review67519
-------
On Jan. 12, 2015, 6:46 p.m., Jie Yu wrote:
>
> ---
> This is an automatically generated e-
> On Jan. 9, 2015, 11:03 p.m., Jie Yu wrote:
> > include/mesos/mesos.proto, line 624
> > <https://reviews.apache.org/r/29785/diff/1/?file=815287#file815287line624>
> >
> > Why 'RESERVE', not 'RESERVE_RESOURCES'?
>
> Ben Mahler wrot
rizer/isolators/disk_quota.cpp PRE-CREATION
src/slave/containerizer/mesos/containerizer.cpp
5c014ebe360b9527b3edd505d47e57a4d5ce5c52
src/slave/flags.hpp f1b8dfbb7391167b67a9498561742aa9ab9089a6
Diff: https://reviews.apache.org/r/29688/diff/
Testing
---
make check
Thanks,
Jie Yu
fc0c3227466ccf364353a739fec8d9532ea3c683
src/tests/disk_quota_tests.cpp PRE-CREATION
Diff: https://reviews.apache.org/r/29689/diff/
Testing
---
make check
Thanks,
Jie Yu
/containerizer/isolators/cgroups/mem.cpp
71f4b9b3885ccb1c9e5ad589e65be06045030f19
src/slave/containerizer/mesos/containerizer.cpp
5c014ebe360b9527b3edd505d47e57a4d5ce5c52
Diff: https://reviews.apache.org/r/29815/diff/
Testing
---
make check
Thanks,
Jie Yu
gt;
maybe we should emphasize that the new master has no log?
- Jie Yu
On Jan. 10, 2015, 10:43 p.m., Ben Mahler wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
>
ssed seeing (3) from the next review, ignore.
In fact, on os x, both 1) and 2) are not true (just tested that).
- Jie
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29689/#review67263
---
785/#comment111584>
Why 'RESERVE', not 'RESERVE_RESOURCES'?
- Jie Yu
On Jan. 9, 2015, 10:56 p.m., Ben Mahler wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
&
-CREATION
Diff: https://reviews.apache.org/r/29690/diff/
Testing
---
make check
Thanks,
Jie Yu
fc0c3227466ccf364353a739fec8d9532ea3c683
src/tests/disk_quota_tests.cpp PRE-CREATION
Diff: https://reviews.apache.org/r/29689/diff/
Testing
---
make check
Thanks,
Jie Yu
t:
https://reviews.apache.org/r/29690/#review67283
-------
On Jan. 8, 2015, 12:45 a.m., Jie Yu wrote:
>
> ---
> This is an automatically generated e-
> On Jan. 8, 2015, 8:03 a.m., Timothy Chen wrote:
> > src/tests/disk_quota_tests.cpp, line 55
> > <https://reviews.apache.org/r/29689/diff/1/?file=810332#file810332line55>
> >
> > Why would this be less?
>
> Jie Yu wrote:
> This is a bit tric
/isolators/disk_quota.cpp PRE-CREATION
src/slave/containerizer/mesos/containerizer.cpp
5c014ebe360b9527b3edd505d47e57a4d5ce5c52
src/slave/flags.hpp f1b8dfbb7391167b67a9498561742aa9ab9089a6
Diff: https://reviews.apache.org/r/29688/diff/
Testing
---
make check
Thanks,
Jie Yu
is behavior
> > could be changed to be configurable so it should not be assumed in any
> > isolator.
>
> Jie Yu wrote:
> Since Limitation has already been set, there is no point continuing
> monitoring the disk usage, right? Anyway, we need to revisit this once we
&g
/isolators/disk_quota.cpp PRE-CREATION
src/slave/containerizer/mesos/containerizer.cpp
5c014ebe360b9527b3edd505d47e57a4d5ce5c52
src/slave/flags.hpp f1b8dfbb7391167b67a9498561742aa9ab9089a6
Diff: https://reviews.apache.org/r/29688/diff/
Testing
---
make check
Thanks,
Jie Yu
592182b21ae2700c627f180db38ca5dc1b3c9e8a
src/slave/state.cpp 9de381528fc320fbbfb662325a1275f0b457225b
Diff: https://reviews.apache.org/r/29687/diff/
Testing
---
make check
Thanks,
Jie Yu
tainer after the Limitation so it should wait until cleanup() before
> > stopping everything.
See above. I added TODO's here.
- Jie
---
This is an automatically generated e-mail. To reply, visit:
https
ique_ptr? :)
Used Owned.
- Jie
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29688/#review67239
---
On Jan. 8, 2015, 12:45 a.m., Jie Yu wrote:
>
> -
Choose not to expose it.
- Jie
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29688/#review67176
---
On Jan.
--------
On Jan. 8, 2015, 12:45 a.m., Jie Yu wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29688/
>
ps://reviews.apache.org/r/29687/#review67299
-----------
On Jan. 8, 2015, 12:44 a.m., Jie Yu wrote:
>
> ---
> This is an automatically generated e-mail.
701 - 800 of 2378 matches
Mail list logo
