[jira] Updated: (OFBIZ-3541) Using Widgets html form templates in FTL files

2010-04-06 Thread Jacques Le Roux (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-3541?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux updated OFBIZ-3541: --- Attachment: OFBIZ-3541 Using Widgets html form templates in FTL files.patch This last patch i

[jira] Created: (OFBIZ-3647) Create dataResource from content

2010-04-06 Thread nicolas malin (JIRA)
Create dataResource from content Key: OFBIZ-3647 URL: https://issues.apache.org/jira/browse/OFBIZ-3647 Project: OFBiz Issue Type: Improvement Components: content Affects Versions: SVN trunk

[jira] Updated: (OFBIZ-3647) Create dataResource from content

2010-04-06 Thread nicolas malin (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-3647?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] nicolas malin updated OFBIZ-3647: - Priority: Minor (was: Major) > Create dataResource from content > --

[jira] Updated: (OFBIZ-3647) Create dataResource from content

2010-04-06 Thread nicolas malin (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-3647?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] nicolas malin updated OFBIZ-3647: - Attachment: content.patch > Create dataResource from content > >

[jira] Closed: (OFBIZ-3640) Error screen in ap -> reports (Ofbiz demo)

2010-04-06 Thread Erwan de FERRIERES (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-3640?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Erwan de FERRIERES closed OFBIZ-3640. - Resolution: Fixed Done at rev 931045 Thanks ! > Error screen in ap -> reports (Ofbiz dem

[jira] Created: (OFBIZ-3648) german WorkeffortUiLabels translations

2010-04-06 Thread Mirko Vogelsmeier (JIRA)
german WorkeffortUiLabels translations -- Key: OFBIZ-3648 URL: https://issues.apache.org/jira/browse/OFBIZ-3648 Project: OFBiz Issue Type: Improvement Components: workeffort Affects Versions:

[jira] Updated: (OFBIZ-3648) german WorkeffortUiLabels translations

2010-04-06 Thread Mirko Vogelsmeier (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-3648?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mirko Vogelsmeier updated OFBIZ-3648: - Attachment: WorkEffortUiLabels.xml.patch Please use linux to apply the patch as otherwise

Re: squareFootage with decimals

2010-04-06 Thread Jacopo Cappellato
On Apr 3, 2010, at 6:59 PM, Ean Schuessler wrote: > I have a friend who's favorite business saying is "start out where you want > to end up". It is sort of a nonsense phrase but it says something similar to > "a stitch in time saves none". If we are clear about what we are trying to > build it

Preparing for the official 09.04 release

2010-04-06 Thread Jacopo Cappellato
We are mostly ready to vote the approval of the official release 09.04, the vote will probably start soon this week. In the meantime, please check the files (that will become our first official release) that I have prepared and placed in my home folder: http://people.apache.org/~jacopoc/dist/ I

Re: Preparing for the official 09.04 release

2010-04-06 Thread BJ Freeman
is there a list of requirements for apache official release? = BJ Freeman http://bjfreeman.elance.com Strategic Power Office with Supplier Automation Specialtymarket.com Sys

Re: svn commit: r930321 - /ofbiz/trunk/applications/order/entitydef/entitymodel.xml

2010-04-06 Thread Erwan de FERRIERES
Le 02/04/2010 18:47, doo...@apache.org a écrit : Author: doogie Date: Fri Apr 2 16:47:22 2010 New Revision: 930321 URL: http://svn.apache.org/viewvc?rev=930321&view=rev Log: Add OrderItem relation on OrderItemGroup. Modified: ofbiz/trunk/applications/order/entitydef/entitymodel.xml Modif

Re: svn commit: r931068 - /ofbiz/trunk/applications/accounting/config/AccountingUiLabels.xml

2010-04-06 Thread Nicolas Malin
I think the label AccountingNoRecordFound will become CommonNoRecordFound. It's a generic information. Erwan if you are ok, I change this label on all OFBiz. Nicolas er...@apache.org wrote: Author: erwan Date: Tue Apr 6 09:59:49 2010 New Revision: 931068 URL: http://svn.apache.org/viewvc?rev

Re: Preparing for the official 09.04 release

2010-04-06 Thread Jacopo Cappellato
http://www.apache.org/dev/release.html http://www.apache.org/dev/release-publishing.html Jacopo On Apr 6, 2010, at 12:07 PM, BJ Freeman wrote: > is there a list of requirements for apache official release? > > = > BJ Freeman > http://bjfreeman.elance.com > Strategic Powe

[jira] Commented: (OFBIZ-3333) Issues with EntitySync

2010-04-06 Thread Jacques Le Roux (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12853837#action_12853837 ] Jacques Le Roux commented on OFBIZ-: Here is aquote from a Deyan's message he s

[jira] Issue Comment Edited: (OFBIZ-3333) Issues with EntitySync

2010-04-06 Thread Jacques Le Roux (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12853837#action_12853837 ] Jacques Le Roux edited comment on OFBIZ- at 4/6/10 10:28 AM:

Re: svn commit: r931068 - /ofbiz/trunk/applications/accounting/config/AccountingUiLabels.xml

2010-04-06 Thread Erwan de FERRIERES
Le 06/04/2010 12:11, Nicolas Malin a écrit : I think the label AccountingNoRecordFound will become CommonNoRecordFound. It's a generic information. Erwan if you are ok, I change this label on all OFBiz. Nicolas Seems logical ! -- Erwan de FERRIERES www.nereide.biz

[jira] Updated: (OFBIZ-3555) Show lookup value descriptions

2010-04-06 Thread Bilgin Ibryam (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-3555?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bilgin Ibryam updated OFBIZ-3555: - Attachment: lookup_description.patch Made show/hide lookup description configurable from widget.p

[jira] Updated: (OFBIZ-3649) Accounting French traduction on invoiceType

2010-04-06 Thread nicolas malin (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-3649?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] nicolas malin updated OFBIZ-3649: - Attachment: accounting.patch > Accounting French traduction on invoiceType >

[jira] Created: (OFBIZ-3649) Accounting French traduction on invoiceType

2010-04-06 Thread nicolas malin (JIRA)
Accounting French traduction on invoiceType --- Key: OFBIZ-3649 URL: https://issues.apache.org/jira/browse/OFBIZ-3649 Project: OFBiz Issue Type: Improvement Components: accounting Affects

[jira] Updated: (OFBIZ-3555) Show lookup value descriptions

2010-04-06 Thread Bilgin Ibryam (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-3555?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bilgin Ibryam updated OFBIZ-3555: - Attachment: lookup_description.patch > Show lookup value descriptions > -

Re: Preparing for the official 09.04 release

2010-04-06 Thread Erwan de FERRIERES
Le 06/04/2010 11:43, Jacopo Cappellato a écrit : We are mostly ready to vote the approval of the official release 09.04, the vote will probably start soon this week. In the meantime, please check the files (that will become our first official release) that I have prepared and placed in my home

[jira] Assigned: (OFBIZ-3649) Accounting French traduction on invoiceType

2010-04-06 Thread Erwan de FERRIERES (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-3649?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Erwan de FERRIERES reassigned OFBIZ-3649: - Assignee: Erwan de FERRIERES > Accounting French traduction on invoiceType >

Re: Preparing for the official 09.04 release

2010-04-06 Thread Jacopo Cappellato
On Apr 6, 2010, at 2:46 PM, Erwan de FERRIERES wrote: > Le 06/04/2010 11:43, Jacopo Cappellato a écrit : >> We are mostly ready to vote the approval of the official release 09.04, the >> vote will probably start soon this week. >> In the meantime, please check the files (that will become our fir

Re: Preparing for the official 09.04 release

2010-04-06 Thread Erwan de FERRIERES
This is still the old one: 9.04 In fact 9.04 is still a release candidate and we want it to be an official release. The next step will be to create a new release candidate 10.04. Jacopo OK; thanks for the clarification ! -- Erwan de FERRIERES www.nereide.biz

[jira] Updated: (OFBIZ-3649) Accounting French traduction on invoiceType

2010-04-06 Thread nicolas malin (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-3649?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] nicolas malin updated OFBIZ-3649: - Attachment: (was: accounting.patch) > Accounting French traduction on invoiceType > -

[jira] Updated: (OFBIZ-3649) Accounting French traduction on invoiceType

2010-04-06 Thread nicolas malin (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-3649?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] nicolas malin updated OFBIZ-3649: - Attachment: accounting.patch Recreate patch, the old contains copy/paste error ;) > Accounting F

[jira] Commented: (OFBIZ-3541) Using Widgets html form templates in FTL files

2010-04-06 Thread Bilgin Ibryam (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-3541?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12853924#action_12853924 ] Bilgin Ibryam commented on OFBIZ-3541: -- Jacques, I applied your patch, browsed a litt

[jira] Closed: (OFBIZ-3649) Accounting French traduction on invoiceType

2010-04-06 Thread Erwan de FERRIERES (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-3649?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Erwan de FERRIERES closed OFBIZ-3649. - Resolution: Fixed Done at rev 931143 Thanks Nicolas > Accounting French traduction on in

Re: Preparing for the official 09.04 release

2010-04-06 Thread Matthieu Bollot
Le mardi 06 avril 2010 à 11:43 +0200, Jacopo Cappellato a écrit : > I would appreciate in particular any feedback on the following areas: > 1) are the file permissions, signatures, chacksums etc all correct? ok for zip, sha and md5 (didn't try other things) > 2) are you able to download and build t

Re: Preparing for the official 09.04 release

2010-04-06 Thread Jacopo Cappellato
Thank you Matthieu, I appreciate your feedback. Jacopo On Apr 6, 2010, at 3:19 PM, Matthieu Bollot wrote: > Le mardi 06 avril 2010 à 11:43 +0200, Jacopo Cappellato a écrit : >> I would appreciate in particular any feedback on the following areas: >> 1) are the file permissions, signatures, chack

Re: svn commit: r930321 - /ofbiz/trunk/applications/order/entitydef/entitymodel.xml

2010-04-06 Thread Adam Heath
Erwan de FERRIERES wrote: > Le 02/04/2010 18:47, doo...@apache.org a écrit : >> Author: doogie >> Date: Fri Apr 2 16:47:22 2010 >> New Revision: 930321 >> >> URL: http://svn.apache.org/viewvc?rev=930321&view=rev >> Log: >> Add OrderItem relation on OrderItemGroup. >> >> Modified: >> ofbiz/tru

[jira] Commented: (OFBIZ-3503) Content has a dependency on Person

2010-04-06 Thread Scott Gray (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-3503?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12854005#action_12854005 ] Scott Gray commented on OFBIZ-3503: --- I would like to close this as Invalid, the WebSiteRo

[jira] Assigned: (OFBIZ-3647) Create dataResource from content

2010-04-06 Thread Scott Gray (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-3647?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Scott Gray reassigned OFBIZ-3647: - Assignee: Scott Gray > Create dataResource from content > > >

[jira] Commented: (OFBIZ-3541) Using Widgets html form templates in FTL files

2010-04-06 Thread Jacques Le Roux (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-3541?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12854019#action_12854019 ] Jacques Le Roux commented on OFBIZ-3541: Thanks for the help Bilgin, This weekend,

Re: svn commit: r930737 - /ofbiz/trunk/framework/entity/src/org/ofbiz/entity/GenericDelegator.java

2010-04-06 Thread BJ Freeman
I use the commits update my 9.04. I also use the ml to check on what has been done when something goes south. I will try to look at the commits. I have about 15 projects I am trying to complete so I am rather busy. = BJ Freeman http://bjfreeman.elance.com Strategic Power Of

Re: svn commit: r931143 - /ofbiz/trunk/applications/accounting/config/AccountingEntityLabels.xml

2010-04-06 Thread Jacques Le Roux
Hi Erwan, Nicolas, I know Nicolas has a better accouting background than me, but are you sure of the translations below? For instance, I'm not quite sure of Return Additional Feature (caractéristiques additionnelles?) Return Discount (remise) Return Digital Good Item (produit numérique) Return F

Re: svn commit: r774627 - in /infrastructure/trunk/nagios/etc/asf: sys-contact.cfg vm-ofbiz.cfg

2010-04-06 Thread Jacques Le Roux
Hi Gavin, We get a lot of false alerts from Nagios. Could we not set the check_command from 5|10 to say 5|15? I suggest these numbers but I'm sure you have a far better understanding on them so please advice if needed. Thanks Jacques From: Author: gmcdonald Date: Sat Mar 27 05:46:01 2010 N

UserLogin.userLoginId primary key, why!?!?!

2010-04-06 Thread Adam Heath
Why oh why does the primary key for UserLogin get used as the actual username during login? This makes it *very* difficult for users to change their username. Even more confusing when the email address is used for login, but then the user changes their email address, and wants to change their log

Re: UserLogin.userLoginId primary key, why!?!?!

2010-04-06 Thread David E Jones
A couple of questions for you: 1. when a user "changes" their username what should happen with the old one? should it be available for another user to pick up? 2. should it be possible for a single person to have more than one username? -David On Apr 6, 2010, at 10:43 AM, Adam Heath wrote:

Re: UserLogin.userLoginId primary key, why!?!?!

2010-04-06 Thread Scott Gray
It can certainly make life difficult at times and I'd be in favor of the discussion continuing although I have no time to be very involved myself right now. Regards Scott HotWax Media http://www.hotwaxmedia.com On 6/04/2010, at 9:43 AM, Adam Heath wrote: > Why oh why does the primary key for

Re: UserLogin.userLoginId primary key, why!?!?!

2010-04-06 Thread Adrian Crum
I agree that it is inconvenient. Either solution will take a lot of work. -Adrian Adam Heath wrote: Why oh why does the primary key for UserLogin get used as the actual username during login? This makes it *very* difficult for users to change their username. Even more confusing when the email

Re: UserLogin.userLoginId primary key, why!?!?!

2010-04-06 Thread Adam Heath
David E Jones wrote: > A couple of questions for you: > > 1. when a user "changes" their username what should happen with the old one? > should it be available for another user to pick up? If username is disconnected from the item that maintains security, then old usernames won't exist at all, o

Re: UserLogin.userLoginId primary key, why!?!?!

2010-04-06 Thread Jacopo Cappellato
Wouldn't be easier to create a new UserLogin, associate it to the same Person and expire the old one? Jacopo On Apr 6, 2010, at 5:43 PM, Adam Heath wrote: > Why oh why does the primary key for UserLogin get used as the actual > username during login? This makes it *very* difficult for users t

Re: UserLogin.userLoginId primary key, why!?!?!

2010-04-06 Thread Ruth Hoffman
Hi Adam: I thought that was the idea behind having a PARTY entity and a partyId. When you use the PARTY as the unique user identifier, a user may have any number of user logins, email addresses etc. Regards, Ruth Adam Heath wrote: Why oh why does the primary key for UserLogin get used as the

Re: UserLogin.userLoginId primary key, why!?!?!

2010-04-06 Thread Adam Heath
Jacopo Cappellato wrote: > Wouldn't be easier to create a new UserLogin, associate it to the same Person > and expire the old one? No. Tons of entities have a createdByUserLogin, lastModifiedByUserLogin, there's UserLoginHistory, UserLoginSecurityGroup, etc. You'd have to modify *all* those ent

Re: UserLogin.userLoginId primary key, why!?!?!

2010-04-06 Thread Adam Heath
Ruth Hoffman wrote: > Hi Adam: > I thought that was the idea behind having a PARTY entity and a partyId. > When you use the PARTY as the unique user identifier, a user may have > any number of user logins, email addresses etc. But you can't reuse old logins for anyone else. And security is attach

Re: UserLogin.userLoginId primary key, why!?!?!

2010-04-06 Thread Nicolas Malin
I've the same idea. +1 Jacopo Cappellato wrote: Wouldn't be easier to create a new UserLogin, associate it to the same Person and expire the old one? Jacopo On Apr 6, 2010, at 5:43 PM, Adam Heath wrote: Why oh why does the primary key for UserLogin get used as the actual username during

[jira] Commented: (OFBIZ-3647) Create dataResource from content

2010-04-06 Thread Scott Gray (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-3647?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12854036#action_12854036 ] Scott Gray commented on OFBIZ-3647: --- Hi Nicolas, Thanks for the patch, here is my review

Re: UserLogin.userLoginId primary key, why!?!?!

2010-04-06 Thread Jacopo Cappellato
On Apr 6, 2010, at 5:56 PM, Adam Heath wrote: > Jacopo Cappellato wrote: >> Wouldn't be easier to create a new UserLogin, associate it to the same >> Person and expire the old one? > > No. Tons of entities have a createdByUserLogin, > lastModifiedByUserLogin, there's UserLoginHistory, > UserLo

Re: UserLogin.userLoginId primary key, why!?!?!

2010-04-06 Thread Jacopo Cappellato
On Apr 6, 2010, at 5:57 PM, Adam Heath wrote: > But you can't reuse old logins for anyone else. This requirement (reusing expired user logins for new parties) is the only reason (together with the realm thing mentioned in another way) I see for modifying the UserLogin entity. If this is what yo

Re: UserLogin.userLoginId primary key, why!?!?!

2010-04-06 Thread Scott Gray
On 6/04/2010, at 10:16 AM, Jacopo Cappellato wrote: > On Apr 6, 2010, at 5:57 PM, Adam Heath wrote: > >> But you can't reuse old logins for anyone else. > > This requirement (reusing expired user logins for new parties) is the only > reason (together with the realm thing mentioned in another wa

Re: UserLogin.userLoginId primary key, why!?!?!

2010-04-06 Thread BJ Freeman
once coded to do all that is not going to be hard. it would run up the cpu usage and database activity but on a dedicated server that should not be a problem. Plus I think it is good for audit to keep all the records synced to the current lognin BJ Freeman http://bjfreem

[jira] Created: (OFBIZ-3650) XHTML Validation - Form Widget with type= list|multi and separate-columns="true" renders bad markup

2010-04-06 Thread Blas Rodriguez Somoza (JIRA)
XHTML Validation - Form Widget with type= list|multi and separate-columns="true" renders bad markup --- Key: OFBIZ-3650 URL: https://issues.apache.org/jira/browse/OFBI

shoppingcart serialization, not shoppinglist

2010-04-06 Thread Adam Heath
Using a shoppinglist to save a cart is very poor form. You'll not be able to save shipgroup assignments, postal address per shipgroup, shipping method, virtual product features, payment settings, promo codes, tons of stuff. We need to be able to restore *all* these things. Saving the cart to an

Re: UserLogin.userLoginId primary key, why!?!?!

2010-04-06 Thread Adam Heath
BJ Freeman wrote: > once coded to do all that is not going to be hard. > it would run up the cpu usage and database activity but on a dedicated > server that should not be a problem. > > Plus I think it is good for audit to keep all the records synced to the > current lognin My recommendation wou

Re: UserLogin.userLoginId primary key, why!?!?!

2010-04-06 Thread Adam Heath
Jacopo Cappellato wrote: > On Apr 6, 2010, at 5:56 PM, Adam Heath wrote: > >> Jacopo Cappellato wrote: >>> Wouldn't be easier to create a new UserLogin, associate it to the same >>> Person and expire the old one? >> No. Tons of entities have a createdByUserLogin, >> lastModifiedByUserLogin, ther

Re: svn commit: r931222 - in /ofbiz/trunk/framework/webtools/webapp/webtools: WEB-INF/actions/artifactinfo/ArtifactInfo.groovy artifactinfo/ArtifactInfo.ftl

2010-04-06 Thread Adam Heath
lekt...@apache.org wrote: > Author: lektran > Date: Tue Apr 6 17:00:05 2010 > New Revision: 931222 > > URL: http://svn.apache.org/viewvc?rev=931222&view=rev > Log: > Store the ArtifactInfo's Recently Viewed Artifacts list in the session as > basic maps instead of ArtifactInfoBase objects that ar

Re: svn commit: r931222 - in /ofbiz/trunk/framework/webtools/webapp/webtools: WEB-INF/actions/artifactinfo/ArtifactInfo.groovy artifactinfo/ArtifactInfo.ftl

2010-04-06 Thread Adam Heath
lekt...@apache.org wrote: > -if (recentArtifactInfoList && > recentArtifactInfoList.get(0).equals(artifactInfo)) { > +if (recentArtifactInfoList && > recentArtifactInfoList.get(0).equals(artifactInfoMap)) { Same here, recentArtifactInfoList[0] == artifactInfoMap. Might be able to do foo

Re: svn commit: r931222 - in /ofbiz/trunk/framework/webtools/webapp/webtools: WEB-INF/actions/artifactinfo/ArtifactInfo.groovy artifactinfo/ArtifactInfo.ftl

2010-04-06 Thread Scott Gray
On 6/04/2010, at 11:04 AM, Adam Heath wrote: > lekt...@apache.org wrote: >> Author: lektran >> Date: Tue Apr 6 17:00:05 2010 >> New Revision: 931222 >> >> URL: http://svn.apache.org/viewvc?rev=931222&view=rev >> Log: >> Store the ArtifactInfo's Recently Viewed Artifacts list in the session as >

Re: svn commit: r931222 - in /ofbiz/trunk/framework/webtools/webapp/webtools: WEB-INF/actions/artifactinfo/ArtifactInfo.groovy artifactinfo/ArtifactInfo.ftl

2010-04-06 Thread Scott Gray
On 6/04/2010, at 11:05 AM, Adam Heath wrote: > lekt...@apache.org wrote: >> -if (recentArtifactInfoList && >> recentArtifactInfoList.get(0).equals(artifactInfo)) { >> +if (recentArtifactInfoList && >> recentArtifactInfoList.get(0).equals(artifactInfoMap)) { > > Same here, recentArtifact

Re: shoppingcart serialization, not shoppinglist

2010-04-06 Thread Robert Morley
Introducing a new type "CART" as an OrderType does not feel right to me. It would seem having an Order of type "SalesOrder" and being able to influence which functionality you wish to execute on that entity via its status (or additional attribute) might be work considering. We had a very

[jira] Created: (OFBIZ-3651) Minor tweaks to the Cobertura integration

2010-04-06 Thread Bob Morley (JIRA)
Minor tweaks to the Cobertura integration - Key: OFBIZ-3651 URL: https://issues.apache.org/jira/browse/OFBIZ-3651 Project: OFBiz Issue Type: Bug Components: framework Affects Versions: SV

[jira] Updated: (OFBIZ-3651) Minor tweaks to the Cobertura integration

2010-04-06 Thread Bob Morley (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-3651?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Bob Morley updated OFBIZ-3651: -- Attachment: OFBIZ-3651_CoberturaMinorEnhancements.patch > Minor tweaks to the Cobertura integration > -

Re: shoppingcart serialization, not shoppinglist

2010-04-06 Thread Adam Heath
Robert Morley wrote: > Introducing a new type "CART" as an OrderType does not feel right to > me. It would seem having an Order of type "SalesOrder" and being able > to influence which functionality you wish to execute on that entity via > its status (or additional attribute) might be work conside

Re: UserLogin.userLoginId primary key, why!?!?!

2010-04-06 Thread Jacopo Cappellato
On Apr 6, 2010, at 7:02 PM, Adam Heath wrote: > Jacopo Cappellato wrote: >> On Apr 6, 2010, at 5:56 PM, Adam Heath wrote: >> >>> Jacopo Cappellato wrote: Wouldn't be easier to create a new UserLogin, associate it to the same Person and expire the old one? >>> No. Tons of entities hav

Re: shoppingcart serialization, not shoppinglist

2010-04-06 Thread Adrian Crum
Adam Heath wrote: Using a shoppinglist to save a cart is very poor form. You'll not be able to save shipgroup assignments, postal address per shipgroup, shipping method, virtual product features, payment settings, promo codes, tons of stuff. We need to be able to restore *all* these things. W

Executing unit tests with Cobertura code coverage metrics

2010-04-06 Thread Bob Morley
Got this running this morning. Have created a minor set of tweaks as ticket OFBIZ-3651; if someone familiar with the Cobertura integration could review that would be helpful. If someone is trying to run these here are a few little pointers: - download Cobertura v1.9.3, drop the cobertura.jar in

Re: shoppingcart serialization, not shoppinglist

2010-04-06 Thread Adam Heath
Adrian Crum wrote: > Adam Heath wrote: >> Using a shoppinglist to save a cart is very poor form. You'll not be >> able to save shipgroup assignments, postal address per shipgroup, >> shipping method, virtual product features, payment settings, promo >> codes, tons of stuff. We need to be able to

Re: UserLogin.userLoginId primary key, why!?!?!

2010-04-06 Thread Adam Heath
Jacopo Cappellato wrote: > On Apr 6, 2010, at 7:02 PM, Adam Heath wrote: > >> Jacopo Cappellato wrote: >>> On Apr 6, 2010, at 5:56 PM, Adam Heath wrote: >>> Jacopo Cappellato wrote: > Wouldn't be easier to create a new UserLogin, associate it to the same > Person and expire the old o

Re: Executing unit tests with Cobertura code coverage metrics

2010-04-06 Thread Adam Heath
Bob Morley wrote: > Got this running this morning. Have created a minor set of tweaks as ticket > OFBIZ-3651; if someone familiar with the Cobertura integration could review > that would be helpful. > > If someone is trying to run these here are a few little pointers: > > - download Cobertura v1

Re: Executing unit tests with Cobertura code coverage metrics

2010-04-06 Thread Robert Morley
On Apr 6, 2010, at 1:50 PM, Adam Heath wrote: Bob Morley wrote: Here is my question -- when looking at the reports it showed 100% line code coverage in UtilValidate (for example) but this was for 111 lines. Clearly this class has many more lines than that, and when I opened it up I saw

Re: UserLogin.userLoginId primary key, why!?!?!

2010-04-06 Thread Jacopo Cappellato
On Apr 6, 2010, at 7:49 PM, Adam Heath wrote: > Jacopo Cappellato wrote: >> On Apr 6, 2010, at 7:02 PM, Adam Heath wrote: >> >>> Jacopo Cappellato wrote: On Apr 6, 2010, at 5:56 PM, Adam Heath wrote: > Jacopo Cappellato wrote: >> Wouldn't be easier to create a new UserLogin, a

Re: Executing unit tests with Cobertura code coverage metrics

2010-04-06 Thread Adrian Crum
Robert Morley wrote: Also, we were talking in the office -- our understanding is that the Cobertura license would restrict Ofbiz from redistribution, but it should be able to use it as part of their build process. Do you think there would be an issue include a target that downloads and deploys

Re: Executing unit tests with Cobertura code coverage metrics

2010-04-06 Thread Scott Gray
On 6/04/2010, at 11:59 AM, Robert Morley wrote: > > On Apr 6, 2010, at 1:50 PM, Adam Heath wrote: > >> Bob Morley wrote: >>> >>> Here is my question -- when looking at the reports it showed 100% line code >>> coverage in UtilValidate (for example) but this was for 111 lines. Clearly >>> this c

Re: [jira] Commented: (OFBIZ-3633) Minimum order quantity

2010-04-06 Thread Robert Morley
+1 for #3 - I think that follows the intended use from the data model On Apr 6, 2010, at 12:10 AM, Rishi Solanki (JIRA) wrote: [ https://issues.apache.org/jira/browse/OFBIZ-3633?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12853724 #action_12853724

[jira] Created: (OFBIZ-3652) Dutch labels patch

2010-04-06 Thread Willem Janssen (JIRA)
Dutch labels patch -- Key: OFBIZ-3652 URL: https://issues.apache.org/jira/browse/OFBIZ-3652 Project: OFBiz Issue Type: Improvement Components: ALL APPLICATIONS Affects Versions: SVN trunk Reporter: W

[jira] Updated: (OFBIZ-3652) Dutch labels patch

2010-04-06 Thread Willem Janssen (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-3652?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Willem Janssen updated OFBIZ-3652: -- Attachment: dutch_labels931244.diff > Dutch labels patch > -- > >

XHTML Validation status

2010-04-06 Thread Blas Rodriguez Somoza
Hello Thanks to those who review/commit patches related with XHTML validation (Adriam Crum, Bruno Busco and Jaques Le Roux) Although there are still 15 patches waiting to be reviewed/committed and probably I'll need to deliver 4 or 5 more, I think I've finished, more or less, the valid

Re: Executing unit tests with Cobertura code coverage metrics

2010-04-06 Thread Adam Heath
Robert Morley wrote: > > On Apr 6, 2010, at 1:50 PM, Adam Heath wrote: > >> Bob Morley wrote: >>> >>> Here is my question -- when looking at the reports it showed 100% >>> line code >>> coverage in UtilValidate (for example) but this was for 111 lines. >>> Clearly >>> this class has many more li

Re: Executing unit tests with Cobertura code coverage metrics

2010-04-06 Thread Adam Heath
Scott Gray wrote: > On 6/04/2010, at 11:59 AM, Robert Morley wrote: > >> On Apr 6, 2010, at 1:50 PM, Adam Heath wrote: >> >>> Bob Morley wrote: Here is my question -- when looking at the reports it showed 100% line code coverage in UtilValidate (for example) but this was for 111 lines.

Re: svn commit: r931143 - /ofbiz/trunk/applications/accounting/config/AccountingEntityLabels.xml

2010-04-06 Thread Nicolas Malin
Jacques Le Roux wrote: Hi Erwan, Nicolas, I know Nicolas has a better accouting background than me, but are you sure of the translations below? For instance, I'm not quite sure of Return Additional Feature (caractéristiques additionnelles?) Or "Retour option supplémentaire" Return Discount (

Re: svn commit: r931143 - /ofbiz/trunk/applications/accounting/config/AccountingEntityLabels.xml

2010-04-06 Thread Jacques Le Roux
- Original Message - From: "Nicolas Malin" To: Sent: Tuesday, April 06, 2010 9:26 PM Subject: Re: svn commit: r931143 - /ofbiz/trunk/applications/accounting/config/AccountingEntityLabels.xml Jacques Le Roux wrote: Hi Erwan, Nicolas, I know Nicolas has a better accouting backgrou

Re: Executing unit tests with Cobertura code coverage metrics

2010-04-06 Thread Jacques Le Roux
From: "Adrian Crum" Robert Morley wrote: Also, we were talking in the office -- our understanding is that the Cobertura license would restrict Ofbiz from redistribution, but it should be able to use it as part of their build process. Do you think there would be an issue include a target that

Re: shoppingcart serialization, not shoppinglist

2010-04-06 Thread Jacques Le Roux
From: "Adam Heath" Robert Morley wrote: Introducing a new type "CART" as an OrderType does not feel right to me. It would seem having an Order of type "SalesOrder" and being able to influence which functionality you wish to execute on that entity via its status (or additional attribute) might

[jira] Reopened: (OFBIZ-3649) Accounting French traduction on invoiceType

2010-04-06 Thread nicolas malin (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-3649?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] nicolas malin reopened OFBIZ-3649: -- Some label can have a better traduction > Accounting French traduction on invoiceType > --

[jira] Commented: (OFBIZ-3503) Content has a dependency on Person

2010-04-06 Thread Jacques Le Roux (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-3503?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12854159#action_12854159 ] Jacques Le Roux commented on OFBIZ-3503: Hi Scott, Yes I agree, why only removing

[jira] Updated: (OFBIZ-3649) Accounting French traduction on invoiceType

2010-04-06 Thread nicolas malin (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-3649?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] nicolas malin updated OFBIZ-3649: - Attachment: accounting.patch Change label after mail with Jacques. > Accounting French traductio

Re: Security Redesign and Release 10.x Branch

2010-04-06 Thread Anil Patel
I was thinking, Why not other way round. As I understand, we will not be able to use execution content features in other parts of Ofbiz in time for 10.4 release. If this is the case then additional code in release branch may add some new issues but will not add any benefits. Right? So IMO we

[jira] Closed: (OFBIZ-3649) Accounting French traduction on invoiceType

2010-04-06 Thread Jacques Le Roux (JIRA)
[ https://issues.apache.org/jira/browse/OFBIZ-3649?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jacques Le Roux closed OFBIZ-3649. -- Resolution: Fixed Thanks Nicolas, Your last patch is in trunk at r931326 > Accounting French

Re: Security Redesign and Release 10.x Branch

2010-04-06 Thread Adrian Crum
Anil Patel wrote: I was thinking, Why not other way round. As I understand, we will not be able to use execution content features in other parts of Ofbiz in time for 10.4 release. If this is the case then additional code in release branch may add some new issues but will not add any benefits. Ri

Re: Security Redesign and Release 10.x Branch

2010-04-06 Thread Scott Gray
On 6/04/2010, at 3:03 PM, Adrian Crum wrote: > Anil Patel wrote: >> I was thinking, Why not other way round. As I understand, we will not be >> able to use execution content features in other parts of Ofbiz in time for >> 10.4 release. If this is the case then additional code in release branch m

Re: Security Redesign and Release 10.x Branch

2010-04-06 Thread Anil Patel
I am really not against merging executioncontext branch with trunk. I don't see reason to include it in upcoming release branch if we will not be using it. And yes, even though Webslinger is not a good examples we can still say that, decision put it in trunk was made too early, but its just me.

Re: Security Redesign and Release 10.x Branch

2010-04-06 Thread Tim Ruppert
Inline Cheers, Ruppert On Apr 6, 2010, at 3:47 PM, Anil Patel wrote: > I am really not against merging executioncontext branch with trunk. I don't > see reason to include it in upcoming release branch if we will not be using > it. +1 - I was writing an email explaining the same thing. > An

Re: Security Redesign and Release 10.x Branch

2010-04-06 Thread Adrian Crum
Scott Gray wrote: On 6/04/2010, at 3:03 PM, Adrian Crum wrote: Anil Patel wrote: I was thinking, Why not other way round. As I understand, we will not be able to use execution content features in other parts of Ofbiz in time for 10.4 release. If this is the case then additional code in release

Re: Security Redesign and Release 10.x Branch

2010-04-06 Thread Scott Gray
On 6/04/2010, at 4:03 PM, Adrian Crum wrote: > Scott Gray wrote: >> On 6/04/2010, at 3:03 PM, Adrian Crum wrote: >>> Anil Patel wrote: I was thinking, Why not other way round. As I understand, we will not be able to use execution content features in other parts of Ofbiz in time for >>>

Re: Security Redesign and Release 10.x Branch

2010-04-06 Thread Adrian Crum
Scott Gray wrote: On 6/04/2010, at 4:03 PM, Adrian Crum wrote: Scott Gray wrote: On 6/04/2010, at 3:03 PM, Adrian Crum wrote: Anil Patel wrote: I was thinking, Why not other way round. As I understand, we will not be able to use execution content features in other parts of Ofbiz in time for 1

Re: Security Redesign and Release 10.x Branch

2010-04-06 Thread Scott Gray
On 6/04/2010, at 4:23 PM, Adrian Crum wrote: > Scott Gray wrote: >> On 6/04/2010, at 4:03 PM, Adrian Crum wrote: >>> Scott Gray wrote: On 6/04/2010, at 3:03 PM, Adrian Crum wrote: > Anil Patel wrote: >> I was thinking, Why not other way round. As I understand, we will not be >> a

Re: Security Redesign and Release 10.x Branch

2010-04-06 Thread Adrian Crum
Scott Gray wrote: On 6/04/2010, at 4:23 PM, Adrian Crum wrote: Scott Gray wrote: On 6/04/2010, at 4:03 PM, Adrian Crum wrote: Scott Gray wrote: On 6/04/2010, at 3:03 PM, Adrian Crum wrote: Anil Patel wrote: I was thinking, Why not other way round. As I understand, we will not be able to use

Re: Security Redesign and Release 10.x Branch

2010-04-06 Thread Scott Gray
On 6/04/2010, at 4:48 PM, Adrian Crum wrote: > Scott Gray wrote: >> On 6/04/2010, at 4:23 PM, Adrian Crum wrote: >>> Scott Gray wrote: On 6/04/2010, at 4:03 PM, Adrian Crum wrote: > Scott Gray wrote: >> On 6/04/2010, at 3:03 PM, Adrian Crum wrote: >>> Anil Patel wrote: I

Re: Security Redesign and Release 10.x Branch

2010-04-06 Thread Adam Heath
Adrian Crum wrote: > Anil Patel wrote: >> I was thinking, Why not other way round. >> As I understand, we will not be able to use execution content features >> in other parts of Ofbiz in time for 10.4 release. If this is the case >> then additional code in release branch may add some new issues but

  1   2   >