Re: Review Request 21615: Multi-Thread CAS-Crawler

2014-05-22 Thread brian Foster
reviews.apache.org/r/21615/#review43328 ------- On May 18, 2014, 7:37 p.m., brian Foster wrote: > > --- > This is an automatically generated e-mail. To re

Review Request 21615: Multi-Thread CAS-Crawler

2014-05-18 Thread brian Foster
PRE-CREATION trunk/crawler/src/main/java/org/apache/oodt/cas/crawl/config/ProductCrawlerBean.java 1590893 trunk/crawler/src/main/resources/cmd-line-options.xml 1590893 Diff: https://reviews.apache.org/r/21615/diff/ Testing --- Thanks, brian Foster

Re: svn commit: r1591965 - in /oodt/trunk/filemgr/src: main/java/org/apache/oodt/cas/filemgr/metadata/extractors/examples/DateTimeExpandMetExtractor.java test/org/apache/oodt/cas/filemgr/metadata/extr

2014-05-02 Thread Brian Foster
.oodt.cas.metadata.util.PathUtils;        >+        >+// Google imports        >+import com.google.common.base.Strings;        >+        >+/**        >+ * Expands a given metadata date time field out into multiple metadata        >fields (i.e. year, month,        >+ * day, hour, min

Review Request 18727: Implementation of DataTransferer which stores files in Amazon S3

2014-03-04 Thread brian Foster
Description --- Implementation of DataTransferer which stores files in Amazon S3 Diffs - Diff: https://reviews.apache.org/r/18727/diff/ Testing --- Unit-tests Thanks, brian Foster

Re: Review Request 18727: Implementation of DataTransferer which stores files in Amazon S3

2014-03-04 Thread brian Foster
://reviews.apache.org/r/18727/diff/ Testing --- Unit-tests Thanks, brian Foster

Re: PushPull DaemonLauncher

2013-12-03 Thread Brian Foster
s on this I would love to hear about it. I am also not an expert on Java Threads, so I could have missed something in the code, but it seems like the Thread is started and never terminated. Thanks for reading,Cameron On Thu, Nov 21, 2013 at 1:43 PM, Brian Foster <holeno...@me.com> wrot

Re: PushPull DaemonLauncher

2013-11-21 Thread Brian Foster
Hey Jordan,Try not specifying the element for your daemons in RemoteSpecs.xml file.  It should just run once through for those sites.  I believe the pushpull shuts down automatically when all deamons have terminated, so after you run one pass it should just terminate.  It's been a while since i've

Re: Maven dynamic libraries?

2013-05-21 Thread Brian Foster
I would talk to the PEATE folks... i wrote an HDF5 extractor in C++ when i was working there and just used ExternMetadataExtractor to run it.-brianOn May 12, 2013, at 11:41 AM, "Mattmann, Chris A (398J)" wrote:Hey Viv, This is possible but you need to bake somewhere into your code where you load

Re: New list ?

2013-05-01 Thread Brian Foster
I think this is solvable with a filter... however i could see a case where someone might only cared about following JIRA issues and didn't want all the svn commits flooding their inbox... so i guess that makes me a +1-brianOn May 01, 2013, at 07:25 AM, "Mattmann, Chris A (398J)" wrote:I'm +0 on th

Re: Environment Variables in OODT

2013-01-15 Thread Brian Foster
hey michael, System.getenv() didn't exist in jdk 1.4 when the code was initially written and System.getenv(String) was deprecated in jdk 1.4... i believe it was rewritten and undeprecated in jdk 1.5 and System.getenv() was added... so ya it probably should be using System.getenv()... a patch w

Re: Review Request: Purposed Changes to Workflow, WorkflowInstance, and WorkflowProcessor

2012-11-08 Thread brian Foster
k/workflow/src/main/java/org/apache/oodt/cas/workflow/structs/WorkflowInstance.java 1399095 trunk/workflow/src/main/java/org/apache/oodt/cas/workflow/structs/WorkflowInstanceStub.java PRE-CREATION Diff: https://reviews.apache.org/r/7944/diff/ Testing --- Thanks, brian Foster

Re: Workflow Task/Condition Instances...

2012-11-08 Thread Brian Foster
ply creating a RunnableInstance >> and think it fits the architecture well! >> +50 to proceed down that path. >> >> Cheers, >> Chris >> >> On Nov 8, 2012, at 3:16 PM, Brian Foster wrote: >> >>> >>> hey chris, >>> >

Review Request: Purposed Changes to Workflow, WorkflowInstance, and WorkflowProcessor

2012-11-08 Thread brian Foster
ow/structs/WorkflowInstance.java 1399095 Diff: https://reviews.apache.org/r/7944/diff/ Testing --- Thanks, brian Foster

Re: Workflow Task/Condition Instances...

2012-11-07 Thread Brian Foster
hey chris, i got the initial changes to Workflow, WorkflowInstance, and WorkflowProcessor in... https://reviews.apache.org/r/7944/ ... let me know what you think... lol -brian On Nov 7, 2012, at 6:16 PM, Brian Foster wrote: > > hey chris, > > I think i work this out... i'

Re: Workflow Task/Condition Instances...

2012-11-07 Thread Brian Foster
hey chris, I think i work this out... i'm gonna create a RunnableInstance class... this will then hold the state, start/end times, type (TASK or CONDITION), and the class to run (WorkflowTaskInstance or WorkflowConditionInstance). -brian On Nov 7, 2012, at 3:05 PM, Brian Foster wrote:

Workflow Task/Condition Instances...

2012-11-07 Thread Brian Foster
hey chris, so i'm going through this WorkflowProcessor stuff and finishing it up... I'm trying to make it so that WorkflowProcessor is used by all Workflow Engines... WorkflowInstance holds the state, times, etc.. for a Workflow, and then a WorkflowProcessor is response for analyzing that Workf

Re: [oodt-dev] Workflow Manager in wengine-branch chews up CPU

2012-10-25 Thread Brian Foster
just put a configurable wait seconds between handling each workflow so the thread doesn't run amuck... we really just need to add "dirty" workflow concept... never got a chance when working on wengine-brianOn Oct 25, 2012, at 02:19 PM, "Mattmann, Chris A (388J)" wrote:Hey Sean, (CC'ing dev@oodt.a

Re: 1100+ Javadoc Warnings...

2012-08-24 Thread Brian Foster
va > (working > copy) > @@ -17,7 +17,7 @@ > package org.apache.oodt.cas.cli.option; > > /** > - * {@link CmdLineOption} for specifying {@link CmdLineAction}. > *+ * {@link CmdLineOption} for specifying {@link > org.apache.oodt.cas.cli.action.CmdLineAction}.* > * > * @author

Re: Question about how to assign a port number to its protocol in pushpull

2012-08-08 Thread Brian Foster
> > Cheers, > Chris > > On Aug 6, 2012, at 11:15 AM, Brian Foster wrote: > >> >> yunhee, >> >> let actually make the property name: >> >> org.apache.oodt.cas.protocol.jsch.sftp.port >> >> what you think chris? >> >

Re: Review Request: Synchronous and Asynchronous LocalEngineRunnerFactory

2012-08-07 Thread brian Foster
i'll check it in today - brian Foster On Aug. 7, 2012, 3:36 a.m., Sheryl John wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://rev

Review Request: Factory out EngineRunner and WorkflowProcessor classes into their own packages

2012-08-07 Thread brian Foster
://reviews.apache.org/r/6407/diff/ Testing --- ran unit-tests Thanks, brian Foster

Re: Review Request: EngineRunnerFactory introduction and Java property cleanup

2012-08-06 Thread brian Foster
we should change this to 9001 done! - brian --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/6357/#review9844 --- On Aug.

Re: Jenkins build became unstable: oodt-trunk #581

2012-08-06 Thread Brian Foster
 oops... fixing...-brianOn Aug 06, 2012, at 12:30 PM, Apache Jenkins Server wrote:See

Re: Question about how to assign a port number to its protocol in pushpull

2012-08-06 Thread Brian Foster
yunhee,let actually make the property name:org.apache.oodt.cas.protocol.jsch.sftp.portwhat you think chris?-brianOn Aug 06, 2012, at 10:52 AM, Brian Foster wrote:hey yunhee,like chris said i would use the java properties he defined and modify the following class to set port to it by default to

Re: Question about how to assign a port number to its protocol in pushpull

2012-08-06 Thread Brian Foster
hey yunhee,like chris said i would use the java properties he defined and modify the following class to set port to it by default to it:https://svn.apache.org/repos/asf/oodt/trunk/protocol/sftp/src/main/java/org/apache/oodt/cas/protocol/sftp/JschSftpProtocolFactory.javayour change would probably lo

Re: The problem occurred when downloading a file by using a protocol "sftp" in pushpull

2012-08-06 Thread Brian Foster
hey yunhee and chris,we DON'T want to turn that off!... you need to connect to the site either using command-line sftp or something similar so you can accept adding the sftp site to your known hosts file... sftp protocol is working correctly-brianOn Aug 06, 2012, at 01:28 AM, YunHee Kang wrote:Hi

Re: Review Request: EngineRunnerFactory introduction and Java property cleanup

2012-08-03 Thread brian Foster
/workflow/src/main/java/org/apache/oodt/cas/workflow/util/GenericWorkflowObjectFactory.java 1369233 Diff: https://reviews.apache.org/r/6357/diff/ Testing --- Thanks, brian Foster

Re: Review Request: EngineRunnerFactory introduction and Java property cleanup

2012-08-03 Thread brian Foster
/java/org/apache/oodt/cas/workflow/system/XmlRpcWorkflowManager.java 1369233 trunk/workflow/src/main/java/org/apache/oodt/cas/workflow/util/GenericWorkflowObjectFactory.java 1369233 Diff: https://reviews.apache.org/r/6357/diff/ Testing --- Thanks, brian Foster

Review Request: EngineFactory introduction and Java property cleanup

2012-08-03 Thread brian Foster
/GenericWorkflowObjectFactory.java 1369233 Diff: https://reviews.apache.org/r/6357/diff/ Testing --- Thanks, brian Foster

Re: Question about metadata specification for Filemgr and Pushpull

2012-08-02 Thread Brian Foster
cataloging mentioned above. Thanks, Yunhee On 8/2/12 6:29 AM, "Brian Foster" <holeno...@me.com> wrote: > >hey YunHee, > >I've submitted the patch, so you can instead of having to patch the code >you can just resync your pushpull code and rebuild it and swap the j

Review Request: CAS-Pushpull uniqueMetadataElement is being loaded as empty String instead of null

2012-08-01 Thread brian Foster
sting --- Ran download with config provided by YunHee Thanks, brian Foster

Re: Question about metadata specification for Filemgr and Pushpull

2012-08-01 Thread Brian Foster
hey YunHee, I've submitted the patch, so you can instead of having to patch the code you can just resync your pushpull code and rebuild it and swap the jar out in your deployment -brian On Aug 1, 2012, at 8:28 AM, YunHee Kang wrote: > Hi Chris and Brian, > > I am reading source codes for ha

Re: Question about metadata specification for Filemgr and Pushpull

2012-08-01 Thread Brian Foster
Hey YunHee, Okay, found another bug... lol... you're on a roll dude! I've attached the fix to issue: https://issues.apache.org/jira/browse/OODT-481 Just patch the fix into the trunk pushpull and download with communication to filemgr should work now. -brian On Aug 1, 2012, at 8:28 AM, YunHe

Fwd: Problem when running pushpull

2012-07-29 Thread Brian Foster
hey YunHee, I keep forgetting to add you to the email cc... are you on the dev list?... see email below, explains your commented out filemgr url making the pushpull work -brian Begin forwarded message: > From: Brian Foster > Date: July 29, 2012 10:12:48 AM PDT > To: "dev@o

Re: Problem when running pushpull

2012-07-29 Thread Brian Foster
ocol > Jul 29, 2012 10:09:30 PM org.apache.oodt.cas.pushpull.daemon.Daemon sleep > INFO: Daemon with ID = 90121 on RMI registry port 9012 is going to > sleep until Sun Jul 29 22:12:00 KST 2012 > > Please let me know how to fix this problem. > > Thanks, > Yunhee > > &

Re: Review Request: RemoteSiteFile doesn't always set RemoteSite

2012-07-27 Thread brian Foster
guava 10.0.1 - brian --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/6166/#review9525 --- On July 27, 2012, 12:1

Re: Problem when running pushpull

2012-07-27 Thread Brian Foster
File(fromFile.getName(), os); > 2)if (ftp.retrieveFile(fromFile.getName(), os))// { > throw new ProtocolException("Failed to download file " > + fromFile.getName()); > // } > > Will you let me know if the method get() in the > CommonsNetFtpProto

Review Request: RemoteSiteFile doesn't always set RemoteSite

2012-07-26 Thread brian Foster
provided by YunHee Thanks, brian Foster

Re: Review Request: RemoteSiteFile doesn't always set RemoteSite

2012-07-26 Thread brian Foster
/retrievalsystem/RetrievalSetup.java 1365306 Diff: https://reviews.apache.org/r/6166/diff/ Testing --- Ran test provided by YunHee Thanks, brian Foster

Re: Problem when running pushpull

2012-07-26 Thread Brian Foster
Haha... Wow... Just put a ! in the if statement below... Lol... and I'll file a bug and fix it tomorrow... It's throwing an exception on success... oops... Lol -Brian On Jul 26, 2012, at 5:38 PM, Brian Foster wrote: > Hey YunHee, > > Okay the latest patch attached to th

Re: Problem when running pushpull

2012-07-26 Thread Brian Foster
ndling ftp protocol ? I used "CommonsNetFtpProtocolFactory.class" in the jar named "cas-protocol-ftp-0.4.jar". The class file was described in the file ProtocolFactoryInfo.xml as follows: class="org.apache.oodt.cas.protocol.ftp.CommonsNetFtpProtocolFactory"/

Fwd: Problem when running pushpull

2012-07-26 Thread Brian Foster
hey Yunhee,i just realized that your probably not on the dev list and my last email just went to the list and didn't have you cc'edtry the patch attached to this issue mentioned below...-brianBegin forwarded message:From: Brian Foster Date: July 25, 2012 12:43:10 AMTo: dev@oodt.apac

Re: Problem when running pushpull

2012-07-25 Thread Brian Foster
8) at java.lang.Thread.run(Thread.java:662) Please let me know what java programs I check frist. Thanks, Yunhee 2012/7/25 Brian Foster <holeno...@mac.com>: > YunHee, > > There is a NullPointerException being thrown... on line 118 of > org.apache.oodt.cas.pushpull.retrievalsystem.Retrie

Re: Problem when running pushpull

2012-07-24 Thread Brian Foster
YunHee,There is a NullPointerException being thrown... on line 118 of org.apache.oodt.cas.pushpull.retrievalsystem.RetrievalSetup.java change it from:                         LOG.log(Level.SEVERE,                                 "Failed to finish downloading per property file

Re: MetadataListPcsMetFileWriter

2012-07-12 Thread Brian Foster
t; ><michael.d.caya...@jpl.nasa.gov> wrote: > >> Hey Brian and Chris, >> >> Does this mean 0.4 CAS-PGE is broken? If so, SMAP will have to wait >>until 0.5 then to do an upgrade. >> >> -Mike >> >> BTW, I subscribed to the dev@ list again

Re: MetadataListPcsMetFileWriter

2012-07-11 Thread Brian Foster
side note: Don't use 0.4 CAS-PGE... use the latest from trunk... there were changes that never made it into the trunk in time for 0.4 release.-brianOn Jul 11, 2012, at 07:16 AM, "Mattmann, Chris A (388J)" wrote:[dropping private@ and user@ CC's] Hi Mike, In general, it's not a good practice to C

Re: MetadataListPcsMetFileWriter

2012-07-10 Thread Brian Foster
0.4 CAS-PGE uses AutoDetectProductCrawler now... in the PgeConfig XML file you now just specify directories where you want your crawler to crawl and you configure ingest with the crawler... same as you would for a pushpull staging area... check out this file: https://svn.apache.org/repos/asf/oodt/t

Re: Review Request: Change SciPgeConfigFileWriter to DynamicConfigFileWriter

2012-06-24 Thread brian Foster
/ Testing --- Thanks, brian Foster

Re: Review Request: Added file staging support to CAS-PGE's XmlFilePgeConfigBuilder

2012-06-24 Thread brian Foster
/diff/ Testing --- Wrote unit-tests Thanks, brian Foster

Review Request: Change SciPgeConfigFileWriter to DynamicConfigFileWriter

2012-06-24 Thread brian Foster
--- Thanks, brian Foster

RADiX tarball not hosted...

2012-06-22 Thread Brian Foster
hey guys,running this:curl http://www.apache.org/dist/oodt/radix-0.4.tgz > radix-0.4.tgzgives me a file with content:404 Not FoundNot FoundThe requested URL /dist/oodt/radix-0.4.tgz was not found on this server.Apache/2.4.1 (Unix) OpenSSL/1.0.0g Server at www.apache.org Port 80Nothing radix at:http

Re: New Met Extractors for Crawler

2012-06-22 Thread Brian Foster
+1On Jun 22, 2012, at 06:58 AM, "Mattmann, Chris A (388J)" wrote:Hey Ricky, I just read your page: https://cwiki.apache.org/confluence/display/OODT/MetExtractors+for+Crawler Super awesome! My +1 the ProdTypePatternMetExtractor sounds super useful. Cheers, Chris ++

Jira/ReviewBoard sync...

2012-06-21 Thread Brian Foster
Ever since review board when down the other day, since it's come back up it is working with JIRA anymore... who should i bug?-brian

Review Request: Added file staging support to CAS-PGE's XmlFilePgeConfigBuilder

2012-06-18 Thread brian Foster
/config/TestXmlFilePgeConfigBuilder.java PRE-CREATION trunk/pge/src/test/org/apache/oodt/cas/pge/util/TestXmlHelper.java PRE-CREATION Diff: https://reviews.apache.org/r/5382/diff/ Testing --- Wrote unit-tests Thanks, brian Foster

Fwd: [jira] [Commented] (OODT-454) Crawler command line bugs

2012-06-16 Thread Brian Foster
Paul what do you think? Begin forwarded message: > From: "Chris A. Mattmann (JIRA)" > Date: June 16, 2012 9:08:42 AM PDT > To: comm...@oodt.apache.org > Subject: [jira] [Commented] (OODT-454) Crawler command line bugs > Reply-To: dev@oodt.apache.org > > >[ > https://issues.apache.org/jir

Re: [VOTE] Apache OODT 0.4 Release

2012-06-15 Thread Brian Foster
+1... however pending the current patch i have up for cas-pge, cas-pge isn't quite ready to be used yet either... so 0.3 workflow and 0.3 cas-pge... few more changes and i think cas-pge will be ready to go... also want to add some basic xml files which can be imported which have common used metadat

Re: OODT XML Namespace URI

2012-06-14 Thread Brian Foster
+1On Jun 14, 2012, at 11:33 AM, "Ramirez, Paul M (388J)" wrote:Hey Guys, Is this to update the namespaces for the different XML files and config we have? Right now we have cas in that string. Do we want one overarching namespace or multiple. I'm fine with either but we could also take the opportu

Re: Staging CAS-PGE config file...

2012-06-06 Thread Brian Foster
ianOn May 01, 2012, at 11:11 PM, "Mattmann, Chris A (388J)" wrote:Hey Brian, Thanks, comments below: On May 1, 2012, at 5:20 PM, Brian Foster wrote: > hey guys, > > in the wengine branched CAS-PGE, it supported staging the CAS-PGE's XML config file to tmp directory s

Re: OODT SoCal Meetup/Hackathon

2012-06-04 Thread Brian Foster
>>>> paul.m.rami...@jpl.nasa.gov> wrote: >>>> >>>>> Your place sounds good to me. Now we just need to lock down a date. >>>>> 1st >>>> or >>>>> 2nd Saturday of June work? >>>>> >>>&g

Re: OODT SoCal Meetup/Hackathon

2012-05-17 Thread Brian Foster
google+ hangout 4 those out of state! On May 16, 2012, at 11:54 AM, "Mattmann, Chris A (388J)" wrote: > Hey Paul, > > This sounds like a great idea and I'm in (of course!) > > One thing we'll need to do is make sure that we do a really good job of trying > to include everyone, even folks tha

Re: OODT SoCal Meetup/Hackathon

2012-05-15 Thread Brian Foster
+1On May 15, 2012, at 05:21 PM, "Ramirez, Paul M (388J)" wrote:Hi All, Anyone interested in doing a meetup/hackathon at the beginning of June. The goal would be to get some updates to our code base but really focused on getting 0.4 out the door. If there is enough interest we would need a place t

Re: Review Request: Wengine Task Querier Thread: OODT-310

2012-05-08 Thread brian Foster
> On 2012-05-02 19:20:13, brian Foster wrote: > > ./trunk/workflow/src/test/org/apache/oodt/cas/workflow/engine/TestTaskQuerier.java, > > line 79 > > <https://reviews.apache.org/r/4961/diff/1/?file=105932#file105932line79> > > > > When Success/done

Re: Review Request: Wengine Task Querier Thread: OODT-310

2012-05-08 Thread brian Foster
> On 2012-05-02 19:20:13, brian Foster wrote: > > ./trunk/workflow/src/test/org/apache/oodt/cas/workflow/engine/TestTaskQuerier.java, > > line 79 > > <https://reviews.apache.org/r/4961/diff/1/?file=105932#file105932line79> > > > > When Success/done

Re: Review Request: Crawler command line bugs

2012-05-07 Thread brian Foster
t; This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/4989/ > ------- > > (Updated 2012-05-03 12:03:13) > > > Review request for oodt, Chris Mattmann, brian Foster, Paul Ramirez, and > Sheryl John. > &g

Re: Review Request: Wengine Task Querier Thread: OODT-310

2012-05-02 Thread brian Foster
y, visit: > https://reviews.apache.org/r/4961/ > --- > > (Updated 2012-05-02 05:08:45) > > > Review request for oodt, brian Foster, Ricky Nguyen, Paul Ramirez, Sheryl > John, and Thomas Bennett. > > > Summ

Staging CAS-PGE config file...

2012-05-01 Thread Brian Foster
hey guys,in the wengine branched CAS-PGE, it supported staging the CAS-PGE's XML config file to tmp directory so it could be parsed and then processed and then the staged config file was copied CAS-PGE's working directory (had to be copied later since the working directory information is in the con

Re: Review Request: Add file staging support to CAS-PGE

2012-04-30 Thread brian Foster
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4746/ --- (Updated 2012-04-30 21:23:30.299369) Review request for oodt, Chris Mattmann, Ri

Java 7 and Maven 3

2012-04-27 Thread Brian Foster
hey guys,There are several cool new features in Java 7... such as, and you JPLer will probably like this one, file change notifications --  The WatchService API lets you receive notification events upon changes to the subject (directory or file)... also Maven 3 has been out for a while and i would

Re: Registering a custom ProductCrawler with cas-crawler

2012-04-26 Thread Brian Foster
Nevermind... Looks like you are using 0.3 instead of the trunk... what I added applies to trunk crawler -Brian On Apr 25, 2012, at 4:36 PM, "Verma, Rishi (388J)" wrote: > Hi all, > > I wrote a custom cas-crawler ProductCrawler, but I'm having some difficulty > registering my custom product

Re: Registering a custom ProductCrawler with cas-crawler

2012-04-26 Thread Brian Foster
Hey Rishi, Do what Chris said AND add a CmdLineAction to cmd-line-action.xml to run you crawler (should just be a copy/paste and change some names) -Brian On Apr 25, 2012, at 10:12 PM, "Mattmann, Chris A (388J)" wrote: > Hey Rishi, > > I think you need to change the actionRepo, something a

Review Request: Add file staging support to CAS-PGE

2012-04-16 Thread brian Foster
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4746/ --- Review request for oodt, Chris Mattmann, Ricky Nguyen, Paul Ramirez, and Thomas B

Re: Review Request: Add file staging support to CAS-PGE

2012-04-16 Thread brian Foster
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4746/ --- (Updated 2012-04-16 22:27:39.110301) Review request for oodt, Chris Mattmann, Ri

Re: bash if statements in PGE

2012-04-13 Thread Brian Foster
Hey Ricky, The envReplace which is causing this problem is the envReplace applied to the script... Currently this cannot be turned off... However if you create an issue for this I will take care of this fix... Updating the XML parser is my next step in porting wengine changes to trunk cas-pge

Re: Review Request: Introduce a CAS-Metadata based renaming interface (CAS-PGE Changes)

2012-04-09 Thread brian Foster
is then > > I recommend putting it back in but commented out. > > > > For instance, I'd expect that instead of metadata keys you want to set > > more of what will be done with that custom metadata would be of use. Also > > an example of multivalued metadata

Re: Review Request: Introduce a CAS-Metadata based renaming interface (CAS-PGE Changes)

2012-04-05 Thread brian Foster
> > 49 > > <https://reviews.apache.org/r/4628/diff/1/?file=98792#file98792line49> > > > > +like ack - brian --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4628/#revi

Re: Review Request: Introduce a CAS-Metadata based renaming interface (CAS-PGE Changes)

2012-04-05 Thread brian Foster
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4628/ --- (Updated 2012-04-06 02:16:10.469275) Review request for oodt, Chris Mattmann, Ri

Re: Review Request: Introduce a CAS-Metadata based renaming interface (CAS-PGE Changes)

2012-04-05 Thread brian Foster
e when i write the unit-tests for it - brian --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4628/#review6670 --- On 2012-04-03 21:56:17,

Review Request: Make CAS-Crawlers MimeExtractorConfigReader relative file paths be relative to its XML file

2012-04-05 Thread brian Foster
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4665/ --- Review request for oodt, Chris Mattmann, Ricky Nguyen, Paul Ramirez, and Thomas B

Review Request: Introduce a CAS-Metadata based renaming interface (CAS-PGE Changes)

2012-04-03 Thread brian Foster
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4628/ --- Review request for oodt, Chris Mattmann, Ricky Nguyen, Paul Ramirez, and Thomas B

Re: Build failed in Jenkins: oodt-trunk #378

2012-03-29 Thread Brian Foster
haha... i like it... i was just practicing good development testing skills #TTD!... lolOn Mar 29, 2012, at 07:02 AM, Sean Kelly wrote:Quite! #TDD: it must break first, then work second! On 2012.Mar.28, at 10.50p, Mattmann, Chris A (388J) wrote: > hahah #TDD dude, you aren't retarded!

Re: Review Request: Get product references before calling retrieveProduct(). Update unit tests testRetrieveFilesById() and testRetrieveFilesByName()

2012-03-29 Thread brian Foster
> Review request for oodt, Chris Mattmann, brian Foster, Paul Ramirez, and > Sheryl John. > > > Summary > --- > > Get product references before calling retrieveProduct(). > 1) call setProductReferences method > 2) remove d.retrieveProduct() outside the if else s

Re: Review Request: Introduce a CAS-Metadata based renaming interface (CAS-Crawler changes)

2012-03-28 Thread brian Foster
/MetExtractorSpec.java <https://reviews.apache.org/r//#comment13930> ignore this files changes... i removed them locally... was added these while debugging - brian On 2012-03-27 00:47:30, brian Foster wrote: > > ---

Re: pushpull from 0.3

2012-03-27 Thread Brian Foster
hey ryan,The example pushpull RemoteSpecs.xml file requires setting some environment variables:CAS_PP_RESOURCES = should be set to absolute path to your pushpull etc directoryCAS_PP_TEMP_PROPS = temporary directory for examples which download pushpull config filesYou might be able to get a few of t

Re: Review Request: filemgr query throws NPE when sorting by key with possibly empty values

2012-03-27 Thread brian Foster
Review request for oodt, Chris Mattmann, brian Foster, Paul Ramirez, Sheryl > John, and Thomas Bennett. > > > Summary > --- > > putting nulls last > > > This addresses bug OODT-429. > https://issues.apache.org/jira/browse/OODT-429 > > >

Re: Review Request: filemgr query throws NPE when sorting by key with possibly empty values

2012-03-27 Thread brian Foster
> On 2012-03-26 21:06:00, brian Foster wrote: > > trunk/filemgr/src/main/java/org/apache/oodt/cas/filemgr/structs/query/QueryResultComparator.java, > > line 48 > > <https://reviews.apache.org/r/4458/diff/2/?file=95128#file95128line48> > > > > i don

Removal of CAS-PGE file renaming and met file writing...

2012-03-27 Thread Brian Foster
hey guys,I'm proposing deletion instead of deprecation of CAS-PGE product file renaming and met file writing... this will be replaced by the CAS-Crawler AutoDetectProductCrawler which now has support for both these things... CAS-Crawler has evolved along-side CAS-PGE and has been integrated with su

Removal of CAS-PGE file renaming and met file writing...

2012-03-27 Thread Brian Foster
hey guys,I'm proposing deletion instead of deprecation of CAS-PGE product file renaming and met file writing... this will be replaced by the CAS-Crawler AutoDetectProductCrawler which now has support for both these things... CAS-Crawler has evolved along-side CAS-PGE and has been integrated with su

Re: Review Request: Introduce a CAS-Metadata based renaming interface (CAS-Crawler changes)

2012-03-26 Thread brian Foster
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r// --- (Updated 2012-03-27 00:47:30.189828) Review request for oodt, Chris Mattmann, Ri

Re: Review Request: Introduce a CAS-Metadata based renaming interface (CAS-Crawler changes)

2012-03-26 Thread brian Foster
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r//#review6349 --- On 2012-03-25 01:55:32, brian Foster wrote: > >

Re: Review Request: filemgr query throws NPE when sorting by key with possibly empty values

2012-03-26 Thread brian Foster
icky Nguyen wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/4458/ > --- > > (Updated 2012-03-23 21:19:16) > > > Review request for oodt, Chris Mattm

Re: Review Request: CrawlerBeansPropHandler doesn't set list properties for Spring PropertyOverrideConfigurer correctly

2012-03-26 Thread brian Foster
ifying either true or false value. - brian --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4454/#review6347 -------

Re: Review Request: CrawlerBeansPropHandler doesn't set list properties for Spring PropertyOverrideConfigurer correctly

2012-03-26 Thread brian Foster
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/4454/ --- (Updated 2012-03-26 20:55:22.461160) Review request for oodt, Chris Mattmann, Ri

Cleanup ReviewBoard...

2012-03-26 Thread Brian Foster
hey guys,If you have ReviewBoard requests which are for JIRA issues that have been resolved can you mark your reviews in ReviewBoard as Close -> Submitted... the ReviewBoard dashboard is starting to get cluttered and hard to figure out which ones still need attention.thanks!-brian

Re: Review Request: filemgr query throws "String index out of range: -1" when some products have undefined metadata values

2012-03-26 Thread brian Foster
Review request for oodt, Chris Mattmann, brian Foster, Paul Ramirez, Sheryl > John, and Thomas Bennett. > > > Summary > --- > > Cleaned up metadata to string methods of QueryResult. If metadata was empty, > it was trying to delete a trailing comma that doesn

Re: Review Request: CrawlerBeansPropHandler throws IndexOutOfBoundsException when parsing boolean command line options

2012-03-26 Thread brian Foster
: > https://reviews.apache.org/r/4465/ > --- > > (Updated 2012-03-23 09:47:04) > > > Review request for oodt, Chris Mattmann, brian Foster, Paul Ramirez, and > Sheryl John. > > > Summary > --- >

Re: Review Request: CrawlerBeansPropHandler throws IndexOutOfBoundsException when parsing boolean command line options

2012-03-26 Thread brian Foster
47:04) > > > Review request for oodt, Chris Mattmann, brian Foster, Paul Ramirez, and > Sheryl John. > > > Summary > --- > > As per Brian's suggestion, I needed to add > > > > > >

Re: Review Request: filemgr query throws NPE when sorting by key with possibly empty values

2012-03-26 Thread brian Foster
- > > (Updated 2012-03-23 00:10:25) > > > Review request for oodt, Chris Mattmann, brian Foster, Paul Ramirez, Sheryl > John, and Thomas Bennett. > > > Summary > --- > > putting nulls last > > > This addresses bug OODT

Re: Review Request: Introduce a CAS-Metadata based renaming interface (CAS-Crawler changes)

2012-03-26 Thread brian Foster
https://reviews.apache.org/r//#review6214 ------- On 2012-03-22 06:09:52, brian Foster wrote: > > --- > This is an automatically generated e-mail

Re: Review Request: Introduce a CAS-Metadata based renaming interface (CAS-Crawler changes)

2012-03-26 Thread brian Foster
n the code will never reach this IF statement... The IF statement it is contained in will be false - brian On 2012-03-22 06:09:52, brian Foster wrote: > > --- > This is an automatically generated e-mail. To reply, visit: >

Re: Review Request: filemgr query throws "String index out of range: -1" when some products have undefined metadata values

2012-03-26 Thread brian Foster
an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/4451/ > --- > > (Updated 2012-03-22 23:47:07) > > > Review request for oodt, Chris Mattmann, brian Foster, Paul Ramirez, Sheryl > John,

  1   2   3   >