[GitHub] thrift issue #1475: THRIFT-4464: Fix typo in TNonblockingServer.py

2018-01-23 Thread nsuke
Github user nsuke commented on the issue: https://github.com/apache/thrift/pull/1475 Thanks @tomtung, looks fine to me. ---

[GitHub] thrift issue #662: THRIFT-3399 Import Haskell haddock comments and trivial r...

2017-11-05 Thread nsuke
Github user nsuke commented on the issue: https://github.com/apache/thrift/pull/662 As described in JIRA, this cannot be merged due to copyright issue. ---

[GitHub] thrift pull request #662: THRIFT-3399 Import Haskell haddock comments and tr...

2017-11-05 Thread nsuke
Github user nsuke closed the pull request at: https://github.com/apache/thrift/pull/662 ---

[GitHub] thrift pull request #1084: THRIFT-3773 Swift 3 Native Library

2017-11-01 Thread nsuke
Github user nsuke commented on a diff in the pull request: https://github.com/apache/thrift/pull/1084#discussion_r148288455 --- Diff: compiler/cpp/src/thrift/generate/t_swift_generator.cc --- @@ -245,22 +297,30 @@ class t_swift_generator : public t_oop_generator

[GitHub] thrift issue #1289: fix TypeError when a py3 str is passed to the function.

2017-10-29 Thread nsuke
Github user nsuke commented on the issue: https://github.com/apache/thrift/pull/1289 Basically yes with some note. It's typically not a UTF-8 encoded binary. To write utf8 strings we can use `writeString`. The point is that `writeBinary` is for writing binaries.

[GitHub] thrift pull request #1274: THRIFT-4207: Make sure Python Accelerated protoco...

2017-10-28 Thread nsuke
Github user nsuke commented on a diff in the pull request: https://github.com/apache/thrift/pull/1274#discussion_r147556105 --- Diff: lib/py/src/ext/protocol.tcc --- @@ -419,18 +419,30 @@ bool ProtocolBase::encodeValue(PyObject* value, TType type, PyObject* type case

[GitHub] thrift pull request #1274: THRIFT-4207: Make sure Python Accelerated protoco...

2017-10-28 Thread nsuke
Github user nsuke commented on a diff in the pull request: https://github.com/apache/thrift/pull/1274#discussion_r147555909 --- Diff: lib/py/src/protocol/TProtocol.py --- @@ -118,6 +118,8 @@ def writeDouble(self, dub): pass def writeString(self, str_val

[GitHub] thrift pull request #1084: THRIFT-3773 Swift 3 Native Library

2017-10-28 Thread nsuke
Github user nsuke commented on a diff in the pull request: https://github.com/apache/thrift/pull/1084#discussion_r147555627 --- Diff: compiler/cpp/src/thrift/generate/t_swift_generator.cc.old --- @@ -0,0 +1,3249 @@ +/* --- End diff -- Can you remove this one if

[GitHub] thrift pull request #1084: THRIFT-3773 Swift 3 Native Library

2017-10-28 Thread nsuke
Github user nsuke commented on a diff in the pull request: https://github.com/apache/thrift/pull/1084#discussion_r147555608 --- Diff: compiler/cpp/src/thrift/generate/t_swift_generator.cc --- @@ -95,19 +110,20 @@ class t_swift_generator : public t_oop_generator { void

[GitHub] thrift issue #1084: THRIFT-3773 Swift 3 Native Library

2017-10-28 Thread nsuke
Github user nsuke commented on the issue: https://github.com/apache/thrift/pull/1084 This replaces current Swift2 generator/lib with new one which supports Swift3. The current one is still kept as option `swift:cocoa`, though. Swift 2 has been not usable with latest XCode for

[GitHub] thrift issue #945: THRIFT-3737 Improve isOpen() to give accurate tcp connect...

2017-10-28 Thread nsuke
Github user nsuke commented on the issue: https://github.com/apache/thrift/pull/945 There's no real use case anymore. happybase does not use Apache Thrift any more. ---

[GitHub] thrift issue #1289: fix TypeError when a py3 str is passed to the function.

2017-10-28 Thread nsuke
Github user nsuke commented on the issue: https://github.com/apache/thrift/pull/1289 It's more of a usability problem. The problem is that the user is passing a non-`byte` instance to `writeBinary`. It's basically the same error as when you pass str `'42'

[GitHub] thrift issue #979: THRIFT-3779 Qt Client Android and Windows QTcpSocket

2017-10-28 Thread nsuke
Github user nsuke commented on the issue: https://github.com/apache/thrift/pull/979 This PR does the following * use `qmake` in addition to autotools and cmake to build C++ lib * introduce blocking variant of Qt based transport The motivation was to use blocking

[GitHub] thrift issue #1359: THRIFT-4064: update node dependencies

2017-09-19 Thread nsuke
Github user nsuke commented on the issue: https://github.com/apache/thrift/pull/1359 jsdoc 3.5.5 addresses the issue: https://github.com/jsdoc3/jsdoc/issues/1438 From what I see there, you would need to rebuild the node installation layer of your local docker image to reproduce

[GitHub] thrift pull request #1214: THRIFT-2026: Eliminate some undefined behavior in...

2017-03-18 Thread nsuke
Github user nsuke commented on a diff in the pull request: https://github.com/apache/thrift/pull/1214#discussion_r106795259 --- Diff: lib/cpp/src/thrift/protocol/TCompactProtocol.tcc --- @@ -387,7 +389,11 @@ uint32_t TCompactProtocolT::writeVarint64(uint64_t n

[GitHub] thrift pull request #1197: THRIFT-4084: Add a SSL/TLS negotiation check to c...

2017-02-18 Thread nsuke
Github user nsuke commented on a diff in the pull request: https://github.com/apache/thrift/pull/1197#discussion_r101909371 --- Diff: test/tests.json --- @@ -606,5 +606,23 @@ "compact" ], "workdir": "rs/bin" + },

[GitHub] thrift pull request #1197: THRIFT-4084: Add a SSL/TLS negotiation check to c...

2017-02-18 Thread nsuke
Github user nsuke commented on a diff in the pull request: https://github.com/apache/thrift/pull/1197#discussion_r101909373 --- Diff: test/secure/test_secure.bash --- @@ -0,0 +1,69 @@ +#!/bin/bash + +# +# Checks various desired attributes in SSL/TLS implementations

[GitHub] thrift pull request #1197: THRIFT-4084: Add a SSL/TLS negotiation check to c...

2017-02-18 Thread nsuke
Github user nsuke commented on a diff in the pull request: https://github.com/apache/thrift/pull/1197#discussion_r101909372 --- Diff: lib/py/src/transport/sslcompat.py --- @@ -66,6 +66,14 @@ def legacy_validate_callback(cert, hostname): --- End diff -- As far as

[GitHub] thrift pull request #1196: THRIFT-3891 TNonblockingServer configured with mo...

2017-02-18 Thread nsuke
Github user nsuke commented on a diff in the pull request: https://github.com/apache/thrift/pull/1196#discussion_r101908082 --- Diff: lib/cpp/src/thrift/server/TNonblockingServer.cpp --- @@ -1520,13 +1524,9 @@ void TNonblockingIOThread::breakLoop(bool error) { ::abort

[GitHub] thrift pull request #1196: THRIFT-3891 TNonblockingServer configured with mo...

2017-02-18 Thread nsuke
Github user nsuke commented on a diff in the pull request: https://github.com/apache/thrift/pull/1196#discussion_r101908056 --- Diff: lib/cpp/src/thrift/server/TNonblockingServer.cpp --- @@ -212,7 +212,8 @@ class TNonblockingServer::TConnection { TConnection(THRIFT_SOCKET

[GitHub] thrift pull request #1196: THRIFT-3891 TNonblockingServer configured with mo...

2017-02-18 Thread nsuke
Github user nsuke commented on a diff in the pull request: https://github.com/apache/thrift/pull/1196#discussion_r101908102 --- Diff: lib/cpp/src/thrift/server/TNonblockingServer.cpp --- @@ -820,9 +821,11 @@ void TNonblockingServer::TConnection::setFlags(short eventFlags

[GitHub] thrift pull request #1196: THRIFT-3891 TNonblockingServer configured with mo...

2017-02-18 Thread nsuke
Github user nsuke commented on a diff in the pull request: https://github.com/apache/thrift/pull/1196#discussion_r101908093 --- Diff: lib/cpp/src/thrift/server/TNonblockingServer.cpp --- @@ -820,9 +821,11 @@ void TNonblockingServer::TConnection::setFlags(short eventFlags

[GitHub] thrift pull request #1197: THRIFT-4084: Add a SSL/TLS negotiation check to c...

2017-02-18 Thread nsuke
Github user nsuke commented on a diff in the pull request: https://github.com/apache/thrift/pull/1197#discussion_r101908015 --- Diff: lib/go/thrift/ssl_socket.go --- @@ -20,152 +20,155 @@ package thrift --- End diff -- See https://github.com/golang/go/commit

[GitHub] thrift pull request #1197: THRIFT-4084: Add a SSL/TLS negotiation check to c...

2017-02-18 Thread nsuke
Github user nsuke commented on a diff in the pull request: https://github.com/apache/thrift/pull/1197#discussion_r101907094 --- Diff: lib/go/thrift/ssl_socket.go --- @@ -20,152 +20,155 @@ package thrift --- End diff -- We cannot replace indentation with spaces

[GitHub] thrift pull request #1197: THRIFT-4084: Add a SSL/TLS negotiation check to c...

2017-02-18 Thread nsuke
Github user nsuke commented on a diff in the pull request: https://github.com/apache/thrift/pull/1197#discussion_r101907745 --- Diff: test/secure/test_secure.bash --- @@ -0,0 +1,69 @@ +#!/bin/bash + +# +# Checks various desired attributes in SSL/TLS implementations

[GitHub] thrift pull request #1197: THRIFT-4084: Add a SSL/TLS negotiation check to c...

2017-02-18 Thread nsuke
Github user nsuke commented on a diff in the pull request: https://github.com/apache/thrift/pull/1197#discussion_r101907113 --- Diff: test/tests.json --- @@ -606,5 +606,23 @@ "compact" ], "workdir": "rs/bin" + },

[GitHub] thrift pull request #1197: THRIFT-4084: Add a SSL/TLS negotiation check to c...

2017-02-18 Thread nsuke
Github user nsuke commented on a diff in the pull request: https://github.com/apache/thrift/pull/1197#discussion_r101907319 --- Diff: lib/py/src/transport/sslcompat.py --- @@ -66,6 +66,14 @@ def legacy_validate_callback(cert, hostname): --- End diff -- Is it to

[GitHub] thrift pull request #1197: THRIFT-4084: Add a SSL/TLS negotiation check to c...

2017-02-18 Thread nsuke
Github user nsuke commented on a diff in the pull request: https://github.com/apache/thrift/pull/1197#discussion_r101907637 --- Diff: lib/nodejs/lib/thrift/connection.js --- @@ -247,6 +247,11 @@ exports.createConnection = function(host, port, options

[GitHub] thrift issue #1185: Thrift 3369 - Third try to merge SSL c_glib

2017-02-12 Thread nsuke
Github user nsuke commented on the issue: https://github.com/apache/thrift/pull/1185 @jeking3 in that case, Ubuntu might be using a patched version of Python. According to the [doc](https://docs.python.org/2/library/ssl.html#ssl.OP_NO_SSLv2), it's added in

[GitHub] thrift issue #1185: Thrift 3369 - Third try to merge SSL c_glib

2017-02-11 Thread nsuke
Github user nsuke commented on the issue: https://github.com/apache/thrift/pull/1185 @jeking3 I can confirm that our C# and Python2 doesn't work for TLS 1.1/1.2. For Python2, it requires Python >= 2.7.9 which includes a lot of security API updates. Only Debian i

[GitHub] thrift pull request #1100: THRIFT-3938 Python TNonblockingServer does not wo...

2017-02-11 Thread nsuke
GitHub user nsuke reopened a pull request: https://github.com/apache/thrift/pull/1100 THRIFT-3938 Python TNonblockingServer does not work with SSL You can merge this pull request into a Git repository by running: $ git pull https://github.com/nsuke/thrift THRIFT-3938

[GitHub] thrift pull request #1100: THRIFT-3938 Python TNonblockingServer does not wo...

2017-02-11 Thread nsuke
Github user nsuke closed the pull request at: https://github.com/apache/thrift/pull/1100 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] thrift pull request #1185: Thrift 3369 - Third try to merge SSL c_glib

2017-02-11 Thread nsuke
Github user nsuke commented on a diff in the pull request: https://github.com/apache/thrift/pull/1185#discussion_r100669840 --- Diff: lib/c_glib/src/thrift/c_glib/transport/thrift_ssl_socket.c --- @@ -0,0 +1,772 @@ +/* + * Licensed to the Apache Software Foundation (ASF

[GitHub] thrift pull request #1185: Thrift 3369 - Third try to merge SSL c_glib

2017-02-11 Thread nsuke
Github user nsuke commented on a diff in the pull request: https://github.com/apache/thrift/pull/1185#discussion_r100669633 --- Diff: test/c_glib/src/test_client.c --- @@ -181,11 +194,22 @@ main (int argc, char **argv) sigpipe_action.sa_flags = SA_RESETHAND; sigaction

[GitHub] thrift pull request #1166: THRIFT-4026 TSSLSocket doesn't work with Python <...

2017-01-28 Thread nsuke
GitHub user nsuke opened a pull request: https://github.com/apache/thrift/pull/1166 THRIFT-4026 TSSLSocket doesn't work with Python < 2.7.9 You can merge this pull request into a Git repository by running: $ git pull https://github.com/nsuke/thrift THRIFT-4026 Alter

[GitHub] thrift pull request #1141: support for timeout in node http connection

2016-12-21 Thread nsuke
Github user nsuke commented on a diff in the pull request: https://github.com/apache/thrift/pull/1141#discussion_r93458710 --- Diff: lib/nodejs/lib/thrift/http_connection.js --- @@ -214,6 +214,18 @@ HttpConnection.prototype.write = function(data) { var req = (self.https

[GitHub] thrift pull request #1141: support for timeout in node http connection

2016-12-21 Thread nsuke
Github user nsuke commented on a diff in the pull request: https://github.com/apache/thrift/pull/1141#discussion_r93437696 --- Diff: lib/nodejs/lib/thrift/http_connection.js --- @@ -214,6 +214,18 @@ HttpConnection.prototype.write = function(data) { var req = (self.https

[GitHub] thrift pull request #1141: support for timeout in node http connection

2016-12-21 Thread nsuke
Github user nsuke commented on a diff in the pull request: https://github.com/apache/thrift/pull/1141#discussion_r93412832 --- Diff: lib/nodejs/lib/thrift/http_connection.js --- @@ -214,6 +214,18 @@ HttpConnection.prototype.write = function(data) { var req = (self.https

[GitHub] thrift pull request #1141: support for timeout in node http connection

2016-12-20 Thread nsuke
Github user nsuke commented on a diff in the pull request: https://github.com/apache/thrift/pull/1141#discussion_r93389394 --- Diff: lib/nodejs/lib/thrift/http_connection.js --- @@ -214,6 +214,18 @@ HttpConnection.prototype.write = function(data) { var req = (self.https

[GitHub] thrift pull request #1084: THRIFT-3773 Swift 3 Native Library

2016-12-20 Thread nsuke
Github user nsuke commented on a diff in the pull request: https://github.com/apache/thrift/pull/1084#discussion_r93366702 --- Diff: lib/swift/README.md --- @@ -0,0 +1,217 @@ +Thrift Swift Library += + +License +--- +Licensed to

[GitHub] thrift pull request #1084: THRIFT-3773 Swift 3 Native Library

2016-12-20 Thread nsuke
Github user nsuke commented on a diff in the pull request: https://github.com/apache/thrift/pull/1084#discussion_r93366730 --- Diff: lib/swift/Sources/TProtocolError.swift --- @@ -0,0 +1,146 @@ +/* +* Licensed to the Apache Software Foundation (ASF) under one +* or more

[GitHub] thrift pull request #1084: THRIFT-3773 Swift 3 Native Library

2016-12-20 Thread nsuke
Github user nsuke commented on a diff in the pull request: https://github.com/apache/thrift/pull/1084#discussion_r93367768 --- Diff: compiler/cpp/src/thrift/generate/t_swift_3_generator.cc --- @@ -0,0 +1,2553 @@ +/* --- End diff -- Assigning simple "--gen swif

[GitHub] thrift pull request #1141: support for timeout in node http connection

2016-12-20 Thread nsuke
Github user nsuke commented on a diff in the pull request: https://github.com/apache/thrift/pull/1141#discussion_r93366270 --- Diff: lib/nodejs/lib/thrift/http_connection.js --- @@ -214,6 +214,18 @@ HttpConnection.prototype.write = function(data) { var req = (self.https

[GitHub] thrift issue #1082: THRIFT-3828 In cmake avoid use of both quoted paths and ...

2016-11-14 Thread nsuke
Github user nsuke commented on the issue: https://github.com/apache/thrift/pull/1082 I cannot reproduce this using GCC 6 and boost headers in /usr/include. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] thrift pull request #1084: THRIFT-3773 Swift 3 Native Library

2016-11-13 Thread nsuke
Github user nsuke commented on a diff in the pull request: https://github.com/apache/thrift/pull/1084#discussion_r87710760 --- Diff: lib/swift/README.md --- @@ -0,0 +1,217 @@ +Thrift Swift Library += + +License +--- +Licensed to

[GitHub] thrift pull request #1084: THRIFT-3773 Swift 3 Native Library

2016-11-13 Thread nsuke
Github user nsuke commented on a diff in the pull request: https://github.com/apache/thrift/pull/1084#discussion_r87710735 --- Diff: lib/swift/Sources/LinuxHelper.swift --- @@ -0,0 +1,34 @@ +// +// LinuxHelper.swift +// Thrift +// +// Created by Christopher

[GitHub] thrift pull request #1084: THRIFT-3773 Swift 3 Native Library

2016-11-13 Thread nsuke
Github user nsuke commented on a diff in the pull request: https://github.com/apache/thrift/pull/1084#discussion_r87710644 --- Diff: compiler/cpp/src/thrift/generate/t_swift_3_generator.cc --- @@ -0,0 +1,2553 @@ +/* --- End diff -- This particular file shares more

[GitHub] thrift pull request #1084: THRIFT-3773 Swift 3 Native Library

2016-11-13 Thread nsuke
Github user nsuke commented on a diff in the pull request: https://github.com/apache/thrift/pull/1084#discussion_r87710725 --- Diff: lib/swift/Package.swift --- @@ -0,0 +1,12 @@ +//let package = Package( --- End diff -- A file header would be nice. --- If your

[GitHub] thrift issue #1114: Added Nonblocking SSL java client

2016-11-13 Thread nsuke
Github user nsuke commented on the issue: https://github.com/apache/thrift/pull/1114 @dthaluru I think we can avoid duplicating the entire client stack. As far as I can see the only thing that really matters is `TNonblockingSSLSocket`. If we make it compatible with

[GitHub] thrift pull request #1129: THRIFT-3038 clean up remaining volatile issues; r...

2016-11-13 Thread nsuke
Github user nsuke commented on a diff in the pull request: https://github.com/apache/thrift/pull/1129#discussion_r87709373 --- Diff: lib/cpp/src/thrift/concurrency/Mutex.h --- @@ -101,25 +101,6 @@ class ReadWriteMutex { boost::shared_ptr impl_

[GitHub] thrift pull request #1129: THRIFT-3038 clean up remaining volatile issues; r...

2016-11-13 Thread nsuke
Github user nsuke commented on a diff in the pull request: https://github.com/apache/thrift/pull/1129#discussion_r87707817 --- Diff: lib/cpp/src/thrift/concurrency/Mutex.cpp --- @@ -37,11 +37,10 @@ namespace concurrency { #ifndef THRIFT_NO_CONTENTION_PROFILING

[GitHub] thrift issue #1120: THRIFT-3301: Naming collisions possible in generated Jav...

2016-10-31 Thread nsuke
Github user nsuke commented on the issue: https://github.com/apache/thrift/pull/1120 @bgould the failing CI job is make dist tarball verification. It's typically caused by missing `EXTRA_DIST` entries for newly added files in `Makefile.am`. --- If your project is set up f

[GitHub] thrift pull request #1115: THRIFT-3949 missing make dist entry for compiler/...

2016-10-18 Thread nsuke
GitHub user nsuke opened a pull request: https://github.com/apache/thrift/pull/1115 THRIFT-3949 missing make dist entry for compiler/cpp/test You can merge this pull request into a Git repository by running: $ git pull https://github.com/nsuke/thrift THRIFT-3949

[GitHub] thrift issue #1103: THRIFT-3932: fixed ThreadManager concurrency issues, add...

2016-10-02 Thread nsuke
Github user nsuke commented on the issue: https://github.com/apache/thrift/pull/1103 Oh, good catch, concurrency_test definitely needs to be enabled for Linux cmake CI and autotools. Somehow thought that you were referring to concurrency_test in the last comment, but

[GitHub] thrift pull request #1105: THRIFT-3902 TFramedTransport.open throws NullPoin...

2016-10-02 Thread nsuke
GitHub user nsuke reopened a pull request: https://github.com/apache/thrift/pull/1105 THRIFT-3902 TFramedTransport.open throws NullPointerException You can merge this pull request into a Git repository by running: $ git pull https://github.com/nsuke/thrift THRIFT-3902

[GitHub] thrift issue #1105: THRIFT-3902 TFramedTransport.open throws NullPointerExce...

2016-10-02 Thread nsuke
Github user nsuke commented on the issue: https://github.com/apache/thrift/pull/1105 nvm it was #1104 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or

[GitHub] thrift pull request #1104: THRIFT-3940 Visual Studio project file for compil...

2016-10-02 Thread nsuke
Github user nsuke closed the pull request at: https://github.com/apache/thrift/pull/1104 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] thrift issue #1104: THRIFT-3940 Visual Studio project file for compiler is b...

2016-10-02 Thread nsuke
Github user nsuke commented on the issue: https://github.com/apache/thrift/pull/1104 merged as d8c6a848 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or

[GitHub] thrift issue #1105: THRIFT-3902 TFramedTransport.open throws NullPointerExce...

2016-10-02 Thread nsuke
Github user nsuke commented on the issue: https://github.com/apache/thrift/pull/1105 merged as d8c6a848 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or

[GitHub] thrift pull request #1105: THRIFT-3902 TFramedTransport.open throws NullPoin...

2016-10-02 Thread nsuke
Github user nsuke closed the pull request at: https://github.com/apache/thrift/pull/1105 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] thrift pull request #1103: THRIFT-3932: fixed ThreadManager concurrency issu...

2016-10-02 Thread nsuke
Github user nsuke commented on a diff in the pull request: https://github.com/apache/thrift/pull/1103#discussion_r81472348 --- Diff: lib/cpp/src/thrift/concurrency/ThreadManager.cpp --- @@ -339,103 +357,88 @@ void ThreadManager::Impl::addWorker(size_t value) { idMap_

[GitHub] thrift issue #1103: THRIFT-3932: fixed ThreadManager concurrency issues, add...

2016-10-02 Thread nsuke
Github user nsuke commented on the issue: https://github.com/apache/thrift/pull/1103 It looks succeeding to me :tada: --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and

[GitHub] thrift pull request #1101: THRIFT-3937: if the compiler is too old (gcc befo...

2016-10-02 Thread nsuke
Github user nsuke commented on a diff in the pull request: https://github.com/apache/thrift/pull/1101#discussion_r81470849 --- Diff: build/cmake/DefineOptions.cmake --- @@ -164,31 +164,36 @@ message(STATUS "Thrift package version: ${PACKAGE_VE

[GitHub] thrift pull request #1101: THRIFT-3937: if the compiler is too old (gcc befo...

2016-10-02 Thread nsuke
Github user nsuke commented on a diff in the pull request: https://github.com/apache/thrift/pull/1101#discussion_r81470826 --- Diff: build/cmake/DefineOptions.cmake --- @@ -164,31 +164,36 @@ message(STATUS "Thrift package version: ${PACKAGE_VE

[GitHub] thrift pull request #1103: THRIFT-3932: fixed ThreadManager concurrency issu...

2016-10-02 Thread nsuke
Github user nsuke commented on a diff in the pull request: https://github.com/apache/thrift/pull/1103#discussion_r81470710 --- Diff: lib/cpp/src/thrift/concurrency/PosixThreadFactory.h --- @@ -39,7 +39,14 @@ class PosixThreadFactory : public ThreadFactory

[GitHub] thrift pull request #1101: THRIFT-3937: if the compiler is too old (gcc befo...

2016-10-02 Thread nsuke
Github user nsuke commented on a diff in the pull request: https://github.com/apache/thrift/pull/1101#discussion_r81464809 --- Diff: build/cmake/DefineOptions.cmake --- @@ -164,31 +164,36 @@ message(STATUS "Thrift package version: ${PACKAGE_VE

[GitHub] thrift pull request #1101: THRIFT-3937: if the compiler is too old (gcc befo...

2016-10-02 Thread nsuke
Github user nsuke commented on a diff in the pull request: https://github.com/apache/thrift/pull/1101#discussion_r81464790 --- Diff: build/cmake/DefineOptions.cmake --- @@ -164,31 +164,36 @@ message(STATUS "Thrift package version: ${PACKAGE_VE

[GitHub] thrift pull request #1103: THRIFT-3932: fixed ThreadManager concurrency issu...

2016-10-02 Thread nsuke
Github user nsuke commented on a diff in the pull request: https://github.com/apache/thrift/pull/1103#discussion_r81467563 --- Diff: lib/cpp/src/thrift/concurrency/ThreadManager.cpp --- @@ -339,103 +357,88 @@ void ThreadManager::Impl::addWorker(size_t value) { idMap_

[GitHub] thrift pull request #1103: THRIFT-3932: fixed ThreadManager concurrency issu...

2016-10-02 Thread nsuke
Github user nsuke commented on a diff in the pull request: https://github.com/apache/thrift/pull/1103#discussion_r81466362 --- Diff: lib/cpp/src/thrift/concurrency/ThreadManager.cpp --- @@ -292,28 +310,30 @@ class ThreadManager::Worker : public Runnable

[GitHub] thrift pull request #1103: THRIFT-3932: fixed ThreadManager concurrency issu...

2016-10-02 Thread nsuke
Github user nsuke commented on a diff in the pull request: https://github.com/apache/thrift/pull/1103#discussion_r81464488 --- Diff: lib/cpp/src/thrift/concurrency/PosixThreadFactory.h --- @@ -39,7 +39,14 @@ class PosixThreadFactory : public ThreadFactory

[GitHub] thrift pull request #1103: THRIFT-3932: fixed ThreadManager concurrency issu...

2016-10-02 Thread nsuke
Github user nsuke commented on a diff in the pull request: https://github.com/apache/thrift/pull/1103#discussion_r81467452 --- Diff: lib/cpp/src/thrift/concurrency/ThreadManager.cpp --- @@ -339,103 +357,88 @@ void ThreadManager::Impl::addWorker(size_t value) { idMap_

[GitHub] thrift pull request #1105: THRIFT-3902 TFramedTransport.open throws NullPoin...

2016-10-01 Thread nsuke
GitHub user nsuke opened a pull request: https://github.com/apache/thrift/pull/1105 THRIFT-3902 TFramedTransport.open throws NullPointerException You can merge this pull request into a Git repository by running: $ git pull https://github.com/nsuke/thrift THRIFT-3902

[GitHub] thrift pull request #1104: THRIFT-3940 Visual Studio project file for compil...

2016-10-01 Thread nsuke
GitHub user nsuke opened a pull request: https://github.com/apache/thrift/pull/1104 THRIFT-3940 Visual Studio project file for compiler is broken You can merge this pull request into a Git repository by running: $ git pull https://github.com/nsuke/thrift THRIFT-3940

[GitHub] thrift pull request #1099: THRIFT-3936: fix compile error on VS2013 and earl...

2016-09-28 Thread nsuke
Github user nsuke commented on a diff in the pull request: https://github.com/apache/thrift/pull/1099#discussion_r81000970 --- Diff: lib/cpp/src/thrift/TApplicationException.h --- @@ -21,6 +21,7 @@ #define _THRIFT_TAPPLICATIONEXCEPTION_H_ 1 #include +#include

[GitHub] thrift pull request #1100: THRIFT-3938 Python TNonblockingServer does not wo...

2016-09-28 Thread nsuke
GitHub user nsuke opened a pull request: https://github.com/apache/thrift/pull/1100 THRIFT-3938 Python TNonblockingServer does not work with SSL You can merge this pull request into a Git repository by running: $ git pull https://github.com/nsuke/thrift THRIFT-3938

[GitHub] thrift pull request #1099: THRIFT-3936: fix compile error on VS2013 and earl...

2016-09-28 Thread nsuke
Github user nsuke commented on a diff in the pull request: https://github.com/apache/thrift/pull/1099#discussion_r80976940 --- Diff: lib/cpp/src/thrift/TApplicationException.h --- @@ -21,6 +21,7 @@ #define _THRIFT_TAPPLICATIONEXCEPTION_H_ 1 #include +#include

[GitHub] thrift pull request #1099: THRIFT-3936: fix compile error on VS2013 and earl...

2016-09-28 Thread nsuke
Github user nsuke commented on a diff in the pull request: https://github.com/apache/thrift/pull/1099#discussion_r80975121 --- Diff: lib/cpp/src/thrift/TApplicationException.h --- @@ -21,6 +21,7 @@ #define _THRIFT_TAPPLICATIONEXCEPTION_H_ 1 #include +#include

[GitHub] thrift issue #1044: THRIFT-3873: fix compiler warnings on windows with VS201...

2016-09-28 Thread nsuke
Github user nsuke commented on the issue: https://github.com/apache/thrift/pull/1044 @jeking3 hi, sorry for the delay, what is your thought on "#define __STDC_LIMIT_MACROS + ..._MAX" v.s. numeric_limists<...>::max() ? If it were my own code, I would always use num

[GitHub] thrift pull request #1097: THRIFT-3934 Automatically resolve OpenSSL binary ...

2016-09-27 Thread nsuke
GitHub user nsuke opened a pull request: https://github.com/apache/thrift/pull/1097 THRIFT-3934 Automatically resolve OpenSSL binary version on Windows CI You can merge this pull request into a Git repository by running: $ git pull https://github.com/nsuke/thrift THRIFT-3934

[GitHub] thrift issue #1014: Thrift 3839

2016-09-26 Thread nsuke
Github user nsuke commented on the issue: https://github.com/apache/thrift/pull/1014 @sstach it's closed because it's merged to the master dd9885e --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your projec

[GitHub] thrift issue #1039: THRIFT-2835 Add possibility to distribute generators sep...

2016-09-25 Thread nsuke
Github user nsuke commented on the issue: https://github.com/apache/thrift/pull/1039 @dtmuller just committed, thanks for all the help and improvements ! It might have not happened at all if you didn't pick it up and revive it ... --- If your project is set up for it, yo

[GitHub] thrift pull request #1022: THRIFT-3845

2016-09-25 Thread nsuke
Github user nsuke commented on a diff in the pull request: https://github.com/apache/thrift/pull/1022#discussion_r80386819 --- Diff: compiler/cpp/src/generate/t_php_generator.cc --- @@ -1341,9 +1341,13 @@ void t_php_generator::generate_process_function(t_service* tservice

[GitHub] thrift pull request #1022: THRIFT-3845

2016-09-25 Thread nsuke
Github user nsuke commented on a diff in the pull request: https://github.com/apache/thrift/pull/1022#discussion_r80386881 --- Diff: lib/php/lib/Thrift/Protocol/TBinaryProtocolAccelerated.php --- @@ -62,4 +62,9 @@ public function isStrictWrite() { return $this

[GitHub] thrift pull request #1095: THRIFT-3826 Appveyor builds cannot download winfl...

2016-09-25 Thread nsuke
GitHub user nsuke opened a pull request: https://github.com/apache/thrift/pull/1095 THRIFT-3826 Appveyor builds cannot download winflexbison properly You can merge this pull request into a Git repository by running: $ git pull https://github.com/nsuke/thrift THRIFT-3826

[GitHub] thrift issue #1084: THRIFT-3773 Swift 3 Native Library

2016-09-12 Thread nsuke
Github user nsuke commented on the issue: https://github.com/apache/thrift/pull/1084 There's a substantial amount of code duplication with existing swift generator. Do you have any idea as to reducing them ? As I've never seen anyone advocating the current practice

[GitHub] thrift issue #1039: THRIFT-2835 Add possibility to distribute generators sep...

2016-09-12 Thread nsuke
Github user nsuke commented on the issue: https://github.com/apache/thrift/pull/1039 @dtmuller as you may have noticed I've squashed commits for merging in #368. If there's no concern I'll push them within a week or so. --- If your project is set up for it, you ca

[GitHub] thrift issue #1048: Ensuring that HTTP failures will clear the http transpor...

2016-09-04 Thread nsuke
Github user nsuke commented on the issue: https://github.com/apache/thrift/pull/1048 @thomas07vt hi thanks for the patch. The change makes sense to me. Could you file an issue on our JIRA, if you haven't done so ? https://github.com/apache/thrift/blob/master/CONTRIBUTI

[GitHub] thrift pull request #1070: THRIFT-3907 Skip Docker image build on CI when un...

2016-09-04 Thread nsuke
Github user nsuke closed the pull request at: https://github.com/apache/thrift/pull/1070 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] thrift issue #1070: THRIFT-3907 Skip Docker image build on CI when unchanged

2016-09-04 Thread nsuke
Github user nsuke commented on the issue: https://github.com/apache/thrift/pull/1070 superceded by #1079 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] thrift pull request #1081: THRIFT-3854 add a way in java to clear TFramedTra...

2016-09-04 Thread nsuke
GitHub user nsuke opened a pull request: https://github.com/apache/thrift/pull/1081 THRIFT-3854 add a way in java to clear TFramedTransport read buffers imported from JIRA issue. You can merge this pull request into a Git repository by running: $ git pull https://github.com

[GitHub] thrift pull request #1080: THRIFT-3891 TNonblockingServer configured with mo...

2016-09-04 Thread nsuke
GitHub user nsuke opened a pull request: https://github.com/apache/thrift/pull/1080 THRIFT-3891 TNonblockingServer configured with more than one IO threa… …ds does not always return from serve() upon stop() imported from JIRA issue. You can merge this pull request into

[GitHub] thrift pull request #1077: THRIFT-3900 Add Python SSL flags

2016-09-04 Thread nsuke
GitHub user nsuke opened a pull request: https://github.com/apache/thrift/pull/1077 THRIFT-3900 Add Python SSL flags imported from JIRA issue. You can merge this pull request into a Git repository by running: $ git pull https://github.com/nsuke/thrift THRIFT-3900

[GitHub] thrift pull request #1078: THRIFT-3919 C# TTLSServerSocket does not use clie...

2016-09-04 Thread nsuke
GitHub user nsuke opened a pull request: https://github.com/apache/thrift/pull/1078 THRIFT-3919 C# TTLSServerSocket does not use clientTimeout You can merge this pull request into a Git repository by running: $ git pull https://github.com/nsuke/thrift THRIFT-3919

[GitHub] thrift pull request #1079: THRIFT-3918 Run subset of make cross

2016-09-04 Thread nsuke
GitHub user nsuke opened a pull request: https://github.com/apache/thrift/pull/1079 THRIFT-3918 Run subset of make cross You can merge this pull request into a Git repository by running: $ git pull https://github.com/nsuke/thrift THRIFT-3918 Alternatively you can review and

[GitHub] thrift issue #345: THRIFT-2926: JS: Binary protocol with unit tests.

2016-09-04 Thread nsuke
Github user nsuke commented on the issue: https://github.com/apache/thrift/pull/345 @ebremer none that I'm not aware of. You can use lib/nodejs code with browserify (or probably webpack), though. --- If your project is set up for it, you can reply to this email and have

[GitHub] thrift pull request #1076: THRIFT-3917 Check backports.ssl_match_hostname mo...

2016-09-02 Thread nsuke
GitHub user nsuke opened a pull request: https://github.com/apache/thrift/pull/1076 THRIFT-3917 Check backports.ssl_match_hostname module version You can merge this pull request into a Git repository by running: $ git pull https://github.com/nsuke/thrift THRIFT-3917

[GitHub] thrift issue #1075: THRIFT-3916 Throw proper errors from JS, not strings

2016-09-02 Thread nsuke
Github user nsuke commented on the issue: https://github.com/apache/thrift/pull/1075 @SimenB we have `Dokerfile` s for build env inside build/docker/ subdirectories. You can also do `docker pull thrift/ubuntu` or thrift/debian. --- If your project is set up for it, you can reply

[GitHub] thrift pull request #1074: THRIFT-3911 Loosen Ruby dev dependency version re...

2016-08-28 Thread nsuke
GitHub user nsuke opened a pull request: https://github.com/apache/thrift/pull/1074 THRIFT-3911 Loosen Ruby dev dependency version requirements You can merge this pull request into a Git repository by running: $ git pull https://github.com/nsuke/thrift THRIFT-3911

[GitHub] thrift pull request #1073: THRIFT-3910 Do not invoke pip as part of build pr...

2016-08-28 Thread nsuke
GitHub user nsuke opened a pull request: https://github.com/apache/thrift/pull/1073 THRIFT-3910 Do not invoke pip as part of build process You can merge this pull request into a Git repository by running: $ git pull https://github.com/nsuke/thrift THRIFT-3910 Alternatively

[GitHub] thrift pull request #1072: THRIFT-3909 Fix c_glib static lib CMake build

2016-08-28 Thread nsuke
GitHub user nsuke opened a pull request: https://github.com/apache/thrift/pull/1072 THRIFT-3909 Fix c_glib static lib CMake build You can merge this pull request into a Git repository by running: $ git pull https://github.com/nsuke/thrift THRIFT-3909 Alternatively you can

  1   2   3   4   5   6   >