Heads up: small Fission experiment starting in 88 Beta

2021-03-18 Thread Chris Peterson
% (50% Fission + 50% control) during 88 Nightly. If you have questions or concerns, please email me or drop by the #fission channel in Matrix or Slack. chris ___ dev-platform mailing list dev-platform@lists.mozilla.org https://lists.mozilla.org/listinf

Re: C++ PSA: Use [[nodiscard]] instead of MOZ_MUST_USE

2021-03-16 Thread Chris Peterson
. Because this change would touch so many files, it's probably not worth the trouble. Bug 1628542 On 12/21/2020 4:20 PM, Chris Peterson wrote: Now that Firefox is compiled as C++17 (bug 1560664), you can use C++17's [[nodiscard]] attribute [1] instead of the MOZ_MUST_USE macro (def

Re: User-facing benefits from UA exposure of Android version and Linux CPU architecture

2021-02-18 Thread Chris Peterson
On 2/18/2021 3:51 AM, Henri Sivonen wrote: As for the CPU architecture on Linux, on Mac and Windows we don't expose aarch64 separately. (On Windows, consistent with Edge, aarch64 looks like x86. On Mac, aarch64 looks like x86_64 which itself doesn't differ from what x86 looked like.) As an alte

C++ PSA: Use [[nodiscard]] instead of MOZ_MUST_USE

2020-12-21 Thread Chris Peterson
Now that Firefox is compiled as C++17 (bug 1560664), you can use C++17's [[nodiscard]] attribute [1] instead of the MOZ_MUST_USE macro (defined using clang and gcc's non-standard __attribute__((warn_unused_result))). I have been slowly replacing MOZ_MUST_USE with [[nodiscard]] in my free time

Re: Improvement to build times through cleanup of C++ include dependencies

2020-12-14 Thread Chris Peterson
On 12/14/2020 3:23 AM, Simon Giesecke wrote: I was using some tools to support this, notably ClangBuildAnalyzer [2] and include-what-you-use [3]. ClangBuildAnalyzer helped to detect headers that are expensive to parse throughout the build, and direct efforts to reduce those specifically. But ther

Re: Tree Closing Window (TCW): July 18

2020-07-19 Thread Chris Cooper
still being closed. There is another TCW in 3 weeks where we hope to try again, provided we understand the upgrade performance better. Thanks for your patience. cheers, -- coop On Fri, Jul 17, 2020 at 7:04 PM Chris Cooper wrote: > > Just a reminder that this TCW is happening *tomorrow*, J

Re: Tree Closing Window (TCW): July 18

2020-07-17 Thread Chris Cooper
Just a reminder that this TCW is happening *tomorrow*, July 18. Trees will be closed for 12 hours for Taskcluster database updates starting at 1400 UTC. As always, if we can open the trees early, we will. cheers, -- coop On Fri, Jul 3, 2020 at 3:37 PM Chris Cooper wrote: > > Hey all,

Tree Closing Window (TCW): July 18

2020-07-03 Thread Chris Cooper
Hey all, We will be having a TCW on Saturday, July 18. The trees will close at 1400 UTC and will be down for approximately 12 hours. The only work that is currently planned is Phase 2 of the Taskcluster database migration. Phase 1 was completely successfully back in April[1]. Taskcluster for fir

Re: Shutting down legacy Taskcluster deployment

2020-06-26 Thread Chris Cooper
t URL at > https://github.com/mozilla/mozregression/blob/3df977cf7b9c50bdbe8495cde17baeb6c5724be2/mozregression/config.py#L23 > which gets used. It would be valuable to ensure mozregression can > continue bisecting old builds after this decommissioning happens. > > On Thu, Jun 25,

Shutting down legacy Taskcluster deployment

2020-06-25 Thread Chris Cooper
d artifacts. If you are one of the few individuals who does access artifacts from the legacy cluster and haven't already spoken to us about alternatives, please reach out before next Thursday. Note: this will *not* affect day-to-day CI on either the Firefox CI or Community clusters at all.

Re: Please don't use functions from ctype.h and strings.h

2020-06-24 Thread Chris Peterson
On 8/27/2018 7:00 AM, Henri Sivonen wrote: I think it's worthwhile to have a lint, but regexps are likely to have false positives, so using clang-tidy is probably better. A bug is on file:https://bugzilla.mozilla.org/show_bug.cgi?id=1485588 On Mon, Aug 27, 2018 at 4:06 PM, Tom Ritter wrote: I

Re: PSA: Python min version bumped to 3.6 for building gecko

2020-06-10 Thread Chris AtLee
The pyenv[1] project is a great way to manage multiple versions of python on your system. I've found it easier than trying to compile directly from source. Cheers, Chris [1] https://github.com/pyenv/pyenv On Wed, 10 Jun 2020 at 16:52, Kartikaya Gupta wrote: > For those of you who lik

Re: Testing Rust code in tree

2020-05-12 Thread Chris Hutten-Czapski
Glean Team here. Can confirm that libxul-provided symbols aren't in rusttests builds at present (Rust stuff is built first then wrapped in the loving embrace of libxul). We do write rusttests in our crates that (currently) have no Gecko symbols (see toolkit/components/glean/api/), but have ended up

Reimplementing MOZ_ALWAYS_TRUE() using MOZ_DIAGNOSTIC_ASSERT() instead of MOZ_ASSERT()

2020-04-06 Thread Chris Peterson
Heads up: In 77 Nightly, I plan to reimplement MOZ_ALWAYS_TRUE() using MOZ_DIAGNOSTIC_ASSERT() instead of MOZ_ASSERT(). This is bug 1620152. MOZ_ALWAYS_TRUE(X) and friends [1] are like MOZ_ASSERT(X), except they also evaluate the expression X in release builds. This is useful for silencing w

Re: New and improved stack-fixing

2020-03-12 Thread Chris Hutten-Czapski
This is wonderful news! The most recent time I interacted with this was tracking down a refcount leak. I was following the instructions at [1] which as of yet mention `fix_linux_stack.py`. Would you like me to file a bug for that to be fixed? I'd edit it directly, but I'm not confident I'd get th

Re: [blink-dev] Re: What to do about scroll anchoring?

2020-02-20 Thread Chris Harrelson
Hi Emlio, Thanks for your patience with these fixes and taking the time to outline your concerns. Hope things are better now, and as always, if not just say so. :) Chris On Thu, Feb 20, 2020 at 7:39 AM Emilio Cobos Álvarez wrote: > A quick status update here: > > I landed some heur

Fission meetings at the Berlin All Hands

2020-01-29 Thread Chris Peterson
The Fission team will be hosting a few meetings at the Berlin All Hands to help Firefox frontend and Gecko engineers convert their code to Fission's async APIs. Step 1: attend the "Introduction to Fission Engineering" presentation to get an overview and code examples of Fission: * Sched: ht

How To: Data Review in Components

2020-01-21 Thread Chris Hutten-Czapski
Hello! We here in Data Stewardship have been receiving inquiries about how the Data Collection Review process[0] works now that more products are being built out of reusable components. What follows is a memo about how to approach Data Review when you're adding a data collection to a reusable com

Shorter Data Collection Review Form For Renewals

2019-12-20 Thread Chris Hutten-Czapski
g one. Checking in on it every six months or so is a good way to ensure that it continues to meet your needs. It also leads to good data hygiene as unused collections will then turn themselves off, saving our users (and Mozilla's!) bandwidth and storage costs. -The Data Stewardship Steering Committ

Re: [blink-dev] Re: What to do about scroll anchoring?

2019-11-06 Thread Chris Harrelson
HI Emilio, I'll follow up on crbug.com/920289. Let's discuss there. On Tue, Oct 29, 2019 at 3:03 PM Emilio Cobos Álvarez wrote: > Hi all, > > 10/18/19 7:19 PM, Chris Harrelson wrote: > > Hi, > > > > Another quick update: Emilio, Navid, Nick, Stefan an

Fwd: Reminder: Planned Taskcluster migration this weekend (Nov 9)

2019-11-04 Thread Chris Cooper
On Monday, November 4, 2019 at 5:00:17 PM UTC-5, Chris Cooper wrote: > > tl;dr: > > Taskcluster, the platform supporting Firefox CI, will be moving to a new > hosting environment during the tree closing window (TCW) this coming > Saturday, Nov 9. Trees will be closed from

Reminder: Planned Taskcluster migration this weekend (Nov 9)

2019-11-04 Thread Chris Cooper
tl;dr: Taskcluster, the platform supporting Firefox CI, will be moving to a new hosting environment during the tree closing window (TCW) this coming Saturday, Nov 9. Trees will be closed from 14:00 UTC to 23:00 UTC. CI services will be available as soon as possible thereafter, pending verifica

Re: [blink-dev] Re: What to do about scroll anchoring?

2019-10-18 Thread Chris Harrelson
them, with the review and feedback support of Emilio. Thanks all, Chris On Thu, Oct 10, 2019 at 2:13 PM Rick Byers wrote: > Sorry for the delay. > > We agree that scroll anchoring has unrealized potential to be valuable for > the web at large, and to make that happen we should be inv

Re: [blink-dev] Re: What to do about scroll anchoring?

2019-10-16 Thread Chris Harrelson
On Sun, Sep 29, 2019 at 2:24 PM Emilio Cobos Álvarez wrote: > pretty significant behavior differences were only > caught later by me and people finding compat issues in the wild, like > [3]. I was sad that the spec reflected absolutely nothing like what > Blink implements. For this issue in part

Re: Must we rebuild all our rust code constantly?

2019-08-22 Thread Chris M.
On Mon, Aug 19, 2019 at 10:32 PM Kris Maglione wrote: > On Tue, Aug 20, 2019 at 02:23:06PM +0900, ISHIKAWA,chiaki wrote: > >On 2019/08/20 9:11, Dave Townsend wrote: > >>Thanks to a tip I've tracked this down. This seems to only be the case > when > >>I have sccache enabled. Disabling it gives me

Re: Must we rebuild all our rust code constantly?

2019-08-22 Thread Chris M.
On Tue, Aug 20, 2019 at 12:33 PM Markus Stange wrote: > On 2019-08-19 8:11 p.m., Dave Townsend wrote: > > Thanks to a tip I've tracked this down. This seems to only be the case > when > > I have sccache enabled. Disabling it gives me nice quick incremental > builds > > again. > > What's your scca

"products" key now required for new Telemetry metrics

2019-07-16 Thread Chris Hutten-Czapski
Hello, As part of the project to report GeckoView metrics in Fenix, we have made the `products` key required for metrics definitions in Histograms.json, Scalars.yaml, and Events.yaml. The products key identifies which "products" (for a hand-wavy definition of the word 'product') you want your

Re: Coding style 🙄 : `int` vs `intX_t` vs `unsigned/uintX_t`

2019-07-05 Thread Chris Peterson
On 7/5/2019 10:39 AM, Gijs Kruitbosch wrote: FWIW once in a while I have come across bugs caused by truncation of integers where someone picked a specific size that was too small also, e.g. storing an offset into a text node in a 16-bit integer.  I think that's maybe something that's hiding bet

Re: Using Google styling of #define guards

2019-07-03 Thread Chris Peterson
On 7/3/2019 11:37 AM, Bryce Seager van Dyk wrote: I wanted to clarify, and discuss if needed, our styling of #define guards. My understanding is that we are now using Google's style in regards to #define guards (https://google.github.io/styleguide/cppguide.html#The__define_Guard). I believe th

Re: Running C++ early in shutdown without an observer

2019-06-07 Thread Chris Peterson
On 6/7/2019 9:36 AM, Kris Maglione wrote: On Fri, Jun 07, 2019 at 09:18:38AM +0300, Henri Sivonen wrote: For late shutdown cleanup, we have nsLayoutStatics::Shutdown(). Do we have a similar method for running things as soon as we've decided that the application is going to shut down? (I know th

Re: To what extent is sccache's distributed compilation usable?

2019-06-07 Thread Chris M.
followed there, or tracked by https://bugzilla.mozilla.org/show_bug.cgi?id=1499145. Chris On Wed, Jun 5, 2019 at 1:52 AM Miko Mynttinen wrote: > Has there been any progress with this? Bug 1524533 is still restricted. > > Miko > > > On Apr 2, 2019, at 10:39 PM, Jeff Muizelaar

Re: Remove browser and OS architecture from Firefox's User-Agent string?

2019-05-14 Thread Chris Peterson
On 5/14/2019 9:53 AM, Tom Ritter wrote: On Tue, May 14, 2019 at 4:26 PM L. David Baron wrote: So I think there's may be value in removing these distinctions from the User-Agent header we send over HTTP even if they're still accessible from Javascript (and useful there for sites offering downloa

Re: Remove browser and OS architecture from Firefox's User-Agent string?

2019-05-14 Thread Chris Peterson
On 5/11/2019 8:59 AM, Henri Sivonen wrote: "Mozilla/5.0 (Windows NT 10.0; rv:66.0) Gecko/20100101 Firefox/66.0" Would there be significant downsides to hard-coding the Windows version to "10.0" in order to put Windows 7 and 8.x users in the same anonymity set with Windows 10 users? ... > Meanw

Re: Remove browser and OS architecture from Firefox's User-Agent string?

2019-05-13 Thread Chris Peterson
On 5/11/2019 4:11 AM, j.j. wrote: < "Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:66.0) Gecko/20100101 Firefox/66.0" > "Mozilla/5.0 (Windows NT 10.0; rv:66.0) Gecko/20100101 Firefox/66.0" Note that "navigator.oscpu" returns "Windows NT 6.1; Win64; x64" or similar. This needs to change the

Remove browser and OS architecture from Firefox's User-Agent string?

2019-05-10 Thread Chris Peterson
Hello, UA string fans! I propose that Firefox's UA string on Windows and Linux omit the browser and OS architectures to reduce UA fingerprinting entropy (and save a few header bytes). I have tentative thumbs up from some webcompat and privacy people, but as there is no official module owner fo

Fwd: Changes to about:telemetry -- Now With Processes!

2019-05-10 Thread Chris Hutten-Czapski
Hello! about:telemetry, the UI that allows you to browse current and historical Telemetry data in Firefox, is changing slightly. Starting with bug 1437446 (presently on autoland) it will default to showing you the Telemetry collected in all process types (previously it would show only the "current

Re: Fennec moving to extended support

2019-04-29 Thread Chris Peterson
d Android code that first lands in the Reference Browser. https://github.com/mozilla-mobile/reference-browser/blob/master/README.md#test-channel-on-google-play-store chris ___ dev-platform mailing list dev-platform@lists.mozilla.org https://lists.mozilla.org/listinfo/dev-platform

Re: To what extent is sccache's distributed compilation usable?

2019-04-01 Thread Chris M.
On Mon, Apr 1, 2019 at 12:23 PM Emilio Cobos Álvarez wrote: > Hi, > > Over in #layout people were ranting about how much of a pain it was to > set up icecc on MacOS. I pointed out that sccache in theory does support > distributed compilation[1] and in theory also supports MacOS clients. > > Does

Re: PSA: Min clang / libclang requirement was updated not long ago...

2019-02-26 Thread Chris Peterson
Seems like mach bootstrap should have a clobber flag so anyone updating build tool dependencies can force people to re-run mach bootstrap (and save many people frustration). On 2/26/2019 10:00 AM, David Major wrote: Does configure warn about this? The link between this error and needing to b

Re: Type-based alias analysis and Gecko C++

2019-02-18 Thread Chris Peterson
On 2/17/2019 11:40 PM, Henri Sivonen wrote: Out of curiosity: Do we know if WebKit and Chromium compile with or without strict-aliasing? Chromium disabled strict aliasing in 2010 [1] and then in 2013 WONTFIX'd the bug that would re-enable strict aliasing[2]. The WONTFIX discussion [3] reporte

Re: W3C Proposed Recommendation: Web Authentication

2019-02-11 Thread Chris Mills
well be in touch with questions soon ;-) --- Chris Mills MDN content lead & writers' team manager MDN Web Docs Mozilla @chrisdavidmills [0] https://developer.mozilla.org/en-US/docs/Web/API/Credential_Management_API <https://developer.mozilla.org/en-US/docs/Web/API/Credential_Manage

Re: Proposal to adjust testing to run on PGO builds only and not test on OPT builds

2019-01-08 Thread Chris M.
end up wanting to turn off opt builds in automation after all we may be able to pull artifacts from pgo builds for local artifact builds by default. The behavior of the compiled code shouldn't be different -- this probably wouldn't matter to people developing front end code locally. Chri

Re: Proposal to adjust testing to run on PGO builds only and not test on OPT builds

2019-01-03 Thread Chris AtLee
Thank you Joel for writing up this proposal! Are you also proposing that we stop the linux64-opt and win64-opt builds as well, except for leaving them as an available option on try? If we're not testing them on integration or release branches, there doesn't seem to be much purpose in doing the bui

Re: Intent to Implement: css-scroll-anchoring

2018-11-14 Thread Chris Peterson
This is great news! In a recent study of Fennec's perceived performance, users ranked 16 criteria for evaluating mobile browser responsiveness. #1 was "Not having the page jump around when scrolling". For a point of reference for just how important that is, "Loading a website" was only #3. :)

Re: Announcing new test platform "Android 7.0 x86"

2018-11-01 Thread Chris Peterson
On 2018-11-01 3:06 PM, Nicholas Alexander wrote: Like the existing "Android 4.2" and "Android 4.3" test platforms, these tests run in an Android emulator running in a docker container (the same Ubuntu-based image used for linux64 tests). The new platform runs an x86 emulator using kvm accelerati

Re: Better incremental builds - Tup backend available on Linux

2018-10-04 Thread Chris M.
On Fri, Sep 28, 2018 at 12:56 PM Michael Shal wrote: > Hi everyone, > > Tup is a modern build system that enables fast and correct builds. I'm > pleased to announce the availability of Tup for building Firefox on Linux. > Compared to Make, building with Tup will result in faster incremental build

Re: Better incremental builds - Tup backend available on Linux

2018-10-01 Thread Chris M.
On Mon, Oct 1, 2018 at 8:05 AM Randell Jesup wrote: > >Tup is a modern build system that enables fast and correct builds. I'm > >pleased to announce the availability of Tup for building Firefox on Linux. > >Compared to Make, building with Tup will result in faster incremental > build > >times and

Re: Input Delay Metric proposal

2018-09-25 Thread Chris Hutten-Czapski
For in-the-wild input delay not specifically during pageload we also measure INPUT_EVENT_RESPONSE_DELAY_MS[1] and (from Firefox 53-60 and then resuscitated in 64) INPUT_EVENT_RESPONSE_COALESCED_MS[2] which record[3] from the time the OS created the input event until the time when the process is don

Re: Intent to ship: Unprefixed Fullscreen API

2018-09-18 Thread Chris Pearce
On Tuesday, September 18, 2018 at 11:48:19 AM UTC+12, Xidorn Quan wrote: > As of Firefox 64, I intend to turn on unprefixed Fullscreen API by default on > all platforms. It has been developed behind the > full-screen-api.unprefix.enabled preference. > > Bug to turn on by default: > https://bugz

Re: CSS Scroll Snap Level 1

2018-09-05 Thread Chris Mills
> On Sep 5, 2018, at 11:05 AM, Cameron McCormack wrote: > > On Wed, Sep 5, 2018, at 7:30 PM, Chris Mills wrote: >> https://drafts.csswg.org/css-scroll-snap-1/ >> <https://drafts.csswg.org/css-scroll-snap-1/> >> >> Have we got any current or futu

CSS Scroll Snap Level 1

2018-09-05 Thread Chris Mills
https://drafts.csswg.org/css-scroll-snap-1/ <https://drafts.csswg.org/css-scroll-snap-1/> Have we got any current or future plans for implementing this in Gecko? Thanks, --- Chris Mills MDN content lead & writers' team manager MDN Web Docs @

Re: Intent to Ship: Shadow DOM and Custom Elements

2018-08-15 Thread Chris Peterson
On 2018-08-15 9:04 AM, smaug wrote: Why does https://caniuse.com/#feat=shadowdomv1 show Firefox 63 show not supported by default? No idea. I don't know who maintains caniuse and when the they update it. Please report to them that they may want to update the page. The caniuse data is m

Re: Intent to implement and ship: HTMLMediaElement.allowedToPlay

2018-08-09 Thread Chris Pearce
On Wednesday, August 8, 2018 at 4:58:28 PM UTC-7, Jan-Ivar Bruaroey wrote: > On 8/8/18 12:43 PM, Chris Pearce wrote: > > Hi Jib, > > > > I appreciate that you care passionately about our users' best interests. > > > > Seeing as you asked "why don

Re: Intent to implement and ship: HTMLMediaElement.allowedToPlay

2018-08-08 Thread Chris Pearce
On Wednesday, August 8, 2018 at 9:54:06 AM UTC-7, Boris Zbarsky wrote: > On 8/8/18 12:43 PM, Chris Pearce wrote: > > On Tuesday, August 7, 2018 at 7:51:50 PM UTC-7, Jan-Ivar Bruaroey wrote: > >> To clarify, I care about Netflix, which is why I question giving up on > >&

Re: Intent to implement and ship: HTMLMediaElement.allowedToPlay

2018-08-08 Thread Chris Pearce
Jan-Ivar Bruaroey wrote: > > On 8/1/18 3:36 AM, Chris Pearce wrote: > >> I think the only thing that you're missing is how vehemently some > >> sites are in their desire to avoid the doorhanger prompt. > > > > No, I'm also missing why we should listen t

Re: Intent to ship '-webkit-appearance' and changes to '-moz-appearance' values

2018-08-07 Thread Chris Peterson
Awesome! This should fix some common webcompat issues for Firefox/GeckoView on Android. What are the criteria for letting -webkit-appearance ride the trains? The GeckoView team is eager to ship mobile webcompat fixes, so they might be willing to accept more risk than Firefox desktop. Are the

Re: Intent to implement and ship: HTMLMediaElement.allowedToPlay

2018-08-01 Thread Chris Pearce
On Tuesday, July 31, 2018 at 9:05:03 AM UTC+12, Jan-Ivar Bruaroey wrote: > On 7/29/18 10:39 PM, Chris Pearce wrote: > > Summary: HTMLMediaElement.allowedToPlay allows web authors to determine in > > advance of calling HTMLMediaElement.play() whether the HTMLMediaElement in > &

Intent to implement and ship: HTMLMediaElement.allowedToPlay

2018-07-29 Thread Chris Pearce
Summary: HTMLMediaElement.allowedToPlay allows web authors to determine in advance of calling HTMLMediaElement.play() whether the HTMLMediaElement in its current state would be allowed to play, or would be blocked by the browser's autoplay blocking policies. This is useful to web authors as if

Re: Intent to ship: block audible autoplay media intervention

2018-07-20 Thread Chris Pearce
On Wednesday, July 4, 2018 at 11:38:21 AM UTC+12, Chris Pearce wrote: > Intent to ship: block audible autoplay media intervention > > SUMMARY: > > We intend to change the behaviour of HTMLMediaElement to block autoplay of > audible audio and video in Firefox on desktop and m

Re: Intent to ship: block audible autoplay media intervention

2018-07-15 Thread Chris Pearce
On Tuesday, July 10, 2018 at 7:30:38 AM UTC+12, Mounir Lamouri wrote: > On Fri, 6 Jul 2018, at 15:35, Chris Pearce wrote: > > On Saturday, July 7, 2018 at 5:04:28 AM UTC+12, Mounir Lamouri wrote: > > > On Fri, 6 Jul 2018, at 00:49, Chris Pearce wrote: > > > > On Frid

Re: Using clang-cl to ship Windows builds

2018-07-10 Thread Chris Peterson
How does the performance of clang-cl builds compare to MSVC builds on benchmarks like Speedometer? On 2018-07-10 1:29 PM, David Major wrote: Bug 1443590 is switching our official Windows builds to use clang-cl as the compiler. Please keep an eye out for regressions and file a blocking bug for

Re: Intent to ship: block audible autoplay media intervention

2018-07-06 Thread Chris Pearce
On Saturday, July 7, 2018 at 5:04:28 AM UTC+12, Mounir Lamouri wrote: > On Fri, 6 Jul 2018, at 00:49, Chris Pearce wrote: > > On Friday, July 6, 2018 at 3:10:58 AM UTC+12, Mounir Lamouri wrote: > > > On Wed, 4 Jul 2018, at 18:22, Chris Pearce wrote: > > > > Hi Mo

Re: Intent to ship: block audible autoplay media intervention

2018-07-05 Thread Chris Pearce
On Friday, July 6, 2018 at 3:10:58 AM UTC+12, Mounir Lamouri wrote: > On Wed, 4 Jul 2018, at 18:22, Chris Pearce wrote: > > Hi Mounir, > > > > Replies inline below... > > > > > > On Thu, Jul 5, 2018 at 2:56 AM, Mounir Lamouri wrote: > > > >

Re: Intent to ship: block audible autoplay media intervention

2018-07-04 Thread Chris Pearce
Hi Mounir, Replies inline below... On Thu, Jul 5, 2018 at 2:56 AM, Mounir Lamouri wrote: > Hi Chris, > > Very excited to see Firefox going forward with autoplay blocking. A couple > of comments inline. > > On Tue, 3 Jul 2018, at 19:38, Chris Pearce wrote: > > DETAI

Re: Event Telemetry now sent on "event" pings instead of "main" pings

2018-07-04 Thread Chris Hutten-Czapski
More details in a more narrative-focused format can be found in the blog post here: https://chuttenblog.wordpress.com/2018/07/04/faster-event-telemetry-with-event-pings/ :chutten On Wed, Jun 27, 2018 at 10:02 AM Chris Hutten-Czapski wrote: > Hello, > > Due to a forecast increase

Intent to ship: block audible autoplay media intervention

2018-07-03 Thread Chris Pearce
Intent to ship: block audible autoplay media intervention SUMMARY: We intend to change the behaviour of HTMLMediaElement to block autoplay of audible audio and video in Firefox on desktop and mobile. We are not going to block WebAudio at the same time. While we do plan to block audible autopla

Event Telemetry now sent on "event" pings instead of "main" pings

2018-06-27 Thread Chris Hutten-Czapski
Hello, Due to a forecast increase in demand for Event Telemetry, we have (via bug 1460595) moved Event Telemetry transmission from the "main" ping to special-purpose "event" pings. This has a couple of benefits, most notably that they are sent more often (less latency) and can also send more

Re: Launch of Phabricator and Lando for mozilla-central

2018-06-06 Thread Chris AtLee
This is really great news, I'm really excited to start using it! Automated landings from code review is such a game changer for productivity and security. Congrats to everyone involved. Cheers, Chris On Wed, 6 Jun 2018 at 11:01, Mark Côté wrote: > > The Engineering Workflow team

Re: Removing tinderbox-builds from archive.mozilla.org

2018-05-31 Thread Chris AtLee
On Tue, 29 May 2018 at 14:21, L. David Baron wrote: > > On Monday 2018-05-28 15:52 -0400, Chris AtLee wrote: > > Here's a bit of a strawman proposal...What if we keep the > > {mozilla-central,mozilla-inbound,autoland}-{linux,linux64,macosx64,win32,win64}{,-pgo}/ >

Re: Removing tinderbox-builds from archive.mozilla.org

2018-05-28 Thread Chris AtLee
On Sun, 20 May 2018 at 19:40, Karl Tomlinson wrote: > On Fri, 18 May 2018 13:13:04 -0400, Chris AtLee wrote: > > IMO, it's not reasonable to keep CI builds around forever, so the question > > is then how long to keep them? 1 year doesn't quite cover a full ESR cycl

Re: Upcoming C++ standards meeting in Rapperswil, Switzerland

2018-05-23 Thread Chris Peterson
On 2018-05-23 1:35 PM, Botond Ballo wrote: There is also work being done in this area outside the formal standards process, in the form of the C++ Core Guidelines [2] (some of which can be checked statically) and the accompanying Guideline Support Library [3], and in the form of Microsoft's lifet

Re: Removing tinderbox-builds from archive.mozilla.org

2018-05-18 Thread Chris AtLee
The discussion about what to do about these particular buildbot builds has naturally shifted into a discussion about what kind of retention policy is appropriate for CI builds. I believe that right now we keep all CI build artifacts for 1 year. Nightly and release builds are kept forever. There's

Re: How to request documentation for new features or report problems on MDN

2018-05-17 Thread Chris Mills
Yes, what sheppy said ;-) Chris Mills MDN content lead & writers' team manager || Mozilla developer.mozilla.org || MDN Web Docs cmi...@mozilla.com || @chrisdavidmills > On 17 May 2018, at 05:27, Eric Shepherd (Sheppy) > wrote: > > Yes. Always, you're welcome to ma

How to request documentation for new features or report problems on MDN

2018-05-16 Thread Chris Mills
x27;t file "Developer Documentation" bugs for feature additions that already being tracked in an engineering bug. Instead, add the "dev-doc-needed" keyword to the engineering bug. We've had a few duplications recently because of this. Many thanks! Chris Mills MDN content

Re: Update on rustc/clang goodness

2018-05-15 Thread Chris Hutten-Czapski
Recently I found myself using the mozbuild-supplied clang for compiling Gecko on Linux (https://bugzilla.mozilla.org/show_bug.cgi?id=1451312). It works just peachily for me, and I find myself liking their error message decorators better than gcc's. Since we supply a compiler during bootstrap, it s

Re: PSA: C++ virtual function declarations should specify only one of virtual, final, or override

2018-02-16 Thread Chris Peterson
On 2018-02-16 12:54 PM, Ben Kelly wrote: Are we supposed to just use override or final on methods that are overriden when the class itself is marked final? Personally writing final again seems redundant with the class level final and the override keyword seems more informative. You could use e

Re: PSA: C++ virtual function declarations should specify only one of virtual, final, or override

2018-02-16 Thread Chris Peterson
On 2018-02-16 1:07 PM, L. David Baron wrote: virtual void Bad1() final I think there might be some legitimate use cases for this one, when a function needs to be virtual because it's required for the calling convention (as part of a binary plugin API or binary embedding API, for example), but

PSA: C++ virtual function declarations should specify only one of virtual, final, or override

2018-02-16 Thread Chris Peterson
Mozilla's C++ style guide [1] says (since 2015) virtual function declarations should specify only one of `virtual`, `final`, or `override`. Over the weekend, I will land a mach lint check (bug 1436263) that will warn about some virtual style violations such as: virtual void Bad1() final v

Chrome will start marking HTTP pages as "Not secure"

2018-02-08 Thread Chris Peterson
Chrome will start marking HTTP pages as "Not secure" in July 2018 (Chrome 68): https://security.googleblog.com/2018/02/a-secure-web-is-here-to-stay.html Firefox has a similar insecure HTTP warning icon, currently disabled by the `security.insecure_connection_icon.enabled` pref added in bug 131

Re: Use Counters were previously over-reporting, are now fixed.

2018-01-17 Thread Chris Hutten-Czapski
1 PM, Steve Fink wrote: > On 1/17/18 7:57 AM, Chris Hutten-Czapski wrote: > >> Hello, >> >>Use Counters[0] as reported by the Telemetry Aggregator (via the HTTPS >> API, and the aggregates dashboards on telemetry.mozilla.org) have been >> over-reporting

Use Counters were previously over-reporting, are now fixed.

2018-01-17 Thread Chris Hutten-Czapski
Hello, Use Counters[0] as reported by the Telemetry Aggregator (via the HTTPS API, and the aggregates dashboards on telemetry.mozilla.org) have been over-reporting usage since bug 1204994[1] (about the middle of September, 2015). They are now fixed [2], and in the course of fixing it, :gfritzsch

Re: PSA: Avoid invoking Debug formatters in release-mode Rust

2018-01-16 Thread Chris Peterson
On 2018-01-12 9:07 PM, Bobby Holley wrote: The most common way this seems to happen is in panic!() messages, where it can be tempting to include a stringified value to make the message more informative. Just a friendly reminder: panic messages that are parameterized to include debug data might

Re: Device Orientation API future

2018-01-10 Thread Chris Van Wiemeersch
Martin, you gave some reasonable mitigation steps earlier in this thread that I think are probably worth revisiting. Anne and Martin, can you think of changes to request for the Sensor API that we would resolve or reasonably improve the existing fingerprinting concerns? On Wed, Jan 10, 2018 at

Re: Nightly Start Time and Daylight Savings

2017-11-06 Thread Chris Peterson
On 2017-11-06 9:46 AM, Justin Wood wrote: Now with Taskcluster the start time is anchored in UTC so doesn't move along with Daylight Savings, currently anchoring at 10am and 10pm UTC. How long do the Nightly builds typically take? If the builds are started at 10am and 10pm UTC (2am and 5pm PST

“approval required” for changes affecting CI infrastructure

2017-11-03 Thread Chris AtLee
the overall system in the leadup to 57. If you don’t hear a response back in 24h, you can assume that your proposal is fine, and proceed to land it. Thanks in advance, Chris ___ dev-platform mailing list dev-platform@lists.mozilla.org https://lists.mozilla

Re: We need better canaries for JS code

2017-10-18 Thread Chris Peterson
On 2017-10-18 4:51 AM, Mark Banner wrote: I expect that this will find a number of lurking errorsy, so we may want to migrate code progressively, using a directive, say "use strict moz-platform" and static analysis to help encourage using this directive. It would definitely be interesting to fail

Re: Intent to unship: rel=preload for firefox 57

2017-10-12 Thread Chris Mills
I intent to land rel=preload for non-cacheable resources as well in next > couple of days. This will be on Firefox 58 and I will turn rel=preload back > on when this lands. What’s the bug number to track this work? thanks, Chris ___ dev-platfor

Re: Experimenting with a shared review queue for Core::Build Config

2017-10-11 Thread Chris Cooper
On Wed, Oct 11, 2017 at 1:46 PM, Nathan Froyd wrote: > Does this user have a bugzilla :alias so that folks submitting patches > via MozReview or similar can just write r=build-peer or something, > rather than having to manually select the appropriate shared queue > after submitting their patch for

Experimenting with a shared review queue for Core::Build Config

2017-10-11 Thread Chris Cooper
Many of the build peers have long review queues. I'm not convinced that all of the review requests going to any particular build peer need to be exclusive. We're going to try an experiment to see if we can make this better for patch authors and reviewers alike. To this end, we've set up a shared re

Setting expectations for sheriffing over the next month

2017-10-10 Thread Chris Cooper
Our code sheriffing bandwidth is greatly reduced right now. We continue to train up the SoftVision (SV) sheriffing contractors to assist with backouts and merges on a 24/7 basis, but they are not ready yet. What does this mean for you? In the short term, this means the sheriffs can only guarantee

Re: Changes to tab min-width

2017-10-05 Thread Chris Hutten-Czapski
I prefer the old behaviour, but I don't have a strong opinion on the matter. I think it's because I'm used to tab navigation by keyboard shortcut more than by mouse. I rearrange tabs so that they're close together. For everyone curious about how much of an outlier your subsessions are... on Nightl

Re: Changes to tab min-width

2017-10-03 Thread Chris Peterson
On 2017-10-03 2:18 PM, Boris Zbarsky wrote: Right now, at 60px, I can see 7-10 chars in a tab title.  This is sometimes (but not always) enough for me to make sense of what I'm looking at when the favicon is not helpful.  For example, for bugzilla bugs I can see the whole bug number. In the n

Re: test-verify now running as tier 2

2017-10-02 Thread Chris Peterson
This is very cool, Geoff! People have been talking about this idea for a long, so it is great to see it actually running. I'm glad to see chaos mode being tested, too. On 2017-10-02 10:11 AM, Geoffrey Brown wrote: Today the test-verify test task will start running as a tier 2 job. Look for th

Re: Follow up on clang-format

2017-09-28 Thread Chris Pearce
On Thursday, September 28, 2017 at 10:15:05 AM UTC+2, Chris Pearce wrote: > On Friday, May 23, 2014 at 3:29:48 AM UTC+2, Anthony Jones wrote: > > Some of you may remember the discussion on clang-format and the `mach > > clang-format` command. What we have in place right now is

Re: Follow up on clang-format

2017-09-28 Thread Chris Pearce
On Friday, May 23, 2014 at 3:29:48 AM UTC+2, Anthony Jones wrote: > Some of you may remember the discussion on clang-format and the `mach > clang-format` command. What we have in place right now is very temporary > but it is functional enough to give it a try. I have not put the effort > into upstr

Re: Coding style: Placement of binary operators when breaking a long line

2017-09-07 Thread Chris Peterson
On 2017-09-06 8:06 PM, Ehsan Akhgari wrote: The interesting points to consider is the data that Nick alluded to in the previous discussion about the existing prevalent style. Also, the point you up about the pragmatic aspect of the need to be able to use automated tools in order to manage our

Re: Device Memory header and JS API

2017-09-06 Thread Chris Peterson
On 2017-09-06 11:48 AM, Tom Ritter wrote: Steam's hardware survey shows the following distribution percentages. Less than 512 MB 0.00% 512 Mb to 999 MB 0.03% 1 GB 0.52% 2 GB 3.30% 3 GB 6.27% 4 GB 14.96% 5 GB 0.66% 6 GB 3.23% 7 GB 2.33% 8 GB 42.77% 9 GB 0.04% 10 GB 0.29% 11 GB 0.18% 12 G

Re: Stylo now the default configuration for mozilla-central

2017-09-05 Thread Chris Peterson
On 2017-09-05 1:10 PM, J. Ryan Stinnett wrote: Assuming bug 1330412 sticks, Stylo will be the default configuration for mozilla-central for all platforms except Android. Thanks to everyone involved with Stylo that helped us reach this stage! Awesome! Thanks for flipping the switch, Ryan. To

Re: Stylesheet wait timeout?

2017-08-31 Thread Chris Peterson
o not have stylo enabled per about:support ("false (disabled by default)"). Dustin 2017-08-31 13:45 GMT-04:00 Chris Peterson : Gerv, do you have Stylo enabled? Even if you did not flip the pref (layout.css.servo.enabled), you might be in the Stylo experiment for Nightly users. Check ab

Re: Stylesheet wait timeout?

2017-08-31 Thread Chris Peterson
Gerv, do you have Stylo enabled? Even if you did not flip the pref (layout.css.servo.enabled), you might be in the Stylo experiment for Nightly users. Check about:support for "Stylo". On 2017-08-31 10:24 AM, Gervase Markham wrote: On 18/08/17 12:11, Gervase Markham wrote: Whereas what I me

  1   2   3   4   5   6   >