[gem5-dev] Review Request: Enabled instruction fetch pipelining.

2011-05-24 Thread Lisa Hsu
--- This is an automatically generated e-mail. To reply, visit: http://reviews.m5sim.org/r/718/ --- Review request for Default, Ali Saidi, Gabe Black, Steve Reinhardt, and Nathan Binke

Re: [m5-dev] Review Request: Ruby: Correctly set access permissions for directory entries

2011-05-13 Thread Lisa Hsu
--- This is an automatically generated e-mail. To reply, visit: http://reviews.m5sim.org/r/684/#review1232 --- Ship it! Hi Nilay, I see no reason why this would not work with our prot

Re: [m5-dev] Review Request: Cache: fix vector stats in classic cache to have matching lengths

2011-04-23 Thread Lisa Hsu
kt->req->contextId() == -1); > > assert(FULL_SYSTEM); > > return stat[pkt->cmdToIndex()][_numSharingContexts]; > > } > > > > And do this: > > getThreadVectorStat(pkt, misses)++; > > getThreadVectorStat(pkt, misses) += 1; > >

Re: [m5-dev] Review Request: Cache: fix vector stats in classic cache to have matching lengths

2011-04-22 Thread Lisa Hsu
e beautiful either. Something returning the index seems messier to me. Then you'd need: int index = getIndex(pkt); statName[pkt->cmdToIndex()][index]++; everywhere, instead of: incrementStat(pkt, statName); or incrementStat(pkt->req->contextId(), statName); I think the latter

[m5-dev] Review Request: Cache: fix vector stats in classic cache to have matching lengths

2011-04-22 Thread Lisa Hsu
--- This is an automatically generated e-mail. To reply, visit: http://reviews.m5sim.org/r/654/ --- Review request for Default, Ali Saidi, Gabe Black, Steve Reinhardt, and Nathan Binke

Re: [m5-dev] Introducing...InOrder AlphaFS!

2011-04-21 Thread Lisa Hsu
Whoop whoop! On Apr 21, 2011 6:50 AM, "Steve Reinhardt" wrote: Way to go, Korey! On Thu, Apr 21, 2011 at 1:11 AM, Gabe Black wrote: > Tada! Congratulations ___ m5-dev mailing list m5-dev@m5sim.org http://m5sim.org/mailman/listinfo/m5-dev

Re: [m5-dev] Stats Bug

2011-04-20 Thread Lisa Hsu
quot;, line 84, in run elif m5.options.outdir: AttributeError: 'module' object has no attribute 'outdir' Lisa On Wed, Apr 20, 2011 at 10:43 AM, Lisa Hsu wrote: > Korey, that's awesome. If you've done it already, then by all means, let's > see it on t

Re: [m5-dev] Stats Bug

2011-04-20 Thread Lisa Hsu
Korey, that's awesome. If you've done it already, then by all means, let's see it on the review board. And Steve, you are right, Ruby does not do stats per context, though recently a set of my pushes made it possible to even pass that information to Ruby. Nothing in the tree takes advantage of i

Re: [m5-dev] Stats Bug

2011-04-20 Thread Lisa Hsu
There's more to it than that. I started it yesterday and I'll post a diff today and you can see what I mean. So one question to you Nate, is what do you prefer, doing a single #if FULL_SYSTEM in the C++, or doing a if buildEnv[FULL_SYSTEM] in the python so that the value passed into the C++ is al

Re: [m5-dev] Stats Bug

2011-04-19 Thread Lisa Hsu
Yes, Steve's got it right. In the C++ you replace the instances of the 3 lengths Nate mentions with a single var (that can be more aptly named as Steve wants) that is pythonically calculated and passed in from the configuration. I'm making up words here :). I think I can do this tonight or tomor

Re: [m5-dev] Stats Bug

2011-04-19 Thread Lisa Hsu
I think the immediate fix is the pythonic fix from a few msgs ago. I believe that's quick and easy. I think :). On Tue, Apr 19, 2011 at 2:27 PM, nathan binkert wrote: > I love that you guys want to fix this. Can we agree on the immediate > fix so it's no longer broken and then improve it? :)

Re: [m5-dev] Stats Bug

2011-04-19 Thread Lisa Hsu
Hi Korey, I suppose you could do that kind of walking, though I think it would be overly complicated. Let's say again you have 4 private L1s, 2 shared L2s, and a shared L3. If the L3 poked its port appropriately, I guess it could know that there are two things hanging off of it on the other side

Re: [m5-dev] Stats Bug

2011-04-19 Thread Lisa Hsu
a local var to one or the other and use that consistently > >>> rather than having #ifdefs all over the place. I'd lean toward #2 > >>> just to keep the output a little cleaner in SE mode. > >>> > >>> Does that make sense, Lisa? > >>>

Re: [m5-dev] Stats Bug

2011-04-18 Thread Lisa Hsu
I'm not sure I understand what the problem is either. Can different VectorStats not have different lengths? Lisa On Mon, Apr 18, 2011 at 11:43 AM, Gabriel Michael Black < gbl...@eecs.umich.edu> wrote: > My first reaction is "let's fix it", but I don't really understand the > problem or the impa

Re: [m5-dev] Interpreting and "Fixing" Ruby Stats??

2011-04-08 Thread Lisa Hsu
I don't have anything definitive about Ruby vs. M5 stats, but until there is anything definitive, I use both depending on what I'm trying to do. I've added my own M5 stats to the Ruby Caches because I know those stats much better, but I've also looked at existing Ruby stats when I know they answer

Re: [m5-dev] changeset in m5: CacheMemory: add allocateVoid() that is == allo...

2011-04-01 Thread Lisa Hsu
a simple way to get around it. C++ only gets angry if you have a variable that's never used. Lisa On Thu, Mar 31, 2011 at 7:46 PM, Nilay wrote: > Lisa, should not compiler yell in this case as well? > > Nilay > > > On Thu, March 31, 2011 8:22 pm, Lisa Hsu wrote: > >

[m5-dev] changeset in m5: CacheMemory: add allocateVoid() that is == allo...

2011-03-31 Thread Lisa Hsu
changeset c7302d55d644 in /z/repo/m5 details: http://repo.m5sim.org/m5?cmd=changeset;node=c7302d55d644 description: CacheMemory: add allocateVoid() that is == allocate() but no return value. This function duplicates the functionality of allocate() exactly, except that it does not

Re: [m5-dev] Review Request: CacheMemory: add allocateVoid() that is == allocate() but no return value.

2011-03-31 Thread Lisa Hsu
re was some way to avoid the code > > duplication. > > Lisa Hsu wrote: > Brad, I agree it's kind of ugly and I've never been a fan of code > duplication. (Which reminds me - why do we need two copies of lookup(), one > const and one not in CacheMemory?) I&#x

Re: [m5-dev] Review Request: CacheMemory: add allocateVoid() that is == allocate() but no return value.

2011-03-31 Thread Lisa Hsu
review1077 ------- On 2011-03-31 12:21:22, Lisa Hsu wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://reviews.m5sim.org/r/629/ >

[m5-dev] ruby_mem_tester.py

2011-03-31 Thread Lisa Hsu
Hi all, As I prepared to push a bunch of stuff today I found that the following command line fails at the head of the the clean tree: ALPHA_SE_MOESI_hammer/m5.debug configs/example/ruby_mem_test.py -l 1000 --num-dma 2 I pushed my changes anyway because they didn't make any difference on this err

[m5-dev] changeset in m5: Ruby: Add new object called WireBuffer to mimic...

2011-03-31 Thread Lisa Hsu
SINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY + * THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT + * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE + * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. + * + * Author: Lis

[m5-dev] changeset in m5: Ruby: Simplify SLICC and Entry/TBE handling.

2011-03-31 Thread Lisa Hsu
changeset be38f7b6ad9e in /z/repo/m5 details: http://repo.m5sim.org/m5?cmd=changeset;node=be38f7b6ad9e description: Ruby: Simplify SLICC and Entry/TBE handling. Before this changeset, all local variables of type Entry and TBE were considered to be pointers, but an immediate

[m5-dev] changeset in m5: Ruby: have the rubytester pass contextId to Ruby.

2011-03-31 Thread Lisa Hsu
changeset 8c68155aac00 in /z/repo/m5 details: http://repo.m5sim.org/m5?cmd=changeset;node=8c68155aac00 description: Ruby: have the rubytester pass contextId to Ruby. diffstat: src/cpu/testers/rubytest/Check.cc | 3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) diffs (27 lines):

[m5-dev] changeset in m5: Ruby: enable multiple sequencers in one control...

2011-03-31 Thread Lisa Hsu
changeset d5ad24eb015f in /z/repo/m5 details: http://repo.m5sim.org/m5?cmd=changeset;node=d5ad24eb015f description: Ruby: enable multiple sequencers in one controller. diffstat: src/mem/slicc/symbols/StateMachine.py | 21 + 1 files changed, 13 insertions(+), 8 deleti

[m5-dev] changeset in m5: Ruby: pass Packet->Req->contextId() to Ruby.

2011-03-31 Thread Lisa Hsu
changeset 20dbef14192d in /z/repo/m5 details: http://repo.m5sim.org/m5?cmd=changeset;node=20dbef14192d description: Ruby: pass Packet->Req->contextId() to Ruby. It is useful for Ruby to understand from whence request packets came. This has all request packets going into Ruby

Re: [m5-dev] Review Request: Ruby: Add new object called WireBuffer to mimic a Wire.

2011-03-31 Thread Lisa Hsu
ed up that stuff, but I obviously missed some. Thanks! - Lisa --- This is an automatically generated e-mail. To reply, visit: http://reviews.m5sim.org/r/627/#review1063 --- On 20

Re: [m5-dev] Review Request: Ruby: enable multiple sequencers in one controller.

2011-03-31 Thread Lisa Hsu
l. To reply, visit: http://reviews.m5sim.org/r/624/#review1069 ------- On 2011-03-31 12:20:53, Lisa Hsu wrote: > > --- > This is an automatically generated e-ma

Re: [m5-dev] Review Request: Ruby: enable multiple sequencers in one controller.

2011-03-31 Thread Lisa Hsu
- On 2011-03-31 12:20:53, Lisa Hsu wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://reviews.m5sim.org/r/624/ > --- >

Re: [m5-dev] Review Request: Ruby: Simplify SLICC and Entry/TBE handling.

2011-03-31 Thread Lisa Hsu
--- This is an automatically generated e-mail. To reply, visit: http://reviews.m5sim.org/r/630/ --- (Updated 2011-03-31 14:26:33.755740) Review request for Default, Ali Saidi, Gabe Bl

[m5-dev] Review Request: Ruby: Simplify SLICC and Entry/TBE handling.

2011-03-31 Thread Lisa Hsu
--- This is an automatically generated e-mail. To reply, visit: http://reviews.m5sim.org/r/630/ --- Review request for Default, Ali Saidi, Gabe Black, Steve Reinhardt, and Nathan Binke

Re: [m5-dev] Review Request: Ruby: Simplify SLICC and Entry/TBE handling.

2011-03-31 Thread Lisa Hsu
--- This is an automatically generated e-mail. To reply, visit: http://reviews.m5sim.org/r/628/ --- (Updated 2011-03-31 14:13:38.794443) Review request for Default, Ali Saidi, Gabe Bl

Re: [m5-dev] Review Request: Ruby: pass Packet->Req->contextId() to Ruby.

2011-03-31 Thread Lisa Hsu
23/#review1060 --- On 2011-03-31 12:16:27, Lisa Hsu wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http

[m5-dev] changeset in m5: Ruby: Bug in SLICC forgot semicolon at end of c...

2011-03-31 Thread Lisa Hsu
changeset 99428f716e7b in /z/repo/m5 details: http://repo.m5sim.org/m5?cmd=changeset;node=99428f716e7b description: Ruby: Bug in SLICC forgot semicolon at end of code. diffstat: src/mem/slicc/symbols/StateMachine.py | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diffs (12 lin

[m5-dev] Review Request: CacheMemory: add allocateVoid() that is == allocate() but no return value.

2011-03-31 Thread Lisa Hsu
--- This is an automatically generated e-mail. To reply, visit: http://reviews.m5sim.org/r/629/ --- Review request for Default, Ali Saidi, Gabe Black, Steve Reinhardt, and Nathan Binke

[m5-dev] Review Request: Ruby: Simplify SLICC and Entry/TBE handling.

2011-03-31 Thread Lisa Hsu
--- This is an automatically generated e-mail. To reply, visit: http://reviews.m5sim.org/r/628/ --- Review request for Default, Ali Saidi, Gabe Black, Steve Reinhardt, and Nathan Binke

[m5-dev] Review Request: Ruby: Add new object called WireBuffer to mimic a Wire.

2011-03-31 Thread Lisa Hsu
--- This is an automatically generated e-mail. To reply, visit: http://reviews.m5sim.org/r/627/ --- Review request for Default, Ali Saidi, Gabe Black, Steve Reinhardt, and Nathan Binke

[m5-dev] Review Request: Ruby: have the rubytester pass contextId to Ruby.

2011-03-31 Thread Lisa Hsu
--- This is an automatically generated e-mail. To reply, visit: http://reviews.m5sim.org/r/625/ --- Review request for Default, Ali Saidi, Gabe Black, Steve Reinhardt, and Nathan Binke

[m5-dev] Review Request: Ruby: enable multiple sequencers in one controller.

2011-03-31 Thread Lisa Hsu
--- This is an automatically generated e-mail. To reply, visit: http://reviews.m5sim.org/r/624/ --- Review request for Default, Ali Saidi, Gabe Black, Steve Reinhardt, and Nathan Binke

[m5-dev] Review Request: Ruby: pass Packet->Req->contextId() to Ruby.

2011-03-31 Thread Lisa Hsu
--- This is an automatically generated e-mail. To reply, visit: http://reviews.m5sim.org/r/623/ --- Review request for Default, Ali Saidi, Gabe Black, Steve Reinhardt, and Nathan Binke

Re: [m5-dev] Review Request: X86 ioctl: Another patch from Vince Weaver

2011-03-31 Thread Lisa Hsu
that's > called is TTY-specific. So, what's the consensus here? No checkin until ioctls are better figured out? - Lisa --- This is an automatically generated e-mail. To reply, visit: htt

Re: [m5-dev] Review Request: X86: rlimit: Another patch from Vince Weaver

2011-03-31 Thread Lisa Hsu
Lisa On 2011-03-17 16:06:30, Lisa Hsu wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://reviews.m5sim.org/r/591/ > --- > > (U

Re: [m5-dev] Review Request: X86: haddps: Another patch from Vince Weaver

2011-03-31 Thread Lisa Hsu
Lisa On 2011-03-17 16:07:08, Lisa Hsu wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://reviews.m5sim.org/r/592/ > --- > > (U

Re: [m5-dev] Review Request: X86: fsincos: Another patch from Vince Weaver

2011-03-31 Thread Lisa Hsu
Lisa On 2011-03-17 16:07:17, Lisa Hsu wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://reviews.m5sim.org/r/593/ > --- > > (U

Re: [m5-dev] Review Request: X86: fnstsw: Another patch from Vince Weaver

2011-03-31 Thread Lisa Hsu
Lisa On 2011-03-17 16:07:24, Lisa Hsu wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > http://reviews.m5sim.org/r/594/ > --- > > (U

Re: [m5-dev] Review Request: patch from Vince Weaver for review

2011-03-31 Thread Lisa Hsu
erything else to get held up because of it. - Lisa --- This is an automatically generated e-mail. To reply, visit: http://reviews.m5sim.org/r/588/#review980 ------

Re: [m5-dev] Ruby Question about MESI_CMP and implications of a Blocking Protocol

2011-03-30 Thread Lisa Hsu
Hi Malek, I think the term "blocking" is confusing because it's really an overloaded term. There's a distinction is between blocking CPUs and blocking memory systems, and they are distinct. As you say below, a TimingCPU is a blocking CPU and only has one outstanding instruction going at a time.

Re: [m5-dev] Ruby Store/Coaslescing Buffer Implementation for TimingSimpleCPU

2011-03-30 Thread Lisa Hsu
Malek, TimingSimpleCPUs are in-order CPU models and only do one instruction at a time, so coalescing at the CPU won't make any sense, since there will be nothing to coalesce. Unless you want to do your coalescing further down the memory hierarchy where you might have multiple accesses from differ

Re: [m5-dev] Running Ruby w/32 Cores

2011-03-30 Thread Lisa Hsu
I think you forgot the attachments :P. Sometimes, if ProtocolTrace isn't enough for me to find a problem, I turn on RubySlicc and RubyGenerated as well. RubySlicc is the DPRINTFs within the actual protocol *.sm files, and RubyGenerated are inside of the generated code that you will only see in t

Re: [m5-dev] Ruby random tester failing with MESI_CMP_directory?

2011-03-23 Thread Lisa Hsu
Yes, that's bizarre, since I was using the same tip, no patches applied. Don't know what to tell you Arka...since you and Nilay are both in Wisconsin maybe you can look at the differences in your setups, because so far it seems like it's just you :P. Lisa On Wed, Mar 23, 2011 at 1:55 PM, Nilay V

Re: [m5-dev] Ruby random tester failing with MESI_CMP_directory?

2011-03-22 Thread Lisa Hsu
Hi Arka, My repo it not the current tip, but the tip is Nilay's push removing CacheMsg, so it's pretty close. I've been running X86_SE_MESI_CMP_directory with the random tester for maybe 10 or 15 minutes now, and it hasn't died. Since yours died "immediately", I would assume that I won't be able

[m5-dev] changeset in m5: configs: combine ruby_se.py and se.py to avoid ...

2011-03-19 Thread Lisa Hsu
changeset 89cd8302abd3 in /z/repo/m5 details: http://repo.m5sim.org/m5?cmd=changeset;node=89cd8302abd3 description: configs: combine ruby_se.py and se.py to avoid all that code duplication diffstat: configs/example/ruby_se.py | 170 - configs/

[m5-dev] changeset in m5: enable x86 workloads on se.py

2011-03-19 Thread Lisa Hsu
changeset 5cbb0a68dce1 in /z/repo/m5 details: http://repo.m5sim.org/m5?cmd=changeset;node=5cbb0a68dce1 description: enable x86 workloads on se.py diffstat: configs/example/se.py | 10 +- 1 files changed, 5 insertions(+), 5 deletions(-) diffs (22 lines): diff -r f596091c854d -r

[m5-dev] changeset in m5: util: update aggregator to handle x86 checkpoi...

2011-03-19 Thread Lisa Hsu
changeset c40d598146ec in /z/repo/m5 details: http://repo.m5sim.org/m5?cmd=changeset;node=c40d598146ec description: util: update aggregator to handle x86 checkpoints. Also, make update to understand some of the newer serialized variables diffstat: util/checkpoint_aggregator.py |

[m5-dev] changeset in m5: se.py: Modify script to make multiprogramming m...

2011-03-19 Thread Lisa Hsu
changeset f596091c854d in /z/repo/m5 details: http://repo.m5sim.org/m5?cmd=changeset;node=f596091c854d description: se.py: Modify script to make multiprogramming much easier. Now, instead of --bench benchname, you can do --bench bench1-bench2-bench3 and it will set up a sim

Re: [m5-dev] Review Request: enable x86 workloads on se.py

2011-03-19 Thread Lisa Hsu
is an automatically generated e-mail. To reply, visit: http://reviews.m5sim.org/r/599/#review991 --- On 2011-03-18 16:06:35, Lisa Hsu wrote: > >

Re: [m5-dev] Review Request: se.py: Modify script to make multiprogramming much easier.

2011-03-19 Thread Lisa Hsu
tle non-traditional. I'd prefer to keep it this way. - Lisa --- This is an automatically generated e-mail. To reply, visit: http://reviews.m5sim.org/r/598/#review993 --------

Re: [m5-dev] Review Request: configs: combine ruby_se.py and se.py to avoid all that code duplication

2011-03-19 Thread Lisa Hsu
h the original ruby_se.py did the same thing. I'll put in a warning if there's a mismatch. - Lisa --- This is an automatically generated e-mail. To reply, visit: http://reviews.m5sim.org/r/600/

Re: [m5-dev] Review Request: Remove CacheMsg class from SLICC

2011-03-18 Thread Lisa Hsu
What's going on with this patch? I don't believe it's been committed but it seems like it should. I've also got some patches waiting behind this because they used to touch CacheMsg and I don't want to mess Nilay up, so I've been waiting to serialize behind this. Lisa On Wed, Feb 9, 2011 at 1:28

[m5-dev] Review Request: configs: combine ruby_se.py and se.py to avoid all that code duplication

2011-03-18 Thread Lisa Hsu
--- This is an automatically generated e-mail. To reply, visit: http://reviews.m5sim.org/r/600/ --- Review request for Default, Ali Saidi, Gabe Black, Steve Reinhardt, and Nathan Binke

[m5-dev] Review Request: enable x86 workloads on se.py

2011-03-18 Thread Lisa Hsu
--- This is an automatically generated e-mail. To reply, visit: http://reviews.m5sim.org/r/599/ --- Review request for Default, Ali Saidi, Gabe Black, Steve Reinhardt, and Nathan Binke

[m5-dev] Review Request: se.py: Modify script to make multiprogramming much easier.

2011-03-18 Thread Lisa Hsu
--- This is an automatically generated e-mail. To reply, visit: http://reviews.m5sim.org/r/598/ --- Review request for Default, Ali Saidi, Gabe Black, Steve Reinhardt, and Nathan Binke

[m5-dev] changeset in m5: Ruby: minor bugfix, line did not adhere to some...

2011-03-17 Thread Lisa Hsu
changeset b0ecadb07742 in /z/repo/m5 details: http://repo.m5sim.org/m5?cmd=changeset;node=b0ecadb07742 description: Ruby: minor bugfix, line did not adhere to some macro usage conventions. diffstat: src/mem/ruby/slicc_interface/RubySlicc_ComponentMapping.hh | 2 +- 1 files changed, 1 in

[m5-dev] changeset in m5: Ruby: expose a simple mod function in slicc int...

2011-03-17 Thread Lisa Hsu
changeset 03f7df749b9d in /z/repo/m5 details: http://repo.m5sim.org/m5?cmd=changeset;node=03f7df749b9d description: Ruby: expose a simple mod function in slicc interface. diffstat: src/mem/protocol/RubySlicc_Util.sm | 2 +- src/mem/ruby/slicc_interface/RubySlicc_Util.hh | 6

Re: [m5-dev] Review Request: X86 ioctl: Another patch from Vince Weaver

2011-03-17 Thread Lisa Hsu
Yes, you assume right. On Thu, Mar 17, 2011 at 4:08 PM, nathan binkert wrote: > I assume that when you commit these, you'll put a proper message in and > make the author vince (qref -u can set the username) > > Nate > > > On Thu, Mar 17, 2011 at 4:06 PM, Lisa Hsu

[m5-dev] Review Request: X86: fnstsw: Another patch from Vince Weaver

2011-03-17 Thread Lisa Hsu
--- This is an automatically generated e-mail. To reply, visit: http://reviews.m5sim.org/r/594/ --- Review request for Default, Ali Saidi, Gabe Black, Steve Reinhardt, and Nathan Binke

[m5-dev] Review Request: X86: fsincos: Another patch from Vince Weaver

2011-03-17 Thread Lisa Hsu
--- This is an automatically generated e-mail. To reply, visit: http://reviews.m5sim.org/r/593/ --- Review request for Default, Ali Saidi, Gabe Black, Steve Reinhardt, and Nathan Binke

[m5-dev] Review Request: X86: haddps: Another patch from Vince Weaver

2011-03-17 Thread Lisa Hsu
--- This is an automatically generated e-mail. To reply, visit: http://reviews.m5sim.org/r/592/ --- Review request for Default, Ali Saidi, Gabe Black, Steve Reinhardt, and Nathan Binke

[m5-dev] Review Request: X86: rlimit: Another patch from Vince Weaver

2011-03-17 Thread Lisa Hsu
--- This is an automatically generated e-mail. To reply, visit: http://reviews.m5sim.org/r/591/ --- Review request for Default, Ali Saidi, Gabe Black, Steve Reinhardt, and Nathan Binke

[m5-dev] Review Request: X86: open flags: Another patch from Vince Weaver

2011-03-17 Thread Lisa Hsu
--- This is an automatically generated e-mail. To reply, visit: http://reviews.m5sim.org/r/590/ --- Review request for Default, Ali Saidi, Gabe Black, Steve Reinhardt, and Nathan Binke

[m5-dev] Review Request: X86 ioctl: Another patch from Vince Weaver

2011-03-17 Thread Lisa Hsu
--- This is an automatically generated e-mail. To reply, visit: http://reviews.m5sim.org/r/589/ --- Review request for Default, Ali Saidi, Gabe Black, Steve Reinhardt, and Nathan Binke

[m5-dev] Review Request: patch from Vince Weaver for review

2011-03-17 Thread Lisa Hsu
--- This is an automatically generated e-mail. To reply, visit: http://reviews.m5sim.org/r/588/ --- Review request for Default, Ali Saidi, Gabe Black, Steve Reinhardt, and Nathan Binke

[m5-dev] changeset in m5: Import changeset

2011-02-16 Thread Lisa Hsu
changeset 60051d2262c2 in /z/repo/m5 details: http://repo.m5sim.org/m5?cmd=changeset;node=60051d2262c2 description: Import changeset diffstat: system/alpha/console/Makefile|44 + system/alpha/console/console.c | 1126 + system/alpha/console/dbmentry

Re: [m5-dev] FYI

2011-01-21 Thread Lisa Hsu
other one > - if neither one works, ask on m5-users > > If people followed this approach, then it wouldn't matter nearly as much > which one they started with. > > Steve > > On Fri, Jan 21, 2011 at 2:50 PM, Lisa Hsu wrote: > >> I have changed the wiki to sa

[m5-dev] FYI

2011-01-21 Thread Lisa Hsu
I have changed the wiki to say that we recommend using the development repository (over m5-stable), since in practice that really is better. Lisa ___ m5-dev mailing list m5-dev@m5sim.org http://m5sim.org/mailman/listinfo/m5-dev

Re: [m5-dev] Question on SLICC

2011-01-21 Thread Lisa Hsu
I think the purpose of libruby was that back in the day GEMS/Ruby was able to be hooked up to several other drivers like Bochs, and libruby encapsulated the APIs to be able to talk to these other guys. Caveat - this is what I recall hearing Brad say, I can't say for sure. But since I'm going thro

Re: [m5-dev] breaking up ISA generated files

2011-01-21 Thread Lisa Hsu
Agreed. On Wed, Jan 19, 2011 at 1:50 PM, Ali Saidi wrote: > > I would not complain if the build times went up slightly but I didn't need > 8GB of RAM to do a -j 6 build. ;) > > Ali > > > > On Wed, 19 Jan 2011 09:02:13 -0800, nathan binkert > wrote: > >> I don't think anyone would have any probl

Re: [m5-dev] Review Request: Changing how CacheMemory interfaces with SLICC

2011-01-12 Thread Lisa Hsu
How funny - yes, my usage of implicit and explicit are the same as Brad's...implicit meaning that in the actions, you can just say "address" and it always knows what you are talking about because it was sent via the trigger function. Glad things seem cleared up now! Keep up the great work Nilay.

Re: [m5-dev] Review Request: Changing how CacheMemory interfaces with SLICC

2011-01-11 Thread Lisa Hsu
Hi Nilay, I've been talking with Brad here at work about some of these things so I will finally jump into the conversation via email. First, great job on this - this has clearly been a substantial amount of work. I'm impressed. I've got some comments below. On Tue, Jan 11, 2011 at 3:46 PM, Nil

Re: [m5-dev] changeset in m5: Mem: Finish half-baked support for mmaping file...

2011-01-11 Thread Lisa Hsu
I just had this break a few checkpoints myself - and it's not a big deal really because it's easily fixup-able...but I wonder whether you really want to serialize the size of the physmem - let's say you run a checkpointing run with physmem N gigs and then you restore with physmem M gigs...I don't s

Re: [m5-dev] changeset in m5: ARM: Add checkpointing support

2011-01-10 Thread Lisa Hsu
I can affirm that the ConfigParser package is super easy to use, and I've used it to aggregate both ALPHA and X86 checkpoints together arbitrarily to make new checkpoints. An updater shouldn't be too hard, I've done a fair amount of fixup along the way in that regard. I also want to point out I a

Re: [m5-dev] Review Request: mem: Added support for Null data packet

2011-01-10 Thread Lisa Hsu
--- This is an automatically generated e-mail. To reply, visit: http://reviews.m5sim.org/r/399/#review715 --- Ship it! Obviates the need for a different patch I had in my own queue, a

Re: [m5-dev] Review Request: ruby: Assert for x86 misaligned access

2011-01-07 Thread Lisa Hsu
--- This is an automatically generated e-mail. To reply, visit: http://reviews.m5sim.org/r/390/#review671 --- Suggest using %#x instead of %x, otherwise, good. - Lisa On 2011-01-06

Re: [m5-dev] Review Request: x86: Add checkpointing capability to arch components

2011-01-07 Thread Lisa Hsu
--- This is an automatically generated e-mail. To reply, visit: http://reviews.m5sim.org/r/386/#review670 --- I don't know about the interrupt device, the but TLB code is good - recent

Re: [m5-dev] Review Request: Ruby: Fix to return cache block size to CPU for split data transfers

2011-01-07 Thread Lisa Hsu
--- This is an automatically generated e-mail. To reply, visit: http://reviews.m5sim.org/r/393/#review666 --- Ship it! - Lisa On 2011-01-06 16:10:36, Brad Beckmann wrote: > > -

Re: [m5-dev] Review Request: ruby: minor fix to deadlock panic message

2011-01-07 Thread Lisa Hsu
--- This is an automatically generated e-mail. To reply, visit: http://reviews.m5sim.org/r/407/#review665 --- Ship it! Though I'm with Nate on "code cleanliness" to just use the hash

Re: [m5-dev] Review Request: stats: Add a histogram statistic type

2011-01-06 Thread Lisa Hsu
--- This is an automatically generated e-mail. To reply, visit: http://reviews.m5sim.org/r/357/#review635 --- Ship it! Didn't check your logic/math or anything, but looks good...so, t

Re: [m5-dev] Cron /z/m5/regression/do-regression quick

2010-06-29 Thread Lisa Hsu
I don't have them either. Usually my phone bings at midnight with a cron email, now that I think about it, hasn't happened in a bit, and there's nothing in inbox or spam. Lisa On Mon, Jun 28, 2010 at 11:17 PM, nathan binkert wrote: > I haven't seen them either. I actually scan my spam folder

Re: [m5-dev] Stats

2010-06-25 Thread Lisa Hsu
Hi Nate, I've never used AverageDeviation. If I recall, I read about it on the twiki and it's kind of random, could be useful but not really a standard stat, so if it's super broken then I think it's ok to nuke it. I like the Distribution stats, I've been using them a fair amount in my tree, whic

Re: [m5-dev] startup issues

2010-06-24 Thread Lisa Hsu
1) I like the idea of putting the init sequence onto the wiki (but including the call to regStats, which isn't there now because it's not relevant to this conversation, but would still be helpful). 2) I like the idea of parameterizing instantiate with a checkpoint or not and then having init() var

[m5-dev] changeset in m5: flags: add comment to avoid future deletions si...

2010-06-09 Thread Lisa Hsu
changeset f98fe16f50ee in /z/repo/m5 details: http://repo.m5sim.org/m5?cmd=changeset;node=f98fe16f50ee description: flags: add comment to avoid future deletions since code appears redundant. diffstat: src/sim/eventq.cc | 13 ++--- 1 files changed, 10 insertions(+), 3 deletions(

[m5-dev] changeset in m5: flags: Unserializing old checkpoints before the...

2010-06-08 Thread Lisa Hsu
changeset 97c34fea328a in /z/repo/m5 details: http://repo.m5sim.org/m5?cmd=changeset;node=97c34fea328a description: flags: Unserializing old checkpoints before the introduction of the Initialized flag would break, set Initialized for events upon unserialization. diffstat:

Re: [m5-dev] changeset in m5: utils: checkpoint aggregator: some physmem file...

2010-06-03 Thread Lisa Hsu
ooks like the latter. > Please use the former in the future. > > Nate > > On Thu, Jun 3, 2010 at 3:27 PM, Lisa Hsu wrote: > > changeset cbedf338fc44 in /z/repo/m5 > > details: http://repo.m5sim.org/m5?cmd=changeset;node=cbedf338fc44 > > description: > >

[m5-dev] changeset in m5: Stats: fix dist stat and enable VectorDistStat

2010-06-03 Thread Lisa Hsu
changeset 669c1d2df752 in /z/repo/m5 details: http://repo.m5sim.org/m5?cmd=changeset;node=669c1d2df752 description: Stats: fix dist stat and enable VectorDistStat diffstat: src/base/statistics.hh | 23 ++- src/base/stats/text.cc | 2 +- 2 files changed, 15 inserti

[m5-dev] changeset in m5: utils: checkpoint aggregator: some physmem file...

2010-06-03 Thread Lisa Hsu
the copyright holders nor the names of its +# contributors may be used to endorse or promote products derived from +# this software without specific prior written permission. +# +# THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS +# "AS IS" AND ANY EXPRESS OR IMPLIED W

Re: [m5-dev] comInstEventQueue

2010-05-24 Thread Lisa Hsu
A while back I think I made totalInstructions() a virtual function because it was impl'ed by all the cpus anyway, don't know if that's basically what you're looking for, functionality-wise. Lisa On Mon, May 24, 2010 at 9:20 PM, nathan binkert wrote: > > There seem to be a few issues with the co

Re: [m5-dev] Runtime Value of Stats

2010-03-05 Thread Lisa Hsu
Korey, Use myStat[tid].value() Lisa On Fri, Mar 5, 2010 at 9:07 AM, Korey Sewell wrote: > Is there a way to get the run-time value of a stat? > > Particularly, I have a vector stats that I am incrementing: > myStat[tid]++. > > But, for debugging purposes, I would like to print out the stats v

[m5-dev] changeset in m5: stats: update stats for the changes I pushed re...

2010-02-25 Thread Lisa Hsu
changeset 9ec11ecd228a in /z/repo/m5 details: http://repo.m5sim.org/m5?cmd=changeset;node=9ec11ecd228a description: stats: update stats for the changes I pushed re: shared cache occupancy diffstat: 237 files changed, 5572 insertions(+), 3115 deletions(-) tests/long/00.gzip/ref/alpha/tru64

[m5-dev] changeset in m5: cache stats: account for writebacks and/or devi...

2010-02-25 Thread Lisa Hsu
changeset 7732bca47f60 in /z/repo/m5 details: http://repo.m5sim.org/m5?cmd=changeset;node=7732bca47f60 description: cache stats: account for writebacks and/or device occupancy in the cache. Plus, a minor bugfix that neglects to update blk->contextSrc in certain cases on a cache in

[m5-dev] changeset in m5: configs: pull out cache configuration code from...

2010-02-25 Thread Lisa Hsu
OF SUCH DAMAGE. +# +# Authors: Lisa Hsu + +# Configure the M5 cache hierarchy config in one place +# + +import m5 +from m5.objects import * +from Caches import * + +def config_cache(options, system): +if options.l2cache: +system.l2 = L2Cache(size='2MB') +system.tol2bus =

Re: [m5-dev] Cron /z/m5/regression/do-regression quick

2010-02-24 Thread Lisa Hsu
These failures are my fault, I've got to check in reference updates. Lisa On Wed, Feb 24, 2010 at 12:18 AM, Cron Daemon wrote: > * build/ALPHA_SE/tests/fast/quick/00.hello/alpha/linux/simple-atomic > passed. > * build/ALPHA_SE/tests/fast/quick/00.hello/alpha/tru64/o3-timing > passed. > *

  1   2   >