Re: RTC vs CTR (was: Concerning Sentry...)

2015-11-26 Thread Stephen Connolly
On Wednesday 25 November 2015, Steve Loughran wrote: > > > On 22 Nov 2015, at 22:34, Branko Čibej > > wrote: > > > > > > The major question here, for me, is: if the project is RTC, then why > > would I make an effort to become a committer

Re: RTC vs CTR (was: Concerning Sentry...)

2015-11-26 Thread Stephen Connolly
On Wednesday 25 November 2015, Steve Loughran wrote: > > > On 22 Nov 2015, at 22:34, Branko Čibej > > wrote: > > > > > > The major question here, for me, is: if the project is RTC, then why > > would I make an effort to become a committer

Re: RTC vs CTR (was: Concerning Sentry...)

2015-11-26 Thread Steve Loughran
This is really good essay on the whole topic. I don't think I've seen a post on any asf list which uses both "existential threat" and "desiderata". I also like the implication that RTC is a function of the complexity of the team, rather than just the code. Every project I've worked on —open or

Re: RTC vs CTR (was: Concerning Sentry...)

2015-11-26 Thread Greg Stein
I concur. Chris' email is very insightful, and very well written. It is great food for thought, for each workflow approach. Thanks, Chris. ... food.. thx... Happy Thanksgiving! -g On Nov 26, 2015 4:28 AM, "Steve Loughran" wrote: > > This is really good essay on the

Re: RTC vs CTR (was: Concerning Sentry...)

2015-11-26 Thread Jim Jagielski
OK, ok... we are at diminishing returns here with people no longer, imo, listening to what others are saying... We have, as a foundation, and HAVE HAD RTC and CTR for years and decades. There are times when one or the other are Good and when they are Bad. Those exact times will, generally, vary

Re: RTC vs CTR (was: Concerning Sentry...)

2015-11-26 Thread Ralph Goers
Sorry Jim. As an attempt to shut down a thread, this wasn't a very good one. Not a single poster in this thread has a problem with the word, or the concept of, "review". It is the process that is the issue and what the impact of that process is upon a community. Ralph > On Nov 26, 2015, at

Re: RTC vs CTR (was: Concerning Sentry...)

2015-11-26 Thread Joe Schaefer
This saga jumped the shark right about the time Mary the sonnetor weighted in. On Thursday, November 26, 2015, Ralph Goers wrote: > Sorry Jim. As an attempt to shut down a thread, this wasn't a very good > one. Not a single poster in this thread has a problem with

Re: RTC vs CTR (was: Concerning Sentry...)

2015-11-26 Thread Harbs
FWIW: I just now looked at Gerrit (being it’s what sparked this discussion) and I think that it falls in that category between classic CTR and RTC. I was reading this document which gives an overview.[1] The review there happens IN the central repo, but it’s mandatory before content is checked

Re: RTC vs CTR (was: Concerning Sentry...)

2015-11-26 Thread Greg Stein
On Thu, Nov 26, 2015 at 10:56 AM, Harbs wrote: >... > So technically, the review is after the commit (to a central staging > repo), but it’s mandatory before the commit is officially accepted and will > be checked out from the (central approved) repo. It’s an interesting >

Re: RTC vs CTR (was: Concerning Sentry...)

2015-11-25 Thread Stephen Connolly
Spoilsport ;-) On 25 November 2015 at 16:47, Upayavira wrote: > Not replying to this mail specifically, but to the thread in general... > > People keep using the terms RTC and CTR as if we all mean the same > thing. Please don't. If you must use these terms, please define what

Re: RTC vs CTR (was: Concerning Sentry...)

2015-11-25 Thread Upayavira
Not replying to this mail specifically, but to the thread in general... People keep using the terms RTC and CTR as if we all mean the same thing. Please don't. If you must use these terms, please define what you mean by them. CTR is a less ambiguous term - I'd suggest we all assume that "commit"

Re: RTC vs CTR (was: Concerning Sentry...)

2015-11-25 Thread Harbs
Very good point, but I’m not sure that CTR is that much less ambiguous. It would be interesting to compare different models both that users consider CTR as well as RTC. I have a feeling there is some overlap of “CTR” and “RTC”. I’m pretty sure that a lot of folks call some CTR cases “RTC”. It’s

Re: RTC vs CTR (was: Concerning Sentry...)

2015-11-25 Thread Sam Ruby
On Wed, Nov 25, 2015 at 5:18 PM, Greg Stein wrote: > On Wed, Nov 25, 2015 at 4:02 PM, Sam Ruby wrote: > >> On Wed, Nov 25, 2015 at 4:51 PM, Greg Stein wrote: >> > >> > Don't shut down trunk/master for product development. >> >> I don't

Re: RTC vs CTR (was: Concerning Sentry...)

2015-11-25 Thread Konstantin Boudnik
On Wed, Nov 25, 2015 at 05:12PM, Chris Douglas wrote: > RTC is regulation. That's not a synonym for control when it's > conflated with suspicion of people. Regulation is a set of deliberate > checks on a system. > > Good regulation estimates (or reacts to) a system's natural excesses, > then

Re: RTC vs CTR (was: Concerning Sentry...)

2015-11-25 Thread Ralph Goers
> On Nov 25, 2015, at 3:22 PM, Todd Lipcon wrote: > > Isn't it an issue of scalability? With pre-commit code reviews, typically > the uploader of the code will pick out one or two people to review the code > who know the area well. Or, if no one is picked by the submitter of

Re: RTC vs CTR (was: Concerning Sentry...)

2015-11-25 Thread Todd Lipcon
On Wed, Nov 25, 2015 at 7:06 PM, Ralph Goers wrote: > Much as I don’t care to participate in GPL projects I also don’t care to > participate in pure RTC projects as both restrict me in ways I very much > dislike, > > You're entitled to that opinion. I personally

Re: RTC vs CTR (was: Concerning Sentry...)

2015-11-25 Thread Chris Douglas
RTC is regulation. That's not a synonym for control when it's conflated with suspicion of people. Regulation is a set of deliberate checks on a system. Good regulation estimates (or reacts to) a system's natural excesses, then attempts to constrain existential threats. It isn't a lack of trust,

Re: RTC vs CTR (was: Concerning Sentry...)

2015-11-25 Thread Sam Ruby
On Wed, Nov 25, 2015 at 9:13 PM, Konstantin Boudnik wrote: > > And that goes, as always, to the question "Who makes the decision about the > _right_ level of trust". The community. - Sam Ruby - To unsubscribe,

Re: RTC vs CTR (was: Concerning Sentry...)

2015-11-25 Thread Andrew Purtell
Most of the Hadoop ecosystem uses RTC. I can't speak to other projects but on the one I chair there's no conspiracy to exclude anyone. I chair Bigtop. We recently tested a switch to CTR. It went very well and so we just wrapped up a vote to make it the permanent state of affairs. I think this is

Re: RTC vs CTR (was: Concerning Sentry...)

2015-11-25 Thread Steve Loughran
> On 22 Nov 2015, at 22:34, Branko Čibej wrote: > > > The major question here, for me, is: if the project is RTC, then why > would I make an effort to become a committer if at the end of the day > I'm still not trusted to know when to ask for review? It'd be less work > to

Re: RTC vs CTR (was: Concerning Sentry...)

2015-11-25 Thread Greg Stein
On Nov 25, 2015, at 4:08 AM, Konstantin Boudnik wrote: > I don't think Git is particularly empowering RTC - there's nothing in it that > requires someone to look over one's shoulder. On Wed, Nov 25, 2015 at 3:28 AM, Harbs wrote: > AIUI, there’s two ways

Re: RTC vs CTR (was: Concerning Sentry...)

2015-11-25 Thread Harbs
If a review is required for non-code changes to the main branch, then I agree. I’m sure you agree that reviews on code make for less bugs. We all make mistakes and can overlook things. It seems kind of extreme to assume that this kind of required review is all about control. Since anyone who

Re: RTC vs CTR (was: Concerning Sentry...)

2015-11-25 Thread Ralph Goers
1. What makes you think all bugs are caught during code reviews (they aren’t)? 2. What makes you think that code reviews after the commit are any less thorough than reviews required before the commit? If you don’t trust your community to do code reviews after you commit then there is a problem

Re: RTC vs CTR (was: Concerning Sentry...)

2015-11-25 Thread Andrew Purtell
And I challenge you to comb over all HBase mailing lists and JIRAs and find any instance where we were not the model of a meritocratic and consensus driven community, or any instance where a committer has ever been aggrieved by our practices, and especially where I as chair have tried to exert

Re: RTC vs CTR (was: Concerning Sentry...)

2015-11-25 Thread Sam Ruby
On Wed, Nov 25, 2015 at 4:51 PM, Greg Stein wrote: > > Don't shut down trunk/master for product development. I don't believe you heard my point, but I'm not going to repeat it. Instead I will add a new point. 'trunk/master for product development' is not the only development

Re: RTC vs CTR (was: Concerning Sentry...)

2015-11-25 Thread Harbs
On Nov 25, 2015, at 11:32 PM, Ralph Goers wrote: > 1. What makes you think all bugs are caught during code reviews (they aren’t)? I don’t, and I did not infer that. > 2. What makes you think that code reviews after the commit are any less > thorough than reviews

Re: RTC vs CTR (was: Concerning Sentry...)

2015-11-25 Thread Greg Stein
On Wed, Nov 25, 2015 at 4:02 PM, Sam Ruby wrote: > On Wed, Nov 25, 2015 at 4:51 PM, Greg Stein wrote: > > > > Don't shut down trunk/master for product development. > > I don't believe you heard my point, but I'm not going to repeat it. > I read your

Re: RTC vs CTR (was: Concerning Sentry...)

2015-11-25 Thread Todd Lipcon
On Wed, Nov 25, 2015 at 1:32 PM, Ralph Goers wrote: > 1. What makes you think all bugs are caught during code reviews (they > aren’t)? > They aren't. But some are. And catching them in code review is cheaper than catching them when a user hits them. Additionally,

Re: RTC vs CTR (was: Concerning Sentry...)

2015-11-25 Thread Andrew Purtell
I have to completely disagree and find your assertion vaguely offensive. > On Nov 25, 2015, at 12:32 PM, Greg Stein wrote: > > On Wed, Nov 25, 2015 at 12:44 PM, Andrew Purtell > wrote: >> ... >> >> and inherited the RTC ethic from our parent community.

Re: RTC vs CTR (was: Concerning Sentry...)

2015-11-25 Thread Greg Stein
That is pretty normal operation in both styles of workflow. My concern is with trunk/master. Is a committer trusted enough to make changes directly? If all meaningful changes (ie. changing APIs and algorithms, not just fixing typos w/o review) are not trusted, and require review/permission, then

Re: RTC vs CTR (was: Concerning Sentry...)

2015-11-25 Thread Jim Jagielski
> On Nov 25, 2015, at 3:49 PM, Greg Stein wrote: > > That is pretty normal operation in both styles of workflow. My concern is > with trunk/master. As far as I know, that condition was unclear... You seemed to imply that RTC *anyplace* was harmful or all about control. Both

Re: RTC vs CTR (was: Concerning Sentry...)

2015-11-25 Thread Greg Stein
On Wed, Nov 25, 2015 at 12:44 PM, Andrew Purtell wrote: >... > > and inherited the RTC ethic from our parent community. I did recently test > the state of consensus on RTC vs CTR there and it still holds. I think this > model makes sense for HBase, which is a mature (read:

Re: RTC vs CTR (was: Concerning Sentry...)

2015-11-25 Thread Greg Stein
I think this is a distraction. You said it best the other day: RTC implies the need for "permission" before making a change to the codebase. Committers are not trusted to make a judgement on whether a change should be made. CTR trusts committers to use their judgement. RTC distrusts committers,

Re: RTC vs CTR (was: Concerning Sentry...)

2015-11-25 Thread Harbs
On Nov 25, 2015, at 10:37 PM, Greg Stein wrote: >> AIUI, there’s two ways to go about RTC which is easier in Git: >> > > That's not what Cos said. He said using Git does not lead to RTC. > > If RTC has been chosen, then you're right: Git makes it easier [than svn]. > But

Re: RTC vs CTR (was: Concerning Sentry...)

2015-11-25 Thread Sam Ruby
On Wed, Nov 25, 2015 at 3:39 PM, Greg Stein wrote: > > Over the 17 years I've been around Apache, every single time I've seen > somebody attempt to justify something like RTC, it always goes back to > control. Always. Strongly disagree. If you say 'every', all it takes is one

Re: RTC vs CTR (was: Concerning Sentry...)

2015-11-25 Thread Greg Stein
On Wed, Nov 25, 2015 at 3:27 PM, Sam Ruby wrote: > On Wed, Nov 25, 2015 at 3:39 PM, Greg Stein wrote: > > > > Over the 17 years I've been around Apache, every single time I've seen > > somebody attempt to justify something like RTC, it always goes back

Re: RTC vs CTR (was: Concerning Sentry...)

2015-11-25 Thread Upayavira
Some setups that people call RTC are actually CTR in your nomenclature, so we could be talking cross-purposes. That's all I'm trying to avoid. E.g. Lucene - everything happens in JIRA first (upload patch, wait for review), but once that has happened, you are free to commit away. So strictly, it is

Re: RTC vs CTR (was: Concerning Sentry...)

2015-11-25 Thread Greg Stein
Boo hoo. Todd said it wasn't about control, and then a few days later said he was forcing people into doing reviews. So yeah: in his case, it *is* about control. Over the 17 years I've been around Apache, every single time I've seen somebody attempt to justify something like RTC, it always goes

Re: RTC vs CTR (was: Concerning Sentry...)

2015-11-25 Thread Pierre Smits
I see some are trying to spread quite some FUD. Pierre Smits *OFBiz Extensions Marketplace* http://oem.ofbizci.net/oci-2/ On Wed, Nov 25, 2015 at 11:47 PM, Sam Ruby wrote: > On Wed, Nov 25, 2015 at 5:18 PM, Greg Stein wrote: > > On Wed, Nov 25, 2015

Re: RTC vs CTR (was: Concerning Sentry...)

2015-11-25 Thread Harbs
AIUI, there’s two ways to go about RTC which is easier in Git: 1) Working in feature/bug fix branches. Assuming RTC only applies to the main branch, changes are done in separate branches where commits do not require review. The feature/bug fix branch is then only merged back in after it had a

Re: RTC vs CTR (was: Concerning Sentry...)

2015-11-24 Thread Konstantin Boudnik
On Mon, Nov 23, 2015 at 12:29PM, Harbs wrote: > This kind of underscores my observation that a large part of this debate is > driven by source control technologies. > > RTC seems popular for projects using Git, while CTR seems popular in > communities using SVN. Well, Apache Bigtop is now

Re: RTC vs CTR (was: Concerning Sentry...)

2015-11-24 Thread Konstantin Boudnik
ay, November 23, 2015 5:49 PM > To: general-incubator <general@incubator.apache.org> > Subject: Re: RTC vs CTR (was: Concerning Sentry...) > > On Mon, Nov 23, 2015 at 12:10 PM, Greg Stein <gst...@gmail.com> wrote: > > > On Mon, Nov 23, 2015 at 5:57 AM, Sam Ruby <r

Re: RTC vs CTR (was: Concerning Sentry...)

2015-11-24 Thread Brock Noland
> On Mon, Nov 23, 2015 at 5:20 AM, Greg Stein wrote: > > Personally, I am saying RTC is destructive, and am willing to give every > podling that message. Delivering that message by informing podlings of your experience is completely acceptable. However, if anyone attempts to

RE: RTC vs CTR (was: Concerning Sentry...)

2015-11-24 Thread Ross Gardler
Brock, I can assure you that's not Greg's style so I doubt you have anything to worry about. -Original Message- From: Brock Noland [mailto:br...@apache.org] Sent: Tuesday, November 24, 2015 9:54 PM To: general@incubator.apache.org Subject: Re: RTC vs CTR (was: Concerning Sentry

Re: RTC vs CTR (was: Concerning Sentry...)

2015-11-24 Thread Greg Stein
assure you that's not Greg's style so I doubt you have > anything to worry about. > > -Original Message- > From: Brock Noland [mailto:br...@apache.org] > Sent: Tuesday, November 24, 2015 9:54 PM > To: general@incubator.apache.org > Subject: Re: RTC vs CTR (was: Concernin

Re: RTC vs CTR (was: Concerning Sentry...)

2015-11-24 Thread Brock Noland
; anything to worry about. >> >> -Original Message- >> From: Brock Noland [mailto:br...@apache.org] >> Sent: Tuesday, November 24, 2015 9:54 PM >> To: general@incubator.apache.org >> Subject: Re: RTC vs CTR (was: Concerning Sentry...) >> >> >

Re: RTC vs CTR (was: Concerning Sentry...)

2015-11-23 Thread Greg Stein
On Sun, Nov 22, 2015 at 11:37 PM, Todd Lipcon wrote: >... > I don't have incubator stats... nor do I have a good way to measure "most > active" or "most successful" projects in the ASF (seems that itself could > be a 'centithread'-worthy discussion). But a potential proxy

Re: RTC vs CTR (was: Concerning Sentry...)

2015-11-23 Thread Greg Stein
On Mon, Nov 23, 2015 at 4:29 AM, Harbs wrote: >... > FWIW, I personally could swallow using RTC with Git, but I would seriously > have problems with RTC with SVN. > I read this as "RTC sucks, but at least Git makes it suck less." :-) (and yes, Git's features naturally

Re: RTC vs CTR (was: Concerning Sentry...)

2015-11-23 Thread Greg Stein
On Mon, Nov 23, 2015 at 12:33 AM, Reynold Xin wrote: > Most non-trivial software projects I worked on (paid or un-paid) have RTC > culture. I cannot represent every single project, but in the ones that I'm > closely involved with that use RTC, it is simply part of the culture

Re: RTC vs CTR (was: Concerning Sentry...)

2015-11-23 Thread Greg Stein
On Mon, Nov 23, 2015 at 5:57 AM, Sam Ruby wrote: > On Mon, Nov 23, 2015 at 5:20 AM, Greg Stein wrote: > > > > Nobody is forcing anything. > > > > Personally, I am saying RTC is destructive, and am willing to give every > > podling that message. > > If

Re: RTC vs CTR (was: Concerning Sentry...)

2015-11-23 Thread Sam Ruby
On Mon, Nov 23, 2015 at 5:20 AM, Greg Stein wrote: > > Nobody is forcing anything. > > Personally, I am saying RTC is destructive, and am willing to give every > podling that message. If it is truly destructive, SHOULDN'T you/we be trying to force something? And if not,

RE: RTC vs CTR (was: Concerning Sentry...)

2015-11-23 Thread Dennis E. Hamilton
> -Original Message- > From: r...@databricks.com [mailto:r...@databricks.com] On Behalf Of > Reynold Xin > Sent: Sunday, November 22, 2015 22:33 > To: general@incubator.apache.org > Subject: Re: RTC vs CTR (was: Concerning Sentry...) > [ ... ] [orcmid] > Commit

Re: RTC vs CTR (was: Concerning Sentry...)

2015-11-23 Thread Harbs
This kind of underscores my observation that a large part of this debate is driven by source control technologies. RTC seems popular for projects using Git, while CTR seems popular in communities using SVN. RTC is a LOT easier using Git than SVN if the model is branching. FWIW, I personally

Re: RTC vs CTR (was: Concerning Sentry...)

2015-11-23 Thread Sam Ruby
On Mon, Nov 23, 2015 at 7:10 AM, Greg Stein wrote: > On Mon, Nov 23, 2015 at 5:57 AM, Sam Ruby wrote: > >> >> P.S. To be clear: I am not a fan of RTC when applied to release.next >> branches. > > I'd appreciate your explanation of this, as "most" CTR

Re: RTC vs CTR (was: Concerning Sentry...)

2015-11-23 Thread Jim Jagielski
> On Nov 22, 2015, at 7:57 AM, Greg Stein wrote: > > On Sun, Nov 22, 2015 at 5:42 AM, Harbs wrote: >> ... > >> If there is a disagreement, it seems to be part semantics, part version >> control technologies (i.e. SVN optimized workflow vs Git optimized

Re: RTC vs CTR (was: Concerning Sentry...)

2015-11-23 Thread Niall Pemberton
On Mon, Nov 23, 2015 at 12:10 PM, Greg Stein wrote: > On Mon, Nov 23, 2015 at 5:57 AM, Sam Ruby wrote: > > > On Mon, Nov 23, 2015 at 5:20 AM, Greg Stein wrote: > > > > > > Nobody is forcing anything. > > > > > > Personally, I am

RE: RTC vs CTR (was: Concerning Sentry...)

2015-11-23 Thread Ross Gardler
The suggestion is to add it to the proposal template - that's before incubation starts. -Original Message- From: Niall Pemberton [mailto:niall.pember...@gmail.com] Sent: Monday, November 23, 2015 5:49 PM To: general-incubator <general@incubator.apache.org> Subject: Re: RTC

Re: RTC vs CTR (was: Concerning Sentry...)

2015-11-22 Thread Todd Lipcon
On Sun, Nov 22, 2015 at 12:18 PM, Konstantin Boudnik wrote: > > > > > The question is not to decide if C-T-R is The Apache Way over R-T-C. > The > > > question is wether a project entering incubation with a selected R-T-C > > > mode is likely to exit incubation for the simple

Re: RTC vs CTR (was: Concerning Sentry...)

2015-11-22 Thread Reynold Xin
Most non-trivial software projects I worked on (paid or un-paid) have RTC culture. I cannot represent every single project, but in the ones that I'm closely involved with that use RTC, it is simply part of the culture and recognition that mandatory code review improves code quality. (We can debate

Re: RTC vs CTR (was: Concerning Sentry...)

2015-11-22 Thread Henry Saputra
I second that. Most Hadoop related projects have this strict RTC policy, so committers from those projects try to implement it to other projects they are involve with. On Sunday, November 22, 2015, Ralph Goers wrote: > Yes, it would be good to take a survey.

Re: RTC vs CTR (was: Concerning Sentry...)

2015-11-22 Thread Branko Čibej
On 18.11.2015 01:35, Konstantin Boudnik wrote: > On Mon, Nov 16, 2015 at 04:50PM, Greg Stein wrote: >> On Mon, Nov 16, 2015 at 11:53 AM, Todd Lipcon wrote: >>> ... >>> 1) You're right, I don't trust anybody to make code changes to a complex >>> project with zero oversight. I

Re: RTC vs CTR (was: Concerning Sentry...)

2015-11-22 Thread Harbs
So. After this long debate, it seems like no one is on either extreme of the CTR/RTC spectrum. The entire debate seems to be exactly where within the spectrum one likes to be. It seems reasonable that the exact position varies from project to project or even within different pieces within a

Re: RTC vs CTR (was: Concerning Sentry...)

2015-11-22 Thread Greg Stein
On Sun, Nov 22, 2015 at 5:42 AM, Harbs wrote: >... > If there is a disagreement, it seems to be part semantics, part version > control technologies (i.e. SVN optimized workflow vs Git optimized > workflow) and part an actual difference in how to handle certain >

Re: RTC vs CTR (was: Concerning Sentry...)

2015-11-22 Thread Mary the sonnetor
I'm am in the process of learning all this fascinating tech things. That's why I was looking at the different outputs. I'm so not hurting or meddling in anybody's life nor I ever want to. Just like the opposing people received a chance. I too deserve 1. I'm sorry someone feels that way about me

Re: RTC vs CTR (was: Concerning Sentry...)

2015-11-22 Thread Konstantin Boudnik
On Tue, Nov 17, 2015 at 11:12PM, Todd Lipcon wrote: > On Tue, Nov 17, 2015 at 10:48 PM, Emmanuel Lécharny > wrote: > > > > >> > > > Except that there seems to be great disagreement among the Members as to > > > whether RTC is somehow anti-Apache-Way. > > > > > > If you want

Re: RTC vs CTR (was: Concerning Sentry...)

2015-11-22 Thread Konstantin Boudnik
On Tue, Nov 17, 2015 at 06:06PM, Todd Lipcon wrote: > On Tue, Nov 17, 2015 at 5:57 PM, Konstantin Boudnik wrote: > > > > > On the contrary... The business of the Incubator and IPMC is to help > > podlings > > and their communities to grok and follow the Apache Way. Trust is a >

Re: RTC vs CTR (was: Concerning Sentry...)

2015-11-22 Thread Joe Schaefer
Thank you Mary and welcome aboard! You are an inspiration for others! On Sun, Nov 22, 2015 at 8:08 AM, Mary the sonnetor < marywantsalittlelamb...@gmail.com> wrote: > I'm am in the process of learning all this fascinating tech things. That's > why I was looking at the different outputs. I'm so

Re: RTC vs CTR (was: Concerning Sentry...)

2015-11-22 Thread Ralph Goers
Yes, it would be good to take a survey. Interestingly, I wasn’t aware that ANY Apache projects used RTC until I became involved with a project in the Hadoop ecosystem, which seems to align with Tood’s statement since all the projects he is listed as being involved in are part of that. In

Re: RTC vs CTR (was: Concerning Sentry...)

2015-11-21 Thread Niclas Hedhman
I have now, days later, Reviewed this Thread and Commit to a veto of the whole debate, Can't agree That it is Rewarding for anyone... ;-) On Sat, Nov 21, 2015 at 2:50 AM, Todd Lipcon wrote: > On Thu, Nov 19, 2015 at 6:49 PM, Greg Stein wrote: > > > Todd: as

Re: RTC vs CTR (was: Concerning Sentry...)

2015-11-21 Thread Greg Stein
On Sat, Nov 21, 2015 at 10:10 PM, Niclas Hedhman wrote: > I have now, days later, Reviewed this Thread and Commit to a veto of the > RTC > whole debate, Can't agree That it is Rewarding for anyone... ;-) > CTR ... I saw what you did there :-)

Re: RTC vs CTR (was: Concerning Sentry...)

2015-11-20 Thread Jim Jagielski
> On Nov 20, 2015, at 9:02 AM, Ralph Goers wrote: > > A combination approach seems like it would be the best to me. Is the process > you guys use documented? > > As I said, the part that bothers me with the way RTC is done in the project I > am involved in is

Re: RTC vs CTR (was: Concerning Sentry...)

2015-11-20 Thread Ralph Goers
A combination approach seems like it would be the best to me. Is the process you guys use documented? As I said, the part that bothers me with the way RTC is done in the project I am involved in is that I can’t commit my own stuff. Ralph > On Nov 20, 2015, at 6:09 AM, Jim Jagielski

Re: RTC vs CTR (was: Concerning Sentry...)

2015-11-20 Thread Bertrand Delacretaz
On Fri, Nov 20, 2015 at 8:09 AM, Jim Jagielski wrote: > ...httpd for example) uses RTC, CTR and Lazy Consensus > simultaneously and works like a dream Indeed - those are different tools that each have their own purpose. They just need to be applied in the right places and

Re: RTC vs CTR (was: Concerning Sentry...)

2015-11-20 Thread Jim Jagielski
++1 > On Nov 20, 2015, at 9:38 AM, Bertrand Delacretaz > wrote: > > On Fri, Nov 20, 2015 at 8:09 AM, Jim Jagielski wrote: >> ...httpd for example) uses RTC, CTR and Lazy Consensus >> simultaneously and works like a dream > > Indeed - those are

Re: RTC vs CTR (was: Concerning Sentry...)

2015-11-20 Thread Jim Jagielski
Lets recall that 'review' is not just about trust (or whether or not it exists), it's also about this little thing called *oversight*. It's to ensure that at least 3 people are engaged enough to be able to not only vet the code/patch/whatever, but to make sure that should the original patch

RE: RTC vs CTR (was: Concerning Sentry...)

2015-11-20 Thread Ross Gardler
] On Behalf Of Sam Ruby Sent: Friday, November 20, 2015 7:43 AM To: general@incubator.apache.org Subject: Re: RTC vs CTR (was: Concerning Sentry...) +1 here too. Most projects here fall somewhere in a spectrum between "do whatever you want in a branch" and "don't release without having othe

Re: RTC vs CTR (was: Concerning Sentry...)

2015-11-20 Thread Ted Dunning
On Sat, Nov 21, 2015 at 12:40 AM, Sam Ruby wrote: > On Fri, Nov 20, 2015 at 11:23 AM, Ross Gardler > wrote: > > Good point. I should add to my comments that even a CTR project uses RTC > for non-committers. And that a release vote means that

Re: RTC vs CTR (was: Concerning Sentry...)

2015-11-20 Thread Sam Ruby
+1 here too. Most projects here fall somewhere in a spectrum between "do whatever you want in a branch" and "don't release without having others approve your work". Different projects put the point where CTR crosses over to RTC at different points. *shrug* - Sam Ruby P.S. Personally a fan of

Re: RTC vs CTR (was: Concerning Sentry...)

2015-11-20 Thread Sam Ruby
e- > From: sa3r...@gmail.com [mailto:sa3r...@gmail.com] On Behalf Of Sam Ruby > Sent: Friday, November 20, 2015 7:43 AM > To: general@incubator.apache.org > Subject: Re: RTC vs CTR (was: Concerning Sentry...) > > +1 here too. > > Most projects here fall somewhere in a spec

Re: RTC vs CTR (was: Concerning Sentry...)

2015-11-20 Thread Alex Harui
On 11/20/15, 8:23 AM, "Ross Gardler" wrote: >However, RTC projects do not use a mix and that's the point of contention >here, some people feel it is suboptimal (I'm one, but others disagree). >The discussion is not whether CTR also uses RTC at points, I believe that

Re: RTC vs CTR (was: Concerning Sentry...)

2015-11-20 Thread Sam Ruby
On Fri, Nov 20, 2015 at 11:47 AM, Ted Dunning wrote: > On Sat, Nov 21, 2015 at 12:40 AM, Sam Ruby wrote: > >> On Fri, Nov 20, 2015 at 11:23 AM, Ross Gardler >> wrote: >> > Good point. I should add to my comments that

Re: RTC vs CTR (was: Concerning Sentry...)

2015-11-20 Thread Todd Lipcon
On Thu, Nov 19, 2015 at 6:49 PM, Greg Stein wrote: > Todd: as Ross notes, your three points about code reviews in a CTR project > are quite valid, and match accepted engineering practices. > > What I haven't seen is an explanation why a committer must be treated the > same as a

Re: RTC vs CTR (was: Concerning Sentry...)

2015-11-19 Thread Chris Nauroth
Some projects use the git Signed-off-by field in the commit log to differentiate the author from the reviewer. --Chris Nauroth On 11/19/15, 10:58 AM, "Ralph Goers" wrote: >And there is another problem I have. Maybe it isn¹t true of all projects, >but the one I am

Re: RTC vs CTR (was: Concerning Sentry...)

2015-11-19 Thread Ralph Goers
And there is another problem I have. Maybe it isn’t true of all projects, but the one I am involved with says the author can’t commit his own code. So the commit logs will not reflect who actually authored the code but who reviewed it. I could probably tolerate RTC if I had to have the commit

Re: RTC vs CTR (was: Concerning Sentry...)

2015-11-19 Thread Greg Stein
Trick question, as I'd never work under that model :-) Apache Subversion is CTR, with a very low bar to get commit access to portions of the tree or a branch (only PMC members get access to whole tree, so we grant full access and PMC membership simultaneously). We don't need a fancy label for

Re: RTC vs CTR (was: Concerning Sentry...)

2015-11-19 Thread Ralph Goers
Greg, which of these do you use when the “contributor” is a committer? Remember the model here is that the author is never allowed to commit their own code. Ralph > On Nov 19, 2015, at 3:10 PM, Greg Stein wrote: > > The Apache Subversion project does something similar: > >

Re: RTC vs CTR (was: Concerning Sentry...)

2015-11-19 Thread Greg Stein
The Apache Subversion project does something similar: http://subversion.apache.org/docs/community-guide/conventions.html#crediting We have a tool ("contribulyzer") that analyzes them. It's pretty neat. On Nov 19, 2015 1:57 PM, "Chris Nauroth" wrote: > Some projects

Re: RTC vs CTR (was: Concerning Sentry...)

2015-11-19 Thread Greg Stein
On Thu, Nov 19, 2015 at 8:10 PM, Ralph Goers wrote: >... > of people wanting to join. I am sure this is going to be a controversial > statement, but I have noticed that the projects that I’ve seen do this > often have a fair number of committers who are paid to work

Re: RTC vs CTR (was: Concerning Sentry...)

2015-11-19 Thread Ralph Goers
Yes, it was a trick question. But it proves my point. I can’t imagine a world where someone would refuse to participate in a project because it was CTR, but in my view this variation of RTC definitely limits the number of people wanting to join. I am sure this is going to be a controversial

Re: RTC vs CTR (was: Concerning Sentry...)

2015-11-19 Thread Greg Stein
which of your three arguments for CTR > are not present in RTC. > > Ross > > -Original Message- > From: Todd Lipcon [mailto:t...@cloudera.com] > Sent: Tuesday, November 17, 2015 11:23 PM > To: general@incubator.apache.org > Subject: Re: RTC vs CTR (was: Concerni

Re: RTC vs CTR (was: Concerning Sentry...)

2015-11-19 Thread Ralph Goers
None of your statements below are any different between RTC or CTR. The only time it makes aa difference is if no one does reviews. My feeling is that a community that insists on RTC believes that code will not be reviewed unless committers are forced to do it. All I can say, is that for me

Re: RTC vs CTR (was: Concerning Sentry...)

2015-11-19 Thread Todd Lipcon
On Thu, Nov 19, 2015 at 8:16 AM, Ralph Goers wrote: > None of your statements below are any different between RTC or CTR. The > only time it makes aa difference is if no one does reviews. My feeling is > that a community that insists on RTC believes that code will

Re: RTC vs CTR (was: Concerning Sentry...)

2015-11-19 Thread Greg Stein
On Thu, Nov 19, 2015 at 11:10 AM, Todd Lipcon wrote: > On Thu, Nov 19, 2015 at 8:16 AM, Ralph Goers > wrote: > > > None of your statements below are any different between RTC or CTR. The > > only time it makes aa difference is if no one does

Re: RTC vs CTR (was: Concerning Sentry...)

2015-11-19 Thread Alex Harui
Sorry for extending the thread, but now I'm curious... On 11/19/15, 9:10 AM, "Todd Lipcon" wrote: >I'm sure it works fine for many communities (I use CTR on some internal >infrastructure within small teams where bugs are less costly and the rate >of development is slow). But

RE: RTC vs CTR (was: Concerning Sentry...)

2015-11-19 Thread Ross Gardler
From: Todd Lipcon [mailto:t...@cloudera.com] Sent: Thursday, November 19, 2015 9:11 AM To: general@incubator.apache.org Subject: Re: RTC vs CTR (was: Concerning Sentry...) On Thu, Nov 19, 2015 at 8:16 AM, Ralph Goers <ralph.go...@dslextreme.com> wrote: > None of your statements below are an

Re: RTC vs CTR (was: Concerning Sentry...)

2015-11-18 Thread Richard Frovarp
On 11/18/2015 09:20 AM, Stephen Connolly wrote: On 18 November 2015 at 14:24, Emmanuel Lécharny wrote: Le 18/11/15 14:34, Stephen Connolly a écrit : On Wednesday 18 November 2015, Emmanuel Lécharny wrote: Le 18/11/15 11:31, Stephen Connolly a

Re: RTC vs CTR (was: Concerning Sentry...)

2015-11-18 Thread Stephen Connolly
/‎18/‎2015 7:21 AM > To: general@incubator.apache.org<mailto:general@incubator.apache.org> > Subject: Re: RTC vs CTR (was: Concerning Sentry...) > > On 18 November 2015 at 14:24, Emmanuel Lécharny <elecha...@gmail.com> > wrote: > > > Le 18/11/15 14:34, Stephen Con

RE: RTC vs CTR (was: Concerning Sentry...)

2015-11-18 Thread Ross Gardler
5 AM To: general@incubator.apache.org<mailto:general@incubator.apache.org> Subject: Re: RTC vs CTR (was: Concerning Sentry...) Le 18/11/15 14:34, Stephen Connolly a écrit : > On Wednesday 18 November 2015, Emmanuel Lécharny <elecha...@gmail.com> > wrote: > >> Le 18/11

RE: RTC vs CTR (was: Concerning Sentry...)

2015-11-18 Thread Ross Gardler
1 AM To: general@incubator.apache.org<mailto:general@incubator.apache.org> Subject: Re: RTC vs CTR (was: Concerning Sentry...) On 18 November 2015 at 14:24, Emmanuel Lécharny <elecha...@gmail.com> wrote: > Le 18/11/15 14:34, Stephen Connolly a écrit : > > On Wednesday 18 November 2015, E

Re: RTC vs CTR (was: Concerning Sentry...)

2015-11-18 Thread Emmanuel Lécharny
Le 18/11/15 17:54, Ross Gardler a écrit : > Summarizing: > > In a healthy project I believe that the only significant things that change > between CTR and RTC are: > > 1) speed of commit (CTR is faster) > 2) quality of master, not releases (RTC catches most issues before commit, > CTR shortly

  1   2   >