Brian Slesinsky has posted comments on this change.
Change subject: Fix non deterministic behaviour in TypeTightener.
..
Patch Set 4: Code-Review+1
(1 comment)
Seems basically okay but I didn't verify anything about when it's
On Mon, Apr 15, 2013 at 8:48 PM, Ray Cromwell wrote:
> Another downside of DevMode maintenance is all the hacks needed in the
> codebase around isScript()/@GwtScriptOnly and other magic JVM stuff.
>
Many of those hacks are there for both performance and debugging (ie, where
the JS version is a mo
Roberto Lublinerman has posted comments on this change.
Change subject: Fix non deterministic behaviour in TypeTightener.
..
Patch Set 2:
(4 comments)
Commit Message
Line 9
Roberto Lublinerman has uploaded a new patch set (#4).
Change subject: Fix non deterministic behaviour in TypeTightener.
..
Fix non deterministic behaviour in TypeTightener.
JProgram.generalizeTypes(Collection) depends on the o
Roberto Lublinerman has uploaded a new patch set (#3).
Change subject: Fix non deterministic behaviour in TypeTightener.
..
Fix non deterministic behaviour in TypeTightener.
JProgram.generalizeTypes(Collection) depends on the o
Another downside of DevMode maintenance is all the hacks needed in the
codebase around isScript()/@GwtScriptOnly and other magic JVM stuff. There
are still lingering bugs in HostedModeClassRewriter around SingleJsoImpls
and generics. I agree that there is nothing that works as smoothly and JVM
roun
Good catch. The real solution IMHO to these issues is to do linker
processing on a JS AST, not on text. Most of the current linker API relies
on string operations which make designing a non-brittle sourcemap
difficult. If for example, we read the JS for the fragment via the
Closure/Rhino AST, then
Brian Slesinsky has posted comments on this change.
Change subject: Fix non deterministic behaviour in TypeTightener.
..
Patch Set 2: Code-Review+1
(3 comments)
Seems fine.
I was wondering whether we could replace LinkedHash
Ray Cromwell has posted comments on this change.
Change subject: Fix non deterministic behaviour in TypeTightener.
..
Patch Set 2: Code-Review+1
(1 comment)
I'm ok with the solution, but it leaves me wonder if we should opt w
Roberto Lublinerman has uploaded a new patch set (#2).
Change subject: Fix non deterministic behaviour in TypeTightener.
..
Fix non deterministic behaviour in TypeTightener.
JProgram.generalizeTyeps(Collection) depends on the o
Roberto Lublinerman has uploaded a new change for review.
https://gwt-review.googlesource.com/2530
Change subject: Fix non deterministic behaviour in TypeTightener.
..
Fix non deterministic behaviour in TypeTightener.
JProg
Roberto Lublinerman has posted comments on this change.
Change subject: Avoid creating anonymous inner classes with wildcard type
parameters.
..
Patch Set 3:
(3 comments)
...
Roberto Lublinerman has uploaded a new patch set (#4).
Change subject: Avoid creating anonymous inner classes with wildcard type
parameters.
..
Avoid creating anonymous inner classes with wildcard type parameters.
Under Java
Goktug Gokdogan has posted comments on this change.
Change subject: Avoid creating anonymous inner classes with wildcard type
parameters.
..
Patch Set 1:
(1 comment)
Sorry, I forgot to publish this one before.
...
Goktug Gokdogan has posted comments on this change.
Change subject: Avoid creating anonymous inner classes with wildcard type
parameters.
..
Patch Set 3:
(3 comments)
Fi
Roberto Lublinerman has posted comments on this change.
Change subject: Avoid creating anonymous inner classes with wildcard type
parameters.
..
Patch Set 2:
(8 comments)
...
Roberto Lublinerman has uploaded a new patch set (#3).
Change subject: Avoid creating anonymous inner classes with wildcard type
parameters.
..
Avoid creating anonymous inner classes with wildcard type parameters.
Under Java
Roberto Lublinerman has abandoned this change.
Change subject: Remove one source of non determinism in MethodInliner.
..
Abandoned
Sumbitted, thanks!
--
To view, visit https://gwt-review.googlesource.com/2490
To unsubscribe,
Goktug Gokdogan has posted comments on this change.
Change subject: Avoid creating anonymous inner classes with wildcard type
parameters.
..
Patch Set 2:
(9 comments)
Co
Brian Slesinsky has posted comments on this change.
Change subject: Adding a DOM clear method to RootPanel
..
Patch Set 3: Code-Review-1
I think this probably isn't worth doing. I don't see why we should change a
public API
Thomas Broyer has posted comments on this change.
Change subject: Adding a DOM clear method to RootPanel
..
Patch Set 2:
(1 comment)
File user/src/com/google/gwt/user/clien
Goktug Gokdogan has posted comments on this change.
Change subject: Adding a DOM clear method to RootPanel
..
Patch Set 2:
(3 comments)
Daniel, can you also respond to other concerns?
It is a good idea to respond every commen
Daniel Kurka has uploaded a new patch set (#3).
Change subject: Adding a DOM clear method to RootPanel
..
Adding a DOM clear method to RootPanel
By calling rootPanel.clear(true) the user can clear
widgets AND DOM elements locat
Daniel Kurka has posted comments on this change.
Change subject: Adding a DOM clear method to RootPanel
..
Patch Set 2:
(1 comment)
File user/src/com/google/gwt/user/client
Thomas Broyer has posted comments on this change.
Change subject: Removes api-checker reference JARs from the source tree.
..
Patch Set 1:
A lot of people will tell you that putting binaries in a VCS is a Bad
Thing™, and 99%
Daniel Kurka has uploaded a new patch set (#2).
Change subject: Add methods to HasTreeItems
..
Add methods to HasTreeItems
-getItem
-getItemCount
-getItemIndex
fixes ISSUE 30
Change-Id: I0a1a20be6dba36f3978d08178b92269b2736f1
Thomas Broyer has posted comments on this change.
Change subject: Adding a DOM clear method to RootPanel
..
Patch Set 2:
(1 comment)
IMO this should remove all child *nodes*, not only elements.
..
Daniel Kurka has uploaded a new patch set (#2).
Change subject: Adding a DOM clear method to RootPanel
..
Adding a DOM clear method to RootPanel
By calling rootPanel.clear(true) the user can clear
widgets AND DOM elements locat
Brian Slesinsky has posted comments on this change.
Change subject: Adding a DOM clear method to RootPanel
..
Patch Set 1:
I like that. Perhaps add Element.removeAllChildren() and put documentation
in root panel's javadoc sh
Goktug Gokdogan has posted comments on this change.
Change subject: Adding a DOM clear method to RootPanel
..
Patch Set 1:
(2 comments)
File user/src/com/google/gwt/user/cl
Roberto Lublinerman has posted comments on this change.
Change subject: Avoid creating anonymous inner classes with wildcard type
parameters.
..
Patch Set 1:
(6 comments)
...
Brian Slesinsky has posted comments on this change.
Change subject: Removes api-checker reference JARs from the source tree.
..
Patch Set 1:
It seems like we should have a separate repo in Gerrit for GWT
dependencies, with c
Goktug Gokdogan has posted comments on this change.
Change subject: Add methods to HasTreeItems
..
Patch Set 1: Code-Review+1
(9 comments)
Nit comments on javadoc style.
Although it is breaking change I guess it is safe to a
Roberto Lublinerman has uploaded a new patch set (#2).
Change subject: Avoid creating anonymous inner classes with wildcard type
parameters.
..
Avoid creating anonymous inner classes with wildcard type parameters.
Under Java
Brian Slesinsky has posted comments on this change.
Change subject: Verify that Timer has not been canceled before firing
..
Patch Set 3:
To be specific, it was changed as part of Ray's massive patch to support
module unload
Goktug Gokdogan has posted comments on this change.
Change subject: Verify that Timer has not been canceled before firing
..
Patch Set 3:
(2 comments)
File user/src/com/goo
Matthew Dempsky has abandoned this change.
Change subject: Reduce ClassSourceFileComposer memory and time complexity
to O(N)
..
Abandoned
Submitted.
--
To view, visit https://gwt-review.googlesource.com/2460
To unsubscribe
Matthew Dempsky has posted comments on this change.
Change subject: Verify that Timer has not been canceled before firing
..
Patch Set 3:
(2 comments)
File user/src/com/goo
Matthew Dempsky has posted comments on this change.
Change subject: Adding a DOM clear method to RootPanel
..
Patch Set 1: Code-Review+1
(2 comments)
File user/src/com/goog
Matthew Dempsky has posted comments on this change.
Change subject: Verify that Timer has not been canceled before firing
..
Patch Set 1:
FYI, no need to abandon. That error message was just for posting the
message to the m
Daniel Kurka has uploaded a new change for review.
https://gwt-review.googlesource.com/2512
Change subject: Adding a DOM clear method to RootPanel
..
Adding a DOM clear method to RootPanel
By calling rootPanel.clear(true) t
Thomas Broyer has posted comments on this change.
Change subject: Add methods to HasTreeItems
..
Patch Set 1: Code-Review+1
Should these methods in Tree and TreeItem be unit-tested?
How much do we care about breaking backward
Thomas Broyer has posted comments on this change.
Change subject: Verify that Timer has not been canceled before firing
..
Patch Set 2:
(3 comments)
Where can I find instructions for how to configure Eclipse
to not automatic
Daniel Kurka has uploaded a new change for review.
https://gwt-review.googlesource.com/2520
Change subject: Add methods to HasTreeItems
..
Add methods to HasTreeItems
-getItem
-getItemCount
-getItemIndex
fixes ISSUE 30
Ch
Daniel Kurka has posted comments on this change.
Change subject: Verify that Timer has not been canceled before firing
..
Patch Set 1: Code-Review+1
(4 comments)
small nits, see comments
.
45 matches
Mail list logo
