Re: [gwt-contrib] Re: GWT 2.7.0-RC1 is available

Release notes are here: http://www.gwtproject.org/release-notes.html#Release_Notes_2_7_0_RC1 -- You received this message because you are subscribed to the Google Groups "GWT Contributors" group. To unsubscribe from this group and stop receiving emails from it, send an email to google-web-toolk

Re: [gwt-contrib] Blocking RC1: Fold gwt-codeserver into gwt-dev

It looks like the gwt-codeserver jar will still exist, but the same classes will also be in gwt-dev.jar. So it's ugly but should be backward compatible? - Brian -- You received this message because you are subscribed to the Google Groups "GWT Contributors" group. To unsubscribe from this group

Re: [gwt-contrib] Blocking RC1: Fold gwt-codeserver into gwt-dev

Yes, merging the jars should be fine as a short-term fix. Codeserver should be built as a separate library to enforce that there are no circular dependencies. (We already have one for DevMode -superDevMode but that should be fixed by splitting out DevMode; it doesn't belong in the same library as

Re: [gwt-contrib] Re: GWT 2.7 release plan

I think this is okay as long as it doesn't cause tests to fail. Elemental is quite separate from everything else so it seems low risk. Daniel? On Thu, Oct 9, 2014 at 8:57 AM, Leif Åstrand wrote: > Lots of Elemental patches have been merged in the last few days, but we do > still have a short lis

Re: [gwt-contrib] Re: GWT 2.7 release plan

It's experimental and hidden behind a flag, but it's there. On Wed, Oct 1, 2014 at 6:20 PM, Cristian Rinaldi wrote: > - JsInterop Preview is part of the release? > > El miércoles, 1 de octubre de 2014 16:15:26 UTC-3, Daniel Kurka escribió: > >> Hi all, >> >> we just settled on a GWT 2.7 release

Re: [gwt-contrib] GWT 2.7 release plan

- Make sure sample apps work with DevMode -superdevmode - I think we're waiting on a patch to CLDR 25 On Wed, Oct 1, 2014 at 12:15 PM, 'Daniel Kurka' via GWT Contributors < google-web-toolkit-contributors@googlegroups.com> wrote: > Hi all, > > we just settled on a GWT 2.7 release plan: > > - We

Re: [gwt-contrib] Trying SDM with Java 1.6 Issue gotcha

Actually, that particular stack trace should be fixed by this uncommitted patch: https://gwt-review.googlesource.com/#/c/9361/ However, I haven't tested it on Java 1.6. On Tue, Sep 30, 2014 at 11:48 AM, Brian Slesinsky wrote: > Oops. This particular bug shouldn't be hard to fi

Re: [gwt-contrib] Trying SDM with Java 1.6 Issue gotcha

Oops. This particular bug shouldn't be hard to fix. On Tue, Sep 30, 2014 at 10:50 AM, Brandon Donnelson wrote: > Just a thought, the folks that forget to update Java 1.6 to Java 1.7 in > their project and run SDM (super dev mode) will have issues. A warning > could be useful for those trying to

Re: [gwt-contrib] Re: SDM "-XcompilePerFile": initial feedback

This sounds like it might be a deadlock. Could you jstack to get a thread dump of the running process? It should tell us where it's stuck. On Tue, Sep 9, 2014 at 8:42 AM, Jens wrote: > recentish ones are: >> 267ad5efd00aae9b0f69eca793891e9fdad28e45 "Opts compilePerFile into >> noPrecompile to

Re: [gwt-contrib] Re: SDM "-XcompilePerFile": initial feedback

> > > On Mon, Sep 8, 2014 at 3:00 PM, Jens wrote: > >> >>> And a last question just popped up again: Is there any way to force >> embedded Jetty of CodeServer to not print out request logs at DEBUG level? >> Kind of annoying when all these progress requests show up between GWT logs. >> > i don't k

Re: [gwt-contrib] JsInterop Advance

I'm eager to start using Java 8 too, but I think we should wait until we have Java 8 committed (behind a flag) before having the discussion about whether to require it for anything. As we've found with incremental compile, sometimes we end up changing direction a bit to reach our goal, so there's n

Re: [gwt-contrib] Re: Dropping IE8 support in useragent-less GWT

It would make sense in principle but we don't know anyone who wants to target older browsers without also using permutations. On Tue, Jul 15, 2014 at 3:55 AM, Jens wrote: > I believe Google builds applications that use Elemental and/or JsInterop, >> so they don't use c.g.g.dom.DOM or any other t

Re: [gwt-contrib] JettyLauncher class loader

I don't understand the details enough to make an informed recommendation, but I think introducing a new entry point is a good time to transition to the standard way (assuming it is standard). We could add the backward-compatibility flag if needed after some testing to see what the breakage would b

Re: [gwt-contrib] Re: GWTproject site menu

If you click "Tutorial" and then "Documentation" the animation is a bit unfortunate. Because the previous menu closes at the same time that the new one opens, the new menu expands both up and down so that your cursor ends up pointing to the middle of the new menu, and then you have to wait until it

Re: [gwt-contrib] JavaWriter API as replacement for SourceWriter family

I believe it's just an idea. In practice, we have lots of GWT generator code that's not easily migrated. I'm not familar with APT but if I wanted to learn about it I would probably start by studying Guice's AutoValue. If they're using JavaWriter then that's a good endorsement. - Brian On Thu, Fe

Re: [gwt-contrib] bug in permutations.js?

Maybe turn on soft permutations in a sample app, since we do at least test those manually before a release. Long-term, I'd like to see us using soft permutations by default, perhaps to collapse some browser permutations. If it were more commonly used then we'd likely notice that it's broken pretty

Re: [gwt-contrib] Re: Not able to run GWTTestCase

I'm not an Eclipse user, but we did upgrade to Jetty 8.1 in 2.6 and its package changed. If you put the new version of Jetty in your classpath that will probably fix it. - Brian On Thu, Feb 13, 2014 at 6:44 AM, Stephan Beutel wrote: > I also tried it with the Eclipse 3.8 and end up at the same

Re: [gwt-contrib] bug in permutations.js?

Yes it sounds like a bug. Want to add that to the issue tracker? I wonder why more people aren't seeing this? Does it only affect soft permutations? - Brian On Thu, Feb 13, 2014 at 11:41 AM, Stephen Haberman wrote: > Hey, > > We upgraded to GWT 2.6 last week, and our seeing weirdness with >

Re: [gwt-contrib] Using JIRA as issue tracker instead of google code - and other things

I just ran a bulk edit to change all 2.6 bugs marked "fixed not released" to "fixed". Thanks for catching that! (Switching to a different issue tracker is a whole different discussion.) - Brian On Wed, Feb 5, 2014 at 11:22 AM, Gilberto Torrezan Filho < gilberto.torre...@gmail.com> wrote: > Hi

Re: [gwt-contrib] Re: Quarterly Hangouts On Air

Perhaps have an occasional "meeting day" on the mailing list or in G+, sort of like a Reddit "Ask me anything"? This might work better with people in different timezones. On Mon, Jan 27, 2014 at 11:39 AM, Goktug Gokdogan wrote: > Just FYI, our gwt-team meetings didn't get enough interest for l

Re: [gwt-contrib] Re: IntelliJ IDEA set-up

Generally I just exclude the super classes from the project; since there should always a server-side equivalent, the rest of the code should still compile. You lose syntax checking on the super files, though. On Wed, Jan 15, 2014 at 12:10 PM, Danilo Reinert wrote: > I'm unable to avoid java com

Re: [gwt-contrib] What about the release of 2.6.0?

Sometime in January after people are back from vacation. On Mon, Dec 30, 2013 at 11:42 AM, Cristiano wrote: > Hello all, > it is many days I don't see info about the release date for GWT 2.6.0... > > I see in GWT issues there are 7 issues for milestone 2_6 that are not in > state > "FixedNotRel

Re: [gwt-contrib] Rebinding Methods improvement proposal and working prototype

This is well-documented and looks like solid work. I think the main issue will be whether it can be made compatible with modular compilation. So the best timing will be to land it after modular compilation. It looks like it should be compatible because the compiler doesn't need to see how a @Rebin

Re: [gwt-contrib] Re: Jetty 9

For GWT 2.6, Super Dev Mode, and the RemoteServiceServlet, you could set the gwt.codeserver.port Java property. On Wed, Nov 20, 2013 at 1:35 AM, Jens wrote: > The issue comes up when we change a piece of shared code, like a DTO. What >> we've found is that if we don't stop, recompile from the

Re: [gwt-contrib] String concatenation

Not a compiler expert, but I wouldn't be surprised since in the AST it will be represented as a binary tree of JBinaryOperation nodes and the visitors walk the tree recursively. So balancing the tree should result in a smaller stack. - Brian On Wed, Oct 30, 2013 at 1:10 PM, Julien Dramaix wrote

Re: [gwt-contrib] Re: Change in gwt[master]: Added disabled IE10 permutation

On Wed, Oct 23, 2013 at 11:59 AM, Jens wrote: > Hmm. It's a fair point. On the other hand, you don't *have* to upgrade >> right away. >> > > Hehe sure, but its hard to resist Java7, @GwtIncompatible support and > compiler/code splitting bug fixes ;-) > > But maybe I misunderstood Matthew's post?

[gwt-contrib] Re: Change in gwt[master]: Added disabled IE10 permutation

Hmm. It's a fair point. On the other hand, you don't *have* to upgrade right away. Assuming third-party libraries want to upgrade, it might be easier to make "works with 2.6" mean "works with a separate ie10 permutation" rather than having to support two modes for 2.6. This doesn't scale, but if t

Re: [gwt-contrib] Re: Bad news for GWT DevMode!

I expect that by next summer devmode will *only* work in IE and perhaps an older version of Firefox. Oddly enough, the IE plugin has apparently worked for years with no complaints. (But the issue is that nobody currently on the team has ever built it.) - Brian On Mon, Oct 21, 2013 at 6:56 AM, Tho

Re: [gwt-contrib] Re: Issue with development mode plugin and Custom selection script / hosted.html that allows separate debugging of multiple GWT applications on a single page

For (1), Super Dev Mode supports multiple GWT apps out of the box. (but you do have to recompile each GWT application you want to debug, one at a time). For (2) I don't think we support multiple instances of the same GWT app. I don't think it's a good idea because you'd be loading the same JavaScr

Re: [gwt-contrib] Re: Steering committee meeting on GWT 3.0 IE & Java compatibility

Okay, we previously talked about having some kind of deprecation policy and I'm fine with that; it seems a lot more limited in scope. I think a reasonable thing to do is to announce that we're dropping a browser version one release before it happens, so we should decide now about what we're going

Re: [gwt-contrib] Re: Steering committee meeting on GWT 3.0 IE & Java compatibility

wrote: > But we now have a steering committee, and decisions are made in public so > anyone can bug you when you forget. That's a different situation than > before. > Le 8 oct. 2013 22:43, "Brian Slesinsky" a écrit : > >> >> On Tue, Oct 8, 2013 at 12:15

Re: [gwt-contrib] Re: Steering committee meeting on GWT 3.0 IE & Java compatibility

On Tue, Oct 8, 2013 at 12:15 PM, Jens wrote: > [...] since in practice we won't consider ourselves bound to them. >> > > Why not? > Because we'll either we'll forget about that page due to turnover or something new will happen and priorities will change. Put it this way: how much do you feel bou

Re: [gwt-contrib] Re: Steering committee meeting on GWT 3.0 IE & Java compatibility

I don't think we should be publishing general rules to the GWT website, since in practice we won't consider ourselves bound to them. At this point I think we're in general agreement that IE6/7 will be dropped after GWT 2.6 and the rest is still being discussed. Dropping Java 6 support doesn't seem

Re: [gwt-contrib] Re: Maven-ization Status

I haven't tried it, but it says here that Gradle has support for publishing to Maven: http://www.gradle.org/docs/current/userguide/publishing_maven.html On Sat, Sep 28, 2013 at 10:49 PM, Cristiano Costantini < cristiano.costant...@gmail.com> wrote: > Hello, > What do you think of having gradle

[gwt-contrib] meeting notes for September 25

September 25, 2013 - Hangout on air today - Matt shared the GWT 2.6 release plan (doc ) - feature-complete November 4th. Release on December 2. - Bhaskar: which feature

Re: [gwt-contrib] Re: Maven-ization Status

I skimmed the Gradle manual and it looks pretty decent. While the syntax and terminology is different, it looks like the concepts map back to stuff I'm already comfortable with. It has "tasks" which are basically build rules which are configured via Groovy (instead of Python macros). The tool buil

Re: [gwt-contrib] Re: Maven-ization Status

On Thu, Sep 26, 2013 at 10:26 AM, Jens wrote: > >> In terms of Gradle vs Buck models, is there any possibility of writing >> a tool that takes a Buck build file and produces Gradle files? That would >> seem like a good option in lieu of waiting for Buck support in IntelliJ and >> Eclipse. This

Re: [gwt-contrib] Re: Maven-ization Status

As a stop-gap measure, can you clean up and check in your IDEA module(s)? - Brian On Wed, Sep 25, 2013 at 9:20 AM, Ray Cromwell wrote: > > The biggest problem with being a GWT contributor today is that it is hard, > very hard, to set up an environment to develop. If you look at the original > GW

Re: [gwt-contrib] Possible firefox leak fix

think there are other ways we could think about doing > this as well, but changing hosted.html keeps it consistent across the board. > > > On Tuesday, September 24, 2013 6:50:07 PM UTC-5, Brian Slesinsky wrote: > >> Hi, >> >> Wow, thanks for tracking thi

Re: [gwt-contrib] Possible firefox leak fix

Hi, Wow, thanks for tracking this down! Could you send a patch that just modifies the source (not worrying about the autogenerated files)? I will rebuild them when I do the next release. Usually I just leave the existing dll's alone and move forward; it's not worth fixing older plugins. However,

[gwt-contrib] Google team meeting notes for September 18 and September 11

September 18, 2013 Talking about Q4 goals: * Separate compilation: more people to help John? How to divide the work? Java / JavaScript integration: Ray says he's going to be working on this for Q4, along with Closure compiler integration. * SuperDevMode: fast compile cycles is most important. Bria

[gwt-contrib] Google team meeting notes for September 4, August 28, August 21

Here are some notes for our last few meetings. I'm sure a comparison between our notes and the YouTube video [1] would show I missed a few things. :-) [1] https://www.youtube.com/watch?v=hIgR7-3ZAMc September 4, 2013 Brian: meeting with someone working on Chrome devtools to get up to speed. Gokt

Re: [gwt-contrib] gwt.junit.testcase.includes broken?

Hi, my guess is that it's just an oversight; at Google we have our own build stystem so we don't use the ant scripts all that often. If you want to dive in, I'd be interested in what you find. - Brian On Sat, Aug 31, 2013 at 2:33 PM, Daniel Trebbien wrote: > Hi, > > I am trying to run only the

Re: [gwt-contrib] Re: I'm enhancing GWT to provide Java stack traces for clientside exceptions in production

Thanks for looking into how to improve Java stack traces. I agree that we could do a better job. However, there are some problems with your approach: First of all, we can't guarantee that we will accept this change. That doesn't seem very fair to whoever might be donating money. I would like to m

Re: [gwt-contrib] Initial support for @GwtCreate (code-gen methods)

Interesting. I like the idea of replacing class parameters with something else. I'm not sure we need to sweep the implementation under the rug. Particularly in fancier scenarios, it might be easier to work with it explicitly. Suppose we have: /** Encapsulates a GWT create call. */ interface Creat

Re: [gwt-contrib] Integrating Spiffy UI into GWT

It seems like a nice project, but integrating it into GWT will slow down both the GWT developers and the SpiffyUI developers a lot. There would have to be some pretty compelling reasons to do that. Otherwise, better to let them keep doing what they're doing, and let them ask for specific changes to

Re: [gwt-contrib] Re: Google team meeting notes for August 7 (and earlier)

I did do some profiling and at the time it looked like a good 40% was spent in the JDT. It will depend on the app though; I'm not satisfied I understand the performance. I've built some infrastructure for collecting better performance metrics inside Google, but at the moment I've put that aside to

Re: [gwt-contrib] Possible GWT.create() Improvements (link)

r for entry >>> to generators. >>> >>> >>> With that move, deferred binding definition for code generator can be >>> just about providing the naming conventions such as " >>> -> $Generated". >>> Based on the rule, when t

Re: [gwt-contrib] Possible GWT.create() Improvements (link)

> > >2. IDE support: IDE can trigger codegen (esp. for debugging) >> > > My experience with this has been pretty poor, and running GWT with -gen is > at least as useful. > Also, Super Dev Mode gives you access to all the generated code. You can either use the browser's debugger with SourceMaps

Re: [gwt-contrib] Patch to support GWT.create(this.getClass())

I've published that doc here: https://docs.google.com/document/d/1MDqiBEMl7dylYliAceLBBxGFAlSvkQB9b-kSlnKmZBk/edit?disco=AGXNBZg#heading=h.gks1bp7hz61l To clarify, I'm not myself working on any GWT.create() enhancements, but I thought it was worth documenting my concerns in greater detail rath

[gwt-contrib] Possible GWT.create() Improvements (link)

Hi, I've published a document [1] with my thoughts on some of the GWT.create() proposals. This doesn't cover everything we've discussed but I think it's a start. If you're on this mailing list you should be able to comment. - Brian [1] https://docs.google.com/document/d/1MDqiBEMl7dylYliAceLBBxGFA

[gwt-contrib] Re: Google team meeting notes for August 7 (and earlier)

Dev Mode for a Google team > I would be nice to hear how this was done on such large projects as Google > has. I try with out application (170k LOC of client code / GWT-RPC, etc.) > and it took 2x-3x more time then DevMode. > > > On Thursday, August 8, 2013 11:04:04 PM UTC+2

[gwt-contrib] Re: Google team meeting notes for August 7 (and earlier)

Our plan is to make Super Dev Mode compile faster. Plan B is to use an extended release of Firefox for a while. (I believe Firefox 24 is the next one.) Despite appearances, I'm not actually a C++ programmer and I'm not plugged into the Firefox community enough to know how realistic it is that i

Re: [gwt-contrib] Nextgen GWT/JS Interop (Public) (google-web-toolkit-contributors@googlegroups.com)

porting libraries defined in TS, Dart, haXe, et al > via some kind of standard plugin extension. > > > > On Thu, Aug 8, 2013 at 9:08 AM, Brian Slesinsky wrote: > >> It might be nice to be able to say that anything defined in a .d.ts can >> be imported into GWT. This will ma

[gwt-contrib] Google team meeting notes for August 7 (and earlier)

I haven't been sending out emails for our meetings. Let's catch up: August 7th: - John got a "hello world" app running using separate compilation. We talked a bit about how it might get pulled back into GWT. - Brian: Firefox architecture changes may break the Development Mode plugin by the end of

Re: [gwt-contrib] Nextgen GWT/JS Interop (Public) (google-web-toolkit-contributors@googlegroups.com)

It might be nice to be able to say that anything defined in a .d.ts can be imported into GWT. This will make it easier to work with JavaScript programmers since they don't have to write any Java code. So perhaps it's worth making sure that generating the Java interfaces from .d.ts files will work?

[gwt-contrib] Change in gwt[master]: Super Dev Mode: deemphasize unused Java lines in codeserver'...

Brian Slesinsky has submitted this change and it was merged. Change subject: Super Dev Mode: deemphasize unused Java lines in codeserver's UI .. Super Dev Mode: deemphasize unused Java lines in codeserver's UI Mo

[gwt-contrib] Change in gwt[master]: Super Dev Mode: deemphasize unused Java lines in codeserver'...

t Gerrit-Branch: master Gerrit-Owner: Brian Slesinsky Gerrit-Reviewer: Brian Slesinsky Gerrit-Reviewer: John Stalcup Gerrit-Reviewer: Leeroy Jenkins Gerrit-Reviewer: Matthew Dempsky -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are su

[gwt-contrib] Change in gwt[master]: Super Dev Mode: deemphasize unused Java lines in codeserver'...

Brian Slesinsky has posted comments on this change. Change subject: Super Dev Mode: deemphasize unused Java lines in codeserver's UI .. Patch Set 1: (7 comments)

[gwt-contrib] Change in gwt[master]: Super Dev Mode: deemphasize unused Java lines in codeserver'...

t Gerrit-Branch: master Gerrit-Owner: Brian Slesinsky Gerrit-Reviewer: John Stalcup Gerrit-Reviewer: Leeroy Jenkins Gerrit-Reviewer: Matthew Dempsky -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups &q

[gwt-contrib] Change in gwt[master]: Super Dev Mode: deemphasize unused Java lines in codeserver'...

Brian Slesinsky has uploaded a new change for review. https://gwt-review.googlesource.com/3600 Change subject: Super Dev Mode: deemphasize unused Java lines in codeserver's UI .. Super Dev Mode: deemphasize unused

[gwt-contrib] Change in gwt[master]: Move StackTraceDeobfuscator from core.server.impl to core.se...

Brian Slesinsky has posted comments on this change. Change subject: Move StackTraceDeobfuscator from core.server.impl to core.server. .. Patch Set 2: Code-Review+2 -- To view, visit https://gwt-review.googlesource.com/3512

[gwt-contrib] Change in gwt[master]: Optimize initializing fields at the top scope.

Brian Slesinsky has posted comments on this change. Change subject: Optimize initializing fields at the top scope. .. Patch Set 3: (2 comments) File dev/core/src/com

[gwt-contrib] Google GWT team meeting notes for June 26th

Hi, in the interest of increased transparency, I'm going to start posting notes from GWT team meetings at Google. I'm not sure if we'll keep this up but we'll see how it goes. (My apologies in advance for any errors.) June 26, 2013 - Discussed goals for the next quarter. Of interest to the commu

[gwt-contrib] Change in gwt[master]: Fix support for Document.{get,set}ScrollLeft() in RTL for sa...

Brian Slesinsky has submitted this change and it was merged. Change subject: Fix support for Document.{get,set}ScrollLeft() in RTL for safari and ie9. .. Fix support for Document.{get,set}ScrollLeft() in RTL for safari and

[gwt-contrib] Change in gwt[master]: Fix support for Document.{get,set}ScrollLeft() in RTL for sa...

Brian Slesinsky has posted comments on this change. Change subject: Fix support for Document.{get,set}ScrollLeft() in RTL for safari and ie9. .. Patch Set 4: Verified+1 Code-Review+2 Looks like all issues have been

Re: [gwt-contrib] Re: Temporarily disabling CR+2 on Gerrit

Update: as far as I know, nobody worked on this today. But on the bright side, nothing had to be rolled back. (I worked on getting the Firefox plugin ready for Firefox 22. It should be out on time.) On Thu, Jun 20, 2013 at 3:32 PM, Matthew Dempsky wrote: > As a ~24h later status report, we ass

[gwt-contrib] Change in gwt[master]: Adds isStandalone to ImageResource so Image can used an Uncl...

Brian Slesinsky has posted comments on this change. Change subject: Adds isStandalone to ImageResource so Image can used an UnclippedState. .. Patch Set 8: Had to roll this back again due to projects that implement the

[gwt-contrib] Change in gwt[master]: Add hasClassName method in com.google.gwt.dom.client.Element

Brian Slesinsky has posted comments on this change. Change subject: Add hasClassName method in com.google.gwt.dom.client.Element .. Patch Set 7: As mentioned above, there's a conflict with Sencha which bit us when we

[gwt-contrib] Change in gwt[master]: Adds an accessor to original throwable from SerializableThro...

Brian Slesinsky has posted comments on this change. Change subject: Adds an accessor to original throwable from SerializableThrowable. .. Patch Set 2: Code-Review+2 (1 comment

[gwt-contrib] Change in gwt[master]: Adds an accessor to original throwable from SerializableThro...

Brian Slesinsky has posted comments on this change. Change subject: Adds an accessor to original throwable from SerializableThrowable. .. Patch Set 1: Code-Review+1 (1 comment) Seems basically okay

Re: [gwt-contrib] Work to do for bug 3042

Another possibility would be to develop a nicer GWT RichTextArea as a separate open source project. There's no reason it has to be in core GWT right away and you'll be able to work faster that way. With real-world usage, you'll probably learn a few things that will make it better quality if we do m

Re: [gwt-contrib] Issue 8083, needs some input from GWT team

cause the RPC system of GWT has limitations. > > David > > > On Thu, Jun 13, 2013 at 10:20 PM, Brian Slesinsky wrote: > >> I agree; this seems like a workaround for one application that picked the >> wrong datatype. Maybe we should warn about BigDecimal being slo

[gwt-contrib] Change in gwt[master]: Adding a DOM clear method to RootPanel

Brian Slesinsky has posted comments on this change. Change subject: Adding a DOM clear method to RootPanel .. Patch Set 6: Code-Review+2 This is a pretty minor change, breakage is unlikely, and I don't think it matter

[gwt-contrib] Change in gwt[master]: Use JSON.parse() instead of eval() to deserialize rpc callba...

Brian Slesinsky has posted comments on this change. Change subject: Use JSON.parse() instead of eval() to deserialize rpc callback payload .. Patch Set 11: Sounds like we need more tests. Serialization code generally does

[gwt-contrib] Change in gwt[master]: Adding a DOM clear method to RootPanel

Brian Slesinsky has posted comments on this change. Change subject: Adding a DOM clear method to RootPanel .. Patch Set 6: Admittedly it's a judgment call. I'm somewhat biased in favor of shorter names and somewh

Re: [gwt-contrib] Issue 8083, needs some input from GWT team

I agree; this seems like a workaround for one application that picked the wrong datatype. Maybe we should warn about BigDecimal being slow somewhere? If someone wants to do some performance tests of GWT-RPC serialization, publishing the results would be useful to the community. My recommendation i

[gwt-contrib] Change in gwt[master]: Adding a DOM clear method to RootPanel

Brian Slesinsky has posted comments on this change. Change subject: Adding a DOM clear method to RootPanel .. Patch Set 6: (1 comment) I still don't think it's necessary but I'm okay with a helper method

Re: [gwt-contrib] Issue 8083, needs some input from GWT team

Lazy parsing can be a performance win, but it also complicates the API in the case of a parse error. Have you thought about how to report errors when they happen later? It might less confusing to solve this using a separate LazyBigDecimal class. People can declare fields of this type in their data

[gwt-contrib] Change in gwt[master]: Fix non-final field initializers running before the super cstr.

Brian Slesinsky has posted comments on this change. Change subject: Fix non-final field initializers running before the super cstr. .. Patch Set 9: Oops, that wasn't very clear. Let me try again: If think you'r

[gwt-contrib] Change in gwt[master]: Fix non-final field initializers running before the super cstr.

Brian Slesinsky has posted comments on this change. Change subject: Fix non-final field initializers running before the super cstr. .. Patch Set 9: Regarding git procedure, I've already rolled back on google/pu a

[gwt-contrib] Change in gwt[master]: Remove unused, package-private FastStringMap.

Brian Slesinsky has posted comments on this change. Change subject: Remove unused, package-private FastStringMap. .. Patch Set 1: Code-Review+2 Not used in Google code either. -- To view, visit https://gwt

Re: [gwt-contrib] Re: ValueListBox should implement HasEnabled (6112) (issue1832803)

+mdempsky Hi, I think you're going to have more trouble than most because you're using Windows and that's not so common for GWT development. The code to automatically add the Change-Id line is specific to Unix but you can do it manually by editing the changelist yourself. To fix your most recent c

[gwt-contrib] Change in gwt[master]: Fix non-final field initializers running before the super cstr.

Brian Slesinsky has posted comments on this change. Change subject: Fix non-final field initializers running before the super cstr. .. Patch Set 9: Hi, we had a performance regression reported to us so we rolled this CL

[gwt-contrib] Change in gwt[master]: The job of defineSeed is to mark the existence of a class an...

Brian Slesinsky has posted comments on this change. Change subject: The job of defineSeed is to mark the existence of a class and associate its castMap with the class's various constructors. .. Patch Set 2: (1 co

[gwt-contrib] Change in gwt[master]: Revert "Update how columns are hidden in CellTable."

Brian Slesinsky has submitted this change and it was merged. Change subject: Revert "Update how columns are hidden in CellTable." .. Revert "Update how columns are hidden in CellTable."

[gwt-contrib] Change in gwt[master]: Revert "Update how columns are hidden in CellTable."

Brian Slesinsky has reverted this change. Change subject: Revert "Update how columns are hidden in CellTable." .. Patch Set 3: Reverted This patchset was reverted in change: I6df575d6d1f5e8b5ec5bef54d5ede7ad2dfca1

[gwt-contrib] Change in gwt[master]: Update how columns are hidden in CellTable.

Brian Slesinsky has posted comments on this change. Change subject: Update how columns are hidden in CellTable. .. Patch Set 3: (1 comment) File user/src/com/google/gwt

[gwt-contrib] Change in gwt[master]: Ensures integer pixel values and adds getters for subpixel v...

Brian Slesinsky has posted comments on this change. Change subject: Ensures integer pixel values and adds getters for subpixel values .. Patch Set 2: Yeah I was afraid of that. If everyone should be using it, what then

[gwt-contrib] Change in gwt[master]: Use JSON.parse() instead of eval() to deserialize rpc callba...

Brian Slesinsky has posted comments on this change. Change subject: Use JSON.parse() instead of eval() to deserialize rpc callback payload .. Patch Set 7: (4 comments) Looking good

[gwt-contrib] Change in gwt[master]: Ensures integer pixel values and adds getters for subpixel v...

Brian Slesinsky has posted comments on this change. Change subject: Ensures integer pixel values and adds getters for subpixel values .. Patch Set 2: Thanks for the explanation. Is there any way to test this other than

Re: [gwt-contrib] serializing final fields

On Wed, Jun 5, 2013 at 7:46 PM, Stephen Haberman wrote: > > > I don't have a good idea about what could break > > I believe nothing would "break"--it's that final fields that were > previously not going over the wire would now go over the wire. > It's also possible that the newly exposed final fi

Re: [gwt-contrib] serializing final fields

I don't have a good idea about what could break, but who knows what we'll find. I think we will at least want a flag to turn it on and off. It might be temporary just to land the patch; not sure if it should survive until the 2.6 release. On Wed, Jun 5, 2013 at 9:03 AM, Stephen Haberman wrote:

[gwt-contrib] Change in gwt[master]: Use JSON.parse() instead of eval() to deserialize rpc callba...

Brian Slesinsky has posted comments on this change. Change subject: Use JSON.parse() instead of eval() to deserialize rpc callback payload .. Patch Set 5: (3 comments) I like where this is going. As I understand it, all

[gwt-contrib] Change in gwt[master]: Use JSON.parse() instead of eval() to deserialize rpc callba...

Brian Slesinsky has posted comments on this change. Change subject: Use JSON.parse() instead of eval() to deserialize rpc callback payload .. Patch Set 4: On the server side, I don't think we need a max version? I

[gwt-contrib] Change in gwt[master]: Ensures integer pixel values and adds getters for subpixel v...

Brian Slesinsky has posted comments on this change. Change subject: Ensures integer pixel values and adds getters for subpixel values .. Patch Set 2: [4] is shorter than [1]. The only question is how common it is. I

[gwt-contrib] Change in gwt[master]: Use JSON.parse() instead of eval() to deserialize rpc callba...

Brian Slesinsky has posted comments on this change. Change subject: Use JSON.parse() instead of eval() to deserialize rpc callback payload .. Patch Set 4: Feasible? I'd guess yes. Up to the implementer to decide how

[gwt-contrib] Change in gwt[master]: Update how columns are hidden in CellTable.

Brian Slesinsky has posted comments on this change. Change subject: Update how columns are hidden in CellTable. .. Patch Set 3: Code-Review+2 -- To view, visit https://gwt-review.googlesource.com/3130 To unsubscribe, visit

[gwt-contrib] Change in gwt[master]: Ensures integer pixel values and adds getters for subpixel v...

Brian Slesinsky has posted comments on this change. Change subject: Ensures integer pixel values and adds getters for subpixel values .. Patch Set 1: I don't have a strong opinion either way, but I'll point out

[gwt-contrib] Change in gwt[master]: Update how columns are hidden in CellTable.

Brian Slesinsky has posted comments on this change. Change subject: Update how columns are hidden in CellTable. .. Patch Set 2: Code-Review+2 Seems okay. If we really need "0%" we can do it later. -- To view, v

  1   2   3   4   >