Permutation is a pretty deeply internal type that shouldn't be exposed.
LGTM.
http://gwt-code-reviews.appspot.com/194801
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Reviewers: scottb, Lex,
Message:
Ready for another look. This patch moves to a more linker-centric
approach.
One note about the change to JUnit.gwt.xml to collapse all properties
(thereby producing one permutation) is that it cuts the time of web-mode
smoke tests by 20-30%.
Description:
This p
On Wed, Mar 17, 2010 at 2:33 PM, wrote:
> Still, what is the use case for globs other than a bare "*" ?
You mean like:
gecko*
ie*
--
Bob Vawter
Google Web Toolkit Team
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
> Those are trivial already. Is there any new use case enabled by it? -Lex
No, it's just a convenience thing. I'm thinking about localized apps
that would have N-many en_?? kind of locale values.
--
Bob Vawter
Google Web Toolkit Team
--
http://groups.google.com/group/Google-Web-Toolkit-Cont
On Wed, Mar 17, 2010 at 4:06 PM, John Tamplin wrote:
> While that may work for some trivial cases, in many cases you will need more
> nuanced control over what gets collapsed, considering locale inheritance and
> aliases.
That sounds like a pre-GWT-compile tool that auto-generates a chunk of gwt.
> Depending on the string name of an enum looks suboptimal.
What are you referring to?
--
Bob Vawter
Google Web Toolkit Team
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Thank you for the feedback.
> It was trivial to hook up the findClientOracleData to work with the existing
> process
Excellent.
> - NPE in the WebModeClientOracle.readStreamAsObject finally block if
> objectInputStream can't be created (ie: if the format is invalid)
Will fix.
> - If the G
Reviewers: Ray Ryan,
Message:
Review requested.
Description:
This allows you to write
@external gwt-*;
or even
@external *;
instead of manually enumerating every class selector in a CssResource
input file
Please review this at http://gwt-code-reviews.appspot.com/243803/show
Affected files:
The __static object is injected into the JavaScript namespace by the
development mode plugin upon startup and is used to dispatch calls to
static methods and accesses to static fields.
--
Bob Vawter
Google Web Toolkit Team
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
To un
Ready for another round of reviews.
I rebased patch set 6 to r7776.
http://gwt-code-reviews.appspot.com/160801/diff/16001/17002
File dev/core/src/com/google/gwt/core/ext/linker/SoftPermutation.java
(right):
http://gwt-code-reviews.appspot.com/160801/diff/16001/17002#newcode25
dev/core/src/com/
LGTM, echoing tbroyer's comment about the main() method. Any reason you
didn't re-use the reflective parser with a Schema that ignores unknown
elements?
http://gwt-code-reviews.appspot.com/284801/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
To unsubscribe from this gr
LGTM.
http://gwt-code-reviews.appspot.com/289801/diff/1/10
File dev/core/src/com/google/gwt/dev/javac/StandardGeneratorContext.java
(right):
http://gwt-code-reviews.appspot.com/289801/diff/1/10#newcode240
dev/core/src/com/google/gwt/dev/javac/StandardGeneratorContext.java:240:
private final Map
It's not a critical component of the serving infrastructure, but maybe
add a comment that any future changes should probably be re-implemented
with a Schema.
http://gwt-code-reviews.appspot.com/284801/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
To unsubscribe from thi
Reviewers: Dan Rice,
Message:
Review requested.
Description:
GWT RPC doesn't conside GenericType to be serializable because it
doesn't think that Void is serializable.
Please review this at http://gwt-code-reviews.appspot.com/294801/show
Affected files:
A
user/src/com/google/gwt/user/clien
On Wed, Mar 31, 2010 at 12:42 PM, Ray Ryan wrote:
> I don't follow your assertion, scott. I'm pretty sure that null is the
> only legal value for a Void field, so what's the big deal about
> serializing it?
null is the only value. This supports a command-style use case where
you have an RPC inte
Reviewers: jgw,
Message:
Joel,
This review isn't super high-priority and is kind of long. I got a
more than just a bit irritated at how hard it was to try to make what
should have been a simple change to ImageResourceGenerator and decided
that the code needed a rework. If you think that someo
Reviewers: scottb,
Description:
Log AssertionErrors thrown by Generators to improve developer
experience.
Fix typo in existing log message.
Patch by: bobv
Review by: scottb
Please review this at http://gwt-code-reviews.appspot.com/362801/show
Affected files:
M dev/core/src/com/google/gwt
-toolkit/issues/detail?id=4797
Patch by: bobv
Review by: rjrjr
Please review this at http://gwt-code-reviews.appspot.com/306802/show
Affected files:
M user/src/com/google/gwt/resources/client/ClientBundle.java
M user/src/com/google/gwt/resources/client/CssResource.java
M user/src/com/google
Reviewers: Ray Ryan,
Message:
Review requested.
Description:
This patch changes how UiBinder's compile-time DOM structure is
generated so that we can provide accurate location information to the
developer when logging errors. Instead of using a DOM parser, this
patch builds a DOM using a SAX pa
Reviewers: Ray Ryan,
Message:
Review requested.
Description:
This patch builds on the first by reworking callers of MortalLogger to
include a contextual XMLElement.
Please review this at http://gwt-code-reviews.appspot.com/395801/show
Affected files:
M
user/src/com/google/gwt/uibinder/attr
New patch for review.
http://gwt-code-reviews.appspot.com/394801/diff/1/2
File user/src/com/google/gwt/uibinder/rebind/MortalLogger.java (right):
http://gwt-code-reviews.appspot.com/394801/diff/1/2#newcode102
user/src/com/google/gwt/uibinder/rebind/MortalLogger.java:102: +
location.getLineNumbe
Reviewers: scottb,
Message:
Ready for first round of reviews.
http://gwt-code-reviews.appspot.com/473801/diff/1/11
File
dev/core/src/com/google/gwt/dev/shell/rewrite/SingleJsoImplSupport.java
(right):
http://gwt-code-reviews.appspot.com/473801/diff/1/11#newcode29
dev/core/src/com/google/gwt/de
Reviewers: scottb,
Message:
Review requested.
Description:
This patch fixes a missing corner case in JsoRestrictionsChecker. It's
possible to declare a JSO subtype that is abstract, implements
non-trivial interfaces, but fails to declare a method defined by the
interface.
Example:
interface I {
Ready for another look.
By adding an actual @SingleJsoImpl annotation to act as a hint for
devmode, the impact on I18N's CurrencyData is pretty much a one-liner.
http://gwt-code-reviews.appspot.com/473801/diff/5001/6004
File dev/core/src/com/google/gwt/dev/shell/JsValueGlue.java (right):
http:
Ping.
http://gwt-code-reviews.appspot.com/335802/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Thanks for the review.
> http://gwt-code-reviews.appspot.com/335802/diff/1/6#newcode167
> user/test/com/google/gwt/resources/client/ImageResourceTest.java:167:
> assertEquals(128, r.scaledUp().getHeight());
> I assume the point of testing both width and height here (even though
> only width is set
Reviewers: jgw,
Message:
Review requested.
Description:
This changes the generated ClientBundle code to initialize
ResourcePrototypes in the ClientBundle's static initializer.
Previously, resource instances were instantiated lazily in the resource
accessor methods. This led to inefficient JavaS
LGTM.
Do you need to make any changes to GenerateJavaScriptAst to
prevent/change code-gen for external types?
http://gwt-code-reviews.appspot.com/589801/diff/1/6
File dev/core/src/com/google/gwt/dev/jjs/ast/JTypeOracle.java (right):
http://gwt-code-reviews.appspot.com/589801/diff/1/6#newcode88
Reviewers: Ray Ryan,
Message:
Review requested.
Description:
This patch allows the developer to specify obfuscated class name
prefixes that CssResource will avoid allocating. This allows
CssResource to be used in situations where there are external
stylesheets using relatively short class name
If you use JavaScriptObjects, r8249 changes Dev (Hosted)
Mode in three ways you might care about. Production (Web) mode
behavior is unaffected by this change.
1) Method invocations on null JSO instances will throw a
NullPointerException instead of quasi-succeeding [1]. This should
help catch err
Another iteration of the patch that simplifies the cross-casting of JSO
subtype arrays by upcasting all JSO subtype arrays to
JavaScriptObject[]. This ensures that array object identity will be
preserved, even after an "illegal" cast between incompatible array
types.
Changes to look at:
- Adde
LGTM.
http://gwt-code-reviews.appspot.com/591801/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Just curious, why not simply use the same technique in both cases?
The disambiguator parameter should work find for non-constructor
methods,
right?
Adding the extra parameter means fiddling with the stack to push the
extra null argument. Since non-constructor method invocation occurs
more o
Patch updated.
http://gwt-code-reviews.appspot.com/473801/diff/78001/79002
File dev/core/src/com/google/gwt/dev/shell/CompilingClassLoader.java
(right):
http://gwt-code-reviews.appspot.com/473801/diff/78001/79002#newcode695
dev/core/src/com/google/gwt/dev/shell/CompilingClassLoader.java:695: *
LGTM if you update com/google/gwt/rpc/server/RpcServlet with this same
pattern as well.
http://gwt-code-reviews.appspot.com/653801/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Reviewers: Ray Ryan,
Description:
Add UiFieldMapper to allow dynamic access to UiFields to support
data-driven UIs.
Patch by: bobv
Review by: rjrjr
Please review this at http://gwt-code-reviews.appspot.com/619806/show
Affected files:
M user/src/com/google/gwt/uibinder/UiBinder.gwt.xml
A
LGTM
http://gwt-code-reviews.appspot.com/687801/diff/1/3
File user/test/com/google/gwt/uibinder/test/client/UiBinderTestApp.java
(right):
http://gwt-code-reviews.appspot.com/687801/diff/1/3#newcode53
user/test/com/google/gwt/uibinder/test/client/UiBinderTestApp.java:53:
Extra blank line.
http:
Couple of questions.
http://gwt-code-reviews.appspot.com/698801/diff/8001/9002
File user/src/com/google/gwt/app/place/AbstractRecordEditActivity.java
(right):
http://gwt-code-reviews.appspot.com/698801/diff/8001/9002#newcode73
user/src/com/google/gwt/app/place/AbstractRecordEditActivity.java:73
LGTM
I'm inclined to say that the multiple cancels case results in
arbitrary output,
since that's all we've offered internally for quite a while and no one
has
complained.
Ok.
Seems like following your GWT.create suggestion, and the existence of
the
delegate hook itself are enough prot
LGTM, with nits.
http://gwt-code-reviews.appspot.com/703801/diff/1/2
File user/src/com/google/gwt/uibinder/elementparsers/GridParser.java
(right):
http://gwt-code-reviews.appspot.com/703801/diff/1/2#newcode2
user/src/com/google/gwt/uibinder/elementparsers/GridParser.java:2: *
Copyright 2009 Goo
LGTM, just a nit.
http://gwt-code-reviews.appspot.com/706801/diff/1/2
File dev/core/src/com/google/gwt/dev/jjs/impl/FragmentExtractor.java
(right):
http://gwt-code-reviews.appspot.com/706801/diff/1/2#newcode640
dev/core/src/com/google/gwt/dev/jjs/impl/FragmentExtractor.java:640:
call.setQualifi
LGTM, just one question.
http://gwt-code-reviews.appspot.com/697802/diff/5001/6001
File user/src/com/google/gwt/uibinder/elementparsers/GridParser.java
(right):
http://gwt-code-reviews.appspot.com/697802/diff/5001/6001#newcode90
user/src/com/google/gwt/uibinder/elementparsers/GridParser.java:90
On Fri, Jul 23, 2010 at 1:53 PM, wrote:
> There is a lot of copying going here which is bad. Would this be better
> done by adding just the new classes to the DynaTable sample, and having
> another gwt.xml in the DynaTable sample. The two gwt.xml could then pull
> just the subset of files they re
Are the .orig files coming from "git add -A"? You could add that
pattern to your .git/info/exclude.
Will the Property API be removed?
http://gwt-code-reviews.appspot.com/710801/diff/4001/5001
File
bikeshed/src/com/google/gwt/sample/expenses/gwt/request/ExpensesRequestFactory.java
(left):
http
When I run the "ant compile" target, I get the following error:
[java] [ERROR] Errors in
'generated://6954F181DAE9DC202565F0658E355AAB/com/google/gwt/sample/dynatablerf/shared/DynaTableRequestFactoryImpl.java'
[java][ERROR] Line 7: The type
DynaTableRequestF
Looks good enough for a first pass. I'll follow up with converting the
UI to UiBinder in preparation for wiring up the editor stuff.
http://gwt-code-reviews.appspot.com/710801/diff/18001/19001
File
bikeshed/src/com/google/gwt/sample/expenses/gwt/request/ExpensesRequestFactory.java
(left):
http
http://gwt-code-reviews.appspot.com/714801/diff/3001/4001
File user/src/com/google/gwt/resources/client/ClientBundle.java (right):
http://gwt-code-reviews.appspot.com/714801/diff/3001/4001#newcode2
user/src/com/google/gwt/resources/client/ClientBundle.java:2: *
Copyright 2010 Google Inc.
Copyrig
Reviewers: Ray Ryan,
Description:
Begin to convert DynaTableRF sample to using UiBinder.
Next step will be to add app-wide event bus to disentangle widget
relationships.
Patch by: bobv
Review by: rjrjr
Please review this at http://gwt-code-reviews.appspot.com/698802/show
Affected files:
M
Review requested.
http://gwt-code-reviews.appspot.com/698802/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Reviewers: tms,
Description:
Call GZIPOutputStream.finish() from RpcServlet.processPost() to ensure
the data received by the browser is properly formatted.
Patch by: bobv
Review by: tms
Please review this at http://gwt-code-reviews.appspot.com/722801/show
Affected files:
M user/src/com
LGTM with minor changes.
http://gwt-code-reviews.appspot.com/714801/diff/10001/11001
File user/src/com/google/gwt/resources/client/DataResource.java (right):
http://gwt-code-reviews.appspot.com/714801/diff/10001/11001#newcode41
user/src/com/google/gwt/resources/client/DataResource.java:41: publ
http://gwt-code-reviews.appspot.com/698802/diff/1/5
File
samples/dynatablerf/src/com/google/gwt/sample/dynatablerf/client/DayFilterWidget.ui.xml
(right):
http://gwt-code-reviews.appspot.com/698802/diff/1/5#newcode17
samples/dynatablerf/src/com/google/gwt/sample/dynatablerf/client/DayFilterWidget
LGTM.
http://gwt-code-reviews.appspot.com/721804/diff/1/2
File
samples/dynatablerf/src/com/google/gwt/sample/dynatablerf/domain/Person.java
(right):
http://gwt-code-reviews.appspot.com/721804/diff/1/2#newcode31
samples/dynatablerf/src/com/google/gwt/sample/dynatablerf/domain/Person.java:31:
id
Reviewers: Ray Ryan,
Description:
Finish modernizing the DynaTableRF sample to use an event-based
application model.
Patch by: bobv
Review by: rjrjr
Please review this at http://gwt-code-reviews.appspot.com/733802/show
Affected files:
M
samples/dynatablerf/src/com/google/gwt/sample
http://gwt-code-reviews.appspot.com/733802/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
New patch uploaded.
http://gwt-code-reviews.appspot.com/733802/diff/1/3
File
samples/dynatablerf/src/com/google/gwt/sample/dynatablerf/client/DayCheckBox.java
(right):
http://gwt-code-reviews.appspot.com/733802/diff/1/3#newcode38
samples/dynatablerf/src/com/google/gwt/sample/dynatablerf/client/
LGTM, just a couple of code style nits I saw re-reading the patch.
http://gwt-code-reviews.appspot.com/714801/diff/48001/6003
File user/src/com/google/gwt/resources/client/DataResource.java (right):
http://gwt-code-reviews.appspot.com/714801/diff/48001/6003#newcode35
user/src/com/google/gwt/res
Reviewers: Ray Ryan,
Description:
Deprecate the DeferredCommand API.
Patch by: bobv
Review by: rjrjr
Please review this at http://gwt-code-reviews.appspot.com/718802/show
Affected files:
M user/src/com/google/gwt/user/client/Command.java
D user/src/com/google/gwt/user/client
http://gwt-code-reviews.appspot.com/718802/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
I already have that. Do you want it in the same patch?
--
Bob Vawter
Google Web Toolkit Team
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Added callsite updates to the patch.
http://gwt-code-reviews.appspot.com/718802/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
http://gwt-code-reviews.appspot.com/750801/diff/1/2
File dev/core/src/com/google/gwt/core/ext/linker/SymbolData.java
(right):
http://gwt-code-reviews.appspot.com/750801/diff/1/2#newcode86
dev/core/src/com/google/gwt/core/ext/linker/SymbolData.java:86: Object
getCastableTypeMap();
What's the retu
> that would do exactly what I need, but they have default visibility
> and are indicated "for testing purposes only". Is there any reason why
> these method couldn't be made public?
Because the public API requires the use of class literals, it forces
the .class file for the annotation to be on th
> At first glance, this would appear to anger the SingleJSO gods. However,
> because NodeImpl contains implementations of all Node methods, there is no
> actual ambiguity as to which method implementation to bind to. The "this is
> a bug" wording in the error also raised my eyebrows a bit :)
Is No
LGTM, the comments are mostly questions to make sure that I understand
what the code is intended to do.
http://gwt-code-reviews.appspot.com/755801/diff/5001/6002
File
samples/dynatablerf/src/com/google/gwt/sample/dynatablerf/client/CalendarProvider.java
(right):
http://gwt-code-reviews.appspot.
@Miguel,
FWIW, since we the time bounds of further optimizing this patch are
not yet
clear, I'd be in favor of landing it and then doing a second round of
optimizations.
This patch achieves its stated goal, although there are some code style
issues that need to be addressed.
@Scott,
Do you
LGTM with nits.
http://gwt-code-reviews.appspot.com/750801/diff/10002/45012
File user/src/com/google/gwt/rpc/linker/CastableTypeDataImpl.java
(right):
http://gwt-code-reviews.appspot.com/750801/diff/10002/45012#newcode24
user/src/com/google/gwt/rpc/linker/CastableTypeDataImpl.java:24: *
Add a p
On Fri, Aug 13, 2010 at 6:31 AM, Thomas Broyer wrote:
> AbstractImagePrototype.create(myImageResource).getHTML()
Yes.
There is no getHTML() method on the ImageResource interface because
the choice of how to render the data is ultimately part of the UI
toolkit.
--
Bob Vawter
Google Web Toolkit
Reviewers: Ray Ryan,
Message:
This isn't ready for review quite yet, but it's a first cut of being
able to edit records and have them persist on the server.
Description:
Initial support for round-trip edits in the DynaTableRF sample.
Patch by: bobv
Review by: rjrjr
Please review th
I've been working on a patch that improves test integration when using
CssResource. The gist of the patch is that CssResource will have a
getDebugInfo() method that provides additional metadata about the
CssResource and all class selectors used in the input to a CssResource
will be available on a
On Wed, Aug 4, 2010 at 6:10 AM, Moocar wrote:
> I'm trying to generate a bunch of ClientBundles with the associated
> images in the same directory. I can't figure out how to write the
> image files to the same directory as the java files generated with
> GeneratorContext.tryCreate(...).
UiBinder
sMap(sourceClassName, sourceClassName);
It is a builder and should probably be named something like
DebugInfoModel.
Description:
Add debugging information to CssResource.
Patch by: bobv
Review by: rjrjr
Please review this at http://gwt-code-reviews.appspot.com/770801/show
Affected files:
A user/src/com/
LGTM
http://gwt-code-reviews.appspot.com/773801/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
http://gwt-code-reviews.appspot.com/766803/diff/1/8
File
user/src/com/google/gwt/resources/rebind/context/AbstractResourceContext.java
(right):
http://gwt-code-reviews.appspot.com/766803/diff/1/8#newcode50
user/src/com/google/gwt/resources/rebind/context/AbstractResourceContext.java:50:
new Refe
er to allow access to static fields.
Patch by: bobv
Review by: rjrjr
Suggested by: sonnyf
Please review this at http://gwt-code-reviews.appspot.com/781801/show
Affected files:
M user/src/com/google/gwt/uibinder/rebind/UiBinderParser.java
M user/src/com/google/gwt/uibinder/rebind/
LGTM
http://gwt-code-reviews.appspot.com/769802/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
Change LGTM, but why is this a problem in practice? Isn't the generated
source transient?
http://gwt-code-reviews.appspot.com/776803/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
http://gwt-code-reviews.appspot.com/789801/diff/1/2
File
user/src/com/google/gwt/resources/rebind/context/AbstractClientBundleGenerator.java
(right):
http://gwt-code-reviews.appspot.com/789801/diff/1/2#newcode702
user/src/com/google/gwt/resources/rebind/context/AbstractClientBundleGenerator.java
http://gwt-code-reviews.appspot.com/766802/diff/1/2
File
user/src/com/google/gwt/validation/client/AbstractBeanDescriptor.java
(right):
http://gwt-code-reviews.appspot.com/766802/diff/1/2#newcode27
user/src/com/google/gwt/validation/client/AbstractBeanDescriptor.java:27:
* Abstract BeanDescripto
http://gwt-code-reviews.appspot.com/760802/diff/6001/1029
File
samples/validation/src/com/google/gwt/sample/validation/Validation.gwt.xml
(right):
http://gwt-code-reviews.appspot.com/760802/diff/6001/1029#newcode3
samples/validation/src/com/google/gwt/sample/validation/Validation.gwt.xml:3:
Upd
http://gwt-code-reviews.appspot.com/794801/diff/1/2
File dev/core/src/com/google/gwt/core/ext/typeinfo/JPrimitiveType.java
(left):
http://gwt-code-reviews.appspot.com/794801/diff/1/2#oldcode9
dev/core/src/com/google/gwt/core/ext/typeinfo/JPrimitiveType.java:9: *
Fix whitespace jitter.
http://gw
LGTM
http://gwt-code-reviews.appspot.com/760802/diff/6001/1032
File
samples/validation/src/com/google/gwt/sample/validation/client/Validation.java
(right):
http://gwt-code-reviews.appspot.com/760802/diff/6001/1032#newcode55
samples/validation/src/com/google/gwt/sample/validation/client/Validati
http://gwt-code-reviews.appspot.com/794801/diff/8001/9001
File dev/core/src/com/google/gwt/core/ext/typeinfo/JPrimitiveType.java
(right):
http://gwt-code-reviews.appspot.com/794801/diff/8001/9001#newcode43
dev/core/src/com/google/gwt/core/ext/typeinfo/JPrimitiveType.java:43:
DESC_FLOAT, "0.0");
Ready for another look.
http://gwt-code-reviews.appspot.com/767801/show
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
RPC changes LGTM.
http://gwt-code-reviews.appspot.com/751803/diff/6001/7014
File user/src/com/google/gwt/rpc/server/WebModeClientOracle.java
(right):
http://gwt-code-reviews.appspot.com/751803/diff/6001/7014#newcode64
user/src/com/google/gwt/rpc/server/WebModeClientOracle.java:64: // the
symbol
Reviewers: rjrjr,
Message:
There's now a generator to create the glue code. Once committed, the
editor support should be good enough to start experimenting with.
Description:
Initial add of generator for RequestFactoryEditorDriver.
Patch by: bobv
Review by: rjrjr
Please review this at
The formatting in these files looks really off, looking at the
indentation of the string concatenation code.
Ray says not to hold this up on the DocumentFragment stuff.
LGTM if you fix the formatter.
http://gwt-code-reviews.appspot.com/794801/diff/32001/33001
File dev/core/src/com/google/gwt/c
Updated with feedback. Most of the new code has been moved into the
requestfactory package.
TakesValue really should be outside of the user.client.ui package. Any
objections to moving it into the user.client package?
http://gwt-code-reviews.appspot.com/823801/diff/2001/3002
File
samples/dynat
On Wed, Sep 1, 2010 at 3:56 PM, wrote:
> Push back roo to a released version.
LGTM
--
Bob Vawter
Google Web Toolkit Team
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
On Wed, Sep 1, 2010 at 6:08 PM, tc wrote:
> I am getting lots of errors when attempting to do a mvn compile on the
> expenses app.
I just got through this.
>From trunk, run ./tools/scripts/maven_script.sh
--
Bob Vawter
Google Web Toolkit Team
--
http://groups.google.com/group/Google-Web-Too
package.
Provide mock implementations for public API interfaces.
Patch by: bobv
Review by: rjrjr
Please review this at http://gwt-code-reviews.appspot.com/835801/show
Affected files:
M
samples/dynatablerf/src/com/google/gwt/sample/dynatablerf/client/widgets/AddressEditor.java
M
samples
Reviewers: rjrjr,
Message:
Review requested.
Description:
Clarify EditorDriver behavior with combinations of Editor mix-in
interfaces through brute-force testing.
Patch by: bobv
Review by: rjrjr
Please review this at http://gwt-code-reviews.appspot.com/840801/show
Affected files:
M user
Reviewers: rjrjr,
Message:
First look requested.
Description:
I needed to add the "CompositeEditor" as a core feature to the
code-generator to express the need to dynamically add Editors.
The ListEditor is built on top of that and provides a wrapped getList()
which will dynamically update a col
Code LGTM, just noticed some empty auto-generated Javadoc.
http://gwt-code-reviews.appspot.com/766802/diff/19001/20008
File
user/src/com/google/gwt/validation/client/impl/ConstraintDescriptorImpl.java
(right):
http://gwt-code-reviews.appspot.com/766802/diff/19001/20008#newcode57
user/src/com/go
http://gwt-code-reviews.appspot.com/845801/diff/5001/6008
File user/src/com/google/gwt/validation/rebind/BeanHelper.java (right):
http://gwt-code-reviews.appspot.com/845801/diff/5001/6008#newcode24
user/src/com/google/gwt/validation/rebind/BeanHelper.java:24: private
final Class clazz;
Could you
Reviewers: rjrjr,
Message:
Review requested.
Description:
Add ListEditor adapter implemented on top of a new CompositeEditor core
behavior.
Remove type-specific adapters in favor of interface-specific adapters.
Improve handling of generic editor interfaces.
Patch by: bobv
Review by: rjrjr
How about http://gwt-code-reviews.appspot.com/1374804 instead to allow
developer control over the classloader instead?
--
Bob Vawter
Google Web Toolkit Team
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
LGTM, committing with minor cleanups.
http://gwt-code-reviews.appspot.com/1364801/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
LGTM. Committing with extra comments in PathCollector.
http://gwt-code-reviews.appspot.com/1363801/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
EditorTest refers to a SimpleFooBarOnlyEditor. Which patch defines that
type?
http://gwt-code-reviews.appspot.com/1371801/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
401 - 500 of 832 matches
Mail list logo
