I have made fix[1] for unused category (only java code). If nobody
has objections I could fix other caterogies.
[1] http://issues.apache.org/jira/browse/HARMONY-1926
2006/10/20, Nathan Beyer [EMAIL PROTECTED]:
I've been trying to work through many of the warnings, module by
module. Most of
Denis Kishenko wrote:
I have made fix[1] for unused category (only java code). If nobody
has objections I could fix other caterogies.
[1] http://issues.apache.org/jira/browse/HARMONY-1926
See Nathan's comments about unused vars -- they cannot be fixed safely
with the Java wizard. Unused
On 10/20/06, Tim Ellison [EMAIL PROTECTED] wrote:
Denis Kishenko wrote:
I have made fix[1] for unused category (only java code). If nobody
has objections I could fix other caterogies.
[1] http://issues.apache.org/jira/browse/HARMONY-1926
See Nathan's comments about unused vars -- they
Almost all unused variables are local. Only two of them are class
fields and they are not using in native code. Build and all tests are
successful.
2006/10/20, Tim Ellison [EMAIL PROTECTED]:
Denis Kishenko wrote:
I have made fix[1] for unused category (only java code). If nobody
has
Denis Kishenko wrote:
Almost all unused variables are local. Only two of them are class
fields and they are not using in native code. Build and all tests are
successful.
Thanks Denis!
Regards,
Tim
--
Tim Ellison ([EMAIL PROTECTED])
IBM Java technology centre, UK.
Added patch for SUID wanings to the same issue.H-1926
2006/10/20, Tim Ellison [EMAIL PROTECTED]:
Denis Kishenko wrote:
Almost all unused variables are local. Only two of them are class
fields and they are not using in native code. Build and all tests are
successful.
Thanks Denis!
Regards,
Nathan Beyer wrote:
I added a compiler arg to the main 'build-java.xml' compile to disable
all of the warnings.
Thanks a lot, Nathan, but how about also add that arg to build-test.xml?
I think the ECJ probably feels more unhappy with the test cases:).
This should take care of the warnings.
I looked at adding the nowarn arg for the tests, but 'build-test.xml'
doesn't have a single large compile statement like 'buid-java.xml'
does. The arg would need to be added to the compile-test of every
module's build, which can be done, I was just feeling lazy at the
moment, sorry. :( Also, I
I also worried about a lot of warnings and I think warnings like these
can be fixed
last\modules\concurrent\standard\src\main\java\java\util\concurrent\ConcurrentHashMap.java
[javac] (at line 26)
[javac] import java.io.ObjectInputStream;
[javac]
+1
I never know if it's something important or not.
On 10/19/06, Denis Kishenko [EMAIL PROTECTED] wrote:
I also worried about a lot of warnings and I think warnings like these
can be fixed
last\modules\concurrent\standard\src\main\java\java\util\concurrent\ConcurrentHashMap.java
[javac]
Nathan has turned off all warnings. I suggest that we start to turn
them back on incrementally and fix the warnings we see.
Regards,
Tim
Denis Kishenko wrote:
I also worried about a lot of warnings and I think warnings like these
can be fixed
I've been trying to work through many of the warnings, module by
module. Most of the warnings fall into the following categories.
* serial - Serializable classes that don't have explicit serialVersionUID fields
* unchecked - missing type variables, mostly collection references
* unused - unused
coolio - thx
Nathan Beyer wrote:
I added a compiler arg to the main 'build-java.xml' compile to disable
all of the warnings.
This should take care of the warnings.
-Nathan
On 10/18/06, Geir Magnusson Jr. [EMAIL PROTECTED] wrote:
Can we just shut them off for now? it's a good project for
You have patience I can only dream about...
geir
Nathan Beyer wrote:
I've been trying to work through many of the warnings, module by
module. Most of the warnings fall into the following categories.
* serial - Serializable classes that don't have explicit
serialVersionUID fields
* unchecked
Can we just shut them off for now? it's a good project for someone to
go and clean those up, but there's no need for all of us to see them.
geir
Mark Hindess wrote:
These messages aren't getting through on the commits list on due to the
large number of warnings since switching to ecj. I've
I added a compiler arg to the main 'build-java.xml' compile to disable
all of the warnings.
This should take care of the warnings.
-Nathan
On 10/18/06, Geir Magnusson Jr. [EMAIL PROTECTED] wrote:
Can we just shut them off for now? it's a good project for someone to
go and clean those up, but
Yes, this happens because HARMONY-1729 was not integrated yet.
HARMONY-1729 consists of build files diff and connetced to HARMONY-1609.
SY, Alexey
2006/10/9, Salikh Zakirov [EMAIL PROTECTED]:
Hi,
I cannot build classlib on the latest revision ([r454318] moving HARMONY-1609
(Applet, ImageIO
I couldn't reproduce that - worked fine before I committed
Now trying on a fresh ws
2006/10/9, Alexey Petrenko [EMAIL PROTECTED]:
Yes, this happens because HARMONY-1729 was not integrated yet.
HARMONY-1729 consists of build files diff and connetced to HARMONY-1609.
SY, Alexey
2006/10/9,
yup, Ive just updated and rebuilt, and it works fine for me too.
Mikhail Loenko wrote:
Works fine on a fresh ws.
could you please update up to 454342:
missed one file (was: moving HARMONY-1609 (Applet, ImageIO and Print
modules) files to correct locations)
and try ant rebuild
Thanks,
Mikhail Loenko wrote:
Works fine on a fresh ws.
could you please update up to 454342:
missed one file (was: moving HARMONY-1609 (Applet, ImageIO and Print
modules) files to correct locations)
and try ant rebuild
Verified.
Classlib builds and works okay on revision
r454349 cyrillic
On 20 September 2006 at 10:03, Leo Li [EMAIL PROTECTED] wrote:
Hi, all:
Since I am not an expert of gcc, I think we need a guru to set the flags in
makefile of linux:
1. It will report any required warnings and regard it as error to lead a
failure build so that it is forced for us to
On 20 September 2006 at 10:06, Mark Hindess [EMAIL PROTECTED] wrote:
On 20 September 2006 at 10:03, Leo Li [EMAIL PROTECTED] wrote:
Hi, all:
Since I am not an expert of gcc, I think we need a guru to set the flags in
makefile of linux:
1. It will report any required warnings and
Dear Mark:
You are right. Thank you. It really works.
I will try to set -Werror option to see if all reported warning. can
be fixed.
On 9/20/06, Mark Hindess [EMAIL PROTECTED] wrote:
On 20 September 2006 at 10:06, Mark Hindess [EMAIL PROTECTED]
wrote:
On 20 September 2006 at
Lets get these aligned... I tend to work on linux, so it had no
problem building..
geir
On Sep 18, 2006, at 10:14 PM, Leo Li wrote:
Just comment it out since it is just a warning treated as error.
It compiles successfully and runs well.
Maybe it will not lead to such an error on Linux due
The warning level is set to level 3 on windows, I mean.
On 9/19/06, Leo Li [EMAIL PROTECTED] wrote:
Hi, Geir:
The warning level is set to level 3 while the warning as error option is
off in linux.
Actually, I would like to set it on in linux since it will help me to
pick some error out,
There is no way to get rid of the warnings in our codebase on linux?
geir
On Sep 19, 2006, at 4:03 AM, Leo Li wrote:
Hi, Geir:
The warning level is set to level 3 while the warning as error
option is
off in linux.
Actually, I would like to set it on in linux since it will help me
to
Incidentally, I had to override the default windows flags to turn off
the warnings-as-error for the awt native code in order to integrate it.
I mentioned this on the -dev list at the time hoping to see some patches
to fix the issues but there haven't been any as yet.
I agree it would be a good
Ok, good - there's a totally reasonable explanation :)
geir
On Sep 19, 2006, at 7:05 AM, Mark Hindess wrote:
Incidentally, I had to override the default windows flags to turn off
the warnings-as-error for the awt native code in order to integrate
it.
I mentioned this on the -dev list at
Well, I was just pointing out a further inconsistency (awt/windows). I
don't recall when/why linux errors were downgraded so that might have
happened before I started hacking the natives around.
Regards,
Mark.
On 19 September 2006 at 7:10, Geir Magnusson Jr. [EMAIL PROTECTED] wrote:
Ok, good
Really - I think the explanation was totally reasonable. I didn't
understand before why it was asymmetric.
On Sep 19, 2006, at 8:40 AM, Mark Hindess wrote:
Well, I was just pointing out a further inconsistency (awt/
windows). I
don't recall when/why linux errors were downgraded so that
Hi, all:
Since I am not an expert of gcc, I think we need a guru to set the flags in
makefile of linux:
1. It will report any required warnings and regard it as error to lead a
failure build so that it is forced for us to correct it.
2. It can avoid to stop building due to such warnings:
In
I just checked in a fix for this. The jarRunner variable needed to be
commented out, as the code that used it was commented out.
Try it now and see if it compiles.
-Nathan
-Original Message-
From: Spark Shen [mailto:[EMAIL PROTECTED]
Sent: Monday, September 18, 2006 8:49 PM
To:
Just comment it out since it is just a warning treated as error.
It compiles successfully and runs well.
Maybe it will not lead to such an error on Linux due to the configuration of
make rules.:)
Good luck!
On 9/19/06, Spark Shen [EMAIL PROTECTED] wrote:
Hi All:
When building today's(Sep 19,
Nathan Beyer 写道:
I just checked in a fix for this. The jarRunner variable needed to be
commented out, as the code that used it was commented out.
Try it now and see if it compiles.
Seems caused by restored the capability to do
java -jar foo.jar :-)
And now, it builds. Thanks a lot.
Best
If it isn't really quick, roll it back and let Nathan fix it...
geir
Tim Ellison wrote:
I see it too.
Stepan / Mikhail, do you get build failures? Shouldn't we stop putting
in new code until this is resolved?
I am happy to take a look at the error, and if it is not a quick fix I
think
Yep, that was the plan, but it was a trivial fix (in repo = r412990).
Just wondering how Mikhail/Stepan got it to build? It may be a
consequence of different compiler versions again since I did not see a
compiler error on the Eclipse compiler either.
Regards,
Tim
Geir Magnusson Jr wrote:
If
Hi Tim,
On 6/9/06, Tim Ellison [EMAIL PROTECTED] wrote:
I see it too.
Stepan / Mikhail, do you get build failures? Shouldn't we stop putting
in new code until this is resolved?
I didn't update this particular file because I work separately with
security module only.
But I think that you
Stepan Mishura wrote:
Hi Tim,
On 6/9/06, Tim Ellison [EMAIL PROTECTED] wrote:
I see it too.
Stepan / Mikhail, do you get build failures? Shouldn't we stop putting
in new code until this is resolved?
I didn't update this particular file because I work separately with
security module
On 9 June 2006 at 16:55, Stepan Mishura [EMAIL PROTECTED] wrote:
Hi Tim,
On 6/9/06, Tim Ellison [EMAIL PROTECTED] wrote:
I see it too.
Stepan / Mikhail, do you get build failures? Shouldn't we stop putting
in new code until this is resolved?
I didn't update this particular
I checked the allow list, and
[EMAIL PROTECTED]
is still there.
I'm assuming that this isn't a real account. Any chance you could
switch to one to test, so you can see the bounceback if there is one?
geir
Tim Ellison wrote:
Stepan Mishura wrote:
Hi Tim,
On 6/9/06, Tim Ellison [EMAIL
A large message should still generate a bounce...
I'll go look to see what the size is.
How large are these messages?
Mark Hindess wrote:
On 9 June 2006 at 16:55, Stepan Mishura [EMAIL PROTECTED] wrote:
Hi Tim,
On 6/9/06, Tim Ellison [EMAIL PROTECTED] wrote:
I see it too.
Stepan /
The most recent success message was 343k at approximately
Fri, 09 Jun 06 11:26:34 +0100.
-Mark.
On 9 June 2006 at 6:33, Geir Magnusson Jr [EMAIL PROTECTED] wrote:
A large message should still generate a bounce...
I'll go look to see what the size is.
How large are these messages?
any clue about how big a failed message is (if you can figure that out...)?
geir
Mark Hindess wrote:
The most recent success message was 343k at approximately
Fri, 09 Jun 06 11:26:34 +0100.
-Mark.
On 9 June 2006 at 6:33, Geir Magnusson Jr [EMAIL PROTECTED] wrote:
A large message should
Just about to go offline, but I'd guess smaller since not as much works!
;-)
-Mark.
On 9 June 2006 at 7:01, Geir Magnusson Jr [EMAIL PROTECTED] wrote:
any clue about how big a failed message is (if you can figure that out...)?
geir
Mark Hindess wrote:
The most recent success message
do you mean larger? I was wondering what the size is so I can see if
it's the threshold set on the list, or something else...
geir
Mark Hindess wrote:
Just about to go offline, but I'd guess smaller since not as much works!
;-)
-Mark.
On 9 June 2006 at 7:01, Geir Magnusson Jr [EMAIL
Geir Magnusson Jr wrote:
do you mean larger?
It may be larger if the last test fails with a walkback ;-) but
generally the build fails part way through, with a message, and the rest
of the log is not written, so it is smaller overall.
Regards,
Tim
I was wondering what the size is so I can see
46 matches
Mail list logo
