[PHP-DEV] Re: Zend JIT Open Sourced

2015-02-27 Thread Xinchen Hui
Hey: On Fri, Feb 27, 2015 at 8:10 PM, Dmitry Stogov dmi...@zend.com wrote: Hi, With the recent discussions of JIT/AOT and the good progress we made on PHP-7, we decided to open up the JIT experiment we've been working on. https://github.com/zendtech/php-src/tree/zend-jit/ext/opcache/jit

Re: [PHP-DEV] [RFC][DISCUSSION] Remove allow_url_include INI

2015-02-27 Thread Yasuo Ohgaki
Hi all, On Sat, Feb 28, 2015 at 11:37 AM, Yasuo Ohgaki yohg...@ohgaki.net wrote: On Fri, Feb 27, 2015 at 8:25 PM, Rowan Collins rowan.coll...@gmail.com wrote: Yasuo Ohgaki wrote on 27/02/2015 03:44: Hi all, This is RFC for removing allow_url_include INI option. [1] During Script only

Re: [PHP-DEV] [RFC] UString

2015-02-27 Thread Joe Watkins
Morning internals, This is just a quick note to announce my intention to ready this RFC for voting next week. I know I'm a little late maybe, I was real sick most of last week, so couldn't do anything useful. A couple of us intend to fix outstanding issues on github and those raised

Re: [PHP-DEV] [VOTE] Expectations

2015-02-27 Thread Joe Watkins
Morning Internals, As mentioned on the RFC, voting finished last night at midnight. The vote passed with a majority (50%+) in favour of custom exceptions, however ... When the patch was originally written assert (expect) was a language construct, and so the exception message wasn't

Re: [PHP-DEV] [VOTE] Exceptions in the engine

2015-02-27 Thread Sebastian Bergmann
Am 28.02.2015 um 01:57 schrieb Larry Garfield: The RFC is currently in voting, so editing it directly is a no-no. A new, short RFC, please. (Exception implements Throwable, Error implements Throwable sounds good to me. Should we ask about SomeUserspaceClass implements Throwable, or will

Re: [PHP-DEV] [RFC][DISCUSSION] Remove allow_url_include INI

2015-02-27 Thread Yasuo Ohgaki
Hi Rowan, On Fri, Feb 27, 2015 at 8:25 PM, Rowan Collins rowan.coll...@gmail.com wrote: Yasuo Ohgaki wrote on 27/02/2015 03:44: Hi all, This is RFC for removing allow_url_include INI option. [1] During Script only include RFC[2] discussion, stream wrapper issue is raised. I was thinking

Re: [PHP-DEV] [RFC][DISCUSSION] Remove allow_url_include INI

2015-02-27 Thread Stanislav Malyshev
Hi! I have no intention to change current include/require syntax, except adding 2nd parameter. This is a bit misleading since include is not a function, so there's no 1st parameter. Instead, it's a syntax construct. Of course, syntax construct's grammar can be changed, though I'm not sure if

Re: [PHP-DEV] Feature request and RFC

2015-02-27 Thread Rowan Collins
Thomas Gielfeldt wrote on 24/02/2015 16:17: Hi internals. I've made PR proposing a feature request: A new interface Sortable. https://github.com/php/php-src/pull/1116 If possible, I would like to create and RFC describing this in more detail, and perhaps get a voting on. I think the reason

RE: [PHP-DEV] A different user perspective on scalar type declarations

2015-02-27 Thread François Laupretre
Hi, If we allow for trailing blanks, we'll allow the same set of chars that is already allowed for leading blanks. I say'blanks' and not 'whitespaces', because here is the list currently allowed as leading blank (with ascii values) : Space (32) , tab (9) , linefeed (10), carriage-return (13),

Re: [PHP-DEV] A different user perspective on scalar type declarations

2015-02-27 Thread Lester Caine
On 27/02/15 13:12, François Laupretre wrote: If we allow for trailing blanks, we'll allow the same set of chars that is already allowed for leading blanks. I say'blanks' and not 'whitespaces', because here is the list currently allowed as leading blank (with ascii values) : Space (32) , tab

Re: [PHP-DEV] Coercive STH - some real world tests and updated RFC

2015-02-27 Thread Damien Tournoud
Hi Christian, On Fri, Feb 27, 2015 at 5:15 PM, Christian Stoller stol...@leonex.de wrote: In this case FALSE is an expected result and it is intended. And as I said other languages are going the same way. Other languages are also doing something saner. It's not really an argument either way.

Re: [PHP-DEV] Coercive STH - some real world tests and updated RFC

2015-02-27 Thread Brian Moon
This RFC trying to simpliy and cleanup the coercison rules, having two different conversion rules for NULL-scalar depending on userland or internal is counter-productive and bad. The behavior you describe as null being empty value is wide-spread in PHP userland code as well. I agree here with

Re: [PHP-DEV] Re: Zend JIT Open Sourced

2015-02-27 Thread Dmitry Stogov
On Fri, Feb 27, 2015 at 7:30 PM, Anthony Ferrara ircmax...@gmail.com wrote: Dmitry, It's not a single request cycle. JIT integrated into opcache, it compiles php script(s) of first access and stores code in shared memory. On following requests precompiled code is executed directly from

Re: [PHP-DEV] Coercive STH - some real world tests and updated RFC

2015-02-27 Thread Lester Caine
On 27/02/15 14:15, Benjamin Eberlei wrote: Imho the problem is that the return values of php internal functions being string|false will lead to massive consecutive errors when passing this on to other internal functions. This is perhaps the crux of my objection to both types of 'error

RE: [PHP-DEV] Re: Zend JIT Open Sourced

2015-02-27 Thread Zeev Suraski
-Original Message- From: Dmitry Stogov [mailto:dmi...@zend.com] Sent: Friday, February 27, 2015 7:31 PM To: Anthony Ferrara Cc: Jordi Boggiano; PHP Internals Subject: Re: [PHP-DEV] Re: Zend JIT Open Sourced On Fri, Feb 27, 2015 at 7:30 PM, Anthony Ferrara ircmax...@gmail.com

Re: [PHP-DEV] Coercive STH - some real world tests and updated RFC

2015-02-27 Thread Lester Caine
On 27/02/15 16:46, Damien Tournoud wrote: You probably haven't read the examples that I pasted. If you think that it makes sense to return an error code if the function is called with invalid arguments, it should be done consistently. The current behavior is just an absurdly inconsistent, it

Re: [PHP-DEV][RFC][VOTE] Enable error_handler callback parameters to be passed by reference

2015-02-27 Thread Pascal MARTIN, AFUP
Le 13/02/2015 21:51, Thomas Bley a écrit : we'd like to initiate a vote on Allow error_handler callback parameters to be passed by reference: https://wiki.php.net/rfc/error_handler_callback_parameters_passed_by_reference Hi, We've discussed this RFC with a few other people at AFUP, and we

Re: [PHP-DEV] Re: Zend JIT Open Sourced

2015-02-27 Thread Anthony Ferrara
Dmitry, It's not a single request cycle. JIT integrated into opcache, it compiles php script(s) of first access and stores code in shared memory. On following requests precompiled code is executed directly from shared memory. - The first request may be extremely slow (few minutes) That

Re: [PHP-DEV] Re: [RFC][VOTE] pecl_http

2015-02-27 Thread Pascal MARTIN, AFUP
Le 26/02/2015 12:28, Michael Wallner a écrit : I forgot to formally declare a voting period, so I’ll do so now. Voting will end on Feb, 27th at 21:00 UTC, so if you didn’t vote yet, please do so until then. https://wiki.php.net/rfc/pecl_http#vote Hi, Not many of us at AFUP participated in

Re: [PHP-DEV] Coercive STH - some real world tests and updated RFC

2015-02-27 Thread Lester Caine
On 27/02/15 13:45, Benjamin Eberlei wrote: Drupal admin interface (across the all pages): One new E_DEPRECATED warning, which again seems to catch a real bug - stripslsahes() operating on a boolean. All those are due to a bug in substr(), that we see now only thanks to proper

Re: [PHP-DEV] Coercive STH - some real world tests and updated RFC

2015-02-27 Thread Benjamin Eberlei
On Fri, Feb 27, 2015 at 2:57 PM, Lester Caine les...@lsces.co.uk wrote: On 27/02/15 13:45, Benjamin Eberlei wrote: Drupal admin interface (across the all pages): One new E_DEPRECATED warning, which again seems to catch a real bug - stripslsahes() operating on a boolean.

RE: [PHP-DEV] Coercive STH - some real world tests and updated RFC

2015-02-27 Thread Christian Stoller
From: Damien Tournoud [mailto:d...@damz.org], Sent: Friday, February 27, 2015 2:38 PM Hi Zeev, On Fri, Feb 27, 2015 at 12:57 AM, Zeev Suraski z...@zend.com wrote: Drupal homepage: One new E_DEPRECATED warning, which seems to catch a real bug, or at least faulty looking code: $path =

Re: [PHP-DEV] Coercive STH - some real world tests and updated RFC

2015-02-27 Thread Benjamin Eberlei
On Fri, Feb 27, 2015 at 2:37 PM, Damien Tournoud d...@damz.org wrote: Hi Zeev, On Fri, Feb 27, 2015 at 12:57 AM, Zeev Suraski z...@zend.com wrote: Drupal homepage: One new E_DEPRECATED warning, which seems to catch a real bug, or at least faulty looking code: $path = trim($path,

Re: [PHP-DEV] [VOTE] Exceptions in the engine

2015-02-27 Thread Sebastian Bergmann
Am 23.02.2015 um 19:15 schrieb Nikita Popov: Voting on the engine exceptions RFC, which proposes to convert existing fatal and recoverable fatal errors into exceptions, has opened: https://wiki.php.net/rfc/engine_exceptions_for_php7#vote The primary vote requires a 2/3 majority, as

Re: [PHP-DEV] [VOTE] Exceptions in the engine

2015-02-27 Thread Jordi Boggiano
On 27/02/2015 14:31, Sebastian Bergmann wrote: Am 23.02.2015 um 19:15 schrieb Nikita Popov: Voting on the engine exceptions RFC, which proposes to convert existing fatal and recoverable fatal errors into exceptions, has opened: https://wiki.php.net/rfc/engine_exceptions_for_php7#vote The

RE: [PHP-DEV] Coercive STH - some real world tests and updated RFC

2015-02-27 Thread Zeev Suraski
-Original Message- From: Benjamin Eberlei [mailto:kont...@beberlei.de] Sent: Friday, February 27, 2015 1:19 PM To: Dmitry Stogov Cc: Zeev Suraski; PHP internals Subject: Re: [PHP-DEV] Coercive STH - some real world tests and updated RFC On Fri, Feb 27, 2015 at 9:44 AM, Dmitry

[PHP-DEV] Re: Zend JIT Open Sourced

2015-02-27 Thread Joe Watkins
Dmitry, Thanks for the opportunity to read, that's cool ;) Cheers Joe On Fri, Feb 27, 2015 at 12:10 PM, Dmitry Stogov dmi...@zend.com wrote: Hi, With the recent discussions of JIT/AOT and the good progress we made on PHP-7, we decided to open up the JIT experiment we've been working

Re: [PHP-DEV] Coercive STH - some real world tests and updated RFC

2015-02-27 Thread Damien Tournoud
Hi Zeev, On Fri, Feb 27, 2015 at 12:57 AM, Zeev Suraski z...@zend.com wrote: Drupal homepage: One new E_DEPRECATED warning, which seems to catch a real bug, or at least faulty looking code: $path = trim($path, '/'); // raises E_DEPRECATED, as $path is boolean false. return $path;

Re: [PHP-DEV] Follow-up to STH user experience, this time with actual testing

2015-02-27 Thread Jordi Boggiano
Matthew, Thanks a bunch for going through this and writing such a detailed report. On 27/02/2015 00:29, Matthew Weier O'Phinney wrote: ### STHv5 [snip] Analysis I did not expect the float value to be coerced, particularly as it had a fractional part. Yes, I understand that this is how

Re: [PHP-DEV] Coercive STH - some real world tests and updated RFC

2015-02-27 Thread Benjamin Eberlei
On Fri, Feb 27, 2015 at 2:37 PM, Damien Tournoud d...@damz.org wrote: Hi Zeev, On Fri, Feb 27, 2015 at 12:57 AM, Zeev Suraski z...@zend.com wrote: Drupal homepage: One new E_DEPRECATED warning, which seems to catch a real bug, or at least faulty looking code: $path = trim($path,

Re: [PHP-DEV] Re: Zend JIT Open Sourced

2015-02-27 Thread Anthony Ferrara
Zeev, Right now it compiles script (php file) at once. So yes, our JIT uses some kind of AOT approach, but completely transparently for the rest of PHP. Just to slightly further clarify - we don't compile the whole codebase at once, but we keep the existing semantics that every file is

Re: [PHP-DEV] Zend JIT Open Sourced

2015-02-27 Thread Pierre Joye
hi, On Fri, Feb 27, 2015 at 4:10 AM, Dmitry Stogov dmi...@zend.com wrote: Hi, With the recent discussions of JIT/AOT and the good progress we made on PHP-7, we decided to open up the JIT experiment we've been working on. https://github.com/zendtech/php-src/tree/zend-jit/ext/opcache/jit

[PHP-DEV] Re: About optimization for compiler

2015-02-27 Thread Xinchen Hui
On Fri, Feb 27, 2015 at 11:08 PM, Bob Weinand bobw...@hotmail.com wrote: Am 27.02.2015 um 07:53 schrieb Xinchen Hui larue...@gmail.com: Hey: On Fri, Feb 27, 2015 at 2:22 PM, Xinchen Hui larue...@gmail.com wrote: Hey Internals: I was looking Bob's switch optimization.. And, I am not

Re: [PHP-DEV] Re: Zend JIT Open Sourced

2015-02-27 Thread Andi Gutmans
On Feb 27, 2015, at 7:12 AM, Anthony Ferrara ircmax...@gmail.com wrote: Dmitry and Zend, Thank you for sharing your code. I look forward to playing with it. Perhaps after 7 stabilizes (and ships) you could write up your thoughts around it? Why decisions were made and the findings that

Re: [PHP-DEV] Re: About optimization for compiler

2015-02-27 Thread Bob Weinand
Am 27.02.2015 um 16:12 schrieb Xinchen Hui larue...@gmail.com: On Fri, Feb 27, 2015 at 11:08 PM, Bob Weinand bobw...@hotmail.com wrote: Am 27.02.2015 um 07:53 schrieb Xinchen Hui larue...@gmail.com: Hey: On Fri, Feb 27, 2015 at 2:22 PM, Xinchen Hui larue...@gmail.com wrote: Hey

Re: [PHP-DEV] [VOTE] Exceptions in the engine

2015-02-27 Thread guilhermebla...@gmail.com
+1 on Sebastian's suggestion. =) I volunteer to either update the RFC or create a new one to resolve this once Exceptions in the engine passes (which looks like a reality already to me). Just tell me which approach I should take and I'll happily write the RFC. []s, On Fri, Feb 27, 2015 at 9:47

Re: [PHP-DEV] Re: Zend JIT Open Sourced

2015-02-27 Thread Dmitry Stogov
On Fri, Feb 27, 2015 at 6:40 PM, Jordi Boggiano j.boggi...@seld.be wrote: On 27/02/2015 15:19, Andi Gutmans wrote: On Feb 27, 2015, at 7:12 AM, Anthony Ferrara ircmax...@gmail.com wrote: Dmitry and Zend, Thank you for sharing your code. I look forward to playing with it. Perhaps after

RE: [PHP-DEV] Coercive STH - some real world tests and updated RFC

2015-02-27 Thread Christian Stoller
From: Damien Tournoud [mailto:d...@damz.org], Sent: Friday, February 27, 2015 4:54 PM Hi Christian, On Fri, Feb 27, 2015 at 3:38 PM, Christian Stoller stol...@leonex.de wrote: It is not a bug. FALSE as a return value of substr() is the identificator for an error (e.g. invalid arguments), as

[PHP-DEV] Re: About optimization for compiler

2015-02-27 Thread Bob Weinand
Am 27.02.2015 um 07:53 schrieb Xinchen Hui larue...@gmail.com: Hey: On Fri, Feb 27, 2015 at 2:22 PM, Xinchen Hui larue...@gmail.com mailto:larue...@gmail.com wrote: Hey Internals: I was looking Bob's switch optimization.. And, I am not against this switch optimization.. I

Re: [PHP-DEV] Follow-up to STH user experience, this time with actual testing

2015-02-27 Thread Sebastian Bergmann
Am 27.02.2015 um 01:29 schrieb Matthew Weier O'Phinney: - PHPUnit passes a boolean false to `debug_backtrace()`... which is documented as expecting an integer! (There are actually several constant values it accepts, all of which are integer values.) In this case, PHPUnit is relying on

Re: [PHP-DEV] Re: Zend JIT Open Sourced

2015-02-27 Thread Rowan Collins
Dmitry Stogov wrote on 27/02/2015 15:56: On Fri, Feb 27, 2015 at 6:40 PM, Jordi Boggianoj.boggi...@seld.be wrote: On 27/02/2015 15:19, Andi Gutmans wrote: On Feb 27, 2015, at 7:12 AM, Anthony Ferraraircmax...@gmail.com wrote: Dmitry and Zend, Thank you for sharing your code. I look

Re: [PHP-DEV] Re: Zend JIT Open Sourced

2015-02-27 Thread Sebastian Bergmann
Am 27.02.2015 um 16:12 schrieb Anthony Ferrara: Thank you for sharing your code. I look forward to playing with it. Perhaps after 7 stabilizes (and ships) you could write up your thoughts around it? Why decisions were made and the findings that you have? What Joe and Anthony said :-)

Re: [PHP-DEV] Re: About optimization for compiler

2015-02-27 Thread Dmitry Stogov
On Fri, Feb 27, 2015 at 6:22 PM, Bob Weinand bobw...@hotmail.com wrote: Am 27.02.2015 um 16:12 schrieb Xinchen Hui larue...@gmail.com: On Fri, Feb 27, 2015 at 11:08 PM, Bob Weinand bobw...@hotmail.com wrote: Am 27.02.2015 um 07:53 schrieb Xinchen Hui larue...@gmail.com: Hey: On

Re: [PHP-DEV] Coercive STH - some real world tests and updated RFC

2015-02-27 Thread Anthony Ferrara
Cristian, All those are due to a bug in substr(), that we see now only thanks to proper type identification. There is no reason for substr() to ever return a boolean. It really needs to be fix to always return a string. Damien It is not a bug. FALSE as a return value of substr() is the

Re: [PHP-DEV] Follow-up to STH user experience, this time with actual testing

2015-02-27 Thread Benjamin Eberlei
On Fri, Feb 27, 2015 at 4:25 PM, Sebastian Bergmann sebast...@php.net wrote: Am 27.02.2015 um 01:29 schrieb Matthew Weier O'Phinney: - PHPUnit passes a boolean false to `debug_backtrace()`... which is documented as expecting an integer! (There are actually several constant values it

Re: [PHP-DEV] Re: Zend JIT Open Sourced

2015-02-27 Thread Jordi Boggiano
On 27/02/2015 15:19, Andi Gutmans wrote: On Feb 27, 2015, at 7:12 AM, Anthony Ferrara ircmax...@gmail.com wrote: Dmitry and Zend, Thank you for sharing your code. I look forward to playing with it. Perhaps after 7 stabilizes (and ships) you could write up your thoughts around it? Why

Re: [PHP-DEV] Coercive STH - some real world tests and updated RFC

2015-02-27 Thread Damien Tournoud
Hi Christian, On Fri, Feb 27, 2015 at 3:38 PM, Christian Stoller stol...@leonex.de wrote: It is not a bug. FALSE as a return value of substr() is the identificator for an error (e.g. invalid arguments), as it is stated in the documentation: [...] It is documented that way and it is not a

[PHP-DEV] Re: Zend JIT Open Sourced

2015-02-27 Thread Anthony Ferrara
Dmitry and Zend, Thank you for sharing your code. I look forward to playing with it. Perhaps after 7 stabilizes (and ships) you could write up your thoughts around it? Why decisions were made and the findings that you have? Thanks again Anthony On Fri, Feb 27, 2015 at 7:10 AM, Dmitry Stogov

[PHP-DEV] Re: About optimization for compiler

2015-02-27 Thread Dmitry Stogov
On Fri, Feb 27, 2015 at 6:08 PM, Bob Weinand bobw...@hotmail.com wrote: Am 27.02.2015 um 07:53 schrieb Xinchen Hui larue...@gmail.com: Hey: On Fri, Feb 27, 2015 at 2:22 PM, Xinchen Hui larue...@gmail.com wrote: Hey Internals: I was looking Bob's switch optimization.. And, I am not

RE: [PHP-DEV] Re: Zend JIT Open Sourced

2015-02-27 Thread Zeev Suraski
-Original Message- From: Anthony Ferrara [mailto:ircmax...@gmail.com] Sent: Friday, February 27, 2015 9:36 PM To: Dmitry Stogov Cc: Zeev Suraski; Jordi Boggiano; PHP Internals Subject: Re: [PHP-DEV] Re: Zend JIT Open Sourced And looking at the code, I can see why. The PHP version

Re: [PHP-DEV] Re: Zend JIT Open Sourced

2015-02-27 Thread Dmitry Stogov
On Fri, Feb 27, 2015 at 10:36 PM, Anthony Ferrara ircmax...@gmail.com wrote: Dmitry, That's not to say there's anything wrong with this approach, nor that there isn't a ton we can learn from it. I think it's a fantastic research effort and plan on digging through it myself. Thank you for

Re: [PHP-DEV] Re: Zend JIT Open Sourced

2015-02-27 Thread Anthony Ferrara
Dmitry, Sneaky sneaky. Also completely fake. It's been brought to my attention that some people have taken what I said completely out of context and insinuated it as a direct insult to you. I assure you that was not the intent (I called the benchmark sneaky and fake, which it is). So if you

Re: [PHP-DEV] Coercive STH - some real world tests and updated RFC

2015-02-27 Thread Damien Tournoud
Hi Lester, On Fri, Feb 27, 2015 at 6:51 PM, Lester Caine les...@lsces.co.uk wrote: This may not be what YOU want substr to do and it would perhaps be useful to ADD additional checks so that 'false' is returned when it can't created a string because of the 'invalid arguments', but type hints

Re: [PHP-DEV] Re: Zend JIT Open Sourced

2015-02-27 Thread Anthony Ferrara
Dmitry, That's not to say there's anything wrong with this approach, nor that there isn't a ton we can learn from it. I think it's a fantastic research effort and plan on digging through it myself. Thank you for open sourcing it. Thanks for good words :) This work may be adopted for some

Re: [PHP-DEV] Re: Zend JIT Open Sourced

2015-02-27 Thread Anthony Ferrara
Zeev, On Fri, Feb 27, 2015 at 3:36 PM, Zeev Suraski z...@zend.com wrote: -Original Message- From: Anthony Ferrara [mailto:ircmax...@gmail.com] Sent: Friday, February 27, 2015 10:21 PM To: Dmitry Stogov Cc: Zeev Suraski; Jordi Boggiano; PHP Internals Subject: Re: [PHP-DEV] Re: Zend

Re: [PHP-DEV] Re: Zend JIT Open Sourced

2015-02-27 Thread Dmitry Stogov
On Fri, Feb 27, 2015 at 10:36 PM, Anthony Ferrara ircmax...@gmail.com wrote: Dmitry, That's not to say there's anything wrong with this approach, nor that there isn't a ton we can learn from it. I think it's a fantastic research effort and plan on digging through it myself. Thank you for

Re: [PHP-DEV] Re: Zend JIT Open Sourced

2015-02-27 Thread Dmitry Stogov
On Fri, Feb 27, 2015 at 11:21 PM, Anthony Ferrara ircmax...@gmail.com wrote: Dmitry, Sneaky sneaky. Also completely fake. It's been brought to my attention that some people have taken what I said completely out of context and insinuated it as a direct insult to you. I assure you that was

RE: [PHP-DEV] Re: Zend JIT Open Sourced

2015-02-27 Thread Zeev Suraski
-Original Message- From: Anthony Ferrara [mailto:ircmax...@gmail.com] Sent: Friday, February 27, 2015 10:21 PM To: Dmitry Stogov Cc: Zeev Suraski; Jordi Boggiano; PHP Internals Subject: Re: [PHP-DEV] Re: Zend JIT Open Sourced Dmitry, Sneaky sneaky. Also completely fake. It's

Re: [PHP-DEV] Re: Zend JIT Open Sourced

2015-02-27 Thread Dmitry Stogov
On Fri, Feb 27, 2015 at 9:55 PM, Anthony Ferrara ircmax...@gmail.com wrote: Zeev, Right now it compiles script (php file) at once. So yes, our JIT uses some kind of AOT approach, but completely transparently for the rest of PHP. Just to slightly further clarify - we don't compile the

Re: [PHP-DEV] Coercive STH - some real world tests and updated RFC

2015-02-27 Thread Lester Caine
On 27/02/15 20:28, Damien Tournoud wrote: Hi Lester, On Fri, Feb 27, 2015 at 6:51 PM, Lester Caine les...@lsces.co.uk mailto:les...@lsces.co.uk wrote: This may not be what YOU want substr to do and it would perhaps be useful to ADD additional checks so that 'false' is returned

Re: [PHP-DEV] Coercive STH - some real world tests and updated RFC

2015-02-27 Thread Benjamin Eberlei
Zeev, On Fri, Feb 27, 2015 at 12:57 AM, Zeev Suraski z...@zend.com wrote: All, We've been working in the last few days to test and tune the Coercive STH patch. I think the results are quite nice, and surprisingly better than one might have expected. Can we try the patch ourselves? I

Re: [PHP-DEV] Follow-up to STH user experience, this time with actual testing

2015-02-27 Thread Xinchen Hui
Hey: On Fri, Feb 27, 2015 at 3:59 PM, Xinchen Hui larue...@php.net wrote: Hey: On Fri, Feb 27, 2015 at 10:06 AM, François Laupretre franc...@php.net wrote: De : Matthew Weier O'Phinney [mailto:matt...@zend.com] - PHPUnit passes a boolean false to `debug_backtrace()`... which is

Re: [PHP-DEV] Follow-up to STH user experience, this time with actual testing

2015-02-27 Thread Benjamin Eberlei
Matthew, On Fri, Feb 27, 2015 at 1:29 AM, Matthew Weier O'Phinney matt...@zend.com wrote: I've taken some time the last couple days to compile both the Scalare Type Hints v0.5 (heretofor STHv5) and Coercive Scalar Type Hints (heretofore STHcoerce) patches and test some code against them.

Re: [PHP-DEV] Follow-up to STH user experience, this time with actual testing

2015-02-27 Thread Xinchen Hui
Hey: On Fri, Feb 27, 2015 at 10:06 AM, François Laupretre franc...@php.net wrote: De : Matthew Weier O'Phinney [mailto:matt...@zend.com] - PHPUnit passes a boolean false to `debug_backtrace()`... which is documented as expecting an integer! (There are actually several constant values it

[PHP-DEV] BC break between PHP 5.6.5 and PHP 5.6.6

2015-02-27 Thread Sebastian Bergmann
While working on PHPUnit today I noticed one test of its own test suite failing on PHP 5.6.6 that passes on PHP 5.6.5. The details of this can be found at https://github.com/sebastianbergmann/phpunit/issues/1630 Florian Margaine reduced the problem to the following minimal,

[PHP-DEV] aes_decrypt() aes_encrypt() (was Re: crypto_something)

2015-02-27 Thread Tom Worster
On 2/26/15 11:12 AM, Leigh wrote: On 26 February 2015 at 15:37, Tom Worster f...@thefsb.org wrote: I've spoken with Anthony and a couple of others about something in the same vein as the new csprng functions. I think core needs a pair of functions that handles the needs of the 99%. Those

Re: [PHP-DEV] Re: [RFC][VOTE] pecl_http

2015-02-27 Thread Michael Wallner
The vote on the pecl_http RFC has been closed, thanks to everyone who participated. The results are 9 in favour and 23 against, so the RFC was declined, which is actually an understatement ;) On 27 02 2015, at 18:19, Pascal MARTIN, AFUP mail...@pascal-martin.fr wrote: Le 26/02/2015

Re: [PHP-DEV] Coercive STH - some real world tests and updated RFC

2015-02-27 Thread Damien Tournoud
Hi Lester, On Fri, Feb 27, 2015 at 9:53 PM, Lester Caine les...@lsces.co.uk wrote: Please, read the examples again, the current behavior is nothing but inconsistent: substr(a, 1) = FALSE substr(a, -300) = ? That was the case prior to PHP5.2.1 The fixes in 5.2.2 were not

Re: [PHP-DEV] aes_decrypt() aes_encrypt() (was Re: crypto_something)

2015-02-27 Thread Leigh
On 27 February 2015 at 21:14, Tom Worster f...@thefsb.org wrote: 1. You say it doesn't leave any room for interoperability but I'm not sure I agree. I invite you again to look at the Cryptography lib for Python. There are countless applications/services that will do things their own way, and

Re: [PHP-DEV] Zend JIT Open Sourced

2015-02-27 Thread Andi Gutmans
On Feb 27, 2015, at 11:36 AM, Anthony Ferrara ircmax...@gmail.com wrote: Dmitry, That's not to say there's anything wrong with this approach, nor that there isn't a ton we can learn from it. I think it's a fantastic research effort and plan on digging through it myself. Thank you for

Re: [PHP-DEV] Re: Zend JIT Open Sourced

2015-02-27 Thread Dmitry Stogov
On Fri, Feb 27, 2015 at 11:53 PM, Anthony Ferrara ircmax...@gmail.com wrote: Zeev, On Fri, Feb 27, 2015 at 3:36 PM, Zeev Suraski z...@zend.com wrote: -Original Message- From: Anthony Ferrara [mailto:ircmax...@gmail.com] Sent: Friday, February 27, 2015 10:21 PM To: Dmitry Stogov

RE: [PHP-DEV] Re: Zend JIT Open Sourced

2015-02-27 Thread Zeev Suraski
-Original Message- From: Anthony Ferrara [mailto:ircmax...@gmail.com] Sent: Friday, February 27, 2015 10:54 PM To: Zeev Suraski Cc: Dmitry Stogov; PHP Internals Subject: Re: [PHP-DEV] Re: Zend JIT Open Sourced Zeev, On Fri, Feb 27, 2015 at 3:36 PM, Zeev Suraski z...@zend.com

Re: [PHP-DEV] BC break between PHP 5.6.5 and PHP 5.6.6

2015-02-27 Thread Sebastian Bergmann
Am 27.02.2015 um 09:14 schrieb Remi Collet: Hmmm http://3v4l.org/QST64 No clue why PHP 5.6.5 seems to have worked for that reproducing script here earlier. Tried it again and, of course, it also fails with my PHP 5.6.5. Looks the like the reproducing script was not the right one. :-/ --

Re: [PHP-DEV] BC break between PHP 5.6.5 and PHP 5.6.6

2015-02-27 Thread Matteo Beccati
On 27/02/2015 09:06, Sebastian Bergmann wrote: While working on PHPUnit today I noticed one test of its own test suite failing on PHP 5.6.6 that passes on PHP 5.6.5. The details of this can be found at https://github.com/sebastianbergmann/phpunit/issues/1630 It's actually very

Re: [PHP-DEV] Coercive STH - some real world tests and updated RFC

2015-02-27 Thread Dmitry Stogov
I've added the link to the patch https://github.com/php/php-src/pull/1125/files Thanks. Dmitry. On Fri, Feb 27, 2015 at 11:03 AM, Benjamin Eberlei kont...@beberlei.de wrote: Zeev, On Fri, Feb 27, 2015 at 12:57 AM, Zeev Suraski z...@zend.com wrote: All, We've been working in the last

Re: [PHP-DEV] BC break between PHP 5.6.5 and PHP 5.6.6

2015-02-27 Thread Xinchen Hui
Hey: On Fri, Feb 27, 2015 at 4:51 PM, Sebastian Bergmann sebast...@php.net wrote: Am 27.02.2015 um 09:30 schrieb Xinchen Hui: maybe related to your own build? The test in the PHPUnit test suite fails with PHP 5.6.6 (cli) (built: Feb 19 2015 09:44:29) Copyright (c) 1997-2015 The PHP

Re: [PHP-DEV] [RFC][DISCUSSION] Remove allow_url_include INI

2015-02-27 Thread Yasuo Ohgaki
Hi Xinchen, On Fri, Feb 27, 2015 at 4:45 PM, Xinchen Hui larue...@php.net wrote: Sorry, but I am confused by the point, do you want to disable include a remote php file or not? if yes, how about with allow_url_fopen? eval(file_get_contents(http://xx/)); thanks My objective is to

Re: [PHP-DEV] BC break between PHP 5.6.5 and PHP 5.6.6

2015-02-27 Thread Leigh
On 27 February 2015 at 08:20, Leigh lei...@gmail.com wrote: Looking through git blames, this property has been protected for a long time. Possibly related (although not at all sure), Dmitry made some changes to zend_read_property()

Re: [PHP-DEV] BC break between PHP 5.6.5 and PHP 5.6.6

2015-02-27 Thread Dmitry Stogov
check xdebug Thanks. Dmitry. On Fri, Feb 27, 2015 at 11:51 AM, Sebastian Bergmann sebast...@php.net wrote: Am 27.02.2015 um 09:30 schrieb Xinchen Hui: maybe related to your own build? The test in the PHPUnit test suite fails with PHP 5.6.6 (cli) (built: Feb 19 2015 09:44:29)

Re: [PHP-DEV] BC break between PHP 5.6.5 and PHP 5.6.6

2015-02-27 Thread Sebastian Bergmann
Am 27.02.2015 um 09:53 schrieb Xinchen Hui: I noticed different version of xdebug, could you try without it? Thank you for bringing Xdebug to my attention. You are right, it appears to be related to Xdebug. Without Xdebug $ php -v PHP 5.6.6 (cli) (built: Feb 19 2015 09:44:29)

Re: [PHP-DEV] A different user perspective on scalar type declarations

2015-02-27 Thread Lester Caine
On 27/02/15 01:29, François Laupretre wrote: Yes. Same conversion rules : empty string and 0 are false, all the rest is true. For consistency reasons, we can extend the 0 case to accept leading zeroes and leading and trailing blanks, as for a numeric string. Just been checking and yes if

Re: [PHP-DEV] [RFC][DISCUSSION] Remove allow_url_include INI

2015-02-27 Thread Yasuo Ohgaki
Hi Xinchen, On Fri, Feb 27, 2015 at 4:45 PM, Xinchen Hui larue...@php.net wrote: Sorry, but I am confused by the point, do you want to disable include a remote php file or not? I think the RFC title was misleading. I've changed to Precise URL include control Thank you for your feedback.

Re: [PHP-DEV] BC break between PHP 5.6.5 and PHP 5.6.6

2015-02-27 Thread Remi Collet
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Le 27/02/2015 09:06, Sebastian Bergmann a écrit : While working on PHPUnit today I noticed one test of its own test suite failing on PHP 5.6.6 that passes on PHP 5.6.5. The details of this can be found at

Re: [PHP-DEV] BC break between PHP 5.6.5 and PHP 5.6.6

2015-02-27 Thread Leigh
On 27 February 2015 at 08:06, Sebastian Bergmann sebast...@php.net wrote: While working on PHPUnit today I noticed one test of its own test suite failing on PHP 5.6.6 that passes on PHP 5.6.5. The details of this can be found at https://github.com/sebastianbergmann/phpunit/issues/1630

Re: [PHP-DEV] BC break between PHP 5.6.5 and PHP 5.6.6

2015-02-27 Thread Benjamin Eberlei
On Fri, Feb 27, 2015 at 9:20 AM, Leigh lei...@gmail.com wrote: On 27 February 2015 at 08:06, Sebastian Bergmann sebast...@php.net wrote: While working on PHPUnit today I noticed one test of its own test suite failing on PHP 5.6.6 that passes on PHP 5.6.5. The details of this can be

Re: [PHP-DEV] BC break between PHP 5.6.5 and PHP 5.6.6

2015-02-27 Thread Xinchen Hui
Hey: On Fri, Feb 27, 2015 at 4:06 PM, Sebastian Bergmann sebast...@php.net wrote: While working on PHPUnit today I noticed one test of its own test suite failing on PHP 5.6.6 that passes on PHP 5.6.5. The details of this can be found at

Re: [PHP-DEV] BC break between PHP 5.6.5 and PHP 5.6.6

2015-02-27 Thread Sebastian Bergmann
Am 27.02.2015 um 09:30 schrieb Xinchen Hui: maybe related to your own build? The test in the PHPUnit test suite fails with PHP 5.6.6 (cli) (built: Feb 19 2015 09:44:29) Copyright (c) 1997-2015 The PHP Group Zend Engine v2.6.0, Copyright (c) 1998-2015 Zend Technologies with

RE: [PHP-DEV] Follow-up to STH user experience, this time with actual testing

2015-02-27 Thread Zeev Suraski
- PHPUnit passes a boolean false to `debug_backtrace()`... which is documented as expecting an integer! (There are actually several constant values it accepts, all of which are integer values.) In this case, PHPUnit is relying on the fact that the engine casts booleans to the integers

Re: [PHP-DEV] Coercive STH - some real world tests and updated RFC

2015-02-27 Thread Benjamin Eberlei
On Fri, Feb 27, 2015 at 9:44 AM, Dmitry Stogov dmi...@zend.com wrote: I've added the link to the patch https://github.com/php/php-src/pull/1125/files Thanks! First, the necessary PHPUnit changes (dev-master) to avoid errors: https://gist.github.com/beberlei/8a33ae940829f1186da2 - Doctrine

Re: [PHP-DEV] aes_decrypt() aes_encrypt() (was Re: crypto_something)

2015-02-27 Thread Tom Worster
On 2/27/15, 4:29 PM, Leigh lei...@gmail.com wrote: On 27 February 2015 at 21:14, Tom Worster f...@thefsb.org wrote: I don't see why we couldn't sponsor an effort to encourage adoption of this or some such interoperability protocol. Go to FIG, see if the Rails, Node and Django people are

Re: [PHP-DEV] Coercive STH - some real world tests and updated RFC

2015-02-27 Thread Larry Garfield
On 2/27/15 10:15 AM, Christian Stoller wrote: From: Damien Tournoud [mailto:d...@damz.org], Sent: Friday, February 27, 2015 4:54 PM Hi Christian, On Fri, Feb 27, 2015 at 3:38 PM, Christian Stoller stol...@leonex.de wrote: It is not a bug. FALSE as a return value of substr() is the

Re: [PHP-DEV] [VOTE] Exceptions in the engine

2015-02-27 Thread Larry Garfield
On 2/27/15 9:28 AM, guilhermebla...@gmail.com wrote: +1 on Sebastian's suggestion. =) I volunteer to either update the RFC or create a new one to resolve this once Exceptions in the engine passes (which looks like a reality already to me). Just tell me which approach I should take and I'll

Re: [PHP-DEV] [RFC][VOTE] Scalar Type Declarations v0.5

2015-02-27 Thread Larry Garfield
On 2/26/15 8:58 AM, Anthony Ferrara wrote: All, I have opened voting on Scalar Type Declarations v0.5. Please cast your vote. https://wiki.php.net/rfc/scalar_type_hints_v5#vote The vote will remain open until March 13th, 2015 or until the date a competing RFC closes voting, whichever is

Re: [PHP-DEV] [VOTE] Exceptions in the engine

2015-02-27 Thread Christoph Becker
Sebastian Bergmann wrote: I am sorry that I was unable to raise this concern earlier (did not really become aware of the RFC before it was put to the vote), but I would prefer the following: * Introduce a Throwable interface * Let Exception implement the Throwable interface *

Re: [PHP-DEV] A different user perspective on scalar type declarations

2015-02-27 Thread Yasuo Ohgaki
Hi Zeev, On Fri, Feb 27, 2015 at 2:48 AM, Zeev Suraski z...@zend.com wrote: You may have a point there. As Francois said, he was in favor of allowing leading and trailing spaces. I'll definitely reconsider. If we consider existing code, leading/trailing spaces may need to be allowed.

Re: [PHP-DEV] [VOTE] Expectations

2015-02-27 Thread Levi Morrison
On Thu, Feb 19, 2015 at 2:09 AM, Joe Watkins pthre...@pthreads.org wrote: The expectations RFC is now in voting phase: https://wiki.php.net/rfc/expectations#vote This announcement doesn't say when voting will close and the RFC doesn't either. When do you expect voting to close? -- PHP

Re: [PHP-DEV][RFC][VOTE] Enable error_handler callback parameters to be passed by reference

2015-02-27 Thread Thomas Bley
Hi all, the rfc was declined: - Allow $errstr parameter to be passed by reference: 3 - Allow $errno, $errstr, $errfile, $fileno parameter to be passed by reference: 1 - No, Allow none of the parameter be a reference parameter: 16 Regards Thomas Thomas Bley wrote on 13.02.2015 21:51: Hi all!

Re: [PHP-DEV] A different user perspective on scalar type declarations

2015-02-27 Thread Yasuo Ohgaki
Hi Francois, On Fri, Feb 27, 2015 at 10:12 PM, François Laupretre franc...@php.net wrote: If we allow for trailing blanks, we'll allow the same set of chars that is already allowed for leading blanks. I say'blanks' and not 'whitespaces', because here is the list currently allowed as leading

Re: [PHP-DEV] Coercive STH - some real world tests and updated RFC

2015-02-27 Thread Lester Caine
On 27/02/15 21:14, Damien Tournoud wrote: Hi Lester, On Fri, Feb 27, 2015 at 9:53 PM, Lester Caine les...@lsces.co.uk mailto:les...@lsces.co.uk wrote: Please, read the examples again, the current behavior is nothing but inconsistent: substr(a, 1) = FALSE

Re: [PHP-DEV] [RFC][DISCUSSION] Remove allow_url_include INI

2015-02-27 Thread Rowan Collins
Yasuo Ohgaki wrote on 27/02/2015 03:44: Hi all, This is RFC for removing allow_url_include INI option. [1] During Script only include RFC[2] discussion, stream wrapper issue is raised. I was thinking this issue as a separate issue, but it seems others are not. I'm not convinced by the

  1   2   >