[PR] [FLINK-33386][runtime] Support tasks balancing at slot level for Default Scheduler [flink]

RocMarshal opened a new pull request, #23635: URL: https://github.com/apache/flink/pull/23635 ## What is the purpose of the change - Support tasks balancing at slot level for Default Scheduler ## Brief change log - *Introduce BalancedPreferredSlotSharingStra

Re: [PR] [FLINK-33386][runtime] Support tasks balancing at slot level for Default Scheduler [flink]

KarmaGYZ commented on code in PR #23635: URL: https://github.com/apache/flink/pull/23635#discussion_r1426214331 ## flink-runtime/src/main/java/org/apache/flink/runtime/jobmaster/slotpool/DeclarativeSlotPoolBridge.java: ## @@ -200,10 +226,45 @@ protected void onReleaseTaskManager

Re: [PR] [FLINK-33386][runtime] Support tasks balancing at slot level for Default Scheduler [flink]

KarmaGYZ commented on code in PR #23635: URL: https://github.com/apache/flink/pull/23635#discussion_r1413318476 ## flink-runtime/src/main/java/org/apache/flink/runtime/jobmaster/slotpool/DeclarativeSlotPoolService.java: ## @@ -110,7 +110,7 @@ public Optional castInto(Class claz

Re: [PR] [FLINK-33386][runtime] Support tasks balancing at slot level for Default Scheduler [flink]

RocMarshal commented on code in PR #23635: URL: https://github.com/apache/flink/pull/23635#discussion_r1426510597 ## flink-runtime/src/main/java/org/apache/flink/runtime/jobmaster/slotpool/DefaultDeclarativeSlotPool.java: ## @@ -127,7 +155,28 @@ public void increaseResourceRequi

Re: [PR] [FLINK-33386][runtime] Support tasks balancing at slot level for Default Scheduler [flink]

RocMarshal commented on code in PR #23635: URL: https://github.com/apache/flink/pull/23635#discussion_r1426516597 ## flink-runtime/src/main/java/org/apache/flink/runtime/jobmaster/slotpool/DefaultDeclarativeSlotPool.java: ## @@ -127,7 +155,28 @@ public void increaseResourceRequi

Re: [PR] [FLINK-33386][runtime] Support tasks balancing at slot level for Default Scheduler [flink]

RocMarshal commented on code in PR #23635: URL: https://github.com/apache/flink/pull/23635#discussion_r1426523374 ## flink-runtime/src/main/java/org/apache/flink/runtime/jobmaster/slotpool/DeclarativeSlotPoolBridge.java: ## @@ -200,10 +226,45 @@ protected void onReleaseTaskManag

Re: [PR] [FLINK-33386][runtime] Support tasks balancing at slot level for Default Scheduler [flink]

RocMarshal commented on code in PR #23635: URL: https://github.com/apache/flink/pull/23635#discussion_r1426524511 ## flink-runtime/src/main/java/org/apache/flink/runtime/jobmaster/slotpool/DeclarativeSlotPoolBridge.java: ## @@ -200,10 +226,45 @@ protected void onReleaseTaskManag

Re: [PR] [FLINK-33386][runtime] Support tasks balancing at slot level for Default Scheduler [flink]

RocMarshal commented on code in PR #23635: URL: https://github.com/apache/flink/pull/23635#discussion_r1426543430 ## flink-runtime/src/main/java/org/apache/flink/runtime/jobmaster/slotpool/DefaultDeclarativeSlotPool.java: ## @@ -127,7 +155,28 @@ public void increaseResourceRequi

Re: [PR] [FLINK-33386][runtime] Support tasks balancing at slot level for Default Scheduler [flink]

RocMarshal commented on code in PR #23635: URL: https://github.com/apache/flink/pull/23635#discussion_r1426543430 ## flink-runtime/src/main/java/org/apache/flink/runtime/jobmaster/slotpool/DefaultDeclarativeSlotPool.java: ## @@ -127,7 +155,28 @@ public void increaseResourceRequi

Re: [PR] [FLINK-33386][runtime] Support tasks balancing at slot level for Default Scheduler [flink]

KarmaGYZ commented on code in PR #23635: URL: https://github.com/apache/flink/pull/23635#discussion_r1427513961 ## flink-runtime/src/main/java/org/apache/flink/runtime/jobmaster/slotpool/DeclarativeSlotPoolBridge.java: ## @@ -200,10 +226,45 @@ protected void onReleaseTaskManager

Re: [PR] [FLINK-33386][runtime] Support tasks balancing at slot level for Default Scheduler [flink]

KarmaGYZ commented on code in PR #23635: URL: https://github.com/apache/flink/pull/23635#discussion_r1427515551 ## flink-runtime/src/main/java/org/apache/flink/runtime/jobmaster/slotpool/DefaultDeclarativeSlotPool.java: ## @@ -127,7 +155,28 @@ public void increaseResourceRequire

Re: [PR] [FLINK-33386][runtime] Support tasks balancing at slot level for Default Scheduler [flink]

KarmaGYZ commented on code in PR #23635: URL: https://github.com/apache/flink/pull/23635#discussion_r1427515808 ## flink-runtime/src/main/java/org/apache/flink/runtime/jobmaster/slotpool/DefaultDeclarativeSlotPool.java: ## @@ -127,7 +155,28 @@ public void increaseResourceRequire

Re: [PR] [FLINK-33386][runtime] Support tasks balancing at slot level for Default Scheduler [flink]

1996fanrui commented on code in PR #23635: URL: https://github.com/apache/flink/pull/23635#discussion_r1427526869 ## flink-runtime/src/main/java/org/apache/flink/runtime/jobmaster/slotpool/DefaultDeclarativeSlotPool.java: ## @@ -103,12 +106,35 @@ public class DefaultDeclarativeS

Re: [PR] [FLINK-33386][runtime] Support tasks balancing at slot level for Default Scheduler [flink]

RocMarshal commented on code in PR #23635: URL: https://github.com/apache/flink/pull/23635#discussion_r1427717395 ## flink-runtime/src/main/java/org/apache/flink/runtime/jobmaster/slotpool/DeclarativeSlotPoolBridge.java: ## @@ -200,10 +226,45 @@ protected void onReleaseTaskManag

Re: [PR] [FLINK-33386][runtime] Support tasks balancing at slot level for Default Scheduler [flink]

KarmaGYZ commented on code in PR #23635: URL: https://github.com/apache/flink/pull/23635#discussion_r1432179061 ## flink-runtime/src/main/java/org/apache/flink/runtime/jobmaster/JobMaster.java: ## @@ -334,7 +334,9 @@ public void onUnknownDeploymentsOf( .

Re: [PR] [FLINK-33386][runtime] Support tasks balancing at slot level for Default Scheduler [flink]

RocMarshal commented on code in PR #23635: URL: https://github.com/apache/flink/pull/23635#discussion_r1432336723 ## flink-runtime/src/main/java/org/apache/flink/runtime/jobmaster/slotpool/DefaultDeclarativeSlotPool.java: ## @@ -118,26 +129,47 @@ public DefaultDeclarativeSlotPoo

Re: [PR] [FLINK-33386][runtime] Support tasks balancing at slot level for Default Scheduler [flink]

RocMarshal commented on code in PR #23635: URL: https://github.com/apache/flink/pull/23635#discussion_r1432351722 ## flink-runtime/src/main/java/org/apache/flink/runtime/jobmaster/JobMaster.java: ## @@ -334,7 +334,9 @@ public void onUnknownDeploymentsOf(

Re: [PR] [FLINK-33386][runtime] Support tasks balancing at slot level for Default Scheduler [flink]

RocMarshal commented on code in PR #23635: URL: https://github.com/apache/flink/pull/23635#discussion_r1432351722 ## flink-runtime/src/main/java/org/apache/flink/runtime/jobmaster/JobMaster.java: ## @@ -334,7 +334,9 @@ public void onUnknownDeploymentsOf(

Re: [PR] [FLINK-33386][runtime] Support tasks balancing at slot level for Default Scheduler [flink]

RocMarshal commented on code in PR #23635: URL: https://github.com/apache/flink/pull/23635#discussion_r1432336723 ## flink-runtime/src/main/java/org/apache/flink/runtime/jobmaster/slotpool/DefaultDeclarativeSlotPool.java: ## @@ -118,26 +129,47 @@ public DefaultDeclarativeSlotPoo

Re: [PR] [FLINK-33386][runtime] Support tasks balancing at slot level for Default Scheduler [flink]

KarmaGYZ commented on code in PR #23635: URL: https://github.com/apache/flink/pull/23635#discussion_r1432481088 ## flink-runtime/src/main/java/org/apache/flink/runtime/jobmaster/JobMaster.java: ## @@ -334,7 +334,9 @@ public void onUnknownDeploymentsOf( .

Re: [PR] [FLINK-33386][runtime] Support tasks balancing at slot level for Default Scheduler [flink]

KarmaGYZ commented on code in PR #23635: URL: https://github.com/apache/flink/pull/23635#discussion_r1432482972 ## flink-runtime/src/main/java/org/apache/flink/runtime/jobmaster/slotpool/DefaultDeclarativeSlotPool.java: ## @@ -118,26 +129,47 @@ public DefaultDeclarativeSlotPool(

Re: [PR] [FLINK-33386][runtime] Support tasks balancing at slot level for Default Scheduler [flink]

RocMarshal commented on code in PR #23635: URL: https://github.com/apache/flink/pull/23635#discussion_r1432535390 ## flink-runtime/src/main/java/org/apache/flink/runtime/jobmaster/JobMaster.java: ## @@ -334,7 +334,9 @@ public void onUnknownDeploymentsOf(

Re: [PR] [FLINK-33386][runtime] Support tasks balancing at slot level for Default Scheduler [flink]

RocMarshal commented on code in PR #23635: URL: https://github.com/apache/flink/pull/23635#discussion_r1432535390 ## flink-runtime/src/main/java/org/apache/flink/runtime/jobmaster/JobMaster.java: ## @@ -334,7 +334,9 @@ public void onUnknownDeploymentsOf(

Re: [PR] [FLINK-33386][runtime] Support tasks balancing at slot level for Default Scheduler [flink]

RocMarshal commented on code in PR #23635: URL: https://github.com/apache/flink/pull/23635#discussion_r1432535390 ## flink-runtime/src/main/java/org/apache/flink/runtime/jobmaster/JobMaster.java: ## @@ -334,7 +334,9 @@ public void onUnknownDeploymentsOf(

Re: [PR] [FLINK-33386][runtime] Support tasks balancing at slot level for Default Scheduler [flink]

RocXing commented on code in PR #23635: URL: https://github.com/apache/flink/pull/23635#discussion_r1436413745 ## flink-runtime/src/main/java/org/apache/flink/runtime/scheduler/TaskBalancedPreferredSlotSharingStrategy.java: ## @@ -0,0 +1,344 @@ +/* + * Licensed to the Apache Sof

Re: [PR] [FLINK-33386][runtime] Support tasks balancing at slot level for Default Scheduler [flink]

Myasuka commented on PR #23635: URL: https://github.com/apache/flink/pull/23635#issuecomment-1892504610 @RocMarshal Just be curious about the progress, does this PR still wait for some comments to be addressed before it could be merged? -- This is an automated message from the Apache Git

Re: [PR] [FLINK-33386][runtime] Support tasks balancing at slot level for Default Scheduler [flink]

KarmaGYZ commented on PR #23635: URL: https://github.com/apache/flink/pull/23635#issuecomment-1892964860 > @RocMarshal Just be curious about the progress, does this PR still wait for some comments to be addressed before it could be merged? This PR is in progress now. We plan to merge

Re: [PR] [FLINK-33386][runtime] Support tasks balancing at slot level for Default Scheduler [flink]

1996fanrui commented on code in PR #23635: URL: https://github.com/apache/flink/pull/23635#discussion_r1453115386 ## flink-core/src/main/java/org/apache/flink/configuration/JobManagerOptions.java: ## @@ -446,6 +446,13 @@ public enum JobStoreType { .defaultV

Re: [PR] [FLINK-33386][runtime] Support tasks balancing at slot level for Default Scheduler [flink]

RocMarshal commented on code in PR #23635: URL: https://github.com/apache/flink/pull/23635#discussion_r1453256769 ## flink-runtime/src/main/java/org/apache/flink/runtime/jobmaster/JobMaster.java: ## @@ -330,12 +334,32 @@ public void onUnknownDeploymentsOf(

Re: [PR] [FLINK-33386][runtime] Support tasks balancing at slot level for Default Scheduler [flink]

1996fanrui commented on code in PR #23635: URL: https://github.com/apache/flink/pull/23635#discussion_r1454413854 ## flink-runtime/src/main/java/org/apache/flink/runtime/scheduler/loading/WeightLoadable.java: ## @@ -0,0 +1,47 @@ +/* + * Licensed to the Apache Software Foundation

Re: [PR] [FLINK-33386][runtime] Support tasks balancing at slot level for Default Scheduler [flink]

1996fanrui commented on code in PR #23635: URL: https://github.com/apache/flink/pull/23635#discussion_r1454932673 ## flink-runtime/src/main/java/org/apache/flink/runtime/scheduler/loading/LoadingWeight.java: ## @@ -0,0 +1,69 @@ +/* + * Licensed to the Apache Software Foundation

Re: [PR] [FLINK-33386][runtime] Support tasks balancing at slot level for Default Scheduler [flink]

RocMarshal commented on code in PR #23635: URL: https://github.com/apache/flink/pull/23635#discussion_r1455014315 ## flink-runtime/src/main/java/org/apache/flink/runtime/scheduler/loading/LoadingWeight.java: ## @@ -0,0 +1,69 @@ +/* + * Licensed to the Apache Software Foundation

Re: [PR] [FLINK-33386][runtime] Support tasks balancing at slot level for Default Scheduler [flink]

1996fanrui commented on code in PR #23635: URL: https://github.com/apache/flink/pull/23635#discussion_r1455025025 ## flink-runtime/src/main/java/org/apache/flink/runtime/scheduler/loading/LoadingWeight.java: ## @@ -0,0 +1,69 @@ +/* + * Licensed to the Apache Software Foundation

Re: [PR] [FLINK-33386][runtime] Support tasks balancing at slot level for Default Scheduler [flink]

1996fanrui commented on code in PR #23635: URL: https://github.com/apache/flink/pull/23635#discussion_r1455029438 ## flink-runtime/src/main/java/org/apache/flink/runtime/scheduler/loading/LoadingWeight.java: ## @@ -0,0 +1,69 @@ +/* + * Licensed to the Apache Software Foundation

Re: [PR] [FLINK-33386][runtime] Support tasks balancing at slot level for Default Scheduler [flink]

flinkbot commented on PR #23635: URL: https://github.com/apache/flink/pull/23635#issuecomment-1787488771 ## CI report: * 0816a1779cbf97c1e3526e18e70d3d2e09817a05 UNKNOWN Bot commands The @flinkbot bot supports the following commands: - `@flinkbot run azure`

Re: [PR] [FLINK-33386][runtime] Support tasks balancing at slot level for Default Scheduler [flink]

1996fanrui commented on code in PR #23635: URL: https://github.com/apache/flink/pull/23635#discussion_r1378331133 ## flink-core/src/main/java/org/apache/flink/configuration/TaskManagerOptions.java: ## @@ -708,6 +708,20 @@ public class TaskManagerOptions {

Re: [PR] [FLINK-33386][runtime] Support tasks balancing at slot level for Default Scheduler [flink]

1996fanrui commented on code in PR #23635: URL: https://github.com/apache/flink/pull/23635#discussion_r1378332744 ## flink-core/src/main/java/org/apache/flink/configuration/TaskManagerOptions.java: ## @@ -708,6 +708,20 @@ public class TaskManagerOptions {

Re: [PR] [FLINK-33386][runtime] Support tasks balancing at slot level for Default Scheduler [flink]

RocMarshal commented on code in PR #23635: URL: https://github.com/apache/flink/pull/23635#discussion_r1378352765 ## flink-runtime/src/main/java/org/apache/flink/runtime/scheduler/BalancedPreferredSlotSharingStrategy.java: ## @@ -0,0 +1,275 @@ +/* + * Licensed to the Apache Soft

Re: [PR] [FLINK-33386][runtime] Support tasks balancing at slot level for Default Scheduler [flink]

RocMarshal commented on code in PR #23635: URL: https://github.com/apache/flink/pull/23635#discussion_r1378358266 ## flink-core/src/main/java/org/apache/flink/configuration/TaskManagerOptions.java: ## @@ -708,6 +708,20 @@ public class TaskManagerOptions {

Re: [PR] [FLINK-33386][runtime] Support tasks balancing at slot level for Default Scheduler [flink]

1996fanrui commented on code in PR #23635: URL: https://github.com/apache/flink/pull/23635#discussion_r1381212518 ## flink-core/src/main/java/org/apache/flink/configuration/TaskManagerOptions.java: ## @@ -708,6 +708,20 @@ public class TaskManagerOptions {

Re: [PR] [FLINK-33386][runtime] Support tasks balancing at slot level for Default Scheduler [flink]

RocMarshal commented on code in PR #23635: URL: https://github.com/apache/flink/pull/23635#discussion_r1381224693 ## flink-core/src/main/java/org/apache/flink/configuration/TaskManagerOptions.java: ## @@ -708,6 +708,20 @@ public class TaskManagerOptions {

Re: [PR] [FLINK-33386][runtime] Support tasks balancing at slot level for Default Scheduler [flink]

RocMarshal commented on code in PR #23635: URL: https://github.com/apache/flink/pull/23635#discussion_r1381224693 ## flink-core/src/main/java/org/apache/flink/configuration/TaskManagerOptions.java: ## @@ -708,6 +708,20 @@ public class TaskManagerOptions {

Re: [PR] [FLINK-33386][runtime] Support tasks balancing at slot level for Default Scheduler [flink]

1996fanrui commented on code in PR #23635: URL: https://github.com/apache/flink/pull/23635#discussion_r1381232496 ## flink-core/src/main/java/org/apache/flink/configuration/TaskManagerOptions.java: ## @@ -708,6 +708,20 @@ public class TaskManagerOptions {

Re: [PR] [FLINK-33386][runtime] Support tasks balancing at slot level for Default Scheduler [flink]

RocMarshal commented on code in PR #23635: URL: https://github.com/apache/flink/pull/23635#discussion_r1382851909 ## flink-runtime/src/main/java/org/apache/flink/runtime/scheduler/SlotSharingExecutionSlotAllocatorFactory.java: ## @@ -84,4 +96,25 @@ public ExecutionSlotAllocator

Re: [PR] [FLINK-33386][runtime] Support tasks balancing at slot level for Default Scheduler [flink]

KarmaGYZ commented on code in PR #23635: URL: https://github.com/apache/flink/pull/23635#discussion_r1383243917 ## flink-runtime/src/main/java/org/apache/flink/runtime/resourcemanager/slotmanager/DefaultResourceAllocationStrategy.java: ## @@ -95,7 +96,7 @@ public DefaultResource

Re: [PR] [FLINK-33386][runtime] Support tasks balancing at slot level for Default Scheduler [flink]

RocMarshal commented on code in PR #23635: URL: https://github.com/apache/flink/pull/23635#discussion_r1387973762 ## flink-runtime/src/main/java/org/apache/flink/runtime/resourcemanager/slotmanager/DefaultResourceAllocationStrategy.java: ## @@ -95,7 +96,7 @@ public DefaultResour

Re: [PR] [FLINK-33386][runtime] Support tasks balancing at slot level for Default Scheduler [flink]

RocMarshal commented on code in PR #23635: URL: https://github.com/apache/flink/pull/23635#discussion_r1387973762 ## flink-runtime/src/main/java/org/apache/flink/runtime/resourcemanager/slotmanager/DefaultResourceAllocationStrategy.java: ## @@ -95,7 +96,7 @@ public DefaultResour

Re: [PR] [FLINK-33386][runtime] Support tasks balancing at slot level for Default Scheduler [flink]

1996fanrui commented on code in PR #23635: URL: https://github.com/apache/flink/pull/23635#discussion_r1385855309 ## flink-runtime/src/main/java/org/apache/flink/runtime/scheduler/ExecutionSlotSharingGroup.java: ## @@ -31,22 +34,36 @@ class ExecutionSlotSharingGroup { pri

Re: [PR] [FLINK-33386][runtime] Support tasks balancing at slot level for Default Scheduler [flink]

KarmaGYZ commented on code in PR #23635: URL: https://github.com/apache/flink/pull/23635#discussion_r1388936955 ## flink-runtime/src/main/java/org/apache/flink/runtime/resourcemanager/slotmanager/DefaultResourceAllocationStrategy.java: ## @@ -95,7 +96,7 @@ public DefaultResource

Re: [PR] [FLINK-33386][runtime] Support tasks balancing at slot level for Default Scheduler [flink]

KarmaGYZ commented on code in PR #23635: URL: https://github.com/apache/flink/pull/23635#discussion_r1388936955 ## flink-runtime/src/main/java/org/apache/flink/runtime/resourcemanager/slotmanager/DefaultResourceAllocationStrategy.java: ## @@ -95,7 +96,7 @@ public DefaultResource

Re: [PR] [FLINK-33386][runtime] Support tasks balancing at slot level for Default Scheduler [flink]

RocMarshal commented on code in PR #23635: URL: https://github.com/apache/flink/pull/23635#discussion_r1390096271 ## flink-core/src/main/java/org/apache/flink/configuration/TaskManagerOptions.java: ## @@ -708,6 +711,60 @@ public class TaskManagerOptions {

Re: [PR] [FLINK-33386][runtime] Support tasks balancing at slot level for Default Scheduler [flink]

1996fanrui commented on code in PR #23635: URL: https://github.com/apache/flink/pull/23635#discussion_r1390096801 ## flink-runtime/src/main/java/org/apache/flink/runtime/resourcemanager/slotmanager/DefaultResourceAllocationStrategy.java: ## @@ -95,7 +96,7 @@ public DefaultResour

Re: [PR] [FLINK-33386][runtime] Support tasks balancing at slot level for Default Scheduler [flink]

RocMarshal commented on code in PR #23635: URL: https://github.com/apache/flink/pull/23635#discussion_r1390231615 ## flink-runtime/src/main/java/org/apache/flink/runtime/resourcemanager/slotmanager/DefaultResourceAllocationStrategy.java: ## @@ -95,7 +96,7 @@ public DefaultResour

Re: [PR] [FLINK-33386][runtime] Support tasks balancing at slot level for Default Scheduler [flink]

1996fanrui commented on code in PR #23635: URL: https://github.com/apache/flink/pull/23635#discussion_r139022 ## flink-runtime/src/main/java/org/apache/flink/runtime/resourcemanager/slotmanager/DefaultResourceAllocationStrategy.java: ## @@ -95,7 +96,7 @@ public DefaultResour

Re: [PR] [FLINK-33386][runtime] Support tasks balancing at slot level for Default Scheduler [flink]

RocMarshal commented on PR #23635: URL: https://github.com/apache/flink/pull/23635#issuecomment-1806832620 Thank you @KarmaGYZ @1996fanrui very much for your comments. and I updated the PR based on your comments. Have a great weekend~ :) -- This is an automated message from the Apach

Re: [PR] [FLINK-33386][runtime] Support tasks balancing at slot level for Default Scheduler [flink]

KarmaGYZ commented on code in PR #23635: URL: https://github.com/apache/flink/pull/23635#discussion_r1390593913 ## flink-runtime/src/main/java/org/apache/flink/runtime/jobmanager/scheduler/SlotSharingGroup.java: ## @@ -76,6 +76,6 @@ public ResourceProfile getResourceProfile() {

Re: [PR] [FLINK-33386][runtime] Support tasks balancing at slot level for Default Scheduler [flink]

1996fanrui commented on code in PR #23635: URL: https://github.com/apache/flink/pull/23635#discussion_r1390238967 ## flink-runtime/src/main/java/org/apache/flink/runtime/resourcemanager/slotmanager/SlotManagerConfiguration.java: ## @@ -295,6 +294,19 @@ public static SlotManagerC

Re: [PR] [FLINK-33386][runtime] Support tasks balancing at slot level for Default Scheduler [flink]

1996fanrui commented on PR #23635: URL: https://github.com/apache/flink/pull/23635#issuecomment-1807589290 Hi @KarmaGYZ , thanks for your hard review! > I think this PR contains two components. First would be a supplement of [FLINK-33448](https://issues.apache.org/jira/browse/FLINK-33

Re: [PR] [FLINK-33386][runtime] Support tasks balancing at slot level for Default Scheduler [flink]

KarmaGYZ commented on code in PR #23635: URL: https://github.com/apache/flink/pull/23635#discussion_r1398939301 ## flink-runtime/src/main/java/org/apache/flink/runtime/scheduler/TaskBalancedPreferredSlotSharingStrategy.java: ## @@ -0,0 +1,361 @@ +/* + * Licensed to the Apache So

Re: [PR] [FLINK-33386][runtime] Support tasks balancing at slot level for Default Scheduler [flink]

1996fanrui commented on code in PR #23635: URL: https://github.com/apache/flink/pull/23635#discussion_r1400131195 ## flink-runtime/src/main/java/org/apache/flink/runtime/scheduler/TaskBalancedPreferredSlotSharingStrategy.java: ## @@ -0,0 +1,361 @@ +/* + * Licensed to the Apache

Re: [PR] [FLINK-33386][runtime] Support tasks balancing at slot level for Default Scheduler [flink]

RocMarshal commented on code in PR #23635: URL: https://github.com/apache/flink/pull/23635#discussion_r1405002564 ## flink-runtime/src/main/java/org/apache/flink/runtime/scheduler/TaskBalancedPreferredSlotSharingStrategy.java: ## @@ -0,0 +1,361 @@ +/* + * Licensed to the Apache

Re: [PR] [FLINK-33386][runtime] Support tasks balancing at slot level for Default Scheduler [flink]

RocMarshal commented on code in PR #23635: URL: https://github.com/apache/flink/pull/23635#discussion_r1405002722 ## flink-runtime/src/main/java/org/apache/flink/runtime/scheduler/TaskBalancedPreferredSlotSharingStrategy.java: ## @@ -0,0 +1,361 @@ +/* + * Licensed to the Apache

Re: [PR] [FLINK-33386][runtime] Support tasks balancing at slot level for Default Scheduler [flink]

RocMarshal commented on code in PR #23635: URL: https://github.com/apache/flink/pull/23635#discussion_r1405002804 ## flink-runtime/src/test/java/org/apache/flink/runtime/scheduler/TaskBalancedPreferredSlotSharingStrategyTest.java: ## @@ -0,0 +1,248 @@ +/* + * Licensed to the Apa

Re: [PR] [FLINK-33386][runtime] Support tasks balancing at slot level for Default Scheduler [flink]

RocMarshal commented on code in PR #23635: URL: https://github.com/apache/flink/pull/23635#discussion_r1405002911 ## flink-runtime/src/test/java/org/apache/flink/runtime/scheduler/TaskBalancedPreferredSlotSharingStrategyTest.java: ## @@ -0,0 +1,248 @@ +/* + * Licensed to the Apa

Re: [PR] [FLINK-33386][runtime] Support tasks balancing at slot level for Default Scheduler [flink]

RocMarshal commented on code in PR #23635: URL: https://github.com/apache/flink/pull/23635#discussion_r1405028622 ## flink-runtime/src/test/java/org/apache/flink/runtime/scheduler/TaskBalancedPreferredSlotSharingStrategyTest.java: ## @@ -0,0 +1,248 @@ +/* + * Licensed to the Apa

Re: [PR] [FLINK-33386][runtime] Support tasks balancing at slot level for Default Scheduler [flink]

RocMarshal commented on PR #23635: URL: https://github.com/apache/flink/pull/23635#issuecomment-1826330445 Hi, @KarmaGYZ @1996fanrui Thank you very much for your patient review comments. I updated it based on your comments. PTAL in your free time，Have a nice weekend~ -- This is an auto

Re: [PR] [FLINK-33386][runtime] Support tasks balancing at slot level for Default Scheduler [flink]

1996fanrui commented on code in PR #23635: URL: https://github.com/apache/flink/pull/23635#discussion_r1405310873 ## flink-runtime/src/main/java/org/apache/flink/runtime/scheduler/TaskBalancedPreferredSlotSharingStrategy.java: ## @@ -0,0 +1,338 @@ +/* + * Licensed to the Apache

Re: [PR] [FLINK-33386][runtime] Support tasks balancing at slot level for Default Scheduler [flink]

1996fanrui commented on code in PR #23635: URL: https://github.com/apache/flink/pull/23635#discussion_r1405352714 ## flink-runtime/src/test/java/org/apache/flink/runtime/scheduler/TaskBalancedPreferredSlotSharingStrategyTest.java: ## @@ -0,0 +1,248 @@ +/* + * Licensed to the Apa

Re: [PR] [FLINK-33386][runtime] Support tasks balancing at slot level for Default Scheduler [flink]

1996fanrui commented on code in PR #23635: URL: https://github.com/apache/flink/pull/23635#discussion_r1405313903 ## flink-runtime/src/test/java/org/apache/flink/runtime/scheduler/TaskBalancedPreferredSlotSharingStrategyTest.java: ## @@ -0,0 +1,248 @@ +/* + * Licensed to the Apa

Re: [PR] [FLINK-33386][runtime] Support tasks balancing at slot level for Default Scheduler [flink]

KarmaGYZ commented on code in PR #23635: URL: https://github.com/apache/flink/pull/23635#discussion_r1405582679 ## flink-runtime/src/test/java/org/apache/flink/runtime/scheduler/TaskBalancedPreferredSlotSharingStrategyTest.java: ## @@ -0,0 +1,115 @@ +/* + * Licensed to the Apach

Re: [PR] [FLINK-33386][runtime] Support tasks balancing at slot level for Default Scheduler [flink]

KarmaGYZ commented on code in PR #23635: URL: https://github.com/apache/flink/pull/23635#discussion_r1405582679 ## flink-runtime/src/test/java/org/apache/flink/runtime/scheduler/TaskBalancedPreferredSlotSharingStrategyTest.java: ## @@ -0,0 +1,115 @@ +/* + * Licensed to the Apach

Re: [PR] [FLINK-33386][runtime] Support tasks balancing at slot level for Default Scheduler [flink]

RocMarshal commented on PR #23635: URL: https://github.com/apache/flink/pull/23635#issuecomment-1837758141 The waiting mechanism is ready for the review. Would you @KarmaGYZ @1996fanrui help take a look if you were in free time? Thank you very much~ And the verification part about the

Re: [PR] [FLINK-33386][runtime] Support tasks balancing at slot level for Default Scheduler [flink]

1996fanrui commented on code in PR #23635: URL: https://github.com/apache/flink/pull/23635#discussion_r1413430330 ## flink-runtime/src/main/java/org/apache/flink/runtime/jobmaster/slotpool/GlobalViewPhysicalSlotProviderImpl.java: ## @@ -0,0 +1,50 @@ +/* + * Licensed to the Apach

Re: [PR] [FLINK-33386][runtime] Support tasks balancing at slot level for Default Scheduler [flink]

1996fanrui commented on code in PR #23635: URL: https://github.com/apache/flink/pull/23635#discussion_r1413436882 ## flink-runtime/src/main/java/org/apache/flink/runtime/jobmaster/slotpool/GlobalViewDeclarativeSlotPoolBridge.java: ## @@ -0,0 +1,261 @@ +/* + * Licensed to the Apa

Re: [PR] [FLINK-33386][runtime] Support tasks balancing at slot level for Default Scheduler [flink]

1996fanrui commented on code in PR #23635: URL: https://github.com/apache/flink/pull/23635#discussion_r1413436882 ## flink-runtime/src/main/java/org/apache/flink/runtime/jobmaster/slotpool/GlobalViewDeclarativeSlotPoolBridge.java: ## @@ -0,0 +1,261 @@ +/* + * Licensed to the Apa

Re: [PR] [FLINK-33386][runtime] Support tasks balancing at slot level for Default Scheduler [flink]

RocMarshal commented on code in PR #23635: URL: https://github.com/apache/flink/pull/23635#discussion_r1415650282 ## flink-runtime/src/main/java/org/apache/flink/runtime/jobmaster/slotpool/GlobalViewDeclarativeSlotPoolBridge.java: ## @@ -0,0 +1,261 @@ +/* + * Licensed to the Apa

Re: [PR] [FLINK-33386][runtime] Support tasks balancing at slot level for Default Scheduler [flink]

RocMarshal commented on code in PR #23635: URL: https://github.com/apache/flink/pull/23635#discussion_r1415663600 ## flink-runtime/src/main/java/org/apache/flink/runtime/jobmaster/slotpool/GlobalViewDeclarativeSlotPoolBridge.java: ## @@ -0,0 +1,261 @@ +/* + * Licensed to the Apa

Re: [PR] [FLINK-33386][runtime] Support tasks balancing at slot level for Default Scheduler [flink]

RocMarshal commented on code in PR #23635: URL: https://github.com/apache/flink/pull/23635#discussion_r1415668887 ## flink-runtime/src/main/java/org/apache/flink/runtime/jobmaster/slotpool/GlobalViewDeclarativeSlotPoolBridge.java: ## @@ -0,0 +1,261 @@ +/* + * Licensed to the Apa

Re: [PR] [FLINK-33386][runtime] Support tasks balancing at slot level for Default Scheduler [flink]

RocMarshal commented on PR #23635: URL: https://github.com/apache/flink/pull/23635#issuecomment-1840891716 Thank you @1996fanrui @KarmaGYZ very much for the review I have re evaluated the implementation location of the waiting mechanisms based on @KarmaGYZ offline suggestions.

Re: [PR] [FLINK-33386][runtime] Support tasks balancing at slot level for Default Scheduler [flink]

1996fanrui commented on code in PR #23635: URL: https://github.com/apache/flink/pull/23635#discussion_r1687687114 ## flink-runtime/src/test/java/org/apache/flink/runtime/scheduler/LocalInputPreferredSlotSharingStrategyTest.java: ## @@ -69,46 +69,29 @@ class LocalInputPreferredSl

Re: [PR] [FLINK-33386][runtime] Support tasks balancing at slot level for Default Scheduler [flink]

RocMarshal commented on code in PR #23635: URL: https://github.com/apache/flink/pull/23635#discussion_r1691113488 ## flink-runtime/src/test/java/org/apache/flink/runtime/scheduler/LocalInputPreferredSlotSharingStrategyTest.java: ## @@ -69,46 +69,29 @@ class LocalInputPreferredSl

Re: [PR] [FLINK-33386][runtime] Support tasks balancing at slot level for Default Scheduler [flink]

1996fanrui merged PR #23635: URL: https://github.com/apache/flink/pull/23635 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@flink.ap

Re: [PR] [FLINK-33386][runtime] Support tasks balancing at slot level for Default Scheduler [flink]

klam-shop commented on PR #23635: URL: https://github.com/apache/flink/pull/23635#issuecomment-2150824717 👋 Hi, are there any updates or progress on this work as part of FLIP-370? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitH

Re: [PR] [FLINK-33386][runtime] Support tasks balancing at slot level for Default Scheduler [flink]

RocMarshal commented on PR #23635: URL: https://github.com/apache/flink/pull/23635#issuecomment-2151329162 > 👋 Hi, are there any updates or progress on this work as part of FLIP-370? thx for your attention. It's still in working. will update in the next few days. -- This is an aut