shiyc created KAFKA-13596:
-
Summary: ERROR Error while deleting segments for {topic} :
java.nio.file.NoSuchFileException
Key: KAFKA-13596
URL: https://issues.apache.org/jira/browse/KAFKA-13596
Project: Kafka
cmccabe commented on pull request #11677:
URL: https://github.com/apache/kafka/pull/11677#issuecomment-1012661747
Do you want to split the `new VersionRange` -> `VersionRange.of` thing off
into a separate PR? I like the change but it's kind of noisy (plus this would
let us make some increm
cmccabe commented on a change in pull request #11677:
URL: https://github.com/apache/kafka/pull/11677#discussion_r784440277
##
File path:
core/src/main/scala/kafka/server/metadata/MetadataVersionManager.scala
##
@@ -0,0 +1,104 @@
+/**
+ * Licensed to the Apache Software Founda
cmccabe commented on a change in pull request #11677:
URL: https://github.com/apache/kafka/pull/11677#discussion_r784439265
##
File path:
core/src/main/scala/kafka/server/metadata/BrokerMetadataPublisher.scala
##
@@ -19,14 +19,15 @@ package kafka.server.metadata
import kafk
cmccabe commented on a change in pull request #11677:
URL: https://github.com/apache/kafka/pull/11677#discussion_r784439106
##
File path:
core/src/main/scala/kafka/server/metadata/BrokerMetadataListener.scala
##
@@ -118,9 +119,14 @@ class BrokerMetadataListener(
}
cmccabe commented on a change in pull request #11677:
URL: https://github.com/apache/kafka/pull/11677#discussion_r784438707
##
File path:
core/src/main/scala/kafka/server/metadata/BrokerMetadataListener.scala
##
@@ -73,7 +74,7 @@ class BrokerMetadataListener(
/**
* The
cmccabe commented on a change in pull request #11677:
URL: https://github.com/apache/kafka/pull/11677#discussion_r784437638
##
File path:
metadata/src/main/java/org/apache/kafka/metadata/MetadataRecordVersionResolver.java
##
@@ -0,0 +1,25 @@
+/*
+ * Licensed to the Apache Soft
cmccabe commented on a change in pull request #11677:
URL: https://github.com/apache/kafka/pull/11677#discussion_r784437102
##
File path: metadata/src/main/java/org/apache/kafka/metadata/MetadataVersion.java
##
@@ -0,0 +1,41 @@
+/*
+ * Licensed to the Apache Software Foundation
cmccabe commented on a change in pull request #11677:
URL: https://github.com/apache/kafka/pull/11677#discussion_r784435597
##
File path:
raft/src/main/java/org/apache/kafka/raft/internals/RecordsIterator.java
##
@@ -240,6 +240,7 @@ private T readRecord(Readable input) {
cmccabe commented on a change in pull request #11677:
URL: https://github.com/apache/kafka/pull/11677#discussion_r784434978
##
File path: core/src/main/scala/kafka/server/ReplicaManager.scala
##
@@ -2107,7 +2107,7 @@ class ReplicaManager(val config: KafkaConfig,
* @param de
cmccabe commented on a change in pull request #11677:
URL: https://github.com/apache/kafka/pull/11677#discussion_r784434196
##
File path: core/src/main/scala/kafka/server/ControllerServer.scala
##
@@ -160,11 +160,24 @@ class ControllerServer(
alterConfigPolicy = Option(c
cmccabe commented on a change in pull request #11677:
URL: https://github.com/apache/kafka/pull/11677#discussion_r784429730
##
File path: clients/src/main/resources/common/message/UpdateFeaturesRequest.json
##
@@ -30,7 +30,11 @@
{"name": "MaxVersionLevel", "type": "int16
cmccabe commented on a change in pull request #11677:
URL: https://github.com/apache/kafka/pull/11677#discussion_r784428620
##
File path:
clients/src/main/java/org/apache/kafka/clients/admin/UpdateFeaturesOptions.java
##
@@ -26,4 +26,14 @@
*/
@InterfaceStability.Evolving
p
cmccabe commented on a change in pull request #11677:
URL: https://github.com/apache/kafka/pull/11677#discussion_r784427654
##
File path:
clients/src/main/java/org/apache/kafka/clients/admin/KafkaAdminClient.java
##
@@ -4245,12 +4245,24 @@ public UpdateFeaturesResult updateFea
cmccabe commented on a change in pull request #11677:
URL: https://github.com/apache/kafka/pull/11677#discussion_r784426931
##
File path:
clients/src/main/java/org/apache/kafka/clients/admin/FeatureUpdate.java
##
@@ -42,6 +60,23 @@ public FeatureUpdate(final short maxVersionLe
cmccabe commented on a change in pull request #11677:
URL: https://github.com/apache/kafka/pull/11677#discussion_r784426742
##
File path:
clients/src/main/java/org/apache/kafka/clients/admin/FeatureUpdate.java
##
@@ -24,6 +24,24 @@
public class FeatureUpdate {
private fi
cmccabe commented on a change in pull request #11677:
URL: https://github.com/apache/kafka/pull/11677#discussion_r784426548
##
File path:
clients/src/main/java/org/apache/kafka/clients/admin/FeatureUpdate.java
##
@@ -24,6 +24,24 @@
public class FeatureUpdate {
private fi
jeffkbkim opened a new pull request #11679:
URL: https://github.com/apache/kafka/pull/11679
newer clients see errors when including reason in JoinGroupRequest to older
broker:
```
Attempted to write a non-default reason at version 7.
```
make reason field in JoinGroupRequest an
cmccabe commented on a change in pull request #11657:
URL: https://github.com/apache/kafka/pull/11657#discussion_r784398567
##
File path: core/src/main/scala/kafka/server/DynamicConfigManager.scala
##
@@ -182,3 +188,52 @@ class DynamicConfigManager(private val zkClient:
KafkaZ
[
https://issues.apache.org/jira/browse/KAFKA-13594?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17475831#comment-17475831
]
Jun Rao commented on KAFKA-13594:
-
[~Waseem_bhura] : You can refer to [https://kafka.apa
cmccabe commented on pull request #11678:
URL: https://github.com/apache/kafka/pull/11678#issuecomment-1012577468
Would it make more sense to expose the `KafkaBroker` object? We expose that
in a lot of other cases, and it gives access to all the stuff
--
This is an automated message from
mumrah opened a new pull request #11678:
URL: https://github.com/apache/kafka/pull/11678
This cleans up a few things in ClusterInstance to make it more usable. Also
fixes some old "raft" references.
I also adjusted the parameter injection that ClusterTestExtensions is doing
to allow
cmccabe commented on a change in pull request #11657:
URL: https://github.com/apache/kafka/pull/11657#discussion_r784365893
##
File path: core/src/main/scala/kafka/server/MetadataSupport.scala
##
@@ -56,11 +59,24 @@ sealed trait MetadataSupport {
*/
def ensureConsistentW
cmccabe commented on a change in pull request #11657:
URL: https://github.com/apache/kafka/pull/11657#discussion_r784343554
##
File path: core/src/main/scala/kafka/server/DynamicConfigManager.scala
##
@@ -182,3 +188,52 @@ class DynamicConfigManager(private val zkClient:
KafkaZ
cmccabe commented on a change in pull request #11657:
URL: https://github.com/apache/kafka/pull/11657#discussion_r784341498
##
File path: core/src/main/scala/kafka/server/ConfigAdminManager.scala
##
@@ -0,0 +1,373 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) un
cmccabe commented on a change in pull request #11657:
URL: https://github.com/apache/kafka/pull/11657#discussion_r784340295
##
File path: core/src/main/scala/kafka/server/ConfigAdminManager.scala
##
@@ -0,0 +1,373 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) un
cmccabe commented on a change in pull request #11657:
URL: https://github.com/apache/kafka/pull/11657#discussion_r784339091
##
File path: core/src/main/scala/kafka/server/ConfigAdminManager.scala
##
@@ -0,0 +1,373 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) un
cmccabe commented on a change in pull request #11657:
URL: https://github.com/apache/kafka/pull/11657#discussion_r78452
##
File path: core/src/main/scala/kafka/server/ConfigAdminManager.scala
##
@@ -0,0 +1,373 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) un
cmccabe commented on a change in pull request #11657:
URL: https://github.com/apache/kafka/pull/11657#discussion_r784329932
##
File path: core/src/main/scala/kafka/server/ConfigAdminManager.scala
##
@@ -0,0 +1,373 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) un
cmccabe commented on a change in pull request #11657:
URL: https://github.com/apache/kafka/pull/11657#discussion_r784328261
##
File path: core/src/main/scala/kafka/server/ConfigAdminManager.scala
##
@@ -0,0 +1,373 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) un
lmr3796 edited a comment on pull request #11669:
URL: https://github.com/apache/kafka/pull/11669#issuecomment-1012513464
Hi @ijuma sorry for the inconvenience!
I accidentally deleted the branch. Just restored it.
--
This is an automated message from the Apache Git Service.
To respond
lmr3796 commented on pull request #11669:
URL: https://github.com/apache/kafka/pull/11669#issuecomment-1012513464
Hi @ijuma I
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment
ijuma commented on pull request #11669:
URL: https://github.com/apache/kafka/pull/11669#issuecomment-1012511094
@lmr3796 I was planning to merge the PR after triaging the test failures.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on t
lmr3796 closed pull request #11669:
URL: https://github.com/apache/kafka/pull/11669
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr.
dajac commented on pull request #11456:
URL: https://github.com/apache/kafka/pull/11456#issuecomment-1012403673
I’ll make a pass tomorrow. Sorry for the delay. I could not do it sooner due
to the holidays.
--
This is an automated message from the Apache Git Service.
To respond to the mes
mumrah commented on a change in pull request #11677:
URL: https://github.com/apache/kafka/pull/11677#discussion_r784226775
##
File path:
metadata/src/main/java/org/apache/kafka/controller/ClusterControlManager.java
##
@@ -251,7 +267,7 @@ public void deactivate() {
L
mumrah commented on a change in pull request #11677:
URL: https://github.com/apache/kafka/pull/11677#discussion_r784225274
##
File path: core/src/main/scala/kafka/server/BrokerMetadataCheckpoint.scala
##
@@ -94,11 +103,16 @@ class RawMetaProperties(val props: Properties = new
mumrah commented on a change in pull request #11677:
URL: https://github.com/apache/kafka/pull/11677#discussion_r784224825
##
File path: core/src/main/scala/kafka/server/BrokerMetadataCheckpoint.scala
##
@@ -94,11 +103,16 @@ class RawMetaProperties(val props: Properties = new
mumrah commented on a change in pull request #11677:
URL: https://github.com/apache/kafka/pull/11677#discussion_r784223928
##
File path: clients/src/main/resources/common/message/UpdateFeaturesRequest.json
##
@@ -30,7 +30,11 @@
{"name": "MaxVersionLevel", "type": "int16"
mumrah opened a new pull request #11677:
URL: https://github.com/apache/kafka/pull/11677
This is part of the implementation of KIP-778.
More description TBD
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
U
jsancio commented on a change in pull request #11657:
URL: https://github.com/apache/kafka/pull/11657#discussion_r784146601
##
File path: core/src/main/scala/kafka/server/ConfigAdminManager.scala
##
@@ -0,0 +1,373 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) un
[
https://issues.apache.org/jira/browse/KAFKA-13593?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Steven Schlansker resolved KAFKA-13593.
---
Resolution: Fixed
> ThrottledChannelReaper slows broker shutdown by multiple seconds
[
https://issues.apache.org/jira/browse/KAFKA-13593?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17475573#comment-17475573
]
Steven Schlansker commented on KAFKA-13593:
---
Perfect! Glad I am not the only o
mimaison commented on a change in pull request #11456:
URL: https://github.com/apache/kafka/pull/11456#discussion_r784199669
##
File path: core/src/test/scala/unit/kafka/tools/LineMessageReaderTest.scala
##
@@ -0,0 +1,210 @@
+/**
+ * Licensed to the Apache Software Foundation (
[ https://issues.apache.org/jira/browse/KAFKA-13575 ]
joecqupt deleted comment on KAFKA-13575:
--
was (Author: joecqupt):
maybe you set both topic dynamic config `retention.ms` and broker dynamic
config `log.retention.ms` , topic dynamic config p
[
https://issues.apache.org/jira/browse/KAFKA-13575?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17475539#comment-17475539
]
joecqupt commented on KAFKA-13575:
--
maybe you set both topic dynamic config `retention.
[
https://issues.apache.org/jira/browse/KAFKA-13593?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17475474#comment-17475474
]
Lucas Bradstreet edited comment on KAFKA-13593 at 1/13/22, 3:58 PM:
--
[
https://issues.apache.org/jira/browse/KAFKA-13593?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17475474#comment-17475474
]
Lucas Bradstreet commented on KAFKA-13593:
--
Thanks for reporting [~stevenschlan
bfncs edited a comment on pull request #7082:
URL: https://github.com/apache/kafka/pull/7082#issuecomment-1012224319
I finally adopted the patch to the current trunk. The CI test run here
failed though, while at least all tests from the related connect transforms
package run for me locally
bfncs commented on pull request #7082:
URL: https://github.com/apache/kafka/pull/7082#issuecomment-1012224319
I finally adopted the patch to the current trunk. The CI test run here
failed though, while at least all tests from the related connect transforms
package run for me locally. Can a
[
https://issues.apache.org/jira/browse/KAFKA-13451?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
David Jacot resolved KAFKA-13451.
-
Fix Version/s: 3.2.0
Reviewer: David Jacot
Resolution: Fixed
> Add reason to Joi
[
https://issues.apache.org/jira/browse/KAFKA-13496?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
David Jacot resolved KAFKA-13496.
-
Fix Version/s: 3.2.0
Reviewer: David Jacot
Resolution: Fixed
> Add reason to Lea
[
https://issues.apache.org/jira/browse/KAFKA-13495?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
David Jacot resolved KAFKA-13495.
-
Fix Version/s: 3.2.0
Reviewer: David Jacot
Resolution: Fixed
> Add reason to Joi
dajac merged pull request #11571:
URL: https://github.com/apache/kafka/pull/11571
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...
rondagostino commented on a change in pull request #11616:
URL: https://github.com/apache/kafka/pull/11616#discussion_r784034488
##
File path: config/kraft/README.md
##
@@ -35,6 +35,9 @@ Formatting /tmp/kraft-combined-logs
If you are using multiple nodes, then you should run
dajac merged pull request #11566:
URL: https://github.com/apache/kafka/pull/11566
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...
showuon commented on pull request #11616:
URL: https://github.com/apache/kafka/pull/11616#issuecomment-1012204127
@rondagostino @cmccabe , please help review. Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use th
ahmed3465 edited a comment on pull request #6097:
URL: https://github.com/apache/kafka/pull/6097#issuecomment-1007159144
Is there a way I can alter the code and share the Mbean sensor across
multiple consumers using the same client-id ?
We have an auto-scaling Kafka connect cluster which
[
https://issues.apache.org/jira/browse/KAFKA-2953?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17475380#comment-17475380
]
Kvicii.Yu commented on KAFKA-2953:
--
I think it's also important to have multilingual doc
[
https://issues.apache.org/jira/browse/KAFKA-9135?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17475375#comment-17475375
]
Kvicii.Yu commented on KAFKA-9135:
--
Do you know your machine's corpus handle number conf
[
https://issues.apache.org/jira/browse/KAFKA-7148?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17475371#comment-17475371
]
Kvicii.Yu commented on KAFKA-7148:
--
This should appear when rebuilding the index, you ca
patrickstuedi opened a new pull request #11676:
URL: https://github.com/apache/kafka/pull/11676
*More detailed description of your change,
if necessary. The PR title and PR message become
the squashed commit message, so use a separate
comment to ping reviewers.*
*Summary of t
dajac commented on pull request #11671:
URL: https://github.com/apache/kafka/pull/11671#issuecomment-1012033147
Failed tests are unrelated:
```
Build / JDK 17 and Scala 2.13 / testDescribeUnderMinIsrPartitionsMixed() –
kafka.admin.TopicCommandIntegrationTest
```
--
This is an au
[
https://issues.apache.org/jira/browse/KAFKA-13452?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17475255#comment-17475255
]
Praveen Sinha commented on KAFKA-13452:
---
This looks related to this one -
https:/
tombentley commented on pull request #8575:
URL: https://github.com/apache/kafka/pull/8575#issuecomment-1012011876
@pan3793 As far as I can see you never started a VOTE thread for your KIP.
If this is something you're still interested in working on it would be good to
get a vote started. I
Mickael Maison created KAFKA-13595:
--
Summary: Allow producing records with null values in Kafka Console
Producer
Key: KAFKA-13595
URL: https://issues.apache.org/jira/browse/KAFKA-13595
Project: Kafka
[
https://issues.apache.org/jira/browse/KAFKA-7589?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mickael Maison resolved KAFKA-7589.
---
Fix Version/s: 3.2.0
Resolution: Fixed
> Allow configuring num.network.threads per lis
mimaison merged pull request #11560:
URL: https://github.com/apache/kafka/pull/11560
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr
Waseem created KAFKA-13594:
--
Summary: In TNPM Wireline Project, vulnerability found in
Log4j-1.2.17.jar under KAFKA directory
Key: KAFKA-13594
URL: https://issues.apache.org/jira/browse/KAFKA-13594
Project:
dajac commented on a change in pull request #11666:
URL: https://github.com/apache/kafka/pull/11666#discussion_r783736527
##
File path:
core/src/test/scala/unit/kafka/controller/ControllerIntegrationTest.scala
##
@@ -1127,27 +1127,29 @@ class ControllerIntegrationTest extends
70 matches
Mail list logo