Re: [PR] KAFKA-19493: Incorrect rate metric with larger window size [kafka]

2025-07-11 Thread via GitHub
Yunyung commented on code in PR #20152: URL: https://github.com/apache/kafka/pull/20152#discussion_r2202317949 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/AbstractCoordinator.java: ## @@ -1407,7 +1408,8 @@ public GroupCoordinatorMetrics(Metrics metrics,

Re: [PR] KAFKA-19493: Incorrect rate metric with larger window size [kafka]

2025-07-11 Thread via GitHub
Yunyung commented on code in PR #20152: URL: https://github.com/apache/kafka/pull/20152#discussion_r2202317949 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/AbstractCoordinator.java: ## @@ -1407,7 +1408,8 @@ public GroupCoordinatorMetrics(Metrics metrics,

Re: [PR] KAFKA-19493: Incorrect rate metric with larger window size [kafka]

2025-07-11 Thread via GitHub
Yunyung commented on code in PR #20152: URL: https://github.com/apache/kafka/pull/20152#discussion_r2202317949 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/AbstractCoordinator.java: ## @@ -1407,7 +1408,8 @@ public GroupCoordinatorMetrics(Metrics metrics,

Re: [PR] KAFKA-19493: Incorrect rate metric with larger window size [kafka]

2025-07-11 Thread via GitHub
Yunyung commented on code in PR #20152: URL: https://github.com/apache/kafka/pull/20152#discussion_r2202317949 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/AbstractCoordinator.java: ## @@ -1407,7 +1408,8 @@ public GroupCoordinatorMetrics(Metrics metrics,

Re: [PR] KAFKA-19493: Incorrect rate metric with larger window size [kafka]

2025-07-11 Thread via GitHub
Yunyung commented on code in PR #20152: URL: https://github.com/apache/kafka/pull/20152#discussion_r2202317949 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/AbstractCoordinator.java: ## @@ -1407,7 +1408,8 @@ public GroupCoordinatorMetrics(Metrics metrics,

Re: [PR] Minor : Increase Config change throwable log info to error [kafka]

2025-07-11 Thread via GitHub
github-actions[bot] commented on PR #14380: URL: https://github.com/apache/kafka/pull/14380#issuecomment-3064603045 A label of 'needs-attention' was automatically added to this PR in order to raise the attention of the committers. Once this issue has been triaged, the `triage` label s

Re: [PR] KAFKA-19470 Avoid creating loggers repeatedly to affect the performance of request processing [kafka]

2025-07-11 Thread via GitHub
github-actions[bot] commented on PR #20105: URL: https://github.com/apache/kafka/pull/20105#issuecomment-3064601795 A label of 'needs-attention' was automatically added to this PR in order to raise the attention of the committers. Once this issue has been triaged, the `triage` label s

Re: [PR] KAFKA-19493: Incorrect rate metric with larger window size [kafka]

2025-07-11 Thread via GitHub
DL1231 commented on code in PR #20152: URL: https://github.com/apache/kafka/pull/20152#discussion_r2202281405 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/AbstractCoordinator.java: ## @@ -1407,7 +1408,8 @@ public GroupCoordinatorMetrics(Metrics metrics, S

Re: [PR] KAFKA-19493: Incorrect rate metric with larger window size [kafka]

2025-07-11 Thread via GitHub
Yunyung commented on code in PR #20152: URL: https://github.com/apache/kafka/pull/20152#discussion_r2202250159 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/AbstractCoordinator.java: ## @@ -1407,7 +1408,8 @@ public GroupCoordinatorMetrics(Metrics metrics,

Re: [PR] KAFKA-19493: Incorrect rate metric with larger window size [kafka]

2025-07-11 Thread via GitHub
Yunyung commented on code in PR #20152: URL: https://github.com/apache/kafka/pull/20152#discussion_r2202250159 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/AbstractCoordinator.java: ## @@ -1407,7 +1408,8 @@ public GroupCoordinatorMetrics(Metrics metrics,

Re: [PR] KAFKA-19493: Incorrect rate metric with larger window size [kafka]

2025-07-11 Thread via GitHub
Yunyung commented on code in PR #20152: URL: https://github.com/apache/kafka/pull/20152#discussion_r2202250159 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/AbstractCoordinator.java: ## @@ -1407,7 +1408,8 @@ public GroupCoordinatorMetrics(Metrics metrics,

Re: [PR] KAFKA-19493: Incorrect rate metric with larger window size [kafka]

2025-07-11 Thread via GitHub
Yunyung commented on code in PR #20152: URL: https://github.com/apache/kafka/pull/20152#discussion_r2202250159 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/AbstractCoordinator.java: ## @@ -1407,7 +1408,8 @@ public GroupCoordinatorMetrics(Metrics metrics,

Re: [PR] KAFKA-19493: Incorrect rate metric with larger window size [kafka]

2025-07-11 Thread via GitHub
Yunyung commented on code in PR #20152: URL: https://github.com/apache/kafka/pull/20152#discussion_r2202250159 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/AbstractCoordinator.java: ## @@ -1407,7 +1408,8 @@ public GroupCoordinatorMetrics(Metrics metrics,

Re: [PR] KAFKA-19493: Incorrect rate metric with larger window size [kafka]

2025-07-11 Thread via GitHub
Yunyung commented on code in PR #20152: URL: https://github.com/apache/kafka/pull/20152#discussion_r2202250159 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/AbstractCoordinator.java: ## @@ -1407,7 +1408,8 @@ public GroupCoordinatorMetrics(Metrics metrics,

Re: [PR] KAFKA-19493: Incorrect rate metric with larger window size [kafka]

2025-07-11 Thread via GitHub
Yunyung commented on code in PR #20152: URL: https://github.com/apache/kafka/pull/20152#discussion_r2202250159 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/AbstractCoordinator.java: ## @@ -1407,7 +1408,8 @@ public GroupCoordinatorMetrics(Metrics metrics,

Re: [PR] KAFKA-19493: Incorrect rate metric with larger window size [kafka]

2025-07-11 Thread via GitHub
DL1231 commented on code in PR #20152: URL: https://github.com/apache/kafka/pull/20152#discussion_r2202240436 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/AbstractCoordinator.java: ## @@ -1407,7 +1408,8 @@ public GroupCoordinatorMetrics(Metrics metrics, S

Re: [PR] KAFKA-18105 Fix flaky PlaintextAdminIntegrationTest#testElectPreferredLeaders [kafka]

2025-07-11 Thread via GitHub
m1a2st commented on code in PR #20068: URL: https://github.com/apache/kafka/pull/20068#discussion_r2202210131 ## core/src/test/scala/integration/kafka/api/PlaintextAdminIntegrationTest.scala: ## @@ -2850,6 +2851,20 @@ class PlaintextAdminIntegrationTest extends BaseAdminIntegra

[PR] KAFKA-17019: Producer TimeoutException should include root cause [kafka]

2025-07-11 Thread via GitHub
chickenchickenlove opened a new pull request, #20159: URL: https://github.com/apache/kafka/pull/20159 ### Changes - Add new Exception class `PotentialCauseException`. - All `org.apache.kafka.common.errors.TimeoutException` in `KafkaProducer` has `PotentialCauseException` as root caus

Re: [PR] KAFKA-19254: Add generic feature level metrics [kafka]

2025-07-11 Thread via GitHub
Yunyung commented on code in PR #20021: URL: https://github.com/apache/kafka/pull/20021#discussion_r2202009032 ## metadata/src/test/java/org/apache/kafka/image/loader/MetadataLoaderTest.java: ## @@ -508,6 +513,61 @@ public void testLoadEmptyBatch() throws Exception { fa

Re: [PR] KAFKA-19132 Move FetchSession and related classes to server module [kafka]

2025-07-11 Thread via GitHub
wernerdv commented on PR #20158: URL: https://github.com/apache/kafka/pull/20158#issuecomment-3063950378 @chia7712 When you get a chance, could you please review this PR? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[PR] KAFKA-19132 Move FetchSession and related classes to server module [kafka]

2025-07-11 Thread via GitHub
wernerdv opened a new pull request, #20158: URL: https://github.com/apache/kafka/pull/20158 Move FetchSession and related classes to server module and rewrite in Java. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

Re: [PR] MINOR: Refactor LockUtils and improve comments (follow up to KAFKA-19390) [kafka]

2025-07-11 Thread via GitHub
Forest0923 commented on code in PR #20131: URL: https://github.com/apache/kafka/pull/20131#discussion_r2201878623 ## storage/src/main/java/org/apache/kafka/storage/internals/log/AbstractIndex.java: ## @@ -48,7 +47,12 @@ private enum SearchResultType { private static final

Re: [PR] MINOR: Refactor LockUtils and improve comments (follow up to KAFKA-19390) [kafka]

2025-07-11 Thread via GitHub
junrao commented on code in PR #20131: URL: https://github.com/apache/kafka/pull/20131#discussion_r2201522171 ## storage/src/main/java/org/apache/kafka/storage/internals/log/AbstractIndex.java: ## @@ -48,7 +47,12 @@ private enum SearchResultType { private static final Log

[PR] KAFKA-19459: List internal topics for the user [kafka]

2025-07-11 Thread via GitHub
lucliu1108 opened a new pull request, #20157: URL: https://github.com/apache/kafka/pull/20157 For the Kafka Stream group commands, if delete topic requests fail due to version mismatch, user will have to remove the topics manually by first retrieving the relevant internal topics. To

Re: [PR] KAFKA-19306: Migrate LogCompactionTester to tools module [kafka]

2025-07-11 Thread via GitHub
chia7712 commented on code in PR #19905: URL: https://github.com/apache/kafka/pull/19905#discussion_r2201453387 ## tools/src/main/java/org/apache/kafka/tools/LogCompactionTester.java: ## @@ -0,0 +1,505 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more

Re: [PR] MINOR: Fix the handling source topic deletion integration test [kafka]

2025-07-11 Thread via GitHub
Yunyung commented on code in PR #20155: URL: https://github.com/apache/kafka/pull/20155#discussion_r2201444279 ## streams/integration-tests/src/test/java/org/apache/kafka/streams/integration/HandlingSourceTopicDeletionIntegrationTest.java: ## @@ -42,10 +42,13 @@ import java.uti

[PR] MINOR: Cleanup Connect Module (3/n) [kafka]

2025-07-11 Thread via GitHub
sjhajharia opened a new pull request, #20156: URL: https://github.com/apache/kafka/pull/20156 Now that Kafka support Java 17, this PR makes some changes in connect module. The changes in this PR are limited to only some files. A future PR(s) shall follow. The changes mostly inclu

[jira] [Created] (KAFKA-19497) Topic replay code does not handle creation and deletion properly if it occurs in the same batch

2025-07-11 Thread Kevin Wu (Jira)
Kevin Wu created KAFKA-19497: Summary: Topic replay code does not handle creation and deletion properly if it occurs in the same batch Key: KAFKA-19497 URL: https://issues.apache.org/jira/browse/KAFKA-19497

[jira] [Resolved] (KAFKA-18681) GetReplicaLogInfo request

2025-07-11 Thread Jonah Hooper (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-18681?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jonah Hooper resolved KAFKA-18681. -- Resolution: Implemented > GetReplicaLogInfo request > - > >

Re: [PR] KAFKA-19400: Update AddRaftVoterRequest RPC to version 1 [kafka]

2025-07-11 Thread via GitHub
kevin-wu24 commented on code in PR #19982: URL: https://github.com/apache/kafka/pull/19982#discussion_r2201295733 ## raft/src/test/java/org/apache/kafka/raft/KafkaRaftClientReconfigTest.java: ## @@ -374,26 +428,105 @@ public void testAddVoter() throws Exception { ap

Re: [PR] KAFKA-19400: Update AddRaftVoterRequest RPC to version 1 [kafka]

2025-07-11 Thread via GitHub
kevin-wu24 commented on code in PR #19982: URL: https://github.com/apache/kafka/pull/19982#discussion_r2201295733 ## raft/src/test/java/org/apache/kafka/raft/KafkaRaftClientReconfigTest.java: ## @@ -374,26 +428,105 @@ public void testAddVoter() throws Exception { ap

Re: [PR] KAFKA-19400: Update AddRaftVoterRequest RPC to version 1 [kafka]

2025-07-11 Thread via GitHub
kevin-wu24 commented on code in PR #19982: URL: https://github.com/apache/kafka/pull/19982#discussion_r2201295733 ## raft/src/test/java/org/apache/kafka/raft/KafkaRaftClientReconfigTest.java: ## @@ -374,26 +428,105 @@ public void testAddVoter() throws Exception { ap

Re: [PR] KAFKA-19400: Update AddRaftVoterRequest RPC to version 1 [kafka]

2025-07-11 Thread via GitHub
kevin-wu24 commented on code in PR #19982: URL: https://github.com/apache/kafka/pull/19982#discussion_r2201295733 ## raft/src/test/java/org/apache/kafka/raft/KafkaRaftClientReconfigTest.java: ## @@ -374,26 +428,105 @@ public void testAddVoter() throws Exception { ap

Re: [PR] KAFKA-19452: Fix flaky test LogRecoveryTest.testHWCheckpointWithFailuresMultipleLogSegments [kafka]

2025-07-11 Thread via GitHub
junrao commented on code in PR #20121: URL: https://github.com/apache/kafka/pull/20121#discussion_r2201285845 ## core/src/test/scala/unit/kafka/server/LogRecoveryTest.scala: ## @@ -64,6 +64,16 @@ class LogRecoveryTest extends QuorumTestHarness { def hwFile2 = new OffsetCheckp

Re: [PR] KAFKA-19400: Update AddRaftVoterRequest RPC to version 1 [kafka]

2025-07-11 Thread via GitHub
kevin-wu24 commented on code in PR #19982: URL: https://github.com/apache/kafka/pull/19982#discussion_r2201283044 ## raft/src/test/java/org/apache/kafka/raft/KafkaRaftClientReconfigTest.java: ## @@ -374,26 +428,105 @@ public void testAddVoter() throws Exception { ap

Re: [PR] KAFKA-19452: Fix flaky test LogRecoveryTest.testHWCheckpointWithFailuresMultipleLogSegments [kafka]

2025-07-11 Thread via GitHub
karuturi commented on code in PR #20121: URL: https://github.com/apache/kafka/pull/20121#discussion_r2201246590 ## core/src/test/scala/unit/kafka/server/LogRecoveryTest.scala: ## @@ -64,6 +64,12 @@ class LogRecoveryTest extends QuorumTestHarness { def hwFile2 = new OffsetChec

Re: [PR] KAFKA-19452: Fix flaky test LogRecoveryTest.testHWCheckpointWithFailuresMultipleLogSegments [kafka]

2025-07-11 Thread via GitHub
karuturi commented on code in PR #20121: URL: https://github.com/apache/kafka/pull/20121#discussion_r2201263896 ## core/src/test/scala/unit/kafka/server/LogRecoveryTest.scala: ## @@ -64,6 +64,12 @@ class LogRecoveryTest extends QuorumTestHarness { def hwFile2 = new OffsetChec

Re: [PR] KAFKA-19452: Fix flaky test LogRecoveryTest.testHWCheckpointWithFailuresMultipleLogSegments [kafka]

2025-07-11 Thread via GitHub
karuturi commented on code in PR #20121: URL: https://github.com/apache/kafka/pull/20121#discussion_r2201246590 ## core/src/test/scala/unit/kafka/server/LogRecoveryTest.scala: ## @@ -64,6 +64,12 @@ class LogRecoveryTest extends QuorumTestHarness { def hwFile2 = new OffsetChec

Re: [PR] KAFKA-19400: Update AddRaftVoterRequest RPC to version 1 [kafka]

2025-07-11 Thread via GitHub
jsancio commented on code in PR #19982: URL: https://github.com/apache/kafka/pull/19982#discussion_r2201032910 ## raft/src/main/java/org/apache/kafka/raft/internals/AddVoterHandler.java: ## @@ -184,7 +185,8 @@ public CompletableFuture handleAddVoterRequest( AddVoterHan

Re: [PR] KAFKA-19493: Incorrect rate metric with larger window size [kafka]

2025-07-11 Thread via GitHub
Yunyung commented on code in PR #20152: URL: https://github.com/apache/kafka/pull/20152#discussion_r2201150928 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/AbstractCoordinator.java: ## @@ -1407,7 +1408,8 @@ public GroupCoordinatorMetrics(Metrics metrics,

Re: [PR] KAFKA-19452: Fix flaky test LogRecoveryTest.testHWCheckpointWithFailuresMultipleLogSegments [kafka]

2025-07-11 Thread via GitHub
junrao commented on code in PR #20121: URL: https://github.com/apache/kafka/pull/20121#discussion_r2201203837 ## core/src/test/scala/unit/kafka/server/LogRecoveryTest.scala: ## @@ -64,6 +64,12 @@ class LogRecoveryTest extends QuorumTestHarness { def hwFile2 = new OffsetCheckp

Re: [PR] KAFKA-19476: Improve state transition handling in SharePartition [kafka]

2025-07-11 Thread via GitHub
apoorvmittal10 commented on code in PR #20124: URL: https://github.com/apache/kafka/pull/20124#discussion_r2201148519 ## core/src/test/java/kafka/server/share/SharePartitionTest.java: ## @@ -7467,6 +7468,164 @@ public void testNextFetchOffsetWhenOffsetsHaveOngoingTransition() {

Re: [PR] KAFKA-10409: Refactor Kakfa Streams RocksDB Iterators [kafka]

2025-07-11 Thread via GitHub
fonsdant commented on PR #18610: URL: https://github.com/apache/kafka/pull/18610#issuecomment-3062905094 @agavra, sorry for the delay, I am resuming the work. How could I check the coverage report for streams only? According on readme, I can run `gradle streams:reportCoverage`, but when I d

[PR] fix the handling source topic deletion integration test [kafka]

2025-07-11 Thread via GitHub
RaidenE1 opened a new pull request, #20155: URL: https://github.com/apache/kafka/pull/20155 Fix an integration test error: In the old version, the `HandlingSouceTopicDeleteIntegrationTest` expects state change to `ERROR` in both old and new protocols, but in the new protocol, we sho

Re: [PR] MINOR: Only send endpoints to partitions on changes [kafka]

2025-07-11 Thread via GitHub
bbejeck closed pull request #19407: MINOR: Only send endpoints to partitions on changes URL: https://github.com/apache/kafka/pull/19407 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific c

Re: [PR] MINOR: Moving the rollback out of lock in share partition [kafka]

2025-07-11 Thread via GitHub
apoorvmittal10 merged PR #20153: URL: https://github.com/apache/kafka/pull/20153 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.

Re: [PR] MINOR: Moving the rollback out of lock in share partition [kafka]

2025-07-11 Thread via GitHub
apoorvmittal10 commented on PR #20153: URL: https://github.com/apache/kafka/pull/20153#issuecomment-3062523514 Unrelated test failure: which is fixed in https://github.com/apache/kafka/pull/20154 -- This is an automated message from the Apache Git Service. To respond to the message, pleas

Re: [PR] KAFKA-19493: Incorrect rate metric with larger window size [kafka]

2025-07-11 Thread via GitHub
apoorvmittal10 commented on code in PR #20152: URL: https://github.com/apache/kafka/pull/20152#discussion_r2200852049 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/AbstractCoordinator.java: ## @@ -1407,7 +1408,8 @@ public GroupCoordinatorMetrics(Metrics me

Re: [PR] KAFKA-19400: Update AddRaftVoterRequest RPC to version 1 [kafka]

2025-07-11 Thread via GitHub
kevin-wu24 commented on code in PR #19982: URL: https://github.com/apache/kafka/pull/19982#discussion_r2198365307 ## raft/src/test/java/org/apache/kafka/raft/KafkaRaftClientReconfigTest.java: ## @@ -374,26 +428,104 @@ public void testAddVoter() throws Exception { ap

Re: [PR] KAFKA-19478 [2/N]: Remove task pairs [kafka]

2025-07-11 Thread via GitHub
bbejeck commented on PR #20127: URL: https://github.com/apache/kafka/pull/20127#issuecomment-3062444346 @lucasbru failure is relevant - imports format -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

Re: [PR] KAFKA-19489: storage tool should check controller.quorum.voters is not set alongside a dynamic quorum flag when formatting [kafka]

2025-07-11 Thread via GitHub
kevin-wu24 commented on code in PR #20136: URL: https://github.com/apache/kafka/pull/20136#discussion_r2200807511 ## core/src/test/scala/unit/kafka/tools/StorageToolTest.scala: ## @@ -376,6 +376,8 @@ Found problem: val availableDirs = Seq(TestUtils.tempDir()) val prope

Re: [PR] KAFKA-19493: Incorrect rate metric with larger window size [kafka]

2025-07-11 Thread via GitHub
AndrewJSchofield commented on code in PR #20152: URL: https://github.com/apache/kafka/pull/20152#discussion_r2200806387 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/AbstractCoordinator.java: ## @@ -1407,7 +1408,8 @@ public GroupCoordinatorMetrics(Metrics

Re: [PR] KAFKA-19489: storage tool should check controller.quorum.voters is not set alongside a dynamic quorum flag when formatting [kafka]

2025-07-11 Thread via GitHub
kevin-wu24 commented on code in PR #20136: URL: https://github.com/apache/kafka/pull/20136#discussion_r2200806228 ## core/src/main/scala/kafka/tools/StorageTool.scala: ## @@ -135,6 +135,15 @@ object StorageTool extends Logging { featureNamesAndLevels(_).foreachEntry {

Re: [PR] KAFKA-19496: Deflake streams admin api describe test [kafka]

2025-07-11 Thread via GitHub
lucasbru merged PR #20154: URL: https://github.com/apache/kafka/pull/20154 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache

Re: [PR] KAFKA-19496: Deflake streams admin api describe test [kafka]

2025-07-11 Thread via GitHub
lucasbru commented on PR #20154: URL: https://github.com/apache/kafka/pull/20154#issuecomment-3062406676 Ah, this was actually introduced by @RaidenE1 's change. Thanks for fixing @aliehsaeedii -- This is an automated message from the Apache Git Service. To respond to the message, please

Re: [PR] Minor : Use specific error in compression catch handle [kafka]

2025-07-11 Thread via GitHub
k-raina commented on code in PR #20144: URL: https://github.com/apache/kafka/pull/20144#discussion_r2200665834 ## clients/src/main/java/org/apache/kafka/common/telemetry/internals/ClientTelemetryReporter.java: ## @@ -717,7 +718,7 @@ private Optional> createPushRequest(ClientTel

[PR] KAFKA-19496: Deflake streams admin api describe test [kafka]

2025-07-11 Thread via GitHub
aliehsaeedii opened a new pull request, #20154: URL: https://github.com/apache/kafka/pull/20154 This fixes the flaky `DescribeStreamsGroupTest.testDescribeMultipleStreamsGroupWithMembersAndVerboseOptions()`, which sometimes fails due to `ERROR stream-thread Missing source topics: Source to

Re: [PR] KAFKA-16717 [3/N]: Add AdminClient.alterShareGroupOffsets [kafka]

2025-07-11 Thread via GitHub
AndrewJSchofield commented on code in PR #19820: URL: https://github.com/apache/kafka/pull/19820#discussion_r2200620277 ## tools/src/main/java/org/apache/kafka/tools/consumer/group/ShareGroupCommand.java: ## @@ -366,6 +378,67 @@ Entry> sendDeleteShareGroupOffsetsRequest(Stri

Re: [PR] KAFKA-19495: update native image config for native images (v4.1.0) [kafka]

2025-07-11 Thread via GitHub
mimaison merged PR #20151: URL: https://github.com/apache/kafka/pull/20151 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache

[jira] [Created] (KAFKA-19496) Failing test: DescribeStreamsGroupTest.testDescribeMultipleStreamsGroupWithMembersAndVerboseOptions()

2025-07-11 Thread Apoorv Mittal (Jira)
Apoorv Mittal created KAFKA-19496: - Summary: Failing test: DescribeStreamsGroupTest.testDescribeMultipleStreamsGroupWithMembersAndVerboseOptions() Key: KAFKA-19496 URL: https://issues.apache.org/jira/browse/KAFKA-

[jira] [Updated] (KAFKA-19496) Failing test: DescribeStreamsGroupTest.testDescribeMultipleStreamsGroupWithMembersAndVerboseOptions()

2025-07-11 Thread Apoorv Mittal (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19496?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Apoorv Mittal updated KAFKA-19496: -- Component/s: streams > Failing test: > DescribeStreamsGroupTest.testDescribeMultipleStreamsGr

Re: [PR] Minor : Use specific error in compression catch handle [kafka]

2025-07-11 Thread via GitHub
apoorvmittal10 commented on code in PR #20144: URL: https://github.com/apache/kafka/pull/20144#discussion_r2200612707 ## clients/src/main/java/org/apache/kafka/common/telemetry/internals/ClientTelemetryReporter.java: ## @@ -717,7 +718,7 @@ private Optional> createPushRequest(Cl

Re: [PR] Minor : Use specific error in compression catch handle [kafka]

2025-07-11 Thread via GitHub
apoorvmittal10 commented on code in PR #20144: URL: https://github.com/apache/kafka/pull/20144#discussion_r2200612707 ## clients/src/main/java/org/apache/kafka/common/telemetry/internals/ClientTelemetryReporter.java: ## @@ -717,7 +718,7 @@ private Optional> createPushRequest(Cl

Re: [PR] Kafka-16505: Adding dead letter queue in Kafka Streams [kafka]

2025-07-11 Thread via GitHub
lucasbru commented on code in PR #17942: URL: https://github.com/apache/kafka/pull/17942#discussion_r2200535462 ## streams/src/main/java/org/apache/kafka/streams/StreamsConfig.java: ## @@ -619,6 +619,10 @@ public class StreamsConfig extends AbstractConfig { "support \"c

Re: [PR] KAFKA-16717 [3/N]: Add AdminClient.alterShareGroupOffsets [kafka]

2025-07-11 Thread via GitHub
AndrewJSchofield commented on PR #19820: URL: https://github.com/apache/kafka/pull/19820#issuecomment-3062032067 Thanks for the updates. I'm starting to review and test it. Here's a small problem I've found so far. `SG1` is an existing share group with 1 member. `T2` doesn't exist, so the m

Re: [PR] KAFKA-19452: Fix flaky test LogRecoveryTest.testHWCheckpointWithFailuresMultipleLogSegments [kafka]

2025-07-11 Thread via GitHub
karuturi commented on code in PR #20121: URL: https://github.com/apache/kafka/pull/20121#discussion_r2200524063 ## core/src/test/scala/unit/kafka/server/LogRecoveryTest.scala: ## @@ -215,7 +215,7 @@ class LogRecoveryTest extends QuorumTestHarness { server2.startup() up

Re: [PR] Minor : Use specific error in compression catch handle [kafka]

2025-07-11 Thread via GitHub
k-raina commented on code in PR #20144: URL: https://github.com/apache/kafka/pull/20144#discussion_r2200520116 ## clients/src/main/java/org/apache/kafka/common/telemetry/internals/ClientTelemetryReporter.java: ## @@ -717,7 +718,7 @@ private Optional> createPushRequest(ClientTel

Re: [PR] KAFKA-19476: Improve state transition handling in SharePartition [kafka]

2025-07-11 Thread via GitHub
adixitconfluent commented on code in PR #20124: URL: https://github.com/apache/kafka/pull/20124#discussion_r2200500905 ## core/src/main/java/kafka/server/share/SharePartition.java: ## @@ -2834,26 +2850,35 @@ final class AcquisitionLockTimerTask extends TimerTask { priva

Re: [PR] KAFKA-19471: Enable acknowledgement for a record which could not be deserialized [kafka]

2025-07-11 Thread via GitHub
DL1231 commented on code in PR #20148: URL: https://github.com/apache/kafka/pull/20148#discussion_r2200440939 ## test-common/test-common-runtime/src/main/java/org/apache/kafka/common/test/ClusterInstance.java: ## @@ -178,12 +179,16 @@ default ShareConsumer shareConsumer() {

Re: [PR] KAFKA-19476: Improve state transition handling in SharePartition [kafka]

2025-07-11 Thread via GitHub
AndrewJSchofield commented on code in PR #20124: URL: https://github.com/apache/kafka/pull/20124#discussion_r2200429775 ## core/src/main/java/kafka/server/share/SharePartition.java: ## @@ -2834,26 +2850,35 @@ final class AcquisitionLockTimerTask extends TimerTask { priv

Re: [PR] KAFKA-19471: Enable acknowledgement for a record which could not be deserialized [kafka]

2025-07-11 Thread via GitHub
AndrewJSchofield commented on code in PR #20148: URL: https://github.com/apache/kafka/pull/20148#discussion_r2200382575 ## test-common/test-common-runtime/src/main/java/org/apache/kafka/common/test/ClusterInstance.java: ## @@ -178,12 +179,16 @@ default ShareConsumer shareConsum

Re: [PR] KAFKA-19441: encapsulate MetadataImage in GroupCoordinator/ShareCoordinator [kafka]

2025-07-11 Thread via GitHub
AndrewJSchofield commented on code in PR #20061: URL: https://github.com/apache/kafka/pull/20061#discussion_r2200340434 ## coordinator-common/src/main/java/org/apache/kafka/coordinator/common/runtime/CoordinatorMetadataImage.java: ## @@ -0,0 +1,145 @@ +/* + * Licensed to the Apa

Re: [PR] KAFKA-19431: Ensure consumer and share assignment consistency with subscriptions [kafka]

2025-07-11 Thread via GitHub
squah-confluent commented on code in PR #20055: URL: https://github.com/apache/kafka/pull/20055#discussion_r2200292220 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/modern/consumer/CurrentAssignmentBuilder.java: ## @@ -151,14 +210,18 @@ public ConsumerGro

Re: [PR] KAFKA-19431: Ensure consumer and share assignment consistency with subscriptions [kafka]

2025-07-11 Thread via GitHub
squah-confluent commented on code in PR #20055: URL: https://github.com/apache/kafka/pull/20055#discussion_r2200278950 ## jmh-benchmarks/src/main/java/org/apache/kafka/jmh/assignor/CurrentAssignmentBuilderBenchmark.java: ## @@ -0,0 +1,171 @@ +/* + * Licensed to the Apache Softwa

[PR] MINOR: Moving the rollback out of lock in share partition [kafka]

2025-07-11 Thread via GitHub
apoorvmittal10 opened a new pull request, #20153: URL: https://github.com/apache/kafka/pull/20153 Moving rollback out of lock, if persister returns a completed future for write state then same data-plane-request-handler thread should not call purgatory safeTryAndComplete while holding Share

Re: [PR] KAFKA-19431: Ensure consumer and share assignment consistency with subscriptions [kafka]

2025-07-11 Thread via GitHub
squah-confluent commented on code in PR #20055: URL: https://github.com/apache/kafka/pull/20055#discussion_r2200219203 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java: ## @@ -3463,15 +3488,16 @@ private ConsumerGroupMember maybeRec

Re: [PR] KAFKA-18105 Fix flaky PlaintextAdminIntegrationTest#testElectPreferredLeaders [kafka]

2025-07-11 Thread via GitHub
TaiJuWu commented on code in PR #20068: URL: https://github.com/apache/kafka/pull/20068#discussion_r2200218526 ## core/src/test/scala/integration/kafka/api/PlaintextAdminIntegrationTest.scala: ## @@ -2850,6 +2851,21 @@ class PlaintextAdminIntegrationTest extends BaseAdminIntegr

Re: [PR] KAFKA-19495: update native image config for native images [kafka]

2025-07-11 Thread via GitHub
frankvicky merged PR #20150: URL: https://github.com/apache/kafka/pull/20150 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apac

Re: [PR] KAFKA-19495: update native image config for native images [kafka]

2025-07-11 Thread via GitHub
showuon commented on code in PR #20150: URL: https://github.com/apache/kafka/pull/20150#discussion_r2200188061 ## docker/native/native-image-configs/reflect-config.json: ## @@ -1023,6 +1023,12 @@ "name":"org.apache.kafka.common.security.kerberos.KerberosLogin", "methods":[

Re: [PR] KAFKA-18105 Fix flaky PlaintextAdminIntegrationTest#testElectPreferredLeaders [kafka]

2025-07-11 Thread via GitHub
jim0987795064 commented on code in PR #20068: URL: https://github.com/apache/kafka/pull/20068#discussion_r2200177131 ## core/src/test/scala/integration/kafka/api/PlaintextAdminIntegrationTest.scala: ## @@ -2850,6 +2851,21 @@ class PlaintextAdminIntegrationTest extends BaseAdmin

Re: [PR] KAFKA-19495: update native image config for native images [kafka]

2025-07-11 Thread via GitHub
frankvicky commented on code in PR #20150: URL: https://github.com/apache/kafka/pull/20150#discussion_r2200158960 ## docker/native/native-image-configs/reflect-config.json: ## @@ -1023,6 +1023,12 @@ "name":"org.apache.kafka.common.security.kerberos.KerberosLogin", "methods

[jira] [Assigned] (KAFKA-19495) DefaultJwtRetriever could not be found with Docker native image

2025-07-11 Thread Luke Chen (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19495?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Luke Chen reassigned KAFKA-19495: - Assignee: Luke Chen > DefaultJwtRetriever could not be found with Docker native image > ---

[jira] [Commented] (KAFKA-19495) DefaultJwtRetriever could not be found with Docker native image

2025-07-11 Thread Luke Chen (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19495?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18004644#comment-18004644 ] Luke Chen commented on KAFKA-19495: --- PR: [https://github.com/apache/kafka/pull/20150]

Re: [PR] MINOR: Cleanup Connect Module (2/n) [kafka]

2025-07-11 Thread via GitHub
sjhajharia commented on PR #19871: URL: https://github.com/apache/kafka/pull/19871#issuecomment-3061304994 Hey @chia7712 @frankvicky Given that you both reviewed the first PR in this series, could you pls take a look at this one too if possible. Thanks in advance! -- This is an aut

Re: [PR] KAFKA-19493: Incorrect rate metric with larger window size [kafka]

2025-07-11 Thread via GitHub
DL1231 commented on code in PR #20152: URL: https://github.com/apache/kafka/pull/20152#discussion_r2200095433 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/AbstractCoordinator.java: ## @@ -1407,7 +1408,8 @@ public GroupCoordinatorMetrics(Metrics metrics, S

Re: [PR] KAFKA-19431: Ensure consumer and share assignment consistency with subscriptions [kafka]

2025-07-11 Thread via GitHub
lucasbru commented on code in PR #20055: URL: https://github.com/apache/kafka/pull/20055#discussion_r2200084635 ## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/modern/consumer/CurrentAssignmentBuilder.java: ## @@ -151,14 +210,18 @@ public ConsumerGroupMembe

[PR] KAFKA-19493: Incorrect rate metric with larger window size [kafka]

2025-07-11 Thread via GitHub
DL1231 opened a new pull request, #20152: URL: https://github.com/apache/kafka/pull/20152 Currently, it appears that the small sampling window size is causing distortion in metrics with larger time windows. The default configuration samples two windows, each 30 seconds long. If rebalance

[PR] MINOR: update native image config for native images (v4.1.0) [kafka]

2025-07-11 Thread via GitHub
showuon opened a new pull request, #20151: URL: https://github.com/apache/kafka/pull/20151 The same change for v4.1.0 as this [PR](https://github.com/apache/kafka/pull/20150). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub a

[PR] MINOR: update native image config for native images [kafka]

2025-07-11 Thread via GitHub
showuon opened a new pull request, #20150: URL: https://github.com/apache/kafka/pull/20150 We failed the native image build and test workflow [here](https://github.com/apache/kafka/actions/runs/16211393417/job/45772104969). The failed messages are: ``` Exception in thread "main" java.

Re: [PR] KAFKA-19441: encapsulate MetadataImage in GroupCoordinator/ShareCoordinator [kafka]

2025-07-11 Thread via GitHub
zzbennett commented on code in PR #20061: URL: https://github.com/apache/kafka/pull/20061#discussion_r2200053645 ## coordinator-common/src/main/java/org/apache/kafka/coordinator/common/runtime/CoordinatorRuntime.java: ## @@ -2474,37 +2472,37 @@ public void scheduleUnloadOperatio

Re: [PR] KAFKA-19395 - Updated Junit and mockito version and license information in NOTICE-binary for Jakarta RESTful Web Services Project [kafka]

2025-07-11 Thread via GitHub
kapoorpalak21999 commented on code in PR #19943: URL: https://github.com/apache/kafka/pull/19943#discussion_r2200028139 ## NOTICE-binary: ## @@ -248,14 +248,14 @@ javaee-api (7.0) * License: Apache-2.0 AND W3C -JUnit (4.11) +JUnit (5.10.2) -* License: Common Public Licens

[jira] [Resolved] (KAFKA-19494) Undeprecate JoinGroup V0 & V1 in 3.x

2025-07-11 Thread Ismael Juma (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-19494?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ismael Juma resolved KAFKA-19494. - Resolution: Fixed > Undeprecate JoinGroup V0 & V1 in 3.x >

Re: [PR] KAFKA-19494: Undeprecate JoinGroup V0 & V1 [kafka]

2025-07-11 Thread via GitHub
ijuma merged PR #20142: URL: https://github.com/apache/kafka/pull/20142 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.or

Re: [PR] KAFKA-19441: encapsulate MetadataImage in GroupCoordinator/ShareCoordinator [kafka]

2025-07-11 Thread via GitHub
TaiJuWu commented on code in PR #20061: URL: https://github.com/apache/kafka/pull/20061#discussion_r2199874395 ## coordinator-common/src/main/java/org/apache/kafka/coordinator/common/runtime/KRaftCoordinatorMetadataDelta.java: ## @@ -0,0 +1,82 @@ +/* + * Licensed to the Apache S

[jira] [Commented] (KAFKA-12512) Pass client listener and security protocol to KafkaClusterTestKit

2025-07-11 Thread Ksolves India Limited (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12512?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18004627#comment-18004627 ] Ksolves India Limited commented on KAFKA-12512: --- Hi [~mumrah] as updated b

[jira] [Commented] (KAFKA-12243) Add toString methods to some of the classes introduced by this Epic

2025-07-11 Thread Ksolves India Limited (Jira)
[ https://issues.apache.org/jira/browse/KAFKA-12243?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18004623#comment-18004623 ] Ksolves India Limited commented on KAFKA-12243: --- Hi [~jsancio] Can you ple