[GitHub] [kafka] showuon commented on a diff in pull request #12748: KAFKA-13715: add generationId field in subscription

showuon commented on code in PR #12748: URL: https://github.com/apache/kafka/pull/12748#discussion_r1035600480 ## clients/src/test/java/org/apache/kafka/clients/consumer/CooperativeStickyAssignorTest.java: ## @@ -44,14 +46,26 @@ public AbstractStickyAssignor createAssignor() {

[GitHub] [kafka] showuon commented on a diff in pull request #12748: KAFKA-13715: add generationId field in subscription

showuon commented on code in PR #12748: URL: https://github.com/apache/kafka/pull/12748#discussion_r1035599539 ## clients/src/test/java/org/apache/kafka/clients/consumer/CooperativeStickyAssignorTest.java: ## @@ -116,6 +130,74 @@ public void

[GitHub] [kafka] showuon commented on a diff in pull request #12748: KAFKA-13715: add generationId field in subscription

showuon commented on code in PR #12748: URL: https://github.com/apache/kafka/pull/12748#discussion_r1035599008 ## clients/src/test/java/org/apache/kafka/clients/consumer/StickyAssignorTest.java: ## @@ -272,6 +284,73 @@ public void testSchemaBackwardCompatibility() {

[GitHub] [kafka] showuon commented on a diff in pull request #12748: KAFKA-13715: add generationId field in subscription

showuon commented on code in PR #12748: URL: https://github.com/apache/kafka/pull/12748#discussion_r1035598812 ## clients/src/test/java/org/apache/kafka/clients/consumer/StickyAssignorTest.java: ## @@ -272,6 +284,73 @@ public void testSchemaBackwardCompatibility() {

[GitHub] [kafka] showuon commented on a diff in pull request #12748: KAFKA-13715: add generationId field in subscription

showuon commented on code in PR #12748: URL: https://github.com/apache/kafka/pull/12748#discussion_r1035598601 ## clients/src/test/java/org/apache/kafka/clients/consumer/StickyAssignorTest.java: ## @@ -272,6 +284,73 @@ public void testSchemaBackwardCompatibility() {

[GitHub] [kafka] showuon commented on a diff in pull request #12748: KAFKA-13715: add generationId field in subscription

showuon commented on code in PR #12748: URL: https://github.com/apache/kafka/pull/12748#discussion_r1035598438 ## clients/src/test/java/org/apache/kafka/clients/consumer/StickyAssignorTest.java: ## @@ -272,6 +284,73 @@ public void testSchemaBackwardCompatibility() {

[GitHub] [kafka] showuon commented on a diff in pull request #12748: KAFKA-13715: add generationId field in subscription

showuon commented on code in PR #12748: URL: https://github.com/apache/kafka/pull/12748#discussion_r1034454065 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/AbstractStickyAssignor.java: ## @@ -162,6 +162,28 @@ private boolean allSubscriptionsEqual(Set

[GitHub] [kafka] showuon commented on a diff in pull request #12748: KAFKA-13715: add generationId field in subscription

showuon commented on code in PR #12748: URL: https://github.com/apache/kafka/pull/12748#discussion_r1034452624 ## clients/src/main/java/org/apache/kafka/clients/consumer/StickyAssignor.java: ## @@ -216,6 +216,8 @@ public ByteBuffer subscriptionUserData(Set topics) {

[GitHub] [kafka] showuon commented on a diff in pull request #12748: KAFKA-13715: add generationId field in subscription

showuon commented on code in PR #12748: URL: https://github.com/apache/kafka/pull/12748#discussion_r1034451061 ## clients/src/main/java/org/apache/kafka/clients/consumer/CooperativeStickyAssignor.java: ## @@ -84,6 +84,11 @@ public ByteBuffer subscriptionUserData(Set topics) {

[GitHub] [kafka] showuon commented on a diff in pull request #12748: KAFKA-13715: add generationId field in subscription

showuon commented on code in PR #12748: URL: https://github.com/apache/kafka/pull/12748#discussion_r1032023101 ## clients/src/test/java/org/apache/kafka/clients/consumer/CooperativeStickyAssignorTest.java: ## @@ -44,14 +46,26 @@ public AbstractStickyAssignor createAssignor() {

[GitHub] [kafka] showuon commented on a diff in pull request #12748: KAFKA-13715: add generationId field in subscription

showuon commented on code in PR #12748: URL: https://github.com/apache/kafka/pull/12748#discussion_r1024795520 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/AbstractStickyAssignor.java: ## @@ -162,6 +162,17 @@ private boolean allSubscriptionsEqual(Set

[GitHub] [kafka] showuon commented on a diff in pull request #12748: KAFKA-13715: add generationId field in subscription

showuon commented on code in PR #12748: URL: https://github.com/apache/kafka/pull/12748#discussion_r1024795520 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/AbstractStickyAssignor.java: ## @@ -162,6 +162,17 @@ private boolean allSubscriptionsEqual(Set

[GitHub] [kafka] showuon commented on a diff in pull request #12748: KAFKA-13715: add generationId field in subscription

showuon commented on code in PR #12748: URL: https://github.com/apache/kafka/pull/12748#discussion_r1024726967 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/AbstractStickyAssignor.java: ## @@ -162,6 +162,17 @@ private boolean allSubscriptionsEqual(Set

[GitHub] [kafka] showuon commented on a diff in pull request #12748: KAFKA-13715: add generationId field in subscription

showuon commented on code in PR #12748: URL: https://github.com/apache/kafka/pull/12748#discussion_r1018917087 ## clients/src/test/java/org/apache/kafka/clients/consumer/internals/AbstractStickyAssignorTest.java: ## @@ -55,12 +60,22 @@ public abstract class

[GitHub] [kafka] showuon commented on a diff in pull request #12748: KAFKA-13715: add generationId field in subscription

showuon commented on code in PR #12748: URL: https://github.com/apache/kafka/pull/12748#discussion_r1018909824 ## clients/src/test/java/org/apache/kafka/clients/consumer/CooperativeStickyAssignorTest.java: ## @@ -78,6 +80,26 @@ public void testDecodeGeneration() {

[GitHub] [kafka] showuon commented on a diff in pull request #12748: KAFKA-13715: add generationId field in subscription

showuon commented on code in PR #12748: URL: https://github.com/apache/kafka/pull/12748#discussion_r1018908171 ## clients/src/test/java/org/apache/kafka/clients/consumer/CooperativeStickyAssignorTest.java: ## @@ -78,6 +80,26 @@ public void testDecodeGeneration() {

[GitHub] [kafka] showuon commented on a diff in pull request #12748: KAFKA-13715: add generationId field in subscription

showuon commented on code in PR #12748: URL: https://github.com/apache/kafka/pull/12748#discussion_r1018907375 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/AbstractStickyAssignor.java: ## @@ -1229,4 +1247,23 @@ private boolean in(Set pairs) {

[GitHub] [kafka] showuon commented on a diff in pull request #12748: KAFKA-13715: add generationId field in subscription

showuon commented on code in PR #12748: URL: https://github.com/apache/kafka/pull/12748#discussion_r1017442642 ## clients/src/test/java/org/apache/kafka/clients/consumer/CooperativeStickyAssignorTest.java: ## @@ -78,6 +80,26 @@ public void testDecodeGeneration() {

[GitHub] [kafka] showuon commented on a diff in pull request #12748: KAFKA-13715: add generationId field in subscription

showuon commented on code in PR #12748: URL: https://github.com/apache/kafka/pull/12748#discussion_r1017395682 ## clients/src/test/java/org/apache/kafka/clients/consumer/internals/ConsumerProtocolTest.java: ## @@ -146,43 +165,22 @@ public void

[GitHub] [kafka] showuon commented on a diff in pull request #12748: KAFKA-13715: add generationId field in subscription

showuon commented on code in PR #12748: URL: https://github.com/apache/kafka/pull/12748#discussion_r1017395458 ## clients/src/test/java/org/apache/kafka/clients/consumer/internals/ConsumerProtocolTest.java: ## @@ -247,4 +245,42 @@ public void

[GitHub] [kafka] showuon commented on a diff in pull request #12748: KAFKA-13715: add generationId field in subscription

showuon commented on code in PR #12748: URL: https://github.com/apache/kafka/pull/12748#discussion_r1017394471 ## clients/src/test/java/org/apache/kafka/clients/consumer/CooperativeStickyAssignorTest.java: ## @@ -78,6 +80,26 @@ public void testDecodeGeneration() {

[GitHub] [kafka] showuon commented on a diff in pull request #12748: KAFKA-13715: add generationId field in subscription

showuon commented on code in PR #12748: URL: https://github.com/apache/kafka/pull/12748#discussion_r1015224638 ## clients/src/main/java/org/apache/kafka/clients/consumer/internals/AbstractStickyAssignor.java: ## @@ -117,30 +117,41 @@ private boolean allSubscriptionsEqual(Set

[GitHub] [kafka] showuon commented on a diff in pull request #12748: KAFKA-13715: add generationId field in subscription

showuon commented on code in PR #12748: URL: https://github.com/apache/kafka/pull/12748#discussion_r1015096016 ## clients/src/main/java/org/apache/kafka/clients/consumer/ConsumerPartitionAssignor.java: ## @@ -102,20 +104,26 @@ final class Subscription { private final