mlaurent added a comment.
I fixed 2 repos.
Otherwise all compiles fine (ok I don't test on windows/mac and perhaps some
module is not compiles on my computer)
REPOSITORY
R240 Extra CMake Modules
REVISION DETAIL
https://phabricator.kde.org/D15566
To: mlaurent, dfaure
Cc:
mlaurent created this revision.
Herald added projects: Frameworks, Build System.
Herald added subscribers: kde-buildsystem, kde-frameworks-devel.
mlaurent requested review of this revision.
REVISION SUMMARY
Use QT_NO_NARROWING_CONVERSIONS_IN_CONNECT as default flags
REPOSITORY
R240 Extra
mlaurent added a reviewer: dfaure.
REPOSITORY
R240 Extra CMake Modules
REVISION DETAIL
https://phabricator.kde.org/D15566
To: mlaurent, dfaure
Cc: kde-frameworks-devel, kde-buildsystem, michaelh, ngraham, bruns
mlaurent accepted this revision.
REPOSITORY
R304 KNewStuff
REVISION DETAIL
https://phabricator.kde.org/D6513
To: leinir, #knewstuff, apol, #kde_store, whiting, ahiemstra, mlaurent, dfaure,
cfeck
Cc: dfaure, cfeck, mlaurent, ngraham, ahiemstra, kde-frameworks-devel,
#knewstuff, michaelh,
mlaurent added a comment.
done.
REPOSITORY
R293 Baloo
BRANCH
bug397843 (branched from master)
REVISION DETAIL
https://phabricator.kde.org/D15136
To: ssloan, mlaurent
Cc: mlaurent, kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich,
spoorun, ngraham, bruns, abrahams
mlaurent closed this revision.
REPOSITORY
R293 Baloo
REVISION DETAIL
https://phabricator.kde.org/D15136
To: ssloan, mlaurent
Cc: mlaurent, kde-frameworks-devel, #baloo, ashaposhnikov, michaelh, astippich,
spoorun, ngraham, bruns, abrahams
mlaurent added a comment.
I will commit for you. what is your email address ?
REPOSITORY
R293 Baloo
BRANCH
bug397843 (branched from master)
REVISION DETAIL
https://phabricator.kde.org/D15136
To: ssloan, mlaurent
Cc: mlaurent, kde-frameworks-devel, #baloo, ashaposhnikov, michaelh,
mlaurent accepted this revision.
mlaurent added a comment.
This revision is now accepted and ready to land.
Thanks
can you commit it ? Do you have commit access ?
REPOSITORY
R293 Baloo
BRANCH
bug397843 (branched from master)
REVISION DETAIL
https://phabricator.kde.org/D15136
To:
mlaurent accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R236 KWidgetsAddons
REVISION DETAIL
https://phabricator.kde.org/D14435
To: glennw, cfeck, mlaurent
Cc: ngraham, kde-frameworks-devel, michaelh, bruns
mlaurent requested changes to this revision.
mlaurent added a comment.
This revision now requires changes to proceed.
For me it's ok after using QVERIFY...
INLINE COMMENTS
> ktimecomboboxtest.cpp:198
> +QString mask = m_combo->lineEdit()->inputMask();
> +
mlaurent requested changes to this revision.
mlaurent added inline comments.
This revision now requires changes to proceed.
INLINE COMMENTS
> ktimecomboboxtest.cpp:198
> +QString mask = m_combo->lineEdit()->inputMask();
> +QCOMPARE(mask.contains(QLatin1String("aa")), true);
> +delete
mlaurent accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R246 Sonnet
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D14447
To: dfaure, sandsmark, mlaurent
Cc: kde-frameworks-devel, #kde_pim, michaelh, ngraham, bruns
mlaurent requested changes to this revision.
mlaurent added a comment.
This revision now requires changes to proceed.
could you provide an autotest for it please ?
(see autotest/ktimecomboboxtest.cpp)
Thanks
REPOSITORY
R236 KWidgetsAddons
REVISION DETAIL
mlaurent requested changes to this revision.
mlaurent added inline comments.
This revision now requires changes to proceed.
INLINE COMMENTS
> entryinternal.cpp:495
> if (reader.name() != QLatin1String("stuff")) {
> -qWarning() << "Parsing Entry from invalid XML";
> +
mlaurent requested changes to this revision.
mlaurent added a comment.
This revision now requires changes to proceed.
Please change commit title "Add" by a commit title which explains what your
commit will do.
thanks
REPOSITORY
R175 PIM: KHolidays
REVISION DETAIL
mlaurent accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R252 Framework Integration
REVISION DETAIL
https://phabricator.kde.org/D13987
To: arojas, afiestas, dfaure, mlaurent
Cc: kde-frameworks-devel, michaelh, ngraham, bruns
mlaurent accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R307 KPeople
REVISION DETAIL
https://phabricator.kde.org/D13989
To: arojas, apol, mlaurent
Cc: kde-frameworks-devel, michaelh, ngraham, bruns
mlaurent accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R301 KEmoticons
REVISION DETAIL
https://phabricator.kde.org/D13986
To: arojas, dfaure, mlaurent
Cc: kde-frameworks-devel, michaelh, ngraham, bruns
mlaurent accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R312 KXmlRpcClient
REVISION DETAIL
https://phabricator.kde.org/D13991
To: arojas, dvratil, mlaurent
Cc: kde-frameworks-devel, michaelh, ngraham, bruns
mlaurent accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R495 Purpose Library
REVISION DETAIL
https://phabricator.kde.org/D13992
To: arojas, apol, mlaurent
Cc: kde-frameworks-devel, michaelh, ngraham, bruns
mlaurent accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R290 KPackage
REVISION DETAIL
https://phabricator.kde.org/D13972
To: arojas, mart, mlaurent
Cc: kde-frameworks-devel, michaelh, ngraham, bruns
mlaurent accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R277 KPlotting
REVISION DETAIL
https://phabricator.kde.org/D13974
To: arojas, cfeck, mlaurent
Cc: kde-frameworks-devel, michaelh, ngraham, bruns
mlaurent accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R310 KTextWidgets
REVISION DETAIL
https://phabricator.kde.org/D13958
To: arojas, dfaure, mlaurent
Cc: kde-frameworks-devel, michaelh, ngraham, bruns
mlaurent accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R237 KConfig
BRANCH
ref_upd (branched from master)
REVISION DETAIL
https://phabricator.kde.org/D12892
To: maximilianocuria, #frameworks, mlaurent
Cc: kde-frameworks-devel, michaelh, ngraham,
mlaurent added inline comments.
INLINE COMMENTS
> hunspelldict.cpp:104
> delete m_speller;
> +if (m_tempDir) {
> +delete m_tempDir;
not necessary to check pointer here.
REPOSITORY
R246 Sonnet
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D12283
To:
mlaurent accepted this revision.
mlaurent added a comment.
This revision is now accepted and ready to land.
Remove indent and commit it :)
Thanks
INLINE COMMENTS
> hunspellclient.cpp:104
> +}
> +return QString();
> +}
fix indent
REPOSITORY
R246 Sonnet
BRANCH
master
mlaurent accepted this revision.
mlaurent added a comment.
This revision is now accepted and ready to land.
Thanks :)
REPOSITORY
R246 Sonnet
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D12282
To: vonreth, mlaurent
Cc: #frameworks, michaelh, ngraham, bruns
mlaurent accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R293 Baloo
BRANCH
sanitize-cmd (branched from master)
REVISION DETAIL
https://phabricator.kde.org/D11287
To: michaelh, #baloo, #frameworks, mlaurent
Cc: mlaurent, ngraham, ashaposhnikov,
mlaurent added inline comments.
INLINE COMMENTS
> michaelh wrote in CMakeLists.txt:16
> @mlaurent Is it worth the effort to change this for the other cli tools
> accordingly?
It's the default variable.
But don't chnage it in this patch.
Perhaps in the future as you are the baloo maintainer :)
mlaurent requested changes to this revision.
mlaurent added inline comments.
This revision now requires changes to proceed.
INLINE COMMENTS
> CMakeLists.txt:16
> +
> +install(TARGETS baloodb DESTINATION ${BIN_INSTALL_DIR})
install(TARGETS baloodb ${KDE_INSTALL_TARGETS_DEFAULT_ARGS})
>
mlaurent requested changes to this revision.
mlaurent added inline comments.
This revision now requires changes to proceed.
INLINE COMMENTS
> main.cpp:103
> +QStringLiteral("devices"),
> +i18n("List devices "),
> +QStringList{},
extra space at the end of i18n
>
mlaurent accepted this revision.
mlaurent added a comment.
This revision is now accepted and ready to land.
+2 for me but I don't know baloo code :)
REPOSITORY
R293 Baloo
BRANCH
sanitize-class (branched from master)
REVISION DETAIL
https://phabricator.kde.org/D11285
To: michaelh,
mlaurent requested changes to this revision.
mlaurent added inline comments.
This revision now requires changes to proceed.
INLINE COMMENTS
> databasesanitizer.cpp:46
> +public:
> +FileInfo(const quint32 d = 0, const quint32 i = 0,
> +const QString& u = QString(),
mlaurent requested changes to this revision.
mlaurent added inline comments.
This revision now requires changes to proceed.
INLINE COMMENTS
> databasesanitizer.cpp:44
> +struct FileInfo {
> +quint32 deviceId;
> +quint32 inode;
initialize value by default please
>
mlaurent added a comment.
Is it possible to create an autotest for this class ?
REPOSITORY
R293 Baloo
REVISION DETAIL
https://phabricator.kde.org/D11285
To: michaelh, #baloo, #frameworks, ngraham, mlaurent
Cc: mlaurent, ngraham, smithjd, ashaposhnikov, michaelh, spoorun, nicolasfella,
mlaurent accepted this revision.
mlaurent added a comment.
This revision is now accepted and ready to land.
Seems good for me
REPOSITORY
R246 Sonnet
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D10744
To: vonreth, mlaurent, dfaure, leinir
Cc: #frameworks, michaelh
mlaurent abandoned this revision.
REPOSITORY
R240 Extra CMake Modules
REVISION DETAIL
https://phabricator.kde.org/D9446
To: mlaurent, kfunk, lbeltrame, cgiboudeaux, dfaure, fvogt
Cc: #frameworks, #build_system, michaelh, ngraham
mlaurent requested changes to this revision.
mlaurent added inline comments.
This revision now requires changes to proceed.
INLINE COMMENTS
> kpluginfactory.h:211
> + */
> +#define K_PLUGIN_CLASS_WITH_JSON(classname, jsonFile)
> K_PLUGIN_FACTORY_WITH_JSON(classname ## Factory, json,
>
mlaurent accepted this revision.
mlaurent added inline comments.
This revision is now accepted and ready to land.
INLINE COMMENTS
> CMakeLists.txt:8
> set(CMAKE_MODULE_PATH ${ECM_MODULE_PATH})
> +set(CMAKE_AUTORCC ON)
>
Just curious it's not default in ECM ? I never used it.
REPOSITORY
mlaurent added a comment.
I made a fix. I wait a rebuild on windows to see if it's ok
REPOSITORY
R244 KCoreAddons
REVISION DETAIL
https://phabricator.kde.org/D9420
To: velurimithun, mlaurent
Cc: bcooksley, dfaure, #frameworks
mlaurent accepted this revision.
mlaurent added a comment.
This revision is now accepted and ready to land.
Thanks
REPOSITORY
R244 KCoreAddons
BRANCH
complieWithoutRemoveDef
REVISION DETAIL
https://phabricator.kde.org/D9420
To: velurimithun, mlaurent
Cc: dfaure, #frameworks
mlaurent requested changes to this revision.
mlaurent added a comment.
This revision now requires changes to proceed.
You still forgot to launch autotest...
see:
"laurent@linux-5nvn:/compile/kde5/framework/frameworks/kcoreaddons/build>
./bin/kaboutdatatest
- Start testing of
mlaurent added a comment.
Ping bis ?:)
REPOSITORY
R244 KCoreAddons
REVISION DETAIL
https://phabricator.kde.org/D9420
To: velurimithun, mlaurent
Cc: dfaure, #frameworks
mlaurent accepted this revision.
REPOSITORY
R236 KWidgetsAddons
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D8908
To: dfaure, cfeck, dvratil, mlaurent
Cc: mlaurent, anthonyfieroni, #frameworks, #kde_pim
mlaurent added a comment.
Ping ?
REPOSITORY
R244 KCoreAddons
REVISION DETAIL
https://phabricator.kde.org/D9420
To: velurimithun, mlaurent
Cc: dfaure, #frameworks
mlaurent accepted this revision.
mlaurent added a comment.
This revision is now accepted and ready to land.
Otherwise all is good. +2 with the QVERIFY(...)
INLINE COMMENTS
> kdatecomboboxtest.cpp:182
> +combo->activateWindow();
> +QTest::qWaitForWindowActive(combo.data());
> +
mlaurent accepted this revision.
mlaurent added a comment.
This revision is now accepted and ready to land.
indeed good catch
REPOSITORY
R236 KWidgetsAddons
REVISION DETAIL
https://phabricator.kde.org/D9884
To: sars, #frameworks, mlaurent
mlaurent added a comment.
Ok I understand why you don't have this problem you need to rebase patch with
last kcoreaddons version.
So code was added.
Please rebase, make sure that it builds and upload patch.
Regards.
REPOSITORY
R244 KCoreAddons
REVISION DETAIL
mlaurent requested changes to this revision.
mlaurent added a comment.
This revision now requires changes to proceed.
When I try to compile your patch I have this compile error:
Do you are sure that you rebuild all ?
mlaurent added a comment.
indeed code will be broken if we don't use QString::fromUtf8.
Could you fix it please ?
REPOSITORY
R244 KCoreAddons
REVISION DETAIL
https://phabricator.kde.org/D9420
To: velurimithun, mlaurent
Cc: dfaure, #frameworks
mlaurent accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R39 KTextEditor
BRANCH
UseOverride (branched from master)
REVISION DETAIL
https://phabricator.kde.org/D9571
To: dhaumann, kfunk, mlaurent
Cc: #frameworks, kevinapavew, ngraham, demsking,
mlaurent added inline comments.
INLINE COMMENTS
> kprocesstest.cpp:47
> p.setProcessChannelMode(QProcess::MergedChannels);
> -p.start(gargv[0], QStringList() << QString::number(how) <<
> QStringLiteral("--nocrashhandler"));
> +p.start(QString::fromLatin1(gargv[0]), QStringList() <<
mlaurent added a comment.
no news ?
REPOSITORY
R244 KCoreAddons
REVISION DETAIL
https://phabricator.kde.org/D9420
To: velurimithun, mlaurent
Cc: #frameworks
mlaurent added a comment.
You still missing all patch...
Please use arc diff so we are sure that all patch is updated.
REPOSITORY
R244 KCoreAddons
REVISION DETAIL
https://phabricator.kde.org/D9420
To: velurimithun, mlaurent
Cc: #frameworks
mlaurent added reviewers: kfunk, lbeltrame, cgiboudeaux, dfaure.
REPOSITORY
R240 Extra CMake Modules
REVISION DETAIL
https://phabricator.kde.org/D9446
To: mlaurent, kfunk, lbeltrame, cgiboudeaux, dfaure
Cc: #frameworks, #build_system
mlaurent added a comment.
IT's a WIP as I use file(APPEND...) because I want to generate several
categories in one file.
But it doesn't work as I don't have idea how to reset file when cmake is
started...
Do you have an idea ?
I will implement autotest and co if we have a
mlaurent created this revision.
Restricted Application added projects: Frameworks, Build System.
Restricted Application added subscribers: Build System, Frameworks.
TEST PLAN
Generate kmail categories file
REPOSITORY
R240 Extra CMake Modules
BRANCH
autogenerate_categories_file
REVISION
mlaurent added inline comments.
INLINE COMMENTS
> velurimithun wrote in kprocesstest.cpp:93
> These strings are going as arguments for QStringList() method that why I used
> QString::FromLatin1()
?
QStringLiteral works fine with QStringList
REPOSITORY
R244 KCoreAddons
REVISION DETAIL
mlaurent added inline comments.
INLINE COMMENTS
> desktoptojsontest.cpp:84
> QByteArray input =
> -// include an insignificant group
> -"[Some Group]\n"
> -"Foo=Bar\n"
> -"\n"
> -"[Desktop Entry]\n"
> -// only data
mlaurent added a comment.
Missing all patch... please see
"https://community.kde.org/Infrastructure/Phabricator;
"Step 2: Updating your diff.
After you upload the code the reviewer will take a look and give you some
comments. If you get a thumbs up, you can skip this step. But
mlaurent requested changes to this revision.
mlaurent added inline comments.
This revision now requires changes to proceed.
INLINE COMMENTS
> kaboutdatatest.cpp:48
>
> -static const char AppName[] ="app";
> -static const char ProgramName[] ="ProgramName";
> -static const
mlaurent added a comment.
Arguiment from method use QString and not QLatin1String()
QString::fromLatin1 returns a QString
REPOSITORY
R244 KCoreAddons
REVISION DETAIL
https://phabricator.kde.org/D9420
To: velurimithun, mlaurent
Cc: #frameworks
mlaurent added a comment.
KAboutData aboutData2(QString::fromLatin1(AppName2),
QString::fromLatin1(ProgramName2), QString::fromLatin1(Version2));
use QString::fromLatin1 is will work
REPOSITORY
R244 KCoreAddons
REVISION DETAIL
https://phabricator.kde.org/D9420
To: velurimithun,
mlaurent requested changes to this revision.
This revision now requires changes to proceed.
REPOSITORY
R244 KCoreAddons
REVISION DETAIL
https://phabricator.kde.org/D9420
To: velurimithun, mlaurent
Cc: #frameworks
mlaurent added a comment.
Could you paste you compile error here please.
INLINE COMMENTS
> CMakeLists.txt:1
> -remove_definitions(-DQT_NO_CAST_FROM_ASCII)
> +#remove_definitions(-DQT_NO_CAST_FROM_ASCII)
>
Better to remove it.
REPOSITORY
R244 KCoreAddons
REVISION DETAIL
mlaurent added a comment.
Not commited ?
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D9332
To: renatoo, mwolff, mlaurent
Cc: mlaurent, aacid, ngraham, #frameworks
Le vendredi 15 décembre 2017, 18:47:40 CET Ben Cooksley a écrit :
> On Fri, Dec 15, 2017 at 7:41 PM, laurent Montel <mon...@kde.org> wrote:
> > Le vendredi 15 décembre 2017, 03:38:32 CET Ben Cooksley a écrit :
> >> Hi Laurent, all,
> >
> > Hi,
> > In
mlaurent accepted this revision.
This revision is now accepted and ready to land.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D9332
To: renatoo, mwolff, mlaurent
Cc: mlaurent, aacid, ngraham, #frameworks
0eff57fef375
>
> Can someone please fix this?
>
> At the moment it's breaking the build of various components which
> depend on KHTML and as a consequence has left the CI system in an
> inconsistent state. At this time both Applications and Plasma have
> been negatively impacted b
mlaurent abandoned this revision.
mlaurent added a comment.
commited in kcoreaddons
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D9330
To: mlaurent, dfaure
Cc: kossebau, flherne, #frameworks
This revision was automatically updated to reflect the committed changes.
Closed by commit R244:fbc5881b916c: Remove cmake 3.10+ warning for users of
K_PLUGIN_FACTORY and… (authored by mlaurent).
REPOSITORY
R244 KCoreAddons
CHANGES SINCE LAST UPDATE
mlaurent added inline comments.
INLINE COMMENTS
> kfileplacesmodel.h:72
> +* @param parent Parent object
> +* @since 5.41
> +*/
5.42 and missing //kf6 comment
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D9332
To: renatoo, mwolff, mlaurent
Cc: mlaurent,
mlaurent retitled this revision from "Remove cmake warning" to "Remove cmake
3.10+ warning for users of K_PLUGIN_FACTORY and K_PLUGIN_FACTORY_WITH_JSON".
REPOSITORY
R244 KCoreAddons
REVISION DETAIL
https://phabricator.kde.org/D9334
To: mlaurent, dfaure
Cc: #frameworks
mlaurent updated this revision to Diff 23928.
mlaurent added a comment.
- Remove line which made no sense in this module
REPOSITORY
R244 KCoreAddons
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D9334?vs=23923=23928
BRANCH
remove_cmake_warning
REVISION DETAIL
mlaurent requested changes to this revision.
mlaurent added inline comments.
This revision now requires changes to proceed.
INLINE COMMENTS
> kfileplacesmodeltest.cpp:1276
> +// create a new entry with alternative application name
> +KBookmark bookmark =
mlaurent added a reviewer: dfaure.
REPOSITORY
R244 KCoreAddons
REVISION DETAIL
https://phabricator.kde.org/D9334
To: mlaurent, dfaure
Cc: #frameworks
mlaurent created this revision.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
TEST PLAN
compile kio without warning
REPOSITORY
R244 KCoreAddons
BRANCH
remove_cmake_warning
REVISION DETAIL
https://phabricator.kde.org/D9334
mlaurent added a comment.
ok see https://phabricator.kde.org/D9334
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D9330
To: mlaurent, dfaure
Cc: kossebau, flherne, #frameworks
This revision was automatically updated to reflect the committed changes.
Closed by commit R241:5a6ce6d48c29: Remove duplicate lines. (authored by
mlaurent).
REPOSITORY
R241 KIO
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D9327?vs=23909=23918
REVISION DETAIL
This revision was automatically updated to reflect the committed changes.
Closed by commit R241:41fbb247d97c: Implement a kfile dialog where we can add
custom widget (authored by mlaurent).
REPOSITORY
R241 KIO
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D9206?vs=23916=23917
mlaurent updated this revision to Diff 23916.
mlaurent added a comment.
- Remove indirection methods as requested by David. Fix doc too
REPOSITORY
R241 KIO
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D9206?vs=23908=23916
BRANCH
add_kfile_dialog
REVISION DETAIL
mlaurent marked 2 inline comments as done.
REPOSITORY
R241 KIO
BRANCH
add_kfile_dialog
REVISION DETAIL
https://phabricator.kde.org/D9206
To: mlaurent, mwolff, dfaure
Cc: #frameworks
mlaurent added a comment.
Ok I can move it to ecm (mais in which file ?)
"kde-modules/KDECMakeSettings.cmake" ?
and it depends if apps have some specific macro for example in kmail we have
"EXPORT_KONTACT_PLUGIN" too
REPOSITORY
R241 KIO
REVISION DETAIL
This revision was automatically updated to reflect the committed changes.
Closed by commit R241:c0e239446b64: Verify that qWaitForWindowActive
doesnt fail (authored by mlaurent).
REPOSITORY
R241 KIO
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D9329?vs=23911=23915
REVISION DETAIL
mlaurent created this revision.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
TEST PLAN
build
REPOSITORY
R241 KIO
BRANCH
fix_cmake_warning
REVISION DETAIL
https://phabricator.kde.org/D9330
AFFECTED FILES
CMakeLists.txt
mlaurent added a reviewer: dfaure.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D9330
To: mlaurent, dfaure
Cc: #frameworks
mlaurent added a reviewer: dfaure.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D9329
To: mlaurent, dfaure
Cc: #frameworks
mlaurent created this revision.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
TEST PLAN
compile
REPOSITORY
R241 KIO
BRANCH
verify_return_value_qWaitForWindowActive
REVISION DETAIL
https://phabricator.kde.org/D9329
AFFECTED
mlaurent added a reviewer: dfaure.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D9327
To: mlaurent, dfaure
Cc: #frameworks
mlaurent created this revision.
Restricted Application added a project: Frameworks.
Restricted Application added a subscriber: Frameworks.
TEST PLAN
build/execute test apps
REPOSITORY
R241 KIO
BRANCH
remove_duplicate_tab_order
REVISION DETAIL
https://phabricator.kde.org/D9327
AFFECTED
mlaurent updated this revision to Diff 23908.
mlaurent added a comment.
- Fix doc, remove unused code, etc.
REPOSITORY
R241 KIO
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D9206?vs=23514=23908
BRANCH
add_kfile_dialog
REVISION DETAIL
https://phabricator.kde.org/D9206
mlaurent marked 7 inline comments as done.
REPOSITORY
R241 KIO
REVISION DETAIL
https://phabricator.kde.org/D9206
To: mlaurent, mwolff, dfaure
Cc: #frameworks
This revision was automatically updated to reflect the committed changes.
Closed by commit R237:962998ad27e9: Remove cmake warning about generating moc
file (authored by mlaurent).
REPOSITORY
R237 KConfig
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D9277?vs=23882=23883
REVISION
mlaurent updated this revision to Diff 23882.
mlaurent added a comment.
- Use set_source_files_properties
REPOSITORY
R237 KConfig
CHANGES SINCE LAST UPDATE
https://phabricator.kde.org/D9277?vs=23716=23882
BRANCH
remove_cmake_warning
REVISION DETAIL
https://phabricator.kde.org/D9277
mlaurent added a comment.
@kfunk what do you think about it ? :)
REPOSITORY
R237 KConfig
REVISION DETAIL
https://phabricator.kde.org/D9277
To: mlaurent, kfunk, dfaure
Cc: mpyne, apol, aacid, #frameworks
mlaurent added a comment.
@dfaure yep I rebuild all qt5.10 so yep :)
REPOSITORY
R237 KConfig
REVISION DETAIL
https://phabricator.kde.org/D9277
To: mlaurent, kfunk, dfaure
Cc: mpyne, apol, aacid, #frameworks
mlaurent added a comment.
@apol do you have cmake >= 3.10 ?
REPOSITORY
R237 KConfig
REVISION DETAIL
https://phabricator.kde.org/D9277
To: mlaurent, kfunk, dfaure
Cc: mpyne, apol, aacid, #frameworks
mlaurent added a comment.
@apol do you have an example of class which generate signal/slot ?
For me ARG_GENERATE_MOC seems to be the case and by default it skips AUTOMOC
REPOSITORY
R237 KConfig
REVISION DETAIL
https://phabricator.kde.org/D9277
To: mlaurent, kfunk, dfaure
Cc: mpyne,
mlaurent added a comment.
it's seems that it was not fixed as I updated my kde last friday afternoon.
and this morning I was this problem.
And if it's fixed we need to remove this 2 lines
So it seems there is still a code to remove.
REPOSITORY
R237 KConfig
REVISION DETAIL
mlaurent added reviewers: kfunk, dfaure.
REPOSITORY
R237 KConfig
REVISION DETAIL
https://phabricator.kde.org/D9277
To: mlaurent, kfunk, dfaure
Cc: #frameworks
501 - 600 of 888 matches
Mail list logo
