Re: [patches] Improve error reporting and log parsing

2015-03-20 Thread Scott Kostyshak
On Wed, Mar 11, 2015 at 3:17 AM, Kornel Benko kor...@lyx.org wrote: Enrico, Georg, Liviu, Kornel: warning/error + PDF OK, looks like this is the most popular. I implemented the warning/error + PDF in cd8be655. I applied the patches sent in this thread with a few minor changes (e.g. I took out

Re: [patches] Improve error reporting and log parsing

2015-03-20 Thread Scott Kostyshak
On Wed, Mar 11, 2015 at 3:17 AM, Kornel Benko wrote: > Enrico, Georg, Liviu, Kornel: warning/error + PDF OK, looks like this is the most popular. I implemented the warning/error + PDF in cd8be655. I applied the patches sent in this thread with a few minor changes (e.g. I took

Re: [patches] Improve error reporting and log parsing

2015-03-11 Thread Kornel Benko
Am Dienstag, 10. März 2015 um 23:54:10, schrieb Scott Kostyshak skost...@lyx.org So far I interpret the following opinions: Enrico, Georg, Liviu: warning/error + PDF Helge: Keep the current behavior (error and no PDF) I do not know if Andrew was supporting a certain behavior or just

Re: [patches] Improve error reporting and log parsing

2015-03-11 Thread Kornel Benko
Am Dienstag, 10. März 2015 um 23:54:10, schrieb Scott Kostyshak > So far I interpret the following opinions: > > Enrico, Georg, Liviu: warning/error + PDF > Helge: Keep the current behavior (error and no PDF) > > I do not know if Andrew was supporting a certain behavior or

Re: [patches] Improve error reporting and log parsing

2015-03-10 Thread Scott Kostyshak
So far I interpret the following opinions: Enrico, Georg, Liviu: warning/error + PDF Helge: Keep the current behavior (error and no PDF) I do not know if Andrew was supporting a certain behavior or just giving his idea of what is currently happening. Does anyone else have an opinion on this? I

Re: [patches] Improve error reporting and log parsing

2015-03-10 Thread Scott Kostyshak
So far I interpret the following opinions: Enrico, Georg, Liviu: warning/error + PDF Helge: Keep the current behavior (error and no PDF) I do not know if Andrew was supporting a certain behavior or just giving his idea of what is currently happening. Does anyone else have an opinion on this? I

Re: [patches] Improve error reporting and log parsing

2015-03-03 Thread Scott Kostyshak
On Mon, Mar 2, 2015 at 8:01 AM, Helge Hafting helge.haft...@hist.no wrote: In my opinion, the current (released) behaviour is fine. LyX do not bring up a PDF when something went wrong. But if you have a viewer open, that viewer might decide on its own to reload the changed pdf from disk. We

Re: [patches] Improve error reporting and log parsing

2015-03-03 Thread Scott Kostyshak
On Mon, Mar 2, 2015 at 8:01 AM, Helge Hafting wrote: > In my opinion, the current (released) behaviour is fine. LyX do not bring up > a PDF when something went wrong. But if you have a viewer open, that viewer > might decide on its own to reload the changed pdf from disk. >

Re: [patches] Improve error reporting and log parsing

2015-03-02 Thread Helge Hafting
Den 27. feb. 2015 22:31, skrev Scott Kostyshak: On Fri, Feb 27, 2015 at 4:14 PM, aparsloe apars...@clear.net.nz wrote: I've noticed that although LyX may report LaTeX errors and not display a pdf, nonetheless one is still produced in the temporary directory and can be displayed by double

Re: [patches] Improve error reporting and log parsing

2015-03-02 Thread Helge Hafting
Den 27. feb. 2015 22:31, skrev Scott Kostyshak: On Fri, Feb 27, 2015 at 4:14 PM, aparsloe wrote: I've noticed that although LyX may report LaTeX errors and not display a pdf, nonetheless one is still produced in the temporary directory and can be displayed by double

Re: [patches] Improve error reporting and log parsing

2015-03-01 Thread Georg Baum
Scott Kostyshak wrote: On Fri, Feb 27, 2015 at 4:27 PM, Georg Baum georg.b...@post.rwth-aachen.de wrote: Enrico Forestieri wrote: My vote is for a warning and an output produced in any case. If latex produces an output, that output has to be shown, IMO. Having the possibility of looking at

Re: [patches] Improve error reporting and log parsing

2015-03-01 Thread Scott Kostyshak
On Sun, Mar 1, 2015 at 5:08 AM, Georg Baum georg.b...@post.rwth-aachen.de wrote: Scott Kostyshak wrote: On Fri, Feb 27, 2015 at 4:27 PM, Georg Baum georg.b...@post.rwth-aachen.de wrote: Enrico Forestieri wrote: My vote is for a warning and an output produced in any case. If latex produces

Re: [patches] Improve error reporting and log parsing

2015-03-01 Thread Georg Baum
Scott Kostyshak wrote: > On Fri, Feb 27, 2015 at 4:27 PM, Georg Baum > wrote: >> Enrico Forestieri wrote: >> >>> My vote is for a warning and an output produced in any case. >>> If latex produces an output, that output has to be shown, IMO. >>> Having the

Re: [patches] Improve error reporting and log parsing

2015-03-01 Thread Scott Kostyshak
On Sun, Mar 1, 2015 at 5:08 AM, Georg Baum wrote: > Scott Kostyshak wrote: > >> On Fri, Feb 27, 2015 at 4:27 PM, Georg Baum >> wrote: >>> Enrico Forestieri wrote: >>> My vote is for a warning and an output produced in any case.

Re: [patches] Improve error reporting and log parsing

2015-02-28 Thread Scott Kostyshak
On Fri, Feb 27, 2015 at 4:27 PM, Georg Baum georg.b...@post.rwth-aachen.de wrote: Enrico Forestieri wrote: My vote is for a warning and an output produced in any case. If latex produces an output, that output has to be shown, IMO. Having the possibility of looking at the output may be of

Re: [patches] Improve error reporting and log parsing

2015-02-28 Thread Scott Kostyshak
On Fri, Feb 27, 2015 at 4:27 PM, Georg Baum wrote: > Enrico Forestieri wrote: > >> My vote is for a warning and an output produced in any case. >> If latex produces an output, that output has to be shown, IMO. >> Having the possibility of looking at the output may

Re: [patches] Improve error reporting and log parsing

2015-02-27 Thread Scott Kostyshak
On Fri, Feb 27, 2015 at 3:50 AM, Liviu Andronic landronim...@gmail.com wrote: On Fri, Feb 27, 2015 at 5:59 AM, Scott Kostyshak skost...@lyx.org wrote: On Thu, Feb 26, 2015 at 4:24 PM, Enrico Forestieri for...@lyx.org wrote: My vote is for a warning and an output produced in any case. If latex

Re: [patches] Improve error reporting and log parsing

2015-02-27 Thread Liviu Andronic
On Fri, Feb 27, 2015 at 7:09 PM, Scott Kostyshak skost...@lyx.org wrote: On Fri, Feb 27, 2015 at 12:54 PM, Liviu Andronic landronim...@gmail.com wrote: On Fri, Feb 27, 2015 at 6:22 PM, Scott Kostyshak skost...@lyx.org wrote: On Fri, Feb 27, 2015 at 3:50 AM, Liviu Andronic

Re: [patches] Improve error reporting and log parsing

2015-02-27 Thread Liviu Andronic
On Fri, Feb 27, 2015 at 6:22 PM, Scott Kostyshak skost...@lyx.org wrote: On Fri, Feb 27, 2015 at 3:50 AM, Liviu Andronic landronim...@gmail.com wrote: On Fri, Feb 27, 2015 at 5:59 AM, Scott Kostyshak skost...@lyx.org wrote: On Thu, Feb 26, 2015 at 4:24 PM, Enrico Forestieri for...@lyx.org

Re: [patches] Improve error reporting and log parsing

2015-02-27 Thread Scott Kostyshak
On Fri, Feb 27, 2015 at 12:54 PM, Liviu Andronic landronim...@gmail.com wrote: On Fri, Feb 27, 2015 at 6:22 PM, Scott Kostyshak skost...@lyx.org wrote: On Fri, Feb 27, 2015 at 3:50 AM, Liviu Andronic landronim...@gmail.com wrote: On Fri, Feb 27, 2015 at 5:59 AM, Scott Kostyshak

Re: [patches] Improve error reporting and log parsing

2015-02-27 Thread aparsloe
On 28/02/2015 6:22 a.m., Scott Kostyshak wrote: On Fri, Feb 27, 2015 at 3:50 AM, Liviu Andronic landronim...@gmail.com wrote: as somewhat often I get errors but a PDF does output (sometimes with useful clues on what really went wrong, and pointers on how to fix it). LaTeX errors? Strange, for

Re: [patches] Improve error reporting and log parsing

2015-02-27 Thread Georg Baum
Enrico Forestieri wrote: My vote is for a warning and an output produced in any case. If latex produces an output, that output has to be shown, IMO. Having the possibility of looking at the output may be of great help to pinpoint problems. This is a good argument actually. Then we should

Re: [patches] Improve error reporting and log parsing

2015-02-27 Thread Scott Kostyshak
On Fri, Feb 27, 2015 at 4:14 PM, aparsloe apars...@clear.net.nz wrote: On 28/02/2015 6:22 a.m., Scott Kostyshak wrote: On Fri, Feb 27, 2015 at 3:50 AM, Liviu Andronic landronim...@gmail.com wrote: as somewhat often I get errors but a PDF does output (sometimes with useful clues on what

Re: [patches] Improve error reporting and log parsing

2015-02-27 Thread Liviu Andronic
On Fri, Feb 27, 2015 at 5:59 AM, Scott Kostyshak skost...@lyx.org wrote: On Thu, Feb 26, 2015 at 4:24 PM, Enrico Forestieri for...@lyx.org wrote: On Thu, Feb 26, 2015 at 12:57:24PM -0500, Scott Kostyshak wrote: On Wed, Feb 25, 2015 at 4:33 PM, Scott Kostyshak skost...@lyx.org wrote: On Wed,

Re: [patches] Improve error reporting and log parsing

2015-02-27 Thread Liviu Andronic
On Fri, Feb 27, 2015 at 5:59 AM, Scott Kostyshak wrote: > On Thu, Feb 26, 2015 at 4:24 PM, Enrico Forestieri wrote: >> On Thu, Feb 26, 2015 at 12:57:24PM -0500, Scott Kostyshak wrote: >>> On Wed, Feb 25, 2015 at 4:33 PM, Scott Kostyshak wrote:

Re: [patches] Improve error reporting and log parsing

2015-02-27 Thread Scott Kostyshak
On Fri, Feb 27, 2015 at 3:50 AM, Liviu Andronic wrote: > On Fri, Feb 27, 2015 at 5:59 AM, Scott Kostyshak wrote: >> On Thu, Feb 26, 2015 at 4:24 PM, Enrico Forestieri wrote: >>> My vote is for a warning and an output produced in any

Re: [patches] Improve error reporting and log parsing

2015-02-27 Thread Liviu Andronic
On Fri, Feb 27, 2015 at 6:22 PM, Scott Kostyshak wrote: > On Fri, Feb 27, 2015 at 3:50 AM, Liviu Andronic > wrote: >> On Fri, Feb 27, 2015 at 5:59 AM, Scott Kostyshak wrote: >>> On Thu, Feb 26, 2015 at 4:24 PM, Enrico Forestieri

Re: [patches] Improve error reporting and log parsing

2015-02-27 Thread Scott Kostyshak
On Fri, Feb 27, 2015 at 12:54 PM, Liviu Andronic wrote: > On Fri, Feb 27, 2015 at 6:22 PM, Scott Kostyshak wrote: >> On Fri, Feb 27, 2015 at 3:50 AM, Liviu Andronic >> wrote: >>> On Fri, Feb 27, 2015 at 5:59 AM, Scott Kostyshak

Re: [patches] Improve error reporting and log parsing

2015-02-27 Thread Liviu Andronic
On Fri, Feb 27, 2015 at 7:09 PM, Scott Kostyshak wrote: > On Fri, Feb 27, 2015 at 12:54 PM, Liviu Andronic > wrote: >> On Fri, Feb 27, 2015 at 6:22 PM, Scott Kostyshak wrote: >>> On Fri, Feb 27, 2015 at 3:50 AM, Liviu Andronic

Re: [patches] Improve error reporting and log parsing

2015-02-27 Thread aparsloe
On 28/02/2015 6:22 a.m., Scott Kostyshak wrote: On Fri, Feb 27, 2015 at 3:50 AM, Liviu Andronic wrote: as somewhat often I get errors but a PDF does output (sometimes with useful clues on what really went wrong, and pointers on how to fix it). LaTeX errors? Strange,

Re: [patches] Improve error reporting and log parsing

2015-02-27 Thread Scott Kostyshak
On Fri, Feb 27, 2015 at 4:14 PM, aparsloe wrote: > On 28/02/2015 6:22 a.m., Scott Kostyshak wrote: >> >> On Fri, Feb 27, 2015 at 3:50 AM, Liviu Andronic >> wrote: >>> >>> as somewhat often I get errors but >>> a PDF does output (sometimes with

Re: [patches] Improve error reporting and log parsing

2015-02-27 Thread Georg Baum
Enrico Forestieri wrote: > My vote is for a warning and an output produced in any case. > If latex produces an output, that output has to be shown, IMO. > Having the possibility of looking at the output may be of great > help to pinpoint problems. This is a good argument actually. Then we should

Re: [patches] Improve error reporting and log parsing

2015-02-26 Thread Scott Kostyshak
On Wed, Feb 25, 2015 at 4:33 PM, Scott Kostyshak skost...@lyx.org wrote: On Wed, Feb 25, 2015 at 4:07 PM, Georg Baum IMHO it can be made an error right away. I would be OK with making it an error right away. The argument for first making it a warning is that from the user perspective, the

Re: [patches] Improve error reporting and log parsing

2015-02-26 Thread Enrico Forestieri
On Thu, Feb 26, 2015 at 12:57:24PM -0500, Scott Kostyshak wrote: On Wed, Feb 25, 2015 at 4:33 PM, Scott Kostyshak skost...@lyx.org wrote: On Wed, Feb 25, 2015 at 4:07 PM, Georg Baum IMHO it can be made an error right away. I would be OK with making it an error right away. The argument

Re: [patches] Improve error reporting and log parsing

2015-02-26 Thread Scott Kostyshak
On Thu, Feb 26, 2015 at 4:24 PM, Enrico Forestieri for...@lyx.org wrote: On Thu, Feb 26, 2015 at 12:57:24PM -0500, Scott Kostyshak wrote: On Wed, Feb 25, 2015 at 4:33 PM, Scott Kostyshak skost...@lyx.org wrote: On Wed, Feb 25, 2015 at 4:07 PM, Georg Baum IMHO it can be made an error right

Re: [patches] Improve error reporting and log parsing

2015-02-26 Thread Scott Kostyshak
On Wed, Feb 25, 2015 at 4:33 PM, Scott Kostyshak wrote: > On Wed, Feb 25, 2015 at 4:07 PM, Georg Baum >> IMHO it can be made an error right away. > > I would be OK with making it an error right away. The argument for > first making it a warning is that from the user

Re: [patches] Improve error reporting and log parsing

2015-02-26 Thread Enrico Forestieri
On Thu, Feb 26, 2015 at 12:57:24PM -0500, Scott Kostyshak wrote: > On Wed, Feb 25, 2015 at 4:33 PM, Scott Kostyshak wrote: > > On Wed, Feb 25, 2015 at 4:07 PM, Georg Baum > > >> IMHO it can be made an error right away. > > > > I would be OK with making it an error right away.

Re: [patches] Improve error reporting and log parsing

2015-02-26 Thread Scott Kostyshak
On Thu, Feb 26, 2015 at 4:24 PM, Enrico Forestieri wrote: > On Thu, Feb 26, 2015 at 12:57:24PM -0500, Scott Kostyshak wrote: >> On Wed, Feb 25, 2015 at 4:33 PM, Scott Kostyshak wrote: >> > On Wed, Feb 25, 2015 at 4:07 PM, Georg Baum >> >> >> IMHO it can be made

Re: [patches] Improve error reporting and log parsing

2015-02-25 Thread Georg Baum
Scott Kostyshak wrote: 0005-Check-exit-code-of-LaTeX-process-in-LaTeX-run.patch - To see why this patch is useful, open New New from Template ACM-sigplan.lyx and compile. It says that compilation was successful and shows the PDF. However, there was an error that was missed in parsing (the

Re: [patches] Improve error reporting and log parsing

2015-02-25 Thread Scott Kostyshak
On Wed, Feb 25, 2015 at 4:07 PM, Georg Baum georg.b...@post.rwth-aachen.de wrote: Scott Kostyshak wrote: 0005-Check-exit-code-of-LaTeX-process-in-LaTeX-run.patch - To see why this patch is useful, open New New from Template ACM-sigplan.lyx and compile. It says that compilation was

Re: [patches] Improve error reporting and log parsing

2015-02-25 Thread Georg Baum
Scott Kostyshak wrote: > 0005-Check-exit-code-of-LaTeX-process-in-LaTeX-run.patch > - To see why this patch is useful, open New > New from Template > > ACM-sigplan.lyx and compile. It says that compilation was successful > and shows the PDF. However, there was an error that was missed in >

Re: [patches] Improve error reporting and log parsing

2015-02-25 Thread Scott Kostyshak
On Wed, Feb 25, 2015 at 4:07 PM, Georg Baum wrote: > Scott Kostyshak wrote: > >> 0005-Check-exit-code-of-LaTeX-process-in-LaTeX-run.patch >> - To see why this patch is useful, open New > New from Template > >> ACM-sigplan.lyx and compile. It says that compilation

Re: [patches] Improve error reporting and log parsing

2015-02-24 Thread Scott Kostyshak
On Tue, Feb 24, 2015 at 1:22 PM, Richard Heck rgh...@lyx.org wrote: On 02/24/2015 12:01 PM, Scott Kostyshak wrote: On Tue, Feb 24, 2015 at 9:30 AM, Richard Heck rgh...@lyx.org wrote: On 02/22/2015 03:45 PM, Scott Kostyshak wrote: 0004-Allow-cloned-buffers-to-give-alerts-in-runLaTeX.patch -

Re: [patches] Improve error reporting and log parsing

2015-02-24 Thread Richard Heck
On 02/22/2015 03:45 PM, Scott Kostyshak wrote: 0004-Allow-cloned-buffers-to-give-alerts-in-runLaTeX.patch - This is the patch I am least confident about. Conditioning on !buffer.isClone() caused the condition to always fail so the alerts were never shown. Is that conditioning still needed? I

Re: [patches] Improve error reporting and log parsing

2015-02-24 Thread Scott Kostyshak
On Tue, Feb 24, 2015 at 9:30 AM, Richard Heck rgh...@lyx.org wrote: On 02/22/2015 03:45 PM, Scott Kostyshak wrote: 0004-Allow-cloned-buffers-to-give-alerts-in-runLaTeX.patch - This is the patch I am least confident about. Conditioning on !buffer.isClone() caused the condition to always fail

Re: [patches] Improve error reporting and log parsing

2015-02-24 Thread Richard Heck
On 02/24/2015 12:01 PM, Scott Kostyshak wrote: On Tue, Feb 24, 2015 at 9:30 AM, Richard Heck rgh...@lyx.org wrote: On 02/22/2015 03:45 PM, Scott Kostyshak wrote: 0004-Allow-cloned-buffers-to-give-alerts-in-runLaTeX.patch - This is the patch I am least confident about. Conditioning on

Re: [patches] Improve error reporting and log parsing

2015-02-24 Thread Richard Heck
On 02/22/2015 03:45 PM, Scott Kostyshak wrote: 0004-Allow-cloned-buffers-to-give-alerts-in-runLaTeX.patch - This is the patch I am least confident about. Conditioning on !buffer.isClone() caused the condition to always fail so the alerts were never shown. Is that conditioning still needed? I

Re: [patches] Improve error reporting and log parsing

2015-02-24 Thread Scott Kostyshak
On Tue, Feb 24, 2015 at 9:30 AM, Richard Heck wrote: > On 02/22/2015 03:45 PM, Scott Kostyshak wrote: >> >> 0004-Allow-cloned-buffers-to-give-alerts-in-runLaTeX.patch >> - This is the patch I am least confident about. Conditioning on >> !buffer.isClone() caused the condition to

Re: [patches] Improve error reporting and log parsing

2015-02-24 Thread Richard Heck
On 02/24/2015 12:01 PM, Scott Kostyshak wrote: On Tue, Feb 24, 2015 at 9:30 AM, Richard Heck wrote: On 02/22/2015 03:45 PM, Scott Kostyshak wrote: 0004-Allow-cloned-buffers-to-give-alerts-in-runLaTeX.patch - This is the patch I am least confident about. Conditioning on

Re: [patches] Improve error reporting and log parsing

2015-02-24 Thread Scott Kostyshak
On Tue, Feb 24, 2015 at 1:22 PM, Richard Heck wrote: > On 02/24/2015 12:01 PM, Scott Kostyshak wrote: >> >> On Tue, Feb 24, 2015 at 9:30 AM, Richard Heck wrote: >>> >>> On 02/22/2015 03:45 PM, Scott Kostyshak wrote:

Re: [patches] Improve error reporting and log parsing

2015-02-23 Thread Scott Kostyshak
On Sun, Feb 22, 2015 at 11:32 PM, aparsloe apars...@clear.net.nz wrote: On 23/02/2015 9:45 a.m., Scott Kostyshak wrote: Attached are a sequence of patches addressing issues related to LyX's error reporting and log parsing. Dear Scott, Not strictly on topic, but for one giddy moment I

Re: [patches] Improve error reporting and log parsing

2015-02-23 Thread Scott Kostyshak
On Sun, Feb 22, 2015 at 11:32 PM, aparsloe wrote: > > On 23/02/2015 9:45 a.m., Scott Kostyshak wrote: >> >> Attached are a sequence of patches addressing issues related to LyX's >> error reporting and log parsing. > > Dear Scott, > > Not strictly on topic, but for one giddy

[patches] Improve error reporting and log parsing

2015-02-22 Thread Scott Kostyshak
Attached are a sequence of patches addressing issues related to LyX's error reporting and log parsing. I give more detailed descriptions of them in the actual commit messages of the attached patches, but below I list important points as well as a couple of questions. I have brought up a couple of

Re: [patches] Improve error reporting and log parsing

2015-02-22 Thread aparsloe
On 23/02/2015 9:45 a.m., Scott Kostyshak wrote: Attached are a sequence of patches addressing issues related to LyX's error reporting and log parsing. Dear Scott, Not strictly on topic, but for one giddy moment I thought there might have been some attention paid to #9211. Alas no. (Instant

[patches] Improve error reporting and log parsing

2015-02-22 Thread Scott Kostyshak
Attached are a sequence of patches addressing issues related to LyX's error reporting and log parsing. I give more detailed descriptions of them in the actual commit messages of the attached patches, but below I list important points as well as a couple of questions. I have brought up a couple of

Re: [patches] Improve error reporting and log parsing

2015-02-22 Thread aparsloe
On 23/02/2015 9:45 a.m., Scott Kostyshak wrote: Attached are a sequence of patches addressing issues related to LyX's error reporting and log parsing. Dear Scott, Not strictly on topic, but for one giddy moment I thought there might have been some attention paid to #9211. Alas no. (Instant