Re: Howto do "a detailed cleanup with the aid of the sysclean package"?

2022-05-06 Thread Marc Espie
Look, can we all just agree it is just a question of adding appropriate verbiage to the port/package, sticking a huge CAVEAT on the documentation leading to it, and go back to writing actual code ?

Re: Howto do "a detailed cleanup with the aid of the sysclean package"?

2022-05-06 Thread Stuart Henderson
On 2022-05-04, Theo de Raadt wrote: > I have also pointed out a couple of times now that sysclean ignores the > lessons of "find -print0" and "xargs -0", and I worry it could find a > file called > > "/somewhere/matchingpattern/\n/etc/spwd.db" Thus is easily fixed by adding a "delete" mode which

Re: Howto do "a detailed cleanup with the aid of the sysclean package"?

2022-05-05 Thread David Rinehart
To Nobody in particular: Confucius is attributed with stating: "The beginning of wisdom is to call things by their proper name" I suggest that "sysclean" is not the name of the code inside this utility. The sysupgrade utility actually upgrades my system and fw_update updates my firmware.  sys

Re: Howto do "a detailed cleanup with the aid of the sysclean package"?

2022-05-04 Thread Luke Call
How about someone simply (better than I) updating the manual page and pkg_info output with warnings and clarifications about the intended use case and risks? Maybe the man page could say (just as an idea): "Warning: this is intended to suggest files for removal, that it guesses are obsolete; if yo

Re: Howto do "a detailed cleanup with the aid of the sysclean package"?

2022-05-04 Thread Sebastien Marie
On Wed, May 04, 2022 at 09:54:26AM -0600, Theo de Raadt wrote: > Marc Espie wrote: > > > All the horrors stories I've seen in this discussion are related > > to people trusting it blindly/automatically. > > But why wouldn't people trust it? > > All the documentation claims it produces a list of

Re: Howto do "a detailed cleanup with the aid of the sysclean package"?

2022-05-04 Thread Theo de Raadt
Marc Espie wrote: > All the horrors stories I've seen in this discussion are related > to people trusting it blindly/automatically. But why wouldn't people trust it? All the documentation claims it produces a list of files that is obsolete. It says those files are obsolete & unused -- with suc

Re: Howto do "a detailed cleanup with the aid of the sysclean package"?

2022-05-04 Thread Marc Espie
On Wed, May 04, 2022 at 07:45:32AM -0400, Raul Miller wrote: > On Wed, May 4, 2022 at 4:15 AM Sebastien Marie wrote: > > The main problem I am seeing would be maintaining such lists, and it > > necessary > > means manual addition to add only "safe" files to remove (no libraries at > > least). >

Re: Howto do "a detailed cleanup with the aid of the sysclean package"?

2022-05-04 Thread Theo de Raadt
Sebastien Marie wrote: > a package could use old libraries, and such libraries will not be listed by > sysclean. the sysclean manual page claims that it correctly identifies "obsolete filenames". Obsolete, adj. 1.no longer produced or used; out of date. But this is innaccurate. By your

Re: Howto do "a detailed cleanup with the aid of the sysclean package"?

2022-05-04 Thread Sebastien Marie
On Wed, May 04, 2022 at 08:03:14AM -0600, Theo de Raadt wrote: > Sebastien Marie wrote: > > > semarie@ spoke about integrating some elements inside the installer when he > > was > > about "clean _other things_". It isn't about "stepping back". Even if the > > installer would clean all it is po

Re: Howto do "a detailed cleanup with the aid of the sysclean package"?

2022-05-04 Thread Theo de Raadt
Sebastien Marie wrote: > semarie@ spoke about integrating some elements inside the installer when he > was > about "clean _other things_". It isn't about "stepping back". Even if the > installer would clean all it is possible to remove safely, I would still use > a > program to list librarie

Re: Howto do "a detailed cleanup with the aid of the sysclean package"?

2022-05-04 Thread Sebastien Marie
On Wed, May 04, 2022 at 06:20:59AM -0600, Theo de Raadt wrote: > > Users are capable of creating linking against older lib*.so.* files. > Such binaries could be anywhere on-disk, and we should not walk the entire > disk to find them. Therefore such old libraries should NEVER be deleted. > > It i

Re: Howto do "a detailed cleanup with the aid of the sysclean package"?

2022-05-04 Thread Theo de Raadt
Harald Dunkel wrote: > Hi folks, > > I think the main problem is pretty easy to describe: OpenBSD loses track > about what it had installed and cannot clean up its own files on a system > upgrade. No, that is incorrect. Users are capable of creating linking against older lib*.so.* files. Such

Re: Howto do "a detailed cleanup with the aid of the sysclean package"?

2022-05-04 Thread Raul Miller
On Wed, May 4, 2022 at 4:15 AM Sebastien Marie wrote: > The main problem I am seeing would be maintaining such lists, and it necessary > means manual addition to add only "safe" files to remove (no libraries at > least). Conceptually speaking, it's possible to track library dependencies, and it's

Re: Howto do "a detailed cleanup with the aid of the sysclean package"?

2022-05-04 Thread Sebastien Marie
On Wed, May 04, 2022 at 07:42:54AM +0200, Harald Dunkel wrote: > Hi folks, > > I think the main problem is pretty easy to describe: OpenBSD loses track > about what it had installed and cannot clean up its own files on a system > upgrade. technically we are already tracking which files were insta

Re: Howto do "a detailed cleanup with the aid of the sysclean package"?

2022-05-03 Thread Florian Obser
On 2022-05-04 07:42 +02, Harald Dunkel wrote: > Hi folks, > > I think the main problem is pretty easy to describe: OpenBSD loses track > about what it had installed and cannot clean up its own files on a system > upgrade. The general case is a hard problem and people who deemed this important hav

Re: Howto do "a detailed cleanup with the aid of the sysclean package"?

2022-05-03 Thread Harald Dunkel
Hi folks, I think the main problem is pretty easy to describe: OpenBSD loses track about what it had installed and cannot clean up its own files on a system upgrade. Regards Harri

Re: Howto do "a detailed cleanup with the aid of the sysclean package"?

2022-04-24 Thread Harald Dunkel
On 2022-04-20 21:25:49, Ryan Kavanagh wrote: On Wed, Apr 20, 2022 at 08:39:09PM +0200, Harald Dunkel wrote: sysclean lists 4180 files and directories on my home server Could you please elaborate how sysclean is going to help me to keep my openbsd hosts clean? How is the usage model of this tool

Re: Howto do "a detailed cleanup with the aid of the sysclean package"?

2022-04-21 Thread Theo de Raadt
Stuart Henderson wrote: > > Btw. there is another school of thought that says old cruft doesn't need > > to be removed, it's not causing any harm. If you need a clean system > > just reinstall and restore config and data from backups. It's a good > > excercise to check that your backups are worki

Re: Howto do "a detailed cleanup with the aid of the sysclean package"?

2022-04-21 Thread Stuart Henderson
On 2022-04-21, Florian Obser wrote: > On 2022-04-20 21:42 UTC, Stuart Henderson wrote: >> On 2022-04-20, Florian Obser wrote: >>> You will need a carefully curated /etc/sysclean.ignore file. >>> >>> You decided to put maildirs somewhere on the system, sysclean is not >>> omniscient, you need to

Re: Howto do "a detailed cleanup with the aid of the sysclean package"?

2022-04-21 Thread Sebastien Marie
On Thu, Apr 21, 2022 at 08:24:31AM +0200, Florian Obser wrote: > On 2022-04-20 21:42 UTC, Stuart Henderson wrote: > > On 2022-04-20, Florian Obser wrote: > >> You will need a carefully curated /etc/sysclean.ignore file. > >> > >> You decided to put maildirs somewhere on the system, sysclean is no

Re: Howto do "a detailed cleanup with the aid of the sysclean package"?

2022-04-20 Thread Florian Obser
On 2022-04-20 21:42 UTC, Stuart Henderson wrote: > On 2022-04-20, Florian Obser wrote: >> You will need a carefully curated /etc/sysclean.ignore file. >> >> You decided to put maildirs somewhere on the system, sysclean is not >> omniscient, you need to tell it to leave them alone. Same with .git

Re: Howto do "a detailed cleanup with the aid of the sysclean package"?

2022-04-20 Thread Stuart Henderson
On 2022-04-20, Florian Obser wrote: > You will need a carefully curated /etc/sysclean.ignore file. > > You decided to put maildirs somewhere on the system, sysclean is not > omniscient, you need to tell it to leave them alone. Same with .git > directories. > I don't recall needing to tell it abo

Re: Howto do "a detailed cleanup with the aid of the sysclean package"?

2022-04-20 Thread Florian Obser
You will need a carefully curated /etc/sysclean.ignore file. You decided to put maildirs somewhere on the system, sysclean is not omniscient, you need to tell it to leave them alone. Same with .git directories. I don't recall needing to tell it about package config files though, that's a bit wei

Re: Howto do "a detailed cleanup with the aid of the sysclean package"?

2022-04-20 Thread Ian Darwin
On Wed, Apr 20, 2022 at 08:39:09PM +0200, Harald Dunkel wrote: > Hi folks, > > the upgrade guide claims > > A detailed cleanup can be done with the aid of the sysclean package. > > sysclean lists 4180 files and directories on my home server, including mail > directories, config files of va