On June 30, 2015, 12:14 a.m., Adam B wrote:
docs/persistent-volume.md, line 56
https://reviews.apache.org/r/35981/diff/1/?file=994064#file994064line56
Can a volume/reservation created by one framework principal only be
destroyed/unreserved by a framework scheduler using the same
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35986/
---
(Updated July 7, 2015, 5:55 p.m.)
Review request for mesos, Adam B and Isabel
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35777/#review90714
---
Patch looks great!
Reviews applied: [35777]
All tests passed.
-
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35986/
---
(Updated July 7, 2015, 5:46 p.m.)
Review request for mesos, Adam B and Isabel
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36204/#review90727
---
Ship it!
LGTM! Could you please add a follow up patch to test this
On July 6, 2015, 5:50 p.m., Jie Yu wrote:
src/slave/slave.cpp, line 4379
https://reviews.apache.org/r/36204/diff/1/?file=1000223#file1000223line4379
Per my comments above, the logic here needs to be adjusted. We need to
apply checkpointed resource to info.resources() here.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36267/
---
Review request for mesos, Benjamin Hindman, Artem Harutyunyan, and Michael Park.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36214/#review90665
---
Ship it!
- Joerg Schad
On July 6, 2015, 8:40 p.m., Timothy Chen
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36048/
---
(Updated July 7, 2015, 9:33 a.m.)
Review request for mesos, Adam B and Till
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36049/
---
(Updated July 7, 2015, 9:34 a.m.)
Review request for mesos, Adam B and Till
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36214/#review90663
---
Ship it!
Ship It!
- Bernd Mathiske
On July 6, 2015, 1:40 p.m.,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36216/#review90662
---
Ship it!
Ship It!
- Bernd Mathiske
On July 6, 2015, 3:58 p.m.,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36205/#review90661
---
Ship it!
After fixing my previous issue...
- Joerg Schad
On
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36205/
---
(Updated July 7, 2015, 10:20 a.m.)
Review request for mesos, Bernd Mathiske,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36205/#review90660
---
3rdparty/libprocess/include/process/gtest.hpp (line 301)
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36216/#review90664
---
src/tests/docker_containerizer_tests.cpp (line 2123)
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36267/#review90744
---
Patch looks great!
Reviews applied: [36267]
All tests passed.
-
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31444/#review90757
---
Bad patch!
Reviews applied: [32891, 31444]
Failed command:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36269/#review90756
---
CHANGELOG (line 337)
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35986/
---
(Updated July 7, 2015, 7:07 p.m.)
Review request for mesos, Adam B and Isabel
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34137/
---
(Updated July 7, 2015, 12:42 p.m.)
Review request for mesos, Chi Zhang, Paul
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36275/
---
(Updated July 7, 2015, 8:04 p.m.)
Review request for mesos, Benjamin Hindman,
On July 7, 2015, 1:30 a.m., Adam B wrote:
src/common/attributes.cpp, lines 150-152
https://reviews.apache.org/r/35986/diff/1/?file=994137#file994137line150
There's a subtle difference in behavior between strings::tokenize and
strings::split. For tokenize, Empty tokens will not be
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36269/#review90754
---
Do you actually want/need MESOS-2640 to go into 0.23.0?
CHANGELOG
On July 7, 2015, 11:40 a.m., Vinod Kone wrote:
CHANGELOG, line 337
https://reviews.apache.org/r/36269/diff/1/?file=1001355#file1001355line337
I would just put this under deprecations section.
Also, mind updating MESOS-2058 in deprecation section to do
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34141/
---
(Updated July 7, 2015, 12:43 p.m.)
Review request for mesos, Chi Zhang, Paul
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34142/
---
(Updated July 7, 2015, 12:43 p.m.)
Review request for mesos, Chi Zhang, Paul
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36246/
---
(Updated July 7, 2015, 7:51 p.m.)
Review request for mesos, Benjamin Hindman
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35986/#review90769
---
Patch looks great!
Reviews applied: [35986]
All tests passed.
-
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35986/
---
(Updated July 7, 2015, 6:33 p.m.)
Review request for mesos, Adam B and Isabel
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31444/
---
(Updated July 7, 2015, 11:33 a.m.)
Review request for mesos, Chi Zhang,
On July 7, 2015, 6:40 p.m., Vinod Kone wrote:
CHANGELOG, line 337
https://reviews.apache.org/r/36269/diff/1/?file=1001355#file1001355line337
I would just put this under deprecations section.
Also, mind updating MESOS-2058 in deprecation section to do
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34140/
---
(Updated July 7, 2015, 12:43 p.m.)
Review request for mesos, Chi Zhang, Paul
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34139/
---
(Updated July 7, 2015, 12:42 p.m.)
Review request for mesos, Chi Zhang, Paul
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34138/
---
(Updated July 7, 2015, 12:42 p.m.)
Review request for mesos, Chi Zhang, Paul
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35986/
---
(Updated July 7, 2015, 6:26 p.m.)
Review request for mesos, Adam B and Isabel
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36267/#review90761
---
Ship it!
Ship It!
- Artem Harutyunyan
On July 7, 2015, 10:21
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36275/
---
Review request for mesos, Benjamin Hindman, Artem Harutyunyan, and Michael Park.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36246/
---
(Updated July 7, 2015, 8:04 p.m.)
Review request for mesos, Benjamin Hindman
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36204/
---
(Updated July 7, 2015, 4:20 p.m.)
Review request for mesos, Ben Mahler, Jie
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36267/#review90787
---
Ship it!
Ship It!
- Benjamin Hindman
On July 7, 2015, 5:21
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36281/
---
Review request for mesos, Ian Downes, Jie Yu, and Cong Wang.
Repository: mesos
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36275/
---
(Updated July 7, 2015, 9:02 p.m.)
Review request for mesos, Benjamin Hindman,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34141/#review90778
---
src/slave/containerizer/provisioners/appc/backend.cpp (line 139)
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36277/#review90782
---
Ship it!
Ship It!
- Adam B
On July 7, 2015, 1:59 p.m., Joris
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36269/#review90776
---
Patch looks great!
Reviews applied: [36269]
All tests passed.
-
On July 7, 2015, 9:42 p.m., Vinod Kone wrote:
support/post-reviews.py, line 173
https://reviews.apache.org/r/35777/diff/2/?file=1001308#file1001308line173
Why 'format' instead of directly printing the message with a %s? Just
curious.
It's a more portable way of printing - also,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36277/#review90784
---
Patch looks great!
Reviews applied: [36277]
All tests passed.
-
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35777/#review90785
---
support/post-reviews.py (line 170)
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36277/#review90786
---
Ship it!
Ship It!
- Benjamin Hindman
On July 7, 2015, 8:59
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36246/#review90788
---
Ship it!
Ship It!
- Benjamin Hindman
On July 7, 2015, 8:04
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36049/#review90774
---
There are some nits and slight inconsistencies but overall I think
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36282/#review90802
---
Question about MESOS-2832, but otherwise looks good.
On July 2, 2015, 11:32 p.m., Ben Mahler wrote:
src/linux/cgroups.hpp, lines 443-472
https://reviews.apache.org/r/36106/diff/1/?file=997646#file997646line443
Thanks!
(1) Do you mind updating my TODO on cgroups::stat() to reflect that
cpuacct::stat is implemented?
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36282/
---
(Updated July 7, 2015, 11:05 p.m.)
Review request for mesos, Adam B, Benjamin
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36282/#review90821
---
Updated the review to use a new optional boolean flag. The docker
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36226/#review90832
---
3rdparty/libprocess/3rdparty/Makefile.am (lines 1 - 7)
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36281/
---
(Updated July 8, 2015, 12:03 a.m.)
Review request for mesos, Ian Downes, Jie
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36282/
---
Review request for mesos, Benjamin Hindman and Joerg Schad.
Bugs: MESOS-2996
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36282/#review90796
---
Ship it!
Looks good but see the issue below about moving this
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36282/#review90812
---
src/slave/containerizer/docker.hpp (line 239)
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36282/#review90814
---
src/slave/containerizer/docker.cpp (line 1544)
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36281/#review90819
---
docs/network-isolation.md (line 29)
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36282/#review90826
---
Ship it!
Barring Adams comment.
On July 7, 2015, 11:43 p.m., Till Toenshoff wrote:
3rdparty/libprocess/3rdparty/Makefile.am, lines 1-7
https://reviews.apache.org/r/36226/diff/1/?file=1000612#file1000612line1
This should be the “Apache License Version 2.0” header instead which
applies to libprocess and stout,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36226/
---
(Updated July 8, 2015, 12:12 a.m.)
Review request for mesos and Benjamin
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36273/
---
(Updated July 7, 2015, 5:24 p.m.)
Review request for mesos, Benjamin Hindman,
On July 7, 2015, 10:08 p.m., Benjamin Hindman wrote:
Added comment and committed, thanks.
- Benjamin
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36275/#review90792
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36275/#review90792
---
Ship it!
3rdparty/libprocess/src/tests/ssl_tests.cpp (line 312)
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34138/#review90791
---
1. Agree that this is useful as a utility in libprocess. Not much
On July 7, 2015, 10:58 p.m., Joerg Schad wrote:
src/slave/containerizer/docker.cpp, line 1544
https://reviews.apache.org/r/36282/diff/1/?file=1001811#file1001811line1544
Wouldn't it be easier --especially considering Adam's comment about
MESOS-2832 and the
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36281/#review90828
---
Bad patch!
Reviews applied: [36281]
Failed command:
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36281/#review90827
---
Thanks for writing this up! I had a few minor suggestions and some
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36279/
---
(Updated July 7, 2015, 3:14 p.m.)
Review request for mesos, Benjamin Hindman,
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36282/#review90811
---
src/slave/containerizer/docker.cpp (line 1552)
On July 3, 2015, 12:29 a.m., Ben Mahler wrote:
I chatted with Isabel on IRC and asked her to break apart this change into
more bite-sized chunks, so that we can do smaller reviews and get things
committed incrementally:
(1) Dummy /call handler on the master.
(2) Validation.
(3)
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34139/#review90830
---
src/slave/containerizer/provisioners/appc/discovery.hpp (lines 43
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36281/#review90798
---
docs/network-isolation.md (line 7)
On July 7, 2015, 10:58 p.m., Joerg Schad wrote:
src/slave/containerizer/docker.cpp, line 1544
https://reviews.apache.org/r/36282/diff/1/?file=1001811#file1001811line1544
Wouldn't it be easier --especially considering Adam's comment about
MESOS-2832 and the
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36282/#review90822
---
Ship it!
Looks like a simpler, more generic fix. Maybe
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36279/#review90823
---
Patch looks great!
Reviews applied: [36279]
All tests passed.
-
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36281/#review90813
---
Ship it!
Thanks Paul! This is great!
It's a little hard to review
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36071/#review90685
---
1. Inconsistent capitalization in box labels.
2. You explain
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36255/
---
Review request for mesos, Adam B and Michael Park.
Bugs: MESOS-2991
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35998/#review90677
---
3rdparty/libprocess/3rdparty/stout/include/stout/path.hpp (line
On June 29, 2015, 5:14 p.m., Adam B wrote:
docs/persistent-volume.md, line 169
https://reviews.apache.org/r/35981/diff/1/?file=994064#file994064line169
There is no `volumes` field. Just a `resources` field, where each
resource in the list must contain a `disk.volume` to be
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36281/#review90858
---
Patch looks great!
Reviews applied: [36281]
All tests passed.
-
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36281/#review90857
---
Ship it!
A few other minor nits, but I think we can commit this
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35947/#review90839
---
Ship it!
src/master/allocator/mesos/hierarchical.hpp (lines 734 -
On July 7, 2015, 3:56 p.m., Jiang Yan Xu wrote:
1. Agree that this is useful as a utility in libprocess. Not much overhead
to move it over right?
2. It feels like something that could be exposed as a function rather than
class, maybe a TODO.
OK I realized that doing the
On July 7, 2015, 11:31 p.m., Jie Yu wrote:
docs/network-isolation.md, line 7
https://reviews.apache.org/r/36281/diff/1/?file=1001779#file1001779line7
Please do not delete the version information. Network monitoring is
added in mesos 0.20 and network isolation is added in mesos
On July 8, 2015, 12:01 a.m., Adam B wrote:
docs/network-isolation.md, line 79
https://reviews.apache.org/r/36281/diff/1/?file=1001779#file1001779line79
Why is this a fixed constant limit? Seems like we might want to adjust
this depending on how many containers are running, or
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36273/#review90852
---
Patch looks great!
Reviews applied: [36273]
All tests passed.
-
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36281/
---
(Updated July 8, 2015, 12:59 a.m.)
Review request for mesos, Ian Downes, Jie
On July 7, 2015, 5:01 p.m., Adam B wrote:
docs/network-isolation.md, line 79
https://reviews.apache.org/r/36281/diff/1/?file=1001779#file1001779line79
Why is this a fixed constant limit? Seems like we might want to adjust
this depending on how many containers are running, or give
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/36277/
---
Review request for mesos and Benjamin Hindman.
Bugs: MESOS-3002
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35777/#review90783
---
Ship it!
Minor nit on error message - fix it and commit.
Thanks
97 matches
Mail list logo
