Re: Review Request 63933: MesosTidy [misc-use-after-move]: Arguments moved into chained calls.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63933/#review191435 --- PASS: Mesos patch 63933 was successfully built and tested.

Re: Review Request 63732: Reconciled offer operations between agent and master.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63732/#review191427 --- src/master/master.cpp Lines 7119 (patched)

Re: Review Request 63175: Do not generate UnavailableResources for inactive frameworks.

> On Nov. 7, 2017, 5:09 p.m., Benjamin Mahler wrote: > > src/master/allocator/mesos/hierarchical.hpp > > Lines 319 (patched) > > > > > > I think this should be `connected`? > > > > Right now there's some

Re: Review Request 63731: Reconciled pending resource provider operations in agent.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63731/#review191425 --- src/slave/slave.cpp Lines 6800 (patched)

Re: Review Request 63842: Allowed removing non-terminal offer operations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63842/#review191424 --- src/master/master.hpp Lines 2913-2915 (original)

Re: Review Request 63918: Updated ResourceProviderMessage stringification with recent changes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63918/#review191422 --- src/resource_provider/message.hpp Lines 77 (patched)

Re: Review Request 63730: Passed operations from resource provider to agent.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63730/#review191423 --- Ship it! Ship It! - Jie Yu On Nov. 17, 2017, 5:24 p.m.,

Re: Review Request 63917: Renamed resource provider message UpdateTotalResources to UpdateState.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63917/#review191421 --- Fix it, then Ship it! src/resource_provider/message.hpp Line

Re: Review Request 63175: Do not generate UnavailableResources for inactive frameworks.

> On Nov. 7, 2017, 5:09 p.m., Benjamin Mahler wrote: > > src/master/allocator/mesos/hierarchical.hpp > > Lines 319 (patched) > > > > > > I think this should be `connected`? > > > > Right now there's some

Re: Review Request 62997: Added checkpoint and recover capability for layers in provisioner.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62997/#review191418 --- Ship it! Ship It! - Gilbert Song On Nov. 17, 2017, 8:51

Re: Review Request 55335: Backfilled required fields in TaskInfo in MesosContainerizer* tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55335/#review191417 --- Ship it! Ship It! - Gilbert Song On Nov. 17, 2017, 8:52

Review Request 63932: MesosTidy [misc-use-after-move]: Added `NOLINT` to false-positives.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63932/ --- Review request for mesos and Benjamin Mahler. Repository: mesos Description

Review Request 63933: MesosTidy [misc-use-after-move]: Arguments moved into chained calls.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63933/ --- Review request for mesos and Benjamin Mahler. Repository: mesos Description

Review Request 63931: MesosTidy [misc-use-after-move]: Fixed `HashMapTest` test.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63931/ --- Review request for mesos and Benjamin Mahler. Repository: mesos Description

Review Request 63930: MesosTidy: Turned on [misc-use-after-move].

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63930/ --- Review request for mesos and Benjamin Mahler. Repository: mesos Description

Re: Review Request 61473: Do not kill non partition aware tasks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61473/#review191409 --- FAIL: Some Mesos tests failed. Reviews applied: `['61473']`

Re: Review Request 63861: Windows: Updated networking doc.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63861/ --- (Updated Nov. 17, 2017, 10:38 p.m.) Review request for mesos, Andrew

Re: Review Request 63860: Windows: Mapped the Docker network info types.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63860/ --- (Updated Nov. 17, 2017, 10:37 p.m.) Review request for mesos, Andrew

Re: Review Request 63889: Use annotated tags in vote.sh and release.sh.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63889/#review191403 --- Ship it! Ship It! - Vinod Kone On Nov. 16, 2017, 8:46 p.m.,

Re: Review Request 61473: Do not kill non partition aware tasks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61473/ --- (Updated Nov. 17, 2017, 10:35 p.m.) Review request for mesos, James Peach,

Re: Review Request 63859: Windows: Fixed mock signal values in stout.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63859/ --- (Updated Nov. 17, 2017, 10:35 p.m.) Review request for mesos, Andrew

Re: Review Request 63862: Ported docker_tests.cpp to Windows.

> On Nov. 16, 2017, 7:25 p.m., Andrew Schwartzmeyer wrote: > > src/tests/containerizer/docker_tests.cpp > > Lines 62 (patched) > > > > > > If you want to use it, we have a `SLEEP_COMMAND` macro that takes an > > int

Re: Review Request 63861: Updated networking doc for Windows docker containers.

> On Nov. 16, 2017, 6:46 p.m., Andrew Schwartzmeyer wrote: > > docs/networking.md > > Lines 118-123 (patched) > > > > > > Are the names of the network types on Windows generally capitalized > > (like the Linux ones

Re: Review Request 63860: Fixed docker network settings for Windows.

> On Nov. 16, 2017, 6:43 p.m., Andrew Schwartzmeyer wrote: > > src/docker/docker.cpp > > Lines 742-743 (original), 742-760 (patched) > > > > > > If there's an MSDN doc we can reference here to explain this mapping,

Re: Review Request 61473: Do not kill non partition aware tasks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61473/ --- (Updated Nov. 17, 2017, 9:27 p.m.) Review request for mesos, James Peach,

Re: Review Request 63859: Fixed signal vals & WEXITSTATUS on Windows stout.

> On Nov. 16, 2017, 6:38 p.m., Andrew Schwartzmeyer wrote: > > 3rdparty/stout/include/stout/windows.hpp > > Lines 346-348 (original), 346-348 (patched) > > > > > > We should add a link to MSDN explaining why these

Re: Review Request 63844: Removed acknowledged offer operation status updates.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63844/#review191391 --- PASS: Mesos patch 63844 was successfully built and tested.

Re: Review Request 62853: Added test for `PRUNE_IMAGES` operator API call.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62853/#review191390 --- PASS: Mesos patch 62853 was successfully built and tested.

Re: Review Request 61473: Do not kill non partition aware tasks.

> On Sept. 29, 2017, 6:19 p.m., Jiang Yan Xu wrote: > > src/master/master.cpp > > Lines 7169-7173 (patched) > > > > > > You have created this `newUpdate` but are not immediately using it, and > > I have to pay

Re: Review Request 61473: Do not kill non partition aware tasks.

> On Sept. 29, 2017, 6:19 p.m., Jiang Yan Xu wrote: > > src/master/master.hpp > > Lines 2475-2477 (patched) > > > > > > Because this method takes a pointer, this mutation could affect future > > uses of it. Even

Re: Review Request 63795: Made `mesos-tcp-connect` support IPv6.

> On Nov. 16, 2017, 6:54 p.m., Avinash sridharan wrote: > > src/checks/tcp_connect.cpp > > Lines 90 (patched) > > > > > > Why do we need this? > > > > `net::IP::in` and `net::IP::in6` already give this

Re: Review Request 61473: Do not kill non partition aware tasks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61473/ --- (Updated Nov. 17, 2017, 7:26 p.m.) Review request for mesos, James Peach,

Re: Review Request 63910: Added 3 tests for TCP/HTTP(S) health check support for Docker container.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63910/#review191375 --- src/tests/health_check_tests.cpp Lines 1972 (patched)

Re: Review Request 61473: Do not kill non partition aware tasks.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61473/ --- (Updated Nov. 17, 2017, 7:11 p.m.) Review request for mesos, James Peach,

Re: Review Request 63888: Updated composing containerizer tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63888/#review191373 --- src/tests/containerizer/composing_containerizer_tests.cpp Line

Re: Review Request 63915: Reduced tasks copying during agent reregistration.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63915/#review191369 --- FAIL: mesos-java failed to build. Reviews applied: `['63628',

Re: Review Request 63887: Fixed `wait()` and `destroy()` in composing containerizer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63887/#review191368 --- src/slave/containerizer/composing.cpp Line 634 (original), 633

Re: Review Request 63887: Fixed `wait()` and `destroy()` in composing containerizer.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63887/#review191331 --- src/slave/containerizer/composing.cpp Lines 382-384 (original),

Re: Review Request 63901: WIP: Added operator API to update and remove resource provider configs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63901/#review191363 --- include/mesos/agent/agent.proto Lines 82 (patched)

Re: Review Request 63732: Reconciled offer operations between agent and master.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63732/ --- (Updated Nov. 17, 2017, 6:26 p.m.) Review request for mesos, Jie Yu and Jan

Re: Review Request 63732: Reconciled offer operations between agent and master.

> On Nov. 16, 2017, 2:05 a.m., Jie Yu wrote: > > src/master/master.cpp > > Lines 7103-7120 (patched) > > > > > > I feel that long term, this way of removing all and then add back will > > probably not work. > >

Re: Review Request 63732: Reconciled offer operations between agent and master.

> On Nov. 16, 2017, 1:43 a.m., Jie Yu wrote: > > src/master/master.cpp > > Lines 7119 (patched) > > > > > > Ditto. You probably want to change `addOfferOperation` to not update > > total resources. That means you

Review Request 63917: Renamed resource provider message UpdateTotalResources to UpdateState.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63917/ --- Review request for mesos, Chun-Hung Hsiao, Jie Yu, and Jan Schlicht.

Review Request 63918: Updated ResourceProviderMessage stringification with recent changes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63918/ --- Review request for mesos, Jie Yu and Jan Schlicht. Repository: mesos

Re: Review Request 63730: Passed operations from resource provider to agent.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63730/ --- (Updated Nov. 17, 2017, 6:24 p.m.) Review request for mesos, Jie Yu and Jan

Re: Review Request 63731: Reconciled pending resource provider operations in agent.

> On Nov. 16, 2017, 1:23 a.m., Jie Yu wrote: > > src/slave/slave.cpp > > Line 6722 (original), 6722 (patched) > > > > > > I suggest we change this to `UPDATE_STATE` to align with the RP API > > because we also

Re: Review Request 63842: Allowed removing non-terminal offer operations.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63842/ --- (Updated Nov. 17, 2017, 6:24 p.m.) Review request for mesos, Greg Mann, Jie

Re: Review Request 63842: Allowed removing non-terminal offer operations.

> On Nov. 15, 2017, 10:05 p.m., Jie Yu wrote: > > src/master/master.cpp > > Lines 9816-9817 (original) > > > > > > If you remove this CHECK, i'd like to see the resoures used by the > > operation being released.

Re: Review Request 63731: Reconciled pending resource provider operations in agent.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63731/ --- (Updated Nov. 17, 2017, 6:24 p.m.) Review request for mesos, Greg Mann, Jie

Re: Review Request 63844: Removed acknowledged offer operation status updates.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63844/ --- (Updated Nov. 17, 2017, 6:24 p.m.) Review request for mesos, Greg Mann, Jie

Re: Review Request 63843: Implemented a test of offer operation reconcilation.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63843/ --- (Updated Nov. 17, 2017, 6:24 p.m.) Review request for mesos, Greg Mann, Jie

Re: Review Request 63897: WIP. Add prototype of master changes.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63897/#review191275 --- src/master/master.hpp Lines 171 (patched)

Re: Review Request 63912: Changed agent (re-)registration to set resource versions.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63912/#review191361 --- PASS: Mesos patch 63912 was successfully built and tested.

Re: Review Request 63910: Added 3 tests for TCP/HTTP(S) health check support for Docker container.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63910/#review191360 --- PASS: Mesos patch 63910 was successfully built and tested.

Re: Review Request 55335: Backfilled required fields in TaskInfo in MesosContainerizer* tests.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55335/ --- (Updated Nov. 17, 2017, 4:52 p.m.) Review request for mesos, Gilbert Song,

Re: Review Request 62997: Added checkpoint and recover capability for layers in provisioner.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62997/ --- (Updated Nov. 17, 2017, 4:51 p.m.) Review request for mesos, Gilbert Song,

Re: Review Request 56721: Implemented pruneImages with a mark and sweep in docker store.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56721/ --- (Updated Nov. 17, 2017, 4:51 p.m.) Review request for mesos, Gilbert Song,

Re: Review Request 56721: Implemented pruneImages with a mark and sweep in docker store.

> On Nov. 17, 2017, 2:07 a.m., Gilbert Song wrote: > > src/slave/containerizer/mesos/provisioner/provisioner.cpp > > Lines 469 (patched) > > > > > > you dont need `this` for this lambda I think we need `this` here

Re: Review Request 60471: Added tests for pruneImages for containerizer and provisioner.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60471/ --- (Updated Nov. 17, 2017, 4:50 p.m.) Review request for mesos, Gilbert Song and

Re: Review Request 56722: Added a new operator API for `PRUNE_IMAGES`.

> On Nov. 17, 2017, 1:24 a.m., Gilbert Song wrote: > > src/slave/http.cpp > > Lines 2302-2304 (patched) > > > > > > one thing to notice is that the current interface returns > > `Future`, so we dont have a way to

Re: Review Request 56722: Added a new operator API for `PRUNE_IMAGES`.

> On Nov. 17, 2017, 1:24 a.m., Gilbert Song wrote: > > src/slave/http.cpp > > Lines 2299 (patched) > > > > > > instead of passing in the `acceptType`, we might want to pass the > > containerId and construct the

Re: Review Request 56722: Added a new operator API for `PRUNE_IMAGES`.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56722/ --- (Updated Nov. 17, 2017, 4:48 p.m.) Review request for mesos, Gilbert Song,

Re: Review Request 62853: Added test for `PRUNE_IMAGES` operator API call.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62853/ --- (Updated Nov. 17, 2017, 4:48 p.m.) Review request for mesos, Gilbert Song and

Re: Review Request 63901: WIP: Added operator API to update and remove resource provider configs.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63901/#review191338 --- PASS: Mesos patch 63901 was successfully built and tested.

Review Request 63914: Changed agent reregistration to work with message directly.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63914/ --- Review request for mesos, Benjamin Mahler and Michael Park. Bugs: MESOS-6972

Review Request 63915: Reduced tasks copying during agent reregistration.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63915/ --- Review request for mesos, Benjamin Mahler and Michael Park. Bugs: MESOS-6972

Review Request 63913: Replaced std::shared_ptr with std::unique_ptr in Future.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63913/ --- Review request for mesos, Benjamin Mahler and Michael Park. Bugs: MESOS-6972

Re: Review Request 63751: Triggered 'ApplyOfferOperationMessage' for agent local resources.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63751/ --- (Updated Nov. 17, 2017, 3 p.m.) Review request for mesos, Benjamin Bannier and

Re: Review Request 63910: Added 3 tests for TCP/HTTP(S) health check support for Docker container.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63910/ --- (Updated Nov. 17, 2017, 9:35 p.m.) Review request for mesos, Alexander

Review Request 63910: Added 3 tests for TCP/HTTP(S) health check support for Docker container.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63910/ --- Review request for mesos, Alexander Rukletsov and Avinash sridharan. Bugs:

Review Request 63912: Changed agent (re-)registration to set resource versions.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63912/ --- Review request for mesos, Benjamin Bannier and Jie Yu. Repository: mesos

Review Request 63911: Bumped up the number of args allowed in some libprocess templates.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63911/ --- Review request for mesos, Benjamin Bannier and Jie Yu. Repository: mesos

Re: Review Request 63794: Added a new member field `ipv6` to the `CheckerProcess` class.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63794/ --- (Updated Nov. 17, 2017, 8:58 p.m.) Review request for mesos, Alexander

Re: Review Request 63795: Made `mesos-tcp-connect` support IPv6.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63795/ --- (Updated Nov. 17, 2017, 8:57 p.m.) Review request for mesos, Alexander

Re: Review Request 63795: Made `mesos-tcp-connect` support IPv6.

> On Nov. 17, 2017, 2:54 a.m., Avinash sridharan wrote: > > src/checks/tcp_connect.cpp > > Lines 90 (patched) > > > > > > Why do we need this? > > > > `net::IP::in` and `net::IP::in6` already give this

Re: Review Request 63895: Fixed flaky test UnreachableAgentReregisterAfterFailover test.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63895/#review191318 --- PASS: Mesos patch 63895 was successfully built and tested.

Re: Review Request 63900: Downgraded the logging level of socket shutdown failures.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63900/#review191317 --- PASS: Mesos patch 63900 was successfully built and tested.

Re: Review Request 60471: Added tests for pruneImages for containerizer and provisioner.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60471/#review191309 --- FAIL: Some Mesos libprocess-tests failed. Reviews applied: