Looks good to me.
Regards,
Rajeev Chamyal
-Original Message-
From: Prasanta Sadhukhan
Sent: 26 October 2016 12:54
To: Rajeev Chamyal; Alexandr Scherbatiy; swing-dev@openjdk.java.net
Subject: Re: [9] RFR JDK-8168657: [PIT] Still, on Windows test
always fails:
java/awt/SplashScreen
Hello Sergey,
I have removed the html file.
http://cr.openjdk.java.net/~rchamyal/8150176/webrev.03/
Regards,
Rajeev Chamyal
-Original Message-
From: Sergey Bylokhov
Sent: 14 September 2016 23:39
To: Alexandr Scherbatiy; Rajeev Chamyal; swing-dev@openjdk.java.net
Subject: Re: [9
Hello Alexandr,
Thanks for the review.
Please review the webrev updated as per review comments.
http://cr.openjdk.java.net/~rchamyal/8150176/webrev.03/
Regards,
Rajeev Chamyal
From: Alexandr Scherbatiy
Sent: 12 September 2016 20:07
To: Rajeev Chamyal; swing-dev@openjdk.java.net
-8154551
Regards,
Rajeev Chamyal
From: Alexandr Scherbatiy
Sent: 14 June 2016 15:21
To: Rajeev Chamyal; swing-dev@openjdk.java.net; Sergey Bylokhov
Subject: Re: [9] Review request for JDK-8150176 [hidpi] wrong
resolution variant of multi-res. image is used for TrayIcon
On 6/13/2016 3
Looks good to me.
Regards,
Rajeev Chamyal
From: Avik Niyogi
Sent: 08 September 2016 11:00
To: Rajeev Chamyal
Cc: Alexandr Scherbatiy; swing-dev@openjdk.java.net
Subject: Re: 8163274: [TEST_BUG][macosx] apparent regression:
javax/swing/JColorChooser/Test7194184.java
A gentle
Looks good to me.
Regards,
Rajeev Chamyal
From: Alexandr Scherbatiy
Sent: 06 September 2016 16:16
To: Avik Niyogi; Rajeev Chamyal; swing-dev@openjdk.java.net
Subject: Re: 8163274: [TEST_BUG][macosx] apparent regression:
javax/swing/JColorChooser/Test7194184.java
The fix looks good
Looks good to me.
Regards,
Rajeev Chamyal
From: Avik Niyogi
Sent: 24 August 2016 14:14
To: Rajeev Chamyal
Cc: Alexander Scherbatiy; swing-dev@openjdk.java.net
Subject: Re: 8163161: [PIT][TEST_BUG] increase timeout in
javax/swing/plaf/nimbus/8057791/bug8057791.java
Hi All,
A gentle
Hello Yuri,
I have attached a snapshot of button in JBS. The button icon border is Yellow.
https://bugs.openjdk.java.net/browse/JDK-8163160
Regards,
Rajeev Chamyal
-Original Message-
From: Yuri Nesterenko
Sent: 19 August 2016 16:38
To: Rajeev Chamyal; Sergey Bylokhov; Alexander
Hello Yuri,
Can you please review below webrev.
Webrev: http://cr.openjdk.java.net/~rchamyal/8163160/webrev.00/
Regards,
Rajeev Chamyal
-Original Message-
From: Rajeev Chamyal
Sent: 16 August 2016 18:45
To: Sergey Bylokhov; Alexander Scherbatiy; swing-dev@openjdk.java.net
Subject: Re
Hello Amarish,
Can you add this bug id to existing regression test case.
Regards,
Rajeev Chamyal
> On 15-Aug-2016, at 3:13 PM, Ambarish Rapte <ambarish.ra...@oracle.com> wrote:
>
> Hi,
> Please review fix for JDK9,
> Bug: https://bugs.openjd
Looks ok to me.
Regards,
Rajeev Chamyal
From: Alexandr Scherbatiy
Sent: 17 August 2016 12:26
To: Avik Niyogi; Rajeev Chamyal; swing-dev@openjdk.java.net
Subject: Re: 8163169: [PIT][TEST_BUG] fix to JDK-8161470 doesn't
work
The fix looks good to me.
Thanks,
Alexandr.
On 8/17/2016
Hello Sergey,
Thanks for the review. In the bug its reported that border of button is grey.
Instead of button border icon border should be checked. I have updated test
instructions for this.
Regards,
Rajeev Chamyal
-Original Message-
From: Sergey Bylokhov
Sent: 16 August 2016 18:28
Hello All,
Please review the following webrev.
Webrev: http://cr.openjdk.java.net/~rchamyal/8163160/webrev.00/
Bug : https://bugs.openjdk.java.net/browse/JDK-8163160
Issue : manual tag was missing in test.
Regards,
Rajeev Chamyal
Hello All,
Please review the following webrev.
Bug: https://bugs.openjdk.java.net/browse/JDK-8161913
Webrev : http://cr.openjdk.java.net/~rchamyal/8161913/webrev.00/
Issue : Test was failing when run repeatedly.
Fix: Added delay in test.
Regards,
Rajeev Chamyal
Linked to 8147648, added prefix Hidpi.
Regards,
Rajeev Chamyal
From: Semyon Sadetsky
Sent: 22 July 2016 15:51
To: Rajeev Chamyal; Alexander Scherbatiy; swing-dev@openjdk.java.net; Sergey
Bylokhov
Subject: Re: [9] Review Request JDK-8147648 [hidpi] multiresolution
image: wrong
Hello Semyon,
Below is the bug id.
https://bugs.openjdk.java.net/browse/JDK-8162387
Regards,
Rajeev Chamyal
From: Semyon Sadetsky
Sent: 22 July 2016 15:21
To: Rajeev Chamyal; Alexander Scherbatiy; swing-dev@openjdk.java.net; Sergey
Bylokhov
Subject: Re: [9] Review Request JDK
/
Regards,
Rajeev Chamyal
From: Alexandr Scherbatiy
Sent: 21 July 2016 20:42
To: Rajeev Chamyal; Semyon Sadetsky; swing-dev@openjdk.java.net; Sergey Bylokhov
Subject: Re: [9] Review Request JDK-8147648 [hidpi] multiresolution
image: wrong resolution variant is used as icon in the Unity pane
and height passed to this API is that of base image not of the spot.
Applications can control this behaviour by overriding this API in derived
classes.
Regards,
Rajeev Chamyal
From: Alexandr Scherbatiy
Sent: 21 July 2016 15:09
To: Semyon Sadetsky; Rajeev Chamyal; swing-dev
Hello Semyon,
Following is the new bug.
https://bugs.openjdk.java.net/browse/JDK-8161995
Regards,
Rajeev Chamyal
From: Semyon Sadetsky
Sent: 21 July 2016 16:14
To: Rajeev Chamyal; Alexander Scherbatiy; swing-dev@openjdk.java.net
Subject: Re: Swing Dev>[9] Review Request JDK-8158
Looks good to me.
Regards,
Rajeev Chamyal
-Original Message-
From: Ajit Ghaisas
Sent: 21 July 2016 15:13
To: Rajeev Chamyal; Alexander Scherbatiy; swing-dev@openjdk.java.net
Subject: RE: [9] Fix for JDK-7096375 : Swing ignores first click
after decreasing system's time
Fixed a typo
Hello Semyon,
I will be creating a new bug for the old issue.
Regards,
Rajeev Chamyal
From: Semyon Sadetsky
Sent: 21 July 2016 15:59
To: Rajeev Chamyal; Alexander Scherbatiy; swing-dev@openjdk.java.net
Subject: Re: Swing Dev>[9] Review Request JDK-8158918 setExtendedStat
Looks fine to me.
Regards,
Rajeev Chamyal
From: Avik Niyogi
Sent: 20 July 2016 11:52
To: Rajeev Chamyal
Cc: Praveen Srivastava; Alexander Scherbatiy; swing-dev@openjdk.java.net
Subject: Re: 8161470: [TEST_BUG] Failure
javax/swing/JRadioButton/FocusTraversal/FocusTraversal.java
Hi
Hello Semyon,
Please review the updated webrev.
http://cr.openjdk.java.net/~rchamyal/8147648/webrev.03/
Regards,
Rajeev Chamyal
From: Semyon Sadetsky
Sent: 14 July 2016 16:58
To: Rajeev Chamyal; swing-dev@openjdk.java.net; Sergey Bylokhov; Alexander
Scherbatiy
Subject: Re: [9
Hello Sergey,
It works fine on linux.
Regards,
Rajeev Chamyal
-Original Message-
From: Sergey Bylokhov
Sent: 20 July 2016 01:13
To: Rajeev Chamyal; Semyon Sadetsky; Alexander Scherbatiy;
swing-dev@openjdk.java.net
Subject: Re: Review Request JDK-8159168 [hidpi] Window.setShape
Looks good to me.
Regards,
Rajeev Chamyal
From: Avik Niyogi
Sent: 19 July 2016 12:12
To: Alexandr Scherbatiy
Cc: Rajeev Chamyal; Semyon Sadetsky; Yuri Nesterenko; swing-dev@openjdk.java.net
Subject: Re: 8160438: [PIT][macosx] [TEST_BUG]
javax/swing/plaf/nimbus/8057791/bug8057791.java
Hello Alexandr,
Please review the updated webrev.
http://cr.openjdk.java.net/~rchamyal/8158918/webrev.01/
Regards,
Rajeev Chamyal
From: Alexandr Scherbatiy
Sent: 14 July 2016 20:54
To: Rajeev Chamyal; Semyon Sadetsky; swing-dev@openjdk.java.net
Subject: Re: Swing Dev>[9] Rev
Hello Semyon,
Please review the updated webrev as per review comments.
http://cr.openjdk.java.net/~rchamyal/8159168/webrev.04/
Regards,
Rajeev Chamyal
From: Semyon Sadetsky
Sent: 11 July 2016 14:29
To: Rajeev Chamyal; Alexander Scherbatiy; swing-dev@openjdk.java.net; Sergey
Hello Semyon,
Thanks for the review. Yes, mouse move is not required I have removed it.
Please review the updated webrev.
http://cr.openjdk.java.net/~rchamyal/8159168/webrev.03/
Regards,
Rajeev Chamyal
From: Semyon Sadetsky
Sent: 11 July 2016 12:30
To: Rajeev Chamyal; Alexander
Hello Alexandr,
Please review the updated webrev.
http://cr.openjdk.java.net/~rchamyal/8158205/webrev.01/
Test was always passing without fix also. I have converted it into manual test.
Regards,
Rajeev Chamyal
From: Alexandr Scherbatiy
Sent: 05 July 2016 13:29
To: Rajeev Chamyal
Hello Ajit,
The fix looks fine to me.
Regarding test: JTable and JTree tests exceed 80 char limit.
Regards,
Rajeev Chamyal
From: Alexandr Scherbatiy
Sent: 07 July 2016 15:17
To: Ajit Ghaisas; Rajeev Chamyal; swing-dev@openjdk.java.net
Subject: Re: [9] Fix for JDK-6567433
Hello Alexandr,
Please review updated webrev.
http://cr.openjdk.java.net/~rchamyal/8159168/webrev.02/
Regards,
Rajeev Chamyal
From: Alexandr Scherbatiy
Sent: 05 July 2016 11:38
To: Rajeev Chamyal; swing-dev@openjdk.java.net; Sergey Bylokhov
Subject: Re: Review Request JDK-8159168
Hello Alexandr,
Thanks for the review.
As per windows specification X & Y scale are always equal that's why I have put
scaleX == scaleY check.
But it may change in future so I have removed this check.
http://cr.openjdk.java.net/~rchamyal/8159168/webrev.01/
Regards,
Rajeev Cha
the WComponentPeer::applyShape to update shape based on system
scale.
Regards,
Rajeev Chamyal
Hello Sergey,
Could you please review this fix.
http://cr.openjdk.java.net/~rchamyal/8147648/webrev.01/
Regards,
Rajeev Chamyal
From: Alexandr Scherbatiy
Sent: 22 June 2016 15:46
To: Rajeev Chamyal; Sergey Bylokhov; swing-dev@openjdk.java.net
Subject: Re: [9] Review Request JDK
Looks good to me.
Regards,
Rajeev Chamyal
From: Alexandr Scherbatiy
Sent: 24 June 2016 17:01
To: Prasanta Sadhukhan; Rajeev Chamyal; swing-dev@openjdk.java.net
Subject: Re: [9] RFR JDK-8159068:The rendering of JTable is broken
The fix looks good to me.
Thanks,
Alexandr.
On 6/24
lFrame all are passing.
http://cr.openjdk.java.net/~rchamyal/8159152/webrev.01/
Regards,
Rajeev Chamyal
From: Alexandr Scherbatiy
Sent: 21 June 2016 16:48
To: Rajeev Chamyal; Sergey Bylokhov; swing-dev@openjdk.java.net
Subject: Re: Review Request JDK-8159152 Ctrl+F6, Ctrl+F5 doe
Hello Alexandr,
Thanks for the review. I have updated webrev as per comments.
http://cr.openjdk.java.net/~rchamyal/8147648/webrev.01/
Regards,
Rajeev Chamyal
From: Alexandr Scherbatiy
Sent: 21 June 2016 17:37
To: Rajeev Chamyal; Sergey Bylokhov; swing-dev@openjdk.java.net
Subject
to find the correct resolution
variant image in current implementation.
Fix: Applied the screen transforms to graphics object.
Regards,
Rajeev Chamyal
on the desktop.
Fix: Updated the iconifyFrame method so that frame cache updates properly on
internal frame remove and icon addition to desktop.
Regards,
Rajeev Chamyal
Hello Prem,
testResult variable is accessed in 2 different threads. It should be declared
volatile.
Regards,
Rajeev Chamyal
From: Alexandr Scherbatiy
Sent: 10 June 2016 19:53
To: Prem Balakrishnan; Sergey Bylokhov; swing-dev@openjdk.java.net
Subject: Re: Review Request JDK-8152419
Hello Alexandr,
Thanks for the review. I have updated the webrev as per review comments.
http://cr.openjdk.java.net/~rchamyal/8150176/webrev.01/
I tried drawing the image directly to paint graphics without buffered image and
it was getting cropped.
Regards,
Rajeev Chamyal
From
Looks good to me.
Regards,
Rajeev Chamyal
-Original Message-
From: Alexandr Scherbatiy
Sent: 10 June 2016 13:06
To: Ajit Ghaisas; Sergey Bylokhov; Rajeev Chamyal; swing-dev@openjdk.java.net
Subject: Re: Fix for JDK-8065861 : Pressing Esc does not set 'canceled'
property
Hello Alexandr,
Please review the updated webrev.
http://cr.openjdk.java.net/~rchamyal/8159135/webrev.01/
Regards,
Rajeev Chamyal
From: Alexandr Scherbatiy
Sent: 10 June 2016 19:52
To: Rajeev Chamyal; Sergey Bylokhov; swing-dev@openjdk.java.net
Subject: Re: [9] Review request
only.
Fix: checking for other color values(green and blue) also.
Regards,
Rajeev Chamyal
to select the correct
image.
Regards,
Rajeev Chamyal
Looks good to me.
Regards,
Rajeev Chamyal
From: Avik Niyogi
Sent: 31 May 2016 13:28
To: Rajeev Chamyal; Alexander Scherbatiy; swing-dev@openjdk.java.net
Subject: Re: Review request for 8132771: [TEST_BUG][macosx] Test
javax/swing/JTree/DnD/LastNodeLowerHalfDrop.java fails for MacOSX
Hello Alexandr,
Please review the updated webrev.
http://cr.openjdk.java.net/~rchamyal/8146319/webrev.02/
Update: Updated code to use try with resources.
Regards,
Rajeev Chamyal
From: Alexandr Scherbatiy
Sent: 01 June 2016 19:30
To: Rajeev Chamyal; Sergey Bylokhov; swing-dev
Hello Alexandr,
Please review the updated webrev.
http://cr.openjdk.java.net/~rchamyal/8158358/webrev.01/
Regards,
Rajeev Chamyal
From: Alexandr Scherbatiy
Sent: 02 June 2016 01:20
To: Rajeev Chamyal; Sergey Bylokhov; swing-dev@openjdk.java.net
Subject: Re: [9] Review request
Hello All,
Please review the following webrev
Webrev : http://cr.openjdk.java.net/~rchamyal/8158358/webrev.00/
Bug : https://bugs.openjdk.java.net/browse/JDK-8158358
Fix : Fixed the compilation error.
Regards,
Rajeev Chamyal
Hello Semyon,
Thanks for the review. Please review the updated webrev.
http://cr.openjdk.java.net/~rchamyal/8146319/webrev.01/
Update: Updated test to use File.createTempFile() for creating temp file.
Regards,
Rajeev Chamyal
From: Semyon Sadetsky
Sent: 01 June 2016 15:01
block.
Regards,
Rajeev Chamyal
Hello Avik,
The frame should be disposed in case of exception also.
Regards,
Rajeev Chamyal
From: Avik Niyogi
Sent: 31 May 2016 11:14
To: Rajeev Chamyal; Alexander Scherbatiy; swing-dev@openjdk.java.net
Subject: Review request for 8132771: [TEST_BUG][macosx] Test
javax/swing
Fix looks fine to me.
Regards,
Rajeev Chamyal
-Original Message-
From: Sergey Bylokhov
Sent: 25 May 2016 22:12
To: Ajit Ghaisas; swing-dev@openjdk.java.net; Alexander Scherbatiy; Rajeev
Chamyal
Subject: Re: Fix for JDK-6827800 : Default button is activated even when it is
invisible
Looks ok to me.
Can you please add specific class imports instead of *.
Regards,
Rajeev Chamyal
From: Avik Niyogi
Sent: 25 May 2016 12:53
To: Alexander Scherbatiy
Cc: Rajeev Chamyal; swing-dev@openjdk.java.net
Subject: Re: Review request for 8144161: [TESTBUG] [macosx] Test
javax
Hello Phil,
Please review the updated webrev.
http://cr.openjdk.java.net/~rchamyal/8147521/webrev.07/
Changes: Updated the Javadoc.
Added the following note:
* This method is intended to be used only by PopupFactory sub-classes.
Regards,
Rajeev Chamyal
-Original Message-
From
to JFormattedTextFiled.
Fix: Updated Formatted text field foreground and background properties.
Regards,
Rajeev Chamyal
Hello Ajit,
Fix looks fine to me. Few comments about test case.
1) @run main is missing in test.
2) JFrame dispose should be done in swing thread.
Regards,
Rajeev Chamyal
-Original Message-
From: Ajit Ghaisas
Sent: 06 May 2016 12:52
To: Alexander Scherbatiy; Sergey Bylokhov; swing-dev
Hello All,
Please review the updated webrev.
http://cr.openjdk.java.net/~rchamyal/8147521/webrev.06/
Changes: Updated the documentation.
Regards,
Rajeev Chamyal
-Original Message-
From: Rajeev Chamyal
Sent: 12 May 2016 13:32
To: Sergey Bylokhov; Alexander Scherbatiy; swing-dev
Hello Sergey,
Please review the updated webrev as per review comments.
http://cr.openjdk.java.net/~rchamyal/8147521/webrev.05/
Regards,
Rajeev Chamyal
-Original Message-
From: Sergey Bylokhov
Sent: 11 May 2016 18:16
To: Rajeev Chamyal; Alexander Scherbatiy; swing-dev@openjdk.java.net
Hello Alexandr,
Please review the updated webrev.
http://cr.openjdk.java.net/~rchamyal/8147521/webrev.04/
Regards,
Rajeev Chamyal
-Original Message-
From: Alexander Scherbatiy
Sent: 11 May 2016 16:29
To: Rajeev Chamyal
Cc: swing-dev@openjdk.java.net; Sergey Bylokhov; Alan Snyder
.
Regards,
Rajeev Chamyal
-Original Message-
From: Alan Snyder [mailto:javali...@cbfiddle.com]
Sent: 11 May 2016 03:39
To: Alexandr Scherbatiy
Cc: swing-dev@openjdk.java.net
Subject: Re: [9] Review request for JDK-8147521 [macosx] Internal
API Usage: setPopupType used to force creation
eOperation(JFrame.EXIT_ON_CLOSE)" can cause a test
failure in some jtreg modes(see JDK-8154365)
Removed
- Is it necessary to make this test "win only", can it cover other look and
feels and platforms?
This issue is with Windows look and feel only. For other LAF and platforms it
works fine.
Hello All,
Please let me know your thoughts on the below webrev.
http://cr.openjdk.java.net/~rchamyal/8147521/webrev.02/
This approach is similar to Aqua as suggested by Sergey.
Regards,
Rajeev Chamyal
-Original Message-
From: Alexandr Scherbatiy
Sent: 11 May 2016 01:16
To: Alan
Chamyal
-Original Message-
From: Alexandr Scherbatiy
Sent: 10 May 2016 20:06
To: Sergey Bylokhov; Rajeev Chamyal; swing-dev@openjdk.java.net
Subject: Re: [9] Review request for JDK-8147521 [macosx] Internal
API Usage: setPopupType used to force creation of heavyweight popup
On 5/10/2016 3
Hello Alexandr,
Please review the updated webrev.
http://cr.openjdk.java.net/~rchamyal/8147521/webrev.01/
Update : Implemented review comments.
Regards,
Rajeev Chamyal
From: Alexandr Scherbatiy
Sent: 10 May 2016 16:07
To: Rajeev Chamyal; Sergey Bylokhov; swing-dev
to be heavyweight.
I am not sure about applications using MEDIUM_WEIGHT_POPUP, but in JDK source
ToolTipManager.java showTipWindow method sets popup to be MEDIUM_WEIGHT_POPUP.
Regards,
Rajeev Chamyal
From: Alexandr Scherbatiy
Sent: 10 May 2016 12:02
To: Rajeev Chamyal; Sergey Bylokhov
these methods to set or return different types of
popups.
Following values can be passed to setPopupType.
0 : LIGHT_WEIGHT_POPUP
1 : MEDIUM_WEIGHT_POPUP
2: HEAVY_WEIGHT_POPUP
Regards,
Rajeev Chamyal
Hello Sergey,
Please review the updated webrev.
http://cr.openjdk.java.net/~rchamyal/8152981/webrev.01/
Update: Added the check Icon install code in installDefaults to a private
method. Calling same method on propertychange.
Regards,
Rajeev Chamyal
-Original Message-
From: Sergey
Hello Sergey,
Checked the tests with 1.9.0-ea-b86 build.
All tests failed.
Regards,
Rajeev Chamyal
-Original Message-
From: Sergey Bylokhov
Sent: 02 May 2016 19:05
To: Rajeev Chamyal; swing-dev@openjdk.java.net; Avik Niyogi
Subject: Re: [9] Review request for JDK-8153282 [TEST_BUG
Looks good to me.
Regards,
Rajeev Chamyal
From: Avik Niyogi
Sent: 24 March 2016 12:54
To: Rajeev Chamyal; Alexander Scherbatiy; Sergey Bylokhov;
swing-dev@openjdk.java.net
Subject: Re: Review Request of 8137169 : [macosx] Incorrect minimal
heigh of JTabbedPane with more tabs
Hi
Looks good to me.
Regards,
Rajeev Chamyal
-Original Message-
From: Semyon Sadetsky
Sent: 24 March 2016 11:45
To: Prem Balakrishnan; Sergey Bylokhov; Rajeev Chamyal; Alexander Scherbatiy;
swing-dev@openjdk.java.net
Subject: Re: Review Request for 6439354 : Win L: TitledBorder colors
Hello Avik,
x variable on line 2195 is not used anywhere. Do we need for loop also?
Regards,
Rajeev Chamyal
From: Avik Niyogi
Sent: 24 March 2016 12:19
To: Alexander Scherbatiy
Cc: Sergey Bylokhov; Rajeev Chamyal; swing-dev@openjdk.java.net
Subject: Re: Review Request of 8137169
Hello Sergey,
I had found below link about pre tag which states A P tag is strictly not
permitted inside PRE, but if a browser encounters one, it should treat it as
two newlines.
http://www.htmlhelp.com/reference/wilbur/block/pre.html
Regards,
Rajeev Chamyal
-Original Message-
From
listener determines the state of arrow buttons and source of
mouse events and based on these it stops the timer.
Regards,
Rajeev Chamyal
-Original Message-
From: Alexander Scherbatiy
Sent: 13 January 2016 21:48
To: Rajeev Chamyal
Cc: Sergey Bylokhov; swing-dev@openjdk.java.net
Subject: Re
Hello All,
Gentle reminder.
Please review the fix.
Bug : https://bugs.openjdk.java.net/browse/JDK-8150225
Webrev: http://cr.openjdk.java.net/~rchamyal/8150225/webrev.00/
Regards,
Rajeev Chamyal
-Original Message-
From: Rajeev Chamyal
Sent: 09 March 2016 15:58
To: Sergey Bylokhov
Test code looks good to me.
Regards,
Rajeev Chamyal
From: Avik Niyogi
Sent: 21 March 2016 14:02
To: Manajit Halder; Alexander Scherbatiy
Cc: swing-dev@openjdk.java.net; Rajeev Chamyal
Subject: Re: Review Request of 8148555: [macosx] An uncaught
exception was raised entering Emoji
Hello Avik,
I can’t comment on objective C code.
As far as test is concerned below are my comments.
1) UI should be created in Swing thread.
2) Switch case in actionPerformed should be refactored.
Regards,
Rajeev Chamyal
From: Avik Niyogi
Sent: 21 March 2016 12:20
Hello Sergey,
I have updated the test as per review comments.
http://cr.openjdk.java.net/~rchamyal/8145896/webrev.02/
Regards,
Rajeev Chamyal
-Original Message-
From: Sergey Bylokhov
Sent: 09 March 2016 18:57
To: Rajeev Chamyal; swing-dev@openjdk.java.net
Subject: Re: Review request
Hello Sergey,
I have run JCK tests for HTMLWriter and AbstractWriter with this fix and all
passed.
Regards,
Rajeev Chamyal
-Original Message-
From: Sergey Bylokhov
Sent: 09 March 2016 15:54
To: Rajeev Chamyal; Alexander Scherbatiy; swing-dev@openjdk.java.net
Subject: Re: [9] Review
JDK-7104635
Fix: Reverted the fix for JDK-7104635 and added a new method in HTMLWriter.java
to check if P tag is within Pre tag.
Decrement indentation is skipped if P tag is with a Pre tag.
Regards,
Rajeev Chamyal
Hello Sergey,
Could you please review the updated webrev.
http://cr.openjdk.java.net/~rchamyal/8145896/webrev.01/
Regards,
Rajeev Chamyal
On 11-01-2016 15:27, Rajeev Chamyal wrote:
Hello Sergey,
Could you please review the updated webrev.
http://cr.openjdk.java.net/~rchamyal/8145896/webrev
Hello Avik,
Fix looks good to me.
Can you please check if test case works on windows and linux.
Regards,
Rajeev Chamyal
From: Avik Niyogi
Sent: 29 February 2016 09:46
To: Sergey Bylokhov; Alexander Scherbatiy; Rajeev Chamyal;
swing-dev@openjdk.java.net
Subject: Re: Review Request
Looks good to me.
Regards,
Rajeev Chamyal
From: Ajit Ghaisas
Sent: 17 February 2016 16:51
To: Rajeev Chamyal; Sergey Bylokhov; Alexander Scherbatiy;
swing-dev@openjdk.java.net
Subject: RE: [9] Review fix for JDK-8020039 : SynthTableHeaderUI
refers to possibly null parameter in cell
Hello Ajit,
Can you please if similar fix is required for other LAF windows ,Aqua etc.
Please add a regression test case also.
Regards,
Rajeev Chamyal
From: Ajit Ghaisas
Sent: 15 February 2016 17:30
To: Rajeev Chamyal; Sergey Bylokhov; Alexander Scherbatiy;
swing-dev
Looks good to me.
Regards,
Rajeev Chamyal
From: Prem Balakrishnan
Sent: 15 February 2016 14:22
To: Rajeev Chamyal; Alexander Scherbatiy
Cc: Sergey Bylokhov; Semyon Sadetsky; Ambarish Rapte; swing-dev@openjdk.java.net
Subject: RE: Review Request for 7126823
Hello Prem,
1) UI should be created in a swing thread so please update the createUI
method to use a swing thread.
2) Also please use SwingUtilities.invokeAndWait instead of
SwingUtilities.invokeLater.
Regards,
Rajeev Chamyal
From: Prem Balakrishnan
Sent: 11 February 2016 12
Hello Prem,
Did you test this fix for other LAF's as well.
Regards,
Rajeev Chamyal
From: Prem Balakrishnan
Sent: 09 February 2016 14:40
To: Sergey Bylokhov; Semyon Sadetsky; Alexander Scherbatiy; Ambarish Rapte;
swing-dev@openjdk.java.net; awt-...@openjdk.java.net
Subject: Review
The fix looks good to me.
Regards,
Rajeev Chamyal
From: Avik Niyogi
Sent: 09 February 2016 11:43
To: Sergey Bylokhov; Alexandr Scherbatiy; Rajeev Chamyal
Cc: swing-dev@openjdk.java.net
Subject: Re: Review Request of 8146321: [macosx] JInternalFrame
frame icon in wrong position on Mac L
Hello Alexandr,
Thanks for the review.
I have updated the webrev as suggested.
http://cr.openjdk.java.net/~rchamyal/8139213/webrev.01/
Regards,
Rajeev Chamyal
-Original Message-
From: Alexander Scherbatiy
Sent: 20 January 2016 17:04
To: Rajeev Chamyal
Cc: Sergey Bylokhov; Prasanta
Hello All,
Gentle reminder for review.
Regards,
Rajeev Chamyal
-Original Message-
From: Rajeev Chamyal
Sent: 13 January 2016 16:37
To: Sergey Bylokhov; Alexander Scherbatiy; Prasanta Sadhukhan;
swing-dev@openjdk.java.net
Subject: Review request for JDK-8139213 : Mac OS X Aqua Look
Hello Avik,
All exception caught during test should mark the test as failed. For example
not able to set any LAF should also be considered as test failure.
Regards,
Rajeev Chamyal
From: Avik Niyogi
Sent: 20 January 2016 10:20
To: Rajeev Chamyal
Cc: Alexander Scherbatiy; Sergey
that needs to be added to the minimum
size obtained from the parent class.
The current webrev code I feel is much cleaner than getting the size from
parent class.
Regards,
Rajeev Chamyal
From: Alexander Scherbatiy
Sent: 19 January 2016 21:00
To: Rajeev Chamyal; Sergey Bylokhov; Prasanta
in AquaButtonAreaLayout to consider default
button width and height while calculating minimum size for JOptionPane.
Regards,
Rajeev Chamyal
Hello All,
Gentle reminder to review the fix.
http://cr.openjdk.java.net/~rchamyal/8075084/webrev.02/
Regards,
Rajeev Chamyal
-Original Message-
From: Rajeev Chamyal
Sent: 27 December 2015 20:32
To: Sergey Bylokhov
Cc: swing-dev@openjdk.java.net
Subject: Re: Review request for JDK
Hello Sergey,
Could you please review the updated webrev.
http://cr.openjdk.java.net/~rchamyal/8145896/webrev.01/
Regards,
Rajeev Chamyal
-Original Message-
From: Rajeev Chamyal
Sent: 02 January 2016 11:46
To: Sergey Bylokhov; swing-dev@openjdk.java.net
Subject: RE: Review request
SynthToolBar is not checking if preferred size is set for the components.
Fix: Updated the minimumLayoutSize method of SynthToolBarUI.java to check
preferred size of components as well.
Regards,
Rajeev Chamyal
Hello Sergey,
Thanks for review I have updated webrev.
There was one more issue with fix to fix it , I have updated
BasicInternalFrameUI.java and added it to webrev.
http://cr.openjdk.java.net/~rchamyal/8145896/webrev.01/
Regards,
Rajeev Chamyal
-Original Message-
From: Sergey
Hello Sergey,
I have updated the webrev.
http://cr.openjdk.java.net/~rchamyal/8145060/webrev.01/
Regards,
Rajeev Chamyal
-Original Message-
From: Sergey Bylokhov
Sent: 29 December 2015 19:48
To: Rajeev Chamyal; Alexander Scherbatiy; Prasanta Sadhukhan;
swing-dev@openjdk.java.net
Hello All,
I need one more review for this webrev.
HYPERLINK
"http://cr.openjdk.java.net/%7Erchamyal/8145896/webrev.00/"http://cr.openjdk.java.net/~rchamyal/8145896/webrev.00/
Regards,
Rajeev Chamyal
From: Alexander Scherbatiy
Sent: 23 December 2015 19:44
To: Rajeev
waste time calculating
the position if we ignore the operation eventually?
[Rajeev Chamyal] Updated the code as suggested.
2) Yet your new errorMessage filed has the same issue. It should be marked
volatile since it's accessed from different threads without synchronization.
Actually I suggest
1 - 100 of 157 matches
Mail list logo
