Re: [sword-devel] Not user-friendly behavior in commentaries (should be continuous)

2021-01-21 Thread John Dudeck
This is the exact problem that I reported many months ago. It is related to the action of osis2mod, which is supposed to link commentary entries that cover a range of verses to all verses in that range. It worked in older versions of osis2mod, but there was a regression. In July 2020 I posted

Re: [sword-devel] Not user-friendly behavior in commentaries (should be continuous)

2020-08-01 Thread domcox
FIY: FreCJE 2.0.1 built with latest Sword svn (3773) has been uploaded in the Beta repository for testing purposes. Dom -- domcox Le lun. 27 juil. 2020 à 14:51, yvand a écrit : Hi Troy, Thank you very much for your help and for the quick fix !! I can confirm that now diatheke returns a c

Re: [sword-devel] Not user-friendly behavior in commentaries (should be continuous)

2020-07-27 Thread yvand
Hi Troy, Thank you very much for your help and for the quick fix !! I can confirm that now diatheke returns a commentary for Gen.1.1 and also for Gen.1.2, Gen.1.3, etc. when I use ranges for annotateRef. Again thank you all for your help for this bug! I will send again my module to Crosswire

Re: [sword-devel] Not user-friendly behavior in commentaries (should be continuous)

2020-07-26 Thread Troy A. Griffitts
Dear yvand, I believe I've fixed this in osis2mod.  osis2mod had code to deal with linking for ranges, but it checked for the necessity of a link with ListKey::getCount(), but this only tells how many elements are in the ListKey, not if any of those elements are ranges.  Oddly, it did have co

Re: [sword-devel] Not user-friendly behavior in commentaries (should be continuous)

2020-07-25 Thread Troy A. Griffitts
Hi yvand, No, it's a bug. annotateRef should accept ranges, not lists, and osisID should accept lists and not ranges. It looks like we have the right functionality there but attached to wrong XML feature. I am planning to add a link test case to our unit tests so we can be sure the fix this and

Re: [sword-devel] Not user-friendly behavior in commentaries (should be continuous)

2020-07-25 Thread yvand
I tried using annotateRef="Gen.1.1 Gen.1.2 Gen.1.3 Gen.1.4" instead of annotateRef="Gen.1.1-Gen.1.4", the behavior is different. diatheke gives a commentary for each verse, but I am not sure it is link entries... So now, I don't know what I can do to "fix" this bug (feature?). I am lost. I sti

Re: [sword-devel] Not user-friendly behavior in commentaries (should be continuous)

2020-07-24 Thread yvand
I tried to replace the first occurrence of annotateRef=".." with osisID="..", but it doesn't worked. With this change, nothing is stored at Gen.1.1 (contrary to before), neither at Gen.1.2, Gen.1.3. Le 24/07/2020 à 10:44, Troy A. Griffitts a écrit : Yes, linking is not working with annotat

Re: [sword-devel] Not user-friendly behavior in commentaries (should be continuous)

2020-07-24 Thread Troy A. Griffitts
Yes, linking is not working with annotateRef.  Thanks for the text.  If you wouldn't mind rebuilding the module and changing one entry to an osisID verse list and then testing again, it would really help finalize what exactly the problem is.  If osisID verse lists do link correctly, then we sim

Re: [sword-devel] Not user-friendly behavior in commentaries (should be continuous)

2020-07-24 Thread yvand
I tried it again, here is what I got: $ diatheke -b FreCJE -k Gen.1.2 Genesis 1:2: (FreCJE) $ diatheke -b FreCJE -k Gen.1.3 Genesis 1:3: (FreCJE) So nothing :-/ --yvand Le 24/07/2020 à 10:38, Troy A. Griffitts a écrit : Hi yvand, Well, that's not an authoritative test.  You need to ask

Re: [sword-devel] Not user-friendly behavior in commentaries (should be continuous)

2020-07-24 Thread Troy A. Griffitts
Hi yvand, Well, that's not an authoritative test.  You need to ask ONLY for verse Gen.1.2. SWORD has logic to "skip" contiguous linked verses, so diatheke might be taking advantage of that to prevent it from printing out the same commentary 19 times in a row.  The output you see is the desir

Re: [sword-devel] Not user-friendly behavior in commentaries (should be continuous)

2020-07-24 Thread yvand
Hey, Thanks Troy for your help. I use annotateRef and not osisID, as mentioned in https://wiki.crosswire.org/OSIS_Commentaries . I tried diatheke, here is what I got : diatheke -b FreCJE -k Gen.1 | head Genesis 1:1: annotateType="commentary" sID="gen1" type="section"/> type="x-p"/>La créatio

Re: [sword-devel] Not user-friendly behavior in commentaries (should be continuous)

2020-07-23 Thread Troy A. Griffitts
Hey yvand, My apologies for not getting back with you.  osis2mod isn't my domain these days, so I am not sure what the current behavior is for annotateRef.  I am pretty sure linking works, and the normal way for linking is the provide osisID="Gen.1.1 Gen.1.2 Gen1.3" You an test linking by us

Re: [sword-devel] Not user-friendly behavior in commentaries (should be continuous)

2020-07-23 Thread Greg Hellings
On Thu, Jul 23, 2020 at 12:44 PM yvand wrote: > Thanks Greg for your quick reply with explanation! > > I thought there was a bug and "link entries" were not taken into > consideration, when using osis2mod. Is there a simple way to test if a > commentary module contains link entries? I tried with

Re: [sword-devel] Not user-friendly behavior in commentaries (should be continuous)

2020-07-23 Thread yvand
Thanks Greg for your quick reply with explanation! I thought there was a bug and "link entries" were not taken into consideration, when using osis2mod. Is there a simple way to test if a commentary module contains link entries? I tried with mod2imp to export FreCJE but it only shows verses wit

Re: [sword-devel] Not user-friendly behavior in commentaries (should be continuous)

2020-07-23 Thread Greg Hellings
On Thu, Jul 23, 2020 at 11:44 AM yvand wrote: > Dear all, > > I am disappointed, because the issue still persists and nobody confirmed > the bug. Although I already send to the mailing the source of the module > FreCJE as asked and John Dudeck recently revived the issue with no > success. Below i

Re: [sword-devel] Not user-friendly behavior in commentaries (should be continuous)

2020-07-23 Thread yvand
Dear all, I am disappointed, because the issue still persists and nobody confirmed the bug. Although I already send to the mailing the source of the module FreCJE as asked and John Dudeck recently revived the issue with no success. Below is again my problem : I use OSIS commentary for "DayBy

Re: [sword-devel] Not user-friendly behavior in commentaries (should be continuous)

2020-07-15 Thread David Haslam
Greg would remind us all again that the Windows versions of Sword utilities are not officially supported. You’d need to have someone demonstrate whether the same issue arises when the modules are built under Linux. Best regards. David Sent from ProtonMail Mobile On Wed, Jul 15, 2020 at 18:40

Re: [sword-devel] Not user-friendly behavior in commentaries (should be continuous)

2020-07-15 Thread ref...@gmx.net
And that too, indeed. Modules are built on Linux. Only. PeterSent from my mobile. Please forgive shortness, typos and weird autocorrects. Original Message Subject: Re: [sword-devel] Not user-friendly behavior in commentaries (should be continuous)From: David Haslam To: SWORD

Re: [sword-devel] Not user-friendly behavior in commentaries (should be continuous)

2020-07-15 Thread John Dudeck
Has there been any action on this? John Dudeck Ok I've put together a repeatable demonstration of the problem. Here you will find two zip files: ftp://editionscle.com/pub/sword/hold/EC_LDPNBAtestOSIS2modBuild2893.zip ftp://editionscle.com/pub/sword/hold/EC_LDPNBAtestOSIS2modBuild3431.zi

Re: [sword-devel] Not user-friendly behavior in commentaries (should be continuous)

2020-06-05 Thread John Dudeck
Ok I've put together a repeatable demonstration of the problem. Here you will find two zip files: ftp://editionscle.com/pub/sword/hold/EC_LDPNBAtestOSIS2modBuild2893.zip ftp://editionscle.com/pub/sword/hold/EC_LDPNBAtestOSIS2modBuild3431.zip The files consist of two builds of the exact same O

Re: [sword-devel] Not user-friendly behavior in commentaries (should be continuous)

2020-06-05 Thread yvand
Of course I can send you the OSIS file. Here is a link to download it https://yapper.fr/~yvand/frecje_v2.0.zip so all can test the OSIS file. The module has been released as 2.0 version last month (by domcox, thanks again!), the .conf is in raw. I hope we can find the issue and fix it. Mayb

Re: [sword-devel] Not user-friendly behavior in commentaries (should be continuous)

2020-06-04 Thread Greg Hellings
On Thu, Jun 4, 2020 at 3:03 PM Dominique Corbex wrote: > On Thu, 4 Jun 2020 17:27:22 +0200 > yvand wrote: > > > Is it possible to import my module > > again with old osis2mod version (if the correction takes time). > > Should be a little bit hard to find a running 2893 copy as: > > $ svn blame -

Re: [sword-devel] Not user-friendly behavior in commentaries (should be continuous)

2020-06-04 Thread Dominique Corbex
On Thu, 4 Jun 2020 17:27:22 +0200 yvand wrote: > Is it possible to import my module > again with old osis2mod version (if the correction takes time). Should be a little bit hard to find a running 2893 copy as: $ svn blame -v osis2mod.cpp | awk '{print $1, $3}'| sort | uniq lists: 2893 2013-0

Re: [sword-devel] Not user-friendly behavior in commentaries (should be continuous)

2020-06-04 Thread yvand
Can somebody confirm this bug? Shall I fill a bug report somewhere? Is it possible to import my module again with old osis2mod version (if the correction takes time). --yvand Le 01/06/2020 à 22:40, John Dudeck a écrit : This sounds like a problem with (at least the Windows version of) the o

Re: [sword-devel] Not user-friendly behavior in commentaries (should be continuous)

2020-06-02 Thread yvand
It might explain my misunderstanding… If this is confirmed, it is a bug in Sword (in osis2mod import tool). Can somebody confirm this bug? Should I fill a bug report somewhere? Is it possible to import my module again with old osis2mod version (if the correction takes time). --yvand Le 01/0

Re: [sword-devel] Not user-friendly behavior in commentaries (should be continuous)

2020-06-01 Thread John Dudeck
This sounds like a problem with (at least the Windows version of) the osis2mod compiler that I complained about years ago, where it does not link all verses in a verse range to the commentary article. For some reason I can't find those messages in my archives. I'm thinking that Build 3431 (64-b

Re: [sword-devel] Not user-friendly behavior in commentaries (should be continuous)

2020-06-01 Thread yvand
Thank you for the clarification and help. Don't duplicate: As Fr. Cyrille has pointed out, SWORD supports entry linking. So, you don't need to duplicate anything, just supply all the verses to which an entry should be associated. That's exactly that I expected (avoid duplication and use entry

Re: [sword-devel] Not user-friendly behavior in commentaries (should be continuous)

2020-06-01 Thread Troy A. Griffitts
As David has said, please be careful about your syntax between osisID and osisRef. osisID="Gen.7.17-Gen.8.5" is invalid. This would be a valid osisRef. osisIDs are how you assign text to a verse entry in SWORD. osisIDs do not take ranges; they take lists. Don't duplicate: As Fr. Cyrille has poi

Re: [sword-devel] Not user-friendly behavior in commentaries (should be continuous)

2020-06-01 Thread David Haslam
Is anyone in this thread confusing osisID syntax and osisRef syntax ? Just a thought David Sent from ProtonMail Mobile On Mon, Jun 1, 2020 at 15:11, Fr Cyrille wrote: > Le 01/06/2020 à 15:14, yvand a écrit : > >> Le 01/06/2020 à 13:20, Fr Cyrille a écrit : >> >>> Le 01/06/2020 à 11:16, yv

Re: [sword-devel] Not user-friendly behavior in commentaries (should be continuous)

2020-06-01 Thread Greg Hellings
On Mon, Jun 1, 2020 at 8:29 AM yvand wrote: > > > On Sat, May 30, 2020 at 11:19 AM Karl Kleinpaste > wrote: > >> On 5/30/20 11:45 AM, yvand wrote: >> >> I think Karl already talked about this feature in the past. But maybe I >> am wrong, I did not find the conversation. >> >> >> Xiphos has a fea

Re: [sword-devel] Not user-friendly behavior in commentaries (should be continuous)

2020-06-01 Thread Fr Cyrille
Le 01/06/2020 à 15:14, yvand a écrit : > Le 01/06/2020 à 13:20, Fr Cyrille a écrit : >> Le 01/06/2020 à 11:16, yvand a écrit : >>> If I change all the OSIS references to match every verses, I hope the >>> module size will not grow 20 times. And if I do so, for frontends like >>> Xiphos which have

Re: [sword-devel] Not user-friendly behavior in commentaries (should be continuous)

2020-06-01 Thread yvand
On Sat, May 30, 2020 at 11:19 AM Karl Kleinpaste > wrote: On 5/30/20 11:45 AM, yvand wrote: I think Karl already talked about this feature in the past. But maybe I am wrong, I did not find the conversation. Xiphos has a feature, "commentary by c

Re: [sword-devel] Not user-friendly behavior in commentaries (should be continuous)

2020-06-01 Thread yvand
Le 01/06/2020 à 13:20, Fr Cyrille a écrit : Le 01/06/2020 à 11:16, yvand a écrit : If I change all the OSIS references to match every verses, I hope the module size will not grow 20 times. And if I do so, for frontends like Xiphos which have a "commentary by chapter" view, the frontend will dupl

Re: [sword-devel] Not user-friendly behavior in commentaries (should be continuous)

2020-06-01 Thread Fr Cyrille
Le 01/06/2020 à 11:16, yvand a écrit : > If I change all the OSIS references to match every verses, I hope the > module size will not grow 20 times. And if I do so, for frontends like > Xiphos which have a "commentary by chapter" view, the frontend will > duplicate the commentary or use a hack to

Re: [sword-devel] Not user-friendly behavior in commentaries (should be continuous)

2020-06-01 Thread Karl Kleinpaste
On 6/1/20 2:54 AM, Greg Hellings wrote: > I think so. Since Bibles are by chapter, it makes sense to have > commentaries as well. I already did it.  See #1036. ___ sword-devel mailing list: sword-devel@crosswire.org http://www.crosswire.org/mailman/listi

Re: [sword-devel] Not user-friendly behavior in commentaries (should be continuous)

2020-06-01 Thread Peter Von Kaehne
which duplicate content - and I would delete any which have made it past me accidentally.   Peter   Gesendet: Montag, 01. Juni 2020 um 10:16 Uhr Von: "yvand" An: sword-devel@crosswire.org Betreff: Re: [sword-devel] Not user-friendly behavior in commentaries (should be continuous)

Re: [sword-devel] Not user-friendly behavior in commentaries (should be continuous)

2020-06-01 Thread yvand
Thanks for the answers. Some advise to duplicate the commentary for every verse (Ps.23.1, Ps.23.2, Ps.23.3, etc.) and some said it is a frontend issue. I am still a bit lose and disappointed for the end users. I don't understand why for commentaries, the OSIS reference "Ps.23-1.5" is not the

Re: [sword-devel] Not user-friendly behavior in commentaries (should be continuous)

2020-05-31 Thread Greg Hellings
On Sat, May 30, 2020 at 11:19 AM Karl Kleinpaste wrote: > On 5/30/20 11:45 AM, yvand wrote: > > I think Karl already talked about this feature in the past. But maybe I am > wrong, I did not find the conversation. > > > Xiphos has a feature, "commentary by chapter," so that whole commentary > chap

Re: [sword-devel] Not user-friendly behavior in commentaries (should be continuous)

2020-05-30 Thread Karl Kleinpaste
On 5/30/20 11:45 AM, yvand wrote: > I think Karl already talked about this feature in the past. But maybe > I am wrong, I did not find the conversation. Xiphos has a feature, "commentary by chapter," so that whole commentary chapters are displayed along with whole Bible chapters, and then the ver

Re: [sword-devel] Not user-friendly behavior in commentaries (should be continuous)

2020-05-30 Thread Fr Cyrille
Le 30/05/2020 à 17:45, yvand a écrit : > Hello all, > > I am the maintainer of the French module FreCJE. I think there is a > not user-friendly behavior with commentaries (in sword engine or in > frontends I don't know). > > For instance, this module includes a commentary for Psalm 23. It is > no

[sword-devel] Not user-friendly behavior in commentaries (should be continuous)

2020-05-30 Thread yvand
Hello all, I am the maintainer of the French module FreCJE. I think there is a not user-friendly behavior with commentaries (in sword engine or in frontends I don't know). For instance, this module includes a commentary for Psalm 23. It is not split by verses (ie verse by verse commentary),