Mark Wu has uploaded a new change for review.
Change subject: Return the result directly instead of generator when getting
network for interface
..
Return the result directly instead of generator when getting network
for
Zhou Zheng Sheng has posted comments on this change.
Change subject: PEP8 cleanup for *.py under vdsm_hooks
..
Patch Set 1: I would prefer that you didn't submit this
Dan tries to remove the pep8 ignore option for E121, E122,
Zhou Zheng Sheng has posted comments on this change.
Change subject: PEP8 cleanup for *.py under vdsm_hooks
..
Patch Set 1: No score
--
To view, visit http://gerrit.ovirt.org/9734
To unsubscribe, visit
Zhou Zheng Sheng has posted comments on this change.
Change subject: pep8: comply with E122 and E123
..
Patch Set 1: No score
My mistake. There are no pep8 problems. I apologize.
--
To view, visit http://gerrit.ovirt.org/9730
Mark Wu has posted comments on this change.
Change subject: PEP8 cleanup for *.py under vdsm_hooks
..
Patch Set 1:
I updated pep8 on my host and didn't ignore any PEP8 error when I fix it. So I
doesn't need a rebase.
--
To
Mark Wu has posted comments on this change.
Change subject: [WIP] netwiring: [4/4] Add API definitions.
..
Patch Set 14: (1 inline comment)
File vdsm/libvirtvm.py
Line 1563:
Zhou Zheng Sheng has posted comments on this change.
Change subject: PEP8 cleanup for *.py under vdsm_hooks
..
Patch Set 1: Verified
(1 inline comment)
Pass autobuild.sh.
pydiff find some changes.
First change:
pydiff
Royce Lv has posted comments on this change.
Change subject: add emulator pin support to create vm
..
Patch Set 7:
Laszlo, if your 'host-mode'patch is ready, I'm glad to rebase on yours and
verify with you.
--
To view, visit
Eduardo has uploaded a new change for review.
Change subject: Do not fail when getVSize is called on an inctive LV.
..
Do not fail when getVSize is called on an inctive LV.
Change-Id: I0a8b6da4d57cdf810769586c1959989d7a545d0c
Dan Kenigsberg has posted comments on this change.
Change subject: Add default MTU=1500 to NIC's ifcfg files.
..
Patch Set 1: I would prefer that you didn't submit this
(1 inline comment)
Eduardo has posted comments on this change.
Change subject: Do not fail when getVSize is called on an inctive LV.
..
Patch Set 1: Verified
#vdsClient 0 getVolumeSize 91202d50-21de-46fa-a4c4-987c062036c5
Dan Kenigsberg has posted comments on this change.
Change subject: Add default MTU=1500 to NIC's ifcfg files.
..
Patch Set 1: Looks good to me, but someone else must approve
(1 inline comment)
Timothy Asir has posted comments on this change.
Change subject: Added gluster volume top functionalities
..
Patch Set 6: Verified
--
To view, visit http://gerrit.ovirt.org/7844
To unsubscribe, visit
Ayal Baron has posted comments on this change.
Change subject: upgrade: reallocate the metadata slots when needed
..
Patch Set 4: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/9660
To unsubscribe, visit
Timothy Asir has posted comments on this change.
Change subject: Added gluster volume top functionalities
..
Patch Set 9: Verified
--
To view, visit http://gerrit.ovirt.org/7844
To unsubscribe, visit
Dan Kenigsberg has posted comments on this change.
Change subject: vm: increase the volume extension on storage migration
..
Patch Set 3: I would prefer that you didn't submit this
(3 inline comments)
minor comments.
Dan Kenigsberg has posted comments on this change.
Change subject: vm: increase the volume extension on storage migration
..
Patch Set 4: Looks good to me, approved
thanks for the quick fix.
--
To view, visit
Bala.FA has posted comments on this change.
Change subject: Added gluster volume top functionalities
..
Patch Set 9: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/7844
To
Dan Kenigsberg has posted comments on this change.
Change subject: Specify the ACPI flag when shutting down VMs
..
Patch Set 1: (1 inline comment)
File vdsm/libvirtvm.py
Daniel Paikov has posted comments on this change.
Change subject: sdcache: add refresh to connectStoragePool
..
Patch Set 2: Verified
--
To view, visit http://gerrit.ovirt.org/9422
To unsubscribe, visit
Dan Kenigsberg has submitted this change and it was merged.
Change subject: vm: increase the volume extension on storage migration
..
vm: increase the volume extension on storage migration
During live migration VDSM needs to
Dan Kenigsberg has posted comments on this change.
Change subject: Added gluster volume top functionalities
..
Patch Set 9: I would prefer that you didn't submit this
(2 inline comments)
Dan Kenigsberg has uploaded a new change for review.
Change subject: vdsm startup: fix assert statement
..
vdsm startup: fix assert statement
SyntaxWarning: assertion is always true, perhaps remove parentheses?
Change-Id:
oVirt Jenkins CI Server has posted comments on this change.
Change subject: vdsm startup: fix assert statement
..
Patch Set 1:
Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_manual_gerrit/239/
(1/2)
--
To view,
oVirt Jenkins CI Server has posted comments on this change.
Change subject: vdsm startup: fix assert statement
..
Patch Set 1:
Build Started http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/205/ (2/2)
--
To view, visit
Yeela Kaplan has posted comments on this change.
Change subject: [WIP] BZ#748386 - refactor qemuConvert to only use qemu-img
convert.
..
Patch Set 4: I would prefer that you didn't submit this
(11 inline comments)
A few
oVirt Jenkins CI Server has posted comments on this change.
Change subject: vdsm startup: fix assert statement
..
Patch Set 1:
Build Successful
http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/205/ : SUCCESS
Yeela Kaplan has posted comments on this change.
Change subject: Move hsm.validatePoolSD() - pool.validatePoolSD().
..
Patch Set 2: (1 inline comment)
File
oVirt Jenkins CI Server has posted comments on this change.
Change subject: upgrade: reallocate the metadata slots when needed
..
Patch Set 5:
Build Started http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/206/ (2/2)
--
To view,
oVirt Jenkins CI Server has posted comments on this change.
Change subject: upgrade: reallocate the metadata slots when needed
..
Patch Set 5:
Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_manual_gerrit/240/
Federico Simoncelli has posted comments on this change.
Change subject: upgrade: reallocate the metadata slots when needed
..
Patch Set 5: Verified
Verified on a storage domain containing _remove_me volumes and broken images.
oVirt Jenkins CI Server has posted comments on this change.
Change subject: upgrade: reallocate the metadata slots when needed
..
Patch Set 5: I would prefer that you didn't submit this
Build Unstable
oVirt Jenkins CI Server has posted comments on this change.
Change subject: upgrade: reallocate the metadata slots when needed
..
Patch Set 6:
Build Started http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/207/ (1/2)
--
To view,
oVirt Jenkins CI Server has posted comments on this change.
Change subject: upgrade: reallocate the metadata slots when needed
..
Patch Set 6:
Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_manual_gerrit/241/
Federico Simoncelli has posted comments on this change.
Change subject: upgrade: reallocate the metadata slots when needed
..
Patch Set 6: Verified
Verified on a storage domain containing _remove_me volumes and broken images.
oVirt Jenkins CI Server has posted comments on this change.
Change subject: upgrade: reallocate the metadata slots when needed
..
Patch Set 6:
Build Successful
http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/207/ : SUCCESS
Shu Ming has posted comments on this change.
Change subject: Move hsm.validatePoolSD() - pool.validatePoolSD().
..
Patch Set 2: I would prefer that you didn't submit this
(2 inline comments)
Laszlo Hornyak has posted comments on this change.
Change subject: add emulator pin support to create vm
..
Patch Set 7:
Royce: at the moment I am still waiting for the VDSM team to decide which
design they would accept :(
Adam Litke has posted comments on this change.
Change subject: netwiring: [1/4] Extend vmInterfaceDevice API def
..
Patch Set 2: Looks good to me, approved
Agreement was reached after discussion on list. Approving.
--
To
oVirt Jenkins CI Server has posted comments on this change.
Change subject: netwiring: [2/4] Add API definitions.
..
Patch Set 6:
Build Started http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/208/ (1/2)
--
To view, visit
oVirt Jenkins CI Server has posted comments on this change.
Change subject: netwiring: [2/4] Add API definitions.
..
Patch Set 6:
Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_manual_gerrit/242/
(2/2)
--
To
oVirt Jenkins CI Server has posted comments on this change.
Change subject: netwiring: [2/4] Add API definitions.
..
Patch Set 6:
Build Successful
http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/208/ : SUCCESS
Saggi Mizrahi has posted comments on this change.
Change subject: dd: use iflag=direct only when supported by the os
..
Patch Set 3: Looks good to me, but someone else must approve
--
To view, visit
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Check that underlying filesystem supports direct IO before
creating a domain on it
..
Patch Set 1:
Build Started
Saggi Mizrahi has uploaded a new change for review.
Change subject: Check that underlying filesystem supports direct IO before
creating a domain on it
..
Check that underlying filesystem supports direct IO before creating a
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Check that underlying filesystem supports direct IO before
creating a domain on it
..
Patch Set 1:
Build Started
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Check that underlying filesystem supports direct IO before
creating a domain on it
..
Patch Set 1: Fails
Build Failed
oVirt Jenkins CI Server has posted comments on this change.
Change subject: netwiring: [3/4] Add cli entry point.
..
Patch Set 9:
Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_manual_gerrit/244/
(1/2)
--
To
oVirt Jenkins CI Server has posted comments on this change.
Change subject: netwiring: [3/4] Add cli entry point.
..
Patch Set 9:
Build Started http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/210/ (2/2)
--
To view, visit
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Fix indentation on fileSD
..
Patch Set 1:
Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_manual_gerrit/245/
(2/2)
--
To view, visit
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Fix indentation on fileSD
..
Patch Set 1:
Build Started http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/211/ (1/2)
--
To view, visit
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Check that underlying filesystem supports direct IO before
creating a domain on it
..
Patch Set 2:
Build Started
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Check that underlying filesystem supports direct IO before
creating a domain on it
..
Patch Set 2:
Build Started
Saggi Mizrahi has uploaded a new change for review.
Change subject: Fix indentation on fileSD
..
Fix indentation on fileSD
Change-Id: Iadf2ecce62022dba47b6c92186e0aeae7011c813
Signed-off-by: Saggi Mizrahi smizr...@redhat.com
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Fix indentation on fileSD
..
Patch Set 1: Fails
Build Failed
http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/211/ : SUCCESS
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Check that underlying filesystem supports direct IO before
creating a domain on it
..
Patch Set 2: Fails
Build Failed
oVirt Jenkins CI Server has posted comments on this change.
Change subject: netwiring: [3/4] Add cli entry point.
..
Patch Set 10:
Build Started http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/213/ (1/2)
--
To view, visit
oVirt Jenkins CI Server has posted comments on this change.
Change subject: netwiring: [3/4] Add cli entry point.
..
Patch Set 10:
Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_manual_gerrit/247/
(2/2)
--
To
oVirt Jenkins CI Server has posted comments on this change.
Change subject: netwiring: [3/4] Add cli entry point.
..
Patch Set 10: I would prefer that you didn't submit this
Build Unstable
Saggi Mizrahi has uploaded a new change for review.
Change subject: Sometimes the test host is overloaded and that might cause a
false positive with such a low timeout
..
Sometimes the test host is overloaded and that might
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Fix indentation on fileSD
..
Patch Set 2:
Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_manual_gerrit/249/
(1/2)
--
To view, visit
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Sometimes the test host is overloaded and that might cause a
false positive with such a low timeout
..
Patch Set 1:
Build Started
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Check that underlying filesystem supports direct IO before
creating a domain on it
..
Patch Set 3:
Build Started
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Fix indentation on fileSD
..
Patch Set 2:
Build Successful
http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/215/ : SUCCESS
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Check that underlying filesystem supports direct IO before
creating a domain on it
..
Patch Set 3:
Build Successful
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Fix indentation on fileSD
..
Patch Set 2:
Build Started http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/215/ (2/2)
--
To view, visit
Saggi Mizrahi has posted comments on this change.
Change subject: pep8 fixes for vdsm file
..
Patch Set 1: I would prefer that you didn't submit this
(1 inline comment)
Dan Kenigsberg has posted comments on this change.
Change subject: pep8 fixes for vdsm file
..
Patch Set 1: I would prefer that you didn't submit this
(1 inline comment)
Dan Kenigsberg has posted comments on this change.
Change subject: sdcache: add refresh to connectStoragePool
..
Patch Set 2: (1 inline comment)
File vdsm/storage/sp.py
Line
Dan Kenigsberg has submitted this change and it was merged.
Change subject: dd: use iflag=direct only when supported by the os
..
dd: use iflag=direct only when supported by the os
Much like as vdsm's use of
Dan Kenigsberg has posted comments on this change.
Change subject: dd: use iflag=direct only when supported by the os
..
Patch Set 3: Verified; Looks good to me, approved
thanks, reviewers.
--
To view, visit
Dan Kenigsberg has abandoned this change.
Change subject: miscTests: Use /var/tmp for O_DIRECT tests
..
Patch Set 1: Abandoned
no need in this, given the unanimous support for
http://gerrit.ovirt.org/#/c/9661/
--
To view,
Saggi Mizrahi has posted comments on this change.
Change subject: upgrade: reallocate the metadata slots when needed
..
Patch Set 6: I would prefer that you didn't submit this
(1 inline comment)
Dan Kenigsberg has posted comments on this change.
Change subject: netwiring: [2/4] Add API definitions.
..
Patch Set 6: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/9560
To unsubscribe, visit
Dan Kenigsberg has posted comments on this change.
Change subject: netwiring: [3/4] Add cli entry point.
..
Patch Set 10: Looks good to me, approved
(1 inline comment)
File
Dan Kenigsberg has posted comments on this change.
Change subject: [WIP] netwiring: [4/4] Add API definitions.
..
Patch Set 16: I would prefer that you didn't submit this
(12 inline comments)
oVirt Jenkins CI Server has posted comments on this change.
Change subject: pep8: comply with E122 and E123
..
Patch Set 2:
Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_manual_gerrit/251/
(2/2)
--
To view,
oVirt Jenkins CI Server has posted comments on this change.
Change subject: pep8: comply with E122 and E123
..
Patch Set 2:
Build Started http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/217/ (1/2)
--
To view, visit
Dan Kenigsberg has posted comments on this change.
Change subject: pep8: comply with E122 and E123
..
Patch Set 2:
oops, no idea how I've failed in the previous patchset.
Zhou, please use -1 when you spot an error like that.
oVirt Jenkins CI Server has posted comments on this change.
Change subject: pep8: comply with E122 and E123
..
Patch Set 2: I would prefer that you didn't submit this
Build Unstable
Dan Kenigsberg has submitted this change and it was merged.
Change subject: Sometimes the test host is overloaded and that might cause a
false positive with such a low timeout
..
Sometimes the test host is overloaded and that
Dan Kenigsberg has posted comments on this change.
Change subject: Sometimes the test host is overloaded and that might cause a
false positive with such a low timeout
..
Patch Set 1: Verified; Looks good to me, approved
5
Ayal Baron has posted comments on this change.
Change subject: upgrade: reallocate the metadata slots when needed
..
Patch Set 6: (1 inline comment)
File
Federico Simoncelli has posted comments on this change.
Change subject: upgrade: reallocate the metadata slots when needed
..
Patch Set 6: (1 inline comment)
File
Antoni Segura Puimedon has posted comments on this change.
Change subject: [WIP] netwiring: [4/4] Add API definitions.
..
Patch Set 16: (12 inline comments)
File vdsm/API.py
oVirt Jenkins CI Server has posted comments on this change.
Change subject: [WIP] netwiring: [4/4] Add API definitions.
..
Patch Set 17:
Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_manual_gerrit/252/
(1/2)
--
oVirt Jenkins CI Server has posted comments on this change.
Change subject: [WIP] netwiring: [4/4] Add API definitions.
..
Patch Set 17:
Build Started http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/218/ (2/2)
--
To view, visit
oVirt Jenkins CI Server has posted comments on this change.
Change subject: [WIP] netwiring: [4/4] Add API definitions.
..
Patch Set 17: Fails
Build Failed
http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/218/ : SUCCESS
Mark Wu has posted comments on this change.
Change subject: cpu mode support for vdsm
..
Patch Set 3: I would prefer that you didn't submit this
(3 inline comments)
File
ShaoHe Feng has posted comments on this change.
Change subject: netwiring: [2/4] Add API definitions.
..
Patch Set 6: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/9560
To
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Extract bonding options building into a separate function.
..
Patch Set 2:
Build Started http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/219/ (2/2)
--
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Extract bonding options building into a separate function.
..
Patch Set 2:
Build Started
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Extract bonding options building into a separate function.
..
Patch Set 3:
Build Started
ShaoHe Feng has posted comments on this change.
Change subject: netwiring: [3/4] Add cli entry point.
..
Patch Set 10: Looks good to me, but someone else must approve
(1 inline comment)
ShaoHe Feng has posted comments on this change.
Change subject: netwiring: [2/4] Add API definitions.
..
Patch Set 6: I would prefer that you didn't submit this
(1 inline comment)
sorry, -1 for I did not find updateDevice
Zhou Zheng Sheng has posted comments on this change.
Change subject: PEP8 cleanup for *.py under vdsm_hooks
..
Patch Set 1: (2 inline comments)
A string literal is changed.
Zhou Zheng Sheng has posted comments on this change.
Change subject: PEP8 cleanup for *.py under vdsm_hooks
..
Patch Set 1: No score
--
To view, visit http://gerrit.ovirt.org/9734
To unsubscribe, visit
Mark Wu has posted comments on this change.
Change subject: logging: setup log filter correctly
..
Patch Set 1: Looks good to me, but someone else must approve
(1 inline comment)
Do you know any reason why python doesn't
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Add shutdown based on qemu-ga(qemu guest agent) in vdsm
..
Patch Set 3:
Build Started http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/221/ (1/2)
--
To
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Add shutdown based on qemu-ga(qemu guest agent) in vdsm
..
Patch Set 3:
Build Started http://jenkins.ovirt.org/job/vdsm_unit_tests_manual_gerrit/255/
1 - 100 of 108 matches
Mail list logo
