Zhou Zheng Sheng has posted comments on this change.
Change subject: Extend vdsm-tool: moving configure libvirt to external shell
script
..
Patch Set 11: (3 inline comments)
Zhou Zheng Sheng has posted comments on this change.
Change subject: XMLRPCServer: make XMLRPCServer able to listen on IPv6 addresses
..
Patch Set 8:
It looks the Jenkins slave should be updated to have a successful build.
--
Zhou Zheng Sheng has posted comments on this change.
Change subject: gluster: verbs for managing services
..
Patch Set 23: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/11094
To
Dan Kenigsberg has posted comments on this change.
Change subject: Fix bridgeless net regression
..
Patch Set 1: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/16086
To unsubscribe, visit
oVirt Jenkins CI Server has posted comments on this change.
Change subject: WIP: storage: Introduce Image.removeAsBlockDevice vdsm verb
..
Patch Set 7:
Build Successful
http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/2944/ :
oVirt Jenkins CI Server has posted comments on this change.
Change subject: WIP: storage: Introduce Image.exportAsBlockDevice vdsm verb
..
Patch Set 9:
Build Successful
http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/2945/ :
Dan Kenigsberg has posted comments on this change.
Change subject: Multiple Gateways[1/2]: add sourceRouting module
..
Patch Set 25: (4 inline comments)
File
Dan Kenigsberg has posted comments on this change.
Change subject: Multiple Gateways[2/2]: configNetwork integration
..
Patch Set 8: (1 inline comment)
File
Antoni Segura Puimedon has posted comments on this change.
Change subject: Multiple Gateways[1/2]: add sourceRouting module
..
Patch Set 25: (4 inline comments)
File
Antoni Segura Puimedon has posted comments on this change.
Change subject: Multiple Gateways[2/2]: configNetwork integration
..
Patch Set 8: (1 inline comment)
File
Deepak C Shetty has posted comments on this change.
Change subject: WIP: storage: Introduce Image.exportAsBlockDevice vdsm verb
..
Patch Set 9: Verified
Fixed jenkins pep8 issues
--
To view, visit
Deepak C Shetty has posted comments on this change.
Change subject: WIP: storage: Introduce Image.removeAsBlockDevice vdsm verb
..
Patch Set 7: Verified
--
To view, visit http://gerrit.ovirt.org/14919
To unsubscribe, visit
Mark Wu has posted comments on this change.
Change subject: Multiple Gateways[1/2]: add sourceRouting module
..
Patch Set 25: (1 inline comment)
File vdsm/sourceRoute.py
Mark Wu has posted comments on this change.
Change subject: Multiple Gateways[2/2]: configNetwork integration
..
Patch Set 8: I would prefer that you didn't submit this
(1 inline comment)
Arik Hadas has posted comments on this change.
Change subject: RAM snapshots feature
..
Patch Set 9:
add padding to the memory dump file to handle qemu's truncation during export
--
To view, visit
Antoni Segura Puimedon has posted comments on this change.
Change subject: Multiple Gateways[2/2]: configNetwork integration
..
Patch Set 8: (1 inline comment)
File
Giuseppe Vallarelli has posted comments on this change.
Change subject: Bugfix update device hooks: after_update_device failure.
..
Patch Set 2: (1 inline comment)
I don't have any alternative solutions for now which are less
oVirt Jenkins CI Server has posted comments on this change.
Change subject: RAM snapshots feature
..
Patch Set 9:
Build Successful
http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/2946/ : SUCCESS
Giuseppe Vallarelli has posted comments on this change.
Change subject: Qos feature: Adds bandwidth definition at configuration level.
..
Patch Set 11: (2 inline comments)
Giuseppe Vallarelli has posted comments on this change.
Change subject: vdscli: make __getLocalVdsName more robust
..
Patch Set 2: (1 inline comment)
File
Dan Kenigsberg has posted comments on this change.
Change subject: vdscli: make __getLocalVdsName more robust
..
Patch Set 2: (3 inline comments)
File lib/vdsm/vdscli.py.in
Michal Skrivanek has posted comments on this change.
Change subject: RAM snapshots feature
..
Patch Set 9: (1 inline comment)
File vdsm/vm.py
Line 3578: # We are
Giuseppe Vallarelli has posted comments on this change.
Change subject: vdscli: make __getLocalVdsName more robust
..
Patch Set 2: (2 inline comments)
File
Michal Skrivanek has posted comments on this change.
Change subject: vdsm: report migration status in getVMList() call
..
Patch Set 3: (1 inline comment)
Commit Message
Line
Giuseppe Vallarelli has posted comments on this change.
Change subject: vdscli: make __getLocalVdsName more robust
..
Patch Set 3: Looks good to me, but someone else must approve
--
To view, visit
Dan Kenigsberg has posted comments on this change.
Change subject: Multiple Gateways[1/2]: add sourceRouting module
..
Patch Set 25: I would prefer that you didn't submit this
(4 inline comments)
Dan Kenigsberg has posted comments on this change.
Change subject: Multiple Gateways[2/2]: configNetwork integration
..
Patch Set 8: I would prefer that you didn't submit this
(1 inline comment)
Yeela Kaplan has uploaded a new change for review.
Change subject: alignmentScanTests: Remove text output validation of help
..
alignmentScanTests: Remove text output validation of help
'virt-alignment-scan --help' output has
Dan Kenigsberg has posted comments on this change.
Change subject: Bugfix update device hooks: after_update_device failure.
..
Patch Set 2: I would prefer that you didn't submit this
(1 inline comment)
Giuseppe Vallarelli has posted comments on this change.
Change subject: Bugfix update device hooks: after_update_device failure.
..
Patch Set 2: (1 inline comment)
File
Giuseppe Vallarelli has posted comments on this change.
Change subject: Qos feature: Adds bandwidth definition at configuration level.
..
Patch Set 13: Verified
Added the functional test as well.
--
To view, visit
Antoni Segura Puimedon has abandoned this change.
Change subject: Fix nics and bonds bridgeless rule removal
..
Patch Set 1: Abandoned
Squashed into http://gerrit.ovirt.org/#/c/15528/
--
To view, visit
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Bugfix update device hooks: after_update_device failure.
..
Patch Set 2:
Build Successful
http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/2947/ :
Martin Sivák has posted comments on this change.
Change subject: Fix the charset conversion logic in hooks.py
..
Patch Set 4: (1 inline comment)
File vdsm/hooks.py
Line 59:
Antoni Segura Puimedon has posted comments on this change.
Change subject: Fix bridgeless net regression
..
Patch Set 1: Verified
--
To view, visit http://gerrit.ovirt.org/16086
To unsubscribe, visit
Dan Kenigsberg has posted comments on this change.
Change subject: Fix the charset conversion logic in hooks.py
..
Patch Set 4: (1 inline comment)
File vdsm/hooks.py
Line
Dan Kenigsberg has submitted this change and it was merged.
Change subject: Fix bridgeless net regression
..
Fix bridgeless net regression
The commit:
Ie8bb5fd9fc6ad69cf120d62264d73490b65b82d7
Dan Kenigsberg has posted comments on this change.
Change subject: alignmentScanTests: Remove text output validation of help
..
Patch Set 1: Looks good to me, approved
yep, the content of --help is not important enough to fail
Dan Kenigsberg has posted comments on this change.
Change subject: Multiple Gateways[1/2]: add sourceRouting module
..
Patch Set 26: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/15207
To unsubscribe,
Antoni Segura Puimedon has posted comments on this change.
Change subject: Multiple Gateways[2/2]: configNetwork integration
..
Patch Set 9: Verified
Verified the tip of the branch:
http://gerrit.ovirt.org/#/c/15890/
--
To
Federico Simoncelli has posted comments on this change.
Change subject: clientIF: Check disk alignment using virt-alignment-scan
..
Patch Set 14: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/12003
To
Antoni Segura Puimedon has posted comments on this change.
Change subject: Fix multiple default gateways reporting
..
Patch Set 6: Verified
Verified with the following (and assuming http://gerrit.ovirt.org/#/c/16086/
has been
Antoni Segura Puimedon has posted comments on this change.
Change subject: Multiple Gateways[1/2]: add sourceRouting module
..
Patch Set 26: Verified
Verified the tip of the branch:
http://gerrit.ovirt.org/#/c/15890/
--
To
oVirt Jenkins CI Server has posted comments on this change.
Change subject: clientIF: Check disk alignment using virt-alignment-scan
..
Patch Set 14:
Build Successful
http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/2949/ :
oVirt Jenkins CI Server has posted comments on this change.
Change subject: vdscli: make __getLocalVdsName more robust
..
Patch Set 3: Fails; I would prefer that you didn't submit this
Build Failed
oVirt Jenkins CI Server has posted comments on this change.
Change subject: vm payload: custom volume labels
..
Patch Set 4: Fails
Build Failed
http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/2951/ : SUCCESS
oVirt Jenkins CI Server has posted comments on this change.
Change subject: vm payload: creation of full pathnames in payload
..
Patch Set 3:
Build Successful
http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/2952/ : SUCCESS
oVirt Jenkins CI Server has posted comments on this change.
Change subject: vm payload: clarify intent of supporting multiple files
..
Patch Set 3:
Build Successful
http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/2953/ :
oVirt Jenkins CI Server has posted comments on this change.
Change subject: alignmentScanTests: Remove text output validation of help
..
Patch Set 1:
Build Successful
http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/2954/ :
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Qos feature: Adds bandwidth definition at configuration level.
..
Patch Set 13:
Build Successful
http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/2955/
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Multiple Gateways[1/2]: add sourceRouting module
..
Patch Set 26:
Build Successful
http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/2956/ : SUCCESS
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Multiple Gateways[2/2]: configNetwork integration
..
Patch Set 9:
Build Successful
http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/2957/ : SUCCESS
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Fix multiple default gateways reporting
..
Patch Set 6:
Build Successful
http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/2958/ : SUCCESS
Dan Kenigsberg has posted comments on this change.
Change subject: vm payload: creation of full pathnames in payload
..
Patch Set 3: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/16072
To unsubscribe,
Dan Kenigsberg has submitted this change and it was merged.
Change subject: Multiple Gateways[1/2]: add sourceRouting module
..
Multiple Gateways[1/2]: add sourceRouting module
http://www.ovirt.org/Features/Multiple_Gateways
oVirt Jenkins CI Server has posted comments on this change.
Change subject: RAM snapshots feature
..
Patch Set 10:
Build Successful
http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/2960/ : SUCCESS
Giuseppe Vallarelli has uploaded a new change for review.
Change subject: Bugfix nic custom properities: custom properities are defined
in the nic device.
..
Bugfix nic custom properities: custom properities are defined in the
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Bugfix nic custom properities: custom properities are defined
in the nic device.
..
Patch Set 1:
Build Successful
Dan Kenigsberg has posted comments on this change.
Change subject: Multiple Gateways[2/2]: configNetwork integration
..
Patch Set 8: (2 inline comments)
File
Dan Kenigsberg has posted comments on this change.
Change subject: Multiple Gateways[2/2]: configNetwork integration
..
Patch Set 9: Looks good to me, approved
(1 inline comment)
Arik Hadas has posted comments on this change.
Change subject: RAM snapshots feature
..
Patch Set 9: (1 inline comment)
File vdsm/vm.py
Line 3578: # We are
Dan Kenigsberg has posted comments on this change.
Change subject: Bugfix nic custom properities: custom properities are defined
in the nic device.
..
Patch Set 1: I would prefer that you didn't submit this
Thanks. We should
Dan Kenigsberg has submitted this change and it was merged.
Change subject: Multiple Gateways[2/2]: configNetwork integration
..
Multiple Gateways[2/2]: configNetwork integration
This patch provides the integration of
Dan Kenigsberg has posted comments on this change.
Change subject: Make networking API endpoints match schema
..
Patch Set 1: Looks good to me, approved
mea culpa. mutable default args are a beautiful trick to leak
Dan Kenigsberg has submitted this change and it was merged.
Change subject: Fix multiple default gateways reporting
..
Fix multiple default gateways reporting
Up until now there was just a default gateway per host, defining
Dan Kenigsberg has posted comments on this change.
Change subject: Fix multiple default gateways reporting
..
Patch Set 6: Looks good to me, approved
(1 inline comment)
Dan Kenigsberg has submitted this change and it was merged.
Change subject: Interface changes for getImageDomainsList internal changes.
..
Interface changes for getImageDomainsList internal changes.
Complement to
Dan Kenigsberg has posted comments on this change.
Change subject: Interface changes for getImageDomainsList internal changes.
..
Patch Set 1: Verified; Looks good to me, approved
Thanks Edu for fixing your own regression of
Dan Kenigsberg has posted comments on this change.
Change subject: Remove StoragePool.getImageDomainsList().
..
Patch Set 9: Looks good to me, approved
Copying Ayal's score.
--
To view, visit http://gerrit.ovirt.org/12927
To
Dan Kenigsberg has submitted this change and it was merged.
Change subject: Remove StoragePool.getImageDomainsList().
..
Remove StoragePool.getImageDomainsList().
Avoid code duplication.
Related to BZ#905038.
Change-Id:
Giuseppe Vallarelli has posted comments on this change.
Change subject: [WIP] Bugfix nic custom properities: custom properities are
defined in the nic device.
..
Patch Set 2:
I'll take care of it.
--
To view, visit
Dan Kenigsberg has posted comments on this change.
Change subject: Ignore partially deleted images in getAllImages().
..
Patch Set 10: Looks good to me, approved
(1 inline comment)
Dan Kenigsberg has submitted this change and it was merged.
Change subject: Ignore partially deleted images in getAllImages().
..
Ignore partially deleted images in getAllImages().
Change-Id:
Dan Kenigsberg has posted comments on this change.
Change subject: vm payload: clarify intent of supporting multiple files
..
Patch Set 3: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/16073
Dan Kenigsberg has posted comments on this change.
Change subject: vm payload: custom volume labels
..
Patch Set 4: Looks good to me, but someone else must approve
(1 inline comment)
oVirt Jenkins CI Server has posted comments on this change.
Change subject: [WIP] Bugfix nic custom properities: custom properities are
defined in the nic device.
..
Patch Set 2:
Build Successful
Douglas Schilling Landgraf has posted comments on this change.
Change subject: alignmentScanTests: Remove text output validation of help
..
Patch Set 1: Verified; Looks good to me, but someone else must approve
--
To view,
Greg Padgett has posted comments on this change.
Change subject: vm payload: creation of full pathnames in payload
..
Patch Set 4:
Rebased, no code changes
--
To view, visit http://gerrit.ovirt.org/16072
To unsubscribe,
Greg Padgett has posted comments on this change.
Change subject: vm payload: custom volume labels
..
Patch Set 5:
Fixed volumeName comparison (iiuc I'm not sure blank vs non-specified matters
to the imaging tools, but
oVirt Jenkins CI Server has posted comments on this change.
Change subject: vm payload: custom volume labels
..
Patch Set 5: Fails
Build Failed
http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/2963/ : SUCCESS
oVirt Jenkins CI Server has posted comments on this change.
Change subject: vm payload: creation of full pathnames in payload
..
Patch Set 4:
Build Successful
http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/2964/ : SUCCESS
oVirt Jenkins CI Server has posted comments on this change.
Change subject: [WIP] Bugfix nic custom properities: custom properities are
defined in the nic device.
..
Patch Set 3:
Build Successful
Dan Kenigsberg has submitted this change and it was merged.
Change subject: alignmentScanTests: Remove text output validation of help
..
alignmentScanTests: Remove text output validation of help
'virt-alignment-scan --help'
Dan Kenigsberg has posted comments on this change.
Change subject: vm payload: custom volume labels
..
Patch Set 5: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/14347
To unsubscribe, visit
Dan Kenigsberg has posted comments on this change.
Change subject: vm payload: custom volume labels
..
Patch Set 5: No score
(1 inline comment)
could you speak with infra@ovirt before we push this in?
Yaniv Bronhaim has posted comments on this change.
Change subject: New getChildrenList implementation.
..
Patch Set 4: (1 inline comment)
File vdsm/storage/fileVolume.py
Dan Kenigsberg has posted comments on this change.
Change subject: RAM snapshots feature
..
Patch Set 10: (2 inline comments)
File vdsm/vm.py
Line 3536:
Dan Kenigsberg has posted comments on this change.
Change subject: vm payload: custom volume labels
..
Patch Set 5: (1 inline comment)
File tests/mkimageTests.py
Line 109:
Antoni Segura Puimedon has uploaded a new change for review.
Change subject: Fix potential race of getting caps during addNet
..
Fix potential race of getting caps during addNet
getmtu can return IOError when a libvirt network
Giuseppe Vallarelli has posted comments on this change.
Change subject: Fix potential race of getting caps during addNet
..
Patch Set 1: Looks good to me, but someone else must approve
--
To view, visit
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Fix potential race of getting caps during addNet
..
Patch Set 1:
Build Successful
http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/2966/ : SUCCESS
oVirt Jenkins CI Server has posted comments on this change.
Change subject: vm payload: custom volume labels
..
Patch Set 6: Fails
Build Failed
http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/2967/ : SUCCESS
Yeela Kaplan has posted comments on this change.
Change subject: clientIF: Check disk alignment using virt-alignment-scan
..
Patch Set 15: Verified
--
To view, visit http://gerrit.ovirt.org/12003
To unsubscribe, visit
oVirt Jenkins CI Server has posted comments on this change.
Change subject: vm payload: custom volume labels
..
Patch Set 7: Fails
Build Failed
http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/2968/ : SUCCESS
oVirt Jenkins CI Server has posted comments on this change.
Change subject: clientIF: Check disk alignment using virt-alignment-scan
..
Patch Set 15:
Build Successful
http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/2969/ :
Federico Simoncelli has posted comments on this change.
Change subject: clientIF: Check disk alignment using virt-alignment-scan
..
Patch Set 15: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/12003
To
Dan Kenigsberg has posted comments on this change.
Change subject: vdscli: make __getLocalVdsName more robust
..
Patch Set 4:
I had to fix some pep8 sloppiness
--
To view, visit http://gerrit.ovirt.org/16059
To unsubscribe,
oVirt Jenkins CI Server has posted comments on this change.
Change subject: vdscli: make __getLocalVdsName more robust
..
Patch Set 4:
Build Successful
http://jenkins.ovirt.org/job/vdsm_pep8_gerrit/2970/ : SUCCESS
Mark Wu has posted comments on this change.
Change subject: Fix potential race of getting caps during addNet
..
Patch Set 1: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/16122
To
Mark Wu has posted comments on this change.
Change subject: Make networking API endpoints match schema
..
Patch Set 1:
It looks for some reason 'MTU=None' went into the ifcfg file before this test.
You could cleanup the ifcfg
1 - 100 of 101 matches
Mail list logo
