Ondřej Svoboda has posted comments on this change.
Change subject: iproute2: Try to remove all dynamic routes even if removal of
one fails
..
Patch Set 1: Code-Review-1
(1 comment)
Missing import.
http://gerrit.ovirt.org/#/c
oVirt Jenkins CI Server has posted comments on this change.
Change subject: NetDevice: Lookup IP attributes using __getattr__
..
Patch Set 2:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/14873/ : S
oVirt Jenkins CI Server has posted comments on this change.
Change subject: NetDevice: Lookup IP attributes using __getattr__
..
Patch Set 1:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/14872/ : F
Ondřej Svoboda has uploaded a new change for review.
Change subject: NetDevice: Lookup IP attributes using __getattr__
..
NetDevice: Lookup IP attributes using __getattr__
Change-Id: Iecf268d557d642cb12a4b25d157ec059293a49c4
Sig
Douglas Schilling Landgraf has posted comments on this change.
Change subject: init: wait for network service
..
Patch Set 1: Verified+1
--
To view, visit http://gerrit.ovirt.org/36703
To unsubscribe, visit http://gerrit.ovirt
Ondřej Svoboda has posted comments on this change.
Change subject: IpConfig: Require all parameters and simplify
..
Patch Set 3: Verified+1
Functional tests still pass :-)
--
To view, visit http://gerrit.ovirt.org/36712
To un
Douglas Schilling Landgraf has posted comments on this change.
Change subject: init: wait for network service
..
Patch Set 1: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/36703
To unsubscribe, visit http://gerrit.ov
Ondřej Svoboda has posted comments on this change.
Change subject: IpConfig: Require all parameters and simplify
..
Patch Set 2: Verified-1 Code-Review-1
(1 comment)
I was too eager on the namedtuple.
http://gerrit.ovirt.org/
oVirt Jenkins CI Server has posted comments on this change.
Change subject: IpConfig: Require all parameters and simplify
..
Patch Set 3:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/14871/ : SUCCE
Dan Kenigsberg has posted comments on this change.
Change subject: openstacknet: add support for using the midonet plugin
..
Patch Set 3: Code-Review-1
(1 comment)
http://gerrit.ovirt.org/#/c/36164/3/vdsm_hooks/openstacknet/af
oVirt Jenkins CI Server has posted comments on this change.
Change subject: IpConfig: Require all parameters and simplify
..
Patch Set 2:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/14870/ : SUCCE
oVirt Jenkins CI Server has posted comments on this change.
Change subject: IpConfig: remove an unneeded check
..
Patch Set 1:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/14869/ : SUCCESS
http://
Ondřej Svoboda has uploaded a new change for review.
Change subject: IpConfig: remove an unneeded check
..
IpConfig: remove an unneeded check
objectivizeNetwork always populates IpConfig's inet4 and inet6 parameters
(which, in t
oVirt Jenkins CI Server has posted comments on this change.
Change subject: tests: Remove getAllVolumesTests
..
Patch Set 1:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/14868/ : FAILURE
http://je
oVirt Jenkins CI Server has posted comments on this change.
Change subject: fileSD: Optimize getAllVolumes on file storage
..
Patch Set 5:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/14867/ : FAIL
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Add tests for getAllVolumes
..
Patch Set 3:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/14866/ : SUCCESS
http://jenkins
oVirt Jenkins CI Server has posted comments on this change.
Change subject: qemu-img convert: check/use "-T src_cache" option when available
..
Patch Set 8:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_unit-tests_cre
oVirt Jenkins CI Server has posted comments on this change.
Change subject: gluster: add createBrick verb
..
Patch Set 6:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/14864/ : FAILURE
http://jenki
oVirt Jenkins CI Server has posted comments on this change.
Change subject: Simplify tests for qemuimg to allow additional capabilities
checks
..
Patch Set 5:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_unit-tests_
oVirt Jenkins CI Server has posted comments on this change.
Change subject: clientIF: change createSSLContext to be a class method
..
Patch Set 1:
Build Successful
http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/1
oVirt Jenkins CI Server has posted comments on this change.
Change subject: clientIF: fail if no permission
..
Patch Set 1:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/14859/ : SUCCESS
http://jen
oVirt Jenkins CI Server has posted comments on this change.
Change subject: [WIP]Use jsonrpc during migration of vms
..
Patch Set 1:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/14858/ : FAILURE
h
Nir Soffer has posted comments on this change.
Change subject: Add tests for getAllVolumes
..
Patch Set 2:
(1 comment)
http://gerrit.ovirt.org/#/c/36589/2/tests/fileSDTests.py
File tests/fileSDTests.py:
Line 58: def __ini
Nir Soffer has posted comments on this change.
Change subject: fileSD: Optimize getAllVolumes on file storage
..
Patch Set 5:
This version fixes pyflakes errors in the tests.
--
To view, visit http://gerrit.ovirt.org/36593
To
Nir Soffer has posted comments on this change.
Change subject: tests: Remove getAllVolumesTests
..
Patch Set 1: Verified+1
--
To view, visit http://gerrit.ovirt.org/36711
To unsubscribe, visit http://gerrit.ovirt.org/settings
Nir Soffer has uploaded a new change for review.
Change subject: tests: Remove getAllVolumesTests
..
tests: Remove getAllVolumesTests
Remove the minimal FileStorageDomain.getAllVolumes tests, replaced
by fileSDTests module, and
oVirt Jenkins CI Server has posted comments on this change.
Change subject: init: wait for network service
..
Patch Set 5:
Build Successful
http://jenkins.ovirt.org/job/vdsm_master_verify-error-codes_merged/6273/ :
SUCCESS
Yeela Kaplan has posted comments on this change.
Change subject: multipath configurator: reload only if service is active
..
Patch Set 5:
(1 comment)
http://gerrit.ovirt.org/#/c/36387/5/lib/vdsm/tool/configurators/multipath.py
Dan Kenigsberg has posted comments on this change.
Change subject: multipath configurator: reload only if service is active
..
Patch Set 5:
(1 comment)
http://gerrit.ovirt.org/#/c/36387/5/lib/vdsm/tool/configurators/multipath.
Yeela Kaplan has posted comments on this change.
Change subject: multipath configurator: reload only if service is active
..
Patch Set 5:
(1 comment)
http://gerrit.ovirt.org/#/c/36387/5/lib/vdsm/tool/configurators/multipath.py
Yeela Kaplan has posted comments on this change.
Change subject: service: make service compatible with systemctl reload rc
..
Patch Set 4:
I verified it first by itself.
The verification for the following one would result with
Dan Kenigsberg has posted comments on this change.
Change subject: service: make service compatible with systemctl reload rc
..
Patch Set 4:
It seems that you verified this patch with the follow up one. Would you care to
verif
Francesco Romani has abandoned this change.
Change subject: WIP: sampling: per-worker sampling
..
Abandoned
more promising ways found, involving bulk stats.
--
To view, visit http://gerrit.ovirt.org/31181
To unsubscribe, visi
Timothy Asir has posted comments on this change.
Change subject: gluster: add glusterStorageDevicesList verb
..
Patch Set 13:
(2 comments)
http://gerrit.ovirt.org/#/c/35028/13/vdsm/rpc/vdsmapi-gluster-schema.json
File vdsm/rpc
Timothy Asir has posted comments on this change.
Change subject: gluster: add glusterStorageDevicesList verb
..
Patch Set 15: Verified+1
--
To view, visit http://gerrit.ovirt.org/35028
To unsubscribe, visit http://gerrit.ovirt
Francesco Romani has posted comments on this change.
Change subject: vm: make _set_lastStatus safer
..
Patch Set 3:
Yaniv, the new bug (https://bugzilla.redhat.com/show_bug.cgi?id=1174813) seems
correct according to flow and w
Francesco Romani has abandoned this change.
Change subject: WIP perf: vdsm/virt/{guestagent,vmchannels}.py
..
Abandoned
took different and better approach
--
To view, visit http://gerrit.ovirt.org/36304
To unsubscribe, visit
Hello Douglas Schilling Landgraf, Ido Barkan, Petr Horáček,
I'd like you to do a code review. Please visit
http://gerrit.ovirt.org/36703
to review the following change.
Change subject: init: wait for network service
..
in
Dan Kenigsberg has posted comments on this change.
Change subject: init: wait for network service
..
Patch Set 4: Code-Review+2
Thanks!
--
To view, visit http://gerrit.ovirt.org/36647
To unsubscribe, visit http://gerrit.ovirt
Dan Kenigsberg has submitted this change and it was merged.
Change subject: init: wait for network service
..
init: wait for network service
The network service is not synchronous. It returns before all of the
interfaces that i
oVirt Jenkins CI Server has posted comments on this change.
Change subject: netinfo: Make bootproto4 a boolean and rename it while it is
still unused
..
Patch Set 11:
Build Successful
http://jenkins.ovirt.org/job/vdsm_master
Douglas Schilling Landgraf has posted comments on this change.
Change subject: init: wait for network service
..
Patch Set 4: Verified+1 Code-Review+1
--
To view, visit http://gerrit.ovirt.org/36647
To unsubscribe, visit http:
oVirt Jenkins CI Server has posted comments on this change.
Change subject: contrib: add useful shell functions to assist in vdsm
development
..
Patch Set 8:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_unit-tests_c
Dan Kenigsberg has posted comments on this change.
Change subject: netlink: event monitor (even more simple version)
..
Patch Set 17:
(5 comments)
http://gerrit.ovirt.org/#/c/36197/17/lib/vdsm/netlink/monitor.py
File lib/vdsm/
Dan Kenigsberg has posted comments on this change.
Change subject: netlink: event monitor (even more simple version)
..
Patch Set 18: Code-Review-1
(3 comments)
http://gerrit.ovirt.org/#/c/36197/18//COMMIT_MSG
Commit Message:
Amador Pahim has posted comments on this change.
Change subject: Simplify tests for qemuimg to allow additional capabilities
checks
..
Patch Set 3:
(1 comment)
http://gerrit.ovirt.org/#/c/36366/3/tests/qemuimgTests.py
File te
Dan Kenigsberg has posted comments on this change.
Change subject: multipath configurator: reload only if service is active
..
Patch Set 5:
(1 comment)
http://gerrit.ovirt.org/#/c/36387/5/lib/vdsm/tool/configurators/multipath.
Dan Kenigsberg has posted comments on this change.
Change subject: For rhel<=6 build only for x86 platforms
..
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.ovirt.org/36684
To unsubscribe, visit http://gerrit.ovir
Yeela Kaplan has uploaded a new change for review.
Change subject: clientIF: fail if no permission
..
clientIF: fail if no permission
Change-Id: I5bd80e36dd575664e8192577fdcddb034e8d1ef2
Signed-off-by: Yeela Kaplan
---
M vdsm/c
Yeela Kaplan has uploaded a new change for review.
Change subject: [WIP]Use jsonrpc during migration of vms
..
[WIP]Use jsonrpc during migration of vms
Change-Id: Ie38334e6cdcc4d7899bd5e836b3196567fc0bfd8
Bug-Url: https://bugzil
Yeela Kaplan has uploaded a new change for review.
Change subject: clientIF: change createSSLContext to be a class method
..
clientIF: change createSSLContext to be a class method
and also make it non private, so we can use it f
oVirt Jenkins CI Server has posted comments on this change.
Change subject: vmTests: clean after assertBuildCmdLine
..
Patch Set 2:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_verify-error-codes_merged/6271/ :
SUCC
Nir Soffer has posted comments on this change.
Change subject: Add tests for getAllVolumes
..
Patch Set 2:
(1 comment)
http://gerrit.ovirt.org/#/c/36589/2/tests/fileSDTests.py
File tests/fileSDTests.py:
Line 58: def __ini
oVirt Jenkins CI Server has posted comments on this change.
Change subject: init: wait for network service
..
Patch Set 4:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/14855/ : SUCCESS
http://jenk
Yeela Kaplan has posted comments on this change.
Change subject: service: make service compatible with systemctl reload rc
..
Patch Set 4:
verified on el6.6:
multipathd is inactive.
change configuration of /etc/multipath.conf
Nir Soffer has posted comments on this change.
Change subject: Simplify tests for qemuimg to allow additional capabilities
checks
..
Patch Set 3:
(1 comment)
http://gerrit.ovirt.org/#/c/36366/3/tests/qemuimgTests.py
File test
Dan Kenigsberg has posted comments on this change.
Change subject: netinfo: Make bootproto4 a boolean and rename it while it is
still unused
..
Patch Set 10: Code-Review+2
--
To view, visit http://gerrit.ovirt.org/35984
To un
Dan Kenigsberg has submitted this change and it was merged.
Change subject: netinfo: Make bootproto4 a boolean and rename it while it is
still unused
..
netinfo: Make bootproto4 a boolean and rename it while it is still unused
Dan Kenigsberg has posted comments on this change.
Change subject: Add tests for getAllVolumes
..
Patch Set 2:
(1 comment)
http://gerrit.ovirt.org/#/c/36589/2/tests/fileSDTests.py
File tests/fileSDTests.py:
Line 58: def _
Petr Horáček has posted comments on this change.
Change subject: init: wait for network service
..
Patch Set 4: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/36647
To unsubscribe, visit http://gerrit.ovirt.org/settin
Petr Horáček has posted comments on this change.
Change subject: init: wait for network service
..
Patch Set 4:
sorry, it hit publish by accident...
ip link add dummy_111 type dummy
sudo vdsClient -s 0 setupNetworks
'network
Petr Horáček has posted comments on this change.
Change subject: init: wait for network service
..
Patch Set 4:
ip link add dummy_111 type dummy
sudo vdsClient -s 0 setupNetworks
'networks={test-network1:{nic:dummy_111,bridge
Ido Barkan has posted comments on this change.
Change subject: init: wait for network service
..
Patch Set 4: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/36647
To unsubscribe, visit http://gerrit.ovirt.org/settings
Yeela Kaplan has posted comments on this change.
Change subject: service: make service compatible with systemctl reload rc
..
Patch Set 4: Verified+1
--
To view, visit http://gerrit.ovirt.org/36491
To unsubscribe, visit http:/
Amador Pahim has posted comments on this change.
Change subject: Simplify tests for qemuimg to allow additional capabilities
checks
..
Patch Set 3:
(4 comments)
http://gerrit.ovirt.org/#/c/36366/3/tests/qemuimgTests.py
File t
Ido Barkan has posted comments on this change.
Change subject: contrib: add useful shell functions to assist in vdsm
development
..
Patch Set 8: Verified+1
--
To view, visit http://gerrit.ovirt.org/36344
To unsubscribe, visit
Ido Barkan has posted comments on this change.
Change subject: contrib: add useful shell functions to assist in vdsm
development
..
Patch Set 7:
(1 comment)
http://gerrit.ovirt.org/#/c/36344/7/contrib/shell_helper
File contri
Dan Kenigsberg has posted comments on this change.
Change subject: fixing race while sampling interfaces
..
Patch Set 1: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/36685
To unsubscribe, visit http://gerrit.ovirt.o
Dan Kenigsberg has posted comments on this change.
Change subject: init: wait for network service
..
Patch Set 4: -Code-Review
--
To view, visit http://gerrit.ovirt.org/36647
To unsubscribe, visit http://gerrit.ovirt.org/setti
Dan Kenigsberg has posted comments on this change.
Change subject: init: wait for network service
..
Patch Set 4: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/36647
To unsubscribe, visit http://gerrit.ovirt.org/sett
Ido Barkan has posted comments on this change.
Change subject: fixing race while sampling interfaces
..
Patch Set 1:
verified by running samplingTests.py
--
To view, visit http://gerrit.ovirt.org/36685
To unsubscribe, visit h
Ido Barkan has posted comments on this change.
Change subject: fixing race while sampling interfaces
..
Patch Set 1: Verified+1
--
To view, visit http://gerrit.ovirt.org/36685
To unsubscribe, visit http://gerrit.ovirt.org/sett
Hello Dan Kenigsberg,
I'd like you to do a code review. Please visit
http://gerrit.ovirt.org/36685
to review the following change.
Change subject: fixing race while sampling interfaces
..
fixing race while sampling interf
Petr Horáček has posted comments on this change.
Change subject: netlink: event monitor (even more simple version)
..
Patch Set 15:
(1 comment)
http://gerrit.ovirt.org/#/c/36197/15/lib/vdsm/netlink/monitor.py
File lib/vdsm/net
Dan Kenigsberg has posted comments on this change.
Change subject: init: wait for network service
..
Patch Set 3:
(1 comment)
http://gerrit.ovirt.org/#/c/36647/3/init/vdsmd_init_common.sh.in
File init/vdsmd_init_common.sh.in:
Vinzenz Feenstra has posted comments on this change.
Change subject: virt: Optimize guest agent string filtering
..
Patch Set 4:
(2 comments)
http://gerrit.ovirt.org/#/c/36630/4/vdsm/virt/guestagent.py
File vdsm/virt/guestagen
Petr Horáček has posted comments on this change.
Change subject: utils: move NoIntrCall from storage/misc.py to utils.py
..
Patch Set 1: Verified+1
Passed vdsm functional storage's tests with localfs backend.
--
To view, visi
Ondřej Svoboda has posted comments on this change.
Change subject: netinfo: Make bootproto4 a boolean and rename it while it is
still unused
..
Patch Set 10:
(1 comment)
http://gerrit.ovirt.org/#/c/35984/10/tests/functional/n
Ido Barkan has posted comments on this change.
Change subject: netinfo: Make bootproto4 a boolean and rename it while it is
still unused
..
Patch Set 10: Code-Review+1
(1 comment)
http://gerrit.ovirt.org/#/c/35984/10/tests/fu
Dan Kenigsberg has posted comments on this change.
Change subject: netinfo: Make bootproto4 a boolean and rename it while it is
still unused
..
Patch Set 10:
(1 comment)
http://gerrit.ovirt.org/#/c/35984/10/tests/functional/n
Michal Skrivanek has posted comments on this change.
Change subject: init: wait for network service
..
Patch Set 3:
(1 comment)
http://gerrit.ovirt.org/#/c/36647/3/init/vdsmd_init_common.sh.in
File init/vdsmd_init_common.sh.in
Ido Barkan has posted comments on this change.
Change subject: netinfo: Make bootproto4 a boolean and rename it while it is
still unused
..
Patch Set 10: Code-Review-1
(1 comment)
http://gerrit.ovirt.org/#/c/35984/10/tests/fu
Yaniv Bronhaim has uploaded a new change for review.
Change subject: For rhel<=6 build only for x86 platforms
..
For rhel<=6 build only for x86 platforms
qemu-img package does not exist for other archs
Change-Id: I81e80603f56f0
Petr Horáček has posted comments on this change.
Change subject: contrib: add useful shell functions to assist in vdsm
development
..
Patch Set 7: Code-Review-1
(1 comment)
http://gerrit.ovirt.org/#/c/36344/7/contrib/shell_he
Dan Kenigsberg has posted comments on this change.
Change subject: hostdev: implement numvfs changing
..
Patch Set 3: Code-Review-1
(2 comments)
http://gerrit.ovirt.org/#/c/36216/3/vdsm/supervdsmServer
File vdsm/supervdsmServe
oVirt Jenkins CI Server has posted comments on this change.
Change subject: ipwrapperTests: prevent infinite stuck
..
Patch Set 10:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/14852/ : SUCCESS
ht
Ondřej Svoboda has posted comments on this change.
Change subject: netinfo: Make bootproto4 a boolean and rename it while it is
still unused
..
Patch Set 10: Verified+1
vdsClient -s 0 getVdsCaps works, unit tests pass, functio
Petr Horáček has posted comments on this change.
Change subject: ipwrapperTests: prevent infinite stuck
..
Patch Set 10: Verified+1
Test runs ok. When i exlude bridge.addDevice() it writes a warning to output
and then fails wi
Petr Horáček has posted comments on this change.
Change subject: init: wait for network service
..
Patch Set 3: Code-Review-1
(3 comments)
http://gerrit.ovirt.org/#/c/36647/3//COMMIT_MSG
Commit Message:
Line 6:
Line 7: init:
Petr Horáček has posted comments on this change.
Change subject: contrib: add useful shell functions to assist in vdsm
development
..
Patch Set 7: Code-Review+1
--
To view, visit http://gerrit.ovirt.org/36344
To unsubscribe,
oVirt Jenkins CI Server has posted comments on this change.
Change subject: init: wait for network service
..
Patch Set 3:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_unit-tests_created/14851/ : SUCCESS
http://jenk
oVirt Jenkins CI Server has posted comments on this change.
Change subject: netlink: event monitor (even more simple version)
..
Patch Set 15:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-fc21_crea
oVirt Jenkins CI Server has posted comments on this change.
Change subject: ip route: parse only first part of each route
..
Patch Set 5:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_verify-error-codes_merged/6270/ :
oVirt Jenkins CI Server has posted comments on this change.
Change subject: netlink: event monitor (even more simple version)
..
Patch Set 14:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-fc21_crea
oVirt Jenkins CI Server has posted comments on this change.
Change subject: netlink: event monitor (even more simple version)
..
Patch Set 15:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-fc21_crea
oVirt Jenkins CI Server has posted comments on this change.
Change subject: netlink: event monitor (even more simple version)
..
Patch Set 13:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-fc21_crea
oVirt Jenkins CI Server has posted comments on this change.
Change subject: gluster: add glusterStorageDevicesList verb
..
Patch Set 14:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-fc21_created/26
oVirt Jenkins CI Server has posted comments on this change.
Change subject: ip route: parse route flags
..
Patch Set 7:
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_verify-error-codes_merged/6269/ :
SUCCESS
http://
oVirt Jenkins CI Server has posted comments on this change.
Change subject: gluster: add createBrick verb
..
Patch Set 5: Code-Review-1 Verified-1
Build Failed
http://jenkins.ovirt.org/job/vdsm_master_install-rpm-sanity-fc21_
Dan Kenigsberg has posted comments on this change.
Change subject: vmTests: clean after assertBuildCmdLine
..
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.ovirt.org/36665
To unsubscribe, visit http://gerrit.ovirt
1 - 100 of 101 matches
Mail list logo
