GitHub user jaceklaskowski opened a pull request:
https://github.com/apache/spark/pull/13384
[CORE][MINOR][DOC] Removing incorrect scaladoc
## What changes were proposed in this pull request?
I don't think the method will ever throw an exception so removing a false
comment
GitHub user jaceklaskowski opened a pull request:
https://github.com/apache/spark/pull/13383
[CORE][DOC][MINOR] typos + links
## What changes were proposed in this pull request?
A very tiny change to javadoc (which I don't mind if gets merged with a
bigger change). I've
Github user jaceklaskowski commented on a diff in the pull request:
https://github.com/apache/spark/pull/13392#discussion_r65136606
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala
---
@@ -937,8 +937,12 @@ object SimplifyConditionals
Github user jaceklaskowski commented on a diff in the pull request:
https://github.com/apache/spark/pull/13406#discussion_r65140165
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/catalog/interface.scala ---
@@ -25,6 +25,14 @@ import
Github user jaceklaskowski commented on a diff in the pull request:
https://github.com/apache/spark/pull/13406#discussion_r65140246
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/catalog/interface.scala ---
@@ -41,6 +49,16 @@ class Database
Github user jaceklaskowski commented on a diff in the pull request:
https://github.com/apache/spark/pull/13406#discussion_r65140296
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/catalog/interface.scala ---
@@ -83,9 +112,19 @@ class Column(
}
-// TODO
Github user jaceklaskowski commented on the pull request:
https://github.com/apache/spark/pull/13329#issuecomment-222140528
The issue with `nonEmpty` is that you could easily miss the negation (and
that's why Scala offers `nonEmpty`). I don't think it's the final solution
Github user jaceklaskowski commented on a diff in the pull request:
https://github.com/apache/spark/pull/13329#discussion_r64900321
--- Diff:
yarn/src/main/scala/org/apache/spark/scheduler/cluster/YarnScheduler.scala ---
@@ -31,9 +31,8 @@ private[spark] class YarnScheduler(sc
GitHub user jaceklaskowski opened a pull request:
https://github.com/apache/spark/pull/13329
[CORE][SQL][MINOR] Scaladoc fixes + string interpolation
## What changes were proposed in this pull request?
Scaladoc fixes + string interpolation for logging
## How
Github user jaceklaskowski commented on the pull request:
https://github.com/apache/spark/pull/13329#issuecomment-42718
How am I supposed to read this? Do you want me to...forget about the
changes? All of them or just some? Which one would you accept since @srowen
said: "
Github user jaceklaskowski commented on the pull request:
https://github.com/apache/spark/pull/13329#issuecomment-70008
Thanks @rxin and @srowen for your help and patience! I'll close the pull
request.
---
If your project is set up for it, you can reply to this email and have
Github user jaceklaskowski closed the pull request at:
https://github.com/apache/spark/pull/13329
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
GitHub user jaceklaskowski opened a pull request:
https://github.com/apache/spark/pull/13432
[CORE][DOC][MINOR] Remove incorrect scaladoc
## What changes were proposed in this pull request?
It removes a sentence about `SparkListener` being internal and may change
Github user jaceklaskowski commented on a diff in the pull request:
https://github.com/apache/spark/pull/13392#discussion_r65008333
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala
---
@@ -937,7 +937,8 @@ object SimplifyConditionals
GitHub user jaceklaskowski opened a pull request:
https://github.com/apache/spark/pull/10698
[STREAMING][MINOR] Typo fixes
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jaceklaskowski/spark
streaming-kafka-typo-fixes
Github user jaceklaskowski commented on a diff in the pull request:
https://github.com/apache/spark/pull/13909#discussion_r68506564
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/complexTypeCreator.scala
---
@@ -51,27 +51,52 @@ case class
Github user jaceklaskowski commented on a diff in the pull request:
https://github.com/apache/spark/pull/13909#discussion_r68506515
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/complexTypeCreator.scala
---
@@ -51,27 +51,52 @@ case class
Github user jaceklaskowski commented on a diff in the pull request:
https://github.com/apache/spark/pull/13909#discussion_r68506637
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/DataFrameComplexTypeSuite.scala ---
@@ -26,6 +26,20 @@ import
Github user jaceklaskowski commented on a diff in the pull request:
https://github.com/apache/spark/pull/13912#discussion_r68506371
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/csv/CSVRelation.scala
---
@@ -195,18 +202,50 @@ private[sql] class
Github user jaceklaskowski commented on a diff in the pull request:
https://github.com/apache/spark/pull/13912#discussion_r68506352
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/csv/CSVRelation.scala
---
@@ -195,18 +202,50 @@ private[sql] class
Github user jaceklaskowski commented on a diff in the pull request:
https://github.com/apache/spark/pull/13909#discussion_r68506607
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/DataFrameComplexTypeSuite.scala ---
@@ -26,6 +26,20 @@ import
Github user jaceklaskowski commented on the pull request:
https://github.com/apache/spark/pull/10946#issuecomment-176115262
I'd appreciate having it merged since the current master is broken without
the fix - checked early morning today.
---
If your project is set up for it, you can
Github user jaceklaskowski commented on the pull request:
https://github.com/apache/spark/pull/10946#issuecomment-177873394
@JoshRosen @rxin a friendly reminder to merge the change (or close it if
irrelevant)
---
If your project is set up for it, you can reply to this email and have
GitHub user jaceklaskowski opened a pull request:
https://github.com/apache/spark/pull/10878
[STREAMING][MINOR] Scaladoc + logs
Found while doing code review
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jaceklaskowski/spark
GitHub user jaceklaskowski opened a pull request:
https://github.com/apache/spark/pull/10946
Fix for [SPARK-12854][SQL] Implement complex types support in Columnaâ¦
â¦rBatch
Fixes build for Scala 2.11.
You can merge this pull request into a Git repository by running
Github user jaceklaskowski commented on the pull request:
https://github.com/apache/spark/pull/11201#issuecomment-186008514
@srowen Mind having a look? I'd appreciate. Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
GitHub user jaceklaskowski opened a pull request:
https://github.com/apache/spark/pull/11201
[STREAMING][DOCS] Fixes and code improvements for checkpointing
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jaceklaskowski/spark
Github user jaceklaskowski commented on the pull request:
https://github.com/apache/spark/pull/11681#issuecomment-196929219
@srowen Mind triggering a test? Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
GitHub user jaceklaskowski opened a pull request:
https://github.com/apache/spark/pull/11681
[SPARK-13825][CORE] Upgrade to Scala 2.11.8
## What changes were proposed in this pull request?
Upgrade to 2.11.8 (from the current 2.11.7)
## How was this patch tested
Github user jaceklaskowski commented on a diff in the pull request:
https://github.com/apache/spark/pull/11615#discussion_r55883199
--- Diff: core/src/main/scala/org/apache/spark/ui/JettyUtils.scala ---
@@ -270,9 +270,25 @@ private[spark] object JettyUtils extends Logging
Github user jaceklaskowski commented on a diff in the pull request:
https://github.com/apache/spark/pull/11802#discussion_r56738903
--- Diff:
streaming/src/main/scala/org/apache/spark/streaming/dstream/DStream.scala ---
@@ -277,7 +277,7 @@ abstract class DStream[T: ClassTag
Github user jaceklaskowski commented on the pull request:
https://github.com/apache/spark/pull/11802#issuecomment-198593089
Thanks @srowen @thunterdb for review!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user jaceklaskowski commented on a diff in the pull request:
https://github.com/apache/spark/pull/11615#discussion_r55868740
--- Diff: core/src/main/scala/org/apache/spark/ui/JettyUtils.scala ---
@@ -270,9 +270,25 @@ private[spark] object JettyUtils extends Logging
Github user jaceklaskowski commented on a diff in the pull request:
https://github.com/apache/spark/pull/11615#discussion_r55869059
--- Diff: core/src/main/scala/org/apache/spark/ui/JettyUtils.scala ---
@@ -270,9 +270,25 @@ private[spark] object JettyUtils extends Logging
Github user jaceklaskowski commented on a diff in the pull request:
https://github.com/apache/spark/pull/12274#discussion_r59124592
--- Diff: mllib/src/main/scala/org/apache/spark/ml/Predictor.scala ---
@@ -171,18 +171,18 @@ abstract class PredictionModel[FeaturesType, M
Github user jaceklaskowski commented on a diff in the pull request:
https://github.com/apache/spark/pull/12274#discussion_r59124613
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/regression/impl/GLMRegressionModel.scala
---
@@ -23,7 +23,7 @@ import
Github user jaceklaskowski commented on a diff in the pull request:
https://github.com/apache/spark/pull/12274#discussion_r59124562
--- Diff: mllib/src/main/scala/org/apache/spark/ml/Pipeline.scala ---
@@ -124,7 +124,7 @@ class Pipeline @Since("1.4.0") (
* @ret
Github user jaceklaskowski commented on a diff in the pull request:
https://github.com/apache/spark/pull/12274#discussion_r59124622
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/tree/model/DecisionTreeModel.scala
---
@@ -32,7 +32,7 @@ import
GitHub user jaceklaskowski opened a pull request:
https://github.com/apache/spark/pull/12192
[HOTFIX][SPARK-14402] Fix ExpressionDescription annotation
## What changes were proposed in this pull request?
Fix for the error introduced in
https://github.com/apache/spark
Github user jaceklaskowski commented on the pull request:
https://github.com/apache/spark/pull/12192#issuecomment-206095697
Is this really the patch to cause the issue or is this more an interim
hiccup?
---
If your project is set up for it, you can reply to this email and have your
Github user jaceklaskowski commented on the pull request:
https://github.com/apache/spark/pull/12192#issuecomment-207175670
Please please merge it as soon as possible as I'm suffering from not having
it in master every time I do the build :(
---
If your project is set up for it, you
Github user jaceklaskowski commented on a diff in the pull request:
https://github.com/apache/spark/pull/12119#discussion_r59296064
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/DataFrameWriter.scala ---
@@ -275,23 +277,64 @@ final class DataFrameWriter private[sql](df
GitHub user jaceklaskowski opened a pull request:
https://github.com/apache/spark/pull/11802
[MINOR] Typo fixes
## What changes were proposed in this pull request?
Typo fixes. No functional changes.
## How was this patch tested?
Built the sources and ran
Github user jaceklaskowski commented on a diff in the pull request:
https://github.com/apache/spark/pull/11802#discussion_r57455819
--- Diff:
streaming/src/main/scala/org/apache/spark/streaming/StreamingContext.scala ---
@@ -246,9 +246,7 @@ class StreamingContext private[streaming
Github user jaceklaskowski commented on a diff in the pull request:
https://github.com/apache/spark/pull/11575#discussion_r55345145
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/feature/StringIndexerSuite.scala ---
@@ -178,6 +178,20 @@ class StringIndexerSuite
Github user jaceklaskowski commented on a diff in the pull request:
https://github.com/apache/spark/pull/10428#discussion_r55347052
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/datetimeExpressions.scala
---
@@ -126,6 +144,13 @@ case class Hour
Github user jaceklaskowski commented on a diff in the pull request:
https://github.com/apache/spark/pull/11568#discussion_r55406003
--- Diff: core/src/main/scala/org/apache/spark/SparkConf.scala ---
@@ -351,7 +351,16 @@ class SparkConf(loadDefaults: Boolean) extends
Cloneable
Github user jaceklaskowski commented on a diff in the pull request:
https://github.com/apache/spark/pull/11568#discussion_r55408473
--- Diff: core/src/main/scala/org/apache/spark/SparkConf.scala ---
@@ -351,7 +351,16 @@ class SparkConf(loadDefaults: Boolean) extends
Cloneable
GitHub user jaceklaskowski opened a pull request:
https://github.com/apache/spark/pull/11915
[MINOR][ML] Use Datasets (to improve internal implementation)
## What changes were proposed in this pull request?
Change the current implementation to use Datasets (not the &quo
Github user jaceklaskowski commented on a diff in the pull request:
https://github.com/apache/spark/pull/12666#discussion_r60991107
--- Diff: core/src/main/scala/org/apache/spark/scheduler/Pool.scala ---
@@ -55,6 +55,8 @@ private[spark] class Pool(
new
Github user jaceklaskowski commented on the pull request:
https://github.com/apache/spark/pull/12569#issuecomment-213275339
@HyukjinKwon In that case I'd ask for the alternative as I currently have
no idea how to make it clearer (it wasn't me to say "the title is not clear"
Github user jaceklaskowski commented on the pull request:
https://github.com/apache/spark/pull/12569#issuecomment-213387430
Title has changed to incorporate @HyukjinKwon's suggestion. Please review
@srowen. I intentionally have not included "in the programming guide" due
Github user jaceklaskowski commented on a diff in the pull request:
https://github.com/apache/spark/pull/12469#discussion_r60725372
--- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveUtils.scala
---
@@ -80,10 +80,8 @@ class HiveContext private[hive](
protected
Github user jaceklaskowski commented on a diff in the pull request:
https://github.com/apache/spark/pull/12469#discussion_r60726392
--- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveUtils.scala
---
@@ -80,10 +80,8 @@ class HiveContext private[hive](
protected
Github user jaceklaskowski commented on a diff in the pull request:
https://github.com/apache/spark/pull/12469#discussion_r60727194
--- Diff: sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveUtils.scala
---
@@ -80,10 +80,8 @@ class HiveContext private[hive](
protected
Github user jaceklaskowski commented on the pull request:
https://github.com/apache/spark/pull/12469#issuecomment-213118039
I fixed the issue with the two failing tests due to the error message
having been changed.
Jenkins retest this please
:)
---
If your project
Github user jaceklaskowski commented on the pull request:
https://github.com/apache/spark/pull/12569#issuecomment-213819194
Could this PR have a bit of @srowen's attention? :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user jaceklaskowski commented on the pull request:
https://github.com/apache/spark/pull/12469#issuecomment-214638031
@srowen Reverted the line removal and rebased with master. Mind merging it
to the repo? Thanks.
---
If your project is set up for it, you can reply
Github user jaceklaskowski commented on a diff in the pull request:
https://github.com/apache/spark/pull/13209#discussion_r63987980
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala ---
@@ -348,6 +348,11 @@ object SQLConf {
.booleanConf
Github user jaceklaskowski commented on a diff in the pull request:
https://github.com/apache/spark/pull/13210#discussion_r63987667
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/UnsupportedOperationChecker.scala
---
@@ -55,10 +55,19 @@ object
Github user jaceklaskowski commented on a diff in the pull request:
https://github.com/apache/spark/pull/13210#discussion_r63987729
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/UnsupportedOperationChecker.scala
---
@@ -55,10 +55,19 @@ object
Github user jaceklaskowski commented on a diff in the pull request:
https://github.com/apache/spark/pull/13210#discussion_r63987696
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/UnsupportedOperationChecker.scala
---
@@ -55,10 +55,19 @@ object
Github user jaceklaskowski commented on a diff in the pull request:
https://github.com/apache/spark/pull/13238#discussion_r64127527
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/DataSource.scala
---
@@ -186,6 +187,14 @@ case class DataSource
Github user jaceklaskowski commented on a diff in the pull request:
https://github.com/apache/spark/pull/13238#discussion_r64127555
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/streaming/FileStreamSourceSuite.scala
---
@@ -140,6 +140,18 @@ class FileStreamSourceSuite
Github user jaceklaskowski commented on a diff in the pull request:
https://github.com/apache/spark/pull/12928#discussion_r62169812
--- Diff: yarn/src/main/scala/org/apache/spark/deploy/yarn/Client.scala ---
@@ -155,10 +155,10 @@ private[spark] class Client(
// Get
GitHub user jaceklaskowski opened a pull request:
https://github.com/apache/spark/pull/12928
[SPARK-15152][DOC][MINOR] Scaladoc and Code style Improvements
## What changes were proposed in this pull request?
Minor doc and code style fixes
## How was this patch
Github user jaceklaskowski commented on a diff in the pull request:
https://github.com/apache/spark/pull/12928#discussion_r62170253
--- Diff: yarn/src/main/scala/org/apache/spark/deploy/yarn/Client.scala ---
@@ -168,7 +168,7 @@ private[spark] class Client(
val appContext
Github user jaceklaskowski commented on a diff in the pull request:
https://github.com/apache/spark/pull/12928#discussion_r62170912
--- Diff: core/src/main/scala/org/apache/spark/scheduler/Pool.scala ---
@@ -98,13 +97,12 @@ private[spark] class Pool(
}
override
Github user jaceklaskowski commented on a diff in the pull request:
https://github.com/apache/spark/pull/12469#discussion_r60092677
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/Dataset.scala ---
@@ -453,8 +453,8 @@ class Dataset[T] private[sql](
* Returns true
Github user jaceklaskowski commented on a diff in the pull request:
https://github.com/apache/spark/pull/12469#discussion_r60092525
--- Diff: mllib/src/main/scala/org/apache/spark/mllib/linalg/Vectors.scala
---
@@ -38,8 +38,6 @@ import org.apache.spark.sql.types
Github user jaceklaskowski commented on a diff in the pull request:
https://github.com/apache/spark/pull/12469#discussion_r60092825
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/HDFSMetadataLog.scala
---
@@ -46,8 +46,7 @@ import
Github user jaceklaskowski commented on a diff in the pull request:
https://github.com/apache/spark/pull/12469#discussion_r60092387
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/regression/LinearRegression.scala ---
@@ -438,7 +438,6 @@ class LinearRegressionModel private[ml
Github user jaceklaskowski commented on the pull request:
https://github.com/apache/spark/pull/11915#issuecomment-211605171
Sorry, no. Got distracted and had no time for it. Let me work on it later
today (it's 00:21 already).
---
If your project is set up for it, you can reply
GitHub user jaceklaskowski opened a pull request:
https://github.com/apache/spark/pull/12469
Minor typo fixes
## What changes were proposed in this pull request?
Minor typo fixes (too minor to deserve separate a JIRA)
## How was this patch tested?
local
Github user jaceklaskowski commented on the pull request:
https://github.com/apache/spark/pull/12469#issuecomment-212316780
@srowen Mind reviewing and possibly merging afterwards? Thanks.
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user jaceklaskowski commented on a diff in the pull request:
https://github.com/apache/spark/pull/12569#discussion_r60577867
--- Diff: docs/programming-guide.md ---
@@ -1328,12 +1328,18 @@ value of the broadcast variable (e.g. if the
variable is shipped to a new node l
Github user jaceklaskowski commented on the pull request:
https://github.com/apache/spark/pull/12469#issuecomment-212920619
Done @srowen. Thanks a lot for your patience.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
GitHub user jaceklaskowski opened a pull request:
https://github.com/apache/spark/pull/12569
[DOCS][MINOR] Accumulators
## What changes were proposed in this pull request?
Added screenshot + minor fixes to improve reading
## How was this patch tested
Github user jaceklaskowski commented on the pull request:
https://github.com/apache/spark/pull/12985#issuecomment-217727591
What do you think about a unit test for this?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user jaceklaskowski commented on a diff in the pull request:
https://github.com/apache/spark/pull/12718#discussion_r61494448
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/feature/ChiSqSelector.scala ---
@@ -79,11 +79,12 @@ final class ChiSqSelector(override val uid
Github user jaceklaskowski commented on the pull request:
https://github.com/apache/spark/pull/12718#issuecomment-215550190
Other than the few places where you could use symbols not string literals
LGTM. Excellent job! Thanks.
---
If your project is set up for it, you can reply
Github user jaceklaskowski commented on a diff in the pull request:
https://github.com/apache/spark/pull/14302#discussion_r71885483
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/tables.scala ---
@@ -436,11 +436,13 @@ case class DescribeTableCommand(table
Github user jaceklaskowski commented on a diff in the pull request:
https://github.com/apache/spark/pull/14309#discussion_r71888979
--- Diff: sql/core/src/test/scala/org/apache/spark/sql/DataFrameSuite.scala
---
@@ -641,6 +641,10 @@ class DataFrameSuite extends QueryTest
Github user jaceklaskowski commented on a diff in the pull request:
https://github.com/apache/spark/pull/14309#discussion_r7196
--- Diff: sql/core/src/test/scala/org/apache/spark/sql/DataFrameSuite.scala
---
@@ -641,6 +641,10 @@ class DataFrameSuite extends QueryTest
Github user jaceklaskowski commented on a diff in the pull request:
https://github.com/apache/spark/pull/14309#discussion_r7137
--- Diff: sql/core/src/test/scala/org/apache/spark/sql/DataFrameSuite.scala
---
@@ -641,6 +641,10 @@ class DataFrameSuite extends QueryTest
Github user jaceklaskowski commented on a diff in the pull request:
https://github.com/apache/spark/pull/14302#discussion_r71886372
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/HiveOperatorQueryableSuite.scala
---
@@ -41,13 +41,13 @@ class
Github user jaceklaskowski commented on the issue:
https://github.com/apache/spark/pull/14307
I didn't even know such a SQL query is possible in SQL :) Lots to learn
still.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user jaceklaskowski commented on the issue:
https://github.com/apache/spark/pull/14305
I think the PR is completely broken and should be recreated.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user jaceklaskowski commented on a diff in the pull request:
https://github.com/apache/spark/pull/14292#discussion_r72148282
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/test/SQLTestUtils.scala ---
@@ -247,6 +248,46 @@ private[sql] trait SQLTestUtils
Github user jaceklaskowski commented on a diff in the pull request:
https://github.com/apache/spark/pull/14292#discussion_r72148009
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/StreamExecution.scala
---
@@ -269,19 +273,11 @@ class StreamExecution
Github user jaceklaskowski commented on a diff in the pull request:
https://github.com/apache/spark/pull/14285#discussion_r71776630
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/ExternalCatalog.scala
---
@@ -167,6 +168,21 @@ abstract class
Github user jaceklaskowski commented on a diff in the pull request:
https://github.com/apache/spark/pull/14304#discussion_r71773933
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/parquet/ParquetEncodingSuite.scala
---
@@ -78,4 +78,29 @@ class
Github user jaceklaskowski commented on a diff in the pull request:
https://github.com/apache/spark/pull/14285#discussion_r71776725
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/SessionCatalog.scala
---
@@ -632,6 +632,23 @@ class SessionCatalog
Github user jaceklaskowski commented on a diff in the pull request:
https://github.com/apache/spark/pull/14285#discussion_r71776877
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/SessionCatalog.scala
---
@@ -632,6 +632,23 @@ class SessionCatalog
Github user jaceklaskowski commented on a diff in the pull request:
https://github.com/apache/spark/pull/14304#discussion_r71774436
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/parquet/ParquetEncodingSuite.scala
---
@@ -78,4 +78,29 @@ class
Github user jaceklaskowski commented on a diff in the pull request:
https://github.com/apache/spark/pull/14295#discussion_r71908714
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/Last.scala
---
@@ -42,6 +42,17 @@ case class Last(child
Github user jaceklaskowski commented on a diff in the pull request:
https://github.com/apache/spark/pull/14327#discussion_r71992254
--- Diff: sql/core/src/test/scala/org/apache/spark/sql/DatasetSuite.scala
---
@@ -422,6 +422,32 @@ class DatasetSuite extends QueryTest
Github user jaceklaskowski commented on a diff in the pull request:
https://github.com/apache/spark/pull/14327#discussion_r71992242
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala
---
@@ -150,13 +150,20 @@ class SimpleTestOptimizer
Github user jaceklaskowski commented on a diff in the pull request:
https://github.com/apache/spark/pull/14327#discussion_r71992270
--- Diff: sql/core/src/test/scala/org/apache/spark/sql/DatasetSuite.scala
---
@@ -422,6 +422,32 @@ class DatasetSuite extends QueryTest
Github user jaceklaskowski commented on a diff in the pull request:
https://github.com/apache/spark/pull/14326#discussion_r71992474
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/regression/RobustRegression.scala ---
@@ -0,0 +1,466 @@
+/*
+ * Licensed to the Apache
101 - 200 of 589 matches
Mail list logo
