On Wed, 13 Mar 2024 16:56:39 GMT, Alexander Zvegintsev
wrote:
>> @azvegint, yes, we can support both. But I didn't test it thoroughly, so I
>> decided it was safer to add this.
>>
>> Please, don't modify `PassFailJFrame` together with tests unless it's
>> strictly required… It is for the sake
On Wed, 13 Mar 2024 19:01:27 GMT, Alexander Zvegintsev
wrote:
>> The test is converted to main.
>> Tested on Linux, Macos and Windows.
>
> Alexander Zvegintsev has updated the pull request incrementally with one
> additional commit since the last revision:
>
> extract logFrameBounds, instruc
On Thu, 14 Mar 2024 11:43:44 GMT, Alexey Ivanov wrote:
>> test/jdk/java/awt/TrayIcon/TrayIconScalingTest.java line 97:
>>
>>> 95: .testTimeOut(8)
>>> 96: .rows(25)
>>> 97: .columns(70)
&
On Wed, 13 Mar 2024 22:04:00 GMT, Phil Race wrote:
>> Alexey Ivanov has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase.
>
> te
`build` method shows all the
> registered windows on the screen, including the instruction frame. Since
> there's no secondary UI, the instructions remain in the centre of the screen.
Alexey Ivanov has updated the pull request with a new target base due to a
merge or a rebase. The pul
`build` method shows all the
> registered windows on the screen, including the instruction frame. Since
> there's no secondary UI, the instructions remain in the centre of the screen.
Alexey Ivanov has updated the pull request with a new target base due to a
merge or a rebase. The
On Mon, 11 Mar 2024 21:18:40 GMT, Alexey Ivanov wrote:
> The `Builder` class in `PassFailJFrame` is public and has a public
> constructor. At the same time, a better design would be to hide all the
> Builder constructors and rely on the `builder()` method which returns an
> ins
ng it here.
>> All comments from the previous review are addressed.
>
> Alexander Zuev has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Update test/jdk/javax/swing/JEditorPane/bug4325606.java
>
> Co-autho
On Thu, 14 Mar 2024 09:25:29 GMT, Alexey Ivanov wrote:
>> Alexander Zuev has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Update test/jdk/javax/swing/JDesktopPane/bug4773378.java
>>
>> Co-auth
On Thu, 14 Mar 2024 06:51:47 GMT, Tejesh R wrote:
>> Convert javax/swing/border/Test4129681.java applet test to main based test
>> using PassFailJFrame.
>
> Tejesh R has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Review updates
Marked as
On Thu, 14 Mar 2024 06:48:08 GMT, Tejesh R wrote:
>> test/jdk/javax/swing/border/Test4129681.java line 43:
>>
>>> 41: public static void main(String[] args) throws Exception {
>>> 42: String testInstructions = """
>>> 43: Turn on the checkbox to disable the label.
>>
On Wed, 13 Mar 2024 20:51:18 GMT, Alexander Zuev wrote:
>> test/jdk/javax/swing/JEditorPane/bug4694598.java line 74:
>>
>>> 72: String html = " " +
>>> 73: "" +
>>> 74: "" +
>>
>> Suggestion:
>>
>> "" +
>>
>> Isn't it enough? Alternative
On Wed, 13 Mar 2024 20:49:19 GMT, Alexander Zuev wrote:
>> test/jdk/javax/swing/JEditorPane/bug4694598.java line 64:
>>
>>> 62: } catch (IOException ioe){
>>> 63: throw new RuntimeException("Could not create html file to
>>> embed", ioe);
>>> 64: }
>>
>> Move creati
On Wed, 13 Mar 2024 19:57:08 GMT, Alexander Zuev wrote:
>> test/jdk/javax/swing/JEditorPane/bug4325606.java line 84:
>>
>>> 82: robo.setAutoDelay(100);
>>> 83: robo.delay(1000);
>>> 84: Point p = frame.getLocationOnScreen();
>>
>> Technically, `getLocationOnS
ng it here.
>> All comments from the previous review are addressed.
>
> Alexander Zuev has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Update test/jdk/javax/swing/JDesktopPane/bug4773378.java
>
> Co-authored-by: Alexey
On Wed, 13 Mar 2024 19:40:16 GMT, Alexander Zuev wrote:
>> test/jdk/javax/swing/JDesktopPane/bug4773378.java line 99:
>>
>>> 97: bug4773378.this.wait();
>>> 98: }
>>> 99: }
>>
>> Suggestion:
>>
>> frameActivated.await();
>>
>>
>> Using `CountDownLa
On Wed, 6 Mar 2024 11:27:08 GMT, Alexey Ivanov wrote:
>> Ensure access to the `filesLoader` field of `BasicDirectoryModel` is
>> synchronized.
>>
>> Without synchronization, a thread checks if `filesLoader` is not null and
>> creates a new `FilesLoader` threa
On Wed, 13 Mar 2024 17:29:46 GMT, Alexey Ivanov wrote:
>> Alexander Zvegintsev has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> minor formatting
>
> test/jdk/java/awt/Frame/GetBoundsRes
On Wed, 13 Mar 2024 00:53:36 GMT, Alexander Zvegintsev
wrote:
>> The test is converted to main.
>> Tested on Linux, Macos and Windows.
>
> Alexander Zvegintsev has updated the pull request incrementally with one
> additional commit since the last revision:
>
> minor formatting
test/jdk/java
On Wed, 13 Mar 2024 18:26:28 GMT, Alexey Ivanov wrote:
>> test/jdk/java/awt/Frame/GetBoundsResizeTest.java line 75:
>>
>>> 73: EventQueue.invokeAndWait(() ->
>>> 74: textArea.append("Original Frame.getBounds() = %s\n"
On Wed, 13 Mar 2024 16:55:08 GMT, Alexander Zvegintsev
wrote:
> It is currently blocked with an artificial check:
>
>
> if (panelCreator != null) {
> if (splitUI && (testWindows != null || windowListCreator != null)) {
> // TODO Is it required? We can support both
> throw n
On Wed, 13 Mar 2024 16:55:08 GMT, Alexander Zvegintsev
wrote:
> It is currently blocked with an artificial check:
>
>
> if (panelCreator != null) {
> if (splitUI && (testWindows != null || windowListCreator != null)) {
> // TODO Is it required? We can support both
> throw n
On Wed, 13 Mar 2024 15:57:55 GMT, Alexey Ivanov wrote:
> > If this makes that CCME go away I'll be pleased.
>
> @prrace CCME is already gone, Tejesh and I resolved it under
> [JDK-8323670](https://bugs.openjdk.org/browse/JDK-8323670) in #17462.
The
On Tue, 12 Mar 2024 21:02:08 GMT, Phil Race wrote:
> > "When the test passes, it usually completes in 5 minutes."
>
> and you've never seen the test time out ? I thought default jtreg timeout is
> 120 seconds.
No, I've never seen the test time out.
The default timeout is factored by 2 in clie
On Wed, 13 Mar 2024 06:49:16 GMT, Alexander Zuev wrote:
> Cleaned up five more tests.
>
> Continuation of https://github.com/openjdk/jdk/pull/18184
>
> Unfortunately one of the commits rendered the whole PR invalid so i closed it
> and restarting it here.
> All comments from the previous revie
On Tue, 12 Mar 2024 20:01:29 GMT, Phil Race wrote:
> If this makes that CCME go away I'll be pleased.
@prrace CCME is already gone, Tejesh and I resolved it under
[JDK-8323670](https://bugs.openjdk.org/browse/JDK-8323670) in #17462.
> I am assuming you've run the "full" battery of tests on thi
On Tue, 12 Mar 2024 19:37:55 GMT, Alexander Zvegintsev
wrote:
>> Alexander Zvegintsev has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> minor formatting
>
> test/jdk/java/awt/regtesthelpers/PassFailJFrame.java line 1338:
>
>> 1336:
On Tue, 12 Mar 2024 18:21:58 GMT, Phil Race wrote:
>> Converts the manual applet test in the files ..
>> SpanishDiacriticsTest/SpanishDiacriticsTest.html
>> SpanishDiacriticsTest/SpanishDiacriticsTest.java
>> .. to a main program using PassFailJFrame
>>
>> Added requires windows since it seems
On Tue, 12 Mar 2024 17:36:46 GMT, Phil Race wrote:
>> Converts the manual applet test in the files ..
>> SpanishDiacriticsTest/SpanishDiacriticsTest.html
>> SpanishDiacriticsTest/SpanishDiacriticsTest.java
>> .. to a main program using PassFailJFrame
>>
>> Added requires windows since it seems
On Tue, 12 Mar 2024 17:24:22 GMT, Phil Race wrote:
>> What if we spell the conditions explicitly:
>>
>> The text field should display ''o (i.e. two apostrophes and o without an
>> acute), press Pass.
>> If you see ó (i.e. o with an acute), press Fail.
>
> I will reword it but the text is the sa
On Tue, 12 Mar 2024 12:50:16 GMT, Alexey Ivanov wrote:
>> Phil Race has updated the pull request incrementally with two additional
>> commits since the last revision:
>>
>> - 8327856
>> - 8327856
>
> test/jdk/java/awt/InputMethods/SpanishD
On Tue, 12 Mar 2024 17:08:18 GMT, Alexey Ivanov wrote:
>> It isn't a single char. It is as written - the sequence of 3 characters -
>> "single quote" "single quote", "latin lower case o"
>
> I misread it. If the text is `''o` in
On Tue, 12 Mar 2024 17:05:04 GMT, Phil Race wrote:
>> test/jdk/java/awt/InputMethods/SpanishDiacriticsTest.java line 60:
>>
>>> 58: expected behaviour for this test.
>>> 59:
>>> 60:If the text field displays ''o, (i.e. o should be without an
>>> acute)
>>
>> Suggestion:
>>
On Tue, 12 Mar 2024 16:36:15 GMT, Phil Race wrote:
>> Alexey Ivanov has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Use the correct path to library
>
> test/jdk/java/awt/font/TextLayout/ArabicBox.java line
> The test is converted to use `PassFailJFrame`.
>
> I confirmed the updated test reproduce the original problem described in
> [JDK-4427483](https://bugs.openjdk.org/browse/JDK-4427483) where Arabic text
> displayed as missing glyphs.
Alexey Ivanov has updated the pull reques
On Tue, 12 Mar 2024 12:34:57 GMT, Alexander Zvegintsev
wrote:
> The test is converted to main.
> Tested on Linux, Macos and Windows.
Marked as reviewed by aivanov (Reviewer).
-
PR Review: https://git.openjdk.org/jdk/pull/18231#pullrequestreview-1931511748
On Tue, 12 Mar 2024 08:33:41 GMT, Alexey Ivanov wrote:
> This is to simplify `TrayIconScalingTest.java`.
>
> 1. Rename `createAndShowGUI` to `createAndShowTrayIcon` which is more
> specific.
> 2. Move creating tray icon to the top.
> 3. Streamline PassFailJFrame with
On Tue, 12 Mar 2024 13:42:28 GMT, Alexey Ivanov wrote:
>> Create a new bug to improve and to clean up the test then.
>
> At the same time, I think you should use the term _“shortcut (.lnk file)”_ in
> the instructions so that it's clear.
>
> The thing is .lnk files
On Tue, 12 Mar 2024 13:52:28 GMT, Prasanta Sadhukhan
wrote:
>> Conversion of manual applet test to main based using PassFailJFrame manual
>> framework
>
> Prasanta Sadhukhan has updated the pull request incrementally with one
> additional commit since the last revision:
>
> instruction upda
On Tue, 12 Mar 2024 13:39:43 GMT, Alexey Ivanov wrote:
>> SInce this exercise is just to convert applet to main, I tried to keep the
>> instructions same (although I agree it seems ambiguous and I also am not
>> clear what needs to be done) which seems to be ok with the
On Tue, 12 Mar 2024 12:47:55 GMT, Prasanta Sadhukhan
wrote:
>> It seems a Windows shortcut is crucial to reproducing the original problem,
>> if it is, the handler for the Start button could show an error message about
>> this fact.
>>
>> Perhaps, if this link cannot be converted to a file in
The test is converted to use `PassFailJFrame`.
I confirmed the updated test reproduce the original problem described in
[JDK-4427483](https://bugs.openjdk.org/browse/JDK-4427483) where Arabic text
displayed as missing glyphs.
-
Commit messages:
- 8320079: The ArabicBox.java test h
On Mon, 11 Mar 2024 23:02:53 GMT, Phil Race wrote:
> Converts the manual applet test in the files ..
> SpanishDiacriticsTest/SpanishDiacriticsTest.html
> SpanishDiacriticsTest/SpanishDiacriticsTest.java
> .. to a main program using PassFailJFrame
>
> Added requires windows since it seems very w
On Tue, 12 Mar 2024 12:37:18 GMT, Alexey Ivanov wrote:
>> test/jdk/javax/swing/JFileChooser/6798062/bug6798062.java line 60:
>>
>>> 58:
>>> 59: 1. Create a link
>>> 60: 2. Copy path to the link into TextField
>>
>> I
On Tue, 12 Mar 2024 10:59:48 GMT, Alexey Ivanov wrote:
>> Prasanta Sadhukhan has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Review comment update
>
> test/jdk/javax/swing/JFileChooser/6798062/bug6798062.
On Tue, 12 Mar 2024 11:58:40 GMT, Alexey Ivanov wrote:
>> It is not unexpected but instead of failing i think test should just pass.
>> Which will happen because the internal frame is not minimized so the test
>> condition is not recreated.
>
> I believe it's unexp
On Tue, 12 Mar 2024 12:05:33 GMT, Alexey Ivanov wrote:
>> This is a very simple case and sleeping worked for it so i do not see reason
>> to rewrite it with CDL.
>
> Using CDL can reduce the execution time… likely the three clicks are handled
> more quickly than in 3 s
On Tue, 12 Mar 2024 09:34:38 GMT, Alexander Zuev wrote:
> I would prefer to keep the directory structure - it does not make any
> difference after al and sometimes makes test logs more readable.
At times, I find it easier to manage in IDE either. Just mark one folder as
Test Sources, and it br
On Tue, 12 Mar 2024 09:00:18 GMT, Alexander Zuev wrote:
>> test/jdk/javax/swing/JDesktopPane/4773378/bug4773378.java line 69:
>>
>>> 67: keyTyped = true;
>>> 68: bug4773378.this.notifyAll();
>>> 69: }
>>
>> A `CountDownLatch` w
On Tue, 12 Mar 2024 11:07:38 GMT, Alexander Zuev wrote:
>> Clean up five more tests.
>>
>> test/jdk/javax/swing/JDesktopPane/4132993/bug4132993.java
>> test/jdk/javax/swing/JDesktopPane/4773378/bug4773378.java
>> test/jdk/javax/swing/JEditorPane/4325606/bug4325606.java
>> test/jdk/javax/swing/JE
On Tue, 12 Mar 2024 08:46:45 GMT, Alexander Zuev wrote:
>> test/jdk/javax/swing/JDesktopPane/4132993/bug4132993.java line 47:
>>
>>> 45: } catch (PropertyVetoException ex) {
>>> 46: ex.printStackTrace();
>>> 47: }
>>
>> Shouldn't the test fail if an unexp
On Tue, 12 Mar 2024 11:39:46 GMT, Alexey Ivanov wrote:
>> I think it's needed to have some files in the directory..
>> This test is problemlisted actually and as per [this
>> comment](https://bugs.openjdk.org/browse/JDK-8146446?
On Tue, 12 Mar 2024 11:24:37 GMT, Prasanta Sadhukhan
wrote:
>> test/jdk/javax/swing/JFileChooser/6798062/bug6798062.java line 108:
>>
>>> 106:
>>> 107: try {
>>> 108: folder = ShellFolder.getShellFolder(new File("."));
>>
>> I wonder if it was expected that there are files
On Tue, 12 Mar 2024 10:37:04 GMT, Prasanta Sadhukhan
wrote:
>> test/jdk/javax/swing/JFileChooser/FileFilterDescription/FileFilterDescription.java
>> line 54:
>>
>>> 52: .rows(10)
>>> 53: .columns(35)
>>> 54: .build();
>>
>> Suggestion:
>>
>>
On Tue, 12 Mar 2024 10:25:28 GMT, Alexander Zvegintsev
wrote:
>> The `java/awt/FileDialog/RegexpFilterTest/RegexpFilterTest` test is written
>> to test the very specific functionality of `XFileDialogPeer`, so it
>> shouldn't be run on platforms other than Linux.
>>
>> We also need to set `sun
On Tue, 12 Mar 2024 10:22:35 GMT, Alexander Zvegintsev
wrote:
>> The test is converted to main.
>> Tested on Linux, Macos and Windows.
>
> Alexander Zvegintsev has updated the pull request incrementally with one
> additional commit since the last revision:
>
> review comments
Marked as revi
On Tue, 12 Mar 2024 10:27:45 GMT, Alexander Zvegintsev
wrote:
>> Now its fine on my screen. But its not in center, but top. Does it differ
>> for windows and linux?
>
> It is not in the center, because in the latest commit I added
> `.position(PassFailJFrame.Position.TOP_LEFT_CORNER)`, as Alex
On Tue, 12 Mar 2024 09:47:37 GMT, Tejesh R wrote:
>> Convert javax/swing/border/Test4129681.java applet test to main based test
>> using PassFailJFrame.
>
> Tejesh R has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Review updates
Marked as
On Tue, 12 Mar 2024 09:08:08 GMT, Alexey Ivanov wrote:
>> Tejesh R has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Review updates
>
> test/jdk/javax/swing/border/Test4129681.java line
On Tue, 12 Mar 2024 09:53:43 GMT, Tejesh R wrote:
>> Convert javax/swing/border/Test4243289.java applet test to main based test
>> using PassFailJFrame.
>
> Tejesh R has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Review updates
Marked as
On Tue, 12 Mar 2024 10:54:37 GMT, Prasanta Sadhukhan
wrote:
>> Conversion of manual applet test to main based using PassFailJFrame manual
>> framework
>
> Prasanta Sadhukhan has updated the pull request incrementally with one
> additional commit since the last revision:
>
> move frame init
On Tue, 12 Mar 2024 02:51:48 GMT, Prasanta Sadhukhan
wrote:
>> Conversion of manual applet test to main based using PassFailJFrame manual
>> framework
>
> Prasanta Sadhukhan has updated the pull request incrementally with two
> additional commits since the last revision:
>
> - Review comment
On Tue, 12 Mar 2024 10:51:47 GMT, Prasanta Sadhukhan
wrote:
> As I understood, testUI calls the passed method in EDT so I think it's better
> to init the swing variables there..
Yes, that's true, if you pass a lambda expression to `testUI`, it is called on
EDT.
Since `initialize` is called f
On Tue, 12 Mar 2024 10:54:37 GMT, Prasanta Sadhukhan
wrote:
>> Conversion of manual applet test to main based using PassFailJFrame manual
>> framework
>
> Prasanta Sadhukhan has updated the pull request incrementally with one
> additional commit since the last revision:
>
> move frame init
On Tue, 12 Mar 2024 02:49:25 GMT, Prasanta Sadhukhan
wrote:
>> Conversion of manual applet test to main based using PassFailJFrame manual
>> framework
>
> Prasanta Sadhukhan has updated the pull request incrementally with one
> additional commit since the last revision:
>
> Review comment u
On Tue, 12 Mar 2024 03:51:52 GMT, Tejesh R wrote:
>> Prasanta Sadhukhan has updated the pull request incrementally with two
>> additional commits since the last revision:
>>
>> - Review comment update
>> - Review comment update
>
> test/jdk/javax/swing/JFileChooser/FileFilterDescription/FileF
On Tue, 12 Mar 2024 02:47:25 GMT, Prasanta Sadhukhan
wrote:
>> Conversion of manual applet test to main based using PassFailJFrame manual
>> framework
>
> Prasanta Sadhukhan has updated the pull request incrementally with two
> additional commits since the last revision:
>
> - Review comment
On Mon, 11 Mar 2024 23:28:30 GMT, Alexander Zvegintsev
wrote:
>> The test is converted to main.
>> Tested on Linux, Macos and Windows.
>
> Alexander Zvegintsev has updated the pull request incrementally with one
> additional commit since the last revision:
>
> review comments
Looks good to
On Tue, 12 Mar 2024 05:17:31 GMT, Tejesh R wrote:
>> Alexander Zvegintsev has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> review comments
>
> test/jdk/java/awt/FileDialog/MultipleMode.java line 101:
>
>> 99: frame.add(sysout, Bo
On Mon, 11 Mar 2024 23:18:28 GMT, Alexander Zvegintsev
wrote:
>> The `java/awt/FileDialog/RegexpFilterTest/RegexpFilterTest` test is written
>> to test the very specific functionality of `XFileDialogPeer`, so it
>> shouldn't be run on platforms other than Linux.
>>
>> We also need to set `sun
On Mon, 11 Mar 2024 23:18:28 GMT, Alexander Zvegintsev
wrote:
>> The `java/awt/FileDialog/RegexpFilterTest/RegexpFilterTest` test is written
>> to test the very specific functionality of `XFileDialogPeer`, so it
>> shouldn't be run on platforms other than Linux.
>>
>> We also need to set `sun
On Tue, 12 Mar 2024 03:29:26 GMT, Tejesh R wrote:
>> Convert javax/swing/border/Test4129681.java applet test to main based test
>> using PassFailJFrame.
>
> Tejesh R has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Review updates
Changes r
On Tue, 12 Mar 2024 03:18:15 GMT, Tejesh R wrote:
>> test/jdk/javax/swing/border/Test4129681.java line 41:
>>
>>> 39:
>>> 40: public class Test4129681 {
>>> 41: private static JLabel label;
>>
>> The `label` does not need to be global, it can be confined to `init`.
>
> Its been used inside
On Tue, 12 Mar 2024 03:48:37 GMT, Tejesh R wrote:
>> Convert javax/swing/border/Test4243289.java applet test to main based test
>> using PassFailJFrame.
>
> Tejesh R has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Review updates - splitUI
This is to simplify `TrayIconScalingTest.java`.
1. Rename `createAndShowGUI` to `createAndShowTrayIcon` which is more specific.
2. Move creating tray icon to the top.
3. Streamline PassFailJFrame with the chained calls, including `awaitAndCheck`.
4. Ensure tray is not null before removing the icon
On Mon, 11 Mar 2024 22:09:09 GMT, Phil Race wrote:
>> The `Builder` class in `PassFailJFrame` is public and has a public
>> constructor. At the same time, a better design would be to hide all the
>> Builder constructors and rely on the `builder()` method which returns an
>> instance of the `Bu
On Mon, 11 Mar 2024 14:46:11 GMT, Tejesh R wrote:
> Convert javax/swing/border/Test4243289.java applet test to main based test
> using PassFailJFrame.
Changes requested by aivanov (Reviewer).
test/jdk/javax/swing/border/Test4243289.java line 47:
> 45: When frame starts, you'll
On Mon, 11 Mar 2024 17:53:48 GMT, Alexander Zvegintsev
wrote:
> The test is converted to main.
> Tested on Linux, Macos and Windows.
Changes requested by aivanov (Reviewer).
test/jdk/java/awt/FileDialog/MultipleMode.java line 68:
> 66: .build();
> 67:
> 68: EventQueue
On Mon, 11 Mar 2024 17:29:50 GMT, Alexander Zvegintsev
wrote:
> The `java/awt/FileDialog/RegexpFilterTest/RegexpFilterTest` test is written
> to test the very specific functionality of `XFileDialogPeer`, so it shouldn't
> be run on platforms other than Linux.
>
> We also need to set `sun.awt.
The `Builder` class in `PassFailJFrame` is public and has a public constructor.
At the same time, a better design would be to hide all the Builder constructors
and rely on the `builder()` method which returns an instance of the `Builder`
class.
This PR makes the constructor of the `Builder` cla
On Mon, 4 Mar 2024 15:52:45 GMT, Alexey Ivanov wrote:
> I'm adding a regression test for
> [JDK-8323670](https://bugs.openjdk.org/browse/JDK-8323670) and
> [JDK-8307091](https://bugs.openjdk.org/browse/JDK-8307091); it's also a
> regression test for
> [JDK-8240690]
On Mon, 11 Mar 2024 16:32:38 GMT, Tejesh R wrote:
>> Convert javax/swing/border/Test4129681.java applet test to main based test
>> using PassFailJFrame.
>
> Tejesh R has updated the pull request incrementally with three additional
> commits since the last revision:
>
> - Review updates
> - R
On Thu, 7 Mar 2024 20:07:19 GMT, Alisen Chung wrote:
>> Introduce delays in test to stabilize. Test passes 50x after fix.
>
> Alisen Chung has updated the pull request incrementally with one additional
> commit since the last revision:
>
> update copyright, fix jtreg formatting, update frame
On Mon, 11 Mar 2024 13:43:56 GMT, Alexey Ivanov wrote:
>> Tejesh R has updated the pull request incrementally with three additional
>> commits since the last revision:
>>
>> - Review updates
>> - Review updates
>> - Updates
>
> test/jdk/javax/swing
On Mon, 11 Mar 2024 15:00:21 GMT, Tejesh R wrote:
>> Convert javax/swing/border/Test4129681.java applet test to main based test
>> using PassFailJFrame.
>
> Tejesh R has updated the pull request incrementally with three additional
> commits since the last revision:
>
> - Review updates
> - R
On Mon, 11 Mar 2024 09:48:36 GMT, Prasanta Sadhukhan
wrote:
>> test/jdk/javax/swing/JFileChooser/6798062/bug6798062.java line 56:
>>
>>> 54: public class bug6798062 {
>>> 55:
>>> 56: private static final String instructionsText = """
>>
>> `instructionsText` may be capitalize as using cap
On Mon, 11 Mar 2024 09:53:17 GMT, Prasanta Sadhukhan
wrote:
>> Conversion of manual applet test to main based using PassFailJFrame manual
>> framework
>
> Prasanta Sadhukhan has updated the pull request incrementally with one
> additional commit since the last revision:
>
> typo
Changes re
On Mon, 11 Mar 2024 08:54:38 GMT, Prasanta Sadhukhan
wrote:
> Conversion of manual applet test to main based using PassFailJFrame manual
> framework
test/jdk/javax/swing/JFileChooser/FileFilterDescription/FileFilterDescription.java
line 60:
> 58: .getInstalledLookAndFeels();
On Mon, 11 Mar 2024 10:02:21 GMT, Prasanta Sadhukhan
wrote:
> Conversion of manual applet test to main based using PassFailJFrame manual
> framework
Changes requested by aivanov (Reviewer).
test/jdk/javax/swing/JInternalFrame/6726866/bug6726866.java line 51:
> 49:
> 50: public static vo
On Mon, 11 Mar 2024 09:41:47 GMT, Alexander Zuev wrote:
> Clean up five more tests.
>
> test/jdk/javax/swing/JDesktopPane/4132993/bug4132993.java
> test/jdk/javax/swing/JDesktopPane/4773378/bug4773378.java
> test/jdk/javax/swing/JEditorPane/4325606/bug4325606.java
> test/jdk/javax/swing/JEditorP
On Mon, 11 Mar 2024 11:10:14 GMT, Tejesh R wrote:
> Convert javax/swing/border/Test4129681.java applet test to main based test
> using PassFailJFrame.
Changes requested by aivanov (Reviewer).
test/jdk/javax/swing/border/Test4129681.java line 48:
> 46: String testInstructions = """
> 4
On Thu, 7 Mar 2024 12:42:05 GMT, Abhishek Kumar wrote:
>>> Backtracking a bit, regarding `Label.foreground` why it needs to be done
>>> here?
>>>
>>> Other L&F, it is added in corresponding LookAndFeel class for example, in
>>> [Metal](https://github.com/openjdk/jdk/blob/master/src/java.deskto
On Tue, 5 Mar 2024 05:28:01 GMT, Abhishek Kumar wrote:
>> JLabel text is not painted with the LAF defined foreground color in GTK LAF.
>> In GTK LAF the foreground color is retrieved by using native system APIs.
>> Fix is to return the foreground color if it is set by LAF defined property
>> o
On Sat, 9 Mar 2024 00:54:05 GMT, Alisen Chung wrote:
>> Root cause of the test failure was fixed with
>> https://bugs.openjdk.org/browse/JDK-8316931, updating this test since the
>> other fix also included a test update.
>
> Alisen Chung has updated the pull request incrementally with one addit
On Fri, 8 Mar 2024 11:34:12 GMT, Prasanta Sadhukhan
wrote:
>> OPensource BoxView test
>
> Prasanta Sadhukhan has updated the pull request incrementally with one
> additional commit since the last revision:
>
> Review comment update
Marked as reviewed by aivanov (Reviewer).
-
P
On Thu, 7 Mar 2024 12:36:05 GMT, Dmitry Markov wrote:
>> Updated several tests to avoid potential failure with recent LCMS update and
>> non-LCMS generated profile.
>
> Dmitry Markov has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Toleranc
On Thu, 7 Mar 2024 12:36:05 GMT, Dmitry Markov wrote:
>> Updated several tests to avoid potential failure with recent LCMS update and
>> non-LCMS generated profile.
>
> Dmitry Markov has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Toleranc
On Thu, 7 Mar 2024 03:16:20 GMT, Prasanta Sadhukhan
wrote:
> OPensource BoxView test
Marked as reviewed by aivanov (Reviewer).
test/jdk/javax/swing/text/BoxView/bug6494356.java line 35:
> 33:
> 34: import java.awt.Dimension;
> 35: import java.awt.Toolkit;
Usually imports are in alphabetical
On Thu, 7 Mar 2024 14:18:39 GMT, Tejesh R wrote:
>> It's not applet-based. The HTML file is an argument to the test, it is the
>> file that's loaded into `JEditorPane`.
>
> Oh, my bad, didn't notice it.
Yeah, it's a bit confusing…
-
PR Review Comment: https://git.openjdk.org/jdk/p
On Thu, 7 Mar 2024 04:53:07 GMT, Tejesh R wrote:
>> OPensource BoxView test
>
> test/jdk/javax/swing/text/BoxView/bug6494356.java line 28:
>
>> 26: * @key headful
>> 27: * @summary Test that BoxView.layout() is not called with negative
>> arguments
>> 28: * @run main bug6494356 bug6494356.ht
801 - 900 of 1886 matches
Mail list logo
