Re: Request to backport some screen-update code
Le 10/07/2024 à 17:17, Richard Kimberly Heck a écrit : Riki, would that be OK? Yes. Should get plenty of testing before release. Thanks, I did that. JMarc -- lyx-devel mailing list lyx-devel@lists.lyx.org http://lists.lyx.org/mailman/listinfo/lyx-devel
Re: Request to backport some screen-update code
On 7/10/24 9:19 AM, Jean-Marc Lasgouttes wrote: Hello, The following patches are a backport of the recent patch series which added the possibility of knowing which paragraph metrics have a computed position and then fixed situations where the assertion added in this first patch was triggered. Adding a new way to assert does not sound good in a stable series, BUT 1/ the assertion is not active in release code (this is not a real crash) 2/ I propose to add 3 more patches which addressed the known assertions. Moreover, compared to the patch in master where a bad position will be returned in release code as -1, the backported code will return -1 as it used to do. The 3 additional patches are harmless IMO, since all they do is add checks, add update operations, or remove a SinglePar optimization hint. Riki, would that be OK? Yes. Should get plenty of testing before release. Riki -- lyx-devel mailing list lyx-devel@lists.lyx.org http://lists.lyx.org/mailman/listinfo/lyx-devel
Request to backport some screen-update code
Hello,
The following patches are a backport of the recent patch series which
added the possibility of knowing which paragraph metrics have a computed
position and then fixed situations where the assertion added in this
first patch was triggered.
Adding a new way to assert does not sound good in a stable series, BUT
1/ the assertion is not active in release code (this is not a real crash)
2/ I propose to add 3 more patches which addressed the known assertions.
Moreover, compared to the patch in master where a bad position will be
returned in release code as -1, the backported code will return -1
as it used to do.
The 3 additional patches are harmless IMO, since all they do is add
checks, add update operations, or remove a SinglePar optimization hint.
Riki, would that be OK?
JMarc
From 24dbdfa68b64d8b574cd39d459fca4296314fb4a Mon Sep 17 00:00:00 2001
From: Jean-Marc Lasgouttes
Date: Fri, 17 May 2024 15:42:08 +0200
Subject: [PATCH 1/4] Handle metrics of not visible paragraphs
The code is not ready for situations where some paragraphs that are
not visible have metrics available.
In PararagraphMetrics, some methods are added to be able to handle the
fact that paragraphs have or do not have a position.
In TextMetrics, a new method returns the first visible paragraph.
Finally, in BufferView::updateMetrics, the paragraphs' positions are
reset (in the case where everything is not cleared) and some care is
taken to skip the ones that are not relevant.
The assumption outside of this method is that all the paragraphs that
are in the TextMetrics are visible (we are talking about top-level
TextMetrics here). This could be changed (in order to avoid
recomputing paragraph metrics), but the cost is high in terms of
complexity and it is not clear that the gain in terms of performance
would be important.
NOTE: contrary to the code in master which returns npos = -1, this
code still returns -1 when the position of a paragraph is unknown.
(cherry picked from commit 145af7c2ac1eb2c5ec5102a7a11cb740be7b3c43)
(cherry picked from commit 05bb851adfb733c942d243800d7151c6b9194645)
(cherry picked from commit 8bc3799b354908f22270f9d96b2cce43ebd96d66)
---
src/BufferView.cpp | 11 +++
src/ParagraphMetrics.cpp | 24 ++--
src/ParagraphMetrics.h | 6 +-
src/TextMetrics.cpp | 6 +-
4 files changed, 39 insertions(+), 8 deletions(-)
diff --git a/src/BufferView.cpp b/src/BufferView.cpp
index 1b2752e638..ec77a81c46 100644
--- a/src/BufferView.cpp
+++ b/src/BufferView.cpp
@@ -3197,6 +3197,7 @@ void BufferView::updateMetrics(bool force)
d->text_metrics_.clear();
}
+ // This should not be moved earlier
TextMetrics & tm = textMetrics();
// make sure inline completion pointer is ok
@@ -3212,14 +3213,16 @@ void BufferView::updateMetrics(bool force)
// Check that the end of the document is not too high
int const min_visible = lyxrc.scroll_below_document ? minVisiblePart() : height_;
- if (tm.last().first == lastpit && tm.last().second->bottom() < min_visible) {
+ if (tm.last().first == lastpit && tm.last().second->hasPosition()
+ && tm.last().second->bottom() < min_visible) {
d->anchor_ypos_ += min_visible - tm.last().second->bottom();
LYXERR(Debug::SCROLLING, "Too high, adjusting anchor ypos to " << d->anchor_ypos_);
tm.updateMetrics(d->anchor_pit_, d->anchor_ypos_, height_);
}
// Check that the start of the document is not too low
- if (tm.first().first == 0 && tm.first().second->top() > 0) {
+ if (tm.first().first == 0 && tm.first().second->hasPosition()
+ && tm.first().second->top() > 0) {
d->anchor_ypos_ -= tm.first().second->top();
LYXERR(Debug::SCROLLING, "Too low, adjusting anchor ypos to " << d->anchor_ypos_);
tm.updateMetrics(d->anchor_pit_, d->anchor_ypos_, height_);
@@ -3232,11 +3235,11 @@ void BufferView::updateMetrics(bool force)
* extra paragraphs are removed
*/
// Remove paragraphs that are outside of screen
- while(tm.first().second->bottom() <= 0) {
+ while(!tm.first().second->hasPosition() || tm.first().second->bottom() <= 0) {
//LYXERR0("Forget pit: " << tm.first().first);
tm.forget(tm.first().first);
}
- while(tm.last().second->top() > height_) {
+ while(!tm.last().second->hasPosition() || tm.last().second->top() > height_) {
//LYXERR0("Forget pit: " << tm.first().first);
tm.forget(tm.last().first);
}
diff --git a/src/ParagraphMetrics.cpp b/src/ParagraphMetrics.cpp
index 31b31a2d01..5bf7cb1d43 100644
--- a/src/ParagraphMetrics.cpp
+++ b/src/ParagraphMetrics.cpp
@@ -40,9 +40,10 @@ using namespace lyx::support;
namespace lyx {
+const int pm_npos = -1;
ParagraphMetrics::ParagraphMetrics(Paragraph const & par) :
- position_(-1), id_(par.id()), par_()
+
Re: [LyX/master] Update format in lyxrc.dist
On 7/3/24 6:56 AM, Enrico Forestieri wrote: On Wed, Jul 03, 2024 at 10:32:56AM +, Enrico Forestieri wrote: commit 1dd0bf3253a7d6abd5f4b13fe46e9a4d83887b5e Author: Enrico Forestieri Date: Wed Jul 3 12:32:18 2024 +0200 Update format in lyxrc.dist Riki, Ok for stable? Yes, again. Riki -- lyx-devel mailing list lyx-devel@lists.lyx.org http://lists.lyx.org/mailman/listinfo/lyx-devel
Re: [LyX/master] Update format in lyxrc.dist
On Wed, Jul 03, 2024 at 10:32:56AM +, Enrico Forestieri wrote: commit 1dd0bf3253a7d6abd5f4b13fe46e9a4d83887b5e Author: Enrico Forestieri Date: Wed Jul 3 12:32:18 2024 +0200 Update format in lyxrc.dist Riki, Ok for stable? -- Enrico -- lyx-devel mailing list lyx-devel@lists.lyx.org http://lists.lyx.org/mailman/listinfo/lyx-devel
Re: [LyX/2.4.1-devel] Update doc info for quote-insert
On Sat, Jun 15, 2024 at 10:06:55AM +0200, Kornel Benko wrote: > I had the impression that 2.4.1-devel branch is dead. Should this not go to > 2.4.x branch > instead? Oops, was on a wrong branch indeed. P -- lyx-devel mailing list lyx-devel@lists.lyx.org http://lists.lyx.org/mailman/listinfo/lyx-devel
Re: [LyX/2.4.1-devel] Update doc info for quote-insert
Am Fri, 14 Jun 2024 20:18:42 + schrieb Pavel Sanda : > commit b8a22a3667b20aee663ff897e1d24761dc9e1f30 > Author: Richard Kimberly Heck > Date: Tue Apr 2 12:46:36 2024 -0400 > > Update doc info for quote-insert > --- > src/LyXAction.cpp | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > I had the impression that 2.4.1-devel branch is dead. Should this not go to 2.4.x branch instead? Kornel pgpcvujIMcTh6.pgp Description: Digitale Signatur von OpenPGP -- lyx-devel mailing list lyx-devel@lists.lyx.org http://lists.lyx.org/mailman/listinfo/lyx-devel
Re: [LyX/master] Update layouts
Am Montag, dem 03.06.2024 um 16:00 +0100 schrieb José Matos: > So I think that for the moment a pragmatic solution is to always > update > the layouts when updating the layout format. By reviewing the changes > we can ensure that the update code does what it should. I might have misunderstood the discussion, but I got that fixing this is not too hard, and having something that enforces us to do it is not too bad. -- Jürgen -- lyx-devel mailing list lyx-devel@lists.lyx.org http://lists.lyx.org/mailman/listinfo/lyx-devel
Re: [LyX/master] Update layouts
On Mon, 2024-06-03 at 16:15 +0200, Jürgen Spitzmüller wrote: > Hm, I intentionally held that back unless we fix the problem > discussed at https://marc.info/?l=lyx-devel=171733833610242=2 IMHO I think that for the moment the right approach is really to update the layouts. :-) The optimization that was suggested there it is relevant mainly for us. This will bite users only if they have a large set of layout files (like we do). As far as I remember we have observed this in the past but the update of all the layouts fixed this issue. So I think that for the moment a pragmatic solution is to always update the layouts when updating the layout format. By reviewing the changes we can ensure that the update code does what it should. We should also add a note somewhere to improve the update mechanism to avoid that the same conversion is done over and over again. This clearly falls under the definition of insanity: “Insanity is doing the same thing over and over and expecting different results.” that is (mis?)attributed to Einstein. -- José Abílio -- lyx-devel mailing list lyx-devel@lists.lyx.org http://lists.lyx.org/mailman/listinfo/lyx-devel
Re: [LyX/master] Update layouts
On Mon, Jun 03, 2024 at 04:15:21PM GMT, Jürgen Spitzmüller wrote: > Am Montag, dem 03.06.2024 um 02:53 + schrieb Scott Kostyshak: > > commit 7c041af6425001d7779f5e44d72918d8591ea37d > > Author: Scott Kostyshak > > Date: Sun Jun 2 22:52:37 2024 -0400 > > > > Update layouts > > Hm, I intentionally held that back unless we fix the problem discussed > at https://marc.info/?l=lyx-devel=171733833610242=2 OK reverted at adefdf8e. Scott signature.asc Description: PGP signature -- lyx-devel mailing list lyx-devel@lists.lyx.org http://lists.lyx.org/mailman/listinfo/lyx-devel
Re: [LyX/master] Update layouts
Am Montag, dem 03.06.2024 um 02:53 + schrieb Scott Kostyshak: > commit 7c041af6425001d7779f5e44d72918d8591ea37d > Author: Scott Kostyshak > Date: Sun Jun 2 22:52:37 2024 -0400 > > Update layouts Hm, I intentionally held that back unless we fix the problem discussed at https://marc.info/?l=lyx-devel=171733833610242=2 -- Jürgen signature.asc Description: This is a digitally signed message part -- lyx-devel mailing list lyx-devel@lists.lyx.org http://lists.lyx.org/mailman/listinfo/lyx-devel
Re: layout update in master?
On Sun, 2024-06-02 at 13:37 -0400, Richard Kimberly Heck wrote: > I don't think caching previous loads is possible. Some of them may > over-write previous declarations. Or even include conditional > operations. > > Riki I mean in the same session: $ grep layouts/stdcounters.inc ~/tmp/inbox/lyx/dbg.out | wc -l 435 It does not make any sense that this layout file is converted 435 times in the same session. Once it is enough, and all the other times that it is called it could be using the cached values. -- José Abílio -- lyx-devel mailing list lyx-devel@lists.lyx.org http://lists.lyx.org/mailman/listinfo/lyx-devel
Re: layout update in master?
Le 02/06/2024 à 19:37, Richard Kimberly Heck a écrit : Right. I think -dbg any loads absolutely every layout file it can find. If the layout formats are not up to date, that is going to take even longer than it otherwise would. I don't think caching previous loads is possible. Some of them may over-write previous declarations. Or even include conditional operations. I would think that caching layout2layout results makes sense. There is no parsing going on here. It is not like loading. JMarc -- lyx-devel mailing list lyx-devel@lists.lyx.org http://lists.lyx.org/mailman/listinfo/lyx-devel
Re: layout update in master?
On 6/2/24 13:23, José Matos wrote: On Sun, 2024-06-02 at 12:56 -0400, Richard Kimberly Heck wrote: I do not see it here. There's a lot of debug output, as you would expect, but it eventually stops. The resulting file is 1.7 MB and layout2layout is called 2176 before we finally had window. It seems that there is no caching of the previous conversions and so for each class all included files are converted over and over again. Right. I think -dbg any loads absolutely every layout file it can find. If the layout formats are not up to date, that is going to take even longer than it otherwise would. I don't think caching previous loads is possible. Some of them may over-write previous declarations. Or even include conditional operations. Riki -- lyx-devel mailing list lyx-devel@lists.lyx.org http://lists.lyx.org/mailman/listinfo/lyx-devel
Re: layout update in master?
On Sun, 2024-06-02 at 12:56 -0400, Richard Kimberly Heck wrote: > I do not see it here. There's a lot of debug output, as you would > expect, but it eventually stops. The resulting file is 1.7 MB and layout2layout is called 2176 before we finally had window. It seems that there is no caching of the previous conversions and so for each class all included files are converted over and over again. -- José Abílio -- lyx-devel mailing list lyx-devel@lists.lyx.org http://lists.lyx.org/mailman/listinfo/lyx-devel
Re: layout update in master?
On Sun, 2024-06-02 at 12:56 -0400, Richard Kimberly Heck wrote: > I do not see it here. There's a lot of debug output, as you would > expect, but it eventually stops. $ src/lyx -dbg tclass > /dev/null 2>&1 I had to wait for more than a minute. I will redirect the output to see what is going on. > This is ancient code. Very odd that we'd see a problem only now. > > Riki Probably this was the last straw? :-) -- José Abílio -- lyx-devel mailing list lyx-devel@lists.lyx.org http://lists.lyx.org/mailman/listinfo/lyx-devel
Re: layout update in master?
On 6/2/24 12:45, José Matos wrote:
On Sun, 2024-06-02 at 17:49 +0200, Jürgen Spitzmüller wrote:
The following is causing this:
if (lyxerr.debugging(Debug::TCLASS)) {
// only system layout files are loaded here so no
// buffer path is needed.
tmpl->load();
}
LayoutFile.cpp::147ff.
No idea why it loops.
I see the same infinite loop.
Could it be a race condition?
I do not see it here. There's a lot of debug output, as you would
expect, but it eventually stops.
This is ancient code. Very odd that we'd see a problem only now.
Riki
--
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel
Re: layout update in master?
On Sun, 2024-06-02 at 17:49 +0200, Jürgen Spitzmüller wrote:
> The following is causing this:
>
> if (lyxerr.debugging(Debug::TCLASS)) {
> // only system layout files are loaded here so no
> // buffer path is needed.
> tmpl->load();
> }
>
> LayoutFile.cpp::147ff.
>
> No idea why it loops.
I see the same infinite loop.
Could it be a race condition?
--
José Abílio
--
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel
Re: layout update in master?
Am Sonntag, dem 02.06.2024 um 17:05 +0200 schrieb Jürgen Spitzmüller:
> Am Sonntag, dem 02.06.2024 um 16:28 +0200 schrieb Pavel Sanda:
> > ./lyx -dbg any
> > ends up in infinite layout2layout conversion loop (strangely it
> > does
> > not when running without -dbg).
> > Did we forget to update layout format number with some recent
> > feature?
>
> I stepped the format number at 2a7ec054be00f, but I don't see
> anything missing there.
The following is causing this:
if (lyxerr.debugging(Debug::TCLASS)) {
// only system layout files are loaded here so no
// buffer path is needed.
tmpl->load();
}
LayoutFile.cpp::147ff.
No idea why it loops.
--
Jürgen
--
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel
Re: layout update in master?
Am Sonntag, dem 02.06.2024 um 16:28 +0200 schrieb Pavel Sanda: > ./lyx -dbg any > ends up in infinite layout2layout conversion loop (strangely it does > not when running without -dbg). > Did we forget to update layout format number with some recent > feature? I stepped the format number at 2a7ec054be00f, but I don't see anything missing there. -- Jürgen -- lyx-devel mailing list lyx-devel@lists.lyx.org http://lists.lyx.org/mailman/listinfo/lyx-devel
layout update in master?
Hi, ./lyx -dbg any ends up in infinite layout2layout conversion loop (strangely it does not when running without -dbg). Did we forget to update layout format number with some recent feature? Pavel -- lyx-devel mailing list lyx-devel@lists.lyx.org http://lists.lyx.org/mailman/listinfo/lyx-devel
Re: Test failure after tlmgr update (not a LyX issue)
On Mon, May 06, 2024 at 01:59:50PM GMT, Kornel Benko wrote: > Am Sun, 5 May 2024 13:12:48 +0200 > schrieb Kornel Benko : > > > > > > > > > See: https://tug.org/pipermail/tex-live/2024-May/050511.html > > > > > > > > Udi > > > > > > Thanks, Kornel and Udi. Indeed, after a new tlmgr update these tests > > > pass. Now the following tests fail for me: > > > > > > export/examples/ja/Modules/Braille_pdf5_systemF > > > export/examples/ja/Welcome_pdf5_systemF > > > export/doc/ja/Shortcuts_pdf5_systemF > > > export/doc/ja/Formula-numbering_pdf5_systemF > > > export/examples/ja/Modules/Multilingual_Captions_pdf5_systemF > > > export/doc/ja/Tutorial_pdf5_systemF > > > > Same here. > > > > > Perhaps my plan should be to wait a couple of weeks and see if the > > > failure persists before spending time checking them out. > > > > +1 > > > > > Scott > > > > Kornel > > Today's tl update: The reported tests succeeded now. Thanks! Now all tests are back to normal. Scott signature.asc Description: PGP signature -- lyx-devel mailing list lyx-devel@lists.lyx.org http://lists.lyx.org/mailman/listinfo/lyx-devel
Re: Test failure after tlmgr update (not a LyX issue)
Am Sun, 5 May 2024 13:12:48 +0200 schrieb Kornel Benko : > > > > > > See: https://tug.org/pipermail/tex-live/2024-May/050511.html > > > > > > Udi > > > > Thanks, Kornel and Udi. Indeed, after a new tlmgr update these tests > > pass. Now the following tests fail for me: > > > > export/examples/ja/Modules/Braille_pdf5_systemF > > export/examples/ja/Welcome_pdf5_systemF > > export/doc/ja/Shortcuts_pdf5_systemF > > export/doc/ja/Formula-numbering_pdf5_systemF > > export/examples/ja/Modules/Multilingual_Captions_pdf5_systemF > > export/doc/ja/Tutorial_pdf5_systemF > > Same here. > > > Perhaps my plan should be to wait a couple of weeks and see if the > > failure persists before spending time checking them out. > > +1 > > > Scott > > Kornel Today's tl update: The reported tests succeeded now. Kornel pgpuRI6GieJ1Y.pgp Description: Digitale Signatur von OpenPGP -- lyx-devel mailing list lyx-devel@lists.lyx.org http://lists.lyx.org/mailman/listinfo/lyx-devel
Re: Test failure after tlmgr update (not a LyX issue)
Am Sat, 4 May 2024 23:18:51 -0400 schrieb Scott Kostyshak : > On Sat, May 04, 2024 at 09:57:22PM GMT, Udicoudco wrote: > > On Sat, May 4, 2024, 9:46 PM Kornel Benko wrote: > > > > > Am Fri, 3 May 2024 10:31:42 -0400 > > > schrieb Scott Kostyshak : > > > > > > > This is likely not a LyX issue so feel free to ignore. > > > > > > > > After a tlmgr update, the following tests now fail: > > > > > > > > export/export/latex/languages/en-ja_platex_dvi3_systemF (Failed) > > > > export/export/latex/languages/en-ja_platex_pdf4_systemF (Failed) > > > > export/export/latex/languages/en-ja_platex_pdf5_systemF (Failed) > > > > > > > > I attach the file that corresponds to the pdf4_systemF test for > > > > convenience. > > > > > > > > The LaTeX error I now get is the following: > > > > > > > > ! Illegal parameter number in definition of \l__exp_internal_tl. > > > > > > > > I'm going to ask a question on tex.se to figure out where to report this > > > > potential regression, but first I wanted to check in here and see if > > > > anyone else can reproduce this error after a tlmgr update or if it might > > > > be something local to my system (I have a few hacks in there). > > > > > > > > Scott > > > > > > I don't have these errors. (TL24 updated today) > > > # ctest -R en-ja_platex_ > > > ... > > > 100% tests passed, 0 tests failed out of 7 > > > > > > Kornel > > > -- > > > > > > See: https://tug.org/pipermail/tex-live/2024-May/050511.html > > > > Udi > > Thanks, Kornel and Udi. Indeed, after a new tlmgr update these tests > pass. Now the following tests fail for me: > > export/examples/ja/Modules/Braille_pdf5_systemF > export/examples/ja/Welcome_pdf5_systemF > export/doc/ja/Shortcuts_pdf5_systemF > export/doc/ja/Formula-numbering_pdf5_systemF > export/examples/ja/Modules/Multilingual_Captions_pdf5_systemF > export/doc/ja/Tutorial_pdf5_systemF Same here. > Perhaps my plan should be to wait a couple of weeks and see if the > failure persists before spending time checking them out. +1 > Scott Kornel pgpAICvvwd_HP.pgp Description: Digitale Signatur von OpenPGP -- lyx-devel mailing list lyx-devel@lists.lyx.org http://lists.lyx.org/mailman/listinfo/lyx-devel
Re: Test failure after tlmgr update (not a LyX issue)
On Sat, May 04, 2024 at 09:57:22PM GMT, Udicoudco wrote: > On Sat, May 4, 2024, 9:46 PM Kornel Benko wrote: > > > Am Fri, 3 May 2024 10:31:42 -0400 > > schrieb Scott Kostyshak : > > > > > This is likely not a LyX issue so feel free to ignore. > > > > > > After a tlmgr update, the following tests now fail: > > > > > > export/export/latex/languages/en-ja_platex_dvi3_systemF (Failed) > > > export/export/latex/languages/en-ja_platex_pdf4_systemF (Failed) > > > export/export/latex/languages/en-ja_platex_pdf5_systemF (Failed) > > > > > > I attach the file that corresponds to the pdf4_systemF test for > > > convenience. > > > > > > The LaTeX error I now get is the following: > > > > > > ! Illegal parameter number in definition of \l__exp_internal_tl. > > > > > > I'm going to ask a question on tex.se to figure out where to report this > > > potential regression, but first I wanted to check in here and see if > > > anyone else can reproduce this error after a tlmgr update or if it might > > > be something local to my system (I have a few hacks in there). > > > > > > Scott > > > > I don't have these errors. (TL24 updated today) > > # ctest -R en-ja_platex_ > > ... > > 100% tests passed, 0 tests failed out of 7 > > > > Kornel > > -- > > > See: https://tug.org/pipermail/tex-live/2024-May/050511.html > > Udi Thanks, Kornel and Udi. Indeed, after a new tlmgr update these tests pass. Now the following tests fail for me: export/examples/ja/Modules/Braille_pdf5_systemF export/examples/ja/Welcome_pdf5_systemF export/doc/ja/Shortcuts_pdf5_systemF export/doc/ja/Formula-numbering_pdf5_systemF export/examples/ja/Modules/Multilingual_Captions_pdf5_systemF export/doc/ja/Tutorial_pdf5_systemF Perhaps my plan should be to wait a couple of weeks and see if the failure persists before spending time checking them out. Scott signature.asc Description: PGP signature -- lyx-devel mailing list lyx-devel@lists.lyx.org http://lists.lyx.org/mailman/listinfo/lyx-devel
Re: Test failure after tlmgr update (not a LyX issue)
On Sat, May 4, 2024, 9:46 PM Kornel Benko wrote: > Am Fri, 3 May 2024 10:31:42 -0400 > schrieb Scott Kostyshak : > > > This is likely not a LyX issue so feel free to ignore. > > > > After a tlmgr update, the following tests now fail: > > > > export/export/latex/languages/en-ja_platex_dvi3_systemF (Failed) > > export/export/latex/languages/en-ja_platex_pdf4_systemF (Failed) > > export/export/latex/languages/en-ja_platex_pdf5_systemF (Failed) > > > > I attach the file that corresponds to the pdf4_systemF test for > > convenience. > > > > The LaTeX error I now get is the following: > > > > ! Illegal parameter number in definition of \l__exp_internal_tl. > > > > I'm going to ask a question on tex.se to figure out where to report this > > potential regression, but first I wanted to check in here and see if > > anyone else can reproduce this error after a tlmgr update or if it might > > be something local to my system (I have a few hacks in there). > > > > Scott > > I don't have these errors. (TL24 updated today) > # ctest -R en-ja_platex_ > ... > 100% tests passed, 0 tests failed out of 7 > > Kornel > -- See: https://tug.org/pipermail/tex-live/2024-May/050511.html Udi > > lyx-devel mailing list > lyx-devel@lists.lyx.org > http://lists.lyx.org/mailman/listinfo/lyx-devel > -- lyx-devel mailing list lyx-devel@lists.lyx.org http://lists.lyx.org/mailman/listinfo/lyx-devel
Re: Test failure after tlmgr update (not a LyX issue)
Am Fri, 3 May 2024 10:31:42 -0400 schrieb Scott Kostyshak : > This is likely not a LyX issue so feel free to ignore. > > After a tlmgr update, the following tests now fail: > > export/export/latex/languages/en-ja_platex_dvi3_systemF (Failed) > export/export/latex/languages/en-ja_platex_pdf4_systemF (Failed) > export/export/latex/languages/en-ja_platex_pdf5_systemF (Failed) > > I attach the file that corresponds to the pdf4_systemF test for > convenience. > > The LaTeX error I now get is the following: > > ! Illegal parameter number in definition of \l__exp_internal_tl. > > I'm going to ask a question on tex.se to figure out where to report this > potential regression, but first I wanted to check in here and see if > anyone else can reproduce this error after a tlmgr update or if it might > be something local to my system (I have a few hacks in there). > > Scott I don't have these errors. (TL24 updated today) # ctest -R en-ja_platex_ ... 100% tests passed, 0 tests failed out of 7 Kornel pgphPZ_OcE7Cm.pgp Description: Digitale Signatur von OpenPGP -- lyx-devel mailing list lyx-devel@lists.lyx.org http://lists.lyx.org/mailman/listinfo/lyx-devel
Test failure after tlmgr update (not a LyX issue)
This is likely not a LyX issue so feel free to ignore. After a tlmgr update, the following tests now fail: export/export/latex/languages/en-ja_platex_dvi3_systemF (Failed) export/export/latex/languages/en-ja_platex_pdf4_systemF (Failed) export/export/latex/languages/en-ja_platex_pdf5_systemF (Failed) I attach the file that corresponds to the pdf4_systemF test for convenience. The LaTeX error I now get is the following: ! Illegal parameter number in definition of \l__exp_internal_tl. I'm going to ask a question on tex.se to figure out where to report this potential regression, but first I wanted to check in here and see if anyone else can reproduce this error after a tlmgr update or if it might be something local to my system (I have a few hacks in there). Scott en-ja_platex.lyx Description: application/lyx signature.asc Description: PGP signature -- lyx-devel mailing list lyx-devel@lists.lyx.org http://lists.lyx.org/mailman/listinfo/lyx-devel
Re: update zh_CN translations 2024-04-13
On Sat, Apr 13, 2024 at 01:40:40PM +0800, CD_Mking wrote: > Add some empty string. Thanks, this is now in as well. Pavel -- lyx-devel mailing list lyx-devel@lists.lyx.org http://lists.lyx.org/mailman/listinfo/lyx-devel
update zh_CN translations 2024-04-13
Add some empty string. 0001-update-zh_CN-translations.patch Description: Binary data -- lyx-devel mailing list lyx-devel@lists.lyx.org http://lists.lyx.org/mailman/listinfo/lyx-devel
Re: [LyX/2.4.x] Update Qt bug documentation (#12641)
Am Samstag, dem 13.04.2024 um 03:00 +0200 schrieb Pavel Sanda: > Isn't all this mac-specific? P Yes, clarified. -- Jürgen -- lyx-devel mailing list lyx-devel@lists.lyx.org http://lists.lyx.org/mailman/listinfo/lyx-devel
Re: [LyX/2.4.x] Update Qt bug documentation (#12641)
On Fri, Apr 12, 2024 at 09:13:59AM +, Juergen Spitzmueller wrote: > commit 8810e9418fe68ad1b608f756afd1806c69cc105c > Author: Juergen Spitzmueller > Date: Fri Apr 12 11:13:15 2024 +0200 > > Update Qt bug documentation (#12641) > --- > lib/RELEASE-NOTES | 7 +-- > 1 file changed, 5 insertions(+), 2 deletions(-) > > diff --git a/lib/RELEASE-NOTES b/lib/RELEASE-NOTES > index 7b103e6f93..78ba3d750d 100644 > --- a/lib/RELEASE-NOTES > +++ b/lib/RELEASE-NOTES > @@ -332,8 +332,11 @@ > > !!Known issues in version 2.4.0 > > -* Compiling LyX 2.4 on MacOS with Qt6 makes currently LyX unresponsive to > - Control-Command keyboard shortcuts (bug #12641). > +* Various versions Qt6 have a problem with key events handling > (QTBUG-123848). > + This issue is documented in bug #12641 (e.g. LyX is unresponsive to > + Control-Command keyboard shortcuts). > + The fix for the Qt bug will be included in Qt 6.8.0 and 6.7.1 and might > also > + be backported to Qt 6.5.6 and 6.2.13. Isn't all this mac-specific? P -- lyx-devel mailing list lyx-devel@lists.lyx.org http://lists.lyx.org/mailman/listinfo/lyx-devel
Re: Update zh_CN Translation
On Wed, Apr 10, 2024 at 05:28:32PM +0800, CD_Mking wrote: > I have finally resolved the issue and exported the patch file. I will now > send the patch. Thank you, it's in. Pavel -- lyx-devel mailing list lyx-devel@lists.lyx.org http://lists.lyx.org/mailman/listinfo/lyx-devel
Re: Update zh_CN Translation
Hello lyx-devel, I hereby grant permission to licence my contributions to LyX under the GNU General Public Licence, version 2 or later. Sincerely, Jiaxu Zi-- lyx-devel mailing list lyx-devel@lists.lyx.org http://lists.lyx.org/mailman/listinfo/lyx-devel
Re: Please update the readme of evince_sync_lyx.zip
Am Mittwoch, dem 10.04.2024 um 10:05 + schrieb 包子 戴: > Here are two problem. > First, I found I have to copy the three file to > /usr/local/bin > to make it work rather than place in a folder which PATH included. This is not a folder with PATH included, but a folder included in your PATH (/usr/local/bin is one example, but the script also works in other folders if they are in PATH, e.g. ~/bin). But I don't see where you got that misunderstanding from in the README. > Second, backward search from within evince is triggered > by + in my practise, not + . > Please update this info. This I have updated. Thanks, -- Jürgen -- lyx-devel mailing list lyx-devel@lists.lyx.org http://lists.lyx.org/mailman/listinfo/lyx-devel
Please update the readme of evince_sync_lyx.zip
Hi, I'm a user of lyx. Below is my environment. OS: Fedora 39 Gnome on Wayland Lyx: 2.3.7 I followed the readme of evince_sync_lyx.zip where can be download https://wiki.lyx.org/LyX/SyncTeX#toc4 . Here are two problem. First, I found I have to copy the three file to /usr/local/bin to make it work rather than place in a folder which PATH included. Second, backward search from within evince is triggered by + in my practise, not + . Please update this info. -- lyx-devel mailing list lyx-devel@lists.lyx.org http://lists.lyx.org/mailman/listinfo/lyx-devel
Re: Update zh_CN Translation
I have finally resolved the issue and exported the patch file. I will now send the patch. 0001-update-zh_CN-translation.patch Description: Binary data -- lyx-devel mailing list lyx-devel@lists.lyx.org http://lists.lyx.org/mailman/listinfo/lyx-devel
Re: Update zh_CN Translation
On Wed, Apr 10, 2024 at 01:40:25PM +0800, CD_Mking wrote: > I have translated part of the zh_CN localization, using AI translation and > subsequently conducting manual proofreading. > I am providing only the po files as I am unable to package them into a > format-patch, and the bundle file is too large to send. Thank you. One thing we need before commit is a blanket permission for your contributions sent to lyx-devel@lists.lyx.org. It should look like this: https://marc.info/?l=lyx-devel=170428353115475=2 If you need to send large files you can use this address po-upda...@lyx.org next time. Pavel -- lyx-devel mailing list lyx-devel@lists.lyx.org http://lists.lyx.org/mailman/listinfo/lyx-devel
Re: [LyX/master] Improve stats update times for buffer switches and toolbar toggles.
On Fri, Apr 05, 2024 at 05:07:27PM -0400, Richard Kimberly Heck wrote: > On 4/5/24 17:01, Pavel Sanda wrote: > > On Fri, Apr 05, 2024 at 09:00:37PM +, Pavel Sanda wrote: > > > commit 77273303a5e22df45239d705e830baa5c0c3fcf1 > > > Author: Pavel Sanda > > > Date: Fri Apr 5 22:59:07 2024 +0200 > > > > > > Improve stats update times for buffer switches and toolbar toggles. > > Riki, Ok for 2.4.1? Pavel > > Yes. Comitted. P -- lyx-devel mailing list lyx-devel@lists.lyx.org http://lists.lyx.org/mailman/listinfo/lyx-devel
Re: [LyX/master] Improve stats update times for buffer switches and toolbar toggles.
On Fri, Apr 05, 2024 at 09:00:37PM +, Pavel Sanda wrote: > commit 77273303a5e22df45239d705e830baa5c0c3fcf1 > Author: Pavel Sanda > Date: Fri Apr 5 22:59:07 2024 +0200 > > Improve stats update times for buffer switches and toolbar toggles. Riki, Ok for 2.4.1? Pavel -- lyx-devel mailing list lyx-devel@lists.lyx.org http://lists.lyx.org/mailman/listinfo/lyx-devel
Re: #13041: Lyx Installation: No file association, view/update toolbar inactive
By the way, I succeed to associate the .lyx files to the application manually, but the files are still not displayed with the LyX icon. On 11/03/2024 13:02, LyX Ticket Tracker wrote: #13041: Lyx Installation: No file association, view/update toolbar inactive ---+- Reporter: jcgarreau | Owner: lasgouttes Type: defect | Status: new Priority: normal | Milestone: Component: general| Version: 2.3.7 Severity: normal | Resolution: Keywords: | ---+- Comment (by lasgouttes): Hello Jean-Claude, what is your operating system? -- PhLAM Directeur de Recherche (retired) - CNRS Laboratoire de Physique des Lasers, Atomes et Molécules Département de Physique - Université de Lille 59655 Villeneuve d'Ascq - France ORCID <https://orcid.org/-0003-4155-4459> Google Scholar <https://scholar.google.fr/citations?user=CKi7rb8J=fr> -- Cet e-mail a été vérifié par le logiciel antivirus d'Avast. www.avast.com-- lyx-devel mailing list lyx-devel@lists.lyx.org http://lists.lyx.org/mailman/listinfo/lyx-devel
Re: #13041: Lyx Installation: No file association, view/update toolbar inactive
Oh, sorry, I forgot that: Windows 11 64 bit Pro. On 11/03/2024 13:02, LyX Ticket Tracker wrote: #13041: Lyx Installation: No file association, view/update toolbar inactive ---+- Reporter: jcgarreau | Owner: lasgouttes Type: defect | Status: new Priority: normal | Milestone: Component: general| Version: 2.3.7 Severity: normal | Resolution: Keywords: | ---+- Comment (by lasgouttes): Hello Jean-Claude, what is your operating system? -- PhLAM Directeur de Recherche (retired) - CNRS Laboratoire de Physique des Lasers, Atomes et Molécules Département de Physique - Université de Lille 59655 Villeneuve d'Ascq - France ORCID <https://orcid.org/-0003-4155-4459> Google Scholar <https://scholar.google.fr/citations?user=CKi7rb8J=fr> -- Cet e-mail a été vérifié par le logiciel antivirus d'Avast. www.avast.com-- lyx-devel mailing list lyx-devel@lists.lyx.org http://lists.lyx.org/mailman/listinfo/lyx-devel
Re: [LyX features/biginset] Indicate that, by default, mouse LFUN do not require a metrics update
Le 27/11/2023 à 18:04, Pavel Sanda a écrit :
On Mon, Nov 27, 2023 at 04:31:29PM +0100, Jean-Marc Lasgouttes wrote:
- { LFUN_MOUSE_PRESS, "", ReadOnly, Hidden },
+ { LFUN_MOUSE_PRESS, "", ReadOnly | NoUpdate, Hidden },
...
- { LFUN_MOUSE_RELEASE, "", ReadOnly, Hidden },
+ { LFUN_MOUSE_RELEASE, "", ReadOnly | NoUpdate, Hidden },
I know nothing about this, just thinking whether triggered DEPM or
(un)collapsing
insets when clicking away should not tigger metrics update?
I _think_ that in this case the code will override the default update. I
can confirm that DEPM works, for example.
To be fair, I did not remember that we had this information in
LyXAction.cpp :)
What it does is change the default update flag before going through
dispatch. I am not sure that this is written in the best (and safest)
possible way, though.
JMarc
--
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel
Re: [LyX features/biginset] Indicate that, by default, mouse LFUN do not require a metrics update
On Mon, Nov 27, 2023 at 04:31:29PM +0100, Jean-Marc Lasgouttes wrote:
> - { LFUN_MOUSE_PRESS, "", ReadOnly, Hidden },
> + { LFUN_MOUSE_PRESS, "", ReadOnly | NoUpdate, Hidden },
...
> - { LFUN_MOUSE_RELEASE, "", ReadOnly, Hidden },
> + { LFUN_MOUSE_RELEASE, "", ReadOnly | NoUpdate, Hidden },
I know nothing about this, just thinking whether triggered DEPM or
(un)collapsing
insets when clicking away should not tigger metrics update?
Pavel
--
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel
Re: [LyX/master] Update ru.po and UserGuide
On Mon, Nov 13, 2023 at 09:59:06AM +0100, Yuriy Skalko wrote: > So, in several linguistics articles I've found another term used for tableau > -- ??/matrix instead of ??/table. Let's hope > linguists will be happy with this or will reply and come up with better > translation :) Thanks, it's in now. Pavel -- lyx-devel mailing list lyx-devel@lists.lyx.org http://lists.lyx.org/mailman/listinfo/lyx-devel
Re: [LyX/master] Update ru.po and UserGuide
If previous versions will be left, then there will be duplicated items in menu since these linguistics tables "tableaux" translate just as "tables". So I added these "(ling.)" prefixes to distinguish them. There is also a calque from "tableau" word, but it has different meaning and does not fit here. Well I doubt that you want to have "Table (lit.)" in the latex output, but if there is no corresponding word for tableaux in your language, then this whole discussion is probably void anyway. In next iteration I'll replace the strings in layouttranslation in whatever you decide is best and is present in the .po file. Pavel So, in several linguistics articles I've found another term used for tableau -- матрица/matrix instead of таблица/table. Let's hope linguists will be happy with this or will reply and come up with better translation :) Yuriy -- lyx-devel mailing list lyx-devel@lists.lyx.org http://lists.lyx.org/mailman/listinfo/lyx-devel
Re: [LyX/master] Update ru.po and UserGuide
On Fri, Nov 10, 2023 at 06:07:02PM +0100, Yuriy Skalko wrote: > If previous versions will be left, then there will be duplicated items in > menu since these linguistics tables "tableaux" translate just as "tables". > So I added these "(ling.)" prefixes to distinguish them. > > There is also a calque from "tableau" word, but it has different meaning and > does not fit here. Well I doubt that you want to have "Table (lit.)" in the latex output, but if there is no corresponding word for tableaux in your language, then this whole discussion is probably void anyway. In next iteration I'll replace the strings in layouttranslation in whatever you decide is best and is present in the .po file. Pavel -- lyx-devel mailing list lyx-devel@lists.lyx.org http://lists.lyx.org/mailman/listinfo/lyx-devel
Re: [LyX/master] Update ru.po and UserGuide
I would like to check with you the changes wrt lib/layouttranslations for PDF outputs. With the current .po version I see two changes (see attachment), which look wrong to me. Wouldn't be more correct to leave it in the previous version without braces? Pavel diff --git a/lib/layouttranslations b/lib/layouttranslations index 376e93ca77..3a31e9a82f 100644 --- a/lib/layouttranslations +++ b/lib/layouttranslations @@ -1306,7 +1306,7 @@ Translation ru "List of Graphs[[mathematical]]" "ХпиŃОк ĐłŃĐ°ŃикОв" "List of Listings" "ХпиŃОк НиŃŃингОв" "List of Schemes" "ХпиŃОк ŃŃ ĐľĐź" - "List of Tableaux" "ХпиŃОк ŃайНиŃ" + "List of Tableaux" "ХпиŃОк ŃĐ°ĐąĐťĐ¸Ń (Нингв.)" "Listing" "ĐиŃŃинг" "Listings[[List of Listings]]" "ĐиŃŃинги" "Nomenclature[[output]]" "ХпиŃОк ОйОСнаŃониК" @@ -1322,7 +1322,7 @@ Translation ru "Scheme" "ĐĄŃ ĐľĐźĐ°" "Solution" "Đ ĐľŃонио" "Summary" "РоСŃПо" - "Tableau" "ТайНиŃĐ°" + "Tableau" "ТайНиŃĐ° (Нингв.)" "Theorem" "ТоОŃоПа" "page[[nomencl]]" "ŃŃŃ." "see equation[[nomencl]]" "ŃĐź." Hi Pavel, If previous versions will be left, then there will be duplicated items in menu since these linguistics tables "tableaux" translate just as "tables". So I added these "(ling.)" prefixes to distinguish them. There is also a calque from "tableau" word, but it has different meaning and does not fit here. Yuriy -- lyx-devel mailing list lyx-devel@lists.lyx.org http://lists.lyx.org/mailman/listinfo/lyx-devel
Re: [LyX/master] Update ru.po and UserGuide
On Wed, Nov 08, 2023 at 10:55:08PM +0100, Yuriy Skalko wrote: > commit bf0005b5b265d8811d7a074de0467e673d4d7bf3 > Author: Yuriy Skalko > Date: Wed Nov 8 23:14:50 2023 +0100 > > Update ru.po and UserGuide Hi Yuriy, I would like to check with you the changes wrt lib/layouttranslations for PDF outputs. With the current .po version I see two changes (see attachment), which look wrong to me. Wouldn't be more correct to leave it in the previous version without braces? Pavel diff --git a/lib/layouttranslations b/lib/layouttranslations index 376e93ca77..3a31e9a82f 100644 --- a/lib/layouttranslations +++ b/lib/layouttranslations @@ -1306,7 +1306,7 @@ Translation ru "List of Graphs[[mathematical]]" "ХпиŃОк ĐłŃĐ°ŃикОв" "List of Listings" "ХпиŃОк НиŃŃингОв" "List of Schemes" "ХпиŃОк ŃŃ ĐľĐź" - "List of Tableaux" "ХпиŃОк ŃайНиŃ" + "List of Tableaux" "ХпиŃОк ŃĐ°ĐąĐťĐ¸Ń (Нингв.)" "Listing" "ĐиŃŃинг" "Listings[[List of Listings]]" "ĐиŃŃинги" "Nomenclature[[output]]" "ХпиŃОк ОйОСнаŃониК" @@ -1322,7 +1322,7 @@ Translation ru "Scheme" "ĐĄŃ ĐľĐźĐ°" "Solution" "Đ ĐľŃонио" "Summary" "РоСŃПо" - "Tableau" "ТайНиŃĐ°" + "Tableau" "ТайНиŃĐ° (Нингв.)" "Theorem" "ТоОŃоПа" "page[[nomencl]]" "ŃŃŃ." "see equation[[nomencl]]" "ŃĐź." -- lyx-devel mailing list lyx-devel@lists.lyx.org http://lists.lyx.org/mailman/listinfo/lyx-devel
Re: [LyX/master] Update math macro display when entering from above/balow
Le 07/11/2023 à 18:22, Richard Kimberly Heck a écrit : But since I have no proof or reason to believe than this extra metrics step is costly, I prefer to leave it like that for now. Yes, I knew that would be ugly, but if it does end up being expensive Then I will fix it :) We probably have worse things to fix. For example, my recent debugging activities suggest that the metrics are computed twice! JMarc -- lyx-devel mailing list lyx-devel@lists.lyx.org http://lists.lyx.org/mailman/listinfo/lyx-devel
Re: [LyX/master] Update math macro display when entering from above/balow
On 11/7/23 12:16, Jean-Marc Lasgouttes wrote: Le 07/11/2023 à 18:08, Richard Kimberly Heck a écrit : On 11/7/23 08:24, Jean-Marc Lasgouttes wrote: commit 9c3d9cded0b7f40b449bdfab0200d7fb27e1b1a8 Author: Jean-Marc Lasgouttes Date: Tue Nov 7 15:43:57 2023 +0100 Update math macro display when entering from above/balow This change forces metrics computation in all cases when cursor enters a math inset from above/below, but I do not have a better idea right now. Would it be possible to check if any of the slices is a math macro? I woujld prefer the code to be in InsetMathMacro (like is done for example in InsetMathMacro::idxFirst() and other places). An alternative would be to have a new method editChangesMetrics (or something like that) set to true for macro inset. Then our code could be changed to act on that. But since I have no proof or reason to believe than this extra metrics step is costly, I prefer to leave it like that for now. Yes, I knew that would be ugly, but if it does end up being expensive Riki -- lyx-devel mailing list lyx-devel@lists.lyx.org http://lists.lyx.org/mailman/listinfo/lyx-devel
Re: [LyX/master] Update math macro display when entering from above/balow
Le 07/11/2023 à 18:08, Richard Kimberly Heck a écrit : On 11/7/23 08:24, Jean-Marc Lasgouttes wrote: commit 9c3d9cded0b7f40b449bdfab0200d7fb27e1b1a8 Author: Jean-Marc Lasgouttes Date: Tue Nov 7 15:43:57 2023 +0100 Update math macro display when entering from above/balow This change forces metrics computation in all cases when cursor enters a math inset from above/below, but I do not have a better idea right now. Would it be possible to check if any of the slices is a math macro? I woujld prefer the code to be in InsetMathMacro (like is done for example in InsetMathMacro::idxFirst() and other places). An alternative would be to have a new method editChangesMetrics (or something like that) set to true for macro inset. Then our code could be changed to act on that. But since I have no proof or reason to believe than this extra metrics step is costly, I prefer to leave it like that for now. JMarc -- lyx-devel mailing list lyx-devel@lists.lyx.org http://lists.lyx.org/mailman/listinfo/lyx-devel
Re: [LyX/master] Update math macro display when entering from above/balow
On 11/7/23 08:24, Jean-Marc Lasgouttes wrote: commit 9c3d9cded0b7f40b449bdfab0200d7fb27e1b1a8 Author: Jean-Marc Lasgouttes Date: Tue Nov 7 15:43:57 2023 +0100 Update math macro display when entering from above/balow This change forces metrics computation in all cases when cursor enters a math inset from above/below, but I do not have a better idea right now. Would it be possible to check if any of the slices is a math macro? Riki -- lyx-devel mailing list lyx-devel@lists.lyx.org http://lists.lyx.org/mailman/listinfo/lyx-devel
Re: String Freeze Update
On Tue, Oct 17, 2023 at 01:01:31PM -0400, Richard Kimberly Heck wrote: > On 10/9/23 14:42, Pavel Sanda wrote: > >On Fri, Sep 08, 2023 at 04:05:49PM -0400, Richard Kimberly Heck wrote: > >>I am planning to freeze strings once we have had some initial feedback on > >>beta 5 and make sure that there aren't any issues there that need a string > >>change. We're waiting at the moment for the Windows installer. > >Riki, how do you evaluate the current status wrt the freeze? > > > >I might have some time in the next few weeks to be somewhat helpful in > >sorting out the issues with (layout)translations if we decide to freeze. > > Sorry, got very busy there. > > I'm inclined to freeze this weekend, unless someone objects. I don't see anything pending, so I think it's safe to declare it, remerge strings and send info to our translators to start working... Pavel -- lyx-devel mailing list lyx-devel@lists.lyx.org http://lists.lyx.org/mailman/listinfo/lyx-devel
Re: String Freeze Update
Am Montag, dem 23.10.2023 um 06:16 +0200 schrieb Jürgen Spitzmüller: > Thanks. So its the "pat" regex in qt_l10n (lyx_pot.py) that is to > blame. Shouldn't be too hard to fix that to consider line breaks > within ..., no? Correcting myself after trying: \n in ui file strings do not seem to work. -- Jürgen -- lyx-devel mailing list lyx-devel@lists.lyx.org http://lists.lyx.org/mailman/listinfo/lyx-devel
Re: String Freeze Update
Am Sonntag, dem 22.10.2023 um 19:34 +0200 schrieb Enrico Forestieri: > Instead of "" you can also use the entity "". The > difference > is that this is directly replaced by lyx_pot.py to "\n" so that Qt > will > not use the html parser simply for introducing a newline char. Thanks. So its the "pat" regex in qt_l10n (lyx_pot.py) that is to blame. Shouldn't be too hard to fix that to consider line breaks within ..., no? -- Jürgen -- lyx-devel mailing list lyx-devel@lists.lyx.org http://lists.lyx.org/mailman/listinfo/lyx-devel
Re: String Freeze Update
On Sun, Oct 22, 2023 at 01:22:05PM +0200, Jürgen Spitzmüller wrote: Am Sonntag, dem 22.10.2023 um 12:33 +0200 schrieb Dan: Just for the record and out of curiosity, what was the problem with that string? I see you just added a line break HTML element to it, and suddenly it appears in the POT file. Has something to do with QT or with Gettext? Will appreciate a brief explanation, danke. For reasons I have not explored, messages with line breaks (\n) do not make it into the po files. It might be our own scripts's fault, I don't know. Instead of "" you can also use the entity "". The difference is that this is directly replaced by lyx_pot.py to "\n" so that Qt will not use the html parser simply for introducing a newline char. -- Enrico -- lyx-devel mailing list lyx-devel@lists.lyx.org http://lists.lyx.org/mailman/listinfo/lyx-devel
Re: String Freeze Update
22 d’oct. de 2023, 13:21 per sa...@lyx.org: > On Sun, Oct 22, 2023 at 01:06:58PM +0200, Dan wrote: > >> Sorry, I did not intend to mean or hint you all should wait until I am done. >> The strings I noted as "problematic" are, in my opinion, not that important: >> little type errors and improvable UX. Also, there are just a few. >> I encounter them as I read and search through the PO file, so I stopped >> adding them to this thread and think it is best to inform of them at once. >> > > Ok, my suggestion is that if you have some half-done list of > typos/suggestions, > report them now so we fix what we can and proceed. Or alternatively just delay > the whole bulk thing for 2.4.1/2.5, up to you. > > Pavel > Go ahead, do not wait for me. I will notify in later versions. Daniel. -- Sent with Tutanota. -- lyx-devel mailing list lyx-devel@lists.lyx.org http://lists.lyx.org/mailman/listinfo/lyx-devel
Re: String Freeze Update
Am Sonntag, dem 22.10.2023 um 12:33 +0200 schrieb Dan: > Just for the record and out of curiosity, what was the problem with > that string? I see you just added a line break HTML element to it, > and suddenly it appears in the POT file. Has something to do with QT > or with Gettext? > > Will appreciate a brief explanation, danke. For reasons I have not explored, messages with line breaks (\n) do not make it into the po files. It might be our own scripts's fault, I don't know. -- Jürgen -- lyx-devel mailing list lyx-devel@lists.lyx.org http://lists.lyx.org/mailman/listinfo/lyx-devel
Re: String Freeze Update
On Sun, Oct 22, 2023 at 01:06:58PM +0200, Dan wrote: > Sorry, I did not intend to mean or hint you all should wait until I am done. > The strings I noted as "problematic" are, in my opinion, not that important: > little type errors and improvable UX. Also, there are just a few. > I encounter them as I read and search through the PO file, so I stopped > adding them to this thread and think it is best to inform of them at once. Ok, my suggestion is that if you have some half-done list of typos/suggestions, report them now so we fix what we can and proceed. Or alternatively just delay the whole bulk thing for 2.4.1/2.5, up to you. Pavel -- lyx-devel mailing list lyx-devel@lists.lyx.org http://lists.lyx.org/mailman/listinfo/lyx-devel
Re: String Freeze Update
22 d’oct. de 2023, 12:51 per sa...@lyx.org: > On Sun, Oct 22, 2023 at 12:21:41PM +0200, Dan wrote: > >> >> I must object :). I have come across some strings of the UI that should >> >> be changed. For now I am only notifying the following two, which I think >> >> are important; the rest I will report in bulk when done with the >> >> translation. >> >> >> > >> > What's your estimation of time needed to finish your translation? >> > >> > Pavel >> > >> Can't really tell. I am actually pretty much done with the Spanish >> translation; then I will start reviewing and writting down some >> documentation of the translation. That's how I work when translating alone: >> separate the roles completely. After revision, most likely I will return to >> the translator role again, restarting the cycle. >> > > Dan, I don't think this is a satysfying answer :) > > If you want to block the string freeze and delay 2.4 release please give us > some time when you plan to "report in bulk of the rest" so we can meditate > whether is worth to keep the project in limbo or not... > > Pavel > Sorry, I did not intend to mean or hint you all should wait until I am done. The strings I noted as "problematic" are, in my opinion, not that important: little type errors and improvable UX. Also, there are just a few. I encounter them as I read and search through the PO file, so I stopped adding them to this thread and think it is best to inform of them at once. Daniel. -- Sent with Tutanota. -- lyx-devel mailing list lyx-devel@lists.lyx.org http://lists.lyx.org/mailman/listinfo/lyx-devel
Re: String Freeze Update
On Sun, Oct 22, 2023 at 12:21:41PM +0200, Dan wrote: > >> I must object :). I have come across some strings of the UI that should be > >> changed. For now I am only notifying the following two, which I think are > >> important; the rest I will report in bulk when done with the translation. > >> > > > > What's your estimation of time needed to finish your translation? > > > > Pavel > > > Can't really tell. I am actually pretty much done with the Spanish > translation; then I will start reviewing and writting down some documentation > of the translation. That's how I work when translating alone: separate the > roles completely. After revision, most likely I will return to the translator > role again, restarting the cycle. Dan, I don't think this is a satysfying answer :) If you want to block the string freeze and delay 2.4 release please give us some time when you plan to "report in bulk of the rest" so we can meditate whether is worth to keep the project in limbo or not... Pavel -- lyx-devel mailing list lyx-devel@lists.lyx.org http://lists.lyx.org/mailman/listinfo/lyx-devel
Re: String Freeze Update
21 d’oct. de 2023, 12:53 per jspi...@gmail.com: > Am Samstag, dem 21.10.2023 um 10:38 +0200 schrieb Dan: > >> 2. There is a tooltip that is not translatable: it does not appear >> in the POT file. Thus, it shows in English in the interface. To see >> what I mean do the following >> 1. Open a new document in Lyx. >> 2. Open the document settings dialog. >> 3. Choose section "Page Margins" and place the cursor over the >> checkbox "Default Margins". >> 4. That tooltip is not translatable. I will appear in English, no >> matter the language set for the UI. >> > > Fixed. > Just for the record and out of curiosity, what was the problem with that string? I see you just added a line break HTML element to it, and suddenly it appears in the POT file. Has something to do with QT or with Gettext? Will appreciate a brief explanation, danke. Daniel. -- Sent with Tutanota. -- lyx-devel mailing list lyx-devel@lists.lyx.org http://lists.lyx.org/mailman/listinfo/lyx-devel
Re: String Freeze Update
21 d’oct. de 2023, 22:15 per sa...@lyx.org: > On Sat, Oct 21, 2023 at 10:38:36AM +0200, Dan wrote: > >> I must object :). I have come across some strings of the UI that should be >> changed. For now I am only notifying the following two, which I think are >> important; the rest I will report in bulk when done with the translation. >> > > What's your estimation of time needed to finish your translation? > > Pavel > Can't really tell. I am actually pretty much done with the Spanish translation; then I will start reviewing and writting down some documentation of the translation. That's how I work when translating alone: separate the roles completely. After revision, most likely I will return to the translator role again, restarting the cycle. I spent quite a few time getting acquainted to the terms and style chosen in the translation, so I want ease the landing of future translators of Spanish by documenting some of the terms and decisions made, just as French and German do. Cannot promise it will be ready in time for the release of Lyx version 2.4.0. Daniel. -- Sent with Tutanota. -- lyx-devel mailing list lyx-devel@lists.lyx.org http://lists.lyx.org/mailman/listinfo/lyx-devel
Re: String Freeze Update
On Sat, Oct 21, 2023 at 10:38:36AM +0200, Dan wrote: > I must object :). I have come across some strings of the UI that should be > changed. For now I am only notifying the following two, which I think are > important; the rest I will report in bulk when done with the translation. What's your estimation of time needed to finish your translation? Pavel -- lyx-devel mailing list lyx-devel@lists.lyx.org http://lists.lyx.org/mailman/listinfo/lyx-devel
Re: String Freeze Update
Am Samstag, dem 21.10.2023 um 10:38 +0200 schrieb Dan: > 1. Language (in the settings dialog of a listing inset). In English > this word can be used to refer to both, a tongue and a programming > language. In other languages this is not necessarily the case, for > instance in Spanish > - Language (tongue) -> lengua / idioma > - Language (programming) -> lenguaje (de programación) > This rises a problem with the string "Language" in the dialog box > for a listing's settings. The problematic string is the group title, > not the language setting itself. The source of the string is > "src/frontends/qt/ui/ListingsUi.ui" line 334. To see exactly what I > mean do this > 1. Insert > Program Listing. > 2. Then place the cursor inside the listing inset. > 3. Edit > Listing Settings. > 4. "Language" is the title of a group of settings. That is the > problematic string. Fixed. > 2. There is a tooltip that is not translatable: it does not appear > in the POT file. Thus, it shows in English in the interface. To see > what I mean do the following > 1. Open a new document in Lyx. > 2. Open the document settings dialog. > 3. Choose section "Page Margins" and place the cursor over the > checkbox "Default Margins". > 4. That tooltip is not translatable. I will appear in English, no > matter the language set for the UI. Fixed. Thanks, -- Jürgen -- lyx-devel mailing list lyx-devel@lists.lyx.org http://lists.lyx.org/mailman/listinfo/lyx-devel
Re: String Freeze Update
On 10/9/23 14:42, Pavel Sanda wrote: On Fri, Sep 08, 2023 at 04:05:49PM -0400, Richard Kimberly Heck wrote: I am planning to freeze strings once we have had some initial feedback on beta 5 and make sure that there aren't any issues there that need a string change. We're waiting at the moment for the Windows installer. Riki, how do you evaluate the current status wrt the freeze? I might have some time in the next few weeks to be somewhat helpful in sorting out the issues with (layout)translations if we decide to freeze. Sorry, got very busy there. I'm inclined to freeze this weekend, unless someone objects. Riki -- lyx-devel mailing list lyx-devel@lists.lyx.org http://lists.lyx.org/mailman/listinfo/lyx-devel
Re: String Freeze Update
Am Montag, dem 09.10.2023 um 20:42 +0200 schrieb Pavel Sanda:
> > 5. The string "Table" appears in quite some contexts that are
> > contradicting: in some it really means Table, while in others it
> > actually means "Tabular". Remember that Table/Tabular are related
> > in the same way Figure/Image do, although LyX kind of ignores that
> > (LaTeX does not). This makes it impossible to translate that word
> > without introducing inconsistencies (see the attached image).
>
> I don't have strong opinion, but not seeing others responding it's
> maybe trying to be too strict. Admittedly I never really
> distinguished these two, OTOH if LaTeX distinguishes it, we should
> perhaps too...
Not very consistently, too. Cf.
\begin{tabular}{lll}
to
\begin{longtable}{lll}
I think the lexical decision is only made since they needed two
different environments (one for the float, one for the matrix).
I am not completely sure, but I don't think the table/tabular
distinction is common beyond LaTeX (tabular seems to be used mostly as
an adjective to denote table-like objects). And we don't want to
promote LaTeXisms in the GUI.
Having written that, it might make sense to distinguish table floats
from actual tables for translation if this is needed for some
translations, simply by table[[float]]. I think there are not many
places where we actually use "tabular", and maybe we should revisit
them and check whether we shouldn't use "table" instead.
Not sure that's for 2.4, though.
--
Jürgen
--
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel
Re: String Freeze Update
On Sat, Sep 16, 2023 at 09:16:37PM +0200, Dan wrote: > > I have three suggestions. > > 1. Tools > Preferences > Document Handling > Display single close-tab > > button. The tooltip states that, if checked, a single close-tab button will > > appear on the "left corner", but it actually appears on the far right of > > the tabbar (see attached images). This one is fixed. > > 2. Some command line options do not work properly (type "lyx --help" in a > > terminal). Try, for instance, issuing twice this command in the terminal > > (with an already existing LyX file) "lyx -v -f none -E lyxgz test > > my-existing-file.lyx" > > ?? option "-f none", not actually working, it still overwrites the output > > file if it exists. > > ?? option "-E" not working either, it ignores the second argument (output > > filename). Seems specific for lyxgz; not saying it's not a bug but a very corner case. Willing to commit working patch, but I am not going to spend my time on it. > > 3. Honestly I would change the "Show Changes in output" strings (related > > to change tracking), which I think are not clear enough (see thread > > http://lists.lyx.org/pipermail/lyx-devel/2023-September/010662.html). Not goint to rally for this one. > 4. When introducing a dynamic text field (Insert > Field), the tooltip > explaining how to use placeholders to set a custom fixed time says "01-23 in > AM/PM", twice. This, obviously does not make any sense, as AM/PM is just for > 00-11 hours. This one is fixed. > 5. The string "Table" appears in quite some contexts that are contradicting: > in some it really means Table, while in others it actually means "Tabular". > Remember that Table/Tabular are related in the same way Figure/Image do, > although LyX kind of ignores that (LaTeX does not). This makes it impossible > to translate that word without introducing inconsistencies (see the attached > image). I don't have strong opinion, but not seeing others responding it's maybe trying to be too strict. Admittedly I never really distinguished these two, OTOH if LaTeX distinguishes it, we should perhaps too... Pavel -- lyx-devel mailing list lyx-devel@lists.lyx.org http://lists.lyx.org/mailman/listinfo/lyx-devel
Re: String Freeze Update
On Fri, Sep 08, 2023 at 04:05:49PM -0400, Richard Kimberly Heck wrote: > I am planning to freeze strings once we have had some initial feedback on > beta 5 and make sure that there aren't any issues there that need a string > change. We're waiting at the moment for the Windows installer. Riki, how do you evaluate the current status wrt the freeze? I might have some time in the next few weeks to be somewhat helpful in sorting out the issues with (layout)translations if we decide to freeze. Pavel -- lyx-devel mailing list lyx-devel@lists.lyx.org http://lists.lyx.org/mailman/listinfo/lyx-devel
Re: String Freeze Update
> I am planning to freeze strings once we have had some initial feedback on > beta 5 and make sure that there aren't any issues there that need a string > change. We're waiting at the moment for the Windows installer. > > That said, if there are any changes you want to get into 2.4.0 that involve > strings, now is the time. > > Riki > I have three suggestions. 1. Tools > Preferences > Document Handling > Display single close-tab button. The tooltip states that, if checked, a single close-tab button will appear on the "left corner", but it actually appears on the far right of the tabbar (see attached images). 2. Some command line options do not work properly (type "lyx --help" in a terminal). Try, for instance, issuing twice this command in the terminal (with an already existing LyX file) "lyx -v -f none -E lyxgz test my-existing-file.lyx" · option "-f none", not actually working, it still overwrites the output file if it exists. · option "-E" not working either, it ignores the second argument (output filename). 3. Honestly I would change the "Show Changes in output" strings (related to change tracking), which I think are not clear enough (see thread http://lists.lyx.org/pipermail/lyx-devel/2023-September/010662.html). 1. Has simple solution: change the string in "src/frontends/qt/ui_PrefDocHandlingUi.h (line 263)" 2. Unsure whether this is intended and the "lyx --help" message is out-of-date, the other way around. In the former case, the changes to the help message are minimal. 3. Not an error, but a (minor) UX improvement. Daniel. -- Enviat amb Tutanota. -- lyx-devel mailing list lyx-devel@lists.lyx.org http://lists.lyx.org/mailman/listinfo/lyx-devel
String Freeze Update
Hi, all, I am planning to freeze strings once we have had some initial feedback on beta 5 and make sure that there aren't any issues there that need a string change. We're waiting at the moment for the Windows installer. That said, if there are any changes you want to get into 2.4.0 that involve strings, now is the time. Riki -- lyx-devel mailing list lyx-devel@lists.lyx.org http://lists.lyx.org/mailman/listinfo/lyx-devel
Re: [PATCH] Making Update::SinglePar work inside insets
Le 23/07/2023 à 02:40, Richard Kimberly Heck a écrit : I was hoping to go to RC1 pretty soon, so it might not be the right time for that. We might go ahead and branch 2.5.0dev once RC1 is out. Fine with me. JMarc -- lyx-devel mailing list lyx-devel@lists.lyx.org http://lists.lyx.org/mailman/listinfo/lyx-devel
Re: [PATCH] Making Update::SinglePar work inside insets
On 7/22/23 18:01, Jean-Marc Lasgouttes wrote: Le 18/07/2023 à 20:50, Jean-Marc Lasgouttes a écrit : Le 17/07/2023 à 23:19, Jean-Marc Lasgouttes a écrit : It worked well until one tries to use mathed %-] Updated patch below is better in this respect. Err, I posted the same patch twice! Here is the updated one. The patch is now attached to #12297. We need time to test it, I can apply it to 2.5.0dev and backport it to 2.4.2 or something. Unless Riki tells me that we can try to apply it now and see what happens. I was hoping to go to RC1 pretty soon, so it might not be the right time for that. We might go ahead and branch 2.5.0dev once RC1 is out. Riki -- lyx-devel mailing list lyx-devel@lists.lyx.org http://lists.lyx.org/mailman/listinfo/lyx-devel
Re: [PATCH] Making Update::SinglePar work inside insets
Le 18/07/2023 à 20:50, Jean-Marc Lasgouttes a écrit : Le 17/07/2023 à 23:19, Jean-Marc Lasgouttes a écrit : It worked well until one tries to use mathed %-] Updated patch below is better in this respect. Err, I posted the same patch twice! Here is the updated one. The patch is now attached to #12297. We need time to test it, I can apply it to 2.5.0dev and backport it to 2.4.2 or something. Unless Riki tells me that we can try to apply it now and see what happens. JMarc -- lyx-devel mailing list lyx-devel@lists.lyx.org http://lists.lyx.org/mailman/listinfo/lyx-devel
Re: [PATCH] Making Update::SinglePar work inside insets
Le 17/07/2023 à 23:19, Jean-Marc Lasgouttes a écrit :
It worked well until one tries to use mathed %-] Updated patch below is
better in this respect.
Err, I posted the same patch twice! Here is the updated one.
JMarc
From f17ff420bfa7c2390776023c566c4974ea612f28 Mon Sep 17 00:00:00 2001
From: Jean-Marc Lasgouttes
Date: Mon, 17 Jul 2023 14:43:29 +0200
Subject: [PATCH] Enable Update::SinglePar in nested insets too
The idea of single par update is to try to re-break only the paragraph
containing the cursor (if this paragraph contains insets etc.,
re-breaking will recursively descend).
The existing single paragraph update mechanism was tailored to work
only at top level. Indeed changing a paragraph nested into an inset may
lead to larger changes.
This commit tries a rather naive approach that seems to work well: we
need a full redraw if either
1/ the height has changed
or
2/ the width has changed and it was equal to the text metrics width;
the goal is to catch the case of a one-row inset that grows with
its contents, but optimize the case of typing in a short paragraph
part of a larger inset.
NOTE: if only the height has changed, then it should be
possible to update all metrics at minimal cost. However,
since this is risky, we do not try that right now.
Part of bug #12297.
---
src/BufferView.cpp | 42 +++---
1 file changed, 27 insertions(+), 15 deletions(-)
diff --git a/src/BufferView.cpp b/src/BufferView.cpp
index 15911e8ff3..fa2c3de299 100644
--- a/src/BufferView.cpp
+++ b/src/BufferView.cpp
@@ -3023,24 +3023,36 @@ Cursor const & BufferView::cursor() const
bool BufferView::singleParUpdate()
{
- Text & buftext = buffer_.text();
- pit_type const bottom_pit = d->cursor_.bottom().pit();
- TextMetrics & tm = textMetrics();
- Dimension const old_dim = tm.parMetrics(bottom_pit).dim();
+ CursorSlice const & its = d->cursor_.innerTextSlice();
+ pit_type const pit = its.pit();
+ TextMetrics & tm = textMetrics(its.text());
+ Dimension const old_dim = tm.parMetrics(pit).dim();
// make sure inline completion pointer is ok
if (d->inlineCompletionPos_.fixIfBroken())
d->inlineCompletionPos_ = DocIterator();
- // In Single Paragraph mode, rebreak only
- // the (main text, not inset!) paragraph containing the cursor.
- // (if this paragraph contains insets etc., rebreaking will
- // recursively descend)
- tm.redoParagraph(bottom_pit);
- ParagraphMetrics & pm = tm.parMetrics(bottom_pit);
- if (pm.height() != old_dim.height()) {
- // Paragraph height has changed so we cannot proceed to
- // the singlePar optimisation.
+ /* Try to rebreak only the paragraph containing the cursor (if
+ * this paragraph contains insets etc., rebreaking will
+ * recursively descend). We need a full redraw if either
+ * 1/ the height has changed
+ * or
+ * 2/ the width has changed and it was equal to the textmetrics
+ *width; the goal is to catch the case of a one-row inset that
+ *grows with its contents, but optimize the case of typing at
+ *the end of a mmultiple-row paragraph.
+ *
+ * NOTE: if only the height has changed, then it should be
+ * possible to update all metrics at minimal cost. However,
+ * since this is risky, we do not try that right now.
+ */
+ tm.redoParagraph(pit);
+ ParagraphMetrics & pm = tm.parMetrics(pit);
+ if (pm.height() != old_dim.height()
+ || (pm.width() != old_dim.width() && old_dim.width() == tm.width())) {
+ // Paragraph height or width has changed so we cannot proceed
+ // to the singlePar optimisation.
+ LYXERR(Debug::PAINTING, "SinglePar optimization failed.");
return false;
}
// Since position() points to the baseline of the first row, we
@@ -3048,11 +3060,11 @@ bool BufferView::singleParUpdate()
// the height does not change but the ascent does.
pm.setPosition(pm.position() - old_dim.ascent() + pm.ascent());
- tm.updatePosCache(bottom_pit);
+ tm.updatePosCache(pit);
LYXERR(Debug::PAINTING, "\ny1: " << pm.position() - pm.ascent()
<< " y2: " << pm.position() + pm.descent()
- << " pit: " << bottom_pit
+ << " pit: " << pit
<< " singlepar: 1");
return true;
}
--
2.39.2
--
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel
Re: [PATCH] Making Update::SinglePar work inside insets
On Mon, Jul 17, 2023 at 11:19:22PM +0200, Jean-Marc Lasgouttes wrote: > What I cannot fix easily, though is that if I insert characters just before > the branch (in same paragraph), things are ugly again because the whole > branch has to be typeset again and again. Indeed, that is still slow. In any case, the situation is much improved! Scott signature.asc Description: PGP signature -- lyx-devel mailing list lyx-devel@lists.lyx.org http://lists.lyx.org/mailman/listinfo/lyx-devel
Re: [PATCH] Making Update::SinglePar work inside insets
Le 17/07/2023 à 18:00, Scott Kostyshak a écrit :
On Mon, Jul 17, 2023 at 04:03:32PM +0200, Jean-Marc Lasgouttes wrote:
Hello,
This patch tries to address #12297, where typing in the big branch in the
attached big-inset.23.lyx file is painfully slow.
Works well! I just did some brief testing.
It worked well until one tries to use mathed %-] Updated patch below is
better in this respect.
Works well! I just did some brief testing. Scrolling is still slow, but with your patch
typing and returns are much faster, and even "workable" (in the sense that if
there were no scrolling issue I could imagine editing the document without too much
frustration).
Indeed. The good news is that in principle LyX has already (painfully)
computed all the needed metrics for scrolling, so in principle it should
not be impossible to fix.
What I cannot fix easily, though is that if I insert characters just
before the branch (in same paragraph), things are ugly again because the
whole branch has to be typeset again and again.
JMarcFrom c48f313d27b0bede0829877fb65100ad388ca3e3 Mon Sep 17 00:00:00 2001
From: Jean-Marc Lasgouttes
Date: Mon, 17 Jul 2023 14:43:29 +0200
Subject: [PATCH] Enable Update::SinglePar in nested insets too
The idea of single par update is to try to re-break only the paragraph
containing the cursor (if this paragraph contains insets etc.,
re-breaking will recursively descend).
The existing single paragraph update mechanism was tailored to work
only at top level. Indeed changing a paragraph nested into an inset may
lead to larger changes.
This commit tries a rather naive approach that seems to work well: we
need a full redraw if either
1/ the height has changed
or
2/ the width has changed and it was equal to the text metrics width;
the goal is to catch the case of a one-row inset that grows with
its contents, but optimize the case of typing in a short paragraph
part of a larger inset.
NOTE: if only the height has changed, then it should be
possible to update all metrics at minimal cost. However,
since this is risky, we do not try that right now.
Part of bug #12297.
---
src/BufferView.cpp | 41 ++---
1 file changed, 26 insertions(+), 15 deletions(-)
diff --git a/src/BufferView.cpp b/src/BufferView.cpp
index 15911e8ff3..f30e656477 100644
--- a/src/BufferView.cpp
+++ b/src/BufferView.cpp
@@ -3023,24 +3023,35 @@ Cursor const & BufferView::cursor() const
bool BufferView::singleParUpdate()
{
- Text & buftext = buffer_.text();
- pit_type const bottom_pit = d->cursor_.bottom().pit();
- TextMetrics & tm = textMetrics();
- Dimension const old_dim = tm.parMetrics(bottom_pit).dim();
+ pit_type const pit = d->cursor_.pit();
+ TextMetrics & tm = textMetrics(d->cursor_.text());
+ Dimension const old_dim = tm.parMetrics(pit).dim();
// make sure inline completion pointer is ok
if (d->inlineCompletionPos_.fixIfBroken())
d->inlineCompletionPos_ = DocIterator();
- // In Single Paragraph mode, rebreak only
- // the (main text, not inset!) paragraph containing the cursor.
- // (if this paragraph contains insets etc., rebreaking will
- // recursively descend)
- tm.redoParagraph(bottom_pit);
- ParagraphMetrics & pm = tm.parMetrics(bottom_pit);
- if (pm.height() != old_dim.height()) {
- // Paragraph height has changed so we cannot proceed to
- // the singlePar optimisation.
+ /* Try to rebreak only the paragraph containing the cursor (if
+ * this paragraph contains insets etc., rebreaking will
+ * recursively descend). We need a full redraw if either
+ * 1/ the height has changed
+ * or
+ * 2/ the width has changed and it was equal to the textmetrics
+ *width; the goal is to catch the case of a one-row inset that
+ *grows with its contents, but optimize the case of typing at
+ *the end of a mmultiple-row paragraph.
+ *
+ * NOTE: if only the height has changed, then it should be
+ * possible to update all metrics at minimal cost. However,
+ * since this is risky, we do not try that right now.
+ */
+ tm.redoParagraph(pit);
+ ParagraphMetrics & pm = tm.parMetrics(pit);
+ if (pm.height() != old_dim.height()
+ || (pm.width() != old_dim.width() && old_dim.width() == tm.width())) {
+ // Paragraph height or width has changed so we cannot proceed
+ // to the singlePar optimisation.
+ LYXERR(Debug::PAINTING, "SinglePar optimization failed.");
return false;
}
// Since position() points to the baseline of the first row, we
@@ -3048,11 +3059,11 @@ bool BufferView::singleParUpdate()
// the height does not change but the ascent does.
pm.setPosition(pm.position() - old_dim.ascent() + pm.ascent());
- tm.updatePosCache(bottom_pit);
+ tm.updatePosCache(pit);
LYXERR(Debug::PAINTING, "\ny1: " << pm.position() - pm.ascent()
<< " y2: " << pm.position() + pm.descent()
- << " pit: " <&
Re: [PATCH] Making Update::SinglePar work inside insets
On Mon, Jul 17, 2023 at 04:03:32PM +0200, Jean-Marc Lasgouttes wrote: > Hello, > > This patch tries to address #12297, where typing in the big branch in the > attached big-inset.23.lyx file is painfully slow. > > To this end, I made BufferView::singleParUpdate, and the result looks great. > Since the changes are pretty minimal, I wonder what I did miss. > > I would be happy if this patch could get some testing in two respects: > > 1/ what are the cases where is breaks screen rendering? > > 2/ what are the operations that are still too slow with the test file? Works well! I just did some brief testing. Scrolling is still slow, but with your patch typing and returns are much faster, and even "workable" (in the sense that if there were no scrolling issue I could imagine editing the document without too much frustration). Thanks for working on this! Scott signature.asc Description: PGP signature -- lyx-devel mailing list lyx-devel@lists.lyx.org http://lists.lyx.org/mailman/listinfo/lyx-devel
Re: [LyX/master] Update tex2lyx tests
On Wed, Jun 21, 2023 at 08:23:55PM +0200, Scott Kostyshak wrote: > > commit f208f180223aa0418cdb7c86619cdf9fa8255962 > Author: Scott Kostyshak > Date: Wed Jun 21 14:38:23 2023 -0400 > > Update tex2lyx tests > > Update the test files after the last format change (c3f98d1f). > --- Riki can you confirm there's nothing we need to do for tex2lyx? Scott signature.asc Description: PGP signature -- lyx-devel mailing list lyx-devel@lists.lyx.org http://lists.lyx.org/mailman/listinfo/lyx-devel
Re: [LyX/master] Honor Update::SinglePar properly
On Tue, Feb 21, 2023 at 06:57:39PM +0100, Lorenzo Bertini wrote: > Il 21/02/23 17:01, Scott Kostyshak ha scritto: > > On Wed, Feb 20, 2019 at 02:37:03PM +0100, Jean-Marc Lasgouttes wrote: > > Found an instance that seems to be missing an update. > > > > Reproducing requires some fast typing. It is only 30% reproducible even > > after a shot of espresso, but 100% reproducible if I cheat with xdotool. > > > > To reproduce: > > > > 1. Open the attached document. > > 2. Place the cursor inside the empty math inset. > > 3. Very quickly type "\upsil". > > > > I get the attached screenshot. > > > > If you are on Linux with X, you can use the following instead of typing > > quickly: > > > > # enter this into a terminal window after opening > > missing-update-screenshot.png. > > sleep 5s && > > # Now switch to LyX and put the cursor in the math inset. > > xdotool type --clearmodifiers --delay 0 "\upsil" && > > xdotool key Tab > > > > Can anyone reproduce? > > > > Scott > > Since a couple years I found a very similar issue in master (that wasn't > there in 2.3). Trying to complete with TAB any math command very fast > produces that result. > > Note that this can be reproduced consistently only on my laptop, which is > quite old and slow; to reproduce on newer hardware you have to be really > fast, or it doesn't happen. Thanks! It is good to have another use case. Scott signature.asc Description: PGP signature -- lyx-devel mailing list lyx-devel@lists.lyx.org http://lists.lyx.org/mailman/listinfo/lyx-devel
Re: [LyX/master] Honor Update::SinglePar properly
Il 21/02/23 17:01, Scott Kostyshak ha scritto: On Wed, Feb 20, 2019 at 02:37:03PM +0100, Jean-Marc Lasgouttes wrote: Found an instance that seems to be missing an update. Reproducing requires some fast typing. It is only 30% reproducible even after a shot of espresso, but 100% reproducible if I cheat with xdotool. To reproduce: 1. Open the attached document. 2. Place the cursor inside the empty math inset. 3. Very quickly type "\upsil". I get the attached screenshot. If you are on Linux with X, you can use the following instead of typing quickly: # enter this into a terminal window after opening missing-update-screenshot.png. sleep 5s && # Now switch to LyX and put the cursor in the math inset. xdotool type --clearmodifiers --delay 0 "\upsil" && xdotool key Tab Can anyone reproduce? Scott Since a couple years I found a very similar issue in master (that wasn't there in 2.3). Trying to complete with TAB any math command very fast produces that result. Note that this can be reproduced consistently only on my laptop, which is quite old and slow; to reproduce on newer hardware you have to be really fast, or it doesn't happen. -- lorenzo-- lyx-devel mailing list lyx-devel@lists.lyx.org http://lists.lyx.org/mailman/listinfo/lyx-devel
Re: [LyX/master] Honor Update::SinglePar properly
Le 21/02/2023 à 18:08, Scott Kostyshak a écrit : Could you put that to trac, so that I can track it? Done: https://www.lyx.org/trac/ticket/12674 I the set milestone to 2.4.0 since it's a regression, but it is a very minor issue and I don't imagine many at all will come across it and even if they do, a simple keypress causes a repaint. So I do not think this is important for 2.4.0 (feel free to remove the milestone). You are too kind, thanks ;) JMarc -- lyx-devel mailing list lyx-devel@lists.lyx.org http://lists.lyx.org/mailman/listinfo/lyx-devel
Re: [LyX/master] Honor Update::SinglePar properly
On Tue, Feb 21, 2023 at 05:56:14PM +0100, Jean-Marc Lasgouttes wrote: > Le 21/02/2023 à 17:01, Scott Kostyshak a écrit : > > On Wed, Feb 20, 2019 at 02:37:03PM +0100, Jean-Marc Lasgouttes wrote: > > > commit 9bdc0dab31337fd6788d587127842eb3558881ae > > > Author: Jean-Marc Lasgouttes > > > Date: Wed Feb 20 12:01:44 2019 +0100 > > > > > > Honor Update::SinglePar properly > > > The SinglePar update flags has been a no-op for a long time without > > > naybody noticing. This means that the current paragraph was > > > always rebroken and redrawn, even when only moving the cursor around. > > > Now we only do that when Update::SinglePar has been specified. This > > > means that there may be cases where update will not be correct > > > anymore, because this flag has not been specified. These places will > > > have to be found and fixed. > > > Update PAINTING_ANALYSIS. > > > --- > > > > Found an instance that seems to be missing an update. > > > > Reproducing requires some fast typing. It is only 30% reproducible even > > after a shot of espresso, but 100% reproducible if I cheat with xdotool. > > A better way to reproduce is to set the inline completion delay to 2 seconds > (instead of the default 0.2s). > > It seems that bad things happen when using tab before the completion timer > triggers. Then Tab shows the missing "psilon" in gray (instead of replacing > everything by the right glyph). > > I don't like macro completion in math. I do not even understand how it works > :( > > Could you put that to trac, so that I can track it? Done: https://www.lyx.org/trac/ticket/12674 I the set milestone to 2.4.0 since it's a regression, but it is a very minor issue and I don't imagine many at all will come across it and even if they do, a simple keypress causes a repaint. So I do not think this is important for 2.4.0 (feel free to remove the milestone). Scott signature.asc Description: PGP signature -- lyx-devel mailing list lyx-devel@lists.lyx.org http://lists.lyx.org/mailman/listinfo/lyx-devel
Re: [LyX/master] Honor Update::SinglePar properly
Le 21/02/2023 à 17:01, Scott Kostyshak a écrit : On Wed, Feb 20, 2019 at 02:37:03PM +0100, Jean-Marc Lasgouttes wrote: commit 9bdc0dab31337fd6788d587127842eb3558881ae Author: Jean-Marc Lasgouttes Date: Wed Feb 20 12:01:44 2019 +0100 Honor Update::SinglePar properly The SinglePar update flags has been a no-op for a long time without naybody noticing. This means that the current paragraph was always rebroken and redrawn, even when only moving the cursor around. Now we only do that when Update::SinglePar has been specified. This means that there may be cases where update will not be correct anymore, because this flag has not been specified. These places will have to be found and fixed. Update PAINTING_ANALYSIS. --- Found an instance that seems to be missing an update. Reproducing requires some fast typing. It is only 30% reproducible even after a shot of espresso, but 100% reproducible if I cheat with xdotool. A better way to reproduce is to set the inline completion delay to 2 seconds (instead of the default 0.2s). It seems that bad things happen when using tab before the completion timer triggers. Then Tab shows the missing "psilon" in gray (instead of replacing everything by the right glyph). I don't like macro completion in math. I do not even understand how it works :( Could you put that to trac, so that I can track it? JMarc To reproduce: 1. Open the attached document. 2. Place the cursor inside the empty math inset. 3. Very quickly type "\upsil". I get the attached screenshot. If you are on Linux with X, you can use the following instead of typing quickly: # enter this into a terminal window after opening missing-update-screenshot.png. sleep 5s && # Now switch to LyX and put the cursor in the math inset. xdotool type --clearmodifiers --delay 0 "\upsil" && xdotool key Tab Can anyone reproduce? Scott -- lyx-devel mailing list lyx-devel@lists.lyx.org http://lists.lyx.org/mailman/listinfo/lyx-devel
Re: [LyX/master] Honor Update::SinglePar properly
On Wed, Feb 20, 2019 at 02:37:03PM +0100, Jean-Marc Lasgouttes wrote: > commit 9bdc0dab31337fd6788d587127842eb3558881ae > Author: Jean-Marc Lasgouttes > Date: Wed Feb 20 12:01:44 2019 +0100 > > Honor Update::SinglePar properly > > The SinglePar update flags has been a no-op for a long time without > naybody noticing. This means that the current paragraph was > always rebroken and redrawn, even when only moving the cursor around. > > Now we only do that when Update::SinglePar has been specified. This > means that there may be cases where update will not be correct > anymore, because this flag has not been specified. These places will > have to be found and fixed. > > Update PAINTING_ANALYSIS. > --- Found an instance that seems to be missing an update. Reproducing requires some fast typing. It is only 30% reproducible even after a shot of espresso, but 100% reproducible if I cheat with xdotool. To reproduce: 1. Open the attached document. 2. Place the cursor inside the empty math inset. 3. Very quickly type "\upsil". I get the attached screenshot. If you are on Linux with X, you can use the following instead of typing quickly: # enter this into a terminal window after opening missing-update-screenshot.png. sleep 5s && # Now switch to LyX and put the cursor in the math inset. xdotool type --clearmodifiers --delay 0 "\upsil" && xdotool key Tab Can anyone reproduce? Scott missing-update.23.lyx Description: application/lyx signature.asc Description: PGP signature -- lyx-devel mailing list lyx-devel@lists.lyx.org http://lists.lyx.org/mailman/listinfo/lyx-devel
Re: Update lyx-2.4 docs
Le 29/01/2023 à 17:37, Jürgen Spitzmüller a écrit : Am Sonntag, dem 29.01.2023 um 17:23 +0100 schrieb Jean-Pierre Chrétien: I would like to search easily what has been updated since (but for the new index features that I have already updated in the UserGuide). Is it possible to search for modifications after a given date in the documents ? I could search for changes in Trac, but is is quite lengthy. Document > Track Changes > Accept and Reject Changes. This dialog has the change dates (not ideal for sure). Thanks, but it would be much faster if this info was automatically displayed when you go to the next modification. -- Jean-Pierre -- lyx-devel mailing list lyx-devel@lists.lyx.org http://lists.lyx.org/mailman/listinfo/lyx-devel
Re: Update lyx-2.4 docs
On 2023-01-29 17:37, Jürgen Spitzmüller wrote: Am Sonntag, dem 29.01.2023 um 17:23 +0100 schrieb Jean-Pierre Chrétien: I would like to search easily what has been updated since (but for the new index features that I have already updated in the UserGuide). Is it possible to search for modifications after a given date in the documents ? I could search for changes in Trac, but is is quite lengthy. Document > Track Changes > Accept and Reject Changes. This dialog has the change dates (not ideal for sure). I am curious, since I don't have an entry named "Accept and Reject Changes". Did you mean "Merge Changes..."? Daniel -- lyx-devel mailing list lyx-devel@lists.lyx.org http://lists.lyx.org/mailman/listinfo/lyx-devel
Re: Update lyx-2.4 docs
On Sun, Jan 29, 2023 at 05:37:30PM +0100, Jürgen Spitzmüller wrote:
> Am Sonntag, dem 29.01.2023 um 17:23 +0100 schrieb Jean-Pierre Chrétien:
> > I would like to search easily what has been updated since (but for
> > the new index
> > features that I have already updated in the UserGuide).
> > Is it possible to search for modifications after a given date in the
> > documents ?
> > I could search for changes in Trac, but is is quite lengthy.
>
> Document > Track Changes > Accept and Reject Changes. This dialog has
> the change dates (not ideal for sure).
Not ideal either but, if you can track down commit hash which you
already covered and count of the commits to manual since then (you could use
something like:
git log {SHA_of_20_month_old_commit_not_translated_yet..HEAD
path_to/manual.lyx | grep ^commit|wc -l
)
Then take that count number and use File->Version control->Compare with older
Revision
and fill up that number into Revisions back.
Pavel
--
lyx-devel mailing list
lyx-devel@lists.lyx.org
http://lists.lyx.org/mailman/listinfo/lyx-devel
Re: Update lyx-2.4 docs
Am Sonntag, dem 29.01.2023 um 17:23 +0100 schrieb Jean-Pierre Chrétien: > I would like to search easily what has been updated since (but for > the new index > features that I have already updated in the UserGuide). > Is it possible to search for modifications after a given date in the > documents ? > I could search for changes in Trac, but is is quite lengthy. Document > Track Changes > Accept and Reject Changes. This dialog has the change dates (not ideal for sure). -- Jürgen -- lyx-devel mailing list lyx-devel@lists.lyx.org http://lists.lyx.org/mailman/listinfo/lyx-devel
Update lyx-2.4 docs
Dear Developers, I performed a first update of the French 2.4 documentation around 20 months ago. I would like to search easily what has been updated since (but for the new index features that I have already updated in the UserGuide). Is it possible to search for modifications after a given date in the documents ? I could search for changes in Trac, but is is quite lengthy. -- Regards Jean-Pierre -- lyx-devel mailing list lyx-devel@lists.lyx.org http://lists.lyx.org/mailman/listinfo/lyx-devel
Re: [LyX/master] Revert doc update for Additional.lyx so maitenance work can continue.
On Wed, Jan 04, 2023 at 10:06:13PM +0100, Pavel Sanda wrote: > On Fri, Dec 30, 2022 at 09:27:32AM +0100, Jürgen Spitzmüller wrote: > > Am Donnerstag, dem 29.12.2022 um 15:25 -0500 schrieb Scott Kostyshak: > > > Sounds good. I can do that. Should I do that now or wait (i.e., would > > > this change disrupt the ongoing work)? > > > > It's probably better to wait until John is done. > > Scott, this is the right time for your fix... Thanks, fixes in at 3c8a5d4d^..cb27aaa8. Scott signature.asc Description: PGP signature -- lyx-devel mailing list lyx-devel@lists.lyx.org http://lists.lyx.org/mailman/listinfo/lyx-devel
Re: [LyX/master] Revert doc update for Additional.lyx so maitenance work can continue.
On Fri, Dec 30, 2022 at 09:27:32AM +0100, Jürgen Spitzmüller wrote: > Am Donnerstag, dem 29.12.2022 um 15:25 -0500 schrieb Scott Kostyshak: > > Sounds good. I can do that. Should I do that now or wait (i.e., would > > this change disrupt the ongoing work)? > > It's probably better to wait until John is done. Scott, this is the right time for your fix... Pavel -- lyx-devel mailing list lyx-devel@lists.lyx.org http://lists.lyx.org/mailman/listinfo/lyx-devel
Patch to update entries for Foils, Slides and Reports in Chapter 3 Document classes and do some final tidying up in Additional.lyx
From 80b7399a0c5b854f897c97329c8288181a7c62d2 Mon Sep 17 00:00:00 2001
From: John R Hudson
Date: Tue, 3 Jan 2023 11:04:16 +
Subject: [PATCH] Update entries for Foils, Slides and Reports in Chapter 3
Document classes and do final tidying up of Additional.lyx
---
lib/doc/Additional.lyx | 450 -
1 file changed, 403 insertions(+), 47 deletions(-)
diff --git a/lib/doc/Additional.lyx b/lib/doc/Additional.lyx
index c4fe5f35b5..f3dd217f12 100644
--- a/lib/doc/Additional.lyx
+++ b/lib/doc/Additional.lyx
@@ -5715,7 +5715,13 @@ Skip
\begin_layout Subsection
-\change_inserted 564990737 1670924924
+\change_inserted 564990737 1672743555
+\begin_inset CommandInset label
+LatexCommand label
+name "subsec:Polish-M.W.collection"
+
+\end_inset
+
Polish M.
\begin_inset space \thinspace{}
\end_inset
@@ -9971,16 +9977,138 @@ name "sec:foiltex"
\end_layout
\begin_layout Standard
-by
+
+\change_inserted 564990737 1672743383
+
+\lang american
+Original by
\noun on
Allan Rae
+\noun default
+; updated by the \SpecialChar LyX
+ Team
\end_layout
\begin_layout Subsubsection
+
+\change_inserted 564990737 1672743383
+
+\lang american
+Introduction
+\end_layout
+
+\begin_layout Standard
+
+\change_inserted 564990737 1672743396
+
+\lang american
+The document class
+\family sans
+presentation
+\begin_inset space \thinspace{}
+\end_inset
+
+(Foil\SpecialChar TeX
+)
+\family default
+ uses the
+\family typewriter
+foils.cls
+\family default
+ document class to make slides for overhead projectors.
+ There are two document classes that can do this: the
+\family sans
+presentations
+\begin_inset space \thinspace{}
+\end_inset
+
+(slides)
+\family default
+ document class (section
+\begin_inset space ~
+\end_inset
+
+
+\begin_inset CommandInset ref
+LatexCommand ref
+reference "sec:slitex"
+plural "false"
+caps "false"
+noprefix "false"
+
+\end_inset
+
+) and the
+\family sans
+Foil\SpecialChar TeX
+
+\family default
+ slides class.
+ As of 2023 the former has continued to be maintained whereas
+\family sans
+Foil\SpecialChar TeX
+
+\family default
+ has not been maintained since 2008.
+ This section documents the latter.
+ If your machine doesn’t have the
+\family sans
+presentation
+\begin_inset space \thinspace{}
+\end_inset
+
+(Foil\SpecialChar TeX
+)
+\family default
+ document class installed, you’ll probably have to use the
+\family sans
+presentations
+\begin_inset space \thinspace{}
+\end_inset
+
+(slides)
+\family default
+ document class.
+ If you want to install the
+\family typewriter
+foils.cls
+\family default
+ document class, it is available from
+\begin_inset CommandInset href
+LatexCommand href
+name "CTAN"
+target "https://www.ctan.org/pkg/foiltex;
+literal "false"
+
+\end_inset
+
+.
+ You should also read the
+\emph on
+Installing New Document Classes
+\emph default
+ chapter of the
+\emph on
+Customization
+\emph default
+ manual.
+\change_deleted 564990737 1672743436
+
+\lang english
+by
+\noun on
+Allan Rae
+\end_layout
+
+\begin_layout Standard
+
+\change_deleted 564990737 1672743383
Introduction
\end_layout
\begin_layout Standard
+
+\change_deleted 564990737 1672743383
This section describes how to use \SpecialChar LyX
to make slides for overhead projectors.
There are two document classes that can do this: the default slides class
@@ -9994,11 +10122,15 @@ Foil\SpecialChar TeX
\end_layout
\begin_layout Standard
+
+\change_deleted 564990737 1672743383
I'm going to say this again, nice and clear, so that there's no misunderstanding
:
\end_layout
\begin_layout Standard
+
+\change_deleted 564990737 1672743383
\begin_inset VSpace bigskip
\end_inset
@@ -10008,6 +10140,8 @@ I'm going to say this again, nice and clear, so that there's no misunderstanding
\begin_layout Standard
\align center
+\change_deleted 564990737 1672743383
+
\size large
This section documents the class
\begin_inset Quotes eld
@@ -10027,6 +10161,8 @@ only.
\end_layout
\begin_layout Standard
+
+\change_deleted 564990737 1672743383
\begin_inset VSpace bigskip
\end_inset
@@ -10034,6 +10170,8 @@ only.
\end_layout
\begin_layout Standard
+
+\change_deleted 564990737 1672743383
If you're looking for the documentation for
\begin_inset Quotes eld
\end_inset
@@ -10076,6 +10214,8 @@ foils.
\end_layout
\begin_layout Standard
+
+\change_deleted 564990737 1672743383
The
\family sans
foils
@@ -10091,6 +10231,8 @@ foils.cls
\SpecialChar LaTeX
class file which is now an integral part of \SpecialChar LaTeX2e
.
+\change_unchanged
+
\end_layout
\begin_layout Subsubsection
@@ -11605,6 +11747,83 @@ name "sec:slitex"
\end_layout
\begin_layout Standard
+
+\change_inserted 564990737 1672743492
+
+\lang american
+Original by
+\noun on
+John Weiss
+\noun default
+; updated by the \SpecialChar LyX
+ Team
+\end_layout
+
+\begin_layout Subs
Re: Updated patch to add KOMA-Script_Book.lyx and associated BibTeX file and CC logo to examples/Books and update Makefile.am
On Sunday, 1 January 2023 21:37:52 GMT Pavel Sanda wrote: > I deleted couple files which were clearly added by mistake > and added to the distribution few ones missing: > + examples/Books/koma-book.bib \ > + examples/Books/koma-book-80x15.png \ Thank you. Now I understand how to do it properly. John -- lyx-devel mailing list lyx-devel@lists.lyx.org http://lists.lyx.org/mailman/listinfo/lyx-devel
Re: Updated patch to add KOMA-Script_Book.lyx and associated BibTeX file and CC logo to examples/Books and update Makefile.am
On Sun, Jan 01, 2023 at 04:38:04PM +, John Robert Hudson wrote: > This patch contains the necessary files. It's in. I deleted couple files which were clearly added by mistake > Figure, |0 > Float- |0 > "Horizontal\302\240Fill." |0 > "Paragraph\302\240Settings."|0 > Settings|0 > "Special\302\240Character-" |0 and added to the distribution few ones missing: + examples/Books/koma-book.bib \ + examples/Books/koma-book-80x15.png \ Thanks, Pavel -- lyx-devel mailing list lyx-devel@lists.lyx.org http://lists.lyx.org/mailman/listinfo/lyx-devel
Updated patch to add KOMA-Script_Book.lyx and associated BibTeX file and CC logo to examples/Books and update Makefile.am
This patch contains the necessary files.From 32c4ab5090727450f0a4684122516a32e120a664 Mon Sep 17 00:00:00 2001 From: John R Hudson Date: Sun, 1 Jan 2023 16:31:50 + Subject: [PATCH] Add KOMA-Script_Book.lyx and associated BibTeX file and CC logo to examples/Books and update Makefile.am --- Figure, |0 Float- |0 "Horizontal\302\240Fill." |0 "Paragraph\302\240Settings."|0 Settings|0 "Special\302\240Character-" |0 lib/Makefile.am |1 + lib/examples/Books/KOMA-Script_Book.lyx | 2409 +++ lib/examples/Books/koma-book-80x15.png | Bin 0 -> 697 bytes lib/examples/Books/koma-book.bib| 22 + 10 files changed, 2432 insertions(+) create mode 100644 Figure, create mode 100644 Float- create mode 100644 "Horizontal\302\240Fill." create mode 100644 "Paragraph\302\240Settings." create mode 100644 Settings create mode 100644 "Special\302\240Character-" create mode 100644 lib/examples/Books/KOMA-Script_Book.lyx create mode 100644 lib/examples/Books/koma-book-80x15.png create mode 100644 lib/examples/Books/koma-book.bib diff --git a/Figure, b/Figure, new file mode 100644 index 00..e69de29bb2 diff --git a/Float- b/Float- new file mode 100644 index 00..e69de29bb2 diff --git "a/Horizontal\302\240Fill." "b/Horizontal\302\240Fill." new file mode 100644 index 00..e69de29bb2 diff --git "a/Paragraph\302\240Settings." "b/Paragraph\302\240Settings." new file mode 100644 index 00..e69de29bb2 diff --git a/Settings b/Settings new file mode 100644 index 00..e69de29bb2 diff --git "a/Special\302\240Character-" "b/Special\302\240Character-" new file mode 100644 index 00..e69de29bb2 diff --git a/lib/Makefile.am b/lib/Makefile.am index 34296ed12e..241a9f5cde 100644 --- a/lib/Makefile.am +++ b/lib/Makefile.am @@ -376,6 +376,7 @@ dist_articlechessexamples_DATA = \ bookexamplesdir = $(pkgdatadir)/examples/Books dist_bookexamples_DATA = \ examples/Books/American_Mathematical_Society_%28AMS%29.lyx \ + examples/Books/KOMA-Script_Book.lyx \ examples/Books/Recipe_Book.lyx \ examples/Books/Tufte_Book.lyx diff --git a/lib/examples/Books/KOMA-Script_Book.lyx b/lib/examples/Books/KOMA-Script_Book.lyx new file mode 100644 index 00..d98a13aa1f --- /dev/null +++ b/lib/examples/Books/KOMA-Script_Book.lyx @@ -0,0 +1,2409 @@ +#LyX 2.4 created this file. For more info see https://www.lyx.org/ +\lyxformat 610 +\begin_document +\begin_header +\save_transient_properties true +\origin unavailable +\textclass scrbook +\begin_preamble + +\end_preamble +\options captions=tableheading,headings=small,numbers=noenddot,BCOR=7.5mm,DIV=12,intoc,index=totoc +\use_default_options true +\maintain_unincluded_children no +\language british +\language_package default +\inputencoding auto-legacy +\fontencoding auto +\font_roman "lmodern" "default" +\font_sans "lmss" "default" +\font_typewriter "lmtt" "default" +\font_math "auto" "auto" +\font_default_family default +\use_non_tex_fonts false +\font_sc false +\font_roman_osf false +\font_sans_osf false +\font_typewriter_osf false +\font_sf_scale 100 100 +\font_tt_scale 100 100 +\use_microtype false +\use_dash_ligatures true +\graphics default +\default_output_format default +\output_sync 0 +\bibtex_command default +\index_command default +\float_placement class +\float_alignment class +\paperfontsize default +\spacing single +\use_hyperref true +\pdf_bookmarks true +\pdf_bookmarksnumbered false +\pdf_bookmarksopen false +\pdf_bookmarksopenlevel 1 +\pdf_breaklinks false +\pdf_pdfborder true +\pdf_colorlinks true +\pdf_backref false +\pdf_pdfusetitle false +\pdf_quoted_options "citecolor=black,linkcolor=black,urlcolor=black" +\papersize a5 +\use_geometry false +\use_package amsmath 1 +\use_package amssymb 1 +\use_package cancel 1 +\use_package esint 1 +\use_package mathdots 1 +\use_package mathtools 1 +\use_package mhchem 1 +\use_package stackrel 1 +\use_package stmaryrd 1 +\use_package undertilde 1 +\cite_engine natbib +\cite_engine_type authoryear +\biblio_style plainnat +\use_bibtopic false +\use_indices false +\paperorientation portrait +\suppress_date true +\justification true +\use_refstyle 1 +\use_minted 0 +\use_lineno 0 +\index Index +\shortcut idx +\color #008000 +\end_index +\secnumdepth 3 +\tocdepth 1 +\paragraph_separation indent +\paragraph_indentation default +\is_math_indent 0 +\math_numbering_side default +\quotes_style english +\dynamic_quotes 0 +\papercolumns 1 +\papersides 2 +\paperpagestyle default +\tablestyle default +\tracking_changes false +\output_changes false +\change_bars false +\postpone_frag
Fwd: Revert of patch to add KOMA-Script_book.lyx and associated BibTeX file and CC logo to Examples>Books and update Makefile.am
-- Forwarded Message -- Subject: Patch to add KOMA-Script_book.lyx and associated BibTeX file and CC logo to Examples>Books and update Makefile.am Date: Saturday, 31 December 2022, 15:45:51 GMT From: John Robert Hudson To: lyx-devel@lists.lyx.org I have reverted this patch because I have realised that I failed to add the relevant files before committing. Sorry>From 4b75a514a5d32745ef5873ac94706a8881193f1c Mon Sep 17 00:00:00 2001 From: John R Hudson Date: Sat, 31 Dec 2022 15:38:22 + Subject: [PATCH] Add KOMA-Script_Book.lyx and associated BibTeX file and CC logo to Examples>Books and update Makefile.am --- lib/Makefile.am | 1 + 1 file changed, 1 insertion(+) diff --git a/lib/Makefile.am b/lib/Makefile.am index 34296ed12e..241a9f5cde 100644 --- a/lib/Makefile.am +++ b/lib/Makefile.am @@ -376,6 +376,7 @@ dist_articlechessexamples_DATA = \ bookexamplesdir = $(pkgdatadir)/examples/Books dist_bookexamples_DATA = \ examples/Books/American_Mathematical_Society_%28AMS%29.lyx \ + examples/Books/KOMA-Script_Book.lyx \ examples/Books/Recipe_Book.lyx \ examples/Books/Tufte_Book.lyx -- 2.35.3 >From b98fc166ae60c8accc21cbdc85f1067db9f23a0b Mon Sep 17 00:00:00 2001 From: John R Hudson Date: Sun, 1 Jan 2023 14:30:44 + Subject: [PATCH] Revert because failed to add new files before commit to "Add KOMA-Script_Book.lyx and associated BibTeX file and CC logo to Examples>Books and update Makefile.am" This reverts commit 4b75a514a5d32745ef5873ac94706a8881193f1c. --- lib/Makefile.am | 1 - 1 file changed, 1 deletion(-) diff --git a/lib/Makefile.am b/lib/Makefile.am index 241a9f5cde..34296ed12e 100644 --- a/lib/Makefile.am +++ b/lib/Makefile.am @@ -376,7 +376,6 @@ dist_articlechessexamples_DATA = \ bookexamplesdir = $(pkgdatadir)/examples/Books dist_bookexamples_DATA = \ examples/Books/American_Mathematical_Society_%28AMS%29.lyx \ - examples/Books/KOMA-Script_Book.lyx \ examples/Books/Recipe_Book.lyx \ examples/Books/Tufte_Book.lyx -- 2.35.3 -- lyx-devel mailing list lyx-devel@lists.lyx.org http://lists.lyx.org/mailman/listinfo/lyx-devel
Patch to add KOMA-Script_book.lyx and associated BibTeX file and CC logo to Examples>Books and update Makefile.am
>From 4b75a514a5d32745ef5873ac94706a8881193f1c Mon Sep 17 00:00:00 2001 From: John R Hudson Date: Sat, 31 Dec 2022 15:38:22 + Subject: [PATCH] Add KOMA-Script_Book.lyx and associated BibTeX file and CC logo to Examples>Books and update Makefile.am --- lib/Makefile.am | 1 + 1 file changed, 1 insertion(+) diff --git a/lib/Makefile.am b/lib/Makefile.am index 34296ed12e..241a9f5cde 100644 --- a/lib/Makefile.am +++ b/lib/Makefile.am @@ -376,6 +376,7 @@ dist_articlechessexamples_DATA = \ bookexamplesdir = $(pkgdatadir)/examples/Books dist_bookexamples_DATA = \ examples/Books/American_Mathematical_Society_%28AMS%29.lyx \ + examples/Books/KOMA-Script_Book.lyx \ examples/Books/Recipe_Book.lyx \ examples/Books/Tufte_Book.lyx -- 2.35.3 -- lyx-devel mailing list lyx-devel@lists.lyx.org http://lists.lyx.org/mailman/listinfo/lyx-devel
Re: [LyX/master] Revert doc update for Additional.lyx so maitenance work can continue.
On Fri, Dec 30, 2022 at 10:21:31AM +0100, Kornel Benko wrote: > Am Fri, 30 Dec 2022 09:27:32 +0100 > schrieb "Jürgen Spitzmüller" : > > > Am Donnerstag, dem 29.12.2022 um 15:25 -0500 schrieb Scott Kostyshak: > > > Sounds good. I can do that. Should I do that now or wait (i.e., would > > > this change disrupt the ongoing work)? > > > > It's probably better to wait until John is done. > > > > If we go this way, we should create a testcase too. Since it seems to be > possible to > create a lyx-file which is not compilable because of language problems, the > cure is to > correct the latex output. > > Just my 2 cents. Good point. I wonder if the problem is the input. e.g., John would need to remember how they input that text, which probably they've forgotten by now. Scott signature.asc Description: PGP signature -- lyx-devel mailing list lyx-devel@lists.lyx.org http://lists.lyx.org/mailman/listinfo/lyx-devel
