Github user srdo commented on the issue:
https://github.com/apache/storm/pull/2789
The change is here https://github.com/apache/storm/pull/2805 and hasn't
been merged yet.
---
Github user srdo commented on the issue:
https://github.com/apache/storm/pull/2800
@danny0405 Thanks for explaining. I'm not sure I understand why the
scheduling thread will see older values with `ConcurrentHashMap` than with
`AtomicReference`? It was my understanding
Github user srdo commented on the issue:
https://github.com/apache/storm/pull/2800
@zd-project I'd like to finish this up. Let me know if you want to make the
last couple of fixes, otherwise I'll open a new PR containing this fix.
@danny0405 I thought about it a bit more
Github user srdo commented on the issue:
https://github.com/apache/storm/pull/2806
+1. Please squash to one commit @jacobtolar.
---
Github user srdo commented on the issue:
https://github.com/apache/storm/pull/2809
@HeartSaVioR Sorry, I didn't get to this in time. I'll try to remember to
fix the nits next time there's a PR against 1.x.
---
Github user srdo commented on the issue:
https://github.com/apache/storm/pull/2800
@danny0405 That doesn't sound safe to me. I think you're right that it
works fine most of the time, but if there are key collisions or an insert leads
the map to get resized, I would think that two
Github user srdo commented on the issue:
https://github.com/apache/storm/pull/2800
@danny0405 Could you elaborate on why fixing the `executorBeats == null`
branch is enough? My concern is that the other branch modifies a HashMap (the
`cache` parameter) from multiple threads
Github user srdo commented on the issue:
https://github.com/apache/storm/pull/2800
Regarding performance, consider that Nimbus is already copying
`heartbeatCache` on writes everywhere else
https://github.com/apache/storm/blob/master/storm-server/src/main/java/org/apache/storm/daemon
Github user srdo commented on the issue:
https://github.com/apache/storm/pull/2800
I don't think fixing the `executorBeats == null` branch is enough. As far
as I can tell, two supervisors/workers can be in the
https://github.com/apache/storm/blob
Github user srdo commented on the issue:
https://github.com/apache/storm/pull/2800
I'm sorry if this turns a bit verbose, but I'm going to write down what I
see as the issue here, so we can hopefully come to a common understanding (and
so I don't forget and have to look at this again
Github user srdo closed the pull request at:
https://github.com/apache/storm/pull/2813
---
Github user srdo commented on the issue:
https://github.com/apache/storm/pull/2813
Need to look at this a bit more, there's an incompatibility with
Cassandra's version of Metrics.
---
GitHub user srdo opened a pull request:
https://github.com/apache/storm/pull/2813
STORM-3204: Upgrade Metrics to 4.0.3
https://issues.apache.org/jira/browse/STORM-3204
The Metrics project has a BOM now, so we don't have to specify versions for
each module or transitive
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2806#discussion_r211484225
--- Diff:
storm-server/src/main/java/org/apache/storm/daemon/supervisor/BasicContainer.java
---
@@ -622,6 +620,12 @@ protected String javaCmd(String cmd
Github user srdo commented on the issue:
https://github.com/apache/storm/pull/2807
Posted a discuss thread on the mailing list.
---
Github user srdo commented on the issue:
https://github.com/apache/storm/pull/2807
Raised https://github.com/apache/storm/pull/2809.
On 1.x the LGPL dependency is excluded so people can install it manually.
If we want to keep metrics-ganglia, we could probably make
GitHub user srdo opened a pull request:
https://github.com/apache/storm/pull/2809
STORM-3199: Remove metrics-ganglia due to LGPL dependency (1.x)
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/srdo/storm STORM-3199-1.x
Github user srdo commented on the issue:
https://github.com/apache/storm/pull/2807
Thanks for reviewing @HeartSaVioR. It can't, I'll open another PR against
1.x shortly
---
Github user srdo closed the pull request at:
https://github.com/apache/storm/pull/2807
---
GitHub user srdo reopened a pull request:
https://github.com/apache/storm/pull/2807
STORM-3199: Remove metrics-ganglia due to LGPL dependency
https://issues.apache.org/jira/browse/STORM-3199
You can merge this pull request into a Git repository by running:
$ git pull https
Github user srdo commented on the issue:
https://github.com/apache/storm/pull/2807
Rerunning test, it had some trouble pulling dependencies from Maven
---
GitHub user srdo opened a pull request:
https://github.com/apache/storm/pull/2807
STORM-3199: Remove metrics-ganglia due to LGPL dependency
https://issues.apache.org/jira/browse/STORM-3199
You can merge this pull request into a Git repository by running:
$ git pull https
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2805#discussion_r210688568
--- Diff: pom.xml ---
@@ -280,7 +280,7 @@
1.6.6
2.8.2
1.7.21
-3.1.0
+3.2.6
--- End diff
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2805#discussion_r210685351
--- Diff: pom.xml ---
@@ -280,7 +280,7 @@
1.6.6
2.8.2
1.7.21
-3.1.0
+3.2.6
--- End diff
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2805#discussion_r210684974
--- Diff: pom.xml ---
@@ -280,7 +280,7 @@
1.6.6
2.8.2
1.7.21
-3.1.0
+3.2.6
--- End diff
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2806#discussion_r210681943
--- Diff:
storm-server/src/main/java/org/apache/storm/daemon/supervisor/BasicContainer.java
---
@@ -622,6 +620,12 @@ protected String javaCmd(String cmd
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2806#discussion_r210683327
--- Diff: pom.xml ---
@@ -278,7 +278,7 @@
4.1.25.Final
1.0.2
1.6.6
-2.8.2
+2.11.0
--- End
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2806#discussion_r210682266
--- Diff: storm-client/src/jvm/org/apache/storm/Config.java ---
@@ -705,6 +705,13 @@
*/
@isString(acceptedValues = { "S0", "
Github user srdo commented on the issue:
https://github.com/apache/storm/pull/2792
The changes look good to me. Please raise an issue at
https://issues.apache.org/jira and rename this PR and the commit message to
contain the issue number.
---
Repository: storm
Updated Branches:
refs/heads/master 4c42ee3d2 -> 88d19b098
STORM-3194 reduce FIFOSchedulingPriorityStrategy logging level
Project: http://git-wip-us.apache.org/repos/asf/storm/repo
Commit: http://git-wip-us.apache.org/repos/asf/storm/commit/cac56053
Tree:
Merge branch 'agresch_fifologging' of https://github.com/agresch/storm into
STORM-3194-merge
Project: http://git-wip-us.apache.org/repos/asf/storm/repo
Commit: http://git-wip-us.apache.org/repos/asf/storm/commit/88d19b09
Tree: http://git-wip-us.apache.org/repos/asf/storm/tree/88d19b09
Diff:
GitHub user srdo opened a pull request:
https://github.com/apache/storm/pull/2805
STORM-3197: Make StormMetricsRegistry non-static
https://issues.apache.org/jira/browse/STORM-3197
This also fixes https://issues.apache.org/jira/browse/STORM-3101 and
https
Github user srdo commented on the issue:
https://github.com/apache/storm/pull/2800
Fixed the nimbus_test https://github.com/zd-project/storm/pull/1
---
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2800#discussion_r210639246
--- Diff:
storm-server/src/main/java/org/apache/storm/daemon/nimbus/Nimbus.java ---
@@ -1660,26 +1658,18 @@ private TopologyDetails readTopologyDetails(String
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2800#discussion_r210633216
--- Diff: storm-client/src/jvm/org/apache/storm/stats/StatsUtil.java ---
@@ -1565,23 +1565,26 @@ public static ComponentPageInfo aggCompExecsStats
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2800#discussion_r210632176
--- Diff: storm-client/src/jvm/org/apache/storm/stats/StatsUtil.java ---
@@ -1525,27 +1528,24 @@ public static ComponentPageInfo aggCompExecsStats
Github user srdo commented on the issue:
https://github.com/apache/storm/pull/2790
@uddhavarote That's not how it works. The stream you emit to doesn't
matter. As long as the tuple you emit from the KafkaBolt is anchored to the
input tuple, the tuple will be replayed from the spout
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2764#discussion_r209381686
--- Diff:
storm-server/src/main/java/org/apache/storm/daemon/nimbus/Nimbus.java ---
@@ -4716,4 +4744,206 @@ public IScheduler getForcedScheduler
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2764#discussion_r209367613
--- Diff:
storm-server/src/main/java/org/apache/storm/daemon/nimbus/Nimbus.java ---
@@ -4716,4 +4744,206 @@ public IScheduler getForcedScheduler
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2764#discussion_r209367421
--- Diff:
storm-server/src/main/java/org/apache/storm/daemon/nimbus/Nimbus.java ---
@@ -4716,4 +4744,206 @@ public IScheduler getForcedScheduler
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2764#discussion_r209366165
--- Diff:
storm-server/src/main/java/org/apache/storm/daemon/nimbus/Nimbus.java ---
@@ -4716,4 +4744,206 @@ public IScheduler getForcedScheduler
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2764#discussion_r209354005
--- Diff:
storm-server/src/main/java/org/apache/storm/daemon/nimbus/Nimbus.java ---
@@ -4716,4 +4744,206 @@ public IScheduler getForcedScheduler
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2764#discussion_r209341987
--- Diff:
storm-server/src/main/java/org/apache/storm/daemon/nimbus/Nimbus.java ---
@@ -2865,16 +2890,14 @@ public void launchServer() throws Exception
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2764#discussion_r209336348
--- Diff:
storm-server/src/main/java/org/apache/storm/daemon/nimbus/Nimbus.java ---
@@ -2905,6 +2929,10 @@ public void launchServer() throws Exception
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2764#discussion_r209333494
--- Diff:
storm-server/src/main/java/org/apache/storm/daemon/nimbus/Nimbus.java ---
@@ -2905,6 +2929,10 @@ public void launchServer() throws Exception
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2764#discussion_r209333088
--- Diff:
storm-server/src/main/java/org/apache/storm/daemon/nimbus/Nimbus.java ---
@@ -4716,4 +4746,186 @@ public IScheduler getForcedScheduler
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2764#discussion_r209331742
--- Diff:
storm-server/src/main/java/org/apache/storm/daemon/nimbus/Nimbus.java ---
@@ -4716,4 +4746,186 @@ public IScheduler getForcedScheduler
Github user srdo commented on the issue:
https://github.com/apache/storm/pull/2789
Once the two PRs with new metrics are merged, I'll try to update the
non-static branch and get a PR opened. It might take me a little while.
---
Github user srdo commented on the issue:
https://github.com/apache/storm/pull/2789
Before spending too long on it, consider if we should fix this issue and
https://github.com/apache/storm/pull/2714 by making the metrics registry
non-static instead (https://github.com/apache/storm
Github user srdo commented on the issue:
https://github.com/apache/storm/pull/2754
+1. Please squash and we can merge.
---
Github user srdo commented on the issue:
https://github.com/apache/storm/pull/2764
I'd like https://github.com/apache/storm/pull/2754 to go in first, so we're
sure the review from there is reflected here. When that one is merged, I'd like
to take another look at these changes.
---
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2754#discussion_r209311727
--- Diff:
storm-server/src/main/java/org/apache/storm/daemon/nimbus/Nimbus.java ---
@@ -2826,21 +2882,27 @@ public void launchServer() throws Exception
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2754#discussion_r209311534
--- Diff:
storm-server/src/main/java/org/apache/storm/daemon/nimbus/Nimbus.java ---
@@ -1984,11 +2052,12 @@ private int fragmentedCpu() {
Cluster
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2764#discussion_r209306763
--- Diff:
storm-server/src/main/java/org/apache/storm/daemon/nimbus/Nimbus.java ---
@@ -4652,4 +4745,192 @@ public IScheduler getForcedScheduler
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2764#discussion_r209304885
--- Diff:
storm-server/src/main/java/org/apache/storm/daemon/nimbus/Nimbus.java ---
@@ -4652,4 +4745,192 @@ public IScheduler getForcedScheduler
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2754#discussion_r209304694
--- Diff:
storm-webapp/src/main/java/org/apache/storm/daemon/logviewer/utils/LogCleaner.java
---
@@ -142,30 +154,41 @@ public void run
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2754#discussion_r209303917
--- Diff:
storm-webapp/src/main/java/org/apache/storm/daemon/logviewer/webapp/LogviewerResource.java
---
@@ -255,8 +302,16 @@ public Response deepSearch
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2764#discussion_r209154625
--- Diff:
storm-server/src/main/java/org/apache/storm/daemon/nimbus/Nimbus.java ---
@@ -4652,4 +4745,192 @@ public IScheduler getForcedScheduler
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2764#discussion_r209154387
--- Diff:
storm-server/src/main/java/org/apache/storm/daemon/nimbus/Nimbus.java ---
@@ -4652,4 +4745,192 @@ public IScheduler getForcedScheduler
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2754#discussion_r209154065
--- Diff:
storm-webapp/src/main/java/org/apache/storm/daemon/logviewer/handler/LogviewerLogPageHandler.java
---
@@ -61,18 +63,21 @@
import
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2754#discussion_r209153726
--- Diff:
storm-webapp/src/test/java/org/apache/storm/daemon/logviewer/handler/LogviewerLogSearchHandlerTest.java
---
@@ -627,6 +627,7 @@ public void
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2754#discussion_r209153602
--- Diff:
storm-webapp/src/main/java/org/apache/storm/daemon/logviewer/webapp/LogviewerResource.java
---
@@ -255,8 +302,16 @@ public Response deepSearch
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2754#discussion_r209153420
--- Diff:
storm-webapp/src/main/java/org/apache/storm/daemon/logviewer/utils/LogFileDownloader.java
---
@@ -18,12 +18,20 @@
package
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2754#discussion_r209153135
--- Diff:
storm-webapp/src/main/java/org/apache/storm/daemon/logviewer/utils/LogCleaner.java
---
@@ -235,7 +258,7 @@ FileFilter mkFileFilterForLogCleanup(long
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2754#discussion_r209152841
--- Diff:
storm-webapp/src/main/java/org/apache/storm/daemon/logviewer/utils/LogCleaner.java
---
@@ -253,12 +276,11 @@ private long
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2754#discussion_r209152808
--- Diff:
storm-webapp/src/main/java/org/apache/storm/daemon/logviewer/utils/LogCleaner.java
---
@@ -142,30 +154,41 @@ public void run
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2754#discussion_r209092525
--- Diff:
storm-webapp/src/main/java/org/apache/storm/daemon/logviewer/LogviewerServer.java
---
@@ -52,7 +55,7 @@
/**
* The main entry of Logviewer
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2754#discussion_r209092338
--- Diff:
storm-webapp/src/main/java/org/apache/storm/daemon/logviewer/LogviewerServer.java
---
@@ -52,7 +55,7 @@
/**
* The main entry of Logviewer
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2764#discussion_r209084882
--- Diff:
storm-server/src/main/java/org/apache/storm/daemon/nimbus/Nimbus.java ---
@@ -4652,4 +4745,192 @@ public IScheduler getForcedScheduler
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2754#discussion_r209083886
--- Diff:
storm-webapp/src/main/java/org/apache/storm/daemon/logviewer/LogviewerServer.java
---
@@ -52,7 +55,7 @@
/**
* The main entry of Logviewer
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2764#discussion_r209083160
--- Diff:
storm-server/src/main/java/org/apache/storm/daemon/nimbus/Nimbus.java ---
@@ -735,39 +756,108 @@ private static int
numUsedWorkers
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2764#discussion_r209081264
--- Diff:
storm-server/src/main/java/org/apache/storm/daemon/nimbus/Nimbus.java ---
@@ -1984,11 +2074,13 @@ private int fragmentedCpu() {
Cluster
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2754#discussion_r209072290
--- Diff:
storm-webapp/src/main/java/org/apache/storm/daemon/logviewer/utils/LogCleaner.java
---
@@ -142,30 +154,41 @@ public void run
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2754#discussion_r209046204
--- Diff:
storm-server/src/test/java/org/apache/storm/metric/StormMetricsRegistryTest.java
---
@@ -0,0 +1,108 @@
+/*
+ * Licensed to the Apache
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2754#discussion_r209078867
--- Diff:
storm-webapp/src/main/java/org/apache/storm/daemon/logviewer/handler/LogviewerLogSearchHandler.java
---
@@ -71,6 +78,10 @@
public class
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2754#discussion_r209078282
--- Diff:
storm-server/src/main/java/org/apache/storm/daemon/nimbus/Nimbus.java ---
@@ -251,10 +257,18 @@
private static final Meter
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2754#discussion_r209078742
--- Diff:
storm-webapp/src/main/java/org/apache/storm/daemon/logviewer/handler/LogviewerLogPageHandler.java
---
@@ -61,18 +63,21 @@
import
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2754#discussion_r209069385
--- Diff:
storm-webapp/src/main/java/org/apache/storm/daemon/logviewer/handler/LogviewerLogSearchHandler.java
---
@@ -388,63 +414,83 @@ private Integer
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2754#discussion_r209079357
--- Diff:
storm-webapp/src/main/java/org/apache/storm/daemon/logviewer/utils/ExceptionMeters.java
---
@@ -0,0 +1,66 @@
+/**
+ * Licensed to the Apache
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2754#discussion_r209077587
--- Diff:
storm-webapp/src/test/java/org/apache/storm/daemon/logviewer/handler/LogviewerLogSearchHandlerTest.java
---
@@ -627,6 +627,7 @@ public void
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2754#discussion_r209047681
--- Diff:
storm-webapp/src/main/java/org/apache/storm/daemon/logviewer/LogviewerServer.java
---
@@ -52,7 +55,7 @@
/**
* The main entry of Logviewer
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2754#discussion_r209079798
--- Diff:
storm-webapp/src/main/java/org/apache/storm/daemon/logviewer/webapp/LogviewerResource.java
---
@@ -62,6 +64,14 @@
"logviewe
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2754#discussion_r209077210
--- Diff:
storm-webapp/src/main/java/org/apache/storm/daemon/logviewer/webapp/LogviewerResource.java
---
@@ -255,8 +302,16 @@ public Response deepSearch
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2754#discussion_r209065332
--- Diff:
storm-webapp/src/main/java/org/apache/storm/daemon/logviewer/handler/LogviewerLogSearchHandler.java
---
@@ -71,6 +78,11 @@
public class
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2754#discussion_r209074521
--- Diff:
storm-webapp/src/main/java/org/apache/storm/daemon/logviewer/utils/LogCleaner.java
---
@@ -253,12 +276,11 @@ private long
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2754#discussion_r209076140
--- Diff:
storm-webapp/src/main/java/org/apache/storm/daemon/logviewer/utils/LogFileDownloader.java
---
@@ -18,12 +18,20 @@
package
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2754#discussion_r209075962
--- Diff:
storm-webapp/src/main/java/org/apache/storm/daemon/logviewer/utils/LogCleaner.java
---
@@ -223,8 +246,8 @@ void cleanupEmptyTopoDirectory(File dir
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2754#discussion_r209075463
--- Diff:
storm-webapp/src/main/java/org/apache/storm/daemon/logviewer/utils/LogCleaner.java
---
@@ -235,7 +258,7 @@ FileFilter mkFileFilterForLogCleanup(long
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2754#discussion_r209071814
--- Diff:
storm-webapp/src/main/java/org/apache/storm/daemon/logviewer/utils/LogCleaner.java
---
@@ -142,30 +154,41 @@ public void run
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2754#discussion_r209048376
--- Diff:
storm-webapp/src/main/java/org/apache/storm/daemon/logviewer/handler/LogviewerLogPageHandler.java
---
@@ -193,24 +198,23 @@ public Response logPage
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2764#discussion_r209064682
--- Diff:
storm-server/src/main/java/org/apache/storm/daemon/nimbus/Nimbus.java ---
@@ -1984,11 +2074,13 @@ private int fragmentedCpu() {
Cluster
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2764#discussion_r209045056
--- Diff:
storm-server/src/main/java/org/apache/storm/daemon/nimbus/Nimbus.java ---
@@ -1984,11 +2074,13 @@ private int fragmentedCpu() {
Cluster
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2764#discussion_r209044589
--- Diff:
storm-server/src/main/java/org/apache/storm/daemon/nimbus/Nimbus.java ---
@@ -1984,11 +2074,13 @@ private int fragmentedCpu() {
Cluster
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2754#discussion_r209039163
--- Diff:
storm-server/src/main/java/org/apache/storm/daemon/nimbus/Nimbus.java ---
@@ -2826,9 +2890,22 @@ public void launchServer() throws Exception
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2764#discussion_r208998511
--- Diff:
storm-server/src/main/java/org/apache/storm/daemon/nimbus/Nimbus.java ---
@@ -735,39 +756,108 @@ private static int
numUsedWorkers
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2764#discussion_r208976776
--- Diff:
storm-server/src/main/java/org/apache/storm/daemon/nimbus/Nimbus.java ---
@@ -735,39 +756,108 @@ private static int
numUsedWorkers
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2764#discussion_r208975129
--- Diff: storm-client/src/jvm/org/apache/storm/scheduler/WorkerSlot.java
---
@@ -39,6 +42,11 @@ public String getId() {
return getNodeId
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2764#discussion_r208972356
--- Diff:
storm-server/src/main/java/org/apache/storm/daemon/nimbus/Nimbus.java ---
@@ -735,39 +756,108 @@ private static int
numUsedWorkers
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2764#discussion_r208971197
--- Diff:
storm-server/src/main/java/org/apache/storm/daemon/nimbus/Nimbus.java ---
@@ -2826,9 +2915,22 @@ public void launchServer() throws Exception
Github user srdo commented on a diff in the pull request:
https://github.com/apache/storm/pull/2764#discussion_r208970512
--- Diff:
storm-server/src/main/java/org/apache/storm/daemon/nimbus/Nimbus.java ---
@@ -2826,9 +2915,22 @@ public void launchServer() throws Exception
301 - 400 of 2639 matches
Mail list logo
