Hello,
please review the doc fix
http://cr.openjdk.java.net/~azvegint/jdk/9/8166313/00/
for the issue
https://bugs.openjdk.java.net/browse/JDK-8166313
This is a simple clean up fix.
--
Thanks,
Alexander.
Hello Sergey,
Main screen on Windows and Mac OS always has (0,0) coordinates. On Linux
main screen may be shifted, e.g. if it is located to the right of
secondary one (800,0).
I think that it is feasible to unify Linux main screen behavior with Mac
OS and Windowsa and make it always located
+1
--
Thanks,
Alexander.
On 02/08/2017 07:59 PM, Sergey Bylokhov wrote:
Looks fine.
Hello,
Could you review the updated fix:
http://cr.openjdk.java.net/~alexsch/8147440/webrev.03
- InvokeFunction is used to call the _WindowDPIChange in the AWT Window on
native level.
- WWindowP
+1
Thanks,
Alexander.
On 23/01/2017 18:35, Sergey Bylokhov wrote:
Looks fine.
Webrev: http://cr.openjdk.java.net/~prr/8167228/
This fix updates libpng in JDK 9 to the current version 1.6.28.
Aside from updating to these files there are few changes to note
(1) The CHANGES file has previously
Sure, updated in place.
Thanks,
Alexander.
On 01/09/2017 06:09 PM, Sergey Bylokhov wrote:
Looks fine.
But it seems that this field can be removed?
private static boolean isGtkSupported =false;
After the fix for JDK-8150954 this field is not used.
Hello,
please review the fix
http://cr.ope
Hello,
please review the fix
http://cr.openjdk.java.net/~azvegint/jdk/9/8165705/00/
for the issue
https://bugs.openjdk.java.net/browse/JDK-8165705
Gtk is now default option for taking screenshots with Robot.
--
Thanks,
Alexander.
Looks good to me.
Thanks,
Alexander.
On 26/10/2016 16:06, Semyon Sadetsky wrote:
Please review the updated fix:
http://cr.openjdk.java.net/~ssadetsky/8167652/webrev.01/
- unnecessary AWT locks are removed
- client code calls are taken away from AWT lock blocks
- some design improvements are
nder.
On 11/29/16 4:12 AM, Alexander Zvegintsev wrote:
I don't find any modern jdk9 prefix convention for such property, so
I've named it "jdk.swing.disableForcedGlobalMenuBar"
http://cr.openjdk.java.net/~azvegint/jdk/9/8166683/02/
Thanks,
Alexander.
On 11/28/16 9:05 P
Probably something like
"globalMenuBar", etc? At least this will allow us to change
implementation in any ways on other platforms w/o changing/adding the
old/new properties.
On 15.11.16 17:39, Alexander Zvegintsev wrote:
Hi Sergey,
I've not found casting issues, but I'v
od is called by the user then appcontext should not be null,
additionally we should not cache this value in the static, so all
other code will use this cached static value.
On 15.11.16 20:38, Phil Race wrote:
+1
-phil.
On 11/15/2016 08:24 AM, Alexander Zvegintsev wrote:
Hello,
please review t
Hello,
please review the fix
http://cr.openjdk.java.net/~azvegint/jdk/9/8151189/00/
for the issue
https://bugs.openjdk.java.net/browse/JDK-8151189
--
Thanks,
Alexander.
va.net/~azvegint/jdk/9/8166683/01/
Thanks,
Alexander.
On 11/11/16 2:14 PM, Sergey Bylokhov wrote:
Hi, Alexander.
Did you run the tests on non-Aqua l&f? I assume that we can have a
places in other l&f where we try to cast the MenuBarUI to some
specific UI delegate.
On 09.11.16 16:58
Hello,
please review the fix
http://cr.openjdk.java.net/~azvegint/jdk/9/8166683/00/
for the issue
https://bugs.openjdk.java.net/browse/JDK-8166683
This fix adds support for ScreenMenuBar for L&F's other than Aqua.
With this fix it is enabled by default if apple.laf.useScreenMenuBar
property
+1
Thanks,
Alexander.
On 8/31/16 5:18 PM, Semyon Sadetsky wrote:
Hello,
Please review fix for JDK9:
bug: https://bugs.openjdk.java.net/browse/JDK-8163101
webrev: http://cr.openjdk.java.net/~ssadetsky/8163101/webrev.00/
In the 8137571 the available screen area request
Toolkit.getDefaultTool
+1
Thanks,
Alexander.
On 11/1/16 10:59 PM, Sergey Bylokhov wrote:
Looks fine.
On 05.10.16 11:45, Semyon Sadetsky wrote:
To avoid this the 8139218 solution is revisited to manage the focus
restore synchronously only if it is possible and send a single
asynchronous focus request otherwise.
Ca
Please see the updated webrev:
http://cr.openjdk.java.net/~azvegint/jdk/9/8143914/02/
Thanks,
Alexander.
On 10/11/16 5:00 PM, Alexander Zvegintsev wrote:
Hi Sergey,
Please see the updated webrev:
http://cr.openjdk.java.net/~azvegint/jdk/9/8143914/01/
As I can observe other windows such
Updated the "behavior is undefined" section:
http://cr.openjdk.java.net/~azvegint/jdk/9/8166594/01/
Thanks,
Alexander.
On 10/6/16 6:14 PM, Semyon Sadetsky wrote:
On 10/6/2016 3:38 PM, Alexander Zvegintsev wrote:
Hi Semyon,
Yes it is, Microsoft defined some set of rules for s
+1
Thanks,
Alexander.
On 10/13/16 12:12 AM, Semyon Sadetsky wrote:
Hello,
Please review fix for JDK9:
bug: https://bugs.openjdk.java.net/browse/JDK-8166897
webrev: http://cr.openjdk.java.net/~ssadetsky/8166897/webrev.00/
The setResizable() method of XDecoratedPeer class clears the frame
in
Looks good.
On 10/7/16 4:21 PM, Sergey Bylokhov wrote:
On 07.10.16 10:06, Semyon Sadetsky wrote:
Hi Sergey,
After applying the patch I found 72 usages of the Event class. Why they
are not replaced?
By the same reason why InputEvent.getModifiers() was not replaced by
InputEvent.getModifiers
Hello,
please review the fix
http://cr.openjdk.java.net/~azvegint/jdk/9/8167565/00/
for the issue
https://bugs.openjdk.java.net/browse/JDK-8167565
We trying to zoom to a zero size window(standardFrame has zero size).
standardFrame initialization happens on setMaximizedBounds call.
Dialog doe
it (I tried on 10.10 and 10.12): application is
blocked by a modal dialog, and there's no way to see it.
-yan
On 10/11/2016 05:01 PM, Alexander Zvegintsev wrote:
Actually I can't reproduce such behavior.
On 9/30/16 5:12 PM, Semyon Sadetsky wrote:
The fix looks good.
Do you know why J
Actually I can't reproduce such behavior.
On 9/30/16 5:12 PM, Semyon Sadetsky wrote:
The fix looks good.
Do you know why JDialog maximize button doesn't work? When I click on
it the maximize button the dialog disappears.
--Semyon
On 9/6/2016 5:32 PM, Alexander Zvegintsev wro
h are generated by the same peer.
Why not use windowWill/DidEnterFullScreen + windowWill/DidExitFullScreen?
Why the fix is for the Frames only, there are some limitations for
other windows, dialogs etc?
On 06.09.16 17:32, Alexander Zvegintsev wrote:
Hello,
please review the fix
http://cr.openjdk.jav
+1
--
Thanks,
Alexander.
On 07.10.2016 17:07, Sergey Bylokhov wrote:
On 07.10.16 10:28, Semyon Sadetsky wrote:
Hi Sergey,
1525 queueEmpty = false;
1526 eventDispatched = false;
1527 synchronized(waitLock) {
Shouldn't lines 1525 & 1526 be moved inside the synchronized
+1
P.S. It wasn't hard to find, but the webrev is updated at the first
revision http://cr.openjdk.java.net/~alanbur/JDK-8165232
--
Thanks,
Alexander.
On 06.10.2016 13:18, Alan Burlison wrote:
On 04/10/2016 19:34, Alan Burlison wrote:
key_syms is not freed.
So there is, thanks for the cat
anged lines to make them following the 80 chars
maximum?
--Semyon
On 06.10.2016 04:56, Alexander Zvegintsev wrote:
Hello,
please review the fix
http://cr.openjdk.java.net/~azvegint/jdk/9/8166594/00/
for the issue
https://bugs.openjdk.java.net/browse/JDK-8166594
It also fixes two issu
You are right, it it undefined behavior.
On 10/6/16 10:02 AM, Semyon Sadetsky wrote:
Hi Alexander,
Is it safe to lock the mutex on one thread and unlock it on another?
--Semyon
On 06.10.2016 06:08, Alexander Zvegintsev wrote:
Hello,
please review the fix
http://cr.openjdk.java.net
Hello,
please review the fix
http://cr.openjdk.java.net/~azvegint/jdk/9/8166942/00/
for the issue
https://bugs.openjdk.java.net/browse/JDK-8166942
SplashEventLoop() acquires the lock[0] and then trying to call
SplashRedrawWindow() which is trying execute some code on the main
thread[1]. Thu
Hello,
please review the fix
http://cr.openjdk.java.net/~azvegint/jdk/9/8166594/00/
for the issue
https://bugs.openjdk.java.net/browse/JDK-8166594
It also fixes two issues to conform the documentation:
setting value below 0 doesn't disable progress indication
switching from indeterminate t
Hello,
as I can see there is a memory leak in case when the index is greater
than or equal to num_syms:
837 KeySym *key_syms = XGetKeyboardMapping(display, keycode, 1, &num_syms);
838 if (index >= num_syms) {
839 return NoSymbol;
840 }
key_syms is not freed.
--
Thanks,
Alexander.
On 10/4/1
Looks fine.
--
Thanks,
Alexander.
On 10/03/2016 07:38 PM, Semyon Sadetsky wrote:
The fix is updated
http://cr.openjdk.java.net/~ssadetsky/8141528/webrev.01/
The root case of the issue is that in Unity the screen window size and
location are get updated several times after display mode is cha
looks good to me.
--
Thanks,
Alexander.
On 24.08.2016 22:18, Semyon Sadetsky wrote:
Hello,
Please review fix for JDK9:
bug: https://bugs.openjdk.java.net/browse/JDK-8159432
webrev: http://cr.openjdk.java.net/~ssadetsky/8159432/webrev.00/
The issue is connected to the restoring focus to the
Looks good to me.
--
Thanks,
Alexander.
On 26.04.2016 16:14, Semyon Sadetsky wrote:
On 4/26/2016 3:49 PM, Philip Race wrote:
> In applications one may need to know the reason why focus is requested
I do not mean why should apps want to *know* the cause.
I am asking why apps should be able
Looks good to me.
--
Thanks,
Alexander.
On 23.09.2016 16:15, Semyon Sadetsky wrote:
Hello,
Please review fix for JDK9:
bug: https://bugs.openjdk.java.net/browse/JDK-8165619
webrev: http://cr.openjdk.java.net/~ssadetsky/8165619/webrev.00/
If frame is created in maximized the window extent pr
Looks good to me.
On 7/17/15 7:27 PM, Semyon Sadetsky wrote:
Hello,
Please review fix for JDK9:
bug: https://bugs.openjdk.java.net/browse/JDK-8041519
webrev: http://cr.openjdk.java.net/~ssadetsky/8041519/webrev.00/
This is regression from JDK-6342381. When a modal dialog blocks drop
operatio
Looks good to me.
On 8/30/16 7:18 PM, Semyon Sadetsky wrote:
Sorry for inconvenience, but I have to update this fix once again.
http://cr.openjdk.java.net/~ssadetsky/8161910/webrev.02
I have found the main root cause of the issue. In the 8036815 I have
missed one insets_corrected = true; sta
Looks good to me.
On 5/30/16 7:39 PM, Sergey Bylokhov wrote:
Hello.
Please review the fix for jdk9.
The test DefaultPolicyChange_Swing.java has two issues:
- It uses invokeLater(), so the test usually pass before the code is
executed on the EDT, because the main thread completes before.
- T
Hello,
please review the fix
http://cr.openjdk.java.net/~azvegint/jdk/9/8140311/00/
for the issue
https://bugs.openjdk.java.net/browse/JDK-8140311
This issue is only reproducible when a window using CWarningWindow.
After window close we cancel HidingTask in CWarningWindow at java level,
howe
Hi Semyon,
I believe that this webrev should be updated to use isUnityCompiz().
--
Thanks,
Alexander.
On 07.12.2015 14:11, Semyon Sadetsky wrote:
Hello,
Please review fix for JDK9:
bug: https://bugs.openjdk.java.net/browse/JDK-8141528
webrev: http://cr.openjdk.java.net/~ssadetsky/8141528/web
/2016 04:53 PM, Sergey Bylokhov wrote:
On 31.08.16 3:27, Alexander Zvegintsev wrote:
Hi Sergey,
It could be, but actually RuntimePermission is used by eawt(sure we can
change it too, but I don't see a point)
It is still unclear to me why in most of the place we check two
permissions? Ca
06.09.16 20:56, Alexander Zvegintsev wrote:
Hello,
please review the fix
http://cr.openjdk.java.net/~azvegint/jdk/9/8153526/00/
for the issue
https://bugs.openjdk.java.net/browse/JDK-8153526
Hello,
please review the fix
http://cr.openjdk.java.net/~azvegint/jdk/9/8153526/00/
for the issue
https://bugs.openjdk.java.net/browse/JDK-8153526
--
Thanks,
Alexander.
Hello,
please review the fix
http://cr.openjdk.java.net/~azvegint/jdk/9/8143914/00/
for the issue
https://bugs.openjdk.java.net/browse/JDK-8143914
This fix adds the green FullScreen button to a resizable frames by default.
Previous maximize behavior is still accessible by holding Alt while
ified window state?
--Semyon
On 26.08.2016 05:53, Alexander Zvegintsev wrote:
Hello,
please review the fix
http://cr.openjdk.java.net/~azvegint/jdk/9/8155083/00/
for the issue
https://bugs.openjdk.java.net/browse/JDK-8155083
With current implementation we are showing initially iconified w
and/or require similar permissions.
On 30.08.16 21:58, Alexander Zvegintsev wrote:
Hello,
Please review the fix
http://cr.openjdk.java.net/~azvegint/jdk/9/8164536/00/
for the issue
https://bugs.openjdk.java.net/browse/JDK-8164536
This fix add check for canProcessApplicationEvents run
Hello,
Please review the fix
http://cr.openjdk.java.net/~azvegint/jdk/9/8164536/00/
for the issue
https://bugs.openjdk.java.net/browse/JDK-8164536
This fix add check for canProcessApplicationEvents runtime
permission(currently used by eawt) for Desktop and Taskbar classes.
--
Thanks,
Alex
Hello,
please review the fix
http://cr.openjdk.java.net/~azvegint/jdk/9/8155083/00/
for the issue
https://bugs.openjdk.java.net/browse/JDK-8155083
With current implementation we are showing initially iconified window
with SW_SHOWMINIMIZED flag, it activates the window, FlashWindowEx
doesn't
create a test for the fix?
On 16.08.16 19:20, Alexander Zvegintsev wrote:
Hello,
please review the fix
http://cr.openjdk.java.net/~azvegint/jdk/9/8162840/00/
for the issue
https://bugs.openjdk.java.net/browse/JDK-8162840
We don't call QuitHandler and using default QuitStrategy if s
Hello,
please review the fix
http://cr.openjdk.java.net/~azvegint/jdk/9/8162840/00/
for the issue
https://bugs.openjdk.java.net/browse/JDK-8162840
We don't call QuitHandler and using default QuitStrategy if sudden
termination is enabled.
--
Thanks,
Alexander.
+1
On 7/19/16 2:28 PM, Alexandr Scherbatiy wrote:
The fix looks good to me.
Thanks,
Alexandr.
On 7/15/2016 2:46 PM, Semyon Sadetsky wrote:
Hello,
Please review fix for JDK9:
bug: https://bugs.openjdk.java.net/browse/JDK-8161007
webrev: http://cr.openjdk.java.net/~ssadetsky/8161007/webrev.
Hi Semyon,
The fix looks good to me.
Thanks,
Alexander.
On 07/13/2016 01:28 PM, Semyon Sadetsky wrote:
Please review an updated version of the fix:
http://cr.openjdk.java.net/~ssadetsky/8036915/webrev.02/
The solution was completely changed. The frame insets correction
algorithm is revised
Looks good to me.
--
Thanks,
Alexander.
On 17.06.2016 11:42, Semyon Sadetsky wrote:
Hello,
Please review fix for JDK9:
bug: https://bugs.openjdk.java.net/browse/JDK-8159460
webrev: http://cr.openjdk.java.net/~ssadetsky/8159460/webrev.00/
On Unity WM_TAKE_FOCUS notification is sent to the de
Hi Semyon, please see the updated webrev
http://cr.openjdk.java.net/~azvegint/jdk/9/8153512/01/
Thanks,
Alexander.
On 07/12/2016 05:22 PM, Semyon Sadetsky wrote:
Hi Alexander,
I would use a static variable and check it once only.
--Semyon
On 12.07.2016 16:56, Alexander Zvegintsev wrote
Hello,
please review the fix
http://cr.openjdk.java.net/~azvegint/jdk/9/8153512/00/
for the issue
https://bugs.openjdk.java.net/browse/JDK-8153512
--
Thanks,
Alexander.
/8149115/webrev.03/
--Semyon
On 7/7/2016 9:57 AM, Alexandr Scherbatiy wrote:
The fix looks good to me.
Thanks,
Alexandr.
On 7/6/2016 11:46 PM, Alexander Zvegintsev wrote:
Still looks good.
--
Thanks,
Alexander.
On 06.07.2016 21:42, Semyon Sadetsky wrote:
Thanks, Alexander. Please see the updated
Still looks good.
--
Thanks,
Alexander.
On 06.07.2016 21:42, Semyon Sadetsky wrote:
Thanks, Alexander. Please see the updated webrev
http://cr.openjdk.java.net/~ssadetsky/8149115/webrev.02/
--Semyon
On 7/6/2016 9:03 PM, Alexander Zvegintsev wrote:
The fix looks good to me.
Just a minor
The fix looks good to me.
Just a minor comment: multiple NULL checks in get_schema_value could be
wrapped in CHECK_NULL_RETURN macro, e.g.:
CHECH_NULL_RETURN(fp_g_settings_schema_has_key
= dlsym(lib_handle, "g_settings_schema_has_key"), NULL);
CHECH_NULL_RETURN(fp_g
.
--
Thanks,
Alexander.
On 07/06/2016 10:25 AM, Alexandr Scherbatiy wrote:
On 7/5/2016 5:54 PM, Alexander Zvegintsev wrote:
We have two cases:
1. Underlying system(Linux) supports only numbers as parameter
(adding this check will block Linux).
2. Underlying system(OS X) supports strings
pport numbers it doesn't support strings too,
thus this exception will be thrown in this case.
On 7/5/16 5:32 PM, Alexandr Scherbatiy wrote:
On 7/5/2016 5:04 PM, Alexander Zvegintsev wrote:
Hello,
please review the fix
http://cr.openjdk.java.net/~azvegint/jdk/9/8159374/00
for the i
Hello,
please review the fix
http://cr.openjdk.java.net/~azvegint/jdk/9/8159374/00
for the issue
https://bugs.openjdk.java.net/browse/JDK-8159374
--
--
Thanks,
Alexander.
Hello,
please review the fix
http://cr.openjdk.java.net/~azvegint/jdk/9/8155515/00
for the issue
https://bugs.openjdk.java.net/browse/JDK-8155515
--
--
Thanks,
Alexander.
Hello,
please review the fix
http://cr.openjdk.java.net/~azvegint/jdk/9/8156212/00
for the issue
https://bugs.openjdk.java.net/browse/JDK-8156212
--
--
Thanks,
Alexander.
Hello,
please review the fix
https://bugs.openjdk.java.net/browse/JDK-8155691
for the issue
http://cr.openjdk.java.net/~azvegint/jdk/9/8155691/00/
--
--
Thanks,
Alexander.
Hello,
please review the fix
https://bugs.openjdk.java.net/browse/JDK-8155690
for the issue
http://cr.openjdk.java.net/~azvegint/jdk/9/8155690/00/
--
--
Thanks,
Alexander.
Vote: yes
--
Thanks,
Alexander.
On 10.06.2016 18:39, Artem Ananiev wrote:
Hi, AWT team,
I hereby nominate Sergey Bylokhov (OpenJDK user name: serb) to AWT
Group Lead [1].
Sergey is a member of Java Client group at Oracle. He has been one of
the most active contributors to AWT (and other Ja
Looks fine to me.
Thanks,
Alexander.
On 31/05/16 17:29, Sergey Bylokhov wrote:
Hi, Mario.
Thanks for your contribution! there is tiny typo in the native:
isGtkSupported should be useGtk. It will be good if someone run jprt
job to confirm that the build is ok, since make file was changed.
On
Looks fine to me too.
Thanks,
Alexander.
On 05/17/2016 06:36 PM, Anton Tarasov wrote:
Would anyone else please review the fix?
Thanks
Anton.
On 5/5/2016 12:45 PM, Sergey Bylokhov wrote:
Looks fine.
On 05.05.16 10:50, Anton Tarasov wrote:
Hello,
Please, review a simple fix:
webrev: http:
Fixed: http://cr.openjdk.java.net/~azvegint/jdk/9/8143227/09/
--
Thanks,
Alexander.
On 03/05/2016 04:10 AM, Mandy Chung wrote:
On Mar 4, 2016, at 11:07 AM, Phil Race wrote:
Approved.
-phil.
One comment on something you can't do anything about *yet*, is
that adding a new API package right in
permission for the file as well.
At the end it is an interesting question: what permissions are needed
to delete the file.
On 21.02.16 14:38, Alexander Zvegintsev wrote:
Hi Phil,
please see updated the webrev here
http://cr.openjdk.java.net/~azvegint/jdk/9/8143227/08/
and comments inline
On
s it never used to
return null. Now it can. So do we really want to add more places
that we need to fix ? In other words I don't think the fix is going
to be to revert to it not returning null, so you are going to have
to deal with it directly here.
-phil.
On 2/21/16, 5:08 PM, Alexander Zvegin
+1
--
Thanks,
Alexander.
On 10.02.2016 14:06, Sergey Bylokhov wrote:
Looks fine.
On 01.10.15 21:27, Semyon Sadetsky wrote:
The fix is amended : plese review the new version
http://cr.openjdk.java.net/~ssadetsky/8021961/webrev.01/
It is taken into account that the transientFor chain may be lon
Hi Sergey,
Yes, it is, anyway I can see only a part of the fix in this webrev.
--
Thanks,
Alexander.
On 26.02.2016 16:57, Sergey Bylokhov wrote:
Hi, Alexander.
It seems that this request is withdrawn?
On 24.11.14 18:07, Alexander Zvegintsev wrote:
Hello,
please review the fix
http
please give an example.
It is another Mac specific feature, it does exactly how it described.
You can have no windows(not even created), no system menu bar and some
running thread, AppReopenedListener
will be called on click in dock icon or on double click on the
application executable.
rmissions ? You do need permission to
exit the VM, so should you be able to set a QuitStrategy if you don't have
such permission ??
More later ..
-phil.
On 01/21/2016 11:16 PM, Alexander Zvegintsev wrote:
Hi Semyon,
I am not sure about flexibility, but providing additional info for a
user ses
--Semyon
On 1/22/2016 10:16 AM, Alexander Zvegintsev wrote:
Hi Semyon,
I am not sure about flexibility, but providing additional info for a
user session change could be useful
http://cr.openjdk.java.net/~azvegint/jdk/9/8143227/05/
(changed awt_Toolkit.cpp, AppEvent.java, UserSessi
.
Also this may add flexibility that allows to support new features in
the future.
--Semyon
On 1/17/2016 11:55 PM, Alexander Zvegintsev wrote:
Hi Semyon,
Is it possible to use WM_QUERYENDSESSION for
Action.APP_SUDDEN_TERMINATION?
Sure, so please see updated webrev:
http://cr.openjdk.java.net
, WDesktopPeer.java:
added SuddenTerminaton support for Windows
--
Thanks,
Alexander.
On 01/15/2016 04:14 PM, Semyon Sadetsky wrote:
Hi,
On 1/15/2016 12:39 PM, Alexander Zvegintsev wrote:
Hi Semyon,
Yes, it is just LOCK/UNLOCK for now, because it is the most common
scenario of desktop usage
CONNECT 0x4
#define WTS_SESSION_LOGON 0x5
#define WTS_SESSION_LOGOFF 0x6
#define WTS_SESSION_LOCK 0x7
#define WTS_SESSION_REMOTE_CONTROL
some of them seems to me more suitable to be chosen as the session
act/deact event. Could you comment that for me?
--Semyon
On 11/24/2015 6:02 PM, Alexander Zvegintsev wr
Please review the updated fix:
http://cr.openjdk.java.net/~azvegint/jdk/9/8143227/03/
removed fullscreen related code (moved to JDK-8143914 [0])
fix serialization in AppEvent
[0] https://bugs.openjdk.java.net/browse/JDK-8143914
Thanks,
Alexander.
On 11/21/2015 03:33 AM, Alexander Zvegintsev
p://cr.openjdk.java.net/~azvegint/jdk/9/8143227/00/src/java.desktop/share/classes/java/awt/desktop/QuitStrategy.java.html
* The strategy use to -> The strategy used to
http://cr.openjdk.java.net/~azvegint/jdk/9/8143227/00/src/java.desktop/share/classes/java/awt/desktop/ScreenSleepListener.java.ht
Hi Phil,
Can someone explain why this is needed given the existing support of
GraphicsDevice.setFullScreenWindow(Window) ?
GraphicsDevice.setFullScreenWindow is used for an exclusive full screen
mode.
Mac OS has another option to create a virtual desktop with provided
window in it.
You can
amp;target=quicklilst-static-entry.png
--
Thanks,
Alexander.
On 11/20/2015 05:36 PM, Yuri Nesterenko wrote:
Hi Alexander,
On 11/19/2015 06:23 PM, Alexander Zvegintsev wrote:
Hi Yuri,
Nice catch! Just tested on Ubuntu 14.04.3, it does not have libunity.so
symlink to libuity.so.9.
so we should
p/share/classes/java/awt/desktop/QuitStrategy.java.html
* The strategy use to -> The strategy used to
http://cr.openjdk.java.net/~azvegint/jdk/9/8143227/00/src/java.desktop/share/classes/java/awt/desktop/ScreenSleepListener.java.html
* have awoke -> have awoken
http://cr.openjdk.java
/~azvegint/jdk/9/8143227/00/src/java.desktop/macosx/classes/sun/lwawt/macosx/CTaskbarPeer.java.html
Thanks,
Alexander.
On 11/19/2015 01:17 AM, Michael Hall wrote:
On Nov 18, 2015, at 1:12 AM, Alexander Zvegintsev
<mailto:alexander.zvegint...@oracle.com>> wrote:
This fix provides publi
t I don't see
BROWSE supported.
Thanks,
-yan
On 11/18/2015 05:01 PM, Alexander Zvegintsev wrote:
Hi Alexander,
resending the same webrev under the new ID
https://bugs.openjdk.java.net/browse/JDK-8143227
http://cr.openjdk.java.net/~azvegint/jdk/9/8143227/00/
The approach is pretty the same as
/to/jdk9/java -Djava.desktop.appName=SomeApp.desktop Snip
Terminal=false
Type=Application
After that you can run it from dash with specified name.
--
Thanks,
Alexander.
On 11/18/2015 02:52 PM, Alexander Scherbatiy wrote:
On 11/18/2015 10:12 AM, Alexander Zvegintsev wrote:
Hello
please review
Hello
please review the fix
http://cr.openjdk.java.net/~azvegint/jdk/9/8048731/
for
https://bugs.openjdk.java.net/browse/JDK-8048731
This fix provides public support Mac OS X
features(com.apple.{eawt,eio}), adds support for various desktop
features such as progress indication, dock overlays, d
: Alexander Scherbatiy
Sent: 11 November 2015 19:57
To: Rajeev Chamyal
Cc: Sergey Bylokhov; Alexander Zvegintsev; awt-dev@openjdk.java.net
Subject: Re: JDK9 Review Request for 8037575: JFrame on Windows
doesn't animate when setting ICONIFIED state
The fix looks good to me.
T
The fix looks good to me.
Thanks,
Alexander.
On 10/28/2015 03:01 PM, Semyon Sadetsky wrote:
On 10/14/2015 3:50 PM, Alexander Zvegintsev wrote:
Hi Semyon,
As I can see there are a lot similar checks in tests for OEL7,
ideally it should be checked against gnome-shell(probably from
Looks good to me.
Thanks,
Alexander.
On 10/06/2015 09:15 AM, Semyon Sadetsky wrote:
Sorry. I meant it is not guaranteed to be sent by every WM.
On 10/6/2015 9:03 AM, Semyon Sadetsky wrote:
In is extended event. In does not guaranteed to be sent by any WM.
On 10/5/2015 6:12 PM, Sergey Bylokh
looks fine to me.
--
Thanks,
Alexander.
On 10/21/2015 07:32 PM, Sergey Bylokhov wrote:
Hello.
Please review the fix for jdk9.
The test emulate implementation of two applets inside one vm. It has
two threads in two different threads groups, for one of them it
creates an appcontext, and the te
Hi Semyon,
As I can see there are a lot similar checks in tests for OEL7, ideally
it should be checked against gnome-shell(probably from DESKTOP_SESSION
env variable, or check for running gnome-shell process), but I am OK
with the current check. Could you please extract this check to some
he
The fix looks good to me.
Thanks,
Alexander.
On 09/29/2015 08:51 PM, Semyon Sadetsky wrote:
Hello,
Please review fix for JDK9:
bug: https://bugs.openjdk.java.net/browse/JDK-8022334
webrev: http://cr.openjdk.java.net/~ssadetsky/8022334/webrev.00/
The Unity WM cannot switch top-level windows
Looks fine to me too.
Thanks,
Alexander.
On 09/28/2015 02:11 PM, Ambarish Rapte wrote:
Hi Sergey,
Thanks for the review.
Executed regression tests for TextArea, TextField & also other tests
which use any of the TextArea, TextField or TextComponent.
=> There are NO fail
Hi Anthony,
Thank you for your feedback!
It seems correct and appropriate to me, so I'll incorporate your
suggestions into the JEP.
Thanks,
Alexander.
On 09/27/2015 09:42 AM, Anthony Vanelverdinghe wrote:
Hi
I have a few questions/comments about the proposed API:
- why not add a class java
Looks good to me.
Thanks,
Alexander.
On 09/24/2015 10:55 PM, Sergey Bylokhov wrote:
Hello.
Please review the fix for jdk9.
The test for JDK-8130390 (which fixed an unspecified
ClassCastException) doesn't take into account that the
createBufferStrategy() method can throw the specified
excep
+1
--
Thanks,
Alexander.
On 15.09.2015 14:31, Sergey Bylokhov wrote:
Looks fine.
14.09.2015 22:12, Daniil Titov wrote:
Hello,
Please review java.desktop part of the changes for jdk9 that remove
the support for serialized applets. Support for serialized applets
was added in JDK 1.1 to allow
looks fine
Thanks,
Alexander.
On 09/11/2015 01:09 PM, pooja chopra wrote:
Hello,
Please review a fix for issue :-
8136354 [TEST_BUG]Test java/awt/image/RescaleOp/RescaleAlphaTest.java
with Bad action for script
Test bug fix.
https://bugs.openjdk.java.net/browse/JDK-8136354
The webrev is :
+1
Thanks,
Alexander.
On 09/04/2015 05:43 PM, Alexander Scherbatiy wrote:
The fix looks good to me.
Thanks,
Alexandr.
On 9/3/2015 4:21 PM, Semyon Sadetsky wrote:
Alexanders? Any questions?
On 8/5/2015 3:11 PM, Semyon Sadetsky wrote:
Hello,
Please review fix for JDK9:
bug: https:/
+1
--
Thanks,
Alexander.
On 01.09.2015 16:39, Sergey Bylokhov wrote:
Looks fine to me.
On 01.09.15 13:49, Alexander Scherbatiy wrote:
Hello,
Could you review the fix:
bug: https://bugs.openjdk.java.net/browse/JDK-8133453
webrev: http://cr.openjdk.java.net/~alexsch/8133453/webrev.00
101 - 200 of 421 matches
Mail list logo
