On Fri, 21 Jul 2023 03:35:57 GMT, Sergey Bylokhov wrote:
>> Renjith Kannath Pariyangad has updated the pull request incrementally with
>> one additional commit since the last revision:
>>
>> Disabled OLE1 from CoInit
>
> Marked as reviewed by serb (Reviewer).
> @mrserb Could you take a look
On Wed, 30 Aug 2023 14:20:41 GMT, ScientificWare wrote:
>> This is referenced in Java Bug Database as
>> - [JDK-8314731 : Adds support for the alt attribute in the image type input
>> HTML tag.](https://bugs.java.com/bugdatabase/view_bug?bug_id=8314731)
>>
>> This is tracked in JBS as
>> -
On Fri, 13 Oct 2023 15:19:53 GMT, Daniel Jeliński wrote:
>> Please review this patch that removes a number of unused exports from
>> java.desktop native libraries.
>>
>> In most cases I removed JNIEXPORT from methods and variables that are only
>> used within a single shared library. Other
On Wed, 30 Aug 2023 14:20:41 GMT, ScientificWare wrote:
>> This is referenced in Java Bug Database as
>> - [JDK-8314731 : Adds support for the alt attribute in the image type input
>> HTML tag.](https://bugs.java.com/bugdatabase/view_bug?bug_id=8314731)
>>
>> This is tracked in JBS as
>> -
On Fri, 29 Sep 2023 12:12:23 GMT, Alexey Ivanov wrote:
> You should probably pass `altAtt` as the `description` parameter, yet I'm
> unsure if it's ever used in this context.
As I say, I'm unsure if it's used… The description could be exposed to
Accessibility API. By default, `ImageIcon
On Fri, 29 Sep 2023 12:41:10 GMT, Alexey Ivanov wrote:
>> ScientificWare has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Update src/java.desktop/share/classes/javax/swing/text/html/FormView.java
>>
On Fri, 20 Oct 2023 10:13:40 GMT, Dmitry Markov wrote:
> It would be good to ensure that f is not NULL before dispose.
I know we're doing it all the time… But is it really relevant?
This has been bothering me for a while now… Let's clear things up.
If the frame is `null`, something has gone
On Fri, 20 Oct 2023 06:59:17 GMT, Renjith Kannath Pariyangad
wrote:
> Hi Reviewers,
>
> I have added additional CountDownLatch for making sure button is visible
> before proceeding,(observe this was one of the key reason for failure) so
> this helps to improve test case stability. Modified
On Wed, 18 Oct 2023 13:21:17 GMT, Alexey Ivanov wrote:
> Update ProblemList entry for java/awt/PopupMenu/PopupMenuLocation.java to
> [JDK-8259913](https://bugs.openjdk.org/browse/JDK-8259913) which is a
> specific bug for AWT menus in High DPI environment.
This pull request has
On Fri, 13 Oct 2023 20:21:04 GMT, Alexey Ivanov wrote:
> Adds additional test cases to
> `javax/swing/text/html/CSS/CSSAttributeEqualityBug.java`.
>
> Currently, CSS parser in Java allows space between the number and the unit or
> percent. This is what the additional te
Update ProblemList entry for java/awt/PopupMenu/PopupMenuLocation.java to
[JDK-8259913](https://bugs.openjdk.org/browse/JDK-8259913) which is a specific
bug for AWT menus in High DPI environment.
-
Commit messages:
- 8318448: Link PopupMenu/PopupMenuLocation.java failure to
On Wed, 16 Aug 2023 23:46:09 GMT, Harshitha Onkar wrote:
> Oh, I didn't notice that `setAutoWaitForIdle()` was not used the first time.
> I have changed it. I think adding a small amount of delay after
> `makeToolbarFloat()` is good in addition to `setAutoWaitForIdle()` to
> stabilize the
On Tue, 17 Oct 2023 11:42:40 GMT, Abhishek Kumar wrote:
> Since[ JDK-8317970](https://bugs.openjdk.org/browse/JDK-8317970) is
> integrated to make macOS 11 the minimum version to build jdk, the 10.13 check
> is not needed and can be removed from TabButtonAccessibility.m file.
Marked as
On Mon, 16 Oct 2023 07:43:06 GMT, Prasanta Sadhukhan
wrote:
> Since [ JDK-8317970](https://bugs.openjdk.org/browse/JDK-8317970) in
> integrated to make macOS 11 the minimum version to build jdk, the 10.14 check
> added in [JDK-8284166](https://bugs.openjdk.org/browse/JDK-8284166) is not
>
On Wed, 11 Oct 2023 09:27:30 GMT, Jan Kratochvil
wrote:
>> `--with-toolchain-type=clang` fails the compilation for me with
>> `clang-16.0.6-3.fc38.x86_64`
>>
>> While the warnings can be disabled I find better to just fix them. The GTK
>> prototypes in JDK reported by clang are either
On Fri, 6 Oct 2023 03:24:36 GMT, Renjith Kannath Pariyangad
wrote:
> Hi Reviewers,
> I have added screen shot capturing facility to the test case and that will
> help for debugging in case of failure. Please review and let me know your
> suggestions or comments if any.
>
> Regards,
>
Adds additional test cases to
`javax/swing/text/html/CSS/CSSAttributeEqualityBug.java`.
Currently, CSS parser in Java allows space between the number and the unit or
percent. This is what the additional test cases verify.
There's also one additional case for `border-width: medium`.
On Fri, 13 Oct 2023 15:07:30 GMT, Renjith Kannath Pariyangad
wrote:
> Hi Revivers,
>
> Part of stability improvement for the test case **WheelModifier.java** I have
> moved _getLocationOnScreen()_ and _getSize()_ into EDT, part of warning
> removal updated _BUTTON1_MASK_ with
On Fri, 13 Oct 2023 15:02:10 GMT, Daniel Jeliński wrote:
> …will file a follow-up PR once this one is merged
You can submit it right away, so that we'll not forget about it.
-
PR Review Comment: https://git.openjdk.org/jdk/pull/13261#discussion_r1358385429
On Thu, 12 Oct 2023 22:01:22 GMT, Damon Nguyen wrote:
>> test/jdk/java/awt/dnd/RejectDragDropActionTest.java line 103:
>>
>>> 101: !p.equals(endPoint) && !incorrectActionDetected;
>>> 102: p.translate(sign(endPoint.x - p.x),
>>> 103:
On Fri, 13 Oct 2023 14:38:59 GMT, Daniel Jeliński wrote:
> Should I move the cleanup of Color as well?
Removing `colorValueID` could be left here, I think: it removes an exported
symbol which is no longer used.
In addition to it, it makes `Java_java_awt_Color_initIDs` empty.
-
On Fri, 13 Oct 2023 07:50:12 GMT, Daniel Jeliński wrote:
>> ~Good point. I only checked the Linux exports/imports, will check the
>> Windows-specific exports now.~
>
> Wait a sec, these symbols are removed from the export list in this PR. Are
> you saying that you still see them?
I saw these
On Fri, 13 Oct 2023 11:17:31 GMT, Daniel Jeliński wrote:
> Found and removed a few more initIDs methods that were empty on all platforms.
It could be a better idea to move this clean up to a separate bugid with
appropriate title. After all, removing empty initIDs affects Java sources as
well.
On Thu, 12 Oct 2023 17:12:05 GMT, Alexey Ivanov wrote:
> **Cleanup**
>
> A trivial modification which removes `class="centered"` from one of the
> `` elements. It's a remnant from a previous version of the image.
>
> Classes aren't used, all `` elements are cent
On Thu, 12 Oct 2023 20:07:18 GMT, Damon Nguyen wrote:
>> This test intermittently fails by timeout. Increasing the timeout alone
>> doesn't solve the failure as it still fails in about 400 runs. Adding
>> another delay and reducing the delay amount to 1000ms. Now, the test passes
>> after 2
On Thu, 12 Oct 2023 17:54:07 GMT, Alexander Zuev wrote:
> As a workaround changing the method that filters out valid resolutions to not
> allow resolutions unsupported by Apple m1/m2 chips to be reported back to
> Java side.
>
> Also removing test from problem list as it should pass again
**Cleanup**
A trivial modification which removes `class="centered"` from one of the
`` elements. It's a remnant from a previous version of the image.
Classes aren't used, all `` elements are centered.
-
Commit messages:
- 8318028: Remove unused class="centered" from
On Thu, 5 Oct 2023 17:43:21 GMT, Damon Nguyen wrote:
> However, since the accumulation of the changes doesn't seem to cause any
> failures anymore, should I just follow through with this PR? I can raise
> another bug if needed for this intermittent failure. Can't identify what's
> causing
On Thu, 5 Oct 2023 16:20:08 GMT, Damon Nguyen wrote:
>> This test intermittently fails by timeout. Increasing the timeout alone
>> doesn't solve the failure as it still fails in about 400 runs. Adding
>> another delay and reducing the delay amount to 1000ms. Now, the test passes
>> after 2
On Wed, 11 Oct 2023 17:48:28 GMT, Daniel Jeliński wrote:
>> src/java.desktop/share/native/libawt/java2d/SurfaceData.h line 557:
>>
>>> 555: */
>>> 556: SurfaceDataOps *
>>> 557: SurfaceData_GetOpsNoSetup(JNIEnv *env, jobject sData);
>>
>> ~~It seems to me none of the functions in
On Wed, 11 Oct 2023 17:54:31 GMT, Daniel Jeliński wrote:
> `img_makePalette` is in libawt.so, `X11Color.c` is in libawt_xawt.so
I see. I didn't check Linux builds, but I should've.
-
PR Comment: https://git.openjdk.org/jdk/pull/13261#issuecomment-1759299249
On Tue, 1 Aug 2023 04:16:30 GMT, Renjith Kannath Pariyangad
wrote:
> Did further investigation on JDK-7116070 (name truncation issue) and found
> its [MS
> structure](https://learn.microsoft.com/en-us/windows-hardware/drivers/audio/extended-capabilities-from-a-wdm-audio-driver)
> limitation,
On Fri, 21 Jul 2023 03:35:57 GMT, Sergey Bylokhov wrote:
>> Renjith Kannath Pariyangad has updated the pull request incrementally with
>> one additional commit since the last revision:
>>
>> Disabled OLE1 from CoInit
>
> Marked as reviewed by serb (Reviewer).
@mrserb Could you take a look
On Thu, 12 Oct 2023 06:40:13 GMT, Renjith Kannath Pariyangad
wrote:
>> Hi Reviewers,
>>
>> Observations :
>> 1. Without com initialize if we access Mixer for recording, library loaded
>> invalid GUID and clipped description in windows(ID not found in registry).
>> With com initialization
On Thu, 5 Oct 2023 16:29:26 GMT, Daniel Jeliński wrote:
>> Please review this patch that removes a number of unused exports from
>> java.desktop native libraries.
>>
>> In most cases I removed JNIEXPORT from methods and variables that are only
>> used within a single shared library. Other
On Thu, 5 Oct 2023 16:29:26 GMT, Daniel Jeliński wrote:
>> Please review this patch that removes a number of unused exports from
>> java.desktop native libraries.
>>
>> In most cases I removed JNIEXPORT from methods and variables that are only
>> used within a single shared library. Other
On Wed, 11 Oct 2023 04:54:54 GMT, ANUPAM DEV wrote:
> Hello,
>
> I have fixed the typo in the comment for the method
> JPopupMenu.setInvoker(Component invoker)
>
> before: Sets the invoker of this popup menu -- the component in which the
> popup menu menu is to be displayed.
> after: Sets
On Tue, 10 Oct 2023 15:11:24 GMT, Andy Goryachev wrote:
>>> would it make more sense to use a switch statement instead of a static map?
>>
>> I believe this was discussed somewhere… Looks like map provides better
>> performance compared to `switch` statement. Fetching an element from a map
>>
On Tue, 10 Oct 2023 14:44:04 GMT, Andy Goryachev wrote:
> would it make more sense to use a switch statement instead of a static map?
I believe this was discussed somewhere… Looks like map provides better
performance compared to `switch` statement. Fetching an element from a map
gives a
On Mon, 9 Oct 2023 23:24:35 GMT, ScientificWare wrote:
>> This is referenced in Java Bug Database as
>> - [JDK-8292276 : Add named colors from CSS Color Module Level
>> 4](https://bugs.java.com/bugdatabase/view_bug?bug_id=8292276)
>>
>> This is tracked in JBS as
>> - [JDK-8292276 : Add named
On Tue, 10 Oct 2023 11:32:41 GMT, Ravi Gupta wrote:
>> Write a test to check textArea triggers MouseEntered/MouseExited events
>> properly
>>
>> MouseEntered should be triggered only when the mouse enters the component
>> and MouseExited should be triggered when the mouse goes out of the
On Mon, 9 Oct 2023 03:20:17 GMT, Renjith Kannath Pariyangad
wrote:
>> Hi Reviewers,
>>
>> Observations :
>> 1. Without com initialize if we access Mixer for recording, library loaded
>> invalid GUID and clipped description in windows(ID not found in registry).
>> With com initialization
On Sun, 8 Oct 2023 22:15:59 GMT, Christoph Langer wrote:
> This test is failing on several Linux configurations (SLES 15), so it should
> be excluded.
Looks good to me.
-
Marked as reviewed by aivanov (Reviewer).
PR Review:
On Mon, 9 Oct 2023 15:01:41 GMT, Jan Kratochvil wrote:
>> `--with-toolchain-type=clang` fails the compilation for me with
>> `clang-16.0.6-3.fc38.x86_64`
>>
>> While the warnings can be disabled I find better to just fix them. The GTK
>> prototypes in JDK reported by clang are either missing
On Mon, 9 Oct 2023 05:07:13 GMT, Ravi Gupta wrote:
>> Write a test to check textArea triggers MouseEntered/MouseExited events
>> properly
>>
>> MouseEntered should be triggered only when the mouse enters the component
>> and MouseExited should be triggered when the mouse goes out of the
On Wed, 4 Oct 2023 17:23:51 GMT, Harshitha Onkar wrote:
> Is there source code fix or PR associated with this test.
I couldn't see the answer to this question. I guess the fix was done long time
ago in JDK-4454304. Now, the test gets open-sourced.
-
PR Comment:
On Thu, 5 Oct 2023 08:13:53 GMT, Ravi Gupta wrote:
>> Write a test to check textArea triggers MouseEntered/MouseExited events
>> properly
>>
>> MouseEntered should be triggered only when the mouse enters the component
>> and MouseExited should be triggered when the mouse goes out of the
On Fri, 6 Oct 2023 11:17:01 GMT, Renjith Kannath Pariyangad
wrote:
>> Hi Reviewers,
>>
>> Observations :
>> 1. Without com initialize if we access Mixer for recording, library loaded
>> invalid GUID and clipped description in windows(ID not found in registry).
>> With com initialization
On Thu, 5 Oct 2023 15:48:03 GMT, Damon Nguyen wrote:
> I can't reproduce this on my machine
Me neither.
> Does removing the listeners work for you?
I haven't run the test in the CI with listeners removed; I haven't tested it in
any way at all. I'm just looking for explanation why the JVM
On Thu, 5 Oct 2023 15:29:15 GMT, Prasanta Sadhukhan
wrote:
> If you concede they are different, then what change you want me to do? If you
> say center is safer and then still use menuLocation coordinate which is
> obtained via getLocationScreen, it's confusing..
I see no big difference in
On Thu, 5 Oct 2023 15:15:24 GMT, Prasanta Sadhukhan
wrote:
> But 1st case uses center coordinates via Util.getCenterPoint whereas 2nd case
> uses getLocationOnScreen+10 so it's not exactly the same.
Yes, they're somewhat different. Yet the centre is safer (what if
`getLocationOnScreen+10` is
On Mon, 31 Jul 2023 10:14:45 GMT, Alexey Ivanov wrote:
> A trivial change: ‘it self’ → ‘itself’.
>
> In addition to it, I added a comma after ‘Similarly’ where it starts a
> sentence.
This pull request has now been integrated.
Changeset: a1c9587c
Author:Alexey Ivanov
URL:
On Tue, 3 Oct 2023 00:17:32 GMT, Harshitha Onkar wrote:
>> Prasanta Sadhukhan has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Add setAutoWaitForIdle
>
> LGTM
Yesterday after talking to Harshitha @honkar-jdk, I also learned, there's an
On Wed, 4 Oct 2023 13:58:59 GMT, Prasanta Sadhukhan
wrote:
> So, I think pt 7 "close menu" is happening before pt 8 "drag mouse"Yes,
> "point" is being reused but I guess it's ok
It is okay, yet I think it would be clearer and cleaner if the flow was like
this:
1. Complete the first
On Wed, 4 Oct 2023 05:37:10 GMT, Renjith Kannath Pariyangad
wrote:
>> Hi Reviewers,
>>
>> Observations :
>> 1. Without com initialize if we access Mixer for recording, library loaded
>> invalid GUID and clipped description in windows(ID not found in registry).
>> With com initialization
On Wed, 7 Jun 2023 17:22:23 GMT, Jeremy wrote:
> What is the fate of auto-closed PRs?
@mickleness You can reopen the PR with the
[`/open`](https://wiki.openjdk.org/display/SKARA/Pull+Request+Commands#PullRequestCommands-/open)
command.
> That is: as long as I don't delete this branch in my
On Wed, 4 Oct 2023 05:37:10 GMT, Renjith Kannath Pariyangad
wrote:
>> Hi Reviewers,
>>
>> Observations :
>> 1. Without com initialize if we access Mixer for recording, library loaded
>> invalid GUID and clipped description in windows(ID not found in registry).
>> With com initialization
On Wed, 4 Oct 2023 17:45:25 GMT, Damon Nguyen wrote:
>> This test intermittently fails by timeout. Increasing the timeout alone
>> doesn't solve the failure as it still fails in about 400 runs. Adding
>> another delay and reducing the delay amount to 1000ms. Now, the test passes
>> after 2
On Tue, 3 Oct 2023 22:36:15 GMT, Damon Nguyen wrote:
>> test/jdk/java/awt/dnd/RejectDragDropActionTest.java line 91:
>>
>>> 89: robot.setAutoWaitForIdle(true);
>>> 90: robot.waitForIdle();
>>> 91: robot.delay(DELAY_TIME);
>>
>> To reduce the initial delay,
On Tue, 3 Oct 2023 22:49:17 GMT, Damon Nguyen wrote:
>> test/jdk/java/awt/dnd/RejectDragDropActionTest.java line 88:
>>
>>> 86:
>>> 87: try {
>>> 88: Robot robot = new Robot();
>>
>> To reduce the initial delay, you may override `Frame.paint` and `countDown`
>> a latch
On Tue, 3 Oct 2023 22:41:37 GMT, Damon Nguyen wrote:
>> This test intermittently fails by timeout. Increasing the timeout alone
>> doesn't solve the failure as it still fails in about 400 runs. Adding
>> another delay and reducing the delay amount to 1000ms. Now, the test passes
>> after 2
On Tue, 3 Oct 2023 21:57:42 GMT, Alisen Chung wrote:
>> Opening closed tests:
>> 12 javax/swing/ToolTipManager/5078214/bug5078214.java
>> 13 javax/swing/plaf/basic/BasicMenuItemUI/4239714/bug4239714.java
>> 14 javax/swing/plaf/basic/BasicMenuUI/4244616/bug4244616.java
>> 15
On Wed, 4 Oct 2023 09:30:55 GMT, Prasanta Sadhukhan
wrote:
>> Test was run without waiting for UI to be made visible leading to
>> IllegalComponentStateException.
>> Used robot.delay consistent with other headful tests to made the test wait
>> after UI is created and shown.
>>
>> Test passed
On Wed, 4 Oct 2023 08:32:31 GMT, Prasanta Sadhukhan
wrote:
>> Can you please tell which system it is not working?
>> I guess harshita and vitaly tested on macos14 and it worked for them and I
>> tested on other mac13,windows10 locally where it also worked, as well as in
>> mach5 systems,
On Fri, 29 Sep 2023 05:05:07 GMT, Prasanta Sadhukhan
wrote:
>> Test was run without waiting for UI to be made visible leading to
>> IllegalComponentStateException.
>> Used robot.delay consistent with other headful tests to made the test wait
>> after UI is created and shown.
>>
>> Test
On Tue, 3 Oct 2023 18:08:16 GMT, Harshitha Onkar wrote:
>> Sure, I just added it. Previously when I initially worked on this test,
>> setAutoWaitForIdle had a weird interaction with how the test was setup.
>> Since the test used a delay of 50ms between each of the movements when
>> dragging
On Tue, 3 Oct 2023 18:09:03 GMT, Damon Nguyen wrote:
>> This test intermittently fails by timeout. Increasing the timeout alone
>> doesn't solve the failure as it still fails in about 400 runs. Adding
>> another delay and reducing the delay amount to 1000ms. Now, the test passes
>> after 2
On Mon, 2 Oct 2023 22:14:50 GMT, Damon Nguyen wrote:
> @alisenchung Looks like `Util.blockTillDisplayed(mainFrame)` has been removed
> which was causing compilation issues earlier. Now the updated test works
> correctly.
Ah, the test didn't compile earlier…
-
PR Comment:
On Tue, 3 Oct 2023 02:44:59 GMT, Alisen Chung wrote:
>> Opening closed tests:
>> 12 javax/swing/ToolTipManager/5078214/bug5078214.java
>> 13 javax/swing/plaf/basic/BasicMenuItemUI/4239714/bug4239714.java
>> 14 javax/swing/plaf/basic/BasicMenuUI/4244616/bug4244616.java
>> 15
On Fri, 29 Sep 2023 19:27:33 GMT, Alexey Ivanov wrote:
>> Alisen Chung has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> fixed skippedexception, fixed comment
>
> test/jdk/javax/swing/ToolTipManager/bug
On Tue, 3 Oct 2023 02:44:59 GMT, Alisen Chung wrote:
>> Opening closed tests:
>> 12 javax/swing/ToolTipManager/5078214/bug5078214.java
>> 13 javax/swing/plaf/basic/BasicMenuItemUI/4239714/bug4239714.java
>> 14 javax/swing/plaf/basic/BasicMenuUI/4244616/bug4244616.java
>> 15
On Tue, 12 Sep 2023 12:34:12 GMT, Christopher Sahnwaldt
wrote:
>> In
>> https://github.com/openjdk/jdk/commit/b8af3d50192f8bc98d83f8102f0fd1989f302e32
>> the weak reference was accidentally changed from a field to a local
>> variable, which means that the PropertyChangeListener keeps a
On Fri, 29 Sep 2023 19:31:08 GMT, Alisen Chung wrote:
>> Opening closed tests:
>> 12 javax/swing/ToolTipManager/5078214/bug5078214.java
>> 13 javax/swing/plaf/basic/BasicMenuItemUI/4239714/bug4239714.java
>> 14 javax/swing/plaf/basic/BasicMenuUI/4244616/bug4244616.java
>> 15
On Wed, 30 Aug 2023 14:20:41 GMT, ScientificWare wrote:
>> This is referenced in Java Bug Database as
>> - [JDK-8314731 : Adds support for the alt attribute in the image type input
>> HTML tag.](https://bugs.java.com/bugdatabase/view_bug?bug_id=8314731)
>>
>> This is tracked in JBS as
>> -
On Thu, 28 Sep 2023 20:39:44 GMT, Alisen Chung wrote:
>> Opening closed tests:
>> 12 javax/swing/ToolTipManager/5078214/bug5078214.java
>> 13 javax/swing/plaf/basic/BasicMenuItemUI/4239714/bug4239714.java
>> 14 javax/swing/plaf/basic/BasicMenuUI/4244616/bug4244616.java
>> 15
On Thu, 7 Sep 2023 10:24:05 GMT, Alexey Ivanov wrote:
> Anyway, I have updated `BasicTreeUI`; in addition to fixing the typo there, I
> expanded the wildcard imports.
>
> Do you have any more comments? @mrserb
@mrserb Have I addressed your concerns? Do you have any additio
On Mon, 7 Aug 2023 19:43:38 GMT, Alexey Ivanov wrote:
> A clean-up of documentation for
> [`BoxLayout`](https://docs.oracle.com/en/java/javase/17/docs/api/java.desktop/javax/swing/BoxLayout.html#class-description):
>
> 1. Use the `` element instead of `` to list layout options or
On Wed, 13 Sep 2023 07:46:50 GMT, Alexey Ivanov wrote:
> The image in the [documentation for
> `Document.remove`](https://docs.oracle.com/en/java/javase/17/docs/api/java.desktop/javax/swing/text/Document.html#remove(int,int))
> looks as if the portion between the offsets 6 and 10 i
On Thu, 28 Sep 2023 17:10:39 GMT, Phil Race wrote:
>>> Since this isn't a test for applet I think we should keep it for now
>>
>> What do you mean?
>>
>> All the test does is it verifies the `installComponents` method is
>> accessible in a subclass of `BasicMenuItemUI`. The
>>
On Thu, 28 Sep 2023 16:05:41 GMT, Alexey Ivanov wrote:
>> test/jdk/javax/swing/ToolTipManager/bug5078214.java line 147:
>>
>>> 145: });
>>> 146:
>>> 147: }
>>
>> As I said, there's absolutely no reason to call `GraphicsEn
On Tue, 26 Sep 2023 14:34:20 GMT, Alexey Ivanov wrote:
>> Alisen Chung has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> updated tests based on feedback
>
> test/jdk/javax/swing/ToolTipManager/bug50
On Thu, 28 Sep 2023 15:39:27 GMT, Alisen Chung wrote:
> Since this isn't a test for applet I think we should keep it for now
What do you mean?
All the test does is it verifies the `installComponents` method is accessible
in a subclass of `BasicMenuItemUI`. The
On Fri, 22 Sep 2023 12:39:04 GMT, Alexey Ivanov wrote:
>> test/jdk/javax/swing/ToolTipManager/bug5078214.java line 102:
>>
>>> 100: System.out.print("We need at least one screen with
>>> ");
>>> 101:
On Mon, 25 Sep 2023 22:00:33 GMT, Alisen Chung wrote:
>> test/jdk/javax/swing/BasicMenuUI/bug4244616.java line 67:
>>
>>> 65: action.actionPerformed(ev);
>>> 66: } catch (Exception ignored) {
>>> 67: }
>>
>> Are exceptions thrown here?
>
>
On Mon, 25 Sep 2023 22:32:05 GMT, Alisen Chung wrote:
>> Opening closed tests:
>> 12 javax/swing/ToolTipManager/5078214/bug5078214.java
>> 13 javax/swing/plaf/basic/BasicMenuItemUI/4239714/bug4239714.java
>> 14 javax/swing/plaf/basic/BasicMenuUI/4244616/bug4244616.java
>> 15
On Wed, 13 Sep 2023 09:17:16 GMT, Alexey Ivanov wrote:
> **Problem**
>
> On a standard display with the scale of 100%, the BoxLayout sample has
> blurred edges.
>
> It is the result of how SVG is rendered: the strokes fall between the pixel
> grid, therefore a 1-pixel w
On Thu, 14 Sep 2023 14:53:08 GMT, Alexey Ivanov wrote:
>> test/jdk/java/awt/Window/8294156/manyWindows/TwoWindowColumnsH.java line 96:
>>
>>> 94: private static final int COLUMNS = 3;
>>> 95:
>>> 96: public static void positionTestUI(List wind
On Wed, 13 Sep 2023 14:25:19 GMT, Alexey Ivanov wrote:
>> This enhances the `Builder` pattern added in
>> [JDK-8294535](https://bugs.openjdk.org/browse/JDK-8294535) with a new method
>> `testUI` which allows passing a lambda expression or a method reference to
>> cr
On Wed, 20 Sep 2023 18:12:25 GMT, Phil Race wrote:
>>> Shouldn't we mention here a window added by `testUI` via builder?
>>
>> I don't think it's necessary: the builder uses `addTestWindow` under the
>> hood. It's the builder that requires documentation.
>>
>> In fact, the entire class
On Wed, 20 Sep 2023 18:05:31 GMT, Phil Race wrote:
> One thing about these and the other enhancements I see is that there's an
> (increasing) need for a nice bit of documentation in PassFailJFrame itself
> about all its features.
> Easiest to do this as you are adding them, so a doc comment
On Mon, 25 Sep 2023 15:45:59 GMT, Alexey Ivanov wrote:
>> Alexander Zvegintsev has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> review comments
>
> test/jdk/java/awt/Frame/DefaultSizeTest.java line 42:
&g
On Tue, 26 Sep 2023 14:43:13 GMT, Alexey Ivanov wrote:
>> I think it's fine the way it is now. Just in case the user sees some unusual
>> failure.
>
> Well, yes… I haven't thought about it.
Anyway I submitted [JDK-8317111](https://bugs.openjdk.org/browse/JDK-8317111):
Prov
On Tue, 26 Sep 2023 14:46:39 GMT, Alexey Ivanov wrote:
>> I have already tried this using keyboard shortcuts.
>>
>> Alt+F4 works fine on Window and Linux (many popular DEs close windows by
>> Alt+F4 by default, e.g. Gnome shell, Plasma).
>>
>> For macos we
On Wed, 27 Sep 2023 08:04:02 GMT, Christoph Langer wrote:
>>> Yet keeping tests in the same area closer seems like a good idea to me.
>>> Either line is fine with me.
>>
>> Let's go for the latter one, line 416.
>>
>>> I started an internal discussion in clientlibs to see whether there are
On Wed, 27 Sep 2023 08:10:16 GMT, Christoph Langer wrote:
>> Exclude java/awt/font/Rotate/RotatedTextTest.java until
>> [JDK-8219641](https://bugs.openjdk.org/browse/JDK-8219641) is fixed. The
>> error shows in several linux installations.
>
> Christoph Langer has updated the pull request with
On Mon, 25 Sep 2023 20:30:50 GMT, Alexander Zvegintsev
wrote:
>> Open sourcing several manual applet tests
>>
>>
>> test/jdk/java/awt/Frame/DefaultSizeTest.java
>> test/jdk/java/awt/LightweightComponent/LightweightCliprect.java
>> test/jdk/java/awt/event/KeyEvent/FunctionKeyTest.java
>>
On Mon, 25 Sep 2023 20:19:17 GMT, Alexander Zvegintsev
wrote:
> But this will probably be a task for one of the next test sprints.
Absolutely, it's too many changes. Yet it may make the test easier.
In fact, I thought about iterating the values automatically … and ask the
tester to click the
On Mon, 25 Sep 2023 20:23:27 GMT, Alexander Zvegintsev
wrote:
>> test/jdk/javax/swing/JFrame/DefaultCloseOperation.java line 78:
>>
>>> 76: - Select "Dispose" from the "JDialog Default Close Operation"
>>> ComboBox
>>> 77: - On the TestDialog, select "Close" from the
On Mon, 25 Sep 2023 14:15:52 GMT, Alexey Ivanov wrote:
> Yet keeping tests in the same area closer seems like a good idea to me.
> Either line is fine with me.
Let's go for the latter one, line 416.
> I started an internal discussion in clientlibs to see whether there are any
>
On Mon, 25 Sep 2023 18:31:04 GMT, Alexander Zvegintsev
wrote:
>> Open sourcing few tests:
>>
>> java/awt/Frame/FrameRepackTest.java
>> java/awt/Frame/FrameResizeTest/FrameResizeTest_1.java
>> java/awt/Frame/FrameResizeTest/FrameResizeTest_2.java
>> java/awt/Frame/WindowMoveTest.java
>
>
801 - 900 of 1956 matches
Mail list logo
