Re: android app crashes, performing async tasks before loadUrl

2014-10-01 Thread Andrew Grieve
The ask had come up by someone, but I can't find the email now. My thinking at the time was that if you've customized the native code, then that's a bit going outside of our we promise to not change a thing zone. And if you were savvy enough to modify your Activity.java, then you'd be able to

Re: [Android] Third Party WebView Reference Implementation

2014-10-01 Thread Andrew Grieve
Good idea (I think)! In my mind there's two main things wrong with our current abstractions: 1. WebView plugins should extend a class instead of implement an interface. - Reason: You can't make *any* changes to an interface without breaking the compile for everyone that implements it 2. We need

Re: Business suggestion

2014-10-01 Thread Andrew Grieve
heh, My bad. Just read the first line and was drawn in! You win this time Jim Lawrence! On Tue, Sep 30, 2014 at 11:55 PM, Ally Ogilvie aogil...@wizcorp.jp wrote: I knew it! The client is Steve! Take your advertising demands elsewhere Steve! Sent from my Windows Phone From: Steven Gill Sent:

Re: [Android] Third Party WebView Reference Implementation

2014-10-01 Thread Andrew Grieve
On Wed, Oct 1, 2014 at 11:07 AM, Joe Bowser bows...@gmail.com wrote: On Wed, Oct 1, 2014 at 7:24 AM, Andrew Grieve agri...@chromium.org wrote: Good idea (I think)! In my mind there's two main things wrong with our current abstractions: 1. WebView plugins should extend a class instead

Re: [DISCUSS] shrinkwrap

2014-10-01 Thread Andrew Grieve
Well I'll be darned. :) The root of what I meant I guess, was that if shrinkwrap doesn't work without publishing, then let's just publish and don't sweat version numbers jumping by more than one. If we can get shrinkwrap to work through another means (private npm repo?), than that's even better.

Re: [Android] Third Party WebView Reference Implementation

2014-10-01 Thread Andrew Grieve
On Wed, Oct 1, 2014 at 4:53 PM, Joe Bowser bows...@gmail.com wrote: On Wed, Oct 1, 2014 at 1:18 PM, Andrew Grieve agri...@chromium.org wrote: On Wed, Oct 1, 2014 at 11:07 AM, Joe Bowser bows...@gmail.com wrote: On Wed, Oct 1, 2014 at 7:24 AM, Andrew Grieve agri...@chromium.org wrote

Re: [DISCUSS] shrinkwrap

2014-10-01 Thread Andrew Grieve
numbers. https://issues.apache.org/jira/browse/CB-7550 Until we have a private registry for release testing, I agree with Steve that rc's should not be published to npm, and instead use --usegit. On Oct 1, 2014, at 4:25 PM, Andrew Grieve agri...@chromium.org wrote

[DISCUSS] Deprecate platform update command?

2014-10-01 Thread Andrew Grieve
There's been a couple bugs come in for Android where our update script has failed to bring a project in line with what would be created for a new project: CB-7683, CB-6772 We could put more effort into writing transformations into the update script, but I think it might be more pragmatic to just

Re: android app crashes, performing async tasks before loadUrl

2014-09-30 Thread Andrew Grieve
subject, but there's no JIRA item related. Un-deprecate CordovaActivity.init() - it's needed to tweak prefs in onCreate, by Andrew Grieve https://git-wip-us.apache.org/repos/asf?p=cordova-android.git;a=commit;h=a14c7942557fbaea41438bd3fe104b47997d8371 Thanks. -- Regards, Martin

Re: [DISCUSS] shrinkwrap

2014-09-30 Thread Andrew Grieve
=14983eb014f84e08e7a76f1ab6ffe069b81f6ffa Comments? On Sep 22, 2014, at 10:01 AM, Andrew Grieve agri...@chromium.org wrote: I like having it in. For CCA, we actually did get bit in a release where we didn't have a shrinkwrap and a descendant dependency changed and broke things on us

Re: [Android] Unbundling okhttp

2014-09-30 Thread Andrew Grieve
+1 unbundle. The reason we added it in was that it fixes issues with Android's built-in networking stack. It was added pre-plugin-breakout, and was never broken out into its own plugin. The good news is that I think it'll be quite straight-forward to extract it out. We don't expose OkHttp

Re: [Android] Unbundling okhttp

2014-09-30 Thread Andrew Grieve
On Tue, Sep 30, 2014 at 12:08 PM, Joe Bowser bows...@gmail.com wrote: On Tue, Sep 30, 2014 at 8:52 AM, Andrew Grieve agri...@chromium.org wrote: +1 unbundle. The reason we added it in was that it fixes issues with Android's built-in networking stack. It was added pre-plugin-breakout

Re: [iOS] Xcode 6 requirement

2014-09-26 Thread Andrew Grieve
Sounds good. Apple pushes Xcode updates hard, so it'll just cause pain to not just go along with it. On Fri, Sep 26, 2014 at 6:50 PM, Shazron shaz...@gmail.com wrote: This is not required (yet) by Apple, but presumably it will be, soon. I'd like this to be the requirement for Cordova iOS going

Re: introduction

2014-09-24 Thread Andrew Grieve
Woohoo! Welcome Kirk! On Wed, Sep 24, 2014 at 7:03 PM, Steven Gill stevengil...@gmail.com wrote: Welcome Kirk! On Wed, Sep 24, 2014 at 4:01 PM, Kirk Shoop (MS OPEN TECH) kirk.sh...@microsoft.com wrote: Hi! I work for Microsoft Open Technologies. I have been watching for a while but

Re: plugin with AAR

2014-09-23 Thread Andrew Grieve
Gradle support on master is still somewhat a work-in-progress, but I think it's coming along nicely :) What you want to do hasn't been done before that I know of, but it *might* just work if you add a build-extras.gradle to your plugin and adding the extra Dependencies line in there. More eyes

Re: [CB-7608] Scale ViewPort for inAppBrowser loaded pages [Android]

2014-09-22 Thread Andrew Grieve
I do think we should add in this setting, but probably should clarify the name of it to be more x-platform and clear as to what it does (sets the default viewport meta to device-width). If you can have your oauth server serve a page with a viewport meta tag in it, that would be a more proper way

Re: New project PATH vs. NAME

2014-09-22 Thread Andrew Grieve
I see no issues with hardcoding the main activity name. On Mon, Sep 22, 2014 at 6:06 AM, Vladimir Kotikov (Akvelon) v-vlk...@microsoft.com wrote: So do we agree to proceed with hardcoded name for android main activity here ('CordovaApp' for example), or we still need to implement additional

Re: [DISCUSS] shrinkwrap

2014-09-22 Thread Andrew Grieve
I like having it in. For CCA, we actually did get bit in a release where we didn't have a shrinkwrap and a descendant dependency changed and broke things on us. It's also really nice that when we sign and vote on a release, that doing an npm install on it down the line will recreate the exact

Re: WKWebView for iOS8

2014-09-22 Thread Andrew Grieve
:20 AM, Shazron shaz...@gmail.com wrote: Haven't yet - but from what I read - no. Something about requests being out of process On Monday, June 16, 2014, Andrew Grieve agri...@chromium.org wrote

Re: [VOTE] Plugins Release Sept 17 2014 (attempt #2)

2014-09-22 Thread Andrew Grieve
I can do it now, what's your npm username? On Mon, Sep 22, 2014 at 3:04 PM, Marcel Kinard cmarc...@gmail.com wrote: Steve / Anis / Max / Andrew / Jesse / Ian: could one of you add me as an owner of the core plugins in the plugman repo so I can publish there? Thanks! Begin forwarded message:

Re: [VOTE] Plugins Release Sept 17 2014 (attempt #2)

2014-09-22 Thread Andrew Grieve
done On Mon, Sep 22, 2014 at 3:15 PM, Marcel Kinard cmarc...@gmail.com wrote: Sorry, forgot to include that: cmarcelk Thanks! On Sep 22, 2014, at 3:07 PM, Andrew Grieve agri...@chromium.org wrote: I can do it now, what's your npm username? On Mon, Sep 22, 2014 at 3:04 PM, Marcel

Re: [VOTE] Plugins Release Sept 17 2014 (attempt #2)

2014-09-22 Thread Andrew Grieve
blog post LGTM - but run www/_posts/linkify-bugs.sh before posting please :) On Mon, Sep 22, 2014 at 4:46 PM, Marcel Kinard cmarc...@gmail.com wrote: I've drafted a blog entry. If you have any suggestions, please either commit to it or submit a pull request. I'd like to post the blog entry

Re: [Vote] Tools Release 3.6.3-0.2.12

2014-09-17 Thread Andrew Grieve
, especially when the shrinkwrap command is careful to check that the main module's node_modules matches its package.json dependencies. It seems to be treating the main module and the submodules differently. On Sep 16, 2014, at 9:56 PM, Andrew Grieve agri...@chromium.org wrote: It shouldn't

Re: Downloading the cordova 3.5.1 files when adding android platform using 3.5.0

2014-09-17 Thread Andrew Grieve
You need to install the Android SDK for API level 19. Use the Android SDK Manager to install it. You can open it by Start-Run android On Wed, Sep 17, 2014 at 9:04 AM, Surinaidu Majji pioneer.s...@gmail.com wrote: I am developing an app using cordova 3.5.0 by using android-4.4.2 with an api

Re: [Vote] Tools Release 3.6.3-0.2.12

2014-09-16 Thread Andrew Grieve
You shouldn't be seeing devDependencies show up in cordova. I'd double make sure that if you: cd cordova-cli rm -r node_modules rm npm-shrinkwrap.json npm install npm shrinkwrap that you end up with an npm-shrinkwrap.json that includes the devDependency. On Tue, Sep 16, 2014 at 4:01 PM,

Re: [Vote] Tools Release 3.6.3-0.2.12

2014-09-16 Thread Andrew Grieve
that and it's still showing up, I don't know why that is :S I'm trying to figure out if I'm doing something wrong, or if the shrinkwrap command is misbehaving. On Sep 16, 2014, at 4:07 PM, Andrew Grieve agri...@chromium.org wrote: You shouldn't be seeing devDependencies show up in cordova. I'd

Re: Android: activityResultKeepRunning

2014-09-12 Thread Andrew Grieve
:00 Andrew Grieve agri...@chromium.org: I guess I can see the value of providing a safety option for pause my app in the background, but in general I think it's better practice to not pause forcefully, and instead have apps listen to the pause event, and stop battery-draining activity

Re: [Vote] 3.6.1 Cadence Release 3rd attempt

2014-09-12 Thread Andrew Grieve
Sounds awful, but I have no better ideas. We might in the future consider pinning CLI to download 3.6.x so that it will automatically pick up point releases for times like this. Don't think the logic's i there now for that though. On Fri, Sep 12, 2014 at 12:42 PM, Marcel Kinard

Re: Is there any plan to make InAppBrowser plugin based on CordovaWebView

2014-09-11 Thread Andrew Grieve
Makes sense that we should do this. On Thu, Sep 11, 2014 at 12:43 PM, Gao, Chun chun@intel.com wrote: Hi, I found there are some requirements for InAppBrowser plugin to support HTML5 features

Re: Android: activityResultKeepRunning

2014-09-11 Thread Andrew Grieve
running in the background at all. This now means that the Javascript is running constantly, regardless of whether it's an event. This means that setInterval is still running. This could break people's applications. On Wed, Sep 10, 2014 at 5:29 PM, Andrew Grieve agri...@chromium.org wrote

Re: Android: activityResultKeepRunning

2014-09-10 Thread Andrew Grieve
you put this on its own branch before it lands in 4.0.x? That'd be awesome! On Tue, Sep 9, 2014 at 5:32 PM, Andrew Grieve agri...@chromium.org wrote: For cordova-android 4.0, I'd like to go as far as just deleting the KeepRunning preference. Apps get a pause event when they are backgrounded

Re: Android: activityResultKeepRunning

2014-09-10 Thread Andrew Grieve
it if you were to put this in your own branch for testing. On Wed, Sep 10, 2014 at 12:41 PM, Andrew Grieve agri...@chromium.org wrote: I don't think there'd be much value in that. It'll be a single commit that almost entirely just deletes lines. What do you think about the never

Android: activityResultKeepRunning

2014-09-09 Thread Andrew Grieve
Commit description: If multitasking is turned on (keepRunning=true), then temporarily disable it when starting a new activity that returns a result - such as camera. https://github.com/apache/cordova-android/commit/26adfb634651196106fb5b66f15eecb535a06d82 Bryce / anyone - clues as to *why* we'd

Re: [iOS 8] Status of WKWebView work

2014-09-09 Thread Andrew Grieve
:( Hopefully UIWebView will still get some updates though? E.g. IndexedDb? On Tue, Sep 9, 2014 at 4:18 PM, Tommy Williams to...@devgeeks.org wrote: That's pretty disappointing. Especially with not even a comment from apple. On 10 Sep 2014 05:50, Shazron shaz...@gmail.com wrote: Well, bad

Re: [iOS 8] Status of WKWebView work

2014-09-09 Thread Andrew Grieve
on html5test.com, and yes it supports indexedDB Full results: http://html5te.st/f16d892273bbe5bd On Tue, Sep 9, 2014 at 1:33 PM, Andrew Grieve agri...@chromium.org wrote: :( Hopefully UIWebView will still get some updates though? E.g. IndexedDb? On Tue, Sep 9, 2014 at 4:18 PM, Tommy Williams

Re: Android: activityResultKeepRunning

2014-09-09 Thread Andrew Grieve
PM, Andrew Grieve agri...@chromium.org wrote: Commit description: If multitasking is turned on (keepRunning=true), then temporarily disable it when starting a new activity that returns a result - such as camera. https://github.com/apache/cordova-android/commit

Re: [Vote] 3.6.1 Cadence Release 3rd attempt

2014-09-09 Thread Andrew Grieve
Updated the release post to trim down the Android section. On Mon, Sep 8, 2014 at 9:27 PM, Marcel Kinard cmarc...@gmail.com wrote: And here is the draft blog post: https://github.com/cordova/apache-blog-posts/blob/master/2014-09-08-cordova-361.md Please add highlights for your platform.

Re: Reopen iOS bug CB-3071

2014-09-08 Thread Andrew Grieve
Thanks - I've re-opened the bug. On Fri, Sep 5, 2014 at 12:04 AM, Li, Jonathan jonathan...@sap.com wrote: Hi, Due to bug https://issues.apache.org/jira/browse/CB-3071, the cached response gets invalidated after each time restarting the iOS cordova app, the suggested workaround is to use

Re: Andrew on Vacation

2014-09-08 Thread Andrew Grieve
-studios-llc/id498577828 Books: http://www.packtpub.com/phonegap-2-mobile-application-hotshot/book http://www.packtpub.com/phonegap-social-app-development/book On Aug 21, 2014, at 23:44, Andrew Grieve agri...@google.com wrote: I'll be back Sept 8th :)

Re: Andrew on Vacation

2014-09-08 Thread Andrew Grieve
Just spent 2 days in Vancouver, and Cordova St was en route to the aquarium :) On Mon, Sep 8, 2014 at 4:40 PM, Joe Bowser bows...@gmail.com wrote: Why did you go to Strathcona? On Mon, Sep 8, 2014 at 12:29 PM, Andrew Grieve agri...@chromium.org wrote: Aaaand, I'm back! Here's

Re: Platform cache issue with browser

2014-09-08 Thread Andrew Grieve
The npm-based download of platforms is still quite new, as is the need for platforms to have npm dependencies. Android and iOS have some checked in node_modules. I believe blackberry solved this using bundleDependencies when publishing to npm. On Mon, Sep 8, 2014 at 8:36 PM, Brian LeRoux

Re: What's Stopping us From Independent Platform Releases

2014-09-08 Thread Andrew Grieve
Splitting out the docs would be really tough for some things: - cross-cutting: Platform support, Icons Splashscreens - Generic in nature: Privacy Guide, Security Guide, etc Handling translations is also a pain the more we extract things out. Having CLI create pre-project docs is a neat idea,

Andrew on Vacation

2014-08-21 Thread Andrew Grieve
I'll be back Sept 8th :)

Re: remotely loaded pages

2014-08-20 Thread Andrew Grieve
I think this is a very desired plugin that many end up re-writing, and it's far better than setting the content src directly to a remote URL. E.g. just stumbled across this yesterday: http://docs.appmobi.com/index.php/live-update/ On Wed, Aug 20, 2014 at 7:57 AM, Michal Mocny

Intel XDK == Cordova IDE?

2014-08-20 Thread Andrew Grieve
In case this is news to anyone else, Intel's XDK has been morphing into a Cordova IDE over the past year (from their custom runtime, which they now call legacy build system). Here's their overview: https://software.intel.com/en-us/html5/articles/using-the-cordova-for-android-ios-etc-build-option

Re: What's Stopping us From Independent Platform Releases

2014-08-20 Thread Andrew Grieve
. For example, with PhoneGap Developer Apps you don't need the entire CLI (or any native bits) but just a create command and the phonegap-connect modules for serving the content to the app (app harness flow too). On Thu, Aug 14, 2014 at 12:59 PM, Andrew Grieve agri...@chromium.org wrote: Could you

Re: [Discuss] 3.6.0 Release

2014-08-19 Thread Andrew Grieve
Seems bb10 was just never published to npm. Josh want to take a stab at this? Should be as simple checking out the tag and typing npm publish On Tue, Aug 19, 2014 at 12:15 PM, Josh Soref jso...@blackberry.com wrote: Steven Gill wrote: How does everyone feel about me starting the release

Re: cordova plugin save

2014-08-18 Thread Andrew Grieve
On Mon, Aug 18, 2014 at 5:58 PM, Brian LeRoux b...@brian.io wrote: We don't have to make plugins a package.json thing…we could do that latter. If we do choose to use package.json highly likely we'll need to reserve a key for our 'namespace'. Perhaps cordova. That key could have whatever we

Re: Cordova workflows based on build systems / task runners

2014-08-14 Thread Andrew Grieve
Certainly shows some rough spots of the CLI interface e.g.: - Need to add plugins before platforms - Need to chdir() before calling functions And yes - love that this makes cordova fit in more nicely with other parts of an app's build system. One thing I wondered when reading it is if Cordova

Re: OnDeviceReady with unstable behaviour

2014-08-14 Thread Andrew Grieve
, Andrew Grieve agri...@chromium.org wrote: My guess: Don't wait until onload to register your deviceready listener. On Wed, Aug 13, 2014 at 1:43 PM, Leonardo Martínez leolib2...@gmail.com wrote: Hi, I am new here and I got into this mailing list because of this strange behaviour

Re: Android: add support of min/max/target SDK to config.xml

2014-08-14 Thread Andrew Grieve
Subject: Re: Android: add support of min/max/target SDK to config.xml +1 Another step towards build-artefact-land. On 7 July 2014 at 23:29:25, Andrew Grieve ( agri...@chromium.org) wrote: I'd

Re: What's Stopping us From Independent Platform Releases

2014-08-14 Thread Andrew Grieve
of the platform/cli release, and its assets are voted on as part of that? On Thu, Aug 14, 2014 at 9:43 AM, Andrew Grieve agri...@chromium.org wrote: app-hello-world is quite a weird one now. There's two parts to it: 1) default icons splashscreens - copied into each

Re: WebView Promise and W3C standards

2014-08-13 Thread Andrew Grieve
I'm be in favour of adding the polyfill right to cordova.js. - I'd like to use setImmediate within the Android bridge code, and setImmediate make up about half of the Promise polyfill code. - The polyfill is quite small - Promises are a part of ECMAScript, have been adopted by multiple browsers,

Re: OnDeviceReady with unstable behaviour

2014-08-13 Thread Andrew Grieve
My guess: Don't wait until onload to register your deviceready listener. On Wed, Aug 13, 2014 at 1:43 PM, Leonardo Martínez leolib2...@gmail.com wrote: Hi, I am new here and I got into this mailing list because of this strange behaviour. The thing is that sometimes the ondeviceready event

Re: cordova.js and cordova.platformVersion

2014-08-12 Thread Andrew Grieve
describe``` On Thu, Aug 7, 2014 at 7:07 AM, Andrew Grieve agri...@chromium.org wrote: That all sounds good to me Steve! On Wed, Aug 6, 2014 at 6:48 PM, Steven Gill stevengil...@gmail.com wrote: I have started to look into adding cordova.platformVersion

Re: your blog feed has errors

2014-08-12 Thread Andrew Grieve
Thanks for pointing this out Paul. I've created an issue for it: https://issues.apache.org/jira/browse/CB-7292 On Sat, Aug 9, 2014 at 12:47 PM, Paul Topping pa...@dessci.com wrote: Just FYI. Here's output from http://feedvalidator.org/check.cgi?url=http%3A%2F%2Fcordova.apache.org%2Frss.xml

Chrome-axiom

2014-08-12 Thread Andrew Grieve
New mailinglist that it may be worth joining. Chrome Axiom is the Chrome Developer Tooling platform. We're building the well lit path for web developers to succeed. http://goto/chrome-axiom

Re: Chrome-axiom

2014-08-12 Thread Andrew Grieve
- From: Andrew Grieve [mailto:agri...@google.com] Sent: Tuesday, August 12, 2014 8:49 AM To: dev Subject: Chrome-axiom New mailinglist that it may be worth joining. Chrome Axiom is the Chrome Developer Tooling platform. We're building the well lit path for web developers to succeed

Re: Chrome-axiom

2014-08-12 Thread Andrew Grieve
: Andrew Grieve agri...@google.com Sent: Tuesday, August 12, 2014 10:49 AM To: dev Subject: Chrome-axiom New mailinglist that it may be worth joining. Chrome Axiom is the Chrome Developer Tooling platform. We're building the well lit path for web developers to succeed. http://goto/chrome-axiom

Re: [Discuss] 3.6.0 Release

2014-08-12 Thread Andrew Grieve
A malicious XSS that navigates the page would probably opt to not include cordova.js :P. So - I see there being three kinds of things to have whitelists for: 1) Top-level navigations, 2) intents (on supported platforms) 3) resources / CSP-related requests. According to CSP docs here:

Re: This deserves it's own thread!

2014-08-12 Thread Andrew Grieve
Very cool! Thanks for sharing. The technique used is the same that JsHybugger uses. Differences though: - This is x-platform - This requires a server - This doesn't integrate with devtools - This is free to use. On Tue, Aug 12, 2014 at 1:56 PM, Jesse purplecabb...@gmail.com wrote: Sergey,

Feedback on cordova plugin save friends

2014-08-12 Thread Andrew Grieve
Played around with it and it's pretty clear to me that the ability to record your plugins platforms in config.xml is a big step up. I do have some specific comments about the current design though: - Right now the plugin save saves all plugins to config.xml rather than just explicitly-installed

Re: Feedback on cordova plugin save friends

2014-08-12 Thread Andrew Grieve
friends plugin is nice, but why not just dependency as plugin.xml already uses? config.xml and plugin.xml share lots of tags already, why fork here? -Michal On Tue, Aug 12, 2014 at 4:06 PM, Andrew Grieve agri...@google.com wrote: Played around with it and it's pretty clear to me

Re: Feedback on cordova plugin save friends

2014-08-12 Thread Andrew Grieve
On Tue, Aug 12, 2014 at 6:43 PM, Gorkem Ercan gorkem.er...@gmail.com wrote: Just returning from PTO, great timing :) :) On Tue, Aug 12, 2014 at 04:06:14PM -0400, Andrew Grieve wrote: Played around with it and it's pretty clear to me that the ability to record your plugins platforms

Re: [iOS] Using workspaces

2014-08-11 Thread Andrew Grieve
I don't see the harm in it, but would be interested to know what the wins are, and how much work it would be to accomplish. e.g. Does the CordovaLib project not currently work within an xcworkspace? Is the current integration as simple as deleting CordovaLib as a subproject and adding it as a

Re: [Discuss] Ripple as a platform

2014-08-08 Thread Andrew Grieve
I think this is a nice summary of the trade-offs between the two approaches. I'm much in favour of ripple as a single platform, mainly because of the fact that you're not running it on devices. The merges/ problem can be solved by the user adding a ripple dir to merges, and the per-platform

Re: What's Stopping us From Independent Platform Releases

2014-08-08 Thread Andrew Grieve
and package.json file. My +1 for this. On Fri, Jul 25, 2014 at 05:25:28PM -0400, Andrew Grieve wrote: Wanted to start a thread for everyone to share what concrete changes they'd like to see happen before we start having platforms being released in an unsynchronized fashion

Re: cordova.js and cordova.platformVersion

2014-08-07 Thread Andrew Grieve
That all sounds good to me Steve! On Wed, Aug 6, 2014 at 6:48 PM, Steven Gill stevengil...@gmail.com wrote: I have started to look into adding cordova.platformVersion to cordova.js. Issue [1]. Trying to figure out the best way to implement this. One potential method. 1) Pass in

Re: [VOTE] Plugins Release

2014-08-07 Thread Andrew Grieve
+1 * Confirmed sigs hashes with `coho verify-archive` * Verified sha1s match tags with `coho verify-tags` On Thu, Aug 7, 2014 at 10:38 AM, Ian Clelland iclell...@chromium.org wrote: +1 * Verified all archives * Verified that the tags are correct, and point to the hashes listed *

Re: Plugins Release blog post draft

2014-08-07 Thread Andrew Grieve
LGTM On Thu, Aug 7, 2014 at 7:17 PM, Steven Gill stevengil...@gmail.com wrote: Please review and send PRs for changes. I can also add you to the repo if you want to edit directly on github and not worry about the PR.

Re: plugin-test-framework PRs

2014-08-06 Thread Andrew Grieve
On Fri, Aug 1, 2014 at 1:19 PM, Staci Cooper staci@gmail.com wrote: I've noticed some problems I'd like to bring up. 1) https://github.com/apache/cordova-mobile-spec/blob/master/www/index.html#L44 This line breaks on windows phone when the query property is used. Using a fragment

What's Stopping us From Independent Platform Releases

2014-07-25 Thread Andrew Grieve
Wanted to start a thread for everyone to share what concrete changes they'd like to see happen before we start having platforms being released in an unsynchronized fashion. I'll start :) cordova-js: - cordova.version returns a value computed from the cordova-js git tag. - Let's deprecate

Re: What's Stopping us From Independent Platform Releases

2014-07-25 Thread Andrew Grieve
On Fri, Jul 25, 2014 at 7:03 PM, Brian LeRoux b...@brian.io wrote: cordova-js: - cordova.version returns a value computed from the cordova-js git tag. - Let's deprecate this field - And create cordova.platformVersion - And update our release process to have the version set

Re: Proposal: remove platform versions from platfroms.js

2014-07-24 Thread Andrew Grieve
Hey Chuck, thanks for joining the conversation! Great to have all stakeholders taking part. On Wed, Jul 23, 2014 at 9:40 PM, Chuck Lantz cla...@microsoft.com wrote: Hey folks, I'm on the Visual Studio team. I think my primary concern here comes more from what we expect developers to

Re: Proposal: remove platform versions from platfroms.js

2014-07-24 Thread Andrew Grieve
If you're interested in this I think it'd be best to look at the --experimental plugin save and plugin restore commands and try to iterate from there. On Wed, Jul 23, 2014 at 5:21 PM, Carlos Santana csantan...@gmail.com wrote: +1 on removing the pining Can we at least record what's get's

Re: Proposal: remove platform versions from platfroms.js

2014-07-24 Thread Andrew Grieve
I agree that the feature will make installing platforms less predictable... or at least, just as unpredictable as plugins. It is a good idea to look at exactly what the benefits are though. First - the benefits of removing the idea of a cadence version: - Android 4.0 is on the horizon, maybe iOS

Re: Proposal: remove platform versions from platfroms.js

2014-07-24 Thread Andrew Grieve
a branching problem that we should not pass on to end users. -Chuck -Original Message- From: agri...@google.com [mailto:agri...@google.com] On Behalf Of Andrew Grieve Sent: Thursday, July 24, 2014 6:47 AM To: dev Subject: Re: Proposal: remove platform versions from platfroms.js I

Re: Proposal: remove platform versions from platfroms.js

2014-07-24 Thread Andrew Grieve
, Andrew Grieve agri...@chromium.org wrote: On Thu, Jul 24, 2014 at 10:40 AM, Chuck Lantz cla...@microsoft.com wrote: To me it sounds like we're talking about something bigger than pinning: What does a Cordova version actually mean? When new macro

Re: Proposal: remove platform versions from platfroms.js

2014-07-24 Thread Andrew Grieve
. My thinking there was that we'll be able to announce platform updates without waiting for a tools release to happen. On Thu, Jul 24, 2014 at 12:36 PM, Andrew Grieve agri...@chromium.org wrote: How about discussing dropping the CAD-SEM version of CLI, and just have SEM? Probably

Re: cordova support for multiple activities

2014-07-23 Thread Andrew Grieve
Hi Walton, This is definitely a use-case that is not well supported right now, but is being actively worked on. In fact, in the next version of cordova-android, there will be a new to programmatically configure each WebView separately. However, it will take some time for plugins to move away from

Re: Proposal: remove platform versions from platfroms.js

2014-07-22 Thread Andrew Grieve
I'm definitely in favour of not pinning the version, since I think that will significantly simplify the release process. re webworks - not sure I fully understood the things you wanted to think about there, but I'm sure it would be easy to have downstreams pin versions. You can already override

Re: Proposal: hooks support for plugins

2014-07-21 Thread Andrew Grieve
installed. If its not optional, you should probably not install the plugin at all if you don't want to run the hook. WDYT? -Michal On Fri, Jul 18, 2014 at 4:25 PM, Andrew Grieve agri...@chromium.org wrote: Finally got to having a look. Lots of neat stuff

Re: Proposal: hooks support for plugins

2014-07-18 Thread Andrew Grieve
Finally got to having a look. Lots of neat stuff in there! Some specific feedback: - Not a fan of script, hook might be better - context.commonModules is a great idea, but I don't think exposing requireCordovaModule or elementtree is a good idea. - E.g. what if we want to drop our dependency on

Re: Change background color of Android Cordova app

2014-07-17 Thread Andrew Grieve
I was actually looking at this recently and found that the backgroundColor preference is not being applied to the actual WebView element. Didn't want to change it because I was changing other things at the time, but likely this is just a bug that we should fix. Filed an issue:

Re: Change background color of Android Cordova app

2014-07-17 Thread Andrew Grieve
to have the backgroundColor. Also, I haven't seen this behaviour on any of the tests that we done. Unless we can reproduce the issue, we can't fix it, and shouldn't just throw things over the wall. On Thu, Jul 17, 2014 at 7:46 AM, Andrew Grieve agri...@chromium.org wrote: I was actually

Re: Pluggable webview design thread

2014-07-17 Thread Andrew Grieve
Thanks Ian! Probably a good idea to discuss the heck of this. On Wed, Jul 16, 2014 at 4:23 PM, Ian Clelland iclell...@chromium.org wrote: [Opening this discussion up on the list, as it had previously been the domain of private conversations and limited-audience discussions] On the 4.0.x

Re: Change background color of Android Cordova app

2014-07-17 Thread Andrew Grieve
17, 2014 at 7:56 AM, Andrew Grieve agri...@chromium.org wrote: Try setting opacity:0 on the html tag and you can reproduce white showing instead of your backgroundColor. On Thu, Jul 17, 2014 at 10:54 AM, Joe Bowser bows...@gmail.com wrote: The WebView element isn't supposed to have

Re: Manual iOS steps for a Cordova plugin... really?

2014-07-16 Thread Andrew Grieve
Swizzling is better than using a category because it will allow multiple plugins to hook into the method. On Wed, Jul 16, 2014 at 3:13 AM, julio cesar sanchez jcesarmob...@gmail.com wrote: I've just tested and you can just create an AppDelegate category for the new methods and this should

Re: Browser as Cordova platform

2014-07-16 Thread Andrew Grieve
I know that there's this PR: https://github.com/apache/cordova-js/pull/70 On Wed, Jul 16, 2014 at 6:56 AM, Sergey Grebnov (Akvelon) v-seg...@microsoft.com wrote: Hi, does anyone know where we are here? The official repo [1] is empty. - I'm trying to understand current status to see how our

Re: Working versions of Cordova-Android and Cordova-Crosswalk-Engine

2014-07-16 Thread Andrew Grieve
to compatibility. We should make a spec engine that's just a clone of AndroidWebView specifically for testing and API functionality. I'll add that to the JIRA subtask. On Wed, Jul 16, 2014 at 9:15 AM, Andrew Grieve agri...@chromium.org wrote: Thanks for compiling. Do you think git

Re: 4.0.x, efcedabe, Patch-Bombing and good faith

2014-07-16 Thread Andrew Grieve
Good call here. I should have made JIRAs for a bunch of these. I've now done so retroactively. On Tue, Jul 15, 2014 at 8:56 PM, Joe Bowser bows...@gmail.com wrote: On Jul 15, 2014 5:43 PM, Andrew Grieve agri...@chromium.org wrote: On Tue, Jul 15, 2014 at 7:51 PM, Joe Bowser bows

Re: A question about IceCreamCordovaWebViewClient class

2014-07-15 Thread Andrew Grieve
The super implementation just returns null, so there's not really any value in calling super here I don't think. If you want to customize the class, then your custom class should extend it rather than changing it to extend you class. On Tue, Jul 15, 2014 at 8:42 AM, Joe Bowser bows...@gmail.com

Re: [Android] Where did webView.getPlugin() go on 4.0.x

2014-07-15 Thread Andrew Grieve
I don't think it's been removed: https://github.com/apache/cordova-android/blob/4.0.x/framework/src/org/apache/cordova/CordovaWebView.java#L81 https://github.com/apache/cordova-android/blob/4.0.x/framework/src/org/apache/cordova/AndroidWebView.java#L732 On Tue, Jul 15, 2014 at 1:33 PM, Joe

Re: [Android] Where did webView.getPlugin() go on 4.0.x

2014-07-15 Thread Andrew Grieve
something. On Tue, Jul 15, 2014 at 10:48 AM, Andrew Grieve agri...@chromium.org wrote: I don't think it's been removed: https://github.com/apache/cordova-android/blob/4.0.x/framework/src/org/apache/cordova/CordovaWebView.java#L81 https://github.com/apache/cordova-android/blob/4.0.x

Re: 4.0.x, efcedabe, Patch-Bombing and good faith

2014-07-15 Thread Andrew Grieve
Let's discuss tonight, but it is actually pretty easy to revert things without --force. git revert can do it, or git checkout HASH . git commit --all -a Also - what's broken? Just did a test compile with 4.0.x https://github.com/clelland/cordova-crosswalk-engine#plugin_with_arm_binary and it

Re: [Android] Where did webView.getPlugin() go on 4.0.x

2014-07-15 Thread Andrew Grieve
. If there was a good tool to check all 30+ commits that happened, that'd help too, but this is extremely frustrating, since I want to demo something. On Tue, Jul 15, 2014 at 10:48 AM, Andrew Grieve agri...@chromium.org wrote: I don't think it's been removed

Re: 4.0.x, efcedabe, Patch-Bombing and good faith

2014-07-15 Thread Andrew Grieve
July 3, 2014 and I did not see any discussion of it in dev@ prior to that. Shaz On Tue, Jul 15, 2014 at 12:42 PM, Andrew Grieve agri...@chromium.org wrote: Let's discuss tonight, but it is actually pretty easy to revert things without --force. git revert can do it, or git checkout HASH

Re: 4.0.x, efcedabe, Patch-Bombing and good faith

2014-07-15 Thread Andrew Grieve
is not pro-community. I may have missed it (apologies if I did) but the series of patches started July 3, 2014 and I did not see any discussion of it in dev@ prior to that. Shaz On Tue, Jul 15, 2014 at 12:42 PM, Andrew Grieve agri...@chromium.org wrote: Let's discuss tonight

Re: Playing sound on Android does not respect system settings

2014-07-11 Thread Andrew Grieve
Makes sense to me! :) On Fri, Jul 11, 2014 at 11:35 AM, Andrey Kurdumov kant2...@googlemail.com wrote: Hi guys, I have latest version of Media plugin on Android and have following behavior when playing sound. When playing sound it does not respect settings which user set on their phone.

Re: Pointing docs to edge

2014-07-11 Thread Andrew Grieve
Yeah, plugin docs are already gone from docs.cordova.io. This change is strictly for guides platform docs. The main motivation here is that it doesn't make sense to have versioned docs if platform versions diverge anyways. It actually already makes little sense for the tools guides, since they

<    1   2   3   4   5   6   7   8   9   10   >